[jira] [Commented] (FLINK-7350) only execute japicmp in one build profile

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116558#comment-16116558
 ] 

ASF GitHub Bot commented on FLINK-7350:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/4461


> only execute japicmp in one build profile
> -
>
> Key: FLINK-7350
> URL: https://issues.apache.org/jira/browse/FLINK-7350
> Project: Flink
>  Issue Type: Improvement
>  Components: Travis
>Affects Versions: 1.4.0
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
> Fix For: 1.4.0
>
>
> Similarly to FLINK-7349 we improve build times (and stability!) by only 
> executing the japicmp plugin in the build profile that builds the all of 
> flink.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7350) only execute japicmp in one build profile

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116396#comment-16116396
 ] 

ASF GitHub Bot commented on FLINK-7350:
---

Github user zentol commented on the issue:

https://github.com/apache/flink/pull/4461
  
merging.


> only execute japicmp in one build profile
> -
>
> Key: FLINK-7350
> URL: https://issues.apache.org/jira/browse/FLINK-7350
> Project: Flink
>  Issue Type: Improvement
>  Components: Travis
>Affects Versions: 1.4.0
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
> Fix For: 1.4.0
>
>
> Similarly to FLINK-7349 we improve build times (and stability!) by only 
> executing the japicmp plugin in the build profile that builds the all of 
> flink.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7350) only execute japicmp in one build profile

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111619#comment-16111619
 ] 

ASF GitHub Bot commented on FLINK-7350:
---

Github user zentol commented on the issue:

https://github.com/apache/flink/pull/4461
  
@greghogan That's a great idea, implemented it.


> only execute japicmp in one build profile
> -
>
> Key: FLINK-7350
> URL: https://issues.apache.org/jira/browse/FLINK-7350
> Project: Flink
>  Issue Type: Improvement
>  Components: Travis
>Affects Versions: 1.4.0
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
> Fix For: 1.4.0
>
>
> Similarly to FLINK-7349 we improve build times (and stability!) by only 
> executing the japicmp plugin in the build profile that builds the all of 
> flink.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7350) only execute japicmp in one build profile

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111611#comment-16111611
 ] 

ASF GitHub Bot commented on FLINK-7350:
---

Github user zentol commented on a diff in the pull request:

https://github.com/apache/flink/pull/4461#discussion_r130973288
  
--- Diff: tools/travis_mvn_watchdog.sh ---
@@ -145,8 +150,11 @@ esac
 # -nsu option forbids downloading snapshot artifacts. The only snapshot 
artifacts we depend are from
 # Flink, which however should all be built locally. see FLINK-7230
 MVN_LOGGING_OPTIONS="-Dlog.dir=${ARTIFACTS_DIR} 
-Dlog4j.configuration=file://$LOG4J_PROPERTIES 
-Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn"
-MVN_COMPILE="mvn -nsu -Dflink.forkCount=2 -Dflink.forkCountTestPackage=2 
-DskipTests -Dmaven.javadoc.skip=true -B $PROFILE $MVN_LOGGING_OPTIONS 
$MVN_COMPILE_MODULES clean install"
-MVN_TEST="mvn -nsu -Dflink.forkCount=2 -Dflink.forkCountTestPackage=2 
-Dmaven.javadoc.skip=true -B $PROFILE $MVN_LOGGING_OPTIONS $MVN_TEST_MODULES 
verify"
+MVN_COMMON_OPTIONS="-nsu -Dflink.forkCount=2 
-Dflink.forkCountTestPackage=2 -Dmaven.javadoc.skip=true -B 
$MVN_LOGGING_OPTIONS"
+MVN_COMPILE_OPTIONS="$MVN_COMPILE_OPTIONS -DskipTests"
+
+MVN_COMPILE="mvn $MVN_COMMON_OPTIONS $MVN_COMPILE_OPTIONS $PROFILE 
$MVN_COMPILE_MODULES clean install"
+MVN_TEST="mvn -$MVN_COMMON_OPTIONS $PROFILE $MVN_TEST_MODULES verify"
--- End diff --

I've removed it in #4460.


> only execute japicmp in one build profile
> -
>
> Key: FLINK-7350
> URL: https://issues.apache.org/jira/browse/FLINK-7350
> Project: Flink
>  Issue Type: Improvement
>  Components: Travis
>Affects Versions: 1.4.0
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
> Fix For: 1.4.0
>
>
> Similarly to FLINK-7349 we improve build times (and stability!) by only 
> executing the japicmp plugin in the build profile that builds the all of 
> flink.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7350) only execute japicmp in one build profile

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111475#comment-16111475
 ] 

ASF GitHub Bot commented on FLINK-7350:
---

Github user greghogan commented on a diff in the pull request:

https://github.com/apache/flink/pull/4461#discussion_r130957157
  
--- Diff: tools/travis_mvn_watchdog.sh ---
@@ -145,8 +150,11 @@ esac
 # -nsu option forbids downloading snapshot artifacts. The only snapshot 
artifacts we depend are from
 # Flink, which however should all be built locally. see FLINK-7230
 MVN_LOGGING_OPTIONS="-Dlog.dir=${ARTIFACTS_DIR} 
-Dlog4j.configuration=file://$LOG4J_PROPERTIES 
-Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn"
-MVN_COMPILE="mvn -nsu -Dflink.forkCount=2 -Dflink.forkCountTestPackage=2 
-DskipTests -Dmaven.javadoc.skip=true -B $PROFILE $MVN_LOGGING_OPTIONS 
$MVN_COMPILE_MODULES clean install"
-MVN_TEST="mvn -nsu -Dflink.forkCount=2 -Dflink.forkCountTestPackage=2 
-Dmaven.javadoc.skip=true -B $PROFILE $MVN_LOGGING_OPTIONS $MVN_TEST_MODULES 
verify"
+MVN_COMMON_OPTIONS="-nsu -Dflink.forkCount=2 
-Dflink.forkCountTestPackage=2 -Dmaven.javadoc.skip=true -B 
$MVN_LOGGING_OPTIONS"
+MVN_COMPILE_OPTIONS="$MVN_COMPILE_OPTIONS -DskipTests"
+
+MVN_COMPILE="mvn $MVN_COMMON_OPTIONS $MVN_COMPILE_OPTIONS $PROFILE 
$MVN_COMPILE_MODULES clean install"
+MVN_TEST="mvn -$MVN_COMMON_OPTIONS $PROFILE $MVN_TEST_MODULES verify"
--- End diff --

Looks to be a spurious `-` after `mvn`.


> only execute japicmp in one build profile
> -
>
> Key: FLINK-7350
> URL: https://issues.apache.org/jira/browse/FLINK-7350
> Project: Flink
>  Issue Type: Improvement
>  Components: Travis
>Affects Versions: 1.4.0
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
> Fix For: 1.4.0
>
>
> Similarly to FLINK-7349 we improve build times (and stability!) by only 
> executing the japicmp plugin in the build profile that builds the all of 
> flink.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7350) only execute japicmp in one build profile

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111414#comment-16111414
 ] 

ASF GitHub Bot commented on FLINK-7350:
---

Github user zentol commented on the issue:

https://github.com/apache/flink/pull/4461
  
I tried upgrading the plugin, but then more violations were detected 
causing the build to fail. I didn't have the time to properly investigate 
whether it makes sense to upgrade the plugin now or not.

The nice thing is that if we ever decide to upgrade it later on we only 
have to remove the profile that i add, the travis scripts will work as is.


> only execute japicmp in one build profile
> -
>
> Key: FLINK-7350
> URL: https://issues.apache.org/jira/browse/FLINK-7350
> Project: Flink
>  Issue Type: Improvement
>  Components: Travis
>Affects Versions: 1.4.0
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
> Fix For: 1.4.0
>
>
> Similarly to FLINK-7349 we improve build times (and stability!) by only 
> executing the japicmp plugin in the build profile that builds the all of 
> flink.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7350) only execute japicmp in one build profile

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111300#comment-16111300
 ] 

ASF GitHub Bot commented on FLINK-7350:
---

Github user greghogan commented on the issue:

https://github.com/apache/flink/pull/4461
  
Should we upgrade to japicmp 0.10 or delay this change until such time?


> only execute japicmp in one build profile
> -
>
> Key: FLINK-7350
> URL: https://issues.apache.org/jira/browse/FLINK-7350
> Project: Flink
>  Issue Type: Improvement
>  Components: Travis
>Affects Versions: 1.4.0
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
> Fix For: 1.4.0
>
>
> Similarly to FLINK-7349 we improve build times (and stability!) by only 
> executing the japicmp plugin in the build profile that builds the all of 
> flink.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7350) only execute japicmp in one build profile

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110669#comment-16110669
 ] 

ASF GitHub Bot commented on FLINK-7350:
---

GitHub user zentol opened a pull request:

https://github.com/apache/flink/pull/4461

[FLINK-7350] [travis] Only execute japicmp in misc profile

Based on #4460.

## What is the purpose of the change

Improve travis build times and stability by skipping redundant japicmp 
executions.

Note that the japicmp 0.7 does not allow skipping the execution form the 
command-line (only added in 0.10), so I worked around that with a profile that 
is activated by specifying `-Djapicmp.skip=true`, which is how it _would_ work 
in 0.10.

## Brief change log

  - add `japicmp.skip` property to skip execution
  - add `skip-japicmp` profile to skip execution, activated by specifying 
"-Djapicmp.skip=true"
  - add `-Djapicmp.skip=true` to core/libraries/connector/tests profile 
options

## Verifying this change

Remove the `@Public` annotation from any class and run it on travis, should 
only fail 1 profile (i.e. 2 builds)

## Does this pull request potentially affect one of the following parts:

  - Dependencies (does it add or upgrade a dependency): (no)
  - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
  - The serializers: (no)
  - The runtime per-record code paths (performance sensitive): (no)
  - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)

## Documentation

  - Does this pull request introduce a new feature? (no)
  - If yes, how is the feature documented? (not applicable)



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zentol/flink 7350

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/4461.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4461


commit 4730355b9efa4169f4739681999c16000d9eb3bd
Author: zentol 
Date:   2017-08-02T10:05:56Z

[FLINK-7349] [travis] Only execute checkstyle in misc profile

commit 855e4effb5dfae27a56fb703ddd1fc3785814538
Author: zentol 
Date:   2017-08-02T10:06:56Z

[FLINK-7350] [travis] Only execute japicmp in misc profile




> only execute japicmp in one build profile
> -
>
> Key: FLINK-7350
> URL: https://issues.apache.org/jira/browse/FLINK-7350
> Project: Flink
>  Issue Type: Improvement
>  Components: Travis
>Affects Versions: 1.4.0
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
> Fix For: 1.4.0
>
>
> Similarly to FLINK-7349 we improve build times (and stability!) by only 
> executing the japicmp plugin in the build profile that builds the all of 
> flink.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)