[jira] [Commented] (FLINK-8494) Migrate CC#DEFAULT_PARALLELISM_KEY

2018-01-30 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-8494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345172#comment-16345172
 ] 

ASF GitHub Bot commented on FLINK-8494:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/5377


> Migrate CC#DEFAULT_PARALLELISM_KEY
> --
>
> Key: FLINK-8494
> URL: https://issues.apache.org/jira/browse/FLINK-8494
> Project: Flink
>  Issue Type: Sub-task
>  Components: Configuration
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>Priority: Blocker
> Fix For: 1.5.0
>
>
> {{ConfigConstants#DEFAULT_PARALLELISM_KEY}} was only partialy migrated to a 
> ConfigOption in FLINK-4770.
> A ConfigOption was createde but the usages weren't replaced. The option is 
> also called {{DEFAULT_PARALLELISM_KEY}} when it should be called 
> {{DEFAULT_PARALLELISM}} to be consistent with all other config options.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-8494) Migrate CC#DEFAULT_PARALLELISM_KEY

2018-01-29 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-8494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343309#comment-16343309
 ] 

ASF GitHub Bot commented on FLINK-8494:
---

Github user zentol commented on the issue:

https://github.com/apache/flink/pull/5377
  
merging.


> Migrate CC#DEFAULT_PARALLELISM_KEY
> --
>
> Key: FLINK-8494
> URL: https://issues.apache.org/jira/browse/FLINK-8494
> Project: Flink
>  Issue Type: Sub-task
>  Components: Configuration
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>Priority: Blocker
> Fix For: 1.5.0
>
>
> {{ConfigConstants#DEFAULT_PARALLELISM_KEY}} was only partialy migrated to a 
> ConfigOption in FLINK-4770.
> A ConfigOption was createde but the usages weren't replaced. The option is 
> also called {{DEFAULT_PARALLELISM_KEY}} when it should be called 
> {{DEFAULT_PARALLELISM}} to be consistent with all other config options.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-8494) Migrate CC#DEFAULT_PARALLELISM_KEY

2018-01-29 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-8494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343262#comment-16343262
 ] 

ASF GitHub Bot commented on FLINK-8494:
---

Github user StephanEwen commented on the issue:

https://github.com/apache/flink/pull/5377
  
+1


> Migrate CC#DEFAULT_PARALLELISM_KEY
> --
>
> Key: FLINK-8494
> URL: https://issues.apache.org/jira/browse/FLINK-8494
> Project: Flink
>  Issue Type: Sub-task
>  Components: Configuration
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>Priority: Blocker
> Fix For: 1.5.0
>
>
> {{ConfigConstants#DEFAULT_PARALLELISM_KEY}} was only partialy migrated to a 
> ConfigOption in FLINK-4770.
> A ConfigOption was createde but the usages weren't replaced. The option is 
> also called {{DEFAULT_PARALLELISM_KEY}} when it should be called 
> {{DEFAULT_PARALLELISM}} to be consistent with all other config options.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-8494) Migrate CC#DEFAULT_PARALLELISM_KEY

2018-01-29 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-8494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343193#comment-16343193
 ] 

ASF GitHub Bot commented on FLINK-8494:
---

GitHub user zentol opened a pull request:

https://github.com/apache/flink/pull/5377

[FLINK-8494][config] Migrate CC#DEFAULT_PARALLELISM_KEY

## What is the purpose of the change

This PR migrates `ConfigOptions#DEFAULT_PARALLELLISM_KEY` to a 
`ConfigOption`.

## Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

## Does this pull request potentially affect one of the following parts:

  - Dependencies (does it add or upgrade a dependency): (no)
  - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes)
  - The serializers: (no)
  - The runtime per-record code paths (performance sensitive): (no)
  - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  - The S3 file system connector: (no)

## Documentation

  - Does this pull request introduce a new feature? (no)
  - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zentol/flink 8494

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/5377.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #5377


commit 65885519a691d06b338215a241d5dff0c76df469
Author: zentol 
Date:   2018-01-23T14:07:09Z

[FLINK-8494][config] Migrate CC#DEFAULT_PARALLELISM_KEY




> Migrate CC#DEFAULT_PARALLELISM_KEY
> --
>
> Key: FLINK-8494
> URL: https://issues.apache.org/jira/browse/FLINK-8494
> Project: Flink
>  Issue Type: Sub-task
>  Components: Configuration
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>Priority: Blocker
> Fix For: 1.5.0
>
>
> {{ConfigConstants#DEFAULT_PARALLELISM_KEY}} was only partialy migrated to a 
> ConfigOption in FLINK-4770.
> A ConfigOption was createde but the usages weren't replaced. The option is 
> also called {{DEFAULT_PARALLELISM_KEY}} when it should be called 
> {{DEFAULT_PARALLELISM}} to be consistent with all other config options.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-8494) Migrate CC#DEFAULT_PARALLELISM_KEY

2018-01-24 Thread Stephan Ewen (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-8494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337178#comment-16337178
 ] 

Stephan Ewen commented on FLINK-8494:
-

Hmmm, might just be an error while migrating (given that the new option is 
unused).

Feel free to revert to the old value.

> Migrate CC#DEFAULT_PARALLELISM_KEY
> --
>
> Key: FLINK-8494
> URL: https://issues.apache.org/jira/browse/FLINK-8494
> Project: Flink
>  Issue Type: Sub-task
>  Components: Configuration
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>Priority: Blocker
> Fix For: 1.5.0
>
>
> {{ConfigConstants#DEFAULT_PARALLELISM_KEY}} was only partialy migrated to a 
> ConfigOption in FLINK-4770.
> A ConfigOption was createde but the usages weren't replaced. The option is 
> also called {{DEFAULT_PARALLELISM_KEY}} when it should be called 
> {{DEFAULT_PARALLELISM}} to be consistent with all other config options.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-8494) Migrate CC#DEFAULT_PARALLELISM_KEY

2018-01-23 Thread Chesnay Schepler (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-8494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335817#comment-16335817
 ] 

Chesnay Schepler commented on FLINK-8494:
-

well this is a bit trickier than expected since the default for the new option 
(-1) is different to the old default (1). [~StephanEwen] is this intended?

> Migrate CC#DEFAULT_PARALLELISM_KEY
> --
>
> Key: FLINK-8494
> URL: https://issues.apache.org/jira/browse/FLINK-8494
> Project: Flink
>  Issue Type: Sub-task
>  Components: Configuration
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>Priority: Blocker
> Fix For: 1.5.0
>
>
> {{ConfigConstants#DEFAULT_PARALLELISM_KEY}} was only partialy migrated to a 
> ConfigOption in FLINK-4770.
> A ConfigOption was createde but the usages weren't replaced. The option is 
> also called {{DEFAULT_PARALLELISM_KEY}} when it should be called 
> {{DEFAULT_PARALLELISM}} to be consistent with all other config options.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)