[jira] [Commented] (FLINK-9234) Commons Logging is missing from shaded Flink Table library
[
https://issues.apache.org/jira/browse/FLINK-9234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16488694#comment-16488694
]
Chesnay Schepler commented on FLINK-9234:
-
My guess is that this wasn't caught on travis since we're using maven 3.2.5
there. If you compile all of Flink with maven 3.3+ the logging dependency in
flink-table is still visible to modules that depend on flink-table, which may
or may not affect testing.
> Commons Logging is missing from shaded Flink Table library
> --
>
> Key: FLINK-9234
> URL: https://issues.apache.org/jira/browse/FLINK-9234
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
>Affects Versions: 1.4.2
> Environment: jdk1.8.0_172
> flink 1.4.2
> Mac High Sierra
>Reporter: Eron Wright
>Assignee: Timo Walther
>Priority: Blocker
> Fix For: 1.5.0, 1.4.3
>
> Attachments: repro.scala
>
>
> The flink-table shaded library seems to be missing some classes from
> {{org.apache.commons.logging}} that are required by
> {{org.apache.commons.configuration}}. Ran into the problem while using the
> external catalog support, on Flink 1.4.2.
> See attached a repro, which produces:
> {code}
> Exception in thread "main" java.lang.NoClassDefFoundError:
> org/apache/flink/table/shaded/org/apache/commons/logging/Log
> at
> org.apache.flink.table.catalog.ExternalTableSourceUtil$.parseScanPackagesFromConfigFile(ExternalTableSourceUtil.scala:153)
> at
> org.apache.flink.table.catalog.ExternalTableSourceUtil$.(ExternalTableSourceUtil.scala:55)
> at
> org.apache.flink.table.catalog.ExternalTableSourceUtil$.(ExternalTableSourceUtil.scala)
> at
> org.apache.flink.table.catalog.ExternalCatalogSchema.getTable(ExternalCatalogSchema.scala:78)
> at
> org.apache.calcite.jdbc.SimpleCalciteSchema.getImplicitTable(SimpleCalciteSchema.java:82)
> at
> org.apache.calcite.jdbc.CalciteSchema.getTable(CalciteSchema.java:256)
> at
> org.apache.calcite.jdbc.CalciteSchema$SchemaPlusImpl.getTable(CalciteSchema.java:561)
> at
> org.apache.flink.table.api.TableEnvironment.scanInternal(TableEnvironment.scala:497)
> at
> org.apache.flink.table.api.TableEnvironment.scan(TableEnvironment.scala:485)
> at Repro$.main(repro.scala:17)
> at Repro.main(repro.scala)
> {code}
> Dependencies:
> {code}
> compile 'org.slf4j:slf4j-api:1.7.25'
> compile 'org.slf4j:slf4j-log4j12:1.7.25'
> runtime 'log4j:log4j:1.2.17'
> compile 'org.apache.flink:flink-scala_2.11:1.4.2'
> compile 'org.apache.flink:flink-streaming-scala_2.11:1.4.2'
> compile 'org.apache.flink:flink-clients_2.11:1.4.2'
> compile 'org.apache.flink:flink-table_2.11:1.4.2'
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9234) Commons Logging is missing from shaded Flink Table library
[
https://issues.apache.org/jira/browse/FLINK-9234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16488654#comment-16488654
]
Timo Walther commented on FLINK-9234:
-
I'm thinking about reverting this change. It pulls in different logging classes
for all dependencies that use {{flink-table}}. This problem will be fixed in
1.6 anyway by FLINK-8511 which I might merge today. Users of the external
catalogs can still add the dependency themselves. What do you think [~fhueske]?
> Commons Logging is missing from shaded Flink Table library
> --
>
> Key: FLINK-9234
> URL: https://issues.apache.org/jira/browse/FLINK-9234
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
>Affects Versions: 1.4.2
> Environment: jdk1.8.0_172
> flink 1.4.2
> Mac High Sierra
>Reporter: Eron Wright
>Assignee: Timo Walther
>Priority: Blocker
> Fix For: 1.5.0, 1.4.3
>
> Attachments: repro.scala
>
>
> The flink-table shaded library seems to be missing some classes from
> {{org.apache.commons.logging}} that are required by
> {{org.apache.commons.configuration}}. Ran into the problem while using the
> external catalog support, on Flink 1.4.2.
> See attached a repro, which produces:
> {code}
> Exception in thread "main" java.lang.NoClassDefFoundError:
> org/apache/flink/table/shaded/org/apache/commons/logging/Log
> at
> org.apache.flink.table.catalog.ExternalTableSourceUtil$.parseScanPackagesFromConfigFile(ExternalTableSourceUtil.scala:153)
> at
> org.apache.flink.table.catalog.ExternalTableSourceUtil$.(ExternalTableSourceUtil.scala:55)
> at
> org.apache.flink.table.catalog.ExternalTableSourceUtil$.(ExternalTableSourceUtil.scala)
> at
> org.apache.flink.table.catalog.ExternalCatalogSchema.getTable(ExternalCatalogSchema.scala:78)
> at
> org.apache.calcite.jdbc.SimpleCalciteSchema.getImplicitTable(SimpleCalciteSchema.java:82)
> at
> org.apache.calcite.jdbc.CalciteSchema.getTable(CalciteSchema.java:256)
> at
> org.apache.calcite.jdbc.CalciteSchema$SchemaPlusImpl.getTable(CalciteSchema.java:561)
> at
> org.apache.flink.table.api.TableEnvironment.scanInternal(TableEnvironment.scala:497)
> at
> org.apache.flink.table.api.TableEnvironment.scan(TableEnvironment.scala:485)
> at Repro$.main(repro.scala:17)
> at Repro.main(repro.scala)
> {code}
> Dependencies:
> {code}
> compile 'org.slf4j:slf4j-api:1.7.25'
> compile 'org.slf4j:slf4j-log4j12:1.7.25'
> runtime 'log4j:log4j:1.2.17'
> compile 'org.apache.flink:flink-scala_2.11:1.4.2'
> compile 'org.apache.flink:flink-streaming-scala_2.11:1.4.2'
> compile 'org.apache.flink:flink-clients_2.11:1.4.2'
> compile 'org.apache.flink:flink-table_2.11:1.4.2'
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9234) Commons Logging is missing from shaded Flink Table library
[
https://issues.apache.org/jira/browse/FLINK-9234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16488617#comment-16488617
]
Timo Walther commented on FLINK-9234:
-
It seems that this change has impacts on other modules. The
{{HBaseConnectorITCase}} fails on my machine. The question is why did Travis
not catch that [~Zentol]?
{code}
Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 1.209 sec <<<
FAILURE! - in org.apache.flink.addons.hbase.HBaseConnectorITCase
org.apache.flink.addons.hbase.HBaseConnectorITCase Time elapsed: 1.208 sec
<<< ERROR!
java.lang.ClassCastException:
org.apache.commons.logging.impl.SLF4JLocationAwareLog cannot be cast to
org.apache.commons.logging.impl.Log4JLogger
org.apache.flink.addons.hbase.HBaseConnectorITCase Time elapsed: 1.209 sec
<<< ERROR!
java.lang.NullPointerException
{code}
> Commons Logging is missing from shaded Flink Table library
> --
>
> Key: FLINK-9234
> URL: https://issues.apache.org/jira/browse/FLINK-9234
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
>Affects Versions: 1.4.2
> Environment: jdk1.8.0_172
> flink 1.4.2
> Mac High Sierra
>Reporter: Eron Wright
>Assignee: Timo Walther
>Priority: Blocker
> Fix For: 1.5.0, 1.4.3
>
> Attachments: repro.scala
>
>
> The flink-table shaded library seems to be missing some classes from
> {{org.apache.commons.logging}} that are required by
> {{org.apache.commons.configuration}}. Ran into the problem while using the
> external catalog support, on Flink 1.4.2.
> See attached a repro, which produces:
> {code}
> Exception in thread "main" java.lang.NoClassDefFoundError:
> org/apache/flink/table/shaded/org/apache/commons/logging/Log
> at
> org.apache.flink.table.catalog.ExternalTableSourceUtil$.parseScanPackagesFromConfigFile(ExternalTableSourceUtil.scala:153)
> at
> org.apache.flink.table.catalog.ExternalTableSourceUtil$.(ExternalTableSourceUtil.scala:55)
> at
> org.apache.flink.table.catalog.ExternalTableSourceUtil$.(ExternalTableSourceUtil.scala)
> at
> org.apache.flink.table.catalog.ExternalCatalogSchema.getTable(ExternalCatalogSchema.scala:78)
> at
> org.apache.calcite.jdbc.SimpleCalciteSchema.getImplicitTable(SimpleCalciteSchema.java:82)
> at
> org.apache.calcite.jdbc.CalciteSchema.getTable(CalciteSchema.java:256)
> at
> org.apache.calcite.jdbc.CalciteSchema$SchemaPlusImpl.getTable(CalciteSchema.java:561)
> at
> org.apache.flink.table.api.TableEnvironment.scanInternal(TableEnvironment.scala:497)
> at
> org.apache.flink.table.api.TableEnvironment.scan(TableEnvironment.scala:485)
> at Repro$.main(repro.scala:17)
> at Repro.main(repro.scala)
> {code}
> Dependencies:
> {code}
> compile 'org.slf4j:slf4j-api:1.7.25'
> compile 'org.slf4j:slf4j-log4j12:1.7.25'
> runtime 'log4j:log4j:1.2.17'
> compile 'org.apache.flink:flink-scala_2.11:1.4.2'
> compile 'org.apache.flink:flink-streaming-scala_2.11:1.4.2'
> compile 'org.apache.flink:flink-clients_2.11:1.4.2'
> compile 'org.apache.flink:flink-table_2.11:1.4.2'
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9234) Commons Logging is missing from shaded Flink Table library
[
https://issues.apache.org/jira/browse/FLINK-9234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16473668#comment-16473668
]
ASF GitHub Bot commented on FLINK-9234:
---
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5897
> Commons Logging is missing from shaded Flink Table library
> --
>
> Key: FLINK-9234
> URL: https://issues.apache.org/jira/browse/FLINK-9234
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
>Affects Versions: 1.4.2
> Environment: jdk1.8.0_172
> flink 1.4.2
> Mac High Sierra
>Reporter: Eron Wright
>Assignee: Timo Walther
>Priority: Blocker
> Attachments: repro.scala
>
>
> The flink-table shaded library seems to be missing some classes from
> {{org.apache.commons.logging}} that are required by
> {{org.apache.commons.configuration}}. Ran into the problem while using the
> external catalog support, on Flink 1.4.2.
> See attached a repro, which produces:
> {code}
> Exception in thread "main" java.lang.NoClassDefFoundError:
> org/apache/flink/table/shaded/org/apache/commons/logging/Log
> at
> org.apache.flink.table.catalog.ExternalTableSourceUtil$.parseScanPackagesFromConfigFile(ExternalTableSourceUtil.scala:153)
> at
> org.apache.flink.table.catalog.ExternalTableSourceUtil$.(ExternalTableSourceUtil.scala:55)
> at
> org.apache.flink.table.catalog.ExternalTableSourceUtil$.(ExternalTableSourceUtil.scala)
> at
> org.apache.flink.table.catalog.ExternalCatalogSchema.getTable(ExternalCatalogSchema.scala:78)
> at
> org.apache.calcite.jdbc.SimpleCalciteSchema.getImplicitTable(SimpleCalciteSchema.java:82)
> at
> org.apache.calcite.jdbc.CalciteSchema.getTable(CalciteSchema.java:256)
> at
> org.apache.calcite.jdbc.CalciteSchema$SchemaPlusImpl.getTable(CalciteSchema.java:561)
> at
> org.apache.flink.table.api.TableEnvironment.scanInternal(TableEnvironment.scala:497)
> at
> org.apache.flink.table.api.TableEnvironment.scan(TableEnvironment.scala:485)
> at Repro$.main(repro.scala:17)
> at Repro.main(repro.scala)
> {code}
> Dependencies:
> {code}
> compile 'org.slf4j:slf4j-api:1.7.25'
> compile 'org.slf4j:slf4j-log4j12:1.7.25'
> runtime 'log4j:log4j:1.2.17'
> compile 'org.apache.flink:flink-scala_2.11:1.4.2'
> compile 'org.apache.flink:flink-streaming-scala_2.11:1.4.2'
> compile 'org.apache.flink:flink-clients_2.11:1.4.2'
> compile 'org.apache.flink:flink-table_2.11:1.4.2'
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9234) Commons Logging is missing from shaded Flink Table library
[
https://issues.apache.org/jira/browse/FLINK-9234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16473479#comment-16473479
]
ASF GitHub Bot commented on FLINK-9234:
---
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/5897
Agreed, let's add it to master as well...
> Commons Logging is missing from shaded Flink Table library
> --
>
> Key: FLINK-9234
> URL: https://issues.apache.org/jira/browse/FLINK-9234
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
>Affects Versions: 1.4.2
> Environment: jdk1.8.0_172
> flink 1.4.2
> Mac High Sierra
>Reporter: Eron Wright
>Assignee: Timo Walther
>Priority: Blocker
> Attachments: repro.scala
>
>
> The flink-table shaded library seems to be missing some classes from
> {{org.apache.commons.logging}} that are required by
> {{org.apache.commons.configuration}}. Ran into the problem while using the
> external catalog support, on Flink 1.4.2.
> See attached a repro, which produces:
> {code}
> Exception in thread "main" java.lang.NoClassDefFoundError:
> org/apache/flink/table/shaded/org/apache/commons/logging/Log
> at
> org.apache.flink.table.catalog.ExternalTableSourceUtil$.parseScanPackagesFromConfigFile(ExternalTableSourceUtil.scala:153)
> at
> org.apache.flink.table.catalog.ExternalTableSourceUtil$.(ExternalTableSourceUtil.scala:55)
> at
> org.apache.flink.table.catalog.ExternalTableSourceUtil$.(ExternalTableSourceUtil.scala)
> at
> org.apache.flink.table.catalog.ExternalCatalogSchema.getTable(ExternalCatalogSchema.scala:78)
> at
> org.apache.calcite.jdbc.SimpleCalciteSchema.getImplicitTable(SimpleCalciteSchema.java:82)
> at
> org.apache.calcite.jdbc.CalciteSchema.getTable(CalciteSchema.java:256)
> at
> org.apache.calcite.jdbc.CalciteSchema$SchemaPlusImpl.getTable(CalciteSchema.java:561)
> at
> org.apache.flink.table.api.TableEnvironment.scanInternal(TableEnvironment.scala:497)
> at
> org.apache.flink.table.api.TableEnvironment.scan(TableEnvironment.scala:485)
> at Repro$.main(repro.scala:17)
> at Repro.main(repro.scala)
> {code}
> Dependencies:
> {code}
> compile 'org.slf4j:slf4j-api:1.7.25'
> compile 'org.slf4j:slf4j-log4j12:1.7.25'
> runtime 'log4j:log4j:1.2.17'
> compile 'org.apache.flink:flink-scala_2.11:1.4.2'
> compile 'org.apache.flink:flink-streaming-scala_2.11:1.4.2'
> compile 'org.apache.flink:flink-clients_2.11:1.4.2'
> compile 'org.apache.flink:flink-table_2.11:1.4.2'
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9234) Commons Logging is missing from shaded Flink Table library
[
https://issues.apache.org/jira/browse/FLINK-9234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16473450#comment-16473450
]
ASF GitHub Bot commented on FLINK-9234:
---
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/5897
Thanks, @StephanEwen.
I will later merge this for `release-1.4` and `release-1.5`. Should we
merge it for `master` as well and create a JIRA to drop the deprecated code?
That would ensure we have the fix in 1.6 as well in case we don't drop the code
for whatever reason.
> Commons Logging is missing from shaded Flink Table library
> --
>
> Key: FLINK-9234
> URL: https://issues.apache.org/jira/browse/FLINK-9234
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
>Affects Versions: 1.4.2
> Environment: jdk1.8.0_172
> flink 1.4.2
> Mac High Sierra
>Reporter: Eron Wright
>Assignee: Timo Walther
>Priority: Blocker
> Attachments: repro.scala
>
>
> The flink-table shaded library seems to be missing some classes from
> {{org.apache.commons.logging}} that are required by
> {{org.apache.commons.configuration}}. Ran into the problem while using the
> external catalog support, on Flink 1.4.2.
> See attached a repro, which produces:
> {code}
> Exception in thread "main" java.lang.NoClassDefFoundError:
> org/apache/flink/table/shaded/org/apache/commons/logging/Log
> at
> org.apache.flink.table.catalog.ExternalTableSourceUtil$.parseScanPackagesFromConfigFile(ExternalTableSourceUtil.scala:153)
> at
> org.apache.flink.table.catalog.ExternalTableSourceUtil$.(ExternalTableSourceUtil.scala:55)
> at
> org.apache.flink.table.catalog.ExternalTableSourceUtil$.(ExternalTableSourceUtil.scala)
> at
> org.apache.flink.table.catalog.ExternalCatalogSchema.getTable(ExternalCatalogSchema.scala:78)
> at
> org.apache.calcite.jdbc.SimpleCalciteSchema.getImplicitTable(SimpleCalciteSchema.java:82)
> at
> org.apache.calcite.jdbc.CalciteSchema.getTable(CalciteSchema.java:256)
> at
> org.apache.calcite.jdbc.CalciteSchema$SchemaPlusImpl.getTable(CalciteSchema.java:561)
> at
> org.apache.flink.table.api.TableEnvironment.scanInternal(TableEnvironment.scala:497)
> at
> org.apache.flink.table.api.TableEnvironment.scan(TableEnvironment.scala:485)
> at Repro$.main(repro.scala:17)
> at Repro.main(repro.scala)
> {code}
> Dependencies:
> {code}
> compile 'org.slf4j:slf4j-api:1.7.25'
> compile 'org.slf4j:slf4j-log4j12:1.7.25'
> runtime 'log4j:log4j:1.2.17'
> compile 'org.apache.flink:flink-scala_2.11:1.4.2'
> compile 'org.apache.flink:flink-streaming-scala_2.11:1.4.2'
> compile 'org.apache.flink:flink-clients_2.11:1.4.2'
> compile 'org.apache.flink:flink-table_2.11:1.4.2'
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9234) Commons Logging is missing from shaded Flink Table library
[
https://issues.apache.org/jira/browse/FLINK-9234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16473441#comment-16473441
]
ASF GitHub Bot commented on FLINK-9234:
---
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/5897
Forwarding some comment from @fhueske from JIRA:
> I tried to reproduce this issue for 1.5 but it seems to work.
>
> Flink 1.5 should be out soon (release candidate 2 was published two days
ago). We can merge a fix for 1.4, but would need to wait for 1.4.3 to be
released before it is publicly available (unless you build from the latest 1.4
branch).
>
> `commons-configuration` is used for the external catalog support that was
recently reworked for the unified table source generation. The code that needs
the dependency was deprecated. I think we can drop the code and dependency for
the 1.6 release.
That means we should merge this into `release-1.4` and `release-1.5`. In
`master`, we could merge this, but should probably simply drop the
pre-unified-source code.
> Commons Logging is missing from shaded Flink Table library
> --
>
> Key: FLINK-9234
> URL: https://issues.apache.org/jira/browse/FLINK-9234
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
>Affects Versions: 1.4.2
> Environment: jdk1.8.0_172
> flink 1.4.2
> Mac High Sierra
>Reporter: Eron Wright
>Assignee: Timo Walther
>Priority: Blocker
> Attachments: repro.scala
>
>
> The flink-table shaded library seems to be missing some classes from
> {{org.apache.commons.logging}} that are required by
> {{org.apache.commons.configuration}}. Ran into the problem while using the
> external catalog support, on Flink 1.4.2.
> See attached a repro, which produces:
> {code}
> Exception in thread "main" java.lang.NoClassDefFoundError:
> org/apache/flink/table/shaded/org/apache/commons/logging/Log
> at
> org.apache.flink.table.catalog.ExternalTableSourceUtil$.parseScanPackagesFromConfigFile(ExternalTableSourceUtil.scala:153)
> at
> org.apache.flink.table.catalog.ExternalTableSourceUtil$.(ExternalTableSourceUtil.scala:55)
> at
> org.apache.flink.table.catalog.ExternalTableSourceUtil$.(ExternalTableSourceUtil.scala)
> at
> org.apache.flink.table.catalog.ExternalCatalogSchema.getTable(ExternalCatalogSchema.scala:78)
> at
> org.apache.calcite.jdbc.SimpleCalciteSchema.getImplicitTable(SimpleCalciteSchema.java:82)
> at
> org.apache.calcite.jdbc.CalciteSchema.getTable(CalciteSchema.java:256)
> at
> org.apache.calcite.jdbc.CalciteSchema$SchemaPlusImpl.getTable(CalciteSchema.java:561)
> at
> org.apache.flink.table.api.TableEnvironment.scanInternal(TableEnvironment.scala:497)
> at
> org.apache.flink.table.api.TableEnvironment.scan(TableEnvironment.scala:485)
> at Repro$.main(repro.scala:17)
> at Repro.main(repro.scala)
> {code}
> Dependencies:
> {code}
> compile 'org.slf4j:slf4j-api:1.7.25'
> compile 'org.slf4j:slf4j-log4j12:1.7.25'
> runtime 'log4j:log4j:1.2.17'
> compile 'org.apache.flink:flink-scala_2.11:1.4.2'
> compile 'org.apache.flink:flink-streaming-scala_2.11:1.4.2'
> compile 'org.apache.flink:flink-clients_2.11:1.4.2'
> compile 'org.apache.flink:flink-table_2.11:1.4.2'
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9234) Commons Logging is missing from shaded Flink Table library
[
https://issues.apache.org/jira/browse/FLINK-9234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16473442#comment-16473442
]
ASF GitHub Bot commented on FLINK-9234:
---
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/5897
From my side, +1 to merge this to `release-1.4` and `release-1.5`.
> Commons Logging is missing from shaded Flink Table library
> --
>
> Key: FLINK-9234
> URL: https://issues.apache.org/jira/browse/FLINK-9234
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
>Affects Versions: 1.4.2
> Environment: jdk1.8.0_172
> flink 1.4.2
> Mac High Sierra
>Reporter: Eron Wright
>Assignee: Timo Walther
>Priority: Blocker
> Attachments: repro.scala
>
>
> The flink-table shaded library seems to be missing some classes from
> {{org.apache.commons.logging}} that are required by
> {{org.apache.commons.configuration}}. Ran into the problem while using the
> external catalog support, on Flink 1.4.2.
> See attached a repro, which produces:
> {code}
> Exception in thread "main" java.lang.NoClassDefFoundError:
> org/apache/flink/table/shaded/org/apache/commons/logging/Log
> at
> org.apache.flink.table.catalog.ExternalTableSourceUtil$.parseScanPackagesFromConfigFile(ExternalTableSourceUtil.scala:153)
> at
> org.apache.flink.table.catalog.ExternalTableSourceUtil$.(ExternalTableSourceUtil.scala:55)
> at
> org.apache.flink.table.catalog.ExternalTableSourceUtil$.(ExternalTableSourceUtil.scala)
> at
> org.apache.flink.table.catalog.ExternalCatalogSchema.getTable(ExternalCatalogSchema.scala:78)
> at
> org.apache.calcite.jdbc.SimpleCalciteSchema.getImplicitTable(SimpleCalciteSchema.java:82)
> at
> org.apache.calcite.jdbc.CalciteSchema.getTable(CalciteSchema.java:256)
> at
> org.apache.calcite.jdbc.CalciteSchema$SchemaPlusImpl.getTable(CalciteSchema.java:561)
> at
> org.apache.flink.table.api.TableEnvironment.scanInternal(TableEnvironment.scala:497)
> at
> org.apache.flink.table.api.TableEnvironment.scan(TableEnvironment.scala:485)
> at Repro$.main(repro.scala:17)
> at Repro.main(repro.scala)
> {code}
> Dependencies:
> {code}
> compile 'org.slf4j:slf4j-api:1.7.25'
> compile 'org.slf4j:slf4j-log4j12:1.7.25'
> runtime 'log4j:log4j:1.2.17'
> compile 'org.apache.flink:flink-scala_2.11:1.4.2'
> compile 'org.apache.flink:flink-streaming-scala_2.11:1.4.2'
> compile 'org.apache.flink:flink-clients_2.11:1.4.2'
> compile 'org.apache.flink:flink-table_2.11:1.4.2'
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9234) Commons Logging is missing from shaded Flink Table library
[
https://issues.apache.org/jira/browse/FLINK-9234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16473440#comment-16473440
]
Stephan Ewen commented on FLINK-9234:
-
[~fhueske] Sounds good, thanks for the heads up.
> Commons Logging is missing from shaded Flink Table library
> --
>
> Key: FLINK-9234
> URL: https://issues.apache.org/jira/browse/FLINK-9234
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
>Affects Versions: 1.4.2
> Environment: jdk1.8.0_172
> flink 1.4.2
> Mac High Sierra
>Reporter: Eron Wright
>Assignee: Timo Walther
>Priority: Blocker
> Attachments: repro.scala
>
>
> The flink-table shaded library seems to be missing some classes from
> {{org.apache.commons.logging}} that are required by
> {{org.apache.commons.configuration}}. Ran into the problem while using the
> external catalog support, on Flink 1.4.2.
> See attached a repro, which produces:
> {code}
> Exception in thread "main" java.lang.NoClassDefFoundError:
> org/apache/flink/table/shaded/org/apache/commons/logging/Log
> at
> org.apache.flink.table.catalog.ExternalTableSourceUtil$.parseScanPackagesFromConfigFile(ExternalTableSourceUtil.scala:153)
> at
> org.apache.flink.table.catalog.ExternalTableSourceUtil$.(ExternalTableSourceUtil.scala:55)
> at
> org.apache.flink.table.catalog.ExternalTableSourceUtil$.(ExternalTableSourceUtil.scala)
> at
> org.apache.flink.table.catalog.ExternalCatalogSchema.getTable(ExternalCatalogSchema.scala:78)
> at
> org.apache.calcite.jdbc.SimpleCalciteSchema.getImplicitTable(SimpleCalciteSchema.java:82)
> at
> org.apache.calcite.jdbc.CalciteSchema.getTable(CalciteSchema.java:256)
> at
> org.apache.calcite.jdbc.CalciteSchema$SchemaPlusImpl.getTable(CalciteSchema.java:561)
> at
> org.apache.flink.table.api.TableEnvironment.scanInternal(TableEnvironment.scala:497)
> at
> org.apache.flink.table.api.TableEnvironment.scan(TableEnvironment.scala:485)
> at Repro$.main(repro.scala:17)
> at Repro.main(repro.scala)
> {code}
> Dependencies:
> {code}
> compile 'org.slf4j:slf4j-api:1.7.25'
> compile 'org.slf4j:slf4j-log4j12:1.7.25'
> runtime 'log4j:log4j:1.2.17'
> compile 'org.apache.flink:flink-scala_2.11:1.4.2'
> compile 'org.apache.flink:flink-streaming-scala_2.11:1.4.2'
> compile 'org.apache.flink:flink-clients_2.11:1.4.2'
> compile 'org.apache.flink:flink-table_2.11:1.4.2'
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9234) Commons Logging is missing from shaded Flink Table library
[
https://issues.apache.org/jira/browse/FLINK-9234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16473438#comment-16473438
]
Fabian Hueske commented on FLINK-9234:
--
I tried to reproduce this issue for 1.5 but it seems to work.
Flink 1.5 should be out soon (release candidate 2 was published two days ago).
We can merge a fix for 1.4, but would need to wait for 1.4.3 to be released
before it is publicly available (unless you build from the latest 1.4 branch).
[~StephanEwen], {{commons-configuration}} is used for the external catalog
support that was recently reworked for the unified table source generation. The
code that needs the dependency was deprecated. I think we can drop the code and
dependency for the 1.6 release.
> Commons Logging is missing from shaded Flink Table library
> --
>
> Key: FLINK-9234
> URL: https://issues.apache.org/jira/browse/FLINK-9234
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
>Affects Versions: 1.4.2
> Environment: jdk1.8.0_172
> flink 1.4.2
> Mac High Sierra
>Reporter: Eron Wright
>Assignee: Timo Walther
>Priority: Blocker
> Attachments: repro.scala
>
>
> The flink-table shaded library seems to be missing some classes from
> {{org.apache.commons.logging}} that are required by
> {{org.apache.commons.configuration}}. Ran into the problem while using the
> external catalog support, on Flink 1.4.2.
> See attached a repro, which produces:
> {code}
> Exception in thread "main" java.lang.NoClassDefFoundError:
> org/apache/flink/table/shaded/org/apache/commons/logging/Log
> at
> org.apache.flink.table.catalog.ExternalTableSourceUtil$.parseScanPackagesFromConfigFile(ExternalTableSourceUtil.scala:153)
> at
> org.apache.flink.table.catalog.ExternalTableSourceUtil$.(ExternalTableSourceUtil.scala:55)
> at
> org.apache.flink.table.catalog.ExternalTableSourceUtil$.(ExternalTableSourceUtil.scala)
> at
> org.apache.flink.table.catalog.ExternalCatalogSchema.getTable(ExternalCatalogSchema.scala:78)
> at
> org.apache.calcite.jdbc.SimpleCalciteSchema.getImplicitTable(SimpleCalciteSchema.java:82)
> at
> org.apache.calcite.jdbc.CalciteSchema.getTable(CalciteSchema.java:256)
> at
> org.apache.calcite.jdbc.CalciteSchema$SchemaPlusImpl.getTable(CalciteSchema.java:561)
> at
> org.apache.flink.table.api.TableEnvironment.scanInternal(TableEnvironment.scala:497)
> at
> org.apache.flink.table.api.TableEnvironment.scan(TableEnvironment.scala:485)
> at Repro$.main(repro.scala:17)
> at Repro.main(repro.scala)
> {code}
> Dependencies:
> {code}
> compile 'org.slf4j:slf4j-api:1.7.25'
> compile 'org.slf4j:slf4j-log4j12:1.7.25'
> runtime 'log4j:log4j:1.2.17'
> compile 'org.apache.flink:flink-scala_2.11:1.4.2'
> compile 'org.apache.flink:flink-streaming-scala_2.11:1.4.2'
> compile 'org.apache.flink:flink-clients_2.11:1.4.2'
> compile 'org.apache.flink:flink-table_2.11:1.4.2'
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9234) Commons Logging is missing from shaded Flink Table library
[
https://issues.apache.org/jira/browse/FLINK-9234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16473349#comment-16473349
]
ASF GitHub Bot commented on FLINK-9234:
---
Github user tragicjun commented on the issue:
https://github.com/apache/flink/pull/5897
any progress on this?
> Commons Logging is missing from shaded Flink Table library
> --
>
> Key: FLINK-9234
> URL: https://issues.apache.org/jira/browse/FLINK-9234
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
>Affects Versions: 1.4.2
> Environment: jdk1.8.0_172
> flink 1.4.2
> Mac High Sierra
>Reporter: Eron Wright
>Assignee: Timo Walther
>Priority: Blocker
> Attachments: repro.scala
>
>
> The flink-table shaded library seems to be missing some classes from
> {{org.apache.commons.logging}} that are required by
> {{org.apache.commons.configuration}}. Ran into the problem while using the
> external catalog support, on Flink 1.4.2.
> See attached a repro, which produces:
> {code}
> Exception in thread "main" java.lang.NoClassDefFoundError:
> org/apache/flink/table/shaded/org/apache/commons/logging/Log
> at
> org.apache.flink.table.catalog.ExternalTableSourceUtil$.parseScanPackagesFromConfigFile(ExternalTableSourceUtil.scala:153)
> at
> org.apache.flink.table.catalog.ExternalTableSourceUtil$.(ExternalTableSourceUtil.scala:55)
> at
> org.apache.flink.table.catalog.ExternalTableSourceUtil$.(ExternalTableSourceUtil.scala)
> at
> org.apache.flink.table.catalog.ExternalCatalogSchema.getTable(ExternalCatalogSchema.scala:78)
> at
> org.apache.calcite.jdbc.SimpleCalciteSchema.getImplicitTable(SimpleCalciteSchema.java:82)
> at
> org.apache.calcite.jdbc.CalciteSchema.getTable(CalciteSchema.java:256)
> at
> org.apache.calcite.jdbc.CalciteSchema$SchemaPlusImpl.getTable(CalciteSchema.java:561)
> at
> org.apache.flink.table.api.TableEnvironment.scanInternal(TableEnvironment.scala:497)
> at
> org.apache.flink.table.api.TableEnvironment.scan(TableEnvironment.scala:485)
> at Repro$.main(repro.scala:17)
> at Repro.main(repro.scala)
> {code}
> Dependencies:
> {code}
> compile 'org.slf4j:slf4j-api:1.7.25'
> compile 'org.slf4j:slf4j-log4j12:1.7.25'
> runtime 'log4j:log4j:1.2.17'
> compile 'org.apache.flink:flink-scala_2.11:1.4.2'
> compile 'org.apache.flink:flink-streaming-scala_2.11:1.4.2'
> compile 'org.apache.flink:flink-clients_2.11:1.4.2'
> compile 'org.apache.flink:flink-table_2.11:1.4.2'
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9234) Commons Logging is missing from shaded Flink Table library
[
https://issues.apache.org/jira/browse/FLINK-9234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16473341#comment-16473341
]
ASF GitHub Bot commented on FLINK-9234:
---
Github user tragicjun commented on the issue:
https://github.com/apache/flink/pull/5897
encountered the same issue, any progress on this?
> Commons Logging is missing from shaded Flink Table library
> --
>
> Key: FLINK-9234
> URL: https://issues.apache.org/jira/browse/FLINK-9234
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
>Affects Versions: 1.4.2
> Environment: jdk1.8.0_172
> flink 1.4.2
> Mac High Sierra
>Reporter: Eron Wright
>Assignee: Timo Walther
>Priority: Blocker
> Attachments: repro.scala
>
>
> The flink-table shaded library seems to be missing some classes from
> {{org.apache.commons.logging}} that are required by
> {{org.apache.commons.configuration}}. Ran into the problem while using the
> external catalog support, on Flink 1.4.2.
> See attached a repro, which produces:
> {code}
> Exception in thread "main" java.lang.NoClassDefFoundError:
> org/apache/flink/table/shaded/org/apache/commons/logging/Log
> at
> org.apache.flink.table.catalog.ExternalTableSourceUtil$.parseScanPackagesFromConfigFile(ExternalTableSourceUtil.scala:153)
> at
> org.apache.flink.table.catalog.ExternalTableSourceUtil$.(ExternalTableSourceUtil.scala:55)
> at
> org.apache.flink.table.catalog.ExternalTableSourceUtil$.(ExternalTableSourceUtil.scala)
> at
> org.apache.flink.table.catalog.ExternalCatalogSchema.getTable(ExternalCatalogSchema.scala:78)
> at
> org.apache.calcite.jdbc.SimpleCalciteSchema.getImplicitTable(SimpleCalciteSchema.java:82)
> at
> org.apache.calcite.jdbc.CalciteSchema.getTable(CalciteSchema.java:256)
> at
> org.apache.calcite.jdbc.CalciteSchema$SchemaPlusImpl.getTable(CalciteSchema.java:561)
> at
> org.apache.flink.table.api.TableEnvironment.scanInternal(TableEnvironment.scala:497)
> at
> org.apache.flink.table.api.TableEnvironment.scan(TableEnvironment.scala:485)
> at Repro$.main(repro.scala:17)
> at Repro.main(repro.scala)
> {code}
> Dependencies:
> {code}
> compile 'org.slf4j:slf4j-api:1.7.25'
> compile 'org.slf4j:slf4j-log4j12:1.7.25'
> runtime 'log4j:log4j:1.2.17'
> compile 'org.apache.flink:flink-scala_2.11:1.4.2'
> compile 'org.apache.flink:flink-streaming-scala_2.11:1.4.2'
> compile 'org.apache.flink:flink-clients_2.11:1.4.2'
> compile 'org.apache.flink:flink-table_2.11:1.4.2'
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9234) Commons Logging is missing from shaded Flink Table library
[
https://issues.apache.org/jira/browse/FLINK-9234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16471526#comment-16471526
]
ASF GitHub Bot commented on FLINK-9234:
---
Github user nezhazheng commented on the issue:
https://github.com/apache/flink/pull/5897
encountered same issue.
> Commons Logging is missing from shaded Flink Table library
> --
>
> Key: FLINK-9234
> URL: https://issues.apache.org/jira/browse/FLINK-9234
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
>Affects Versions: 1.4.2
> Environment: jdk1.8.0_172
> flink 1.4.2
> Mac High Sierra
>Reporter: Eron Wright
>Assignee: Timo Walther
>Priority: Blocker
> Attachments: repro.scala
>
>
> The flink-table shaded library seems to be missing some classes from
> {{org.apache.commons.logging}} that are required by
> {{org.apache.commons.configuration}}. Ran into the problem while using the
> external catalog support, on Flink 1.4.2.
> See attached a repro, which produces:
> {code}
> Exception in thread "main" java.lang.NoClassDefFoundError:
> org/apache/flink/table/shaded/org/apache/commons/logging/Log
> at
> org.apache.flink.table.catalog.ExternalTableSourceUtil$.parseScanPackagesFromConfigFile(ExternalTableSourceUtil.scala:153)
> at
> org.apache.flink.table.catalog.ExternalTableSourceUtil$.(ExternalTableSourceUtil.scala:55)
> at
> org.apache.flink.table.catalog.ExternalTableSourceUtil$.(ExternalTableSourceUtil.scala)
> at
> org.apache.flink.table.catalog.ExternalCatalogSchema.getTable(ExternalCatalogSchema.scala:78)
> at
> org.apache.calcite.jdbc.SimpleCalciteSchema.getImplicitTable(SimpleCalciteSchema.java:82)
> at
> org.apache.calcite.jdbc.CalciteSchema.getTable(CalciteSchema.java:256)
> at
> org.apache.calcite.jdbc.CalciteSchema$SchemaPlusImpl.getTable(CalciteSchema.java:561)
> at
> org.apache.flink.table.api.TableEnvironment.scanInternal(TableEnvironment.scala:497)
> at
> org.apache.flink.table.api.TableEnvironment.scan(TableEnvironment.scala:485)
> at Repro$.main(repro.scala:17)
> at Repro.main(repro.scala)
> {code}
> Dependencies:
> {code}
> compile 'org.slf4j:slf4j-api:1.7.25'
> compile 'org.slf4j:slf4j-log4j12:1.7.25'
> runtime 'log4j:log4j:1.2.17'
> compile 'org.apache.flink:flink-scala_2.11:1.4.2'
> compile 'org.apache.flink:flink-streaming-scala_2.11:1.4.2'
> compile 'org.apache.flink:flink-clients_2.11:1.4.2'
> compile 'org.apache.flink:flink-table_2.11:1.4.2'
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9234) Commons Logging is missing from shaded Flink Table library
[
https://issues.apache.org/jira/browse/FLINK-9234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16458725#comment-16458725
]
ASF GitHub Bot commented on FLINK-9234:
---
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/5897
Can we actually get rid of `commons-configuration` in the table API?
All the commons packages with their weird long tail of not properly
declared dependencies have become a bit of an anti-pattern to me over time...
> Commons Logging is missing from shaded Flink Table library
> --
>
> Key: FLINK-9234
> URL: https://issues.apache.org/jira/browse/FLINK-9234
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
>Affects Versions: 1.4.2
> Environment: jdk1.8.0_172
> flink 1.4.2
> Mac High Sierra
>Reporter: Eron Wright
>Assignee: Timo Walther
>Priority: Blocker
> Attachments: repro.scala
>
>
> The flink-table shaded library seems to be missing some classes from
> {{org.apache.commons.logging}} that are required by
> {{org.apache.commons.configuration}}. Ran into the problem while using the
> external catalog support, on Flink 1.4.2.
> See attached a repro, which produces:
> {code}
> Exception in thread "main" java.lang.NoClassDefFoundError:
> org/apache/flink/table/shaded/org/apache/commons/logging/Log
> at
> org.apache.flink.table.catalog.ExternalTableSourceUtil$.parseScanPackagesFromConfigFile(ExternalTableSourceUtil.scala:153)
> at
> org.apache.flink.table.catalog.ExternalTableSourceUtil$.(ExternalTableSourceUtil.scala:55)
> at
> org.apache.flink.table.catalog.ExternalTableSourceUtil$.(ExternalTableSourceUtil.scala)
> at
> org.apache.flink.table.catalog.ExternalCatalogSchema.getTable(ExternalCatalogSchema.scala:78)
> at
> org.apache.calcite.jdbc.SimpleCalciteSchema.getImplicitTable(SimpleCalciteSchema.java:82)
> at
> org.apache.calcite.jdbc.CalciteSchema.getTable(CalciteSchema.java:256)
> at
> org.apache.calcite.jdbc.CalciteSchema$SchemaPlusImpl.getTable(CalciteSchema.java:561)
> at
> org.apache.flink.table.api.TableEnvironment.scanInternal(TableEnvironment.scala:497)
> at
> org.apache.flink.table.api.TableEnvironment.scan(TableEnvironment.scala:485)
> at Repro$.main(repro.scala:17)
> at Repro.main(repro.scala)
> {code}
> Dependencies:
> {code}
> compile 'org.slf4j:slf4j-api:1.7.25'
> compile 'org.slf4j:slf4j-log4j12:1.7.25'
> runtime 'log4j:log4j:1.2.17'
> compile 'org.apache.flink:flink-scala_2.11:1.4.2'
> compile 'org.apache.flink:flink-streaming-scala_2.11:1.4.2'
> compile 'org.apache.flink:flink-clients_2.11:1.4.2'
> compile 'org.apache.flink:flink-table_2.11:1.4.2'
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9234) Commons Logging is missing from shaded Flink Table library
[
https://issues.apache.org/jira/browse/FLINK-9234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16449576#comment-16449576
]
ASF GitHub Bot commented on FLINK-9234:
---
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/5897
The Flink code doesn't need the `jcl` dependency but if `commons` libraries
want to log something we should make this possible, right? Good point @zentol.
I will verify the logs again.
> Commons Logging is missing from shaded Flink Table library
> --
>
> Key: FLINK-9234
> URL: https://issues.apache.org/jira/browse/FLINK-9234
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
>Affects Versions: 1.4.2
> Environment: jdk1.8.0_172
> flink 1.4.2
> Mac High Sierra
>Reporter: Eron Wright
>Assignee: Timo Walther
>Priority: Blocker
> Attachments: repro.scala
>
>
> The flink-table shaded library seems to be missing some classes from
> {{org.apache.commons.logging}} that are required by
> {{org.apache.commons.configuration}}. Ran into the problem while using the
> external catalog support, on Flink 1.4.2.
> See attached a repro, which produces:
> {code}
> Exception in thread "main" java.lang.NoClassDefFoundError:
> org/apache/flink/table/shaded/org/apache/commons/logging/Log
> at
> org.apache.flink.table.catalog.ExternalTableSourceUtil$.parseScanPackagesFromConfigFile(ExternalTableSourceUtil.scala:153)
> at
> org.apache.flink.table.catalog.ExternalTableSourceUtil$.(ExternalTableSourceUtil.scala:55)
> at
> org.apache.flink.table.catalog.ExternalTableSourceUtil$.(ExternalTableSourceUtil.scala)
> at
> org.apache.flink.table.catalog.ExternalCatalogSchema.getTable(ExternalCatalogSchema.scala:78)
> at
> org.apache.calcite.jdbc.SimpleCalciteSchema.getImplicitTable(SimpleCalciteSchema.java:82)
> at
> org.apache.calcite.jdbc.CalciteSchema.getTable(CalciteSchema.java:256)
> at
> org.apache.calcite.jdbc.CalciteSchema$SchemaPlusImpl.getTable(CalciteSchema.java:561)
> at
> org.apache.flink.table.api.TableEnvironment.scanInternal(TableEnvironment.scala:497)
> at
> org.apache.flink.table.api.TableEnvironment.scan(TableEnvironment.scala:485)
> at Repro$.main(repro.scala:17)
> at Repro.main(repro.scala)
> {code}
> Dependencies:
> {code}
> compile 'org.slf4j:slf4j-api:1.7.25'
> compile 'org.slf4j:slf4j-log4j12:1.7.25'
> runtime 'log4j:log4j:1.2.17'
> compile 'org.apache.flink:flink-scala_2.11:1.4.2'
> compile 'org.apache.flink:flink-streaming-scala_2.11:1.4.2'
> compile 'org.apache.flink:flink-clients_2.11:1.4.2'
> compile 'org.apache.flink:flink-table_2.11:1.4.2'
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9234) Commons Logging is missing from shaded Flink Table library
[
https://issues.apache.org/jira/browse/FLINK-9234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16447809#comment-16447809
]
ASF GitHub Bot commented on FLINK-9234:
---
GitHub user twalthr opened a pull request:
https://github.com/apache/flink/pull/5897
[FLINK-9234] [table] Fix missing dependencies for external catalogs
## What is the purpose of the change
This PR adds the required dependencies `commons-logging` (via `slf4j`) and
`commons-collections` to `flink-table`. They are required for the deprecated
external catalog discovery.
## Brief change log
Modified `pom.xml`.
## Verifying this change
Manually verified.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): yes
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/twalthr/flink FLINK-9234
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5897.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5897
commit 1c4a6695496f021a6be7bc58090bdc64a97aa87e
Author: Timo Walther
Date: 2018-04-23T09:04:51Z
[FLINK-9234] [table] Fix missing dependencies for external catalogs
> Commons Logging is missing from shaded Flink Table library
> --
>
> Key: FLINK-9234
> URL: https://issues.apache.org/jira/browse/FLINK-9234
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
>Affects Versions: 1.4.2
> Environment: jdk1.8.0_172
> flink 1.4.2
> Mac High Sierra
>Reporter: Eron Wright
>Assignee: Timo Walther
>Priority: Blocker
> Attachments: repro.scala
>
>
> The flink-table shaded library seems to be missing some classes from
> {{org.apache.commons.logging}} that are required by
> {{org.apache.commons.configuration}}. Ran into the problem while using the
> external catalog support, on Flink 1.4.2.
> See attached a repro, which produces:
> {code}
> Exception in thread "main" java.lang.NoClassDefFoundError:
> org/apache/flink/table/shaded/org/apache/commons/logging/Log
> at
> org.apache.flink.table.catalog.ExternalTableSourceUtil$.parseScanPackagesFromConfigFile(ExternalTableSourceUtil.scala:153)
> at
> org.apache.flink.table.catalog.ExternalTableSourceUtil$.(ExternalTableSourceUtil.scala:55)
> at
> org.apache.flink.table.catalog.ExternalTableSourceUtil$.(ExternalTableSourceUtil.scala)
> at
> org.apache.flink.table.catalog.ExternalCatalogSchema.getTable(ExternalCatalogSchema.scala:78)
> at
> org.apache.calcite.jdbc.SimpleCalciteSchema.getImplicitTable(SimpleCalciteSchema.java:82)
> at
> org.apache.calcite.jdbc.CalciteSchema.getTable(CalciteSchema.java:256)
> at
> org.apache.calcite.jdbc.CalciteSchema$SchemaPlusImpl.getTable(CalciteSchema.java:561)
> at
> org.apache.flink.table.api.TableEnvironment.scanInternal(TableEnvironment.scala:497)
> at
> org.apache.flink.table.api.TableEnvironment.scan(TableEnvironment.scala:485)
> at Repro$.main(repro.scala:17)
> at Repro.main(repro.scala)
> {code}
> Dependencies:
> {code}
> compile 'org.slf4j:slf4j-api:1.7.25'
> compile 'org.slf4j:slf4j-log4j12:1.7.25'
> runtime 'log4j:log4j:1.2.17'
> compile 'org.apache.flink:flink-scala_2.11:1.4.2'
> compile 'org.apache.flink:flink-streaming-scala_2.11:1.4.2'
> compile 'org.apache.flink:flink-clients_2.11:1.4.2'
> compile 'org.apache.flink:flink-table_2.11:1.4.2'
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9234) Commons Logging is missing from shaded Flink Table library
[
https://issues.apache.org/jira/browse/FLINK-9234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16447811#comment-16447811
]
ASF GitHub Bot commented on FLINK-9234:
---
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/5897
@zentol @EronWright would be great if you could verify my changes
> Commons Logging is missing from shaded Flink Table library
> --
>
> Key: FLINK-9234
> URL: https://issues.apache.org/jira/browse/FLINK-9234
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
>Affects Versions: 1.4.2
> Environment: jdk1.8.0_172
> flink 1.4.2
> Mac High Sierra
>Reporter: Eron Wright
>Assignee: Timo Walther
>Priority: Blocker
> Attachments: repro.scala
>
>
> The flink-table shaded library seems to be missing some classes from
> {{org.apache.commons.logging}} that are required by
> {{org.apache.commons.configuration}}. Ran into the problem while using the
> external catalog support, on Flink 1.4.2.
> See attached a repro, which produces:
> {code}
> Exception in thread "main" java.lang.NoClassDefFoundError:
> org/apache/flink/table/shaded/org/apache/commons/logging/Log
> at
> org.apache.flink.table.catalog.ExternalTableSourceUtil$.parseScanPackagesFromConfigFile(ExternalTableSourceUtil.scala:153)
> at
> org.apache.flink.table.catalog.ExternalTableSourceUtil$.(ExternalTableSourceUtil.scala:55)
> at
> org.apache.flink.table.catalog.ExternalTableSourceUtil$.(ExternalTableSourceUtil.scala)
> at
> org.apache.flink.table.catalog.ExternalCatalogSchema.getTable(ExternalCatalogSchema.scala:78)
> at
> org.apache.calcite.jdbc.SimpleCalciteSchema.getImplicitTable(SimpleCalciteSchema.java:82)
> at
> org.apache.calcite.jdbc.CalciteSchema.getTable(CalciteSchema.java:256)
> at
> org.apache.calcite.jdbc.CalciteSchema$SchemaPlusImpl.getTable(CalciteSchema.java:561)
> at
> org.apache.flink.table.api.TableEnvironment.scanInternal(TableEnvironment.scala:497)
> at
> org.apache.flink.table.api.TableEnvironment.scan(TableEnvironment.scala:485)
> at Repro$.main(repro.scala:17)
> at Repro.main(repro.scala)
> {code}
> Dependencies:
> {code}
> compile 'org.slf4j:slf4j-api:1.7.25'
> compile 'org.slf4j:slf4j-log4j12:1.7.25'
> runtime 'log4j:log4j:1.2.17'
> compile 'org.apache.flink:flink-scala_2.11:1.4.2'
> compile 'org.apache.flink:flink-streaming-scala_2.11:1.4.2'
> compile 'org.apache.flink:flink-clients_2.11:1.4.2'
> compile 'org.apache.flink:flink-table_2.11:1.4.2'
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
