Re: [PR] [FLINK-33264][table] Support source parallelism setting for DataGen connector [flink]
libenchao closed pull request #24133: [FLINK-33264][table] Support source parallelism setting for DataGen connector URL: https://github.com/apache/flink/pull/24133 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33264][table] Support source parallelism setting for DataGen connector [flink]
XComp commented on PR #24133: URL: https://github.com/apache/flink/pull/24133#issuecomment-1911845153 Ah I see, thanks for the pointer. I approved and merge the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33264][table] Support source parallelism setting for DataGen connector [flink]
X-czh commented on PR #24133: URL: https://github.com/apache/flink/pull/24133#issuecomment-1911838497 @XComp Thanks for the notice. We've already prepared another separate PR: #24200 on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33264][table] Support source parallelism setting for DataGen connector [flink]
XComp commented on PR #24133: URL: https://github.com/apache/flink/pull/24133#issuecomment-1911798162 @X-czh thanks for discovering the compilation error that was merged into `master`. Could you merge the hotfix commit separately from the bigger change of this PR? The hotfix commit doesn't need to wait for CI to pass and would enable `master` to be stable again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33264][table] Support source parallelism setting for DataGen connector [flink]
X-czh commented on code in PR #24133: URL: https://github.com/apache/flink/pull/24133#discussion_r1467174161 ## docs/content/docs/connectors/table/datagen.md: ## @@ -270,6 +270,13 @@ Connector Options Long The total number of rows to emit. By default, the table is unbounded. + + scan.parallelism + optional + (none) + Long Review Comment: Fixed in the new commit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33264][table] Support source parallelism setting for DataGen connector [flink]
X-czh commented on code in PR #24133: URL: https://github.com/apache/flink/pull/24133#discussion_r1467171751 ## docs/content/docs/connectors/table/datagen.md: ## @@ -270,6 +270,13 @@ Connector Options Long The total number of rows to emit. By default, the table is unbounded. + + scan.parallelism + optional + (none) + Long Review Comment: Thanks for catching this. I'll fix that -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33264][table] Support source parallelism setting for DataGen connector [flink]
X-czh commented on code in PR #24133:
URL: https://github.com/apache/flink/pull/24133#discussion_r1467171607
##
flink-table/flink-table-api-java-bridge/src/test/java/org/apache/flink/table/factories/DataGenTableSourceFactoryTest.java:
##
@@ -581,6 +588,27 @@ void testWrongTypes() {
anyCauseMatches("Could not parse value 'Wrong' for key
'fields.f0.start'"));
}
+@Test
+void testWithParallelism() {
Review Comment:
I've already included an IT case in
`DataGeneratorConnectorITCase#testWithParallelism` where the physical execution
plan is checked, would that be enough?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [FLINK-33264][table] Support source parallelism setting for DataGen connector [flink]
libenchao commented on code in PR #24133:
URL: https://github.com/apache/flink/pull/24133#discussion_r1467163104
##
docs/content/docs/connectors/table/datagen.md:
##
@@ -270,6 +270,13 @@ Connector Options
Long
The total number of rows to emit. By default, the table is
unbounded.
+
+ scan.parallelism
+ optional
+ (none)
+ Long
Review Comment:
Actually it's defined as `int` in the code.
##
flink-table/flink-table-api-java-bridge/src/test/java/org/apache/flink/table/factories/DataGenTableSourceFactoryTest.java:
##
@@ -581,6 +588,27 @@ void testWrongTypes() {
anyCauseMatches("Could not parse value 'Wrong' for key
'fields.f0.start'"));
}
+@Test
+void testWithParallelism() {
Review Comment:
In FLINK-33263, we've introduced a way to verify that the transformation,
could you also add a test based on that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [FLINK-33264][table] Support source parallelism setting for DataGen connector [flink]
X-czh commented on PR #24133: URL: https://github.com/apache/flink/pull/24133#issuecomment-1902132296 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33264][table] Support source parallelism setting for DataGen connector [flink]
libenchao commented on PR #24133: URL: https://github.com/apache/flink/pull/24133#issuecomment-1899537774 > @libenchao Could you help review it after #24128 is merged? I assigned it to myself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33264][table] Support source parallelism setting for DataGen connector [flink]
X-czh commented on PR #24133: URL: https://github.com/apache/flink/pull/24133#issuecomment-1899531944 @libenchao Could you help review it after #24128 is merged? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33264][table] Support source parallelism setting for DataGen connector [flink]
flinkbot commented on PR #24133: URL: https://github.com/apache/flink/pull/24133#issuecomment-1898552816 ## CI report: * ce0c1fb08207d66bb5693b1311bb03d7ba1fda3d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
