Re: [PR] [FLINK-34961] Use dedicated CI name for Kubernetes Operator to differentiate it in infra-reports [flink-kubernetes-operator]
caicancai commented on PR #813: URL: https://github.com/apache/flink-kubernetes-operator/pull/813#issuecomment-2053630401 it look good for me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (FLINK-35094) SinkTestSuiteBase.testScaleDown is hanging for 1.20-SNAPSHOT
[
https://issues.apache.org/jira/browse/FLINK-35094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-35094:
---
Labels: pull-request-available test-stability (was: test-stability)
> SinkTestSuiteBase.testScaleDown is hanging for 1.20-SNAPSHOT
>
>
> Key: FLINK-35094
> URL: https://issues.apache.org/jira/browse/FLINK-35094
> Project: Flink
> Issue Type: Bug
> Components: Connectors / ElasticSearch, Tests
>Affects Versions: elasticsearch-3.1.0, 1.20.0
>Reporter: Sergey Nuyanzin
>Priority: Blocker
> Labels: pull-request-available, test-stability
>
> Currently it is reproduced for elastic search connector
> all the ci jobs (for all jdks) against 1.20-SNAPSHOT are hanging on
> {noformat}
> 2024-04-12T05:56:50.6179284Z "main" #1 prio=5 os_prio=0 cpu=18726.96ms
> elapsed=2522.03s tid=0x7f670c025a50 nid=0x3c6d waiting on condition
> [0x7f6712513000]
> 2024-04-12T05:56:50.6180667Zjava.lang.Thread.State: TIMED_WAITING
> (sleeping)
> 2024-04-12T05:56:50.6181497Z at
> java.lang.Thread.sleep(java.base@17.0.10/Native Method)
> 2024-04-12T05:56:50.6182762Z at
> org.apache.flink.runtime.testutils.CommonTestUtils.waitUntilCondition(CommonTestUtils.java:152)
> 2024-04-12T05:56:50.6184456Z at
> org.apache.flink.runtime.testutils.CommonTestUtils.waitUntilCondition(CommonTestUtils.java:145)
> 2024-04-12T05:56:50.6186346Z at
> org.apache.flink.connector.testframe.testsuites.SinkTestSuiteBase.checkResultWithSemantic(SinkTestSuiteBase.java:504)
> 2024-04-12T05:56:50.6188474Z at
> org.apache.flink.connector.testframe.testsuites.SinkTestSuiteBase.restartFromSavepoint(SinkTestSuiteBase.java:327)
> 2024-04-12T05:56:50.6190145Z at
> org.apache.flink.connector.testframe.testsuites.SinkTestSuiteBase.testScaleDown(SinkTestSuiteBase.java:224)
> 2024-04-12T05:56:50.6191247Z at
> jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(java.base@17.0.10/Native
> Method)
> 2024-04-12T05:56:50.6192806Z at
> jdk.internal.reflect.NativeMethodAccessorImpl.invoke(java.base@17.0.10/NativeMethodAccessorImpl.java:77)
> 2024-04-12T05:56:50.6193863Z at
> jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(java.base@17.0.10/DelegatingMethodAccessorImpl.java:43)
> 2024-04-12T05:56:50.6194834Z at
> java.lang.reflect.Method.invoke(java.base@17.0.10/Method.java:568)
> {noformat}
> for 1.17, 1.18, 1.19 there is no such issue and everything is ok
> https://github.com/apache/flink-connector-elasticsearch/actions/runs/8538572134
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] [FLINK-35094] SinkTestSuiteBase.testScaleDown is hanging for 1.20-SNAPSHOT [flink-connector-elasticsearch]
snuyanzin opened a new pull request, #98: URL: https://github.com/apache/flink-connector-elasticsearch/pull/98 The PR adds `org.apache.flink.core.execution.CheckpointingMode` to make E2E test compatible with 1.18, 1.19, 1.20 Flink versions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-30081][runtime] Reset jvm-overhead.min/max for local executor [flink]
liuml07 commented on code in PR #22547:
URL: https://github.com/apache/flink/pull/22547#discussion_r1563862180
##
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutorResourceUtils.java:
##
@@ -285,4 +286,15 @@ private static void setConfigOptionToDefaultIfNotSet(
config.set(option, defaultValue);
}
}
+
+private static void resetConfigOption(
+Configuration config, ConfigOption option, T value) {
+if (config.contains(option)) {
+LOG.info(
+"The configuration option {} has no effect for local
execution, resetting to {}",
+option.key(),
+value);
+}
+config.set(option, value);
+}
Review Comment:
Yes this makes sense. After removing them, I find we can be simply set the
valid default config value, instead of checking first. So
`silentlySetConfigOptionIfNotSet()` and it's callsites are just removed. A bit
simpler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] chore: fix typo [flink-kubernetes-operator]
caicancai commented on PR #812: URL: https://github.com/apache/flink-kubernetes-operator/pull/812#issuecomment-2053629838 @drgnchan I think the commit message is best changed to the form of "[hotfix] XXX" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-34970] Translate architecture documents into Chinese [flink-kubernetes-operator]
caicancai commented on PR #809: URL: https://github.com/apache/flink-kubernetes-operator/pull/809#issuecomment-2053635501 > Thanks @caicancai for the great work! > > Overall is good for me, i left some comments, please take a look in your free time, thanks a lot. > > I wanna mention some common issues here due to we have a lot of pages will be translated in the future. > > 1. Can we keep some Terminology (do not translate them)? such as: operator, deployment, etc > 2. We don't need to translate for every English word. Try to ensure that the translated Chinese is easy to understand and not awkward to read. (尽量保证翻译后的中文通俗易懂，读起来不别扭。) Thanks for the reminder, I will improve it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-34961] Use dedicated CI name for Rabbit MQ connector to differentiate it in infra-reports [flink-connector-rabbitmq]
boring-cyborg[bot] commented on PR #26: URL: https://github.com/apache/flink-connector-rabbitmq/pull/26#issuecomment-2053716419 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-34961] Use dedicated CI name for Rabbit MQ connector to differentiate it in infra-reports [flink-connector-rabbitmq]
snuyanzin merged PR #26: URL: https://github.com/apache/flink-connector-rabbitmq/pull/26 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.commons:commons-compress from 1.21 to 1.26.0 [flink-connector-aws]
dannycranmer commented on PR #131: URL: https://github.com/apache/flink-connector-aws/pull/131#issuecomment-2053726181 We need to update NOTICE file with this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.commons:commons-compress from 1.21 to 1.26.0 [flink-connector-aws]
snuyanzin commented on PR #131: URL: https://github.com/apache/flink-connector-aws/pull/131#issuecomment-2053726937 I would suggest to bump rather to 1.26.1 to avoid issues mentioned at FLINK-35008 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-30081][runtime] Reset unused options like jvm-overhead.min/max for local executor [flink]
liuml07 commented on code in PR #22547:
URL: https://github.com/apache/flink/pull/22547#discussion_r1564418871
##
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutorResourceUtils.java:
##
@@ -285,4 +286,15 @@ private static void setConfigOptionToDefaultIfNotSet(
config.set(option, defaultValue);
}
}
+
+private static void resetConfigOption(
+Configuration config, ConfigOption option, T value) {
+if (config.contains(option)) {
+LOG.info(
+"The configuration option {} has no effect for local
execution, resetting to {}",
+option.key(),
+value);
+}
+config.set(option, value);
+}
Review Comment:
@xintongsong how do I trigger a Jenkins build? I tested manually and the
code snippet in the JIRA passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (FLINK-35098) Incorrect results for queries like "10 >= y" on tables using Filesystem connector and Orc format
[
https://issues.apache.org/jira/browse/FLINK-35098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-35098:
---
Labels: pull-request-available (was: )
> Incorrect results for queries like "10 >= y" on tables using Filesystem
> connector and Orc format
>
>
> Key: FLINK-35098
> URL: https://issues.apache.org/jira/browse/FLINK-35098
> Project: Flink
> Issue Type: Bug
> Components: Connectors / ORC, Formats (JSON, Avro, Parquet, ORC,
> SequenceFile)
>Affects Versions: 1.12.7, 1.13.6, 1.14.6, 1.15.4, 1.16.3, 1.17.2, 1.19.0,
> 1.18.1
>Reporter: Andrey Gaskov
>Priority: Major
> Labels: pull-request-available
>
> When working with ORC files, there is an issue with evaluation of SQL queries
> containing expressions with a literal as the first operand. Specifically, the
> query *10 >= y* does not always return the correct result.
> This test added to OrcFileSystemITCase.java fails on the second check:
>
> {code:java}
> @TestTemplate
> void testOrcFilterPushDownLiteralFirst() throws ExecutionException,
> InterruptedException {
> super.tableEnv()
> .executeSql("insert into orcLimitTable values('a', 10, 10)")
> .await();
> List expected = Collections.singletonList(Row.of(10));
> check("select y from orcLimitTable where y <= 10", expected);
> check("select y from orcLimitTable where 10 >= y", expected);
> }
> Results do not match for query:
> select y from orcLimitTable where 10 >= y
> Results
> == Correct Result - 1 == == Actual Result - 0 ==
> !+I[10] {code}
> The checks are equivalent and should evaluate to the same result. But the
> second query doesn't return the record with y=10.
> The table is defined as:
> {code:java}
> create table orcLimitTable (
> x string,
> y int,
> a int)
> with (
> 'connector' = 'filesystem',
> 'path' = '/tmp/junit4374176500101507155/junit7109291529844202275/',
> 'format'='orc'){code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] [FLINK-35098][orc] Fix incorrect results in thanEquals filters [flink]
jeyhunkarimov opened a new pull request, #24658: URL: https://github.com/apache/flink/pull/24658 ## What is the purpose of the change Fix incorrect results in thanEquals filters ## Brief change log - Fix the reverse function for Orc GREATER_THAN_OR_EQUAL - Fix the reverse function for Orc LESS_THAN_OR_EQUAL ## Verifying this change Via tests in `org.apache.flink.orc.OrcFileSystemITCase::testThanEquals` ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (FLINK-35040) The performance of serializerHeavyString regresses since April 3
[ https://issues.apache.org/jira/browse/FLINK-35040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836843#comment-17836843 ] Robert Metzger commented on FLINK-35040: Do we know what causes the performance degradation with commons-io? Maybe there's a ticket in the commons-io project that helps us understand what is going on? If not, it might make sense to report to commons-io, so that they are aware that they have a performance degradation. > The performance of serializerHeavyString regresses since April 3 > > > Key: FLINK-35040 > URL: https://issues.apache.org/jira/browse/FLINK-35040 > Project: Flink > Issue Type: Bug > Components: Benchmarks >Affects Versions: 1.20.0 >Reporter: Rui Fan >Assignee: Rui Fan >Priority: Blocker > Labels: pull-request-available > Attachments: image-2024-04-08-10-51-07-403.png, > image-2024-04-11-12-53-53-353.png, screenshot-1.png > > > The performance of serializerHeavyString regresses since April 3, and had not > yet recovered on April 8th. > It seems Java 11 regresses, and Java 8 and Java 17 are fine. > http://flink-speed.xyz/timeline/#/?exe=1,6,12=serializerHeavyString=on=on=off=3=200 > !screenshot-1.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] [FLINK-35098][ORC] Fix incorrect results with literal first expressions [flink]
empathy87 opened a new pull request, #24659: URL: https://github.com/apache/flink/pull/24659 ## What is the purpose of the change Fixes an issue with SQL queries containing expressions like **10 >= y** when using Filesystem connector and ORC format. ## Brief change log - In OrcFilters fixed filters push down of GREATER_THAN, GREATER_THAN_OR_EQUAL, LESS_THAN, LESS_THAN_OR_EQUAL functions ## Verifying this change Added tests: - `OrcFileSystemITCase::testOrcFilterPushDownLiteralFirst` verifies a query result. - `OrcFileSystemFilterTest::testApplyPredicateReverse` verifies expression conversions to ORC filter predicates. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - The serializers: no - The runtime per-record code paths (performance sensitive): no - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no - The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? no -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (FLINK-35098) Incorrect results for queries like "10 >= y" on tables using Filesystem connector and Orc format
[
https://issues.apache.org/jira/browse/FLINK-35098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836879#comment-17836879
]
Andrey Gaskov commented on FLINK-35098:
---
[~jeyhunkarimov], thank you! I submitted my PR.
> Incorrect results for queries like "10 >= y" on tables using Filesystem
> connector and Orc format
>
>
> Key: FLINK-35098
> URL: https://issues.apache.org/jira/browse/FLINK-35098
> Project: Flink
> Issue Type: Bug
> Components: Connectors / ORC, Formats (JSON, Avro, Parquet, ORC,
> SequenceFile)
>Affects Versions: 1.12.7, 1.13.6, 1.14.6, 1.15.4, 1.16.3, 1.17.2, 1.19.0,
> 1.18.1
>Reporter: Andrey Gaskov
>Priority: Major
> Labels: pull-request-available
>
> When working with ORC files, there is an issue with evaluation of SQL queries
> containing expressions with a literal as the first operand. Specifically, the
> query *10 >= y* does not always return the correct result.
> This test added to OrcFileSystemITCase.java fails on the second check:
>
> {code:java}
> @TestTemplate
> void testOrcFilterPushDownLiteralFirst() throws ExecutionException,
> InterruptedException {
> super.tableEnv()
> .executeSql("insert into orcLimitTable values('a', 10, 10)")
> .await();
> List expected = Collections.singletonList(Row.of(10));
> check("select y from orcLimitTable where y <= 10", expected);
> check("select y from orcLimitTable where 10 >= y", expected);
> }
> Results do not match for query:
> select y from orcLimitTable where 10 >= y
> Results
> == Correct Result - 1 == == Actual Result - 0 ==
> !+I[10] {code}
> The checks are equivalent and should evaluate to the same result. But the
> second query doesn't return the record with y=10.
> The table is defined as:
> {code:java}
> create table orcLimitTable (
> x string,
> y int,
> a int)
> with (
> 'connector' = 'filesystem',
> 'path' = '/tmp/junit4374176500101507155/junit7109291529844202275/',
> 'format'='orc'){code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [FLINK-35098][ORC] Fix incorrect results with literal first expressions [flink]
flinkbot commented on PR #24659: URL: https://github.com/apache/flink/pull/24659#issuecomment-2053886702 ## CI report: * 8db107dba2702b73249b586ff4d3266e1a8f2bc8 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (FLINK-35098) Incorrect results for queries like "10 >= y" on tables using Filesystem connector and Orc format
Andrey Gaskov created FLINK-35098:
-
Summary: Incorrect results for queries like "10 >= y" on tables
using Filesystem connector and Orc format
Key: FLINK-35098
URL: https://issues.apache.org/jira/browse/FLINK-35098
Project: Flink
Issue Type: Bug
Components: Connectors / ORC, Formats (JSON, Avro, Parquet, ORC,
SequenceFile)
Affects Versions: 1.18.1, 1.19.0, 1.17.2, 1.16.3, 1.15.4, 1.14.6, 1.13.6,
1.12.7
Reporter: Andrey Gaskov
When working with ORC files, there is an issue with evaluation of SQL queries
containing expressions with a literal as the first operand. Specifically, the
query *10 >= y* does not always return the correct result.
This test added to OrcFileSystemITCase.java fails on the second check:
{code:java}
@TestTemplate
void testOrcFilterPushDownLiteralFirst() throws ExecutionException,
InterruptedException {
super.tableEnv()
.executeSql("insert into orcLimitTable values('a', 10, 10)")
.await();
List expected = Collections.singletonList(Row.of(10));
check("select y from orcLimitTable where y <= 10", expected);
check("select y from orcLimitTable where 10 >= y", expected);
}
Results do not match for query:
select y from orcLimitTable where 10 >= y
Results
== Correct Result - 1 == == Actual Result - 0 ==
!+I[10] {code}
The checks are equivalent and should evaluate to the same result. But the
second query doesn't return the record with y=10.
The table is defined as:
{code:java}
create table orcLimitTable (
x string,
y int,
a int)
with (
'connector' = 'filesystem',
'path' = '/tmp/junit4374176500101507155/junit7109291529844202275/',
'format'='orc'){code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [FLINK-35098][orc] Fix incorrect results in thanEquals filters [flink]
flinkbot commented on PR #24658: URL: https://github.com/apache/flink/pull/24658#issuecomment-2053746320 ## CI report: * bad8304a2d5ad3d9fda25596469405bc4ec9a1d4 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (FLINK-35098) Incorrect results for queries like "10 >= y" on tables using Filesystem connector and Orc format
[
https://issues.apache.org/jira/browse/FLINK-35098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836868#comment-17836868
]
Jeyhun Karimov commented on FLINK-35098:
Hi [~empathy87] sorry, I have been working on the issue in the time between you
created the issue and you commented here, so I did not track your comment here.
In any case, submission might have some issues (now closed), so you are welcome
to submit your PR. Thanks
> Incorrect results for queries like "10 >= y" on tables using Filesystem
> connector and Orc format
>
>
> Key: FLINK-35098
> URL: https://issues.apache.org/jira/browse/FLINK-35098
> Project: Flink
> Issue Type: Bug
> Components: Connectors / ORC, Formats (JSON, Avro, Parquet, ORC,
> SequenceFile)
>Affects Versions: 1.12.7, 1.13.6, 1.14.6, 1.15.4, 1.16.3, 1.17.2, 1.19.0,
> 1.18.1
>Reporter: Andrey Gaskov
>Priority: Major
> Labels: pull-request-available
>
> When working with ORC files, there is an issue with evaluation of SQL queries
> containing expressions with a literal as the first operand. Specifically, the
> query *10 >= y* does not always return the correct result.
> This test added to OrcFileSystemITCase.java fails on the second check:
>
> {code:java}
> @TestTemplate
> void testOrcFilterPushDownLiteralFirst() throws ExecutionException,
> InterruptedException {
> super.tableEnv()
> .executeSql("insert into orcLimitTable values('a', 10, 10)")
> .await();
> List expected = Collections.singletonList(Row.of(10));
> check("select y from orcLimitTable where y <= 10", expected);
> check("select y from orcLimitTable where 10 >= y", expected);
> }
> Results do not match for query:
> select y from orcLimitTable where 10 >= y
> Results
> == Correct Result - 1 == == Actual Result - 0 ==
> !+I[10] {code}
> The checks are equivalent and should evaluate to the same result. But the
> second query doesn't return the record with y=10.
> The table is defined as:
> {code:java}
> create table orcLimitTable (
> x string,
> y int,
> a int)
> with (
> 'connector' = 'filesystem',
> 'path' = '/tmp/junit4374176500101507155/junit7109291529844202275/',
> 'format'='orc'){code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (FLINK-35098) Incorrect results for queries like "10 >= y" on tables using Filesystem connector and Orc format
[
https://issues.apache.org/jira/browse/FLINK-35098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836830#comment-17836830
]
Andrey Gaskov commented on FLINK-35098:
---
Please, assign this issue to me. I know where it could be fixed.
> Incorrect results for queries like "10 >= y" on tables using Filesystem
> connector and Orc format
>
>
> Key: FLINK-35098
> URL: https://issues.apache.org/jira/browse/FLINK-35098
> Project: Flink
> Issue Type: Bug
> Components: Connectors / ORC, Formats (JSON, Avro, Parquet, ORC,
> SequenceFile)
>Affects Versions: 1.12.7, 1.13.6, 1.14.6, 1.15.4, 1.16.3, 1.17.2, 1.19.0,
> 1.18.1
>Reporter: Andrey Gaskov
>Priority: Major
>
> When working with ORC files, there is an issue with evaluation of SQL queries
> containing expressions with a literal as the first operand. Specifically, the
> query *10 >= y* does not always return the correct result.
> This test added to OrcFileSystemITCase.java fails on the second check:
>
> {code:java}
> @TestTemplate
> void testOrcFilterPushDownLiteralFirst() throws ExecutionException,
> InterruptedException {
> super.tableEnv()
> .executeSql("insert into orcLimitTable values('a', 10, 10)")
> .await();
> List expected = Collections.singletonList(Row.of(10));
> check("select y from orcLimitTable where y <= 10", expected);
> check("select y from orcLimitTable where 10 >= y", expected);
> }
> Results do not match for query:
> select y from orcLimitTable where 10 >= y
> Results
> == Correct Result - 1 == == Actual Result - 0 ==
> !+I[10] {code}
> The checks are equivalent and should evaluate to the same result. But the
> second query doesn't return the record with y=10.
> The table is defined as:
> {code:java}
> create table orcLimitTable (
> x string,
> y int,
> a int)
> with (
> 'connector' = 'filesystem',
> 'path' = '/tmp/junit4374176500101507155/junit7109291529844202275/',
> 'format'='orc'){code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [FLINK-35098][orc] Fix incorrect results in thanEquals filters [flink]
jeyhunkarimov commented on PR #24658: URL: https://github.com/apache/flink/pull/24658#issuecomment-2053765908 > Thanks for contribution > however it seems the test doesn't reproduce the actual issue: I tried to execute it without fix and it is green > Hi @snuyanzin thanks a lot for your comment. I have started on reproducing this issue and working on it, so I did not track the jira updates. So, I have not seen the comment tbh. I would not judge others for being disrespectful without knowing the context. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-35098][orc] Fix incorrect results in thanEquals filters [flink]
jeyhunkarimov closed pull request #24658: [FLINK-35098][orc] Fix incorrect results in thanEquals filters URL: https://github.com/apache/flink/pull/24658 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-34961] Use dedicated CI name for Kubernetes Operator to differentiate it in infra-reports [flink-kubernetes-operator]
snuyanzin commented on PR #813: URL: https://github.com/apache/flink-kubernetes-operator/pull/813#issuecomment-2053722641 Thanks for taking a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-34961] Use dedicated CI name for Kubernetes Operator to differentiate it in infra-reports [flink-kubernetes-operator]
snuyanzin merged PR #813: URL: https://github.com/apache/flink-kubernetes-operator/pull/813 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-35098][orc] Fix incorrect results in thanEquals filters [flink]
snuyanzin commented on PR #24658: URL: https://github.com/apache/flink/pull/24658#issuecomment-2053762163 Thanks for contribution however it seems the test Doesn't reproduce the actual issue: I tried to execute it without fix and it is green -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
