[jira] [Commented] (GEODE-2900) BucketRegionQueue transitions from primary/secondary/primary can lead to events lingering in queue

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16097020#comment-16097020
 ] 

ASF subversion and git services commented on GEODE-2900:


Commit acdf2e80184edf9c3ba934a6f0fa760a83020953 in geode's branch 
refs/heads/develop from [~upthewaterspout]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=acdf2e8 ]

GEODE-2900: DUnit test of moving primary during AEQ dispatching

Adding a dunit test that moves the primary and moves it again during AEQ
dispatching.

This closes #506


> BucketRegionQueue transitions from primary/secondary/primary can lead to 
> events lingering in queue
> --
>
> Key: GEODE-2900
> URL: https://issues.apache.org/jira/browse/GEODE-2900
> Project: Geode
>  Issue Type: Bug
>  Components: lucene, wan
>Reporter: Jason Huynh
>Assignee: Jason Huynh
> Fix For: 1.2.0
>
>
> In this scenario when peek() is called from BucketRegionQueue, a side effect 
> is that the key is removed from the eventSeqNumQueue and an event is placed 
> into the peekedEvents list.
> If there is failure dispatching the event, we add the peekedEvents list to a 
> new peekedEvents list.  Before doing so, we remove any events that we are not 
> primary for.  Now the event is not in the eventSeqNumQueue or the 
> peekedEvents list
> If we now become primary (before the other node could dispatch this event), 
> and because we do not have that event in the eventSeqNumQueue or the 
> peekedEvents, it gets "stuck."
> This also affects the Lucene implementation.  An stuck event can mean 
> incorrectly indexed data or data inconsistencies



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3213) Refactor Protobuf Serialization Implemenation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16097013#comment-16097013
 ] 

ASF GitHub Bot commented on GEODE-3213:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/646


> Refactor Protobuf Serialization Implemenation
> -
>
> Key: GEODE-3213
> URL: https://issues.apache.org/jira/browse/GEODE-3213
> Project: Geode
>  Issue Type: Improvement
>  Components: client/server, serialization
>Reporter: Udo Kohlmeyer
>
> In the Protobuf serialization implementation, there are some refactorings we 
> want to make:
> * OperationHandlers take OperationRequest and OperationResponse message, not 
> the parent Request/Response Object
> * A generic flow needs to be implemented that all OperationHandlers follow. 
> No bespoke flows for any OperationHandlers... way too much maintenance
> * Use Functional semantics to configure the functionality to extract 
> OperationRequest from Request (per OperationHandler)
> * Use Functional semantics to configure the functionality to populate 
> OperationResponse in the relevant Response
> * Have generic Error Handling framework to populate "known" errors and error 
> codes



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3213) Refactor Protobuf Serialization Implemenation

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16097012#comment-16097012
 ] 

ASF subversion and git services commented on GEODE-3213:


Commit 64eab4559900f2f9e3c30a62e6daa45c422c22ac in geode's branch 
refs/heads/develop from [~gosullivan]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=64eab45 ]

GEODE-3213: Refactor ProtoBuf handler flow. This now closes #646

Signed-off-by: Alexander Murmann 


> Refactor Protobuf Serialization Implemenation
> -
>
> Key: GEODE-3213
> URL: https://issues.apache.org/jira/browse/GEODE-3213
> Project: Geode
>  Issue Type: Improvement
>  Components: client/server, serialization
>Reporter: Udo Kohlmeyer
>
> In the Protobuf serialization implementation, there are some refactorings we 
> want to make:
> * OperationHandlers take OperationRequest and OperationResponse message, not 
> the parent Request/Response Object
> * A generic flow needs to be implemented that all OperationHandlers follow. 
> No bespoke flows for any OperationHandlers... way too much maintenance
> * Use Functional semantics to configure the functionality to extract 
> OperationRequest from Request (per OperationHandler)
> * Use Functional semantics to configure the functionality to populate 
> OperationResponse in the relevant Response
> * Have generic Error Handling framework to populate "known" errors and error 
> codes



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (GEODE-3286) Failing to cleanup connections from ConnectionTable receiver table

[Brian Rowe (JIRA)]

Brian Rowe created GEODE-3286:
-

 Summary: Failing to cleanup connections from ConnectionTable 
receiver table
 Key: GEODE-3286
 URL: https://issues.apache.org/jira/browse/GEODE-3286
 Project: Geode
  Issue Type: Bug
  Components: membership
Reporter: Brian Rowe


This bug tracks gemfire issue 1554 
(https://jira-pivotal.atlassian.net/browse/GEM-1544).


Hello team,

A customer (VMWare) is experiencing several {{OutOfMemoryError}} on production 
servers, and they believe there's a memory leak within GemFire.
Apparently 9.5GB of the heap heap is occupied by 487,828 instances of 
{{sun.security.ssl.SSLSocketImpl}}, and 7.7GB of the heap is occupied by 
487,804 instances of {{sun.security.ssl.AppOutputStream}}, both referenced from 
the {{receivers}} attribute within the {{ConnectionTable}} class. I got this 
information from the Eclipse Memory Analyzer plugin, the images are attached.
Below are some OQLs that I was able to run within the plugin, it is weird that 
the collection of receivers is composed of 486.368 elements...

{code}
SELECT * FROM com.gemstone.gemfire.internal.tcp.ConnectionTable
-> 1
SELECT receivers.size FROM com.gemstone.gemfire.internal.tcp.ConnectionTable 
-> 486.368
SELECT * FROM com.gemstone.gemfire.internal.tcp.Connection
-> 487.758
SELECT * FROM com.gemstone.gemfire.internal.tcp.Connection con WHERE 
con.stopped = true
-> 486.461
SELECT * FROM com.gemstone.gemfire.internal.tcp.Connection con WHERE 
con.stopped = false
-> 1297
{code}

That said, nothing in the statistics (maybe there's something, but I can't find 
it...) seems to point to a spike in the amount of entries within the regions, 
neither in the current amount of connections, nor anything to be able to 
explain the continuous drop of the available heap over time (chart#freeMemory).
The heap dump (approximately 20GB) and the statistics (don't have logs yet, but 
they might not be required by looking at the heap and the statistics) have been 
uploaded to [Google 
Drive|https://drive.google.com/drive/folders/0BxDMZZTfEL4WUFZjbjhLMXptbEk?usp=sharing].
Just for the record, apparently we delivered 8.2.0.6 to them a year and half 
ago as a fix to [GEM-94|https://jira-pivotal.atlassian.net/browse/GEM-94] / 
[GEODE-332|https://issues.apache.org/jira/browse/GEODE-332], they've been 
running fine since then, until now. The last change in the {{ConnectionTable}} 
was done to fix these issues, so if there's actually a bug within the class, it 
will also exist on 8.2.5 (just a reminder to change the affected version field 
if required).
The issue is not reproducible at will but happens in several of their 
environments, yet I haven't been able to reproduce it in my lab environment for 
now.
Please let me know if you need anything else to proceed.
Best regards.




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3271) Refactor WanCommands

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16097000#comment-16097000
 ] 

ASF GitHub Bot commented on GEODE-3271:
---

Github user YehEmily commented on the issue:

https://github.com/apache/geode/pull/647
  
@PurelyApplied Updated! Thanks for the feedback!


> Refactor WanCommands
> 
>
> Key: GEODE-3271
> URL: https://issues.apache.org/jira/browse/GEODE-3271
> Project: Geode
>  Issue Type: Sub-task
>  Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{WanCommands.java}} is a large class that contains multiple commands. Each 
> command should be refactored into a separate class, and the methods shared by 
> the commands should be refactored into a new and appropriately named class of 
> their own.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3168) Fix CLI projects and tests.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16096994#comment-16096994
 ] 

ASF subversion and git services commented on GEODE-3168:


Commit 5ef80c0627f206250ea746fc54e257724b4aba23 in geode-native's branch 
refs/heads/develop from Jacob Barrett
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=5ef80c0 ]

GEODE-3168: Fixes vcvars powershell script.


> Fix CLI projects and tests.
> ---
>
> Key: GEODE-3168
> URL: https://issues.apache.org/jira/browse/GEODE-3168
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>
> CLI projects and tests have path issues that can cause compile issues.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3206) lucene search results in gfsh are listed in reverse relevancy order

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16096986#comment-16096986
 ] 

ASF GitHub Bot commented on GEODE-3206:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/648


> lucene search results in gfsh are listed in reverse relevancy order
> ---
>
> Key: GEODE-3206
> URL: https://issues.apache.org/jira/browse/GEODE-3206
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Diane Hardman
>Assignee: Deepak Dixit
>
> Using the lucene example in the pull request for GEODE-3202, execute one of 
> the lucene searches that returns multiple results. For example:
> search lucene --name=simpleIndex --region=example-region 
> --queryStrings="firstName:pat OR lastName:chive~" --defaultField=lastName
> The results should list employee with name 'Pat' first since it is an exact 
> match and has a higher relevancy score. Instead it lists:
>  key  |  value
>   | score
> - | 
> ---
>  | --
> 10015 | EmployeeData [firstName=Jamie, lastName=Jive, emplNumber=10015, 
> email= jamie.j...@example.com, salary=6, .. | 0.14384104
> 10028 | EmployeeData [firstName=Pat, lastName=Puts, emplNumber=10028, email= 
> pat.p...@example.com, salary=75000, hour.. | 0.2876821
> Note the higher relevancy score is listed second.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3206) lucene search results in gfsh are listed in reverse relevancy order

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16096985#comment-16096985
 ] 

ASF subversion and git services commented on GEODE-3206:


Commit 208f5ae58c160212aecad82efddecb13f0eb86a6 in geode's branch 
refs/heads/develop from zhouxh
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=208f5ae ]

GEODE-3206 : Corrected order of lucene search results based on score.
This closes #648


> lucene search results in gfsh are listed in reverse relevancy order
> ---
>
> Key: GEODE-3206
> URL: https://issues.apache.org/jira/browse/GEODE-3206
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Diane Hardman
>Assignee: Deepak Dixit
>
> Using the lucene example in the pull request for GEODE-3202, execute one of 
> the lucene searches that returns multiple results. For example:
> search lucene --name=simpleIndex --region=example-region 
> --queryStrings="firstName:pat OR lastName:chive~" --defaultField=lastName
> The results should list employee with name 'Pat' first since it is an exact 
> match and has a higher relevancy score. Instead it lists:
>  key  |  value
>   | score
> - | 
> ---
>  | --
> 10015 | EmployeeData [firstName=Jamie, lastName=Jive, emplNumber=10015, 
> email= jamie.j...@example.com, salary=6, .. | 0.14384104
> 10028 | EmployeeData [firstName=Pat, lastName=Puts, emplNumber=10028, email= 
> pat.p...@example.com, salary=75000, hour.. | 0.2876821
> Note the higher relevancy score is listed second.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3213) Refactor Protobuf Serialization Implemenation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16096981#comment-16096981
 ] 

ASF GitHub Bot commented on GEODE-3213:
---

Github user PurelyApplied commented on the issue:

https://github.com/apache/geode/pull/646
  
If you are using IntelliJ as your IDE, please remember to update your style 
file to that located in `geode/etc/intellij-java-modified-google-style.xml` to 
be consistent with Geode's established style guide.  This file was updated June 
13 with commit `a561bd12` to be consistent with documented expectations.  If 
you are using Eclipse, please import both style guidefiles, also located in 
`geode/etc/`.

After having done so, please optimize the imports to the correct order and 
to eliminate the use of the wildcard imports from the 25 offending files this 
pull request touches. 



> Refactor Protobuf Serialization Implemenation
> -
>
> Key: GEODE-3213
> URL: https://issues.apache.org/jira/browse/GEODE-3213
> Project: Geode
>  Issue Type: Improvement
>  Components: client/server, serialization
>Reporter: Udo Kohlmeyer
>
> In the Protobuf serialization implementation, there are some refactorings we 
> want to make:
> * OperationHandlers take OperationRequest and OperationResponse message, not 
> the parent Request/Response Object
> * A generic flow needs to be implemented that all OperationHandlers follow. 
> No bespoke flows for any OperationHandlers... way too much maintenance
> * Use Functional semantics to configure the functionality to extract 
> OperationRequest from Request (per OperationHandler)
> * Use Functional semantics to configure the functionality to populate 
> OperationResponse in the relevant Response
> * Have generic Error Handling framework to populate "known" errors and error 
> codes



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3168) Fix CLI projects and tests.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16096977#comment-16096977
 ] 

ASF subversion and git services commented on GEODE-3168:


Commit 6e7e176b76e40b13c8001e139ed70dd7750f93b3 in geode-native's branch 
refs/heads/develop from Jacob Barrett
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=6e7e176 ]

GEODE-3168: Fixes VC helper bat to use VS 2015.

> Fix CLI projects and tests.
> ---
>
> Key: GEODE-3168
> URL: https://issues.apache.org/jira/browse/GEODE-3168
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>
> CLI projects and tests have path issues that can cause compile issues.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3271) Refactor WanCommands

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16096976#comment-16096976
 ] 

ASF GitHub Bot commented on GEODE-3271:
---

Github user PurelyApplied commented on the issue:

https://github.com/apache/geode/pull/647
  
+1 as it stands.

Unimportant nitpicks, rambling observations, and "it could be even better 
if...":

* `punePort` appears in these tests a lot.  I have no idea what `pune` is 
supposed to mean.  Maybe `dsIdPort` would be better, glancing at the 
implementation of `createFirstLocatorWithDSId`?

* There are five instances in `WANCommandsTestBase` that has a loop like 
this

```
for (GatewaySender s : senders) {
  if (s.getId().equals(senderId)) {
sender = (AbstractGatewaySender) s;
break;
  }
}
```

that my hatred of `break` as function control thinks it would read a lot 
better as 

```
AbstractGatewaySender sender =
(AbstractGatewaySender) senders.stream().filter(s -> 
s.getId().equalsIgnoreCase(senderId)).findFirst().orElse(null);
```
* I'd take the Inspection-suggested change in `WANCommandBaseTest.java:489` 
to turn the string `indexOf(...) != -1` to be `contains(...)`.


> Refactor WanCommands
> 
>
> Key: GEODE-3271
> URL: https://issues.apache.org/jira/browse/GEODE-3271
> Project: Geode
>  Issue Type: Sub-task
>  Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{WanCommands.java}} is a large class that contains multiple commands. Each 
> command should be refactored into a separate class, and the methods shared by 
> the commands should be refactored into a new and appropriately named class of 
> their own.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3281) Native Client Example Docs Use RegisterType instead of RegisterTypeGeneric

[Ernest Burghardt (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16096969#comment-16096969
 ] 

Ernest Burghardt commented on GEODE-3281:
-

Yes, that is sort of a historical typo... chances are the code snippet 
pre-dated the CLI's change to use Generics.

> Native Client Example Docs Use RegisterType instead of RegisterTypeGeneric
> --
>
> Key: GEODE-3281
> URL: https://issues.apache.org/jira/browse/GEODE-3281
> Project: Geode
>  Issue Type: Bug
>  Components: docs, native client
>Reporter: Addison
>
> Change RegisterType to RegisterTypeGeneric in 
> https://github.com/apache/geode-native/blob/develop/docs/geode-native-docs/dotnet-caching-api/custom-class-igfserializable.html.md.erb



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (GEODE-3284) New flow: getAvailableServers

[Brian Baynes (JIRA)]

Brian Baynes created GEODE-3284:
---

 Summary: New flow: getAvailableServers
 Key: GEODE-3284
 URL: https://issues.apache.org/jira/browse/GEODE-3284
 Project: Geode
  Issue Type: Sub-task
  Components: client/server
Reporter: Brian Baynes


As a Geode client user, I'd like to be able to know all available servers in a 
grid in order to support operations targeting any available server.
Create op handler for getAvailableServers message, following proto message 
definition.
Client should be able to complete getAvailableServers, receiving all servers 
available in grid.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (GEODE-3180) CI failure: org.apache.geode.internal.cache.partitioned.PersistentColocatedPartitionedRegionDUnitTest.testFullTreeOfColocatedChildPRsWithMissingRegions fails with org.moc

[Fred Krone (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fred Krone updated GEODE-3180:
--
Labels: storage_3  (was: storage_3 windows_test)

> CI failure: 
> org.apache.geode.internal.cache.partitioned.PersistentColocatedPartitionedRegionDUnitTest.testFullTreeOfColocatedChildPRsWithMissingRegions
>  fails with org.mockito.exceptions.verification.NoInteractionsWanted
> ---
>
> Key: GEODE-3180
> URL: https://issues.apache.org/jira/browse/GEODE-3180
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Lynn Gallinat
>  Labels: storage_3
>
> {noformat}
> org.apache.geode.internal.cache.partitioned.PersistentColocatedPartitionedRegionDUnitTest
>  > testFullTreeOfColocatedChildPRsWithMissingRegions FAILED
> java.lang.AssertionError: An exception occurred during asynchronous 
> invocation.
> at 
> org.apache.geode.test.dunit.AsyncInvocation.checkException(AsyncInvocation.java:148)
> at 
> org.apache.geode.test.dunit.AsyncInvocation.get(AsyncInvocation.java:422)
> at 
> org.apache.geode.internal.cache.partitioned.PersistentColocatedPartitionedRegionDUnitTest.testFullTreeOfColocatedChildPRsWithMissingRegions(PersistentColocatedPartitionedRegionDUnitTest.java:1298)
> Caused by:
> org.mockito.exceptions.verification.NoInteractionsWanted: 
> No interactions wanted here:
> -> at 
> org.apache.geode.internal.cache.partitioned.PersistentColocatedPartitionedRegionDUnitTest$14.call(PersistentColocatedPartitionedRegionDUnitTest.java:1232)
> But found this interaction on mock 'appender':
> -> at 
> org.apache.logging.log4j.core.config.AppenderControl.tryCallAppender(AppenderControl.java:156)
> ***
> For your reference, here is the list of all invocations ([?] - means 
> unverified).
> 1. -> at 
> org.apache.logging.log4j.core.config.AbstractConfiguration.addLoggerAppender(AbstractConfiguration.java:694)
> 2. -> at 
> org.apache.logging.log4j.core.config.AppenderControl.(AppenderControl.java:51)
> 3. -> at 
> org.apache.logging.log4j.core.config.AppenderControl.ensureAppenderStarted(AppenderControl.java:134)
> 4. -> at 
> org.apache.logging.log4j.core.config.AppenderControl.tryCallAppender(AppenderControl.java:156)
> 5. -> at 
> org.apache.logging.log4j.core.config.AppenderControl.ensureAppenderStarted(AppenderControl.java:134)
> 6. [?]-> at 
> org.apache.logging.log4j.core.config.AppenderControl.tryCallAppender(AppenderControl.java:156){noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (GEODE-3185) CI failure (windows): org.apache.geode.internal.cache.BackupJUnitTest, 3 tests failing with java.lang.AssertionError: Null entry

[Fred Krone (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fred Krone updated GEODE-3185:
--
Labels: storage_3 windows_test  (was: )

> CI failure (windows): org.apache.geode.internal.cache.BackupJUnitTest, 3 
> tests failing with java.lang.AssertionError: Null entry
> 
>
> Key: GEODE-3185
> URL: https://issues.apache.org/jira/browse/GEODE-3185
> Project: Geode
>  Issue Type: Bug
>  Components: persistence
>Reporter: Lynn Gallinat
>  Labels: storage_3, windows_test
>
> {noformat}
> org.apache.geode.internal.cache.BackupJUnitTest > testBackupAndRecover FAILED
> java.lang.AssertionError: Null entry 512
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at 
> org.apache.geode.internal.cache.BackupJUnitTest.validateEntriesExist(BackupJUnitTest.java:354)
> at 
> org.apache.geode.internal.cache.BackupJUnitTest.backupAndRecover(BackupJUnitTest.java:229)
> at 
> org.apache.geode.internal.cache.BackupJUnitTest.testBackupAndRecover(BackupJUnitTest.java:126)
> org.apache.geode.internal.cache.BackupJUnitTest > testCompactionDuringBackup 
> FAILED
> java.lang.AssertionError: Null entry 0
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at 
> org.apache.geode.internal.cache.BackupJUnitTest.validateEntriesExist(BackupJUnitTest.java:354)
> at 
> org.apache.geode.internal.cache.BackupJUnitTest.testCompactionDuringBackup(BackupJUnitTest.java:309)
> org.apache.geode.internal.cache.BackupJUnitTest > 
> testBackupAndRecoverOldConfig FAILED
> java.lang.AssertionError: Null entry 512
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at 
> org.apache.geode.internal.cache.BackupJUnitTest.validateEntriesExist(BackupJUnitTest.java:354)
> at 
> org.apache.geode.internal.cache.BackupJUnitTest.backupAndRecover(BackupJUnitTest.java:229)
> at 
> org.apache.geode.internal.cache.BackupJUnitTest.testBackupAndRecoverOldConfig(BackupJUnitTest.java:136)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (GEODE-3187) CI failure (windows): org.apache.geode.internal.cache.persistence.BackupInspectorJUnitTest.testIncrementalBackupScript

[Fred Krone (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fred Krone updated GEODE-3187:
--
Labels: storage_3 windows_test  (was: )

> CI failure (windows): 
> org.apache.geode.internal.cache.persistence.BackupInspectorJUnitTest.testIncrementalBackupScript
> --
>
> Key: GEODE-3187
> URL: https://issues.apache.org/jira/browse/GEODE-3187
> Project: Geode
>  Issue Type: Bug
>  Components: persistence
>Reporter: Lynn Gallinat
>  Labels: storage_3, windows_test
>
> {noformat}
> org.apache.geode.internal.cache.persistence.BackupInspectorJUnitTest > 
> testIncrementalBackupScript FAILED
> java.lang.AssertionError
> at org.junit.Assert.fail(Assert.java:86)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at org.junit.Assert.assertTrue(Assert.java:52)
> at 
> org.apache.geode.internal.cache.persistence.BackupInspectorJUnitTest.testIncrementalBackupScript(BackupInspectorJUnitTest.java:198)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (GEODE-3190) CI failure: org.apache.geode.internal.cache.Bug48182JUnitTest.test48182WithRegionDestroy

[Fred Krone (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fred Krone updated GEODE-3190:
--
Labels: storage_3 windoes_test  (was: )

> CI failure: 
> org.apache.geode.internal.cache.Bug48182JUnitTest.test48182WithRegionDestroy
> 
>
> Key: GEODE-3190
> URL: https://issues.apache.org/jira/browse/GEODE-3190
> Project: Geode
>  Issue Type: Bug
>  Components: offheap
>Reporter: Lynn Gallinat
>  Labels: storage_3, windoes_test
>
> {noformat}
> org.apache.geode.internal.cache.Bug48182JUnitTest > 
> test48182WithRegionDestroy FAILED
> java.lang.AssertionError: A RegionDestroyedException was not triggered
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at 
> org.apache.geode.internal.cache.Bug48182JUnitTest.test48182WithRegionDestroy(Bug48182JUnitTest.java:201)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (GEODE-3180) CI failure: org.apache.geode.internal.cache.partitioned.PersistentColocatedPartitionedRegionDUnitTest.testFullTreeOfColocatedChildPRsWithMissingRegions fails with org.moc

[Fred Krone (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fred Krone updated GEODE-3180:
--
Labels: storage_3 windows_test  (was: )

> CI failure: 
> org.apache.geode.internal.cache.partitioned.PersistentColocatedPartitionedRegionDUnitTest.testFullTreeOfColocatedChildPRsWithMissingRegions
>  fails with org.mockito.exceptions.verification.NoInteractionsWanted
> ---
>
> Key: GEODE-3180
> URL: https://issues.apache.org/jira/browse/GEODE-3180
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Lynn Gallinat
>  Labels: storage_3, windows_test
>
> {noformat}
> org.apache.geode.internal.cache.partitioned.PersistentColocatedPartitionedRegionDUnitTest
>  > testFullTreeOfColocatedChildPRsWithMissingRegions FAILED
> java.lang.AssertionError: An exception occurred during asynchronous 
> invocation.
> at 
> org.apache.geode.test.dunit.AsyncInvocation.checkException(AsyncInvocation.java:148)
> at 
> org.apache.geode.test.dunit.AsyncInvocation.get(AsyncInvocation.java:422)
> at 
> org.apache.geode.internal.cache.partitioned.PersistentColocatedPartitionedRegionDUnitTest.testFullTreeOfColocatedChildPRsWithMissingRegions(PersistentColocatedPartitionedRegionDUnitTest.java:1298)
> Caused by:
> org.mockito.exceptions.verification.NoInteractionsWanted: 
> No interactions wanted here:
> -> at 
> org.apache.geode.internal.cache.partitioned.PersistentColocatedPartitionedRegionDUnitTest$14.call(PersistentColocatedPartitionedRegionDUnitTest.java:1232)
> But found this interaction on mock 'appender':
> -> at 
> org.apache.logging.log4j.core.config.AppenderControl.tryCallAppender(AppenderControl.java:156)
> ***
> For your reference, here is the list of all invocations ([?] - means 
> unverified).
> 1. -> at 
> org.apache.logging.log4j.core.config.AbstractConfiguration.addLoggerAppender(AbstractConfiguration.java:694)
> 2. -> at 
> org.apache.logging.log4j.core.config.AppenderControl.(AppenderControl.java:51)
> 3. -> at 
> org.apache.logging.log4j.core.config.AppenderControl.ensureAppenderStarted(AppenderControl.java:134)
> 4. -> at 
> org.apache.logging.log4j.core.config.AppenderControl.tryCallAppender(AppenderControl.java:156)
> 5. -> at 
> org.apache.logging.log4j.core.config.AppenderControl.ensureAppenderStarted(AppenderControl.java:134)
> 6. [?]-> at 
> org.apache.logging.log4j.core.config.AppenderControl.tryCallAppender(AppenderControl.java:156){noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-393) FunctionContext should provide a Cache

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16096874#comment-16096874
 ] 

ASF subversion and git services commented on GEODE-393:
---

Commit 56d964f867cd27a1489ebe3343c93b84c55cd8a9 in geode's branch 
refs/heads/develop from [~jinmeiliao]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=56d964f ]

GEODE-393: revert - GetRegionFunction uses the cache in the FunctionContext


> FunctionContext should provide a Cache
> --
>
> Key: GEODE-393
> URL: https://issues.apache.org/jira/browse/GEODE-393
> Project: Geode
>  Issue Type: Improvement
>  Components: functions
>Reporter: Dan Smith
>Assignee: David Anuta
>  Labels: starter
> Fix For: 1.3.0
>
>
> FunctionContext has methods to get the arguments to the function and the 
> result sender, but there is no way to get the Cache or DistributedSystem.
> This means pretty much any function will need to statically look up the cache 
> using CacheFactory.getAnyInstance(). While that works, it makes it impossible 
> to write unit tests for functions by passing in a mock cache.
> Note that onRegion functions are provided a RegionFunctionContext, which does 
> provide these functions with a means to look up the cache, but not all 
> functions are applied to a region.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3231) Do not have Server/LocatorStarterRule put logs in a log file by default.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16096854#comment-16096854
 ] 

ASF subversion and git services commented on GEODE-3231:


Commit 0ea489ea52bb8f04e50c396cb5a8c0629f82f075 in geode's branch 
refs/heads/feature/GEM-1483 from [~jinmeiliao]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=0ea489e ]

GEODE-3231: do not use temporary folder as workingdir or log to file by default 
when using the member starter rules

* do not create a workingDir and sets the user.dir by default for 
Locator/ServerStarterRule
* do not use a temp folder for all vms workingDir by default when using 
LocatorServerStarterRule.
* only bounce the vm when changing the workingdir of vms, otherwise, just 
cleanup the persisted files after each test.


> Do not have Server/LocatorStarterRule put logs in a log file by default.
> 
>
> Key: GEODE-3231
> URL: https://issues.apache.org/jira/browse/GEODE-3231
> Project: Geode
>  Issue Type: Bug
>Reporter: Jinmei Liao
>
> Currently, these rules have LOG_FILE defined by default, thus logs won't go 
> into the console but into a file. Need to have the logs go to the console by 
> default, and to file only needed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3055) waitUntilFlush did not check the brq's tempQueue, which caused data mismatch

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16096855#comment-16096855
 ] 

ASF subversion and git services commented on GEODE-3055:


Commit 24c004d8a4ccf212fd3ea89adab027fc52522326 in geode's branch 
refs/heads/feature/GEM-1483 from zhouxh
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=24c004d ]

GEODE-3055: The old primary's the shadow bucket is not
initialized when rebalance remove it. Thus the new primary candidate can
never initialize from it. The fix is to wait until new primary exists before
remove the old primary's bucket in rebalance.

There's another issue: the CreateMissingBucketsTask did not wait until the
region's buckets finished recovery, thus its check usually did nothing.
If a shadow region bucket failed to initialize due to race condition, then
no way to create missing bucket of the shadow region.


> waitUntilFlush did not check the brq's tempQueue, which caused data mismatch
> 
>
> Key: GEODE-3055
> URL: https://issues.apache.org/jira/browse/GEODE-3055
> Project: Geode
>  Issue Type: Bug
>Reporter: xiaojian zhou
>Assignee: xiaojian zhou
>  Labels: lucene
>
> /export/buglogs_bvt/xzhou/lucene/concParRegHAPersist-0601-171739
> lucene/concParRegHAPersist.conf
> A=accessor
> B=dataStore
> accessorHosts=1
> accessorThreadsPerVM=5
> accessorVMsPerHost=1
> dataStoreHosts=6
> dataStoreThreadsPerVM=5
> dataStoreVMsPerHost=1
> numVMsToStop=2
> redundantCopies=0
> no local.conf
> In dataStoregemfire5_7483/system.log, thread tid=0xdf, putAll Object_11066
> 17:22:27.135 tid=0xdf] generated tag {v1; rv13 shadowKey=2939
> 17:22:27.136 _partitionedRegionPARALLELGATEWAYSENDER_QUEUE_1 bucket : null // 
> brq is not ready yet
> is enqueued to the tempQueue
> 17:22:27.272 tid=0xdf] generated tag {v3; rv15 shadowKey=3278
> 17:22:33.111 Subregion created: 
> /_PR/_BAsyncEventQueueindex#partitionedRegionPARALLELGATEWAYSENDER_QUEUE_1
> vm_3_dataStore3_r02-s28_28143.log:
> 17:22:33.120 Put successfully in the queue shadowKey= 2939
> 17:22:33.156 tid=0x7fe started query
> 17:22:33.176 Peeked shadowKey= 2939
> So the root cause is: the event is still in tempQueue before it's processed, 
> the query happened. WaitUntilFlush should wait until tempQueue is also 
> flushed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-393) FunctionContext should provide a Cache

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16096853#comment-16096853
 ] 

ASF subversion and git services commented on GEODE-393:
---

Commit 5551b3feb1e85d1c7eae207583e505f11ed26720 in geode's branch 
refs/heads/feature/GEM-1483 from [~jinmeiliao]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=5551b3f ]

GEODE-393: GetRegionFunction uses the cache in the FunctionContext


> FunctionContext should provide a Cache
> --
>
> Key: GEODE-393
> URL: https://issues.apache.org/jira/browse/GEODE-393
> Project: Geode
>  Issue Type: Improvement
>  Components: functions
>Reporter: Dan Smith
>Assignee: David Anuta
>  Labels: starter
> Fix For: 1.3.0
>
>
> FunctionContext has methods to get the arguments to the function and the 
> result sender, but there is no way to get the Cache or DistributedSystem.
> This means pretty much any function will need to statically look up the cache 
> using CacheFactory.getAnyInstance(). While that works, it makes it impossible 
> to write unit tests for functions by passing in a mock cache.
> Note that onRegion functions are provided a RegionFunctionContext, which does 
> provide these functions with a means to look up the cache, but not all 
> functions are applied to a region.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3217) Reimplement GFSH Query as a single-step command

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16096852#comment-16096852
 ] 

ASF subversion and git services commented on GEODE-3217:


Commit 564a94b912e7ad70b1f001d3a43a123ed45900ba in geode's branch 
refs/heads/feature/GEM-1483 from [~jstewart]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=564a94b ]

GEODE-3217: Reimplement gfsh query as a single-step command


> Reimplement GFSH Query as a single-step command
> ---
>
> Key: GEODE-3217
> URL: https://issues.apache.org/jira/browse/GEODE-3217
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Reporter: Jared Stewart
>Assignee: Jared Stewart
> Fix For: 1.2.1
>
>
> The GFSH Query command is overly complex due to its implementation as a 
> "multistep" command.  The current pagination is broken.  We should 
> re-implement it as a standard (single-step) command.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (GEODE-3283) Add gfsh option on export to parrallelize a snapshot for PRs

[Fred Krone (JIRA)]

Fred Krone created GEODE-3283:
-

 Summary: Add gfsh option on export to parrallelize a snapshot for 
PRs
 Key: GEODE-3283
 URL: https://issues.apache.org/jira/browse/GEODE-3283
 Project: Geode
  Issue Type: Sub-task
Reporter: Fred Krone


This is related to another ticket to improve snapshot export time



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (GEODE-3107) Improve gfsh export time when doing a snapshot

[Fred Krone (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fred Krone reassigned GEODE-3107:
-

Assignee: Nick Reich  (was: Anilkumar Gingade)

> Improve gfsh export time when doing a snapshot
> --
>
> Key: GEODE-3107
> URL: https://issues.apache.org/jira/browse/GEODE-3107
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Affects Versions: 1.3.0
>Reporter: Fred Krone
>Assignee: Nick Reich
>  Labels: storage_1
>
> Currently a large snapshot puts a lot of pressure on the locator which needs 
> to hold all keys and they do not get destroyed.
> Snapshot goes through the JMX manager but snapshots can also be parallelized 
> and in theory this will probably improve performance.
> It would be useful to benchmark the current gfsh export time on 1 TB region 
> and compare it with performance improvements from this ticket.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (GEODE-3282) Snapshot more than one region at a time

[Fred Krone (JIRA)]

Fred Krone created GEODE-3282:
-

 Summary: Snapshot more than one region at a time
 Key: GEODE-3282
 URL: https://issues.apache.org/jira/browse/GEODE-3282
 Project: Geode
  Issue Type: Sub-task
  Components: regions
Reporter: Fred Krone


Provide an option to snapshot more than one Region at a time.  This is useful 
in the event where regions are colocated or have reference data.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (GEODE-3159) Improvements to Snapshot

[Fred Krone (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fred Krone updated GEODE-3159:
--
Summary: Improvements to Snapshot  (was: Snapshot more than one region at a 
time)

> Improvements to Snapshot
> 
>
> Key: GEODE-3159
> URL: https://issues.apache.org/jira/browse/GEODE-3159
> Project: Geode
>  Issue Type: Wish
>  Components: regions
>Reporter: Fred Krone
>Assignee: Fred Krone
>
> This story serves as an epic for improving Snapshots.  Specifically, 
> providing the ability to snapshot multiple regions at a time. 
> Use case is: I have two regions related to each other and I want to snapshot 
> them both to maintain consistency.
> Problem: Currently only one region can be snapshotted at a time.
> Provide the ability to snapshot more than one region.  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3231) Do not have Server/LocatorStarterRule put logs in a log file by default.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16096787#comment-16096787
 ] 

ASF subversion and git services commented on GEODE-3231:


Commit 0ea489ea52bb8f04e50c396cb5a8c0629f82f075 in geode's branch 
refs/heads/develop from [~jinmeiliao]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=0ea489e ]

GEODE-3231: do not use temporary folder as workingdir or log to file by default 
when using the member starter rules

* do not create a workingDir and sets the user.dir by default for 
Locator/ServerStarterRule
* do not use a temp folder for all vms workingDir by default when using 
LocatorServerStarterRule.
* only bounce the vm when changing the workingdir of vms, otherwise, just 
cleanup the persisted files after each test.


> Do not have Server/LocatorStarterRule put logs in a log file by default.
> 
>
> Key: GEODE-3231
> URL: https://issues.apache.org/jira/browse/GEODE-3231
> Project: Geode
>  Issue Type: Bug
>Reporter: Jinmei Liao
>
> Currently, these rules have LOG_FILE defined by default, thus logs won't go 
> into the console but into a file. Need to have the logs go to the console by 
> default, and to file only needed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-393) FunctionContext should provide a Cache

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16096784#comment-16096784
 ] 

ASF subversion and git services commented on GEODE-393:
---

Commit 5551b3feb1e85d1c7eae207583e505f11ed26720 in geode's branch 
refs/heads/develop from [~jinmeiliao]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=5551b3f ]

GEODE-393: GetRegionFunction uses the cache in the FunctionContext


> FunctionContext should provide a Cache
> --
>
> Key: GEODE-393
> URL: https://issues.apache.org/jira/browse/GEODE-393
> Project: Geode
>  Issue Type: Improvement
>  Components: functions
>Reporter: Dan Smith
>Assignee: David Anuta
>  Labels: starter
> Fix For: 1.3.0
>
>
> FunctionContext has methods to get the arguments to the function and the 
> result sender, but there is no way to get the Cache or DistributedSystem.
> This means pretty much any function will need to statically look up the cache 
> using CacheFactory.getAnyInstance(). While that works, it makes it impossible 
> to write unit tests for functions by passing in a mock cache.
> Note that onRegion functions are provided a RegionFunctionContext, which does 
> provide these functions with a means to look up the cache, but not all 
> functions are applied to a region.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-2997) New flow: putAll/getAll

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16096764#comment-16096764
 ] 

ASF GitHub Bot commented on GEODE-2997:
---

Github user kohlmu-pivotal commented on a diff in the pull request:

https://github.com/apache/geode/pull/649#discussion_r128848930
  
--- Diff: geode-protobuf/src/main/proto/basicTypes.proto ---
@@ -62,4 +62,14 @@ message Region {
 
 message Server {
 string url = 1;
-}
\ No newline at end of file
+}
+
+message Error {
+int32 errorCode = 1;
+string message = 2;
+}
+
+message ErrorEntry {
--- End diff --

Tbh, I'm not ecstatic about the name. I'd prefer `FailedEntry`


> New flow: putAll/getAll
> ---
>
> Key: GEODE-2997
> URL: https://issues.apache.org/jira/browse/GEODE-2997
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server
>Reporter: Brian Baynes
>
> Create proto message definitions and op handler for putAll/getAll messages.
> Client should be able to complete putAll/getAll of primitives and JSON with 
> response.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-2997) New flow: putAll/getAll

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16096763#comment-16096763
 ] 

ASF GitHub Bot commented on GEODE-2997:
---

Github user kohlmu-pivotal commented on a diff in the pull request:

https://github.com/apache/geode/pull/649#discussion_r128847166
  
--- Diff: geode-protobuf/src/main/proto/clientProtocol.proto ---
@@ -66,7 +66,7 @@ message Response {
 RemoveAllResponse removeAllResponse = 7;
 ListKeysResponse listKeysResponse = 8;
 
-ErrorResponse errorResponse = 13;
+Error error = 13;
--- End diff --

Why has this been renamed to Error from ErrorResponse? Imo, we are 
following the pattern (good or bad) that a ClientProtocol.Response contains an 
Operation specific response. To now have a non-"Response" message sort of 
breaks the mold.


> New flow: putAll/getAll
> ---
>
> Key: GEODE-2997
> URL: https://issues.apache.org/jira/browse/GEODE-2997
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server
>Reporter: Brian Baynes
>
> Create proto message definitions and op handler for putAll/getAll messages.
> Client should be able to complete putAll/getAll of primitives and JSON with 
> response.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-2936) Refactor OrderByComparator's compare method to reduce redundant code

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16096688#comment-16096688
 ] 

ASF GitHub Bot commented on GEODE-2936:
---

Github user YehEmily commented on the issue:

https://github.com/apache/geode/pull/580
  
@jhuynh1 Thanks for the suggestion! I updated the tests in 
`OrderByComparatorJUnitTest.java` to cover all the cases in 
`OrderByComparator.java` and updated the PR.


> Refactor OrderByComparator's compare method to reduce redundant code
> 
>
> Key: GEODE-2936
> URL: https://issues.apache.org/jira/browse/GEODE-2936
> Project: Geode
>  Issue Type: Bug
>  Components: querying
>Reporter: nabarun
>Assignee: Emily Yeh
>
> Issue:
> OrderByComparator's compare method has a lot of redundant code.
> Solution:
> These code sections can be modified to have one method call



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3253) Refactor ClientCommands

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16096669#comment-16096669
 ] 

ASF GitHub Bot commented on GEODE-3253:
---

GitHub user YehEmily opened a pull request:

https://github.com/apache/geode/pull/650

GEODE-3253: Refactoring ClientCommands and related tests

[View the JIRA ticket 
here.](https://issues.apache.org/jira/browse/GEODE-3253)

`ClientCommands.java` was a large class that contained multiple commands. 
In this PR, each command was refactored into a separate class. 
`ClientCommandsDUnitTest.java` was also refactored and split into 
`DescribeClientCommandDUnitTest.java` and `ListClientCommandDUnitTest.java`. 
Methods shared by these two tests were moved into a new class, 
`ClientCommandsTestUtils.java`.

- [x] JIRA Ticket referenced

- [x] PR rebased against develop

- [x] Initial contribution is a single squashed commit

- [x] `gradlew build` runs cleanly

- [x] Tests updated to verify changes

**Testing status**: **Precheckin currently running**

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/YehEmily/geode GEODE-3253

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/650.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #650


commit bf623e78ed44621f3efd6e5884f3d97d0cac31ee
Author: YehEmily 
Date:   2017-07-20T23:54:22Z

GEODE-3253: Refactoring ClientCommands and related tests




> Refactor ClientCommands
> ---
>
> Key: GEODE-3253
> URL: https://issues.apache.org/jira/browse/GEODE-3253
> Project: Geode
>  Issue Type: Sub-task
>  Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{ClientCommands.java}} is a large class that contains multiple commands. 
> Each command should be refactored into a separate class, and the methods 
> shared by the commands should be refactored into a new and appropriately 
> named class of their own.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (GEODE-3281) Native Client Example Docs Use RegisterType instead of RegisterTypeGeneric

[Addison (JIRA)]

Addison created GEODE-3281:
--

 Summary: Native Client Example Docs Use RegisterType instead of 
RegisterTypeGeneric
 Key: GEODE-3281
 URL: https://issues.apache.org/jira/browse/GEODE-3281
 Project: Geode
  Issue Type: Bug
  Components: docs, native client
Reporter: Addison


Change RegisterType to RegisterTypeGeneric in 
https://github.com/apache/geode-native/blob/develop/docs/geode-native-docs/dotnet-caching-api/custom-class-igfserializable.html.md.erb



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3217) Reimplement GFSH Query as a single-step command

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16096581#comment-16096581
 ] 

ASF subversion and git services commented on GEODE-3217:


Commit 564a94b912e7ad70b1f001d3a43a123ed45900ba in geode's branch 
refs/heads/develop from [~jstewart]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=564a94b ]

GEODE-3217: Reimplement gfsh query as a single-step command


> Reimplement GFSH Query as a single-step command
> ---
>
> Key: GEODE-3217
> URL: https://issues.apache.org/jira/browse/GEODE-3217
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Reporter: Jared Stewart
>Assignee: Jared Stewart
> Fix For: 1.2.1
>
>
> The GFSH Query command is overly complex due to its implementation as a 
> "multistep" command.  The current pagination is broken.  We should 
> re-implement it as a standard (single-step) command.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (GEODE-3218) Client-Server protocol API Specification

[Udo Kohlmeyer (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Udo Kohlmeyer reassigned GEODE-3218:


Assignee: Galen O'Sullivan

> Client-Server protocol API Specification
> 
>
> Key: GEODE-3218
> URL: https://issues.apache.org/jira/browse/GEODE-3218
> Project: Geode
>  Issue Type: Task
>  Components: client/server, serialization
>Reporter: Udo Kohlmeyer
>Assignee: Galen O'Sullivan
>
> This is a parent task to track the specification of the client-server 
> protocol API.
> This specification will contain:
> * Message definition (Request/Response)
> * Use Cases and expected results



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (GEODE-3227) GetAvailableServers Specification Definition

[Udo Kohlmeyer (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Udo Kohlmeyer reassigned GEODE-3227:


Assignee: Galen O'Sullivan

> GetAvailableServers Specification Definition
> 
>
> Key: GEODE-3227
> URL: https://issues.apache.org/jira/browse/GEODE-3227
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server, serialization
>Reporter: Udo Kohlmeyer
>Assignee: Galen O'Sullivan
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (GEODE-3236) Error Message Specification Definition

[Udo Kohlmeyer (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Udo Kohlmeyer reassigned GEODE-3236:


Assignee: Galen O'Sullivan

> Error Message Specification Definition
> --
>
> Key: GEODE-3236
> URL: https://issues.apache.org/jira/browse/GEODE-3236
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server, serialization
>Reporter: Udo Kohlmeyer
>Assignee: Galen O'Sullivan
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (GEODE-3225) GetRegionInfo Specification Definition

[Udo Kohlmeyer (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Udo Kohlmeyer reassigned GEODE-3225:


Assignee: Galen O'Sullivan

> GetRegionInfo Specification Definition
> --
>
> Key: GEODE-3225
> URL: https://issues.apache.org/jira/browse/GEODE-3225
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server, serialization
>Reporter: Udo Kohlmeyer
>Assignee: Galen O'Sullivan
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (GEODE-3226) GetAvailableRegionNames Specification Definition

[Udo Kohlmeyer (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Udo Kohlmeyer reassigned GEODE-3226:


Assignee: Galen O'Sullivan

> GetAvailableRegionNames Specification Definition
> 
>
> Key: GEODE-3226
> URL: https://issues.apache.org/jira/browse/GEODE-3226
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server, serialization
>Reporter: Udo Kohlmeyer
>Assignee: Galen O'Sullivan
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3213) Refactor Protobuf Serialization Implemenation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16096532#comment-16096532
 ] 

ASF GitHub Bot commented on GEODE-3213:
---

Github user galen-pivotal commented on a diff in the pull request:

https://github.com/apache/geode/pull/646#discussion_r128811946
  
--- Diff: 
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/OperationContext.java
 ---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+
+package org.apache.geode.protocol.protobuf;
+
+import org.apache.geode.protocol.operations.OperationHandler;
+
+import java.util.function.Function;
+
+public class OperationContext {
--- End diff --

I think it makes more sense to have these be implementations of an 
interface, since they're acting as an immutable collection of functions.


> Refactor Protobuf Serialization Implemenation
> -
>
> Key: GEODE-3213
> URL: https://issues.apache.org/jira/browse/GEODE-3213
> Project: Geode
>  Issue Type: Improvement
>  Components: client/server, serialization
>Reporter: Udo Kohlmeyer
>
> In the Protobuf serialization implementation, there are some refactorings we 
> want to make:
> * OperationHandlers take OperationRequest and OperationResponse message, not 
> the parent Request/Response Object
> * A generic flow needs to be implemented that all OperationHandlers follow. 
> No bespoke flows for any OperationHandlers... way too much maintenance
> * Use Functional semantics to configure the functionality to extract 
> OperationRequest from Request (per OperationHandler)
> * Use Functional semantics to configure the functionality to populate 
> OperationResponse in the relevant Response
> * Have generic Error Handling framework to populate "known" errors and error 
> codes



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (GEODE-3221) GetAll Specification Definition

[Udo Kohlmeyer (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Udo Kohlmeyer reassigned GEODE-3221:


Assignee: Galen O'Sullivan

> GetAll Specification Definition
> ---
>
> Key: GEODE-3221
> URL: https://issues.apache.org/jira/browse/GEODE-3221
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server, serialization
>Reporter: Udo Kohlmeyer
>Assignee: Galen O'Sullivan
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (GEODE-3220) Put Specification Definition

[Udo Kohlmeyer (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Udo Kohlmeyer reassigned GEODE-3220:


Assignee: Galen O'Sullivan

> Put Specification Definition
> 
>
> Key: GEODE-3220
> URL: https://issues.apache.org/jira/browse/GEODE-3220
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server, serialization
>Reporter: Udo Kohlmeyer
>Assignee: Galen O'Sullivan
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (GEODE-3219) Get Specification Definition

[Udo Kohlmeyer (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Udo Kohlmeyer reassigned GEODE-3219:


Assignee: Galen O'Sullivan  (was: Udo Kohlmeyer)

> Get Specification Definition
> 
>
> Key: GEODE-3219
> URL: https://issues.apache.org/jira/browse/GEODE-3219
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server, serialization
>Reporter: Udo Kohlmeyer
>Assignee: Galen O'Sullivan
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (GEODE-3219) Get Specification Definition

[Udo Kohlmeyer (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Udo Kohlmeyer reassigned GEODE-3219:


Assignee: Udo Kohlmeyer

> Get Specification Definition
> 
>
> Key: GEODE-3219
> URL: https://issues.apache.org/jira/browse/GEODE-3219
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server, serialization
>Reporter: Udo Kohlmeyer
>Assignee: Udo Kohlmeyer
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3213) Refactor Protobuf Serialization Implemenation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16096386#comment-16096386
 ] 

ASF GitHub Bot commented on GEODE-3213:
---

Github user pivotal-amurmann commented on a diff in the pull request:

https://github.com/apache/geode/pull/646#discussion_r128793895
  
--- Diff: 
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufResponseUtilities.java
 ---
@@ -50,47 +38,14 @@
* @param ex - exception which should be logged
* @return An error response containing the first three parameters.
*/
-  public static ClientProtocol.Response createAndLogErrorResponse(String 
errorMessage,
+  public static ClientProtocol.ErrorResponse 
createAndLogFailureResponse(String errorMessage,
--- End diff --

I think those were to changes that were made independently. Syncing this up 
right now


> Refactor Protobuf Serialization Implemenation
> -
>
> Key: GEODE-3213
> URL: https://issues.apache.org/jira/browse/GEODE-3213
> Project: Geode
>  Issue Type: Improvement
>  Components: client/server, serialization
>Reporter: Udo Kohlmeyer
>
> In the Protobuf serialization implementation, there are some refactorings we 
> want to make:
> * OperationHandlers take OperationRequest and OperationResponse message, not 
> the parent Request/Response Object
> * A generic flow needs to be implemented that all OperationHandlers follow. 
> No bespoke flows for any OperationHandlers... way too much maintenance
> * Use Functional semantics to configure the functionality to extract 
> OperationRequest from Request (per OperationHandler)
> * Use Functional semantics to configure the functionality to populate 
> OperationResponse in the relevant Response
> * Have generic Error Handling framework to populate "known" errors and error 
> codes



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (GEODE-3280) Hello

[Gregory Chase (JIRA)]

Gregory Chase created GEODE-3280:


 Summary: Hello 
 Key: GEODE-3280
 URL: https://issues.apache.org/jira/browse/GEODE-3280
 Project: Geode
  Issue Type: Improvement
Reporter: Gregory Chase


Hello 

*Reporter*: Makara Soeng
*E-mail*: [mailto:makaraso...@gmail.com]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3108) secure ability to create lucene indexes

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095859#comment-16095859
 ] 

ASF subversion and git services commented on GEODE-3108:


Commit b71f3a636175a26974fae88a5090ed4d94ccce73 in geode's branch 
refs/heads/feature/GEM-1483 from [~jinmeiliao]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=b71f3a6 ]

GEODE-3108: update lucene security permission to use "LUCENE" target

* have lucene module define it's own target for plugability
* added string based target support for SecurityService


> secure ability to create lucene indexes
> ---
>
> Key: GEODE-3108
> URL: https://issues.apache.org/jira/browse/GEODE-3108
> Project: Geode
>  Issue Type: Sub-task
>  Components: docs, security
>Reporter: Swapnil Bawaskar
>Assignee: Kenneth Howe
>
> Treat queries as a CLUSTER resource so that administrators can control 
> ability to manage indices (both OQL and Lucene), and manage Continuous 
> queries.
> Only a user with CLUSTER:MANAGE:LUCENE should be able to run the following 
> gfsh commands:
> {noformat}
> create lucene index   
> destroy lucene index  
> {noformat}
> A user with CLUSTER:READ:LUCENE should be able to run the following commands:
> {noformat}
> describe lucene index 
> list lucene indexes   
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-2818) add alias to any command's options that involves "group", "member", "jar"

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095857#comment-16095857
 ] 

ASF subversion and git services commented on GEODE-2818:


Commit 92f26f176f2a6530d334eee2bb74fdda23ea6f8e in geode's branch 
refs/heads/feature/GEM-1483 from YehEmily
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=92f26f1 ]

GEODE-2818: Making "groups" a valid option when starting locators or servers 
and adding a comprehensive test to cover changes.

* this closes #598


> add alias to any command's options that involves "group", "member", "jar"
> -
>
> Key: GEODE-2818
> URL: https://issues.apache.org/jira/browse/GEODE-2818
> Project: Geode
>  Issue Type: New Feature
>  Components: docs, gfsh
>Reporter: Jinmei Liao
>Assignee: Emily Yeh
>
> Or anything that would have confusion about if we are going to use singular 
> or plural at all.
> 1) add alias for those options
> 2) make sure it parameter type is an array type, some method only accepts a 
> string and split it inside the command.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3055) waitUntilFlush did not check the brq's tempQueue, which caused data mismatch

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095863#comment-16095863
 ] 

ASF subversion and git services commented on GEODE-3055:


Commit 40fb5fdf9e7053de7b1f1df0fc1adfd3fe78546b in geode's branch 
refs/heads/feature/GEM-1483 from zhouxh
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=40fb5fd ]

GEODE-3055: The old primary's the shadow bucket is not
initialized when rebalance remove it. Thus the new primary candidate can
never initialize from it. The fix is to wait until new primary exists before
remove the old primary's bucket in rebalance.


> waitUntilFlush did not check the brq's tempQueue, which caused data mismatch
> 
>
> Key: GEODE-3055
> URL: https://issues.apache.org/jira/browse/GEODE-3055
> Project: Geode
>  Issue Type: Bug
>Reporter: xiaojian zhou
>Assignee: xiaojian zhou
>  Labels: lucene
>
> /export/buglogs_bvt/xzhou/lucene/concParRegHAPersist-0601-171739
> lucene/concParRegHAPersist.conf
> A=accessor
> B=dataStore
> accessorHosts=1
> accessorThreadsPerVM=5
> accessorVMsPerHost=1
> dataStoreHosts=6
> dataStoreThreadsPerVM=5
> dataStoreVMsPerHost=1
> numVMsToStop=2
> redundantCopies=0
> no local.conf
> In dataStoregemfire5_7483/system.log, thread tid=0xdf, putAll Object_11066
> 17:22:27.135 tid=0xdf] generated tag {v1; rv13 shadowKey=2939
> 17:22:27.136 _partitionedRegionPARALLELGATEWAYSENDER_QUEUE_1 bucket : null // 
> brq is not ready yet
> is enqueued to the tempQueue
> 17:22:27.272 tid=0xdf] generated tag {v3; rv15 shadowKey=3278
> 17:22:33.111 Subregion created: 
> /_PR/_BAsyncEventQueueindex#partitionedRegionPARALLELGATEWAYSENDER_QUEUE_1
> vm_3_dataStore3_r02-s28_28143.log:
> 17:22:33.120 Put successfully in the queue shadowKey= 2939
> 17:22:33.156 tid=0x7fe started query
> 17:22:33.176 Peeked shadowKey= 2939
> So the root cause is: the event is still in tempQueue before it's processed, 
> the query happened. WaitUntilFlush should wait until tempQueue is also 
> flushed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3272) Correct docs: location of .gfsh.history file

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095855#comment-16095855
 ] 

ASF subversion and git services commented on GEODE-3272:


Commit e2f79e5d47faedc708c3c07038a84b01759558eb in geode's branch 
refs/heads/feature/GEM-1483 from [~karensmolermiller]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=e2f79e5 ]

GEODE-3272 Doc update: .gfsh.history goes into .geode dir

Doing this single word correction as a Commit-Then-Review
change.  The gfsh history command reference page had the correct
directory name, but the subsection titled Configuring the gfsh
Environment also states the directory name and it had the
old, incorrect name.


> Correct docs: location of .gfsh.history file
> 
>
> Key: GEODE-3272
> URL: https://issues.apache.org/jira/browse/GEODE-3272
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
> Fix For: 1.3.0
>
>
> The .gfsh.history file goes into a directory named .geode.  There is an 
> instance in the manual (file tools_modules/gfsh/configuring_gfsh.html) that 
> still says the directory is named .gemfire.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3156) Add AcceptanceTest gradle target and junit category

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095858#comment-16095858
 ] 

ASF subversion and git services commented on GEODE-3156:


Commit ef688c8a3c5ba63f2da2f09e9ae3fca4dca37a62 in geode's branch 
refs/heads/feature/GEM-1483 from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=ef688c8 ]

GEODE-3156: add AcceptanceTest gradle target and junit category


> Add AcceptanceTest gradle target and junit category
> ---
>
> Key: GEODE-3156
> URL: https://issues.apache.org/jira/browse/GEODE-3156
> Project: Geode
>  Issue Type: Improvement
>  Components: build
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> Add AcceptanceTest gradle target and junit category.
> We would then have these test type categories and targets:
> * UnitTest: ./gradlew test
> * IntegrationTest: ./gradlew integrationTest
> * DistributedTest: ./gradlew distributedTest
> * AcceptanceTest: ./gradlew acceptanceTest



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3208) Update JAR file references in docs

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095860#comment-16095860
 ] 

ASF subversion and git services commented on GEODE-3208:


Commit 119c20f9b5148bd8c02ed3fecd26b2fff9e67f87 in geode's branch 
refs/heads/feature/GEM-1483 from [~karensmolermiller]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=119c20f ]

GEODE-3208 Revise docs with outdated JAR references

This closes #644


> Update JAR file references in docs
> --
>
> Key: GEODE-3208
> URL: https://issues.apache.org/jira/browse/GEODE-3208
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
> Fix For: 1.3.0
>
>
> All references throughout the documentation that currently say
> - {{lib/server-dependencies.jar}}
> - {{lib/locator-dependencies.jar}}
> are no longer correct.  Both change to {{lib/geode-dependencies.jar}} .



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3112) CI failure: ClientFunctionTimeoutRegressionTest.testExecuteFunctionReadsDefaultTimeout

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095862#comment-16095862
 ] 

ASF subversion and git services commented on GEODE-3112:


Commit 66cd31a7c280efac101c75fd438e0bf0c0476904 in geode's branch 
refs/heads/feature/GEM-1483 from [~DivineEnder]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=66cd31a ]

GEODE-3112: Fixing improper ordering of client timeout setting

This closes #639.


> CI failure: 
> ClientFunctionTimeoutRegressionTest.testExecuteFunctionReadsDefaultTimeout
> --
>
> Key: GEODE-3112
> URL: https://issues.apache.org/jira/browse/GEODE-3112
> Project: Geode
>  Issue Type: Bug
>  Components: functions
>Affects Versions: 1.2.0, 1.3.0
>Reporter: Shelley Lynn Hughes-Godfrey
>Assignee: David Anuta
> Fix For: 1.3.0
>
>
> {noformat}
> org.apache.geode.internal.cache.execute.ClientFunctionTimeoutRegressionTest > 
> testExecuteFunctionReadsDefaultTimeout(false,6000,server) [3] FAILED
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.internal.cache.execute.ClientFunctionTimeoutRegressionTest$$Lambda$21/1996321698.run
>  in VM 1 running on Host 11375a95c724 with 4 VMs
> at org.apache.geode.test.dunit.VM.invoke(VM.java:377)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:347)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:292)
> at 
> org.apache.geode.internal.cache.execute.ClientFunctionTimeoutRegressionTest.testExecuteFunctionReadsDefaultTimeout(ClientFunctionTimeoutRegressionTest.java:109)
> Caused by:
> org.junit.ComparisonFailure: [Server did not read 
> client_function_timeout from client.] expected:<[tru]e> but was:<[fals]e>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native 
> Method)
> at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at 
> org.apache.geode.internal.cache.execute.ClientFunctionTimeoutRegressionTest.executeFunction(ClientFunctionTimeoutRegressionTest.java:179)
> at 
> org.apache.geode.internal.cache.execute.ClientFunctionTimeoutRegressionTest.lambda$testExecuteFunctionReadsDefaultTimeout$a0075c0$1(ClientFunctionTimeoutRegressionTest.java:109)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3090) gfsh help typo

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095861#comment-16095861
 ] 

ASF subversion and git services commented on GEODE-3090:


Commit 571239151ea941ea7c09dc21a570c0e8e5e853b3 in geode's branch 
refs/heads/feature/GEM-1483 from [~eyeh]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=5712391 ]

GEODE-3090: Fixing gfsh help message (and a lot of other typos)

* this closes #590


> gfsh help typo
> --
>
> Key: GEODE-3090
> URL: https://issues.apache.org/jira/browse/GEODE-3090
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Reporter: Dave Barnes
>Assignee: Emily Yeh
>Priority: Minor
>
> gfsh> help connect
> ...
> use-ssl
> Whether to use SSL for communication with Locator and/or JMX Manager. 
> If set to "true", will also read "gfsecurity.properties". SSL Options
> take precedence over proeprties file.
> "proeprties" should be "properties"



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3113) CI failure: .HARQAddOperationJUnitTest.testNoExpiryOnThreadIdentifier

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095856#comment-16095856
 ] 

ASF subversion and git services commented on GEODE-3113:


Commit 81c7014e0c0789cfeefe6d78b2bda4e23bf829f0 in geode's branch 
refs/heads/feature/GEM-1483 from [~lhughesgodfrey]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=81c7014 ]

GEODE-3113: Modify HARegionQueue test to use Awaitility vs. timeouts
This closes #645

* Modify test to use Awaitility (at most 60 seconds) vs. sleeps prior to 
checking expiration
* remove obsolete comment


> CI failure: .HARQAddOperationJUnitTest.testNoExpiryOnThreadIdentifier
> -
>
> Key: GEODE-3113
> URL: https://issues.apache.org/jira/browse/GEODE-3113
> Project: Geode
>  Issue Type: Bug
>  Components: client queues
>Affects Versions: 1.3.0
>Reporter: Shelley Lynn Hughes-Godfrey
>Assignee: Shelley Lynn Hughes-Godfrey
> Fix For: 1.3.0
>
>
> {noformat}
> org.apache.geode.internal.cache.ha.HARQAddOperationJUnitTest > 
> testNoExpiryOnThreadIdentifier FAILED
> java.lang.AssertionError: expected:<0> but was:<1>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:834)
> at org.junit.Assert.assertEquals(Assert.java:645)
> at org.junit.Assert.assertEquals(Assert.java:631)
> at 
> org.apache.geode.internal.cache.ha.HARQAddOperationJUnitTest.testNoExpiryOnThreadIdentifier(HARQAddOperationJUnitTest.java:295)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-240) Remove deprecated methods on TransactionEvent

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095842#comment-16095842
 ] 

ASF GitHub Bot commented on GEODE-240:
--

Github user shankarh commented on the issue:

https://github.com/apache/geode/pull/515
  
Can this PR be merged? 


> Remove deprecated methods on TransactionEvent
> -
>
> Key: GEODE-240
> URL: https://issues.apache.org/jira/browse/GEODE-240
> Project: Geode
>  Issue Type: Sub-task
>Reporter: Darrel Schneider
>Assignee: Shankar Hundekar
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> The following methods should all be deleted from TransactionEvent and callers 
> should be changed to instead use getEvents. The caller may have to do its own 
> filtering on getEvents to find the event(s) it is interested in.
> - getCreateEvents
> - getDestroyEvents
> - getPutEvents
> - getInvalidateEvents
> Some of the existing unit tests depend on the filtering done by these methods 
> so that filtering will need to move to some test util methods.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)