[jira] [Reopened] (GEODE-3322) geode-core:javadoc is generating warnings

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund reopened GEODE-3322:
--

We have several new sources of warnings:
{noformat}
:geode-core:javadoc
/Users/klund/dev/gemfire/open/geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockRequestProcessor.java:206:
 warning - @return tag has no arguments.
1 warning
{noformat}


> geode-core:javadoc is generating warnings
> -
>
> Key: GEODE-3322
> URL: https://issues.apache.org/jira/browse/GEODE-3322
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Reporter: Kirk Lund
>Assignee: Kirk Lund
> Fix For: 1.3.0
>
>
> {noformat}
> :geode-core:javadoc
> /Users/klund/dev/gemfire/open/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/HostAddress.java:45:
>  warning - @return tag has no arguments.
> 1 warning
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3469) LocatorLauncherLocalFileIntegrationTest.usesLocatorPortAsDefaultPort fails intermittently with IllegalArgumentException: Invalid pid '0' specified

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133836#comment-16133836
 ] 

ASF GitHub Bot commented on GEODE-3469:
---

Github user kirklund commented on a diff in the pull request:

https://github.com/apache/geode/pull/724#discussion_r134077082
  
--- Diff: 
geode-core/src/test/java/org/apache/geode/internal/process/lang/AvailablePid.java
 ---
@@ -30,37 +30,88 @@
  */
 public class AvailablePid {
 
-  static final int LOWER_BOUND = 1;
-  static final int UPPER_BOUND = 64000;
+  static final int DEFAULT_LOWER_BOUND = 1;
+  static final int DEFAULT_UPPER_BOUND = 64000;
   static final int DEFAULT_TIMEOUT_MILLIS = 60 * 1000;
 
+  private final int lowerBound;
+  private final int upperBound;
   private final Random random;
   private final int timeoutMillis;
 
   /**
-   * Construct with no seed and default timeout of 1 minute.
+   * Construct with:
+   * 
+   * default {@link Bounds} of {@link #DEFAULT_LOWER_BOUND} 
(inclusive) and
+   * {@link #DEFAULT_UPPER_BOUND} (inclusive)
+   * Random with no see
--- End diff --

I no see your point ;)


> LocatorLauncherLocalFileIntegrationTest.usesLocatorPortAsDefaultPort fails 
> intermittently with IllegalArgumentException: Invalid pid '0' specified
> --
>
> Key: GEODE-3469
> URL: https://issues.apache.org/jira/browse/GEODE-3469
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> {noformat}
> org.apache.geode.distributed.LocatorLauncherLocalFileIntegrationTest > 
> usesLocatorPortAsDefaultPort FAILED
> java.lang.IllegalArgumentException: Invalid pid '0' specified
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (GEODE-3474) ProtobufSimpleAuthenticator is incompatible with ExampleSecurityManager

[Galen O'Sullivan (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Galen O'Sullivan updated GEODE-3474:

Issue Type: Sub-task  (was: Bug)
Parent: GEODE-3447

> ProtobufSimpleAuthenticator is incompatible with ExampleSecurityManager
> ---
>
> Key: GEODE-3474
> URL: https://issues.apache.org/jira/browse/GEODE-3474
> Project: Geode
>  Issue Type: Sub-task
>  Components: messaging
>Reporter: Galen O'Sullivan
>
> {{ProtobufSimpleAuthenticator}} uses the property names "username" and 
> password" to provide credentials, but {{ExampleSecurityManager}} uses 
> "security-username" and "security-password". These are defined as 
> {{ResourceConstants.USER_NAME}} and  {{ResourceConstants.PASSWORD}} and 
> therefore probably the correct values to use.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (GEODE-3474) ProtobufSimpleAuthenticator is incompatible with ExampleSecurityManager

[Galen O'Sullivan (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Galen O'Sullivan updated GEODE-3474:

Description: {{ProtobufSimpleAuthenticator}} uses the property names 
"username" and password" to provide credentials, but {{ExampleSecurityManager}} 
uses "security-username" and "security-password". These are defined as 
{{ResourceConstants.USER_NAME}} and  {{ResourceConstants.PASSWORD}} and 
therefore probably the correct values to use.  (was: 
{{ProtobufSimpleAuthenticator}} uses the property names "username" and 
password" to provide credentials, but {{ExampleSecurityManager}} uses 
"security-username" and "security-password". These are defined as 
{{ResourceConstants.USER_NAME}} and  {{ResourceConstants.PASSWORD}})

> ProtobufSimpleAuthenticator is incompatible with ExampleSecurityManager
> ---
>
> Key: GEODE-3474
> URL: https://issues.apache.org/jira/browse/GEODE-3474
> Project: Geode
>  Issue Type: Bug
>  Components: messaging
>Reporter: Galen O'Sullivan
>
> {{ProtobufSimpleAuthenticator}} uses the property names "username" and 
> password" to provide credentials, but {{ExampleSecurityManager}} uses 
> "security-username" and "security-password". These are defined as 
> {{ResourceConstants.USER_NAME}} and  {{ResourceConstants.PASSWORD}} and 
> therefore probably the correct values to use.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (GEODE-3474) ProtobufSimpleAuthenticator is incompatible with ExampleSecurityManager

[Galen O'Sullivan (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Galen O'Sullivan updated GEODE-3474:

Description: {{ProtobufSimpleAuthenticator}} uses the property names 
"username" and password" to provide credentials, but {{ExampleSecurityManager}} 
uses "security-username" and "security-password". These are defined as 
{{ResourceConstants.USER_NAME}} and  {{ResourceConstants.PASSWORD}}  (was: 
{{ProtobufSimpleAuthenticator}} uses the property names "username" and 
password" to provide credentials, but {{ExampleSecurityManager}} uses 
"security-username" and "security-password". I don't know the contract for 
security managers in general, but these two should probably be able to talk to 
one another.)

> ProtobufSimpleAuthenticator is incompatible with ExampleSecurityManager
> ---
>
> Key: GEODE-3474
> URL: https://issues.apache.org/jira/browse/GEODE-3474
> Project: Geode
>  Issue Type: Bug
>  Components: messaging
>Reporter: Galen O'Sullivan
>
> {{ProtobufSimpleAuthenticator}} uses the property names "username" and 
> password" to provide credentials, but {{ExampleSecurityManager}} uses 
> "security-username" and "security-password". These are defined as 
> {{ResourceConstants.USER_NAME}} and  {{ResourceConstants.PASSWORD}}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3395) Variable-ize product version and name in user guide

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133815#comment-16133815
 ] 

ASF subversion and git services commented on GEODE-3395:


Commit ed9a8fd47a56fa84b810f0e4c4261b299150d1de in geode's branch 
refs/heads/feature/GEODE-1279 from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=ed9a8fd ]

GEODE-3395 Variable-ize product version and name in user guide - Developing


>  Variable-ize product version and name in user guide
> 
>
> Key: GEODE-3395
> URL: https://issues.apache.org/jira/browse/GEODE-3395
> Project: Geode
>  Issue Type: New Feature
>  Components: docs
>Reporter: Dave Barnes
>Assignee: Dave Barnes
>
> The Guide contains many occurrences of the product version string ("1.2", 
> "1.1", and "1.0-incubating" are recent examples) scattered over about 900 
> files.  It would be a great convenience to those who write and edit these 
> files to define the version number symbolically so it could be updated in one 
> central location. A template variable in the book's config.yml file would be 
> an obvious candidate for the implementation.
> Similarly, it would be handy to provide symbolic identifiers for the product 
> name, long and short: "Apache Geode" and "Geode", respectively.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3434) Allow the modules to be interoperable with current and older versions of tomcat 7

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133813#comment-16133813
 ] 

ASF subversion and git services commented on GEODE-3434:


Commit f38dff9d217a8808117b6fbb2e5f4021ef9c84ce in geode's branch 
refs/heads/feature/GEODE-1279 from [~huynhja]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=f38dff9 ]

GEODE-3434: Allow the modules to be interoperable with current and older 
versions of tomcat 7

  * Modified DeltaSessions to use reflection to handle attributes fields incase 
an earlier tomcat 7 is used
  * Modified DeltaSession7 and DeltaSession8 to extend from DeltaSession
  * Added session backward compatibility tests
  * Modified aseembly build to download old product installs
  * Minor refactor of VersionManager to reuse property file load code


> Allow the modules to be interoperable with current and older versions of 
> tomcat 7 
> --
>
> Key: GEODE-3434
> URL: https://issues.apache.org/jira/browse/GEODE-3434
> Project: Geode
>  Issue Type: Bug
>  Components: http session
>Reporter: Jason Huynh
>Assignee: Jason Huynh
> Fix For: 1.3.0
>
>
> There was a change to the attribute field in tomcat (and we made the 
> necessary changes in geode session modules), but that does not allow our 
> session modules to work with older versions of tomcat 7.  We can probably 
> modify the classes to allow use with of the session module jars across 
> different versions of tomcat 7.
> We should probably add tests that run against older versions of geode to 
> allow backwards compatibility between a geode server and a session module jar 
> from a previous release.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3429) Deploy does not register Functions whose parent classes live in separate jar files

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133811#comment-16133811
 ] 

ASF subversion and git services commented on GEODE-3429:


Commit 1a67d46278ea519a1bfe185a7da11247e9771a4b in geode's branch 
refs/heads/feature/GEODE-1279 from [~jstewart]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=1a67d46 ]

Add test to expose GEODE-3429


> Deploy does not register Functions whose parent classes live in separate jar 
> files
> --
>
> Key: GEODE-3429
> URL: https://issues.apache.org/jira/browse/GEODE-3429
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, management
>Reporter: Jared Stewart
>Assignee: Jared Stewart
>
> Consider the following scenario: 
> Abstract.jar - public abstract class AbstractFunction implements Function 
> {...} 
> Concrete.jar - public class ConcreteFunction extends AbstractFunction {...}
> When Concrete.jar is deployed, we are not registering ConcreteFunction.  
> Everything works as expected if AbstractFunction and ConcreteFunction live in 
> the same jar. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3395) Variable-ize product version and name in user guide

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133816#comment-16133816
 ] 

ASF subversion and git services commented on GEODE-3395:


Commit 1c04aabb76b1e990899069fc864c8b96f8f63300 in geode's branch 
refs/heads/feature/GEODE-1279 from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=1c04aab ]

GEODE-3395 Variable-ize product version and name in user guide - Developing 
(top-level book file)


>  Variable-ize product version and name in user guide
> 
>
> Key: GEODE-3395
> URL: https://issues.apache.org/jira/browse/GEODE-3395
> Project: Geode
>  Issue Type: New Feature
>  Components: docs
>Reporter: Dave Barnes
>Assignee: Dave Barnes
>
> The Guide contains many occurrences of the product version string ("1.2", 
> "1.1", and "1.0-incubating" are recent examples) scattered over about 900 
> files.  It would be a great convenience to those who write and edit these 
> files to define the version number symbolically so it could be updated in one 
> central location. A template variable in the book's config.yml file would be 
> an obvious candidate for the implementation.
> Similarly, it would be handy to provide symbolic identifiers for the product 
> name, long and short: "Apache Geode" and "Geode", respectively.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3169) Decouple implementation of backups from DiskStore

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133814#comment-16133814
 ] 

ASF subversion and git services commented on GEODE-3169:


Commit 3bb6a2214d02fcb339ecba0d0645457d3926ab12 in geode's branch 
refs/heads/feature/GEODE-1279 from [~nreich]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=3bb6a22 ]

GEODE-3169: Decoupling of DiskStore and backups
This closes #715
  * move backup logic away from DiskStore and into BackupManager
  * refactor code into smaller methods
  * improve test code clarity


> Decouple implementation of backups from DiskStore
> -
>
> Key: GEODE-3169
> URL: https://issues.apache.org/jira/browse/GEODE-3169
> Project: Geode
>  Issue Type: Sub-task
>  Components: persistence
>Reporter: Nick Reich
>Assignee: Nick Reich
> Fix For: 1.3.0
>
>
> As a first step towards enabling expanded backup options (such pushing 
> backups to cloud storage), the logic for doing so needs to be decoupled from 
> DiskStore. This will allow for the eventual modular design of the backup 
> system and make future improvement easier to implement and test.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-1279) Tests for old TRAC bugs should be renamed to useful names

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133818#comment-16133818
 ] 

ASF subversion and git services commented on GEODE-1279:


Commit 23c4126a653fa6009a3c243fda6424d9427ae92c in geode's branch 
refs/heads/feature/GEODE-1279 from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=23c4126 ]

GEODE-1279: rename tests with old bug system numbers

* Bug34387DUnitTest -> CreateAndLocalDestroyInTXRegressionTest
* Bug35214DUnitTest -> EntriesDoNotExpireDuringGIIRegressionTest
* Bug38013DUnitTest -> RemotePRValuesAreNotDeserializedRegressionTest
* Bug34948DUnitTest -> ValuesAreLazilyDeserializedRegressionTest


> Tests for old TRAC bugs should be renamed to useful names
> -
>
> Key: GEODE-1279
> URL: https://issues.apache.org/jira/browse/GEODE-1279
> Project: Geode
>  Issue Type: Improvement
>  Components: tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> Examples:
> * Bug52289JUnitTest -> FinalStaticArrayShouldNotCauseSegFaultTest
> * Bug36619JUnitTest -> MembershipAttributesAreSerializableTest



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3444) Intermittent ClientServerJTADUnitTest failure

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133812#comment-16133812
 ] 

ASF subversion and git services commented on GEODE-3444:


Commit 04867000f8ad33b34947c35278ad944380ff5f95 in geode's branch 
refs/heads/feature/GEODE-1279 from [~eshu]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=0486700 ]

GEODE-3444: remove the redundant method calls.


> Intermittent ClientServerJTADUnitTest failure
> -
>
> Key: GEODE-3444
> URL: https://issues.apache.org/jira/browse/GEODE-3444
> Project: Geode
>  Issue Type: Bug
>  Components: transactions
>Reporter: Nick Reich
>Assignee: Eric Shu
> Fix For: 1.3.0
>
>
> A test in ClientServerJTADUnitTest is failing in an automated test pipeline. 
> I have tried to reproduce the issue locally, but was unsuccessful over five 
> attempts. The wait timeout suggests a possible race condition.
> {code}
> ```org.apache.geode.internal.jta.ClientServerJTADUnitTest > 
> testClientTXStateStubBeforeCompletion FAILED
> org.awaitility.core.ConditionTimeoutException: Condition with lambda 
> expression in org.apache.geode.internal.jta.ClientServerJTADUnitTest was not 
> fulfilled within 30 seconds.
> at 
> org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:104)
> at 
> org.awaitility.core.CallableCondition.await(CallableCondition.java:79)
> at 
> org.awaitility.core.CallableCondition.await(CallableCondition.java:27)
> at 
> org.awaitility.core.ConditionFactory.until(ConditionFactory.java:809)
> at 
> org.awaitility.core.ConditionFactory.until(ConditionFactory.java:785)
> at 
> org.apache.geode.internal.jta.ClientServerJTADUnitTest.testClientTXStateStubBeforeCompletion(ClientServerJTADUnitTest.java:104)```
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3235) Deploy jar does not register functions which extend FunctionAdapter

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133810#comment-16133810
 ] 

ASF subversion and git services commented on GEODE-3235:


Commit 64f33c3e456af775d7ee35b05a67f76cb3a23941 in geode's branch 
refs/heads/feature/GEODE-1279 from [~jstewart]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=64f33c3 ]

GEODE-3235: Deploy jar registers functions which extend FunctionAdapter


> Deploy jar does not register functions which extend FunctionAdapter
> ---
>
> Key: GEODE-3235
> URL: https://issues.apache.org/jira/browse/GEODE-3235
> Project: Geode
>  Issue Type: Bug
>  Components: functions, gfsh
>Affects Versions: 1.2.0
>Reporter: Jared Stewart
>Assignee: Jared Stewart
> Fix For: 1.3.0, 1.2.1
>
>
> Scanning a deployed jar to find its contained Functions work as expected when 
> the Functions directly implement the *Function* interface, but fails to find 
> them when the functions extend *FunctionAdapter* abstract class. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3469) LocatorLauncherLocalFileIntegrationTest.usesLocatorPortAsDefaultPort fails intermittently with IllegalArgumentException: Invalid pid '0' specified

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133808#comment-16133808
 ] 

ASF GitHub Bot commented on GEODE-3469:
---

Github user jaredjstewart commented on a diff in the pull request:

https://github.com/apache/geode/pull/724#discussion_r134075704
  
--- Diff: 
geode-core/src/test/java/org/apache/geode/internal/process/lang/AvailablePidTest.java
 ---
@@ -100,7 +105,53 @@ public void 
findAvailablePidsShouldReturnNoDuplicatedPids() throws Exception {
 assertThatNoPidIsDuplicated(availablePid.findAvailablePids(8));
   }
 
-  private void assertThatNoPidIsDuplicated(int[] pids) {
+  @Test(timeout = DEFAULT_TIMEOUT_MILLIS)
+  public void findAvailablePidShouldReturnGreaterThanOrEqualToLowerBound() 
throws Exception {
+availablePid = new AvailablePid(new AvailablePid.Bounds(1, 3));
+
+int pid = availablePid.findAvailablePid();
+
+assertThat(pid).isGreaterThanOrEqualTo(1);
--- End diff --

I wonder if trying random values for some time period (like the awaitility 
tests below) might be more robust:

```
availablePid = new AvailablePid(new AvailablePid.Bounds(1, 3));

com.google.common.base.Stopwatch stopwatch = Stopwatch.createStarted();
while (stopwatch.elapsed(TimeUnit.SECONDS) < 10) {
  int pid = availablePid.findAvailablePid();
  assertThat(pid).isLessThanOrEqualTo(3);
}


> LocatorLauncherLocalFileIntegrationTest.usesLocatorPortAsDefaultPort fails 
> intermittently with IllegalArgumentException: Invalid pid '0' specified
> --
>
> Key: GEODE-3469
> URL: https://issues.apache.org/jira/browse/GEODE-3469
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> {noformat}
> org.apache.geode.distributed.LocatorLauncherLocalFileIntegrationTest > 
> usesLocatorPortAsDefaultPort FAILED
> java.lang.IllegalArgumentException: Invalid pid '0' specified
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3469) LocatorLauncherLocalFileIntegrationTest.usesLocatorPortAsDefaultPort fails intermittently with IllegalArgumentException: Invalid pid '0' specified

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133807#comment-16133807
 ] 

ASF GitHub Bot commented on GEODE-3469:
---

Github user jaredjstewart commented on a diff in the pull request:

https://github.com/apache/geode/pull/724#discussion_r134075476
  
--- Diff: 
geode-core/src/test/java/org/apache/geode/internal/process/lang/AvailablePidTest.java
 ---
@@ -100,7 +105,53 @@ public void 
findAvailablePidsShouldReturnNoDuplicatedPids() throws Exception {
 assertThatNoPidIsDuplicated(availablePid.findAvailablePids(8));
   }
 
-  private void assertThatNoPidIsDuplicated(int[] pids) {
+  @Test(timeout = DEFAULT_TIMEOUT_MILLIS)
+  public void findAvailablePidShouldReturnGreaterThanOrEqualToLowerBound() 
throws Exception {
+availablePid = new AvailablePid(new AvailablePid.Bounds(1, 3));
+
+int pid = availablePid.findAvailablePid();
+
+assertThat(pid).isGreaterThanOrEqualTo(1);
+  }
+
+  @Test(timeout = DEFAULT_TIMEOUT_MILLIS)
+  public void findAvailablePidShouldReturnLessThanOrEqualToUpperBound() 
throws Exception {
+availablePid = new AvailablePid(new AvailablePid.Bounds(1, 3));
+
+int pid = availablePid.findAvailablePid();
+
+assertThat(pid).isLessThanOrEqualTo(3);
+  }
+
+  @Test
+  public void randomLowerBoundIsInclusive() throws Exception {
+availablePid = new AvailablePid(new AvailablePid.Bounds(1, 3));
+
+await().atMost(10, SECONDS).until(() -> 
assertThat(availablePid.random()).isEqualTo(1));
+  }
+
+  @Test
+  public void randomUpperBoundIsInclusive() throws Exception {
+availablePid = new AvailablePid(new AvailablePid.Bounds(1, 3));
+
+await().atMost(10, SECONDS).until(() -> 
assertThat(availablePid.random()).isEqualTo(3));
--- End diff --

This is a clever way to test that lower and upper bounds are potential 
output values!


> LocatorLauncherLocalFileIntegrationTest.usesLocatorPortAsDefaultPort fails 
> intermittently with IllegalArgumentException: Invalid pid '0' specified
> --
>
> Key: GEODE-3469
> URL: https://issues.apache.org/jira/browse/GEODE-3469
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> {noformat}
> org.apache.geode.distributed.LocatorLauncherLocalFileIntegrationTest > 
> usesLocatorPortAsDefaultPort FAILED
> java.lang.IllegalArgumentException: Invalid pid '0' specified
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3469) LocatorLauncherLocalFileIntegrationTest.usesLocatorPortAsDefaultPort fails intermittently with IllegalArgumentException: Invalid pid '0' specified

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133809#comment-16133809
 ] 

ASF GitHub Bot commented on GEODE-3469:
---

Github user jaredjstewart commented on a diff in the pull request:

https://github.com/apache/geode/pull/724#discussion_r134075750
  
--- Diff: 
geode-core/src/test/java/org/apache/geode/internal/process/lang/AvailablePid.java
 ---
@@ -30,37 +30,88 @@
  */
 public class AvailablePid {
 
-  static final int LOWER_BOUND = 1;
-  static final int UPPER_BOUND = 64000;
+  static final int DEFAULT_LOWER_BOUND = 1;
+  static final int DEFAULT_UPPER_BOUND = 64000;
   static final int DEFAULT_TIMEOUT_MILLIS = 60 * 1000;
 
+  private final int lowerBound;
+  private final int upperBound;
   private final Random random;
   private final int timeoutMillis;
 
   /**
-   * Construct with no seed and default timeout of 1 minute.
+   * Construct with:
+   * 
+   * default {@link Bounds} of {@link #DEFAULT_LOWER_BOUND} 
(inclusive) and
+   * {@link #DEFAULT_UPPER_BOUND} (inclusive)
+   * Random with no see
--- End diff --

I think you meant "no see**d**"


> LocatorLauncherLocalFileIntegrationTest.usesLocatorPortAsDefaultPort fails 
> intermittently with IllegalArgumentException: Invalid pid '0' specified
> --
>
> Key: GEODE-3469
> URL: https://issues.apache.org/jira/browse/GEODE-3469
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> {noformat}
> org.apache.geode.distributed.LocatorLauncherLocalFileIntegrationTest > 
> usesLocatorPortAsDefaultPort FAILED
> java.lang.IllegalArgumentException: Invalid pid '0' specified
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (GEODE-3474) ProtobufSimpleAuthenticator is incompatible with ExampleSecurityManager

[Galen O'Sullivan (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Galen O'Sullivan updated GEODE-3474:

Component/s: messaging

> ProtobufSimpleAuthenticator is incompatible with ExampleSecurityManager
> ---
>
> Key: GEODE-3474
> URL: https://issues.apache.org/jira/browse/GEODE-3474
> Project: Geode
>  Issue Type: Bug
>  Components: messaging
>Reporter: Galen O'Sullivan
>
> {{ProtobufSimpleAuthenticator}} uses the property names "username" and 
> password" to provide credentials, but {{ExampleSecurityManager}} uses 
> "security-username" and "security-password". I don't know the contract for 
> security managers in general, but these two should probably be able to talk 
> to one another.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (GEODE-3474) ProtobufSimpleAuthenticator is incompatible with ExampleSecurityManager

[Galen O'Sullivan (JIRA)]

Galen O'Sullivan created GEODE-3474:
---

 Summary: ProtobufSimpleAuthenticator is incompatible with 
ExampleSecurityManager
 Key: GEODE-3474
 URL: https://issues.apache.org/jira/browse/GEODE-3474
 Project: Geode
  Issue Type: Bug
Reporter: Galen O'Sullivan


{{ProtobufSimpleAuthenticator}} uses the property names "username" and 
password" to provide credentials, but {{ExampleSecurityManager}} uses 
"security-username" and "security-password". I don't know the contract for 
security managers in general, but these two should probably be able to talk to 
one another.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3470) Increase serial gateway sender token timeout

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133792#comment-16133792
 ] 

ASF GitHub Bot commented on GEODE-3470:
---

GitHub user boglesby opened a pull request:

https://github.com/apache/geode/pull/725

GEODE-3470: Increased serial gateway sender token timeout

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to d...@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/geode feature/GEODE-3470

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/725.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #725


commit af919311a37c374ef131d6388cf3d50ea410424a
Author: Barry Oglesby 
Date:   2017-08-18T23:41:26Z

GEODE-3470: Increased serial gateway sender token timeout




> Increase serial gateway sender token timeout
> 
>
> Key: GEODE-3470
> URL: https://issues.apache.org/jira/browse/GEODE-3470
> Project: Geode
>  Issue Type: Bug
>  Components: wan
>Reporter: Barry Oglesby
>Assignee: Barry Oglesby
>
> There have been cases where the default token timeout of 15 seconds is not 
> high enough. To increase it, set the default for the 
> {{AbstractGatewaySender.TOKEN_TIMEOUT}} static variable higher:
> {noformat}
> public static int TOKEN_TIMEOUT =
>   Integer.getInteger("GatewaySender.TOKEN_TIMEOUT", 15000).intValue();
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3470) Increase serial gateway sender token timeout

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133790#comment-16133790
 ] 

ASF subversion and git services commented on GEODE-3470:


Commit af919311a37c374ef131d6388cf3d50ea410424a in geode's branch 
refs/heads/feature/GEODE-3470 from [~barry.oglesby]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=af91931 ]

GEODE-3470: Increased serial gateway sender token timeout


> Increase serial gateway sender token timeout
> 
>
> Key: GEODE-3470
> URL: https://issues.apache.org/jira/browse/GEODE-3470
> Project: Geode
>  Issue Type: Bug
>  Components: wan
>Reporter: Barry Oglesby
>Assignee: Barry Oglesby
>
> There have been cases where the default token timeout of 15 seconds is not 
> high enough. To increase it, set the default for the 
> {{AbstractGatewaySender.TOKEN_TIMEOUT}} static variable higher:
> {noformat}
> public static int TOKEN_TIMEOUT =
>   Integer.getInteger("GatewaySender.TOKEN_TIMEOUT", 15000).intValue();
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (GEODE-3436) GFSH commands tests are failing after committing refactorings of command classes

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-3436:
-
Description: 
{noformat}
:geode-core:integrationTest

org.apache.geode.management.internal.cli.help.HelperIntegrationTest > 
testHelpWithNoInput FAILED
java.lang.AssertionError: 
Expected size:<2> but was:<4> in:
<["help (Available)",
"Display syntax and usage information for all commands or list all 
available commands if  isn't specified.",
"hint (Available)",
"Provide hints for a topic or list all available topics if "topic" 
isn't specified."]>
at 
org.apache.geode.management.internal.cli.help.HelperIntegrationTest.testHelpWithNoInput(HelperIntegrationTest.java:69)

org.apache.geode.management.internal.cli.help.HelperIntegrationTest > 
testHintWithNoInput FAILED
java.lang.AssertionError: 
Expected size:<21> but was:<22> in:
<["Hints are available for the following topics. Use "hint " 
for a specific hint.",
"",
"Client",
"Cluster Configuration",
"Configuration",
"Data",
"Debug-Utility",
"Disk Store",
"Function Execution",
"GFSH",
"Geode",
"Help",
"JMX",
"Lifecycle",
"Locator",
"Logs",
"Management-Monitoring",
"Manager",
"Region",
"Server",
"Statistics",
"WAN"]>
at 
org.apache.geode.management.internal.cli.help.HelperIntegrationTest.testHintWithNoInput(HelperIntegrationTest.java:96)

org.apache.geode.management.internal.cli.GfshParserConverterTest > 
testHintConverter FAILED
java.lang.StringIndexOutOfBoundsException: String index out of range: -1
at java.lang.String.substring(String.java:1931)
at 
org.apache.geode.management.internal.cli.GfshParser.lambda$completeAdvanced$0(GfshParser.java:265)
at java.util.ArrayList.replaceAll(ArrayList.java:1442)
at 
org.apache.geode.management.internal.cli.GfshParser.completeAdvanced(GfshParser.java:264)
at 
org.apache.geode.test.dunit.rules.GfshParserRule.complete(GfshParserRule.java:58)
at 
org.apache.geode.management.internal.cli.GfshParserConverterTest.testHintConverter(GfshParserConverterTest.java:126)

org.apache.geode.management.internal.security.CliCommandsSecurityTest > 
testNoAccess FAILED
org.assertj.core.api.SoftAssertionError: 
The following assertion failed:
1) [destroy function --id=InterestCalculations] 
Expecting:
 <"stranger not authorized for CLUSTER:MANAGE:JAR">
to contain:
 <"DATA:MANAGE"> 
at CliCommandsSecurityTest.testNoAccess(CliCommandsSecurityTest.java:74)
at 
org.assertj.core.api.SoftAssertions.assertAll(SoftAssertions.java:134)
at 
org.apache.geode.management.internal.security.CliCommandsSecurityTest.testNoAccess(CliCommandsSecurityTest.java:78)

org.apache.geode.management.internal.security.GfshCommandsSecurityTest > 
testRegionAReader FAILED
org.junit.ComparisonFailure: [destroy function --id=InterestCalculations] 
expected:<[110]> but was:<[415]>
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at 
sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
at 
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at 
org.apache.geode.management.internal.security.GfshCommandsSecurityTest.runCommandsPermittedAndForbiddenBy(GfshCommandsSecurityTest.java:164)
at 
org.apache.geode.management.internal.security.GfshCommandsSecurityTest.testRegionAReader(GfshCommandsSecurityTest.java:108)

org.apache.geode.management.internal.security.GfshCommandsSecurityTest > 
testRegionAWriter FAILED
org.junit.ComparisonFailure: [destroy function --id=InterestCalculations] 
expected:<[110]> but was:<[415]>
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at 
sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
at 
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at 
org.apache.geode.management.internal.security.GfshCommandsSecurityTest.runCommandsPermittedAndForbiddenBy(GfshCommandsSecurityTest.java:164)
at 
org.apache.geode.management.internal.security.GfshCommandsSecurityTest.testRegionAWriter(GfshCommandsSecurityTest.java:114)

org.apache.geode.management.internal.security.GfshCommandsSecurityTest > 
testClusterReader FAILED
org.junit.ComparisonFailure: [destroy function --id=InterestCalculations] 
expected:<[110]> but was:<[415]>
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at 
sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
at 

[jira] [Commented] (GEODE-3469) LocatorLauncherLocalFileIntegrationTest.usesLocatorPortAsDefaultPort fails intermittently with IllegalArgumentException: Invalid pid '0' specified

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133766#comment-16133766
 ] 

ASF GitHub Bot commented on GEODE-3469:
---

GitHub user kirklund opened a pull request:

https://github.com/apache/geode/pull/724

GEODE-3469: prevent zero pid from AvailablePid for tests



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kirklund/geode 
GEODE-3469-LocatorLauncherLocalFileIntegrationTest

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/724.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #724


commit 53b98edb1fb6340c9dfc5921317ee129fdcf4ff4
Author: Kirk Lund 
Date:   2017-08-18T21:33:25Z

GEODE-3469: prevent zero pid from AvailablePid for tests




> LocatorLauncherLocalFileIntegrationTest.usesLocatorPortAsDefaultPort fails 
> intermittently with IllegalArgumentException: Invalid pid '0' specified
> --
>
> Key: GEODE-3469
> URL: https://issues.apache.org/jira/browse/GEODE-3469
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> {noformat}
> org.apache.geode.distributed.LocatorLauncherLocalFileIntegrationTest > 
> usesLocatorPortAsDefaultPort FAILED
> java.lang.IllegalArgumentException: Invalid pid '0' specified
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3055) data mismatch caused by rebalance. waitUntilFlashed return false

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133763#comment-16133763
 ] 

ASF subversion and git services commented on GEODE-3055:


Commit d809076d01c28b9b819ab32d6af172004b3f8740 in geode's branch 
refs/heads/develop from zhouxh
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=d809076 ]

GEODE-3055: Should use a conservative fix to only catch the PartitionOfflineEx
to remove the leader region bucket.

Previous fix to catch all RuntimeException is too aggressive.

This closes #723


> data mismatch caused by rebalance. waitUntilFlashed return false
> 
>
> Key: GEODE-3055
> URL: https://issues.apache.org/jira/browse/GEODE-3055
> Project: Geode
>  Issue Type: Bug
>Reporter: xiaojian zhou
>Assignee: xiaojian zhou
>  Labels: lucene
> Fix For: 1.3.0
>
>
> /export/buglogs_bvt/xzhou/lucene/concParRegHAPersist-0601-171739
> lucene/concParRegHAPersist.conf
> A=accessor
> B=dataStore
> accessorHosts=1
> accessorThreadsPerVM=5
> accessorVMsPerHost=1
> dataStoreHosts=6
> dataStoreThreadsPerVM=5
> dataStoreVMsPerHost=1
> numVMsToStop=2
> redundantCopies=0
> no local.conf
> In dataStoregemfire5_7483/system.log, thread tid=0xdf, putAll Object_11066
> 17:22:27.135 tid=0xdf] generated tag {v1; rv13 shadowKey=2939
> 17:22:27.136 _partitionedRegionPARALLELGATEWAYSENDER_QUEUE_1 bucket : null // 
> brq is not ready yet
> is enqueued to the tempQueue
> 17:22:27.272 tid=0xdf] generated tag {v3; rv15 shadowKey=3278
> 17:22:33.111 Subregion created: 
> /_PR/_BAsyncEventQueueindex#partitionedRegionPARALLELGATEWAYSENDER_QUEUE_1
> vm_3_dataStore3_r02-s28_28143.log:
> 17:22:33.120 Put successfully in the queue shadowKey= 2939
> 17:22:33.156 tid=0x7fe started query
> 17:22:33.176 Peeked shadowKey= 2939
> So the root cause is: the event is still in tempQueue before it's processed, 
> the query happened. WaitUntilFlush should wait until tempQueue is also 
> flushed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3169) Decouple implementation of backups from DiskStore

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133755#comment-16133755
 ] 

ASF subversion and git services commented on GEODE-3169:


Commit 3bb6a2214d02fcb339ecba0d0645457d3926ab12 in geode's branch 
refs/heads/feature/GEM-1601 from [~nreich]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=3bb6a22 ]

GEODE-3169: Decoupling of DiskStore and backups
This closes #715
  * move backup logic away from DiskStore and into BackupManager
  * refactor code into smaller methods
  * improve test code clarity


> Decouple implementation of backups from DiskStore
> -
>
> Key: GEODE-3169
> URL: https://issues.apache.org/jira/browse/GEODE-3169
> Project: Geode
>  Issue Type: Sub-task
>  Components: persistence
>Reporter: Nick Reich
>Assignee: Nick Reich
> Fix For: 1.3.0
>
>
> As a first step towards enabling expanded backup options (such pushing 
> backups to cloud storage), the logic for doing so needs to be decoupled from 
> DiskStore. This will allow for the eventual modular design of the backup 
> system and make future improvement easier to implement and test.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3055) data mismatch caused by rebalance. waitUntilFlashed return false

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133758#comment-16133758
 ] 

ASF subversion and git services commented on GEODE-3055:


Commit 360c3d536fb12106645d9942546324fc446546fe in geode's branch 
refs/heads/feature/GEM-1601 from zhouxh
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=360c3d5 ]

GEODE-3055: Should use a conservative fix to only catch the PartitionOfflineEx
to remove the leader region bucket.

Previous fix to catch all RuntimeException is too aggressive.


> data mismatch caused by rebalance. waitUntilFlashed return false
> 
>
> Key: GEODE-3055
> URL: https://issues.apache.org/jira/browse/GEODE-3055
> Project: Geode
>  Issue Type: Bug
>Reporter: xiaojian zhou
>Assignee: xiaojian zhou
>  Labels: lucene
> Fix For: 1.3.0
>
>
> /export/buglogs_bvt/xzhou/lucene/concParRegHAPersist-0601-171739
> lucene/concParRegHAPersist.conf
> A=accessor
> B=dataStore
> accessorHosts=1
> accessorThreadsPerVM=5
> accessorVMsPerHost=1
> dataStoreHosts=6
> dataStoreThreadsPerVM=5
> dataStoreVMsPerHost=1
> numVMsToStop=2
> redundantCopies=0
> no local.conf
> In dataStoregemfire5_7483/system.log, thread tid=0xdf, putAll Object_11066
> 17:22:27.135 tid=0xdf] generated tag {v1; rv13 shadowKey=2939
> 17:22:27.136 _partitionedRegionPARALLELGATEWAYSENDER_QUEUE_1 bucket : null // 
> brq is not ready yet
> is enqueued to the tempQueue
> 17:22:27.272 tid=0xdf] generated tag {v3; rv15 shadowKey=3278
> 17:22:33.111 Subregion created: 
> /_PR/_BAsyncEventQueueindex#partitionedRegionPARALLELGATEWAYSENDER_QUEUE_1
> vm_3_dataStore3_r02-s28_28143.log:
> 17:22:33.120 Put successfully in the queue shadowKey= 2939
> 17:22:33.156 tid=0x7fe started query
> 17:22:33.176 Peeked shadowKey= 2939
> So the root cause is: the event is still in tempQueue before it's processed, 
> the query happened. WaitUntilFlush should wait until tempQueue is also 
> flushed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3395) Variable-ize product version and name in user guide

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133757#comment-16133757
 ] 

ASF subversion and git services commented on GEODE-3395:


Commit 1c04aabb76b1e990899069fc864c8b96f8f63300 in geode's branch 
refs/heads/feature/GEM-1601 from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=1c04aab ]

GEODE-3395 Variable-ize product version and name in user guide - Developing 
(top-level book file)


>  Variable-ize product version and name in user guide
> 
>
> Key: GEODE-3395
> URL: https://issues.apache.org/jira/browse/GEODE-3395
> Project: Geode
>  Issue Type: New Feature
>  Components: docs
>Reporter: Dave Barnes
>Assignee: Dave Barnes
>
> The Guide contains many occurrences of the product version string ("1.2", 
> "1.1", and "1.0-incubating" are recent examples) scattered over about 900 
> files.  It would be a great convenience to those who write and edit these 
> files to define the version number symbolically so it could be updated in one 
> central location. A template variable in the book's config.yml file would be 
> an obvious candidate for the implementation.
> Similarly, it would be handy to provide symbolic identifiers for the product 
> name, long and short: "Apache Geode" and "Geode", respectively.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3395) Variable-ize product version and name in user guide

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133756#comment-16133756
 ] 

ASF subversion and git services commented on GEODE-3395:


Commit ed9a8fd47a56fa84b810f0e4c4261b299150d1de in geode's branch 
refs/heads/feature/GEM-1601 from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=ed9a8fd ]

GEODE-3395 Variable-ize product version and name in user guide - Developing


>  Variable-ize product version and name in user guide
> 
>
> Key: GEODE-3395
> URL: https://issues.apache.org/jira/browse/GEODE-3395
> Project: Geode
>  Issue Type: New Feature
>  Components: docs
>Reporter: Dave Barnes
>Assignee: Dave Barnes
>
> The Guide contains many occurrences of the product version string ("1.2", 
> "1.1", and "1.0-incubating" are recent examples) scattered over about 900 
> files.  It would be a great convenience to those who write and edit these 
> files to define the version number symbolically so it could be updated in one 
> central location. A template variable in the book's config.yml file would be 
> an obvious candidate for the implementation.
> Similarly, it would be handy to provide symbolic identifiers for the product 
> name, long and short: "Apache Geode" and "Geode", respectively.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3395) Variable-ize product version and name in user guide

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133746#comment-16133746
 ] 

ASF subversion and git services commented on GEODE-3395:


Commit 1c04aabb76b1e990899069fc864c8b96f8f63300 in geode's branch 
refs/heads/develop from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=1c04aab ]

GEODE-3395 Variable-ize product version and name in user guide - Developing 
(top-level book file)


>  Variable-ize product version and name in user guide
> 
>
> Key: GEODE-3395
> URL: https://issues.apache.org/jira/browse/GEODE-3395
> Project: Geode
>  Issue Type: New Feature
>  Components: docs
>Reporter: Dave Barnes
>Assignee: Dave Barnes
>
> The Guide contains many occurrences of the product version string ("1.2", 
> "1.1", and "1.0-incubating" are recent examples) scattered over about 900 
> files.  It would be a great convenience to those who write and edit these 
> files to define the version number symbolically so it could be updated in one 
> central location. A template variable in the book's config.yml file would be 
> an obvious candidate for the implementation.
> Similarly, it would be handy to provide symbolic identifiers for the product 
> name, long and short: "Apache Geode" and "Geode", respectively.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3131) CI Failure: org.apache.geode.internal.cache.ha.HARQueueNewImplDUnitTest.testRefCountForNormalAndGIIPut

[Dan Smith (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133731#comment-16133731
 ] 

Dan Smith commented on GEODE-3131:
--

I'm still seeing this fail with f38dff9d217a8808117b6fbb2e5f4021ef9c84ce

> CI Failure: 
> org.apache.geode.internal.cache.ha.HARQueueNewImplDUnitTest.testRefCountForNormalAndGIIPut
> --
>
> Key: GEODE-3131
> URL: https://issues.apache.org/jira/browse/GEODE-3131
> Project: Geode
>  Issue Type: Bug
>  Components: client queues
>Affects Versions: 1.1.0
>Reporter: Jason Huynh
> Fix For: 1.3.0
>
>
> org.apache.geode.internal.cache.ha.HARQueueNewImplDUnitTest > 
> testRefCountForNormalAndGIIPut FAILED
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.internal.cache.ha.HARQueueNewImplDUnitTest$$Lambda$95/1198712296.run
>  in VM 1 running on Host 893875957fbb with 4 VMs
> at org.apache.geode.test.dunit.VM.invoke(VM.java:344)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:314)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:259)
> at 
> org.apache.geode.internal.cache.ha.HARQueueNewImplDUnitTest.testRefCountForNormalAndGIIPut(HARQueueNewImplDUnitTest.java:383)
> Caused by:
> java.lang.AssertionError: expected:<3> but was:<2>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:834)
> at org.junit.Assert.assertEquals(Assert.java:645)
> at org.junit.Assert.assertEquals(Assert.java:631)
> at 
> org.apache.geode.internal.cache.ha.HARQueueNewImplDUnitTest.verifyQueueData(HARQueueNewImplDUnitTest.java:1061)
> at 
> org.apache.geode.internal.cache.ha.HARQueueNewImplDUnitTest.lambda$testRefCountForNormalAndGIIPut$bb17a952$11(HARQueueNewImplDUnitTest.java:383)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (GEODE-3470) Increase serial gateway sender token timeout

[Barry Oglesby (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Barry Oglesby reassigned GEODE-3470:


Assignee: Barry Oglesby

> Increase serial gateway sender token timeout
> 
>
> Key: GEODE-3470
> URL: https://issues.apache.org/jira/browse/GEODE-3470
> Project: Geode
>  Issue Type: Bug
>  Components: wan
>Reporter: Barry Oglesby
>Assignee: Barry Oglesby
>
> There have been cases where the default token timeout of 15 seconds is not 
> high enough. To increase it, set the default for the 
> {{AbstractGatewaySender.TOKEN_TIMEOUT}} static variable higher:
> {noformat}
> public static int TOKEN_TIMEOUT =
>   Integer.getInteger("GatewaySender.TOKEN_TIMEOUT", 15000).intValue();
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (GEODE-3466) User Guide: Add WAN caveat to Delta Propagation section

[Dave Barnes (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Barnes resolved GEODE-3466.

   Resolution: Fixed
Fix Version/s: 1.3.0

> User Guide: Add WAN caveat to Delta Propagation section
> ---
>
> Key: GEODE-3466
> URL: https://issues.apache.org/jira/browse/GEODE-3466
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Dave Barnes
>Assignee: Dave Barnes
>Priority: Minor
> Fix For: 1.3.0
>
>
> On the "How Delta Propagation Works" page 
> (http://localhost:9292/docs/guide/12/developing/delta_propagation/how_delta_propagation_works.html)
>  under the "Supported Topologies and Limitations" topic, add a bullet point:
> - Multi-site (WAN). Gateway senders do not send Deltas. The full value is 
> always sent.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3406) Enable new flow for protocol on locators

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133701#comment-16133701
 ] 

ASF GitHub Bot commented on GEODE-3406:
---

Github user pivotal-amurmann commented on a diff in the pull request:

https://github.com/apache/geode/pull/716#discussion_r134066027
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/InvalidExecutionContextException.java
 ---
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+package org.apache.geode.internal.cache.tier.sockets;
--- End diff --

Where would be a better place for this? I am honestly just plain confused 
by the existing structure.


> Enable new flow for protocol on locators
> 
>
> Key: GEODE-3406
> URL: https://issues.apache.org/jira/browse/GEODE-3406
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server
>Reporter: Brian Baynes
>Assignee: Alexander Murmann
>
> Enable magic byte and new flow for new protocol on locators.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (GEODE-3473) Change new protocol package to use *internal* naming convention

[Brian Baynes (JIRA)]

Brian Baynes created GEODE-3473:
---

 Summary: Change new protocol package to use *internal* naming 
convention
 Key: GEODE-3473
 URL: https://issues.apache.org/jira/browse/GEODE-3473
 Project: Geode
  Issue Type: Improvement
  Components: client/server
Reporter: Brian Baynes


New protocol needs to follow established conventions for Geode APIs.
Change new protocol package to use *internal* naming convention.




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-2817) Have the function author determine what permissions the function execution requires

[Swapnil Bawaskar (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133695#comment-16133695
 ] 

Swapnil Bawaskar commented on GEODE-2817:
-

>From discussion on the mailing list, it seems that adding an annotation is a 
>popular choice. Something like:
{noformat}
​@RequiresPermission(resource = "user_profile", operation = "read")
public void execute(FunctionContext context) {
...
}
{noformat}

> Have the function author determine what permissions the function execution 
> requires
> ---
>
> Key: GEODE-2817
> URL: https://issues.apache.org/jira/browse/GEODE-2817
> Project: Geode
>  Issue Type: New Feature
>  Components: docs, security
>Reporter: Jinmei Liao
>
> Currently to execute a function, you will need "data:write" permission, but 
> it really depends on what the function is doing. So we should either:
> 1) externalize the authorize* api so that function author can use it in the 
> function.execute code to check authorization.
> 2) add a function api to tell the framework what permission this function 
> needs to execute, so that the framework will check the permission before 
> executing the function.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (GEODE-3472) Code Cleanup: remove dead code from /management.

[Patrick Rhomberg (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Rhomberg reassigned GEODE-3472:
---

Assignee: Patrick Rhomberg

> Code Cleanup: remove dead code from /management.
> 
>
> Key: GEODE-3472
> URL: https://issues.apache.org/jira/browse/GEODE-3472
> Project: Geode
>  Issue Type: Improvement
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>
> There is a great deal of dead, commented, and unused code in the codebase.  
> This ticket addresses some of it, limiting scope to those files in 
> `geode-core/**/management/**` to keep the eventual diff relatively small.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3055) data mismatch caused by rebalance. waitUntilFlashed return false

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133671#comment-16133671
 ] 

ASF subversion and git services commented on GEODE-3055:


Commit 291dac019f534af41470f0ee709c47477395d6fb in geode's branch 
refs/heads/feature/GEM-1601 from zhouxh
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=291dac0 ]

GEODE-3055: Should use a conservative fix to only catch the PartitionOfflineEx
to remove the leader region bucket.

Previous fix to catch all RuntimeException is too aggressive.


> data mismatch caused by rebalance. waitUntilFlashed return false
> 
>
> Key: GEODE-3055
> URL: https://issues.apache.org/jira/browse/GEODE-3055
> Project: Geode
>  Issue Type: Bug
>Reporter: xiaojian zhou
>Assignee: xiaojian zhou
>  Labels: lucene
> Fix For: 1.3.0
>
>
> /export/buglogs_bvt/xzhou/lucene/concParRegHAPersist-0601-171739
> lucene/concParRegHAPersist.conf
> A=accessor
> B=dataStore
> accessorHosts=1
> accessorThreadsPerVM=5
> accessorVMsPerHost=1
> dataStoreHosts=6
> dataStoreThreadsPerVM=5
> dataStoreVMsPerHost=1
> numVMsToStop=2
> redundantCopies=0
> no local.conf
> In dataStoregemfire5_7483/system.log, thread tid=0xdf, putAll Object_11066
> 17:22:27.135 tid=0xdf] generated tag {v1; rv13 shadowKey=2939
> 17:22:27.136 _partitionedRegionPARALLELGATEWAYSENDER_QUEUE_1 bucket : null // 
> brq is not ready yet
> is enqueued to the tempQueue
> 17:22:27.272 tid=0xdf] generated tag {v3; rv15 shadowKey=3278
> 17:22:33.111 Subregion created: 
> /_PR/_BAsyncEventQueueindex#partitionedRegionPARALLELGATEWAYSENDER_QUEUE_1
> vm_3_dataStore3_r02-s28_28143.log:
> 17:22:33.120 Put successfully in the queue shadowKey= 2939
> 17:22:33.156 tid=0x7fe started query
> 17:22:33.176 Peeked shadowKey= 2939
> So the root cause is: the event is still in tempQueue before it's processed, 
> the query happened. WaitUntilFlush should wait until tempQueue is also 
> flushed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (GEODE-3471) NPE in MBeanProxyFactory

[Jared Stewart (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jared Stewart reassigned GEODE-3471:


Assignee: Jared Stewart

> NPE in MBeanProxyFactory
> 
>
> Key: GEODE-3471
> URL: https://issues.apache.org/jira/browse/GEODE-3471
> Project: Geode
>  Issue Type: Bug
>Affects Versions: 1.2.0
>Reporter: Jared Stewart
>Assignee: Jared Stewart
>
> {noformat}
> java.lang.NullPointerException
> at 
> org.apache.geode.management.internal.MBeanProxyFactory.createProxy(MBeanProxyFactory.java:86)
> at 
> org.apache.geode.management.internal.MBeanProxyFactory.createAllProxies(MBeanProxyFactory.java:138)
> at 
> org.apache.geode.management.internal.FederatingManager$GIITask.call(FederatingManager.java:457)
> at 
> org.apache.geode.management.internal.FederatingManager$GIITask.call(FederatingManager.java:341)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (GEODE-3471) NPE in MBeanProxyFactory

[Jared Stewart (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jared Stewart updated GEODE-3471:
-
Affects Version/s: 1.2.0

> NPE in MBeanProxyFactory
> 
>
> Key: GEODE-3471
> URL: https://issues.apache.org/jira/browse/GEODE-3471
> Project: Geode
>  Issue Type: Bug
>Affects Versions: 1.2.0
>Reporter: Jared Stewart
>
> {noformat}
> java.lang.NullPointerException
> at 
> org.apache.geode.management.internal.MBeanProxyFactory.createProxy(MBeanProxyFactory.java:86)
> at 
> org.apache.geode.management.internal.MBeanProxyFactory.createAllProxies(MBeanProxyFactory.java:138)
> at 
> org.apache.geode.management.internal.FederatingManager$GIITask.call(FederatingManager.java:457)
> at 
> org.apache.geode.management.internal.FederatingManager$GIITask.call(FederatingManager.java:341)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (GEODE-3471) NPE in MBeanProxyFactory

[Jared Stewart (JIRA)]

Jared Stewart created GEODE-3471:


 Summary: NPE in MBeanProxyFactory
 Key: GEODE-3471
 URL: https://issues.apache.org/jira/browse/GEODE-3471
 Project: Geode
  Issue Type: Bug
Reporter: Jared Stewart


{noformat}
java.lang.NullPointerException
at 
org.apache.geode.management.internal.MBeanProxyFactory.createProxy(MBeanProxyFactory.java:86)
at 
org.apache.geode.management.internal.MBeanProxyFactory.createAllProxies(MBeanProxyFactory.java:138)
at 
org.apache.geode.management.internal.FederatingManager$GIITask.call(FederatingManager.java:457)
at 
org.apache.geode.management.internal.FederatingManager$GIITask.call(FederatingManager.java:341)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
{noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (GEODE-3290) Remove Dead Classes: FilterChain, LocalFilterChain, RemoteFilterChain

[Patrick Rhomberg (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Rhomberg reassigned GEODE-3290:
---

Assignee: Patrick Rhomberg

> Remove Dead Classes: FilterChain, LocalFilterChain, RemoteFilterChain
> -
>
> Key: GEODE-3290
> URL: https://issues.apache.org/jira/browse/GEODE-3290
> Project: Geode
>  Issue Type: Improvement
>  Components: general
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>
> `FilterChain` and its two extensions `LocalFilterChain` and 
> `RemoteFilterChain` are long-dead classes whose methods are one-line boolean 
> returns.  The invocation of these methods is misleading, resulting a multiple 
> code segments that are unreachable.
> These classes should be removed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (GEODE-3290) Remove Dead Classes: FilterChain, LocalFilterChain, RemoteFilterChain

[Patrick Rhomberg (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Rhomberg resolved GEODE-3290.
-
Resolution: Fixed

> Remove Dead Classes: FilterChain, LocalFilterChain, RemoteFilterChain
> -
>
> Key: GEODE-3290
> URL: https://issues.apache.org/jira/browse/GEODE-3290
> Project: Geode
>  Issue Type: Improvement
>  Components: general
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>
> `FilterChain` and its two extensions `LocalFilterChain` and 
> `RemoteFilterChain` are long-dead classes whose methods are one-line boolean 
> returns.  The invocation of these methods is misleading, resulting a multiple 
> code segments that are unreachable.
> These classes should be removed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (GEODE-3470) Increase serial gateway sender token timeout

[Barry Oglesby (JIRA)]

Barry Oglesby created GEODE-3470:


 Summary: Increase serial gateway sender token timeout
 Key: GEODE-3470
 URL: https://issues.apache.org/jira/browse/GEODE-3470
 Project: Geode
  Issue Type: Bug
  Components: wan
Reporter: Barry Oglesby


There have been cases where the default token timeout of 15 seconds is not high 
enough. To increase it, set the default for the 
{{AbstractGatewaySender.TOKEN_TIMEOUT}} static variable higher:
{noformat}
public static int TOKEN_TIMEOUT =
  Integer.getInteger("GatewaySender.TOKEN_TIMEOUT", 15000).intValue();
{noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3447) Implement client authorization for the new protocol

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133618#comment-16133618
 ] 

ASF GitHub Bot commented on GEODE-3447:
---

Github user kohlmu-pivotal commented on a diff in the pull request:

https://github.com/apache/geode/pull/719#discussion_r134050811
  
--- Diff: 
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufSimpleAuthenticator.java
 ---
@@ -40,20 +42,28 @@ public void receiveMessage(InputStream inputStream, 
OutputStream outputStream,
 properties.setProperty("username", 
authenticationRequest.getUsername());
 properties.setProperty("password", 
authenticationRequest.getPassword());
 
+authorizer = null; // authenticating a new user clears current 
authorizer
 try {
   Object principal = securityManager.authenticate(properties);
-  authenticated = principal != null;
+  if (principal != null) {
+authorizer = new ProtobufSimpleAuthorizer(principal, 
securityManager);
+  }
 } catch (AuthenticationFailedException e) {
-  authenticated = false;
+  authorizer = null;
 }
 
-
AuthenticationAPI.SimpleAuthenticationResponse.newBuilder().setAuthenticated(authenticated)
+
AuthenticationAPI.SimpleAuthenticationResponse.newBuilder().setAuthenticated(isAuthenticated())
 .build().writeDelimitedTo(outputStream);
   }
 
   @Override
   public boolean isAuthenticated() {
-return authenticated;
+return authorizer != null;
--- End diff --

I must disagree with this logic. Something is NOT `authenticated` just 
because there is an authorizer populated. A authorizer should be constructed 
BECAUSE something was `authenticated`


> Implement client authorization for the new protocol
> ---
>
> Key: GEODE-3447
> URL: https://issues.apache.org/jira/browse/GEODE-3447
> Project: Geode
>  Issue Type: New Feature
>  Components: client/server
>Reporter: Brian Baynes
>Assignee: Bruce Schuchardt
>
> As a user of the new client/server protocol, I need to make sure the clients 
> using the protocol to access my grid are authorized to perform each operation 
> they attempt.
> Implement client authorization for operations in new protocol based on 
> existing authorization configuration.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3447) Implement client authorization for the new protocol

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133616#comment-16133616
 ] 

ASF GitHub Bot commented on GEODE-3447:
---

Github user kohlmu-pivotal commented on a diff in the pull request:

https://github.com/apache/geode/pull/719#discussion_r134025383
  
--- Diff: 
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufSimpleAuthorizer.java
 ---
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+package org.apache.geode.protocol.protobuf;
+
+import java.io.EOFException;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.OutputStream;
+import java.util.Properties;
+
+import org.apache.geode.security.AuthenticationFailedException;
+import org.apache.geode.security.ResourcePermission;
+import org.apache.geode.security.SecurityManager;
+import org.apache.geode.security.StreamAuthenticator;
+import org.apache.geode.security.StreamAuthorizer;
+
+public class ProtobufSimpleAuthorizer implements StreamAuthorizer {
+  private final Object authenticatedPrincipal;
+  private final SecurityManager securityManager;
+
+  public ProtobufSimpleAuthorizer(Object authenticatedPrincipal, 
SecurityManager securityManager) {
+this.authenticatedPrincipal = authenticatedPrincipal;
+this.securityManager = securityManager;
+  }
+
+  @Override
+  public boolean authorize(ResourcePermission permissionRequested) {
--- End diff --

why would I not pass in the Principal and requested permissions? Then I can 
have 1 authorizer and not 1 per user.


> Implement client authorization for the new protocol
> ---
>
> Key: GEODE-3447
> URL: https://issues.apache.org/jira/browse/GEODE-3447
> Project: Geode
>  Issue Type: New Feature
>  Components: client/server
>Reporter: Brian Baynes
>Assignee: Bruce Schuchardt
>
> As a user of the new client/server protocol, I need to make sure the clients 
> using the protocol to access my grid are authorized to perform each operation 
> they attempt.
> Implement client authorization for operations in new protocol based on 
> existing authorization configuration.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3406) Enable new flow for protocol on locators

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133615#comment-16133615
 ] 

ASF GitHub Bot commented on GEODE-3406:
---

Github user kohlmu-pivotal commented on a diff in the pull request:

https://github.com/apache/geode/pull/716#discussion_r134053987
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/InvalidExecutionContextException.java
 ---
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+package org.apache.geode.internal.cache.tier.sockets;
--- End diff --

What does an ExecutionContext have to do with socket?


> Enable new flow for protocol on locators
> 
>
> Key: GEODE-3406
> URL: https://issues.apache.org/jira/browse/GEODE-3406
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server
>Reporter: Brian Baynes
>Assignee: Alexander Murmann
>
> Enable magic byte and new flow for new protocol on locators.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3406) Enable new flow for protocol on locators

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133607#comment-16133607
 ] 

ASF GitHub Bot commented on GEODE-3406:
---

Github user pivotal-amurmann commented on a diff in the pull request:

https://github.com/apache/geode/pull/716#discussion_r134053063
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/InvalidExecutionContextException.java
 ---
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+package org.apache.geode.internal.cache.tier.sockets;
--- End diff --

It gets thrown by the execution context which gets passed in from TcpServer 
and GenericProtocolServerConnection


> Enable new flow for protocol on locators
> 
>
> Key: GEODE-3406
> URL: https://issues.apache.org/jira/browse/GEODE-3406
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server
>Reporter: Brian Baynes
>Assignee: Alexander Murmann
>
> Enable magic byte and new flow for new protocol on locators.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (GEODE-3469) LocatorLauncherLocalFileIntegrationTest.usesLocatorPortAsDefaultPort fails intermittently with IllegalArgumentException: Invalid pid '0' specified

[Kirk Lund (JIRA)]

Kirk Lund created GEODE-3469:


 Summary: 
LocatorLauncherLocalFileIntegrationTest.usesLocatorPortAsDefaultPort fails 
intermittently with IllegalArgumentException: Invalid pid '0' specified
 Key: GEODE-3469
 URL: https://issues.apache.org/jira/browse/GEODE-3469
 Project: Geode
  Issue Type: Bug
  Components: gfsh, tests
Reporter: Kirk Lund


{noformat}
org.apache.geode.distributed.LocatorLauncherLocalFileIntegrationTest > 
usesLocatorPortAsDefaultPort FAILED
java.lang.IllegalArgumentException: Invalid pid '0' specified
{noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (GEODE-3469) LocatorLauncherLocalFileIntegrationTest.usesLocatorPortAsDefaultPort fails intermittently with IllegalArgumentException: Invalid pid '0' specified

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund reassigned GEODE-3469:


Assignee: Kirk Lund

> LocatorLauncherLocalFileIntegrationTest.usesLocatorPortAsDefaultPort fails 
> intermittently with IllegalArgumentException: Invalid pid '0' specified
> --
>
> Key: GEODE-3469
> URL: https://issues.apache.org/jira/browse/GEODE-3469
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> {noformat}
> org.apache.geode.distributed.LocatorLauncherLocalFileIntegrationTest > 
> usesLocatorPortAsDefaultPort FAILED
> java.lang.IllegalArgumentException: Invalid pid '0' specified
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (GEODE-3468) improve error message for an incomplete gfsh command

[Swapnil Bawaskar (JIRA)]

Swapnil Bawaskar created GEODE-3468:
---

 Summary: improve error message for an incomplete gfsh command
 Key: GEODE-3468
 URL: https://issues.apache.org/jira/browse/GEODE-3468
 Project: Geode
  Issue Type: Improvement
  Components: gfsh
Reporter: Swapnil Bawaskar


When a user types in a gfsh command that is missing some required parameters, 
in the error message we should only list the parameters that are required.

For example, we show the below exception:
{noformat}
gfsh>create gateway-sender --id=123
You should specify option (--group, --member, --remote-distributed-system-id, 
--parallel, --manual-start, --socket-buffer-size, --socket-read-timeout, 
--enable-batch-conflation, --batch-size, --batch-time-interval, 
--enable-persistence, --disk-store-name, --disk-synchronous, 
--maximum-queue-memory, --alert-threshold, --dispatcher-threads, 
--order-policy, --gateway-event-filter, --gateway-transport-filter) for this 
command
{noformat}
instead we should only have shown:
{noformat}
gfsh>create gateway-sender --id=123
You should specify option (--remote-distributed-system-id) for this command
{noformat}
since that is the only missing required parameter.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3184) Clean up session replication testing

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133587#comment-16133587
 ] 

ASF GitHub Bot commented on GEODE-3184:
---

GitHub user DivineEnder opened a pull request:

https://github.com/apache/geode/pull/722

GEODE-3184: Cleaned up Cargo tests

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to d...@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/DivineEnder/geode feature/GEODE-3184

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/722.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #722


commit b47c7fd5491bf4725005d4ea57aa6192df6176cc
Author: David Anuta 
Date:   2017-08-18T16:41:24Z

GEODE-3184: Cleaned up Cargo tests




> Clean up session replication testing
> 
>
> Key: GEODE-3184
> URL: https://issues.apache.org/jira/browse/GEODE-3184
> Project: Geode
>  Issue Type: Improvement
>  Components: http session
>Reporter: David Anuta
>Assignee: David Anuta
>Priority: Minor
>
> Would be good to review  the code base and make sure methods are properly 
> organized.
> Also, the previous session replication testing is still in place in the 
> extensions folder. This needs to be reviewed and any tests not covered by 
> cargo should be transferred over into the new cargo replication testing. An 
> example of something within this that needs to be cleaned up would be 
> QueryCommand and CommandServlet classes, which are both in the 
> extensions/geode-modules and extensions/session-testing-war projects. the 
> QueryCommand and Command Servlet class within the extensions/geode-modules 
> project could be removed if the previous session tests were all ported to 
> cargo and then removed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (GEODE-3467) gfsh help should display parameters ordered by "Required" field

[Swapnil Bawaskar (JIRA)]

Swapnil Bawaskar created GEODE-3467:
---

 Summary: gfsh help should display parameters ordered by "Required" 
field
 Key: GEODE-3467
 URL: https://issues.apache.org/jira/browse/GEODE-3467
 Project: Geode
  Issue Type: Improvement
  Components: gfsh
Reporter: Swapnil Bawaskar


It would be helpful to new users if we displayed all the required parameters 
followed by all the optional ones, so that users do have to look at all the 
parameters in the help text.
{noformat}
gfsh>help create gateway-sender
NAME
create gateway-sender
IS AVAILABLE
true
SYNOPSIS
Create the Gateway Sender on a member or members.
SYNTAX
create gateway-sender [--group=value(,value)*] [--member=value(,value)*] 
--id=value --remote-distributed-system-id=value [--parallel=value] 
[--manual-start=value]
[--socket-buffer-size=value] [--socket-read-timeout=value] 
[--enable-batch-conflation=value] [--batch-size=value] 
[--batch-time-interval=value] [--enable-persistence=value]
[--disk-store-name=value] [--disk-synchronous=value] 
[--maximum-queue-memory=value] [--alert-threshold=value] 
[--dispatcher-threads=value] [--order-policy=value]
[--gateway-event-filter=value(,value)*] 
[--gateway-transport-filter=value(,value)*]
PARAMETERS
group
Group(s) of members on which to create the Gateway Sender.
Synonyms: groups
Required: false
member
Name/Id of the member on which to create the Gateway Sender.
Synonyms: members
Required: false
id
Id of the GatewaySender.
Required: true
remote-distributed-system-id
Id of the remote distributed system to which the sender will send 
events.
Required: true
parallel
Whether this is Parallel GatewaySender.
Required: false
{noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3448) Complete and expose parallel snapshot importing feature

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133470#comment-16133470
 ] 

ASF GitHub Bot commented on GEODE-3448:
---

GitHub user nreich opened a pull request:

https://github.com/apache/geode/pull/721

GEODE-3448: Implement and expose parallel snapshot import

Tests showed that allowing the parallel import of snapshot files (from 
parallel export) scales nearly linearly, greatly increasing performance when 
importing snapshots as cluster size increases. Using it requires specifying a 
directory, which must be the same on all nodes that have files that need 
importing. All snapshot .gfd files in those directories will be loaded into the 
cluster.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nreich/geode feature/GEODE-3448

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/721.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #721


commit 85d7b54627b59e75c7c08bce1d6feef7e565ea10
Author: Nick Reich 
Date:   2017-08-17T23:29:45Z

GEODE-3448: Implement and expose parallel snapshot import




> Complete and expose parallel snapshot importing feature
> ---
>
> Key: GEODE-3448
> URL: https://issues.apache.org/jira/browse/GEODE-3448
> Project: Geode
>  Issue Type: Sub-task
>  Components: snapshot
>Reporter: Nick Reich
>Assignee: Nick Reich
>
> Tests have suggested that parallelizing the importing of a snapshot (using 
> the multiple files created in a parallel export) has significant advantages 
> as the cluster increased in size. The ability to do this conveniently 
> (instead of running an import manually on each member of the cluster) should 
> be exposed.
> The implementation will assume that each member of the cluster has the 
> specified directory locally available (or at least every member where there 
> is data that needs import). However, this means that it will not be possible 
> to do a parallel import directly from a shared network disk: if we require 
> such functionality, a flag will need to be added to indicate the use of a 
> shared location, otherwise, all data will be imported by each member, rather 
> than just once.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (GEODE-3466) User Guide: Add WAN caveat to Delta Propagation section

[Dave Barnes (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Barnes reassigned GEODE-3466:
--

Assignee: Dave Barnes

> User Guide: Add WAN caveat to Delta Propagation section
> ---
>
> Key: GEODE-3466
> URL: https://issues.apache.org/jira/browse/GEODE-3466
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Dave Barnes
>Assignee: Dave Barnes
>Priority: Minor
>
> On the "How Delta Propagation Works" page 
> (http://localhost:9292/docs/guide/12/developing/delta_propagation/how_delta_propagation_works.html)
>  under the "Supported Topologies and Limitations" topic, add a bullet point:
> - Multi-site (WAN). Gateway senders do not send Deltas. The full value is 
> always sent.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (GEODE-3466) User Guide: Add WAN caveat to Delta Propagation section

[Dave Barnes (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Barnes updated GEODE-3466:
---
Priority: Minor  (was: Major)

> User Guide: Add WAN caveat to Delta Propagation section
> ---
>
> Key: GEODE-3466
> URL: https://issues.apache.org/jira/browse/GEODE-3466
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Dave Barnes
>Priority: Minor
>
> On the "How Delta Propagation Works" page 
> (http://localhost:9292/docs/guide/12/developing/delta_propagation/how_delta_propagation_works.html)
>  under the "Supported Topologies and Limitations" topic, add a bullet point:
> - Multi-site (WAN). Gateway senders do not send Deltas. The full value is 
> always sent.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (GEODE-3466) User Guide: Add WAN caveat to Delta Propagation section

[Dave Barnes (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Barnes updated GEODE-3466:
---
Summary: User Guide: Add WAN caveat to Delta Propagation section  (was: 
User Guid: Add WAN caveat to Delta Propagation section)

> User Guide: Add WAN caveat to Delta Propagation section
> ---
>
> Key: GEODE-3466
> URL: https://issues.apache.org/jira/browse/GEODE-3466
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Dave Barnes
>
> On the "How Delta Propagation Works" page 
> (http://localhost:9292/docs/guide/12/developing/delta_propagation/how_delta_propagation_works.html)
>  under the "Supported Topologies and Limitations" topic, add a bullet point:
> - Multi-site (WAN). Gateway senders do not send Deltas. The full value is 
> always sent.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (GEODE-3466) User Guid: Add WAN caveat to Delta Propagation section

[Dave Barnes (JIRA)]

Dave Barnes created GEODE-3466:
--

 Summary: User Guid: Add WAN caveat to Delta Propagation section
 Key: GEODE-3466
 URL: https://issues.apache.org/jira/browse/GEODE-3466
 Project: Geode
  Issue Type: Improvement
  Components: docs
Reporter: Dave Barnes


On the "How Delta Propagation Works" page 
(http://localhost:9292/docs/guide/12/developing/delta_propagation/how_delta_propagation_works.html)
 under the "Supported Topologies and Limitations" topic, add a bullet point:

- Multi-site (WAN). Gateway senders do not send Deltas. The full value is 
always sent.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (GEODE-3235) Deploy jar does not register functions which extend FunctionAdapter

[Jared Stewart (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jared Stewart updated GEODE-3235:
-
Fix Version/s: 1.3.0

> Deploy jar does not register functions which extend FunctionAdapter
> ---
>
> Key: GEODE-3235
> URL: https://issues.apache.org/jira/browse/GEODE-3235
> Project: Geode
>  Issue Type: Bug
>  Components: functions, gfsh
>Affects Versions: 1.2.0
>Reporter: Jared Stewart
>Assignee: Jared Stewart
> Fix For: 1.3.0, 1.2.1
>
>
> Scanning a deployed jar to find its contained Functions work as expected when 
> the Functions directly implement the *Function* interface, but fails to find 
> them when the functions extend *FunctionAdapter* abstract class. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3406) Enable new flow for protocol on locators

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133382#comment-16133382
 ] 

ASF GitHub Bot commented on GEODE-3406:
---

Github user galen-pivotal commented on a diff in the pull request:

https://github.com/apache/geode/pull/716#discussion_r134021675
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpServer.java
 ---
@@ -334,107 +351,109 @@ protected void run() {
* fix for bug 33711 - client requests are spun off to another thread 
for processing. Requests are
* synchronized in processGossip.
*/
-  private void processRequest(final Socket sock) {
+  private void processRequest(final Socket socket) {
 executor.execute(() -> {
   long startTime = DistributionStats.getStatTime();
   DataInputStream input = null;
   Object request, response;
   try {
 
-sock.setSoTimeout(READ_TIMEOUT);
-getSocketCreator().configureServerSSLSocket(sock);
+socket.setSoTimeout(READ_TIMEOUT);
+getSocketCreator().configureServerSSLSocket(socket);
 
 try {
-  input = new DataInputStream(sock.getInputStream());
+  input = new DataInputStream(socket.getInputStream());
 } catch (StreamCorruptedException e) {
   // Some garbage can be left on the socket stream
   // if a peer disappears at exactly the wrong moment.
   log.debug("Discarding illegal request from "
-  + (sock.getInetAddress().getHostAddress() + ":" + 
sock.getPort()), e);
+  + (socket.getInetAddress().getHostAddress() + ":" + 
socket.getPort()), e);
   return;
 }
-int gossipVersion = readGossipVersion(sock, input);
+int gossipVersion = readGossipVersion(socket, input);
 
 short versionOrdinal;
-if (gossipVersion <= getCurrentGossipVersion()
-&& GOSSIP_TO_GEMFIRE_VERSION_MAP.containsKey(gossipVersion)) {
-  // Create a versioned stream to remember sender's GemFire version
-  versionOrdinal = (short) 
GOSSIP_TO_GEMFIRE_VERSION_MAP.get(gossipVersion);
-} else {
-  // Close the socket. We can not accept requests from a newer 
version
-  try {
-sock.getOutputStream().write("unknown protocol 
version".getBytes());
-sock.getOutputStream().flush();
-  } catch (IOException e) {
-log.debug(
-"exception in sending reply to process using unknown 
protocol " + gossipVersion, e);
+if (gossipVersion == NON_GOSSIP_REQUEST_VERSION) {
+  if (input.readUnsignedByte() == PROTOBUF_CLIENT_SERVER_PROTOCOL
+  && Boolean.getBoolean("geode.feature-protobuf-protocol")) {
+messageHandler.receiveMessage(input, socket.getOutputStream(),
+new MessageExecutionContext(internalLocator));
+  } else {
+rejectUnknownProtocolConnection(socket, gossipVersion);
   }
-  sock.close();
-  return;
-}
-if (Version.GFE_71.compareTo(versionOrdinal) <= 0) {
-  // Recent versions of TcpClient will send the version ordinal
-  versionOrdinal = input.readShort();
-}
-
-if (log.isDebugEnabled() && versionOrdinal != 
Version.CURRENT_ORDINAL) {
-  log.debug("Locator reading request from " + 
sock.getInetAddress() + " with version "
-  + Version.fromOrdinal(versionOrdinal, false));
-}
-input = new VersionedDataInputStream(input, 
Version.fromOrdinal(versionOrdinal, false));
-request = DataSerializer.readObject(input);
-if (log.isDebugEnabled()) {
-  log.debug("Locator received request " + request + " from " + 
sock.getInetAddress());
-}
-if (request instanceof ShutdownRequest) {
-  shuttingDown = true;
-  // Don't call shutdown from within the worker thread, see java 
bug #6576792.
-  // Closing the socket will cause our acceptor thread to shutdown 
the executor
-  this.serverSocketPortAtClose = srv_sock.getLocalPort();
-  srv_sock.close();
-  response = new ShutdownResponse();
-} else if (request instanceof InfoRequest) {
-  response = handleInfoRequest(request);
-} else if (request instanceof VersionRequest) {
-  response = handleVersionRequest(request);
 } else {
-  response = handler.processRequest(request);
-}
-
-handler.endRequest(request, startTime);
+  if (gossipVersion <= 

[jira] [Commented] (GEODE-3406) Enable new flow for protocol on locators

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133380#comment-16133380
 ] 

ASF GitHub Bot commented on GEODE-3406:
---

Github user galen-pivotal commented on a diff in the pull request:

https://github.com/apache/geode/pull/716#discussion_r134021523
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpServer.java
 ---
@@ -334,107 +351,109 @@ protected void run() {
* fix for bug 33711 - client requests are spun off to another thread 
for processing. Requests are
* synchronized in processGossip.
*/
-  private void processRequest(final Socket sock) {
+  private void processRequest(final Socket socket) {
 executor.execute(() -> {
   long startTime = DistributionStats.getStatTime();
   DataInputStream input = null;
   Object request, response;
   try {
 
-sock.setSoTimeout(READ_TIMEOUT);
-getSocketCreator().configureServerSSLSocket(sock);
+socket.setSoTimeout(READ_TIMEOUT);
+getSocketCreator().configureServerSSLSocket(socket);
 
 try {
-  input = new DataInputStream(sock.getInputStream());
+  input = new DataInputStream(socket.getInputStream());
 } catch (StreamCorruptedException e) {
   // Some garbage can be left on the socket stream
   // if a peer disappears at exactly the wrong moment.
   log.debug("Discarding illegal request from "
-  + (sock.getInetAddress().getHostAddress() + ":" + 
sock.getPort()), e);
+  + (socket.getInetAddress().getHostAddress() + ":" + 
socket.getPort()), e);
   return;
 }
-int gossipVersion = readGossipVersion(sock, input);
+int gossipVersion = readGossipVersion(socket, input);
 
 short versionOrdinal;
-if (gossipVersion <= getCurrentGossipVersion()
-&& GOSSIP_TO_GEMFIRE_VERSION_MAP.containsKey(gossipVersion)) {
-  // Create a versioned stream to remember sender's GemFire version
-  versionOrdinal = (short) 
GOSSIP_TO_GEMFIRE_VERSION_MAP.get(gossipVersion);
-} else {
-  // Close the socket. We can not accept requests from a newer 
version
-  try {
-sock.getOutputStream().write("unknown protocol 
version".getBytes());
-sock.getOutputStream().flush();
-  } catch (IOException e) {
-log.debug(
-"exception in sending reply to process using unknown 
protocol " + gossipVersion, e);
+if (gossipVersion == NON_GOSSIP_REQUEST_VERSION) {
+  if (input.readUnsignedByte() == PROTOBUF_CLIENT_SERVER_PROTOCOL
+  && Boolean.getBoolean("geode.feature-protobuf-protocol")) {
+messageHandler.receiveMessage(input, socket.getOutputStream(),
+new MessageExecutionContext(internalLocator));
+  } else {
+rejectUnknownProtocolConnection(socket, gossipVersion);
   }
-  sock.close();
-  return;
-}
-if (Version.GFE_71.compareTo(versionOrdinal) <= 0) {
-  // Recent versions of TcpClient will send the version ordinal
-  versionOrdinal = input.readShort();
-}
-
-if (log.isDebugEnabled() && versionOrdinal != 
Version.CURRENT_ORDINAL) {
-  log.debug("Locator reading request from " + 
sock.getInetAddress() + " with version "
-  + Version.fromOrdinal(versionOrdinal, false));
-}
-input = new VersionedDataInputStream(input, 
Version.fromOrdinal(versionOrdinal, false));
-request = DataSerializer.readObject(input);
-if (log.isDebugEnabled()) {
-  log.debug("Locator received request " + request + " from " + 
sock.getInetAddress());
-}
-if (request instanceof ShutdownRequest) {
-  shuttingDown = true;
-  // Don't call shutdown from within the worker thread, see java 
bug #6576792.
-  // Closing the socket will cause our acceptor thread to shutdown 
the executor
-  this.serverSocketPortAtClose = srv_sock.getLocalPort();
-  srv_sock.close();
-  response = new ShutdownResponse();
-} else if (request instanceof InfoRequest) {
-  response = handleInfoRequest(request);
-} else if (request instanceof VersionRequest) {
-  response = handleVersionRequest(request);
 } else {
-  response = handler.processRequest(request);
-}
-
-handler.endRequest(request, startTime);
+  if (gossipVersion <= 

[jira] [Created] (GEODE-3465) GetAvailableServerRequest on Locator accepts group

[Alexander Murmann (JIRA)]

Alexander Murmann created GEODE-3465:


 Summary: GetAvailableServerRequest on Locator accepts group
 Key: GEODE-3465
 URL: https://issues.apache.org/jira/browse/GEODE-3465
 Project: Geode
  Issue Type: New Feature
  Components: client/server
Reporter: Alexander Murmann


The user should be able to specify a group for which the want to receive a list 
of available servers from the locator.

Acceptance Criteria:
When making a ProtoBuf request to the locator I can pass a group to the 
available server's method
Then I receive back only servers from that group



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3395) Variable-ize product version and name in user guide

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1618#comment-1618
 ] 

ASF subversion and git services commented on GEODE-3395:


Commit ed9a8fd47a56fa84b810f0e4c4261b299150d1de in geode's branch 
refs/heads/develop from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=ed9a8fd ]

GEODE-3395 Variable-ize product version and name in user guide - Developing


>  Variable-ize product version and name in user guide
> 
>
> Key: GEODE-3395
> URL: https://issues.apache.org/jira/browse/GEODE-3395
> Project: Geode
>  Issue Type: New Feature
>  Components: docs
>Reporter: Dave Barnes
>Assignee: Dave Barnes
>
> The Guide contains many occurrences of the product version string ("1.2", 
> "1.1", and "1.0-incubating" are recent examples) scattered over about 900 
> files.  It would be a great convenience to those who write and edit these 
> files to define the version number symbolically so it could be updated in one 
> central location. A template variable in the book's config.yml file would be 
> an obvious candidate for the implementation.
> Similarly, it would be handy to provide symbolic identifiers for the product 
> name, long and short: "Apache Geode" and "Geode", respectively.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (GEODE-3464) If multiple MessageHandlers are found user should see exception

[Alexander Murmann (JIRA)]

Alexander Murmann created GEODE-3464:


 Summary: If multiple MessageHandlers are found user should see 
exception
 Key: GEODE-3464
 URL: https://issues.apache.org/jira/browse/GEODE-3464
 Project: Geode
  Issue Type: New Feature
  Components: client/server
Reporter: Alexander Murmann


Currently the system will use the first MessageHandler it finds. If there are 
multiple it's unclear which one will be used, resulting in potentially 
nondeterministic behavior. Instead a exception should be thrown if multiple 
handlers are present. That behavior is still not ideal, but at least it's 
deterministic.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (GEODE-3463) Ensure ProtoBuf requests are tracked propery

[Alexander Murmann (JIRA)]

Alexander Murmann created GEODE-3463:


 Summary: Ensure ProtoBuf requests are tracked propery
 Key: GEODE-3463
 URL: https://issues.apache.org/jira/browse/GEODE-3463
 Project: Geode
  Issue Type: New Feature
  Components: client/server
Reporter: Alexander Murmann


ProtoBuf requests should be tracked like all other requests on the locator. I 
should be able to see the same usage statistics as I can see for all other 
requests.

Implementation Note: 
It's not entirely clear what is currently being gathered. This seems to be done 
via TcpHandler in TcpServer. We need to find out what it's doing and how to use 
it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (GEODE-3382) CI Failure: ClientHealthStatsDUnitTesttestClientHealthStats_SubscriptionDisabled

[Jared Stewart (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jared Stewart updated GEODE-3382:
-
Description: 
{noformat}
org.apache.geode.test.dunit.RMIException: While invoking 
org.apache.geode.management.ClientHealthStatsDUnitTest$$Lambda$33/422336689.run 
in VM 0 running on Host cb1ab49db437 with 4 VMs
at org.apache.geode.test.dunit.VM.invoke(VM.java:387)
at org.apache.geode.test.dunit.VM.invoke(VM.java:357)
at org.apache.geode.test.dunit.VM.invoke(VM.java:302)
at 
org.apache.geode.management.ClientHealthStatsDUnitTest.testClientHealthStats_SubscriptionDisabled(ClientHealthStatsDUnitTest.java:136)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at 
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at 
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at 
org.apache.geode.management.ManagementTestRule$2.evaluate(ManagementTestRule.java:86)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at 
org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
at 
org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
at 
org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
at 
org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
at 
org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
at 
org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
at 
org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
at 
org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
at 
org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
at 
org.gradle.internal.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:377)
at 
org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:54)
at 
org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:40)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.AssertionError: 
Expected size:<2> but was:<1> in:

[jira] [Commented] (GEODE-3406) Enable new flow for protocol on locators

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133284#comment-16133284
 ] 

ASF GitHub Bot commented on GEODE-3406:
---

Github user kohlmu-pivotal commented on a diff in the pull request:

https://github.com/apache/geode/pull/716#discussion_r134007044
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ExecutionContext.java
 ---
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+
+package org.apache.geode.internal.cache.tier.sockets;
+
+import org.apache.geode.cache.Cache;
+import org.apache.geode.distributed.internal.InternalLocator;
+
+public class ExecutionContext {
+  private Cache cache;
+  private InternalLocator locator;
--- End diff --

I think we should deal with the `Locator` interface rather than the 
concrete implementation


> Enable new flow for protocol on locators
> 
>
> Key: GEODE-3406
> URL: https://issues.apache.org/jira/browse/GEODE-3406
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server
>Reporter: Brian Baynes
>Assignee: Alexander Murmann
>
> Enable magic byte and new flow for new protocol on locators.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3406) Enable new flow for protocol on locators

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133286#comment-16133286
 ] 

ASF GitHub Bot commented on GEODE-3406:
---

Github user kohlmu-pivotal commented on a diff in the pull request:

https://github.com/apache/geode/pull/716#discussion_r134007487
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ExecutionContext.java
 ---
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+
+package org.apache.geode.internal.cache.tier.sockets;
--- End diff --

Is this class maybe in the wrong package?


> Enable new flow for protocol on locators
> 
>
> Key: GEODE-3406
> URL: https://issues.apache.org/jira/browse/GEODE-3406
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server
>Reporter: Brian Baynes
>Assignee: Alexander Murmann
>
> Enable magic byte and new flow for new protocol on locators.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3406) Enable new flow for protocol on locators

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133285#comment-16133285
 ] 

ASF GitHub Bot commented on GEODE-3406:
---

Github user kohlmu-pivotal commented on a diff in the pull request:

https://github.com/apache/geode/pull/716#discussion_r134007584
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/InvalidExecutionContextException.java
 ---
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+package org.apache.geode.internal.cache.tier.sockets;
--- End diff --

Is this class in the wrong package?


> Enable new flow for protocol on locators
> 
>
> Key: GEODE-3406
> URL: https://issues.apache.org/jira/browse/GEODE-3406
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server
>Reporter: Brian Baynes
>Assignee: Alexander Murmann
>
> Enable magic byte and new flow for new protocol on locators.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (GEODE-3169) Decouple implementation of backups from DiskStore

[Nick Reich (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nick Reich resolved GEODE-3169.
---
Resolution: Fixed

> Decouple implementation of backups from DiskStore
> -
>
> Key: GEODE-3169
> URL: https://issues.apache.org/jira/browse/GEODE-3169
> Project: Geode
>  Issue Type: Sub-task
>  Components: persistence
>Reporter: Nick Reich
>Assignee: Nick Reich
> Fix For: 1.3.0
>
>
> As a first step towards enabling expanded backup options (such pushing 
> backups to cloud storage), the logic for doing so needs to be decoupled from 
> DiskStore. This will allow for the eventual modular design of the backup 
> system and make future improvement easier to implement and test.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (GEODE-3169) Decouple implementation of backups from DiskStore

[Nick Reich (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nick Reich updated GEODE-3169:
--
Fix Version/s: 1.3.0

> Decouple implementation of backups from DiskStore
> -
>
> Key: GEODE-3169
> URL: https://issues.apache.org/jira/browse/GEODE-3169
> Project: Geode
>  Issue Type: Sub-task
>  Components: persistence
>Reporter: Nick Reich
>Assignee: Nick Reich
> Fix For: 1.3.0
>
>
> As a first step towards enabling expanded backup options (such pushing 
> backups to cloud storage), the logic for doing so needs to be decoupled from 
> DiskStore. This will allow for the eventual modular design of the backup 
> system and make future improvement easier to implement and test.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3169) Decouple implementation of backups from DiskStore

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133260#comment-16133260
 ] 

ASF subversion and git services commented on GEODE-3169:


Commit 3bb6a2214d02fcb339ecba0d0645457d3926ab12 in geode's branch 
refs/heads/develop from [~nreich]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=3bb6a22 ]

GEODE-3169: Decoupling of DiskStore and backups
This closes #715
  * move backup logic away from DiskStore and into BackupManager
  * refactor code into smaller methods
  * improve test code clarity


> Decouple implementation of backups from DiskStore
> -
>
> Key: GEODE-3169
> URL: https://issues.apache.org/jira/browse/GEODE-3169
> Project: Geode
>  Issue Type: Sub-task
>  Components: persistence
>Reporter: Nick Reich
>Assignee: Nick Reich
>
> As a first step towards enabling expanded backup options (such pushing 
> backups to cloud storage), the logic for doing so needs to be decoupled from 
> DiskStore. This will allow for the eventual modular design of the backup 
> system and make future improvement easier to implement and test.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3169) Decouple implementation of backups from DiskStore

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133262#comment-16133262
 ] 

ASF GitHub Bot commented on GEODE-3169:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/715


> Decouple implementation of backups from DiskStore
> -
>
> Key: GEODE-3169
> URL: https://issues.apache.org/jira/browse/GEODE-3169
> Project: Geode
>  Issue Type: Sub-task
>  Components: persistence
>Reporter: Nick Reich
>Assignee: Nick Reich
>
> As a first step towards enabling expanded backup options (such pushing 
> backups to cloud storage), the logic for doing so needs to be decoupled from 
> DiskStore. This will allow for the eventual modular design of the backup 
> system and make future improvement easier to implement and test.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3406) Enable new flow for protocol on locators

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133259#comment-16133259
 ] 

ASF GitHub Bot commented on GEODE-3406:
---

Github user kohlmu-pivotal commented on a diff in the pull request:

https://github.com/apache/geode/pull/716#discussion_r134005525
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpServer.java
 ---
@@ -143,11 +150,12 @@
 
   public TcpServer(int port, InetAddress bind_address, Properties 
sslConfig,
   DistributionConfigImpl cfg, TcpHandler handler, PoolStatHelper 
poolHelper,
-  ThreadGroup threadGroup, String threadName) {
+  ThreadGroup threadGroup, String threadName, InternalLocator 
internalLocator) {
--- End diff --

Is there a reason why we pass in the specific `InternalLocator` rather than 
a more generic `Locator`


> Enable new flow for protocol on locators
> 
>
> Key: GEODE-3406
> URL: https://issues.apache.org/jira/browse/GEODE-3406
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server
>Reporter: Brian Baynes
>Assignee: Alexander Murmann
>
> Enable magic byte and new flow for new protocol on locators.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3406) Enable new flow for protocol on locators

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133253#comment-16133253
 ] 

ASF GitHub Bot commented on GEODE-3406:
---

Github user pivotal-amurmann commented on a diff in the pull request:

https://github.com/apache/geode/pull/716#discussion_r134005011
  
--- Diff: 
geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImplJUnitTest.java
 ---
@@ -392,7 +388,7 @@ public void testLocatorUpdateIntervalZero() throws 
Exception {
 
   private void startFakeLocator() throws UnknownHostException, 
IOException, InterruptedException {
 server = new TcpServer(port, InetAddress.getLocalHost(), null, null, 
handler, new FakeHelper(),
-Thread.currentThread().getThreadGroup(), "Tcp Server");
+Thread.currentThread().getThreadGroup(), "Tcp Server", null);
--- End diff --

We added another parameter "protobuf handler" for TcpServer constructor to 
process protobuf messages. And it is nothing to do with existing code base and 
is only relevant for Protobuf requests. That's why we are passing null for old 
code.


> Enable new flow for protocol on locators
> 
>
> Key: GEODE-3406
> URL: https://issues.apache.org/jira/browse/GEODE-3406
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server
>Reporter: Brian Baynes
>Assignee: Alexander Murmann
>
> Enable magic byte and new flow for new protocol on locators.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3462) FunctionStats Exposed over JMX

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133249#comment-16133249
 ] 

ASF GitHub Bot commented on GEODE-3462:
---

Github user kirklund commented on a diff in the pull request:

https://github.com/apache/geode/pull/720#discussion_r134003701
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/FunctionStatsMXBean.java 
---
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+package org.apache.geode.management;
+
+import org.apache.geode.cache.asyncqueue.AsyncEventQueue;
+import org.apache.geode.management.internal.security.ResourceOperation;
+import org.apache.geode.security.ResourcePermission.Operation;
+import org.apache.geode.security.ResourcePermission.Resource;
+
+/**
+ * MBean that provides access to an {@link AsyncEventQueue}.
+ * 
+ * @since GemFire 7.0
--- End diff --

This is Geode, not GemFire and it certainly isn't 7.0. The next release 
would be Geode 1.3.0 but we really aren't supposed to add new User APIs in 
minor releases -- it may have to wait for Geode 2.0 -- that's something to 
discuss on the dev list as well.


> FunctionStats Exposed over JMX
> --
>
> Key: GEODE-3462
> URL: https://issues.apache.org/jira/browse/GEODE-3462
> Project: Geode
>  Issue Type: Improvement
>  Components: core
>Reporter: dineshakhand
>
> Currently FunctionStats are not visible on JMX. need to added them on JMX.
> now on JMX Server user can see the function stats.
> Created the FunctionStats bean and registerd on JMX.
> Also AsyncQueue Internal Region are exposed to JMX



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3462) FunctionStats Exposed over JMX

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133250#comment-16133250
 ] 

ASF GitHub Bot commented on GEODE-3462:
---

Github user kirklund commented on a diff in the pull request:

https://github.com/apache/geode/pull/720#discussion_r134004793
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/FunctionStatsMXBean.java 
---
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+package org.apache.geode.management;
+
+import org.apache.geode.cache.asyncqueue.AsyncEventQueue;
+import org.apache.geode.management.internal.security.ResourceOperation;
+import org.apache.geode.security.ResourcePermission.Operation;
+import org.apache.geode.security.ResourcePermission.Resource;
+
+/**
+ * MBean that provides access to an {@link AsyncEventQueue}.
+ * 
+ * @since GemFire 7.0
+ * 
+ */
+@ResourceOperation(resource = Resource.CLUSTER, operation = Operation.READ)
+public interface FunctionStatsMXBean {
--- End diff --

The design of this MBean doesn't fit in with the other Geode MBeans. We are 
not creating "stats" mbeans, we are creating mbeans for components in Geode. 
Example: we have a CacheServerMXBean and some of the attributes on that mbean 
are CacheServer stats.

I would recommend writing up some sort of proposal for adding a new 
FunctionService mbean on the Apache Geode wiki and then starting a discussion 
about this on the dev list. However, I should note that we've purposely avoided 
fine-grained mbeans, preferring overall mbeans such as FunctionServiceMXBean 
instead of having an mbean per Function. The same issue came up with Clients 
and Geode dev community decided that having an mbean per Client was NOT the 
direction we wanted to go in -- you may be going down a similar path here.

At present, the Cache and Function service are both squashed on the 
MemberMXBean which is why there is no separate mbean for Function service.


> FunctionStats Exposed over JMX
> --
>
> Key: GEODE-3462
> URL: https://issues.apache.org/jira/browse/GEODE-3462
> Project: Geode
>  Issue Type: Improvement
>  Components: core
>Reporter: dineshakhand
>
> Currently FunctionStats are not visible on JMX. need to added them on JMX.
> now on JMX Server user can see the function stats.
> Created the FunctionStats bean and registerd on JMX.
> Also AsyncQueue Internal Region are exposed to JMX



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (GEODE-3458) Failure in SerialWANPropagationDUnitTest.testReplicatedSerialPropagationWithRemoteReceiverRestarted_SenderReceiverPersistent due to loss of quorum

[Dan Smith (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Smith updated GEODE-3458:
-
Component/s: (was: wan)
 membership

> Failure in 
> SerialWANPropagationDUnitTest.testReplicatedSerialPropagationWithRemoteReceiverRestarted_SenderReceiverPersistent
>  due to loss of quorum
> --
>
> Key: GEODE-3458
> URL: https://issues.apache.org/jira/browse/GEODE-3458
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Reporter: Dan Smith
>
> This test failed in a private build with 
> bc655eb9b3683282705e7449f0f7a720c1a6243d
> {noformat}
> org.apache.geode.internal.cache.wan.serial.SerialWANPropagationDUnitTest > 
> testReplicatedSerialPropagationWithRemoteReceiverRestarted_SenderReceiverPersistent
>  FAILED
> java.lang.AssertionError: Suspicious strings were written to the log 
> during this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> ---
> Found suspect string in log4j at line 2776
> [fatal 2017/08/16 00:34:19.721 UTC  
> tid=0xf5] Possible loss of quorum due to the loss of 1 cache processes: 
> [172.17.0.8(179):32771]
> {noformat}
> Looking at the test, I think what is going on is that we create a WAN site 
> with only 2 members. When the test tears down the VMs, it closes the first 
> member and I think the second member is then deciding that is has lost quorum.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (GEODE-3381) Enhance Cargo tests to test different version of geode

[David Anuta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Anuta resolved GEODE-3381.

   Resolution: Fixed
Fix Version/s: 1.3.0

> Enhance Cargo tests to test different version of geode
> --
>
> Key: GEODE-3381
> URL: https://issues.apache.org/jira/browse/GEODE-3381
> Project: Geode
>  Issue Type: Improvement
>  Components: http session
>Reporter: David Anuta
>Assignee: David Anuta
> Fix For: 1.3.0
>
>
> Cargo tests are currently specifically built for geode 9.1. They should be 
> expanded to allow other versions of geode to be used. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (GEODE-3434) Allow the modules to be interoperable with current and older versions of tomcat 7

[David Anuta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Anuta resolved GEODE-3434.

   Resolution: Fixed
Fix Version/s: 1.3.0

> Allow the modules to be interoperable with current and older versions of 
> tomcat 7 
> --
>
> Key: GEODE-3434
> URL: https://issues.apache.org/jira/browse/GEODE-3434
> Project: Geode
>  Issue Type: Bug
>  Components: http session
>Reporter: Jason Huynh
>Assignee: Jason Huynh
> Fix For: 1.3.0
>
>
> There was a change to the attribute field in tomcat (and we made the 
> necessary changes in geode session modules), but that does not allow our 
> session modules to work with older versions of tomcat 7.  We can probably 
> modify the classes to allow use with of the session module jars across 
> different versions of tomcat 7.
> We should probably add tests that run against older versions of geode to 
> allow backwards compatibility between a geode server and a session module jar 
> from a previous release.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3406) Enable new flow for protocol on locators

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133230#comment-16133230
 ] 

ASF GitHub Bot commented on GEODE-3406:
---

Github user pivotal-amurmann commented on a diff in the pull request:

https://github.com/apache/geode/pull/716#discussion_r134002721
  
--- Diff: 
geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImplJUnitTest.java
 ---
@@ -392,7 +388,7 @@ public void testLocatorUpdateIntervalZero() throws 
Exception {
 
   private void startFakeLocator() throws UnknownHostException, 
IOException, InterruptedException {
 server = new TcpServer(port, InetAddress.getLocalHost(), null, null, 
handler, new FakeHelper(),
-Thread.currentThread().getThreadGroup(), "Tcp Server");
+Thread.currentThread().getThreadGroup(), "Tcp Server", null);
 server.start();
 Thread.sleep(500);
--- End diff --

It could, but we only really touched this file to account for the changed 
method signature


> Enable new flow for protocol on locators
> 
>
> Key: GEODE-3406
> URL: https://issues.apache.org/jira/browse/GEODE-3406
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server
>Reporter: Brian Baynes
>Assignee: Alexander Murmann
>
> Enable magic byte and new flow for new protocol on locators.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3462) FunctionStats Exposed over JMX

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133234#comment-16133234
 ] 

ASF GitHub Bot commented on GEODE-3462:
---

Github user jaredjstewart commented on the issue:

https://github.com/apache/geode/pull/720
  
Hi Dinesh,

I just commented on your earlier PR, and the same principle applies to this 
one as well: Changes to public APIs should first be discussed on 
d...@geode.apache.org.

Thank you,
Jared Stewart


> FunctionStats Exposed over JMX
> --
>
> Key: GEODE-3462
> URL: https://issues.apache.org/jira/browse/GEODE-3462
> Project: Geode
>  Issue Type: Improvement
>  Components: core
>Reporter: dineshakhand
>
> Currently FunctionStats are not visible on JMX. need to added them on JMX.
> now on JMX Server user can see the function stats.
> Created the FunctionStats bean and registerd on JMX.
> Also AsyncQueue Internal Region are exposed to JMX



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3151) Configuration Parameter Based Registration Of internal Region over JMX

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133228#comment-16133228
 ] 

ASF GitHub Bot commented on GEODE-3151:
---

Github user jaredjstewart commented on the issue:

https://github.com/apache/geode/pull/613
  
Hi Dinesh,

Sorry to be so slow in responding to your PR.  Since the changes you are 
proposing in GEODE-3151 involve changing a public-facing API (in 
DistributionConfig, I think it first needs to be discussed on 
d...@geode.apache.org before we could pull this in.  Would you mind sending an 
email to that list with your proposal and the use-case you have in mind?

Thank you,
Jared


> Configuration Parameter Based Registration Of internal Region over JMX
> --
>
> Key: GEODE-3151
> URL: https://issues.apache.org/jira/browse/GEODE-3151
> Project: Geode
>  Issue Type: New Feature
>  Components: general
>Reporter: dinesh akhand
>
> I am Adding the Configuration parameter which will have the internal region 
> name/function name
> which we want to register in JMX.
> currently for Internal Region Bean is not getting registered in  JMX.
> I want to make this as configurable.
> If user provided internal region names in configuration[property file ] then
> bean should get register in JMX.
> Current use: we want to register the async queue associated internal region 
> in JMX.
> future scope: using same parameter we want to register few functions to JMX.
> output : only defined internal regions in property file are going to be show 
> in JMX.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3151) Configuration Parameter Based Registration Of internal Region over JMX

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133226#comment-16133226
 ] 

ASF GitHub Bot commented on GEODE-3151:
---

Github user kirklund commented on the issue:

https://github.com/apache/geode/pull/613
  
I think this sort of change should be proposed and discussed on the dev 
list. This is effectively adding new User APIs and that requires more 
discussion.


> Configuration Parameter Based Registration Of internal Region over JMX
> --
>
> Key: GEODE-3151
> URL: https://issues.apache.org/jira/browse/GEODE-3151
> Project: Geode
>  Issue Type: New Feature
>  Components: general
>Reporter: dinesh akhand
>
> I am Adding the Configuration parameter which will have the internal region 
> name/function name
> which we want to register in JMX.
> currently for Internal Region Bean is not getting registered in  JMX.
> I want to make this as configurable.
> If user provided internal region names in configuration[property file ] then
> bean should get register in JMX.
> Current use: we want to register the async queue associated internal region 
> in JMX.
> future scope: using same parameter we want to register few functions to JMX.
> output : only defined internal regions in property file are going to be show 
> in JMX.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3434) Allow the modules to be interoperable with current and older versions of tomcat 7

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133183#comment-16133183
 ] 

ASF GitHub Bot commented on GEODE-3434:
---

Github user jhuynh1 closed the pull request at:

https://github.com/apache/geode/pull/718


> Allow the modules to be interoperable with current and older versions of 
> tomcat 7 
> --
>
> Key: GEODE-3434
> URL: https://issues.apache.org/jira/browse/GEODE-3434
> Project: Geode
>  Issue Type: Bug
>  Components: http session
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>
> There was a change to the attribute field in tomcat (and we made the 
> necessary changes in geode session modules), but that does not allow our 
> session modules to work with older versions of tomcat 7.  We can probably 
> modify the classes to allow use with of the session module jars across 
> different versions of tomcat 7.
> We should probably add tests that run against older versions of geode to 
> allow backwards compatibility between a geode server and a session module jar 
> from a previous release.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3411) Monitor the neighbour JVM using neihbour's member-timeout

[Udo Kohlmeyer (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133151#comment-16133151
 ] 

Udo Kohlmeyer commented on GEODE-3411:
--

This is a change in the default behavior of the system and I think this needs 
to be discussed by the greater GEODE community. 
Could I request that you possibly put this approach forward on the GEODE DEV 
list? This way the community can decide is this a feature the product should 
support.


> Monitor the neighbour JVM using neihbour's member-timeout
> -
>
> Key: GEODE-3411
> URL: https://issues.apache.org/jira/browse/GEODE-3411
> Project: Geode
>  Issue Type: Wish
>  Components: membership
>Reporter: Aravind M
> Fix For: 1.3.0
>
>
> Now when a member monitor's its neighbor, It uses it's own member timeout to 
> wait and then pass the suspect request to coordinator.
> But if we do so, while configuring the member timeout of all the member's, we 
> are not sure for how much time that member will be removed from the view as 
> it depends on the member-timeout of the jvm which is monitoring this one.
> So, if we use neighbor's member-timeout to wait for response instead of its 
> own member-timeout, then we can know for how much time a member will be 
> removed from the view.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (GEODE-3462) FunctionStats Exposed over JMX

[dineshakhand (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

dineshakhand updated GEODE-3462:

Description: 
Currently FunctionStats are not visible on JMX. need to added them on JMX.
now on JMX Server user can see the function stats.

Created the FunctionStats bean and registerd on JMX.

Also AsyncQueue Internal Region are exposed to JMX

  was:
I added the functionstats to JMX.
now on JMX Server user can see the function stats
Also AsyncQueue Internal Region are exposed to JMX


> FunctionStats Exposed over JMX
> --
>
> Key: GEODE-3462
> URL: https://issues.apache.org/jira/browse/GEODE-3462
> Project: Geode
>  Issue Type: Improvement
>  Components: core
>Reporter: dineshakhand
>
> Currently FunctionStats are not visible on JMX. need to added them on JMX.
> now on JMX Server user can see the function stats.
> Created the FunctionStats bean and registerd on JMX.
> Also AsyncQueue Internal Region are exposed to JMX



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (GEODE-3462) FunctionStats Exposed over JMX

[dineshakhand (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

dineshakhand updated GEODE-3462:


https://github.com/apache/geode/pull/720

> FunctionStats Exposed over JMX
> --
>
> Key: GEODE-3462
> URL: https://issues.apache.org/jira/browse/GEODE-3462
> Project: Geode
>  Issue Type: Improvement
>  Components: core
>Reporter: dineshakhand
>
> I added the functionstats to JMX.
> now on JMX Server user can see the function stats
> Also AsyncQueue Internal Region are exposed to JMX



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (GEODE-3462) FunctionStats Exposed over JMX

[dineshakhand (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

dineshakhand updated GEODE-3462:

Description: 
I added the functionstats to JMX.
now on JMX Server user can see the function stats
Also AsyncQueue Internal Region are exposed to JMX

  was:
I added the functionstats to JMX.
now on JMX Server user can see the function stats


> FunctionStats Exposed over JMX
> --
>
> Key: GEODE-3462
> URL: https://issues.apache.org/jira/browse/GEODE-3462
> Project: Geode
>  Issue Type: Improvement
>  Components: core
>Reporter: dineshakhand
>
> I added the functionstats to JMX.
> now on JMX Server user can see the function stats
> Also AsyncQueue Internal Region are exposed to JMX



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)