[jira] [Commented] (GEODE-3276) CI failure: org.apache.geode.internal.cache.wan.parallel.ParallelWANStatsDUnitTest > testParallelPropagationWithRemoteRegionDestroy FAILED

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139439#comment-16139439
 ] 

ASF GitHub Bot commented on GEODE-3276:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/732


> CI failure: 
> org.apache.geode.internal.cache.wan.parallel.ParallelWANStatsDUnitTest > 
> testParallelPropagationWithRemoteRegionDestroy FAILED
> --
>
> Key: GEODE-3276
> URL: https://issues.apache.org/jira/browse/GEODE-3276
> Project: Geode
>  Issue Type: Bug
>  Components: statistics, wan
>Affects Versions: 1.2.0
>Reporter: Shelley Lynn Hughes-Godfrey
>Assignee: nabarun
>
> {noformat}
> org.apache.geode.internal.cache.wan.parallel.ParallelWANStatsDUnitTest > 
> testParallelPropagationWithRemoteRegionDestroy FAILED
> java.lang.AssertionError: An exception occurred during asynchronous 
> invocation.
> Caused by:
> java.lang.OutOfMemoryError: Java heap space
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3276) CI failure: org.apache.geode.internal.cache.wan.parallel.ParallelWANStatsDUnitTest > testParallelPropagationWithRemoteRegionDestroy FAILED

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139438#comment-16139438
 ] 

ASF subversion and git services commented on GEODE-3276:


Commit 0daf9549a69a135ad1ab267be8e0749e00986dfa in geode's branch 
refs/heads/develop from [~nnag]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=0daf954 ]

GEODE-3276: Managing race conditions while the senders are stopped

* When a connection is initialized, a readAckThread may be alive from a 
previous incarnation.
* This AckThread will be stuck on a read socket with no timeout as 
nothing was dispatched.
* Also while it was stuck on the read, it will hold a connection 
lifecycle read lock
* The initialize connection needs a connection life cycle write lock to 
start the connection but the read lock is held by the ack thread.
* This results in a deadlock and eventually a hang.
* Another situation is that we set the flag isStopped for the event 
processor before actually shutting down the diapatcher and ack thread.
* So after the flag is set and before actually shutting down the 
dispatcher and ackThread, a gateway proxy stomper thread gets in between these 
two steps of execution.
* The stomper thread checks the isStopped flag, which was set to true, 
and proceeds to destroy the connection pool. However the dispatcher and 
ackThread were still running.
* This results in a out of heap memory exception while the ack thread 
is reading from the socket while connection pool was destroyed.
* To solve this issue, the stomper thread checks if the event processor 
and dispatcher exists, if true then we close the input streams before 
destroying the connection pool.

This closes #732


> CI failure: 
> org.apache.geode.internal.cache.wan.parallel.ParallelWANStatsDUnitTest > 
> testParallelPropagationWithRemoteRegionDestroy FAILED
> --
>
> Key: GEODE-3276
> URL: https://issues.apache.org/jira/browse/GEODE-3276
> Project: Geode
>  Issue Type: Bug
>  Components: statistics, wan
>Affects Versions: 1.2.0
>Reporter: Shelley Lynn Hughes-Godfrey
>Assignee: nabarun
>
> {noformat}
> org.apache.geode.internal.cache.wan.parallel.ParallelWANStatsDUnitTest > 
> testParallelPropagationWithRemoteRegionDestroy FAILED
> java.lang.AssertionError: An exception occurred during asynchronous 
> invocation.
> Caused by:
> java.lang.OutOfMemoryError: Java heap space
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3395) Variable-ize product version and name in user guide

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139384#comment-16139384
 ] 

ASF subversion and git services commented on GEODE-3395:


Commit a5469147da1d4cc45e93e44762c025b25092bc40 in geode's branch 
refs/heads/develop from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=a546914 ]

GEODE-3395 Variable-ize product version and name in user guide - Basic config


>  Variable-ize product version and name in user guide
> 
>
> Key: GEODE-3395
> URL: https://issues.apache.org/jira/browse/GEODE-3395
> Project: Geode
>  Issue Type: New Feature
>  Components: docs
>Reporter: Dave Barnes
>Assignee: Dave Barnes
>
> The Guide contains many occurrences of the product version string ("1.2", 
> "1.1", and "1.0-incubating" are recent examples) scattered over about 900 
> files.  It would be a great convenience to those who write and edit these 
> files to define the version number symbolically so it could be updated in one 
> central location. A template variable in the book's config.yml file would be 
> an obvious candidate for the implementation.
> Similarly, it would be handy to provide symbolic identifiers for the product 
> name, long and short: "Apache Geode" and "Geode", respectively.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3503) Remove Codec classes for Protobuf encoded primitives

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139352#comment-16139352
 ] 

ASF subversion and git services commented on GEODE-3503:


Commit 6ce00598757d5b30e7bd4df0f80098400066ed36 in geode's branch 
refs/heads/feature/GEODE-3503 from [~ukohlmeyer]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=6ce0059 ]

GEODE-3503: fixed tests and reverted change to region_API.proto


> Remove Codec classes for Protobuf encoded primitives
> 
>
> Key: GEODE-3503
> URL: https://issues.apache.org/jira/browse/GEODE-3503
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server
>Reporter: Udo Kohlmeyer
>Assignee: Udo Kohlmeyer
>
> As per the initial implementation, the client protocol would encode all 
> primitives using specified codecs. To improve on this, all primitives are now 
> encoded using protobuf and the codec classes are not required anymore and can 
> be removed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3503) Remove Codec classes for Protobuf encoded primitives

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139322#comment-16139322
 ] 

ASF GitHub Bot commented on GEODE-3503:
---

Github user kohlmu-pivotal commented on a diff in the pull request:

https://github.com/apache/geode/pull/737#discussion_r134895876
  
--- Diff: geode-protobuf/src/main/proto/region_API.proto ---
@@ -58,6 +58,7 @@ message GetAllRequest {
 
 message GetAllResponse {
 repeated Entry entries = 1;
+repeated KeyedErrorResponse failedKeys = 2;
--- End diff --

reverted


> Remove Codec classes for Protobuf encoded primitives
> 
>
> Key: GEODE-3503
> URL: https://issues.apache.org/jira/browse/GEODE-3503
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server
>Reporter: Udo Kohlmeyer
>Assignee: Udo Kohlmeyer
>
> As per the initial implementation, the client protocol would encode all 
> primitives using specified codecs. To improve on this, all primitives are now 
> encoded using protobuf and the codec classes are not required anymore and can 
> be removed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (GEODE-3249) Validate internal client/server messages

[Karen Smoler Miller (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karen Smoler Miller resolved GEODE-3249.

Resolution: Fixed

> Validate internal client/server messages
> 
>
> Key: GEODE-3249
> URL: https://issues.apache.org/jira/browse/GEODE-3249
> Project: Geode
>  Issue Type: Bug
>  Components: docs, messaging
>Reporter: Anthony Baker
>Assignee: Karen Smoler Miller
> Fix For: 1.3.0, 1.2.1
>
>
> Some message types can not be invoked directly by an end user.  For 
> validation purposes, we should treat these messages the same way we treat 
> normal messages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3249) Validate internal client/server messages

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139309#comment-16139309
 ] 

ASF subversion and git services commented on GEODE-3249:


Commit d83ba36e8143054f8ce1fab4eec08641de8384f5 in geode's branch 
refs/heads/develop from [~karensmolermiller]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=d83ba36 ]

GEODE-3249 Document geode.allow-internal-messages-without-credentials

This closes #735


> Validate internal client/server messages
> 
>
> Key: GEODE-3249
> URL: https://issues.apache.org/jira/browse/GEODE-3249
> Project: Geode
>  Issue Type: Bug
>  Components: docs, messaging
>Reporter: Anthony Baker
>Assignee: Karen Smoler Miller
> Fix For: 1.3.0, 1.2.1
>
>
> Some message types can not be invoked directly by an end user.  For 
> validation purposes, we should treat these messages the same way we treat 
> normal messages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-2842) Remove unnecessary @CliOption arguments

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139302#comment-16139302
 ] 

ASF GitHub Bot commented on GEODE-2842:
---

Github user PurelyApplied commented on the issue:

https://github.com/apache/geode/pull/731
  
Precheckin green, with some flakiness observed in 
`org.apache.geode.internal.cache.ha.Bug48571DUnitTest`.


> Remove unnecessary @CliOption arguments
> ---
>
> Key: GEODE-2842
> URL: https://issues.apache.org/jira/browse/GEODE-2842
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Reporter: Jared Stewart
>Assignee: Jared Stewart
>
> The {{@CliOption}} annotation specifies default values for some of its fields 
> (like {{mandatory}} and {{unspecifiedDefaultValue}}).  Yet, we often 
> explicitly set those fields to the default value.  For example,
> {noformat}  @CliOption(key = CliStrings.START_LOCATOR__MEMBER_NAME, 
> mandatory = false,
>   unspecifiedDefaultValue = CliMetaData.ANNOTATION_NULL_VALUE,
>   help = CliStrings.START_LOCATOR__MEMBER_NAME__HELP) String 
> memberName {noformat}
> could simply read   
> {noformat}  @CliOption(key = CliStrings.START_LOCATOR__MEMBER_NAME,
>   help = CliStrings.START_LOCATOR__MEMBER_NAME__HELP) String 
> memberName {noformat}
> Removing these redundant/unnecessary arguments will make the code a lot more 
> readable.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3503) Remove Codec classes for Protobuf encoded primitives

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139296#comment-16139296
 ] 

ASF GitHub Bot commented on GEODE-3503:
---

Github user galen-pivotal commented on the issue:

https://github.com/apache/geode/pull/737
  
Looks like JSONCodecJUnitTest has multiple failures.


> Remove Codec classes for Protobuf encoded primitives
> 
>
> Key: GEODE-3503
> URL: https://issues.apache.org/jira/browse/GEODE-3503
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server
>Reporter: Udo Kohlmeyer
>Assignee: Udo Kohlmeyer
>
> As per the initial implementation, the client protocol would encode all 
> primitives using specified codecs. To improve on this, all primitives are now 
> encoded using protobuf and the codec classes are not required anymore and can 
> be removed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-2997) New flow: putAll/getAll

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139280#comment-16139280
 ] 

ASF GitHub Bot commented on GEODE-2997:
---

Github user galen-pivotal closed the pull request at:

https://github.com/apache/geode/pull/649


> New flow: putAll/getAll
> ---
>
> Key: GEODE-2997
> URL: https://issues.apache.org/jira/browse/GEODE-2997
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server
>Reporter: Brian Baynes
>Assignee: Udo Kohlmeyer
>
> Create proto message definitions and op handler for putAll/getAll messages.
> Client should be able to complete putAll/getAll of primitives and JSON with 
> response.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (GEODE-3511) Add package.html to geode-protobuf

[Galen O'Sullivan (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Galen O'Sullivan updated GEODE-3511:

Issue Type: Sub-task  (was: Improvement)
Parent: GEODE-2580

> Add package.html to geode-protobuf
> --
>
> Key: GEODE-3511
> URL: https://issues.apache.org/jira/browse/GEODE-3511
> Project: Geode
>  Issue Type: Sub-task
>  Components: messaging
>Reporter: Galen O'Sullivan
>
> Having a package.html file in the geode-protobuf module would allow us to 
> provide module-level documentation and give developers an overview of what's 
> going on, as well as whatever additional experimental warnings we want.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (GEODE-3511) Add package.html to geode-protobuf

[Galen O'Sullivan (JIRA)]

Galen O'Sullivan created GEODE-3511:
---

 Summary: Add package.html to geode-protobuf
 Key: GEODE-3511
 URL: https://issues.apache.org/jira/browse/GEODE-3511
 Project: Geode
  Issue Type: Improvement
  Components: messaging
Reporter: Galen O'Sullivan


Having a package.html file in the geode-protobuf module would allow us to 
provide module-level documentation and give developers an overview of what's 
going on, as well as whatever additional experimental warnings we want.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3508) Removed unused internal deprecated classes.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139212#comment-16139212
 ] 

ASF GitHub Bot commented on GEODE-3508:
---

Github user PurelyApplied commented on a diff in the pull request:

https://github.com/apache/geode/pull/734#discussion_r134881817
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/internal/process/ClusterConfigurationNotAvailableException.java
 ---
@@ -1,33 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
- * agreements. See the NOTICE file distributed with this work for 
additional information regarding
- * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
- * "License"); you may not use this file except in compliance with the 
License. You may obtain a
- * copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software 
distributed under the License
- * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
- * or implied. See the License for the specific language governing 
permissions and limitations under
- * the License.
- */
-package org.apache.geode.internal.process;
-
-/**
- * Exception thrown during server startup when it requests the locators 
for shared configuration and
- * does not receive it.
- *
- * @since GemFire 8.0
- * @deprecated Please use
--- End diff --

Looks like `@deprecated` wants to be one, too.  Better use those backticks.

I definitely misread those annotations, yes.  I should get in the habit of 
checking the `git blame` to be sure about the deprecation date.

Other than the reason you mentioned -- possibly using it during a rolling 
upgrade -- is there a good reason to deprecate an internal class instead of 
simply removing it?  It was my understanding that internal packages didn't hold 
any promise of API stability.  Or could there be a backwards-compatibility 
issue that I'm not seeing?


> Removed unused internal deprecated classes.
> ---
>
> Key: GEODE-3508
> URL: https://issues.apache.org/jira/browse/GEODE-3508
> Project: Geode
>  Issue Type: Improvement
>Reporter: Patrick Rhomberg
>
> The following classes are internal, deprecated, and (essentially) unused.
> {noformat}
> geode-core/src/main/java/org/apache/geode/distributed/internal/MessageFactory.java
> geode-core/src/main/java/org/apache/geode/internal/process/ClusterConfigurationNotAvailableException.java
> geode-core/src/main/java/org/apache/geode/management/internal/configuration/utils/DtdResolver.java
> {noformat}
> They may be safely deleted.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3385) Change GetAllRequest to return list of errors

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139208#comment-16139208
 ] 

ASF GitHub Bot commented on GEODE-3385:
---

GitHub user galen-pivotal opened a pull request:

https://github.com/apache/geode/pull/739

GEODE-3385: Change GetAllRequest to return list of errors.

Also:
* Rename `KeyedErrorResponse` to `KeyedError`.
* move `ErrorResponse` to `clientProtocol.proto`.
* Check for null value in `ProtobufUtilities.createEntry`.
  If we find a null, we don't set the value; previously this resulted in
NPE.

Signed-off-by: Galen O'Sullivan 

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [x] Is your initial contribution a single, squashed commit?

- [x] Does `gradlew build` run cleanly?

- [x] Have you written or updated unit tests to verify your changes?

- [n/a] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to d...@geode.apache.org.

@WireBaron @bschuchardt @hiteshk25 @kohlmu-pivotal @pivotal-amurmann 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/galen-pivotal/geode feature/GEODE-3385

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/739.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #739


commit 78514a41718fb2682780bb949cf8ee4efb76224b
Author: Brian Rowe 
Date:   2017-08-23T21:53:06Z

GEODE-3385: Change GetAllRequest to return list of errors.

Also:
* Rename `KeyedErrorResponse` to `KeyedError`.
* move `ErrorResponse` to `clientProtocol.proto`.
* Check for null value in `ProtobufUtilities.createEntry`.
  If we find a null, we don't set the value; previously this resulted in
NPE.

Signed-off-by: Galen O'Sullivan 




> Change GetAllRequest to return list of errors
> -
>
> Key: GEODE-3385
> URL: https://issues.apache.org/jira/browse/GEODE-3385
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server
>Reporter: Galen O'Sullivan
>Assignee: Galen O'Sullivan
>
> GetAllRequest currently returns a list of successful keys or an error (if 
> getting any key threw an exception). We should instead return a list of 
> errors, similar to PutAllRequest.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3506) LocatorLauncherRemoteFileIntegrationTest.startDeletesStaleControlFiles fails intermittently with IllegalStateException: Failed to read status file

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139181#comment-16139181
 ] 

ASF GitHub Bot commented on GEODE-3506:
---

GitHub user kirklund opened a pull request:

https://github.com/apache/geode/pull/738

GEODE-3506: improve validation/error checking for process file control

We only ever hit this failure once and I don't think it's a flaky test. 
This could actually be one more (last remaining?) root cause of "start locator" 
or "start server" hanging-while-printing-dots in GFSH. 

I've added what I consider to be excessive validation and error checking 
but it should point us at the cause if this check in FileProcessController ever 
fails again:

if (isBlank(lines)) {
  throw new IllegalStateException("Status file '" + statusFile + "' is 
blank");
}

In addition to this PR, we should consider adding more direct test coverage 
for ServiceState and its subclasses as well as more unit tests of the Launcher 
using mocks.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kirklund/geode 
GEODE-3506-FileProcessController

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/738.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #738


commit 8edd3f0e15406082bb568de975c631de2ae373d7
Author: Kirk Lund 
Date:   2017-08-23T21:20:18Z

GEODE-3506: improve validation and error handling of process file control




> LocatorLauncherRemoteFileIntegrationTest.startDeletesStaleControlFiles fails 
> intermittently with IllegalStateException: Failed to read status file
> --
>
> Key: GEODE-3506
> URL: https://issues.apache.org/jira/browse/GEODE-3506
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, management
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> {noformat}
> org.apache.geode.distributed.LocatorLauncherRemoteFileIntegrationTest > 
> startDeletesStaleControlFiles FAILED
> java.lang.IllegalStateException: Failed to read status file
> {noformat}
> Full stack trace:
> {noformat}
> java.lang.IllegalStateException: Failed to read status file
> at 
> org.apache.geode.internal.process.FileProcessController.status(FileProcessController.java:152)
> at 
> org.apache.geode.internal.process.FileProcessController.status(FileProcessController.java:89)
> at 
> org.apache.geode.distributed.LocatorLauncher.statusWithWorkingDirectory(LocatorLauncher.java:940)
> at 
> org.apache.geode.distributed.LocatorLauncher.status(LocatorLauncher.java:868)
> at 
> org.apache.geode.distributed.LocatorLauncherRemoteIntegrationTestCase.lambda$awaitStart$1(LocatorLauncherRemoteIntegrationTestCase.java:196)
> at 
> org.awaitility.core.AssertionCondition$1.eval(AssertionCondition.java:55)
> at 
> org.awaitility.core.ConditionAwaiter$ConditionPoller.run(ConditionAwaiter.java:215)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3503) Remove Codec classes for Protobuf encoded primitives

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139155#comment-16139155
 ] 

ASF subversion and git services commented on GEODE-3503:


Commit 42eb4b926331c1fc4ded1165f7ccab6c6ed26b8d in geode's branch 
refs/heads/feature/GEODE-3503 from [~ukohlmeyer]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=42eb4b9 ]

GEODE-3503: Removal of Codec classes left behind.
Added tests to test the remaining JSONCodec.


> Remove Codec classes for Protobuf encoded primitives
> 
>
> Key: GEODE-3503
> URL: https://issues.apache.org/jira/browse/GEODE-3503
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server
>Reporter: Udo Kohlmeyer
>Assignee: Udo Kohlmeyer
>
> As per the initial implementation, the client protocol would encode all 
> primitives using specified codecs. To improve on this, all primitives are now 
> encoded using protobuf and the codec classes are not required anymore and can 
> be removed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3508) Removed unused internal deprecated classes.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139153#comment-16139153
 ] 

ASF GitHub Bot commented on GEODE-3508:
---

Github user kirklund commented on a diff in the pull request:

https://github.com/apache/geode/pull/734#discussion_r134875716
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/internal/process/ClusterConfigurationNotAvailableException.java
 ---
@@ -1,33 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
- * agreements. See the NOTICE file distributed with this work for 
additional information regarding
- * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
- * "License"); you may not use this file except in compliance with the 
License. You may obtain a
- * copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software 
distributed under the License
- * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
- * or implied. See the License for the specific language governing 
permissions and limitations under
- * the License.
- */
-package org.apache.geode.internal.process;
-
-/**
- * Exception thrown during server startup when it requests the locators 
for shared configuration and
- * does not receive it.
- *
- * @since GemFire 8.0
- * @deprecated Please use
--- End diff --

Oops, someone has a github name of "since" in mixed case.


> Removed unused internal deprecated classes.
> ---
>
> Key: GEODE-3508
> URL: https://issues.apache.org/jira/browse/GEODE-3508
> Project: Geode
>  Issue Type: Improvement
>Reporter: Patrick Rhomberg
>
> The following classes are internal, deprecated, and (essentially) unused.
> {noformat}
> geode-core/src/main/java/org/apache/geode/distributed/internal/MessageFactory.java
> geode-core/src/main/java/org/apache/geode/internal/process/ClusterConfigurationNotAvailableException.java
> geode-core/src/main/java/org/apache/geode/management/internal/configuration/utils/DtdResolver.java
> {noformat}
> They may be safely deleted.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3472) Code Cleanup: remove dead code from /management.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139131#comment-16139131
 ] 

ASF GitHub Bot commented on GEODE-3472:
---

Github user jaredjstewart commented on a diff in the pull request:

https://github.com/apache/geode/pull/730#discussion_r134869699
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/CliUtil.java 
---
@@ -212,8 +211,7 @@ public static void bytesToFiles(byte[][] fileData, 
String parentDirPath, boolean
   }
 
   public static boolean isValidFileName(String filePath, String extension) 
{
-boolean isValid = true;
-return isValid;
+return true;
--- End diff --

Can we just delete this method entirely?


> Code Cleanup: remove dead code from /management.
> 
>
> Key: GEODE-3472
> URL: https://issues.apache.org/jira/browse/GEODE-3472
> Project: Geode
>  Issue Type: Improvement
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>
> There is a great deal of dead, commented, and unused code in the codebase.  
> This ticket addresses some of it, limiting scope to those files in 
> `geode-core/**/management/**` to keep the eventual diff relatively small.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3472) Code Cleanup: remove dead code from /management.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139134#comment-16139134
 ] 

ASF GitHub Bot commented on GEODE-3472:
---

Github user jaredjstewart commented on a diff in the pull request:

https://github.com/apache/geode/pull/730#discussion_r134872863
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/MBeanJMXAdapter.java
 ---
@@ -72,16 +72,13 @@
   private DistributedMember distMember;
 
   /**
-   * log writer, or null if there is no distributed system available
-   */
-  // private LogWriterI18n logger = 
InternalDistributedSystem.getLoggerI18n();
-
-  /**
* public constructor
*/
 
+  public static final int VALUE_NOT_AVAILABLE = -1;
--- End diff --

Should this live in VMStatsMonitor since that's the only place it appears 
to be used?


> Code Cleanup: remove dead code from /management.
> 
>
> Key: GEODE-3472
> URL: https://issues.apache.org/jira/browse/GEODE-3472
> Project: Geode
>  Issue Type: Improvement
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>
> There is a great deal of dead, commented, and unused code in the codebase.  
> This ticket addresses some of it, limiting scope to those files in 
> `geode-core/**/management/**` to keep the eventual diff relatively small.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3472) Code Cleanup: remove dead code from /management.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139133#comment-16139133
 ] 

ASF GitHub Bot commented on GEODE-3472:
---

Github user jaredjstewart commented on a diff in the pull request:

https://github.com/apache/geode/pull/730#discussion_r134867453
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/domain/DataCommandResult.java
 ---
@@ -415,9 +413,8 @@ public Result toCommandResult() {
   toCommandResult_isPut(section, table);
 } else if (isRemove()) {
   toCommandResult_isRemove(section, table);
-} else if (isSelect()) {
-  // its moved to its separate method
 }
+// isSelect() moved to a separate method
--- End diff --

Did you intended to leave this comment?  


> Code Cleanup: remove dead code from /management.
> 
>
> Key: GEODE-3472
> URL: https://issues.apache.org/jira/browse/GEODE-3472
> Project: Geode
>  Issue Type: Improvement
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>
> There is a great deal of dead, commented, and unused code in the codebase.  
> This ticket addresses some of it, limiting scope to those files in 
> `geode-core/**/management/**` to keep the eventual diff relatively small.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3472) Code Cleanup: remove dead code from /management.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139132#comment-16139132
 ] 

ASF GitHub Bot commented on GEODE-3472:
---

Github user jaredjstewart commented on a diff in the pull request:

https://github.com/apache/geode/pull/730#discussion_r134869226
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/Gfsh.java
 ---
@@ -158,7 +156,7 @@
   private Thread runner;
   private boolean debugON;
   private Terminal terminal;
-  private boolean supressScriptCmdOutput;
+  private boolean suppressScriptCadOutput;
--- End diff --

This looks like a newly introduced typo :P


> Code Cleanup: remove dead code from /management.
> 
>
> Key: GEODE-3472
> URL: https://issues.apache.org/jira/browse/GEODE-3472
> Project: Geode
>  Issue Type: Improvement
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>
> There is a great deal of dead, commented, and unused code in the codebase.  
> This ticket addresses some of it, limiting scope to those files in 
> `geode-core/**/management/**` to keep the eventual diff relatively small.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3503) Remove Codec classes for Protobuf encoded primitives

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139091#comment-16139091
 ] 

ASF GitHub Bot commented on GEODE-3503:
---

GitHub user kohlmu-pivotal opened a pull request:

https://github.com/apache/geode/pull/737

GEODE-3503: Removal of Codec classes left behind.

Added tests to test the remaining JSONCodec.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to d...@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/geode feature/GEODE-3503

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/737.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #737


commit a182a5a956d8a2e299fa3fb1307a79aa7c353e9e
Author: Udo Kohlmeyer 
Date:   2017-08-23T20:48:11Z

GEODE-3503: Removal of Codec classes left behind.
Added tests to test the remaining JSONCodec.




> Remove Codec classes for Protobuf encoded primitives
> 
>
> Key: GEODE-3503
> URL: https://issues.apache.org/jira/browse/GEODE-3503
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server
>Reporter: Udo Kohlmeyer
>Assignee: Udo Kohlmeyer
>
> As per the initial implementation, the client protocol would encode all 
> primitives using specified codecs. To improve on this, all primitives are now 
> encoded using protobuf and the codec classes are not required anymore and can 
> be removed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3507) actualRedundantCopies stat in org.apache.geode.internal.cache.PartitionedRegionStats can go negative

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139089#comment-16139089
 ] 

ASF subversion and git services commented on GEODE-3507:


Commit 039edfce4bd5f58f967b98fad0ee72c4a0adfba4 in geode's branch 
refs/heads/feature/GEODE-3503 from [~lgallinat]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=039edfc ]

GEODE-3507 PartitionedRegionRedundancyTracker now does not allow 
actualRedundantCopies stat to be negative


> actualRedundantCopies stat in 
> org.apache.geode.internal.cache.PartitionedRegionStats can go negative
> 
>
> Key: GEODE-3507
> URL: https://issues.apache.org/jira/browse/GEODE-3507
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Lynn Gallinat
>Assignee: Lynn Gallinat
> Fix For: 1.3.0
>
>
> The actualRedundantCopies can be set to a negative value through the 
> org.apache.geode.internal.cache.PartitionedRegionRedundancyTrackerTest class. 
> This behavior was introduced in the fix for GEODE-3049.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3164) ClientHealthStatsDUnitTest.testClientHealthStats_SubscriptionDisabled fails intermittently with AssertionError

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139082#comment-16139082
 ] 

ASF subversion and git services commented on GEODE-3164:


Commit afded2a8d960359f4e319e76bf5e39720151ae0d in geode's branch 
refs/heads/feature/GEODE-3503 from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=afded2a ]

GEODE-3164: fix flakiness with await


> ClientHealthStatsDUnitTest.testClientHealthStats_SubscriptionDisabled fails 
> intermittently with AssertionError
> --
>
> Key: GEODE-3164
> URL: https://issues.apache.org/jira/browse/GEODE-3164
> Project: Geode
>  Issue Type: Bug
>  Components: client/server, management, tests
>Reporter: Hitesh Khamesra
>Assignee: Kirk Lund
>  Labels: DistributedTest, Flaky
> Fix For: 1.3.0
>
>
> {noformat}
> org.apache.geode.management.ClientHealthStatsDUnitTest > 
> testClientHealthStats_SubscriptionDisabled FAILED
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.management.ClientHealthStatsDUnitTest$$Lambda$33/1335405829.run
>  in VM 0 running on Host 57af4a2e6a1a with 4 VMs
> at org.apache.geode.test.dunit.VM.invoke(VM.java:377)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:347)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:292)
> at 
> org.apache.geode.management.ClientHealthStatsDUnitTest.testClientHealthStats_SubscriptionDisabled(ClientHealthStatsDUnitTest.java:136)
> Caused by:
> java.lang.AssertionError: 
> Expected size:<2> but was:<1> in:
> <["172.17.0.4(197:loner):57014:0e60d6fc"]>
> at 
> org.apache.geode.management.ClientHealthStatsDUnitTest.verifyClientStats(ClientHealthStatsDUnitTest.java:314)
> at 
> org.apache.geode.management.ClientHealthStatsDUnitTest.lambda$testClientHealthStats_SubscriptionDisabled$1db6af62$1(ClientHealthStatsDUnitTest.java:136)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3505) NonBlockingProcessStreamReaderIntegrationTest.processTerminatesWhenDestroyed fails intermittently with ConditionTimeoutException

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139084#comment-16139084
 ] 

ASF subversion and git services commented on GEODE-3505:


Commit 6f7667d90e56d4dec6f2670a1c46e40b4e354026 in geode's branch 
refs/heads/feature/GEODE-3503 from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=6f7667d ]

GEODE-3461: increase test timeouts

Also fixes:
* GEODE-3505

This closes #729


> NonBlockingProcessStreamReaderIntegrationTest.processTerminatesWhenDestroyed 
> fails intermittently with ConditionTimeoutException
> 
>
> Key: GEODE-3505
> URL: https://issues.apache.org/jira/browse/GEODE-3505
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, management, tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>  Labels: Flaky
> Fix For: 1.3.0
>
>
> {noformat}
> org.apache.geode.internal.process.NonBlockingProcessStreamReaderIntegrationTest
>  > processTerminatesWhenDestroyed FAILED
> org.awaitility.core.ConditionTimeoutException: Condition defined as a 
> lambda expression in 
> org.apache.geode.internal.process.AbstractProcessStreamReaderIntegrationTest 
> expected:<[fals]e> but was:<[tru]e> within 2 milliseconds.
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3406) Enable new flow for protocol on locators

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139087#comment-16139087
 ] 

ASF subversion and git services commented on GEODE-3406:


Commit fa29ec13f049e39c13ff4e711364e55708ede94d in geode's branch 
refs/heads/feature/GEODE-3503 from [~hitesh.khamesra]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=fa29ec1 ]

Closing pull request for GEODE-3406. Closes #716


> Enable new flow for protocol on locators
> 
>
> Key: GEODE-3406
> URL: https://issues.apache.org/jira/browse/GEODE-3406
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server
>Reporter: Brian Baynes
>Assignee: Hitesh Khamesra
>
> Enable magic byte and new flow for new protocol on locators.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3335) CI Failure : RegionManagementDUnitTest.testNavigationAPIS fails intermittently with ConditionTimeoutException

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139080#comment-16139080
 ] 

ASF subversion and git services commented on GEODE-3335:


Commit c95b32ee8c95f2a95767ce771eb6b2f5ee8492c7 in geode's branch 
refs/heads/feature/GEODE-3503 from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=c95b32e ]

GEODE-3335: add FlakyTest category to testNavigationAPIS


> CI Failure : RegionManagementDUnitTest.testNavigationAPIS fails 
> intermittently with ConditionTimeoutException
> -
>
> Key: GEODE-3335
> URL: https://issues.apache.org/jira/browse/GEODE-3335
> Project: Geode
>  Issue Type: Bug
>  Components: management
>Reporter: nabarun
>Assignee: Kirk Lund
>  Labels: DistributedTest, Flaky
>
> {noformat}
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.test.dunit.NamedRunnable.run in VM 0 running on Host 
> 96fffb6d85d3 with 4 VMs
>   at org.apache.geode.test.dunit.VM.invoke(VM.java:387)
>   at org.apache.geode.test.dunit.VM.invoke(VM.java:357)
>   at org.apache.geode.test.dunit.VM.invoke(VM.java:290)
>   at 
> org.apache.geode.management.RegionManagementDUnitTest.verifyNavigationApis(RegionManagementDUnitTest.java:419)
>   at 
> org.apache.geode.management.RegionManagementDUnitTest.testNavigationAPIS(RegionManagementDUnitTest.java:282)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
>   at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
>   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
>   at 
> org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
>   at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
>   at 
> 

[jira] [Commented] (GEODE-2859) ShowDeadlockDUnitTest.testDistributedDeadlockWithFunction failing in CI.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139081#comment-16139081
 ] 

ASF subversion and git services commented on GEODE-2859:


Commit a0ad56896a8ed183f1e1db0ddc24e6857640de58 in geode's branch 
refs/heads/feature/GEODE-3503 from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=a0ad568 ]

GEODE-2859: minor cleanup


> ShowDeadlockDUnitTest.testDistributedDeadlockWithFunction failing in CI.
> 
>
> Key: GEODE-2859
> URL: https://issues.apache.org/jira/browse/GEODE-2859
> Project: Geode
>  Issue Type: Test
>  Components: gfsh, membership, messaging, tests
>Reporter: Galen O'Sullivan
>Assignee: Jared Stewart
> Fix For: 1.2.0
>
>
> https://builds.apache.org/job/Geode-nightly/821/
> This test is a copy of GemFireDeadlockDetectorDUnitTest.java, which was 
> recently updated (https://reviews.apache.org/r/58541/diff/1#index_header). 
> Probably it needs the same fix or related.
> ShowDeadlockDUnitTest.testNoDeadlock also fails in this test run.
> {code}
> Error Message
> java.lang.AssertionError
> Stacktrace
> java.lang.AssertionError
>   at org.junit.Assert.fail(Assert.java:86)
>   at org.junit.Assert.assertTrue(Assert.java:41)
>   at org.junit.Assert.assertTrue(Assert.java:52)
>   at 
> org.apache.geode.management.internal.cli.commands.ShowDeadlockDUnitTest.testDistributedDeadlockWithFunction(ShowDeadlockDUnitTest.java:156)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
>   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
>   at 
> org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
>   at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
>   at 
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109)
>   at 

[jira] [Commented] (GEODE-3503) Remove Codec classes for Protobuf encoded primitives

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139090#comment-16139090
 ] 

ASF subversion and git services commented on GEODE-3503:


Commit a182a5a956d8a2e299fa3fb1307a79aa7c353e9e in geode's branch 
refs/heads/feature/GEODE-3503 from [~ukohlmeyer]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=a182a5a ]

GEODE-3503: Removal of Codec classes left behind.
Added tests to test the remaining JSONCodec.


> Remove Codec classes for Protobuf encoded primitives
> 
>
> Key: GEODE-3503
> URL: https://issues.apache.org/jira/browse/GEODE-3503
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server
>Reporter: Udo Kohlmeyer
>Assignee: Udo Kohlmeyer
>
> As per the initial implementation, the client protocol would encode all 
> primitives using specified codecs. To improve on this, all primitives are now 
> encoded using protobuf and the codec classes are not required anymore and can 
> be removed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3184) Clean up session replication testing

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139088#comment-16139088
 ] 

ASF subversion and git services commented on GEODE-3184:


Commit a229933ce4dfa2db462f81fc864a4bb1b78e2d08 in geode's branch 
refs/heads/feature/GEODE-3503 from [~DivineEnder]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=a229933 ]

GEODE-3184: Cleaned up Cargo tests

This closes #722


> Clean up session replication testing
> 
>
> Key: GEODE-3184
> URL: https://issues.apache.org/jira/browse/GEODE-3184
> Project: Geode
>  Issue Type: Improvement
>  Components: http session
>Reporter: David Anuta
>Assignee: David Anuta
>Priority: Minor
>
> Would be good to review  the code base and make sure methods are properly 
> organized.
> Also, the previous session replication testing is still in place in the 
> extensions folder. This needs to be reviewed and any tests not covered by 
> cargo should be transferred over into the new cargo replication testing. An 
> example of something within this that needs to be cleaned up would be 
> QueryCommand and CommandServlet classes, which are both in the 
> extensions/geode-modules and extensions/session-testing-war projects. the 
> QueryCommand and Command Servlet class within the extensions/geode-modules 
> project could be removed if the previous session tests were all ported to 
> cargo and then removed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3395) Variable-ize product version and name in user guide

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139085#comment-16139085
 ] 

ASF subversion and git services commented on GEODE-3395:


Commit 1b84ecbe4d942d843cb0d0fa8c2e03eb55f07f39 in geode's branch 
refs/heads/feature/GEODE-3503 from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=1b84ecb ]

GEODE-3395 Variable-ize product version and name in user guide - Managing


>  Variable-ize product version and name in user guide
> 
>
> Key: GEODE-3395
> URL: https://issues.apache.org/jira/browse/GEODE-3395
> Project: Geode
>  Issue Type: New Feature
>  Components: docs
>Reporter: Dave Barnes
>Assignee: Dave Barnes
>
> The Guide contains many occurrences of the product version string ("1.2", 
> "1.1", and "1.0-incubating" are recent examples) scattered over about 900 
> files.  It would be a great convenience to those who write and edit these 
> files to define the version number symbolically so it could be updated in one 
> central location. A template variable in the book's config.yml file would be 
> an obvious candidate for the implementation.
> Similarly, it would be handy to provide symbolic identifiers for the product 
> name, long and short: "Apache Geode" and "Geode", respectively.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3504) User Guide: Add Experimental caveat for Redis and Auto-rebalance

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139079#comment-16139079
 ] 

ASF subversion and git services commented on GEODE-3504:


Commit a1ac45dee947dd95c70200e7779275a03b492733 in geode's branch 
refs/heads/feature/GEODE-3503 from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=a1ac45d ]

GEODE-3504: Add Experimental caveat for Redis and Auto-rebalance


> User Guide: Add Experimental caveat for Redis and Auto-rebalance
> 
>
> Key: GEODE-3504
> URL: https://issues.apache.org/jira/browse/GEODE-3504
> Project: Geode
>  Issue Type: Improvement
>Reporter: Dave Barnes
>Assignee: Dave Barnes
>Priority: Minor
> Fix For: 1.3.0
>
>
> The Redis adapter and the Auto-rebalance feature are not fully-baked. Add a 
> caveat to their respective pages to alert the reader.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3461) BlockingProcessStreamReaderIntegrationTest.processTerminatesWhenDestroyed fails intermittently with ConditionTimeoutException

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139083#comment-16139083
 ] 

ASF subversion and git services commented on GEODE-3461:


Commit 6f7667d90e56d4dec6f2670a1c46e40b4e354026 in geode's branch 
refs/heads/feature/GEODE-3503 from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=6f7667d ]

GEODE-3461: increase test timeouts

Also fixes:
* GEODE-3505

This closes #729


> BlockingProcessStreamReaderIntegrationTest.processTerminatesWhenDestroyed 
> fails intermittently with ConditionTimeoutException
> -
>
> Key: GEODE-3461
> URL: https://issues.apache.org/jira/browse/GEODE-3461
> Project: Geode
>  Issue Type: Bug
>  Components: management, tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>  Labels: CI, Flaky
> Fix For: 1.3.0
>
>
> {noformat}
> org.awaitility.core.ConditionTimeoutException: Condition defined as a lambda 
> expression in 
> org.apache.geode.internal.process.AbstractProcessStreamReaderIntegrationTest 
> expected:<[fals]e> but was:<[tru]e> within 2 milliseconds.
> at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:104)
> at 
> org.awaitility.core.AssertionCondition.await(AssertionCondition.java:117)
> at 
> org.awaitility.core.AssertionCondition.await(AssertionCondition.java:32)
> at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:809)
> at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:648)
> at 
> org.apache.geode.internal.process.AbstractProcessStreamReaderIntegrationTest.waitUntilProcessStops(AbstractProcessStreamReaderIntegrationTest.java:169)
> at 
> org.apache.geode.internal.process.BaseProcessStreamReaderIntegrationTest.processTerminatesWhenDestroyed(BaseProcessStreamReaderIntegrationTest.java:48)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
> at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
> at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
> at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
> at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
> at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
> at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
> at 
> org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
> at 
> org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
> at 

[jira] [Commented] (GEODE-3503) Remove Codec classes for Protobuf encoded primitives

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139086#comment-16139086
 ] 

ASF GitHub Bot commented on GEODE-3503:
---

Github user kohlmu-pivotal closed the pull request at:

https://github.com/apache/geode/pull/736


> Remove Codec classes for Protobuf encoded primitives
> 
>
> Key: GEODE-3503
> URL: https://issues.apache.org/jira/browse/GEODE-3503
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server
>Reporter: Udo Kohlmeyer
>Assignee: Udo Kohlmeyer
>
> As per the initial implementation, the client protocol would encode all 
> primitives using specified codecs. To improve on this, all primitives are now 
> encoded using protobuf and the codec classes are not required anymore and can 
> be removed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3503) Remove Codec classes for Protobuf encoded primitives

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139068#comment-16139068
 ] 

ASF GitHub Bot commented on GEODE-3503:
---

GitHub user kohlmu-pivotal opened a pull request:

https://github.com/apache/geode/pull/736

GEODE-3503: Removal of Codec classes left behind.

Added tests to test the remaining JSONCodec.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to d...@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/geode feature/GEODE-3503

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/736.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #736


commit 6c807e8267b6ac6878e4b497d0b3d680ea496ef1
Author: Udo Kohlmeyer 
Date:   2017-08-23T20:48:11Z

GEODE-3503: Removal of Codec classes left behind.
Added tests to test the remaining JSONCodec.




> Remove Codec classes for Protobuf encoded primitives
> 
>
> Key: GEODE-3503
> URL: https://issues.apache.org/jira/browse/GEODE-3503
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server
>Reporter: Udo Kohlmeyer
>Assignee: Udo Kohlmeyer
>
> As per the initial implementation, the client protocol would encode all 
> primitives using specified codecs. To improve on this, all primitives are now 
> encoded using protobuf and the codec classes are not required anymore and can 
> be removed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3503) Remove Codec classes for Protobuf encoded primitives

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139065#comment-16139065
 ] 

ASF subversion and git services commented on GEODE-3503:


Commit 6c807e8267b6ac6878e4b497d0b3d680ea496ef1 in geode's branch 
refs/heads/feature/GEODE-3503 from [~ukohlmeyer]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=6c807e8 ]

GEODE-3503: Removal of Codec classes left behind.
Added tests to test the remaining JSONCodec.


> Remove Codec classes for Protobuf encoded primitives
> 
>
> Key: GEODE-3503
> URL: https://issues.apache.org/jira/browse/GEODE-3503
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server
>Reporter: Udo Kohlmeyer
>Assignee: Udo Kohlmeyer
>
> As per the initial implementation, the client protocol would encode all 
> primitives using specified codecs. To improve on this, all primitives are now 
> encoded using protobuf and the codec classes are not required anymore and can 
> be removed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3249) Validate internal client/server messages

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139028#comment-16139028
 ] 

ASF GitHub Bot commented on GEODE-3249:
---

GitHub user karensmolermiller opened a pull request:

https://github.com/apache/geode/pull/735

GEODE-3249 Document geode.allow-internal-messages-without-credentials

@bschuchardt @metatype Please review documentation of the new property.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/karensmolermiller/geode feature/GEODE-3249

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/735.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #735


commit 440dd6fbb7184acad7a4436f82e35b912155a24d
Author: Karen Miller 
Date:   2017-08-23T20:25:19Z

GEODE-3249 Document geode.allow-internal-messages-without-credentials




> Validate internal client/server messages
> 
>
> Key: GEODE-3249
> URL: https://issues.apache.org/jira/browse/GEODE-3249
> Project: Geode
>  Issue Type: Bug
>  Components: docs, messaging
>Reporter: Anthony Baker
>Assignee: Karen Smoler Miller
> Fix For: 1.3.0, 1.2.1
>
>
> Some message types can not be invoked directly by an end user.  For 
> validation purposes, we should treat these messages the same way we treat 
> normal messages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (GEODE-3510) GfshRule loses output from standard error

[Jared Stewart (JIRA)]

Jared Stewart created GEODE-3510:


 Summary: GfshRule loses output from standard error
 Key: GEODE-3510
 URL: https://issues.apache.org/jira/browse/GEODE-3510
 Project: Geode
  Issue Type: Bug
  Components: gfsh, tests
Reporter: Jared Stewart


There is a bug in GfshRule that causes output to only show up from standard 
out, but not from standard error.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3507) actualRedundantCopies stat in org.apache.geode.internal.cache.PartitionedRegionStats can go negative

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138886#comment-16138886
 ] 

ASF subversion and git services commented on GEODE-3507:


Commit 039edfce4bd5f58f967b98fad0ee72c4a0adfba4 in geode's branch 
refs/heads/develop from [~lgallinat]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=039edfc ]

GEODE-3507 PartitionedRegionRedundancyTracker now does not allow 
actualRedundantCopies stat to be negative


> actualRedundantCopies stat in 
> org.apache.geode.internal.cache.PartitionedRegionStats can go negative
> 
>
> Key: GEODE-3507
> URL: https://issues.apache.org/jira/browse/GEODE-3507
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Lynn Gallinat
>Assignee: Lynn Gallinat
>
> The actualRedundantCopies can be set to a negative value through the 
> org.apache.geode.internal.cache.PartitionedRegionRedundancyTrackerTest class. 
> This behavior was introduced in the fix for GEODE-3049.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3184) Clean up session replication testing

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138849#comment-16138849
 ] 

ASF subversion and git services commented on GEODE-3184:


Commit a229933ce4dfa2db462f81fc864a4bb1b78e2d08 in geode's branch 
refs/heads/develop from [~DivineEnder]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=a229933 ]

GEODE-3184: Cleaned up Cargo tests

This closes #722


> Clean up session replication testing
> 
>
> Key: GEODE-3184
> URL: https://issues.apache.org/jira/browse/GEODE-3184
> Project: Geode
>  Issue Type: Improvement
>  Components: http session
>Reporter: David Anuta
>Assignee: David Anuta
>Priority: Minor
>
> Would be good to review  the code base and make sure methods are properly 
> organized.
> Also, the previous session replication testing is still in place in the 
> extensions folder. This needs to be reviewed and any tests not covered by 
> cargo should be transferred over into the new cargo replication testing. An 
> example of something within this that needs to be cleaned up would be 
> QueryCommand and CommandServlet classes, which are both in the 
> extensions/geode-modules and extensions/session-testing-war projects. the 
> QueryCommand and Command Servlet class within the extensions/geode-modules 
> project could be removed if the previous session tests were all ported to 
> cargo and then removed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3184) Clean up session replication testing

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138851#comment-16138851
 ] 

ASF GitHub Bot commented on GEODE-3184:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/722


> Clean up session replication testing
> 
>
> Key: GEODE-3184
> URL: https://issues.apache.org/jira/browse/GEODE-3184
> Project: Geode
>  Issue Type: Improvement
>  Components: http session
>Reporter: David Anuta
>Assignee: David Anuta
>Priority: Minor
>
> Would be good to review  the code base and make sure methods are properly 
> organized.
> Also, the previous session replication testing is still in place in the 
> extensions folder. This needs to be reviewed and any tests not covered by 
> cargo should be transferred over into the new cargo replication testing. An 
> example of something within this that needs to be cleaned up would be 
> QueryCommand and CommandServlet classes, which are both in the 
> extensions/geode-modules and extensions/session-testing-war projects. the 
> QueryCommand and Command Servlet class within the extensions/geode-modules 
> project could be removed if the previous session tests were all ported to 
> cargo and then removed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3406) Enable new flow for protocol on locators

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138806#comment-16138806
 ] 

ASF GitHub Bot commented on GEODE-3406:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/716


> Enable new flow for protocol on locators
> 
>
> Key: GEODE-3406
> URL: https://issues.apache.org/jira/browse/GEODE-3406
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server
>Reporter: Brian Baynes
>Assignee: Hitesh Khamesra
>
> Enable magic byte and new flow for new protocol on locators.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3406) Enable new flow for protocol on locators

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138804#comment-16138804
 ] 

ASF subversion and git services commented on GEODE-3406:


Commit fa29ec13f049e39c13ff4e711364e55708ede94d in geode's branch 
refs/heads/develop from [~hitesh.khamesra]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=fa29ec1 ]

Closing pull request for GEODE-3406. Closes #716


> Enable new flow for protocol on locators
> 
>
> Key: GEODE-3406
> URL: https://issues.apache.org/jira/browse/GEODE-3406
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server
>Reporter: Brian Baynes
>Assignee: Hitesh Khamesra
>
> Enable magic byte and new flow for new protocol on locators.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3508) Removed unused internal deprecated classes.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138766#comment-16138766
 ] 

ASF GitHub Bot commented on GEODE-3508:
---

GitHub user PurelyApplied opened a pull request:

https://github.com/apache/geode/pull/734

GEODE-3508: Remove unused internal deprecated classes.

* Update ClusterConfigurationNotAvailableException to extend Exception 
directly, rather than the deprecated class.

--

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [x] Is your initial contribution a single, squashed commit?

- [x] Does `gradlew build` run cleanly?

- [n/a] Have you written or updated unit tests to verify your changes?

- [n/a] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to d...@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/PurelyApplied/geode geode-3508

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/734.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #734


commit 86e6daf53fa1660ea4744415a3d9f613f4b5a3f5
Author: Patrick Rhomberg 
Date:   2017-08-23T17:49:32Z

GEODE-3508: Remove three unused internal deprecated classes.

* Update ClusterConfigurationNotAvailableException to extend Exception 
directly, rather than the deprecated class.




> Removed unused internal deprecated classes.
> ---
>
> Key: GEODE-3508
> URL: https://issues.apache.org/jira/browse/GEODE-3508
> Project: Geode
>  Issue Type: Improvement
>Reporter: Patrick Rhomberg
>
> The following classes are internal, deprecated, and (essentially) unused.
> {noformat}
> geode-core/src/main/java/org/apache/geode/distributed/internal/MessageFactory.java
> geode-core/src/main/java/org/apache/geode/internal/process/ClusterConfigurationNotAvailableException.java
> geode-core/src/main/java/org/apache/geode/management/internal/configuration/utils/DtdResolver.java
> {noformat}
> They may be safely deleted.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (GEODE-3508) Removed unused internal deprecated classes.

[Patrick Rhomberg (JIRA)]

Patrick Rhomberg created GEODE-3508:
---

 Summary: Removed unused internal deprecated classes.
 Key: GEODE-3508
 URL: https://issues.apache.org/jira/browse/GEODE-3508
 Project: Geode
  Issue Type: Improvement
Reporter: Patrick Rhomberg


The following classes are internal, deprecated, and (essentially) unused.

{noformat}
geode-core/src/main/java/org/apache/geode/distributed/internal/MessageFactory.java
geode-core/src/main/java/org/apache/geode/internal/process/ClusterConfigurationNotAvailableException.java
geode-core/src/main/java/org/apache/geode/management/internal/configuration/utils/DtdResolver.java
{noformat}

They may be safely deleted.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (GEODE-3440) Create new geode-example about using functions

[Michael Dodge (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Dodge reassigned GEODE-3440:


Assignee: Michael Dodge

> Create new geode-example about using functions
> --
>
> Key: GEODE-3440
> URL: https://issues.apache.org/jira/browse/GEODE-3440
> Project: Geode
>  Issue Type: New Feature
>  Components: examples
>Reporter: Michael Dodge
>Assignee: Michael Dodge
>
> The more examples, the better. . .
> Create an example that demonstrates how to use a function.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3395) Variable-ize product version and name in user guide

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138723#comment-16138723
 ] 

ASF subversion and git services commented on GEODE-3395:


Commit 1b84ecbe4d942d843cb0d0fa8c2e03eb55f07f39 in geode's branch 
refs/heads/develop from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=1b84ecb ]

GEODE-3395 Variable-ize product version and name in user guide - Managing


>  Variable-ize product version and name in user guide
> 
>
> Key: GEODE-3395
> URL: https://issues.apache.org/jira/browse/GEODE-3395
> Project: Geode
>  Issue Type: New Feature
>  Components: docs
>Reporter: Dave Barnes
>Assignee: Dave Barnes
>
> The Guide contains many occurrences of the product version string ("1.2", 
> "1.1", and "1.0-incubating" are recent examples) scattered over about 900 
> files.  It would be a great convenience to those who write and edit these 
> files to define the version number symbolically so it could be updated in one 
> central location. A template variable in the book's config.yml file would be 
> an obvious candidate for the implementation.
> Similarly, it would be handy to provide symbolic identifiers for the product 
> name, long and short: "Apache Geode" and "Geode", respectively.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (GEODE-3509) Update Gradle Docker Plugin To Work With Gradle 3.X

[Mark Bretl (JIRA)]

Mark Bretl created GEODE-3509:
-

 Summary: Update Gradle Docker Plugin To Work With Gradle 3.X
 Key: GEODE-3509
 URL: https://issues.apache.org/jira/browse/GEODE-3509
 Project: Geode
  Issue Type: Bug
  Components: build
Reporter: Mark Bretl


After updating the Gradle wrapper to 3.5.1, the Docker plugin now fails with 
the error:

Could not find matching constructor for: 
org.gradle.process.internal.worker.DefaultWorkerProcessFactory(org.gradle.api.logging.LogLevel,
 com.pedjak.gradle.plugins.dockerizedtest.DockerizedTestPlugin$MessageServer, 
org.gradle.api.internal.DefaultClassPathRegistry, 
org.gradle.internal.id.LongIdGenerator, java.io.File, 
org.gradle.api.internal.file.TmpDirTemporaryFileProvider, 
com.sun.proxy.$Proxy73)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3508) Removed unused internal deprecated classes.

[Patrick Rhomberg (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138726#comment-16138726
 ] 

Patrick Rhomberg commented on GEODE-3508:
-

This removes MessageFactory, but not the other elements specified in GEODE-285.

> Removed unused internal deprecated classes.
> ---
>
> Key: GEODE-3508
> URL: https://issues.apache.org/jira/browse/GEODE-3508
> Project: Geode
>  Issue Type: Improvement
>Reporter: Patrick Rhomberg
>
> The following classes are internal, deprecated, and (essentially) unused.
> {noformat}
> geode-core/src/main/java/org/apache/geode/distributed/internal/MessageFactory.java
> geode-core/src/main/java/org/apache/geode/internal/process/ClusterConfigurationNotAvailableException.java
> geode-core/src/main/java/org/apache/geode/management/internal/configuration/utils/DtdResolver.java
> {noformat}
> They may be safely deleted.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (GEODE-3385) Change GetAllRequest to return list of errors

[Galen O'Sullivan (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Galen O'Sullivan reassigned GEODE-3385:
---

Assignee: Galen O'Sullivan  (was: Udo Kohlmeyer)

> Change GetAllRequest to return list of errors
> -
>
> Key: GEODE-3385
> URL: https://issues.apache.org/jira/browse/GEODE-3385
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server
>Reporter: Galen O'Sullivan
>Assignee: Galen O'Sullivan
>
> GetAllRequest currently returns a list of successful keys or an error (if 
> getting any key threw an exception). We should instead return a list of 
> errors, similar to PutAllRequest.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3472) Code Cleanup: remove dead code from /management.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138610#comment-16138610
 ] 

ASF GitHub Bot commented on GEODE-3472:
---

Github user pdxrunner commented on a diff in the pull request:

https://github.com/apache/geode/pull/730#discussion_r134804772
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/result/AbstractResultData.java
 ---
@@ -147,11 +147,10 @@ public ResultData addAsFile(String fileName, String 
fileContents, String message
 
   public ResultData addAsFile(String fileName, byte[] data, int fileType, 
String message,
   boolean addTimeStampToName) {
-byte[] bytes = data;
--- End diff --

I stand corrected. I confused myself with past experiences with other 
languages.



> Code Cleanup: remove dead code from /management.
> 
>
> Key: GEODE-3472
> URL: https://issues.apache.org/jira/browse/GEODE-3472
> Project: Geode
>  Issue Type: Improvement
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>
> There is a great deal of dead, commented, and unused code in the codebase.  
> This ticket addresses some of it, limiting scope to those files in 
> `geode-core/**/management/**` to keep the eventual diff relatively small.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3249) Validate internal client/server messages

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138555#comment-16138555
 ] 

ASF subversion and git services commented on GEODE-3249:


Commit c8a365418fd185198b61113991e2947dc69d249e in geode's branch 
refs/heads/release/1.2.1 from [~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=c8a3654 ]

GEODE-3249: Validate internal client/server messages

This is a squashed commit of the following from feature/GEODE-3249b:

commit c16b151e57169733186f0c029d1957da32d59635
"spotless" fixes

commit f8e7ddd5e4696907ce60a14f581ef1ca83e65232

GEODE-3249: Validate internal client/server messages

This was merely a matter of changing the server to require the credentials
and changing the client to send credentials.  I removed the general 
overriding
of AbstractOp.processSecureBytes() because it made no sense.  If the server
sends a secure byte "part" in a message the client is obligated to process
it or the next message it sends will cause a security violation.

I've added a server-side property that folks can set to allow old clients
to continue to work.  This must be used to roll the servers forward to the
new version that contains this change.  Clients must then be rolled
forward & the servers can then be rolled once again without the property 
set.

The system property is
  geode.allow-internal-messages-without-credentials=true

(cherry picked from commit 6be38cad729d56f355c7586ec994bfef933c5e65)


> Validate internal client/server messages
> 
>
> Key: GEODE-3249
> URL: https://issues.apache.org/jira/browse/GEODE-3249
> Project: Geode
>  Issue Type: Bug
>  Components: docs, messaging
>Reporter: Anthony Baker
>Assignee: Karen Smoler Miller
> Fix For: 1.3.0, 1.2.1
>
>
> Some message types can not be invoked directly by an end user.  For 
> validation purposes, we should treat these messages the same way we treat 
> normal messages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3249) Validate internal client/server messages

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138556#comment-16138556
 ] 

ASF subversion and git services commented on GEODE-3249:


Commit c8a365418fd185198b61113991e2947dc69d249e in geode's branch 
refs/heads/release/1.2.1 from [~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=c8a3654 ]

GEODE-3249: Validate internal client/server messages

This is a squashed commit of the following from feature/GEODE-3249b:

commit c16b151e57169733186f0c029d1957da32d59635
"spotless" fixes

commit f8e7ddd5e4696907ce60a14f581ef1ca83e65232

GEODE-3249: Validate internal client/server messages

This was merely a matter of changing the server to require the credentials
and changing the client to send credentials.  I removed the general 
overriding
of AbstractOp.processSecureBytes() because it made no sense.  If the server
sends a secure byte "part" in a message the client is obligated to process
it or the next message it sends will cause a security violation.

I've added a server-side property that folks can set to allow old clients
to continue to work.  This must be used to roll the servers forward to the
new version that contains this change.  Clients must then be rolled
forward & the servers can then be rolled once again without the property 
set.

The system property is
  geode.allow-internal-messages-without-credentials=true

(cherry picked from commit 6be38cad729d56f355c7586ec994bfef933c5e65)


> Validate internal client/server messages
> 
>
> Key: GEODE-3249
> URL: https://issues.apache.org/jira/browse/GEODE-3249
> Project: Geode
>  Issue Type: Bug
>  Components: docs, messaging
>Reporter: Anthony Baker
>Assignee: Karen Smoler Miller
> Fix For: 1.3.0, 1.2.1
>
>
> Some message types can not be invoked directly by an end user.  For 
> validation purposes, we should treat these messages the same way we treat 
> normal messages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3249) Validate internal client/server messages

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138554#comment-16138554
 ] 

ASF subversion and git services commented on GEODE-3249:


Commit c8a365418fd185198b61113991e2947dc69d249e in geode's branch 
refs/heads/release/1.2.1 from [~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=c8a3654 ]

GEODE-3249: Validate internal client/server messages

This is a squashed commit of the following from feature/GEODE-3249b:

commit c16b151e57169733186f0c029d1957da32d59635
"spotless" fixes

commit f8e7ddd5e4696907ce60a14f581ef1ca83e65232

GEODE-3249: Validate internal client/server messages

This was merely a matter of changing the server to require the credentials
and changing the client to send credentials.  I removed the general 
overriding
of AbstractOp.processSecureBytes() because it made no sense.  If the server
sends a secure byte "part" in a message the client is obligated to process
it or the next message it sends will cause a security violation.

I've added a server-side property that folks can set to allow old clients
to continue to work.  This must be used to roll the servers forward to the
new version that contains this change.  Clients must then be rolled
forward & the servers can then be rolled once again without the property 
set.

The system property is
  geode.allow-internal-messages-without-credentials=true

(cherry picked from commit 6be38cad729d56f355c7586ec994bfef933c5e65)


> Validate internal client/server messages
> 
>
> Key: GEODE-3249
> URL: https://issues.apache.org/jira/browse/GEODE-3249
> Project: Geode
>  Issue Type: Bug
>  Components: docs, messaging
>Reporter: Anthony Baker
>Assignee: Karen Smoler Miller
> Fix For: 1.3.0, 1.2.1
>
>
> Some message types can not be invoked directly by an end user.  For 
> validation purposes, we should treat these messages the same way we treat 
> normal messages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3249) Validate internal client/server messages

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138557#comment-16138557
 ] 

ASF subversion and git services commented on GEODE-3249:


Commit 99b0fd6f9b0c73540f46c8c98acc089b67be791d in geode's branch 
refs/heads/release/1.2.1 from [~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=99b0fd6 ]

GEODE-3249: internal messages should require credentials

Removed unnecessary statement in one of the tests added for this ticket.

(cherry picked from commit 7cbbf67f3ae313920421fe24f15a72ce27ea2308)


> Validate internal client/server messages
> 
>
> Key: GEODE-3249
> URL: https://issues.apache.org/jira/browse/GEODE-3249
> Project: Geode
>  Issue Type: Bug
>  Components: docs, messaging
>Reporter: Anthony Baker
>Assignee: Karen Smoler Miller
> Fix For: 1.3.0, 1.2.1
>
>
> Some message types can not be invoked directly by an end user.  For 
> validation purposes, we should treat these messages the same way we treat 
> normal messages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3447) Implement client authorization for the new protocol

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138542#comment-16138542
 ] 

ASF GitHub Bot commented on GEODE-3447:
---

Github user bschuchardt commented on the issue:

https://github.com/apache/geode/pull/719
  
GetAvailableServers will be executed on a Locator which installs a no-op 
authorizer in the execution "context".  That can change if we decide later on 
that we want to perform authentication and authorization on locator requests.


> Implement client authorization for the new protocol
> ---
>
> Key: GEODE-3447
> URL: https://issues.apache.org/jira/browse/GEODE-3447
> Project: Geode
>  Issue Type: New Feature
>  Components: client/server
>Reporter: Brian Baynes
>Assignee: Bruce Schuchardt
>
> As a user of the new client/server protocol, I need to make sure the clients 
> using the protocol to access my grid are authorized to perform each operation 
> they attempt.
> Implement client authorization for operations in new protocol based on 
> existing authorization configuration.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3506) LocatorLauncherRemoteFileIntegrationTest.startDeletesStaleControlFiles fails intermittently with IllegalStateException: Failed to read status file

[Kirk Lund (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138533#comment-16138533
 ] 

Kirk Lund commented on GEODE-3506:
--

I'm unable to reproduce this failure in over 1000 test runs. The failure was 
seen on AWS and was caused by reading zero lines in from a status file that 
should never be empty.

> LocatorLauncherRemoteFileIntegrationTest.startDeletesStaleControlFiles fails 
> intermittently with IllegalStateException: Failed to read status file
> --
>
> Key: GEODE-3506
> URL: https://issues.apache.org/jira/browse/GEODE-3506
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, management
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> {noformat}
> org.apache.geode.distributed.LocatorLauncherRemoteFileIntegrationTest > 
> startDeletesStaleControlFiles FAILED
> java.lang.IllegalStateException: Failed to read status file
> {noformat}
> Full stack trace:
> {noformat}
> java.lang.IllegalStateException: Failed to read status file
> at 
> org.apache.geode.internal.process.FileProcessController.status(FileProcessController.java:152)
> at 
> org.apache.geode.internal.process.FileProcessController.status(FileProcessController.java:89)
> at 
> org.apache.geode.distributed.LocatorLauncher.statusWithWorkingDirectory(LocatorLauncher.java:940)
> at 
> org.apache.geode.distributed.LocatorLauncher.status(LocatorLauncher.java:868)
> at 
> org.apache.geode.distributed.LocatorLauncherRemoteIntegrationTestCase.lambda$awaitStart$1(LocatorLauncherRemoteIntegrationTestCase.java:196)
> at 
> org.awaitility.core.AssertionCondition$1.eval(AssertionCondition.java:55)
> at 
> org.awaitility.core.ConditionAwaiter$ConditionPoller.run(ConditionAwaiter.java:215)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-1211) Multiple Regions using the same DiskStore cause double-counting in the member TotalDiskUsage JMX attribute

[Darrel Schneider (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138492#comment-16138492
 ] 

Darrel Schneider commented on GEODE-1211:
-

I think the bug is in the mbean code. Namely how the MemberMBean class 
aggregates its regions. As Barry's original comment on this bug shows when the 
member has two regions on the same disk store the disk store related stats get 
counted twice at the member level. If it had three regions on the same disk 
store it would be counted 3 times. He also showed that if the regions are on 
different disk stores then they are correctly aggregated at the member level. I 
think the aggregator, AggregateRegionStatsMonitor, needs to be changed in how 
disk stats are aggregated.
The actual bug might be in MemberMBeanBridge.java. It has both a 
"regionMonitor" field and a "diskMonitor" field. The regionMonitor will 
aggregate every region added to it and the current impl gets disk space from 
it. If you search  AggregateRegionStatsMonitor for DISK_SPACE you will see how 
it computes disk space for the DiskDirStats that have been added to it.
I think this method: 
org.apache.geode.management.internal.beans.MemberMBeanBridge.addRegion(Region)
needs to no longer add DiskDirStats when a region is added. Here is the code 
that needs to be removed from addRegion:
{noformat}
DiskRegion dr = l.getDiskRegion();
if (dr != null) {
  for (DirectoryHolder dh : dr.getDirectories()) {
addDirectoryStats(dh.getDiskDirectoryStats());
  }
}
{noformat}
Instead these DirectoryHolder instances need to be obtained from a DiskStore 
when it is added to the member in this method: 
org.apache.geode.management.internal.beans.MemberMBeanBridge.addDiskStore(DiskStore)
 by calling: 
org.apache.geode.internal.cache.DiskStoreImpl.getDirectoryHolders().

You will probably also want to reverse this when this method is called: 
org.apache.geode.management.internal.beans.MemberMBeanBridge.removeDiskStore(DiskStore)

The basic idea is to compute this disk space used from DiskStore instances on a 
member not on Regions on a member. Even if a member has no persistence regions 
it can still have disk stores using disk space (think of our PDX internal impl 
that uses a disk store).

So it seems like this bug is completely in the internal.beans package.

> Multiple Regions using the same DiskStore cause double-counting in the member 
> TotalDiskUsage JMX attribute
> --
>
> Key: GEODE-1211
> URL: https://issues.apache.org/jira/browse/GEODE-1211
> Project: Geode
>  Issue Type: Bug
>  Components: persistence, statistics
>Reporter: Barry Oglesby
>
> Here is what I'm seeing in my simple tests.
> After putting with 1 entries into two persistent replicated regions each 
> using its own disk store:
> {{MemberMBean.getTotalDiskUsage}} totals each disk store bytes on disk 
> properly:
> {noformat}
> MemberMBean.getTotalDiskUsage returning 1298573 bytes
> DiskStoreMBeanBridge.getTotalBytesOnDisk data-rr_store returning 649253 bytes
> DiskStoreMBeanBridge.getTotalBytesOnDisk data2-rr_store returning 649320 bytes
> {noformat}
> After putting with 1 entries into two persistent replicated regions each 
> using the same disk store:
> {{MemberMBean.getTotalDiskUsage}} double-counts the disk store bytes on disk:
> {noformat}
> MemberMBean.getTotalDiskUsage returning 2596956 bytes
> DiskStoreMBeanBridge.getTotalBytesOnDisk data-rr_store returning 1298478 bytes
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)