[jira] [Commented] (GEODE-3136) Replace all public API time values with std::chrono types

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248382#comment-16248382
 ] 

ASF subversion and git services commented on GEODE-3136:


Commit 9fe0782f47f0f58ec98f3873b208437df3e93b32 in geode-native's branch 
refs/heads/develop from Jacob Barrett
[ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=9fe0782 ]

GEODE-3136: Convert time values to std::chrono::duration. (#144)

* GEODE-3136: Convert time values to std::chrono::duration.

- Adds duration utilities.
- XML Schema changes.
- Convert CLI time values to TimeSpan.



> Replace all public API time values with std::chrono types
> -
>
> Key: GEODE-3136
> URL: https://issues.apache.org/jira/browse/GEODE-3136
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>
> Remove ambiguity of time values by using 
> [{{std::chrono}}|http://en.cppreference.com/w/cpp/chrono] types in the public 
> API. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3136) Replace all public API time values with std::chrono types

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248380#comment-16248380
 ] 

ASF subversion and git services commented on GEODE-3136:


Commit 9fe0782f47f0f58ec98f3873b208437df3e93b32 in geode-native's branch 
refs/heads/develop from Jacob Barrett
[ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=9fe0782 ]

GEODE-3136: Convert time values to std::chrono::duration. (#144)

* GEODE-3136: Convert time values to std::chrono::duration.

- Adds duration utilities.
- XML Schema changes.
- Convert CLI time values to TimeSpan.



> Replace all public API time values with std::chrono types
> -
>
> Key: GEODE-3136
> URL: https://issues.apache.org/jira/browse/GEODE-3136
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>
> Remove ambiguity of time values by using 
> [{{std::chrono}}|http://en.cppreference.com/w/cpp/chrono] types in the public 
> API. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-2565) gfsh destroy gateway-sender should be idempotent

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248333#comment-16248333
 ] 

ASF GitHub Bot commented on GEODE-2565:
---

jinmeiliao opened a new pull request #1048: GEODE-2565: add if-exists option to 
DestoryGatewaySenderCommand
URL: https://github.com/apache/geode/pull/1048
 
 
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
   submit an update to your PR as soon as possible. If you need help, please 
send an
   email to d...@geode.apache.org.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> gfsh destroy gateway-sender should be idempotent
> 
>
> Key: GEODE-2565
> URL: https://issues.apache.org/jira/browse/GEODE-2565
> Project: Geode
>  Issue Type: Sub-task
>  Components: gfsh
>Reporter: Swapnil Bawaskar
>
> Currently, running destroy gateway-sender multiple times return the following 
> error:
> {{{
> destroy gateway-sender --id=1
> Member | Status
> -- | -
> serv2  | ERROR: GateWaySender with Id  1 not found
> serv1  | ERROR: GateWaySender with Id  1 not found
> }}}
> We should add a {{--if-exists}} option to destroy gateway-sender command.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3539) Add more test coverage for p2p commands

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248330#comment-16248330
 ] 

ASF subversion and git services commented on GEODE-3539:


Commit e67456dbce7d2781ad40824cb9e20b67bf7c4074 in geode's branch 
refs/heads/develop from [~jinmeiliao]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=e67456d ]

GEODE-3539: cleanup GfshCommand and refactor tests

* remove more try catch blocks in commands
* make GfshCommand a pure wrapper around CliUtil for easy mocking
* unify EntityNotFoundException


> Add more test coverage for p2p commands
> ---
>
> Key: GEODE-3539
> URL: https://issues.apache.org/jira/browse/GEODE-3539
> Project: Geode
>  Issue Type: Improvement
>  Components: gfsh
>Reporter: Jinmei Liao
>
> Add more command tests that would eventually get rid of the legacy tests.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3149) Protobuf protocol module will throw exceptions on some input

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248218#comment-16248218
 ] 

ASF GitHub Bot commented on GEODE-3149:
---

mhansonp commented on a change in pull request #148: GEODE-3149: Removing the 
VectorT.hpp header file and typedefs
URL: https://github.com/apache/geode-native/pull/148#discussion_r150364303
 
 

 ##
 File path: clicache/src/impl/ManagedString.hpp
 ##
 @@ -40,7 +40,7 @@ namespace Apache
 {
 private:
 
-  IntPtr m_str;
+ IntPtr m_str;
 
 Review comment:
   Agreed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Protobuf protocol module will throw exceptions on some input
> 
>
> Key: GEODE-3149
> URL: https://issues.apache.org/jira/browse/GEODE-3149
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Brian Rowe
> Fix For: 1.3.0
>
>
> The protobuf protocol handler needs to be able to handle any input on the 
> incoming socket without crashing.  
> Right now closing the socket will cause a crash as we try to process a 
> message from the empty stream (the bug here might be that the server 
> connection shouldn't be trying to process a message here, but the protocol 
> deserialization still needs to have much better error handling).
> {code:java}
> severe 2017/06/28 13:50:55.565 PDT  
> tid=0x31] Uncaught exception in thread Thread[ServerConnection on port 22514 
> Thread 0,5,ServerConnection on port 22514]
> java.lang.NullPointerException
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.processOneMessage(ProtobufStreamProcessor.java:67)
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.receiveMessage(ProtobufStreamProcessor.java:79)
>   at 
> org.apache.geode.internal.cache.tier.sockets.GenericProtocolServerConnection.doOneMessage(GenericProtocolServerConnection.java:68)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1155)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:552)
>   at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3149) Protobuf protocol module will throw exceptions on some input

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248216#comment-16248216
 ] 

ASF GitHub Bot commented on GEODE-3149:
---

dgkimura commented on a change in pull request #148: GEODE-3149: Removing the 
VectorT.hpp header file and typedefs
URL: https://github.com/apache/geode-native/pull/148#discussion_r150363896
 
 

 ##
 File path: clicache/src/CacheableBuiltins.hpp
 ##
 @@ -386,20 +386,20 @@ namespace Apache
}   
  \
\
internal:   
\
-   static IGeodeSerializable^ Create(native::SerializablePtr obj)  
  \
+   static IGeodeSerializable^ 
Create(std::shared_ptr obj)\
{   
  \
return (obj != nullptr ? gcnew m(obj) : nullptr);   
\
}   
  \
\
private:
\
- inline m(native::SerializablePtr nativeptr)   
 \
+ inline m(std::shared_ptr nativeptr) 
   \
   : CacheableBuiltinKey(nativeptr) { } 
   \
   };
 
 
 #define _GFCLI_CACHEABLE_ARRAY_DEF_NEW(m, mt)  
  \
   ref class m : public CacheableBuiltinArray<\
-native::m, native::m##Ptr, mt, GeodeClassIds::m>  \
 
 Review comment:
   Perhaps I'm missing something.  Why wasn't the line changed to `native::m, 
std::shared_ptr, mt, GeodeClassIds::m>`?  Did you change the second 
parameter in the `CacheableBuiltinArray` template away from a shared_ptr?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Protobuf protocol module will throw exceptions on some input
> 
>
> Key: GEODE-3149
> URL: https://issues.apache.org/jira/browse/GEODE-3149
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Brian Rowe
> Fix For: 1.3.0
>
>
> The protobuf protocol handler needs to be able to handle any input on the 
> incoming socket without crashing.  
> Right now closing the socket will cause a crash as we try to process a 
> message from the empty stream (the bug here might be that the server 
> connection shouldn't be trying to process a message here, but the protocol 
> deserialization still needs to have much better error handling).
> {code:java}
> severe 2017/06/28 13:50:55.565 PDT  
> tid=0x31] Uncaught exception in thread Thread[ServerConnection on port 22514 
> Thread 0,5,ServerConnection on port 22514]
> java.lang.NullPointerException
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.processOneMessage(ProtobufStreamProcessor.java:67)
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.receiveMessage(ProtobufStreamProcessor.java:79)
>   at 
> org.apache.geode.internal.cache.tier.sockets.GenericProtocolServerConnection.doOneMessage(GenericProtocolServerConnection.java:68)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1155)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:552)
>   at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3149) Protobuf protocol module will throw exceptions on some input

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248213#comment-16248213
 ] 

ASF GitHub Bot commented on GEODE-3149:
---

pivotal-jbarrett commented on a change in pull request #148: GEODE-3149: 
Removing the VectorT.hpp header file and typedefs
URL: https://github.com/apache/geode-native/pull/148#discussion_r150363582
 
 

 ##
 File path: .gitignore
 ##
 @@ -4,3 +4,6 @@
 /.settings/
 /.cproject
 /.project
+/.idea/
+/Testing/
 
 Review comment:
   Do not ignore personal directories like this. Ignoring `.idea` is acceptable 
since it is created by a commonly used IDE.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Protobuf protocol module will throw exceptions on some input
> 
>
> Key: GEODE-3149
> URL: https://issues.apache.org/jira/browse/GEODE-3149
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Brian Rowe
> Fix For: 1.3.0
>
>
> The protobuf protocol handler needs to be able to handle any input on the 
> incoming socket without crashing.  
> Right now closing the socket will cause a crash as we try to process a 
> message from the empty stream (the bug here might be that the server 
> connection shouldn't be trying to process a message here, but the protocol 
> deserialization still needs to have much better error handling).
> {code:java}
> severe 2017/06/28 13:50:55.565 PDT  
> tid=0x31] Uncaught exception in thread Thread[ServerConnection on port 22514 
> Thread 0,5,ServerConnection on port 22514]
> java.lang.NullPointerException
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.processOneMessage(ProtobufStreamProcessor.java:67)
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.receiveMessage(ProtobufStreamProcessor.java:79)
>   at 
> org.apache.geode.internal.cache.tier.sockets.GenericProtocolServerConnection.doOneMessage(GenericProtocolServerConnection.java:68)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1155)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:552)
>   at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3007) Simplify support for custom GFSH commands

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248208#comment-16248208
 ] 

ASF GitHub Bot commented on GEODE-3007:
---

PurelyApplied commented on a change in pull request #1042: GEODE-3007: Simplify 
support for custom GFSH commands
URL: https://github.com/apache/geode/pull/1042#discussion_r150362984
 
 

 ##
 File path: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/GfshParser.java
 ##
 @@ -57,10 +57,14 @@ public GfshParser(CommandManager commandManager) {
   add(command);
 }
 
-for (Converter converter : commandManager.getConverters()) {
+for (Converter converter : commandManager.getConverters()) {
   if (converter.getClass().isAssignableFrom(ArrayConverter.class)) {
 ArrayConverter arrayConverter = (ArrayConverter) converter;
-arrayConverter.setConverters(new 
HashSet<>(commandManager.getConverters()));
+HashSet converters = new HashSet<>();
+for (Converter c : commandManager.getConverters()) {
+  converters.add(c);
+}
+arrayConverter.setConverters(converters);
 
 Review comment:
   Also, just for the record: all of the above is predicated on a hazy 
understanding of the difference between `Converter` and `Converter`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Simplify support for custom GFSH commands
> -
>
> Key: GEODE-3007
> URL: https://issues.apache.org/jira/browse/GEODE-3007
> Project: Geode
>  Issue Type: Improvement
>  Components: docs, gfsh
>Reporter: Jared Stewart
>Assignee: Jared Stewart
>
> Geode currently supports three ways to load GFSH commands: 
> 1. Scan the classpath for commands in 
> "org.apache.geode.management.internal.cli.commands”
> 2. Scan the classpath for commands in a package specified by a user via the 
> “user-command-packages” system property. 
> 3. Scan the classpath for commands registered in files inside 
> META-INF.services (e.g. 
> "geode-core/src/test/resources/META-INF/services/org.springframework.shell.core.CommandMarker”)
>  
> After the improvements made by GEODE-2989, there is no reason to require a 
> user to specify the location of their custom commands via one of these 
> mechanisms.  Instead, we should simply scan the entire classpath for any 
> classes implementing CommandMarker (regardless of whatever packages they live 
> in).  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3149) Protobuf protocol module will throw exceptions on some input

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248205#comment-16248205
 ] 

ASF GitHub Bot commented on GEODE-3149:
---

pivotal-jbarrett commented on a change in pull request #148: GEODE-3149: 
Removing the VectorT.hpp header file and typedefs
URL: https://github.com/apache/geode-native/pull/148#discussion_r150362727
 
 

 ##
 File path: clicache/src/LocalRegion.cpp
 ##
 @@ -893,7 +893,7 @@ namespace Apache
 
 _GF_MG_EXCEPTION_TRY2/* due to auto replace */
 
-   
std::vector vc;
 
 Review comment:
   Your editor is using TAB not SPACE.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Protobuf protocol module will throw exceptions on some input
> 
>
> Key: GEODE-3149
> URL: https://issues.apache.org/jira/browse/GEODE-3149
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Brian Rowe
> Fix For: 1.3.0
>
>
> The protobuf protocol handler needs to be able to handle any input on the 
> incoming socket without crashing.  
> Right now closing the socket will cause a crash as we try to process a 
> message from the empty stream (the bug here might be that the server 
> connection shouldn't be trying to process a message here, but the protocol 
> deserialization still needs to have much better error handling).
> {code:java}
> severe 2017/06/28 13:50:55.565 PDT  
> tid=0x31] Uncaught exception in thread Thread[ServerConnection on port 22514 
> Thread 0,5,ServerConnection on port 22514]
> java.lang.NullPointerException
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.processOneMessage(ProtobufStreamProcessor.java:67)
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.receiveMessage(ProtobufStreamProcessor.java:79)
>   at 
> org.apache.geode.internal.cache.tier.sockets.GenericProtocolServerConnection.doOneMessage(GenericProtocolServerConnection.java:68)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1155)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:552)
>   at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3007) Simplify support for custom GFSH commands

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248200#comment-16248200
 ] 

ASF GitHub Bot commented on GEODE-3007:
---

PurelyApplied commented on a change in pull request #1042: GEODE-3007: Simplify 
support for custom GFSH commands
URL: https://github.com/apache/geode/pull/1042#discussion_r150362381
 
 

 ##
 File path: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/GfshParser.java
 ##
 @@ -57,10 +57,14 @@ public GfshParser(CommandManager commandManager) {
   add(command);
 }
 
-for (Converter converter : commandManager.getConverters()) {
+for (Converter converter : commandManager.getConverters()) {
   if (converter.getClass().isAssignableFrom(ArrayConverter.class)) {
 ArrayConverter arrayConverter = (ArrayConverter) converter;
-arrayConverter.setConverters(new 
HashSet<>(commandManager.getConverters()));
+HashSet converters = new HashSet<>();
+for (Converter c : commandManager.getConverters()) {
+  converters.add(c);
+}
+arrayConverter.setConverters(converters);
 
 Review comment:
   At the very least, that should be a `Set` and not a `HashSet` on the left.
   
   If we wanted to collapse this into a `stream`, we could.
   
   ```
   Set converters = new HashSet<>();
   for (Converter c : commandManager.getConverters()) {
 converters.add(c);
   }
   ```
   It seems to me that this is just doing some strange workaround to get a set 
of `Converter` to a set of `Converter`.  That could be rewritten as
   ```
   Set converters = 
commandManager.getConverters().stream().map(c -> (Converter) c).collect(
   Collectors.toSet());
   ```
   
   But at that point, the whole loop would go from
   ```
   for (Converter converter : commandManager.getConverters()) {
 if (converter.getClass().isAssignableFrom(ArrayConverter.class)) {
   ArrayConverter arrayConverter = (ArrayConverter) converter;
   Set converters = 
commandManager.getConverters().stream().map(c -> (Converter) c).collect(
   Collectors.toSet());
   arrayConverter.setConverters(converters);
 }
 add(converter);
   }
   ```
   to
   ```
  commandManager.getConverters()
   .stream()
   .filter(converter -> 
converter.getClass().isAssignableFrom(ArrayConverter.class))
   .forEach(converter ->
   ((ArrayConverter) converter).setConverters(
 commandManager.getConverters().stream().map(
 c -> (Converter) c).collect(
   Collectors.toSet(;
   commandManager.getConverters().forEach(this::add);
   ```
   with the caveat that the `add(converter)` is now happening for each after 
the others have been addressed, and not in the middle of the loop.  But I don't 
think that should really matter, should it..?
   
   Looking at that, I don't really believe it to be more readable than the 
first code block in this comment.  So probably split the difference, with
   ```
   for (Converter converter : commandManager.getConverters()) {
 if (converter.getClass().isAssignableFrom(ArrayConverter.class)) {
   ArrayConverter arrayConverter = (ArrayConverter) converter;
   arrayConverter.setConverters(
   commandManager.getConverters().stream()
   .map(c -> (Converter) c).collect(Collectors.toSet()));
 }
 add(converter);
   }
   ```
   
   I don't know.  I guess you could one step farther and reduce to
   ```
   for (Converter converter : commandManager.getConverters()) {
 if (converter.getClass().isAssignableFrom(ArrayConverter.class)) {
   ((ArrayConverter) converter).setConverters(
   commandManager.getConverters().stream()
   .map(c -> (Converter) c).collect(Collectors.toSet()));
 }
 add(converter);
   }
   ```
   but I personally don't like one-lining casts and method calls.
   
   ...
   
   This comment got a lot bigger than I originally intended...


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Simplify support for custom GFSH commands
> -
>
> Key: GEODE-3007
> URL: https://issues.apache.org/jira/browse/GEODE-3007
> Project: Geode
>  Issue Type: Improvement
>  Components: docs, gfsh
>Reporter: Jared Stewart
>Assignee: Jared Stewart
>
> Geode currently 

[jira] [Commented] (GEODE-3420) Remove all .inl files

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248199#comment-16248199
 ] 

ASF GitHub Bot commented on GEODE-3420:
---

pivotal-jbarrett commented on issue #143: GEODE-3420: Remove inline header files
URL: https://github.com/apache/geode-native/pull/143#issuecomment-343616877
 
 
   I am cool with the changes here as is.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Remove all .inl files
> -
>
> Key: GEODE-3420
> URL: https://issues.apache.org/jira/browse/GEODE-3420
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Addison
>
> Remove all .inc files in favor of a more readable format to describe includes 
> and templates.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3420) Remove all .inl files

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248198#comment-16248198
 ] 

ASF GitHub Bot commented on GEODE-3420:
---

pivotal-jbarrett commented on a change in pull request #143: GEODE-3420: Remove 
inline header files
URL: https://github.com/apache/geode-native/pull/143#discussion_r150361916
 
 

 ##
 File path: cppcache/include/geode/CacheableString.hpp
 ##
 @@ -308,6 +308,31 @@ inline CacheablePtr createValueArr(const wchar_t* value) {
   return CacheableString::create(value);
 }
 
+template 
+inline CacheablePtr createValue(const TVALUE* value) {
+  return CacheableString::create(value);
+}
 
 Review comment:
   I am just curious how it handles matching say `int*` since it lacks any 
conditional traits. I suppose our changes to `std::string` will address this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Remove all .inl files
> -
>
> Key: GEODE-3420
> URL: https://issues.apache.org/jira/browse/GEODE-3420
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Addison
>
> Remove all .inc files in favor of a more readable format to describe includes 
> and templates.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3420) Remove all .inl files

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248185#comment-16248185
 ] 

ASF GitHub Bot commented on GEODE-3420:
---

pivotal-jbarrett commented on a change in pull request #143: GEODE-3420: Remove 
inline header files
URL: https://github.com/apache/geode-native/pull/143#discussion_r150361766
 
 

 ##
 File path: cppcache/include/geode/Cacheable.hpp
 ##
 @@ -35,10 +35,10 @@ typedef SerializablePtr CacheablePtr;
 typedef Serializable Cacheable;
 
 template 
-inline CacheablePtr createValue(const std::shared_ptr& value);
+inline CacheablePtr createValue(const std::shared_ptr& value) {
 
 Review comment:
   We can correct this in a different ticket. How about you open one to address 
the ambiguity here.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Remove all .inl files
> -
>
> Key: GEODE-3420
> URL: https://issues.apache.org/jira/browse/GEODE-3420
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Addison
>
> Remove all .inc files in favor of a more readable format to describe includes 
> and templates.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3136) Replace all public API time values with std::chrono types

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248170#comment-16248170
 ] 

ASF GitHub Bot commented on GEODE-3136:
---

pivotal-jbarrett commented on a change in pull request #144: GEODE-3136: 
Convert time values to std::chrono::duration.
URL: https://github.com/apache/geode-native/pull/144#discussion_r150359976
 
 

 ##
 File path: cppcache/src/LocalRegion.cpp
 ##
 @@ -346,15 +348,16 @@ void LocalRegion::localPut(const CacheableKeyPtr& key,
   GfErrTypeToException("Region::localPut", err);
 }
 
-void LocalRegion::putAll(const HashMapOfCacheable& map, uint32_t timeout,
+void LocalRegion::putAll(const HashMapOfCacheable& map,
+ std::chrono::milliseconds timeout,
  const SerializablePtr& aCallbackArgument) {
-  if ((timeout * 1000) >= 0x7fff) {
-throw IllegalArgumentException(
-"Region::putAll: timeout parameter "
-"greater than maximum allowed (2^31/1000 i.e 2147483).");
-  }
-  int64_t sampleStartNanos = startStatOpTime();
-  GfErrType err = putAllNoThrow(map, timeout, aCallbackArgument);
+  //  if ((timeout * 1000) >= 0x7fff) {
 
 Review comment:
   @dgkimura Fixed in 
https://github.com/apache/geode-native/pull/144/commits/91a47a9f898921932ec037704bde43edf3ba04b4


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Replace all public API time values with std::chrono types
> -
>
> Key: GEODE-3136
> URL: https://issues.apache.org/jira/browse/GEODE-3136
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>
> Remove ambiguity of time values by using 
> [{{std::chrono}}|http://en.cppreference.com/w/cpp/chrono] types in the public 
> API. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3136) Replace all public API time values with std::chrono types

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248168#comment-16248168
 ] 

ASF GitHub Bot commented on GEODE-3136:
---

pivotal-jbarrett commented on a change in pull request #144: GEODE-3136: 
Convert time values to std::chrono::duration.
URL: https://github.com/apache/geode-native/pull/144#discussion_r150359809
 
 

 ##
 File path: tests/cli/NewFwkLib/FunctionExecution/MyResultCollector.cs
 ##
 @@ -52,48 +52,47 @@ public MyResultCollector()
 public void AddResult(TResult result)
 {
   m_addResultCount++;
-  //CacheableArrayList rs = result as CacheableArrayList;
-  //List rs = result as List;
-  //for (int i = 0; i < rs.Count; i++)
-  //{
-  //  m_results.Add(rs[i]);
-  //}
   m_results.Add(result);
 }
 public ICollection GetResult()
 {
-  return GetResult(50);
+  return GetResult(TimeSpan.FromSeconds(50));
 }
-public ICollection GetResult(UInt32 timeout)
+public ICollection GetResult(TimeSpan timeout)
 {
   m_getResultCount++;
-  if (m_resultReady == true)
-  {
-return m_results;
-  }
-  else
+
+  lock(this)
   {
-for (int i = 0; i < timeout; i++)
+if (!m_resultReady)
 {
-  Thread.Sleep(1000);
-  if (m_resultReady == true)
-  {
-return m_results;
+  if (timeout > TimeSpan.Zero) {
+if (!Monitor.Wait(this, timeout)) {
+  throw new FunctionExecutionException("Timeout waiting for 
result.");
+}
+  } else {
+throw new FunctionExecutionException("Results not ready.");
   }
 }
-throw new FunctionExecutionException(
-   "Result is not ready, endResults callback is called before 
invoking getResult() method");
-
   }
+
+  return m_results;
 }
+
 public void EndResults()
 {
   m_endResultCount++;
-  m_resultReady = true;
+
+  lock (this) {
+m_resultReady = true;
+Monitor.Pulse(this);
+  }
 }
+
 public void ClearResults(/*bool unused*/)
 {
   m_results.Clear();
+  m_resultReady = false;
 
 Review comment:
   Original code doesn't even reset the ready flag. Synching on the flag isn't 
necessary because the same thread resetting here will be the same thread 
checking it later if the collector is reused. For completeness we could sync.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Replace all public API time values with std::chrono types
> -
>
> Key: GEODE-3136
> URL: https://issues.apache.org/jira/browse/GEODE-3136
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>
> Remove ambiguity of time values by using 
> [{{std::chrono}}|http://en.cppreference.com/w/cpp/chrono] types in the public 
> API. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3136) Replace all public API time values with std::chrono types

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248165#comment-16248165
 ] 

ASF GitHub Bot commented on GEODE-3136:
---

pivotal-jbarrett commented on a change in pull request #144: GEODE-3136: 
Convert time values to std::chrono::duration.
URL: https://github.com/apache/geode-native/pull/144#discussion_r150359570
 
 

 ##
 File path: clicache/integration-test/ThinClientFunctionExecutionTestsN.cs
 ##
 @@ -61,43 +61,44 @@ public void AddResult(TResult result)
 }
 public ICollection GetResult()
 {
-  return GetResult(50);
+  return GetResult(TimeSpan.FromSeconds(50));
 }
-
-public ICollection GetResult(UInt32 timeout) 
+public ICollection GetResult(TimeSpan timeout)
 {
   m_getResultCount++;
-  if (m_resultReady == true)
-  {
-return m_results;
-  }
-  else
-  {
-for (int i = 0; i < timeout; i++)
-{
-  Thread.Sleep(1000);
-  if (m_resultReady == true)
-  {
-return m_results;
-  }
 
+  lock (this) {
+if (!m_resultReady) {
+  if (timeout > TimeSpan.Zero) {
+if (!Monitor.Wait(this, timeout)) {
+  throw new FunctionExecutionException("Timeout waiting for 
result.");
+}
+  } else {
+throw new FunctionExecutionException("Results not ready.");
+  }
 }
-throw new FunctionExecutionException(
-   "Result is not ready, endResults callback is called before 
invoking getResult() method");
-
   }
+
+  return m_results;
 }
+
 public void EndResults()
 {
   m_endResultCount++;
-  m_resultReady = true;
+
+  lock (this) {
+m_resultReady = true;
+Monitor.Pulse(this);
+  }
 }
+
 public void ClearResults(/*bool unused*/)
 
 Review comment:
   Called only by tests as far as I can see. Not sure the intent outside of 
what the docs say about it being called by client users before subsequent calls 
to execute using the same collector.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Replace all public API time values with std::chrono types
> -
>
> Key: GEODE-3136
> URL: https://issues.apache.org/jira/browse/GEODE-3136
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>
> Remove ambiguity of time values by using 
> [{{std::chrono}}|http://en.cppreference.com/w/cpp/chrono] types in the public 
> API. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3136) Replace all public API time values with std::chrono types

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248159#comment-16248159
 ] 

ASF GitHub Bot commented on GEODE-3136:
---

mhansonp commented on a change in pull request #144: GEODE-3136: Convert time 
values to std::chrono::duration.
URL: https://github.com/apache/geode-native/pull/144#discussion_r150359110
 
 

 ##
 File path: cppcache/include/geode/ResultCollector.hpp
 ##
 @@ -20,10 +15,17 @@
  * limitations under the License.
  */
 
+#pragma once
+
+#ifndef GEODE_RESULTCOLLECTOR_H_
+#define GEODE_RESULTCOLLECTOR_H_
+
+#include 
 
 Review comment:
   global_types.h includes 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Replace all public API time values with std::chrono types
> -
>
> Key: GEODE-3136
> URL: https://issues.apache.org/jira/browse/GEODE-3136
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>
> Remove ambiguity of time values by using 
> [{{std::chrono}}|http://en.cppreference.com/w/cpp/chrono] types in the public 
> API. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3136) Replace all public API time values with std::chrono types

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248158#comment-16248158
 ] 

ASF GitHub Bot commented on GEODE-3136:
---

pivotal-jbarrett commented on a change in pull request #144: GEODE-3136: 
Convert time values to std::chrono::duration.
URL: https://github.com/apache/geode-native/pull/144#discussion_r150359042
 
 

 ##
 File path: cppcache/include/geode/Pool.hpp
 ##
 @@ -20,8 +15,16 @@
  * limitations under the License.
  */
 
+#pragma once
+
+#ifndef GEODE_POOL_H_
+#define GEODE_POOL_H_
+
 
 Review comment:
   `#pragma once` is not a C++ standard and is not supported in all compilers.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Replace all public API time values with std::chrono types
> -
>
> Key: GEODE-3136
> URL: https://issues.apache.org/jira/browse/GEODE-3136
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>
> Remove ambiguity of time values by using 
> [{{std::chrono}}|http://en.cppreference.com/w/cpp/chrono] types in the public 
> API. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3136) Replace all public API time values with std::chrono types

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248157#comment-16248157
 ] 

ASF GitHub Bot commented on GEODE-3136:
---

pivotal-jbarrett commented on a change in pull request #144: GEODE-3136: 
Convert time values to std::chrono::duration.
URL: https://github.com/apache/geode-native/pull/144#discussion_r150358900
 
 

 ##
 File path: cppcache/include/geode/ResultCollector.hpp
 ##
 @@ -20,10 +15,17 @@
  * limitations under the License.
  */
 
+#pragma once
+
+#ifndef GEODE_RESULTCOLLECTOR_H_
+#define GEODE_RESULTCOLLECTOR_H_
+
+#include 
 
 Review comment:
   I am not sure what mean here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Replace all public API time values with std::chrono types
> -
>
> Key: GEODE-3136
> URL: https://issues.apache.org/jira/browse/GEODE-3136
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>
> Remove ambiguity of time values by using 
> [{{std::chrono}}|http://en.cppreference.com/w/cpp/chrono] types in the public 
> API. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3572) Update ACE to 6.4.5

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248155#comment-16248155
 ] 

ASF subversion and git services commented on GEODE-3572:


Commit cc60c30832bdf8194ef79b9599ca53b63ef3bf7a in geode-native's branch 
refs/heads/develop from [~dkimura]
[ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=cc60c30 ]

GEODE-3572: Update to ACE 6.4.5 (#146)



> Update ACE to 6.4.5
> ---
>
> Key: GEODE-3572
> URL: https://issues.apache.org/jira/browse/GEODE-3572
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: Jacob S. Barrett
>
> Updating to ACE 6.4.5 adds support for OpenSSL 1.1 and future 1.2 LTS. I 
> suggest we upgrade as OpenSSL 1.0.x line is being replaced with 1.1/2 line.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3872) Consolidate GfshShellConnectionRule assertions

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248154#comment-16248154
 ] 

ASF subversion and git services commented on GEODE-3872:


Commit 36408b72b8a629896842fcc1dcae04c939cccda7 in geode's branch 
refs/heads/develop from [~jinmeiliao]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=36408b7 ]

GEODE-3872: simplify the Command result Assert (#1043)

* GEODE-3872: simplify the Command result Assert


> Consolidate GfshShellConnectionRule assertions
> --
>
> Key: GEODE-3872
> URL: https://issues.apache.org/jira/browse/GEODE-3872
> Project: Geode
>  Issue Type: Improvement
>  Components: gfsh, tests
>Reporter: Jared Stewart
>Assignee: Jared Stewart
> Fix For: 1.4.0
>
>
> We have started to accumulate several flavors of _executeCommand_ methods on 
> GfshShellConnectionRule that implicitly make certain kinds of assertions.  
> (For example, assertions on the command result status or on the output text.) 
>  It would make the code more maintainable to separate the various assertion 
> methods into a separate class and to have a single executeCommand method.
> (See e.g. 
> http://joel-costigliola.github.io/assertj/assertj-core-custom-assertions.html#custom-assertion-class)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3872) Consolidate GfshShellConnectionRule assertions

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248152#comment-16248152
 ] 

ASF GitHub Bot commented on GEODE-3872:
---

jinmeiliao closed pull request #1043: GEODE-3872: simplify the Command result 
Assert
URL: https://github.com/apache/geode/pull/1043
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DestroyRegionCommandTest.java
 
b/geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DestroyRegionCommandTest.java
index b519c8d423..7cfe1263a5 100644
--- 
a/geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DestroyRegionCommandTest.java
+++ 
b/geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DestroyRegionCommandTest.java
@@ -31,6 +31,7 @@
 import org.apache.geode.internal.cache.InternalCache;
 import org.apache.geode.management.cli.Result;
 import org.apache.geode.management.internal.cli.result.CommandResult;
+import org.apache.geode.test.junit.assertions.CommandResultAssert;
 import org.apache.geode.test.junit.categories.UnitTest;
 import org.apache.geode.test.junit.rules.GfshParserRule;
 
@@ -68,9 +69,10 @@ public void invalidRegion() throws Exception {
   public void whenNoRegionIsFoundOnAnyMembers() throws Exception {
 doReturn(Collections.emptySet()).when(command).findMembersForRegion(any(), 
any());
 result = parser.executeCommandWithInstance(command, "destroy region 
--name=test");
-assertThat(result.getStatus()).isEqualTo(Result.Status.ERROR);
+new CommandResultAssert(result).statusIsError()
+.containsOutput("Could not find a Region with Region path");
 
 result = parser.executeCommandWithInstance(command, "destroy region 
--name=test --if-exists");
-assertThat(result.getStatus()).isEqualTo(Result.Status.OK);
+new CommandResultAssert(result).statusIsSuccess();
   }
 }
diff --git 
a/geode-core/src/test/java/org/apache/geode/test/junit/assertions/GfshShellConnectionRuleAssert.java
 
b/geode-core/src/test/java/org/apache/geode/test/junit/assertions/CommandResultAssert.java
similarity index 80%
rename from 
geode-core/src/test/java/org/apache/geode/test/junit/assertions/GfshShellConnectionRuleAssert.java
rename to 
geode-core/src/test/java/org/apache/geode/test/junit/assertions/CommandResultAssert.java
index 79d54d9c86..f23326ba67 100644
--- 
a/geode-core/src/test/java/org/apache/geode/test/junit/assertions/GfshShellConnectionRuleAssert.java
+++ 
b/geode-core/src/test/java/org/apache/geode/test/junit/assertions/CommandResultAssert.java
@@ -17,8 +17,6 @@
 import static org.assertj.core.api.Assertions.assertThat;
 
 import java.util.Arrays;
-import java.util.List;
-import java.util.Optional;
 
 import org.assertj.core.api.AbstractAssert;
 import org.assertj.core.api.Assertions;
@@ -27,14 +25,18 @@
 import org.apache.geode.management.cli.Result;
 import org.apache.geode.management.internal.cli.json.GfJsonObject;
 import org.apache.geode.management.internal.cli.result.CommandResult;
-import org.apache.geode.test.junit.rules.GfshShellConnectionRule;
 
 
-public class GfshShellConnectionRuleAssert
-extends AbstractAssert {
-  public GfshShellConnectionRuleAssert(GfshShellConnectionRule gfsh, 
CommandResult commandResult) {
-super(new GfshShellConnectionRuleExecution(gfsh, commandResult),
-GfshShellConnectionRuleAssert.class);
+public class CommandResultAssert
+extends AbstractAssert {
+
+  public CommandResultAssert(CommandResult commandResult) {
+super(new CommandResultExecution(commandResult.toJson(), commandResult),
+CommandResultAssert.class);
+  }
+
+  public CommandResultAssert(String output, CommandResult commandResult) {
+super(new CommandResultExecution(output, commandResult), 
CommandResultAssert.class);
   }
 
   /**
@@ -57,8 +59,8 @@ public GfshShellConnectionRuleAssert(GfshShellConnectionRule 
gfsh, CommandResult
*  containsKeyValuePair("Key Class", "java.lang.String"); 
* 
*/
-  public GfshShellConnectionRuleAssert containsKeyValuePair(String key, String 
value) {
-assertThat(actual.getGfshOutput()).containsPattern(key + "\\s+: " + value);
+  public CommandResultAssert containsKeyValuePair(String key, String value) {
+assertThat(actual.getOutput()).containsPattern(key + "\\s+: " + value);
 
 return this;
   }
@@ -66,9 +68,9 @@ public GfshShellConnectionRuleAssert 
containsKeyValuePair(String key, String val
   /**
* Verifies the gfsh output contains the given output
*/
-  public 

[jira] [Commented] (GEODE-3572) Update ACE to 6.4.5

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248156#comment-16248156
 ] 

ASF GitHub Bot commented on GEODE-3572:
---

dgkimura closed pull request #146: GEODE-3572: Update to ACE 6.4.5
URL: https://github.com/apache/geode-native/pull/146
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/dependencies/ACE/CMakeLists.txt b/dependencies/ACE/CMakeLists.txt
index 2adf2f35..e351ec10 100644
--- a/dependencies/ACE/CMakeLists.txt
+++ b/dependencies/ACE/CMakeLists.txt
@@ -15,8 +15,8 @@
 
 project( ACE )
 
-set( ${PROJECT_NAME}_VERSION 6.4.4 )
-set( ${PROJECT_NAME}_SHA265 
95d6c36b7f5f410006e54fe47c8912cf88fe82738bf4baf4a370fac8c716213b )
+set( ${PROJECT_NAME}_VERSION 6.4.5 )
+set( ${PROJECT_NAME}_SHA265 
8e10b2d6c72fd7cf1dc08d1114be1e4dedf54b67aea3f36c497ae87c9463ff5d )
 string(REPLACE "." "_" _VERSION_UNDERSCORE ${${PROJECT_NAME}_VERSION})
 set( ${PROJECT_NAME}_URL 
"https://github.com/DOCGroup/ACE_TAO/releases/download/ACE%2BTAO-${_VERSION_UNDERSCORE}/ACE.tar.gz;
 )
 set( ${PROJECT_NAME}_EXTERN ${PROJECT_NAME}-extern )


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Update ACE to 6.4.5
> ---
>
> Key: GEODE-3572
> URL: https://issues.apache.org/jira/browse/GEODE-3572
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: Jacob S. Barrett
>
> Updating to ACE 6.4.5 adds support for OpenSSL 1.1 and future 1.2 LTS. I 
> suggest we upgrade as OpenSSL 1.0.x line is being replaced with 1.1/2 line.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3872) Consolidate GfshShellConnectionRule assertions

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248153#comment-16248153
 ] 

ASF subversion and git services commented on GEODE-3872:


Commit 36408b72b8a629896842fcc1dcae04c939cccda7 in geode's branch 
refs/heads/develop from [~jinmeiliao]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=36408b7 ]

GEODE-3872: simplify the Command result Assert (#1043)

* GEODE-3872: simplify the Command result Assert


> Consolidate GfshShellConnectionRule assertions
> --
>
> Key: GEODE-3872
> URL: https://issues.apache.org/jira/browse/GEODE-3872
> Project: Geode
>  Issue Type: Improvement
>  Components: gfsh, tests
>Reporter: Jared Stewart
>Assignee: Jared Stewart
> Fix For: 1.4.0
>
>
> We have started to accumulate several flavors of _executeCommand_ methods on 
> GfshShellConnectionRule that implicitly make certain kinds of assertions.  
> (For example, assertions on the command result status or on the output text.) 
>  It would make the code more maintainable to separate the various assertion 
> methods into a separate class and to have a single executeCommand method.
> (See e.g. 
> http://joel-costigliola.github.io/assertj/assertj-core-custom-assertions.html#custom-assertion-class)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3149) Protobuf protocol module will throw exceptions on some input

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248116#comment-16248116
 ] 

ASF GitHub Bot commented on GEODE-3149:
---

dgkimura commented on a change in pull request #148: GEODE-3149: Removing the 
VectorT.hpp header file and typedefs
URL: https://github.com/apache/geode-native/pull/148#discussion_r150353786
 
 

 ##
 File path: cppcache/include/geode/PersistenceManager.hpp
 ##
 @@ -132,8 +133,12 @@ class CPPCACHE_EXPORT PersistenceManager {
  protected:
   /** Region for this persistence manager.
*/
-  const RegionPtr m_regionPtr;
+  const std::shared_ptr m_regionPtr;
 };
+
+
+typedef std::shared_ptr (*getPersistenceManagerInstance)(
 
 Review comment:
   Seems like this is defined twice


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Protobuf protocol module will throw exceptions on some input
> 
>
> Key: GEODE-3149
> URL: https://issues.apache.org/jira/browse/GEODE-3149
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Brian Rowe
> Fix For: 1.3.0
>
>
> The protobuf protocol handler needs to be able to handle any input on the 
> incoming socket without crashing.  
> Right now closing the socket will cause a crash as we try to process a 
> message from the empty stream (the bug here might be that the server 
> connection shouldn't be trying to process a message here, but the protocol 
> deserialization still needs to have much better error handling).
> {code:java}
> severe 2017/06/28 13:50:55.565 PDT  
> tid=0x31] Uncaught exception in thread Thread[ServerConnection on port 22514 
> Thread 0,5,ServerConnection on port 22514]
> java.lang.NullPointerException
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.processOneMessage(ProtobufStreamProcessor.java:67)
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.receiveMessage(ProtobufStreamProcessor.java:79)
>   at 
> org.apache.geode.internal.cache.tier.sockets.GenericProtocolServerConnection.doOneMessage(GenericProtocolServerConnection.java:68)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1155)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:552)
>   at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (GEODE-3560) Document creation of a non-Java client w/ new protocol

[Brian Baynes (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brian Baynes reassigned GEODE-3560:
---

Assignee: Jens Deppe

> Document creation of a non-Java client w/ new protocol
> --
>
> Key: GEODE-3560
> URL: https://issues.apache.org/jira/browse/GEODE-3560
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server
>Reporter: Brian Baynes
>Assignee: Jens Deppe
>
> Alongside GEODE-3551 (update wiki on how to implement a new client), it will 
> be helpful for devs to see a simple, working example of a client using the 
> new protocol.
> Create a simple client using something other than Java (or C#), documenting 
> the steps.
> At a minimum, implement connection, authentication, get servers from locator, 
> get, and put.
> Update the wiki with the results.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3149) Protobuf protocol module will throw exceptions on some input

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248103#comment-16248103
 ] 

ASF GitHub Bot commented on GEODE-3149:
---

mhansonp commented on a change in pull request #148: GEODE-3149: Removing the 
VectorT.hpp header file and typedefs
URL: https://github.com/apache/geode-native/pull/148#discussion_r150352172
 
 

 ##
 File path: clicache/src/impl/CacheLoader.hpp
 ##
 @@ -41,13 +35,14 @@ namespace Apache
   {
   public:
 std::shared_ptr load( const 
std::shared_ptr& region,
-  const std::shared_ptr& key, 
const std::shared_ptr& helper );
+const 
std::shared_ptr& key,
 
 Review comment:
   This looks fine in the editor as well... Not sure what is going on...


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Protobuf protocol module will throw exceptions on some input
> 
>
> Key: GEODE-3149
> URL: https://issues.apache.org/jira/browse/GEODE-3149
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Brian Rowe
> Fix For: 1.3.0
>
>
> The protobuf protocol handler needs to be able to handle any input on the 
> incoming socket without crashing.  
> Right now closing the socket will cause a crash as we try to process a 
> message from the empty stream (the bug here might be that the server 
> connection shouldn't be trying to process a message here, but the protocol 
> deserialization still needs to have much better error handling).
> {code:java}
> severe 2017/06/28 13:50:55.565 PDT  
> tid=0x31] Uncaught exception in thread Thread[ServerConnection on port 22514 
> Thread 0,5,ServerConnection on port 22514]
> java.lang.NullPointerException
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.processOneMessage(ProtobufStreamProcessor.java:67)
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.receiveMessage(ProtobufStreamProcessor.java:79)
>   at 
> org.apache.geode.internal.cache.tier.sockets.GenericProtocolServerConnection.doOneMessage(GenericProtocolServerConnection.java:68)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1155)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:552)
>   at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3149) Protobuf protocol module will throw exceptions on some input

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248100#comment-16248100
 ] 

ASF GitHub Bot commented on GEODE-3149:
---

mhansonp commented on a change in pull request #148: GEODE-3149: Removing the 
VectorT.hpp header file and typedefs
URL: https://github.com/apache/geode-native/pull/148#discussion_r150351974
 
 

 ##
 File path: clicache/src/CacheableBuiltins.hpp
 ##
 @@ -386,20 +386,20 @@ namespace Apache
}   
  \
\
internal:   
\
-   static IGeodeSerializable^ Create(native::SerializablePtr obj)  
  \
+   static IGeodeSerializable^ 
Create(std::shared_ptr obj)\
{   
  \
return (obj != nullptr ? gcnew m(obj) : nullptr);   
\
}   
  \
\
private:
\
- inline m(native::SerializablePtr nativeptr)   
 \
+ inline m(std::shared_ptr nativeptr) 
   \
   : CacheableBuiltinKey(nativeptr) { } 
   \
   };
 
 
 #define _GFCLI_CACHEABLE_ARRAY_DEF_NEW(m, mt)  
  \
   ref class m : public CacheableBuiltinArray<\
-native::m, native::m##Ptr, mt, GeodeClassIds::m>  \
 
 Review comment:
   In the changes below this line, we went from "somethingPtr" to 
std::shared_ptr<"something"> var... So the ##Ptr was no longer required.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Protobuf protocol module will throw exceptions on some input
> 
>
> Key: GEODE-3149
> URL: https://issues.apache.org/jira/browse/GEODE-3149
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Brian Rowe
> Fix For: 1.3.0
>
>
> The protobuf protocol handler needs to be able to handle any input on the 
> incoming socket without crashing.  
> Right now closing the socket will cause a crash as we try to process a 
> message from the empty stream (the bug here might be that the server 
> connection shouldn't be trying to process a message here, but the protocol 
> deserialization still needs to have much better error handling).
> {code:java}
> severe 2017/06/28 13:50:55.565 PDT  
> tid=0x31] Uncaught exception in thread Thread[ServerConnection on port 22514 
> Thread 0,5,ServerConnection on port 22514]
> java.lang.NullPointerException
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.processOneMessage(ProtobufStreamProcessor.java:67)
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.receiveMessage(ProtobufStreamProcessor.java:79)
>   at 
> org.apache.geode.internal.cache.tier.sockets.GenericProtocolServerConnection.doOneMessage(GenericProtocolServerConnection.java:68)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1155)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:552)
>   at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3149) Protobuf protocol module will throw exceptions on some input

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248101#comment-16248101
 ] 

ASF GitHub Bot commented on GEODE-3149:
---

mhansonp commented on a change in pull request #148: GEODE-3149: Removing the 
VectorT.hpp header file and typedefs
URL: https://github.com/apache/geode-native/pull/148#discussion_r150352082
 
 

 ##
 File path: clicache/src/LocalRegion.cpp
 ##
 @@ -893,7 +893,7 @@ namespace Apache
 
 _GF_MG_EXCEPTION_TRY2/* due to auto replace */
 
-   
std::vector vc;
 
 Review comment:
   This looks fine in the editor Not sure what the deal is here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Protobuf protocol module will throw exceptions on some input
> 
>
> Key: GEODE-3149
> URL: https://issues.apache.org/jira/browse/GEODE-3149
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Brian Rowe
> Fix For: 1.3.0
>
>
> The protobuf protocol handler needs to be able to handle any input on the 
> incoming socket without crashing.  
> Right now closing the socket will cause a crash as we try to process a 
> message from the empty stream (the bug here might be that the server 
> connection shouldn't be trying to process a message here, but the protocol 
> deserialization still needs to have much better error handling).
> {code:java}
> severe 2017/06/28 13:50:55.565 PDT  
> tid=0x31] Uncaught exception in thread Thread[ServerConnection on port 22514 
> Thread 0,5,ServerConnection on port 22514]
> java.lang.NullPointerException
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.processOneMessage(ProtobufStreamProcessor.java:67)
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.receiveMessage(ProtobufStreamProcessor.java:79)
>   at 
> org.apache.geode.internal.cache.tier.sockets.GenericProtocolServerConnection.doOneMessage(GenericProtocolServerConnection.java:68)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1155)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:552)
>   at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3961) Show metrics disregards specified --categories for CacheServer (--port option related) metrics

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248069#comment-16248069
 ] 

ASF GitHub Bot commented on GEODE-3961:
---

jinmeiliao commented on a change in pull request #1046: GEODE-3961: Refactor 
ShowMetricsCommand to behave uniformly...
URL: https://github.com/apache/geode/pull/1046#discussion_r150344376
 
 

 ##
 File path: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ShowMetricsInterceptor.java
 ##
 @@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional 
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY 
KIND, either express
+ * or implied. See the License for the specific language governing permissions 
and limitations under
+ * the License.
+ */
+package org.apache.geode.management.internal.cli.commands;
+
+import java.util.Arrays;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+import java.util.stream.Collectors;
+
+import org.apache.commons.lang.StringUtils;
+
+import org.apache.geode.management.cli.Result;
+import org.apache.geode.management.internal.cli.AbstractCliAroundInterceptor;
+import org.apache.geode.management.internal.cli.GfshParseResult;
+import 
org.apache.geode.management.internal.cli.commands.ShowMetricsCommand.Category;
+import org.apache.geode.management.internal.cli.i18n.CliStrings;
+import org.apache.geode.management.internal.cli.result.CommandResult;
+import org.apache.geode.management.internal.cli.result.ResultBuilder;
+
+public class ShowMetricsInterceptor extends AbstractCliAroundInterceptor {
+  @Override
+  public Result preExecution(GfshParseResult parseResult) {
+String export_to_report_to = 
parseResult.getParamValueAsString(CliStrings.SHOW_METRICS__FILE);
+if (export_to_report_to != null && !export_to_report_to.endsWith(".csv")) {
+  return ResultBuilder
+  
.createUserErrorResult(CliStrings.format(CliStrings.INVALID_FILE_EXTENSION, 
".csv"));
+}
+
+String regionName = 
parseResult.getParamValueAsString(CliStrings.SHOW_METRICS__REGION);
+String port = 
parseResult.getParamValueAsString(CliStrings.SHOW_METRICS__CACHESERVER__PORT);
+String member = parseResult.getParamValueAsString(CliStrings.MEMBER);
+String[] categoryArgs = (String[]) 
parseResult.getParamValue(CliStrings.SHOW_METRICS__CATEGORY);
+
+if (StringUtils.isNotEmpty(port) && !StringUtils.isNumeric(port)) {
 
 Review comment:
   you can declare the port in the option as Integer, that way, the parser will 
validate it to be an integer for you.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Show metrics disregards specified --categories for CacheServer (--port option 
> related) metrics 
> ---
>
> Key: GEODE-3961
> URL: https://issues.apache.org/jira/browse/GEODE-3961
> Project: Geode
>  Issue Type: Bug
>Reporter: Patrick Rhomberg
>
> Those CacheServer metric categories ({{query}}, {{notification}}, and 
> {{cache-server}}) are not checked against those categories specified by the 
> user and are only checked against the cache server bean being non-null 
> (implicitly: that the port was provided and valid).
> For unification and consistency, these categories should not be displayed 
> when the {{--categories}} option is specified and excludes them.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3961) Show metrics disregards specified --categories for CacheServer (--port option related) metrics

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248070#comment-16248070
 ] 

ASF GitHub Bot commented on GEODE-3961:
---

jinmeiliao commented on a change in pull request #1046: GEODE-3961: Refactor 
ShowMetricsCommand to behave uniformly...
URL: https://github.com/apache/geode/pull/1046#discussion_r150344932
 
 

 ##
 File path: 
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ShowMetricsOptionDependencyJUnitTest.java
 ##
 @@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional 
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY 
KIND, either express
+ * or implied. See the License for the specific language governing permissions 
and limitations under
+ * the License.
+ */
+package org.apache.geode.management.internal.cli.commands;
+
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.mockito.Mockito.spy;
+
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+
+import org.apache.geode.management.cli.Result;
+import org.apache.geode.management.internal.cli.result.CommandResult;
+import org.apache.geode.test.junit.categories.UnitTest;
+import org.apache.geode.test.junit.rules.GfshParserRule;
+
+@Category(UnitTest.class)
+public class ShowMetricsOptionDependencyJUnitTest {
 
 Review comment:
   Just let it remain as ShowMetricsCommandJUnitTest, so that when we type in 
ShowMetricsCommand in the search window, it will show us all the tests 
available for that command.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Show metrics disregards specified --categories for CacheServer (--port option 
> related) metrics 
> ---
>
> Key: GEODE-3961
> URL: https://issues.apache.org/jira/browse/GEODE-3961
> Project: Geode
>  Issue Type: Bug
>Reporter: Patrick Rhomberg
>
> Those CacheServer metric categories ({{query}}, {{notification}}, and 
> {{cache-server}}) are not checked against those categories specified by the 
> user and are only checked against the cache server bean being non-null 
> (implicitly: that the port was provided and valid).
> For unification and consistency, these categories should not be displayed 
> when the {{--categories}} option is specified and excludes them.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3961) Show metrics disregards specified --categories for CacheServer (--port option related) metrics

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248071#comment-16248071
 ] 

ASF GitHub Bot commented on GEODE-3961:
---

jinmeiliao commented on a change in pull request #1046: GEODE-3961: Refactor 
ShowMetricsCommand to behave uniformly...
URL: https://github.com/apache/geode/pull/1046#discussion_r150344738
 
 

 ##
 File path: 
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ShowMetricsCommandJUnitTest.java
 ##
 @@ -16,47 +16,156 @@
 package org.apache.geode.management.internal.cli.commands;
 
 import static org.assertj.core.api.Assertions.assertThat;
-import static org.mockito.Mockito.spy;
 
+import java.util.Arrays;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+import java.util.stream.Collectors;
+
+import org.apache.logging.log4j.Logger;
+import org.junit.ClassRule;
 import org.junit.Rule;
 import org.junit.Test;
 import org.junit.experimental.categories.Category;
 
-import org.apache.geode.management.cli.Result;
-import org.apache.geode.management.internal.cli.result.CommandResult;
-import org.apache.geode.test.junit.categories.UnitTest;
-import org.apache.geode.test.junit.rules.GfshParserRule;
+import org.apache.geode.cache.RegionShortcut;
+import org.apache.geode.internal.logging.LogService;
+import org.apache.geode.test.junit.categories.IntegrationTest;
+import org.apache.geode.test.junit.rules.GfshShellConnectionRule;
+import org.apache.geode.test.junit.rules.GfshShellConnectionRule.PortType;
+import org.apache.geode.test.junit.rules.ServerStarterRule;
 
-@Category(UnitTest.class)
+@Category(IntegrationTest.class)
 public class ShowMetricsCommandJUnitTest {
 
 Review comment:
   This is an integration test. It's not a JUnit test. Rename this to be 
ShowMetricsCommandIntegrationTest


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Show metrics disregards specified --categories for CacheServer (--port option 
> related) metrics 
> ---
>
> Key: GEODE-3961
> URL: https://issues.apache.org/jira/browse/GEODE-3961
> Project: Geode
>  Issue Type: Bug
>Reporter: Patrick Rhomberg
>
> Those CacheServer metric categories ({{query}}, {{notification}}, and 
> {{cache-server}}) are not checked against those categories specified by the 
> user and are only checked against the cache server bean being non-null 
> (implicitly: that the port was provided and valid).
> For unification and consistency, these categories should not be displayed 
> when the {{--categories}} option is specified and excludes them.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3969) Protobuf protocol requests includes a CallbackArgs field

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248047#comment-16248047
 ] 

ASF GitHub Bot commented on GEODE-3969:
---

WireBaron opened a new pull request #1047: GEODE-3969: Remove CallbackArgs from 
protobuf requests
URL: https://github.com/apache/geode/pull/1047
 
 
   @galen-pivotal @kohlmu-pivotal @bschuchardt @PivotalSarge 
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?
   
   - [x] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?
   
   - [x] Is your initial contribution a single, squashed commit?
   
   - [x] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
   submit an update to your PR as soon as possible. If you need help, please 
send an
   email to d...@geode.apache.org.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Protobuf protocol requests includes a CallbackArgs field
> 
>
> Key: GEODE-3969
> URL: https://issues.apache.org/jira/browse/GEODE-3969
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Brian Rowe
>
> We eventually want to support allowing clients to pass arguments to cache 
> listeners in their requests, but this functionality is not going to be 
> present in v1.  Having this field is therefore misleading and it should be 
> removed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (GEODE-3969) Protobuf protocol requests includes a CallbackArgs field

[Brian Rowe (JIRA)]

Brian Rowe created GEODE-3969:
-

 Summary: Protobuf protocol requests includes a CallbackArgs field
 Key: GEODE-3969
 URL: https://issues.apache.org/jira/browse/GEODE-3969
 Project: Geode
  Issue Type: Bug
  Components: client/server
Reporter: Brian Rowe


We eventually want to support allowing clients to pass arguments to cache 
listeners in their requests, but this functionality is not going to be present 
in v1.  Having this field is therefore misleading and it should be removed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3961) Show metrics disregards specified --categories for CacheServer (--port option related) metrics

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248015#comment-16248015
 ] 

ASF GitHub Bot commented on GEODE-3961:
---

PurelyApplied opened a new pull request #1046: GEODE-3961: Refactor 
ShowMetricsCommand to behave uniformly...
URL: https://github.com/apache/geode/pull/1046
 
 
   ... when --categories is provided.
   
   * The ShowMetricsCommand has been almost entirely refactored, but with 
minimal change to existing behavior.
   * The category "cache-server" has been renamed to "cacheserver"
   * The "query" category now only lists once instead of twice.
   * Category checking is now performed by the client, not the server.
   * Expand test coverage
   * Associated help updated and corrected.
   * Alphabetized excludedClasses.txt
   
   -
   
   I realize the alphabetization of `excludedClasses.txt` is well beyond the 
scope of this ticket, but it seemed harmless at the time.  I can revert that 
change to a one-line addition if that is the desire of the community.  Or I 
could open a new ticket and address it in that.
   
   Technically, this is contains a behavior change in that 
`--categories=cache-server` was a valid option that should now be expressed as 
`--categories=cacheserver`.  For the sake and stability of using an `Enum`, the 
dash is prohibited.  A special case could be added to allow this legacy 
behavior to remain, stripping hyphens from the input string, but that seemed to 
be more special-case handling than was warranted.
   
   --
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
   submit an update to your PR as soon as possible. If you need help, please 
send an
   email to d...@geode.apache.org.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Show metrics disregards specified --categories for CacheServer (--port option 
> related) metrics 
> ---
>
> Key: GEODE-3961
> URL: https://issues.apache.org/jira/browse/GEODE-3961
> Project: Geode
>  Issue Type: Bug
>Reporter: Patrick Rhomberg
>
> Those CacheServer metric categories ({{query}}, {{notification}}, and 
> {{cache-server}}) are not checked against those categories specified by the 
> user and are only checked against the cache server bean being non-null 
> (implicitly: that the port was provided and valid).
> For unification and consistency, these categories should not be displayed 
> when the {{--categories}} option is specified and excludes them.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3149) Protobuf protocol module will throw exceptions on some input

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247992#comment-16247992
 ] 

ASF GitHub Bot commented on GEODE-3149:
---

mhansonp commented on a change in pull request #148: GEODE-3149: Removing the 
VectorT.hpp header file and typedefs
URL: https://github.com/apache/geode-native/pull/148#discussion_r150325958
 
 

 ##
 File path: clicache/src/impl/SafeConvert.hpp
 ##
 @@ -132,13 +132,13 @@ namespace Apache
   }
 
   template
-  inline static NativeType* GetNativePtr( ManagedType^ mg_obj )
+  inline static NativeType*std::GetNativePtr( ManagedType^ mg_obj )
 
 Review comment:
   fixed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Protobuf protocol module will throw exceptions on some input
> 
>
> Key: GEODE-3149
> URL: https://issues.apache.org/jira/browse/GEODE-3149
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Brian Rowe
> Fix For: 1.3.0
>
>
> The protobuf protocol handler needs to be able to handle any input on the 
> incoming socket without crashing.  
> Right now closing the socket will cause a crash as we try to process a 
> message from the empty stream (the bug here might be that the server 
> connection shouldn't be trying to process a message here, but the protocol 
> deserialization still needs to have much better error handling).
> {code:java}
> severe 2017/06/28 13:50:55.565 PDT  
> tid=0x31] Uncaught exception in thread Thread[ServerConnection on port 22514 
> Thread 0,5,ServerConnection on port 22514]
> java.lang.NullPointerException
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.processOneMessage(ProtobufStreamProcessor.java:67)
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.receiveMessage(ProtobufStreamProcessor.java:79)
>   at 
> org.apache.geode.internal.cache.tier.sockets.GenericProtocolServerConnection.doOneMessage(GenericProtocolServerConnection.java:68)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1155)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:552)
>   at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3149) Protobuf protocol module will throw exceptions on some input

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247991#comment-16247991
 ] 

ASF GitHub Bot commented on GEODE-3149:
---

mhansonp commented on a change in pull request #148: GEODE-3149: Removing the 
VectorT.hpp header file and typedefs
URL: https://github.com/apache/geode-native/pull/148#discussion_r150325937
 
 

 ##
 File path: cppcache/include/geode/CacheLoader.hpp
 ##
 @@ -67,8 +68,8 @@ class CPPCACHE_EXPORT CacheLoader  {
*
*@see Region::get .
*/
-  virtual CacheablePtr load(const RegionPtr& rp, const CacheableKeyPtr& key,
-const SerializablePtr& aCallbackArgument) = 0;
+  virtual std::shared_ptr load(const std::shared_ptr& rp, 
const std::shared_ptr& key,
+const std::shared_ptr& 
aCallbackArgument) = 0;
 
 Review comment:
   fixed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Protobuf protocol module will throw exceptions on some input
> 
>
> Key: GEODE-3149
> URL: https://issues.apache.org/jira/browse/GEODE-3149
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Brian Rowe
> Fix For: 1.3.0
>
>
> The protobuf protocol handler needs to be able to handle any input on the 
> incoming socket without crashing.  
> Right now closing the socket will cause a crash as we try to process a 
> message from the empty stream (the bug here might be that the server 
> connection shouldn't be trying to process a message here, but the protocol 
> deserialization still needs to have much better error handling).
> {code:java}
> severe 2017/06/28 13:50:55.565 PDT  
> tid=0x31] Uncaught exception in thread Thread[ServerConnection on port 22514 
> Thread 0,5,ServerConnection on port 22514]
> java.lang.NullPointerException
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.processOneMessage(ProtobufStreamProcessor.java:67)
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.receiveMessage(ProtobufStreamProcessor.java:79)
>   at 
> org.apache.geode.internal.cache.tier.sockets.GenericProtocolServerConnection.doOneMessage(GenericProtocolServerConnection.java:68)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1155)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:552)
>   at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3149) Protobuf protocol module will throw exceptions on some input

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247988#comment-16247988
 ] 

ASF GitHub Bot commented on GEODE-3149:
---

dgkimura commented on a change in pull request #148: GEODE-3149: Removing the 
VectorT.hpp header file and typedefs
URL: https://github.com/apache/geode-native/pull/148#discussion_r150325005
 
 

 ##
 File path: cppcache/include/geode/CacheFactory.hpp
 ##
 @@ -127,24 +128,24 @@ class CPPCACHE_EXPORT CacheFactory
* @return a reference to this
* @since 3.5
*/
-  CacheFactoryPtr set(const char* name, const char* value);
+  std::shared_ptr set(const char* name, const char* value);
 
  private:
-  PropertiesPtr dsProp;
+  std::shared_ptr dsProp;
   bool ignorePdxUnreadFields;
   bool pdxReadSerialized;
-  AuthInitializePtr authInitialize;
+  std::shared_ptr authInitialize;
 
-  CachePtr create(const char* name,
-  const CacheAttributesPtr& attrs = nullptr);
+  std::shared_ptr create(const char* name,
+  const std::shared_ptr& attrs = nullptr);
 
 Review comment:
   format


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Protobuf protocol module will throw exceptions on some input
> 
>
> Key: GEODE-3149
> URL: https://issues.apache.org/jira/browse/GEODE-3149
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Brian Rowe
> Fix For: 1.3.0
>
>
> The protobuf protocol handler needs to be able to handle any input on the 
> incoming socket without crashing.  
> Right now closing the socket will cause a crash as we try to process a 
> message from the empty stream (the bug here might be that the server 
> connection shouldn't be trying to process a message here, but the protocol 
> deserialization still needs to have much better error handling).
> {code:java}
> severe 2017/06/28 13:50:55.565 PDT  
> tid=0x31] Uncaught exception in thread Thread[ServerConnection on port 22514 
> Thread 0,5,ServerConnection on port 22514]
> java.lang.NullPointerException
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.processOneMessage(ProtobufStreamProcessor.java:67)
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.receiveMessage(ProtobufStreamProcessor.java:79)
>   at 
> org.apache.geode.internal.cache.tier.sockets.GenericProtocolServerConnection.doOneMessage(GenericProtocolServerConnection.java:68)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1155)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:552)
>   at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3149) Protobuf protocol module will throw exceptions on some input

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247989#comment-16247989
 ] 

ASF GitHub Bot commented on GEODE-3149:
---

dgkimura commented on a change in pull request #148: GEODE-3149: Removing the 
VectorT.hpp header file and typedefs
URL: https://github.com/apache/geode-native/pull/148#discussion_r150325113
 
 

 ##
 File path: cppcache/include/geode/CacheLoader.hpp
 ##
 @@ -67,8 +68,8 @@ class CPPCACHE_EXPORT CacheLoader  {
*
*@see Region::get .
*/
-  virtual CacheablePtr load(const RegionPtr& rp, const CacheableKeyPtr& key,
-const SerializablePtr& aCallbackArgument) = 0;
+  virtual std::shared_ptr load(const std::shared_ptr& rp, 
const std::shared_ptr& key,
+const std::shared_ptr& 
aCallbackArgument) = 0;
 
 Review comment:
   format


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Protobuf protocol module will throw exceptions on some input
> 
>
> Key: GEODE-3149
> URL: https://issues.apache.org/jira/browse/GEODE-3149
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Brian Rowe
> Fix For: 1.3.0
>
>
> The protobuf protocol handler needs to be able to handle any input on the 
> incoming socket without crashing.  
> Right now closing the socket will cause a crash as we try to process a 
> message from the empty stream (the bug here might be that the server 
> connection shouldn't be trying to process a message here, but the protocol 
> deserialization still needs to have much better error handling).
> {code:java}
> severe 2017/06/28 13:50:55.565 PDT  
> tid=0x31] Uncaught exception in thread Thread[ServerConnection on port 22514 
> Thread 0,5,ServerConnection on port 22514]
> java.lang.NullPointerException
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.processOneMessage(ProtobufStreamProcessor.java:67)
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.receiveMessage(ProtobufStreamProcessor.java:79)
>   at 
> org.apache.geode.internal.cache.tier.sockets.GenericProtocolServerConnection.doOneMessage(GenericProtocolServerConnection.java:68)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1155)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:552)
>   at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3149) Protobuf protocol module will throw exceptions on some input

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247985#comment-16247985
 ] 

ASF GitHub Bot commented on GEODE-3149:
---

mhansonp commented on a change in pull request #148: GEODE-3149: Removing the 
VectorT.hpp header file and typedefs
URL: https://github.com/apache/geode-native/pull/148#discussion_r150324486
 
 

 ##
 File path: Testing/Temporary/CTestCostData.txt
 ##
 @@ -0,0 +1 @@
+---
 
 Review comment:
   removed in new commit.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Protobuf protocol module will throw exceptions on some input
> 
>
> Key: GEODE-3149
> URL: https://issues.apache.org/jira/browse/GEODE-3149
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Brian Rowe
> Fix For: 1.3.0
>
>
> The protobuf protocol handler needs to be able to handle any input on the 
> incoming socket without crashing.  
> Right now closing the socket will cause a crash as we try to process a 
> message from the empty stream (the bug here might be that the server 
> connection shouldn't be trying to process a message here, but the protocol 
> deserialization still needs to have much better error handling).
> {code:java}
> severe 2017/06/28 13:50:55.565 PDT  
> tid=0x31] Uncaught exception in thread Thread[ServerConnection on port 22514 
> Thread 0,5,ServerConnection on port 22514]
> java.lang.NullPointerException
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.processOneMessage(ProtobufStreamProcessor.java:67)
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.receiveMessage(ProtobufStreamProcessor.java:79)
>   at 
> org.apache.geode.internal.cache.tier.sockets.GenericProtocolServerConnection.doOneMessage(GenericProtocolServerConnection.java:68)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1155)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:552)
>   at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3149) Protobuf protocol module will throw exceptions on some input

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247984#comment-16247984
 ] 

ASF GitHub Bot commented on GEODE-3149:
---

mhansonp commented on a change in pull request #148: GEODE-3149: Removing the 
VectorT.hpp header file and typedefs
URL: https://github.com/apache/geode-native/pull/148#discussion_r150324448
 
 

 ##
 File path: Testing/Temporary/LastTest.log
 ##
 @@ -0,0 +1,3 @@
+Start testing: Nov 01 15:14 PDT
+--
 
 Review comment:
   removed in new commit.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Protobuf protocol module will throw exceptions on some input
> 
>
> Key: GEODE-3149
> URL: https://issues.apache.org/jira/browse/GEODE-3149
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Brian Rowe
> Fix For: 1.3.0
>
>
> The protobuf protocol handler needs to be able to handle any input on the 
> incoming socket without crashing.  
> Right now closing the socket will cause a crash as we try to process a 
> message from the empty stream (the bug here might be that the server 
> connection shouldn't be trying to process a message here, but the protocol 
> deserialization still needs to have much better error handling).
> {code:java}
> severe 2017/06/28 13:50:55.565 PDT  
> tid=0x31] Uncaught exception in thread Thread[ServerConnection on port 22514 
> Thread 0,5,ServerConnection on port 22514]
> java.lang.NullPointerException
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.processOneMessage(ProtobufStreamProcessor.java:67)
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.receiveMessage(ProtobufStreamProcessor.java:79)
>   at 
> org.apache.geode.internal.cache.tier.sockets.GenericProtocolServerConnection.doOneMessage(GenericProtocolServerConnection.java:68)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1155)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:552)
>   at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3872) Consolidate GfshShellConnectionRule assertions

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247986#comment-16247986
 ] 

ASF GitHub Bot commented on GEODE-3872:
---

jinmeiliao commented on issue #1043: GEODE-3872: simplify the Command result 
Assert
URL: https://github.com/apache/geode/pull/1043#issuecomment-343570542
 
 
   precheckin green


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Consolidate GfshShellConnectionRule assertions
> --
>
> Key: GEODE-3872
> URL: https://issues.apache.org/jira/browse/GEODE-3872
> Project: Geode
>  Issue Type: Improvement
>  Components: gfsh, tests
>Reporter: Jared Stewart
>Assignee: Jared Stewart
> Fix For: 1.4.0
>
>
> We have started to accumulate several flavors of _executeCommand_ methods on 
> GfshShellConnectionRule that implicitly make certain kinds of assertions.  
> (For example, assertions on the command result status or on the output text.) 
>  It would make the code more maintainable to separate the various assertion 
> methods into a separate class and to have a single executeCommand method.
> (See e.g. 
> http://joel-costigliola.github.io/assertj/assertj-core-custom-assertions.html#custom-assertion-class)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3149) Protobuf protocol module will throw exceptions on some input

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247983#comment-16247983
 ] 

ASF GitHub Bot commented on GEODE-3149:
---

dgkimura commented on a change in pull request #148: GEODE-3149: Removing the 
VectorT.hpp header file and typedefs
URL: https://github.com/apache/geode-native/pull/148#discussion_r150324353
 
 

 ##
 File path: clicache/src/impl/SafeConvert.hpp
 ##
 @@ -132,13 +132,13 @@ namespace Apache
   }
 
   template
-  inline static NativeType* GetNativePtr( ManagedType^ mg_obj )
+  inline static NativeType*std::GetNativePtr( ManagedType^ mg_obj )
 
 Review comment:
   Ehh?!  This doesn't look right...?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Protobuf protocol module will throw exceptions on some input
> 
>
> Key: GEODE-3149
> URL: https://issues.apache.org/jira/browse/GEODE-3149
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Brian Rowe
> Fix For: 1.3.0
>
>
> The protobuf protocol handler needs to be able to handle any input on the 
> incoming socket without crashing.  
> Right now closing the socket will cause a crash as we try to process a 
> message from the empty stream (the bug here might be that the server 
> connection shouldn't be trying to process a message here, but the protocol 
> deserialization still needs to have much better error handling).
> {code:java}
> severe 2017/06/28 13:50:55.565 PDT  
> tid=0x31] Uncaught exception in thread Thread[ServerConnection on port 22514 
> Thread 0,5,ServerConnection on port 22514]
> java.lang.NullPointerException
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.processOneMessage(ProtobufStreamProcessor.java:67)
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.receiveMessage(ProtobufStreamProcessor.java:79)
>   at 
> org.apache.geode.internal.cache.tier.sockets.GenericProtocolServerConnection.doOneMessage(GenericProtocolServerConnection.java:68)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1155)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:552)
>   at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3149) Protobuf protocol module will throw exceptions on some input

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247981#comment-16247981
 ] 

ASF GitHub Bot commented on GEODE-3149:
---

dgkimura commented on a change in pull request #148: GEODE-3149: Removing the 
VectorT.hpp header file and typedefs
URL: https://github.com/apache/geode-native/pull/148#discussion_r150324173
 
 

 ##
 File path: clicache/src/impl/PersistenceManagerProxy.hpp
 ##
 @@ -20,23 +20,26 @@
 #include "SafeConvert.hpp"
 #include "../Region.hpp"
 #include "../Properties.hpp"
+#include "begin_native.hpp"
+#include 
+#include "end_native.hpp"
 using namespace System;
 namespace Apache
 {
   namespace Geode
   {
 namespace Client
 {
-
+   namespace native = apache::geode::client;
 
 Review comment:
   format


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Protobuf protocol module will throw exceptions on some input
> 
>
> Key: GEODE-3149
> URL: https://issues.apache.org/jira/browse/GEODE-3149
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Brian Rowe
> Fix For: 1.3.0
>
>
> The protobuf protocol handler needs to be able to handle any input on the 
> incoming socket without crashing.  
> Right now closing the socket will cause a crash as we try to process a 
> message from the empty stream (the bug here might be that the server 
> connection shouldn't be trying to process a message here, but the protocol 
> deserialization still needs to have much better error handling).
> {code:java}
> severe 2017/06/28 13:50:55.565 PDT  
> tid=0x31] Uncaught exception in thread Thread[ServerConnection on port 22514 
> Thread 0,5,ServerConnection on port 22514]
> java.lang.NullPointerException
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.processOneMessage(ProtobufStreamProcessor.java:67)
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.receiveMessage(ProtobufStreamProcessor.java:79)
>   at 
> org.apache.geode.internal.cache.tier.sockets.GenericProtocolServerConnection.doOneMessage(GenericProtocolServerConnection.java:68)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1155)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:552)
>   at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3149) Protobuf protocol module will throw exceptions on some input

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247979#comment-16247979
 ] 

ASF GitHub Bot commented on GEODE-3149:
---

dgkimura commented on a change in pull request #148: GEODE-3149: Removing the 
VectorT.hpp header file and typedefs
URL: https://github.com/apache/geode-native/pull/148#discussion_r150323926
 
 

 ##
 File path: clicache/src/impl/ManagedString.hpp
 ##
 @@ -40,7 +40,7 @@ namespace Apache
 {
 private:
 
-  IntPtr m_str;
+ IntPtr m_str;
 
 Review comment:
   None of the edits in this file seem to add value.  If that's the case then 
let's revert this file.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Protobuf protocol module will throw exceptions on some input
> 
>
> Key: GEODE-3149
> URL: https://issues.apache.org/jira/browse/GEODE-3149
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Brian Rowe
> Fix For: 1.3.0
>
>
> The protobuf protocol handler needs to be able to handle any input on the 
> incoming socket without crashing.  
> Right now closing the socket will cause a crash as we try to process a 
> message from the empty stream (the bug here might be that the server 
> connection shouldn't be trying to process a message here, but the protocol 
> deserialization still needs to have much better error handling).
> {code:java}
> severe 2017/06/28 13:50:55.565 PDT  
> tid=0x31] Uncaught exception in thread Thread[ServerConnection on port 22514 
> Thread 0,5,ServerConnection on port 22514]
> java.lang.NullPointerException
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.processOneMessage(ProtobufStreamProcessor.java:67)
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.receiveMessage(ProtobufStreamProcessor.java:79)
>   at 
> org.apache.geode.internal.cache.tier.sockets.GenericProtocolServerConnection.doOneMessage(GenericProtocolServerConnection.java:68)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1155)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:552)
>   at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3149) Protobuf protocol module will throw exceptions on some input

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247972#comment-16247972
 ] 

ASF GitHub Bot commented on GEODE-3149:
---

dgkimura commented on a change in pull request #148: GEODE-3149: Removing the 
VectorT.hpp header file and typedefs
URL: https://github.com/apache/geode-native/pull/148#discussion_r150323080
 
 

 ##
 File path: clicache/src/impl/ManagedCacheWriter.hpp
 ##
 @@ -33,7 +33,7 @@ namespace apache
   {
 namespace client
 {
-
+   namespace native = apache::geode::client;
 
 Review comment:
   Formatting.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Protobuf protocol module will throw exceptions on some input
> 
>
> Key: GEODE-3149
> URL: https://issues.apache.org/jira/browse/GEODE-3149
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Brian Rowe
> Fix For: 1.3.0
>
>
> The protobuf protocol handler needs to be able to handle any input on the 
> incoming socket without crashing.  
> Right now closing the socket will cause a crash as we try to process a 
> message from the empty stream (the bug here might be that the server 
> connection shouldn't be trying to process a message here, but the protocol 
> deserialization still needs to have much better error handling).
> {code:java}
> severe 2017/06/28 13:50:55.565 PDT  
> tid=0x31] Uncaught exception in thread Thread[ServerConnection on port 22514 
> Thread 0,5,ServerConnection on port 22514]
> java.lang.NullPointerException
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.processOneMessage(ProtobufStreamProcessor.java:67)
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.receiveMessage(ProtobufStreamProcessor.java:79)
>   at 
> org.apache.geode.internal.cache.tier.sockets.GenericProtocolServerConnection.doOneMessage(GenericProtocolServerConnection.java:68)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1155)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:552)
>   at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3149) Protobuf protocol module will throw exceptions on some input

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247971#comment-16247971
 ] 

ASF GitHub Bot commented on GEODE-3149:
---

dgkimura commented on a change in pull request #148: GEODE-3149: Removing the 
VectorT.hpp header file and typedefs
URL: https://github.com/apache/geode-native/pull/148#discussion_r150322968
 
 

 ##
 File path: clicache/src/impl/ManagedCacheLoader.cpp
 ##
 @@ -214,8 +214,8 @@ namespace apache
 return NULL;
   }
 
-  CacheablePtr ManagedCacheLoaderGeneric::load(const RegionPtr& region,
-   const CacheableKeyPtr& key, 
const SerializablePtr& aCallbackArgument)
+ std::shared_ptr ManagedCacheLoaderGeneric::load(const 
std::shared_ptr& region,
+   const 
std::shared_ptr& key, const 
std::shared_ptr& aCallbackArgument)
 
 Review comment:
   Formatting is kinda awkward here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Protobuf protocol module will throw exceptions on some input
> 
>
> Key: GEODE-3149
> URL: https://issues.apache.org/jira/browse/GEODE-3149
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Brian Rowe
> Fix For: 1.3.0
>
>
> The protobuf protocol handler needs to be able to handle any input on the 
> incoming socket without crashing.  
> Right now closing the socket will cause a crash as we try to process a 
> message from the empty stream (the bug here might be that the server 
> connection shouldn't be trying to process a message here, but the protocol 
> deserialization still needs to have much better error handling).
> {code:java}
> severe 2017/06/28 13:50:55.565 PDT  
> tid=0x31] Uncaught exception in thread Thread[ServerConnection on port 22514 
> Thread 0,5,ServerConnection on port 22514]
> java.lang.NullPointerException
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.processOneMessage(ProtobufStreamProcessor.java:67)
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.receiveMessage(ProtobufStreamProcessor.java:79)
>   at 
> org.apache.geode.internal.cache.tier.sockets.GenericProtocolServerConnection.doOneMessage(GenericProtocolServerConnection.java:68)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1155)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:552)
>   at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3149) Protobuf protocol module will throw exceptions on some input

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247966#comment-16247966
 ] 

ASF GitHub Bot commented on GEODE-3149:
---

dgkimura commented on a change in pull request #148: GEODE-3149: Removing the 
VectorT.hpp header file and typedefs
URL: https://github.com/apache/geode-native/pull/148#discussion_r150321960
 
 

 ##
 File path: clicache/src/Cache.cpp
 ##
 @@ -181,7 +181,7 @@ namespace Apache
   generic
   array^>^ Cache::RootRegions( )
   {
-apache::geode::client::VectorOfRegion vrr;
+std::vector vrr;
 
 Review comment:
   While you're in the file, it would be nice to have some consistency.  Can we 
switch to use the `native` namespace?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Protobuf protocol module will throw exceptions on some input
> 
>
> Key: GEODE-3149
> URL: https://issues.apache.org/jira/browse/GEODE-3149
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Brian Rowe
> Fix For: 1.3.0
>
>
> The protobuf protocol handler needs to be able to handle any input on the 
> incoming socket without crashing.  
> Right now closing the socket will cause a crash as we try to process a 
> message from the empty stream (the bug here might be that the server 
> connection shouldn't be trying to process a message here, but the protocol 
> deserialization still needs to have much better error handling).
> {code:java}
> severe 2017/06/28 13:50:55.565 PDT  
> tid=0x31] Uncaught exception in thread Thread[ServerConnection on port 22514 
> Thread 0,5,ServerConnection on port 22514]
> java.lang.NullPointerException
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.processOneMessage(ProtobufStreamProcessor.java:67)
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.receiveMessage(ProtobufStreamProcessor.java:79)
>   at 
> org.apache.geode.internal.cache.tier.sockets.GenericProtocolServerConnection.doOneMessage(GenericProtocolServerConnection.java:68)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1155)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:552)
>   at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3149) Protobuf protocol module will throw exceptions on some input

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247962#comment-16247962
 ] 

ASF GitHub Bot commented on GEODE-3149:
---

dgkimura commented on a change in pull request #148: GEODE-3149: Removing the 
VectorT.hpp header file and typedefs
URL: https://github.com/apache/geode-native/pull/148#discussion_r150321519
 
 

 ##
 File path: Testing/Temporary/CTestCostData.txt
 ##
 @@ -0,0 +1 @@
+---
 
 Review comment:
   I assume you did a `git add .`  Please double check that you didn't add any 
other files by mistake.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Protobuf protocol module will throw exceptions on some input
> 
>
> Key: GEODE-3149
> URL: https://issues.apache.org/jira/browse/GEODE-3149
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Brian Rowe
> Fix For: 1.3.0
>
>
> The protobuf protocol handler needs to be able to handle any input on the 
> incoming socket without crashing.  
> Right now closing the socket will cause a crash as we try to process a 
> message from the empty stream (the bug here might be that the server 
> connection shouldn't be trying to process a message here, but the protocol 
> deserialization still needs to have much better error handling).
> {code:java}
> severe 2017/06/28 13:50:55.565 PDT  
> tid=0x31] Uncaught exception in thread Thread[ServerConnection on port 22514 
> Thread 0,5,ServerConnection on port 22514]
> java.lang.NullPointerException
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.processOneMessage(ProtobufStreamProcessor.java:67)
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.receiveMessage(ProtobufStreamProcessor.java:79)
>   at 
> org.apache.geode.internal.cache.tier.sockets.GenericProtocolServerConnection.doOneMessage(GenericProtocolServerConnection.java:68)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1155)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:552)
>   at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3149) Protobuf protocol module will throw exceptions on some input

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247963#comment-16247963
 ] 

ASF GitHub Bot commented on GEODE-3149:
---

dgkimura commented on a change in pull request #148: GEODE-3149: Removing the 
VectorT.hpp header file and typedefs
URL: https://github.com/apache/geode-native/pull/148#discussion_r150321543
 
 

 ##
 File path: Testing/Temporary/LastTest.log
 ##
 @@ -0,0 +1,3 @@
+Start testing: Nov 01 15:14 PDT
+--
 
 Review comment:
   I assume you did a `git add .`  Please double check that you didn't add any 
other files by mistake.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Protobuf protocol module will throw exceptions on some input
> 
>
> Key: GEODE-3149
> URL: https://issues.apache.org/jira/browse/GEODE-3149
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Brian Rowe
> Fix For: 1.3.0
>
>
> The protobuf protocol handler needs to be able to handle any input on the 
> incoming socket without crashing.  
> Right now closing the socket will cause a crash as we try to process a 
> message from the empty stream (the bug here might be that the server 
> connection shouldn't be trying to process a message here, but the protocol 
> deserialization still needs to have much better error handling).
> {code:java}
> severe 2017/06/28 13:50:55.565 PDT  
> tid=0x31] Uncaught exception in thread Thread[ServerConnection on port 22514 
> Thread 0,5,ServerConnection on port 22514]
> java.lang.NullPointerException
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.processOneMessage(ProtobufStreamProcessor.java:67)
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.receiveMessage(ProtobufStreamProcessor.java:79)
>   at 
> org.apache.geode.internal.cache.tier.sockets.GenericProtocolServerConnection.doOneMessage(GenericProtocolServerConnection.java:68)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1155)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:552)
>   at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3149) Protobuf protocol module will throw exceptions on some input

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247957#comment-16247957
 ] 

ASF GitHub Bot commented on GEODE-3149:
---

dgkimura commented on a change in pull request #148: GEODE-3149: Removing the 
VectorT.hpp header file and typedefs
URL: https://github.com/apache/geode-native/pull/148#discussion_r150320492
 
 

 ##
 File path: clicache/src/CacheableBuiltins.hpp
 ##
 @@ -386,20 +386,20 @@ namespace Apache
}   
  \
\
internal:   
\
-   static IGeodeSerializable^ Create(native::SerializablePtr obj)  
  \
+   static IGeodeSerializable^ 
Create(std::shared_ptr obj)\
{   
  \
return (obj != nullptr ? gcnew m(obj) : nullptr);   
\
}   
  \
\
private:
\
- inline m(native::SerializablePtr nativeptr)   
 \
+ inline m(std::shared_ptr nativeptr) 
   \
   : CacheableBuiltinKey(nativeptr) { } 
   \
   };
 
 
 #define _GFCLI_CACHEABLE_ARRAY_DEF_NEW(m, mt)  
  \
   ref class m : public CacheableBuiltinArray<\
-native::m, native::m##Ptr, mt, GeodeClassIds::m>  \
 
 Review comment:
   Why is this type changing away from shared_ptr?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Protobuf protocol module will throw exceptions on some input
> 
>
> Key: GEODE-3149
> URL: https://issues.apache.org/jira/browse/GEODE-3149
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Brian Rowe
> Fix For: 1.3.0
>
>
> The protobuf protocol handler needs to be able to handle any input on the 
> incoming socket without crashing.  
> Right now closing the socket will cause a crash as we try to process a 
> message from the empty stream (the bug here might be that the server 
> connection shouldn't be trying to process a message here, but the protocol 
> deserialization still needs to have much better error handling).
> {code:java}
> severe 2017/06/28 13:50:55.565 PDT  
> tid=0x31] Uncaught exception in thread Thread[ServerConnection on port 22514 
> Thread 0,5,ServerConnection on port 22514]
> java.lang.NullPointerException
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.processOneMessage(ProtobufStreamProcessor.java:67)
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.receiveMessage(ProtobufStreamProcessor.java:79)
>   at 
> org.apache.geode.internal.cache.tier.sockets.GenericProtocolServerConnection.doOneMessage(GenericProtocolServerConnection.java:68)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1155)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:552)
>   at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3421) Public API Removals

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247951#comment-16247951
 ] 

ASF subversion and git services commented on GEODE-3421:


Commit 2acb7087ed5c0097458ace48e634c0e27f69ccaf in geode-native's branch 
refs/heads/develop from [~dkimura]
[ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=2acb708 ]

GEODE-3421: Cleanup public API headers (#145)

GEODE-3421: Cleanup public API headers

> Public API Removals
> ---
>
> Key: GEODE-3421
> URL: https://issues.apache.org/jira/browse/GEODE-3421
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Addison
>
> Move the following out of the public API:
> - CacheTransactionmanager2PC
> - Log.hpp
> - utils.hpp



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3421) Public API Removals

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247950#comment-16247950
 ] 

ASF GitHub Bot commented on GEODE-3421:
---

dgkimura closed pull request #145: GEODE-3421: Cleanup public API headers
URL: https://github.com/apache/geode-native/pull/145
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/clicache/src/CacheTransactionManager.hpp 
b/clicache/src/CacheTransactionManager.hpp
index 07f69547..5c435a4f 100644
--- a/clicache/src/CacheTransactionManager.hpp
+++ b/clicache/src/CacheTransactionManager.hpp
@@ -20,7 +20,7 @@
 #include "geode_defs.hpp"
 #include "begin_native.hpp"
 #include 
-#include 
+#include "InternalCacheTransactionManager2PC.hpp"
 #include "end_native.hpp"
 #include "native_shared_ptr.hpp"
 #include "TransactionId.hpp"
diff --git a/clicache/src/Log.hpp b/clicache/src/Log.hpp
index ed5dd289..8e2947b4 100644
--- a/clicache/src/Log.hpp
+++ b/clicache/src/Log.hpp
@@ -19,7 +19,7 @@
 
 #include "geode_defs.hpp"
 #include "begin_native.hpp"
-#include 
+#include "util/Log.hpp"
 #include "end_native.hpp"
 
 
diff --git a/cppcache/include/geode/DataOutput.hpp 
b/cppcache/include/geode/DataOutput.hpp
index 6bc91e07..fa04bf5c 100644
--- a/cppcache/include/geode/DataOutput.hpp
+++ b/cppcache/include/geode/DataOutput.hpp
@@ -22,7 +22,7 @@
 
 #include "geode_globals.hpp"
 #include "ExceptionTypes.hpp"
-#include "Log.hpp"
+#include "util/Log.hpp"
 #include "Serializable.hpp"
 #include "CacheableString.hpp"
 
diff --git a/cppcache/include/geode/HashMapT.hpp 
b/cppcache/include/geode/HashMapT.hpp
index 5b5e7e6d..8e322619 100644
--- a/cppcache/include/geode/HashMapT.hpp
+++ b/cppcache/include/geode/HashMapT.hpp
@@ -23,12 +23,11 @@
 #include 
 #include 
 
-#include 
-
 #include "geode_globals.hpp"
 #include "Cacheable.hpp"
 #include "CacheableKey.hpp"
 #include "Exception.hpp"
+#include "util/functional.hpp"
 
 namespace apache {
 namespace geode {
diff --git a/cppcache/include/geode/HashSetT.hpp 
b/cppcache/include/geode/HashSetT.hpp
index fd5c8b5e..488cebba 100644
--- a/cppcache/include/geode/HashSetT.hpp
+++ b/cppcache/include/geode/HashSetT.hpp
@@ -23,10 +23,9 @@
 #include 
 #include 
 
-#include 
-
 #include "geode_globals.hpp"
 #include "CacheableKey.hpp"
+#include "util/functional.hpp"
 
 namespace apache {
 namespace geode {
diff --git a/cppcache/include/geode/Struct.hpp 
b/cppcache/include/geode/Struct.hpp
index 6dbd2966..cea08c38 100644
--- a/cppcache/include/geode/Struct.hpp
+++ b/cppcache/include/geode/Struct.hpp
@@ -23,8 +23,6 @@
 #include 
 #include 
 
-#include 
-
 #include "geode_globals.hpp"
 #include "geode_types.hpp"
 #include "CacheableBuiltins.hpp"
diff --git a/cppcache/include/geode/SystemProperties.hpp 
b/cppcache/include/geode/SystemProperties.hpp
index ff8960d1..18b48144 100644
--- a/cppcache/include/geode/SystemProperties.hpp
+++ b/cppcache/include/geode/SystemProperties.hpp
@@ -21,7 +21,7 @@
  */
 
 #include "Properties.hpp"
-#include "Log.hpp"
+#include "util/Log.hpp"
 
 /** @file
  */
diff --git a/cppcache/include/geode/geode_globals.hpp 
b/cppcache/include/geode/geode_globals.hpp
index ae3b56d2..b5c7ffbc 100644
--- a/cppcache/include/geode/geode_globals.hpp
+++ b/cppcache/include/geode/geode_globals.hpp
@@ -122,7 +122,7 @@
 
 #include 
 
-#include "Log.hpp"
+#include "util/Log.hpp"
 #include "Assert.hpp"
 
 #endif  // GEODE_GFCPP_GLOBALS_H_
diff --git a/cppcache/integration-test/fw_helper.hpp 
b/cppcache/integration-test/fw_helper.hpp
index 5afc75c0..e346888a 100644
--- a/cppcache/integration-test/fw_helper.hpp
+++ b/cppcache/integration-test/fw_helper.hpp
@@ -88,7 +88,7 @@ BEGIN_TEST.
 
 #include 
 #include 
-#include 
+#include "util/Log.hpp"
 
 #include 
 #include 
diff --git a/cppcache/src/Assert.cpp b/cppcache/src/Assert.cpp
index 9dc0d5c5..6a0fdc39 100644
--- a/cppcache/src/Assert.cpp
+++ b/cppcache/src/Assert.cpp
@@ -14,9 +14,9 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-#include 
 #include 
-#include 
+#include "Assert.hpp"
+#include "util/Log.hpp"
 
 namespace apache {
 namespace geode {
diff --git a/cppcache/include/geode/Assert.hpp b/cppcache/src/Assert.hpp
similarity index 98%
rename from cppcache/include/geode/Assert.hpp
rename to cppcache/src/Assert.hpp
index 0254d6b0..aa95ac1a 100644
--- a/cppcache/include/geode/Assert.hpp
+++ b/cppcache/src/Assert.hpp
@@ -1,8 +1,3 @@
-#pragma once
-
-#ifndef GEODE_ASSERT_H_
-#define GEODE_ASSERT_H_
-
 /*
  * Licensed to the Apache Software Foundation (ASF) under one or more
  * contributor license agreements.  See the NOTICE file distributed with
@@ -20,7 +15,12 @@
  * limitations under the License.
  */
 

[jira] [Commented] (GEODE-3421) Public API Removals

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247952#comment-16247952
 ] 

ASF subversion and git services commented on GEODE-3421:


Commit 2acb7087ed5c0097458ace48e634c0e27f69ccaf in geode-native's branch 
refs/heads/develop from [~dkimura]
[ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=2acb708 ]

GEODE-3421: Cleanup public API headers (#145)

GEODE-3421: Cleanup public API headers

> Public API Removals
> ---
>
> Key: GEODE-3421
> URL: https://issues.apache.org/jira/browse/GEODE-3421
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Addison
>
> Move the following out of the public API:
> - CacheTransactionmanager2PC
> - Log.hpp
> - utils.hpp



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3149) Protobuf protocol module will throw exceptions on some input

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247934#comment-16247934
 ] 

ASF GitHub Bot commented on GEODE-3149:
---

mhansonp opened a new pull request #148: GEODE-3149: Removing the VectorT.hpp 
header file and typedefs
URL: https://github.com/apache/geode-native/pull/148
 
 
   -Changing (somthing)Ptr to std::shared_ptr<(something>
   -Changing unnecessary declarations to auto
   -Cleaning up Macro defines that were no longer needed


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Protobuf protocol module will throw exceptions on some input
> 
>
> Key: GEODE-3149
> URL: https://issues.apache.org/jira/browse/GEODE-3149
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Brian Rowe
> Fix For: 1.3.0
>
>
> The protobuf protocol handler needs to be able to handle any input on the 
> incoming socket without crashing.  
> Right now closing the socket will cause a crash as we try to process a 
> message from the empty stream (the bug here might be that the server 
> connection shouldn't be trying to process a message here, but the protocol 
> deserialization still needs to have much better error handling).
> {code:java}
> severe 2017/06/28 13:50:55.565 PDT  
> tid=0x31] Uncaught exception in thread Thread[ServerConnection on port 22514 
> Thread 0,5,ServerConnection on port 22514]
> java.lang.NullPointerException
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.processOneMessage(ProtobufStreamProcessor.java:67)
>   at 
> org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.receiveMessage(ProtobufStreamProcessor.java:79)
>   at 
> org.apache.geode.internal.cache.tier.sockets.GenericProtocolServerConnection.doOneMessage(GenericProtocolServerConnection.java:68)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1155)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:552)
>   at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (GEODE-3968) Document how rebalance actually works

[Fred Krone (JIRA)]

Fred Krone created GEODE-3968:
-

 Summary: Document how rebalance actually works
 Key: GEODE-3968
 URL: https://issues.apache.org/jira/browse/GEODE-3968
 Project: Geode
  Issue Type: Task
  Components: regions
Reporter: Fred Krone


There are a lot of user questions around how rebalance works, configuration etc.

Example from Gideon: I still think we need to make important improvements to 
the rebalancing documentation.  One "big picture" item is to explain the 
resource manager's role in rebalancing activity (RM isn't mentioned in the 
doc's in this context).  

We should also add more detail explaining how to optimize multi-threaded 
rebalancing.  

What exactly happens with multi-threaded rebalancing, and what are the limits 
and/or consequences?  For example, could too high a degree of parallelism 
defeat the rebalancing algorithm (given the original design targets reaching 
the right end-state by moving buckets one at-a-time)?  Or, is the reverse true, 
and we might bet better final results with more threads ? Is there some 
guideline we can devise based on the number of nodes in the cluster, the number 
of cores per server, and the configured number of buckets for a PR?  Is 
multi-threaded applied on each host individually, or are the extra threads only 
running on the rebalance "coordinator" node?  

I wasn't able to explain any of the nuances of rebalancing based on our docs 
and cursory review of the Geode codebase (although for the latter I'm sure I 
could eventually . . .).  This actually screams for a dedicated section on the 
Geode Wiki "Geode Internal Architecture" section . . . I would be happy to help 
write this I can get get started with answers to the above questions.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3539) Add more test coverage for p2p commands

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247924#comment-16247924
 ] 

ASF GitHub Bot commented on GEODE-3539:
---

jinmeiliao opened a new pull request #1045: GEODE-3539: cleanup GfshCommand and 
refactor tests
URL: https://github.com/apache/geode/pull/1045
 
 
   
   * remove more try catch blocks in commands
   * make GfshCommand a pure wrapper around CliUtil for easy mocking
   * Generalize MemberNotFoundException and DiskStoreNotFoundException into 
EntityNotFoundException
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
   submit an update to your PR as soon as possible. If you need help, please 
send an
   email to d...@geode.apache.org.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add more test coverage for p2p commands
> ---
>
> Key: GEODE-3539
> URL: https://issues.apache.org/jira/browse/GEODE-3539
> Project: Geode
>  Issue Type: Improvement
>  Components: gfsh
>Reporter: Jinmei Liao
>
> Add more command tests that would eventually get rid of the legacy tests.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (GEODE-2217) Add generic type parameter to FunctionContext interface

[Jens Deppe (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jens Deppe updated GEODE-2217:
--
Description: 
FunctionContext has a method getArguments() that returns Object.  It would be 
nice to have getArguments return a known type instead.

{noformat}
public interface FunctionContext  {
  public T getArguments();
}
{noformat}

The Function interface would then allow users to bound the expected argument 
type:
{noformat}
public interface Function {
  public void execute(FunctionContext context);
}
{noformat}


  was:
FunctionContext has a method getArguments() that returns Object.  It would be 
nice to have getArguments return a known type instead.

```
public interface FunctionContext  {
  public T getArguments();
}
```

The Function interface would then allow users to bound the expected argument 
type:
```
public interface Function {
  public void execute(FunctionContext context);
}
```


> Add generic type parameter to FunctionContext interface
> ---
>
> Key: GEODE-2217
> URL: https://issues.apache.org/jira/browse/GEODE-2217
> Project: Geode
>  Issue Type: Bug
>  Components: functions
>Reporter: Jared Stewart
>Assignee: Alyssa Kim
> Fix For: 1.2.0
>
>
> FunctionContext has a method getArguments() that returns Object.  It would be 
> nice to have getArguments return a known type instead.
> {noformat}
> public interface FunctionContext  {
>   public T getArguments();
> }
> {noformat}
> The Function interface would then allow users to bound the expected argument 
> type:
> {noformat}
> public interface Function {
>   public void execute(FunctionContext context);
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3007) Simplify support for custom GFSH commands

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247842#comment-16247842
 ] 

ASF GitHub Bot commented on GEODE-3007:
---

pdxrunner commented on a change in pull request #1042: GEODE-3007: Simplify 
support for custom GFSH commands
URL: https://github.com/apache/geode/pull/1042#discussion_r150298594
 
 

 ##
 File path: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/GfshParser.java
 ##
 @@ -57,10 +57,14 @@ public GfshParser(CommandManager commandManager) {
   add(command);
 }
 
-for (Converter converter : commandManager.getConverters()) {
+for (Converter converter : commandManager.getConverters()) {
   if (converter.getClass().isAssignableFrom(ArrayConverter.class)) {
 ArrayConverter arrayConverter = (ArrayConverter) converter;
-arrayConverter.setConverters(new 
HashSet<>(commandManager.getConverters()));
+HashSet converters = new HashSet<>();
+for (Converter c : commandManager.getConverters()) {
+  converters.add(c);
+}
+arrayConverter.setConverters(converters);
 
 Review comment:
   Surely the logic in these nested foreach's could be simplified.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Simplify support for custom GFSH commands
> -
>
> Key: GEODE-3007
> URL: https://issues.apache.org/jira/browse/GEODE-3007
> Project: Geode
>  Issue Type: Improvement
>  Components: docs, gfsh
>Reporter: Jared Stewart
>Assignee: Jared Stewart
>
> Geode currently supports three ways to load GFSH commands: 
> 1. Scan the classpath for commands in 
> "org.apache.geode.management.internal.cli.commands”
> 2. Scan the classpath for commands in a package specified by a user via the 
> “user-command-packages” system property. 
> 3. Scan the classpath for commands registered in files inside 
> META-INF.services (e.g. 
> "geode-core/src/test/resources/META-INF/services/org.springframework.shell.core.CommandMarker”)
>  
> After the improvements made by GEODE-2989, there is no reason to require a 
> user to specify the location of their custom commands via one of these 
> mechanisms.  Instead, we should simply scan the entire classpath for any 
> classes implementing CommandMarker (regardless of whatever packages they live 
> in).  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3007) Simplify support for custom GFSH commands

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247819#comment-16247819
 ] 

ASF GitHub Bot commented on GEODE-3007:
---

pdxrunner commented on a change in pull request #1042: GEODE-3007: Simplify 
support for custom GFSH commands
URL: https://github.com/apache/geode/pull/1042#discussion_r150296170
 
 

 ##
 File path: 
geode-core/src/main/java/org/apache/geode/distributed/ConfigurationProperties.java
 ##
 @@ -1860,7 +1860,10 @@
* Default: ""
* 
* Since: GemFire 8.0
+   *
+   * @deprecated Since Geode 1.4 (See GEODE-3007)
*/
+  @Deprecated()
 
 Review comment:
   All uses of this property have been removed in this change - is that going 
to be a breaking change anywhere?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Simplify support for custom GFSH commands
> -
>
> Key: GEODE-3007
> URL: https://issues.apache.org/jira/browse/GEODE-3007
> Project: Geode
>  Issue Type: Improvement
>  Components: docs, gfsh
>Reporter: Jared Stewart
>Assignee: Jared Stewart
>
> Geode currently supports three ways to load GFSH commands: 
> 1. Scan the classpath for commands in 
> "org.apache.geode.management.internal.cli.commands”
> 2. Scan the classpath for commands in a package specified by a user via the 
> “user-command-packages” system property. 
> 3. Scan the classpath for commands registered in files inside 
> META-INF.services (e.g. 
> "geode-core/src/test/resources/META-INF/services/org.springframework.shell.core.CommandMarker”)
>  
> After the improvements made by GEODE-2989, there is no reason to require a 
> user to specify the location of their custom commands via one of these 
> mechanisms.  Instead, we should simply scan the entire classpath for any 
> classes implementing CommandMarker (regardless of whatever packages they live 
> in).  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3136) Replace all public API time values with std::chrono types

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247709#comment-16247709
 ] 

ASF GitHub Bot commented on GEODE-3136:
---

pivotal-jbarrett commented on a change in pull request #144: GEODE-3136: 
Convert time values to std::chrono::duration.
URL: https://github.com/apache/geode-native/pull/144#discussion_r150272880
 
 

 ##
 File path: cppcache/src/LocalRegion.cpp
 ##
 @@ -346,15 +348,16 @@ void LocalRegion::localPut(const CacheableKeyPtr& key,
   GfErrTypeToException("Region::localPut", err);
 }
 
-void LocalRegion::putAll(const HashMapOfCacheable& map, uint32_t timeout,
+void LocalRegion::putAll(const HashMapOfCacheable& map,
+ std::chrono::milliseconds timeout,
  const SerializablePtr& aCallbackArgument) {
-  if ((timeout * 1000) >= 0x7fff) {
-throw IllegalArgumentException(
-"Region::putAll: timeout parameter "
-"greater than maximum allowed (2^31/1000 i.e 2147483).");
-  }
-  int64_t sampleStartNanos = startStatOpTime();
-  GfErrType err = putAllNoThrow(map, timeout, aCallbackArgument);
+  //  if ((timeout * 1000) >= 0x7fff) {
 
 Review comment:
   @dgkimura I had really hoped that redefining the parameter as 
`std::chrono::duration timeout` would have solved it 
compile time but strangely it doesn't. I was able to compile a call at passed 
in64_t max seconds, which is WAY over the limit. I feel like this is compiler 
bug but we will just have to check at runtime now.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Replace all public API time values with std::chrono types
> -
>
> Key: GEODE-3136
> URL: https://issues.apache.org/jira/browse/GEODE-3136
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>
> Remove ambiguity of time values by using 
> [{{std::chrono}}|http://en.cppreference.com/w/cpp/chrono] types in the public 
> API. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3136) Replace all public API time values with std::chrono types

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247642#comment-16247642
 ] 

ASF GitHub Bot commented on GEODE-3136:
---

pivotal-jbarrett commented on a change in pull request #144: GEODE-3136: 
Convert time values to std::chrono::duration.
URL: https://github.com/apache/geode-native/pull/144#discussion_r150263661
 
 

 ##
 File path: clicache/src/TimeSpanUtils.hpp
 ##
 @@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#pragma once
+
+#include "begin_native.hpp"
+#include 
+#include 
+#include "end_native.hpp"
+
+namespace Apache
+{
+  namespace Geode
+  {
+namespace Client
+{
+  using namespace System;
+  using namespace apache::geode::util::chrono::duration;
+
+  using ticks = std::chrono::duration>;
+  
+  class TimeSpanUtils
+  {
+  public:
+template 
+inline static _Duration TimeSpanToDurationCeil(TimeSpan timeSpan)
+{
+  return _ceil<_Duration>(TimeSpanToDuration(timeSpan));
 
 Review comment:
   @dgkimura There are places in the public headers that we use some of the 
methods in here. We would either need to split the header to move the `_` 
methods internal only. I am still in favor of the `_`convention as it is 
consistent with public headers in C++ std library that use `__` (double `_`) 
convention to denote internal methods/types/etc. Splitting isn't that bad 
either just means more work. ;)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Replace all public API time values with std::chrono types
> -
>
> Key: GEODE-3136
> URL: https://issues.apache.org/jira/browse/GEODE-3136
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>
> Remove ambiguity of time values by using 
> [{{std::chrono}}|http://en.cppreference.com/w/cpp/chrono] types in the public 
> API. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)