[
https://issues.apache.org/jira/browse/GEODE-3420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248185#comment-16248185
]
ASF GitHub Bot commented on GEODE-3420:
---------------------------------------
pivotal-jbarrett commented on a change in pull request #143: GEODE-3420: Remove
inline header files
URL: https://github.com/apache/geode-native/pull/143#discussion_r150361766
##########
File path: cppcache/include/geode/Cacheable.hpp
##########
@@ -35,10 +35,10 @@ typedef SerializablePtr CacheablePtr;
typedef Serializable Cacheable;
template <typename TVALUE>
-inline CacheablePtr createValue(const std::shared_ptr<TVALUE>& value);
+inline CacheablePtr createValue(const std::shared_ptr<TVALUE>& value) {
Review comment:
We can correct this in a different ticket. How about you open one to address
the ambiguity here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Remove all .inl files
> ---------------------
>
> Key: GEODE-3420
> URL: https://issues.apache.org/jira/browse/GEODE-3420
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Addison
>
> Remove all .inc files in favor of a more readable format to describe includes
> and templates.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
