[jira] [Assigned] (GEODE-4129) gfsh list members command feels inconsistent
[
https://issues.apache.org/jira/browse/GEODE-4129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jinmei Liao reassigned GEODE-4129:
--
Assignee: Jinmei Liao
> gfsh list members command feels inconsistent
>
>
> Key: GEODE-4129
> URL: https://issues.apache.org/jira/browse/GEODE-4129
> Project: Geode
> Issue Type: Bug
> Components: docs, gfsh
>Reporter: Jens Deppe
>Assignee: Jinmei Liao
>Priority: Major
> Labels: pull-request-available
>
> {{list members}} now also shows the 'coordinator':
> {noformat}
> gfsh>list members
> Name | Id
> |
> Coordinator: | 10.118.19.26(locator1:7903:locator):1024
> locator1 | 10.118.19.26(locator1:7903:locator):1024
> server1 | 10.118.19.26(server1:7933):1025
> server2 | 10.118.19.26(server2:8075):1026
> {noformat}
> This just looks untidy.
> Here {{server-2}} is part of a group:
> {noformat}
> gfsh>list members --group=group1
> Name | Id
> |
> Coordinator: | 10.118.19.26(locator1:7903:locator):1024
> server2 | 10.118.19.26(server2:8075):1026
> {noformat}
> But the 'coordinator' is not part of that group. Again, inconsistent and
> untidy.
> I would prefer the relevant member to be highlight somehow as a coordinator.
> For example:
> {noformat}
> gfsh>list members
> Name | Id
> |
> locator1 | 10.118.19.26(locator1:7903:locator):1024 [coordinator]
> server1 | 10.118.19.26(server1:7933):1025
> server2 | 10.118.19.26(server2:8075):1026
> {noformat}
> Or perhaps better yet would be to introduce a separate {{list coordinator}}
> command.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GEODE-3974) improve permission for Internal functions
[ https://issues.apache.org/jira/browse/GEODE-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331849#comment-16331849 ] ASF GitHub Bot commented on GEODE-3974: --- jinmeiliao opened a new pull request #1310: GEODE-3974: Core function security improvement URL: https://github.com/apache/geode/pull/1310 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to d...@geode.apache.org. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > improve permission for Internal functions > - > > Key: GEODE-3974 > URL: https://issues.apache.org/jira/browse/GEODE-3974 > Project: Geode > Issue Type: Bug > Components: docs, management >Reporter: Jinmei Liao >Priority: Major > Labels: pull-request-available > Fix For: 1.5.0 > > > Internal functions needs to be updated to require appropriate permissions -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-3974) improve permission for Internal functions
[ https://issues.apache.org/jira/browse/GEODE-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331845#comment-16331845 ] ASF subversion and git services commented on GEODE-3974: Commit 00be4f9774e1adf8e7ccc2664da8005fc30bb11d in geode's branch refs/heads/develop from [~jinmeiliao] [ https://gitbox.apache.org/repos/asf?p=geode.git;h=00be4f9 ] GEODE-3974: function security improvement (#1287) * GEODE-3974: function security improvement * function executed on a local member does not log out user accidentally * Mark some internal functions as InternalEntity * test refactor > improve permission for Internal functions > - > > Key: GEODE-3974 > URL: https://issues.apache.org/jira/browse/GEODE-3974 > Project: Geode > Issue Type: Bug > Components: docs, management >Reporter: Jinmei Liao >Priority: Major > Labels: pull-request-available > Fix For: 1.5.0 > > > Internal functions needs to be updated to require appropriate permissions -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-3974) improve permission for Internal functions
[ https://issues.apache.org/jira/browse/GEODE-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331844#comment-16331844 ] ASF subversion and git services commented on GEODE-3974: Commit 00be4f9774e1adf8e7ccc2664da8005fc30bb11d in geode's branch refs/heads/develop from [~jinmeiliao] [ https://gitbox.apache.org/repos/asf?p=geode.git;h=00be4f9 ] GEODE-3974: function security improvement (#1287) * GEODE-3974: function security improvement * function executed on a local member does not log out user accidentally * Mark some internal functions as InternalEntity * test refactor > improve permission for Internal functions > - > > Key: GEODE-3974 > URL: https://issues.apache.org/jira/browse/GEODE-3974 > Project: Geode > Issue Type: Bug > Components: docs, management >Reporter: Jinmei Liao >Priority: Major > Labels: pull-request-available > Fix For: 1.5.0 > > > Internal functions needs to be updated to require appropriate permissions -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331771#comment-16331771 ] ASF subversion and git services commented on GEODE-3967: Commit b2061392860bf28033072aa3304a9c77aba965d3 in geode's branch refs/heads/feature/GEM-883 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=b206139 ] GEODE-3967: trace into basicPut > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou >Assignee: xiaojian zhou >Priority: Major > Labels: pull-request-available > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-3391) eval shared_ptr usage in CacheListener/CacheLoader/CacheTransactionMgr/CacheWriter
[ https://issues.apache.org/jira/browse/GEODE-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331659#comment-16331659 ] ASF subversion and git services commented on GEODE-3391: Commit bf1d77610a41250635a43906b27fca6feba9690d in geode-native's branch refs/heads/develop from [~dkimura] [ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=bf1d776 ] GEODE-3391: ThinClientTransactionsXA still failing on some platforms > eval shared_ptr usage in > CacheListener/CacheLoader/CacheTransactionMgr/CacheWriter > -- > > Key: GEODE-3391 > URL: https://issues.apache.org/jira/browse/GEODE-3391 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Ernest Burghardt >Priority: Major > Labels: pull-request-available > > evaluate shared_ptr usage and change to reference > virtual void afterRegionDisconnected(Region& region) > virtual CacheablePtr load(Region& rp, const CacheableKeyPtr& key, > const UserDataPtr& aCallbackArgument) = 0; > virtual void close(Region& rp); > virtual void resume(const TransactionId& transactionId) > virtual const TransactionId& getTransactionId() = 0; > virtual void close(Region& rp); -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-4129) gfsh list members command feels inconsistent
[
https://issues.apache.org/jira/browse/GEODE-4129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331660#comment-16331660
]
ASF GitHub Bot commented on GEODE-4129:
---
jinmeiliao commented on issue #1308: GEODE-4129: do not list coordinator as a
different entry in list memb…
URL: https://github.com/apache/geode/pull/1308#issuecomment-358852171
precheckin green
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> gfsh list members command feels inconsistent
>
>
> Key: GEODE-4129
> URL: https://issues.apache.org/jira/browse/GEODE-4129
> Project: Geode
> Issue Type: Bug
> Components: docs, gfsh
>Reporter: Jens Deppe
>Priority: Major
> Labels: pull-request-available
>
> {{list members}} now also shows the 'coordinator':
> {noformat}
> gfsh>list members
> Name | Id
> |
> Coordinator: | 10.118.19.26(locator1:7903:locator):1024
> locator1 | 10.118.19.26(locator1:7903:locator):1024
> server1 | 10.118.19.26(server1:7933):1025
> server2 | 10.118.19.26(server2:8075):1026
> {noformat}
> This just looks untidy.
> Here {{server-2}} is part of a group:
> {noformat}
> gfsh>list members --group=group1
> Name | Id
> |
> Coordinator: | 10.118.19.26(locator1:7903:locator):1024
> server2 | 10.118.19.26(server2:8075):1026
> {noformat}
> But the 'coordinator' is not part of that group. Again, inconsistent and
> untidy.
> I would prefer the relevant member to be highlight somehow as a coordinator.
> For example:
> {noformat}
> gfsh>list members
> Name | Id
> |
> locator1 | 10.118.19.26(locator1:7903:locator):1024 [coordinator]
> server1 | 10.118.19.26(server1:7933):1025
> server2 | 10.118.19.26(server2:8075):1026
> {noformat}
> Or perhaps better yet would be to introduce a separate {{list coordinator}}
> command.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GEODE-4129) gfsh list members command feels inconsistent
[
https://issues.apache.org/jira/browse/GEODE-4129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331656#comment-16331656
]
ASF GitHub Bot commented on GEODE-4129:
---
jinmeiliao commented on issue #1308: GEODE-4129: do not list coordinator as a
different entry in list memb…
URL: https://github.com/apache/geode/pull/1308#issuecomment-358852171
precheckin green
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> gfsh list members command feels inconsistent
>
>
> Key: GEODE-4129
> URL: https://issues.apache.org/jira/browse/GEODE-4129
> Project: Geode
> Issue Type: Bug
> Components: docs, gfsh
>Reporter: Jens Deppe
>Priority: Major
> Labels: pull-request-available
>
> {{list members}} now also shows the 'coordinator':
> {noformat}
> gfsh>list members
> Name | Id
> |
> Coordinator: | 10.118.19.26(locator1:7903:locator):1024
> locator1 | 10.118.19.26(locator1:7903:locator):1024
> server1 | 10.118.19.26(server1:7933):1025
> server2 | 10.118.19.26(server2:8075):1026
> {noformat}
> This just looks untidy.
> Here {{server-2}} is part of a group:
> {noformat}
> gfsh>list members --group=group1
> Name | Id
> |
> Coordinator: | 10.118.19.26(locator1:7903:locator):1024
> server2 | 10.118.19.26(server2:8075):1026
> {noformat}
> But the 'coordinator' is not part of that group. Again, inconsistent and
> untidy.
> I would prefer the relevant member to be highlight somehow as a coordinator.
> For example:
> {noformat}
> gfsh>list members
> Name | Id
> |
> locator1 | 10.118.19.26(locator1:7903:locator):1024 [coordinator]
> server1 | 10.118.19.26(server1:7933):1025
> server2 | 10.118.19.26(server2:8075):1026
> {noformat}
> Or perhaps better yet would be to introduce a separate {{list coordinator}}
> command.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (GEODE-4321) Upgrade nokogiri to v1.8.1
Anthony Baker created GEODE-4321: Summary: Upgrade nokogiri to v1.8.1 Key: GEODE-4321 URL: https://issues.apache.org/jira/browse/GEODE-4321 Project: Geode Issue Type: Improvement Components: docs Reporter: Anthony Baker The docs generation uses nokogiri. We should update this dependency to at least 1.8.1. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331555#comment-16331555 ] ASF subversion and git services commented on GEODE-3967: Commit 95549933eb13de9fd0c219b41ae071c67a4ecd2e in geode's branch refs/heads/feature/GEM-883 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=9554993 ] GEODE-3967: add trace for exception > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou >Assignee: xiaojian zhou >Priority: Major > Labels: pull-request-available > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (GEODE-4129) gfsh list members command feels inconsistent
[
https://issues.apache.org/jira/browse/GEODE-4129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joey McAllister updated GEODE-4129:
---
Component/s: docs
> gfsh list members command feels inconsistent
>
>
> Key: GEODE-4129
> URL: https://issues.apache.org/jira/browse/GEODE-4129
> Project: Geode
> Issue Type: Bug
> Components: docs, gfsh
>Reporter: Jens Deppe
>Priority: Major
> Labels: pull-request-available
>
> {{list members}} now also shows the 'coordinator':
> {noformat}
> gfsh>list members
> Name | Id
> |
> Coordinator: | 10.118.19.26(locator1:7903:locator):1024
> locator1 | 10.118.19.26(locator1:7903:locator):1024
> server1 | 10.118.19.26(server1:7933):1025
> server2 | 10.118.19.26(server2:8075):1026
> {noformat}
> This just looks untidy.
> Here {{server-2}} is part of a group:
> {noformat}
> gfsh>list members --group=group1
> Name | Id
> |
> Coordinator: | 10.118.19.26(locator1:7903:locator):1024
> server2 | 10.118.19.26(server2:8075):1026
> {noformat}
> But the 'coordinator' is not part of that group. Again, inconsistent and
> untidy.
> I would prefer the relevant member to be highlight somehow as a coordinator.
> For example:
> {noformat}
> gfsh>list members
> Name | Id
> |
> locator1 | 10.118.19.26(locator1:7903:locator):1024 [coordinator]
> server1 | 10.118.19.26(server1:7933):1025
> server2 | 10.118.19.26(server2:8075):1026
> {noformat}
> Or perhaps better yet would be to introduce a separate {{list coordinator}}
> command.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GEODE-3868) Client security example should use SSL
[ https://issues.apache.org/jira/browse/GEODE-3868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331538#comment-16331538 ] ASF GitHub Bot commented on GEODE-3868: --- metatype commented on a change in pull request #45: GEODE-3868: Client security example should use SSL URL: https://github.com/apache/geode-examples/pull/45#discussion_r162514007 ## File path: clientSecurity/scripts/start.gfsh ## @@ -20,7 +20,7 @@ # This requires that the example_security.json be on the classpath. # Recall that the --classpath option is specified relative to the locator's working directory. -start locator --name=locator --bind-address=127.0.0.1\ +start locator --name=locator --bind-address=127.0.0.1 --connect=false --enable-cluster-configuration=false\ Review comment: I don't think we want to show examples of *not* using cluster configuration...do we? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Client security example should use SSL > -- > > Key: GEODE-3868 > URL: https://issues.apache.org/jira/browse/GEODE-3868 > Project: Geode > Issue Type: Improvement > Components: docs, security >Reporter: Dan Smith >Priority: Major > Labels: pull-request-available > > We added a client security example as part of GEODE-2988. > However, that example does not actually use secure sockets. That makes it a > bad example of how to secure a client, because the credentials are sent over > the wire without encryption. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (GEODE-4061) Adding coordinator in list member command output
[ https://issues.apache.org/jira/browse/GEODE-4061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-4061: -- Labels: pull-request-available (was: ) > Adding coordinator in list member command output > > > Key: GEODE-4061 > URL: https://issues.apache.org/jira/browse/GEODE-4061 > Project: Geode > Issue Type: Bug > Components: docs, gfsh, messaging >Reporter: dinesh ak >Assignee: Karen Smoler Miller >Priority: Major > Labels: pull-request-available > Fix For: 1.4.0 > > > no way to find out the coordinator apart from log messages. > i have added coordinator in list member command output. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-4061) Adding coordinator in list member command output
[ https://issues.apache.org/jira/browse/GEODE-4061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331519#comment-16331519 ] ASF GitHub Bot commented on GEODE-4061: --- karensmolermiller opened a new pull request #1309: GEODE-4061 Update docs output for gfsh list members; URL: https://github.com/apache/geode/pull/1309 include membership coordinator in the output @bschuchardt @upthewaterspout @davebarnes97 @joeymcallister Please review to make sure the new output and explanation of gfsh list members looks correct for the addition of the membership coordinator. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Adding coordinator in list member command output > > > Key: GEODE-4061 > URL: https://issues.apache.org/jira/browse/GEODE-4061 > Project: Geode > Issue Type: Bug > Components: docs, gfsh, messaging >Reporter: dinesh ak >Assignee: Karen Smoler Miller >Priority: Major > Labels: pull-request-available > Fix For: 1.4.0 > > > no way to find out the coordinator apart from log messages. > i have added coordinator in list member command output. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-633) CI failure: GIIDeltaDUnitTest.testTombstoneGCInMiddleOfGII
[
https://issues.apache.org/jira/browse/GEODE-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331500#comment-16331500
]
Nick Reich commented on GEODE-633:
--
Stack trace of recent failure:
{noformat}
org.apache.geode.test.dunit.RMIException: While invoking
org.apache.geode.internal.cache.GIIDeltaDUnitTest$56.run in VM 2 running on
Host 00b6cc25-65ef-45cc-5943-a863d1d47617 with 4 VMs
at org.apache.geode.test.dunit.VM.invoke(VM.java:393)
at org.apache.geode.test.dunit.VM.invoke(VM.java:363)
at org.apache.geode.test.dunit.VM.invoke(VM.java:308)
at
org.apache.geode.internal.cache.GIIDeltaDUnitTest.verifyTombstoneExist(GIIDeltaDUnitTest.java:2662)
at
org.apache.geode.internal.cache.GIIDeltaDUnitTest.testTombstoneGCInMiddleOfGII(GIIDeltaDUnitTest.java:1388)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
at org.junit.rules.RunRules.evaluate(RunRules.java:20)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at
org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
at
org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
at
org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
at
org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
at
org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
at
org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
at
org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
at
org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
at
org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
at
org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:147)
at
org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:129)
at
org.gradle.internal.remote.internal.hub.Mes
[jira] [Commented] (GEODE-3868) Client security example should use SSL
[ https://issues.apache.org/jira/browse/GEODE-3868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331496#comment-16331496 ] ASF GitHub Bot commented on GEODE-3868: --- PurelyApplied commented on a change in pull request #45: GEODE-3868: Client security example should use SSL URL: https://github.com/apache/geode-examples/pull/45#discussion_r162509528 ## File path: clientSecurity/scripts/start.gfsh ## @@ -20,7 +20,7 @@ # This requires that the example_security.json be on the classpath. # Recall that the --classpath option is specified relative to the locator's working directory. -start locator --name=locator --bind-address=127.0.0.1\ +start locator --name=locator --bind-address=127.0.0.1 --connect=false --enable-cluster-configuration=false\ Review comment: Isn't this `--enable-cluster-configuration=false` overwritten by the use of a security manager? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Client security example should use SSL > -- > > Key: GEODE-3868 > URL: https://issues.apache.org/jira/browse/GEODE-3868 > Project: Geode > Issue Type: Improvement > Components: docs, security >Reporter: Dan Smith >Priority: Major > Labels: pull-request-available > > We added a client security example as part of GEODE-2988. > However, that example does not actually use secure sockets. That makes it a > bad example of how to secure a client, because the credentials are sent over > the wire without encryption. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331479#comment-16331479 ] ASF subversion and git services commented on GEODE-3967: Commit df66c915b925fb0719a8ac0abbbe718ed569bb06 in geode's branch refs/heads/feature/GEM-883 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=df66c91 ] GEODE-3967: add more trace arround doPutOrCreate > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou >Assignee: xiaojian zhou >Priority: Major > Labels: pull-request-available > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (GEODE-4320) AbstractConfig reproduces option redaction code
Patrick Rhomberg created GEODE-4320:
---
Summary: AbstractConfig reproduces option redaction code
Key: GEODE-4320
URL: https://issues.apache.org/jira/browse/GEODE-4320
Project: Geode
Issue Type: Bug
Components: logging, security
Reporter: Patrick Rhomberg
{{AbstractConfig}} handles its redaction differently than the
{{ArgumentRedactor}}. This logic should be consolidated to reduce code
duplication.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331432#comment-16331432 ] ASF GitHub Bot commented on GEODE-3967: --- gesterzhou closed pull request #1044: GEODE-3967: if put hits concurrent modification exception should stil… URL: https://github.com/apache/geode/pull/1044 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou >Assignee: xiaojian zhou >Priority: Major > Labels: pull-request-available > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-3967: -- Labels: pull-request-available (was: ) > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou >Assignee: xiaojian zhou >Priority: Major > Labels: pull-request-available > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (GEODE-4129) gfsh list members command feels inconsistent
[
https://issues.apache.org/jira/browse/GEODE-4129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated GEODE-4129:
--
Labels: pull-request-available (was: )
> gfsh list members command feels inconsistent
>
>
> Key: GEODE-4129
> URL: https://issues.apache.org/jira/browse/GEODE-4129
> Project: Geode
> Issue Type: Bug
> Components: gfsh
>Reporter: Jens Deppe
>Priority: Major
> Labels: pull-request-available
>
> {{list members}} now also shows the 'coordinator':
> {noformat}
> gfsh>list members
> Name | Id
> |
> Coordinator: | 10.118.19.26(locator1:7903:locator):1024
> locator1 | 10.118.19.26(locator1:7903:locator):1024
> server1 | 10.118.19.26(server1:7933):1025
> server2 | 10.118.19.26(server2:8075):1026
> {noformat}
> This just looks untidy.
> Here {{server-2}} is part of a group:
> {noformat}
> gfsh>list members --group=group1
> Name | Id
> |
> Coordinator: | 10.118.19.26(locator1:7903:locator):1024
> server2 | 10.118.19.26(server2:8075):1026
> {noformat}
> But the 'coordinator' is not part of that group. Again, inconsistent and
> untidy.
> I would prefer the relevant member to be highlight somehow as a coordinator.
> For example:
> {noformat}
> gfsh>list members
> Name | Id
> |
> locator1 | 10.118.19.26(locator1:7903:locator):1024 [coordinator]
> server1 | 10.118.19.26(server1:7933):1025
> server2 | 10.118.19.26(server2:8075):1026
> {noformat}
> Or perhaps better yet would be to introduce a separate {{list coordinator}}
> command.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GEODE-4129) gfsh list members command feels inconsistent
[
https://issues.apache.org/jira/browse/GEODE-4129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331427#comment-16331427
]
ASF GitHub Bot commented on GEODE-4129:
---
jinmeiliao opened a new pull request #1308: GEODE-4129: do not list coordinator
as a different entry in list memb…
URL: https://github.com/apache/geode/pull/1308
…er command
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to d...@geode.apache.org.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> gfsh list members command feels inconsistent
>
>
> Key: GEODE-4129
> URL: https://issues.apache.org/jira/browse/GEODE-4129
> Project: Geode
> Issue Type: Bug
> Components: gfsh
>Reporter: Jens Deppe
>Priority: Major
> Labels: pull-request-available
>
> {{list members}} now also shows the 'coordinator':
> {noformat}
> gfsh>list members
> Name | Id
> |
> Coordinator: | 10.118.19.26(locator1:7903:locator):1024
> locator1 | 10.118.19.26(locator1:7903:locator):1024
> server1 | 10.118.19.26(server1:7933):1025
> server2 | 10.118.19.26(server2:8075):1026
> {noformat}
> This just looks untidy.
> Here {{server-2}} is part of a group:
> {noformat}
> gfsh>list members --group=group1
> Name | Id
> |
> Coordinator: | 10.118.19.26(locator1:7903:locator):1024
> server2 | 10.118.19.26(server2:8075):1026
> {noformat}
> But the 'coordinator' is not part of that group. Again, inconsistent and
> untidy.
> I would prefer the relevant member to be highlight somehow as a coordinator.
> For example:
> {noformat}
> gfsh>list members
> Name | Id
> |
> locator1 | 10.118.19.26(locator1:7903:locator):1024 [coordinator]
> server1 | 10.118.19.26(server1:7933):1025
> server2 | 10.118.19.26(server2:8075):1026
> {noformat}
> Or perhaps better yet would be to introduce a separate {{list coordinator}}
> command.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GEODE-427) CI failure: MemoryThresholdsDUnitTest.testEventDelivery
[
https://issues.apache.org/jira/browse/GEODE-427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331423#comment-16331423
]
ASF GitHub Bot commented on GEODE-427:
--
kirklund commented on a change in pull request #1307: GEODE-427: Prevent out of
order message processing
URL: https://github.com/apache/geode/pull/1307#discussion_r162501600
##
File path:
geode-core/src/test/java/org/apache/geode/cache/management/MemoryThresholdsDUnitTest.java
##
@@ -522,17 +521,29 @@ public Object call() throws Exception {
verifyListenerValue(server1, MemoryState.EVICTION, 2, true);
verifyListenerValue(server1, MemoryState.NORMAL, 1, true);
-LogWriterUtils.getLogWriter().info("before NORMAL->CRITICAL->NORMAL");
-// NORMAL -> EVICTION -> NORMAL
-server2.invoke(new SerializableCallable("NORMAL->CRITICAL->NORMAL") {
+// NORMAL -> CRITICAL
+server2.invoke(new SerializableCallable("NORMAL->CRITICAL") {
public Object call() throws Exception {
GemFireCacheImpl gfCache = (GemFireCacheImpl) getCache();
gfCache.getInternalResourceManager().getHeapMonitor().updateStateAndSendEvent(950);
+return null;
+ }
+});
+
+verifyListenerValue(server2, MemoryState.CRITICAL, 2, true);
+verifyListenerValue(server2, MemoryState.EVICTION, 3, true);
+verifyListenerValue(server2, MemoryState.NORMAL, 1, true);
+verifyListenerValue(server1, MemoryState.CRITICAL, 2, true);
+verifyListenerValue(server1, MemoryState.EVICTION, 3, true);
+verifyListenerValue(server1, MemoryState.NORMAL, 1, true);
+
+server2.invoke(new SerializableCallable("CRITICAL->NORMAL") {
+ public Object call() throws Exception {
+GemFireCacheImpl gfCache = (GemFireCacheImpl) getCache();
Review comment:
Recommend changing from GemFireCacheImpl to InternalCache. The
getInternalResourceManager method should exist on InternalCache.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> CI failure: MemoryThresholdsDUnitTest.testEventDelivery
> ---
>
> Key: GEODE-427
> URL: https://issues.apache.org/jira/browse/GEODE-427
> Project: Geode
> Issue Type: Bug
>Reporter: Kirk Lund
>Assignee: Nick Reich
>Priority: Major
> Labels: CI, Flaky, pull-request-available
>
> {noformat}
> dunit.RMIException: While invoking
> com.gemstone.gemfire.cache.management.MemoryThresholdsDUnitTest$56.call in VM
> 0 running on Host venezuela.gemstone.com with 4 VMs
> at dunit.VM.invoke(VM.java:360)
> at dunit.VM.invoke(VM.java:303)
> at dunit.VM.invoke(VM.java:271)
> at
> com.gemstone.gemfire.cache.management.MemoryThresholdsDUnitTest.verifyListenerValue(MemoryThresholdsDUnitTest.java:1457)
> at
> com.gemstone.gemfire.cache.management.MemoryThresholdsDUnitTest.testEventDelivery(MemoryThresholdsDUnitTest.java:467)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at junit.framework.TestCase.runTest(TestCase.java:176)
> at junit.framework.TestCase.runBare(TestCase.java:141)
> at junit.framework.TestResult$1.protect(TestResult.java:122)
> at junit.framework.TestResult.runProtected(TestResult.java:142)
> at junit.framework.TestResult.run(TestResult.java:125)
> at junit.framework.TestCase.run(TestCase.java:129)
> at junit.framework.TestSuite.runTest(TestSuite.java:252)
> at junit.framework.TestSuite.run(TestSuite.java:247)
> at
> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:86)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:86)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:49)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:64)
> at
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:50)
> at sun.reflect.GeneratedMethodAccessor219.invoke(Unknown Source)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331407#comment-16331407 ] ASF subversion and git services commented on GEODE-3967: Commit 39ecfa9b5f7018c6c29ec6a8d1861f896bea6b58 in geode's branch refs/heads/feature/GEM-883 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=39ecfa9 ] GEODE-3967: update the log > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou >Assignee: xiaojian zhou >Priority: Major > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (GEODE-987) CI Failure: MemoryThresholdsDUnitTest.testPR_RemotePutRejectionWithTx failed with AssertionFailedError
[
https://issues.apache.org/jira/browse/GEODE-987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Shu reassigned GEODE-987:
--
Assignee: Eric Shu
> CI Failure: MemoryThresholdsDUnitTest.testPR_RemotePutRejectionWithTx failed
> with AssertionFailedError
> --
>
> Key: GEODE-987
> URL: https://issues.apache.org/jira/browse/GEODE-987
> Project: Geode
> Issue Type: Bug
> Components: transactions
>Reporter: Barry Oglesby
>Assignee: Eric Shu
>Priority: Major
> Labels: CI, Flaky
>
> Geode_develop_DistributedTests
> Private Build #1648
> Revision: ef944168056cd7394085c1ef8d7465d75bcdc031
> Error Message
> {noformat}
> com.gemstone.gemfire.test.dunit.RMIException: While invoking
> com.gemstone.gemfire.cache.management.MemoryThresholdsDUnitTest$49.call in VM
> 0 running on Host zambia.gemstone.com with 4 VMs
> {noformat}
> Stacktrace
> {noformat}
> com.gemstone.gemfire.test.dunit.RMIException: While invoking
> com.gemstone.gemfire.cache.management.MemoryThresholdsDUnitTest$49.call in VM
> 0 running on Host zambia.gemstone.com with 4 VMs
> at com.gemstone.gemfire.test.dunit.VM.invoke(VM.java:372)
> at com.gemstone.gemfire.test.dunit.VM.invoke(VM.java:315)
> at com.gemstone.gemfire.test.dunit.VM.invoke(VM.java:281)
> at
> com.gemstone.gemfire.cache.management.MemoryThresholdsDUnitTest.doPutAlls(MemoryThresholdsDUnitTest.java:1334)
> at
> com.gemstone.gemfire.cache.management.MemoryThresholdsDUnitTest.prRemotePutRejection(MemoryThresholdsDUnitTest.java:663)
> at
> com.gemstone.gemfire.cache.management.MemoryThresholdsDUnitTest.testPR_RemotePutRejectionWithTx(MemoryThresholdsDUnitTest.java:572)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at junit.framework.TestCase.runTest(TestCase.java:176)
> at junit.framework.TestCase.runBare(TestCase.java:141)
> at junit.framework.TestResult$1.protect(TestResult.java:122)
> at junit.framework.TestResult.runProtected(TestResult.java:142)
> at junit.framework.TestResult.run(TestResult.java:125)
> at junit.framework.TestCase.run(TestCase.java:129)
> at junit.framework.TestSuite.runTest(TestSuite.java:252)
> at junit.framework.TestSuite.run(TestSuite.java:247)
> at
> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:86)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:105)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:56)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:64)
> at
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:50)
> at sun.reflect.GeneratedMethodAccessor7.invoke(Unknown Source)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
> at
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
> at
> org.gradle.messaging.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
> at
> org.gradle.messaging.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
> at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
> at
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:106)
> at sun.reflect.GeneratedMethodAccessor6.invoke(Unknown Source)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
> at
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
> at
> org.gradle.messaging.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:360)
> at
> org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:54)
> at
> org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:40)
> at
> java.util.concur
[jira] [Commented] (GEODE-427) CI failure: MemoryThresholdsDUnitTest.testEventDelivery
[
https://issues.apache.org/jira/browse/GEODE-427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331398#comment-16331398
]
ASF GitHub Bot commented on GEODE-427:
--
nreich opened a new pull request #1307: GEODE-427: Prevent out of order message
processing
URL: https://github.com/apache/geode/pull/1307
* This test could fail if two messages are sent close enough in time that
* they are processed out of order, as the test expects each message to be
* processed in order, though there is no product requirement for that
* behavior
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> CI failure: MemoryThresholdsDUnitTest.testEventDelivery
> ---
>
> Key: GEODE-427
> URL: https://issues.apache.org/jira/browse/GEODE-427
> Project: Geode
> Issue Type: Bug
>Reporter: Kirk Lund
>Assignee: Nick Reich
>Priority: Major
> Labels: CI, Flaky, pull-request-available
>
> {noformat}
> dunit.RMIException: While invoking
> com.gemstone.gemfire.cache.management.MemoryThresholdsDUnitTest$56.call in VM
> 0 running on Host venezuela.gemstone.com with 4 VMs
> at dunit.VM.invoke(VM.java:360)
> at dunit.VM.invoke(VM.java:303)
> at dunit.VM.invoke(VM.java:271)
> at
> com.gemstone.gemfire.cache.management.MemoryThresholdsDUnitTest.verifyListenerValue(MemoryThresholdsDUnitTest.java:1457)
> at
> com.gemstone.gemfire.cache.management.MemoryThresholdsDUnitTest.testEventDelivery(MemoryThresholdsDUnitTest.java:467)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at junit.framework.TestCase.runTest(TestCase.java:176)
> at junit.framework.TestCase.runBare(TestCase.java:141)
> at junit.framework.TestResult$1.protect(TestResult.java:122)
> at junit.framework.TestResult.runProtected(TestResult.java:142)
> at junit.framework.TestResult.run(TestResult.java:125)
> at junit.framework.TestCase.run(TestCase.java:129)
> at junit.framework.TestSuite.runTest(TestSuite.java:252)
> at junit.framework.TestSuite.run(TestSuite.java:247)
> at
> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:86)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:86)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:49)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:64)
> at
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:50)
> at sun.reflect.GeneratedMethodAccessor219.invoke(Unknown Source)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
> at
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
> at
> org.gradle.messaging.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
> at
> org.gradle.messaging.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
> at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
> at
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:106)
> at sun.reflect.GeneratedMethodAccessor218.invoke(Unknown Source)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
> at
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
> at
> org.gradle.messaging.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:360)
> at
> org.gradle.internal.concurrent.DefaultExecutorFactory$StoppableExecutorImpl$1.run(DefaultExecutorFactory.java:64)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecuto
[jira] [Updated] (GEODE-427) CI failure: MemoryThresholdsDUnitTest.testEventDelivery
[
https://issues.apache.org/jira/browse/GEODE-427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated GEODE-427:
-
Labels: CI Flaky pull-request-available (was: CI Flaky)
> CI failure: MemoryThresholdsDUnitTest.testEventDelivery
> ---
>
> Key: GEODE-427
> URL: https://issues.apache.org/jira/browse/GEODE-427
> Project: Geode
> Issue Type: Bug
>Reporter: Kirk Lund
>Assignee: Nick Reich
>Priority: Major
> Labels: CI, Flaky, pull-request-available
>
> {noformat}
> dunit.RMIException: While invoking
> com.gemstone.gemfire.cache.management.MemoryThresholdsDUnitTest$56.call in VM
> 0 running on Host venezuela.gemstone.com with 4 VMs
> at dunit.VM.invoke(VM.java:360)
> at dunit.VM.invoke(VM.java:303)
> at dunit.VM.invoke(VM.java:271)
> at
> com.gemstone.gemfire.cache.management.MemoryThresholdsDUnitTest.verifyListenerValue(MemoryThresholdsDUnitTest.java:1457)
> at
> com.gemstone.gemfire.cache.management.MemoryThresholdsDUnitTest.testEventDelivery(MemoryThresholdsDUnitTest.java:467)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at junit.framework.TestCase.runTest(TestCase.java:176)
> at junit.framework.TestCase.runBare(TestCase.java:141)
> at junit.framework.TestResult$1.protect(TestResult.java:122)
> at junit.framework.TestResult.runProtected(TestResult.java:142)
> at junit.framework.TestResult.run(TestResult.java:125)
> at junit.framework.TestCase.run(TestCase.java:129)
> at junit.framework.TestSuite.runTest(TestSuite.java:252)
> at junit.framework.TestSuite.run(TestSuite.java:247)
> at
> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:86)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:86)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:49)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:64)
> at
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:50)
> at sun.reflect.GeneratedMethodAccessor219.invoke(Unknown Source)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
> at
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
> at
> org.gradle.messaging.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
> at
> org.gradle.messaging.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
> at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
> at
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:106)
> at sun.reflect.GeneratedMethodAccessor218.invoke(Unknown Source)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
> at
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
> at
> org.gradle.messaging.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:360)
> at
> org.gradle.internal.concurrent.DefaultExecutorFactory$StoppableExecutorImpl$1.run(DefaultExecutorFactory.java:64)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> Caused by: junit.framework.AssertionFailedError: Event never occurred after
> 5000 ms: Remote CRITICAL assert failed TestListenerStatus: normalCalls :1
> allCalls :3 criticalThresholdCalls :1 evictionThresholdCalls :2
> previousNormalCalls :1 bytesFromThreshold :50 currentHeapPercentage :75
> evictionDisabledCalls :0 criticalDisabledCalls :0
> at junit.framework.Assert.fail(Assert.java:57)
> at junit.framework.TestCase.fail(TestCase.java:227)
> at
> dunit.DistributedTestCase.waitForCriterion(DistributedTestCase.java:116
[jira] [Assigned] (GEODE-427) CI failure: MemoryThresholdsDUnitTest.testEventDelivery
[
https://issues.apache.org/jira/browse/GEODE-427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Reich reassigned GEODE-427:
Assignee: Nick Reich
> CI failure: MemoryThresholdsDUnitTest.testEventDelivery
> ---
>
> Key: GEODE-427
> URL: https://issues.apache.org/jira/browse/GEODE-427
> Project: Geode
> Issue Type: Bug
>Reporter: Kirk Lund
>Assignee: Nick Reich
>Priority: Major
> Labels: CI, Flaky
>
> {noformat}
> dunit.RMIException: While invoking
> com.gemstone.gemfire.cache.management.MemoryThresholdsDUnitTest$56.call in VM
> 0 running on Host venezuela.gemstone.com with 4 VMs
> at dunit.VM.invoke(VM.java:360)
> at dunit.VM.invoke(VM.java:303)
> at dunit.VM.invoke(VM.java:271)
> at
> com.gemstone.gemfire.cache.management.MemoryThresholdsDUnitTest.verifyListenerValue(MemoryThresholdsDUnitTest.java:1457)
> at
> com.gemstone.gemfire.cache.management.MemoryThresholdsDUnitTest.testEventDelivery(MemoryThresholdsDUnitTest.java:467)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at junit.framework.TestCase.runTest(TestCase.java:176)
> at junit.framework.TestCase.runBare(TestCase.java:141)
> at junit.framework.TestResult$1.protect(TestResult.java:122)
> at junit.framework.TestResult.runProtected(TestResult.java:142)
> at junit.framework.TestResult.run(TestResult.java:125)
> at junit.framework.TestCase.run(TestCase.java:129)
> at junit.framework.TestSuite.runTest(TestSuite.java:252)
> at junit.framework.TestSuite.run(TestSuite.java:247)
> at
> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:86)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:86)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:49)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:64)
> at
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:50)
> at sun.reflect.GeneratedMethodAccessor219.invoke(Unknown Source)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
> at
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
> at
> org.gradle.messaging.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
> at
> org.gradle.messaging.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
> at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
> at
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:106)
> at sun.reflect.GeneratedMethodAccessor218.invoke(Unknown Source)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
> at
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
> at
> org.gradle.messaging.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:360)
> at
> org.gradle.internal.concurrent.DefaultExecutorFactory$StoppableExecutorImpl$1.run(DefaultExecutorFactory.java:64)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> Caused by: junit.framework.AssertionFailedError: Event never occurred after
> 5000 ms: Remote CRITICAL assert failed TestListenerStatus: normalCalls :1
> allCalls :3 criticalThresholdCalls :1 evictionThresholdCalls :2
> previousNormalCalls :1 bytesFromThreshold :50 currentHeapPercentage :75
> evictionDisabledCalls :0 criticalDisabledCalls :0
> at junit.framework.Assert.fail(Assert.java:57)
> at junit.framework.TestCase.fail(TestCase.java:227)
> at
> dunit.DistributedTestCase.waitForCriterion(DistributedTestCase.java:1162)
> at
> com.gemstone.gemfire.cache.management.Memory
[jira] [Commented] (GEODE-3322) geode-core:javadoc is generating warnings
[
https://issues.apache.org/jira/browse/GEODE-3322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331361#comment-16331361
]
ASF subversion and git services commented on GEODE-3322:
Commit cb3baf3bc9da743a9329ea98d9b9a9d00afb16d3 in geode's branch
refs/heads/develop from [~agingade]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=cb3baf3 ]
GEODE-3322: Fix javadoc warnings
> geode-core:javadoc is generating warnings
> -
>
> Key: GEODE-3322
> URL: https://issues.apache.org/jira/browse/GEODE-3322
> Project: Geode
> Issue Type: Bug
> Components: build, membership
>Reporter: Kirk Lund
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.3.0
>
>
> {noformat}
> :geode-core:javadoc
> /Users/klund/dev/gemfire/open/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/HostAddress.java:45:
> warning - @return tag has no arguments.
> 1 warning
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GEODE-3322) geode-core:javadoc is generating warnings
[
https://issues.apache.org/jira/browse/GEODE-3322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331360#comment-16331360
]
ASF GitHub Bot commented on GEODE-3322:
---
agingade closed pull request #1305: GEODE-3322: Fix javadoc warnings
URL: https://github.com/apache/geode/pull/1305
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> geode-core:javadoc is generating warnings
> -
>
> Key: GEODE-3322
> URL: https://issues.apache.org/jira/browse/GEODE-3322
> Project: Geode
> Issue Type: Bug
> Components: build, membership
>Reporter: Kirk Lund
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.3.0
>
>
> {noformat}
> :geode-core:javadoc
> /Users/klund/dev/gemfire/open/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/HostAddress.java:45:
> warning - @return tag has no arguments.
> 1 warning
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Reopened] (GEODE-4061) Adding coordinator in list member command output
[ https://issues.apache.org/jira/browse/GEODE-4061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karen Smoler Miller reopened GEODE-4061: Assignee: Karen Smoler Miller (was: Kenneth Howe) Reopening to complete documentation. > Adding coordinator in list member command output > > > Key: GEODE-4061 > URL: https://issues.apache.org/jira/browse/GEODE-4061 > Project: Geode > Issue Type: Bug > Components: docs, gfsh, messaging >Reporter: dinesh ak >Assignee: Karen Smoler Miller >Priority: Major > Fix For: 1.4.0 > > > no way to find out the coordinator apart from log messages. > i have added coordinator in list member command output. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-3554) Document not invoking CacheFactory.getAnyInstance() from user callbacks
[ https://issues.apache.org/jira/browse/GEODE-3554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331350#comment-16331350 ] ASF GitHub Bot commented on GEODE-3554: --- agingade opened a new pull request #1306: GEODE-3554: Add javadoc warning about getAnyInstance in CacheCallback URL: https://github.com/apache/geode/pull/1306 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Document not invoking CacheFactory.getAnyInstance() from user callbacks > --- > > Key: GEODE-3554 > URL: https://issues.apache.org/jira/browse/GEODE-3554 > Project: Geode > Issue Type: New Feature > Components: core >Reporter: Fred Krone >Priority: Major > Labels: cache, geode-150, pull-request-available > > As long as the product continues to invoke user plug-in callbacks during > startup (and with the main thread), we probably need to document a warning > not to use CacheFactory.getAnyInstance() as the API call is common in > plug-ins and this will freeze startup. > We are planning on deprecating and removing CacheFactory.getAnyInstance() > anyway. > Documentation should recommend using preferred APIs: > * FunctionContext.getCache() > * Event.getRegion().getCache() > We could expose Event.getCache() to make it more obvious to users. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (GEODE-3554) Document not invoking CacheFactory.getAnyInstance() from user callbacks
[ https://issues.apache.org/jira/browse/GEODE-3554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-3554: -- Labels: cache geode-150 pull-request-available (was: cache geode-150) > Document not invoking CacheFactory.getAnyInstance() from user callbacks > --- > > Key: GEODE-3554 > URL: https://issues.apache.org/jira/browse/GEODE-3554 > Project: Geode > Issue Type: New Feature > Components: core >Reporter: Fred Krone >Priority: Major > Labels: cache, geode-150, pull-request-available > > As long as the product continues to invoke user plug-in callbacks during > startup (and with the main thread), we probably need to document a warning > not to use CacheFactory.getAnyInstance() as the API call is common in > plug-ins and this will freeze startup. > We are planning on deprecating and removing CacheFactory.getAnyInstance() > anyway. > Documentation should recommend using preferred APIs: > * FunctionContext.getCache() > * Event.getRegion().getCache() > We could expose Event.getCache() to make it more obvious to users. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-3391) eval shared_ptr usage in CacheListener/CacheLoader/CacheTransactionMgr/CacheWriter
[ https://issues.apache.org/jira/browse/GEODE-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331338#comment-16331338 ] ASF subversion and git services commented on GEODE-3391: Commit f29295906065f99429943fc12a1ca36c9e0f1a9b in geode-native's branch refs/heads/develop from [~dkimura] [ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=f292959 ] GEODE-3391: Update Transaction id to pass by references (#188) > eval shared_ptr usage in > CacheListener/CacheLoader/CacheTransactionMgr/CacheWriter > -- > > Key: GEODE-3391 > URL: https://issues.apache.org/jira/browse/GEODE-3391 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Ernest Burghardt >Priority: Major > Labels: pull-request-available > > evaluate shared_ptr usage and change to reference > virtual void afterRegionDisconnected(Region& region) > virtual CacheablePtr load(Region& rp, const CacheableKeyPtr& key, > const UserDataPtr& aCallbackArgument) = 0; > virtual void close(Region& rp); > virtual void resume(const TransactionId& transactionId) > virtual const TransactionId& getTransactionId() = 0; > virtual void close(Region& rp); -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-4250) Users would like a command to re-establish redundancy without rebalancing
[ https://issues.apache.org/jira/browse/GEODE-4250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331282#comment-16331282 ] Dan Smith commented on GEODE-4250: -- In response to Kirk's comment - there is automated rebalancing and automated redundancy recovery already. Automated redundancy recovery is handled by the recovery-delay and startup-recovery-delay settings. For rebalancing, there is a separate geode-rebalancer module. > Users would like a command to re-establish redundancy without rebalancing > - > > Key: GEODE-4250 > URL: https://issues.apache.org/jira/browse/GEODE-4250 > Project: Geode > Issue Type: Improvement > Components: docs, regions >Reporter: Fred Krone >Priority: Major > > Command would only succeed when the system is fully redundant. > Re-establishing Redundancy after the loss of a peer node is typically far > more urgent and important than achieving better balance. The operational > impact of rebalancing is also much higher, forcing impacted buckets' updates > to be distributed to _redundancy-copies + 1_ peer processes and potentially > spiking p2p connections/threads (and thus load) far beyond normal operations. > If the system is already close to exhausting available capacity for some > hardware component, this can be enough to push it over-the-edge (and may > force the original fault to recur).This problem is exacerbated when the > cluster's overall capacity has been reduced due to the loss of a physical > server. Without the ability to separate the operational tasks of > re-establishing full data redundancy and rebalancing bucket partitions (that > are already safely redundant), system administrators may be forced to > provision replacement capacity _before_ they can restore full service, thus > increasing downtime unnecessarily. > For these reasons, we must add the option to execute these operational tasks > separately. > It still makes sense for _rebalancing_ ops to first re-establish redundancy, > so we can keep the existing GFSH command/behavior (it would still be useful > to clearly log completion of one step before the next one begins). We need a > new GFSH command/ResourceManager API to execute re-establishment of > redundancy _without_ rebalancing. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-4250) Users would like a command to re-establish redundancy without rebalancing
[ https://issues.apache.org/jira/browse/GEODE-4250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331263#comment-16331263 ] Kirk Lund commented on GEODE-4250: -- This should probably be exposed to Users in two places: * ResourceManager API * GFSH command(s) Would it be valuable to provide some sort of automated redundancy recovery? We did NOT provide that for rebalancing because it was such an expensive operation. But for redundancy recovery, it might be acceptable. > Users would like a command to re-establish redundancy without rebalancing > - > > Key: GEODE-4250 > URL: https://issues.apache.org/jira/browse/GEODE-4250 > Project: Geode > Issue Type: Improvement > Components: docs, regions >Reporter: Fred Krone >Priority: Major > > Command would only succeed when the system is fully redundant. > Re-establishing Redundancy after the loss of a peer node is typically far > more urgent and important than achieving better balance. The operational > impact of rebalancing is also much higher, forcing impacted buckets' updates > to be distributed to _redundancy-copies + 1_ peer processes and potentially > spiking p2p connections/threads (and thus load) far beyond normal operations. > If the system is already close to exhausting available capacity for some > hardware component, this can be enough to push it over-the-edge (and may > force the original fault to recur).This problem is exacerbated when the > cluster's overall capacity has been reduced due to the loss of a physical > server. Without the ability to separate the operational tasks of > re-establishing full data redundancy and rebalancing bucket partitions (that > are already safely redundant), system administrators may be forced to > provision replacement capacity _before_ they can restore full service, thus > increasing downtime unnecessarily. > For these reasons, we must add the option to execute these operational tasks > separately. > It still makes sense for _rebalancing_ ops to first re-establish redundancy, > so we can keep the existing GFSH command/behavior (it would still be useful > to clearly log completion of one step before the next one begins). We need a > new GFSH command/ResourceManager API to execute re-establishment of > redundancy _without_ rebalancing. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (GEODE-3554) Document not invoking CacheFactory.getAnyInstance() from user callbacks
[ https://issues.apache.org/jira/browse/GEODE-3554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-3554: - Description: As long as the product continues to invoke user plug-in callbacks during startup (and with the main thread), we probably need to document a warning not to use CacheFactory.getAnyInstance() as the API call is common in plug-ins and this will freeze startup. We are planning on deprecating and removing CacheFactory.getAnyInstance() anyway. Documentation should recommend using preferred APIs: * FunctionContext.getCache() * Event.getRegion().getCache() We could expose Event.getCache() to make it more obvious to users. was: As long as the product continues to invoke user plug-in callbacks during startup (and with the main thread), we probably need to document a warning not to use CacheFactory.getAnyInstance() as the API call is common in plug-ins and this will freeze startup. We are planning on deprecating and removing CacheFactory.getAnyInstance() anyway. > Document not invoking CacheFactory.getAnyInstance() from user callbacks > --- > > Key: GEODE-3554 > URL: https://issues.apache.org/jira/browse/GEODE-3554 > Project: Geode > Issue Type: New Feature > Components: core >Reporter: Fred Krone >Priority: Major > Labels: cache, geode-150 > > As long as the product continues to invoke user plug-in callbacks during > startup (and with the main thread), we probably need to document a warning > not to use CacheFactory.getAnyInstance() as the API call is common in > plug-ins and this will freeze startup. > We are planning on deprecating and removing CacheFactory.getAnyInstance() > anyway. > Documentation should recommend using preferred APIs: > * FunctionContext.getCache() > * Event.getRegion().getCache() > We could expose Event.getCache() to make it more obvious to users. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (GEODE-3554) Document not invoking CacheFactory.getAnyInstance() from user callbacks
[ https://issues.apache.org/jira/browse/GEODE-3554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fred Krone updated GEODE-3554: -- Description: As long as the product continues to invoke user plug-in callbacks during startup (and with the main thread), we probably need to document a warning not to use CacheFactory.getAnyInstance() as the API call is common in plug-ins and this will freeze startup. We are planning on deprecating and removing CacheFactory.getAnyInstance() anyway. was: As long as the product continues to invoke user plug-in callbacks during startup (and with the main thread), we probably need to document a warning not to use CacheFactory.getAnyInstance() as the API call is common in plug-ins and this will freeze startup. A better fix could be to make changes to cache initialization that would prevent this deadlock. > Document not invoking CacheFactory.getAnyInstance() from user callbacks > --- > > Key: GEODE-3554 > URL: https://issues.apache.org/jira/browse/GEODE-3554 > Project: Geode > Issue Type: New Feature > Components: core >Reporter: Fred Krone >Priority: Major > Labels: cache, geode-150 > > As long as the product continues to invoke user plug-in callbacks during > startup (and with the main thread), we probably need to document a warning > not to use CacheFactory.getAnyInstance() as the API call is common in > plug-ins and this will freeze startup. > We are planning on deprecating and removing CacheFactory.getAnyInstance() > anyway. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (GEODE-3554) Document not invoking CacheFactory.getAnyInstance() from user callbacks
[ https://issues.apache.org/jira/browse/GEODE-3554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fred Krone updated GEODE-3554: -- Description: As long as the product continues to invoke user plug-in callbacks during startup (and with the main thread), we probably need to document a warning not to use CacheFactory.getAnyInstance() as the API call is common in plug-ins and this will freeze startup. A better fix could be to make changes to cache initialization that would prevent this deadlock. was: As long as the product continues to invoke user plug-in callbacks during startup (and with the main thread), we probably need to document a warning not to use CacheFactory.getAnyInstance() as the API call is common in plug-ins and this will freeze startup. A better fix could be to make changes to cache initialization that would prevent this deadlock. > Document not invoking CacheFactory.getAnyInstance() from user callbacks > --- > > Key: GEODE-3554 > URL: https://issues.apache.org/jira/browse/GEODE-3554 > Project: Geode > Issue Type: New Feature > Components: core >Reporter: Fred Krone >Priority: Major > Labels: cache, geode-150 > > As long as the product continues to invoke user plug-in callbacks during > startup (and with the main thread), we probably need to document a warning > not to use CacheFactory.getAnyInstance() as the API call is common in > plug-ins and this will freeze startup. > > > A better fix could be to make changes to cache initialization that would > prevent this deadlock. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (GEODE-3554) Document not invoking CacheFactory.getAnyInstance() from user callbacks
[ https://issues.apache.org/jira/browse/GEODE-3554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fred Krone updated GEODE-3554: -- Summary: Document not invoking CacheFactory.getAnyInstance() from user callbacks (was: Fix startup freeze at callback to CacheFactory.getAnyInstance() ) > Document not invoking CacheFactory.getAnyInstance() from user callbacks > --- > > Key: GEODE-3554 > URL: https://issues.apache.org/jira/browse/GEODE-3554 > Project: Geode > Issue Type: New Feature > Components: core >Reporter: Fred Krone >Priority: Major > Labels: cache, geode-150 > > As long as the product continues to invoke user plug-in callbacks during > startup (and with the main thread), we probably need to document a warning > not to use CacheFactory.getAnyInstance() as the API call is common in > plug-ins and this will freeze startup. > A better fix could be to make changes to cache initialization that would > prevent this deadlock. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-3554) Fix startup freeze at callback to CacheFactory.getAnyInstance()
[ https://issues.apache.org/jira/browse/GEODE-3554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331215#comment-16331215 ] Fred Krone commented on GEODE-3554: --- [~klund] sounds good to me. I'll update this. > Fix startup freeze at callback to CacheFactory.getAnyInstance() > - > > Key: GEODE-3554 > URL: https://issues.apache.org/jira/browse/GEODE-3554 > Project: Geode > Issue Type: New Feature > Components: core >Reporter: Fred Krone >Priority: Major > Labels: cache, geode-150 > > As long as the product continues to invoke user plug-in callbacks during > startup (and with the main thread), we probably need to document a warning > not to use CacheFactory.getAnyInstance() as the API call is common in > plug-ins and this will freeze startup. > A better fix could be to make changes to cache initialization that would > prevent this deadlock. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-4238) CI failure: RegionExpirationDUnitTest.testRegionTTLInvalidate
[
https://issues.apache.org/jira/browse/GEODE-4238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331174#comment-16331174
]
ASF subversion and git services commented on GEODE-4238:
Commit f0d3f239b960a209abe6d8fd2e0a63f50833ebe2 in geode's branch
refs/heads/develop from [~apa...@the9muses.net]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=f0d3f23 ]
GEODE-4238: rewrite flaky region expiration tests (#1292)
> CI failure: RegionExpirationDUnitTest.testRegionTTLInvalidate
> -
>
> Key: GEODE-4238
> URL: https://issues.apache.org/jira/browse/GEODE-4238
> Project: Geode
> Issue Type: Bug
> Components: expiration
>Reporter: Nick Reich
>Assignee: Kirk Lund
>Priority: Major
> Labels: pull-request-available
>
> {noformat}
> org.apache.geode.cache30.RegionExpirationDUnitTest > testRegionTTLInvalidate
> FAILED
> org.apache.geode.test.dunit.RMIException: While invoking
> org.apache.geode.cache30.RegionExpirationDUnitTest$6.run in VM 1 running on
> Host cad33bfaeb5e with 4 VMs
> at org.apache.geode.test.dunit.VM.invoke(VM.java:393)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:363)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:308)
> at
> org.apache.geode.cache30.RegionExpirationDUnitTest._testRegionTTL(RegionExpirationDUnitTest.java:217)
> at
> org.apache.geode.cache30.RegionExpirationDUnitTest.testRegionTTLInvalidate(RegionExpirationDUnitTest.java:96)
> Caused by:
> java.lang.AssertionError
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GEODE-4238) CI failure: RegionExpirationDUnitTest.testRegionTTLInvalidate
[
https://issues.apache.org/jira/browse/GEODE-4238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331173#comment-16331173
]
ASF GitHub Bot commented on GEODE-4238:
---
kirklund closed pull request #1292: GEODE-4238: rewrite flaky region expiration
tests
URL: https://github.com/apache/geode/pull/1292
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/geode-core/src/test/java/org/apache/geode/cache/RegionExpirationDUnitTest.java
b/geode-core/src/test/java/org/apache/geode/cache/RegionExpirationDUnitTest.java
new file mode 100644
index 00..63dc650372
--- /dev/null
+++
b/geode-core/src/test/java/org/apache/geode/cache/RegionExpirationDUnitTest.java
@@ -0,0 +1,193 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express
+ * or implied. See the License for the specific language governing permissions
and limitations under
+ * the License.
+ */
+package org.apache.geode.cache;
+
+import static java.util.concurrent.TimeUnit.MINUTES;
+import static org.apache.geode.cache.RegionShortcut.REPLICATE;
+import static org.apache.geode.test.dunit.Host.getHost;
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.Mockito.spy;
+import static org.mockito.Mockito.timeout;
+
+import java.io.Serializable;
+import java.util.function.Consumer;
+
+import junitparams.JUnitParamsRunner;
+import junitparams.Parameters;
+import junitparams.naming.TestCaseName;
+import org.junit.Before;
+import org.junit.ClassRule;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.runner.RunWith;
+import org.mockito.Mockito;
+
+import org.apache.geode.test.dunit.VM;
+import org.apache.geode.test.dunit.rules.CacheRule;
+import org.apache.geode.test.dunit.rules.DistributedTestRule;
+import org.apache.geode.test.junit.categories.DistributedTest;
+import org.apache.geode.test.junit.rules.serializable.SerializableTestName;
+
+/**
+ * Test Region expiration - both time-to-live and idle timeout.
+ *
+ *
+ * Note: See LocalRegionTest and MultiVMRegionTestCase for more expiration
tests.
+ *
+ *
+ * Single-JVM tests were extracted to {@link RegionExpirationIntegrationTest}.
+ *
+ * @since GemFire 3.0
+ */
+@Category(DistributedTest.class)
+@RunWith(JUnitParamsRunner.class)
+@SuppressWarnings("serial")
+public class RegionExpirationDUnitTest implements Serializable {
+
+ private static final int TTL_SECONDS = 10;
+ private static final String KEY = "key";
+ private static final String VALUE = "value";
+
+ private static CacheListener spyCacheListener;
+
+ private String regionName;
+ private VM withExpirationVM0;
+ private VM withoutExpirationVM1;
+
+ @ClassRule
+ public static DistributedTestRule distributedTestRule = new
DistributedTestRule();
+
+ @Rule
+ public CacheRule cacheRule = CacheRule.builder().createCacheInAll().build();
+
+ @Rule
+ public SerializableTestName testName = new SerializableTestName();
+
+ @Before
+ public void setUp() {
+regionName = getClass().getSimpleName() + "_" + testName.getMethodName();
+
+withExpirationVM0 = getHost(0).getVM(0);
+withoutExpirationVM1 = getHost(0).getVM(1);
+ }
+
+ @Test
+ @Parameters({"LOCAL_DESTROY", "DESTROY", "LOCAL_INVALIDATE", "INVALIDATE"})
+ @TestCaseName("{method}({params})")
+ public void regionExpiresAfterTtl(final Verification verification) throws
Exception {
+// In withoutExpirationVM1, create the region - no ttl
+withoutExpirationVM1.invoke(() -> {
+ cacheRule.getCache().createRegionFactory(REPLICATE).create(regionName);
+});
+
+// In withExpirationVM0, create the region with ttl, and put value
+withExpirationVM0.invoke(() -> {
+ spyCacheListener = spy(CacheListener.class);
+
+ RegionFactory regionFactory =
+ cacheRule.getCache().createRegionFactory(REPLICATE);
+ regionFactory.setRegionTimeToLive(
+ new ExpirationAttributes(TTL_SECONDS,
verification.expirationAction()));
+ regionFactory.addCacheListene
[jira] [Comment Edited] (GEODE-3554) Fix startup freeze at callback to CacheFactory.getAnyInstance()
[ https://issues.apache.org/jira/browse/GEODE-3554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331151#comment-16331151 ] Kirk Lund edited comment on GEODE-3554 at 1/18/18 8:31 PM: --- I think a feature request should focus on either 1) document not invoking CacheFactory.getAnyInstance() from user callbacks OR 2) change CacheFactory.getAnyInstance() so that it's safe to invoke from user callbacks, but not both. As for #2, the current plan is to deprecate and remove CacheFactory.getAnyInstance(), so I don't think it's a good idea to accept a feature request to make any behavior changes to this API. I'd like to change this feature request to be documentation and javadocs changes only. was (Author: klund): I think a feature request just as this should focus on either 1) document not invoking CacheFactory.getAnyInstance() from user callbacks OR 2) change CacheFactory.getAnyInstance() so that it's safe to invoke from user callbacks, but not both. As for #2, the current plan is to deprecate and remove CacheFactory.getAnyInstance(), so I don't think it's a good idea to accept a feature request to make any behavior changes to this API. I'd like to change this feature request to be documentation and javadocs changes only. > Fix startup freeze at callback to CacheFactory.getAnyInstance() > - > > Key: GEODE-3554 > URL: https://issues.apache.org/jira/browse/GEODE-3554 > Project: Geode > Issue Type: New Feature > Components: core >Reporter: Fred Krone >Priority: Major > Labels: cache, geode-150 > > As long as the product continues to invoke user plug-in callbacks during > startup (and with the main thread), we probably need to document a warning > not to use CacheFactory.getAnyInstance() as the API call is common in > plug-ins and this will freeze startup. > A better fix could be to make changes to cache initialization that would > prevent this deadlock. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-3554) Fix startup freeze at callback to CacheFactory.getAnyInstance()
[ https://issues.apache.org/jira/browse/GEODE-3554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331151#comment-16331151 ] Kirk Lund commented on GEODE-3554: -- I think a feature request just as this should focus on either 1) document not invoking CacheFactory.getAnyInstance() from user callbacks OR 2) change CacheFactory.getAnyInstance() so that it's safe to invoke from user callbacks, but not both. As for #2, the current plan is to deprecate and remove CacheFactory.getAnyInstance(), so I don't think it's a good idea to accept a feature request to make any behavior changes to this API. I'd like to change this feature request to be documentation and javadocs changes only. > Fix startup freeze at callback to CacheFactory.getAnyInstance() > - > > Key: GEODE-3554 > URL: https://issues.apache.org/jira/browse/GEODE-3554 > Project: Geode > Issue Type: New Feature > Components: core >Reporter: Fred Krone >Priority: Major > Labels: cache, geode-150 > > As long as the product continues to invoke user plug-in callbacks during > startup (and with the main thread), we probably need to document a warning > not to use CacheFactory.getAnyInstance() as the API call is common in > plug-ins and this will freeze startup. > A better fix could be to make changes to cache initialization that would > prevent this deadlock. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (GEODE-4319) CI hang: AsyncEventListenerOffHeapDUnitTest.testPartitionedSerialAsyncEventQueueWithPeristenceEnabled
Jason Huynh created GEODE-4319: -- Summary: CI hang: AsyncEventListenerOffHeapDUnitTest.testPartitionedSerialAsyncEventQueueWithPeristenceEnabled Key: GEODE-4319 URL: https://issues.apache.org/jira/browse/GEODE-4319 Project: Geode Issue Type: Bug Components: client queues Reporter: Jason Huynh It looks like this test was possibly causing a hang. There isn't any output but from the dunit-progress file it looks like it was still running over an hour later. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (GEODE-4211) EvictionListBuilder should not invoke GemFireCacheImpl.getExisting(String)
[ https://issues.apache.org/jira/browse/GEODE-4211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Darrel Schneider resolved GEODE-4211. - Resolution: Fixed Fix Version/s: 1.5.0 fixed as part of GEODE-4299 > EvictionListBuilder should not invoke GemFireCacheImpl.getExisting(String) > -- > > Key: GEODE-4211 > URL: https://issues.apache.org/jira/browse/GEODE-4211 > Project: Geode > Issue Type: Sub-task > Components: eviction >Reporter: Kirk Lund >Assignee: Darrel Schneider >Priority: Major > Fix For: 1.5.0 > > > EvictionListBuilder should not invoke GemFireCacheImpl.getExisting(String) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-4304) Many places in the code access the "dataPolicy" field instead of calling getDataPolicy
[ https://issues.apache.org/jira/browse/GEODE-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331136#comment-16331136 ] ASF subversion and git services commented on GEODE-4304: Commit 3504d51c6be126975dcb394d3e926d0d2552a0b0 in geode's branch refs/heads/develop from [~dschneider] [ https://gitbox.apache.org/repos/asf?p=geode.git;h=3504d51 ] GEODE-4304: use the gettor method for dataPolicy (#1295) GEODE-4304: use the gettor method for dataPolicy > Many places in the code access the "dataPolicy" field instead of calling > getDataPolicy > -- > > Key: GEODE-4304 > URL: https://issues.apache.org/jira/browse/GEODE-4304 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Darrel Schneider >Assignee: Darrel Schneider >Priority: Major > Labels: pull-request-available > Fix For: 1.5.0 > > > The field "dataPolicy" on AbstractRegion is protected. > Many other classes directly access this field instead of calling > getDataPolicy. > The field should be made private and all access to it should be through > methods. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-4304) Many places in the code access the "dataPolicy" field instead of calling getDataPolicy
[ https://issues.apache.org/jira/browse/GEODE-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331135#comment-16331135 ] ASF subversion and git services commented on GEODE-4304: Commit 3504d51c6be126975dcb394d3e926d0d2552a0b0 in geode's branch refs/heads/develop from [~dschneider] [ https://gitbox.apache.org/repos/asf?p=geode.git;h=3504d51 ] GEODE-4304: use the gettor method for dataPolicy (#1295) GEODE-4304: use the gettor method for dataPolicy > Many places in the code access the "dataPolicy" field instead of calling > getDataPolicy > -- > > Key: GEODE-4304 > URL: https://issues.apache.org/jira/browse/GEODE-4304 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Darrel Schneider >Assignee: Darrel Schneider >Priority: Major > Labels: pull-request-available > Fix For: 1.5.0 > > > The field "dataPolicy" on AbstractRegion is protected. > Many other classes directly access this field instead of calling > getDataPolicy. > The field should be made private and all access to it should be through > methods. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (GEODE-4304) Many places in the code access the "dataPolicy" field instead of calling getDataPolicy
[ https://issues.apache.org/jira/browse/GEODE-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Darrel Schneider resolved GEODE-4304. - Resolution: Fixed Fix Version/s: 1.5.0 > Many places in the code access the "dataPolicy" field instead of calling > getDataPolicy > -- > > Key: GEODE-4304 > URL: https://issues.apache.org/jira/browse/GEODE-4304 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Darrel Schneider >Assignee: Darrel Schneider >Priority: Major > Labels: pull-request-available > Fix For: 1.5.0 > > > The field "dataPolicy" on AbstractRegion is protected. > Many other classes directly access this field instead of calling > getDataPolicy. > The field should be made private and all access to it should be through > methods. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-3391) eval shared_ptr usage in CacheListener/CacheLoader/CacheTransactionMgr/CacheWriter
[ https://issues.apache.org/jira/browse/GEODE-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331131#comment-16331131 ] ASF GitHub Bot commented on GEODE-3391: --- pivotal-jbarrett commented on a change in pull request #188: GEODE-3391: Update Transaction id to pass by references URL: https://github.com/apache/geode-native/pull/188#discussion_r162457004 ## File path: cppcache/integration-test/CMakeLists.txt ## @@ -183,8 +183,6 @@ set_property(TEST testThinClientPutAllPRSingleHop PROPERTY LABELS FLAKY) set_property(TEST testThinClientPutAllWithCallBackArgWithoutConcurrency PROPERTY LABELS FLAKY) set_property(TEST testThinClientSecurityCQAuthorizationMU PROPERTY LABELS FLAKY) set_property(TEST testThinClientTXFailover PROPERTY LABELS FLAKY) -set_property(TEST testThinClientTransactionsWithSticky PROPERTY LABELS FLAKY) Review comment: Yay for fixed tests! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > eval shared_ptr usage in > CacheListener/CacheLoader/CacheTransactionMgr/CacheWriter > -- > > Key: GEODE-3391 > URL: https://issues.apache.org/jira/browse/GEODE-3391 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Ernest Burghardt >Priority: Major > Labels: pull-request-available > > evaluate shared_ptr usage and change to reference > virtual void afterRegionDisconnected(Region& region) > virtual CacheablePtr load(Region& rp, const CacheableKeyPtr& key, > const UserDataPtr& aCallbackArgument) = 0; > virtual void close(Region& rp); > virtual void resume(const TransactionId& transactionId) > virtual const TransactionId& getTransactionId() = 0; > virtual void close(Region& rp); -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-4316) Add tests for jar deployment to check for server restarting
[ https://issues.apache.org/jira/browse/GEODE-4316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331118#comment-16331118 ] ASF GitHub Bot commented on GEODE-4316: --- jdeppe-pivotal commented on issue #1303: GEODE-4316: Additional function deploy tests URL: https://github.com/apache/geode/pull/1303#issuecomment-358766928 precheckin is green This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add tests for jar deployment to check for server restarting > --- > > Key: GEODE-4316 > URL: https://issues.apache.org/jira/browse/GEODE-4316 > Project: Geode > Issue Type: Improvement > Components: gfsh >Reporter: Jens Deppe >Assignee: Jens Deppe >Priority: Major > Labels: pull-request-available > > Check whether a function undeploy works correctly when a server is restarted -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-4316) Add tests for jar deployment to check for server restarting
[ https://issues.apache.org/jira/browse/GEODE-4316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331120#comment-16331120 ] ASF subversion and git services commented on GEODE-4316: Commit 893f5a637627cbb450069db76b8368fcfca87ee7 in geode's branch refs/heads/develop from [~jens.deppe] [ https://gitbox.apache.org/repos/asf?p=geode.git;h=893f5a6 ] GEODE-4316: Additional function deploy tests (#1303) - Ensure that undeployed functions remain gone after server restart. > Add tests for jar deployment to check for server restarting > --- > > Key: GEODE-4316 > URL: https://issues.apache.org/jira/browse/GEODE-4316 > Project: Geode > Issue Type: Improvement > Components: gfsh >Reporter: Jens Deppe >Assignee: Jens Deppe >Priority: Major > Labels: pull-request-available > > Check whether a function undeploy works correctly when a server is restarted -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-4316) Add tests for jar deployment to check for server restarting
[
https://issues.apache.org/jira/browse/GEODE-4316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331119#comment-16331119
]
ASF GitHub Bot commented on GEODE-4316:
---
jdeppe-pivotal closed pull request #1303: GEODE-4316: Additional function
deploy tests
URL: https://github.com/apache/geode/pull/1303
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DeployWithGroupsDUnitTest.java
b/geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DeployWithGroupsDUnitTest.java
index 6441df7ce6..a1bd2c4a58 100644
---
a/geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DeployWithGroupsDUnitTest.java
+++
b/geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DeployWithGroupsDUnitTest.java
@@ -180,7 +180,6 @@ public void deployMultipleJarsToOneGroup() throws Exception
{
});
}
-
@Test
public void deployJarToAllServers() throws Exception {
// Deploy a jar to all servers
@@ -200,6 +199,67 @@ public void deployJarToAllServers() throws Exception {
server2.invoke(() -> assertThatCanLoad(jarName1, class1));
}
+ @Test
+ public void deployJarToAllServersWithRestart() throws Exception {
+// Deploy a jar to all servers
+gfshConnector.executeAndAssertThat("deploy --jar=" +
jar1).statusIsSuccess();
+String resultString = gfshConnector.getGfshOutput();
+
+assertThat(resultString).contains(server1.getName());
+assertThat(resultString).contains(server2.getName());
+assertThat(resultString).contains(jarName1);
+
+server1.invoke(() -> assertThatCanLoad(jarName1, class1));
+server2.invoke(() -> assertThatCanLoad(jarName1, class1));
+
+server1.getVM().bounce();
+server2.getVM().bounce();
+
+// Restart the actual cache
+Properties props = new Properties();
+props.setProperty(GROUPS, GROUP1);
+server1 = lsRule.startServerVM(1, props, locator.getPort());
+
+props.setProperty(GROUPS, GROUP2);
+server2 = lsRule.startServerVM(2, props, locator.getPort());
+
+server1.invoke(() -> assertThatCanLoad(jarName1, class1));
+server2.invoke(() -> assertThatCanLoad(jarName1, class1));
+ }
+
+ @Test
+ public void undeployJarFromAllServersWithRestart() throws Exception {
+// Deploy a jar to all servers
+gfshConnector.executeAndAssertThat("deploy --jar=" +
jar1).statusIsSuccess();
+String resultString = gfshConnector.getGfshOutput();
+
+assertThat(resultString).contains(server1.getName());
+assertThat(resultString).contains(server2.getName());
+assertThat(resultString).contains(jarName1);
+
+server1.invoke(() -> assertThatCanLoad(jarName1, class1));
+server2.invoke(() -> assertThatCanLoad(jarName1, class1));
+
+gfshConnector.executeAndAssertThat("undeploy --jar=" +
jar1.getName()).statusIsSuccess();
+// Although the jar is undeployed, we can still access the class
+server1.invoke(() -> assertThatCannotLoad(jarName1, class1));
+server2.invoke(() -> assertThatCannotLoad(jarName1, class1));
+
+server1.getVM().bounce();
+server2.getVM().bounce();
+
+// Restart the actual cache
+Properties props = new Properties();
+props.setProperty(GROUPS, GROUP1);
+server1 = lsRule.startServerVM(1, props, locator.getPort());
+
+props.setProperty(GROUPS, GROUP2);
+server2 = lsRule.startServerVM(2, props, locator.getPort());
+
+server1.invoke(() -> assertThatCannotLoad(jarName1, class1));
+server2.invoke(() -> assertThatCannotLoad(jarName1, class1));
+ }
+
@Test
public void deployMultipleJarsToAllServers() throws Exception {
gfshConnector.executeAndAssertThat("deploy --dir=" +
subdirWithJars3and4.getCanonicalPath())
@@ -263,7 +323,6 @@ private void assertThatCannotLoad(String jarName, String
className) {
.isExactlyInstanceOf(ClassNotFoundException.class);
}
-
@Test
public void testListDeployed() throws Exception {
// Deploy a couple of JAR files which can be listed
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add tests for jar deployment to check for server restarting
> ---
>
> Key: GEODE-4316
> URL: https://issues.apache.org/jira/browse/GEODE-4316
> Project: Geode
> Issue Type: Improvement
>
[jira] [Commented] (GEODE-4316) Add tests for jar deployment to check for server restarting
[
https://issues.apache.org/jira/browse/GEODE-4316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331117#comment-16331117
]
ASF GitHub Bot commented on GEODE-4316:
---
jdeppe-pivotal commented on a change in pull request #1303: GEODE-4316:
Additional function deploy tests
URL: https://github.com/apache/geode/pull/1303#discussion_r162455540
##
File path:
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DeployWithGroupsDUnitTest.java
##
@@ -200,6 +199,67 @@ public void deployJarToAllServers() throws Exception {
server2.invoke(() -> assertThatCanLoad(jarName1, class1));
}
+ @Test
+ public void deployJarToAllServersWithRestart() throws Exception {
+// Deploy a jar to all servers
+gfshConnector.executeAndAssertThat("deploy --jar=" +
jar1).statusIsSuccess();
+String resultString = gfshConnector.getGfshOutput();
+
+assertThat(resultString).contains(server1.getName());
+assertThat(resultString).contains(server2.getName());
+assertThat(resultString).contains(jarName1);
+
+server1.invoke(() -> assertThatCanLoad(jarName1, class1));
+server2.invoke(() -> assertThatCanLoad(jarName1, class1));
+
+server1.getVM().bounce();
Review comment:
`bounce()` does not clean the filesystem AFAICT.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add tests for jar deployment to check for server restarting
> ---
>
> Key: GEODE-4316
> URL: https://issues.apache.org/jira/browse/GEODE-4316
> Project: Geode
> Issue Type: Improvement
> Components: gfsh
>Reporter: Jens Deppe
>Assignee: Jens Deppe
>Priority: Major
> Labels: pull-request-available
>
> Check whether a function undeploy works correctly when a server is restarted
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (GEODE-1611) Region javadocs has misinformation regarding "the root region"
[ https://issues.apache.org/jira/browse/GEODE-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sai Boorlagadda reassigned GEODE-1611: -- Assignee: (was: Sai Boorlagadda) > Region javadocs has misinformation regarding "the root region" > -- > > Key: GEODE-1611 > URL: https://issues.apache.org/jira/browse/GEODE-1611 > Project: Geode > Issue Type: Bug > Components: regions >Reporter: Darrel Schneider >Priority: Major > Labels: javadocs > > The javadocs on the Region interface talks about "the root region". It no > longer exists. Now users can create any number of root regions explicitly > instead of the product having a single implicit root region. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-3391) eval shared_ptr usage in CacheListener/CacheLoader/CacheTransactionMgr/CacheWriter
[
https://issues.apache.org/jira/browse/GEODE-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331036#comment-16331036
]
ASF GitHub Bot commented on GEODE-3391:
---
pivotal-jbarrett commented on a change in pull request #188: GEODE-3391: Update
Transaction id to pass by references
URL: https://github.com/apache/geode-native/pull/188#discussion_r162444128
##
File path: cppcache/src/CacheTransactionManagerImpl.cpp
##
@@ -364,16 +364,16 @@ std::shared_ptr
CacheTransactionManagerImpl::suspend() {
txState->setSuspendedExpiryTaskId(id);
// add the transaction state to the list of suspended transactions
- addSuspendedTx(txState->getTransactionId()->getId(), txState);
+ addSuspendedTx(txState->getTransactionId().getId(), txState);
// set the current transaction state as null
TSSTXStateWrapper::s_geodeTSSTXState->setTXState(nullptr);
// return the transaction ID
- return txState->getTransactionId();
+ return static_cast(txState->getTransactionId());
Review comment:
Let's investigate separate from this ticket.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> eval shared_ptr usage in
> CacheListener/CacheLoader/CacheTransactionMgr/CacheWriter
> --
>
> Key: GEODE-3391
> URL: https://issues.apache.org/jira/browse/GEODE-3391
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Ernest Burghardt
>Priority: Major
> Labels: pull-request-available
>
> evaluate shared_ptr usage and change to reference
> virtual void afterRegionDisconnected(Region& region)
> virtual CacheablePtr load(Region& rp, const CacheableKeyPtr& key,
> const UserDataPtr& aCallbackArgument) = 0;
> virtual void close(Region& rp);
> virtual void resume(const TransactionId& transactionId)
> virtual const TransactionId& getTransactionId() = 0;
> virtual void close(Region& rp);
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GEODE-3391) eval shared_ptr usage in CacheListener/CacheLoader/CacheTransactionMgr/CacheWriter
[
https://issues.apache.org/jira/browse/GEODE-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331035#comment-16331035
]
ASF GitHub Bot commented on GEODE-3391:
---
pivotal-jbarrett commented on a change in pull request #188: GEODE-3391: Update
Transaction id to pass by references
URL: https://github.com/apache/geode-native/pull/188#discussion_r162444049
##
File path: cppcache/include/geode/CacheTransactionManager.hpp
##
@@ -173,15 +173,15 @@ class _GEODE_EXPORT CacheTransactionManager {
* @since 3.6.2
* @see #isSuspended(TransactionId)
*/
- virtual bool exists(std::shared_ptr transactionId) = 0;
+ virtual bool exists(TransactionId& transactionId) = 0;
Review comment:
Let's investigate separate from this ticket.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> eval shared_ptr usage in
> CacheListener/CacheLoader/CacheTransactionMgr/CacheWriter
> --
>
> Key: GEODE-3391
> URL: https://issues.apache.org/jira/browse/GEODE-3391
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Ernest Burghardt
>Priority: Major
> Labels: pull-request-available
>
> evaluate shared_ptr usage and change to reference
> virtual void afterRegionDisconnected(Region& region)
> virtual CacheablePtr load(Region& rp, const CacheableKeyPtr& key,
> const UserDataPtr& aCallbackArgument) = 0;
> virtual void close(Region& rp);
> virtual void resume(const TransactionId& transactionId)
> virtual const TransactionId& getTransactionId() = 0;
> virtual void close(Region& rp);
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GEODE-3322) geode-core:javadoc is generating warnings
[
https://issues.apache.org/jira/browse/GEODE-3322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331003#comment-16331003
]
ASF GitHub Bot commented on GEODE-3322:
---
agingade opened a new pull request #1305: GEODE-3322: Fix javadoc warnings
URL: https://github.com/apache/geode/pull/1305
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> geode-core:javadoc is generating warnings
> -
>
> Key: GEODE-3322
> URL: https://issues.apache.org/jira/browse/GEODE-3322
> Project: Geode
> Issue Type: Bug
> Components: build, membership
>Reporter: Kirk Lund
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.3.0
>
>
> {noformat}
> :geode-core:javadoc
> /Users/klund/dev/gemfire/open/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/HostAddress.java:45:
> warning - @return tag has no arguments.
> 1 warning
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (GEODE-3322) geode-core:javadoc is generating warnings
[
https://issues.apache.org/jira/browse/GEODE-3322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated GEODE-3322:
--
Labels: pull-request-available (was: )
> geode-core:javadoc is generating warnings
> -
>
> Key: GEODE-3322
> URL: https://issues.apache.org/jira/browse/GEODE-3322
> Project: Geode
> Issue Type: Bug
> Components: build, membership
>Reporter: Kirk Lund
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.3.0
>
>
> {noformat}
> :geode-core:javadoc
> /Users/klund/dev/gemfire/open/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/HostAddress.java:45:
> warning - @return tag has no arguments.
> 1 warning
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GEODE-3868) Client security example should use SSL
[ https://issues.apache.org/jira/browse/GEODE-3868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16330999#comment-16330999 ] ASF GitHub Bot commented on GEODE-3868: --- sboorlagadda commented on a change in pull request #45: GEODE-3868: Client security example should use SSL URL: https://github.com/apache/geode-examples/pull/45#discussion_r162438630 ## File path: README.md ## @@ -26,6 +26,11 @@ Contributions[2] and corrections are welcome. Please talk to us about your suggestions at [d...@geode.apache.org](mailto:d...@geode.apache.org) or submit a [pull request](https://github.com/apache/geode/pull/new/develop). +# Apache Geode Version Review comment: fixed readme This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Client security example should use SSL > -- > > Key: GEODE-3868 > URL: https://issues.apache.org/jira/browse/GEODE-3868 > Project: Geode > Issue Type: Improvement > Components: docs, security >Reporter: Dan Smith >Priority: Major > Labels: pull-request-available > > We added a client security example as part of GEODE-2988. > However, that example does not actually use secure sockets. That makes it a > bad example of how to secure a client, because the credentials are sent over > the wire without encryption. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (GEODE-4318) gfsh does not redact passwords from history if given without =
Patrick Rhomberg created GEODE-4318:
---
Summary: gfsh does not redact passwords from history if given
without =
Key: GEODE-4318
URL: https://issues.apache.org/jira/browse/GEODE-4318
Project: Geode
Issue Type: Bug
Reporter: Patrick Rhomberg
The {{ArgumentRedactor}} expects arguments in the form {{--option=value}} and
detects what should be redacted based on {{option}}. However, when given as
{{--option value}}, the terms {{option}} and {{value}} will be parsed
separately and {{value}} will not be redacted.
As a consequence, any {{gfsh}} command executed with {{[command] --user
username --password myPassword}} will be visible in plaintext in command
history.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GEODE-4306) TTL (time to live) expiration not working properly in client side
[ https://issues.apache.org/jira/browse/GEODE-4306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16330968#comment-16330968 ] ASF GitHub Bot commented on GEODE-4306: --- boglesby opened a new pull request #1304: GEODE-4306: Added concurrent checks enabled test to event time URL: https://github.com/apache/geode/pull/1304 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to d...@geode.apache.org. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > TTL (time to live) expiration not working properly in client side > - > > Key: GEODE-4306 > URL: https://issues.apache.org/jira/browse/GEODE-4306 > Project: Geode > Issue Type: Bug > Components: client/server >Reporter: Barry Oglesby >Assignee: Barry Oglesby >Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (GEODE-4306) TTL (time to live) expiration not working properly in client side
[ https://issues.apache.org/jira/browse/GEODE-4306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-4306: -- Labels: pull-request-available (was: ) > TTL (time to live) expiration not working properly in client side > - > > Key: GEODE-4306 > URL: https://issues.apache.org/jira/browse/GEODE-4306 > Project: Geode > Issue Type: Bug > Components: client/server >Reporter: Barry Oglesby >Assignee: Barry Oglesby >Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-4313) Incorrect JVM Argument in gfsh
[
https://issues.apache.org/jira/browse/GEODE-4313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16330967#comment-16330967
]
Kenneth Howe commented on GEODE-4313:
-
What does {{ipconfig}} show on the machine where the Powershell script is
running?
> Incorrect JVM Argument in gfsh
> --
>
> Key: GEODE-4313
> URL: https://issues.apache.org/jira/browse/GEODE-4313
> Project: Geode
> Issue Type: Bug
> Components: gfsh
> Environment: This issue was seen in version 9.1.1 of gemfire running
> on Windows 10.
>Reporter: Michael Martell
>Priority: Minor
>
> When running the attached Powershell script to start a locator and server on
> Windows, the output of the start server command is incorrent.
> *{color:#14892c}Here's the script:{color}*
> param(
> [Parameter(HelpMessage="C# src directory")]
> [string] $cssrc = "C:\gemfire-dotnetsession",
> [Parameter(HelpMessage="Geode root directory")]
> [string] $gfrootdir = "C:\gemfire"
> )
> $ErrorActionPreference = "Stop"
> $IPADDRESS = "localhost"
> $DIRGUID = "samplewebapps"
> pushd $cssrc
> echo "" "Killing java processes..." ""
> Stop-Process -name java -ErrorAction Ignore
> Remove-Item -Recurse -Force "c:\temp\*"
> echo "" "Starting gemfire up..." ""
> pushd ${gfrootdir}\bin
> .\gfsh.bat `
> -e "start locator --name=locator --http-service-port=0
> --dir=C:/temp/${DIRGUID} --bind-address=${IPADDRESS}
> --J=-Dgemfire.jmx-manager-hostname-for-clients=${IPADDRESS}
> --J=-Dgeode.feature-protobuf-protocol=false
> --enable-cluster-configuration=true" `
> -e "configure pdx --read-serialized=true" `
> -e "start server --name=gbp-server --log-level=error
> --dir=C:/temp/${DIRGUID} --bind-address=${IPADDRESS} --J=-XX:+UseG1GC" `
> -e "alter runtime --enable-statistics=true" `
> -e "alter runtime --statistic-archive-file=Statistics.gfs" `
> -e "create region --name=session --type=PARTITION" `
> -e "deploy
> --jar=${cssrc}\build\SessionStateStoreFunctions\SessionStateStoreFunctions.jar"
> if (!$?) \{exit 1}
> popd
>
> {color:#d04437}*Here's the output (Note the error string highlighted in red
> below, where the actual IP Address is concatenated with the loopback
> IP):*{color}
> S C:\gemfire-dotnetsession>
> C:\gemfire-dotnetsession\bin\RunLocalhostGemfire.ps1
> Killing java processes...
> Starting gemfire up...
> (1) Executing - start locator --name=locator --http-service-port=0
> --dir=C:/temp/samplewebapps --bind-address=localhost
> --J=-Dgemfire.jmx-manager-hostname-for-clients=lo
> calhost --J=-Dgeode.feature-protobuf-protocol=false
> --enable-cluster-configuration=true
> ...
> Locator in C:\temp\samplewebapps on 127.0.0.1[10334] as locator is currently
> online.
> Process ID: 19968
> Uptime: 3 seconds
> Geode Version: 9.1.1
> Java Version: 1.8.0_131
> Log File: C:\temp\samplewebapps\locator.log
> JVM Arguments: -Dgemfire.http-service-port=0
> -Dgemfire.enable-cluster-configuration=true
> -Dgemfire.load-cluster-configuration-from-dir=false
> -Dgemfire.jmx-manager-hostna
> me-for-clients=localhost -Dgeode.feature-protobuf-protocol=false
> -Dgemfire.launcher.registerSignalHandlers=true -Djava.awt.headless=true
> -Dsun.rmi.dgc.server.gcInterval=
> 9223372036854775806
> Class-Path:
> C:\gemfire\lib\geode-core-9.1.1.jar;C:\gemfire\lib\geode-dependencies.jar
> Successfully connected to: JMX Manager [host=localhost, port=1099]
> Cluster configuration service is up and running.
> (2) Executing - configure pdx --read-serialized=true
> persistent = false
> read-serialized = true
> ignore-unread-fields = false
> (3) Executing - start server --name=gbp-server --log-level=error
> --dir=C:/temp/samplewebapps --bind-address=localhost --J=-XX:+UseG1GC
>
> Server in C:\temp\samplewebapps on 10.118.33.191[40404] as gbp-server is
> currently online.
> Process ID: 4376
> Uptime: 4 seconds
> Geode Version: 9.1.1
> Java Version: 1.8.0_131
> Log File: C:\temp\samplewebapps\gbp-server.log
> JVM Arguments:
> {color:#d04437}-Dgemfire.default.locators=10.118.33.191:127.0.0.1[10334]{color}
> -Dgemfire.use-cluster-configuration=true -Dgemfire.bind-address=localhost
> -Dgemfire.start-dev-re
> st-api=false -Dgemfire.log-level=error -XX:+UseG1GC
> -XX:OnOutOfMemoryError=taskkill /F /PID %p
> -Dgemfire.launcher.registerSignalHandlers=true -Djava.awt.headless=true -D
> sun.rmi.dgc.server.gcInterval=9223372036854775806
> Class-Path:
> C:\gemfire\lib\geode-core-9.1.1.jar;C:\gemfire\lib\geode-dependencies.jar
> (4) Executing - alter runtime --enable-statistics=true
> Runtime configuration altered successfully for the following member(s)
> 127.0.0.1(gbp-server:4376):1025
>
> (5) Executing - alter runtime --statistic-archive-file=Statistics.gfs
> Runtime configuration altered successfully for the following member(s)
> 127.0.0.1(gbp-server:4376):1025
>
> (6) Exec
[jira] [Assigned] (GEODE-4317) add error handling to the experimental ProtobufDriver's Region implementation
[ https://issues.apache.org/jira/browse/GEODE-4317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruce Schuchardt reassigned GEODE-4317: --- Assignee: Bruce Schuchardt > add error handling to the experimental ProtobufDriver's Region implementation > - > > Key: GEODE-4317 > URL: https://issues.apache.org/jira/browse/GEODE-4317 > Project: Geode > Issue Type: Bug > Components: client/server >Reporter: Bruce Schuchardt >Assignee: Bruce Schuchardt >Priority: Major > > The experimental Protobuf driver is not checking for error responses from the > server. For instance, a put() operation with a malformed JSON document will > appear to succeed even though the server rejected the value. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (GEODE-1611) Region javadocs has misinformation regarding "the root region"
[ https://issues.apache.org/jira/browse/GEODE-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sai Boorlagadda reassigned GEODE-1611: -- Assignee: Sai Boorlagadda > Region javadocs has misinformation regarding "the root region" > -- > > Key: GEODE-1611 > URL: https://issues.apache.org/jira/browse/GEODE-1611 > Project: Geode > Issue Type: Bug > Components: regions >Reporter: Darrel Schneider >Assignee: Sai Boorlagadda >Priority: Major > Labels: javadocs > > The javadocs on the Region interface talks about "the root region". It no > longer exists. Now users can create any number of root regions explicitly > instead of the product having a single implicit root region. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (GEODE-1611) Region javadocs has misinformation regarding "the root region"
[ https://issues.apache.org/jira/browse/GEODE-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sai Boorlagadda reassigned GEODE-1611: -- Assignee: (was: Sai Boorlagadda) > Region javadocs has misinformation regarding "the root region" > -- > > Key: GEODE-1611 > URL: https://issues.apache.org/jira/browse/GEODE-1611 > Project: Geode > Issue Type: Bug > Components: regions >Reporter: Darrel Schneider >Priority: Major > Labels: javadocs > > The javadocs on the Region interface talks about "the root region". It no > longer exists. Now users can create any number of root regions explicitly > instead of the product having a single implicit root region. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (GEODE-4317) add error handling to the experimental ProtobufDriver's Region implementation
Bruce Schuchardt created GEODE-4317: --- Summary: add error handling to the experimental ProtobufDriver's Region implementation Key: GEODE-4317 URL: https://issues.apache.org/jira/browse/GEODE-4317 Project: Geode Issue Type: Bug Components: client/server Reporter: Bruce Schuchardt The experimental Protobuf driver is not checking for error responses from the server. For instance, a put() operation with a malformed JSON document will appear to succeed even though the server rejected the value. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-3868) Client security example should use SSL
[ https://issues.apache.org/jira/browse/GEODE-3868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16330947#comment-16330947 ] ASF GitHub Bot commented on GEODE-3868: --- upthewaterspout commented on a change in pull request #45: GEODE-3868: Client security example should use SSL URL: https://github.com/apache/geode-examples/pull/45#discussion_r162422848 ## File path: README.md ## @@ -26,6 +26,11 @@ Contributions[2] and corrections are welcome. Please talk to us about your suggestions at [d...@geode.apache.org](mailto:d...@geode.apache.org) or submit a [pull request](https://github.com/apache/geode/pull/new/develop). +# Apache Geode Version Review comment: I think we should just tell people to check out the master branch, which should be the default. That will have the examples that run against the latest geode release. We shouldn't point people at the snapshot releases per apache policy. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Client security example should use SSL > -- > > Key: GEODE-3868 > URL: https://issues.apache.org/jira/browse/GEODE-3868 > Project: Geode > Issue Type: Improvement > Components: docs, security >Reporter: Dan Smith >Priority: Major > Labels: pull-request-available > > We added a client security example as part of GEODE-2988. > However, that example does not actually use secure sockets. That makes it a > bad example of how to secure a client, because the credentials are sent over > the wire without encryption. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (GEODE-4256) BCSnapshotDUnitTest.testSnapshot timed out
[ https://issues.apache.org/jira/browse/GEODE-4256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anilkumar Gingade resolved GEODE-4256. -- Resolution: Invalid Test does not exist in Geode > BCSnapshotDUnitTest.testSnapshot timed out > -- > > Key: GEODE-4256 > URL: https://issues.apache.org/jira/browse/GEODE-4256 > Project: Geode > Issue Type: Bug > Components: snapshot >Reporter: Lynn Gallinat >Priority: Major > > org.apache.geode.BCSnapshotDUnitTest > testSnapshot[0] FAILED > java.util.concurrent.TimeoutException > at bcunit.BCBlackboardImpl.waitForGate(BCBlackboardImpl.java:139) > at > org.apache.geode.BCSnapshotDUnitTest.testSnapshot(BCSnapshotDUnitTest.java:92) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (GEODE-4256) BCSnapshotDUnitTest.testSnapshot timed out
[ https://issues.apache.org/jira/browse/GEODE-4256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anilkumar Gingade closed GEODE-4256. > BCSnapshotDUnitTest.testSnapshot timed out > -- > > Key: GEODE-4256 > URL: https://issues.apache.org/jira/browse/GEODE-4256 > Project: Geode > Issue Type: Bug > Components: snapshot >Reporter: Lynn Gallinat >Priority: Major > > org.apache.geode.BCSnapshotDUnitTest > testSnapshot[0] FAILED > java.util.concurrent.TimeoutException > at bcunit.BCBlackboardImpl.waitForGate(BCBlackboardImpl.java:139) > at > org.apache.geode.BCSnapshotDUnitTest.testSnapshot(BCSnapshotDUnitTest.java:92) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-4306) TTL (time to live) expiration not working properly in client side
[ https://issues.apache.org/jira/browse/GEODE-4306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16330888#comment-16330888 ] ASF subversion and git services commented on GEODE-4306: Commit ed3d07695279632266b6f6d27e71b59b28d8cf57 in geode's branch refs/heads/feature/GEODE-4306 from [~barry.oglesby] [ https://gitbox.apache.org/repos/asf?p=geode.git;h=ed3d076 ] GEODE-4306: Added concurrent checks enabled test to event time > TTL (time to live) expiration not working properly in client side > - > > Key: GEODE-4306 > URL: https://issues.apache.org/jira/browse/GEODE-4306 > Project: Geode > Issue Type: Bug > Components: client/server >Reporter: Barry Oglesby >Assignee: Barry Oglesby >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-4147) Add variability to client rebalance logic
[
https://issues.apache.org/jira/browse/GEODE-4147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16330867#comment-16330867
]
ASF GitHub Bot commented on GEODE-4147:
---
upthewaterspout closed pull request #1284: GEODE-4147: Add variability to
client rebalance logic.
URL: https://github.com/apache/geode/pull/1284
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/geode-core/src/main/java/org/apache/geode/cache/client/internal/pooling/ConnectionManagerImpl.java
b/geode-core/src/main/java/org/apache/geode/cache/client/internal/pooling/ConnectionManagerImpl.java
index b2fb67907f..687470bb6d 100644
---
a/geode-core/src/main/java/org/apache/geode/cache/client/internal/pooling/ConnectionManagerImpl.java
+++
b/geode-core/src/main/java/org/apache/geode/cache/client/internal/pooling/ConnectionManagerImpl.java
@@ -15,8 +15,20 @@
package org.apache.geode.cache.client.internal.pooling;
import java.net.SocketException;
-import java.util.*;
-import java.util.concurrent.*;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.Iterator;
+import java.util.LinkedList;
+import java.util.List;
+import java.util.Set;
+import java.util.SplittableRandom;
+import java.util.concurrent.RejectedExecutionException;
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.ScheduledThreadPoolExecutor;
+import java.util.concurrent.ThreadFactory;
+import java.util.concurrent.TimeUnit;
import java.util.concurrent.locks.Condition;
import java.util.concurrent.locks.ReentrantLock;
@@ -26,9 +38,18 @@
import org.apache.geode.CancelException;
import org.apache.geode.SystemFailure;
import org.apache.geode.cache.GatewayConfigurationException;
-import org.apache.geode.cache.client.*;
-import org.apache.geode.cache.client.internal.*;
+import org.apache.geode.cache.client.AllConnectionsInUseException;
+import org.apache.geode.cache.client.NoAvailableServersException;
+import org.apache.geode.cache.client.ServerConnectivityException;
+import org.apache.geode.cache.client.ServerOperationException;
+import org.apache.geode.cache.client.ServerRefusedConnectionException;
+import org.apache.geode.cache.client.internal.Connection;
+import org.apache.geode.cache.client.internal.ConnectionFactory;
+import org.apache.geode.cache.client.internal.Endpoint;
+import org.apache.geode.cache.client.internal.EndpointManager;
+import org.apache.geode.cache.client.internal.PoolImpl;
import org.apache.geode.cache.client.internal.PoolImpl.PoolTask;
+import org.apache.geode.cache.client.internal.QueueConnectionImpl;
import org.apache.geode.distributed.PoolCancelledException;
import org.apache.geode.distributed.internal.DistributionConfig;
import org.apache.geode.distributed.internal.ServerLocation;
@@ -86,6 +107,26 @@
private static final long NANOS_PER_MS = 100L;
+ /**
+ * Adds an arbitrary variance to a positive temporal interval. Where
possible, 10% of the interval
+ * is added or subtracted from the interval. Otherwise, 1 is added or
subtracted from the
+ * interval. For all positive intervals, the returned value will
not equal the
+ * supplied interval.
+ *
+ * @param interval Positive temporal interval.
+ * @return Adjusted interval including the variance for positive intervals;
the unmodified
+ * interval for non-positive intervals.
+ */
+ static int addVarianceToInterval(int interval) {
+if (1 <= interval) {
+ final SplittableRandom random = new SplittableRandom();
+ final int variance = (interval < 10) ? 1 : (1 + random.nextInt((interval
/ 10) - 1));
+ final int sign = random.nextBoolean() ? 1 : -1;
+ return interval + (sign * variance);
+}
+return interval;
+ }
+
/**
* Create a connection manager
*
@@ -121,12 +162,12 @@ public ConnectionManagerImpl(String poolName,
ConnectionFactory factory,
this.endpointManager = endpointManager;
this.maxConnections = maxConnections == -1 ? Integer.MAX_VALUE :
maxConnections;
this.minConnections = minConnections;
-this.lifetimeTimeout = lifetimeTimeout;
-this.lifetimeTimeoutNanos = lifetimeTimeout * NANOS_PER_MS;
-if (lifetimeTimeout != -1) {
- if (idleTimeout > lifetimeTimeout || idleTimeout == -1) {
+this.lifetimeTimeout = addVarianceToInterval(lifetimeTimeout);
+this.lifetimeTimeoutNanos = this.lifetimeTimeout * NANOS_PER_MS;
+if (this.lifetimeTimeout != -1) {
+ if (idleTimeout > this.lifetimeTimeout || idleTimeout == -1) {
// lifetimeTimeout takes precedence over longer idle timeouts
-idleTimeout = lifetimeTimeout;
+idle
[jira] [Resolved] (GEODE-4147) Add variability to client rebalance logic
[
https://issues.apache.org/jira/browse/GEODE-4147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Smith resolved GEODE-4147.
--
Resolution: Fixed
Fix Version/s: 1.5.0
> Add variability to client rebalance logic
> -
>
> Key: GEODE-4147
> URL: https://issues.apache.org/jira/browse/GEODE-4147
> Project: Geode
> Issue Type: Improvement
> Components: client/server, locator
>Reporter: Galen O'Sullivan
>Assignee: Michael Dodge
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.5.0
>
>
> Clients periodically check with the locator to see if they would be better
> connected to another server, for load balancing purposes
> ({{ClientReplacementRequest}}). Currently the delay is always the same, which
> can cause clients to flip flop between servers that the locator thinks are
> more or less loaded. Adding variability to the delay will help reduce the
> amount of coordinated hammering.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GEODE-4147) Add variability to client rebalance logic
[
https://issues.apache.org/jira/browse/GEODE-4147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16330868#comment-16330868
]
ASF subversion and git services commented on GEODE-4147:
Commit 501cfdab2252a47084f8d2023b8047e6d375d3b6 in geode's branch
refs/heads/develop from [~PivotalSarge]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=501cfda ]
GEODE-4147: Add variability to client rebalance logic.
> Add variability to client rebalance logic
> -
>
> Key: GEODE-4147
> URL: https://issues.apache.org/jira/browse/GEODE-4147
> Project: Geode
> Issue Type: Improvement
> Components: client/server, locator
>Reporter: Galen O'Sullivan
>Assignee: Michael Dodge
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.5.0
>
>
> Clients periodically check with the locator to see if they would be better
> connected to another server, for load balancing purposes
> ({{ClientReplacementRequest}}). Currently the delay is always the same, which
> can cause clients to flip flop between servers that the locator thinks are
> more or less loaded. Adding variability to the delay will help reduce the
> amount of coordinated hammering.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (GEODE-4299) some internal classes for eviction are serializable for no apparent reason
[ https://issues.apache.org/jira/browse/GEODE-4299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fred Krone updated GEODE-4299: -- Issue Type: Sub-task (was: Bug) Parent: GEODE-3845 > some internal classes for eviction are serializable for no apparent reason > -- > > Key: GEODE-4299 > URL: https://issues.apache.org/jira/browse/GEODE-4299 > Project: Geode > Issue Type: Sub-task > Components: eviction >Reporter: Darrel Schneider >Assignee: Darrel Schneider >Priority: Major > Labels: pull-request-available > Fix For: 1.5.0 > > > The eviction controller classes are serializable even though they can no > longer be safely serialized. > Also, in general, the internal classes for eviction are confusing. The > dependencies between them are not clear and multiple classes attempt to do > the same thing. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (GEODE-4304) Many places in the code access the "dataPolicy" field instead of calling getDataPolicy
[ https://issues.apache.org/jira/browse/GEODE-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fred Krone updated GEODE-4304: -- Issue Type: Sub-task (was: Improvement) Parent: GEODE-3845 > Many places in the code access the "dataPolicy" field instead of calling > getDataPolicy > -- > > Key: GEODE-4304 > URL: https://issues.apache.org/jira/browse/GEODE-4304 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Darrel Schneider >Assignee: Darrel Schneider >Priority: Major > Labels: pull-request-available > > The field "dataPolicy" on AbstractRegion is protected. > Many other classes directly access this field instead of calling > getDataPolicy. > The field should be made private and all access to it should be through > methods. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-4312) CI failure: org.apache.geode.cache30.CacheXml80DUnitTest > testPartitionedRegionAttributesForCoLocation3 FAILED
[
https://issues.apache.org/jira/browse/GEODE-4312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16330841#comment-16330841
]
ASF GitHub Bot commented on GEODE-4312:
---
agingade commented on a change in pull request #1302: GEODE-4312: Wait for
rebalancing to complete as part of teardown
URL: https://github.com/apache/geode/pull/1302#discussion_r162418263
##
File path:
geode-core/src/test/java/org/apache/geode/test/dunit/cache/internal/JUnit4CacheTestCase.java
##
@@ -368,6 +368,7 @@ public void postTearDownCacheTestCase() throws Exception {
private static synchronized void remoteTearDown() {
try {
DistributionMessageObserver.setInstance(null);
+ waitForNoRebalancing();
Review comment:
Looks like this is test specific...how about having this in
"CacheXmlTestCase" instead here...
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> CI failure: org.apache.geode.cache30.CacheXml80DUnitTest >
> testPartitionedRegionAttributesForCoLocation3 FAILED
> ---
>
> Key: GEODE-4312
> URL: https://issues.apache.org/jira/browse/GEODE-4312
> Project: Geode
> Issue Type: Bug
> Components: gfsh
>Reporter: Jens Deppe
>Assignee: Jens Deppe
>Priority: Major
> Labels: ci, pull-request-available
>
> Test produces this:
> {noformat}
> Suspicious strings were written to the log during this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> ---
> Found suspect string in log4j at line 157
> [error 2018/01/17 03:31:42.318 UTC
> tid=0x2c6] Unexpected exception during bucket recovery
> java.lang.IllegalStateException: Region specified in 'colocated-with'
> (Customer) for region /Order does not exist. It should be created before
> setting 'colocated-with' attribute for this region.
> at
> org.apache.geode.internal.cache.ColocationHelper.getColocatedRegion(ColocationHelper.java:94)
> at
> org.apache.geode.internal.cache.ColocationHelper.getLeaderRegion(ColocationHelper.java:455)
> at
> org.apache.geode.internal.cache.partitioned.PartitionedRegionRebalanceOp.(PartitionedRegionRebalanceOp.java:134)
> at
> org.apache.geode.internal.cache.partitioned.PartitionedRegionRebalanceOp.(PartitionedRegionRebalanceOp.java:114)
> at
> org.apache.geode.internal.cache.PRHARedundancyProvider$3.run2(PRHARedundancyProvider.java:1568)
> at
> org.apache.geode.internal.cache.partitioned.RecoveryRunnable.run(RecoveryRunnable.java:61)
> at
> org.apache.geode.internal.OneTaskOnlyExecutor$DelegatingRunnable.run(OneTaskOnlyExecutor.java:134)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> {noformat}
> The relevant section of the log is this:
> {noformat}
> [info 2018/01/17 03:31:42.248 UTC tid=0x16] Initializing region
> __PR
> [info 2018/01/17 03:31:42.248 UTC tid=0x16] Initialization of
> region __PR completed
> [info 2018/01/17 03:31:42.249 UTC tid=0x16] Partitioned Region
> /Customer is born with prId=4 ident:#Customer
> [info 2018/01/17 03:31:42.271 UTC tid=0x16] Partitioned Region
> /Order is born with prId=5 ident:#Order
> [info 2018/01/17 03:31:42.314 UTC tid=0x16] GemFireCache[id =
> 1650399312; isClosing = true; isShutDownAll = false; created = Wed Jan 17
> 03:31:41 UTC 2018; server = false; copyOnRead = false; lockLease = 120;
> lockTimeout = 60]: Now closing.
> [error 2018/01/17 03:31:42.318 UTC
> tid=0x2c6] Unexpected exception during bucket recovery
> java.lang.IllegalStateException: Region specified in 'colocated-with'
> (Customer) for region /Order does not exist. It should be created before
> setting 'colocated-with' attribute for this region.
> at
> org.apache.geode.internal.cache.ColocationHelper.getColocatedRegion(ColocationHelper.java:94)
> at
> org.apache.geode.i
[jira] [Updated] (GEODE-4184) Change mapIndexKeys hash set to able to handle concurrent access
[ https://issues.apache.org/jira/browse/GEODE-4184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anthony Baker updated GEODE-4184: - Fix Version/s: (was: 1.4.0) 1.5.0 > Change mapIndexKeys hash set to able to handle concurrent access > > > Key: GEODE-4184 > URL: https://issues.apache.org/jira/browse/GEODE-4184 > Project: Geode > Issue Type: Bug > Components: querying >Reporter: nabarun >Assignee: nabarun >Priority: Major > Fix For: 1.5.0 > > > Concurrent access to a HashSet results in inconsistent behavior. > This needs to be changed to a set backed by a concurrent hash map -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (GEODE-4305) Many places in the code access the "concurrencyChecksEnabled" field instead of calling getConcurrencyChecksEnabled
[ https://issues.apache.org/jira/browse/GEODE-4305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fred Krone updated GEODE-4305: -- Issue Type: Sub-task (was: Improvement) Parent: GEODE-3845 > Many places in the code access the "concurrencyChecksEnabled" field instead > of calling getConcurrencyChecksEnabled > -- > > Key: GEODE-4305 > URL: https://issues.apache.org/jira/browse/GEODE-4305 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Darrel Schneider >Assignee: Darrel Schneider >Priority: Major > Labels: pull-request-available > Fix For: 1.5.0 > > > The field "concurrencyChecksEnabled" on AbstractRegion is protected. > Many other classes directly access this field instead of calling > getConcurrencyChecksEnabled. > The field should be made private and all access to it should be through > methods. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-4316) Add tests for jar deployment to check for server restarting
[
https://issues.apache.org/jira/browse/GEODE-4316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16330844#comment-16330844
]
ASF GitHub Bot commented on GEODE-4316:
---
jinmeiliao commented on a change in pull request #1303: GEODE-4316: Additional
function deploy tests
URL: https://github.com/apache/geode/pull/1303#discussion_r162418421
##
File path:
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DeployWithGroupsDUnitTest.java
##
@@ -200,6 +199,67 @@ public void deployJarToAllServers() throws Exception {
server2.invoke(() -> assertThatCanLoad(jarName1, class1));
}
+ @Test
+ public void deployJarToAllServersWithRestart() throws Exception {
+// Deploy a jar to all servers
+gfshConnector.executeAndAssertThat("deploy --jar=" +
jar1).statusIsSuccess();
+String resultString = gfshConnector.getGfshOutput();
+
+assertThat(resultString).contains(server1.getName());
+assertThat(resultString).contains(server2.getName());
+assertThat(resultString).contains(jarName1);
+
+server1.invoke(() -> assertThatCanLoad(jarName1, class1));
+server2.invoke(() -> assertThatCanLoad(jarName1, class1));
+
+server1.getVM().bounce();
Review comment:
does bounce cleans the filesytem as well? can we use server1.stopVM(false)?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add tests for jar deployment to check for server restarting
> ---
>
> Key: GEODE-4316
> URL: https://issues.apache.org/jira/browse/GEODE-4316
> Project: Geode
> Issue Type: Improvement
> Components: gfsh
>Reporter: Jens Deppe
>Assignee: Jens Deppe
>Priority: Major
> Labels: pull-request-available
>
> Check whether a function undeploy works correctly when a server is restarted
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GEODE-4312) CI failure: org.apache.geode.cache30.CacheXml80DUnitTest > testPartitionedRegionAttributesForCoLocation3 FAILED
[
https://issues.apache.org/jira/browse/GEODE-4312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16330837#comment-16330837
]
ASF GitHub Bot commented on GEODE-4312:
---
jinmeiliao commented on issue #1302: GEODE-4312: Wait for rebalancing to
complete as part of teardown
URL: https://github.com/apache/geode/pull/1302#issuecomment-358725168
thanks for fixing this. I had this failure on my precheckin
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> CI failure: org.apache.geode.cache30.CacheXml80DUnitTest >
> testPartitionedRegionAttributesForCoLocation3 FAILED
> ---
>
> Key: GEODE-4312
> URL: https://issues.apache.org/jira/browse/GEODE-4312
> Project: Geode
> Issue Type: Bug
> Components: gfsh
>Reporter: Jens Deppe
>Assignee: Jens Deppe
>Priority: Major
> Labels: ci, pull-request-available
>
> Test produces this:
> {noformat}
> Suspicious strings were written to the log during this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> ---
> Found suspect string in log4j at line 157
> [error 2018/01/17 03:31:42.318 UTC
> tid=0x2c6] Unexpected exception during bucket recovery
> java.lang.IllegalStateException: Region specified in 'colocated-with'
> (Customer) for region /Order does not exist. It should be created before
> setting 'colocated-with' attribute for this region.
> at
> org.apache.geode.internal.cache.ColocationHelper.getColocatedRegion(ColocationHelper.java:94)
> at
> org.apache.geode.internal.cache.ColocationHelper.getLeaderRegion(ColocationHelper.java:455)
> at
> org.apache.geode.internal.cache.partitioned.PartitionedRegionRebalanceOp.(PartitionedRegionRebalanceOp.java:134)
> at
> org.apache.geode.internal.cache.partitioned.PartitionedRegionRebalanceOp.(PartitionedRegionRebalanceOp.java:114)
> at
> org.apache.geode.internal.cache.PRHARedundancyProvider$3.run2(PRHARedundancyProvider.java:1568)
> at
> org.apache.geode.internal.cache.partitioned.RecoveryRunnable.run(RecoveryRunnable.java:61)
> at
> org.apache.geode.internal.OneTaskOnlyExecutor$DelegatingRunnable.run(OneTaskOnlyExecutor.java:134)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> {noformat}
> The relevant section of the log is this:
> {noformat}
> [info 2018/01/17 03:31:42.248 UTC tid=0x16] Initializing region
> __PR
> [info 2018/01/17 03:31:42.248 UTC tid=0x16] Initialization of
> region __PR completed
> [info 2018/01/17 03:31:42.249 UTC tid=0x16] Partitioned Region
> /Customer is born with prId=4 ident:#Customer
> [info 2018/01/17 03:31:42.271 UTC tid=0x16] Partitioned Region
> /Order is born with prId=5 ident:#Order
> [info 2018/01/17 03:31:42.314 UTC tid=0x16] GemFireCache[id =
> 1650399312; isClosing = true; isShutDownAll = false; created = Wed Jan 17
> 03:31:41 UTC 2018; server = false; copyOnRead = false; lockLease = 120;
> lockTimeout = 60]: Now closing.
> [error 2018/01/17 03:31:42.318 UTC
> tid=0x2c6] Unexpected exception during bucket recovery
> java.lang.IllegalStateException: Region specified in 'colocated-with'
> (Customer) for region /Order does not exist. It should be created before
> setting 'colocated-with' attribute for this region.
> at
> org.apache.geode.internal.cache.ColocationHelper.getColocatedRegion(ColocationHelper.java:94)
> at
> org.apache.geode.internal.cache.ColocationHelper.getLeaderRegion(ColocationHelper.java:455)
> at
> org.apache.geode.internal.cache.partitioned.PartitionedRegionRebalanceOp.(PartitionedRegionRebalanceOp.java:134)
> at
> org.apache.geode.internal.cache.partitioned.PartitionedRegionRebalanceOp.(PartitionedRegionRebalanceOp.java:114)
> at
> org.apache.geode.internal.cache.PRHARedundancyProvider$3.run2(PRHARedundancyProvider.java:1
[jira] [Resolved] (GEODE-4305) Many places in the code access the "concurrencyChecksEnabled" field instead of calling getConcurrencyChecksEnabled
[ https://issues.apache.org/jira/browse/GEODE-4305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Darrel Schneider resolved GEODE-4305. - Resolution: Fixed Fix Version/s: 1.5.0 > Many places in the code access the "concurrencyChecksEnabled" field instead > of calling getConcurrencyChecksEnabled > -- > > Key: GEODE-4305 > URL: https://issues.apache.org/jira/browse/GEODE-4305 > Project: Geode > Issue Type: Improvement > Components: regions >Reporter: Darrel Schneider >Assignee: Darrel Schneider >Priority: Major > Labels: pull-request-available > Fix For: 1.5.0 > > > The field "concurrencyChecksEnabled" on AbstractRegion is protected. > Many other classes directly access this field instead of calling > getConcurrencyChecksEnabled. > The field should be made private and all access to it should be through > methods. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-4305) Many places in the code access the "concurrencyChecksEnabled" field instead of calling getConcurrencyChecksEnabled
[ https://issues.apache.org/jira/browse/GEODE-4305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16330823#comment-16330823 ] ASF subversion and git services commented on GEODE-4305: Commit ffee51a19437d69099b5aefe0da6c47ac32e853d in geode's branch refs/heads/develop from [~dschneider] [ https://gitbox.apache.org/repos/asf?p=geode.git;h=ffee51a ] GEODE-4305: encapsulate the concurrencyChecksEnabled field (#1297) The concurrencyChecksEnabled is now always accessed using getConcurrencyChecksEnabled and setConcurrencyChecksEnabled. > Many places in the code access the "concurrencyChecksEnabled" field instead > of calling getConcurrencyChecksEnabled > -- > > Key: GEODE-4305 > URL: https://issues.apache.org/jira/browse/GEODE-4305 > Project: Geode > Issue Type: Improvement > Components: regions >Reporter: Darrel Schneider >Assignee: Darrel Schneider >Priority: Major > Labels: pull-request-available > > The field "concurrencyChecksEnabled" on AbstractRegion is protected. > Many other classes directly access this field instead of calling > getConcurrencyChecksEnabled. > The field should be made private and all access to it should be through > methods. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (GEODE-4299) some internal classes for eviction are serializable for no apparent reason
[ https://issues.apache.org/jira/browse/GEODE-4299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Darrel Schneider resolved GEODE-4299. - Resolution: Fixed Fix Version/s: 1.5.0 > some internal classes for eviction are serializable for no apparent reason > -- > > Key: GEODE-4299 > URL: https://issues.apache.org/jira/browse/GEODE-4299 > Project: Geode > Issue Type: Bug > Components: eviction >Reporter: Darrel Schneider >Assignee: Darrel Schneider >Priority: Major > Labels: pull-request-available > Fix For: 1.5.0 > > > The eviction controller classes are serializable even though they can no > longer be safely serialized. > Also, in general, the internal classes for eviction are confusing. The > dependencies between them are not clear and multiple classes attempt to do > the same thing. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-4299) some internal classes for eviction are serializable for no apparent reason
[ https://issues.apache.org/jira/browse/GEODE-4299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16330813#comment-16330813 ] ASF subversion and git services commented on GEODE-4299: Commit c9feba399abf64e7d6797eca9f216a3cd969e9fb in geode's branch refs/heads/develop from [~dschneider] [ https://gitbox.apache.org/repos/asf?p=geode.git;h=c9feba3 ] GEODE-4299: refactor eviction (#1290) GEODE-4299: refactor eviction The EvictionController classes are no longer Serializable nor Cloneable. These internal classes used to be external and needed to be these things in the past because they were stored in the configuration. But they no longer are so these interfaces were removed for clarity. The EvictionController classes are no longer responsible for creating InternalEvictionStatistics. Instead the other entities it depends on are passed in to its constructor. The only class with an EvictionController instance is now VMLRURegionMap which makes the code easier to understand and reduces the number of inter-module dependencies. renamed internalSetMaximum to setMaximum on EvictionAttributesImpl AbstractBucketRegionQueue no longer uses EvictionStatistics to notify itself that it removed some objects from the queue. So it no longer needs to access all the EvictionStatistics. AbstractLRURegionMap has been moved to VMLRURegionMap Casts to AbstractLRURegionMap have been removed by added additional methods to RegionMap. new EvictableRegion interface make clear the things a region implementation needs to do/provide for the eviction implementation EvictionAttributesMutator is now implemented by the dedicated class EvictionAttributesMutatorImpl close and clear on RegionMap now take a BucketRegion parameter so that the eviction classes do not need to keep track of the BucketRegion. EvictionList no longer does some of the things it did before that should have been the responsibility of the EvictionController. Now the EvictionList is given the EvictionController it should defer to. The EvictionListBuilder has been simplified since EvictionList now only needs a controller. The eviction classes that track statistics have been refactored to be clearer. Now the EvictionStats interface is implemented by classes that provide vsd type stats. The EvictionCounters interface is implemented by a class that wraps EvictionStats and provides atomics for some of them.* Removed old code that made the EvictionController classes Serializable, Declarable, and Clonable. > some internal classes for eviction are serializable for no apparent reason > -- > > Key: GEODE-4299 > URL: https://issues.apache.org/jira/browse/GEODE-4299 > Project: Geode > Issue Type: Bug > Components: eviction >Reporter: Darrel Schneider >Assignee: Darrel Schneider >Priority: Major > Labels: pull-request-available > > The eviction controller classes are serializable even though they can no > longer be safely serialized. > Also, in general, the internal classes for eviction are confusing. The > dependencies between them are not clear and multiple classes attempt to do > the same thing. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-4299) some internal classes for eviction are serializable for no apparent reason
[ https://issues.apache.org/jira/browse/GEODE-4299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16330814#comment-16330814 ] ASF subversion and git services commented on GEODE-4299: Commit c9feba399abf64e7d6797eca9f216a3cd969e9fb in geode's branch refs/heads/develop from [~dschneider] [ https://gitbox.apache.org/repos/asf?p=geode.git;h=c9feba3 ] GEODE-4299: refactor eviction (#1290) GEODE-4299: refactor eviction The EvictionController classes are no longer Serializable nor Cloneable. These internal classes used to be external and needed to be these things in the past because they were stored in the configuration. But they no longer are so these interfaces were removed for clarity. The EvictionController classes are no longer responsible for creating InternalEvictionStatistics. Instead the other entities it depends on are passed in to its constructor. The only class with an EvictionController instance is now VMLRURegionMap which makes the code easier to understand and reduces the number of inter-module dependencies. renamed internalSetMaximum to setMaximum on EvictionAttributesImpl AbstractBucketRegionQueue no longer uses EvictionStatistics to notify itself that it removed some objects from the queue. So it no longer needs to access all the EvictionStatistics. AbstractLRURegionMap has been moved to VMLRURegionMap Casts to AbstractLRURegionMap have been removed by added additional methods to RegionMap. new EvictableRegion interface make clear the things a region implementation needs to do/provide for the eviction implementation EvictionAttributesMutator is now implemented by the dedicated class EvictionAttributesMutatorImpl close and clear on RegionMap now take a BucketRegion parameter so that the eviction classes do not need to keep track of the BucketRegion. EvictionList no longer does some of the things it did before that should have been the responsibility of the EvictionController. Now the EvictionList is given the EvictionController it should defer to. The EvictionListBuilder has been simplified since EvictionList now only needs a controller. The eviction classes that track statistics have been refactored to be clearer. Now the EvictionStats interface is implemented by classes that provide vsd type stats. The EvictionCounters interface is implemented by a class that wraps EvictionStats and provides atomics for some of them.* Removed old code that made the EvictionController classes Serializable, Declarable, and Clonable. > some internal classes for eviction are serializable for no apparent reason > -- > > Key: GEODE-4299 > URL: https://issues.apache.org/jira/browse/GEODE-4299 > Project: Geode > Issue Type: Bug > Components: eviction >Reporter: Darrel Schneider >Assignee: Darrel Schneider >Priority: Major > Labels: pull-request-available > > The eviction controller classes are serializable even though they can no > longer be safely serialized. > Also, in general, the internal classes for eviction are confusing. The > dependencies between them are not clear and multiple classes attempt to do > the same thing. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (GEODE-3868) Client security example should use SSL
[ https://issues.apache.org/jira/browse/GEODE-3868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-3868: -- Labels: pull-request-available (was: ) > Client security example should use SSL > -- > > Key: GEODE-3868 > URL: https://issues.apache.org/jira/browse/GEODE-3868 > Project: Geode > Issue Type: Improvement > Components: docs, security >Reporter: Dan Smith >Priority: Major > Labels: pull-request-available > > We added a client security example as part of GEODE-2988. > However, that example does not actually use secure sockets. That makes it a > bad example of how to secure a client, because the credentials are sent over > the wire without encryption. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-3868) Client security example should use SSL
[ https://issues.apache.org/jira/browse/GEODE-3868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16330776#comment-16330776 ] ASF GitHub Bot commented on GEODE-3868: --- sboorlagadda opened a new pull request #45: GEODE-3868: Client security example should use SSL URL: https://github.com/apache/geode-examples/pull/45 Updated the example to use SSL between all members and between client/server. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Client security example should use SSL > -- > > Key: GEODE-3868 > URL: https://issues.apache.org/jira/browse/GEODE-3868 > Project: Geode > Issue Type: Improvement > Components: docs, security >Reporter: Dan Smith >Priority: Major > Labels: pull-request-available > > We added a client security example as part of GEODE-2988. > However, that example does not actually use secure sockets. That makes it a > bad example of how to secure a client, because the credentials are sent over > the wire without encryption. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-2275) CI Failure: ClearTXLockingDUnitTest.testPutWithClearDifferentVM
[
https://issues.apache.org/jira/browse/GEODE-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16330770#comment-16330770
]
ASF GitHub Bot commented on GEODE-2275:
---
nreich closed pull request #1298: GEODE-2275: Remove async creation of shared
static resource
URL: https://github.com/apache/geode/pull/1298
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/geode-core/src/test/java/org/apache/geode/internal/cache/ClearTXLockingDUnitTest.java
b/geode-core/src/test/java/org/apache/geode/internal/cache/ClearTXLockingDUnitTest.java
index a2ea1454cc..a270675ad1 100644
---
a/geode-core/src/test/java/org/apache/geode/internal/cache/ClearTXLockingDUnitTest.java
+++
b/geode-core/src/test/java/org/apache/geode/internal/cache/ClearTXLockingDUnitTest.java
@@ -24,8 +24,8 @@
import java.util.Map;
import java.util.concurrent.CountDownLatch;
-import org.apache.logging.log4j.Logger;
import org.assertj.core.api.JUnitSoftAssertions;
+import org.junit.Before;
import org.junit.Ignore;
import org.junit.Rule;
import org.junit.Test;
@@ -34,22 +34,15 @@
import org.apache.geode.cache.Cache;
import org.apache.geode.cache.CacheEvent;
import org.apache.geode.cache.CacheFactory;
-import org.apache.geode.cache.CacheTransactionManager;
import org.apache.geode.cache.Region;
import org.apache.geode.cache.RegionFactory;
import org.apache.geode.cache.RegionShortcut;
import org.apache.geode.cache.Scope;
-import org.apache.geode.distributed.DistributedMember;
import
org.apache.geode.distributed.internal.membership.InternalDistributedMember;
-import org.apache.geode.internal.logging.LogService;
import org.apache.geode.test.dunit.Host;
-import org.apache.geode.test.dunit.SerializableCallable;
-import org.apache.geode.test.dunit.SerializableRunnable;
-import org.apache.geode.test.dunit.SerializableRunnableIF;
import org.apache.geode.test.dunit.VM;
import org.apache.geode.test.dunit.cache.internal.JUnit4CacheTestCase;
import org.apache.geode.test.junit.categories.DistributedTest;
-import org.apache.geode.test.junit.categories.FlakyTest;
/**
* Test class to verify proper locking interaction between transactions and
the CLEAR region
@@ -76,46 +69,44 @@
* processing is complete before clearing the region. Failure to do so,
would result in region
* inconsistencies.
*/
- VM vm0, vm1, opsVM, regionVM;
+ private static final String THE_KEY = "theKey";
+ private static final String THE_VALUE = "theValue";
+ private static final int NUMBER_OF_PUTS = 2;
+ private static final String REGION_NAME1 = "testRegion1";
+ private static final String REGION_NAME2 = "testRegion2";
static Cache cache;
-
- ArmLockHook theArmHook;
-
- DistributedMember vm0ID, vm1ID;
-
- static CacheTransactionManager txmgr;
-
- static final String THE_KEY = "theKey";
- static final String THE_VALUE = "theValue";
- static final int NUMBER_OF_PUTS = 2;
-
- static final String REGION_NAME1 = "testRegion1";
- static final String REGION_NAME2 = "testRegion2";
-
static CountDownLatch opsLatch;
- static CountDownLatch regionLatch;
- static CountDownLatch verifyLatch;
+ private static CountDownLatch regionLatch;
+ private static CountDownLatch verifyLatch;
- private static final Logger logger = LogService.getLogger();
+ private VM vm0;
+ private VM vm1;
+ private VM opsVM;
+ private VM regionVM;
+
+ @Before
+ public void setup() {
+Host host = Host.getHost(0);
+vm0 = host.getVM(0);
+vm1 = host.getVM(1);
- // test methods
+createCache(vm0);
+createCache(vm1);
+ }
@Test
- public void testPutWithClearSameVM() throws InterruptedException {
-getVMs();
+ public void testPutWithClearSameVM() {
setupRegions(vm0, vm0);
setClearHook(REGION_NAME1, opsVM, regionVM);
-performTestAndCheckResults(putOperationsTest);
+performTestAndCheckResults();
}
- @Category(FlakyTest.class) // GEODE-2275
@Test
- public void testPutWithClearDifferentVM() throws InterruptedException {
-getVMs();
+ public void testPutWithClearDifferentVM() {
setupRegions(vm0, vm1);
setClearHook(REGION_NAME1, opsVM, regionVM);
-performTestAndCheckResults(putOperationsTest);
+performTestAndCheckResults();
}
/*
@@ -124,20 +115,18 @@ public void testPutWithClearDifferentVM() throws
InterruptedException {
*/
@Ignore
@Test
- public void testPutWithCloseSameVM() throws InterruptedException {
-getVMs();
+ public void testPutWithCloseSameVM() {
setupRegions(vm0, vm0);
setCloseHook(REGION_NAME1, opsVM, regionVM);
-performTestAndCheckResults(putOperationsTest);
+performTestAndCheckResults();
}
@Ignore
@Test
- publi
[jira] [Commented] (GEODE-2275) CI Failure: ClearTXLockingDUnitTest.testPutWithClearDifferentVM
[ https://issues.apache.org/jira/browse/GEODE-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16330772#comment-16330772 ] ASF subversion and git services commented on GEODE-2275: Commit f565ac1e1e960261588f6bfe47e01e8b21dfafdb in geode's branch refs/heads/develop from [~nreich] [ https://gitbox.apache.org/repos/asf?p=geode.git;h=f565ac1 ] GEODE-2275: Remove async creation of shared static resource (#1298) > CI Failure: ClearTXLockingDUnitTest.testPutWithClearDifferentVM > --- > > Key: GEODE-2275 > URL: https://issues.apache.org/jira/browse/GEODE-2275 > Project: Geode > Issue Type: Bug > Components: regions, transactions >Reporter: Eric Shu >Assignee: Nick Reich >Priority: Major > Labels: ci, flaky, pull-request-available > Fix For: 1.5.0 > > > org.apache.geode.internal.cache.ClearTXLockingDUnitTest > > testPutWithClearDifferentVM FAILED > org.apache.geode.test.dunit.RMIException: While invoking > org.apache.geode.internal.cache.ClearTXLockingDUnitTest$1.run in VM 0 running > on Host d7fcb695b430 with 4 VMs > at org.apache.geode.test.dunit.VM.invoke(VM.java:344) > at org.apache.geode.test.dunit.VM.invoke(VM.java:314) > at org.apache.geode.test.dunit.VM.invoke(VM.java:259) > at > org.apache.geode.internal.cache.ClearTXLockingDUnitTest.runLockingTest(ClearTXLockingDUnitTest.java:206) > at > org.apache.geode.internal.cache.ClearTXLockingDUnitTest.performTestAndCheckResults(ClearTXLockingDUnitTest.java:170) > at > org.apache.geode.internal.cache.ClearTXLockingDUnitTest.testPutWithClearDifferentVM(ClearTXLockingDUnitTest.java:115) > Caused by: > org.apache.geode.test.dunit.RMIException: While invoking > org.apache.geode.internal.cache.ClearTXLockingDUnitTest$1$$Lambda$21/402256214.run > in VM 0 running on Host d7fcb695b430 with 4 VMs > Caused by: > org.apache.geode.test.dunit.RMIException: While invoking > org.apache.geode.internal.cache.ClearTXLockingDUnitTest$$Lambda$24/1595591059.run > in VM 1 running on Host d7fcb695b430 with 4 VMs > at org.apache.geode.test.dunit.VM.invoke(VM.java:344) > at org.apache.geode.test.dunit.VM.invoke(VM.java:314) > at org.apache.geode.test.dunit.VM.invoke(VM.java:259) > at > org.apache.geode.internal.cache.ClearTXLockingDUnitTest.releaseRegionOperation(ClearTXLockingDUnitTest.java:324) > at > org.apache.geode.internal.cache.ClearTXLockingDUnitTest.access$100(ClearTXLockingDUnitTest.java:67) > at > org.apache.geode.internal.cache.ClearTXLockingDUnitTest$CommitTestCallback.run(ClearTXLockingDUnitTest.java:408) > at > org.apache.geode.internal.cache.TXState.applyChanges(TXState.java:796) > at > org.apache.geode.internal.cache.TXState.commit(TXState.java:468) > at > org.apache.geode.internal.cache.TXStateProxyImpl.commit(TXStateProxyImpl.java:254) > at > org.apache.geode.internal.cache.TXManagerImpl.commit(TXManagerImpl.java:375) > at > org.apache.geode.internal.cache.ClearTXLockingDUnitTest.doPuts(ClearTXLockingDUnitTest.java:316) > at > org.apache.geode.internal.cache.ClearTXLockingDUnitTest.access$000(ClearTXLockingDUnitTest.java:67) > Caused by: > java.lang.NullPointerException > at > org.apache.geode.internal.cache.ClearTXLockingDUnitTest.lambda$releaseRegionOperation$b6506259$1(ClearTXLockingDUnitTest.java:324) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (GEODE-2275) CI Failure: ClearTXLockingDUnitTest.testPutWithClearDifferentVM
[ https://issues.apache.org/jira/browse/GEODE-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Reich resolved GEODE-2275. --- Resolution: Fixed Fix Version/s: 1.5.0 > CI Failure: ClearTXLockingDUnitTest.testPutWithClearDifferentVM > --- > > Key: GEODE-2275 > URL: https://issues.apache.org/jira/browse/GEODE-2275 > Project: Geode > Issue Type: Bug > Components: regions, transactions >Reporter: Eric Shu >Assignee: Nick Reich >Priority: Major > Labels: ci, flaky, pull-request-available > Fix For: 1.5.0 > > > org.apache.geode.internal.cache.ClearTXLockingDUnitTest > > testPutWithClearDifferentVM FAILED > org.apache.geode.test.dunit.RMIException: While invoking > org.apache.geode.internal.cache.ClearTXLockingDUnitTest$1.run in VM 0 running > on Host d7fcb695b430 with 4 VMs > at org.apache.geode.test.dunit.VM.invoke(VM.java:344) > at org.apache.geode.test.dunit.VM.invoke(VM.java:314) > at org.apache.geode.test.dunit.VM.invoke(VM.java:259) > at > org.apache.geode.internal.cache.ClearTXLockingDUnitTest.runLockingTest(ClearTXLockingDUnitTest.java:206) > at > org.apache.geode.internal.cache.ClearTXLockingDUnitTest.performTestAndCheckResults(ClearTXLockingDUnitTest.java:170) > at > org.apache.geode.internal.cache.ClearTXLockingDUnitTest.testPutWithClearDifferentVM(ClearTXLockingDUnitTest.java:115) > Caused by: > org.apache.geode.test.dunit.RMIException: While invoking > org.apache.geode.internal.cache.ClearTXLockingDUnitTest$1$$Lambda$21/402256214.run > in VM 0 running on Host d7fcb695b430 with 4 VMs > Caused by: > org.apache.geode.test.dunit.RMIException: While invoking > org.apache.geode.internal.cache.ClearTXLockingDUnitTest$$Lambda$24/1595591059.run > in VM 1 running on Host d7fcb695b430 with 4 VMs > at org.apache.geode.test.dunit.VM.invoke(VM.java:344) > at org.apache.geode.test.dunit.VM.invoke(VM.java:314) > at org.apache.geode.test.dunit.VM.invoke(VM.java:259) > at > org.apache.geode.internal.cache.ClearTXLockingDUnitTest.releaseRegionOperation(ClearTXLockingDUnitTest.java:324) > at > org.apache.geode.internal.cache.ClearTXLockingDUnitTest.access$100(ClearTXLockingDUnitTest.java:67) > at > org.apache.geode.internal.cache.ClearTXLockingDUnitTest$CommitTestCallback.run(ClearTXLockingDUnitTest.java:408) > at > org.apache.geode.internal.cache.TXState.applyChanges(TXState.java:796) > at > org.apache.geode.internal.cache.TXState.commit(TXState.java:468) > at > org.apache.geode.internal.cache.TXStateProxyImpl.commit(TXStateProxyImpl.java:254) > at > org.apache.geode.internal.cache.TXManagerImpl.commit(TXManagerImpl.java:375) > at > org.apache.geode.internal.cache.ClearTXLockingDUnitTest.doPuts(ClearTXLockingDUnitTest.java:316) > at > org.apache.geode.internal.cache.ClearTXLockingDUnitTest.access$000(ClearTXLockingDUnitTest.java:67) > Caused by: > java.lang.NullPointerException > at > org.apache.geode.internal.cache.ClearTXLockingDUnitTest.lambda$releaseRegionOperation$b6506259$1(ClearTXLockingDUnitTest.java:324) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (GEODE-4316) Add tests for jar deployment to check for server restarting
[ https://issues.apache.org/jira/browse/GEODE-4316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-4316: -- Labels: pull-request-available (was: ) > Add tests for jar deployment to check for server restarting > --- > > Key: GEODE-4316 > URL: https://issues.apache.org/jira/browse/GEODE-4316 > Project: Geode > Issue Type: Improvement > Components: gfsh >Reporter: Jens Deppe >Assignee: Jens Deppe >Priority: Major > Labels: pull-request-available > > Check whether a function undeploy works correctly when a server is restarted -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-4316) Add tests for jar deployment to check for server restarting
[ https://issues.apache.org/jira/browse/GEODE-4316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16330757#comment-16330757 ] ASF GitHub Bot commented on GEODE-4316: --- jdeppe-pivotal opened a new pull request #1303: GEODE-4316: Additional function deploy tests URL: https://github.com/apache/geode/pull/1303 - Ensure that undeployed function remain gone after server restart. Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to d...@geode.apache.org. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add tests for jar deployment to check for server restarting > --- > > Key: GEODE-4316 > URL: https://issues.apache.org/jira/browse/GEODE-4316 > Project: Geode > Issue Type: Improvement > Components: gfsh >Reporter: Jens Deppe >Assignee: Jens Deppe >Priority: Major > Labels: pull-request-available > > Check whether a function undeploy works correctly when a server is restarted -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-3974) improve permission for Internal functions
[
https://issues.apache.org/jira/browse/GEODE-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16330738#comment-16330738
]
ASF GitHub Bot commented on GEODE-3974:
---
jinmeiliao commented on a change in pull request #1287: GEODE-3974: function
security improvement
URL: https://github.com/apache/geode/pull/1287#discussion_r162398607
##
File path:
geode-lucene/src/test/java/org/apache/geode/cache/lucene/test/LuceneFunctionSecurityTest.java
##
@@ -105,366 +67,45 @@
@ClassRule
public static ServerStarterRule server =
new
ServerStarterRule().withJMXManager().withSecurityManager(SimpleSecurityManager.class)
- .withRegion(RegionShortcut.PARTITION, regionName).withAutoStart();
+ .withRegion(RegionShortcut.PARTITION, "testRegion").withAutoStart();
@Rule
public GfshCommandRule gfsh =
new GfshCommandRule(server::getJmxPort,
GfshCommandRule.PortType.jmxManager);
+ private static Map functionStringMap = new HashMap<>();
+
@BeforeClass
public static void setupClass() {
-FunctionService.registerFunction(luceneCreateIndexFunction);
-FunctionService.registerFunction(luceneDescribeIndexFunction);
-FunctionService.registerFunction(luceneDestroyIndexFunction);
-FunctionService.registerFunction(luceneListIndexFunction);
-FunctionService.registerFunction(luceneSearchIndexFunction);
-FunctionService.registerFunction(dumpDirectoryFiles);
-FunctionService.registerFunction(luceneQueryFunction);
-FunctionService.registerFunction(waitUntilFlushedFunction);
-FunctionService.registerFunction(luceneGetPageFunction);
- }
-
- /* Command authorized tests */
- @Test
- @ConnectionConfiguration(user = "clusterManageLucene", password =
"clusterManageLucene")
- public void testValidPermissionsForLuceneCreateIndexFunction() {
-Function thisFunction = luceneCreateIndexFunction;
-
-gfsh.executeAndAssertThat("execute function --id=" + thisFunction.getId())
-.doesNotContainOutput("not authorized for").statusIsSuccess();
- }
-
- @Test
- @ConnectionConfiguration(user = "clusterReadLucene", password =
"clusterReadLucene")
- public void testValidPermissionsForLuceneDescribeIndexFunction() {
-Function thisFunction = luceneDescribeIndexFunction;
-
-gfsh.executeAndAssertThat("execute function --id=" + thisFunction.getId())
-.doesNotContainOutput("not authorized for").statusIsSuccess();
- }
-
- @Test
- @ConnectionConfiguration(user = "clusterManageLucene", password =
"clusterManageLucene")
- public void testValidPermissionsForLuceneDestroyIndexFunction() {
-Function thisFunction = luceneDestroyIndexFunction;
-
-gfsh.executeAndAssertThat("execute function --id=" + thisFunction.getId())
-.doesNotContainOutput("not authorized for").statusIsSuccess();
- }
-
- @Test
- @ConnectionConfiguration(user = "clusterReadLucene", password =
"clusterReadLucene")
- public void testValidPermissionsForLuceneListIndexFunction() {
-Function thisFunction = luceneListIndexFunction;
-
-gfsh.executeAndAssertThat("execute function --id=" + thisFunction.getId())
-.doesNotContainOutput("not authorized for").statusIsSuccess();
- }
-
- @Test
- @ConnectionConfiguration(user = "dataReadThis_test_region,clusterManage",
- password = "dataReadThis_test_region,clusterManage")
- public void testValidPermissionsForDumpDirectoryFilesWithRegionParameter() {
-Function thisFunction = dumpDirectoryFiles;
-
-gfsh.executeAndAssertThat(
-"execute function --region=" + regionName + " --id=" +
thisFunction.getId())
-.doesNotContainOutput("not authorized for").statusIsSuccess();
- }
-
- @Test
- @ConnectionConfiguration(user = "dataRead,clusterManage", password =
"dataRead,clusterManage")
- public void
testValidPermissionsForDumpDirectoryFilesWithoutRegionParameter() {
-Function thisFunction = dumpDirectoryFiles;
-
-gfsh.executeAndAssertThat("execute function --id=" + thisFunction.getId())
-.doesNotContainOutput("not authorized for").statusIsSuccess();
- }
-
-
- @Test
- @ConnectionConfiguration(user = "dataRead", password = "dataRead")
- public void
testValidPermissionsForLuceneSearchIndexFunctionWithoutRegionParameter() {
-Function thisFunction = luceneSearchIndexFunction;
-
-gfsh.executeAndAssertThat("execute function --id=" + thisFunction.getId())
-.doesNotContainOutput("not authorized for").statusIsSuccess();
- }
-
- @Test
- @ConnectionConfiguration(user = "dataReadThis_test_region", password =
"dataReadThis_test_region")
- public void
testValidPermissionsForLuceneSearchIndexFunctionWithRegionParameter() {
-Function thisFunction = luceneSearchIndexFunction;
-
-gfsh.executeAndAssertThat(
-"execute function --region=" + regionName + " --id=" +
thisFunction.getId())
-.doesNotContainOutput("not authorized for")
[jira] [Commented] (GEODE-3974) improve permission for Internal functions
[
https://issues.apache.org/jira/browse/GEODE-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16330733#comment-16330733
]
ASF GitHub Bot commented on GEODE-3974:
---
jinmeiliao commented on a change in pull request #1287: GEODE-3974: function
security improvement
URL: https://github.com/apache/geode/pull/1287#discussion_r162397689
##
File path:
geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/UserFunctionExecution.java
##
@@ -31,138 +34,149 @@
import org.apache.geode.internal.ClassPathLoader;
import org.apache.geode.internal.InternalEntity;
import org.apache.geode.internal.cache.InternalCache;
+import org.apache.geode.internal.logging.LogService;
import org.apache.geode.internal.security.SecurityService;
import org.apache.geode.management.internal.cli.i18n.CliStrings;
+import org.apache.geode.security.AuthenticationRequiredException;
/**
* @since GemFire 7.0
*/
public class UserFunctionExecution implements Function,
InternalEntity {
public static final String ID = UserFunctionExecution.class.getName();
+ private static Logger logger = LogService.getLogger();
private static final long serialVersionUID = 1L;
@Override
public void execute(FunctionContext context) {
Cache cache = context.getCache();
DistributedMember member =
cache.getDistributedSystem().getDistributedMember();
-try {
- String[] functionArgs = null;
- Object[] args = context.getArguments();
- if (args == null) {
-context.getResultSender().lastResult(new
CliFunctionResult(member.getId(), false,
-CliStrings.EXECUTE_FUNCTION__MSG__COULD_NOT_RETRIEVE_ARGUMENTS));
-return;
- }
+String[] functionArgs = null;
+Object[] args = context.getArguments();
+if (args == null) {
+ context.getResultSender().lastResult(new
CliFunctionResult(member.getId(), false,
+ CliStrings.EXECUTE_FUNCTION__MSG__COULD_NOT_RETRIEVE_ARGUMENTS));
+ return;
+}
- String functionId = ((String) args[0]);
- String filterString = ((String) args[1]);
- String resultCollectorName = ((String) args[2]);
- String argumentsString = ((String) args[3]);
- String onRegion = ((String) args[4]);
- Properties credentials = (Properties) args[5];
+String functionId = ((String) args[0]);
+String filterString = ((String) args[1]);
+String resultCollectorName = ((String) args[2]);
+String argumentsString = ((String) args[3]);
+String onRegion = ((String) args[4]);
+Properties credentials = (Properties) args[5];
- SecurityService securityService = ((InternalCache)
context.getCache()).getSecurityService();
+SecurityService securityService = ((InternalCache)
context.getCache()).getSecurityService();
+boolean loginNeeded = false;
+try {
+ // if the function is executed on a server with jmx-manager that user is
already logged into
+ // then we do not need to do login/logout here.
+ Subject subject = securityService.getSubject();
+ loginNeeded = subject == null || !subject.isAuthenticated();
+} catch (AuthenticationRequiredException e) {
+ loginNeeded = true;
+}
- try {
+try {
+ if (loginNeeded) {
securityService.login(credentials);
+ }
-if (argumentsString != null && argumentsString.length() > 0) {
- functionArgs = argumentsString.split(",");
-}
-Set filters = new HashSet<>();
-ResultCollector resultCollectorInstance = null;
-if (resultCollectorName != null && resultCollectorName.length() > 0) {
- resultCollectorInstance = (ResultCollector)
ClassPathLoader.getLatest()
- .forName(resultCollectorName).newInstance();
-}
-if (filterString != null && filterString.length() > 0) {
- filters.add(filterString);
-}
+ if (argumentsString != null && argumentsString.length() > 0) {
+functionArgs = argumentsString.split(",");
+ }
+ Set filters = new HashSet<>();
+ ResultCollector resultCollectorInstance = null;
+ if (resultCollectorName != null && resultCollectorName.length() > 0) {
+resultCollectorInstance = (ResultCollector) ClassPathLoader.getLatest()
+.forName(resultCollectorName).newInstance();
+ }
+ if (filterString != null && filterString.length() > 0) {
+filters.add(filterString);
+ }
-Function function = FunctionService.getFunction(functionId);
-if (function == null) {
- context.getResultSender()
- .lastResult(new CliFunctionResult(member.getId(), false,
- (CliStrings.format(
-
CliStrings.EXECUTE_FUNCTION__MSG__DOES_NOT_HAVE_FUNCTION_0_REGISTERED,
- functionId;
- return;
-}
+ Function function = F
[jira] [Commented] (GEODE-3974) improve permission for Internal functions
[
https://issues.apache.org/jira/browse/GEODE-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16330729#comment-16330729
]
ASF GitHub Bot commented on GEODE-3974:
---
jinmeiliao commented on a change in pull request #1287: GEODE-3974: function
security improvement
URL: https://github.com/apache/geode/pull/1287#discussion_r162396886
##
File path:
geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/UserFunctionExecution.java
##
@@ -31,138 +34,149 @@
import org.apache.geode.internal.ClassPathLoader;
import org.apache.geode.internal.InternalEntity;
import org.apache.geode.internal.cache.InternalCache;
+import org.apache.geode.internal.logging.LogService;
import org.apache.geode.internal.security.SecurityService;
import org.apache.geode.management.internal.cli.i18n.CliStrings;
+import org.apache.geode.security.AuthenticationRequiredException;
/**
* @since GemFire 7.0
*/
public class UserFunctionExecution implements Function,
InternalEntity {
public static final String ID = UserFunctionExecution.class.getName();
+ private static Logger logger = LogService.getLogger();
private static final long serialVersionUID = 1L;
@Override
public void execute(FunctionContext context) {
Cache cache = context.getCache();
DistributedMember member =
cache.getDistributedSystem().getDistributedMember();
-try {
- String[] functionArgs = null;
- Object[] args = context.getArguments();
- if (args == null) {
-context.getResultSender().lastResult(new
CliFunctionResult(member.getId(), false,
-CliStrings.EXECUTE_FUNCTION__MSG__COULD_NOT_RETRIEVE_ARGUMENTS));
-return;
- }
+String[] functionArgs = null;
+Object[] args = context.getArguments();
+if (args == null) {
+ context.getResultSender().lastResult(new
CliFunctionResult(member.getId(), false,
+ CliStrings.EXECUTE_FUNCTION__MSG__COULD_NOT_RETRIEVE_ARGUMENTS));
+ return;
+}
- String functionId = ((String) args[0]);
- String filterString = ((String) args[1]);
- String resultCollectorName = ((String) args[2]);
- String argumentsString = ((String) args[3]);
- String onRegion = ((String) args[4]);
- Properties credentials = (Properties) args[5];
+String functionId = ((String) args[0]);
+String filterString = ((String) args[1]);
+String resultCollectorName = ((String) args[2]);
+String argumentsString = ((String) args[3]);
+String onRegion = ((String) args[4]);
+Properties credentials = (Properties) args[5];
- SecurityService securityService = ((InternalCache)
context.getCache()).getSecurityService();
+SecurityService securityService = ((InternalCache)
context.getCache()).getSecurityService();
+boolean loginNeeded = false;
+try {
+ // if the function is executed on a server with jmx-manager that user is
already logged into
+ // then we do not need to do login/logout here.
+ Subject subject = securityService.getSubject();
+ loginNeeded = subject == null || !subject.isAuthenticated();
+} catch (AuthenticationRequiredException e) {
+ loginNeeded = true;
+}
Review comment:
let's see how it would get reused before we make it a public facing api.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> improve permission for Internal functions
> -
>
> Key: GEODE-3974
> URL: https://issues.apache.org/jira/browse/GEODE-3974
> Project: Geode
> Issue Type: Bug
> Components: docs, management
>Reporter: Jinmei Liao
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.5.0
>
>
> Internal functions needs to be updated to require appropriate permissions
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (GEODE-4316) Add tests for jar deployment to check for server restarting
[ https://issues.apache.org/jira/browse/GEODE-4316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Deppe reassigned GEODE-4316: - Assignee: Jens Deppe > Add tests for jar deployment to check for server restarting > --- > > Key: GEODE-4316 > URL: https://issues.apache.org/jira/browse/GEODE-4316 > Project: Geode > Issue Type: Improvement > Components: gfsh >Reporter: Jens Deppe >Assignee: Jens Deppe >Priority: Major > > Check whether a function undeploy works correctly when a server is restarted -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (GEODE-4312) CI failure: org.apache.geode.cache30.CacheXml80DUnitTest > testPartitionedRegionAttributesForCoLocation3 FAILED
[
https://issues.apache.org/jira/browse/GEODE-4312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Deppe reassigned GEODE-4312:
-
Assignee: Jens Deppe
> CI failure: org.apache.geode.cache30.CacheXml80DUnitTest >
> testPartitionedRegionAttributesForCoLocation3 FAILED
> ---
>
> Key: GEODE-4312
> URL: https://issues.apache.org/jira/browse/GEODE-4312
> Project: Geode
> Issue Type: Bug
> Components: gfsh
>Reporter: Jens Deppe
>Assignee: Jens Deppe
>Priority: Major
> Labels: ci, pull-request-available
>
> Test produces this:
> {noformat}
> Suspicious strings were written to the log during this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> ---
> Found suspect string in log4j at line 157
> [error 2018/01/17 03:31:42.318 UTC
> tid=0x2c6] Unexpected exception during bucket recovery
> java.lang.IllegalStateException: Region specified in 'colocated-with'
> (Customer) for region /Order does not exist. It should be created before
> setting 'colocated-with' attribute for this region.
> at
> org.apache.geode.internal.cache.ColocationHelper.getColocatedRegion(ColocationHelper.java:94)
> at
> org.apache.geode.internal.cache.ColocationHelper.getLeaderRegion(ColocationHelper.java:455)
> at
> org.apache.geode.internal.cache.partitioned.PartitionedRegionRebalanceOp.(PartitionedRegionRebalanceOp.java:134)
> at
> org.apache.geode.internal.cache.partitioned.PartitionedRegionRebalanceOp.(PartitionedRegionRebalanceOp.java:114)
> at
> org.apache.geode.internal.cache.PRHARedundancyProvider$3.run2(PRHARedundancyProvider.java:1568)
> at
> org.apache.geode.internal.cache.partitioned.RecoveryRunnable.run(RecoveryRunnable.java:61)
> at
> org.apache.geode.internal.OneTaskOnlyExecutor$DelegatingRunnable.run(OneTaskOnlyExecutor.java:134)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> {noformat}
> The relevant section of the log is this:
> {noformat}
> [info 2018/01/17 03:31:42.248 UTC tid=0x16] Initializing region
> __PR
> [info 2018/01/17 03:31:42.248 UTC tid=0x16] Initialization of
> region __PR completed
> [info 2018/01/17 03:31:42.249 UTC tid=0x16] Partitioned Region
> /Customer is born with prId=4 ident:#Customer
> [info 2018/01/17 03:31:42.271 UTC tid=0x16] Partitioned Region
> /Order is born with prId=5 ident:#Order
> [info 2018/01/17 03:31:42.314 UTC tid=0x16] GemFireCache[id =
> 1650399312; isClosing = true; isShutDownAll = false; created = Wed Jan 17
> 03:31:41 UTC 2018; server = false; copyOnRead = false; lockLease = 120;
> lockTimeout = 60]: Now closing.
> [error 2018/01/17 03:31:42.318 UTC
> tid=0x2c6] Unexpected exception during bucket recovery
> java.lang.IllegalStateException: Region specified in 'colocated-with'
> (Customer) for region /Order does not exist. It should be created before
> setting 'colocated-with' attribute for this region.
> at
> org.apache.geode.internal.cache.ColocationHelper.getColocatedRegion(ColocationHelper.java:94)
> at
> org.apache.geode.internal.cache.ColocationHelper.getLeaderRegion(ColocationHelper.java:455)
> at
> org.apache.geode.internal.cache.partitioned.PartitionedRegionRebalanceOp.(PartitionedRegionRebalanceOp.java:134)
> at
> org.apache.geode.internal.cache.partitioned.PartitionedRegionRebalanceOp.(PartitionedRegionRebalanceOp.java:114)
> at
> org.apache.geode.internal.cache.PRHARedundancyProvider$3.run2(PRHARedundancyProvider.java:1568)
> at
> org.apache.geode.internal.cache.partitioned.RecoveryRunnable.run(RecoveryRunnable.java:61)
> at
> org.apache.geode.internal.OneTaskOnlyExecutor$DelegatingRunnable.run(OneTaskOnlyExecutor.java:134)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask
