[jira] [Commented] (GEODE-4509) change the InternalCache interface to use InternalRegion instead of LocalRegion

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-4509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353466#comment-16353466
 ] 

ASF subversion and git services commented on GEODE-4509:


Commit 158992b474e1c94bab64c7cbb127cdce4a643bdb in geode's branch 
refs/heads/feature/GEODE-3967 from [~dschneider]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=158992b ]

GEODE-4509: change uses of LocalRegion to InternalRegion (#1379)

* changed to use InternalRegion

* changed cast of LocalRegion to InternalRegion

The following classes/interfaces have been changed to use InternalRegion 
instead of LocalRegion:
InternalCache, ClientMetaDataService, ClientRegionFactoryImpl, RegionFactory, 
RequiredRoles, MemoryAllocatorImpl, and CacheStatisticsImpl

> change the InternalCache interface to use InternalRegion instead of 
> LocalRegion
> ---
>
> Key: GEODE-4509
> URL: https://issues.apache.org/jira/browse/GEODE-4509
> Project: Geode
>  Issue Type: Improvement
>  Components: regions
>Reporter: Darrel Schneider
>Assignee: Darrel Schneider
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.5.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> The InternalCache interface should not expose or use LocalRegion. It should 
> use InternalRegion instead.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353469#comment-16353469
 ] 

ASF subversion and git services commented on GEODE-3967:


Commit c67d100feb2a2106866f42cbdc143ca887b48050 in geode's branch 
refs/heads/feature/GEODE-3967 from zhouxh
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=c67d100 ]

GEODE-3967: when ConcurrentCacheModificationException happened. 
GatewaySenderEventImpl should save the status and notify gatewaysender anyway. 
SerialGatewaySender will handle it. In AbstractUpdateOperation's 
doPutOrCreate's 3 tries of basicUpdate, the 3rd one should allow both create 
and update.
make event with CME to be ignored by dispatcher


> if put hits concurrent modification exception should still notify serial 
> gateway sender
> ---
>
> Key: GEODE-3967
> URL: https://issues.apache.org/jira/browse/GEODE-3967
> Project: Geode
>  Issue Type: Bug
>  Components: wan
>Reporter: xiaojian zhou
>Assignee: xiaojian zhou
>Priority: Major
>  Labels: pull-request-available
>
> In serial gateway sender, the event arrives at secondary will be put into 
> unprocessedMap and wait for event from primary queue to distribute over, then 
> remove it from the unprocessedMap.
> If the put at primary member (member with primary queue) failed with CME, the 
> event in unprocessedMap will never be removed. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-4442) Create message for cancelling an in progress backup

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-4442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353468#comment-16353468
 ] 

ASF subversion and git services commented on GEODE-4442:


Commit e9b4bd5ae03acb062840ed33c03353db9bfd24d7 in geode's branch 
refs/heads/feature/GEODE-3967 from [~nreich]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=e9b4bd5 ]

GEODE-4442: Move abort of backups to separate message (#1381)



> Create message for cancelling an in progress backup
> ---
>
> Key: GEODE-4442
> URL: https://issues.apache.org/jira/browse/GEODE-4442
> Project: Geode
>  Issue Type: Sub-task
>  Components: persistence
>Reporter: Nick Reich
>Assignee: Nick Reich
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.5.0
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> Currently, the final message involved in backups contains an abort flag that 
> is the only way to cancel the backup. We should allow a way to try and halt 
> an in progress backup by splitting out the abort logic from the existing 
> message into a new message.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-4397) Extract many methods from RegionMapDestroy destroy

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-4397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353465#comment-16353465
 ] 

ASF subversion and git services commented on GEODE-4397:


Commit 1c89fe156905529009d9c3e838a6ead5add0202b in geode's branch 
refs/heads/feature/GEODE-3967 from [~apa...@the9muses.net]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=1c89fe1 ]

GEODE-4397: refactor RegionMapDestroy destroy operation (#1370)



> Extract many methods from RegionMapDestroy destroy
> --
>
> Key: GEODE-4397
> URL: https://issues.apache.org/jira/browse/GEODE-4397
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.5.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Extract many methods from RegionMapDestroy destroy.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-4487) Remove singleton calls from all tests in org.apache.geode.internal.offheap

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353467#comment-16353467
 ] 

ASF subversion and git services commented on GEODE-4487:


Commit c36a11356efac2ca942fac97f27e39d47a496ede in geode's branch 
refs/heads/feature/GEODE-3967 from [~dschneider]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=c36a113 ]

GEODE-4487: Remove singleton calls from offheap package (#1382)

One test was using the singletons just to confirm the cache had been shutdown. 
It was easy to change that test to not confirm the singleton was null but to 
instead ask if the test's cache was closed.

The other test was testing DataType which is product code that is only used by 
tests to inspect what is stored in offheap memory. The test was mocking the 
singleton methods because the product DataType was using the singleton to 
decode a serialized PDX. I changed DataType to just do less decoding of pdx. 
Now it will just say it was a pdx and give you the type number.


> Remove singleton calls from all tests in org.apache.geode.internal.offheap
> --
>
> Key: GEODE-4487
> URL: https://issues.apache.org/jira/browse/GEODE-4487
> Project: Geode
>  Issue Type: Sub-task
>  Components: offheap, tests
>Reporter: Kirk Lund
>Assignee: Darrel Schneider
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.5.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> These tests in org.apache.geode.internal.offheap invoke singleton getters.
> GemFireCacheImpl.getInstance():
> * OutOfOffHeapMemoryDUnitTest
> GemFireCacheImpl.getForPdx(String):
> * DataTypeJUnitTest
> InternalDistributedSystem.getAnyInstance():
> * OutOfOffHeapMemoryDUnitTest



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-4076) Client receives a GemFireSecurityException instead of AuthenticationRequiredException

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-4076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353463#comment-16353463
 ] 

ASF subversion and git services commented on GEODE-4076:


Commit 198b9e003d0ac9320c707ef8866f7b9569fe40e6 in geode's branch 
refs/heads/feature/GEODE-3967 from [~jinmeiliao]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=198b9e0 ]

GEODE-4076: throw AuthenticationRequiredException when failed to find… (#1369)



> Client receives a GemFireSecurityException instead of 
> AuthenticationRequiredException
> -
>
> Key: GEODE-4076
> URL: https://issues.apache.org/jira/browse/GEODE-4076
> Project: Geode
>  Issue Type: Bug
>  Components: security
>Reporter: Jinmei Liao
>Assignee: Jinmei Liao
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.4.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> In some cases, when a client message comes in, the ServerConnection that 
> handles this client message fails to find the authenticated user for this 
> clientID, the older security framework throws an 
> AuthenticationRequiredException while the new Security framework throws 
> GemfireSecurityException. This might causes the client not do a retry 
> connection. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-3966) PoolImpl.createAuthenticatedCacheView should not call CacheFactory.getInstance

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353464#comment-16353464
 ] 

ASF subversion and git services commented on GEODE-3966:


Commit 40a2ca0041e575cd3c21f9fba80f523ce44bc3c1 in geode's branch 
refs/heads/feature/GEODE-3967 from [~PivotalSarge]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=40a2ca0 ]

GEODE-3966: Avoid singletons by passing distributed system and cache. (#1366)



> PoolImpl.createAuthenticatedCacheView should not call CacheFactory.getInstance
> --
>
> Key: GEODE-3966
> URL: https://issues.apache.org/jira/browse/GEODE-3966
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server
>Reporter: Darrel Schneider
>Assignee: Michael Dodge
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.5.0
>
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> PoolImpl.createAuthenticatedCacheView should not call 
> CacheFactory.getInstance.
> It looks like it would be easy for all the callers of this method to pass the 
> cache in as a parameter.
> Or maybe an InternalPool should be associated with a Cache already (there are 
> two other uses of CacheFactory.getInstance in this class)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-4270) [CI Failure] org.apache.geode.cache.query.cq.dunit.CqSecurityAuthorizedUserDUnitTest > cqExecuteWithInitialResultsWithMethodInvocationWithUnpopulatedRegionAndFollowedBy

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-4270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353462#comment-16353462
 ] 

ASF subversion and git services commented on GEODE-4270:


Commit 80ad2d70435fb255a8a2d08c8866fbb30a7bedd3 in geode's branch 
refs/heads/feature/GEODE-3967 from [~WireBaron]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=80ad2d7 ]

GEODE-4270: remove race condition where CacheClientProxy could be asked to 
(#1378)

authorize a message prior to receiving its security subject.

> [CI Failure] 
> org.apache.geode.cache.query.cq.dunit.CqSecurityAuthorizedUserDUnitTest > 
> cqExecuteWithInitialResultsWithMethodInvocationWithUnpopulatedRegionAndFollowedByAPutShouldTriggerCqError[0]
>  FAILED
> --
>
> Key: GEODE-4270
> URL: https://issues.apache.org/jira/browse/GEODE-4270
> Project: Geode
>  Issue Type: Bug
>  Components: client/server, security
>Reporter: nabarun
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> {noformat}
> org.apache.geode.cache.query.cq.dunit.CqSecurityAuthorizedUserDUnitTest > 
> cqExecuteWithInitialResultsWithMethodInvocationWithUnpopulatedRegionAndFollowedByAPutShouldTriggerCqError[0]
>  FAILED
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.security.query.QuerySecurityBase$$Lambda$50/1990038369.run 
> in VM 1 running on Host 6b888a694193 with 4 VMs
> at org.apache.geode.test.dunit.VM.invoke(VM.java:393)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:363)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:308)
> at 
> org.apache.geode.security.query.QuerySecurityBase.putIntoRegion(QuerySecurityBase.java:202)
> at 
> org.apache.geode.cache.query.cq.dunit.CqSecurityAuthorizedUserDUnitTest.cqExecuteWithInitialResultsWithMethodInvocationWithUnpopulatedRegionAndFollowedByAPutShouldTriggerCqError(CqSecurityAuthorizedUserDUnitTest.java:138)
> Caused by:
> org.apache.geode.cache.client.ServerOperationException: remote server 
> on 6b888a694193(153:loner):32936:ced4ccdc: 
> org.apache.geode.security.GemFireSecurityException: Error: Anonymous User
> Caused by:
> org.apache.geode.security.GemFireSecurityException: Error: 
> Anonymous User
> {noformat}
> *+Test logs+*
> https://concourse.apachegeode-ci.info/teams/main/pipelines/develop/jobs/DistributedTest/builds/70#L5a4ed7fc:654



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (GEODE-4525) Remove singleton calls from product code in org.apache.geode.internal.cache.wan

[Avinash Dongre (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Avinash Dongre reassigned GEODE-4525:
-

Assignee: Avinash Dongre

> Remove singleton calls from product code in 
> org.apache.geode.internal.cache.wan
> ---
>
> Key: GEODE-4525
> URL: https://issues.apache.org/jira/browse/GEODE-4525
> Project: Geode
>  Issue Type: Sub-task
>  Components: wan
>Reporter: Kirk Lund
>Assignee: Avinash Dongre
>Priority: Major
>
> These product classes in org.apache.geode.internal.cache.wan invoke singleton 
> getters.
> CacheFactory.getAnyInstance():
> * GatewaySenderEventImpl
> * GatewaySenderQueueEntrySynchronizationOperation
> * 
> GatewaySenderQueueEntrySynchronizationOperation$GatewaySenderQueueEntrySynchronizationMessage
> * 
> GatewaySenderQueueEntrySynchronizationOperation$GatewaySenderQueueEntrySynchronizationReplyProcessor
> InternalDistributedSystem.getAnyInstance():
> * GatewayReceiverStats
> * GatewaySenderFactoryImpl



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (GEODE-4590) Remove singleton calls from product code in org.apache.geode.internal.util.concurrent

[Darrel Schneider (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darrel Schneider reassigned GEODE-4590:
---

Assignee: Darrel Schneider

> Remove singleton calls from product code in 
> org.apache.geode.internal.util.concurrent
> -
>
> Key: GEODE-4590
> URL: https://issues.apache.org/jira/browse/GEODE-4590
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Kirk Lund
>Assignee: Darrel Schneider
>Priority: Major
>
> These product classes in org.apache.geode.internal.util.concurrent invoke 
> singleton getters.
> InternalDistributedSystem.getConnectedInstance():
> * CustomEntryConcurrentHashMap



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (GEODE-4345) Remove current geode-native quickstarts

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated GEODE-4345:
--
Labels: pull-request-available  (was: )

> Remove current geode-native quickstarts
> ---
>
> Key: GEODE-4345
> URL: https://issues.apache.org/jira/browse/GEODE-4345
> Project: Geode
>  Issue Type: Sub-task
>  Components: native client
>Reporter: Addison
>Assignee: Jacob S. Barrett
>Priority: Major
>  Labels: pull-request-available
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (GEODE-4572) SerializationRegistry::addType and similar functions should return std::shared_ptr

[Jacob S. Barrett (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacob S. Barrett reassigned GEODE-4572:
---

Assignee: Jacob S. Barrett

> SerializationRegistry::addType and similar functions should return 
> std::shared_ptr
> --
>
> Key: GEODE-4572
> URL: https://issues.apache.org/jira/browse/GEODE-4572
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 2h
>  Remaining Estimate: 0h
>
> Currently these functions return a raw pointer. Returning a std::shared_ptr 
> reduces the chance for memory leaks and improves performance given that all 
> use cases resulted in the raw pointer being wrapped later in std::shared_ptr.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (GEODE-4345) Remove current geode-native quickstarts

[Jacob S. Barrett (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacob S. Barrett reassigned GEODE-4345:
---

Assignee: Jacob S. Barrett

> Remove current geode-native quickstarts
> ---
>
> Key: GEODE-4345
> URL: https://issues.apache.org/jira/browse/GEODE-4345
> Project: Geode
>  Issue Type: Sub-task
>  Components: native client
>Reporter: Addison
>Assignee: Jacob S. Barrett
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (GEODE-4605) Replace void* with std::shared_ptr in PdxSerializer/PdxWrapper

[Jacob S. Barrett (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacob S. Barrett reassigned GEODE-4605:
---

Assignee: Jacob S. Barrett

> Replace void* with std::shared_ptr in PdxSerializer/PdxWrapper
> 
>
> Key: GEODE-4605
> URL: https://issues.apache.org/jira/browse/GEODE-4605
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> With {{void*}} it is necessary to keep a deleter function around to free 
> memory allocated to the type erased pointer. Switching to 
> \{{std::shared_ptr}} keeps the type erased pointer but preserves the 
> correct delete behavior with the added bonus of non-ambiguous pointer 
> ownership.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-4572) SerializationRegistry::addType and similar functions should return std::shared_ptr

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353165#comment-16353165
 ] 

ASF subversion and git services commented on GEODE-4572:


Commit 6135f3b4cb6875b05de42207a333eefc4bc52c19 in geode-native's branch 
refs/heads/develop from Jacob Barrett
[ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=6135f3b ]

 GEODE-4572: Refactor createDeserialized with std::shared_ptr. (#204)




> SerializationRegistry::addType and similar functions should return 
> std::shared_ptr
> --
>
> Key: GEODE-4572
> URL: https://issues.apache.org/jira/browse/GEODE-4572
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Jacob S. Barrett
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 2h
>  Remaining Estimate: 0h
>
> Currently these functions return a raw pointer. Returning a std::shared_ptr 
> reduces the chance for memory leaks and improves performance given that all 
> use cases resulted in the raw pointer being wrapped later in std::shared_ptr.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (GEODE-4605) Replace void* with std::shared_ptr in PdxSerializer/PdxWrapper

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated GEODE-4605:
--
Labels: pull-request-available  (was: )

> Replace void* with std::shared_ptr in PdxSerializer/PdxWrapper
> 
>
> Key: GEODE-4605
> URL: https://issues.apache.org/jira/browse/GEODE-4605
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Jacob S. Barrett
>Priority: Major
>  Labels: pull-request-available
>
> With {{void*}} it is necessary to keep a deleter function around to free 
> memory allocated to the type erased pointer. Switching to 
> \{{std::shared_ptr}} keeps the type erased pointer but preserves the 
> correct delete behavior with the added bonus of non-ambiguous pointer 
> ownership.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (GEODE-4607) Get rid of Request and Response; renumber Protobuf fields

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated GEODE-4607:
--
Labels: pull-request-available  (was: )

> Get rid of Request and Response; renumber Protobuf fields
> -
>
> Key: GEODE-4607
> URL: https://issues.apache.org/jira/browse/GEODE-4607
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Brian Rowe
>Priority: Major
>  Labels: pull-request-available
>
> Get in a few breaking changes to improve the protobuf protocol before we 
> remove the experimental tag.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (GEODE-4607) Get rid of Request and Response; renumber Protobuf fields

[Brian Rowe (JIRA)]

Brian Rowe created GEODE-4607:
-

 Summary: Get rid of Request and Response; renumber Protobuf fields
 Key: GEODE-4607
 URL: https://issues.apache.org/jira/browse/GEODE-4607
 Project: Geode
  Issue Type: Bug
  Components: client/server
Reporter: Brian Rowe


Get in a few breaking changes to improve the protobuf protocol before we remove 
the experimental tag.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (GEODE-4606) Create new geode-example about continuous queries

[Michael Dodge (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Dodge reassigned GEODE-4606:


Assignee: Michael Dodge

> Create new geode-example about continuous queries
> -
>
> Key: GEODE-4606
> URL: https://issues.apache.org/jira/browse/GEODE-4606
> Project: Geode
>  Issue Type: New Feature
>  Components: examples
>Reporter: Michael Dodge
>Assignee: Michael Dodge
>Priority: Major
>
> Create an example the demonstrates continuous queries.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (GEODE-4606) Create new geode-example about continuous queries

[Michael Dodge (JIRA)]

Michael Dodge created GEODE-4606:


 Summary: Create new geode-example about continuous queries
 Key: GEODE-4606
 URL: https://issues.apache.org/jira/browse/GEODE-4606
 Project: Geode
  Issue Type: New Feature
  Components: examples
Reporter: Michael Dodge


Create an example the demonstrates continuous queries.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (GEODE-4605) Replace void* with std::shared_ptr in PdxSerializer/PdxWrapper

[Jacob S. Barrett (JIRA)]

Jacob S. Barrett created GEODE-4605:
---

 Summary: Replace void* with std::shared_ptr in 
PdxSerializer/PdxWrapper
 Key: GEODE-4605
 URL: https://issues.apache.org/jira/browse/GEODE-4605
 Project: Geode
  Issue Type: Improvement
  Components: native client
Reporter: Jacob S. Barrett


With {{void*}} it is necessary to keep a deleter function around to free memory 
allocated to the type erased pointer. Switching to \{{std::shared_ptr}} 
keeps the type erased pointer but preserves the correct delete behavior with 
the added bonus of non-ambiguous pointer ownership.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (GEODE-4440) Create new geode-example about OQL indexes

[Michael Dodge (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Dodge updated GEODE-4440:
-
Summary: Create new geode-example about OQL indexes  (was: Add an example 
for OQL indexes.)

> Create new geode-example about OQL indexes
> --
>
> Key: GEODE-4440
> URL: https://issues.apache.org/jira/browse/GEODE-4440
> Project: Geode
>  Issue Type: New Feature
>  Components: examples
>Reporter: Michael Dodge
>Assignee: Michael Dodge
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Create an example that demonstrates OQL compact range indexes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (GEODE-4440) Add an example for OQL indexes.

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated GEODE-4440:
--
Labels: pull-request-available  (was: )

> Add an example for OQL indexes.
> ---
>
> Key: GEODE-4440
> URL: https://issues.apache.org/jira/browse/GEODE-4440
> Project: Geode
>  Issue Type: New Feature
>  Components: examples
>Reporter: Michael Dodge
>Assignee: Michael Dodge
>Priority: Major
>  Labels: pull-request-available
>
> Create an example that demonstrates OQL compact range indexes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (GEODE-4604) Rest API is not getting the permissions required by each function to do security check

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated GEODE-4604:
--
Labels: pull-request-available  (was: )

> Rest API is not getting the permissions required by each function to do 
> security check
> --
>
> Key: GEODE-4604
> URL: https://issues.apache.org/jira/browse/GEODE-4604
> Project: Geode
>  Issue Type: Bug
>  Components: rest (dev), security
>Reporter: Jinmei Liao
>Assignee: Jinmei Liao
>Priority: Major
>  Labels: pull-request-available
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (GEODE-4604) Rest API is not getting the permissions required by each function to do security check

[Jinmei Liao (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jinmei Liao reassigned GEODE-4604:
--

Assignee: Jinmei Liao

> Rest API is not getting the permissions required by each function to do 
> security check
> --
>
> Key: GEODE-4604
> URL: https://issues.apache.org/jira/browse/GEODE-4604
> Project: Geode
>  Issue Type: Bug
>  Components: rest (dev), security
>Reporter: Jinmei Liao
>Assignee: Jinmei Liao
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (GEODE-4604) Rest API is not getting the permissions required by each function to do security check

[Jinmei Liao (JIRA)]

Jinmei Liao created GEODE-4604:
--

 Summary: Rest API is not getting the permissions required by each 
function to do security check
 Key: GEODE-4604
 URL: https://issues.apache.org/jira/browse/GEODE-4604
 Project: Geode
  Issue Type: Bug
  Components: rest (dev), security
Reporter: Jinmei Liao






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (GEODE-3966) PoolImpl.createAuthenticatedCacheView should not call CacheFactory.getInstance

[Michael Dodge (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Dodge resolved GEODE-3966.
--
   Resolution: Fixed
Fix Version/s: 1.5.0

> PoolImpl.createAuthenticatedCacheView should not call CacheFactory.getInstance
> --
>
> Key: GEODE-3966
> URL: https://issues.apache.org/jira/browse/GEODE-3966
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server
>Reporter: Darrel Schneider
>Assignee: Michael Dodge
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.5.0
>
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> PoolImpl.createAuthenticatedCacheView should not call 
> CacheFactory.getInstance.
> It looks like it would be easy for all the callers of this method to pass the 
> cache in as a parameter.
> Or maybe an InternalPool should be associated with a Cache already (there are 
> two other uses of CacheFactory.getInstance in this class)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (GEODE-3281) Native Client Example Docs Use RegisterType instead of RegisterTypeGeneric

[Addison (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Addison updated GEODE-3281:
---
Priority: Trivial  (was: Major)

> Native Client Example Docs Use RegisterType instead of RegisterTypeGeneric
> --
>
> Key: GEODE-3281
> URL: https://issues.apache.org/jira/browse/GEODE-3281
> Project: Geode
>  Issue Type: Bug
>  Components: docs, native client
>Reporter: Addison
>Priority: Trivial
>
> Change RegisterType to RegisterTypeGeneric in 
> https://github.com/apache/geode-native/blob/develop/docs/geode-native-docs/dotnet-caching-api/custom-class-igfserializable.html.md.erb



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (GEODE-4603) Refactor TcrMessage - break up processChunk

[Addison (JIRA)]

Addison created GEODE-4603:
--

 Summary: Refactor TcrMessage - break up processChunk
 Key: GEODE-4603
 URL: https://issues.apache.org/jira/browse/GEODE-4603
 Project: Geode
  Issue Type: Task
  Components: native client
Reporter: Addison


TcrMessage::processChunk contains a giant switch statement which processes the 
message based on the message type.

Consider separating the process logic for each reply into a unique reply class 
for each reply type. If we create unique reply classes for each reply then the 
logic can be broken out among the appropriate reply class rather than a giant 
proccessChunk which knows how to process every message.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (GEODE-4602) Refactor TcrMessage - unfriend TcrMessageHelper and TcrMessage

[Addison (JIRA)]

Addison created GEODE-4602:
--

 Summary: Refactor TcrMessage - unfriend TcrMessageHelper and 
TcrMessage
 Key: GEODE-4602
 URL: https://issues.apache.org/jira/browse/GEODE-4602
 Project: Geode
  Issue Type: Task
  Components: native client
Reporter: Addison


TcrMessageHelper breaks encapsulation of TcrMessage so that ThinClientRegion 
can process messages. For example, look at ChunkedQueryResponse::handleChunk.

Evaluate ways to decouple these classes. Consider making a non-friend processor 
class instead. Make more stories as appropriate.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (GEODE-4601) Refactor TcrMessage - resolve accessor encapsulation

[Addison (JIRA)]

Addison created GEODE-4601:
--

 Summary: Refactor TcrMessage - resolve accessor encapsulation
 Key: GEODE-4601
 URL: https://issues.apache.org/jira/browse/GEODE-4601
 Project: Geode
  Issue Type: Task
  Components: native client
Reporter: Addison


{{TcrMessage}} has accessor {{setMessageType()}} which should be removed from 
the base class.  It is used only on reply messages, _not_ request messages.

Here are some steps we can take:
# Move it into the {{TcrMessageReply}} class.
# Remove the accessor entirely by altering internal APIs, e.g. 
{{TcrMessageHelper::readChunkPartHeader()}}, to return a message object rather 
than taking a reference to a message and then modifying the type.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (GEODE-4600) Config XML parser should enforce schema

[Addison (JIRA)]

Addison created GEODE-4600:
--

 Summary: Config XML parser should enforce schema
 Key: GEODE-4600
 URL: https://issues.apache.org/jira/browse/GEODE-4600
 Project: Geode
  Issue Type: Improvement
  Components: native client
Reporter: Addison


The config xml parser does not validate the XML document against the old DTDs 
or the new XSD. Many of the config files we have are not valid to the DTD or 
XSD. Many mistakes in configuration could be caught in the parser by validation 
alone.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Issue Comment Deleted] (GEODE-2932) Users would like option for PR with empty data policy

[Wes Williams (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Wes Williams updated GEODE-2932:

Comment: was deleted

(was: This can be done now with local regions but it's a admin royal pain. Gfsh 
doesn't record the local regions and it increases complexity for the users. An 
empty PR is needed.)

> Users would like option for PR with empty data policy 
> --
>
> Key: GEODE-2932
> URL: https://issues.apache.org/jira/browse/GEODE-2932
> Project: Geode
>  Issue Type: Improvement
>  Components: regions
>Reporter: Fred Krone
>Priority: Major
>  Labels: storage_2
>
> Allow for accessor partitioned regions to route incoming operations. 
> The idea is to use a PR to control distributed/partitioned _processing_ of 
> events without the need to cache them. This option would be especially useful 
> for streaming cases where the target is a PR's attached AsyncEventQueue.  
> Also useful when the target is a PR's attached CacheListener.  We have 
> developed some work-around for this in the field, but they require 
> significant code and complex configuration, and limited to event input from 
> peer-clients.
> For many use-cases, there would still be a need to co-locate other 
> standard/caching PR's with the "empty" one to enable enrichment, 
> transformation, and similar logic in the custom event callbacks (either 
> CacheListener or AEQ Listener). 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-2932) Users would like option for PR with empty data policy

[Wes Williams (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353004#comment-16353004
 ] 

Wes Williams commented on GEODE-2932:
-

This can be done now with local regions but it's a admin royal pain. Gfsh 
doesn't record the local regions and it increases complexity for the users. An 
empty PR is needed.

> Users would like option for PR with empty data policy 
> --
>
> Key: GEODE-2932
> URL: https://issues.apache.org/jira/browse/GEODE-2932
> Project: Geode
>  Issue Type: Improvement
>  Components: regions
>Reporter: Fred Krone
>Priority: Major
>  Labels: storage_2
>
> Allow for accessor partitioned regions to route incoming operations. 
> The idea is to use a PR to control distributed/partitioned _processing_ of 
> events without the need to cache them. This option would be especially useful 
> for streaming cases where the target is a PR's attached AsyncEventQueue.  
> Also useful when the target is a PR's attached CacheListener.  We have 
> developed some work-around for this in the field, but they require 
> significant code and complex configuration, and limited to event input from 
> peer-clients.
> For many use-cases, there would still be a need to co-locate other 
> standard/caching PR's with the "empty" one to enable enrichment, 
> transformation, and similar logic in the custom event callbacks (either 
> CacheListener or AEQ Listener). 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (GEODE-4599) Ensure native client checks if locks are acquired

[Addison (JIRA)]

Addison created GEODE-4599:
--

 Summary: Ensure native client checks if locks are acquired
 Key: GEODE-4599
 URL: https://issues.apache.org/jira/browse/GEODE-4599
 Project: Geode
  Issue Type: Wish
  Components: native client
Reporter: Addison


In several places NC tries to acquire a lock, but never checks that the lock 
was successfully acquired.  ACE documentation clearly states that this is bad 
behavior:

{noformat}
Code like this is dangerous:
  {
ACE_Guard g(lock);
... perform critical operation requiring lock to be held...
  }
Instead, one must do something like this:
  {
ACE_Guard g(lock);
if (! g.locked())
  {
... handle error ...
  }
else
  {
... perform critical operation requiring lock to be held ...
  }
  }
{noformat}

It's worth noting that this may be linked to GEM-267 where the following code 
was found with an error thrown inside a critical section of 
{{ThinClientRegion.cpp}}.

{noformat}
if (m_resultCollectorLock != NULL) {
ACE_Guard < ACE_Recursive_Thread_Mutex > guard(
*m_resultCollectorLock);
m_rc->addResult(result);
} else {
m_rc->addResult(result);
}
{noformat}

We may need to investigate on a case-by-case basis how we should handle when 
the lock isn't successfully acquired.  There are roughly 200 other places where 
this same behavior is present.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (GEODE-4598) Make LRUListWithAsyncSorting the default LRU list

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated GEODE-4598:
--
Labels: pull-request-available  (was: )

> Make LRUListWithAsyncSorting the default LRU list
> -
>
> Key: GEODE-4598
> URL: https://issues.apache.org/jira/browse/GEODE-4598
> Project: Geode
>  Issue Type: Bug
>  Components: eviction
>Reporter: Nick Reich
>Assignee: Nick Reich
>Priority: Major
>  Labels: pull-request-available
>
> The new LRUListWithAsyncSorting should become the new default (replacing the 
> old algorithm) and the experimental tag should be removed from its properties.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (GEODE-4442) Create message for cancelling an in progress backup

[Nick Reich (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nick Reich resolved GEODE-4442.
---
   Resolution: Fixed
Fix Version/s: 1.5.0

> Create message for cancelling an in progress backup
> ---
>
> Key: GEODE-4442
> URL: https://issues.apache.org/jira/browse/GEODE-4442
> Project: Geode
>  Issue Type: Sub-task
>  Components: persistence
>Reporter: Nick Reich
>Assignee: Nick Reich
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.5.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Currently, the final message involved in backups contains an abort flag that 
> is the only way to cancel the backup. We should allow a way to try and halt 
> an in progress backup by splitting out the abort logic from the existing 
> message into a new message.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-4442) Create message for cancelling an in progress backup

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-4442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352979#comment-16352979
 ] 

ASF subversion and git services commented on GEODE-4442:


Commit e9b4bd5ae03acb062840ed33c03353db9bfd24d7 in geode's branch 
refs/heads/develop from [~nreich]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=e9b4bd5 ]

GEODE-4442: Move abort of backups to separate message (#1381)



> Create message for cancelling an in progress backup
> ---
>
> Key: GEODE-4442
> URL: https://issues.apache.org/jira/browse/GEODE-4442
> Project: Geode
>  Issue Type: Sub-task
>  Components: persistence
>Reporter: Nick Reich
>Assignee: Nick Reich
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Currently, the final message involved in backups contains an abort flag that 
> is the only way to cancel the backup. We should allow a way to try and halt 
> an in progress backup by splitting out the abort logic from the existing 
> message into a new message.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (GEODE-4598) Make LRUListWithAsyncSorting the default LRU list

[Nick Reich (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nick Reich reassigned GEODE-4598:
-

Assignee: Nick Reich

> Make LRUListWithAsyncSorting the default LRU list
> -
>
> Key: GEODE-4598
> URL: https://issues.apache.org/jira/browse/GEODE-4598
> Project: Geode
>  Issue Type: Bug
>  Components: eviction
>Reporter: Nick Reich
>Assignee: Nick Reich
>Priority: Major
>
> The new LRUListWithAsyncSorting should become the new default (replacing the 
> old algorithm) and the experimental tag should be removed from its properties.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (GEODE-4598) Make LRUListWithAsyncSorting the default LRU list

[Nick Reich (JIRA)]

Nick Reich created GEODE-4598:
-

 Summary: Make LRUListWithAsyncSorting the default LRU list
 Key: GEODE-4598
 URL: https://issues.apache.org/jira/browse/GEODE-4598
 Project: Geode
  Issue Type: Bug
  Components: eviction
Reporter: Nick Reich


The new LRUListWithAsyncSorting should become the new default (replacing the 
old algorithm) and the experimental tag should be removed from its properties.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (GEODE-4597) RemoteRemoveAllMessage and RemotePutAllMessage should not use a partitioned region class

[Darrel Schneider (JIRA)]

Darrel Schneider created GEODE-4597:
---

 Summary: RemoteRemoveAllMessage and RemotePutAllMessage should not 
use a partitioned region class
 Key: GEODE-4597
 URL: https://issues.apache.org/jira/browse/GEODE-4597
 Project: Geode
  Issue Type: Improvement
  Components: transactions
Reporter: Darrel Schneider


 The RemoteRemoveAllMessage and RemotePutAllMessage implement removeAll/putAll 
for transactions on non-partitioned classes. But they call a static method 
(getEventForEntry) on RemoveAllPRMessage/PutAllPRMessage which is a messaged 
used for partitioned regions.

This code should be refactored so that the common getEventForEntry is not in a 
class dedicated to a specific type of region.

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (GEODE-4596) Remove internal.cache.execute.TestFunction

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated GEODE-4596:
--
Labels: pull-request-available  (was: )

> Remove internal.cache.execute.TestFunction
> --
>
> Key: GEODE-4596
> URL: https://issues.apache.org/jira/browse/GEODE-4596
> Project: Geode
>  Issue Type: Improvement
>  Components: functions, tests
>Reporter: Galen O'Sullivan
>Assignee: Galen O'Sullivan
>Priority: Trivial
>  Labels: pull-request-available
>
> It looks like this particular TestFunction isn't actually used in the code, 
> so I'm going to remove it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-2542) LocatorDUnitTest and LocatorUDPSecurityDUnitTest fail frequently in Geode Nightly Build

[Galen O'Sullivan (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352949#comment-16352949
 ] 

Galen O'Sullivan commented on GEODE-2542:
-

Failed again today in 
https://concourse.apachegeode-ci.info/teams/main/pipelines/develop/jobs/FlakyTest/builds/182

> LocatorDUnitTest and LocatorUDPSecurityDUnitTest fail frequently in Geode 
> Nightly Build
> ---
>
> Key: GEODE-2542
> URL: https://issues.apache.org/jira/browse/GEODE-2542
> Project: Geode
>  Issue Type: Bug
>  Components: locator
>Reporter: Kirk Lund
>Priority: Major
>  Labels: Flaky
>
> testMultipleLocators:
> {noformat}
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.test.dunit.NamedRunnable.run in VM 0 running on Host 
> asf919.gq1.ygridcore.net with 5 VMs
>   at org.apache.geode.test.dunit.VM.invoke(VM.java:377)
>   at org.apache.geode.test.dunit.VM.invoke(VM.java:347)
>   at org.apache.geode.test.dunit.VM.invoke(VM.java:280)
>   at 
> org.apache.geode.distributed.LocatorDUnitTest.testMultipleLocators(LocatorDUnitTest.java:1567)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
>   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
>   at 
> org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
>   at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
>   at 
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> 

[jira] [Resolved] (GEODE-4542) Remove singleton calls from product code in org.apache.geode.internal.offheap

[Darrel Schneider (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darrel Schneider resolved GEODE-4542.
-
   Resolution: Fixed
Fix Version/s: 1.5.0

> Remove singleton calls from product code in org.apache.geode.internal.offheap
> -
>
> Key: GEODE-4542
> URL: https://issues.apache.org/jira/browse/GEODE-4542
> Project: Geode
>  Issue Type: Sub-task
>  Components: offheap
>Reporter: Kirk Lund
>Assignee: Darrel Schneider
>Priority: Major
> Fix For: 1.5.0
>
>
> These product classes in org.apache.geode.internal.offheap invoke singleton 
> getters.
> GemFireCacheImpl.getForPdx(String):
> * DataType



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (GEODE-4487) Remove singleton calls from all tests in org.apache.geode.internal.offheap

[Darrel Schneider (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darrel Schneider resolved GEODE-4487.
-
   Resolution: Fixed
Fix Version/s: 1.5.0

> Remove singleton calls from all tests in org.apache.geode.internal.offheap
> --
>
> Key: GEODE-4487
> URL: https://issues.apache.org/jira/browse/GEODE-4487
> Project: Geode
>  Issue Type: Sub-task
>  Components: offheap, tests
>Reporter: Kirk Lund
>Assignee: Darrel Schneider
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.5.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> These tests in org.apache.geode.internal.offheap invoke singleton getters.
> GemFireCacheImpl.getInstance():
> * OutOfOffHeapMemoryDUnitTest
> GemFireCacheImpl.getForPdx(String):
> * DataTypeJUnitTest
> InternalDistributedSystem.getAnyInstance():
> * OutOfOffHeapMemoryDUnitTest



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-4487) Remove singleton calls from all tests in org.apache.geode.internal.offheap

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352947#comment-16352947
 ] 

ASF subversion and git services commented on GEODE-4487:


Commit c36a11356efac2ca942fac97f27e39d47a496ede in geode's branch 
refs/heads/develop from [~dschneider]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=c36a113 ]

GEODE-4487: Remove singleton calls from offheap package (#1382)

One test was using the singletons just to confirm the cache had been shutdown. 
It was easy to change that test to not confirm the singleton was null but to 
instead ask if the test's cache was closed.

The other test was testing DataType which is product code that is only used by 
tests to inspect what is stored in offheap memory. The test was mocking the 
singleton methods because the product DataType was using the singleton to 
decode a serialized PDX. I changed DataType to just do less decoding of pdx. 
Now it will just say it was a pdx and give you the type number.


> Remove singleton calls from all tests in org.apache.geode.internal.offheap
> --
>
> Key: GEODE-4487
> URL: https://issues.apache.org/jira/browse/GEODE-4487
> Project: Geode
>  Issue Type: Sub-task
>  Components: offheap, tests
>Reporter: Kirk Lund
>Assignee: Darrel Schneider
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.5.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> These tests in org.apache.geode.internal.offheap invoke singleton getters.
> GemFireCacheImpl.getInstance():
> * OutOfOffHeapMemoryDUnitTest
> GemFireCacheImpl.getForPdx(String):
> * DataTypeJUnitTest
> InternalDistributedSystem.getAnyInstance():
> * OutOfOffHeapMemoryDUnitTest



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (GEODE-4596) Remove internal.cache.execute.TestFunction

[Galen O'Sullivan (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Galen O'Sullivan reassigned GEODE-4596:
---

Assignee: Galen O'Sullivan

> Remove internal.cache.execute.TestFunction
> --
>
> Key: GEODE-4596
> URL: https://issues.apache.org/jira/browse/GEODE-4596
> Project: Geode
>  Issue Type: Improvement
>  Components: functions, tests
>Reporter: Galen O'Sullivan
>Assignee: Galen O'Sullivan
>Priority: Trivial
>
> It looks like this particular TestFunction isn't actually used in the code, 
> so I'm going to remove it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (GEODE-4596) Remove internal.cache.execute.TestFunction

[Galen O'Sullivan (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Galen O'Sullivan updated GEODE-4596:

Priority: Trivial  (was: Major)

> Remove internal.cache.execute.TestFunction
> --
>
> Key: GEODE-4596
> URL: https://issues.apache.org/jira/browse/GEODE-4596
> Project: Geode
>  Issue Type: Improvement
>  Components: functions, tests
>Reporter: Galen O'Sullivan
>Priority: Trivial
>
> It looks like this particular TestFunction isn't actually used in the code, 
> so I'm going to remove it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (GEODE-4596) Remove internal.cache.executeTestFunction

[Galen O'Sullivan (JIRA)]

Galen O'Sullivan created GEODE-4596:
---

 Summary: Remove internal.cache.executeTestFunction
 Key: GEODE-4596
 URL: https://issues.apache.org/jira/browse/GEODE-4596
 Project: Geode
  Issue Type: Improvement
  Components: functions, tests
Reporter: Galen O'Sullivan


It looks like this particular TestFunction isn't actually used in the code, so 
I'm going to remove it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (GEODE-4596) Remove internal.cache.execute.TestFunction

[Galen O'Sullivan (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Galen O'Sullivan updated GEODE-4596:

Summary: Remove internal.cache.execute.TestFunction  (was: Remove 
internal.cache.executeTestFunction)

> Remove internal.cache.execute.TestFunction
> --
>
> Key: GEODE-4596
> URL: https://issues.apache.org/jira/browse/GEODE-4596
> Project: Geode
>  Issue Type: Improvement
>  Components: functions, tests
>Reporter: Galen O'Sullivan
>Priority: Major
>
> It looks like this particular TestFunction isn't actually used in the code, 
> so I'm going to remove it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (GEODE-4595) AnalyzeSerializablesJUnitTest fails to detect removal of toData/fromData methods

[Bruce Schuchardt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bruce Schuchardt updated GEODE-4595:

Issue Type: Test  (was: Improvement)

> AnalyzeSerializablesJUnitTest fails to detect removal of toData/fromData 
> methods
> 
>
> Key: GEODE-4595
> URL: https://issues.apache.org/jira/browse/GEODE-4595
> Project: Geode
>  Issue Type: Test
>  Components: serialization
>Reporter: Bruce Schuchardt
>Priority: Major
>
> Nick just came to me with an interesting situation.  He had created a new 
> DataSerializable message class that AnalyzeSerializables didn't notice.  He 
> had also removed the toData/fromData from a message that no longer had any 
> state.  AnalyzeSerializables also didn't detect this change.
> The test currently looks for any class that implements fromData/toData and 
> looks for changes to those methods.  Clearly it also needs to look for 
> implementations that don't have toData/fromData methods.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-4509) change the InternalCache interface to use InternalRegion instead of LocalRegion

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-4509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352938#comment-16352938
 ] 

ASF subversion and git services commented on GEODE-4509:


Commit 158992b474e1c94bab64c7cbb127cdce4a643bdb in geode's branch 
refs/heads/develop from [~dschneider]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=158992b ]

GEODE-4509: change uses of LocalRegion to InternalRegion (#1379)

* changed to use InternalRegion

* changed cast of LocalRegion to InternalRegion

The following classes/interfaces have been changed to use InternalRegion 
instead of LocalRegion:
InternalCache, ClientMetaDataService, ClientRegionFactoryImpl, RegionFactory, 
RequiredRoles, MemoryAllocatorImpl, and CacheStatisticsImpl

> change the InternalCache interface to use InternalRegion instead of 
> LocalRegion
> ---
>
> Key: GEODE-4509
> URL: https://issues.apache.org/jira/browse/GEODE-4509
> Project: Geode
>  Issue Type: Improvement
>  Components: regions
>Reporter: Darrel Schneider
>Assignee: Darrel Schneider
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.5.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> The InternalCache interface should not expose or use LocalRegion. It should 
> use InternalRegion instead.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (GEODE-4509) change the InternalCache interface to use InternalRegion instead of LocalRegion

[Darrel Schneider (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darrel Schneider resolved GEODE-4509.
-
   Resolution: Fixed
Fix Version/s: 1.5.0

> change the InternalCache interface to use InternalRegion instead of 
> LocalRegion
> ---
>
> Key: GEODE-4509
> URL: https://issues.apache.org/jira/browse/GEODE-4509
> Project: Geode
>  Issue Type: Improvement
>  Components: regions
>Reporter: Darrel Schneider
>Assignee: Darrel Schneider
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.5.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> The InternalCache interface should not expose or use LocalRegion. It should 
> use InternalRegion instead.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (GEODE-4595) AnalyzeSerializablesJUnitTest fails to detect removal of toData/fromData methods

[Bruce Schuchardt (JIRA)]

Bruce Schuchardt created GEODE-4595:
---

 Summary: AnalyzeSerializablesJUnitTest fails to detect removal of 
toData/fromData methods
 Key: GEODE-4595
 URL: https://issues.apache.org/jira/browse/GEODE-4595
 Project: Geode
  Issue Type: Improvement
  Components: serialization
Reporter: Bruce Schuchardt


Nick just came to me with an interesting situation.  He had created a new 
DataSerializable message class that AnalyzeSerializables didn't notice.  He had 
also removed the toData/fromData from a message that no longer had any state.  
AnalyzeSerializables also didn't detect this change.

The test currently looks for any class that implements fromData/toData and 
looks for changes to those methods.  Clearly it also needs to look for 
implementations that don't have toData/fromData methods.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (GEODE-4594) CI failure: org.apache.geode.internal.cache.wan.asyncqueue.AsyncEventQueueStatsDUnitTest testReplicatedSerialPropagation hangs during CI

[Shelley Lynn Hughes-Godfrey (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shelley Lynn Hughes-Godfrey updated GEODE-4594:
---
Labels: CI  (was: )

> CI failure: 
> org.apache.geode.internal.cache.wan.asyncqueue.AsyncEventQueueStatsDUnitTest 
> testReplicatedSerialPropagation hangs during CI
> 
>
> Key: GEODE-4594
> URL: https://issues.apache.org/jira/browse/GEODE-4594
> Project: Geode
>  Issue Type: Bug
>  Components: wan
>Affects Versions: 1.5.0
>Reporter: Shelley Lynn Hughes-Godfrey
>Priority: Major
>  Labels: CI
>
> This test did not complete in over an hour during CI:
> https://concourse.apachegeode-ci.info/teams/main/pipelines/develop/jobs/DistributedTest/builds/118
> Output from progress utility:
> {noformat}
> Started @ 2018-02-02 23:25:13.754 +
> 2018-02-03 00:22:22.836 +  
> org.apache.geode.internal.cache.wan.asyncqueue.AsyncEventQueueStatsDUnitTest 
> testReplicatedSerialPropagation
> Ended @ 2018-02-03 01:35:46.907 +
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (GEODE-4378) PersistentRecoveryOrderDUnitTest testCrashDuringPreparePersistentId fails with IllegalStateException

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund reassigned GEODE-4378:


Assignee: (was: Kirk Lund)

> PersistentRecoveryOrderDUnitTest testCrashDuringPreparePersistentId fails 
> with IllegalStateException
> 
>
> Key: GEODE-4378
> URL: https://issues.apache.org/jira/browse/GEODE-4378
> Project: Geode
>  Issue Type: Bug
>  Components: persistence
>Reporter: Darrel Schneider
>Priority: Major
>  Labels: CI, flaky
>
> {noformat}
> org.apache.geode.internal.cache.persistence.PersistentRecoveryOrderDUnitTest 
> > testCrashDuringPreparePersistentId FAILED
>     java.lang.RuntimeException: java.lang.IllegalStateException: Disk store 
> PersistentRecoveryOrderDUnitTest_testCrashDuringPreparePersistentIdRegion not 
> found
>         at 
> org.apache.geode.internal.cache.persistence.PersistentReplicatedTestBase._createPersistentRegion(PersistentReplicatedTestBase.java:186)
>         at 
> org.apache.geode.internal.cache.persistence.PersistentReplicatedTestBase.createPersistentRegion(PersistentReplicatedTestBase.java:172)
>         at 
> org.apache.geode.internal.cache.persistence.PersistentRecoveryOrderDUnitTest.testCrashDuringPreparePersistentId(PersistentRecoveryOrderDUnitTest.java:1336)
>  
>         Caused by:
>         java.lang.IllegalStateException: Disk store 
> PersistentRecoveryOrderDUnitTest_testCrashDuringPreparePersistentIdRegion not 
> found
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (GEODE-4594) CI failure: org.apache.geode.internal.cache.wan.asyncqueue.AsyncEventQueueStatsDUnitTest testReplicatedSerialPropagation hangs during CI

[Shelley Lynn Hughes-Godfrey (JIRA)]

Shelley Lynn Hughes-Godfrey created GEODE-4594:
--

 Summary: CI failure: 
org.apache.geode.internal.cache.wan.asyncqueue.AsyncEventQueueStatsDUnitTest 
testReplicatedSerialPropagation hangs during CI
 Key: GEODE-4594
 URL: https://issues.apache.org/jira/browse/GEODE-4594
 Project: Geode
  Issue Type: Bug
  Components: wan
Reporter: Shelley Lynn Hughes-Godfrey


This test did not complete in over an hour during CI:
https://concourse.apachegeode-ci.info/teams/main/pipelines/develop/jobs/DistributedTest/builds/118

Output from progress utility:
{noformat}
Started @ 2018-02-02 23:25:13.754 +
2018-02-03 00:22:22.836 +  
org.apache.geode.internal.cache.wan.asyncqueue.AsyncEventQueueStatsDUnitTest 
testReplicatedSerialPropagation
Ended @ 2018-02-03 01:35:46.907 +
{noformat}




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (GEODE-4594) CI failure: org.apache.geode.internal.cache.wan.asyncqueue.AsyncEventQueueStatsDUnitTest testReplicatedSerialPropagation hangs during CI

[Shelley Lynn Hughes-Godfrey (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shelley Lynn Hughes-Godfrey updated GEODE-4594:
---
Affects Version/s: 1.5.0

> CI failure: 
> org.apache.geode.internal.cache.wan.asyncqueue.AsyncEventQueueStatsDUnitTest 
> testReplicatedSerialPropagation hangs during CI
> 
>
> Key: GEODE-4594
> URL: https://issues.apache.org/jira/browse/GEODE-4594
> Project: Geode
>  Issue Type: Bug
>  Components: wan
>Affects Versions: 1.5.0
>Reporter: Shelley Lynn Hughes-Godfrey
>Priority: Major
>
> This test did not complete in over an hour during CI:
> https://concourse.apachegeode-ci.info/teams/main/pipelines/develop/jobs/DistributedTest/builds/118
> Output from progress utility:
> {noformat}
> Started @ 2018-02-02 23:25:13.754 +
> 2018-02-03 00:22:22.836 +  
> org.apache.geode.internal.cache.wan.asyncqueue.AsyncEventQueueStatsDUnitTest 
> testReplicatedSerialPropagation
> Ended @ 2018-02-03 01:35:46.907 +
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (GEODE-4202) PartitionedRegion should not invoke GemFireCacheImpl.getInstance

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund resolved GEODE-4202.
--
   Resolution: Fixed
Fix Version/s: 1.5.0

> PartitionedRegion should not invoke GemFireCacheImpl.getInstance
> 
>
> Key: GEODE-4202
> URL: https://issues.apache.org/jira/browse/GEODE-4202
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>Priority: Major
> Fix For: 1.5.0
>
>
> PartitionedRegion should not invoke GemFireCacheImpl.getInstance



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (GEODE-4577) Remove singleton calls from product code in org.apache.geode.internal.tcp

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4577:
-
Description: 
These product classes in org.apache.geode.internal.tcp invoke singleton getters.

InternalDistributedSystem.getAnyInstance():
* ConnectionTable

InternalDistributedSystem.unsafeGetConnectedInstance():
* MsgDestreamer

  was:
These product classes in org.apache.geode.internal.tcp invoke singleton getters.

InternalDistributedSystem.getAnyInstance():
* ConnectionTable


> Remove singleton calls from product code in org.apache.geode.internal.tcp
> -
>
> Key: GEODE-4577
> URL: https://issues.apache.org/jira/browse/GEODE-4577
> Project: Geode
>  Issue Type: Sub-task
>  Components: messaging
>Reporter: Kirk Lund
>Priority: Major
>
> These product classes in org.apache.geode.internal.tcp invoke singleton 
> getters.
> InternalDistributedSystem.getAnyInstance():
> * ConnectionTable
> InternalDistributedSystem.unsafeGetConnectedInstance():
> * MsgDestreamer



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (GEODE-4572) SerializationRegistry::addType and similar functions should return std::shared_ptr

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated GEODE-4572:
--
Labels: pull-request-available  (was: )

> SerializationRegistry::addType and similar functions should return 
> std::shared_ptr
> --
>
> Key: GEODE-4572
> URL: https://issues.apache.org/jira/browse/GEODE-4572
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Jacob S. Barrett
>Priority: Major
>  Labels: pull-request-available
>
> Currently these functions return a raw pointer. Returning a std::shared_ptr 
> reduces the chance for memory leaks and improves performance given that all 
> use cases resulted in the raw pointer being wrapped later in std::shared_ptr.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-4423) Convert PdxFieldTypes to enum class

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352882#comment-16352882
 ] 

ASF subversion and git services commented on GEODE-4423:


Commit 2a1e0660522f00df8b261e38861f90a211a03898 in geode-native's branch 
refs/heads/develop from Jacob Barrett
[ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=2a1e066 ]

GEODE-4423: Fixes warning introduced after Solaris fix.


> Convert PdxFieldTypes to enum class
> ---
>
> Key: GEODE-4423
> URL: https://issues.apache.org/jira/browse/GEODE-4423
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Jacob S. Barrett
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (GEODE-4523) Remove singleton calls from core product code in org.apache.geode.internal

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4523:
-
Description: 
These product classes in org.apache.geode.internal invoke singleton getters.

CacheFactory.getAnyInstance():
* DeployedJar (core)

InternalDistributedSystem.getConnectedInstance():
* SystemAdmin

  was:
These product classes in org.apache.geode.internal invoke singleton getters.

CacheFactory.getAnyInstance():
* DeployedJar (core)



> Remove singleton calls from core product code in org.apache.geode.internal
> --
>
> Key: GEODE-4523
> URL: https://issues.apache.org/jira/browse/GEODE-4523
> Project: Geode
>  Issue Type: Sub-task
>  Components: core
>Reporter: Kirk Lund
>Priority: Major
>
> These product classes in org.apache.geode.internal invoke singleton getters.
> CacheFactory.getAnyInstance():
> * DeployedJar (core)
> InternalDistributedSystem.getConnectedInstance():
> * SystemAdmin



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (GEODE-4593) MigrationClient and MigrationServer classes should be removed

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund reassigned GEODE-4593:


Assignee: Kirk Lund

> MigrationClient and MigrationServer classes should be removed
> -
>
> Key: GEODE-4593
> URL: https://issues.apache.org/jira/browse/GEODE-4593
> Project: Geode
>  Issue Type: Improvement
>  Components: core
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>Priority: Major
>
> The MigrationClient and MigrationServer classes in org.apache.geode.internal 
> are no longer used and should be removed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (GEODE-4593) MigrationClient and MigrationServer classes should be removed

[Kirk Lund (JIRA)]

Kirk Lund created GEODE-4593:


 Summary: MigrationClient and MigrationServer classes should be 
removed
 Key: GEODE-4593
 URL: https://issues.apache.org/jira/browse/GEODE-4593
 Project: Geode
  Issue Type: Improvement
  Components: core
Reporter: Kirk Lund


The MigrationClient and MigrationServer classes in org.apache.geode.internal 
are no longer used and should be removed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (GEODE-4543) Remove singleton calls from serialization product code in org.apache.geode.internal

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4543:
-
Description: 
These serialization product classes in org.apache.geode.internal invoke 
singleton getters.

GemFireCacheImpl.getForPdx(String):
* InternalDataSerializer (serialization)

GemFireCacheImpl.getInstance():
* InternalInstantiator

InternalDistributedSystem.getAnyInstance():
* InternalDataSerializer
* InternalInstantiator

InternalDistributedSystem.getConnectedInstance():
* InternalDataSerializer

  was:
These serialization product classes in org.apache.geode.internal invoke 
singleton getters.

GemFireCacheImpl.getForPdx(String):
* InternalDataSerializer (serialization)

GemFireCacheImpl.getInstance():
* InternalInstantiator

InternalDistributedSystem.getAnyInstance():
* InternalDataSerializer
* InternalInstantiator


> Remove singleton calls from serialization product code in 
> org.apache.geode.internal
> ---
>
> Key: GEODE-4543
> URL: https://issues.apache.org/jira/browse/GEODE-4543
> Project: Geode
>  Issue Type: Sub-task
>  Components: serialization
>Reporter: Kirk Lund
>Priority: Major
>
> These serialization product classes in org.apache.geode.internal invoke 
> singleton getters.
> GemFireCacheImpl.getForPdx(String):
> * InternalDataSerializer (serialization)
> GemFireCacheImpl.getInstance():
> * InternalInstantiator
> InternalDistributedSystem.getAnyInstance():
> * InternalDataSerializer
> * InternalInstantiator
> InternalDistributedSystem.getConnectedInstance():
> * InternalDataSerializer



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (GEODE-4592) Remove singleton calls from product code in org.apache.geode.internal.cache.tier.sockets.commandorg.apache.geode.distributed.internal.membership.gms.fd

[Kirk Lund (JIRA)]

Kirk Lund created GEODE-4592:


 Summary: Remove singleton calls from product code in 
org.apache.geode.internal.cache.tier.sockets.commandorg.apache.geode.distributed.internal.membership.gms.fd
 Key: GEODE-4592
 URL: https://issues.apache.org/jira/browse/GEODE-4592
 Project: Geode
  Issue Type: Sub-task
  Components: membership
Reporter: Kirk Lund


These product classes in 
org.apache.geode.distributed.internal.membership.gms.fd invoke singleton 
getters.

InternalDistributedSystem.getConnectedInstance():
* GMSHealthMonitor



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (GEODE-4591) Remove singleton calls from product code in org.apache.geode.cache.execute

[Kirk Lund (JIRA)]

Kirk Lund created GEODE-4591:


 Summary: Remove singleton calls from product code in 
org.apache.geode.cache.execute
 Key: GEODE-4591
 URL: https://issues.apache.org/jira/browse/GEODE-4591
 Project: Geode
  Issue Type: Sub-task
  Components: functions
Reporter: Kirk Lund


These product classes in org.apache.geode.cache.execute invoke singleton 
getters.

InternalDistributedSystem.getConnectedInstance():
* FunctionService



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (GEODE-4540) Remove singleton calls from product code in org.apache.geode.internal.cache.tier.sockets.command

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4540:
-
Description: 
These product classes in org.apache.geode.internal.cache.tier.sockets.command 
invoke singleton getters.

GemFireCacheImpl.getExisting(String):
* ExecuteFunction66

InternalDistributedSystem.getConnectedInstance():
* ExecuteFunction70

  was:
These product classes in org.apache.geode.internal.cache.tier.sockets.command 
invoke singleton getters.

GemFireCacheImpl.getExisting(String):
* ExecuteFunction66


> Remove singleton calls from product code in 
> org.apache.geode.internal.cache.tier.sockets.command
> 
>
> Key: GEODE-4540
> URL: https://issues.apache.org/jira/browse/GEODE-4540
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server
>Reporter: Kirk Lund
>Priority: Major
>
> These product classes in org.apache.geode.internal.cache.tier.sockets.command 
> invoke singleton getters.
> GemFireCacheImpl.getExisting(String):
> * ExecuteFunction66
> InternalDistributedSystem.getConnectedInstance():
> * ExecuteFunction70



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (GEODE-4540) Remove singleton calls from product code in org.apache.geode.internal.cache.tier.sockets.command

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4540:
-
Description: 
These product classes in org.apache.geode.internal.cache.tier.sockets.command 
invoke singleton getters.

GemFireCacheImpl.getExisting(String):
* ExecuteFunction66

InternalDistributedSystem.getConnectedInstance():
* ExecuteFunction70
* TXSynchronizationCommand

  was:
These product classes in org.apache.geode.internal.cache.tier.sockets.command 
invoke singleton getters.

GemFireCacheImpl.getExisting(String):
* ExecuteFunction66

InternalDistributedSystem.getConnectedInstance():
* ExecuteFunction70


> Remove singleton calls from product code in 
> org.apache.geode.internal.cache.tier.sockets.command
> 
>
> Key: GEODE-4540
> URL: https://issues.apache.org/jira/browse/GEODE-4540
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server
>Reporter: Kirk Lund
>Priority: Major
>
> These product classes in org.apache.geode.internal.cache.tier.sockets.command 
> invoke singleton getters.
> GemFireCacheImpl.getExisting(String):
> * ExecuteFunction66
> InternalDistributedSystem.getConnectedInstance():
> * ExecuteFunction70
> * TXSynchronizationCommand



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (GEODE-4553) Remove singleton calls from product code in org.apache.geode.distributed.internal

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4553:
-
Description: 
These product classes in org.apache.geode.distributed.internal invoke singleton 
getters.

GemFireCacheImpl.getInstance():
* DSClock
* DSClock$CacheTimeTask
* InternalDistributedSystem
* InternalLocator

InternalDistributedSystem.getAnyInstance():
* DistributionMessage
* HighPriorityAckedMessage
* InternalDistributedSystem
* InternalLocator
* SerialAckedMessage

InternalDistributedSystem.getConnectedInstance():
* DistributionConfigImpl
* InternalLocator


  was:
These product classes in org.apache.geode.distributed.internal invoke singleton 
getters.

GemFireCacheImpl.getInstance():
* DSClock
* DSClock$CacheTimeTask
* InternalDistributedSystem
* InternalLocator

InternalDistributedSystem.getAnyInstance():
* DistributionMessage
* HighPriorityAckedMessage
* InternalDistributedSystem
* InternalLocator
* SerialAckedMessage



> Remove singleton calls from product code in 
> org.apache.geode.distributed.internal
> -
>
> Key: GEODE-4553
> URL: https://issues.apache.org/jira/browse/GEODE-4553
> Project: Geode
>  Issue Type: Sub-task
>  Components: membership
>Reporter: Kirk Lund
>Priority: Major
>
> These product classes in org.apache.geode.distributed.internal invoke 
> singleton getters.
> GemFireCacheImpl.getInstance():
> * DSClock
> * DSClock$CacheTimeTask
> * InternalDistributedSystem
> * InternalLocator
> InternalDistributedSystem.getAnyInstance():
> * DistributionMessage
> * HighPriorityAckedMessage
> * InternalDistributedSystem
> * InternalLocator
> * SerialAckedMessage
> InternalDistributedSystem.getConnectedInstance():
> * DistributionConfigImpl
> * InternalLocator



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (GEODE-4590) Remove singleton calls from product code in org.apache.geode.internal.util.concurrent

[Kirk Lund (JIRA)]

Kirk Lund created GEODE-4590:


 Summary: Remove singleton calls from product code in 
org.apache.geode.internal.util.concurrent
 Key: GEODE-4590
 URL: https://issues.apache.org/jira/browse/GEODE-4590
 Project: Geode
  Issue Type: Sub-task
  Components: regions
Reporter: Kirk Lund


These product classes in org.apache.geode.internal.util.concurrent invoke 
singleton getters.

InternalDistributedSystem.getConnectedInstance():
* CustomEntryConcurrentHashMap



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (GEODE-4547) Remove singleton calls from product code in org.apache.geode.cache

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4547:
-
Description: 
These product classes in org.apache.geode.cache invoke singleton getters.

GemFireCacheImpl.getInstance():
* CacheFactory

InternalDistributedSystem.getConnectedInstance():
* CacheFactory

  was:
These product classes in org.apache.geode.cache invoke singleton getters.

GemFireCacheImpl.getInstance():
* CacheFactory


> Remove singleton calls from product code in org.apache.geode.cache
> --
>
> Key: GEODE-4547
> URL: https://issues.apache.org/jira/browse/GEODE-4547
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Kirk Lund
>Priority: Major
>
> These product classes in org.apache.geode.cache invoke singleton getters.
> GemFireCacheImpl.getInstance():
> * CacheFactory
> InternalDistributedSystem.getConnectedInstance():
> * CacheFactory



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (GEODE-4589) Remove singleton calls from launcher product code in org.apache.geode.cache.client.internal

[Kirk Lund (JIRA)]

Kirk Lund created GEODE-4589:


 Summary: Remove singleton calls from launcher product code in 
org.apache.geode.cache.client.internal
 Key: GEODE-4589
 URL: https://issues.apache.org/jira/browse/GEODE-4589
 Project: Geode
  Issue Type: Sub-task
  Components: client/server, security
Reporter: Kirk Lund


These security product classes in org.apache.geode.cache.client.internal invoke 
singleton getters.

InternalDistributedSystem.getConnectedInstance():
* AuthenticateUserOp$AuthenticateUserOpImpl



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (GEODE-4546) Remove singleton calls from product code in org.apache.geode.internal.cache.tier.sockets

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4546:
-
Description: 
[NOTE: I'm not sure if these classes are client/server or client-queues.]

These product classes in org.apache.geode.internal.cache.tier.sockets invoke 
singleton getters.

GemFireCacheImpl.getInstance():
* CacheClientNotifier
* CacheClientUpdater

InternalDistributedSystem.getAnyInstance():
* CacheServerStats
* MessageDispatcher
* ServerHandShakeProcessor

InternalDistributedSystem.getConnectedInstance():
* AcceptorImpl
* VersionedObjectList

  was:
[NOTE: I'm not sure if these classes are client/server or client-queues.]

These product classes in org.apache.geode.internal.cache.tier.sockets invoke 
singleton getters.

GemFireCacheImpl.getInstance():
* CacheClientNotifier
* CacheClientUpdater

InternalDistributedSystem.getAnyInstance():
* CacheServerStats
* MessageDispatcher
* ServerHandShakeProcessor


> Remove singleton calls from product code in 
> org.apache.geode.internal.cache.tier.sockets
> 
>
> Key: GEODE-4546
> URL: https://issues.apache.org/jira/browse/GEODE-4546
> Project: Geode
>  Issue Type: Sub-task
>  Components: client queues, client/server
>Reporter: Kirk Lund
>Priority: Major
>
> [NOTE: I'm not sure if these classes are client/server or client-queues.]
> These product classes in org.apache.geode.internal.cache.tier.sockets invoke 
> singleton getters.
> GemFireCacheImpl.getInstance():
> * CacheClientNotifier
> * CacheClientUpdater
> InternalDistributedSystem.getAnyInstance():
> * CacheServerStats
> * MessageDispatcher
> * ServerHandShakeProcessor
> InternalDistributedSystem.getConnectedInstance():
> * AcceptorImpl
> * VersionedObjectList



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (GEODE-4571) Remove singleton calls from launcher product code in org.apache.geode.distributed

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4571:
-
Description: 
[NOTE: launcher code is for gfsh launching of server and locator processes.]

These launcher product classes in org.apache.geode.distributed invoke singleton 
getters.

GemFireCacheImpl.getInstance():
* ServerLauncher$ServerState

InternalDistributedSystem.getAnyInstance():
* ServerLauncher$ServerState

InternalDistributedSystem.getConnectedInstance():
* AbstractLauncher

  was:
[NOTE: launcher code is for gfsh launching of server and locator processes.]

These launcher product classes in org.apache.geode.distributed invoke singleton 
getters.

GemFireCacheImpl.getInstance():
* ServerLauncher$ServerState

InternalDistributedSystem.getAnyInstance():
* ServerLauncher$ServerState


> Remove singleton calls from launcher product code in 
> org.apache.geode.distributed
> -
>
> Key: GEODE-4571
> URL: https://issues.apache.org/jira/browse/GEODE-4571
> Project: Geode
>  Issue Type: Sub-task
>  Components: gfsh, management
>Reporter: Kirk Lund
>Priority: Major
>
> [NOTE: launcher code is for gfsh launching of server and locator processes.]
> These launcher product classes in org.apache.geode.distributed invoke 
> singleton getters.
> GemFireCacheImpl.getInstance():
> * ServerLauncher$ServerState
> InternalDistributedSystem.getAnyInstance():
> * ServerLauncher$ServerState
> InternalDistributedSystem.getConnectedInstance():
> * AbstractLauncher



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (GEODE-2334) Updated AssemblyInfo for all examples.

[Addison (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Addison closed GEODE-2334.
--

> Updated AssemblyInfo for all examples.
> --
>
> Key: GEODE-2334
> URL: https://issues.apache.org/jira/browse/GEODE-2334
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: Jacob S. Barrett
>Priority: Major
>
> Update AssembyInfo for all examples. Replace company and copyright 
> statements. 
> Reset version information to "0.0.0.0" since these are not binary release and 
> are meant as examples. They don't need to match versions with Geode.
> Remove COM section as we are not providing COM examples.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (GEODE-2334) Updated AssemblyInfo for all examples.

[Addison (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Addison resolved GEODE-2334.

Resolution: Invalid

This will be resolved by GEODE-4341

> Updated AssemblyInfo for all examples.
> --
>
> Key: GEODE-2334
> URL: https://issues.apache.org/jira/browse/GEODE-2334
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: Jacob S. Barrett
>Priority: Major
>
> Update AssembyInfo for all examples. Replace company and copyright 
> statements. 
> Reset version information to "0.0.0.0" since these are not binary release and 
> are meant as examples. They don't need to match versions with Geode.
> Remove COM section as we are not providing COM examples.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (GEODE-4588) Remove singleton calls from product code in org.apache.geode.internal.cache.locks

[Kirk Lund (JIRA)]

Kirk Lund created GEODE-4588:


 Summary: Remove singleton calls from product code in 
org.apache.geode.internal.cache.locks
 Key: GEODE-4588
 URL: https://issues.apache.org/jira/browse/GEODE-4588
 Project: Geode
  Issue Type: Sub-task
  Components: transactions
Reporter: Kirk Lund


These product classes in org.apache.geode.internal.cache.locks invoke singleton 
getters.

InternalDistributedSystem.getAnyInstance():
* TXLockServiceImpl



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (GEODE-4587) Remove singleton calls from product code in org.apache.geode.internal.net

[Kirk Lund (JIRA)]

Kirk Lund created GEODE-4587:


 Summary: Remove singleton calls from product code in 
org.apache.geode.internal.net
 Key: GEODE-4587
 URL: https://issues.apache.org/jira/browse/GEODE-4587
 Project: Geode
  Issue Type: Sub-task
  Components: messaging
Reporter: Kirk Lund


These product classes in org.apache.geode.internal.net invoke singleton getters.

InternalDistributedSystem.getAnyInstance():
* SocketCreator



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (GEODE-4571) Remove singleton calls from launcher product code in org.apache.geode.distributed

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4571:
-
Description: 
[NOTE: launcher code is for gfsh launching of server and locator processes.]

These launcher product classes in org.apache.geode.distributed invoke singleton 
getters.

GemFireCacheImpl.getInstance():
* ServerLauncher$ServerState

InternalDistributedSystem.getAnyInstance():
* ServerLauncher$ServerState

  was:
[NOTE: launcher code is for gfsh launching of server and locator processes.]

These launcher product classes in org.apache.geode.distributed invoke singleton 
getters.

GemFireCacheImpl.getInstance():
* ServerLauncher$ServerState


> Remove singleton calls from launcher product code in 
> org.apache.geode.distributed
> -
>
> Key: GEODE-4571
> URL: https://issues.apache.org/jira/browse/GEODE-4571
> Project: Geode
>  Issue Type: Sub-task
>  Components: gfsh, management
>Reporter: Kirk Lund
>Priority: Major
>
> [NOTE: launcher code is for gfsh launching of server and locator processes.]
> These launcher product classes in org.apache.geode.distributed invoke 
> singleton getters.
> GemFireCacheImpl.getInstance():
> * ServerLauncher$ServerState
> InternalDistributedSystem.getAnyInstance():
> * ServerLauncher$ServerState



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (GEODE-4554) Remove singleton calls from product code in org.apache.geode.cache.client

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4554:
-
Description: 
These product classes in org.apache.geode.cache.client invoke singleton getters.

GemFireCacheImpl.getInstance():
* ClientCacheFactory

InternalDistributedSystem.getAnyInstance():
* ServerOperationException

  was:
These product classes in org.apache.geode.cache.client invoke singleton getters.

GemFireCacheImpl.getInstance():
* ClientCacheFactory



> Remove singleton calls from product code in org.apache.geode.cache.client
> -
>
> Key: GEODE-4554
> URL: https://issues.apache.org/jira/browse/GEODE-4554
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server
>Reporter: Kirk Lund
>Priority: Major
>
> These product classes in org.apache.geode.cache.client invoke singleton 
> getters.
> GemFireCacheImpl.getInstance():
> * ClientCacheFactory
> InternalDistributedSystem.getAnyInstance():
> * ServerOperationException



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (GEODE-4586) Remove singleton calls from product code in org.apache.geode.internal.cache.versions

[Kirk Lund (JIRA)]

Kirk Lund created GEODE-4586:


 Summary: Remove singleton calls from product code in 
org.apache.geode.internal.cache.versions
 Key: GEODE-4586
 URL: https://issues.apache.org/jira/browse/GEODE-4586
 Project: Geode
  Issue Type: Sub-task
  Components: regions
Reporter: Kirk Lund


These product classes in org.apache.geode.internal.cache.versions invoke 
singleton getters.

InternalDistributedSystem.getAnyInstance():
* RegionVersionVector



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (GEODE-4425) Refactor Properties to use std::unordered map.

[Addison (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Addison updated GEODE-4425:
---
Description: This will allow us to get further away from ACE.

> Refactor Properties to use std::unordered map.
> --
>
> Key: GEODE-4425
> URL: https://issues.apache.org/jira/browse/GEODE-4425
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Jacob S. Barrett
>Priority: Major
>
> This will allow us to get further away from ACE.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (GEODE-4449) Replace macro-templates with plain templates to allow better debugging

[Addison (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Addison updated GEODE-4449:
---
Summary: Replace macro-templates with plain templates to allow better 
debugging  (was: Replace macro-templates with plain templates)

> Replace macro-templates with plain templates to allow better debugging
> --
>
> Key: GEODE-4449
> URL: https://issues.apache.org/jira/browse/GEODE-4449
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: David Kimura
>Priority: Major
>
> Replace macro-templates in CacheableBuiltins.hpp from...
> _GEODE_CACHEABLE_ARRAY_TYPE_(int8_t, CacheableBytes);
> _GEODE_CACHEABLE_ARRAY_TYPE_(std::shared_ptr, 
> CacheableStringArray);
> into...
> using CacheableBytes = CacheableArray;
> using CacheableStringArray = CacheableArray GeodeTypeIds::CacheableStringArray>;
> It also makes the code debuggable since most debuggers can step through 
> templates, but not macros.  It also removes an unnecessary level of 
> indirection by the preprocessor.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (GEODE-4392) Code Cleanup: Remove catch blocks that immediate rethrow the caught exception.

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated GEODE-4392:
--
Labels: pull-request-available  (was: )

> Code Cleanup: Remove catch blocks that immediate rethrow the caught exception.
> --
>
> Key: GEODE-4392
> URL: https://issues.apache.org/jira/browse/GEODE-4392
> Project: Geode
>  Issue Type: Task
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>Priority: Trivial
>  Labels: pull-request-available
>
> Excepting, of course, any catch blocks that act as a prioritization for 
> throwing certain types of exceptions while suppressing a more general type.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (GEODE-4585) Remove singleton calls from product code in org.apache.geode.internal.cache.snapshot

[Kirk Lund (JIRA)]

Kirk Lund created GEODE-4585:


 Summary: Remove singleton calls from product code in 
org.apache.geode.internal.cache.snapshot
 Key: GEODE-4585
 URL: https://issues.apache.org/jira/browse/GEODE-4585
 Project: Geode
  Issue Type: Sub-task
  Components: snapshot
Reporter: Kirk Lund


These product classes in org.apache.geode.internal.cache.snapshot invoke 
singleton getters.

InternalDistributedSystem.getAnyInstance():
* RegionSnapshotServiceImpl



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (GEODE-4584) Remove singleton calls from product code in org.apache.geode.internal.protocol.protobuf.statistics

[Kirk Lund (JIRA)]

Kirk Lund created GEODE-4584:


 Summary: Remove singleton calls from product code in 
org.apache.geode.internal.protocol.protobuf.statistics
 Key: GEODE-4584
 URL: https://issues.apache.org/jira/browse/GEODE-4584
 Project: Geode
  Issue Type: Sub-task
  Components: client/server
Reporter: Kirk Lund


These product classes in org.apache.geode.internal.protocol.protobuf.statistics 
invoke singleton getters.

InternalDistributedSystem.getAnyInstance():
* ProtobufClientStatistics



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (GEODE-3915) supply arguments over gfsh while initializing Declarable

[Barbara Pruijn (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Barbara Pruijn updated GEODE-3915:
--
Fix Version/s: 1.5.0

> supply arguments over gfsh while initializing Declarable
> 
>
> Key: GEODE-3915
> URL: https://issues.apache.org/jira/browse/GEODE-3915
> Project: Geode
>  Issue Type: Sub-task
>  Components: docs, gfsh
>Reporter: Swapnil Bawaskar
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.5.0
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> User implementations of the Declarable interface may want to pass in 
> arguments while the class is being initialized. We should provide ability to 
> pass these arguments from gfsh. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (GEODE-3915) supply arguments over gfsh while initializing Declarable

[Barbara Pruijn (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Barbara Pruijn resolved GEODE-3915.
---
Resolution: Fixed

> supply arguments over gfsh while initializing Declarable
> 
>
> Key: GEODE-3915
> URL: https://issues.apache.org/jira/browse/GEODE-3915
> Project: Geode
>  Issue Type: Sub-task
>  Components: docs, gfsh
>Reporter: Swapnil Bawaskar
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.5.0
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> User implementations of the Declarable interface may want to pass in 
> arguments while the class is being initialized. We should provide ability to 
> pass these arguments from gfsh. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (GEODE-4534) Remove singleton calls from client/server product code in org.apache.geode.cache.client.internal

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4534:
-
Description: 
These client/server product classes in org.apache.geode.cache.client.internal 
invoke singleton getters.

CacheFactory.getAnyInstance():
* PoolImpl

CacheFactory.getInstance(DistributedSystem):
* PoolImpl

GemFireCacheImpl.getInstance():
* PingTask
* PoolImpl

InternalDistributedSystem.getAnyInstance():
* PoolImpl


  was:
These client/server product classes in org.apache.geode.cache.client.internal 
invoke singleton getters.

CacheFactory.getAnyInstance():
* PoolImpl

CacheFactory.getInstance(DistributedSystem):
* PoolImpl

GemFireCacheImpl.getInstance():
* PingTask
* PoolImpl



> Remove singleton calls from client/server product code in 
> org.apache.geode.cache.client.internal
> 
>
> Key: GEODE-4534
> URL: https://issues.apache.org/jira/browse/GEODE-4534
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server
>Reporter: Kirk Lund
>Priority: Major
>
> These client/server product classes in org.apache.geode.cache.client.internal 
> invoke singleton getters.
> CacheFactory.getAnyInstance():
> * PoolImpl
> CacheFactory.getInstance(DistributedSystem):
> * PoolImpl
> GemFireCacheImpl.getInstance():
> * PingTask
> * PoolImpl
> InternalDistributedSystem.getAnyInstance():
> * PoolImpl



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (GEODE-4573) Query execution within a transaction (JTA) produces a ClassCastException in version 1.4.0

[Fred Krone (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fred Krone updated GEODE-4573:
--
Affects Version/s: 1.4.0

> Query execution within a transaction (JTA) produces a ClassCastException in 
> version 1.4.0
> -
>
> Key: GEODE-4573
> URL: https://issues.apache.org/jira/browse/GEODE-4573
> Project: Geode
>  Issue Type: Bug
>  Components: transactions
>Affects Versions: 1.4.0
>Reporter: Vadim Lotarev
>Priority: Major
>
> The stack trace is like that:
> {code:java}
> Caused by: java.lang.ClassCastException: 
> org.apache.geode.internal.cache.TXEntry cannot be cast to 
> org.apache.geode.internal.cache.LocalRegion$NonTXEntry
> at 
> org.apache.geode.internal.cache.EntriesSet$EntriesIterator.moveNext(EntriesSet.java:179)
> at 
> org.apache.geode.internal.cache.EntriesSet$EntriesIterator.(EntriesSet.java:118)
> at org.apache.geode.internal.cache.EntriesSet.iterator(EntriesSet.java:83)
> at 
> org.apache.geode.cache.query.internal.ResultsCollectionWrapper.iterator(ResultsCollectionWrapper.java:184)
> at org.apache.geode.cache.query.internal.QRegion.iterator(QRegion.java:244)
> at 
> org.apache.geode.cache.query.internal.CompiledSelect.doNestedIterations(CompiledSelect.java:834)
> at 
> org.apache.geode.cache.query.internal.CompiledSelect.doIterationEvaluate(CompiledSelect.java:701)
> at 
> org.apache.geode.cache.query.internal.CompiledSelect.evaluate(CompiledSelect.java:545)
> at 
> org.apache.geode.cache.query.internal.CompiledSelect.evaluate(CompiledSelect.java:55)
> at 
> org.apache.geode.cache.query.internal.DefaultQuery.executeUsingContext(DefaultQuery.java:557)
> at 
> org.apache.geode.cache.query.internal.DefaultQuery.execute(DefaultQuery.java:384)
> {code}
> When property {{-Dgemfire.restoreSetOperationTransactionBehavior=true}} is 
> set than everything works without errors.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (GEODE-4573) Query execution within a transaction (JTA) produces a ClassCastException in version 1.4.0

[Fred Krone (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fred Krone updated GEODE-4573:
--
Component/s: transactions

> Query execution within a transaction (JTA) produces a ClassCastException in 
> version 1.4.0
> -
>
> Key: GEODE-4573
> URL: https://issues.apache.org/jira/browse/GEODE-4573
> Project: Geode
>  Issue Type: Bug
>  Components: transactions
>Affects Versions: 1.4.0
>Reporter: Vadim Lotarev
>Priority: Major
>
> The stack trace is like that:
> {code:java}
> Caused by: java.lang.ClassCastException: 
> org.apache.geode.internal.cache.TXEntry cannot be cast to 
> org.apache.geode.internal.cache.LocalRegion$NonTXEntry
> at 
> org.apache.geode.internal.cache.EntriesSet$EntriesIterator.moveNext(EntriesSet.java:179)
> at 
> org.apache.geode.internal.cache.EntriesSet$EntriesIterator.(EntriesSet.java:118)
> at org.apache.geode.internal.cache.EntriesSet.iterator(EntriesSet.java:83)
> at 
> org.apache.geode.cache.query.internal.ResultsCollectionWrapper.iterator(ResultsCollectionWrapper.java:184)
> at org.apache.geode.cache.query.internal.QRegion.iterator(QRegion.java:244)
> at 
> org.apache.geode.cache.query.internal.CompiledSelect.doNestedIterations(CompiledSelect.java:834)
> at 
> org.apache.geode.cache.query.internal.CompiledSelect.doIterationEvaluate(CompiledSelect.java:701)
> at 
> org.apache.geode.cache.query.internal.CompiledSelect.evaluate(CompiledSelect.java:545)
> at 
> org.apache.geode.cache.query.internal.CompiledSelect.evaluate(CompiledSelect.java:55)
> at 
> org.apache.geode.cache.query.internal.DefaultQuery.executeUsingContext(DefaultQuery.java:557)
> at 
> org.apache.geode.cache.query.internal.DefaultQuery.execute(DefaultQuery.java:384)
> {code}
> When property {{-Dgemfire.restoreSetOperationTransactionBehavior=true}} is 
> set than everything works without errors.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (GEODE-4582) Remove singleton calls from product code in org.apache.geode.distributed.internal.membership

[Kirk Lund (JIRA)]

Kirk Lund created GEODE-4582:


 Summary: Remove singleton calls from product code in 
org.apache.geode.distributed.internal.membership
 Key: GEODE-4582
 URL: https://issues.apache.org/jira/browse/GEODE-4582
 Project: Geode
  Issue Type: Sub-task
Reporter: Kirk Lund


These product classes in org.apache.geode.distributed.internal.membership 
invoke singleton getters.

InternalDistributedSystem.getAnyInstance():
* InternalRole



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (GEODE-4582) Remove singleton calls from product code in org.apache.geode.distributed.internal.membership

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4582:
-
Component/s: membership

> Remove singleton calls from product code in 
> org.apache.geode.distributed.internal.membership
> 
>
> Key: GEODE-4582
> URL: https://issues.apache.org/jira/browse/GEODE-4582
> Project: Geode
>  Issue Type: Sub-task
>  Components: membership
>Reporter: Kirk Lund
>Priority: Major
>
> These product classes in org.apache.geode.distributed.internal.membership 
> invoke singleton getters.
> InternalDistributedSystem.getAnyInstance():
> * InternalRole



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (GEODE-4543) Remove singleton calls from serialization product code in org.apache.geode.internal

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4543:
-
Description: 
These serialization product classes in org.apache.geode.internal invoke 
singleton getters.

GemFireCacheImpl.getForPdx(String):
* InternalDataSerializer (serialization)

GemFireCacheImpl.getInstance():
* InternalInstantiator

InternalDistributedSystem.getAnyInstance():
* InternalDataSerializer
* InternalInstantiator

  was:
These serialization product classes in org.apache.geode.internal invoke 
singleton getters.

GemFireCacheImpl.getForPdx(String):
* InternalDataSerializer (serialization)

GemFireCacheImpl.getInstance():
* InternalInstantiator


> Remove singleton calls from serialization product code in 
> org.apache.geode.internal
> ---
>
> Key: GEODE-4543
> URL: https://issues.apache.org/jira/browse/GEODE-4543
> Project: Geode
>  Issue Type: Sub-task
>  Components: serialization
>Reporter: Kirk Lund
>Priority: Major
>
> These serialization product classes in org.apache.geode.internal invoke 
> singleton getters.
> GemFireCacheImpl.getForPdx(String):
> * InternalDataSerializer (serialization)
> GemFireCacheImpl.getInstance():
> * InternalInstantiator
> InternalDistributedSystem.getAnyInstance():
> * InternalDataSerializer
> * InternalInstantiator



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (GEODE-4562) Remove singleton calls from product code in org.apache.geode.distributed.internal.membership.gms.mgr

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4562:
-
Description: 
These product classes in 
org.apache.geode.distributed.internal.membership.gms.mgr invoke singleton 
getters.

GemFireCacheImpl.getInstance():
* GMSMembershipManager

InternalDistributedSystem.getAnyInstance():
* GMSMembershipManager

  was:
These product classes in 
org.apache.geode.distributed.internal.membership.gms.mgr invoke singleton 
getters.

GemFireCacheImpl.getInstance():
* GMSMembershipManager


> Remove singleton calls from product code in 
> org.apache.geode.distributed.internal.membership.gms.mgr
> 
>
> Key: GEODE-4562
> URL: https://issues.apache.org/jira/browse/GEODE-4562
> Project: Geode
>  Issue Type: Sub-task
>  Components: membership
>Reporter: Kirk Lund
>Priority: Major
>
> These product classes in 
> org.apache.geode.distributed.internal.membership.gms.mgr invoke singleton 
> getters.
> GemFireCacheImpl.getInstance():
> * GMSMembershipManager
> InternalDistributedSystem.getAnyInstance():
> * GMSMembershipManager



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (GEODE-4309) ArgumentRedactor is not properly applied to System Properties

[Barbara Pruijn (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Barbara Pruijn resolved GEODE-4309.
---
Resolution: Fixed

> ArgumentRedactor is not properly applied to System Properties
> -
>
> Key: GEODE-4309
> URL: https://issues.apache.org/jira/browse/GEODE-4309
> Project: Geode
>  Issue Type: Bug
>  Components: logging, security
>Affects Versions: 1.2.1
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.5.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The System Properties section of {{Banner.java}} contains the line
> {noformat}
> out.println("" + key + " = " + 
> ArgumentRedactor.redact(String.valueOf(me.getValue(;
> {noformat}
> However, the method {{redact}} excepts the entire line, not only the value, 
> to determine if the entry should be redacted.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (GEODE-4581) Remove singleton calls from product code in org.apache.geode.distributed.internal.membership.gms.locator

[Kirk Lund (JIRA)]

Kirk Lund created GEODE-4581:


 Summary: Remove singleton calls from product code in 
org.apache.geode.distributed.internal.membership.gms.locator
 Key: GEODE-4581
 URL: https://issues.apache.org/jira/browse/GEODE-4581
 Project: Geode
  Issue Type: Sub-task
  Components: locator, membership
Reporter: Kirk Lund


These product classes in 
org.apache.geode.distributed.internal.membership.gms.locator invoke singleton 
getters.

InternalDistributedSystem.getAnyInstance():
* GMSLocator



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (GEODE-4525) Remove singleton calls from product code in org.apache.geode.internal.cache.wan

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4525:
-
Description: 
These product classes in org.apache.geode.internal.cache.wan invoke singleton 
getters.

CacheFactory.getAnyInstance():
* GatewaySenderEventImpl
* GatewaySenderQueueEntrySynchronizationOperation
* 
GatewaySenderQueueEntrySynchronizationOperation$GatewaySenderQueueEntrySynchronizationMessage
* 
GatewaySenderQueueEntrySynchronizationOperation$GatewaySenderQueueEntrySynchronizationReplyProcessor

InternalDistributedSystem.getAnyInstance():
* GatewayReceiverStats
* GatewaySenderFactoryImpl

  was:
These product classes in org.apache.geode.internal.cache.wan invoke singleton 
getters.

CacheFactory.getAnyInstance():
* GatewaySenderEventImpl
* GatewaySenderQueueEntrySynchronizationOperation
* 
GatewaySenderQueueEntrySynchronizationOperation$GatewaySenderQueueEntrySynchronizationMessage
* 
GatewaySenderQueueEntrySynchronizationOperation$GatewaySenderQueueEntrySynchronizationReplyProcessor



> Remove singleton calls from product code in 
> org.apache.geode.internal.cache.wan
> ---
>
> Key: GEODE-4525
> URL: https://issues.apache.org/jira/browse/GEODE-4525
> Project: Geode
>  Issue Type: Sub-task
>  Components: wan
>Reporter: Kirk Lund
>Priority: Major
>
> These product classes in org.apache.geode.internal.cache.wan invoke singleton 
> getters.
> CacheFactory.getAnyInstance():
> * GatewaySenderEventImpl
> * GatewaySenderQueueEntrySynchronizationOperation
> * 
> GatewaySenderQueueEntrySynchronizationOperation$GatewaySenderQueueEntrySynchronizationMessage
> * 
> GatewaySenderQueueEntrySynchronizationOperation$GatewaySenderQueueEntrySynchronizationReplyProcessor
> InternalDistributedSystem.getAnyInstance():
> * GatewayReceiverStats
> * GatewaySenderFactoryImpl



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)