[jira] [Commented] (GEODE-8102) Link and load OpenSSL library directly
[
https://issues.apache.org/jira/browse/GEODE-8102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169223#comment-17169223
]
ASF GitHub Bot commented on GEODE-8102:
---
pivotal-jbarrett commented on a change in pull request #630:
URL: https://github.com/apache/geode-native/pull/630#discussion_r463914946
##
File path: clicache/src/CMakeLists.txt
##
@@ -23,7 +23,7 @@
configure_file(${CMAKE_CURRENT_SOURCE_DIR}/impl/AssemblyInfo.cpp.in ${CMAKE_CURR
list(APPEND CONFIGURE_IN_FILES
${CMAKE_CURRENT_SOURCE_DIR}/impl/AssemblyInfo.cpp.in)
list(APPEND CONFIGURE_OUT_FILES
${CMAKE_CURRENT_BINARY_DIR}/impl/AssemblyInfo.cpp)
-add_library(${PROJECT_NAME} SHARED
+add_library(Apache.Geode SHARED
Review comment:
Most of the IDE's that integrate with CMake don't resolve the target
names correctly if they are variables. It's also not necessary that all targets
be unique projects in CMake. It was a bad pattern that was used in the early
days in CMake and in Geode Native (my bad).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Link and load OpenSSL library directly
> --
>
> Key: GEODE-8102
> URL: https://issues.apache.org/jira/browse/GEODE-8102
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Jacob Barrett
>Priority: Major
> Labels: pull-request-available
>
> Lazy load the OpenSSL library directly, through ACE_SSL, into the
> apache-geode library. Currently we lazy load cryptoImpl, which immediately
> loads OpenSSL. The original intent was to avoid having an immediate
> dependency on OpenSSL at a time when its availability was questionable. On
> unix like systems OpenSSL is almost always available since so many other
> components in the OS depend on it. This immediate load dependency will have
> little to no effect on those systems. On some unix like systems the
> experience will improve by not having a runtime dependency on an intermediate
> library, cryptoImpl, that may need special treatments, like LD_LIBRARY_PATH
> or RPATH changes. On Windows, where OpenSSL is an anomaly we can use MSVC's
> lazy loading feature to only load OpenSSL if SSL/TLS is configured. This
> significantly improves the experience on Windows with regards to the location
> of cryptoImpl when using .NET.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8102) Link and load OpenSSL library directly
[
https://issues.apache.org/jira/browse/GEODE-8102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169210#comment-17169210
]
ASF GitHub Bot commented on GEODE-8102:
---
moleske commented on a change in pull request #630:
URL: https://github.com/apache/geode-native/pull/630#discussion_r463855720
##
File path: cppcache/src/TcpConn.cpp
##
@@ -126,142 +124,68 @@ void TcpConn::init() {
connect();
}
-TcpConn::TcpConn(const char *ipaddr, std::chrono::microseconds waitSeconds,
- int32_t maxBuffSizePool)
-: m_io(nullptr),
- m_addr(ipaddr),
- m_waitMilliSeconds(waitSeconds),
- m_maxBuffSizePool(maxBuffSizePool),
- m_chunkSize(getDefaultChunkSize()) {}
-
-TcpConn::TcpConn(const char *hostname, int32_t port,
+TcpConn::TcpConn(const std::string& address,
std::chrono::microseconds waitSeconds, int32_t
maxBuffSizePool)
-: m_io(nullptr),
- m_addr(port, hostname),
- m_waitMilliSeconds(waitSeconds),
- m_maxBuffSizePool(maxBuffSizePool),
- m_chunkSize(getDefaultChunkSize()) {}
-
-void TcpConn::listen(const char *hostname, int32_t port,
- std::chrono::microseconds waitSeconds) {
- ACE_INET_Addr addr(port, hostname);
- listen(addr, waitSeconds);
-}
-
-void TcpConn::listen(const char *ipaddr,
- std::chrono::microseconds waitSeconds) {
- ACE_INET_Addr addr(ipaddr);
- listen(addr, waitSeconds);
-}
-
-void TcpConn::listen(ACE_INET_Addr addr,
- std::chrono::microseconds waitSeconds) {
- using apache::geode::internal::chrono::duration::to_string;
-
- ACE_SOCK_Acceptor listener(addr, 1);
- int32_t retVal = 0;
- if (waitSeconds > std::chrono::microseconds::zero()) {
-ACE_Time_Value wtime(waitSeconds);
-retVal = listener.accept(*m_io, nullptr, );
- } else {
-retVal = listener.accept(*m_io, nullptr);
- }
- if (retVal == -1) {
-char msg[256];
-int32_t lastError = ACE_OS::last_error();
-if (lastError == ETIME || lastError == ETIMEDOUT) {
- throw TimeoutException(
- "TcpConn::listen Attempt to listen timed out after " +
- to_string(waitSeconds) + ".");
-}
-std::snprintf(msg, 256, "TcpConn::listen failed with errno: %d: %s",
- lastError, ACE_OS::strerror(lastError));
-throw GeodeIOException(msg);
- }
-}
-
-void TcpConn::connect(const char *hostname, int32_t port,
- std::chrono::microseconds waitSeconds) {
- ACE_INET_Addr addr(port, hostname);
- m_addr = addr;
- m_waitMilliSeconds = waitSeconds;
- connect();
-}
+: stream_(nullptr),
Review comment:
Thanks for using the style guide naming suggestions!
##
File path: clicache/src/CMakeLists.txt
##
@@ -23,7 +23,7 @@
configure_file(${CMAKE_CURRENT_SOURCE_DIR}/impl/AssemblyInfo.cpp.in ${CMAKE_CURR
list(APPEND CONFIGURE_IN_FILES
${CMAKE_CURRENT_SOURCE_DIR}/impl/AssemblyInfo.cpp.in)
list(APPEND CONFIGURE_OUT_FILES
${CMAKE_CURRENT_BINARY_DIR}/impl/AssemblyInfo.cpp)
-add_library(${PROJECT_NAME} SHARED
+add_library(Apache.Geode SHARED
Review comment:
I'm a bit confused on why `${Project_Name}` was replaced. Looking at
the commit that did the switch didn't help me much
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Link and load OpenSSL library directly
> --
>
> Key: GEODE-8102
> URL: https://issues.apache.org/jira/browse/GEODE-8102
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Jacob Barrett
>Priority: Major
> Labels: pull-request-available
>
> Lazy load the OpenSSL library directly, through ACE_SSL, into the
> apache-geode library. Currently we lazy load cryptoImpl, which immediately
> loads OpenSSL. The original intent was to avoid having an immediate
> dependency on OpenSSL at a time when its availability was questionable. On
> unix like systems OpenSSL is almost always available since so many other
> components in the OS depend on it. This immediate load dependency will have
> little to no effect on those systems. On some unix like systems the
> experience will improve by not having a runtime dependency on an intermediate
> library, cryptoImpl, that may need special treatments, like LD_LIBRARY_PATH
> or RPATH changes. On Windows, where OpenSSL is an anomaly we can use MSVC's
> lazy loading feature to only load OpenSSL if SSL/TLS is configured. This
> significantly improves the experience on Windows with regards to the location
> of cryptoImpl when using
[jira] [Commented] (GEODE-8388) Geode Native Client user guide: delete unused sources
[ https://issues.apache.org/jira/browse/GEODE-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169202#comment-17169202 ] ASF subversion and git services commented on GEODE-8388: Commit 5c5b320080f8f247eb09dd5749ca803d7d973650 in geode-native's branch refs/heads/support/1.13 from Dave Barnes [ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=5c5b320 ] GEODE-8388: Geode Native Client User Guide - delete unused source files (#631) > Geode Native Client user guide: delete unused sources > - > > Key: GEODE-8388 > URL: https://issues.apache.org/jira/browse/GEODE-8388 > Project: Geode > Issue Type: Bug > Components: docs, native client >Reporter: Dave Barnes >Assignee: Dave Barnes >Priority: Major > Labels: pull-request-available > > The geode-native docs directory contains unused sources from the > pre-open-source days. The problem is that while they're not linked to the > user guide's T of C, these out-of-date docs are still included in the manual > build (a quirk of the toolset), where they can be accidentally discovered via > web searches. > These unused files need to be identified and deleted. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-6076) CI Failure: WANRollingUpgradeCreateGatewaySenderMixedSiteOneCurrentSiteTwo.CreateGatewaySenderMixedSiteOneCurrentSiteTwo
[
https://issues.apache.org/jira/browse/GEODE-6076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169125#comment-17169125
]
Mark Hanson commented on GEODE-6076:
https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/UpgradeTestOpenJDK8/builds/385
=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0253/test-results/upgradeTest/1596218418/
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Test report artifacts from this job are available at:
http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0253/test-artifacts/1596218418/upgradetestfiles-OpenJDK8-1.14.0-build.0253.tgz
> CI Failure:
> WANRollingUpgradeCreateGatewaySenderMixedSiteOneCurrentSiteTwo.CreateGatewaySenderMixedSiteOneCurrentSiteTwo
>
>
> Key: GEODE-6076
> URL: https://issues.apache.org/jira/browse/GEODE-6076
> Project: Geode
> Issue Type: Bug
> Components: wan
>Reporter: Jens Deppe
>Priority: Major
>
> {noformat}
> org.apache.geode.cache.wan.WANRollingUpgradeCreateGatewaySenderMixedSiteOneCurrentSiteTwo
> > CreateGatewaySenderMixedSiteOneCurrentSiteTwo[from_v110] FAILED
> org.apache.geode.test.dunit.RMIException: While invoking
> org.apache.geode.cache.wan.WANRollingUpgradeCreateGatewaySenderMixedSiteOneCurrentSiteTwo$$Lambda$53/1234278717.call
> in VM 0 running on Host 1d2a3ce05625 with 7 VMs
> at org.apache.geode.test.dunit.VM.invoke(VM.java:433)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:402)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:384)
> at
> org.apache.geode.cache.wan.WANRollingUpgradeCreateGatewaySenderMixedSiteOneCurrentSiteTwo.CreateGatewaySenderMixedSiteOneCurrentSiteTwo(WANRollingUpgradeCreateGatewaySenderMixedSiteOneCurrentSiteTwo.java:92)
> Caused by:
> org.apache.geode.management.ManagementException:
> java.rmi.server.ExportException: Port already in use: 26239; nested exception
> is:
> java.net.BindException: Failed to create server socket on
> 1d2a3ce05625/172.17.0.33[26239]
> at
> org.apache.geode.management.internal.ManagementAgent.startAgent(ManagementAgent.java:162)
> at
> org.apache.geode.management.internal.SystemManagementService.startManager(SystemManagementService.java:429)
> at
> org.apache.geode.management.internal.beans.ManagementAdapter.handleCacheCreation(ManagementAdapter.java:173)
> at
> org.apache.geode.management.internal.beans.ManagementListener.handleEvent(ManagementListener.java:115)
> at
> org.apache.geode.distributed.internal.InternalDistributedSystem.notifyResourceEventListeners(InternalDistributedSystem.java:2201)
> at
> org.apache.geode.distributed.internal.InternalDistributedSystem.handleResourceEvent(InternalDistributedSystem.java:606)
> at
> org.apache.geode.internal.cache.GemFireCacheImpl.initialize(GemFireCacheImpl.java:1211)
> at
> org.apache.geode.internal.cache.GemFireCacheImpl.basicCreate(GemFireCacheImpl.java:797)
> at
> org.apache.geode.internal.cache.GemFireCacheImpl.create(GemFireCacheImpl.java:783)
> at
> org.apache.geode.cache.CacheFactory.create(CacheFactory.java:176)
> at
> org.apache.geode.cache.CacheFactory.create(CacheFactory.java:223)
> at
> org.apache.geode.distributed.internal.InternalLocator.startCache(InternalLocator.java:652)
> at
> org.apache.geode.distributed.internal.InternalLocator.startDistributedSystem(InternalLocator.java:639)
> at
> org.apache.geode.distributed.internal.InternalLocator.startLocator(InternalLocator.java:326)
> at
> org.apache.geode.distributed.Locator.startLocator(Locator.java:252)
> at
> org.apache.geode.distributed.Locator.startLocatorAndDS(Locator.java:139)
> at
> org.apache.geode.cache.wan.WANRollingUpgradeDUnitTest.startLocatorWithJmxManager(WANRollingUpgradeDUnitTest.java:112)
> at
> org.apache.geode.cache.wan.WANRollingUpgradeCreateGatewaySenderMixedSiteOneCurrentSiteTwo.lambda$CreateGatewaySenderMixedSiteOneCurrentSiteTwo$e0147a59$1(WANRollingUpgradeCreateGatewaySenderMixedSiteOneCurrentSiteTwo.java:92)
> Caused by:
> java.rmi.server.ExportException: Port already in use: 26239;
> nested exception is:
> java.net.BindException: Failed to create server socket on
> 1d2a3ce05625/172.17.0.33[26239]
> at
> sun.rmi.transport.tcp.TCPTransport.listen(TCPTransport.java:346)
> at
>
[jira] [Commented] (GEODE-6076) CI Failure: WANRollingUpgradeCreateGatewaySenderMixedSiteOneCurrentSiteTwo.CreateGatewaySenderMixedSiteOneCurrentSiteTwo
[
https://issues.apache.org/jira/browse/GEODE-6076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169127#comment-17169127
]
Mark Hanson commented on GEODE-6076:
https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/UpgradeTestOpenJDK11/builds/383
=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0252/test-results/upgradeTest/1596214796/
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Test report artifacts from this job are available at:
http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0252/test-artifacts/1596214796/upgradetestfiles-OpenJDK11-1.14.0-build.0252.tgz
> CI Failure:
> WANRollingUpgradeCreateGatewaySenderMixedSiteOneCurrentSiteTwo.CreateGatewaySenderMixedSiteOneCurrentSiteTwo
>
>
> Key: GEODE-6076
> URL: https://issues.apache.org/jira/browse/GEODE-6076
> Project: Geode
> Issue Type: Bug
> Components: wan
>Reporter: Jens Deppe
>Priority: Major
>
> {noformat}
> org.apache.geode.cache.wan.WANRollingUpgradeCreateGatewaySenderMixedSiteOneCurrentSiteTwo
> > CreateGatewaySenderMixedSiteOneCurrentSiteTwo[from_v110] FAILED
> org.apache.geode.test.dunit.RMIException: While invoking
> org.apache.geode.cache.wan.WANRollingUpgradeCreateGatewaySenderMixedSiteOneCurrentSiteTwo$$Lambda$53/1234278717.call
> in VM 0 running on Host 1d2a3ce05625 with 7 VMs
> at org.apache.geode.test.dunit.VM.invoke(VM.java:433)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:402)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:384)
> at
> org.apache.geode.cache.wan.WANRollingUpgradeCreateGatewaySenderMixedSiteOneCurrentSiteTwo.CreateGatewaySenderMixedSiteOneCurrentSiteTwo(WANRollingUpgradeCreateGatewaySenderMixedSiteOneCurrentSiteTwo.java:92)
> Caused by:
> org.apache.geode.management.ManagementException:
> java.rmi.server.ExportException: Port already in use: 26239; nested exception
> is:
> java.net.BindException: Failed to create server socket on
> 1d2a3ce05625/172.17.0.33[26239]
> at
> org.apache.geode.management.internal.ManagementAgent.startAgent(ManagementAgent.java:162)
> at
> org.apache.geode.management.internal.SystemManagementService.startManager(SystemManagementService.java:429)
> at
> org.apache.geode.management.internal.beans.ManagementAdapter.handleCacheCreation(ManagementAdapter.java:173)
> at
> org.apache.geode.management.internal.beans.ManagementListener.handleEvent(ManagementListener.java:115)
> at
> org.apache.geode.distributed.internal.InternalDistributedSystem.notifyResourceEventListeners(InternalDistributedSystem.java:2201)
> at
> org.apache.geode.distributed.internal.InternalDistributedSystem.handleResourceEvent(InternalDistributedSystem.java:606)
> at
> org.apache.geode.internal.cache.GemFireCacheImpl.initialize(GemFireCacheImpl.java:1211)
> at
> org.apache.geode.internal.cache.GemFireCacheImpl.basicCreate(GemFireCacheImpl.java:797)
> at
> org.apache.geode.internal.cache.GemFireCacheImpl.create(GemFireCacheImpl.java:783)
> at
> org.apache.geode.cache.CacheFactory.create(CacheFactory.java:176)
> at
> org.apache.geode.cache.CacheFactory.create(CacheFactory.java:223)
> at
> org.apache.geode.distributed.internal.InternalLocator.startCache(InternalLocator.java:652)
> at
> org.apache.geode.distributed.internal.InternalLocator.startDistributedSystem(InternalLocator.java:639)
> at
> org.apache.geode.distributed.internal.InternalLocator.startLocator(InternalLocator.java:326)
> at
> org.apache.geode.distributed.Locator.startLocator(Locator.java:252)
> at
> org.apache.geode.distributed.Locator.startLocatorAndDS(Locator.java:139)
> at
> org.apache.geode.cache.wan.WANRollingUpgradeDUnitTest.startLocatorWithJmxManager(WANRollingUpgradeDUnitTest.java:112)
> at
> org.apache.geode.cache.wan.WANRollingUpgradeCreateGatewaySenderMixedSiteOneCurrentSiteTwo.lambda$CreateGatewaySenderMixedSiteOneCurrentSiteTwo$e0147a59$1(WANRollingUpgradeCreateGatewaySenderMixedSiteOneCurrentSiteTwo.java:92)
> Caused by:
> java.rmi.server.ExportException: Port already in use: 26239;
> nested exception is:
> java.net.BindException: Failed to create server socket on
> 1d2a3ce05625/172.17.0.33[26239]
> at
> sun.rmi.transport.tcp.TCPTransport.listen(TCPTransport.java:346)
> at
>
[jira] [Commented] (GEODE-6070) CI Failure: ShutdownCommandOverHttpDUnitTest > testShutdownAll
[
https://issues.apache.org/jira/browse/GEODE-6070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169123#comment-17169123
]
Mark Hanson commented on GEODE-6070:
{noformat}
Failed in Windows...
https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/WindowsGfshDistributedTestOpenJDK11/builds/367
=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0252/test-results/distributedTest/1596225340/
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Test report artifacts from this job are available at:
http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0252/test-artifacts/1596225340/windows-gfshdistributedtest-OpenJDK11-1.14.0-build.0252.tgz
{noformat}
> CI Failure: ShutdownCommandOverHttpDUnitTest > testShutdownAll
> --
>
> Key: GEODE-6070
> URL: https://issues.apache.org/jira/browse/GEODE-6070
> Project: Geode
> Issue Type: Bug
>Affects Versions: 1.12.0
>Reporter: Helena Bales
>Assignee: Kirk Lund
>Priority: Major
> Labels: GeodeCommons, flaky
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Failed with stacktrace:
> {noformat}
> org.apache.geode.management.internal.cli.commands.ShutdownCommandOverHttpDUnitTest
> > testShutdownAll FAILED
> java.lang.AssertionError: Suspicious strings were written to the log
> during this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> ---
> Found suspect string in log4j at line 302
> org.apache.geode.distributed.DistributedSystemDisconnectedException:
> Distribution manager on 172.17.0.3(server-1:496):41002 started at Thu Nov
> 15 19:47:58 UTC 2018: Message distribution has terminated
> {noformat}
> Test results can be found here:
> http://files.apachegeode-ci.info/builds/apache-develop-main/1.9.0-build.158/test-results/distributedTest/1542315851/classes/org.apache.geode.management.internal.cli.commands.ShutdownCommandOverHttpDUnitTest.html#testShutdownAll
>
> Test Artifacts can be found here:
> http://files.apachegeode-ci.info/builds/apache-develop-main/1.9.0-build.158/test-artifacts/1542315851/distributedtestfiles-OpenJDK8-1.9.0-build.158.tgz
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8337) Rename Version enum to KnownVersion; VersionOrdinal to Version
[
https://issues.apache.org/jira/browse/GEODE-8337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17168980#comment-17168980
]
ASF GitHub Bot commented on GEODE-8337:
---
Bill commented on pull request #5409:
URL: https://github.com/apache/geode/pull/5409#issuecomment-667208641
sorry about the confusion @bschuchardt. Nothing to review here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Rename Version enum to KnownVersion; VersionOrdinal to Version
> --
>
> Key: GEODE-8337
> URL: https://issues.apache.org/jira/browse/GEODE-8337
> Project: Geode
> Issue Type: Improvement
> Components: serialization
>Reporter: Bill Burcham
>Assignee: Bill Burcham
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.14.0
>
> Attachments: screenshot-1.png, screenshot-2.png
>
>
> As a follow-on to GEODE-8240 and GEODE-8330, this is the final ticket, to
> rename:
> {{Version}} -> {{KnownVersion}}
> {{VersionOrdinal}} -> {{Version}}
> With this ticket, the work started in GEODE-8240 is complete.
> After this change, the versioning hierarchy will be:
> !screenshot-1.png!
> Before this change, the hierarchy was:
> !screenshot-2.png!
> As part of this story we'll also harmonize version access methods on
> MemberIdentifier, InternalDistributedMember, and GMSMemberData:
> getVersionOrdinalObject() becomes getVersion()
> On GMSMemberData:
> setVersionObjectForTest() becomes setVersionForTest()
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8387) SUNIONSTORE, SINTERSTORE, and SDIFFSTORE should delete the target key if the computed set is empty
[ https://issues.apache.org/jira/browse/GEODE-8387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17168965#comment-17168965 ] ASF subversion and git services commented on GEODE-8387: Commit dec583b9411664c4db55c4ee4651a80cfe8a51a7 in geode's branch refs/heads/develop from Darrel Schneider [ https://gitbox.apache.org/repos/asf?p=geode.git;h=dec583b ] GEODE-8387: fix SET*STORE commands handling of empty results (#5405) > SUNIONSTORE, SINTERSTORE, and SDIFFSTORE should delete the target key if the > computed set is empty > -- > > Key: GEODE-8387 > URL: https://issues.apache.org/jira/browse/GEODE-8387 > Project: Geode > Issue Type: Bug > Components: redis >Reporter: Darrel Schneider >Priority: Major > Labels: pull-request-available > Fix For: 1.14.0 > > > The current impl of SUNIONSTORE, SINTERSTORE, and SDIFFSTORE set the > destination to an empty set if the computed set is empty. But they should > instead in that case delete the destination. This is true if the read keys do > not exist. > If the read keys exist but are not sets then the commands should fail with a > WRONGTYPE error. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-8387) SUNIONSTORE, SINTERSTORE, and SDIFFSTORE should delete the target key if the computed set is empty
[ https://issues.apache.org/jira/browse/GEODE-8387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Darrel Schneider resolved GEODE-8387. - Fix Version/s: 1.14.0 Resolution: Fixed > SUNIONSTORE, SINTERSTORE, and SDIFFSTORE should delete the target key if the > computed set is empty > -- > > Key: GEODE-8387 > URL: https://issues.apache.org/jira/browse/GEODE-8387 > Project: Geode > Issue Type: Bug > Components: redis >Reporter: Darrel Schneider >Priority: Major > Labels: pull-request-available > Fix For: 1.14.0 > > > The current impl of SUNIONSTORE, SINTERSTORE, and SDIFFSTORE set the > destination to an empty set if the computed set is empty. But they should > instead in that case delete the destination. This is true if the read keys do > not exist. > If the read keys exist but are not sets then the commands should fail with a > WRONGTYPE error. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8387) SUNIONSTORE, SINTERSTORE, and SDIFFSTORE should delete the target key if the computed set is empty
[ https://issues.apache.org/jira/browse/GEODE-8387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17168964#comment-17168964 ] ASF GitHub Bot commented on GEODE-8387: --- dschneider-pivotal merged pull request #5405: URL: https://github.com/apache/geode/pull/5405 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > SUNIONSTORE, SINTERSTORE, and SDIFFSTORE should delete the target key if the > computed set is empty > -- > > Key: GEODE-8387 > URL: https://issues.apache.org/jira/browse/GEODE-8387 > Project: Geode > Issue Type: Bug > Components: redis >Reporter: Darrel Schneider >Priority: Major > Labels: pull-request-available > > The current impl of SUNIONSTORE, SINTERSTORE, and SDIFFSTORE set the > destination to an empty set if the computed set is empty. But they should > instead in that case delete the destination. This is true if the read keys do > not exist. > If the read keys exist but are not sets then the commands should fail with a > WRONGTYPE error. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8386) SRANDMEMBER with negative count should return that many members
[
https://issues.apache.org/jira/browse/GEODE-8386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17168961#comment-17168961
]
ASF GitHub Bot commented on GEODE-8386:
---
dschneider-pivotal merged pull request #5404:
URL: https://github.com/apache/geode/pull/5404
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> SRANDMEMBER with negative count should return that many members
> ---
>
> Key: GEODE-8386
> URL: https://issues.apache.org/jira/browse/GEODE-8386
> Project: Geode
> Issue Type: Bug
> Components: redis
>Reporter: Darrel Schneider
>Assignee: Darrel Schneider
>Priority: Major
> Labels: pull-request-available
>
> When SRANDMEMBER is sent a negative count, it should return a number of items
> equal to the absolute value. uniqueness is not guaranteed.
>
> {{SADD abc 123 456
> SRANDMEMBER abc -1 -> 123
> SRANDMEMBER abc -2 -> 123, 123 OR 123, 456, 456, 123 OR 456, 456
> SRANDMEMBER abc -5 -> 123,123,456,123,456 OR any one of the 2^5
> combinations...}}
> see the redis unit tests and docs: unit/type/set -> SRANDMEMBER with
> - hashtable
> and documentation: [https://redis.io/commands/srandmember]
> Currently, Geode Redis returns only up to as many members as there are in the
> set.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8384) SETEX error message should be consistent with native redis
[
https://issues.apache.org/jira/browse/GEODE-8384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17168960#comment-17168960
]
ASF subversion and git services commented on GEODE-8384:
Commit 0a31dd5de4bfe4402e86505f5a65fbe46c48c72b in geode's branch
refs/heads/develop from Darrel Schneider
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=0a31dd5 ]
GEODE-8384: fix SETEX error message (#5402)
> SETEX error message should be consistent with native redis
> --
>
> Key: GEODE-8384
> URL: https://issues.apache.org/jira/browse/GEODE-8384
> Project: Geode
> Issue Type: Bug
> Components: redis
>Reporter: Darrel Schneider
>Assignee: Darrel Schneider
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.14.0
>
>
> When we pass a negative expiration to SETEX on native redis we get the
> following error message:
>
> {{ERR invalid expire time in setex}}
> When we pass a negative expiration to SETEX on geode redis we get the
> following error message:
>
> {{ERR The expiration argument must be greater than 0}}
> These error messages should match.
> Revert the following native Redis test back to its original form:
>
> {{test \{SETEX - Wrong time parameter}}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8384) SETEX error message should be consistent with native redis
[
https://issues.apache.org/jira/browse/GEODE-8384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17168957#comment-17168957
]
ASF subversion and git services commented on GEODE-8384:
Commit 0a31dd5de4bfe4402e86505f5a65fbe46c48c72b in geode's branch
refs/heads/develop from Darrel Schneider
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=0a31dd5 ]
GEODE-8384: fix SETEX error message (#5402)
> SETEX error message should be consistent with native redis
> --
>
> Key: GEODE-8384
> URL: https://issues.apache.org/jira/browse/GEODE-8384
> Project: Geode
> Issue Type: Bug
> Components: redis
>Reporter: Darrel Schneider
>Assignee: Darrel Schneider
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.14.0
>
>
> When we pass a negative expiration to SETEX on native redis we get the
> following error message:
>
> {{ERR invalid expire time in setex}}
> When we pass a negative expiration to SETEX on geode redis we get the
> following error message:
>
> {{ERR The expiration argument must be greater than 0}}
> These error messages should match.
> Revert the following native Redis test back to its original form:
>
> {{test \{SETEX - Wrong time parameter}}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8386) SRANDMEMBER with negative count should return that many members
[
https://issues.apache.org/jira/browse/GEODE-8386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17168962#comment-17168962
]
ASF subversion and git services commented on GEODE-8386:
Commit 42c086b6578b6f0f768a3ff9ead627fbe70abf22 in geode's branch
refs/heads/develop from Darrel Schneider
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=42c086b ]
GEODE-8386: fix SRANDMEMBER with negative count (#5404)
> SRANDMEMBER with negative count should return that many members
> ---
>
> Key: GEODE-8386
> URL: https://issues.apache.org/jira/browse/GEODE-8386
> Project: Geode
> Issue Type: Bug
> Components: redis
>Reporter: Darrel Schneider
>Assignee: Darrel Schneider
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.14.0
>
>
> When SRANDMEMBER is sent a negative count, it should return a number of items
> equal to the absolute value. uniqueness is not guaranteed.
>
> {{SADD abc 123 456
> SRANDMEMBER abc -1 -> 123
> SRANDMEMBER abc -2 -> 123, 123 OR 123, 456, 456, 123 OR 456, 456
> SRANDMEMBER abc -5 -> 123,123,456,123,456 OR any one of the 2^5
> combinations...}}
> see the redis unit tests and docs: unit/type/set -> SRANDMEMBER with
> - hashtable
> and documentation: [https://redis.io/commands/srandmember]
> Currently, Geode Redis returns only up to as many members as there are in the
> set.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (GEODE-8386) SRANDMEMBER with negative count should return that many members
[
https://issues.apache.org/jira/browse/GEODE-8386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Darrel Schneider resolved GEODE-8386.
-
Fix Version/s: 1.14.0
Resolution: Fixed
> SRANDMEMBER with negative count should return that many members
> ---
>
> Key: GEODE-8386
> URL: https://issues.apache.org/jira/browse/GEODE-8386
> Project: Geode
> Issue Type: Bug
> Components: redis
>Reporter: Darrel Schneider
>Assignee: Darrel Schneider
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.14.0
>
>
> When SRANDMEMBER is sent a negative count, it should return a number of items
> equal to the absolute value. uniqueness is not guaranteed.
>
> {{SADD abc 123 456
> SRANDMEMBER abc -1 -> 123
> SRANDMEMBER abc -2 -> 123, 123 OR 123, 456, 456, 123 OR 456, 456
> SRANDMEMBER abc -5 -> 123,123,456,123,456 OR any one of the 2^5
> combinations...}}
> see the redis unit tests and docs: unit/type/set -> SRANDMEMBER with
> - hashtable
> and documentation: [https://redis.io/commands/srandmember]
> Currently, Geode Redis returns only up to as many members as there are in the
> set.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (GEODE-8384) SETEX error message should be consistent with native redis
[
https://issues.apache.org/jira/browse/GEODE-8384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Darrel Schneider resolved GEODE-8384.
-
Fix Version/s: 1.14.0
Resolution: Fixed
> SETEX error message should be consistent with native redis
> --
>
> Key: GEODE-8384
> URL: https://issues.apache.org/jira/browse/GEODE-8384
> Project: Geode
> Issue Type: Bug
> Components: redis
>Reporter: Darrel Schneider
>Assignee: Darrel Schneider
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.14.0
>
>
> When we pass a negative expiration to SETEX on native redis we get the
> following error message:
>
> {{ERR invalid expire time in setex}}
> When we pass a negative expiration to SETEX on geode redis we get the
> following error message:
>
> {{ERR The expiration argument must be greater than 0}}
> These error messages should match.
> Revert the following native Redis test back to its original form:
>
> {{test \{SETEX - Wrong time parameter}}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8384) SETEX error message should be consistent with native redis
[
https://issues.apache.org/jira/browse/GEODE-8384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17168956#comment-17168956
]
ASF GitHub Bot commented on GEODE-8384:
---
dschneider-pivotal merged pull request #5402:
URL: https://github.com/apache/geode/pull/5402
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> SETEX error message should be consistent with native redis
> --
>
> Key: GEODE-8384
> URL: https://issues.apache.org/jira/browse/GEODE-8384
> Project: Geode
> Issue Type: Bug
> Components: redis
>Reporter: Darrel Schneider
>Assignee: Darrel Schneider
>Priority: Major
> Labels: pull-request-available
>
> When we pass a negative expiration to SETEX on native redis we get the
> following error message:
>
> {{ERR invalid expire time in setex}}
> When we pass a negative expiration to SETEX on geode redis we get the
> following error message:
>
> {{ERR The expiration argument must be greater than 0}}
> These error messages should match.
> Revert the following native Redis test back to its original form:
>
> {{test \{SETEX - Wrong time parameter}}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8102) Link and load OpenSSL library directly
[ https://issues.apache.org/jira/browse/GEODE-8102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17168955#comment-17168955 ] ASF GitHub Bot commented on GEODE-8102: --- lgtm-com[bot] commented on pull request #630: URL: https://github.com/apache/geode-native/pull/630#issuecomment-667193803 This pull request **fixes 1 alert** when merging d7edeb3047a20363df4afabcddfc5cff7846a6ae into 729185236e66377e5b367d40e43c8654314c60ed - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode-native/rev/pr-bc23ef9aba24518f948b5340720d8bf58be7f7be) **fixed alerts:** * 1 for Virtual call from constructor or destructor This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Link and load OpenSSL library directly > -- > > Key: GEODE-8102 > URL: https://issues.apache.org/jira/browse/GEODE-8102 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Jacob Barrett >Priority: Major > Labels: pull-request-available > > Lazy load the OpenSSL library directly, through ACE_SSL, into the > apache-geode library. Currently we lazy load cryptoImpl, which immediately > loads OpenSSL. The original intent was to avoid having an immediate > dependency on OpenSSL at a time when its availability was questionable. On > unix like systems OpenSSL is almost always available since so many other > components in the OS depend on it. This immediate load dependency will have > little to no effect on those systems. On some unix like systems the > experience will improve by not having a runtime dependency on an intermediate > library, cryptoImpl, that may need special treatments, like LD_LIBRARY_PATH > or RPATH changes. On Windows, where OpenSSL is an anomaly we can use MSVC's > lazy loading feature to only load OpenSSL if SSL/TLS is configured. This > significantly improves the experience on Windows with regards to the location > of cryptoImpl when using .NET. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8388) Geode Native Client user guide: delete unused sources
[ https://issues.apache.org/jira/browse/GEODE-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17168940#comment-17168940 ] ASF GitHub Bot commented on GEODE-8388: --- pdxcodemonkey merged pull request #631: URL: https://github.com/apache/geode-native/pull/631 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Geode Native Client user guide: delete unused sources > - > > Key: GEODE-8388 > URL: https://issues.apache.org/jira/browse/GEODE-8388 > Project: Geode > Issue Type: Bug > Components: docs, native client >Reporter: Dave Barnes >Assignee: Dave Barnes >Priority: Major > Labels: pull-request-available > > The geode-native docs directory contains unused sources from the > pre-open-source days. The problem is that while they're not linked to the > user guide's T of C, these out-of-date docs are still included in the manual > build (a quirk of the toolset), where they can be accidentally discovered via > web searches. > These unused files need to be identified and deleted. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8388) Geode Native Client user guide: delete unused sources
[ https://issues.apache.org/jira/browse/GEODE-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17168941#comment-17168941 ] ASF subversion and git services commented on GEODE-8388: Commit ed18ce4d805250809e9d9a50770c954c05327e7e in geode-native's branch refs/heads/develop from Dave Barnes [ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=ed18ce4 ] GEODE-8388: Geode Native Client User Guide - delete unused source files (#631) > Geode Native Client user guide: delete unused sources > - > > Key: GEODE-8388 > URL: https://issues.apache.org/jira/browse/GEODE-8388 > Project: Geode > Issue Type: Bug > Components: docs, native client >Reporter: Dave Barnes >Assignee: Dave Barnes >Priority: Major > Labels: pull-request-available > > The geode-native docs directory contains unused sources from the > pre-open-source days. The problem is that while they're not linked to the > user guide's T of C, these out-of-date docs are still included in the manual > build (a quirk of the toolset), where they can be accidentally discovered via > web searches. > These unused files need to be identified and deleted. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8382) Run Redis tests against Redis API for Geode
[ https://issues.apache.org/jira/browse/GEODE-8382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17168869#comment-17168869 ] ASF GitHub Bot commented on GEODE-8382: --- sabbeyPivotal commented on pull request #5416: URL: https://github.com/apache/geode/pull/5416#issuecomment-667115984 > The pipeline linked is not publicly viewable, so it is harder to assert that it is indeed working Good point, Mike. The pipeline was tested locally, feel free to deploy a local version to make sure it works. DUnit failure is unrelated to this change. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Run Redis tests against Redis API for Geode > --- > > Key: GEODE-8382 > URL: https://issues.apache.org/jira/browse/GEODE-8382 > Project: Geode > Issue Type: New Feature > Components: ci, redis >Reporter: Sarah Abbey >Priority: Major > Labels: pull-request-available > > We would like to run Redis's tests against Redis API for Geode. Tests will > run a separate job in the PR and main pipelines. It has been included in the > 'tests' jinja variables. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8382) Run Redis tests against Redis API for Geode
[ https://issues.apache.org/jira/browse/GEODE-8382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17168446#comment-17168446 ] ASF GitHub Bot commented on GEODE-8382: --- moleske commented on pull request #5416: URL: https://github.com/apache/geode/pull/5416#issuecomment-666964959 The pipeline linked is not publicly viewable, so it is harder to assert that it is indeed working This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Run Redis tests against Redis API for Geode > --- > > Key: GEODE-8382 > URL: https://issues.apache.org/jira/browse/GEODE-8382 > Project: Geode > Issue Type: New Feature > Components: ci, redis >Reporter: Sarah Abbey >Priority: Major > Labels: pull-request-available > > We would like to run Redis's tests against Redis API for Geode. Tests will > run a separate job in the PR and main pipelines. It has been included in the > 'tests' jinja variables. -- This message was sent by Atlassian Jira (v8.3.4#803005)
