[jira] [Commented] (GEODE-8393) CI: CrashAndNoRepeatDUnitTest > givenServerCrashesDuringAPPEND_thenDataIsNotLost FAILED

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175173#comment-17175173
 ] 

ASF subversion and git services commented on GEODE-8393:


Commit d19368f7eb676026d1f921eac4106ff465131cc0 in geode's branch 
refs/heads/develop from Darrel Schneider
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=d19368f ]

Revert "GEODE-8393: change memberDeparted to disconnect the connection (#5431)" 
(#5441)

This reverts commit 0a91484b05f1caffa8cc3a59cc7fc38abe4376ed.

> CI: CrashAndNoRepeatDUnitTest > 
> givenServerCrashesDuringAPPEND_thenDataIsNotLost FAILED
> ---
>
> Key: GEODE-8393
> URL: https://issues.apache.org/jira/browse/GEODE-8393
> Project: Geode
>  Issue Type: Bug
>  Components: redis
>Reporter: Jinmei Liao
>Assignee: Darrel Schneider
>Priority: Major
>  Labels: CI, pull-request-available
>
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK11/builds/384
> org.apache.geode.redis.internal.executor.CrashAndNoRepeatDUnitTest > 
> givenServerCrashesDuringAPPEND_thenDataIsNotLost FAILED
> java.util.concurrent.ExecutionException: java.lang.AssertionError: 
> unexpected 0 at index 3967 in string 
> 

[jira] [Commented] (GEODE-8417) CI failure: SessionExpirationDUnitTest.sessionShouldTimeout_whenAppFailsOverToAnotherRedisServer fails with a timeout

2020-08-10 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175172#comment-17175172
 ] 

ASF GitHub Bot commented on GEODE-8417:
---

jdeppe-pivotal merged pull request #5441:
URL: https://github.com/apache/geode/pull/5441


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> CI failure: 
> SessionExpirationDUnitTest.sessionShouldTimeout_whenAppFailsOverToAnotherRedisServer
>  fails with a timeout
> -
>
> Key: GEODE-8417
> URL: https://issues.apache.org/jira/browse/GEODE-8417
> Project: Geode
>  Issue Type: Bug
>  Components: redis
>Reporter: Bruce J Schuchardt
>Assignee: Darrel Schneider
>Priority: Major
>  Labels: pull-request-available
>
> This test failed in a CI run:
> [https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK11/builds/402#L5f20d92c:648]
>  
> {noformat}
> org.apache.geode.redis.session.SessionExpirationDUnitTest > 
> sessionShouldTimeout_whenAppFailsOverToAnotherRedisServer FAILED
> 13:20:39org.awaitility.core.ConditionTimeoutException: Condition with 
> lambda expression in 
> org.apache.geode.redis.session.SessionExpirationDUnitTest that uses 
> java.lang.String was not fulfilled within 10 seconds.
> 13:20:39at 
> org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:165)
> 13:20:39at 
> org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
> 13:20:39at 
> org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
> 13:20:39at 
> org.awaitility.core.ConditionFactory.until(ConditionFactory.java:895)
> 13:20:39at 
> org.awaitility.core.ConditionFactory.until(ConditionFactory.java:864)
> 13:20:39at 
> org.apache.geode.redis.session.SessionExpirationDUnitTest.waitForTheSessionToExpire(SessionExpirationDUnitTest.java:113)
> 13:20:39at 
> org.apache.geode.redis.session.SessionExpirationDUnitTest.sessionShouldTimeout_whenAppFailsOverToAnotherRedisServer(SessionExpirationDUnitTest.java:93)
> 13:20:39
> 13:20:39Caused by:
> 13:20:39redis.clients.jedis.exceptions.JedisConnectionException: 
> java.net.SocketException: Broken pipe (Write failed)
> 13:20:39at 
> redis.clients.jedis.Protocol.sendCommand(Protocol.java:109)
> 13:20:39at 
> redis.clients.jedis.Protocol.sendCommand(Protocol.java:89)
> 13:20:39at 
> redis.clients.jedis.Connection.sendCommand(Connection.java:126)
> 13:20:39at 
> redis.clients.jedis.BinaryClient.ttl(BinaryClient.java:186)
> 13:20:39at redis.clients.jedis.Client.ttl(Client.java:114)
> 13:20:39at redis.clients.jedis.Jedis.ttl(Jedis.java:399)
> 13:20:39at 
> org.apache.geode.redis.session.SessionExpirationDUnitTest.lambda$waitForTheSessionToExpire$0(SessionExpirationDUnitTest.java:114)
> 13:20:39
> 13:20:39Caused by:
> 13:20:39java.net.SocketException: Broken pipe (Write failed)
> 13:20:39at java.net.SocketOutputStream.socketWrite0(Native 
> Method)
> 13:20:39at 
> java.net.SocketOutputStream.socketWrite(SocketOutputStream.java:110)
> 13:20:39at 
> java.net.SocketOutputStream.write(SocketOutputStream.java:150)
> 13:20:39at 
> redis.clients.jedis.util.RedisOutputStream.flushBuffer(RedisOutputStream.java:52)
> 13:20:39at 
> redis.clients.jedis.util.RedisOutputStream.write(RedisOutputStream.java:59)
> 13:20:39at 
> redis.clients.jedis.Protocol.sendCommand(Protocol.java:95)
> 13:20:39... 6 more
> 13:20:39 {noformat}
>  
> I bisected and found it started failing here:
> {noformat}
> commit 0a91484b05f1caffa8cc3a59cc7fc38abe4376ed
> Author: Darrel Schneider 
> Date:   Mon Aug 10 12:50:31 2020 -0700
> GEODE-8393: change memberDeparted to disconnect the connection (#5431)
> * server now disconnects connection if memberDeparted
> Co-authored-by: john Hutchison 
>  {noformat}
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7864) Code improvement refactoring

2020-08-10 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175138#comment-17175138
 ] 

ASF GitHub Bot commented on GEODE-7864:
---

DonalEvans opened a new pull request #5443:
URL: https://github.com/apache/geode/pull/5443


   Authored-by: Donal Evans 
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?
   
   - [x] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?
   
   - [x] Is your initial contribution a single, squashed commit?
   
   - [x] Does `gradlew build` run cleanly?
   
   - [N/A] Have you written or updated unit tests to verify your changes?
   
   - [N/A] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build 
issues and
   submit an update to your PR as soon as possible. If you need help, please 
send an
   email to d...@geode.apache.org.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Code improvement refactoring
> 
>
> Key: GEODE-7864
> URL: https://issues.apache.org/jira/browse/GEODE-7864
> Project: Geode
>  Issue Type: Improvement
>Reporter: Nabarun Nag
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 13h 10m
>  Remaining Estimate: 0h
>
> This is a placeholder ticket.
>  * this is used to do refactoring.
>  * this ticket number is used to number the commit message.
>  * this ticket will never be closed.
>  * it will be used to mark improvements like correcting spelling mistakes, 
> efficient java code, etc.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8420) Throw AssertionError when SQLException occurs in JdbcWriter

2020-08-10 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175121#comment-17175121
 ] 

ASF GitHub Bot commented on GEODE-8420:
---

masaki-yamakawa opened a new pull request #5442:
URL: https://github.com/apache/geode/pull/5442


   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [X] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?
   
   - [X] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?
   
   - [X] Is your initial contribution a single, squashed commit?
   
   - [X] Does `gradlew build` run cleanly?
   
   - [X] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build 
issues and
   submit an update to your PR as soon as possible. If you need help, please 
send an
   email to d...@geode.apache.org.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Throw AssertionError when SQLException occurs in JdbcWriter
> ---
>
> Key: GEODE-8420
> URL: https://issues.apache.org/jira/browse/GEODE-8420
> Project: Geode
>  Issue Type: Improvement
>  Components: jdbc
>Reporter: Masaki Yamakawa
>Priority: Minor
>
> When using JdbcWriter or JdbcAsyncWriter of Simple JDBC Connector, 
> SQLException occurs if you set the character string exceeding 10 digits in 
> the column defined as varchar(10) in RDB column.
> However, JdbcWriter and JdbcAsyncWriter throws AssertionError.
> This error is difficult to notice the problem, so I would like to change it 
> to throw SQLException.
> The cause is that the upsert of 
> `org.apache.geode.connectors.jdbc.internal.SqlHandler#write` is considered.
> There are cases in which SQLException is ignored during this consideration.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (GEODE-8420) Throw AssertionError when SQLException occurs in JdbcWriter

2020-08-10 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-8420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated GEODE-8420:
--
Labels: pull-request-available  (was: )

> Throw AssertionError when SQLException occurs in JdbcWriter
> ---
>
> Key: GEODE-8420
> URL: https://issues.apache.org/jira/browse/GEODE-8420
> Project: Geode
>  Issue Type: Improvement
>  Components: jdbc
>Reporter: Masaki Yamakawa
>Priority: Minor
>  Labels: pull-request-available
>
> When using JdbcWriter or JdbcAsyncWriter of Simple JDBC Connector, 
> SQLException occurs if you set the character string exceeding 10 digits in 
> the column defined as varchar(10) in RDB column.
> However, JdbcWriter and JdbcAsyncWriter throws AssertionError.
> This error is difficult to notice the problem, so I would like to change it 
> to throw SQLException.
> The cause is that the upsert of 
> `org.apache.geode.connectors.jdbc.internal.SqlHandler#write` is considered.
> There are cases in which SQLException is ignored during this consideration.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (GEODE-8420) Throw AssertionError when SQLException occurs in JdbcWriter

2020-08-10 Thread Masaki Yamakawa (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-8420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Masaki Yamakawa updated GEODE-8420:
---
Priority: Minor  (was: Major)

> Throw AssertionError when SQLException occurs in JdbcWriter
> ---
>
> Key: GEODE-8420
> URL: https://issues.apache.org/jira/browse/GEODE-8420
> Project: Geode
>  Issue Type: Improvement
>  Components: jdbc
>Reporter: Masaki Yamakawa
>Priority: Minor
>
> When using JdbcWriter or JdbcAsyncWriter of Simple JDBC Connector, 
> SQLException occurs if you set the character string exceeding 10 digits in 
> the column defined as varchar(10) in RDB column.
> However, JdbcWriter and JdbcAsyncWriter throws AssertionError.
> This error is difficult to notice the problem, so I would like to change it 
> to throw SQLException.
> The cause is that the upsert of 
> `org.apache.geode.connectors.jdbc.internal.SqlHandler#write` is considered.
> There are cases in which SQLException is ignored during this consideration.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (GEODE-8420) Throw AssertionError when SQLException occurs in JdbcWriter

2020-08-10 Thread Masaki Yamakawa (Jira)
Masaki Yamakawa created GEODE-8420:
--

 Summary: Throw AssertionError when SQLException occurs in 
JdbcWriter
 Key: GEODE-8420
 URL: https://issues.apache.org/jira/browse/GEODE-8420
 Project: Geode
  Issue Type: Improvement
  Components: jdbc
Reporter: Masaki Yamakawa


When using JdbcWriter or JdbcAsyncWriter of Simple JDBC Connector, SQLException 
occurs if you set the character string exceeding 10 digits in the column 
defined as varchar(10) in RDB column.
However, JdbcWriter and JdbcAsyncWriter throws AssertionError.

This error is difficult to notice the problem, so I would like to change it to 
throw SQLException.

The cause is that the upsert of 
`org.apache.geode.connectors.jdbc.internal.SqlHandler#write` is considered.
There are cases in which SQLException is ignored during this consideration.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (GEODE-8419) SSL/TLS protocol and cipher suite configuration is ignored

2020-08-10 Thread Jacob Barrett (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-8419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacob Barrett updated GEODE-8419:
-
Affects Version/s: 1.14.0
   1.13.0
   1.10.0
   1.11.0
   1.12.0

> SSL/TLS protocol and cipher suite configuration is ignored
> --
>
> Key: GEODE-8419
> URL: https://issues.apache.org/jira/browse/GEODE-8419
> Project: Geode
>  Issue Type: Bug
>  Components: client/server, membership, security
>Affects Versions: 1.10.0, 1.11.0, 1.12.0, 1.13.0, 1.14.0
>Reporter: Jacob Barrett
>Priority: Major
>
> Configuring {{ssl-protocols}} or {{ssl-ciphers}} properties, or per-component 
> ssl properties, have no effect. Configuring {{ssl-protocols}} may effect the 
> {{SSLContext}} selected and limit some of the protocols allowed but does not 
> restrict to just the set specified in the property. The {{ssl-ciphers}} 
> property does not limit cipher selection at all.
> The result is that all ciphers allowed under the match {{SSLContext}} are 
> allowed and negotiated. This can result in an unintended cipher being used in 
> SSL/TLS communication. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (GEODE-8419) SSL/TLS protocol and cipher suite configuration is ignored

2020-08-10 Thread Jacob Barrett (Jira)
Jacob Barrett created GEODE-8419:


 Summary: SSL/TLS protocol and cipher suite configuration is ignored
 Key: GEODE-8419
 URL: https://issues.apache.org/jira/browse/GEODE-8419
 Project: Geode
  Issue Type: Bug
  Components: client/server, membership, security
Reporter: Jacob Barrett


Configuring {{ssl-protocols}} or {{ssl-ciphers}} properties, or per-component 
ssl properties, have no effect. Configuring {{ssl-protocols}} may effect the 
{{SSLContext}} selected and limit some of the protocols allowed but does not 
restrict to just the set specified in the property. The {{ssl-ciphers}} 
property does not limit cipher selection at all.

The result is that all ciphers allowed under the match {{SSLContext}} are 
allowed and negotiated. This can result in an unintended cipher being used in 
SSL/TLS communication. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (GEODE-8418) CI failure: HashesAndCrashesDUnitTest.givenServerCrashesDuringSET_thenDataIsNotLost

2020-08-10 Thread Darrel Schneider (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-8418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darrel Schneider reassigned GEODE-8418:
---

Assignee: Darrel Schneider

> CI failure: 
> HashesAndCrashesDUnitTest.givenServerCrashesDuringSET_thenDataIsNotLost
> ---
>
> Key: GEODE-8418
> URL: https://issues.apache.org/jira/browse/GEODE-8418
> Project: Geode
>  Issue Type: Bug
>  Components: redis
>Reporter: Bruce J Schuchardt
>Assignee: Darrel Schneider
>Priority: Major
>
> This redis test failed in a CI run:
> [https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK8/builds/414]
> {noformat}
> org.apache.geode.redis.internal.executor.hash.HashesAndCrashesDUnitTest > 
> givenServerCrashesDuringSET_thenDataIsNotLost FAILED
> 13:18:47java.util.concurrent.ExecutionException: 
> io.lettuce.core.RedisException: 
> io.netty.channel.unix.Errors$NativeIoException: readAddress(..) failed: 
> Connection reset by peer
> 13:18:47at 
> java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:357)
> 13:18:47at 
> java.util.concurrent.CompletableFuture.get(CompletableFuture.java:1908)
> 13:18:47at 
> org.apache.geode.redis.internal.executor.hash.HashesAndCrashesDUnitTest.modifyDataWhileCrashingVMs(HashesAndCrashesDUnitTest.java:239)
> 13:18:47at 
> org.apache.geode.redis.internal.executor.hash.HashesAndCrashesDUnitTest.givenServerCrashesDuringSET_thenDataIsNotLost(HashesAndCrashesDUnitTest.java:174)
> 13:18:47
> 13:18:47Caused by:
> 13:18:47io.lettuce.core.RedisException: 
> io.netty.channel.unix.Errors$NativeIoException: readAddress(..) failed: 
> Connection reset by peer
> 13:18:47at 
> io.lettuce.core.LettuceFutures.awaitOrCancel(LettuceFutures.java:129)
> 13:18:47at 
> io.lettuce.core.FutureSyncInvocationHandler.handleInvocation(FutureSyncInvocationHandler.java:69)
> 13:18:47at 
> io.lettuce.core.internal.AbstractInvocationHandler.invoke(AbstractInvocationHandler.java:80)
> 13:18:47at com.sun.proxy.$Proxy70.set(Unknown Source)
> 13:18:47at 
> org.apache.geode.redis.internal.executor.hash.HashesAndCrashesDUnitTest.setPerformAndVerify(HashesAndCrashesDUnitTest.java:296)
> 13:18:47at 
> org.apache.geode.redis.internal.executor.hash.HashesAndCrashesDUnitTest.lambda$modifyDataWhileCrashingVMs$9(HashesAndCrashesDUnitTest.java:206)
> 13:18:47
> 13:18:47Caused by:
> 13:18:47io.netty.channel.unix.Errors$NativeIoException: 
> readAddress(..) failed: Connection reset by peer
> 13:20:00
> 13:20:00org.apache.geode.redis.internal.executor.hash.HashesAndCrashesDUnitTest
>  > givenServerCrashesDuringSADD_thenDataIsNotLost FAILED
> 13:20:00java.util.concurrent.ExecutionException: 
> io.lettuce.core.RedisException: 
> io.netty.channel.unix.Errors$NativeIoException: readAddress(..) failed: 
> Connection reset by peer
> 13:20:00at 
> java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:357)
> 13:20:00at 
> java.util.concurrent.CompletableFuture.get(CompletableFuture.java:1908)
> 13:20:00at 
> org.apache.geode.redis.internal.executor.hash.HashesAndCrashesDUnitTest.modifyDataWhileCrashingVMs(HashesAndCrashesDUnitTest.java:239)
> 13:20:00at 
> org.apache.geode.redis.internal.executor.hash.HashesAndCrashesDUnitTest.givenServerCrashesDuringSADD_thenDataIsNotLost(HashesAndCrashesDUnitTest.java:169)
> 13:20:00
> 13:20:00Caused by:
> 13:20:00io.lettuce.core.RedisException: 
> io.netty.channel.unix.Errors$NativeIoException: readAddress(..) failed: 
> Connection reset by peer
> 13:20:00at 
> io.lettuce.core.LettuceFutures.awaitOrCancel(LettuceFutures.java:129)
> 13:20:00at 
> io.lettuce.core.FutureSyncInvocationHandler.handleInvocation(FutureSyncInvocationHandler.java:69)
> 13:20:00at 
> io.lettuce.core.internal.AbstractInvocationHandler.invoke(AbstractInvocationHandler.java:80)
> 13:20:00at com.sun.proxy.$Proxy70.sadd(Unknown Source)
> 13:20:00at 
> org.apache.geode.redis.internal.executor.hash.HashesAndCrashesDUnitTest.saddPerformAndVerify(HashesAndCrashesDUnitTest.java:272)
> 13:20:00at 
> org.apache.geode.redis.internal.executor.hash.HashesAndCrashesDUnitTest.lambda$modifyDataWhileCrashingVMs$5(HashesAndCrashesDUnitTest.java:200)
> 13:20:00
> 13:20:00Caused by:
> 13:20:00io.netty.channel.unix.Errors$NativeIoException: 
> readAddress(..) failed: Connection reset by peer {noformat}
>  
> I bisected and think this commit introduced the failure:
> {noformat}
> commit 0a91484b05f1caffa8cc3a59cc7fc38abe4376ed (HEAD)
> Author: Darrel 

[jira] [Assigned] (GEODE-8417) CI failure: SessionExpirationDUnitTest.sessionShouldTimeout_whenAppFailsOverToAnotherRedisServer fails with a timeout

2020-08-10 Thread Darrel Schneider (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-8417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darrel Schneider reassigned GEODE-8417:
---

Assignee: Darrel Schneider

> CI failure: 
> SessionExpirationDUnitTest.sessionShouldTimeout_whenAppFailsOverToAnotherRedisServer
>  fails with a timeout
> -
>
> Key: GEODE-8417
> URL: https://issues.apache.org/jira/browse/GEODE-8417
> Project: Geode
>  Issue Type: Bug
>  Components: redis
>Reporter: Bruce J Schuchardt
>Assignee: Darrel Schneider
>Priority: Major
>  Labels: pull-request-available
>
> This test failed in a CI run:
> [https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK11/builds/402#L5f20d92c:648]
>  
> {noformat}
> org.apache.geode.redis.session.SessionExpirationDUnitTest > 
> sessionShouldTimeout_whenAppFailsOverToAnotherRedisServer FAILED
> 13:20:39org.awaitility.core.ConditionTimeoutException: Condition with 
> lambda expression in 
> org.apache.geode.redis.session.SessionExpirationDUnitTest that uses 
> java.lang.String was not fulfilled within 10 seconds.
> 13:20:39at 
> org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:165)
> 13:20:39at 
> org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
> 13:20:39at 
> org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
> 13:20:39at 
> org.awaitility.core.ConditionFactory.until(ConditionFactory.java:895)
> 13:20:39at 
> org.awaitility.core.ConditionFactory.until(ConditionFactory.java:864)
> 13:20:39at 
> org.apache.geode.redis.session.SessionExpirationDUnitTest.waitForTheSessionToExpire(SessionExpirationDUnitTest.java:113)
> 13:20:39at 
> org.apache.geode.redis.session.SessionExpirationDUnitTest.sessionShouldTimeout_whenAppFailsOverToAnotherRedisServer(SessionExpirationDUnitTest.java:93)
> 13:20:39
> 13:20:39Caused by:
> 13:20:39redis.clients.jedis.exceptions.JedisConnectionException: 
> java.net.SocketException: Broken pipe (Write failed)
> 13:20:39at 
> redis.clients.jedis.Protocol.sendCommand(Protocol.java:109)
> 13:20:39at 
> redis.clients.jedis.Protocol.sendCommand(Protocol.java:89)
> 13:20:39at 
> redis.clients.jedis.Connection.sendCommand(Connection.java:126)
> 13:20:39at 
> redis.clients.jedis.BinaryClient.ttl(BinaryClient.java:186)
> 13:20:39at redis.clients.jedis.Client.ttl(Client.java:114)
> 13:20:39at redis.clients.jedis.Jedis.ttl(Jedis.java:399)
> 13:20:39at 
> org.apache.geode.redis.session.SessionExpirationDUnitTest.lambda$waitForTheSessionToExpire$0(SessionExpirationDUnitTest.java:114)
> 13:20:39
> 13:20:39Caused by:
> 13:20:39java.net.SocketException: Broken pipe (Write failed)
> 13:20:39at java.net.SocketOutputStream.socketWrite0(Native 
> Method)
> 13:20:39at 
> java.net.SocketOutputStream.socketWrite(SocketOutputStream.java:110)
> 13:20:39at 
> java.net.SocketOutputStream.write(SocketOutputStream.java:150)
> 13:20:39at 
> redis.clients.jedis.util.RedisOutputStream.flushBuffer(RedisOutputStream.java:52)
> 13:20:39at 
> redis.clients.jedis.util.RedisOutputStream.write(RedisOutputStream.java:59)
> 13:20:39at 
> redis.clients.jedis.Protocol.sendCommand(Protocol.java:95)
> 13:20:39... 6 more
> 13:20:39 {noformat}
>  
> I bisected and found it started failing here:
> {noformat}
> commit 0a91484b05f1caffa8cc3a59cc7fc38abe4376ed
> Author: Darrel Schneider 
> Date:   Mon Aug 10 12:50:31 2020 -0700
> GEODE-8393: change memberDeparted to disconnect the connection (#5431)
> * server now disconnects connection if memberDeparted
> Co-authored-by: john Hutchison 
>  {noformat}
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (GEODE-8417) CI failure: SessionExpirationDUnitTest.sessionShouldTimeout_whenAppFailsOverToAnotherRedisServer fails with a timeout

2020-08-10 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-8417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated GEODE-8417:
--
Labels: pull-request-available  (was: )

> CI failure: 
> SessionExpirationDUnitTest.sessionShouldTimeout_whenAppFailsOverToAnotherRedisServer
>  fails with a timeout
> -
>
> Key: GEODE-8417
> URL: https://issues.apache.org/jira/browse/GEODE-8417
> Project: Geode
>  Issue Type: Bug
>  Components: redis
>Reporter: Bruce J Schuchardt
>Priority: Major
>  Labels: pull-request-available
>
> This test failed in a CI run:
> [https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK11/builds/402#L5f20d92c:648]
>  
> {noformat}
> org.apache.geode.redis.session.SessionExpirationDUnitTest > 
> sessionShouldTimeout_whenAppFailsOverToAnotherRedisServer FAILED
> 13:20:39org.awaitility.core.ConditionTimeoutException: Condition with 
> lambda expression in 
> org.apache.geode.redis.session.SessionExpirationDUnitTest that uses 
> java.lang.String was not fulfilled within 10 seconds.
> 13:20:39at 
> org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:165)
> 13:20:39at 
> org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
> 13:20:39at 
> org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
> 13:20:39at 
> org.awaitility.core.ConditionFactory.until(ConditionFactory.java:895)
> 13:20:39at 
> org.awaitility.core.ConditionFactory.until(ConditionFactory.java:864)
> 13:20:39at 
> org.apache.geode.redis.session.SessionExpirationDUnitTest.waitForTheSessionToExpire(SessionExpirationDUnitTest.java:113)
> 13:20:39at 
> org.apache.geode.redis.session.SessionExpirationDUnitTest.sessionShouldTimeout_whenAppFailsOverToAnotherRedisServer(SessionExpirationDUnitTest.java:93)
> 13:20:39
> 13:20:39Caused by:
> 13:20:39redis.clients.jedis.exceptions.JedisConnectionException: 
> java.net.SocketException: Broken pipe (Write failed)
> 13:20:39at 
> redis.clients.jedis.Protocol.sendCommand(Protocol.java:109)
> 13:20:39at 
> redis.clients.jedis.Protocol.sendCommand(Protocol.java:89)
> 13:20:39at 
> redis.clients.jedis.Connection.sendCommand(Connection.java:126)
> 13:20:39at 
> redis.clients.jedis.BinaryClient.ttl(BinaryClient.java:186)
> 13:20:39at redis.clients.jedis.Client.ttl(Client.java:114)
> 13:20:39at redis.clients.jedis.Jedis.ttl(Jedis.java:399)
> 13:20:39at 
> org.apache.geode.redis.session.SessionExpirationDUnitTest.lambda$waitForTheSessionToExpire$0(SessionExpirationDUnitTest.java:114)
> 13:20:39
> 13:20:39Caused by:
> 13:20:39java.net.SocketException: Broken pipe (Write failed)
> 13:20:39at java.net.SocketOutputStream.socketWrite0(Native 
> Method)
> 13:20:39at 
> java.net.SocketOutputStream.socketWrite(SocketOutputStream.java:110)
> 13:20:39at 
> java.net.SocketOutputStream.write(SocketOutputStream.java:150)
> 13:20:39at 
> redis.clients.jedis.util.RedisOutputStream.flushBuffer(RedisOutputStream.java:52)
> 13:20:39at 
> redis.clients.jedis.util.RedisOutputStream.write(RedisOutputStream.java:59)
> 13:20:39at 
> redis.clients.jedis.Protocol.sendCommand(Protocol.java:95)
> 13:20:39... 6 more
> 13:20:39 {noformat}
>  
> I bisected and found it started failing here:
> {noformat}
> commit 0a91484b05f1caffa8cc3a59cc7fc38abe4376ed
> Author: Darrel Schneider 
> Date:   Mon Aug 10 12:50:31 2020 -0700
> GEODE-8393: change memberDeparted to disconnect the connection (#5431)
> * server now disconnects connection if memberDeparted
> Co-authored-by: john Hutchison 
>  {noformat}
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8417) CI failure: SessionExpirationDUnitTest.sessionShouldTimeout_whenAppFailsOverToAnotherRedisServer fails with a timeout

2020-08-10 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175112#comment-17175112
 ] 

ASF GitHub Bot commented on GEODE-8417:
---

dschneider-pivotal opened a new pull request #5441:
URL: https://github.com/apache/geode/pull/5441


   The fix for GEODE-8393 seems to have caused both GEODE-8417 and GEODE-8418.
   This revert should fix those new issues.
   
   This reverts commit 0a91484b05f1caffa8cc3a59cc7fc38abe4376ed.
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build 
issues and
   submit an update to your PR as soon as possible. If you need help, please 
send an
   email to d...@geode.apache.org.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> CI failure: 
> SessionExpirationDUnitTest.sessionShouldTimeout_whenAppFailsOverToAnotherRedisServer
>  fails with a timeout
> -
>
> Key: GEODE-8417
> URL: https://issues.apache.org/jira/browse/GEODE-8417
> Project: Geode
>  Issue Type: Bug
>  Components: redis
>Reporter: Bruce J Schuchardt
>Priority: Major
>
> This test failed in a CI run:
> [https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK11/builds/402#L5f20d92c:648]
>  
> {noformat}
> org.apache.geode.redis.session.SessionExpirationDUnitTest > 
> sessionShouldTimeout_whenAppFailsOverToAnotherRedisServer FAILED
> 13:20:39org.awaitility.core.ConditionTimeoutException: Condition with 
> lambda expression in 
> org.apache.geode.redis.session.SessionExpirationDUnitTest that uses 
> java.lang.String was not fulfilled within 10 seconds.
> 13:20:39at 
> org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:165)
> 13:20:39at 
> org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
> 13:20:39at 
> org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
> 13:20:39at 
> org.awaitility.core.ConditionFactory.until(ConditionFactory.java:895)
> 13:20:39at 
> org.awaitility.core.ConditionFactory.until(ConditionFactory.java:864)
> 13:20:39at 
> org.apache.geode.redis.session.SessionExpirationDUnitTest.waitForTheSessionToExpire(SessionExpirationDUnitTest.java:113)
> 13:20:39at 
> org.apache.geode.redis.session.SessionExpirationDUnitTest.sessionShouldTimeout_whenAppFailsOverToAnotherRedisServer(SessionExpirationDUnitTest.java:93)
> 13:20:39
> 13:20:39Caused by:
> 13:20:39redis.clients.jedis.exceptions.JedisConnectionException: 
> java.net.SocketException: Broken pipe (Write failed)
> 13:20:39at 
> redis.clients.jedis.Protocol.sendCommand(Protocol.java:109)
> 13:20:39at 
> redis.clients.jedis.Protocol.sendCommand(Protocol.java:89)
> 13:20:39at 
> redis.clients.jedis.Connection.sendCommand(Connection.java:126)
> 13:20:39at 
> redis.clients.jedis.BinaryClient.ttl(BinaryClient.java:186)
> 13:20:39at redis.clients.jedis.Client.ttl(Client.java:114)
> 13:20:39at redis.clients.jedis.Jedis.ttl(Jedis.java:399)
> 13:20:39at 
> org.apache.geode.redis.session.SessionExpirationDUnitTest.lambda$waitForTheSessionToExpire$0(SessionExpirationDUnitTest.java:114)
> 13:20:39
> 13:20:39Caused by:
> 13:20:39java.net.SocketException: Broken pipe (Write failed)
> 13:20:39at java.net.SocketOutputStream.socketWrite0(Native 
> Method)
> 13:20:39at 
> java.net.SocketOutputStream.socketWrite(SocketOutputStream.java:110)
> 13:20:39at 
> java.net.SocketOutputStream.write(SocketOutputStream.java:150)
> 13:20:39 

[jira] [Commented] (GEODE-8406) enable early-return for CI only changes in Geode Concourse

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175106#comment-17175106
 ] 

ASF subversion and git services commented on GEODE-8406:


Commit 0e31dd1fd9c421c62c4aa24705834a0899c496cf in geode's branch 
refs/heads/develop from Robert Houghton
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=0e31dd1 ]

GEODE-8406: Make early-return immune to the Geode dir not existing (#5440)



> enable early-return for CI only changes in Geode Concourse
> --
>
> Key: GEODE-8406
> URL: https://issues.apache.org/jira/browse/GEODE-8406
> Project: Geode
>  Issue Type: Improvement
>  Components: ci
>Reporter: Robert Houghton
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> The Geode Concourse PR pipeline pulls the _ci_ scripts from upstream, not the 
> code under test. Ergo, CI changes are untestable by the main CI itself, and 
> running the PR jobs is useless, and costly.
> GitHub does not allow granular control of what directories require a _status_ 
> to allow merging, so our solution is to short circuit the work for CI-only 
> PRs, allowing the status to be set.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8406) enable early-return for CI only changes in Geode Concourse

2020-08-10 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175105#comment-17175105
 ] 

ASF GitHub Bot commented on GEODE-8406:
---

rhoughton-pivot merged pull request #5440:
URL: https://github.com/apache/geode/pull/5440


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> enable early-return for CI only changes in Geode Concourse
> --
>
> Key: GEODE-8406
> URL: https://issues.apache.org/jira/browse/GEODE-8406
> Project: Geode
>  Issue Type: Improvement
>  Components: ci
>Reporter: Robert Houghton
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> The Geode Concourse PR pipeline pulls the _ci_ scripts from upstream, not the 
> code under test. Ergo, CI changes are untestable by the main CI itself, and 
> running the PR jobs is useless, and costly.
> GitHub does not allow granular control of what directories require a _status_ 
> to allow merging, so our solution is to short circuit the work for CI-only 
> PRs, allowing the status to be set.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8337) Rename Version enum to KnownVersion; VersionOrdinal to Version

2020-08-10 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175104#comment-17175104
 ] 

ASF GitHub Bot commented on GEODE-8337:
---

Bill edited a comment on pull request #5409:
URL: https://github.com/apache/geode/pull/5409#issuecomment-667208641


   sorry about the confusion @bschuchardt…
   
   I had to revert due to test failures in proprietary code. No changes were 
needed to this code, as it turns out. But it's taken me a long time to fix that 
proprietary code. I believe I have it fixed now.
   
   There are no unapproved changes in this PR. It's merely cherry-picking 
(commits for) two formerly approved PRs.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Rename Version enum to KnownVersion; VersionOrdinal to Version
> --
>
> Key: GEODE-8337
> URL: https://issues.apache.org/jira/browse/GEODE-8337
> Project: Geode
>  Issue Type: Improvement
>  Components: serialization
>Reporter: Bill Burcham
>Assignee: Bill Burcham
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.14.0
>
> Attachments: screenshot-1.png, screenshot-2.png
>
>
> As a follow-on to GEODE-8240 and GEODE-8330, this is the final ticket, to 
> rename:
> {{Version}} -> {{KnownVersion}}
> {{VersionOrdinal}} -> {{Version}}
> With this ticket, the work started in GEODE-8240 is complete.
> After this change, the versioning hierarchy will be:
>  !screenshot-1.png! 
> Before this change, the hierarchy was:
>  !screenshot-2.png! 
> As part of this story we'll also harmonize version access methods on 
> MemberIdentifier, InternalDistributedMember, and GMSMemberData:
> getVersionOrdinalObject() becomes getVersion()
> On GMSMemberData:
> setVersionObjectForTest() becomes setVersionForTest()



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8406) enable early-return for CI only changes in Geode Concourse

2020-08-10 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175095#comment-17175095
 ] 

ASF GitHub Bot commented on GEODE-8406:
---

rhoughton-pivot opened a new pull request #5440:
URL: https://github.com/apache/geode/pull/5440


   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [X] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?
   
   - [X] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?
   
   - [X] Is your initial contribution a single, squashed commit?
   
   - [X] Does `gradlew build` run cleanly?
   
   - [n/a] Have you written or updated unit tests to verify your changes?
   
   - [n/a] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build 
issues and
   submit an update to your PR as soon as possible. If you need help, please 
send an
   email to d...@geode.apache.org.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> enable early-return for CI only changes in Geode Concourse
> --
>
> Key: GEODE-8406
> URL: https://issues.apache.org/jira/browse/GEODE-8406
> Project: Geode
>  Issue Type: Improvement
>  Components: ci
>Reporter: Robert Houghton
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> The Geode Concourse PR pipeline pulls the _ci_ scripts from upstream, not the 
> code under test. Ergo, CI changes are untestable by the main CI itself, and 
> running the PR jobs is useless, and costly.
> GitHub does not allow granular control of what directories require a _status_ 
> to allow merging, so our solution is to short circuit the work for CI-only 
> PRs, allowing the status to be set.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (GEODE-8417) CI failure: SessionExpirationDUnitTest.sessionShouldTimeout_whenAppFailsOverToAnotherRedisServer fails with a timeout

2020-08-10 Thread Bruce J Schuchardt (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-8417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bruce J Schuchardt updated GEODE-8417:
--
Component/s: redis

> CI failure: 
> SessionExpirationDUnitTest.sessionShouldTimeout_whenAppFailsOverToAnotherRedisServer
>  fails with a timeout
> -
>
> Key: GEODE-8417
> URL: https://issues.apache.org/jira/browse/GEODE-8417
> Project: Geode
>  Issue Type: Bug
>  Components: redis
>Reporter: Bruce J Schuchardt
>Priority: Major
>
> This test failed in a CI run:
> [https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK11/builds/402#L5f20d92c:648]
>  
> {noformat}
> org.apache.geode.redis.session.SessionExpirationDUnitTest > 
> sessionShouldTimeout_whenAppFailsOverToAnotherRedisServer FAILED
> 13:20:39org.awaitility.core.ConditionTimeoutException: Condition with 
> lambda expression in 
> org.apache.geode.redis.session.SessionExpirationDUnitTest that uses 
> java.lang.String was not fulfilled within 10 seconds.
> 13:20:39at 
> org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:165)
> 13:20:39at 
> org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
> 13:20:39at 
> org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
> 13:20:39at 
> org.awaitility.core.ConditionFactory.until(ConditionFactory.java:895)
> 13:20:39at 
> org.awaitility.core.ConditionFactory.until(ConditionFactory.java:864)
> 13:20:39at 
> org.apache.geode.redis.session.SessionExpirationDUnitTest.waitForTheSessionToExpire(SessionExpirationDUnitTest.java:113)
> 13:20:39at 
> org.apache.geode.redis.session.SessionExpirationDUnitTest.sessionShouldTimeout_whenAppFailsOverToAnotherRedisServer(SessionExpirationDUnitTest.java:93)
> 13:20:39
> 13:20:39Caused by:
> 13:20:39redis.clients.jedis.exceptions.JedisConnectionException: 
> java.net.SocketException: Broken pipe (Write failed)
> 13:20:39at 
> redis.clients.jedis.Protocol.sendCommand(Protocol.java:109)
> 13:20:39at 
> redis.clients.jedis.Protocol.sendCommand(Protocol.java:89)
> 13:20:39at 
> redis.clients.jedis.Connection.sendCommand(Connection.java:126)
> 13:20:39at 
> redis.clients.jedis.BinaryClient.ttl(BinaryClient.java:186)
> 13:20:39at redis.clients.jedis.Client.ttl(Client.java:114)
> 13:20:39at redis.clients.jedis.Jedis.ttl(Jedis.java:399)
> 13:20:39at 
> org.apache.geode.redis.session.SessionExpirationDUnitTest.lambda$waitForTheSessionToExpire$0(SessionExpirationDUnitTest.java:114)
> 13:20:39
> 13:20:39Caused by:
> 13:20:39java.net.SocketException: Broken pipe (Write failed)
> 13:20:39at java.net.SocketOutputStream.socketWrite0(Native 
> Method)
> 13:20:39at 
> java.net.SocketOutputStream.socketWrite(SocketOutputStream.java:110)
> 13:20:39at 
> java.net.SocketOutputStream.write(SocketOutputStream.java:150)
> 13:20:39at 
> redis.clients.jedis.util.RedisOutputStream.flushBuffer(RedisOutputStream.java:52)
> 13:20:39at 
> redis.clients.jedis.util.RedisOutputStream.write(RedisOutputStream.java:59)
> 13:20:39at 
> redis.clients.jedis.Protocol.sendCommand(Protocol.java:95)
> 13:20:39... 6 more
> 13:20:39 {noformat}
>  
> I bisected and found it started failing here:
> {noformat}
> commit 0a91484b05f1caffa8cc3a59cc7fc38abe4376ed
> Author: Darrel Schneider 
> Date:   Mon Aug 10 12:50:31 2020 -0700
> GEODE-8393: change memberDeparted to disconnect the connection (#5431)
> * server now disconnects connection if memberDeparted
> Co-authored-by: john Hutchison 
>  {noformat}
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (GEODE-8418) CI failure: HashesAndCrashesDUnitTest.givenServerCrashesDuringSET_thenDataIsNotLost

2020-08-10 Thread Bruce J Schuchardt (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-8418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bruce J Schuchardt updated GEODE-8418:
--
Component/s: redis

> CI failure: 
> HashesAndCrashesDUnitTest.givenServerCrashesDuringSET_thenDataIsNotLost
> ---
>
> Key: GEODE-8418
> URL: https://issues.apache.org/jira/browse/GEODE-8418
> Project: Geode
>  Issue Type: Bug
>  Components: redis
>Reporter: Bruce J Schuchardt
>Priority: Major
>
> This redis test failed in a CI run:
> [https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK8/builds/414]
> {noformat}
> org.apache.geode.redis.internal.executor.hash.HashesAndCrashesDUnitTest > 
> givenServerCrashesDuringSET_thenDataIsNotLost FAILED
> 13:18:47java.util.concurrent.ExecutionException: 
> io.lettuce.core.RedisException: 
> io.netty.channel.unix.Errors$NativeIoException: readAddress(..) failed: 
> Connection reset by peer
> 13:18:47at 
> java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:357)
> 13:18:47at 
> java.util.concurrent.CompletableFuture.get(CompletableFuture.java:1908)
> 13:18:47at 
> org.apache.geode.redis.internal.executor.hash.HashesAndCrashesDUnitTest.modifyDataWhileCrashingVMs(HashesAndCrashesDUnitTest.java:239)
> 13:18:47at 
> org.apache.geode.redis.internal.executor.hash.HashesAndCrashesDUnitTest.givenServerCrashesDuringSET_thenDataIsNotLost(HashesAndCrashesDUnitTest.java:174)
> 13:18:47
> 13:18:47Caused by:
> 13:18:47io.lettuce.core.RedisException: 
> io.netty.channel.unix.Errors$NativeIoException: readAddress(..) failed: 
> Connection reset by peer
> 13:18:47at 
> io.lettuce.core.LettuceFutures.awaitOrCancel(LettuceFutures.java:129)
> 13:18:47at 
> io.lettuce.core.FutureSyncInvocationHandler.handleInvocation(FutureSyncInvocationHandler.java:69)
> 13:18:47at 
> io.lettuce.core.internal.AbstractInvocationHandler.invoke(AbstractInvocationHandler.java:80)
> 13:18:47at com.sun.proxy.$Proxy70.set(Unknown Source)
> 13:18:47at 
> org.apache.geode.redis.internal.executor.hash.HashesAndCrashesDUnitTest.setPerformAndVerify(HashesAndCrashesDUnitTest.java:296)
> 13:18:47at 
> org.apache.geode.redis.internal.executor.hash.HashesAndCrashesDUnitTest.lambda$modifyDataWhileCrashingVMs$9(HashesAndCrashesDUnitTest.java:206)
> 13:18:47
> 13:18:47Caused by:
> 13:18:47io.netty.channel.unix.Errors$NativeIoException: 
> readAddress(..) failed: Connection reset by peer
> 13:20:00
> 13:20:00org.apache.geode.redis.internal.executor.hash.HashesAndCrashesDUnitTest
>  > givenServerCrashesDuringSADD_thenDataIsNotLost FAILED
> 13:20:00java.util.concurrent.ExecutionException: 
> io.lettuce.core.RedisException: 
> io.netty.channel.unix.Errors$NativeIoException: readAddress(..) failed: 
> Connection reset by peer
> 13:20:00at 
> java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:357)
> 13:20:00at 
> java.util.concurrent.CompletableFuture.get(CompletableFuture.java:1908)
> 13:20:00at 
> org.apache.geode.redis.internal.executor.hash.HashesAndCrashesDUnitTest.modifyDataWhileCrashingVMs(HashesAndCrashesDUnitTest.java:239)
> 13:20:00at 
> org.apache.geode.redis.internal.executor.hash.HashesAndCrashesDUnitTest.givenServerCrashesDuringSADD_thenDataIsNotLost(HashesAndCrashesDUnitTest.java:169)
> 13:20:00
> 13:20:00Caused by:
> 13:20:00io.lettuce.core.RedisException: 
> io.netty.channel.unix.Errors$NativeIoException: readAddress(..) failed: 
> Connection reset by peer
> 13:20:00at 
> io.lettuce.core.LettuceFutures.awaitOrCancel(LettuceFutures.java:129)
> 13:20:00at 
> io.lettuce.core.FutureSyncInvocationHandler.handleInvocation(FutureSyncInvocationHandler.java:69)
> 13:20:00at 
> io.lettuce.core.internal.AbstractInvocationHandler.invoke(AbstractInvocationHandler.java:80)
> 13:20:00at com.sun.proxy.$Proxy70.sadd(Unknown Source)
> 13:20:00at 
> org.apache.geode.redis.internal.executor.hash.HashesAndCrashesDUnitTest.saddPerformAndVerify(HashesAndCrashesDUnitTest.java:272)
> 13:20:00at 
> org.apache.geode.redis.internal.executor.hash.HashesAndCrashesDUnitTest.lambda$modifyDataWhileCrashingVMs$5(HashesAndCrashesDUnitTest.java:200)
> 13:20:00
> 13:20:00Caused by:
> 13:20:00io.netty.channel.unix.Errors$NativeIoException: 
> readAddress(..) failed: Connection reset by peer {noformat}
>  
> I bisected and think this commit introduced the failure:
> {noformat}
> commit 0a91484b05f1caffa8cc3a59cc7fc38abe4376ed (HEAD)
> Author: Darrel Schneider 
> Date:   Mon Aug 10 12:50:31 2020 

[jira] [Created] (GEODE-8418) CI failure: HashesAndCrashesDUnitTest.givenServerCrashesDuringSET_thenDataIsNotLost

2020-08-10 Thread Bruce J Schuchardt (Jira)
Bruce J Schuchardt created GEODE-8418:
-

 Summary: CI failure: 
HashesAndCrashesDUnitTest.givenServerCrashesDuringSET_thenDataIsNotLost
 Key: GEODE-8418
 URL: https://issues.apache.org/jira/browse/GEODE-8418
 Project: Geode
  Issue Type: Bug
Reporter: Bruce J Schuchardt


This redis test failed in a CI run:

[https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK8/builds/414]
{noformat}
org.apache.geode.redis.internal.executor.hash.HashesAndCrashesDUnitTest > 
givenServerCrashesDuringSET_thenDataIsNotLost FAILED
13:18:47java.util.concurrent.ExecutionException: 
io.lettuce.core.RedisException: io.netty.channel.unix.Errors$NativeIoException: 
readAddress(..) failed: Connection reset by peer
13:18:47at 
java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:357)
13:18:47at 
java.util.concurrent.CompletableFuture.get(CompletableFuture.java:1908)
13:18:47at 
org.apache.geode.redis.internal.executor.hash.HashesAndCrashesDUnitTest.modifyDataWhileCrashingVMs(HashesAndCrashesDUnitTest.java:239)
13:18:47at 
org.apache.geode.redis.internal.executor.hash.HashesAndCrashesDUnitTest.givenServerCrashesDuringSET_thenDataIsNotLost(HashesAndCrashesDUnitTest.java:174)
13:18:47
13:18:47Caused by:
13:18:47io.lettuce.core.RedisException: 
io.netty.channel.unix.Errors$NativeIoException: readAddress(..) failed: 
Connection reset by peer
13:18:47at 
io.lettuce.core.LettuceFutures.awaitOrCancel(LettuceFutures.java:129)
13:18:47at 
io.lettuce.core.FutureSyncInvocationHandler.handleInvocation(FutureSyncInvocationHandler.java:69)
13:18:47at 
io.lettuce.core.internal.AbstractInvocationHandler.invoke(AbstractInvocationHandler.java:80)
13:18:47at com.sun.proxy.$Proxy70.set(Unknown Source)
13:18:47at 
org.apache.geode.redis.internal.executor.hash.HashesAndCrashesDUnitTest.setPerformAndVerify(HashesAndCrashesDUnitTest.java:296)
13:18:47at 
org.apache.geode.redis.internal.executor.hash.HashesAndCrashesDUnitTest.lambda$modifyDataWhileCrashingVMs$9(HashesAndCrashesDUnitTest.java:206)
13:18:47
13:18:47Caused by:
13:18:47io.netty.channel.unix.Errors$NativeIoException: 
readAddress(..) failed: Connection reset by peer
13:20:00
13:20:00org.apache.geode.redis.internal.executor.hash.HashesAndCrashesDUnitTest 
> givenServerCrashesDuringSADD_thenDataIsNotLost FAILED
13:20:00java.util.concurrent.ExecutionException: 
io.lettuce.core.RedisException: io.netty.channel.unix.Errors$NativeIoException: 
readAddress(..) failed: Connection reset by peer
13:20:00at 
java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:357)
13:20:00at 
java.util.concurrent.CompletableFuture.get(CompletableFuture.java:1908)
13:20:00at 
org.apache.geode.redis.internal.executor.hash.HashesAndCrashesDUnitTest.modifyDataWhileCrashingVMs(HashesAndCrashesDUnitTest.java:239)
13:20:00at 
org.apache.geode.redis.internal.executor.hash.HashesAndCrashesDUnitTest.givenServerCrashesDuringSADD_thenDataIsNotLost(HashesAndCrashesDUnitTest.java:169)
13:20:00
13:20:00Caused by:
13:20:00io.lettuce.core.RedisException: 
io.netty.channel.unix.Errors$NativeIoException: readAddress(..) failed: 
Connection reset by peer
13:20:00at 
io.lettuce.core.LettuceFutures.awaitOrCancel(LettuceFutures.java:129)
13:20:00at 
io.lettuce.core.FutureSyncInvocationHandler.handleInvocation(FutureSyncInvocationHandler.java:69)
13:20:00at 
io.lettuce.core.internal.AbstractInvocationHandler.invoke(AbstractInvocationHandler.java:80)
13:20:00at com.sun.proxy.$Proxy70.sadd(Unknown Source)
13:20:00at 
org.apache.geode.redis.internal.executor.hash.HashesAndCrashesDUnitTest.saddPerformAndVerify(HashesAndCrashesDUnitTest.java:272)
13:20:00at 
org.apache.geode.redis.internal.executor.hash.HashesAndCrashesDUnitTest.lambda$modifyDataWhileCrashingVMs$5(HashesAndCrashesDUnitTest.java:200)
13:20:00
13:20:00Caused by:
13:20:00io.netty.channel.unix.Errors$NativeIoException: 
readAddress(..) failed: Connection reset by peer {noformat}
 

I bisected and think this commit introduced the failure:
{noformat}
commit 0a91484b05f1caffa8cc3a59cc7fc38abe4376ed (HEAD)
Author: Darrel Schneider 
Date:   Mon Aug 10 12:50:31 2020 -0700
GEODE-8393: change memberDeparted to disconnect the connection (#5431)
* server now disconnects connection if memberDeparted
Co-authored-by: john Hutchison 
 {noformat}
 

 

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (GEODE-8417) CI failure: SessionExpirationDUnitTest.sessionShouldTimeout_whenAppFailsOverToAnotherRedisServer fails with a timeout

2020-08-10 Thread Bruce J Schuchardt (Jira)
Bruce J Schuchardt created GEODE-8417:
-

 Summary: CI failure: 
SessionExpirationDUnitTest.sessionShouldTimeout_whenAppFailsOverToAnotherRedisServer
 fails with a timeout
 Key: GEODE-8417
 URL: https://issues.apache.org/jira/browse/GEODE-8417
 Project: Geode
  Issue Type: Bug
Reporter: Bruce J Schuchardt


This test failed in a CI run:

[https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK11/builds/402#L5f20d92c:648]

 
{noformat}
org.apache.geode.redis.session.SessionExpirationDUnitTest > 
sessionShouldTimeout_whenAppFailsOverToAnotherRedisServer FAILED
13:20:39org.awaitility.core.ConditionTimeoutException: Condition with 
lambda expression in org.apache.geode.redis.session.SessionExpirationDUnitTest 
that uses java.lang.String was not fulfilled within 10 seconds.
13:20:39at 
org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:165)
13:20:39at 
org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
13:20:39at 
org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
13:20:39at 
org.awaitility.core.ConditionFactory.until(ConditionFactory.java:895)
13:20:39at 
org.awaitility.core.ConditionFactory.until(ConditionFactory.java:864)
13:20:39at 
org.apache.geode.redis.session.SessionExpirationDUnitTest.waitForTheSessionToExpire(SessionExpirationDUnitTest.java:113)
13:20:39at 
org.apache.geode.redis.session.SessionExpirationDUnitTest.sessionShouldTimeout_whenAppFailsOverToAnotherRedisServer(SessionExpirationDUnitTest.java:93)
13:20:39
13:20:39Caused by:
13:20:39redis.clients.jedis.exceptions.JedisConnectionException: 
java.net.SocketException: Broken pipe (Write failed)
13:20:39at 
redis.clients.jedis.Protocol.sendCommand(Protocol.java:109)
13:20:39at 
redis.clients.jedis.Protocol.sendCommand(Protocol.java:89)
13:20:39at 
redis.clients.jedis.Connection.sendCommand(Connection.java:126)
13:20:39at 
redis.clients.jedis.BinaryClient.ttl(BinaryClient.java:186)
13:20:39at redis.clients.jedis.Client.ttl(Client.java:114)
13:20:39at redis.clients.jedis.Jedis.ttl(Jedis.java:399)
13:20:39at 
org.apache.geode.redis.session.SessionExpirationDUnitTest.lambda$waitForTheSessionToExpire$0(SessionExpirationDUnitTest.java:114)
13:20:39
13:20:39Caused by:
13:20:39java.net.SocketException: Broken pipe (Write failed)
13:20:39at java.net.SocketOutputStream.socketWrite0(Native 
Method)
13:20:39at 
java.net.SocketOutputStream.socketWrite(SocketOutputStream.java:110)
13:20:39at 
java.net.SocketOutputStream.write(SocketOutputStream.java:150)
13:20:39at 
redis.clients.jedis.util.RedisOutputStream.flushBuffer(RedisOutputStream.java:52)
13:20:39at 
redis.clients.jedis.util.RedisOutputStream.write(RedisOutputStream.java:59)
13:20:39at 
redis.clients.jedis.Protocol.sendCommand(Protocol.java:95)
13:20:39... 6 more
13:20:39 {noformat}
 

I bisected and found it started failing here:
{noformat}
commit 0a91484b05f1caffa8cc3a59cc7fc38abe4376ed
Author: Darrel Schneider 
Date:   Mon Aug 10 12:50:31 2020 -0700
GEODE-8393: change memberDeparted to disconnect the connection (#5431)
* server now disconnects connection if memberDeparted
Co-authored-by: john Hutchison 
 {noformat}
 

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (GEODE-8410) Remove offensive wording from documentation

2020-08-10 Thread Karen Smoler Miller (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-8410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karen Smoler Miller resolved GEODE-8410.

Fix Version/s: 1.14.0
   Resolution: Fixed

> Remove offensive wording from documentation
> ---
>
> Key: GEODE-8410
> URL: https://issues.apache.org/jira/browse/GEODE-8410
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> Offensive wording appears in our documentation.  We should rewrite to 
> eliminate the offensive wording.
> Here are some examples and possible substitutions:
> abort becomes stop/cancel/stop prematurely
> whitelist and blacklist become allowlist(noun), allow(v) and denylist(noun), 
> deny(v) or block
> blackout becomes restriction(noun), restrict(v)
> master and slave become primary or main and secondary or worker
> whitehat and blackhat become ethical and unethical
> kill becomes stop or halt
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8410) Remove offensive wording from documentation

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175068#comment-17175068
 ] 

ASF subversion and git services commented on GEODE-8410:


Commit eb10815343855a8df518a6821a1973c551674e69 in geode's branch 
refs/heads/develop from Karen Miller
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=eb10815 ]

GEODE-8410: remove offensive language from docs (#5437)

Co-authored-by: Karen Miller 

> Remove offensive wording from documentation
> ---
>
> Key: GEODE-8410
> URL: https://issues.apache.org/jira/browse/GEODE-8410
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>Priority: Major
>  Labels: pull-request-available
>
> Offensive wording appears in our documentation.  We should rewrite to 
> eliminate the offensive wording.
> Here are some examples and possible substitutions:
> abort becomes stop/cancel/stop prematurely
> whitelist and blacklist become allowlist(noun), allow(v) and denylist(noun), 
> deny(v) or block
> blackout becomes restriction(noun), restrict(v)
> master and slave become primary or main and secondary or worker
> whitehat and blackhat become ethical and unethical
> kill becomes stop or halt
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8410) Remove offensive wording from documentation

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175067#comment-17175067
 ] 

ASF subversion and git services commented on GEODE-8410:


Commit eb10815343855a8df518a6821a1973c551674e69 in geode's branch 
refs/heads/develop from Karen Miller
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=eb10815 ]

GEODE-8410: remove offensive language from docs (#5437)

Co-authored-by: Karen Miller 

> Remove offensive wording from documentation
> ---
>
> Key: GEODE-8410
> URL: https://issues.apache.org/jira/browse/GEODE-8410
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>Priority: Major
>  Labels: pull-request-available
>
> Offensive wording appears in our documentation.  We should rewrite to 
> eliminate the offensive wording.
> Here are some examples and possible substitutions:
> abort becomes stop/cancel/stop prematurely
> whitelist and blacklist become allowlist(noun), allow(v) and denylist(noun), 
> deny(v) or block
> blackout becomes restriction(noun), restrict(v)
> master and slave become primary or main and secondary or worker
> whitehat and blackhat become ethical and unethical
> kill becomes stop or halt
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8410) Remove offensive wording from documentation

2020-08-10 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175066#comment-17175066
 ] 

ASF GitHub Bot commented on GEODE-8410:
---

karensmolermiller merged pull request #5437:
URL: https://github.com/apache/geode/pull/5437


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Remove offensive wording from documentation
> ---
>
> Key: GEODE-8410
> URL: https://issues.apache.org/jira/browse/GEODE-8410
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>Priority: Major
>  Labels: pull-request-available
>
> Offensive wording appears in our documentation.  We should rewrite to 
> eliminate the offensive wording.
> Here are some examples and possible substitutions:
> abort becomes stop/cancel/stop prematurely
> whitelist and blacklist become allowlist(noun), allow(v) and denylist(noun), 
> deny(v) or block
> blackout becomes restriction(noun), restrict(v)
> master and slave become primary or main and secondary or worker
> whitehat and blackhat become ethical and unethical
> kill becomes stop or halt
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8416) Add more Redis tests files to pipeline

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175049#comment-17175049
 ] 

ASF subversion and git services commented on GEODE-8416:


Commit 52c215c3cbcff6188d6731673b4cea014db89d18 in geode's branch 
refs/heads/develop from Sarah Abbey
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=52c215c ]

GEODE-8416: Add more Redis tests files to pipeline (#5438)



> Add more Redis tests files to pipeline
> --
>
> Key: GEODE-8416
> URL: https://issues.apache.org/jira/browse/GEODE-8416
> Project: Geode
>  Issue Type: Improvement
>  Components: ci, redis, tests
>Reporter: Sarah Abbey
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> Include more .tcl files in the Redis Tests CI job



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (GEODE-8416) Add more Redis tests files to pipeline

2020-08-10 Thread Sarah Abbey (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-8416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sarah Abbey resolved GEODE-8416.

Fix Version/s: 1.14.0
   Resolution: Fixed

> Add more Redis tests files to pipeline
> --
>
> Key: GEODE-8416
> URL: https://issues.apache.org/jira/browse/GEODE-8416
> Project: Geode
>  Issue Type: Improvement
>  Components: ci, redis, tests
>Reporter: Sarah Abbey
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> Include more .tcl files in the Redis Tests CI job



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8416) Add more Redis tests files to pipeline

2020-08-10 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175048#comment-17175048
 ] 

ASF GitHub Bot commented on GEODE-8416:
---

rhoughton-pivot merged pull request #5438:
URL: https://github.com/apache/geode/pull/5438


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add more Redis tests files to pipeline
> --
>
> Key: GEODE-8416
> URL: https://issues.apache.org/jira/browse/GEODE-8416
> Project: Geode
>  Issue Type: Improvement
>  Components: ci, redis, tests
>Reporter: Sarah Abbey
>Priority: Major
>  Labels: pull-request-available
>
> Include more .tcl files in the Redis Tests CI job



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8416) Add more Redis tests files to pipeline

2020-08-10 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175045#comment-17175045
 ] 

ASF GitHub Bot commented on GEODE-8416:
---

sabbeyPivotal removed a comment on pull request #5438:
URL: https://github.com/apache/geode/pull/5438#issuecomment-671573159


   @smgoller @rhoughton-pivot @onichols-pivotal @dickcav



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add more Redis tests files to pipeline
> --
>
> Key: GEODE-8416
> URL: https://issues.apache.org/jira/browse/GEODE-8416
> Project: Geode
>  Issue Type: Improvement
>  Components: ci, redis, tests
>Reporter: Sarah Abbey
>Priority: Major
>  Labels: pull-request-available
>
> Include more .tcl files in the Redis Tests CI job



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8416) Add more Redis tests files to pipeline

2020-08-10 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175044#comment-17175044
 ] 

ASF GitHub Bot commented on GEODE-8416:
---

sabbeyPivotal commented on pull request #5438:
URL: https://github.com/apache/geode/pull/5438#issuecomment-671573159


   @smgoller @rhoughton-pivot @onichols-pivotal @dickcav



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add more Redis tests files to pipeline
> --
>
> Key: GEODE-8416
> URL: https://issues.apache.org/jira/browse/GEODE-8416
> Project: Geode
>  Issue Type: Improvement
>  Components: ci, redis, tests
>Reporter: Sarah Abbey
>Priority: Major
>  Labels: pull-request-available
>
> Include more .tcl files in the Redis Tests CI job



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (GEODE-8416) Add more Redis tests files to pipeline

2020-08-10 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-8416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated GEODE-8416:
--
Labels: pull-request-available  (was: )

> Add more Redis tests files to pipeline
> --
>
> Key: GEODE-8416
> URL: https://issues.apache.org/jira/browse/GEODE-8416
> Project: Geode
>  Issue Type: Improvement
>  Components: ci, redis, tests
>Reporter: Sarah Abbey
>Priority: Major
>  Labels: pull-request-available
>
> Include more .tcl files in the Redis Tests CI job



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8416) Add more Redis tests files to pipeline

2020-08-10 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175042#comment-17175042
 ] 

ASF GitHub Bot commented on GEODE-8416:
---

sabbeyPivotal opened a new pull request #5438:
URL: https://github.com/apache/geode/pull/5438


   Include more .tcl files in the Redis Tests CI job



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add more Redis tests files to pipeline
> --
>
> Key: GEODE-8416
> URL: https://issues.apache.org/jira/browse/GEODE-8416
> Project: Geode
>  Issue Type: Improvement
>  Components: ci, redis, tests
>Reporter: Sarah Abbey
>Priority: Major
>
> Include more .tcl files in the Redis Tests CI job



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (GEODE-8416) Add more Redis tests files to pipeline

2020-08-10 Thread Sarah Abbey (Jira)
Sarah Abbey created GEODE-8416:
--

 Summary: Add more Redis tests files to pipeline
 Key: GEODE-8416
 URL: https://issues.apache.org/jira/browse/GEODE-8416
 Project: Geode
  Issue Type: Improvement
  Components: ci, redis, tests
Reporter: Sarah Abbey


Include more .tcl files in the Redis Tests CI job



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8393) CI: CrashAndNoRepeatDUnitTest > givenServerCrashesDuringAPPEND_thenDataIsNotLost FAILED

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175028#comment-17175028
 ] 

ASF subversion and git services commented on GEODE-8393:


Commit 0a91484b05f1caffa8cc3a59cc7fc38abe4376ed in geode's branch 
refs/heads/develop from Darrel Schneider
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=0a91484 ]

GEODE-8393: change memberDeparted to disconnect the connection (#5431)

* server now disconnects connection if memberDeparted

Co-authored-by: john Hutchison 

> CI: CrashAndNoRepeatDUnitTest > 
> givenServerCrashesDuringAPPEND_thenDataIsNotLost FAILED
> ---
>
> Key: GEODE-8393
> URL: https://issues.apache.org/jira/browse/GEODE-8393
> Project: Geode
>  Issue Type: Bug
>  Components: redis
>Reporter: Jinmei Liao
>Assignee: Darrel Schneider
>Priority: Major
>  Labels: CI, pull-request-available
>
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK11/builds/384
> org.apache.geode.redis.internal.executor.CrashAndNoRepeatDUnitTest > 
> givenServerCrashesDuringAPPEND_thenDataIsNotLost FAILED
> java.util.concurrent.ExecutionException: java.lang.AssertionError: 
> unexpected 0 at index 3967 in string 
> 

[jira] [Commented] (GEODE-8393) CI: CrashAndNoRepeatDUnitTest > givenServerCrashesDuringAPPEND_thenDataIsNotLost FAILED

2020-08-10 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175027#comment-17175027
 ] 

ASF GitHub Bot commented on GEODE-8393:
---

jdeppe-pivotal merged pull request #5431:
URL: https://github.com/apache/geode/pull/5431


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> CI: CrashAndNoRepeatDUnitTest > 
> givenServerCrashesDuringAPPEND_thenDataIsNotLost FAILED
> ---
>
> Key: GEODE-8393
> URL: https://issues.apache.org/jira/browse/GEODE-8393
> Project: Geode
>  Issue Type: Bug
>  Components: redis
>Reporter: Jinmei Liao
>Assignee: Darrel Schneider
>Priority: Major
>  Labels: CI
>
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK11/builds/384
> org.apache.geode.redis.internal.executor.CrashAndNoRepeatDUnitTest > 
> givenServerCrashesDuringAPPEND_thenDataIsNotLost FAILED
> java.util.concurrent.ExecutionException: java.lang.AssertionError: 
> unexpected 0 at index 3967 in string 
> 

[jira] [Updated] (GEODE-8393) CI: CrashAndNoRepeatDUnitTest > givenServerCrashesDuringAPPEND_thenDataIsNotLost FAILED

2020-08-10 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-8393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated GEODE-8393:
--
Labels: CI pull-request-available  (was: CI)

> CI: CrashAndNoRepeatDUnitTest > 
> givenServerCrashesDuringAPPEND_thenDataIsNotLost FAILED
> ---
>
> Key: GEODE-8393
> URL: https://issues.apache.org/jira/browse/GEODE-8393
> Project: Geode
>  Issue Type: Bug
>  Components: redis
>Reporter: Jinmei Liao
>Assignee: Darrel Schneider
>Priority: Major
>  Labels: CI, pull-request-available
>
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK11/builds/384
> org.apache.geode.redis.internal.executor.CrashAndNoRepeatDUnitTest > 
> givenServerCrashesDuringAPPEND_thenDataIsNotLost FAILED
> java.util.concurrent.ExecutionException: java.lang.AssertionError: 
> unexpected 0 at index 3967 in string 
> 

[jira] [Resolved] (GEODE-8409) SUNIONSTORE, SINTERSTORE, and SDIFFSTORE should delete the target key even if target exists and is not a set

2020-08-10 Thread Darrel Schneider (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-8409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darrel Schneider resolved GEODE-8409.
-
Fix Version/s: 1.14.0
   Resolution: Fixed

> SUNIONSTORE, SINTERSTORE, and SDIFFSTORE should delete the target key even if 
> target exists and is not a set
> 
>
> Key: GEODE-8409
> URL: https://issues.apache.org/jira/browse/GEODE-8409
> Project: Geode
>  Issue Type: Bug
>  Components: redis
>Reporter: Darrel Schneider
>Assignee: Darrel Schneider
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> This sequence:
>  
> {{SET setres xxx
> SUNIONSTORE setres foo111 bar222}}
> ({{foo111}} and {{bar222}} do not exist)
> {{setres}} should be deleted and we should get a response of
> {{(integer) 0}}
> Instead we get
> {{(error) WRONGTYPE Operation against a key holding the wrong kind of value}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8409) SUNIONSTORE, SINTERSTORE, and SDIFFSTORE should delete the target key even if target exists and is not a set

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175016#comment-17175016
 ] 

ASF subversion and git services commented on GEODE-8409:


Commit 018339f5c84ea3099f3fc0570c3be5f2203a229b in geode's branch 
refs/heads/develop from Darrel Schneider
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=018339f ]

GEODE-8409: S*STORE need to handle target that is not a redis set (#5429)



> SUNIONSTORE, SINTERSTORE, and SDIFFSTORE should delete the target key even if 
> target exists and is not a set
> 
>
> Key: GEODE-8409
> URL: https://issues.apache.org/jira/browse/GEODE-8409
> Project: Geode
>  Issue Type: Bug
>  Components: redis
>Reporter: Darrel Schneider
>Assignee: Darrel Schneider
>Priority: Major
>  Labels: pull-request-available
>
> This sequence:
>  
> {{SET setres xxx
> SUNIONSTORE setres foo111 bar222}}
> ({{foo111}} and {{bar222}} do not exist)
> {{setres}} should be deleted and we should get a response of
> {{(integer) 0}}
> Instead we get
> {{(error) WRONGTYPE Operation against a key holding the wrong kind of value}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8409) SUNIONSTORE, SINTERSTORE, and SDIFFSTORE should delete the target key even if target exists and is not a set

2020-08-10 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175013#comment-17175013
 ] 

ASF GitHub Bot commented on GEODE-8409:
---

dschneider-pivotal merged pull request #5429:
URL: https://github.com/apache/geode/pull/5429


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> SUNIONSTORE, SINTERSTORE, and SDIFFSTORE should delete the target key even if 
> target exists and is not a set
> 
>
> Key: GEODE-8409
> URL: https://issues.apache.org/jira/browse/GEODE-8409
> Project: Geode
>  Issue Type: Bug
>  Components: redis
>Reporter: Darrel Schneider
>Assignee: Darrel Schneider
>Priority: Major
>  Labels: pull-request-available
>
> This sequence:
>  
> {{SET setres xxx
> SUNIONSTORE setres foo111 bar222}}
> ({{foo111}} and {{bar222}} do not exist)
> {{setres}} should be deleted and we should get a response of
> {{(integer) 0}}
> Instead we get
> {{(error) WRONGTYPE Operation against a key holding the wrong kind of value}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (GEODE-5772) fix the potential cache leak caused by reconnect

2020-08-10 Thread Anilkumar Gingade (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-5772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anilkumar Gingade updated GEODE-5772:
-
Labels: GeodeOperationAPI pull-request-available  (was: 
pull-request-available)

> fix the potential cache leak caused by reconnect
> 
>
> Key: GEODE-5772
> URL: https://issues.apache.org/jira/browse/GEODE-5772
> Project: Geode
>  Issue Type: Bug
>  Components: core
>Reporter: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeOperationAPI, pull-request-available
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Customer reported when reconnect happens, the memory usage will increase a 
> lot. 
>  
> After investigation with Barry and Anil, we found there're one or more cache 
> instances are still alive after reconnect closed it and created a new live 
> cache. 
>  
> We walk through the code and fix some potential places that still hold the 
> cache reference. 
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (GEODE-6901) If a region is replicate and replicate persistent in different members and a replicate persistent member crashes, the replicate members throw a ToDataException attempting

2020-08-10 Thread Anilkumar Gingade (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-6901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anilkumar Gingade updated GEODE-6901:
-
Labels: GeodeOperationAPI caching-applications pull-request-available  
(was: caching-applications pull-request-available)

> If a region is replicate and replicate persistent in different members and a 
> replicate persistent member crashes, the replicate members throw a 
> ToDataException attempting to synchronize the region
> 
>
> Key: GEODE-6901
> URL: https://issues.apache.org/jira/browse/GEODE-6901
> Project: Geode
>  Issue Type: Bug
>  Components: persistence, regions
>Reporter: Barrett Oglesby
>Priority: Major
>  Labels: GeodeOperationAPI, caching-applications, 
> pull-request-available
> Attachments: 
> 0001-GEODE-6901-Modified-RegionVersionVector-to-handle-a-.patch
>
>
> If a region is replicate and replicate persistent in different members and a 
> replicate persistent member crashes, the replicate members throw a 
> ToDataException attempting to synchronize the region
> In this case, an exception like this is thrown in the replicate member:
> {noformat}
> [warn 2019/06/21 17:06:33.516 PDT  tid=0x2b] Timer task 
>  encountered 
> exception
> org.apache.geode.ToDataException: class 
> org.apache.geode.internal.cache.versions.VMRegionVersionVector
>  at 
> org.apache.geode.internal.InternalDataSerializer.invokeToData(InternalDataSerializer.java:2331)
>  at 
> org.apache.geode.internal.InternalDataSerializer.writeDSFID(InternalDataSerializer.java:1492)
>  at 
> org.apache.geode.internal.InternalDataSerializer.basicWriteObject(InternalDataSerializer.java:2067)
>  at org.apache.geode.DataSerializer.writeObject(DataSerializer.java:2943)
>  at 
> org.apache.geode.internal.cache.InitialImageOperation$RequestImageMessage.toData(InitialImageOperation.java:2135)
>  at 
> org.apache.geode.internal.InternalDataSerializer.invokeToData(InternalDataSerializer.java:2300)
>  at 
> org.apache.geode.internal.InternalDataSerializer.writeDSFID(InternalDataSerializer.java:1492)
>  at 
> org.apache.geode.internal.tcp.MsgStreamer.writeMessage(MsgStreamer.java:242)
>  at 
> org.apache.geode.distributed.internal.direct.DirectChannel.sendToMany(DirectChannel.java:385)
>  at 
> org.apache.geode.distributed.internal.direct.DirectChannel.sendToOne(DirectChannel.java:241)
>  at 
> org.apache.geode.distributed.internal.direct.DirectChannel.send(DirectChannel.java:596)
>  at 
> org.apache.geode.distributed.internal.membership.gms.mgr.GMSMembershipManager.directChannelSend(GMSMembershipManager.java:1711)
>  at 
> org.apache.geode.distributed.internal.membership.gms.mgr.GMSMembershipManager.send(GMSMembershipManager.java:1892)
>  at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendViaMembershipManager(ClusterDistributionManager.java:2852)
>  at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendOutgoing(ClusterDistributionManager.java:2779)
>  at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendMessage(ClusterDistributionManager.java:2816)
>  at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.putOutgoing(ClusterDistributionManager.java:1526)
>  at 
> org.apache.geode.internal.cache.InitialImageOperation.synchronizeWith(InitialImageOperation.java:649)
>  at 
> org.apache.geode.internal.cache.DistributedRegion.synchronizeWith(DistributedRegion.java:1321)
>  at 
> org.apache.geode.internal.cache.DistributedRegion.synchronizeForLostMember(DistributedRegion.java:1310)
>  at 
> org.apache.geode.internal.cache.DistributedRegion.performSynchronizeForLostMemberTask(DistributedRegion.java:1295)
>  at 
> org.apache.geode.internal.cache.DistributedRegion$1.run2(DistributedRegion.java:1285)
>  at 
> org.apache.geode.internal.SystemTimer$SystemTimerTask.run(SystemTimer.java:445)
>  at java.util.TimerThread.mainLoop(Timer.java:555)
>  at java.util.TimerThread.run(Timer.java:505)
> Caused by: java.lang.ClassCastException: 
> org.apache.geode.internal.cache.persistence.DiskStoreID cannot be cast to 
> org.apache.geode.distributed.internal.membership.InternalDistributedMember
>  at 
> org.apache.geode.internal.cache.versions.VMRegionVersionVector.writeMember(VMRegionVersionVector.java:31)
>  at 
> org.apache.geode.internal.cache.versions.RegionVersionVector.toData(RegionVersionVector.java:1204)
>  at 
> org.apache.geode.internal.InternalDataSerializer.invokeToData(InternalDataSerializer.java:2300)
>  ... 24 more
> {noformat}
> RegionVersionVector.java:1204 is here:
> {noformat}
>  for (Map.Entry> entry : 
> this.memberToVersion.entrySet()) {
> -> 

[jira] [Updated] (GEODE-2682) Compaction with async disk writes may resurrect removed entries

2020-08-10 Thread Anilkumar Gingade (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-2682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anilkumar Gingade updated GEODE-2682:
-
Labels: GeodeOperationAPI storage_2  (was: storage_2)

> Compaction with async disk writes may resurrect removed entries
> ---
>
> Key: GEODE-2682
> URL: https://issues.apache.org/jira/browse/GEODE-2682
> Project: Geode
>  Issue Type: Bug
>  Components: persistence
>Affects Versions: 1.0.0-incubating, 1.1.0
>Reporter: Jason Huynh
>Priority: Major
>  Labels: GeodeOperationAPI, storage_2
> Attachments: cache.xml, oplogs.tar.gz
>
>
> This can occur for persistent async event queues and for regions when 
> concurrency checks are disabled.
> Currently->
> 1.) When rolling a crf we create a krf that is based on the current “live” 
> region
> 2.) If removes are being done at the same time, the krf will reflect the 
> current state, where the keys are not part of the krf file
> 3.) Due to the async disk write, the drf has yet to be updated.
> 4.) If the cluster gets shut down before the drf is written to.  This can 
> lead to the following scenarios:
>  * (No issue) the user recovers with the existing krf/drf/crf files.  This 
> works just fine as the krf has reflected the change
>  * (Problem!) If the user compacts and then recovers, the removed entries are 
> now resurrected and appear in the region due to the way compaction operates.  
> It ignores the krf and works on a the existing crf/drf files.  Because the 
> drf does not reflect removed events, the events are rolled forward from the 
> crf.
> Attached is a set oplogs for a single node prior to compaction and a 
> cache.xml (need to fill in the correct location for the diskstore directory) 
> Recovering from this set of oplogs recovers 0 entries for the async event 
> queues.
> If you run offline compaction on the oplogs and recover, there are now 
> entries in the async event queues.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8173) Add test coverage for PartitionedRegionClear class

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174577#comment-17174577
 ] 

ASF subversion and git services commented on GEODE-8173:


Commit e5efc6d307e09356e4213074c60d9555c26cce52 in geode's branch 
refs/heads/feature/GEODE-7665 from agingade
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=e5efc6d ]

GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. (#5208)

* GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class.
Co-authored-by: anilkumar gingade 

> Add test coverage for PartitionedRegionClear class
> --
>
> Key: GEODE-8173
> URL: https://issues.apache.org/jira/browse/GEODE-8173
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Anilkumar Gingade
>Priority: Major
>  Labels: GeodeOperationAPI
> Fix For: 1.14.0
>
>
> Add test coverage for PartitionedRegionClear class.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8173) Add test coverage for PartitionedRegionClear class

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174924#comment-17174924
 ] 

ASF subversion and git services commented on GEODE-8173:


Commit e5efc6d307e09356e4213074c60d9555c26cce52 in geode's branch 
refs/heads/feature/GEODE-7665 from agingade
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=e5efc6d ]

GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. (#5208)

* GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class.
Co-authored-by: anilkumar gingade 

> Add test coverage for PartitionedRegionClear class
> --
>
> Key: GEODE-8173
> URL: https://issues.apache.org/jira/browse/GEODE-8173
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Anilkumar Gingade
>Priority: Major
>  Labels: GeodeOperationAPI
> Fix For: 1.14.0
>
>
> Add test coverage for PartitionedRegionClear class.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174926#comment-17174926
 ] 

ASF subversion and git services commented on GEODE-8334:


Commit 2d82c288e5af109ae0c3311a2702c83e389ad720 in geode's branch 
refs/heads/feature/GEODE-7665 from Xiaojian Zhou
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=2d82c28 ]

GEODE-8334: PR.clear should sync with putAll or removeAll on rvvLock (#5365)


Co-authored-by: Xiaojian Zhou 
Co-authored-by: Anil Gingade 



> Primary and secondary bucket data mismatch with concurrent putAll/removeAll 
> and PR.clear 
> -
>
> Key: GEODE-8334
> URL: https://issues.apache.org/jira/browse/GEODE-8334
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Affects Versions: 1.14.0
>Reporter: Xiaojian Zhou
>Assignee: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeOperationAPI
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7678) Partitioned Region clear operations must invoke cache level listeners

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174921#comment-17174921
 ] 

ASF subversion and git services commented on GEODE-7678:


Commit ab008ffd81d902bdddea88ef2b3736d8cf4ae8ea in geode's branch 
refs/heads/feature/GEODE-7665 from agingade
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=ab008ff ]

GEODE-7678 (2nd PR) - Support for cache-listener and client-notification for 
Partitioned Region Clear operation  (#5124)

* GEODE-7678: Add support for cache listener and client notification for PR 
clear

The changes are made to PR clear messaging and locking mechanism to preserve
cache-listener and client-events ordering during concurrent cache operation
while clear in progress.


> Partitioned Region clear operations must invoke cache level listeners
> -
>
> Key: GEODE-7678
> URL: https://issues.apache.org/jira/browse/GEODE-7678
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Anilkumar Gingade
>Priority: Major
>  Labels: GeodeCommons, GeodeOperationAPI
>
> Clear operations are successful and CacheListener.afterRegionClear(), 
> CacheWriter.beforeRegionClear() are invoked.
>  
> Acceptance :
>  * DUnit tests validating the above behavior.
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8173) Add test coverage for PartitionedRegionClear class

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174925#comment-17174925
 ] 

ASF subversion and git services commented on GEODE-8173:


Commit e5efc6d307e09356e4213074c60d9555c26cce52 in geode's branch 
refs/heads/feature/GEODE-7665 from agingade
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=e5efc6d ]

GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. (#5208)

* GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class.
Co-authored-by: anilkumar gingade 

> Add test coverage for PartitionedRegionClear class
> --
>
> Key: GEODE-8173
> URL: https://issues.apache.org/jira/browse/GEODE-8173
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Anilkumar Gingade
>Priority: Major
>  Labels: GeodeOperationAPI
> Fix For: 1.14.0
>
>
> Add test coverage for PartitionedRegionClear class.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7678) Partitioned Region clear operations must invoke cache level listeners

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174922#comment-17174922
 ] 

ASF subversion and git services commented on GEODE-7678:


Commit ab008ffd81d902bdddea88ef2b3736d8cf4ae8ea in geode's branch 
refs/heads/feature/GEODE-7665 from agingade
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=ab008ff ]

GEODE-7678 (2nd PR) - Support for cache-listener and client-notification for 
Partitioned Region Clear operation  (#5124)

* GEODE-7678: Add support for cache listener and client notification for PR 
clear

The changes are made to PR clear messaging and locking mechanism to preserve
cache-listener and client-events ordering during concurrent cache operation
while clear in progress.


> Partitioned Region clear operations must invoke cache level listeners
> -
>
> Key: GEODE-7678
> URL: https://issues.apache.org/jira/browse/GEODE-7678
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Anilkumar Gingade
>Priority: Major
>  Labels: GeodeCommons, GeodeOperationAPI
>
> Clear operations are successful and CacheListener.afterRegionClear(), 
> CacheWriter.beforeRegionClear() are invoked.
>  
> Acceptance :
>  * DUnit tests validating the above behavior.
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7667) GFSH commands - uniform gfsh command to clear regions

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174920#comment-17174920
 ] 

ASF subversion and git services commented on GEODE-7667:


Commit 2d7548446c8f6f0fa4c897e1c6ee2c5f2b89068b in geode's branch 
refs/heads/feature/GEODE-7665 from Nabarun Nag
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=2d75484 ]

GEODE-7667: Fixing test to include PR clear help text.


> GFSH commands - uniform gfsh command to clear regions
> -
>
> Key: GEODE-7667
> URL: https://issues.apache.org/jira/browse/GEODE-7667
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Benjamin P Ross
>Priority: Major
>  Labels: GeodeCommons, docs
>  Time Spent: 5h
>  Remaining Estimate: 0h
>
> * Currently, the gfsh command to clear replicated region is called ‘remove 
> —region=/regionName’.
>  * Replace this command with ‘clear region —region=regionName’
>  * While executing this gfsh command on partitioned regions, this should call 
> the clear() Java API using the gfsh function execution machinery.
>  * Point to note is that this command should take into consideration of the 
> coordinator selection and how this command is distributed to the members
> Acceptance :
>  * There should be ‘clear region —region=/regionName’ gfsh command
>  * The gfsh command must be documented in the Geode User Guide
>  * DUnit tests to verify that command can be executed successfully on 
> PartitionedRegion
>  * Deprecate the remove command, as remove does not mean clear
>  * Unit tests with complete code coverage for the newly written code.
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8361) Incorrect Bucket Count Warning Message Shown

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174927#comment-17174927
 ] 

ASF subversion and git services commented on GEODE-8361:


Commit 9909cae4cfe587ab1d07f6018b3688bc3dab0413 in geode's branch 
refs/heads/feature/GEODE-7665 from Donal Evans
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=9909cae ]

GEODE-8361: Use Set instead of List to track cleared buckets (#5379)

- Refactor PartitionRegionClear to use Set instead of List
- Some other changes to remove warnings/alerts from PartitionedRegionClear and 
PartitionedRegionClearMessage

Authored-by: Donal Evans 

> Incorrect Bucket Count Warning Message Shown
> 
>
> Key: GEODE-8361
> URL: https://issues.apache.org/jira/browse/GEODE-8361
> Project: Geode
>  Issue Type: Sub-task
>  Components: logging
>Reporter: Juan Ramos
>Assignee: Donal Evans
>Priority: Trivial
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> While analysing some failures related to GEODE-7670, I've noticed that 
> sometimes we report an incorrect bucket count within the warning message 
> logged when the clear didn't complete successfully that could confuse our 
> users.
> For this test the partition region always has 13 buckets so, as I user, I 
> would never expect to see a bucket count higher than 13 in my logs (no matter 
> how many redundant copies I have).
> ---
> Below are some examples:
> {noformat}
> [vm1] [warn 2020/07/15 11:56:17.739 GMT RMI TCP 
> Connection(5)-172.17.0.5 tid=0x5f] Unable to clear all the buckets from 
> the partitioned region PartitionedRegion, either data (buckets) moved or 
> member departed. expected to clear number of buckets: 13 actual cleared: 26
> [vm1] [warn 2020/07/15 11:57:48.403 GMT RMI TCP 
> Connection(6)-172.17.0.9 tid=0x10f] Unable to clear all the buckets from 
> the partitioned region PartitionedRegion, either data (buckets) moved or 
> member departed. expected to clear number of buckets: 13 actual cleared: 14
> [vm0] [warn 2020/07/15 12:07:36.227 GMT RMI TCP 
> Connection(32)-172.17.0.25 tid=0x1fe] Unable to clear all the buckets 
> from the partitioned region PartitionedRegion, either data (buckets) moved or 
> member departed. expected to clear number of buckets: 13 actual cleared: 19
> [vm0] [warn 2020/07/15 12:08:56.277 GMT RMI TCP 
> Connection(37)-172.17.0.24 tid=0x2a2] Unable to clear all the buckets 
> from the partitioned region PartitionedRegion, either data (buckets) moved or 
> member departed. expected to clear number of buckets: 13 actual cleared: 16
> {noformat}
> The full set of artefacts and results:
> {noformat}
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=  Test Results URI 
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> http://files.apachegeode-ci.info/builds/apache-develop-pr/geode-pr-4848/test-results/repeatTest/1594816968/
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> Test report artifacts from this job are available at:
> http://files.apachegeode-ci.info/builds/apache-develop-pr/geode-pr-4848/test-artifacts/1594816968/stressnewtestfiles-geode-pr-4848.tgz
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7670) Partitioned Region clear operations can occur during concurrent data operations

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174928#comment-17174928
 ] 

ASF subversion and git services commented on GEODE-7670:


Commit 7d45393e4819849ad819fba0bf547990c20223a2 in geode's branch 
refs/heads/feature/GEODE-7665 from Juan José Ramos
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=7d45393 ]

GEODE-7670: PR Clear with Concurrent Ops DUnitTests (#4848)

Added distributed tests to verify that the clear operation on
Partitioned Regions works as expected when there are other
concurrent operations happening on the cache (put, putAll, get,
remove, removeAll, members added and members removed).

> Partitioned Region clear operations can occur during concurrent data 
> operations
> ---
>
> Key: GEODE-7670
> URL: https://issues.apache.org/jira/browse/GEODE-7670
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Juan Ramos
>Priority: Major
>  Labels: GeodeCommons, pull-request-available
>  Time Spent: 5.5h
>  Remaining Estimate: 0h
>
> Clear operations are successful when concurrent read/write operations occur. 
> Ensure there are test coverage for this use case and modify the code needed 
> to enable this.
> Acceptance :
>  * Passing DUnit tests where clear operations are successful on partitioned 
> region with 
>  * concurrent puts (writes) and clear op
>  * concurrent gets (reads) and clear op
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7669) Test coverage for Partitioned Region clear with Overflow enabled

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174923#comment-17174923
 ] 

ASF subversion and git services commented on GEODE-7669:


Commit df1b2d3218681fc8cac86adaf5b2eaa438aac893 in geode's branch 
refs/heads/feature/GEODE-7665 from Jianxia Chen
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=df1b2d3 ]

GEODE-7669 Test coverage for Partitioned Region clear with Overflow enabled 
(#5189)

Authored-by: Jianxia Chen 


> Test coverage for Partitioned Region clear with Overflow enabled
> 
>
> Key: GEODE-7669
> URL: https://issues.apache.org/jira/browse/GEODE-7669
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Jianxia Chen
>Priority: Major
>  Labels: GeodeCommons, GeodeOperationAPI
>
> Using TDD ensure that clear operations are successful when the partitioned 
> regions have overflow enabled.
> Make the code changes required to enable this.
>  
> Acceptance :
>  * Passing DUnit tests where clear operations are successful on partitioned 
> region with overflow enabled.
>  * Ensure that data has overflown when the clear operation is executed and in 
> the end everything is cleared.
>  * These tests should have redundancy of more than zero 
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.
> Note:
> analyze if these tests are needed for offheap?
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7894) CustomSSLProviderDistributedTest hostNameIsValidatedWhenUsingDefaultContext fails with suspect uncaught DistributedSystemDisconnectedException

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174919#comment-17174919
 ] 

ASF subversion and git services commented on GEODE-7894:


Commit a5ca20c28231a683466af4b99a678b7d95f8d6c3 in geode's branch 
refs/heads/feature/GEODE-7665 from Nabarun Nag
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=a5ca20c ]

GEODE-7894: Moving expiry tasks to AbstractRegion.


> CustomSSLProviderDistributedTest hostNameIsValidatedWhenUsingDefaultContext 
> fails with suspect uncaught DistributedSystemDisconnectedException
> --
>
> Key: GEODE-7894
> URL: https://issues.apache.org/jira/browse/GEODE-7894
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Reporter: Darrel Schneider
>Assignee: Dan Smith
>Priority: Minor
>  Labels: flakey
> Fix For: 1.13.0
>
>
> See: 
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK8/builds/1663
> {noformat}
> org.apache.geode.cache.client.internal.CustomSSLProviderDistributedTest > 
> hostNameIsValidatedWhenUsingDefaultContext FAILED
> java.lang.AssertionError: Suspicious strings were written to the log 
> during this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> ---
> Found suspect string in log4j at line 1654
> [fatal 2020/03/19 17:26:01.806 GMT  tid=215] Uncaught 
> exception in thread Thread[unused p2p reader,5,RMI Runtime]
> org.apache.geode.distributed.DistributedSystemDisconnectedException: 
> Distribution manager on 172.17.0.15(server-1:113):41001 started at Thu 
> Mar 19 17:25:57 GMT 2020: Message distribution has terminated
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager$Stopper.generateCancelledException(ClusterDistributionManager.java:2873)
>   at 
> org.apache.geode.internal.tcp.TCPConduit$Stopper.generateCancelledException(TCPConduit.java:1004)
>   at 
> org.apache.geode.CancelCriterion.checkCancelInProgress(CancelCriterion.java:83)
>   at 
> org.apache.geode.internal.tcp.Connection.readMessages(Connection.java:1666)
>   at org.apache.geode.internal.tcp.Connection.run(Connection.java:1446)
>   at java.lang.Thread.run(Thread.java:748)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7676) All expiration tasks are cleared after a Partitioned Region is cleared

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174918#comment-17174918
 ] 

ASF subversion and git services commented on GEODE-7676:


Commit 2a2ebc998c5d0d8c053ca33bea9257ba52c52014 in geode's branch 
refs/heads/feature/GEODE-7665 from Nabarun Nag
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=2a2ebc9 ]

GEODE-7676: Conversion of duration to seconds.


> All expiration tasks are cleared after a Partitioned Region is cleared
> --
>
> Key: GEODE-7676
> URL: https://issues.apache.org/jira/browse/GEODE-7676
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Juan Ramos
>Priority: Major
>  Labels: GeodeCommons, feature/GEODE-7665
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> Clear operations are successful and all the expiration tasks are cleared in 
> the bucket level
> Acceptance :
>  * DUnit tests ensuring that clear operations are successful 
>  * Expiration tasks are cleared.
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7680) Partitioned region clear operations must be successful while interacting with rebalance

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174929#comment-17174929
 ] 

ASF subversion and git services commented on GEODE-7680:


Commit 605f5b25493f4223e7fa30cc0c0b946e33e6c199 in geode's branch 
refs/heads/feature/GEODE-7665 from Donal Evans
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=605f5b2 ]

GEODE-7680: PR.clear must be successful when interacting with rebalance (#5095)

- Added DUnit tests to confirm that clear does not interfere with
rebalance or vice versa
- Test when member departs during clear/rebalance
- Test when member joins during clear/rebalance
- Fixed typo in PartitionedRegionClearWithExpirationDUnitTest
- Fixed typo in PartitionedRegion
- Call assignBucketsToPartitions() on leader colocated region during clear
instead of target region

Authored-by: Donal Evans 

> Partitioned region clear operations must be successful while interacting with 
> rebalance 
> 
>
> Key: GEODE-7680
> URL: https://issues.apache.org/jira/browse/GEODE-7680
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Donal Evans
>Priority: Major
>  Labels: GeodeCommons, caching-applications, 
> pull-request-available
> Fix For: 1.14.0
>
>
> Clear operations are successful and while rebalance operations are ongoing.
> Acceptance :
>  * DUnit tests validating the above behavior.
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7678) Partitioned Region clear operations must invoke cache level listeners

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174908#comment-17174908
 ] 

ASF subversion and git services commented on GEODE-7678:


Commit ab008ffd81d902bdddea88ef2b3736d8cf4ae8ea in geode's branch 
refs/heads/feature/GEODE-7665 from agingade
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=ab008ff ]

GEODE-7678 (2nd PR) - Support for cache-listener and client-notification for 
Partitioned Region Clear operation  (#5124)

* GEODE-7678: Add support for cache listener and client notification for PR 
clear

The changes are made to PR clear messaging and locking mechanism to preserve
cache-listener and client-events ordering during concurrent cache operation
while clear in progress.


> Partitioned Region clear operations must invoke cache level listeners
> -
>
> Key: GEODE-7678
> URL: https://issues.apache.org/jira/browse/GEODE-7678
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Anilkumar Gingade
>Priority: Major
>  Labels: GeodeCommons, GeodeOperationAPI
>
> Clear operations are successful and CacheListener.afterRegionClear(), 
> CacheWriter.beforeRegionClear() are invoked.
>  
> Acceptance :
>  * DUnit tests validating the above behavior.
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8361) Incorrect Bucket Count Warning Message Shown

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174914#comment-17174914
 ] 

ASF subversion and git services commented on GEODE-8361:


Commit 9909cae4cfe587ab1d07f6018b3688bc3dab0413 in geode's branch 
refs/heads/feature/GEODE-7665 from Donal Evans
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=9909cae ]

GEODE-8361: Use Set instead of List to track cleared buckets (#5379)

- Refactor PartitionRegionClear to use Set instead of List
- Some other changes to remove warnings/alerts from PartitionedRegionClear and 
PartitionedRegionClearMessage

Authored-by: Donal Evans 

> Incorrect Bucket Count Warning Message Shown
> 
>
> Key: GEODE-8361
> URL: https://issues.apache.org/jira/browse/GEODE-8361
> Project: Geode
>  Issue Type: Sub-task
>  Components: logging
>Reporter: Juan Ramos
>Assignee: Donal Evans
>Priority: Trivial
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> While analysing some failures related to GEODE-7670, I've noticed that 
> sometimes we report an incorrect bucket count within the warning message 
> logged when the clear didn't complete successfully that could confuse our 
> users.
> For this test the partition region always has 13 buckets so, as I user, I 
> would never expect to see a bucket count higher than 13 in my logs (no matter 
> how many redundant copies I have).
> ---
> Below are some examples:
> {noformat}
> [vm1] [warn 2020/07/15 11:56:17.739 GMT RMI TCP 
> Connection(5)-172.17.0.5 tid=0x5f] Unable to clear all the buckets from 
> the partitioned region PartitionedRegion, either data (buckets) moved or 
> member departed. expected to clear number of buckets: 13 actual cleared: 26
> [vm1] [warn 2020/07/15 11:57:48.403 GMT RMI TCP 
> Connection(6)-172.17.0.9 tid=0x10f] Unable to clear all the buckets from 
> the partitioned region PartitionedRegion, either data (buckets) moved or 
> member departed. expected to clear number of buckets: 13 actual cleared: 14
> [vm0] [warn 2020/07/15 12:07:36.227 GMT RMI TCP 
> Connection(32)-172.17.0.25 tid=0x1fe] Unable to clear all the buckets 
> from the partitioned region PartitionedRegion, either data (buckets) moved or 
> member departed. expected to clear number of buckets: 13 actual cleared: 19
> [vm0] [warn 2020/07/15 12:08:56.277 GMT RMI TCP 
> Connection(37)-172.17.0.24 tid=0x2a2] Unable to clear all the buckets 
> from the partitioned region PartitionedRegion, either data (buckets) moved or 
> member departed. expected to clear number of buckets: 13 actual cleared: 16
> {noformat}
> The full set of artefacts and results:
> {noformat}
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=  Test Results URI 
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> http://files.apachegeode-ci.info/builds/apache-develop-pr/geode-pr-4848/test-results/repeatTest/1594816968/
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> Test report artifacts from this job are available at:
> http://files.apachegeode-ci.info/builds/apache-develop-pr/geode-pr-4848/test-artifacts/1594816968/stressnewtestfiles-geode-pr-4848.tgz
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7894) CustomSSLProviderDistributedTest hostNameIsValidatedWhenUsingDefaultContext fails with suspect uncaught DistributedSystemDisconnectedException

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174906#comment-17174906
 ] 

ASF subversion and git services commented on GEODE-7894:


Commit a5ca20c28231a683466af4b99a678b7d95f8d6c3 in geode's branch 
refs/heads/feature/GEODE-7665 from Nabarun Nag
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=a5ca20c ]

GEODE-7894: Moving expiry tasks to AbstractRegion.


> CustomSSLProviderDistributedTest hostNameIsValidatedWhenUsingDefaultContext 
> fails with suspect uncaught DistributedSystemDisconnectedException
> --
>
> Key: GEODE-7894
> URL: https://issues.apache.org/jira/browse/GEODE-7894
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Reporter: Darrel Schneider
>Assignee: Dan Smith
>Priority: Minor
>  Labels: flakey
> Fix For: 1.13.0
>
>
> See: 
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK8/builds/1663
> {noformat}
> org.apache.geode.cache.client.internal.CustomSSLProviderDistributedTest > 
> hostNameIsValidatedWhenUsingDefaultContext FAILED
> java.lang.AssertionError: Suspicious strings were written to the log 
> during this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> ---
> Found suspect string in log4j at line 1654
> [fatal 2020/03/19 17:26:01.806 GMT  tid=215] Uncaught 
> exception in thread Thread[unused p2p reader,5,RMI Runtime]
> org.apache.geode.distributed.DistributedSystemDisconnectedException: 
> Distribution manager on 172.17.0.15(server-1:113):41001 started at Thu 
> Mar 19 17:25:57 GMT 2020: Message distribution has terminated
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager$Stopper.generateCancelledException(ClusterDistributionManager.java:2873)
>   at 
> org.apache.geode.internal.tcp.TCPConduit$Stopper.generateCancelledException(TCPConduit.java:1004)
>   at 
> org.apache.geode.CancelCriterion.checkCancelInProgress(CancelCriterion.java:83)
>   at 
> org.apache.geode.internal.tcp.Connection.readMessages(Connection.java:1666)
>   at org.apache.geode.internal.tcp.Connection.run(Connection.java:1446)
>   at java.lang.Thread.run(Thread.java:748)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7670) Partitioned Region clear operations can occur during concurrent data operations

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174915#comment-17174915
 ] 

ASF subversion and git services commented on GEODE-7670:


Commit 7d45393e4819849ad819fba0bf547990c20223a2 in geode's branch 
refs/heads/feature/GEODE-7665 from Juan José Ramos
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=7d45393 ]

GEODE-7670: PR Clear with Concurrent Ops DUnitTests (#4848)

Added distributed tests to verify that the clear operation on
Partitioned Regions works as expected when there are other
concurrent operations happening on the cache (put, putAll, get,
remove, removeAll, members added and members removed).

> Partitioned Region clear operations can occur during concurrent data 
> operations
> ---
>
> Key: GEODE-7670
> URL: https://issues.apache.org/jira/browse/GEODE-7670
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Juan Ramos
>Priority: Major
>  Labels: GeodeCommons, pull-request-available
>  Time Spent: 5.5h
>  Remaining Estimate: 0h
>
> Clear operations are successful when concurrent read/write operations occur. 
> Ensure there are test coverage for this use case and modify the code needed 
> to enable this.
> Acceptance :
>  * Passing DUnit tests where clear operations are successful on partitioned 
> region with 
>  * concurrent puts (writes) and clear op
>  * concurrent gets (reads) and clear op
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7669) Test coverage for Partitioned Region clear with Overflow enabled

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174910#comment-17174910
 ] 

ASF subversion and git services commented on GEODE-7669:


Commit df1b2d3218681fc8cac86adaf5b2eaa438aac893 in geode's branch 
refs/heads/feature/GEODE-7665 from Jianxia Chen
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=df1b2d3 ]

GEODE-7669 Test coverage for Partitioned Region clear with Overflow enabled 
(#5189)

Authored-by: Jianxia Chen 


> Test coverage for Partitioned Region clear with Overflow enabled
> 
>
> Key: GEODE-7669
> URL: https://issues.apache.org/jira/browse/GEODE-7669
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Jianxia Chen
>Priority: Major
>  Labels: GeodeCommons, GeodeOperationAPI
>
> Using TDD ensure that clear operations are successful when the partitioned 
> regions have overflow enabled.
> Make the code changes required to enable this.
>  
> Acceptance :
>  * Passing DUnit tests where clear operations are successful on partitioned 
> region with overflow enabled.
>  * Ensure that data has overflown when the clear operation is executed and in 
> the end everything is cleared.
>  * These tests should have redundancy of more than zero 
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.
> Note:
> analyze if these tests are needed for offheap?
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7667) GFSH commands - uniform gfsh command to clear regions

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174907#comment-17174907
 ] 

ASF subversion and git services commented on GEODE-7667:


Commit 2d7548446c8f6f0fa4c897e1c6ee2c5f2b89068b in geode's branch 
refs/heads/feature/GEODE-7665 from Nabarun Nag
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=2d75484 ]

GEODE-7667: Fixing test to include PR clear help text.


> GFSH commands - uniform gfsh command to clear regions
> -
>
> Key: GEODE-7667
> URL: https://issues.apache.org/jira/browse/GEODE-7667
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Benjamin P Ross
>Priority: Major
>  Labels: GeodeCommons, docs
>  Time Spent: 5h
>  Remaining Estimate: 0h
>
> * Currently, the gfsh command to clear replicated region is called ‘remove 
> —region=/regionName’.
>  * Replace this command with ‘clear region —region=regionName’
>  * While executing this gfsh command on partitioned regions, this should call 
> the clear() Java API using the gfsh function execution machinery.
>  * Point to note is that this command should take into consideration of the 
> coordinator selection and how this command is distributed to the members
> Acceptance :
>  * There should be ‘clear region —region=/regionName’ gfsh command
>  * The gfsh command must be documented in the Geode User Guide
>  * DUnit tests to verify that command can be executed successfully on 
> PartitionedRegion
>  * Deprecate the remove command, as remove does not mean clear
>  * Unit tests with complete code coverage for the newly written code.
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7678) Partitioned Region clear operations must invoke cache level listeners

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174909#comment-17174909
 ] 

ASF subversion and git services commented on GEODE-7678:


Commit ab008ffd81d902bdddea88ef2b3736d8cf4ae8ea in geode's branch 
refs/heads/feature/GEODE-7665 from agingade
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=ab008ff ]

GEODE-7678 (2nd PR) - Support for cache-listener and client-notification for 
Partitioned Region Clear operation  (#5124)

* GEODE-7678: Add support for cache listener and client notification for PR 
clear

The changes are made to PR clear messaging and locking mechanism to preserve
cache-listener and client-events ordering during concurrent cache operation
while clear in progress.


> Partitioned Region clear operations must invoke cache level listeners
> -
>
> Key: GEODE-7678
> URL: https://issues.apache.org/jira/browse/GEODE-7678
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Anilkumar Gingade
>Priority: Major
>  Labels: GeodeCommons, GeodeOperationAPI
>
> Clear operations are successful and CacheListener.afterRegionClear(), 
> CacheWriter.beforeRegionClear() are invoked.
>  
> Acceptance :
>  * DUnit tests validating the above behavior.
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8173) Add test coverage for PartitionedRegionClear class

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174911#comment-17174911
 ] 

ASF subversion and git services commented on GEODE-8173:


Commit e5efc6d307e09356e4213074c60d9555c26cce52 in geode's branch 
refs/heads/feature/GEODE-7665 from agingade
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=e5efc6d ]

GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. (#5208)

* GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class.
Co-authored-by: anilkumar gingade 

> Add test coverage for PartitionedRegionClear class
> --
>
> Key: GEODE-8173
> URL: https://issues.apache.org/jira/browse/GEODE-8173
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Anilkumar Gingade
>Priority: Major
>  Labels: GeodeOperationAPI
> Fix For: 1.14.0
>
>
> Add test coverage for PartitionedRegionClear class.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174913#comment-17174913
 ] 

ASF subversion and git services commented on GEODE-8334:


Commit 2d82c288e5af109ae0c3311a2702c83e389ad720 in geode's branch 
refs/heads/feature/GEODE-7665 from Xiaojian Zhou
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=2d82c28 ]

GEODE-8334: PR.clear should sync with putAll or removeAll on rvvLock (#5365)


Co-authored-by: Xiaojian Zhou 
Co-authored-by: Anil Gingade 



> Primary and secondary bucket data mismatch with concurrent putAll/removeAll 
> and PR.clear 
> -
>
> Key: GEODE-8334
> URL: https://issues.apache.org/jira/browse/GEODE-8334
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Affects Versions: 1.14.0
>Reporter: Xiaojian Zhou
>Assignee: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeOperationAPI
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7680) Partitioned region clear operations must be successful while interacting with rebalance

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174916#comment-17174916
 ] 

ASF subversion and git services commented on GEODE-7680:


Commit 605f5b25493f4223e7fa30cc0c0b946e33e6c199 in geode's branch 
refs/heads/feature/GEODE-7665 from Donal Evans
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=605f5b2 ]

GEODE-7680: PR.clear must be successful when interacting with rebalance (#5095)

- Added DUnit tests to confirm that clear does not interfere with
rebalance or vice versa
- Test when member departs during clear/rebalance
- Test when member joins during clear/rebalance
- Fixed typo in PartitionedRegionClearWithExpirationDUnitTest
- Fixed typo in PartitionedRegion
- Call assignBucketsToPartitions() on leader colocated region during clear
instead of target region

Authored-by: Donal Evans 

> Partitioned region clear operations must be successful while interacting with 
> rebalance 
> 
>
> Key: GEODE-7680
> URL: https://issues.apache.org/jira/browse/GEODE-7680
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Donal Evans
>Priority: Major
>  Labels: GeodeCommons, caching-applications, 
> pull-request-available
> Fix For: 1.14.0
>
>
> Clear operations are successful and while rebalance operations are ongoing.
> Acceptance :
>  * DUnit tests validating the above behavior.
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8173) Add test coverage for PartitionedRegionClear class

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174912#comment-17174912
 ] 

ASF subversion and git services commented on GEODE-8173:


Commit e5efc6d307e09356e4213074c60d9555c26cce52 in geode's branch 
refs/heads/feature/GEODE-7665 from agingade
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=e5efc6d ]

GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. (#5208)

* GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class.
Co-authored-by: anilkumar gingade 

> Add test coverage for PartitionedRegionClear class
> --
>
> Key: GEODE-8173
> URL: https://issues.apache.org/jira/browse/GEODE-8173
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Anilkumar Gingade
>Priority: Major
>  Labels: GeodeOperationAPI
> Fix For: 1.14.0
>
>
> Add test coverage for PartitionedRegionClear class.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7676) All expiration tasks are cleared after a Partitioned Region is cleared

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174905#comment-17174905
 ] 

ASF subversion and git services commented on GEODE-7676:


Commit 2a2ebc998c5d0d8c053ca33bea9257ba52c52014 in geode's branch 
refs/heads/feature/GEODE-7665 from Nabarun Nag
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=2a2ebc9 ]

GEODE-7676: Conversion of duration to seconds.


> All expiration tasks are cleared after a Partitioned Region is cleared
> --
>
> Key: GEODE-7676
> URL: https://issues.apache.org/jira/browse/GEODE-7676
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Juan Ramos
>Priority: Major
>  Labels: GeodeCommons, feature/GEODE-7665
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> Clear operations are successful and all the expiration tasks are cleared in 
> the bucket level
> Acceptance :
>  * DUnit tests ensuring that clear operations are successful 
>  * Expiration tasks are cleared.
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8173) Add test coverage for PartitionedRegionClear class

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174898#comment-17174898
 ] 

ASF subversion and git services commented on GEODE-8173:


Commit e5efc6d307e09356e4213074c60d9555c26cce52 in geode's branch 
refs/heads/feature/GEODE-7665 from agingade
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=e5efc6d ]

GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. (#5208)

* GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class.
Co-authored-by: anilkumar gingade 

> Add test coverage for PartitionedRegionClear class
> --
>
> Key: GEODE-8173
> URL: https://issues.apache.org/jira/browse/GEODE-8173
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Anilkumar Gingade
>Priority: Major
>  Labels: GeodeOperationAPI
> Fix For: 1.14.0
>
>
> Add test coverage for PartitionedRegionClear class.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7680) Partitioned region clear operations must be successful while interacting with rebalance

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174903#comment-17174903
 ] 

ASF subversion and git services commented on GEODE-7680:


Commit 605f5b25493f4223e7fa30cc0c0b946e33e6c199 in geode's branch 
refs/heads/feature/GEODE-7665 from Donal Evans
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=605f5b2 ]

GEODE-7680: PR.clear must be successful when interacting with rebalance (#5095)

- Added DUnit tests to confirm that clear does not interfere with
rebalance or vice versa
- Test when member departs during clear/rebalance
- Test when member joins during clear/rebalance
- Fixed typo in PartitionedRegionClearWithExpirationDUnitTest
- Fixed typo in PartitionedRegion
- Call assignBucketsToPartitions() on leader colocated region during clear
instead of target region

Authored-by: Donal Evans 

> Partitioned region clear operations must be successful while interacting with 
> rebalance 
> 
>
> Key: GEODE-7680
> URL: https://issues.apache.org/jira/browse/GEODE-7680
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Donal Evans
>Priority: Major
>  Labels: GeodeCommons, caching-applications, 
> pull-request-available
> Fix For: 1.14.0
>
>
> Clear operations are successful and while rebalance operations are ongoing.
> Acceptance :
>  * DUnit tests validating the above behavior.
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7678) Partitioned Region clear operations must invoke cache level listeners

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174895#comment-17174895
 ] 

ASF subversion and git services commented on GEODE-7678:


Commit ab008ffd81d902bdddea88ef2b3736d8cf4ae8ea in geode's branch 
refs/heads/feature/GEODE-7665 from agingade
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=ab008ff ]

GEODE-7678 (2nd PR) - Support for cache-listener and client-notification for 
Partitioned Region Clear operation  (#5124)

* GEODE-7678: Add support for cache listener and client notification for PR 
clear

The changes are made to PR clear messaging and locking mechanism to preserve
cache-listener and client-events ordering during concurrent cache operation
while clear in progress.


> Partitioned Region clear operations must invoke cache level listeners
> -
>
> Key: GEODE-7678
> URL: https://issues.apache.org/jira/browse/GEODE-7678
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Anilkumar Gingade
>Priority: Major
>  Labels: GeodeCommons, GeodeOperationAPI
>
> Clear operations are successful and CacheListener.afterRegionClear(), 
> CacheWriter.beforeRegionClear() are invoked.
>  
> Acceptance :
>  * DUnit tests validating the above behavior.
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8173) Add test coverage for PartitionedRegionClear class

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174899#comment-17174899
 ] 

ASF subversion and git services commented on GEODE-8173:


Commit e5efc6d307e09356e4213074c60d9555c26cce52 in geode's branch 
refs/heads/feature/GEODE-7665 from agingade
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=e5efc6d ]

GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. (#5208)

* GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class.
Co-authored-by: anilkumar gingade 

> Add test coverage for PartitionedRegionClear class
> --
>
> Key: GEODE-8173
> URL: https://issues.apache.org/jira/browse/GEODE-8173
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Anilkumar Gingade
>Priority: Major
>  Labels: GeodeOperationAPI
> Fix For: 1.14.0
>
>
> Add test coverage for PartitionedRegionClear class.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174900#comment-17174900
 ] 

ASF subversion and git services commented on GEODE-8334:


Commit 2d82c288e5af109ae0c3311a2702c83e389ad720 in geode's branch 
refs/heads/feature/GEODE-7665 from Xiaojian Zhou
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=2d82c28 ]

GEODE-8334: PR.clear should sync with putAll or removeAll on rvvLock (#5365)


Co-authored-by: Xiaojian Zhou 
Co-authored-by: Anil Gingade 



> Primary and secondary bucket data mismatch with concurrent putAll/removeAll 
> and PR.clear 
> -
>
> Key: GEODE-8334
> URL: https://issues.apache.org/jira/browse/GEODE-8334
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Affects Versions: 1.14.0
>Reporter: Xiaojian Zhou
>Assignee: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeOperationAPI
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8361) Incorrect Bucket Count Warning Message Shown

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174901#comment-17174901
 ] 

ASF subversion and git services commented on GEODE-8361:


Commit 9909cae4cfe587ab1d07f6018b3688bc3dab0413 in geode's branch 
refs/heads/feature/GEODE-7665 from Donal Evans
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=9909cae ]

GEODE-8361: Use Set instead of List to track cleared buckets (#5379)

- Refactor PartitionRegionClear to use Set instead of List
- Some other changes to remove warnings/alerts from PartitionedRegionClear and 
PartitionedRegionClearMessage

Authored-by: Donal Evans 

> Incorrect Bucket Count Warning Message Shown
> 
>
> Key: GEODE-8361
> URL: https://issues.apache.org/jira/browse/GEODE-8361
> Project: Geode
>  Issue Type: Sub-task
>  Components: logging
>Reporter: Juan Ramos
>Assignee: Donal Evans
>Priority: Trivial
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> While analysing some failures related to GEODE-7670, I've noticed that 
> sometimes we report an incorrect bucket count within the warning message 
> logged when the clear didn't complete successfully that could confuse our 
> users.
> For this test the partition region always has 13 buckets so, as I user, I 
> would never expect to see a bucket count higher than 13 in my logs (no matter 
> how many redundant copies I have).
> ---
> Below are some examples:
> {noformat}
> [vm1] [warn 2020/07/15 11:56:17.739 GMT RMI TCP 
> Connection(5)-172.17.0.5 tid=0x5f] Unable to clear all the buckets from 
> the partitioned region PartitionedRegion, either data (buckets) moved or 
> member departed. expected to clear number of buckets: 13 actual cleared: 26
> [vm1] [warn 2020/07/15 11:57:48.403 GMT RMI TCP 
> Connection(6)-172.17.0.9 tid=0x10f] Unable to clear all the buckets from 
> the partitioned region PartitionedRegion, either data (buckets) moved or 
> member departed. expected to clear number of buckets: 13 actual cleared: 14
> [vm0] [warn 2020/07/15 12:07:36.227 GMT RMI TCP 
> Connection(32)-172.17.0.25 tid=0x1fe] Unable to clear all the buckets 
> from the partitioned region PartitionedRegion, either data (buckets) moved or 
> member departed. expected to clear number of buckets: 13 actual cleared: 19
> [vm0] [warn 2020/07/15 12:08:56.277 GMT RMI TCP 
> Connection(37)-172.17.0.24 tid=0x2a2] Unable to clear all the buckets 
> from the partitioned region PartitionedRegion, either data (buckets) moved or 
> member departed. expected to clear number of buckets: 13 actual cleared: 16
> {noformat}
> The full set of artefacts and results:
> {noformat}
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=  Test Results URI 
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> http://files.apachegeode-ci.info/builds/apache-develop-pr/geode-pr-4848/test-results/repeatTest/1594816968/
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> Test report artifacts from this job are available at:
> http://files.apachegeode-ci.info/builds/apache-develop-pr/geode-pr-4848/test-artifacts/1594816968/stressnewtestfiles-geode-pr-4848.tgz
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7669) Test coverage for Partitioned Region clear with Overflow enabled

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174897#comment-17174897
 ] 

ASF subversion and git services commented on GEODE-7669:


Commit df1b2d3218681fc8cac86adaf5b2eaa438aac893 in geode's branch 
refs/heads/feature/GEODE-7665 from Jianxia Chen
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=df1b2d3 ]

GEODE-7669 Test coverage for Partitioned Region clear with Overflow enabled 
(#5189)

Authored-by: Jianxia Chen 


> Test coverage for Partitioned Region clear with Overflow enabled
> 
>
> Key: GEODE-7669
> URL: https://issues.apache.org/jira/browse/GEODE-7669
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Jianxia Chen
>Priority: Major
>  Labels: GeodeCommons, GeodeOperationAPI
>
> Using TDD ensure that clear operations are successful when the partitioned 
> regions have overflow enabled.
> Make the code changes required to enable this.
>  
> Acceptance :
>  * Passing DUnit tests where clear operations are successful on partitioned 
> region with overflow enabled.
>  * Ensure that data has overflown when the clear operation is executed and in 
> the end everything is cleared.
>  * These tests should have redundancy of more than zero 
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.
> Note:
> analyze if these tests are needed for offheap?
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7670) Partitioned Region clear operations can occur during concurrent data operations

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174902#comment-17174902
 ] 

ASF subversion and git services commented on GEODE-7670:


Commit 7d45393e4819849ad819fba0bf547990c20223a2 in geode's branch 
refs/heads/feature/GEODE-7665 from Juan José Ramos
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=7d45393 ]

GEODE-7670: PR Clear with Concurrent Ops DUnitTests (#4848)

Added distributed tests to verify that the clear operation on
Partitioned Regions works as expected when there are other
concurrent operations happening on the cache (put, putAll, get,
remove, removeAll, members added and members removed).

> Partitioned Region clear operations can occur during concurrent data 
> operations
> ---
>
> Key: GEODE-7670
> URL: https://issues.apache.org/jira/browse/GEODE-7670
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Juan Ramos
>Priority: Major
>  Labels: GeodeCommons, pull-request-available
>  Time Spent: 5.5h
>  Remaining Estimate: 0h
>
> Clear operations are successful when concurrent read/write operations occur. 
> Ensure there are test coverage for this use case and modify the code needed 
> to enable this.
> Acceptance :
>  * Passing DUnit tests where clear operations are successful on partitioned 
> region with 
>  * concurrent puts (writes) and clear op
>  * concurrent gets (reads) and clear op
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7678) Partitioned Region clear operations must invoke cache level listeners

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174896#comment-17174896
 ] 

ASF subversion and git services commented on GEODE-7678:


Commit ab008ffd81d902bdddea88ef2b3736d8cf4ae8ea in geode's branch 
refs/heads/feature/GEODE-7665 from agingade
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=ab008ff ]

GEODE-7678 (2nd PR) - Support for cache-listener and client-notification for 
Partitioned Region Clear operation  (#5124)

* GEODE-7678: Add support for cache listener and client notification for PR 
clear

The changes are made to PR clear messaging and locking mechanism to preserve
cache-listener and client-events ordering during concurrent cache operation
while clear in progress.


> Partitioned Region clear operations must invoke cache level listeners
> -
>
> Key: GEODE-7678
> URL: https://issues.apache.org/jira/browse/GEODE-7678
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Anilkumar Gingade
>Priority: Major
>  Labels: GeodeCommons, GeodeOperationAPI
>
> Clear operations are successful and CacheListener.afterRegionClear(), 
> CacheWriter.beforeRegionClear() are invoked.
>  
> Acceptance :
>  * DUnit tests validating the above behavior.
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7667) GFSH commands - uniform gfsh command to clear regions

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174894#comment-17174894
 ] 

ASF subversion and git services commented on GEODE-7667:


Commit 2d7548446c8f6f0fa4c897e1c6ee2c5f2b89068b in geode's branch 
refs/heads/feature/GEODE-7665 from Nabarun Nag
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=2d75484 ]

GEODE-7667: Fixing test to include PR clear help text.


> GFSH commands - uniform gfsh command to clear regions
> -
>
> Key: GEODE-7667
> URL: https://issues.apache.org/jira/browse/GEODE-7667
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Benjamin P Ross
>Priority: Major
>  Labels: GeodeCommons, docs
>  Time Spent: 5h
>  Remaining Estimate: 0h
>
> * Currently, the gfsh command to clear replicated region is called ‘remove 
> —region=/regionName’.
>  * Replace this command with ‘clear region —region=regionName’
>  * While executing this gfsh command on partitioned regions, this should call 
> the clear() Java API using the gfsh function execution machinery.
>  * Point to note is that this command should take into consideration of the 
> coordinator selection and how this command is distributed to the members
> Acceptance :
>  * There should be ‘clear region —region=/regionName’ gfsh command
>  * The gfsh command must be documented in the Geode User Guide
>  * DUnit tests to verify that command can be executed successfully on 
> PartitionedRegion
>  * Deprecate the remove command, as remove does not mean clear
>  * Unit tests with complete code coverage for the newly written code.
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7676) All expiration tasks are cleared after a Partitioned Region is cleared

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174890#comment-17174890
 ] 

ASF subversion and git services commented on GEODE-7676:


Commit 2a2ebc998c5d0d8c053ca33bea9257ba52c52014 in geode's branch 
refs/heads/feature/GEODE-7665 from Nabarun Nag
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=2a2ebc9 ]

GEODE-7676: Conversion of duration to seconds.


> All expiration tasks are cleared after a Partitioned Region is cleared
> --
>
> Key: GEODE-7676
> URL: https://issues.apache.org/jira/browse/GEODE-7676
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Juan Ramos
>Priority: Major
>  Labels: GeodeCommons, feature/GEODE-7665
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> Clear operations are successful and all the expiration tasks are cleared in 
> the bucket level
> Acceptance :
>  * DUnit tests ensuring that clear operations are successful 
>  * Expiration tasks are cleared.
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7894) CustomSSLProviderDistributedTest hostNameIsValidatedWhenUsingDefaultContext fails with suspect uncaught DistributedSystemDisconnectedException

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174891#comment-17174891
 ] 

ASF subversion and git services commented on GEODE-7894:


Commit a5ca20c28231a683466af4b99a678b7d95f8d6c3 in geode's branch 
refs/heads/feature/GEODE-7665 from Nabarun Nag
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=a5ca20c ]

GEODE-7894: Moving expiry tasks to AbstractRegion.


> CustomSSLProviderDistributedTest hostNameIsValidatedWhenUsingDefaultContext 
> fails with suspect uncaught DistributedSystemDisconnectedException
> --
>
> Key: GEODE-7894
> URL: https://issues.apache.org/jira/browse/GEODE-7894
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Reporter: Darrel Schneider
>Assignee: Dan Smith
>Priority: Minor
>  Labels: flakey
> Fix For: 1.13.0
>
>
> See: 
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK8/builds/1663
> {noformat}
> org.apache.geode.cache.client.internal.CustomSSLProviderDistributedTest > 
> hostNameIsValidatedWhenUsingDefaultContext FAILED
> java.lang.AssertionError: Suspicious strings were written to the log 
> during this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> ---
> Found suspect string in log4j at line 1654
> [fatal 2020/03/19 17:26:01.806 GMT  tid=215] Uncaught 
> exception in thread Thread[unused p2p reader,5,RMI Runtime]
> org.apache.geode.distributed.DistributedSystemDisconnectedException: 
> Distribution manager on 172.17.0.15(server-1:113):41001 started at Thu 
> Mar 19 17:25:57 GMT 2020: Message distribution has terminated
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager$Stopper.generateCancelledException(ClusterDistributionManager.java:2873)
>   at 
> org.apache.geode.internal.tcp.TCPConduit$Stopper.generateCancelledException(TCPConduit.java:1004)
>   at 
> org.apache.geode.CancelCriterion.checkCancelInProgress(CancelCriterion.java:83)
>   at 
> org.apache.geode.internal.tcp.Connection.readMessages(Connection.java:1666)
>   at org.apache.geode.internal.tcp.Connection.run(Connection.java:1446)
>   at java.lang.Thread.run(Thread.java:748)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7669) Test coverage for Partitioned Region clear with Overflow enabled

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174569#comment-17174569
 ] 

ASF subversion and git services commented on GEODE-7669:


Commit df1b2d3218681fc8cac86adaf5b2eaa438aac893 in geode's branch 
refs/heads/feature/GEODE-7665 from Jianxia Chen
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=df1b2d3 ]

GEODE-7669 Test coverage for Partitioned Region clear with Overflow enabled 
(#5189)

Authored-by: Jianxia Chen 


> Test coverage for Partitioned Region clear with Overflow enabled
> 
>
> Key: GEODE-7669
> URL: https://issues.apache.org/jira/browse/GEODE-7669
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Jianxia Chen
>Priority: Major
>  Labels: GeodeCommons, GeodeOperationAPI
>
> Using TDD ensure that clear operations are successful when the partitioned 
> regions have overflow enabled.
> Make the code changes required to enable this.
>  
> Acceptance :
>  * Passing DUnit tests where clear operations are successful on partitioned 
> region with overflow enabled.
>  * Ensure that data has overflown when the clear operation is executed and in 
> the end everything is cleared.
>  * These tests should have redundancy of more than zero 
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.
> Note:
> analyze if these tests are needed for offheap?
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7680) Partitioned region clear operations must be successful while interacting with rebalance

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174619#comment-17174619
 ] 

ASF subversion and git services commented on GEODE-7680:


Commit 605f5b25493f4223e7fa30cc0c0b946e33e6c199 in geode's branch 
refs/heads/feature/GEODE-7665 from Donal Evans
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=605f5b2 ]

GEODE-7680: PR.clear must be successful when interacting with rebalance (#5095)

- Added DUnit tests to confirm that clear does not interfere with
rebalance or vice versa
- Test when member departs during clear/rebalance
- Test when member joins during clear/rebalance
- Fixed typo in PartitionedRegionClearWithExpirationDUnitTest
- Fixed typo in PartitionedRegion
- Call assignBucketsToPartitions() on leader colocated region during clear
instead of target region

Authored-by: Donal Evans 

> Partitioned region clear operations must be successful while interacting with 
> rebalance 
> 
>
> Key: GEODE-7680
> URL: https://issues.apache.org/jira/browse/GEODE-7680
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Donal Evans
>Priority: Major
>  Labels: GeodeCommons, caching-applications, 
> pull-request-available
> Fix For: 1.14.0
>
>
> Clear operations are successful and while rebalance operations are ongoing.
> Acceptance :
>  * DUnit tests validating the above behavior.
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174593#comment-17174593
 ] 

ASF subversion and git services commented on GEODE-8334:


Commit 2d82c288e5af109ae0c3311a2702c83e389ad720 in geode's branch 
refs/heads/feature/GEODE-7665 from Xiaojian Zhou
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=2d82c28 ]

GEODE-8334: PR.clear should sync with putAll or removeAll on rvvLock (#5365)


Co-authored-by: Xiaojian Zhou 
Co-authored-by: Anil Gingade 



> Primary and secondary bucket data mismatch with concurrent putAll/removeAll 
> and PR.clear 
> -
>
> Key: GEODE-8334
> URL: https://issues.apache.org/jira/browse/GEODE-8334
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Affects Versions: 1.14.0
>Reporter: Xiaojian Zhou
>Assignee: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeOperationAPI
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7678) Partitioned Region clear operations must invoke cache level listeners

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174547#comment-17174547
 ] 

ASF subversion and git services commented on GEODE-7678:


Commit ab008ffd81d902bdddea88ef2b3736d8cf4ae8ea in geode's branch 
refs/heads/feature/GEODE-7665 from agingade
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=ab008ff ]

GEODE-7678 (2nd PR) - Support for cache-listener and client-notification for 
Partitioned Region Clear operation  (#5124)

* GEODE-7678: Add support for cache listener and client notification for PR 
clear

The changes are made to PR clear messaging and locking mechanism to preserve
cache-listener and client-events ordering during concurrent cache operation
while clear in progress.


> Partitioned Region clear operations must invoke cache level listeners
> -
>
> Key: GEODE-7678
> URL: https://issues.apache.org/jira/browse/GEODE-7678
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Anilkumar Gingade
>Priority: Major
>  Labels: GeodeCommons, GeodeOperationAPI
>
> Clear operations are successful and CacheListener.afterRegionClear(), 
> CacheWriter.beforeRegionClear() are invoked.
>  
> Acceptance :
>  * DUnit tests validating the above behavior.
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8361) Incorrect Bucket Count Warning Message Shown

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174601#comment-17174601
 ] 

ASF subversion and git services commented on GEODE-8361:


Commit 9909cae4cfe587ab1d07f6018b3688bc3dab0413 in geode's branch 
refs/heads/feature/GEODE-7665 from Donal Evans
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=9909cae ]

GEODE-8361: Use Set instead of List to track cleared buckets (#5379)

- Refactor PartitionRegionClear to use Set instead of List
- Some other changes to remove warnings/alerts from PartitionedRegionClear and 
PartitionedRegionClearMessage

Authored-by: Donal Evans 

> Incorrect Bucket Count Warning Message Shown
> 
>
> Key: GEODE-8361
> URL: https://issues.apache.org/jira/browse/GEODE-8361
> Project: Geode
>  Issue Type: Sub-task
>  Components: logging
>Reporter: Juan Ramos
>Assignee: Donal Evans
>Priority: Trivial
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> While analysing some failures related to GEODE-7670, I've noticed that 
> sometimes we report an incorrect bucket count within the warning message 
> logged when the clear didn't complete successfully that could confuse our 
> users.
> For this test the partition region always has 13 buckets so, as I user, I 
> would never expect to see a bucket count higher than 13 in my logs (no matter 
> how many redundant copies I have).
> ---
> Below are some examples:
> {noformat}
> [vm1] [warn 2020/07/15 11:56:17.739 GMT RMI TCP 
> Connection(5)-172.17.0.5 tid=0x5f] Unable to clear all the buckets from 
> the partitioned region PartitionedRegion, either data (buckets) moved or 
> member departed. expected to clear number of buckets: 13 actual cleared: 26
> [vm1] [warn 2020/07/15 11:57:48.403 GMT RMI TCP 
> Connection(6)-172.17.0.9 tid=0x10f] Unable to clear all the buckets from 
> the partitioned region PartitionedRegion, either data (buckets) moved or 
> member departed. expected to clear number of buckets: 13 actual cleared: 14
> [vm0] [warn 2020/07/15 12:07:36.227 GMT RMI TCP 
> Connection(32)-172.17.0.25 tid=0x1fe] Unable to clear all the buckets 
> from the partitioned region PartitionedRegion, either data (buckets) moved or 
> member departed. expected to clear number of buckets: 13 actual cleared: 19
> [vm0] [warn 2020/07/15 12:08:56.277 GMT RMI TCP 
> Connection(37)-172.17.0.24 tid=0x2a2] Unable to clear all the buckets 
> from the partitioned region PartitionedRegion, either data (buckets) moved or 
> member departed. expected to clear number of buckets: 13 actual cleared: 16
> {noformat}
> The full set of artefacts and results:
> {noformat}
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=  Test Results URI 
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> http://files.apachegeode-ci.info/builds/apache-develop-pr/geode-pr-4848/test-results/repeatTest/1594816968/
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> Test report artifacts from this job are available at:
> http://files.apachegeode-ci.info/builds/apache-develop-pr/geode-pr-4848/test-artifacts/1594816968/stressnewtestfiles-geode-pr-4848.tgz
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7670) Partitioned Region clear operations can occur during concurrent data operations

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174608#comment-17174608
 ] 

ASF subversion and git services commented on GEODE-7670:


Commit 7d45393e4819849ad819fba0bf547990c20223a2 in geode's branch 
refs/heads/feature/GEODE-7665 from Juan José Ramos
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=7d45393 ]

GEODE-7670: PR Clear with Concurrent Ops DUnitTests (#4848)

Added distributed tests to verify that the clear operation on
Partitioned Regions works as expected when there are other
concurrent operations happening on the cache (put, putAll, get,
remove, removeAll, members added and members removed).

> Partitioned Region clear operations can occur during concurrent data 
> operations
> ---
>
> Key: GEODE-7670
> URL: https://issues.apache.org/jira/browse/GEODE-7670
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Juan Ramos
>Priority: Major
>  Labels: GeodeCommons, pull-request-available
>  Time Spent: 5.5h
>  Remaining Estimate: 0h
>
> Clear operations are successful when concurrent read/write operations occur. 
> Ensure there are test coverage for this use case and modify the code needed 
> to enable this.
> Acceptance :
>  * Passing DUnit tests where clear operations are successful on partitioned 
> region with 
>  * concurrent puts (writes) and clear op
>  * concurrent gets (reads) and clear op
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7894) CustomSSLProviderDistributedTest hostNameIsValidatedWhenUsingDefaultContext fails with suspect uncaught DistributedSystemDisconnectedException

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174504#comment-17174504
 ] 

ASF subversion and git services commented on GEODE-7894:


Commit a5ca20c28231a683466af4b99a678b7d95f8d6c3 in geode's branch 
refs/heads/feature/GEODE-7665 from Nabarun Nag
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=a5ca20c ]

GEODE-7894: Moving expiry tasks to AbstractRegion.


> CustomSSLProviderDistributedTest hostNameIsValidatedWhenUsingDefaultContext 
> fails with suspect uncaught DistributedSystemDisconnectedException
> --
>
> Key: GEODE-7894
> URL: https://issues.apache.org/jira/browse/GEODE-7894
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Reporter: Darrel Schneider
>Assignee: Dan Smith
>Priority: Minor
>  Labels: flakey
> Fix For: 1.13.0
>
>
> See: 
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK8/builds/1663
> {noformat}
> org.apache.geode.cache.client.internal.CustomSSLProviderDistributedTest > 
> hostNameIsValidatedWhenUsingDefaultContext FAILED
> java.lang.AssertionError: Suspicious strings were written to the log 
> during this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> ---
> Found suspect string in log4j at line 1654
> [fatal 2020/03/19 17:26:01.806 GMT  tid=215] Uncaught 
> exception in thread Thread[unused p2p reader,5,RMI Runtime]
> org.apache.geode.distributed.DistributedSystemDisconnectedException: 
> Distribution manager on 172.17.0.15(server-1:113):41001 started at Thu 
> Mar 19 17:25:57 GMT 2020: Message distribution has terminated
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager$Stopper.generateCancelledException(ClusterDistributionManager.java:2873)
>   at 
> org.apache.geode.internal.tcp.TCPConduit$Stopper.generateCancelledException(TCPConduit.java:1004)
>   at 
> org.apache.geode.CancelCriterion.checkCancelInProgress(CancelCriterion.java:83)
>   at 
> org.apache.geode.internal.tcp.Connection.readMessages(Connection.java:1666)
>   at org.apache.geode.internal.tcp.Connection.run(Connection.java:1446)
>   at java.lang.Thread.run(Thread.java:748)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8173) Add test coverage for PartitionedRegionClear class

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174586#comment-17174586
 ] 

ASF subversion and git services commented on GEODE-8173:


Commit e5efc6d307e09356e4213074c60d9555c26cce52 in geode's branch 
refs/heads/feature/GEODE-7665 from agingade
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=e5efc6d ]

GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. (#5208)

* GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class.
Co-authored-by: anilkumar gingade 

> Add test coverage for PartitionedRegionClear class
> --
>
> Key: GEODE-8173
> URL: https://issues.apache.org/jira/browse/GEODE-8173
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Anilkumar Gingade
>Priority: Major
>  Labels: GeodeOperationAPI
> Fix For: 1.14.0
>
>
> Add test coverage for PartitionedRegionClear class.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7678) Partitioned Region clear operations must invoke cache level listeners

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174528#comment-17174528
 ] 

ASF subversion and git services commented on GEODE-7678:


Commit ab008ffd81d902bdddea88ef2b3736d8cf4ae8ea in geode's branch 
refs/heads/feature/GEODE-7665 from agingade
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=ab008ff ]

GEODE-7678 (2nd PR) - Support for cache-listener and client-notification for 
Partitioned Region Clear operation  (#5124)

* GEODE-7678: Add support for cache listener and client notification for PR 
clear

The changes are made to PR clear messaging and locking mechanism to preserve
cache-listener and client-events ordering during concurrent cache operation
while clear in progress.


> Partitioned Region clear operations must invoke cache level listeners
> -
>
> Key: GEODE-7678
> URL: https://issues.apache.org/jira/browse/GEODE-7678
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Anilkumar Gingade
>Priority: Major
>  Labels: GeodeCommons, GeodeOperationAPI
>
> Clear operations are successful and CacheListener.afterRegionClear(), 
> CacheWriter.beforeRegionClear() are invoked.
>  
> Acceptance :
>  * DUnit tests validating the above behavior.
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7667) GFSH commands - uniform gfsh command to clear regions

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174516#comment-17174516
 ] 

ASF subversion and git services commented on GEODE-7667:


Commit 2d7548446c8f6f0fa4c897e1c6ee2c5f2b89068b in geode's branch 
refs/heads/feature/GEODE-7665 from Nabarun Nag
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=2d75484 ]

GEODE-7667: Fixing test to include PR clear help text.


> GFSH commands - uniform gfsh command to clear regions
> -
>
> Key: GEODE-7667
> URL: https://issues.apache.org/jira/browse/GEODE-7667
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Benjamin P Ross
>Priority: Major
>  Labels: GeodeCommons, docs
>  Time Spent: 5h
>  Remaining Estimate: 0h
>
> * Currently, the gfsh command to clear replicated region is called ‘remove 
> —region=/regionName’.
>  * Replace this command with ‘clear region —region=regionName’
>  * While executing this gfsh command on partitioned regions, this should call 
> the clear() Java API using the gfsh function execution machinery.
>  * Point to note is that this command should take into consideration of the 
> coordinator selection and how this command is distributed to the members
> Acceptance :
>  * There should be ‘clear region —region=/regionName’ gfsh command
>  * The gfsh command must be documented in the Geode User Guide
>  * DUnit tests to verify that command can be executed successfully on 
> PartitionedRegion
>  * Deprecate the remove command, as remove does not mean clear
>  * Unit tests with complete code coverage for the newly written code.
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7676) All expiration tasks are cleared after a Partitioned Region is cleared

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174493#comment-17174493
 ] 

ASF subversion and git services commented on GEODE-7676:


Commit 2a2ebc998c5d0d8c053ca33bea9257ba52c52014 in geode's branch 
refs/heads/feature/GEODE-7665 from Nabarun Nag
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=2a2ebc9 ]

GEODE-7676: Conversion of duration to seconds.


> All expiration tasks are cleared after a Partitioned Region is cleared
> --
>
> Key: GEODE-7676
> URL: https://issues.apache.org/jira/browse/GEODE-7676
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Juan Ramos
>Priority: Major
>  Labels: GeodeCommons, feature/GEODE-7665
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> Clear operations are successful and all the expiration tasks are cleared in 
> the bucket level
> Acceptance :
>  * DUnit tests ensuring that clear operations are successful 
>  * Expiration tasks are cleared.
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7894) CustomSSLProviderDistributedTest hostNameIsValidatedWhenUsingDefaultContext fails with suspect uncaught DistributedSystemDisconnectedException

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174450#comment-17174450
 ] 

ASF subversion and git services commented on GEODE-7894:


Commit a5ca20c28231a683466af4b99a678b7d95f8d6c3 in geode's branch 
refs/heads/feature/GEODE-7665 from Nabarun Nag
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=a5ca20c ]

GEODE-7894: Moving expiry tasks to AbstractRegion.


> CustomSSLProviderDistributedTest hostNameIsValidatedWhenUsingDefaultContext 
> fails with suspect uncaught DistributedSystemDisconnectedException
> --
>
> Key: GEODE-7894
> URL: https://issues.apache.org/jira/browse/GEODE-7894
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Reporter: Darrel Schneider
>Assignee: Dan Smith
>Priority: Minor
>  Labels: flakey
> Fix For: 1.13.0
>
>
> See: 
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK8/builds/1663
> {noformat}
> org.apache.geode.cache.client.internal.CustomSSLProviderDistributedTest > 
> hostNameIsValidatedWhenUsingDefaultContext FAILED
> java.lang.AssertionError: Suspicious strings were written to the log 
> during this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> ---
> Found suspect string in log4j at line 1654
> [fatal 2020/03/19 17:26:01.806 GMT  tid=215] Uncaught 
> exception in thread Thread[unused p2p reader,5,RMI Runtime]
> org.apache.geode.distributed.DistributedSystemDisconnectedException: 
> Distribution manager on 172.17.0.15(server-1:113):41001 started at Thu 
> Mar 19 17:25:57 GMT 2020: Message distribution has terminated
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager$Stopper.generateCancelledException(ClusterDistributionManager.java:2873)
>   at 
> org.apache.geode.internal.tcp.TCPConduit$Stopper.generateCancelledException(TCPConduit.java:1004)
>   at 
> org.apache.geode.CancelCriterion.checkCancelInProgress(CancelCriterion.java:83)
>   at 
> org.apache.geode.internal.tcp.Connection.readMessages(Connection.java:1666)
>   at org.apache.geode.internal.tcp.Connection.run(Connection.java:1446)
>   at java.lang.Thread.run(Thread.java:748)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7669) Test coverage for Partitioned Region clear with Overflow enabled

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174454#comment-17174454
 ] 

ASF subversion and git services commented on GEODE-7669:


Commit df1b2d3218681fc8cac86adaf5b2eaa438aac893 in geode's branch 
refs/heads/feature/GEODE-7665 from Jianxia Chen
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=df1b2d3 ]

GEODE-7669 Test coverage for Partitioned Region clear with Overflow enabled 
(#5189)

Authored-by: Jianxia Chen 


> Test coverage for Partitioned Region clear with Overflow enabled
> 
>
> Key: GEODE-7669
> URL: https://issues.apache.org/jira/browse/GEODE-7669
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Jianxia Chen
>Priority: Major
>  Labels: GeodeCommons, GeodeOperationAPI
>
> Using TDD ensure that clear operations are successful when the partitioned 
> regions have overflow enabled.
> Make the code changes required to enable this.
>  
> Acceptance :
>  * Passing DUnit tests where clear operations are successful on partitioned 
> region with overflow enabled.
>  * Ensure that data has overflown when the clear operation is executed and in 
> the end everything is cleared.
>  * These tests should have redundancy of more than zero 
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.
> Note:
> analyze if these tests are needed for offheap?
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7676) All expiration tasks are cleared after a Partitioned Region is cleared

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174449#comment-17174449
 ] 

ASF subversion and git services commented on GEODE-7676:


Commit 2a2ebc998c5d0d8c053ca33bea9257ba52c52014 in geode's branch 
refs/heads/feature/GEODE-7665 from Nabarun Nag
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=2a2ebc9 ]

GEODE-7676: Conversion of duration to seconds.


> All expiration tasks are cleared after a Partitioned Region is cleared
> --
>
> Key: GEODE-7676
> URL: https://issues.apache.org/jira/browse/GEODE-7676
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Juan Ramos
>Priority: Major
>  Labels: GeodeCommons, feature/GEODE-7665
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> Clear operations are successful and all the expiration tasks are cleared in 
> the bucket level
> Acceptance :
>  * DUnit tests ensuring that clear operations are successful 
>  * Expiration tasks are cleared.
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7680) Partitioned region clear operations must be successful while interacting with rebalance

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174460#comment-17174460
 ] 

ASF subversion and git services commented on GEODE-7680:


Commit 605f5b25493f4223e7fa30cc0c0b946e33e6c199 in geode's branch 
refs/heads/feature/GEODE-7665 from Donal Evans
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=605f5b2 ]

GEODE-7680: PR.clear must be successful when interacting with rebalance (#5095)

- Added DUnit tests to confirm that clear does not interfere with
rebalance or vice versa
- Test when member departs during clear/rebalance
- Test when member joins during clear/rebalance
- Fixed typo in PartitionedRegionClearWithExpirationDUnitTest
- Fixed typo in PartitionedRegion
- Call assignBucketsToPartitions() on leader colocated region during clear
instead of target region

Authored-by: Donal Evans 

> Partitioned region clear operations must be successful while interacting with 
> rebalance 
> 
>
> Key: GEODE-7680
> URL: https://issues.apache.org/jira/browse/GEODE-7680
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Donal Evans
>Priority: Major
>  Labels: GeodeCommons, caching-applications, 
> pull-request-available
> Fix For: 1.14.0
>
>
> Clear operations are successful and while rebalance operations are ongoing.
> Acceptance :
>  * DUnit tests validating the above behavior.
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7678) Partitioned Region clear operations must invoke cache level listeners

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174452#comment-17174452
 ] 

ASF subversion and git services commented on GEODE-7678:


Commit ab008ffd81d902bdddea88ef2b3736d8cf4ae8ea in geode's branch 
refs/heads/feature/GEODE-7665 from agingade
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=ab008ff ]

GEODE-7678 (2nd PR) - Support for cache-listener and client-notification for 
Partitioned Region Clear operation  (#5124)

* GEODE-7678: Add support for cache listener and client notification for PR 
clear

The changes are made to PR clear messaging and locking mechanism to preserve
cache-listener and client-events ordering during concurrent cache operation
while clear in progress.


> Partitioned Region clear operations must invoke cache level listeners
> -
>
> Key: GEODE-7678
> URL: https://issues.apache.org/jira/browse/GEODE-7678
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Anilkumar Gingade
>Priority: Major
>  Labels: GeodeCommons, GeodeOperationAPI
>
> Clear operations are successful and CacheListener.afterRegionClear(), 
> CacheWriter.beforeRegionClear() are invoked.
>  
> Acceptance :
>  * DUnit tests validating the above behavior.
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7678) Partitioned Region clear operations must invoke cache level listeners

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174453#comment-17174453
 ] 

ASF subversion and git services commented on GEODE-7678:


Commit ab008ffd81d902bdddea88ef2b3736d8cf4ae8ea in geode's branch 
refs/heads/feature/GEODE-7665 from agingade
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=ab008ff ]

GEODE-7678 (2nd PR) - Support for cache-listener and client-notification for 
Partitioned Region Clear operation  (#5124)

* GEODE-7678: Add support for cache listener and client notification for PR 
clear

The changes are made to PR clear messaging and locking mechanism to preserve
cache-listener and client-events ordering during concurrent cache operation
while clear in progress.


> Partitioned Region clear operations must invoke cache level listeners
> -
>
> Key: GEODE-7678
> URL: https://issues.apache.org/jira/browse/GEODE-7678
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Anilkumar Gingade
>Priority: Major
>  Labels: GeodeCommons, GeodeOperationAPI
>
> Clear operations are successful and CacheListener.afterRegionClear(), 
> CacheWriter.beforeRegionClear() are invoked.
>  
> Acceptance :
>  * DUnit tests validating the above behavior.
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8173) Add test coverage for PartitionedRegionClear class

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174456#comment-17174456
 ] 

ASF subversion and git services commented on GEODE-8173:


Commit e5efc6d307e09356e4213074c60d9555c26cce52 in geode's branch 
refs/heads/feature/GEODE-7665 from agingade
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=e5efc6d ]

GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. (#5208)

* GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class.
Co-authored-by: anilkumar gingade 

> Add test coverage for PartitionedRegionClear class
> --
>
> Key: GEODE-8173
> URL: https://issues.apache.org/jira/browse/GEODE-8173
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Anilkumar Gingade
>Priority: Major
>  Labels: GeodeOperationAPI
> Fix For: 1.14.0
>
>
> Add test coverage for PartitionedRegionClear class.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7667) GFSH commands - uniform gfsh command to clear regions

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174451#comment-17174451
 ] 

ASF subversion and git services commented on GEODE-7667:


Commit 2d7548446c8f6f0fa4c897e1c6ee2c5f2b89068b in geode's branch 
refs/heads/feature/GEODE-7665 from Nabarun Nag
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=2d75484 ]

GEODE-7667: Fixing test to include PR clear help text.


> GFSH commands - uniform gfsh command to clear regions
> -
>
> Key: GEODE-7667
> URL: https://issues.apache.org/jira/browse/GEODE-7667
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Benjamin P Ross
>Priority: Major
>  Labels: GeodeCommons, docs
>  Time Spent: 5h
>  Remaining Estimate: 0h
>
> * Currently, the gfsh command to clear replicated region is called ‘remove 
> —region=/regionName’.
>  * Replace this command with ‘clear region —region=regionName’
>  * While executing this gfsh command on partitioned regions, this should call 
> the clear() Java API using the gfsh function execution machinery.
>  * Point to note is that this command should take into consideration of the 
> coordinator selection and how this command is distributed to the members
> Acceptance :
>  * There should be ‘clear region —region=/regionName’ gfsh command
>  * The gfsh command must be documented in the Geode User Guide
>  * DUnit tests to verify that command can be executed successfully on 
> PartitionedRegion
>  * Deprecate the remove command, as remove does not mean clear
>  * Unit tests with complete code coverage for the newly written code.
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174457#comment-17174457
 ] 

ASF subversion and git services commented on GEODE-8334:


Commit 2d82c288e5af109ae0c3311a2702c83e389ad720 in geode's branch 
refs/heads/feature/GEODE-7665 from Xiaojian Zhou
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=2d82c28 ]

GEODE-8334: PR.clear should sync with putAll or removeAll on rvvLock (#5365)


Co-authored-by: Xiaojian Zhou 
Co-authored-by: Anil Gingade 



> Primary and secondary bucket data mismatch with concurrent putAll/removeAll 
> and PR.clear 
> -
>
> Key: GEODE-8334
> URL: https://issues.apache.org/jira/browse/GEODE-8334
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Affects Versions: 1.14.0
>Reporter: Xiaojian Zhou
>Assignee: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeOperationAPI
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7670) Partitioned Region clear operations can occur during concurrent data operations

2020-08-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174459#comment-17174459
 ] 

ASF subversion and git services commented on GEODE-7670:


Commit 7d45393e4819849ad819fba0bf547990c20223a2 in geode's branch 
refs/heads/feature/GEODE-7665 from Juan José Ramos
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=7d45393 ]

GEODE-7670: PR Clear with Concurrent Ops DUnitTests (#4848)

Added distributed tests to verify that the clear operation on
Partitioned Regions works as expected when there are other
concurrent operations happening on the cache (put, putAll, get,
remove, removeAll, members added and members removed).

> Partitioned Region clear operations can occur during concurrent data 
> operations
> ---
>
> Key: GEODE-7670
> URL: https://issues.apache.org/jira/browse/GEODE-7670
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Juan Ramos
>Priority: Major
>  Labels: GeodeCommons, pull-request-available
>  Time Spent: 5.5h
>  Remaining Estimate: 0h
>
> Clear operations are successful when concurrent read/write operations occur. 
> Ensure there are test coverage for this use case and modify the code needed 
> to enable this.
> Acceptance :
>  * Passing DUnit tests where clear operations are successful on partitioned 
> region with 
>  * concurrent puts (writes) and clear op
>  * concurrent gets (reads) and clear op
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


  1   2   >