[jira] [Commented] (GEODE-10016) Use Thread Name In Log Messages
[ https://issues.apache.org/jira/browse/GEODE-10016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488606#comment-17488606 ] ASF GitHub Bot commented on GEODE-10016: mmartell commented on a change in pull request #918: URL: https://github.com/apache/geode-native/pull/918#discussion_r801291414 ## File path: cppcache/src/ThreadPool.cpp ## @@ -16,20 +16,19 @@ */ #include "ThreadPool.hpp" +#include "./util/Log.hpp" Review comment: Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Use Thread Name In Log Messages > --- > > Key: GEODE-10016 > URL: https://issues.apache.org/jira/browse/GEODE-10016 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Michael Martell >Priority: Minor > Labels: pull-request-available > > The native client logging system currently prints the threadId in all log > messages. Since all internally created native client threads are named, we > should print the threadName instead of threadId. This will be extremely > helpful to understanding the flow of messages since there are many background > threads in the native client. > Note: Lots of log messages are running on an application thread which was not > created internally by the native client. Messages running on these threads > should continue to print the threadId. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (GEODE-10016) Use Thread Name In Log Messages
[ https://issues.apache.org/jira/browse/GEODE-10016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488570#comment-17488570 ] ASF GitHub Bot commented on GEODE-10016: pivotal-jbarrett commented on a change in pull request #918: URL: https://github.com/apache/geode-native/pull/918#discussion_r801232140 ## File path: cppcache/src/ThreadPool.cpp ## @@ -16,20 +16,19 @@ */ #include "ThreadPool.hpp" +#include "./util/Log.hpp" Review comment: ./ is redundant here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Use Thread Name In Log Messages > --- > > Key: GEODE-10016 > URL: https://issues.apache.org/jira/browse/GEODE-10016 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Michael Martell >Priority: Minor > Labels: pull-request-available > > The native client logging system currently prints the threadId in all log > messages. Since all internally created native client threads are named, we > should print the threadName instead of threadId. This will be extremely > helpful to understanding the flow of messages since there are many background > threads in the native client. > Note: Lots of log messages are running on an application thread which was not > created internally by the native client. Messages running on these threads > should continue to print the threadId. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (GEODE-10016) Use Thread Name In Log Messages
[
https://issues.apache.org/jira/browse/GEODE-10016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488547#comment-17488547
]
ASF GitHub Bot commented on GEODE-10016:
mmartell commented on a change in pull request #918:
URL: https://github.com/apache/geode-native/pull/918#discussion_r801207475
##
File path: cppcache/src/Log.cpp
##
@@ -378,12 +421,21 @@ std::string Log::formatLogLine(LogLevel level) {
now - std::chrono::system_clock::from_time_t(secs));
auto tm_val = apache::geode::util::chrono::localtime(secs);
+ std::thread::id id = std::this_thread::get_id();
+ std::stringstream ss;
+ ss << id;
+ std::string threadIdWithName;
+ if (getThreadName() != "") {
+threadIdWithName = ss.str() + " (" + getThreadName() + ")";
+ } else {
+threadIdWithName = ss.str();
+ }
+
msg << "[" << Log::levelToChars(level) << " "
<< std::put_time(_val, "%Y/%m/%d %H:%M:%S") << '.' <<
std::setfill('0')
<< std::setw(6) << microseconds.count() << ' '
<< std::put_time(_val, "%z ") << g_hostName << ":"
- << boost::this_process::get_id() << " " << std::this_thread::get_id()
- << "] ";
+ << boost::this_process::get_id() << " " << threadIdWithName << "] ";
Review comment:
Good catch. Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use Thread Name In Log Messages
> ---
>
> Key: GEODE-10016
> URL: https://issues.apache.org/jira/browse/GEODE-10016
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Michael Martell
>Priority: Minor
> Labels: pull-request-available
>
> The native client logging system currently prints the threadId in all log
> messages. Since all internally created native client threads are named, we
> should print the threadName instead of threadId. This will be extremely
> helpful to understanding the flow of messages since there are many background
> threads in the native client.
> Note: Lots of log messages are running on an application thread which was not
> created internally by the native client. Messages running on these threads
> should continue to print the threadId.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (GEODE-10016) Use Thread Name In Log Messages
[
https://issues.apache.org/jira/browse/GEODE-10016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488545#comment-17488545
]
ASF GitHub Bot commented on GEODE-10016:
mmartell commented on a change in pull request #918:
URL: https://github.com/apache/geode-native/pull/918#discussion_r801207149
##
File path: cppcache/src/Log.cpp
##
@@ -369,6 +372,46 @@ LogLevel Log::charsToLevel(const std::string& chars) {
}
}
+void Log::setThreadName(const std::string& threadName) {
Review comment:
Need to leave this alone because of the try/except block. If string is
not const we get this error:
ErrorC2712 Cannot use __try in functions that require object
unwinding apache-geode-static C:\temp\geode-native\cppcache\src\Log.cpp
413
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use Thread Name In Log Messages
> ---
>
> Key: GEODE-10016
> URL: https://issues.apache.org/jira/browse/GEODE-10016
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Michael Martell
>Priority: Minor
> Labels: pull-request-available
>
> The native client logging system currently prints the threadId in all log
> messages. Since all internally created native client threads are named, we
> should print the threadName instead of threadId. This will be extremely
> helpful to understanding the flow of messages since there are many background
> threads in the native client.
> Note: Lots of log messages are running on an application thread which was not
> created internally by the native client. Messages running on these threads
> should continue to print the threadId.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (GEODE-10016) Use Thread Name In Log Messages
[ https://issues.apache.org/jira/browse/GEODE-10016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488544#comment-17488544 ] ASF GitHub Bot commented on GEODE-10016: mmartell commented on a change in pull request #918: URL: https://github.com/apache/geode-native/pull/918#discussion_r801205976 ## File path: cppcache/src/Log.cpp ## @@ -38,6 +38,7 @@ #include #include +#include "DistributedSystemImpl.hpp" Review comment: Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Use Thread Name In Log Messages > --- > > Key: GEODE-10016 > URL: https://issues.apache.org/jira/browse/GEODE-10016 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Michael Martell >Priority: Minor > Labels: pull-request-available > > The native client logging system currently prints the threadId in all log > messages. Since all internally created native client threads are named, we > should print the threadName instead of threadId. This will be extremely > helpful to understanding the flow of messages since there are many background > threads in the native client. > Note: Lots of log messages are running on an application thread which was not > created internally by the native client. Messages running on these threads > should continue to print the threadId. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (GEODE-10016) Use Thread Name In Log Messages
[ https://issues.apache.org/jira/browse/GEODE-10016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488540#comment-17488540 ] ASF GitHub Bot commented on GEODE-10016: mmartell commented on a change in pull request #918: URL: https://github.com/apache/geode-native/pull/918#discussion_r801202748 ## File path: cppcache/src/SystemProperties.cpp ## @@ -169,7 +169,8 @@ SystemProperties::SystemProperties( m_sslTrustStore(DefaultSslTrustStore), m_sslKeystorePassword(DefaultSslKeystorePassword), m_conflateEvents(DefaultConflateEvents), - m_threadPoolSize(DefaultThreadPoolSize), + // m_threadPoolSize(DefaultThreadPoolSize), + m_threadPoolSize(16), Review comment: Good catch. Yup that was for investigating impact of threadLocals on TSSDataOutput buffers. Reverted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Use Thread Name In Log Messages > --- > > Key: GEODE-10016 > URL: https://issues.apache.org/jira/browse/GEODE-10016 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Michael Martell >Priority: Minor > Labels: pull-request-available > > The native client logging system currently prints the threadId in all log > messages. Since all internally created native client threads are named, we > should print the threadName instead of threadId. This will be extremely > helpful to understanding the flow of messages since there are many background > threads in the native client. > Note: Lots of log messages are running on an application thread which was not > created internally by the native client. Messages running on these threads > should continue to print the threadId. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (GEODE-10016) Use Thread Name In Log Messages
[
https://issues.apache.org/jira/browse/GEODE-10016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488539#comment-17488539
]
ASF GitHub Bot commented on GEODE-10016:
mmartell commented on a change in pull request #918:
URL: https://github.com/apache/geode-native/pull/918#discussion_r801202171
##
File path: cppcache/src/Log.cpp
##
@@ -378,12 +421,21 @@ std::string Log::formatLogLine(LogLevel level) {
now - std::chrono::system_clock::from_time_t(secs));
auto tm_val = apache::geode::util::chrono::localtime(secs);
+ std::thread::id id = std::this_thread::get_id();
Review comment:
Good catch. Inlined.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use Thread Name In Log Messages
> ---
>
> Key: GEODE-10016
> URL: https://issues.apache.org/jira/browse/GEODE-10016
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Michael Martell
>Priority: Minor
> Labels: pull-request-available
>
> The native client logging system currently prints the threadId in all log
> messages. Since all internally created native client threads are named, we
> should print the threadName instead of threadId. This will be extremely
> helpful to understanding the flow of messages since there are many background
> threads in the native client.
> Note: Lots of log messages are running on an application thread which was not
> created internally by the native client. Messages running on these threads
> should continue to print the threadId.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (GEODE-10016) Use Thread Name In Log Messages
[ https://issues.apache.org/jira/browse/GEODE-10016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488537#comment-17488537 ] ASF GitHub Bot commented on GEODE-10016: mmartell commented on a change in pull request #918: URL: https://github.com/apache/geode-native/pull/918#discussion_r801201189 ## File path: cppcache/src/Log.cpp ## @@ -60,6 +61,8 @@ static FILE* g_log = nullptr; static std::string g_hostName; +static thread_local std::string g_threadName; Review comment: Leaving this one to be consistent with name of several other variables in this file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Use Thread Name In Log Messages > --- > > Key: GEODE-10016 > URL: https://issues.apache.org/jira/browse/GEODE-10016 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Michael Martell >Priority: Minor > Labels: pull-request-available > > The native client logging system currently prints the threadId in all log > messages. Since all internally created native client threads are named, we > should print the threadName instead of threadId. This will be extremely > helpful to understanding the flow of messages since there are many background > threads in the native client. > Note: Lots of log messages are running on an application thread which was not > created internally by the native client. Messages running on these threads > should continue to print the threadId. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (GEODE-10016) Use Thread Name In Log Messages
[
https://issues.apache.org/jira/browse/GEODE-10016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488535#comment-17488535
]
ASF GitHub Bot commented on GEODE-10016:
mmartell commented on a change in pull request #918:
URL: https://github.com/apache/geode-native/pull/918#discussion_r801200713
##
File path: cppcache/src/ExpiryTaskManager.cpp
##
@@ -51,7 +51,7 @@ void ExpiryTaskManager::start() {
auto start_future = start_promise.get_future();
runner_ = std::thread{[this, _promise] {
start_promise.set_value(true);
-DistributedSystemImpl::setThreadName(NC_ETM_Thread);
+Log::setThreadName(NC_ETM_Thread);
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use Thread Name In Log Messages
> ---
>
> Key: GEODE-10016
> URL: https://issues.apache.org/jira/browse/GEODE-10016
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Michael Martell
>Priority: Minor
> Labels: pull-request-available
>
> The native client logging system currently prints the threadId in all log
> messages. Since all internally created native client threads are named, we
> should print the threadName instead of threadId. This will be extremely
> helpful to understanding the flow of messages since there are many background
> threads in the native client.
> Note: Lots of log messages are running on an application thread which was not
> created internally by the native client. Messages running on these threads
> should continue to print the threadId.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (GEODE-10016) Use Thread Name In Log Messages
[ https://issues.apache.org/jira/browse/GEODE-10016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488534#comment-17488534 ] ASF GitHub Bot commented on GEODE-10016: mmartell commented on a change in pull request #918: URL: https://github.com/apache/geode-native/pull/918#discussion_r801200642 ## File path: cppcache/src/DistributedSystemImpl.hpp ## @@ -24,6 +24,7 @@ #include #include #include +#include Review comment: Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Use Thread Name In Log Messages > --- > > Key: GEODE-10016 > URL: https://issues.apache.org/jira/browse/GEODE-10016 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Michael Martell >Priority: Minor > Labels: pull-request-available > > The native client logging system currently prints the threadId in all log > messages. Since all internally created native client threads are named, we > should print the threadName instead of threadId. This will be extremely > helpful to understanding the flow of messages since there are many background > threads in the native client. > Note: Lots of log messages are running on an application thread which was not > created internally by the native client. Messages running on these threads > should continue to print the threadId. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (GEODE-10009) The CacheClientProxy for a durable client can be terminated when it shouldn't be
[ https://issues.apache.org/jira/browse/GEODE-10009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488524#comment-17488524 ] ASF subversion and git services commented on GEODE-10009: - Commit 551d7d78548f10218146b074df9b0c4adc0940f7 in geode's branch refs/heads/develop from Barry Oglesby [ https://gitbox.apache.org/repos/asf?p=geode.git;h=551d7d7 ] GEODE-10009: Invoked internalClose with keepAlive true (#7332) > The CacheClientProxy for a durable client can be terminated when it shouldn't > be > > > Key: GEODE-10009 > URL: https://issues.apache.org/jira/browse/GEODE-10009 > Project: Geode > Issue Type: Bug > Components: client queues >Affects Versions: 1.15.0 >Reporter: Barrett Oglesby >Assignee: Barrett Oglesby >Priority: Major > Labels: blocks-1.15.0, pull-request-available > > When the client connection is closed but the server has not left or crashed > (e.g in the re-authentication failed case), its possible that two threads in > a durable client can interleave in a way that causes an extra durable task to > be created on the server that eventually causes the CacheClientProxy to be > terminated. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (GEODE-10021) Clean up RemoteTrasactionDUnitTest
Hale Bales created GEODE-10021: -- Summary: Clean up RemoteTrasactionDUnitTest Key: GEODE-10021 URL: https://issues.apache.org/jira/browse/GEODE-10021 Project: Geode Issue Type: Improvement Affects Versions: 1.16.0 Reporter: Hale Bales I have been working on GEODE-9929 and the failing DUnitTest has a lot of errors. I want to clean up some of the errors where I can use find and replace, as well as a couple of changes to make it easier for the next person who works on GEODE-9929. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (GEODE-8705) Modify java.gradle to generate module.xml as well as the Manifest file
[ https://issues.apache.org/jira/browse/GEODE-8705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-8705: -- Labels: pull-request-available (was: ) > Modify java.gradle to generate module.xml as well as the Manifest file > -- > > Key: GEODE-8705 > URL: https://issues.apache.org/jira/browse/GEODE-8705 > Project: Geode > Issue Type: New Feature >Reporter: Udo Kohlmeyer >Assignee: Udo Kohlmeyer >Priority: Major > Labels: pull-request-available > > In order to convert the current ClassLoader Isolation work to use `java -jar > jboss-modules` one would like to have `module.xml` files that standard > jboss-modules knows how to handle. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (GEODE-10016) Use Thread Name In Log Messages
[
https://issues.apache.org/jira/browse/GEODE-10016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488497#comment-17488497
]
ASF GitHub Bot commented on GEODE-10016:
mmartell commented on a change in pull request #918:
URL: https://github.com/apache/geode-native/pull/918#discussion_r801150167
##
File path: cppcache/src/DistributedSystemImpl.cpp
##
@@ -143,11 +148,26 @@ void DistributedSystemImpl::unregisterCliCallback(int
appdomainId) {
}
}
+std::string DistributedSystemImpl::getThreadName() {
+ std::thread::id id = std::this_thread::get_id();
+ std::stringstream ss;
+ ss << id;
+ std::string threadName;
+ if (g_threadNames[id] != "") {
+threadName = ss.str() + " (" + g_threadNames[id] + ")";
+ } else {
+threadName = ss.str();
+ }
+ return threadName;
Review comment:
I moved this logic to the formatLogLine function. Should be fine since
most work is on the main thread has no name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use Thread Name In Log Messages
> ---
>
> Key: GEODE-10016
> URL: https://issues.apache.org/jira/browse/GEODE-10016
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Michael Martell
>Priority: Minor
> Labels: pull-request-available
>
> The native client logging system currently prints the threadId in all log
> messages. Since all internally created native client threads are named, we
> should print the threadName instead of threadId. This will be extremely
> helpful to understanding the flow of messages since there are many background
> threads in the native client.
> Note: Lots of log messages are running on an application thread which was not
> created internally by the native client. Messages running on these threads
> should continue to print the threadId.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (GEODE-10016) Use Thread Name In Log Messages
[
https://issues.apache.org/jira/browse/GEODE-10016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488496#comment-17488496
]
ASF GitHub Bot commented on GEODE-10016:
pivotal-jbarrett commented on a change in pull request #918:
URL: https://github.com/apache/geode-native/pull/918#discussion_r801145569
##
File path: cppcache/src/ExpiryTaskManager.cpp
##
@@ -51,7 +51,7 @@ void ExpiryTaskManager::start() {
auto start_future = start_promise.get_future();
runner_ = std::thread{[this, _promise] {
start_promise.set_value(true);
-DistributedSystemImpl::setThreadName(NC_ETM_Thread);
+Log::setThreadName(NC_ETM_Thread);
Review comment:
Can we just inline the string constants, they aren't used anywhere else.
##
File path: cppcache/src/SystemProperties.cpp
##
@@ -169,7 +169,8 @@ SystemProperties::SystemProperties(
m_sslTrustStore(DefaultSslTrustStore),
m_sslKeystorePassword(DefaultSslKeystorePassword),
m_conflateEvents(DefaultConflateEvents),
- m_threadPoolSize(DefaultThreadPoolSize),
+ // m_threadPoolSize(DefaultThreadPoolSize),
+ m_threadPoolSize(16),
Review comment:
Looks like an unintentional change!
##
File path: cppcache/src/Log.cpp
##
@@ -369,6 +372,46 @@ LogLevel Log::charsToLevel(const std::string& chars) {
}
}
+void Log::setThreadName(const std::string& threadName) {
Review comment:
Change signature to `std::string threadName` then `std::move` into
`g_threadName`.
##
File path: cppcache/src/Log.cpp
##
@@ -38,6 +38,7 @@
#include
#include
+#include "DistributedSystemImpl.hpp"
Review comment:
You can drop this too I think.
##
File path: cppcache/src/Log.cpp
##
@@ -378,12 +421,21 @@ std::string Log::formatLogLine(LogLevel level) {
now - std::chrono::system_clock::from_time_t(secs));
auto tm_val = apache::geode::util::chrono::localtime(secs);
+ std::thread::id id = std::this_thread::get_id();
Review comment:
Why the variable?
##
File path: cppcache/src/Log.cpp
##
@@ -60,6 +61,8 @@ static FILE* g_log = nullptr;
static std::string g_hostName;
+static thread_local std::string g_threadName;
Review comment:
See https://google.github.io/styleguide/cppguide.html#thread_local and
https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables
for naming guidelines. I think you want `kThreadName` but I am not too keen on
that given it isn't really a constant.
##
File path: cppcache/src/DistributedSystemImpl.hpp
##
@@ -24,6 +24,7 @@
#include
#include
#include
+#include
Review comment:
Drop this.
##
File path: cppcache/src/Log.cpp
##
@@ -378,12 +421,21 @@ std::string Log::formatLogLine(LogLevel level) {
now - std::chrono::system_clock::from_time_t(secs));
auto tm_val = apache::geode::util::chrono::localtime(secs);
+ std::thread::id id = std::this_thread::get_id();
+ std::stringstream ss;
+ ss << id;
+ std::string threadIdWithName;
+ if (getThreadName() != "") {
+threadIdWithName = ss.str() + " (" + getThreadName() + ")";
+ } else {
+threadIdWithName = ss.str();
+ }
+
msg << "[" << Log::levelToChars(level) << " "
<< std::put_time(_val, "%Y/%m/%d %H:%M:%S") << '.' <<
std::setfill('0')
<< std::setw(6) << microseconds.count() << ' '
<< std::put_time(_val, "%z ") << g_hostName << ":"
- << boost::this_process::get_id() << " " << std::this_thread::get_id()
- << "] ";
+ << boost::this_process::get_id() << " " << threadIdWithName << "] ";
Review comment:
just
```c++
.. << std::this_thread::id << g_threadName << ...
```
Avoid the extra stream creation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use Thread Name In Log Messages
> ---
>
> Key: GEODE-10016
> URL: https://issues.apache.org/jira/browse/GEODE-10016
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Michael Martell
>Priority: Minor
> Labels: pull-request-available
>
> The native client logging system currently prints the threadId in all log
> messages. Since all internally created native client threads are named, we
> should print the threadName instead of threadId. This will be extremely
> helpful to understanding the flow of messages since there are many background
> threads in the native client.
> Note: Lots of log messages are running on an application thread which
[jira] [Commented] (GEODE-10016) Use Thread Name In Log Messages
[
https://issues.apache.org/jira/browse/GEODE-10016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488494#comment-17488494
]
ASF GitHub Bot commented on GEODE-10016:
mmartell commented on a change in pull request #918:
URL: https://github.com/apache/geode-native/pull/918#discussion_r801148644
##
File path: cppcache/src/DistributedSystemImpl.hpp
##
@@ -48,6 +49,7 @@ using CliCallbackMethod = std::function;
class DistributedSystemImpl {
public:
static void setThreadName(const std::string& threadName);
Review comment:
Indeed. I moved it to the Log class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use Thread Name In Log Messages
> ---
>
> Key: GEODE-10016
> URL: https://issues.apache.org/jira/browse/GEODE-10016
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Michael Martell
>Priority: Minor
> Labels: pull-request-available
>
> The native client logging system currently prints the threadId in all log
> messages. Since all internally created native client threads are named, we
> should print the threadName instead of threadId. This will be extremely
> helpful to understanding the flow of messages since there are many background
> threads in the native client.
> Note: Lots of log messages are running on an application thread which was not
> created internally by the native client. Messages running on these threads
> should continue to print the threadId.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (GEODE-10016) Use Thread Name In Log Messages
[
https://issues.apache.org/jira/browse/GEODE-10016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488491#comment-17488491
]
ASF GitHub Bot commented on GEODE-10016:
mmartell commented on a change in pull request #918:
URL: https://github.com/apache/geode-native/pull/918#discussion_r801148351
##
File path: cppcache/src/DistributedSystemImpl.cpp
##
@@ -38,6 +38,10 @@
#include "util/Log.hpp"
#include "version.h"
+namespace {
+std::map g_threadNames;
Review comment:
Can't acually use thread_local in DistributedSystemImpl anyway since
it's used my clicache. C++/CLI used to support [System::ThreadLocalAttribute]
like C#. But no longer supported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use Thread Name In Log Messages
> ---
>
> Key: GEODE-10016
> URL: https://issues.apache.org/jira/browse/GEODE-10016
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Michael Martell
>Priority: Minor
> Labels: pull-request-available
>
> The native client logging system currently prints the threadId in all log
> messages. Since all internally created native client threads are named, we
> should print the threadName instead of threadId. This will be extremely
> helpful to understanding the flow of messages since there are many background
> threads in the native client.
> Note: Lots of log messages are running on an application thread which was not
> created internally by the native client. Messages running on these threads
> should continue to print the threadId.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (GEODE-10016) Use Thread Name In Log Messages
[
https://issues.apache.org/jira/browse/GEODE-10016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488490#comment-17488490
]
ASF GitHub Bot commented on GEODE-10016:
mmartell commented on a change in pull request #918:
URL: https://github.com/apache/geode-native/pull/918#discussion_r801146648
##
File path: cppcache/src/DistributedSystemImpl.cpp
##
@@ -143,11 +148,26 @@ void DistributedSystemImpl::unregisterCliCallback(int
appdomainId) {
}
}
+std::string DistributedSystemImpl::getThreadName() {
+ std::thread::id id = std::this_thread::get_id();
+ std::stringstream ss;
+ ss << id;
+ std::string threadName;
+ if (g_threadNames[id] != "") {
Review comment:
Using thread_local now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use Thread Name In Log Messages
> ---
>
> Key: GEODE-10016
> URL: https://issues.apache.org/jira/browse/GEODE-10016
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Michael Martell
>Priority: Minor
> Labels: pull-request-available
>
> The native client logging system currently prints the threadId in all log
> messages. Since all internally created native client threads are named, we
> should print the threadName instead of threadId. This will be extremely
> helpful to understanding the flow of messages since there are many background
> threads in the native client.
> Note: Lots of log messages are running on an application thread which was not
> created internally by the native client. Messages running on these threads
> should continue to print the threadId.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (GEODE-10016) Use Thread Name In Log Messages
[
https://issues.apache.org/jira/browse/GEODE-10016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488489#comment-17488489
]
ASF GitHub Bot commented on GEODE-10016:
mmartell commented on a change in pull request #918:
URL: https://github.com/apache/geode-native/pull/918#discussion_r801145931
##
File path: cppcache/src/DistributedSystemImpl.cpp
##
@@ -143,11 +148,26 @@ void DistributedSystemImpl::unregisterCliCallback(int
appdomainId) {
}
}
+std::string DistributedSystemImpl::getThreadName() {
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use Thread Name In Log Messages
> ---
>
> Key: GEODE-10016
> URL: https://issues.apache.org/jira/browse/GEODE-10016
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Michael Martell
>Priority: Minor
> Labels: pull-request-available
>
> The native client logging system currently prints the threadId in all log
> messages. Since all internally created native client threads are named, we
> should print the threadName instead of threadId. This will be extremely
> helpful to understanding the flow of messages since there are many background
> threads in the native client.
> Note: Lots of log messages are running on an application thread which was not
> created internally by the native client. Messages running on these threads
> should continue to print the threadId.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (GEODE-10016) Use Thread Name In Log Messages
[
https://issues.apache.org/jira/browse/GEODE-10016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488478#comment-17488478
]
ASF GitHub Bot commented on GEODE-10016:
mmartell commented on a change in pull request #918:
URL: https://github.com/apache/geode-native/pull/918#discussion_r801126305
##
File path: cppcache/src/Log.cpp
##
@@ -382,7 +383,8 @@ std::string Log::formatLogLine(LogLevel level) {
<< std::put_time(_val, "%Y/%m/%d %H:%M:%S") << '.' <<
std::setfill('0')
<< std::setw(6) << microseconds.count() << ' '
<< std::put_time(_val, "%z ") << g_hostName << ":"
- << boost::this_process::get_id() << " " << std::this_thread::get_id()
+ << boost::this_process::get_id() << " "
+ << DistributedSystemImpl::getThreadName(std::this_thread::get_id())
Review comment:
Yah this is a perfect case threadlocal storage. Just required moving the
threadName and its accessors to the Log class. Which makes more sense anyway
since logging is the only use of threadName.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use Thread Name In Log Messages
> ---
>
> Key: GEODE-10016
> URL: https://issues.apache.org/jira/browse/GEODE-10016
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Michael Martell
>Priority: Minor
> Labels: pull-request-available
>
> The native client logging system currently prints the threadId in all log
> messages. Since all internally created native client threads are named, we
> should print the threadName instead of threadId. This will be extremely
> helpful to understanding the flow of messages since there are many background
> threads in the native client.
> Note: Lots of log messages are running on an application thread which was not
> created internally by the native client. Messages running on these threads
> should continue to print the threadId.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Resolved] (GEODE-9985) Mass-Test-Run: SlowDispatcherDUnitTest > registeredInterest_durableClient_kill_primarySever_receives_marker FAILED
[
https://issues.apache.org/jira/browse/GEODE-9985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jinmei Liao resolved GEODE-9985.
Fix Version/s: 1.16.0
Resolution: Fixed
> Mass-Test-Run: SlowDispatcherDUnitTest >
> registeredInterest_durableClient_kill_primarySever_receives_marker FAILED
> --
>
> Key: GEODE-9985
> URL: https://issues.apache.org/jira/browse/GEODE-9985
> Project: Geode
> Issue Type: Bug
>Affects Versions: 1.15.0
>Reporter: Kristen
>Assignee: Jinmei Liao
>Priority: Major
> Labels: GeodeOperationAPI, pull-request-available
> Fix For: 1.16.0
>
>
> {code:java}
> SlowDispatcherDUnitTest >
> registeredInterest_durableClient_kill_primarySever_receives_marker FAILED
> org.apache.geode.test.dunit.RMIException: While invoking
> org.apache.geode.internal.cache.tier.sockets.SlowDispatcherDUnitTest$$Lambda$299/1561169457.run
> in VM 3 running on Host
> heavy-lifter-f18312bf-ecf3-5384-8b36-e5d91bf8ebb9.c.apachegeode-ci.internal
> with 5 VMs
> at org.apache.geode.test.dunit.VM.executeMethodOnObject(VM.java:631)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:448)
> at
> org.apache.geode.test.junit.rules.VMProvider.invoke(VMProvider.java:96)
> at
> org.apache.geode.internal.cache.tier.sockets.SlowDispatcherDUnitTest.registeredInterest_durableClient_kill_primarySever_receives_marker(SlowDispatcherDUnitTest.java:135)
> Caused by:
> org.awaitility.core.ConditionTimeoutException: Assertion condition
> defined as a
> org.apache.geode.internal.cache.tier.sockets.SlowDispatcherDUnitTest
> expected: 49
> but was: 40 within 5 minutes.
> at
> org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:164)
> at
> org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
> at
> org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
> at
> org.awaitility.core.ConditionFactory.until(ConditionFactory.java:939)
> at
> org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:723)
> at
> org.apache.geode.internal.cache.tier.sockets.SlowDispatcherDUnitTest.lambda$registeredInterest_durableClient_kill_primarySever_receives_marker$bb17a952$2(SlowDispatcherDUnitTest.java:137)
> Caused by:
> org.opentest4j.AssertionFailedError:
> expected: 49
> but was: 40
> at
> sun.reflect.GeneratedConstructorAccessor21.newInstance(Unknown Source)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at
> org.apache.geode.internal.cache.tier.sockets.SlowDispatcherDUnitTest.lambda$null$2(SlowDispatcherDUnitTest.java:137)
> 8357 tests completed, 1 failed, 414 skipped
> {code}
> Test report artifacts from {color:#172b4d}this{color} job are available at:
> http:{color:#172b4d}//files.apachegeode-ci.info/builds/apache-develop-mass-test-run/1.15.0-build.0806/test-artifacts/1642831372/distributedtestfiles-openjdk8-1.15.0-build.0806.tgz{color}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Assigned] (GEODE-9985) Mass-Test-Run: SlowDispatcherDUnitTest > registeredInterest_durableClient_kill_primarySever_receives_marker FAILED
[
https://issues.apache.org/jira/browse/GEODE-9985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jinmei Liao reassigned GEODE-9985:
--
Assignee: Jinmei Liao
> Mass-Test-Run: SlowDispatcherDUnitTest >
> registeredInterest_durableClient_kill_primarySever_receives_marker FAILED
> --
>
> Key: GEODE-9985
> URL: https://issues.apache.org/jira/browse/GEODE-9985
> Project: Geode
> Issue Type: Bug
>Affects Versions: 1.15.0
>Reporter: Kristen
>Assignee: Jinmei Liao
>Priority: Major
> Labels: GeodeOperationAPI, pull-request-available
>
> {code:java}
> SlowDispatcherDUnitTest >
> registeredInterest_durableClient_kill_primarySever_receives_marker FAILED
> org.apache.geode.test.dunit.RMIException: While invoking
> org.apache.geode.internal.cache.tier.sockets.SlowDispatcherDUnitTest$$Lambda$299/1561169457.run
> in VM 3 running on Host
> heavy-lifter-f18312bf-ecf3-5384-8b36-e5d91bf8ebb9.c.apachegeode-ci.internal
> with 5 VMs
> at org.apache.geode.test.dunit.VM.executeMethodOnObject(VM.java:631)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:448)
> at
> org.apache.geode.test.junit.rules.VMProvider.invoke(VMProvider.java:96)
> at
> org.apache.geode.internal.cache.tier.sockets.SlowDispatcherDUnitTest.registeredInterest_durableClient_kill_primarySever_receives_marker(SlowDispatcherDUnitTest.java:135)
> Caused by:
> org.awaitility.core.ConditionTimeoutException: Assertion condition
> defined as a
> org.apache.geode.internal.cache.tier.sockets.SlowDispatcherDUnitTest
> expected: 49
> but was: 40 within 5 minutes.
> at
> org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:164)
> at
> org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
> at
> org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
> at
> org.awaitility.core.ConditionFactory.until(ConditionFactory.java:939)
> at
> org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:723)
> at
> org.apache.geode.internal.cache.tier.sockets.SlowDispatcherDUnitTest.lambda$registeredInterest_durableClient_kill_primarySever_receives_marker$bb17a952$2(SlowDispatcherDUnitTest.java:137)
> Caused by:
> org.opentest4j.AssertionFailedError:
> expected: 49
> but was: 40
> at
> sun.reflect.GeneratedConstructorAccessor21.newInstance(Unknown Source)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at
> org.apache.geode.internal.cache.tier.sockets.SlowDispatcherDUnitTest.lambda$null$2(SlowDispatcherDUnitTest.java:137)
> 8357 tests completed, 1 failed, 414 skipped
> {code}
> Test report artifacts from {color:#172b4d}this{color} job are available at:
> http:{color:#172b4d}//files.apachegeode-ci.info/builds/apache-develop-mass-test-run/1.15.0-build.0806/test-artifacts/1642831372/distributedtestfiles-openjdk8-1.15.0-build.0806.tgz{color}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (GEODE-9985) Mass-Test-Run: SlowDispatcherDUnitTest > registeredInterest_durableClient_kill_primarySever_receives_marker FAILED
[
https://issues.apache.org/jira/browse/GEODE-9985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488448#comment-17488448
]
ASF subversion and git services commented on GEODE-9985:
Commit e7094ee9ac9ec1ac276b74cff25bda4251a46e9d in geode's branch
refs/heads/develop from Jinmei Liao
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=e7094ee ]
GEODE-9985: add region redundancy to avoid data loss. (#7308)
> Mass-Test-Run: SlowDispatcherDUnitTest >
> registeredInterest_durableClient_kill_primarySever_receives_marker FAILED
> --
>
> Key: GEODE-9985
> URL: https://issues.apache.org/jira/browse/GEODE-9985
> Project: Geode
> Issue Type: Bug
>Affects Versions: 1.15.0
>Reporter: Kristen
>Priority: Major
> Labels: GeodeOperationAPI, pull-request-available
>
> {code:java}
> SlowDispatcherDUnitTest >
> registeredInterest_durableClient_kill_primarySever_receives_marker FAILED
> org.apache.geode.test.dunit.RMIException: While invoking
> org.apache.geode.internal.cache.tier.sockets.SlowDispatcherDUnitTest$$Lambda$299/1561169457.run
> in VM 3 running on Host
> heavy-lifter-f18312bf-ecf3-5384-8b36-e5d91bf8ebb9.c.apachegeode-ci.internal
> with 5 VMs
> at org.apache.geode.test.dunit.VM.executeMethodOnObject(VM.java:631)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:448)
> at
> org.apache.geode.test.junit.rules.VMProvider.invoke(VMProvider.java:96)
> at
> org.apache.geode.internal.cache.tier.sockets.SlowDispatcherDUnitTest.registeredInterest_durableClient_kill_primarySever_receives_marker(SlowDispatcherDUnitTest.java:135)
> Caused by:
> org.awaitility.core.ConditionTimeoutException: Assertion condition
> defined as a
> org.apache.geode.internal.cache.tier.sockets.SlowDispatcherDUnitTest
> expected: 49
> but was: 40 within 5 minutes.
> at
> org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:164)
> at
> org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
> at
> org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
> at
> org.awaitility.core.ConditionFactory.until(ConditionFactory.java:939)
> at
> org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:723)
> at
> org.apache.geode.internal.cache.tier.sockets.SlowDispatcherDUnitTest.lambda$registeredInterest_durableClient_kill_primarySever_receives_marker$bb17a952$2(SlowDispatcherDUnitTest.java:137)
> Caused by:
> org.opentest4j.AssertionFailedError:
> expected: 49
> but was: 40
> at
> sun.reflect.GeneratedConstructorAccessor21.newInstance(Unknown Source)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at
> org.apache.geode.internal.cache.tier.sockets.SlowDispatcherDUnitTest.lambda$null$2(SlowDispatcherDUnitTest.java:137)
> 8357 tests completed, 1 failed, 414 skipped
> {code}
> Test report artifacts from {color:#172b4d}this{color} job are available at:
> http:{color:#172b4d}//files.apachegeode-ci.info/builds/apache-develop-mass-test-run/1.15.0-build.0806/test-artifacts/1642831372/distributedtestfiles-openjdk8-1.15.0-build.0806.tgz{color}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (GEODE-9985) Mass-Test-Run: SlowDispatcherDUnitTest > registeredInterest_durableClient_kill_primarySever_receives_marker FAILED
[
https://issues.apache.org/jira/browse/GEODE-9985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated GEODE-9985:
--
Labels: GeodeOperationAPI pull-request-available (was: GeodeOperationAPI)
> Mass-Test-Run: SlowDispatcherDUnitTest >
> registeredInterest_durableClient_kill_primarySever_receives_marker FAILED
> --
>
> Key: GEODE-9985
> URL: https://issues.apache.org/jira/browse/GEODE-9985
> Project: Geode
> Issue Type: Bug
>Affects Versions: 1.15.0
>Reporter: Kristen
>Priority: Major
> Labels: GeodeOperationAPI, pull-request-available
>
> {code:java}
> SlowDispatcherDUnitTest >
> registeredInterest_durableClient_kill_primarySever_receives_marker FAILED
> org.apache.geode.test.dunit.RMIException: While invoking
> org.apache.geode.internal.cache.tier.sockets.SlowDispatcherDUnitTest$$Lambda$299/1561169457.run
> in VM 3 running on Host
> heavy-lifter-f18312bf-ecf3-5384-8b36-e5d91bf8ebb9.c.apachegeode-ci.internal
> with 5 VMs
> at org.apache.geode.test.dunit.VM.executeMethodOnObject(VM.java:631)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:448)
> at
> org.apache.geode.test.junit.rules.VMProvider.invoke(VMProvider.java:96)
> at
> org.apache.geode.internal.cache.tier.sockets.SlowDispatcherDUnitTest.registeredInterest_durableClient_kill_primarySever_receives_marker(SlowDispatcherDUnitTest.java:135)
> Caused by:
> org.awaitility.core.ConditionTimeoutException: Assertion condition
> defined as a
> org.apache.geode.internal.cache.tier.sockets.SlowDispatcherDUnitTest
> expected: 49
> but was: 40 within 5 minutes.
> at
> org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:164)
> at
> org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
> at
> org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
> at
> org.awaitility.core.ConditionFactory.until(ConditionFactory.java:939)
> at
> org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:723)
> at
> org.apache.geode.internal.cache.tier.sockets.SlowDispatcherDUnitTest.lambda$registeredInterest_durableClient_kill_primarySever_receives_marker$bb17a952$2(SlowDispatcherDUnitTest.java:137)
> Caused by:
> org.opentest4j.AssertionFailedError:
> expected: 49
> but was: 40
> at
> sun.reflect.GeneratedConstructorAccessor21.newInstance(Unknown Source)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at
> org.apache.geode.internal.cache.tier.sockets.SlowDispatcherDUnitTest.lambda$null$2(SlowDispatcherDUnitTest.java:137)
> 8357 tests completed, 1 failed, 414 skipped
> {code}
> Test report artifacts from {color:#172b4d}this{color} job are available at:
> http:{color:#172b4d}//files.apachegeode-ci.info/builds/apache-develop-mass-test-run/1.15.0-build.0806/test-artifacts/1642831372/distributedtestfiles-openjdk8-1.15.0-build.0806.tgz{color}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (GEODE-10015) gfsh does not send hostname in SNI header
[
https://issues.apache.org/jira/browse/GEODE-10015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488446#comment-17488446
]
ASF subversion and git services commented on GEODE-10015:
-
Commit 1da903901bf4bb4d339d83a244051eaf58d8b690 in geode's branch
refs/heads/develop from Jacob Barrett
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=1da9039 ]
GEODE-10015: Set java.rmi.server.hostname when SSL enabled. (#7337)
When SSL is enabled we set the java.rmi.server.hostname System Property
to force creation of endpoints bound to that address rather than the
default, which is the local IP address. When RMI clients make
connections for these endpoints they will use the correct hostname,
which should match the hostname in the SSL certificate.
> gfsh does not send hostname in SNI header
> -
>
> Key: GEODE-10015
> URL: https://issues.apache.org/jira/browse/GEODE-10015
> Project: Geode
> Issue Type: Bug
> Components: gfsh, jmx
>Affects Versions: 1.15.0, 1.16.0
>Reporter: Jacob Barrett
>Priority: Blocker
> Labels: blocks-1.15.0, pull-request-available
>
> When {{gfsh}} tries to connect the JMX port on the locator it sends the IP
> address of the locator in the SNI header rather than the hostname. This
> results in a certificate validation failure when the IP is not found in the
> SAN entries.
> Version 1.14.3 sends the correct hostname in the SNI. Something changed
> between 1.14.3 and now.
>
> Reproduction:
> {noformat}
> gfsh -e version --full -e start locator --name=locator2
> --bind-address=myhost.example.com --port=20005
> --J=-Dgemfire.jmx-manager-port=20007
> --security-properties-file=/path/to/security.properties --http-service-port=0
> --locators=myhost.example.com[20004]
> (1) Executing - version --full
> ...
> Product-Version: 1.16.0-build.0
> ...
> (2) Executing - start locator --name=locator2
> --bind-address=myhost.example.com --port=20005
> --J=-Dgemfire.jmx-manager-port=20007 --security-properties-file=
> --http-service-port=0 --locators=myhost.example.com[20004]
> ...
> [fatal 2022/02/02 19:47:27.050 PST tid=0x1] Problem forming SSL
> connection to /192.168.68.56[20007].
> javax.net.ssl.SSLHandshakeException: java.security.cert.CertificateException:
> No subject alternative names matching IP address 192.168.68.56 found
> ...
> Locator in /path/to/locator2 on myhost.example.com[20005] as locator2 is
> currently online.
> ...
> Unable to auto-connect (Security Manager may be enabled). Please use "connect
> --locator=myhost.example.com[20005]" to connect Gfsh to the locator.
> SSL configuration required to connect to the Manager.
> Failed to connect; unknown cause: error during JRMP connection establishment;
> nested exception is:
> javax.net.ssl.SSLHandshakeException:
> sun.security.validator.ValidatorException: PKIX path building failed:
> sun.security.provider.certpath.SunCertPathBuilderException: unable to find
> valid certification path to requested target
> {noformat}
> Where {{/path/to/security.properties}} contains:
> {noformat}
> ssl-require-authentication=true
> ssl-keystore=/path/to/keystore.jks
> ssl-truststore-type=jks
> ssl-keystore-password=password
> ssl-truststore=/path/to/truststore.jks
> ssl-enabled-components=all
> ssl-truststore-password=password
> ssl-protocols=any
> ssl-endpoint-identification-enabled=true
> ssl-keystore-type=jks
> {noformat}
> The certificate used in the key store is singed by a fake CA and contains
> only the hostname, {{myhost.example.com}}. The trust store contains the fake
> CA.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (GEODE-10020) Gradual activation of LiveServerPinger for each destination
[ https://issues.apache.org/jira/browse/GEODE-10020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-10020: --- Labels: pull-request-available (was: ) > Gradual activation of LiveServerPinger for each destination > --- > > Key: GEODE-10020 > URL: https://issues.apache.org/jira/browse/GEODE-10020 > Project: Geode > Issue Type: Improvement > Components: wan >Reporter: Mario Ivanac >Assignee: Mario Ivanac >Priority: Major > Labels: pull-request-available > > Add configurable option to gradually activate pinging toward destination. > This can be accomplish by increasing initial delay of each ping task. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (GEODE-9982) Native clients older than 1.15 fail to read longer version ordinal from 1.15 servers.
[
https://issues.apache.org/jira/browse/GEODE-9982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated GEODE-9982:
--
Labels: pull-request-available (was: )
> Native clients older than 1.15 fail to read longer version ordinal from 1.15
> servers.
> -
>
> Key: GEODE-9982
> URL: https://issues.apache.org/jira/browse/GEODE-9982
> Project: Geode
> Issue Type: Bug
> Components: native client
>Affects Versions: 1.12.8, 1.13.7, 1.14.0, 1.14.1, 1.14.2, 1.14.3, 1.14.4
>Reporter: Jacob Barrett
>Priority: Critical
> Labels: pull-request-available
> Attachments: GEODE-9982.patch
>
>
> Geode Native C++ client v1.14.0 fails execution of
> testThinClientTransactionsWithoutSticky against current develop branch
> server. C++ client v1.14.0 does not fail when talking to a v1.14.0 server.
> Current develop branch C++ client does not fail when talking to a develop
> branch server. It appears there may be a protocol incompatibly issue between
> these two versions. More investigations to narrow down the version matrix is
> necessary.
> The following error is logged when the test fails:
> {{Error during send for endpoint 192.168.68.56:18539 due to
> apache::geode::client::IllegalStateException: Unregistered type in
> deserialization}}
> ||Server Versions|1.14.0|1.15.0|
> ||Client Versions||
> |1.14.0|P|F|
> |1.15.0|-|P|
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Assigned] (GEODE-9947) Implement LINDEX
[ https://issues.apache.org/jira/browse/GEODE-9947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kristen reassigned GEODE-9947: -- Assignee: Kristen > Implement LINDEX > > > Key: GEODE-9947 > URL: https://issues.apache.org/jira/browse/GEODE-9947 > Project: Geode > Issue Type: New Feature > Components: redis >Reporter: Wayne >Assignee: Kristen >Priority: Major > > Implement the [LINDEX|https://redis.io/commands/lindex] command. > > +Acceptance Criteria+ > > The command has been implemented along with appropriate unit and system tests. > > The command has been tested using the redis-cli tool and verified against > native redis. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (GEODE-9980) Startup of Locator or Server should fail fast if geode.enableGlobalSerialFilter is enabled but fails configuration
[
https://issues.apache.org/jira/browse/GEODE-9980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488368#comment-17488368
]
Kirk Lund commented on GEODE-9980:
--
All changes are currently complete but I'm blocked from merging to develop
because one of two unit tests is unexpectedly setting a real process-wide
serial filter in the JVM which causes cascading failures. Both tests are
supposed to be using a mock api for setting a the serial filter so that nothing
real is configured.
> Startup of Locator or Server should fail fast if
> geode.enableGlobalSerialFilter is enabled but fails configuration
> --
>
> Key: GEODE-9980
> URL: https://issues.apache.org/jira/browse/GEODE-9980
> Project: Geode
> Issue Type: Bug
> Components: serialization
>Affects Versions: 1.15.0
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>Priority: Major
> Labels: GeodeOperationAPI, blocks-1.15.0, pull-request-available
>
> The following error conditions need better handling which includes handling
> of all errors consistently and cause the startup of a Locator or Server to
> fail if it's unable to honor the setting of
> {{-Dgeode.enableGlobalSerialFilter=true}} for any reason. Currently, if
> {{-Dgeode.enableGlobalSerialFilter=true}} is specified but Geode is unable to
> create a global serial filter, then it will will log a warning and continue
> running. A user may easily miss that log statement and believe that the JVM
> is running with a properly configured serialization filter.
> 1) The user is trying to secure the JVM very thoroughly and accidentally
> specifies both {{-Djdk.serialFilter}} and
> {{-Dgeode.enableGlobalSerialFilter}}.
> 2) The user runs some non-Geode code in the same JVM that invokes
> {{ObjectInputFilter.Config.setFilter(...)}} directly.
> 3) The user is using a version of Java 8 prior to 8u121 (the release that
> first added {{sun.misc.ObjectInputFilter}}) and specifies
> {{-Dgeode.enableGlobalSerialFilter=true}}. Also, the same behavior occurs if
> they do NOT specify enabling that property.
> 4) {{LocatorLauncher}} or {{ServerLauncher}} is started in a JVM that has
> already created at least one {{ObjectInputStream}} which will cause
> {{ObjectInputFilter.Config.setFilter(...)}} to fail.
> 5) {{LocatorLauncher}} or {{ServerLauncher}} is started in a Java 8 JVM that
> is not based on OpenJDK (ie {{sun.misc.ObjectInputFilter}} does not exist).
> 6) {{LocatorLauncher}} or {{ServerLauncher}} is started in an unforeseen
> environment that causes invocation of
> {{ObjectInputFilter.Config.setFilter(...)}} via Java Reflection to throw
> {{IllegalAccessException}}.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (GEODE-10016) Use Thread Name In Log Messages
[ https://issues.apache.org/jira/browse/GEODE-10016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488363#comment-17488363 ] ASF GitHub Bot commented on GEODE-10016: mmartell commented on a change in pull request #918: URL: https://github.com/apache/geode-native/pull/918#discussion_r800968284 ## File path: cppcache/src/ThreadPool.cpp ## @@ -16,6 +16,8 @@ */ #include "ThreadPool.hpp" +#include Review comment: You're right. Not needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Use Thread Name In Log Messages > --- > > Key: GEODE-10016 > URL: https://issues.apache.org/jira/browse/GEODE-10016 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Michael Martell >Priority: Minor > Labels: pull-request-available > > The native client logging system currently prints the threadId in all log > messages. Since all internally created native client threads are named, we > should print the threadName instead of threadId. This will be extremely > helpful to understanding the flow of messages since there are many background > threads in the native client. > Note: Lots of log messages are running on an application thread which was not > created internally by the native client. Messages running on these threads > should continue to print the threadId. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (GEODE-10016) Use Thread Name In Log Messages
[
https://issues.apache.org/jira/browse/GEODE-10016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488364#comment-17488364
]
ASF GitHub Bot commented on GEODE-10016:
mmartell commented on a change in pull request #918:
URL: https://github.com/apache/geode-native/pull/918#discussion_r800968844
##
File path: cppcache/src/DistributedSystemImpl.cpp
##
@@ -143,11 +147,24 @@ void DistributedSystemImpl::unregisterCliCallback(int
appdomainId) {
}
}
-void DistributedSystemImpl::setThreadName(const std::string& threadName) {
+std::string DistributedSystemImpl::getThreadName(std::thread::id id) {
+ std::string threadName = m_threadNames[id];
Review comment:
Good catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use Thread Name In Log Messages
> ---
>
> Key: GEODE-10016
> URL: https://issues.apache.org/jira/browse/GEODE-10016
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Michael Martell
>Priority: Minor
> Labels: pull-request-available
>
> The native client logging system currently prints the threadId in all log
> messages. Since all internally created native client threads are named, we
> should print the threadName instead of threadId. This will be extremely
> helpful to understanding the flow of messages since there are many background
> threads in the native client.
> Note: Lots of log messages are running on an application thread which was not
> created internally by the native client. Messages running on these threads
> should continue to print the threadId.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (GEODE-10016) Use Thread Name In Log Messages
[
https://issues.apache.org/jira/browse/GEODE-10016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488350#comment-17488350
]
ASF GitHub Bot commented on GEODE-10016:
pivotal-jbarrett commented on a change in pull request #918:
URL: https://github.com/apache/geode-native/pull/918#discussion_r800946679
##
File path: cppcache/src/DistributedSystemImpl.cpp
##
@@ -143,11 +148,26 @@ void DistributedSystemImpl::unregisterCliCallback(int
appdomainId) {
}
}
+std::string DistributedSystemImpl::getThreadName() {
Review comment:
You can use `const std::string&` once you use the `thread_local`
implementation.
##
File path: cppcache/src/DistributedSystemImpl.cpp
##
@@ -38,6 +38,10 @@
#include "util/Log.hpp"
#include "version.h"
+namespace {
+std::map g_threadNames;
Review comment:
Replace with `static thread_local` member on `DistributedSystemImpl`:
Header:
```c++
class DistributedSystemImpl {
...
private:
static thread_local std::string threadName_;
}
```
Implementation:
```c++
std::string initThreadName() {
std::stringstream ss;
ss << std::this_thread::get_id();
return ss.str();
}
thread_local std::string DistributedSystemImpl::threadName_ =
initThreadName();
const std::string& DistributedSystemImpl::getThreadName() {
return threadName_;
}
void DistributedSystemImpl::setThreadName(const std::string& threadName) {
std::stringstream ss;
ss << std::this_thread::get_id() << " (" << threadName << ")";
threadName_ = ss.str();
}
```
I question the usefulness of putting the id in the threadName since when
logging we include both `std::thread::id` and this thread name already. I
suggest removing it which also simplifies the implementation.
Default thread name is `""`, empty string.
```c++
thread_local std::string DistributedSystemImpl::threadName_;
const std::string& DistributedSystemImpl::getThreadName() {
return threadName_;
}
void DistributedSystemImpl::setThreadName(std::string threadName) {
threadName_ = std::move(threadName);
}
```
##
File path: cppcache/src/DistributedSystemImpl.cpp
##
@@ -143,11 +148,26 @@ void DistributedSystemImpl::unregisterCliCallback(int
appdomainId) {
}
}
+std::string DistributedSystemImpl::getThreadName() {
+ std::thread::id id = std::this_thread::get_id();
+ std::stringstream ss;
+ ss << id;
+ std::string threadName;
+ if (g_threadNames[id] != "") {
Review comment:
This is not a thread safe access to a non-thread safe data structure.
There is actually no reason to use a map with thread ID as key since that is
pretty much what `thread_local` is.
##
File path: cppcache/src/DistributedSystemImpl.hpp
##
@@ -48,6 +49,7 @@ using CliCallbackMethod = std::function;
class DistributedSystemImpl {
public:
static void setThreadName(const std::string& threadName);
Review comment:
Maybe none of this should be on `DistributedSystemImpl`. It has nothing
to do with the Distributed System. Perhaps, since this is only used for
logging, it should be in the logging classes somewhere. It could also be its
own class/struct or just some global name spaced values and functions.
##
File path: cppcache/src/DistributedSystemImpl.cpp
##
@@ -143,11 +148,26 @@ void DistributedSystemImpl::unregisterCliCallback(int
appdomainId) {
}
}
+std::string DistributedSystemImpl::getThreadName() {
+ std::thread::id id = std::this_thread::get_id();
+ std::stringstream ss;
+ ss << id;
+ std::string threadName;
+ if (g_threadNames[id] != "") {
+threadName = ss.str() + " (" + g_threadNames[id] + ")";
+ } else {
+threadName = ss.str();
+ }
+ return threadName;
Review comment:
Augmenting the thread name on each all is expensive for an output that
will effectively be constant. If the threadName needs to be augmented, though I
argue it doesn't, then it should be done on the less frequently executed
`setThreadName()` call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use Thread Name In Log Messages
> ---
>
> Key: GEODE-10016
> URL: https://issues.apache.org/jira/browse/GEODE-10016
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Michael Martell
>Priority: Minor
> Labels: pull-request-available
>
> The native client logging system currently prints the threadId in all log
>
[jira] [Assigned] (GEODE-10002) Document recommendation but not obligation for parallel gateway sender to share disk store with region
[ https://issues.apache.org/jira/browse/GEODE-10002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alberto Gomez reassigned GEODE-10002: - Assignee: Alberto Gomez > Document recommendation but not obligation for parallel gateway sender to > share disk store with region > -- > > Key: GEODE-10002 > URL: https://issues.apache.org/jira/browse/GEODE-10002 > Project: Geode > Issue Type: Bug > Components: docs, wan >Reporter: Alberto Gomez >Assignee: Alberto Gomez >Priority: Major > Labels: needsTriage, pull-request-available > > As a result of GEODE-7997, it was documented that "the persisted data from a > parallel gateway sender must go to the same disk store as used by the region, > because parallel gateway sender queues must be colocated with their regions > to operate correctly.". > Even though it is true that "parallel gateway sender queues must be colocated > with their regions to operate correctly", having different disk stores for > the region and for the parallel gateway sender queues does not prevent them > from being colocated and therefore to operate correctly. > As stated in the Activity in the original ticket by Dan Smith, "The only > issue with separating the data into two separate disk stores is that manually > deleting the files for just one of the disk stores could cause a hang on > startup looking for the missing disk store. We recommend keeping all of the > colocated data together." > Given that the current statement in the documentation adds a non compatible > change to previous versions and also that the given restriction prevents from > the independent management of the disk used by the region and by the parallel > gateway sender queues it is proposed to change the statement from an > obligation to a recommendation giving the reasons for it. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (GEODE-10002) Document recommendation but not obligation for parallel gateway sender to share disk store with region
[ https://issues.apache.org/jira/browse/GEODE-10002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-10002: --- Labels: needsTriage pull-request-available (was: needsTriage) > Document recommendation but not obligation for parallel gateway sender to > share disk store with region > -- > > Key: GEODE-10002 > URL: https://issues.apache.org/jira/browse/GEODE-10002 > Project: Geode > Issue Type: Bug > Components: docs, wan >Reporter: Alberto Gomez >Priority: Major > Labels: needsTriage, pull-request-available > > As a result of GEODE-7997, it was documented that "the persisted data from a > parallel gateway sender must go to the same disk store as used by the region, > because parallel gateway sender queues must be colocated with their regions > to operate correctly.". > Even though it is true that "parallel gateway sender queues must be colocated > with their regions to operate correctly", having different disk stores for > the region and for the parallel gateway sender queues does not prevent them > from being colocated and therefore to operate correctly. > As stated in the Activity in the original ticket by Dan Smith, "The only > issue with separating the data into two separate disk stores is that manually > deleting the files for just one of the disk stores could cause a hang on > startup looking for the missing disk store. We recommend keeping all of the > colocated data together." > Given that the current statement in the documentation adds a non compatible > change to previous versions and also that the given restriction prevents from > the independent management of the disk used by the region and by the parallel > gateway sender queues it is proposed to change the statement from an > obligation to a recommendation giving the reasons for it. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (GEODE-10016) Use Thread Name In Log Messages
[
https://issues.apache.org/jira/browse/GEODE-10016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488327#comment-17488327
]
ASF GitHub Bot commented on GEODE-10016:
mmartell commented on a change in pull request #918:
URL: https://github.com/apache/geode-native/pull/918#discussion_r800935951
##
File path: cppcache/src/Log.cpp
##
@@ -382,7 +383,8 @@ std::string Log::formatLogLine(LogLevel level) {
<< std::put_time(_val, "%Y/%m/%d %H:%M:%S") << '.' <<
std::setfill('0')
<< std::setw(6) << microseconds.count() << ' '
<< std::put_time(_val, "%z ") << g_hostName << ":"
- << boost::this_process::get_id() << " " << std::this_thread::get_id()
+ << boost::this_process::get_id() << " "
+ << DistributedSystemImpl::getThreadName(std::this_thread::get_id())
Review comment:
Good catch. gnmsg has been updated to handle either kind of log lines as
below:
``` [debug 2022/02/06 07:44:02.450497 -0800 FirstPro:20336 18736]
EventId::EventId
[fine 2022/02/06 07:44:02.453857 -0800 FirstPro:20336 18812 (NC ETM
Thread)] ExpiryTaskManager thread is running.```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use Thread Name In Log Messages
> ---
>
> Key: GEODE-10016
> URL: https://issues.apache.org/jira/browse/GEODE-10016
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Michael Martell
>Priority: Minor
> Labels: pull-request-available
>
> The native client logging system currently prints the threadId in all log
> messages. Since all internally created native client threads are named, we
> should print the threadName instead of threadId. This will be extremely
> helpful to understanding the flow of messages since there are many background
> threads in the native client.
> Note: Lots of log messages are running on an application thread which was not
> created internally by the native client. Messages running on these threads
> should continue to print the threadId.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (GEODE-10016) Use Thread Name In Log Messages
[
https://issues.apache.org/jira/browse/GEODE-10016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488329#comment-17488329
]
ASF GitHub Bot commented on GEODE-10016:
mmartell commented on a change in pull request #918:
URL: https://github.com/apache/geode-native/pull/918#discussion_r800935951
##
File path: cppcache/src/Log.cpp
##
@@ -382,7 +383,8 @@ std::string Log::formatLogLine(LogLevel level) {
<< std::put_time(_val, "%Y/%m/%d %H:%M:%S") << '.' <<
std::setfill('0')
<< std::setw(6) << microseconds.count() << ' '
<< std::put_time(_val, "%z ") << g_hostName << ":"
- << boost::this_process::get_id() << " " << std::this_thread::get_id()
+ << boost::this_process::get_id() << " "
+ << DistributedSystemImpl::getThreadName(std::this_thread::get_id())
Review comment:
Good catch. gnmsg has been updated to handle either kind of log lines as
below:
[debug 2022/02/06 07:44:02.450497 -0800 FirstPro:20336 18736]
EventId::EventId ...
[fine 2022/02/06 07:44:02.453857 -0800 FirstPro:20336 18812 (NC ETM
Thread)] ExpiryTaskManager thread is running.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use Thread Name In Log Messages
> ---
>
> Key: GEODE-10016
> URL: https://issues.apache.org/jira/browse/GEODE-10016
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Michael Martell
>Priority: Minor
> Labels: pull-request-available
>
> The native client logging system currently prints the threadId in all log
> messages. Since all internally created native client threads are named, we
> should print the threadName instead of threadId. This will be extremely
> helpful to understanding the flow of messages since there are many background
> threads in the native client.
> Note: Lots of log messages are running on an application thread which was not
> created internally by the native client. Messages running on these threads
> should continue to print the threadId.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (GEODE-10016) Use Thread Name In Log Messages
[
https://issues.apache.org/jira/browse/GEODE-10016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488326#comment-17488326
]
ASF GitHub Bot commented on GEODE-10016:
mmartell commented on a change in pull request #918:
URL: https://github.com/apache/geode-native/pull/918#discussion_r800935951
##
File path: cppcache/src/Log.cpp
##
@@ -382,7 +383,8 @@ std::string Log::formatLogLine(LogLevel level) {
<< std::put_time(_val, "%Y/%m/%d %H:%M:%S") << '.' <<
std::setfill('0')
<< std::setw(6) << microseconds.count() << ' '
<< std::put_time(_val, "%z ") << g_hostName << ":"
- << boost::this_process::get_id() << " " << std::this_thread::get_id()
+ << boost::this_process::get_id() << " "
+ << DistributedSystemImpl::getThreadName(std::this_thread::get_id())
Review comment:
Good catch. gnmsg has been updated to handle either kind of log lines as
below:
```[debug 2022/02/06 07:44:02.450497 -0800 FirstPro:20336 18736]
EventId::EventId ...
[fine 2022/02/06 07:44:02.453857 -0800 FirstPro:20336 18812 (NC ETM
Thread)] ExpiryTaskManager thread is running.
```[debug 2022/02/06 07:44:02.450497 -0800 FirstPro:20336 18736]
EventId::EventId ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use Thread Name In Log Messages
> ---
>
> Key: GEODE-10016
> URL: https://issues.apache.org/jira/browse/GEODE-10016
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Michael Martell
>Priority: Minor
> Labels: pull-request-available
>
> The native client logging system currently prints the threadId in all log
> messages. Since all internally created native client threads are named, we
> should print the threadName instead of threadId. This will be extremely
> helpful to understanding the flow of messages since there are many background
> threads in the native client.
> Note: Lots of log messages are running on an application thread which was not
> created internally by the native client. Messages running on these threads
> should continue to print the threadId.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (GEODE-10016) Use Thread Name In Log Messages
[
https://issues.apache.org/jira/browse/GEODE-10016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488324#comment-17488324
]
ASF GitHub Bot commented on GEODE-10016:
mmartell commented on a change in pull request #918:
URL: https://github.com/apache/geode-native/pull/918#discussion_r800935951
##
File path: cppcache/src/Log.cpp
##
@@ -382,7 +383,8 @@ std::string Log::formatLogLine(LogLevel level) {
<< std::put_time(_val, "%Y/%m/%d %H:%M:%S") << '.' <<
std::setfill('0')
<< std::setw(6) << microseconds.count() << ' '
<< std::put_time(_val, "%z ") << g_hostName << ":"
- << boost::this_process::get_id() << " " << std::this_thread::get_id()
+ << boost::this_process::get_id() << " "
+ << DistributedSystemImpl::getThreadName(std::this_thread::get_id())
Review comment:
Good catch. gnmsg has been updated to handle either kind of log lines as
below:
```
[fine 2022/02/06 07:44:02.453857 -0800 FirstPro:20336 18812 (NC ETM
Thread)] ExpiryTaskManager thread is running.
```[debug 2022/02/06 07:44:02.450497 -0800 FirstPro:20336 18736]
EventId::EventId ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use Thread Name In Log Messages
> ---
>
> Key: GEODE-10016
> URL: https://issues.apache.org/jira/browse/GEODE-10016
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Michael Martell
>Priority: Minor
> Labels: pull-request-available
>
> The native client logging system currently prints the threadId in all log
> messages. Since all internally created native client threads are named, we
> should print the threadName instead of threadId. This will be extremely
> helpful to understanding the flow of messages since there are many background
> threads in the native client.
> Note: Lots of log messages are running on an application thread which was not
> created internally by the native client. Messages running on these threads
> should continue to print the threadId.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (GEODE-10016) Use Thread Name In Log Messages
[
https://issues.apache.org/jira/browse/GEODE-10016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488322#comment-17488322
]
ASF GitHub Bot commented on GEODE-10016:
mmartell commented on a change in pull request #918:
URL: https://github.com/apache/geode-native/pull/918#discussion_r800935951
##
File path: cppcache/src/Log.cpp
##
@@ -382,7 +383,8 @@ std::string Log::formatLogLine(LogLevel level) {
<< std::put_time(_val, "%Y/%m/%d %H:%M:%S") << '.' <<
std::setfill('0')
<< std::setw(6) << microseconds.count() << ' '
<< std::put_time(_val, "%z ") << g_hostName << ":"
- << boost::this_process::get_id() << " " << std::this_thread::get_id()
+ << boost::this_process::get_id() << " "
+ << DistributedSystemImpl::getThreadName(std::this_thread::get_id())
Review comment:
Good catch. gnmsg has been updated to handle either kind of log lines as
below:
```[debug 2022/02/06 07:44:02.450497 -0800 FirstPro:20336 18736]
EventId::EventId ...
[fine 2022/02/06 07:44:02.453857 -0800 FirstPro:20336 18812 (NC ETM
Thread)] ExpiryTaskManager thread is running.```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use Thread Name In Log Messages
> ---
>
> Key: GEODE-10016
> URL: https://issues.apache.org/jira/browse/GEODE-10016
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Michael Martell
>Priority: Minor
> Labels: pull-request-available
>
> The native client logging system currently prints the threadId in all log
> messages. Since all internally created native client threads are named, we
> should print the threadName instead of threadId. This will be extremely
> helpful to understanding the flow of messages since there are many background
> threads in the native client.
> Note: Lots of log messages are running on an application thread which was not
> created internally by the native client. Messages running on these threads
> should continue to print the threadId.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (GEODE-10016) Use Thread Name In Log Messages
[
https://issues.apache.org/jira/browse/GEODE-10016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488320#comment-17488320
]
ASF GitHub Bot commented on GEODE-10016:
mmartell commented on a change in pull request #918:
URL: https://github.com/apache/geode-native/pull/918#discussion_r800935951
##
File path: cppcache/src/Log.cpp
##
@@ -382,7 +383,8 @@ std::string Log::formatLogLine(LogLevel level) {
<< std::put_time(_val, "%Y/%m/%d %H:%M:%S") << '.' <<
std::setfill('0')
<< std::setw(6) << microseconds.count() << ' '
<< std::put_time(_val, "%z ") << g_hostName << ":"
- << boost::this_process::get_id() << " " << std::this_thread::get_id()
+ << boost::this_process::get_id() << " "
+ << DistributedSystemImpl::getThreadName(std::this_thread::get_id())
Review comment:
Good catch. gnmsg has been updated to handle either kind of log lines as
below:
```[debug 2022/02/06 07:44:02.450497 -0800 FirstPro:20336 18736]
EventId::EventId ...
[fine 2022/02/06 07:44:02.453857 -0800 FirstPro:20336 18812 (NC ETM
Thread)] ExpiryTaskManager thread is running.```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use Thread Name In Log Messages
> ---
>
> Key: GEODE-10016
> URL: https://issues.apache.org/jira/browse/GEODE-10016
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Michael Martell
>Priority: Minor
> Labels: pull-request-available
>
> The native client logging system currently prints the threadId in all log
> messages. Since all internally created native client threads are named, we
> should print the threadName instead of threadId. This will be extremely
> helpful to understanding the flow of messages since there are many background
> threads in the native client.
> Note: Lots of log messages are running on an application thread which was not
> created internally by the native client. Messages running on these threads
> should continue to print the threadId.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (GEODE-10016) Use Thread Name In Log Messages
[
https://issues.apache.org/jira/browse/GEODE-10016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488319#comment-17488319
]
ASF GitHub Bot commented on GEODE-10016:
mmartell commented on a change in pull request #918:
URL: https://github.com/apache/geode-native/pull/918#discussion_r800935951
##
File path: cppcache/src/Log.cpp
##
@@ -382,7 +383,8 @@ std::string Log::formatLogLine(LogLevel level) {
<< std::put_time(_val, "%Y/%m/%d %H:%M:%S") << '.' <<
std::setfill('0')
<< std::setw(6) << microseconds.count() << ' '
<< std::put_time(_val, "%z ") << g_hostName << ":"
- << boost::this_process::get_id() << " " << std::this_thread::get_id()
+ << boost::this_process::get_id() << " "
+ << DistributedSystemImpl::getThreadName(std::this_thread::get_id())
Review comment:
Good catch. gnmsg has been updated to handle either kind of log lines as
below:
```[debug 2022/02/06 07:44:02.450497 -0800 FirstPro:20336 18736]
EventId::EventId(02894033BF60) - doInit=false, reserveSize=0,
fullValueAfterDeltaFail=false
[fine 2022/02/06 07:44:02.453857 -0800 FirstPro:20336 18812 (NC ETM
Thread)] ExpiryTaskManager thread is running.```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use Thread Name In Log Messages
> ---
>
> Key: GEODE-10016
> URL: https://issues.apache.org/jira/browse/GEODE-10016
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Michael Martell
>Priority: Minor
> Labels: pull-request-available
>
> The native client logging system currently prints the threadId in all log
> messages. Since all internally created native client threads are named, we
> should print the threadName instead of threadId. This will be extremely
> helpful to understanding the flow of messages since there are many background
> threads in the native client.
> Note: Lots of log messages are running on an application thread which was not
> created internally by the native client. Messages running on these threads
> should continue to print the threadId.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (GEODE-10016) Use Thread Name In Log Messages
[
https://issues.apache.org/jira/browse/GEODE-10016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488316#comment-17488316
]
ASF GitHub Bot commented on GEODE-10016:
mmartell commented on a change in pull request #918:
URL: https://github.com/apache/geode-native/pull/918#discussion_r800935951
##
File path: cppcache/src/Log.cpp
##
@@ -382,7 +383,8 @@ std::string Log::formatLogLine(LogLevel level) {
<< std::put_time(_val, "%Y/%m/%d %H:%M:%S") << '.' <<
std::setfill('0')
<< std::setw(6) << microseconds.count() << ' '
<< std::put_time(_val, "%z ") << g_hostName << ":"
- << boost::this_process::get_id() << " " << std::this_thread::get_id()
+ << boost::this_process::get_id() << " "
+ << DistributedSystemImpl::getThreadName(std::this_thread::get_id())
Review comment:
Good catch. gnmsg has been updated to handle either kind of log lines as
below:
```[debug 2022/02/06 07:44:02.450497 -0800 FirstPro:20336 18736]
EventId::EventId(02894033BF60) - doInit=false, reserveSize=0,
fullValueAfterDeltaFail=false
[fine 2022/02/06 07:44:02.453857 -0800 FirstPro:20336 18812 (NC ETM
Thread)] ExpiryTaskManager thread is running.```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use Thread Name In Log Messages
> ---
>
> Key: GEODE-10016
> URL: https://issues.apache.org/jira/browse/GEODE-10016
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Michael Martell
>Priority: Minor
> Labels: pull-request-available
>
> The native client logging system currently prints the threadId in all log
> messages. Since all internally created native client threads are named, we
> should print the threadName instead of threadId. This will be extremely
> helpful to understanding the flow of messages since there are many background
> threads in the native client.
> Note: Lots of log messages are running on an application thread which was not
> created internally by the native client. Messages running on these threads
> should continue to print the threadId.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (GEODE-9991) SSL protocol and cipher preferences are ignored when endpoint verification is enabled.
[
https://issues.apache.org/jira/browse/GEODE-9991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488296#comment-17488296
]
Jacob Barrett commented on GEODE-9991:
--
Changes in GEODE-10015 are needed to complete JDK upgrade testing.
> SSL protocol and cipher preferences are ignored when endpoint verification is
> enabled.
> --
>
> Key: GEODE-9991
> URL: https://issues.apache.org/jira/browse/GEODE-9991
> Project: Geode
> Issue Type: Bug
> Components: core, security
>Affects Versions: 1.12.8, 1.12.9, 1.13.7, 1.13.8, 1.14.3, 1.14.4, 1.15.0,
> 1.16.0
>Reporter: Jacob Barrett
>Assignee: Jacob Barrett
>Priority: Major
> Labels: blocks-1.15.0, pull-request-available
>
> When SSL endpoint verification is enabled the configuration for protocols and
> ciphers reverts to the {{SSLContext}}'s client mode defaults. This can result
> in difficulty upgrade the JDK when the newer JDK may use different defaults
> for client and server mode SSL.
> Oracle JDK 1.8.0_u261 and OpenJDK 1.8.0_u272 replaced the SSL implementation
> with a back port from Java 11. This changed the default server protocols from
> {{[SSLv2Hello, TLSv1, TLSv1.1, TLSv1.2]}} to {{[TLSv1.3,TLSv1.2,SSLv2Hello]}}
> and client to {{[TLSv1.3,TLSv1.2]}}. With this bug the the server protocols
> get reset to the client protocols dropping support for the {{SSLv2Hello}}
> protocol, which is the first priority protocol by default in the old JDK.
> The result is a failure to handshake with the following exception:
> {{javax.net.ssl.SSLHandshakeException: SSLv2Hello is not enabled}}
> To reproduce you need to have endpoint validation enabled on your SSL
> configuration. Set your protocols to `any`. Start 1st locator with JDK older
> than 1.8.0_u261. Start 2nd locator with JDK at least as new as JDK
> 1.8.0_u272.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (GEODE-9991) SSL protocol and cipher preferences are ignored when endpoint verification is enabled.
[
https://issues.apache.org/jira/browse/GEODE-9991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacob Barrett updated GEODE-9991:
-
Affects Version/s: 1.12.8
1.12.9
1.13.8
1.14.4
1.16.0
> SSL protocol and cipher preferences are ignored when endpoint verification is
> enabled.
> --
>
> Key: GEODE-9991
> URL: https://issues.apache.org/jira/browse/GEODE-9991
> Project: Geode
> Issue Type: Bug
> Components: core, security
>Affects Versions: 1.12.8, 1.12.9, 1.13.7, 1.13.8, 1.14.3, 1.14.4, 1.15.0,
> 1.16.0
>Reporter: Jacob Barrett
>Assignee: Jacob Barrett
>Priority: Major
> Labels: blocks-1.15.0, pull-request-available
>
> When SSL endpoint verification is enabled the configuration for protocols and
> ciphers reverts to the {{SSLContext}}'s client mode defaults. This can result
> in difficulty upgrade the JDK when the newer JDK may use different defaults
> for client and server mode SSL.
> Oracle JDK 1.8.0_u261 and OpenJDK 1.8.0_u272 replaced the SSL implementation
> with a back port from Java 11. This changed the default server protocols from
> {{[SSLv2Hello, TLSv1, TLSv1.1, TLSv1.2]}} to {{[TLSv1.3,TLSv1.2,SSLv2Hello]}}
> and client to {{[TLSv1.3,TLSv1.2]}}. With this bug the the server protocols
> get reset to the client protocols dropping support for the {{SSLv2Hello}}
> protocol, which is the first priority protocol by default in the old JDK.
> The result is a failure to handshake with the following exception:
> {{javax.net.ssl.SSLHandshakeException: SSLv2Hello is not enabled}}
> To reproduce you need to have endpoint validation enabled on your SSL
> configuration. Set your protocols to `any`. Start 1st locator with JDK older
> than 1.8.0_u261. Start 2nd locator with JDK at least as new as JDK
> 1.8.0_u272.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Resolved] (GEODE-9323) Remove ACE references from tests/cpp
[ https://issues.apache.org/jira/browse/GEODE-9323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender resolved GEODE-9323. - Resolution: Fixed > Remove ACE references from tests/cpp > > > Key: GEODE-9323 > URL: https://issues.apache.org/jira/browse/GEODE-9323 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: obliterate-ace, pull-request-available > > *AS A* native client contributor > *I WANT TO* remove all remaining references to ACE in tests/cpp projects > *SO THAT* eventually we can get rid of ACE library > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (GEODE-9323) Remove ACE references from tests/cpp
[ https://issues.apache.org/jira/browse/GEODE-9323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender closed GEODE-9323. --- > Remove ACE references from tests/cpp > > > Key: GEODE-9323 > URL: https://issues.apache.org/jira/browse/GEODE-9323 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: obliterate-ace, pull-request-available > > *AS A* native client contributor > *I WANT TO* remove all remaining references to ACE in tests/cpp projects > *SO THAT* eventually we can get rid of ACE library > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (GEODE-9323) Remove ACE references from tests/cpp
[ https://issues.apache.org/jira/browse/GEODE-9323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488223#comment-17488223 ] ASF GitHub Bot commented on GEODE-9323: --- pdxcodemonkey merged pull request #811: URL: https://github.com/apache/geode-native/pull/811 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove ACE references from tests/cpp > > > Key: GEODE-9323 > URL: https://issues.apache.org/jira/browse/GEODE-9323 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: obliterate-ace, pull-request-available > > *AS A* native client contributor > *I WANT TO* remove all remaining references to ACE in tests/cpp projects > *SO THAT* eventually we can get rid of ACE library > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (GEODE-9323) Remove ACE references from tests/cpp
[ https://issues.apache.org/jira/browse/GEODE-9323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488222#comment-17488222 ] ASF subversion and git services commented on GEODE-9323: Commit 52c05ef1d06c60db733350c4b2c3b8f7bda11d99 in geode-native's branch refs/heads/develop from Mario Salazar de Torres [ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=52c05ef ] GEODE-9323: Remove ACE from tests/cpp projects (#811) * GEODE-9323: Remove ACE from tests/cpp projects - Removed all ACE references from tests/cpp projects. - Also moved SerializationRegistry inline functions to the source file in order to solve compilation. * GEODE-9323: Empty commit to trigger CI > Remove ACE references from tests/cpp > > > Key: GEODE-9323 > URL: https://issues.apache.org/jira/browse/GEODE-9323 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: obliterate-ace, pull-request-available > > *AS A* native client contributor > *I WANT TO* remove all remaining references to ACE in tests/cpp projects > *SO THAT* eventually we can get rid of ACE library > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (GEODE-8679) Replace Native logger with 3rd party solution
[ https://issues.apache.org/jira/browse/GEODE-8679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488214#comment-17488214 ] ASF GitHub Bot commented on GEODE-8679: --- pdxcodemonkey commented on pull request #761: URL: https://github.com/apache/geode-native/pull/761#issuecomment-1031631405 There remains one integration test in the old suite (I believe) that hangs every time when run with DEBUG-level logging and this change. I don't have bandwidth or inclination to debug this issue to resolution. I'm also a lot more reluctant to introduce a 3rd-party logger into our code base, given everyone's recent experience with Log4j issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Replace Native logger with 3rd party solution > - > > Key: GEODE-8679 > URL: https://issues.apache.org/jira/browse/GEODE-8679 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Blake Bender >Priority: Major > Labels: pull-request-available > > As a native client developer, I would prefer to only maintain code that > actually implements core features of a Geode client. A logging subsystem is > definitely not core Geode functionality. Additionally, the existing > geode-native logger does not properly support the `loig-file-size-limit` and > `log-disk-space-limit` properties. Rather than attempt to fix the existing > logging code to properly implement these, we should switch to a 3rd-party > solution (spdlog or similar) that already has these features available and > working. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (GEODE-8679) Replace Native logger with 3rd party solution
[ https://issues.apache.org/jira/browse/GEODE-8679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488213#comment-17488213 ] ASF GitHub Bot commented on GEODE-8679: --- pdxcodemonkey closed pull request #761: URL: https://github.com/apache/geode-native/pull/761 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Replace Native logger with 3rd party solution > - > > Key: GEODE-8679 > URL: https://issues.apache.org/jira/browse/GEODE-8679 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Blake Bender >Priority: Major > Labels: pull-request-available > > As a native client developer, I would prefer to only maintain code that > actually implements core features of a Geode client. A logging subsystem is > definitely not core Geode functionality. Additionally, the existing > geode-native logger does not properly support the `loig-file-size-limit` and > `log-disk-space-limit` properties. Rather than attempt to fix the existing > logging code to properly implement these, we should switch to a 3rd-party > solution (spdlog or similar) that already has these features available and > working. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (GEODE-9896) Upgrade dependencies
[ https://issues.apache.org/jira/browse/GEODE-9896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488212#comment-17488212 ] ASF GitHub Bot commented on GEODE-9896: --- pdxcodemonkey merged pull request #916: URL: https://github.com/apache/geode-native/pull/916 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Upgrade dependencies > > > Key: GEODE-9896 > URL: https://issues.apache.org/jira/browse/GEODE-9896 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Jacob Barrett >Assignee: Jacob Barrett >Priority: Major > Labels: pull-request-available > > * ACE 7.0.5 > * Boost 1.78.0 > * SQLite 3.37 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (GEODE-9896) Upgrade dependencies
[ https://issues.apache.org/jira/browse/GEODE-9896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488211#comment-17488211 ] ASF subversion and git services commented on GEODE-9896: Commit 53ec0fd0049948db08a6a3995143e04b67a6e75e in geode-native's branch refs/heads/develop from M. Oleske [ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=53ec0fd ] GEODE-9896: bump sqlite-fx to 1.0.115.5 (#916) > Upgrade dependencies > > > Key: GEODE-9896 > URL: https://issues.apache.org/jira/browse/GEODE-9896 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Jacob Barrett >Assignee: Jacob Barrett >Priority: Major > Labels: pull-request-available > > * ACE 7.0.5 > * Boost 1.78.0 > * SQLite 3.37 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (GEODE-9896) Upgrade dependencies
[ https://issues.apache.org/jira/browse/GEODE-9896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488208#comment-17488208 ] ASF subversion and git services commented on GEODE-9896: Commit 237640cc9112dcf13d2124b7ef6ab26894d45d61 in geode-native's branch refs/heads/develop from M. Oleske [ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=237640c ] GEODE-9896: Bump sqlite to 3.37.2 (#914) Authored-by: M. Oleske > Upgrade dependencies > > > Key: GEODE-9896 > URL: https://issues.apache.org/jira/browse/GEODE-9896 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Jacob Barrett >Assignee: Jacob Barrett >Priority: Major > Labels: pull-request-available > > * ACE 7.0.5 > * Boost 1.78.0 > * SQLite 3.37 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (GEODE-9896) Upgrade dependencies
[ https://issues.apache.org/jira/browse/GEODE-9896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488203#comment-17488203 ] ASF GitHub Bot commented on GEODE-9896: --- pdxcodemonkey merged pull request #914: URL: https://github.com/apache/geode-native/pull/914 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Upgrade dependencies > > > Key: GEODE-9896 > URL: https://issues.apache.org/jira/browse/GEODE-9896 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Jacob Barrett >Assignee: Jacob Barrett >Priority: Major > Labels: pull-request-available > > * ACE 7.0.5 > * Boost 1.78.0 > * SQLite 3.37 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (GEODE-9896) Upgrade dependencies
[ https://issues.apache.org/jira/browse/GEODE-9896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488197#comment-17488197 ] ASF subversion and git services commented on GEODE-9896: Commit 49301fbd6c657f2e12c8756dbc22ef6cf238776d in geode-native's branch refs/heads/develop from M. Oleske [ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=49301fb ] GEODE-9896: Bump ace to 7.0.6 (#913) - fix building on macos monterry Authored-by: M. Oleske > Upgrade dependencies > > > Key: GEODE-9896 > URL: https://issues.apache.org/jira/browse/GEODE-9896 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Jacob Barrett >Assignee: Jacob Barrett >Priority: Major > Labels: pull-request-available > > * ACE 7.0.5 > * Boost 1.78.0 > * SQLite 3.37 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (GEODE-9896) Upgrade dependencies
[ https://issues.apache.org/jira/browse/GEODE-9896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488198#comment-17488198 ] ASF GitHub Bot commented on GEODE-9896: --- pdxcodemonkey merged pull request #913: URL: https://github.com/apache/geode-native/pull/913 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Upgrade dependencies > > > Key: GEODE-9896 > URL: https://issues.apache.org/jira/browse/GEODE-9896 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Jacob Barrett >Assignee: Jacob Barrett >Priority: Major > Labels: pull-request-available > > * ACE 7.0.5 > * Boost 1.78.0 > * SQLite 3.37 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (GEODE-9617) CI Failure: PartitionedRegionSingleHopDUnitTest fails with ConditionTimeoutException waiting for server to bucket map size
[
https://issues.apache.org/jira/browse/GEODE-9617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488145#comment-17488145
]
Geode Integration commented on GEODE-9617:
--
Seen in [distributed-test-openjdk8
#931|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-mass-test-run/jobs/distributed-test-openjdk8/builds/931]
... see [test
results|http://files.apachegeode-ci.info/builds/apache-develop-mass-test-run/1.16.0-build.0035/test-results/distributedTest/1644054845/]
or download
[artifacts|http://files.apachegeode-ci.info/builds/apache-develop-mass-test-run/1.16.0-build.0035/test-artifacts/1644054845/distributedtestfiles-openjdk8-1.16.0-build.0035.tgz].
> CI Failure: PartitionedRegionSingleHopDUnitTest fails with
> ConditionTimeoutException waiting for server to bucket map size
> --
>
> Key: GEODE-9617
> URL: https://issues.apache.org/jira/browse/GEODE-9617
> Project: Geode
> Issue Type: Bug
> Components: client/server
>Affects Versions: 1.15.0
>Reporter: Kirk Lund
>Assignee: Mark Hanson
>Priority: Major
> Labels: pull-request-available
>
> {noformat}
> org.apache.geode.internal.cache.PartitionedRegionSingleHopDUnitTest >
> testClientMetadataForPersistentPrs FAILED
> org.awaitility.core.ConditionTimeoutException: Assertion condition
> defined as a lambda expression in
> org.apache.geode.internal.cache.PartitionedRegionSingleHopDUnitTest that uses
> org.apache.geode.cache.client.internal.ClientMetadataService,
> org.apache.geode.cache.client.internal.ClientMetadataServiceorg.apache.geode.cache.Region
>
> Expecting actual not to be null within 5 minutes.
> at
> org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:166)
> at
> org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
> at
> org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
> at
> org.awaitility.core.ConditionFactory.until(ConditionFactory.java:939)
> at
> org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:723)
> at
> org.apache.geode.internal.cache.PartitionedRegionSingleHopDUnitTest.testClientMetadataForPersistentPrs(PartitionedRegionSingleHopDUnitTest.java:971)
> Caused by:
> java.lang.AssertionError:
> Expecting actual not to be null
> at
> org.apache.geode.internal.cache.PartitionedRegionSingleHopDUnitTest.lambda$testClientMetadataForPersistentPrs$26(PartitionedRegionSingleHopDUnitTest.java:976)
> {noformat}
> {noformat}
> org.apache.geode.internal.cache.PartitionedRegionSingleHopDUnitTest >
> testMetadataServiceCallAccuracy_FromGetOp FAILED
> org.awaitility.core.ConditionTimeoutException: Assertion condition
> defined as a lambda expression in
> org.apache.geode.internal.cache.PartitionedRegionSingleHopDUnitTest that uses
> org.apache.geode.cache.client.internal.ClientMetadataService
> Expecting value to be false but was true expected:<[fals]e> but
> was:<[tru]e> within 5 minutes.
> at
> org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:166)
> at
> org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
> at
> org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
> at
> org.awaitility.core.ConditionFactory.until(ConditionFactory.java:939)
> at
> org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:723)
> at
> org.apache.geode.internal.cache.PartitionedRegionSingleHopDUnitTest.testMetadataServiceCallAccuracy_FromGetOp(PartitionedRegionSingleHopDUnitTest.java:394)
> Caused by:
> org.junit.ComparisonFailure:
> Expecting value to be false but was true expected:<[fals]e> but
> was:<[tru]e>
> at sun.reflect.GeneratedConstructorAccessor29.newInstance(Unknown
> Source)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at
> org.apache.geode.internal.cache.PartitionedRegionSingleHopDUnitTest.lambda$testMetadataServiceCallAccuracy_FromGetOp$6(PartitionedRegionSingleHopDUnitTest.java:395)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (GEODE-9565) DeploymentManagementDUnitTest fails mass test run with (HTTP form data?) in the log
[
https://issues.apache.org/jira/browse/GEODE-9565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488143#comment-17488143
]
Geode Integration commented on GEODE-9565:
--
Seen in [distributed-test-openjdk8
#971|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-mass-test-run/jobs/distributed-test-openjdk8/builds/971]
... see [test
results|http://files.apachegeode-ci.info/builds/apache-develop-mass-test-run/1.16.0-build.0035/test-results/distributedTest/1644086113/]
or download
[artifacts|http://files.apachegeode-ci.info/builds/apache-develop-mass-test-run/1.16.0-build.0035/test-artifacts/1644086113/distributedtestfiles-openjdk8-1.16.0-build.0035.tgz].
> DeploymentManagementDUnitTest fails mass test run with (HTTP form data?) in
> the log
> ---
>
> Key: GEODE-9565
> URL: https://issues.apache.org/jira/browse/GEODE-9565
> Project: Geode
> Issue Type: Bug
> Components: management
>Affects Versions: 1.15.0
>Reporter: Bill Burcham
>Priority: Major
>
> Failure in this run due to "Suspicious strings were written to the log":
> https://hydradb.hdb.gemfire-ci.info/hdb/testresult/11466814
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-mass-test-run/jobs/distributed-test-openjdk8/builds/1430
> Here's the beginning of the offending log content:
> {code:java}
> org.apache.geode.management.internal.rest.DeploymentManagementDUnitTest >
> classMethod FAILED
> java.lang.AssertionError: Suspicious strings were written to the log
> during this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> ---
> Found suspect string in 'dunit_suspect-vm0.log' at line 602
>
> $ \u\u\utimestamp3436046\u0001bS#C\uPK\u0007\u0008C??{}
> \u\u\u
>
> \u\u\uPK\u0001\u0002\u0014\u\u0014\u\u0008\u0008\u0008\u\u00068\u001cS?\u\u\u??\u\u\u\u000c\u\u0004\u\u\u\u\u\u\u\u\u\u\u\u\u\u\uClass2.class\u\uPK\u0001\u0002\u0014\u\u0014\u\u0008\u0008\u0008\u\u00068\u001cSC??{}
> \u\u\u
> \u\u\u
> \u\u\u\u\u\u\u\u\u\u\u\u\u??\u\u\utimestampPK\u0005\u0006\u\u\u\u\u0002\u\u0002\uu\u\u\u\u001d\u0001\u\u\u\u
> --YZ_CWqvae2jydiy-5zCOPBjJdXq3V4ISPRu
> Content-Disposition: form-data; name="config"
> Content-Type: application/json
> at org.junit.Assert.fail(Assert.java:89)
> at
> org.apache.geode.test.dunit.internal.DUnitLauncher.closeAndCheckForSuspects(DUnitLauncher.java:409)
> at
> org.apache.geode.test.dunit.internal.DUnitLauncher.closeAndCheckForSuspects(DUnitLauncher.java:425)
> at
> org.apache.geode.test.dunit.rules.ClusterStartupRule.after(ClusterStartupRule.java:186)
> at
> org.apache.geode.test.dunit.rules.ClusterStartupRule.access$100(ClusterStartupRule.java:70)
> at
> org.apache.geode.test.dunit.rules.ClusterStartupRule$1.evaluate(ClusterStartupRule.java:141)
> at
> org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:54)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (GEODE-7739) JMX managers may fail to federate mbeans for other members
[ https://issues.apache.org/jira/browse/GEODE-7739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488142#comment-17488142 ] Geode Integration commented on GEODE-7739: -- Seen in [distributed-test-openjdk8 #987|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-mass-test-run/jobs/distributed-test-openjdk8/builds/987] ... see [test results|http://files.apachegeode-ci.info/builds/apache-develop-mass-test-run/1.16.0-build.0035/test-results/distributedTest/1644096584/] or download [artifacts|http://files.apachegeode-ci.info/builds/apache-develop-mass-test-run/1.16.0-build.0035/test-artifacts/1644096584/distributedtestfiles-openjdk8-1.16.0-build.0035.tgz]. > JMX managers may fail to federate mbeans for other members > -- > > Key: GEODE-7739 > URL: https://issues.apache.org/jira/browse/GEODE-7739 > Project: Geode > Issue Type: Bug > Components: jmx >Reporter: Kirk Lund >Assignee: Kirk Lund >Priority: Major > Labels: GeodeOperationAPI, pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > > JMX Manager may fail to federate one or more MXBeans for other members > because of a race condition during startup. When ManagementCacheListener is > first constructed, it is in a state that will ignore all callbacks because > the field readyForEvents is false. > > Debugging with JMXMBeanReconnectDUnitTest revealed this bug. > The test starts two locators with jmx manager configured and started. > Locator1 always has all of locator2's mbeans, but locator2 is intermittently > missing the personal mbeans of locator1. > I think this is caused by some sort of race condition in the code that > creates the monitoring regions for other members in locator2. > It's possible that the jmx manager that hits this bug might fail to have > mbeans for servers as well as other locators but I haven't seen a test case > for this scenario. > The exposure of this bug means that a user running more than one locator > might have a locator that is missing one or more mbeans for the cluster. > > Studying the JMX code also reveals the existence of *GEODE-8012*. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Assigned] (GEODE-10020) Gradual activation of LiveServerPinger for each destination
[ https://issues.apache.org/jira/browse/GEODE-10020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mario Ivanac reassigned GEODE-10020: Assignee: Mario Ivanac > Gradual activation of LiveServerPinger for each destination > --- > > Key: GEODE-10020 > URL: https://issues.apache.org/jira/browse/GEODE-10020 > Project: Geode > Issue Type: Improvement > Components: wan >Reporter: Mario Ivanac >Assignee: Mario Ivanac >Priority: Major > > Add configurable option to gradually activate pinging toward destination. > This can be accomplish by increasing initial delay of each ping task. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (GEODE-10020) Gradual activation of LiveServerPinger for each destination
Mario Ivanac created GEODE-10020: Summary: Gradual activation of LiveServerPinger for each destination Key: GEODE-10020 URL: https://issues.apache.org/jira/browse/GEODE-10020 Project: Geode Issue Type: Improvement Components: wan Reporter: Mario Ivanac Add configurable option to gradually activate pinging toward destination. This can be accomplish by increasing initial delay of each ping task. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (GEODE-10008) Avoid possible EntryDestroyedException error in wan-copy region command when entry destroyed in partitioned region
[ https://issues.apache.org/jira/browse/GEODE-10008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-10008: --- Labels: needsTriage pull-request-available (was: needsTriage) > Avoid possible EntryDestroyedException error in wan-copy region command when > entry destroyed in partitioned region > -- > > Key: GEODE-10008 > URL: https://issues.apache.org/jira/browse/GEODE-10008 > Project: Geode > Issue Type: Bug > Components: gfsh, wan >Reporter: Alberto Gomez >Assignee: Alberto Gomez >Priority: Major > Labels: needsTriage, pull-request-available > > When the wan-copy region command is executed over a partitioned region, it is > possible that sometimes an EntryDestroyedException error is found if, while > reading the entries from the region, one of them is destroyed. > The error has been seen sometimes when running the following test: > WanCopyRegionCommandDUnitTest. > testSuccessfulExecutionWhileRunningOpsOnRegion(true, true). > > Log of the error: > Multiple Failures (2 failures) > org.opentest4j.AssertionFailedError: [ Member | > Status | Message > -- | -- | > --- > alberto-dell(421543):41010 | ERROR | Execution failed. Error: > org.apache.geode.cache.EntryDestroyedException: 26 > alberto-dell(421504):41009 | OK | Entries copied: 2,977 > alberto-dell(421598):41011 | OK | Entries copied: 3,042 > ] > expected: OK > but was: ERROR > java.lang.AssertionError: Suspicious strings were written to the log > during this run. > Fix the strings or use IgnoredException.addIgnoredException to ignore. > --- > Found suspect string in 'dunit_suspect-vm6.log' at line 1883 > [error 2022/02/01 08:58:59.046 CET tid=99] > Exception occurred attempting to wan-copy region > java.util.concurrent.ExecutionException: > org.apache.geode.cache.EntryDestroyedException: 26 > at java.util.concurrent.FutureTask.report(FutureTask.java:122) > at java.util.concurrent.FutureTask.get(FutureTask.java:192) > at > org.apache.geode.cache.wan.internal.WanCopyRegionFunctionService.execute(WanCopyRegionFunctionService.java:90) > at > org.apache.geode.management.internal.cli.functions.WanCopyRegionFunction.executeFunctionInService(WanCopyRegionFunction.java:163) > at > org.apache.geode.management.internal.cli.functions.WanCopyRegionFunction.executeFunction(WanCopyRegionFunction.java:157) > at > org.apache.geode.management.cli.CliFunction.execute(CliFunction.java:37) > at > org.apache.geode.internal.cache.MemberFunctionStreamingMessage.process(MemberFunctionStreamingMessage.java:201) > at > org.apache.geode.distributed.internal.DistributionMessage.scheduleAction(DistributionMessage.java:382) > at > org.apache.geode.distributed.internal.DistributionMessage$1.run(DistributionMessage.java:447) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > at > org.apache.geode.distributed.internal.ClusterOperationExecutors.runUntilShutdown(ClusterOperationExecutors.java:444) > at > org.apache.geode.distributed.internal.ClusterOperationExecutors.doFunctionExecutionThread(ClusterOperationExecutors.java:379) > at > org.apache.geode.logging.internal.executors.LoggingThreadFactory.lambda$newThread$0(LoggingThreadFactory.java:120) > at java.lang.Thread.run(Thread.java:748) > Caused by: org.apache.geode.cache.EntryDestroyedException: 26 > at > org.apache.geode.internal.cache.NonTXEntry.basicGetEntry(NonTXEntry.java:62) > at > org.apache.geode.internal.cache.NonTXEntry.getRegion(NonTXEntry.java:119) > at > org.apache.geode.internal.cache.NonTXEntry.hashCode(NonTXEntry.java:157) > at java.util.HashMap.hash(HashMap.java:340) > at java.util.HashMap.put(HashMap.java:613) > at java.util.HashSet.add(HashSet.java:220) > at java.util.stream.ReduceOps$3ReducingSink.accept(ReduceOps.java:169) > at java.util.Iterator.forEachRemaining(Iterator.java:116) > at > java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1801) > at > java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:647) > at > java.util.stream.ReferencePipeline$7$1.accept(ReferencePipeline.java:272) > at java.util.HashMap$KeySpliterator.forEachRemaining(HashMap.java:1580) > at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:482) > at >
