[jira] [Commented] (GEODE-3048) Tests that require the Gradle test runner should fail descriptively when run through Intellij

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16090437#comment-16090437
 ] 

ASF GitHub Bot commented on GEODE-3048:
---

Github user YehEmily closed the pull request at:

https://github.com/apache/geode/pull/575


> Tests that require the Gradle test runner should fail descriptively when run 
> through Intellij
> -
>
> Key: GEODE-3048
> URL: https://issues.apache.org/jira/browse/GEODE-3048
> Project: Geode
>  Issue Type: Bug
>  Components: management, tests
>Reporter: Jared Stewart
>Assignee: Jared Stewart
>
> We have some tests the only pass when run through gradle (as opposed to 
> running via the Intellij test runner).  If one of these tests fails in CI, it 
> is easy to being debugging them in the IDE without realizing that they will 
> *never* pass when not run via gradle.  Until we fix the underlying issues 
> that require running through gradle, it would be nice for such tests to 
> detect when they are running outside of gradle, and to notify the user that 
> they should be expected to fail.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3048) Tests that require the Gradle test runner should fail descriptively when run through Intellij

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16048051#comment-16048051
 ] 

ASF GitHub Bot commented on GEODE-3048:
---

Github user YehEmily commented on a diff in the pull request:

https://github.com/apache/geode/pull/575#discussion_r121717861
  
--- Diff: 
geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsIntegrationTest.java
 ---
@@ -39,6 +39,8 @@
 import org.junit.Before;
 import org.junit.Rule;
 import org.junit.Test;
+import org.junit.ClassRule;
--- End diff --

Okay, I'll get that done and update the PR! Thank you!


> Tests that require the Gradle test runner should fail descriptively when run 
> through Intellij
> -
>
> Key: GEODE-3048
> URL: https://issues.apache.org/jira/browse/GEODE-3048
> Project: Geode
>  Issue Type: Bug
>  Components: management, tests
>Reporter: Jared Stewart
>Assignee: Jared Stewart
>
> We have some tests the only pass when run through gradle (as opposed to 
> running via the Intellij test runner).  If one of these tests fails in CI, it 
> is easy to being debugging them in the IDE without realizing that they will 
> *never* pass when not run via gradle.  Until we fix the underlying issues 
> that require running through gradle, it would be nice for such tests to 
> detect when they are running outside of gradle, and to notify the user that 
> they should be expected to fail.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3048) Tests that require the Gradle test runner should fail descriptively when run through Intellij

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047957#comment-16047957
 ] 

ASF GitHub Bot commented on GEODE-3048:
---

Github user pdxrunner commented on a diff in the pull request:

https://github.com/apache/geode/pull/575#discussion_r121690706
  
--- Diff: 
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/controllers/RestAPIOnRegionFunctionExecutionDUnitTest.java
 ---
@@ -26,7 +26,9 @@
 import java.util.Map;
 import java.util.Set;
 
+import org.apache.geode.test.dunit.rules.RequiresGeodeHome;
--- End diff --

Reorder imports - looks like there are several files that should have the 
imports reordered. I'd suggest reviewing all of the tests modified and use the 
IDE to reorder the imports.


> Tests that require the Gradle test runner should fail descriptively when run 
> through Intellij
> -
>
> Key: GEODE-3048
> URL: https://issues.apache.org/jira/browse/GEODE-3048
> Project: Geode
>  Issue Type: Bug
>  Components: management, tests
>Reporter: Jared Stewart
>Assignee: Jared Stewart
>
> We have some tests the only pass when run through gradle (as opposed to 
> running via the Intellij test runner).  If one of these tests fails in CI, it 
> is easy to being debugging them in the IDE without realizing that they will 
> *never* pass when not run via gradle.  Until we fix the underlying issues 
> that require running through gradle, it would be nice for such tests to 
> detect when they are running outside of gradle, and to notify the user that 
> they should be expected to fail.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3048) Tests that require the Gradle test runner should fail descriptively when run through Intellij

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047168#comment-16047168
 ] 

ASF GitHub Bot commented on GEODE-3048:
---

Github user YehEmily commented on the issue:

https://github.com/apache/geode/pull/575
  
Precheckin in progress!


> Tests that require the Gradle test runner should fail descriptively when run 
> through Intellij
> -
>
> Key: GEODE-3048
> URL: https://issues.apache.org/jira/browse/GEODE-3048
> Project: Geode
>  Issue Type: Bug
>  Components: management, tests
>Reporter: Jared Stewart
>Assignee: Jared Stewart
>
> We have some tests the only pass when run through gradle (as opposed to 
> running via the Intellij test runner).  If one of these tests fails in CI, it 
> is easy to being debugging them in the IDE without realizing that they will 
> *never* pass when not run via gradle.  Until we fix the underlying issues 
> that require running through gradle, it would be nice for such tests to 
> detect when they are running outside of gradle, and to notify the user that 
> they should be expected to fail.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3048) Tests that require the Gradle test runner should fail descriptively when run through Intellij

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047167#comment-16047167
 ] 

ASF GitHub Bot commented on GEODE-3048:
---

GitHub user YehEmily opened a pull request:

https://github.com/apache/geode/pull/575

GEODE-3048: Editing tests requiring Gradle test runner to fail 
descriptively in IntelliJ

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to d...@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/YehEmily/geode GEODE-3048

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/575.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #575


commit 9ba574244450766b2fa2e843719eb4a51a344b7d
Author: YehEmily 
Date:   2017-06-08T19:09:14Z

GEODE-3048: Editing tests that require the Gradle test runner to fail 
descriptively when run through IntelliJ




> Tests that require the Gradle test runner should fail descriptively when run 
> through Intellij
> -
>
> Key: GEODE-3048
> URL: https://issues.apache.org/jira/browse/GEODE-3048
> Project: Geode
>  Issue Type: Bug
>  Components: management, tests
>Reporter: Jared Stewart
>Assignee: Jared Stewart
>
> We have some tests the only pass when run through gradle (as opposed to 
> running via the Intellij test runner).  If one of these tests fails in CI, it 
> is easy to being debugging them in the IDE without realizing that they will 
> *never* pass when not run via gradle.  Until we fix the underlying issues 
> that require running through gradle, it would be nice for such tests to 
> detect when they are running outside of gradle, and to notify the user that 
> they should be expected to fail.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3048) Tests that require the Gradle test runner should fail descriptively when run through Intellij

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047156#comment-16047156
 ] 

ASF subversion and git services commented on GEODE-3048:


Commit 2c4b53722b43ea654114b9e730bbba4ee0472482 in geode's branch 
refs/heads/develop from [~jstewart]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=2c4b537 ]

GEODE-3048: Introduce a rule to identify tests that require GEODE_HOME


> Tests that require the Gradle test runner should fail descriptively when run 
> through Intellij
> -
>
> Key: GEODE-3048
> URL: https://issues.apache.org/jira/browse/GEODE-3048
> Project: Geode
>  Issue Type: Bug
>  Components: management, tests
>Reporter: Jared Stewart
>Assignee: Jared Stewart
>
> We have some tests the only pass when run through gradle (as opposed to 
> running via the Intellij test runner).  If one of these tests fails in CI, it 
> is easy to being debugging them in the IDE without realizing that they will 
> *never* pass when not run via gradle.  Until we fix the underlying issues 
> that require running through gradle, it would be nice for such tests to 
> detect when they are running outside of gradle, and to notify the user that 
> they should be expected to fail.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)