[jira] [Commented] (GEODE-7237) CI failure: ConnectCommandAcceptanceTest.invalidHostname
[
https://issues.apache.org/jira/browse/GEODE-7237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16954834#comment-16954834
]
ASF subversion and git services commented on GEODE-7237:
Commit ee790035d6ab1239f6cc10759f3faf7b9d2408eb in geode's branch
refs/heads/develop from Aaron Lindsey
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=ee79003 ]
GEODE-7237: Fix race condition in GfshRule (#4153)
GfshRule.execute() now blocks while the ProcessLogger is still
collecting output from the GFSH process. This fixes a race condition
that causes ConnectCommandAcceptanceTest.invalidHostname() to fail
intermittently.
Co-authored-by: Aaron Lindsey
Co-authored-by: Kirk Lund
> CI failure: ConnectCommandAcceptanceTest.invalidHostname
>
>
> Key: GEODE-7237
> URL: https://issues.apache.org/jira/browse/GEODE-7237
> Project: Geode
> Issue Type: Bug
> Components: ci, tests
>Reporter: Aaron Lindsey
>Assignee: Aaron Lindsey
>Priority: Major
> Fix For: 1.11.0
>
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> [https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/AcceptanceTestOpenJDK8/builds/1101]
> {code:java}
> org.apache.geode.management.internal.cli.commands.ConnectCommandAcceptanceTest
> > invalidHostname FAILED
> java.lang.AssertionError:
> Expecting:
> <"">
> to contain:
> <"can't be reached. Hostname or IP address could not be found.">
> at
> org.apache.geode.management.internal.cli.commands.ConnectCommandAcceptanceTest.invalidHostname(ConnectCommandAcceptanceTest.java:59)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-7237) CI failure: ConnectCommandAcceptanceTest.invalidHostname
[
https://issues.apache.org/jira/browse/GEODE-7237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949829#comment-16949829
]
ASF subversion and git services commented on GEODE-7237:
Commit 924e3f8948352dca8e2cdfd49a8b96a524af8b13 in geode's branch
refs/heads/develop from Kirk Lund
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=924e3f8 ]
GEODE-7237: Disable invalidHostname temporarily
Revert this when GEODE-7237 is fixed.
> CI failure: ConnectCommandAcceptanceTest.invalidHostname
>
>
> Key: GEODE-7237
> URL: https://issues.apache.org/jira/browse/GEODE-7237
> Project: Geode
> Issue Type: Bug
> Components: ci, tests
>Reporter: Aaron Lindsey
>Assignee: Kirk Lund
>Priority: Major
> Fix For: 1.11.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> [https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/AcceptanceTestOpenJDK8/builds/1101]
> {code:java}
> org.apache.geode.management.internal.cli.commands.ConnectCommandAcceptanceTest
> > invalidHostname FAILED
> java.lang.AssertionError:
> Expecting:
> <"">
> to contain:
> <"can't be reached. Hostname or IP address could not be found.">
> at
> org.apache.geode.management.internal.cli.commands.ConnectCommandAcceptanceTest.invalidHostname(ConnectCommandAcceptanceTest.java:59)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-7237) CI failure: ConnectCommandAcceptanceTest.invalidHostname
[
https://issues.apache.org/jira/browse/GEODE-7237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949830#comment-16949830
]
ASF subversion and git services commented on GEODE-7237:
Commit 924e3f8948352dca8e2cdfd49a8b96a524af8b13 in geode's branch
refs/heads/develop from Kirk Lund
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=924e3f8 ]
GEODE-7237: Disable invalidHostname temporarily
Revert this when GEODE-7237 is fixed.
> CI failure: ConnectCommandAcceptanceTest.invalidHostname
>
>
> Key: GEODE-7237
> URL: https://issues.apache.org/jira/browse/GEODE-7237
> Project: Geode
> Issue Type: Bug
> Components: ci, tests
>Reporter: Aaron Lindsey
>Assignee: Kirk Lund
>Priority: Major
> Fix For: 1.11.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> [https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/AcceptanceTestOpenJDK8/builds/1101]
> {code:java}
> org.apache.geode.management.internal.cli.commands.ConnectCommandAcceptanceTest
> > invalidHostname FAILED
> java.lang.AssertionError:
> Expecting:
> <"">
> to contain:
> <"can't be reached. Hostname or IP address could not be found.">
> at
> org.apache.geode.management.internal.cli.commands.ConnectCommandAcceptanceTest.invalidHostname(ConnectCommandAcceptanceTest.java:59)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-7237) CI failure: ConnectCommandAcceptanceTest.invalidHostname
[
https://issues.apache.org/jira/browse/GEODE-7237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949679#comment-16949679
]
Aaron Lindsey commented on GEODE-7237:
--
Failed again:
https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/AcceptanceTestOpenJDK8/builds/1147
> CI failure: ConnectCommandAcceptanceTest.invalidHostname
>
>
> Key: GEODE-7237
> URL: https://issues.apache.org/jira/browse/GEODE-7237
> Project: Geode
> Issue Type: Bug
> Components: ci, tests
>Reporter: Aaron Lindsey
>Assignee: Kirk Lund
>Priority: Major
> Fix For: 1.11.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> [https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/AcceptanceTestOpenJDK8/builds/1101]
> {code:java}
> org.apache.geode.management.internal.cli.commands.ConnectCommandAcceptanceTest
> > invalidHostname FAILED
> java.lang.AssertionError:
> Expecting:
> <"">
> to contain:
> <"can't be reached. Hostname or IP address could not be found.">
> at
> org.apache.geode.management.internal.cli.commands.ConnectCommandAcceptanceTest.invalidHostname(ConnectCommandAcceptanceTest.java:59)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-7237) CI failure: ConnectCommandAcceptanceTest.invalidHostname
[
https://issues.apache.org/jira/browse/GEODE-7237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949609#comment-16949609
]
ASF subversion and git services commented on GEODE-7237:
Commit 3686b4358eb088ab8e9a8a498bbcd14729a838b9 in geode's branch
refs/heads/feature/GEODE-3780 from Kirk Lund
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=3686b43 ]
GEODE-7237: Use invalid host name in ConnectCommandAcceptanceTest (#4128)
The test invalidHostname continues to fail intermittently. In the
failure, something fails to throw UnknownHostException. Having
spaces in the "invalid host name" should guarantee that it always
throws UnknownHostException now.
Also, remove the double negative from the assumeTrue by flipping it
to assumeFalse. Move the comment into the assumeFalse as a message.
> CI failure: ConnectCommandAcceptanceTest.invalidHostname
>
>
> Key: GEODE-7237
> URL: https://issues.apache.org/jira/browse/GEODE-7237
> Project: Geode
> Issue Type: Bug
> Components: ci, tests
>Reporter: Aaron Lindsey
>Assignee: Kirk Lund
>Priority: Major
> Fix For: 1.11.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> [https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/AcceptanceTestOpenJDK8/builds/1101]
> {code:java}
> org.apache.geode.management.internal.cli.commands.ConnectCommandAcceptanceTest
> > invalidHostname FAILED
> java.lang.AssertionError:
> Expecting:
> <"">
> to contain:
> <"can't be reached. Hostname or IP address could not be found.">
> at
> org.apache.geode.management.internal.cli.commands.ConnectCommandAcceptanceTest.invalidHostname(ConnectCommandAcceptanceTest.java:59)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-7237) CI failure: ConnectCommandAcceptanceTest.invalidHostname
[
https://issues.apache.org/jira/browse/GEODE-7237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16948844#comment-16948844
]
Aaron Lindsey commented on GEODE-7237:
--
Failed again:
https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/AcceptanceTestOpenJDK8/builds/1146
> CI failure: ConnectCommandAcceptanceTest.invalidHostname
>
>
> Key: GEODE-7237
> URL: https://issues.apache.org/jira/browse/GEODE-7237
> Project: Geode
> Issue Type: Bug
> Components: ci, tests
>Reporter: Aaron Lindsey
>Assignee: Kirk Lund
>Priority: Major
> Fix For: 1.11.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> [https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/AcceptanceTestOpenJDK8/builds/1101]
> {code:java}
> org.apache.geode.management.internal.cli.commands.ConnectCommandAcceptanceTest
> > invalidHostname FAILED
> java.lang.AssertionError:
> Expecting:
> <"">
> to contain:
> <"can't be reached. Hostname or IP address could not be found.">
> at
> org.apache.geode.management.internal.cli.commands.ConnectCommandAcceptanceTest.invalidHostname(ConnectCommandAcceptanceTest.java:59)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-7237) CI failure: ConnectCommandAcceptanceTest.invalidHostname
[
https://issues.apache.org/jira/browse/GEODE-7237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946324#comment-16946324
]
ASF subversion and git services commented on GEODE-7237:
Commit 3686b4358eb088ab8e9a8a498bbcd14729a838b9 in geode's branch
refs/heads/develop from Kirk Lund
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=3686b43 ]
GEODE-7237: Use invalid host name in ConnectCommandAcceptanceTest (#4128)
The test invalidHostname continues to fail intermittently. In the
failure, something fails to throw UnknownHostException. Having
spaces in the "invalid host name" should guarantee that it always
throws UnknownHostException now.
Also, remove the double negative from the assumeTrue by flipping it
to assumeFalse. Move the comment into the assumeFalse as a message.
> CI failure: ConnectCommandAcceptanceTest.invalidHostname
>
>
> Key: GEODE-7237
> URL: https://issues.apache.org/jira/browse/GEODE-7237
> Project: Geode
> Issue Type: Bug
> Components: ci, tests
>Reporter: Aaron Lindsey
>Assignee: Kirk Lund
>Priority: Major
> Fix For: 1.11.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> [https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/AcceptanceTestOpenJDK8/builds/1101]
> {code:java}
> org.apache.geode.management.internal.cli.commands.ConnectCommandAcceptanceTest
> > invalidHostname FAILED
> java.lang.AssertionError:
> Expecting:
> <"">
> to contain:
> <"can't be reached. Hostname or IP address could not be found.">
> at
> org.apache.geode.management.internal.cli.commands.ConnectCommandAcceptanceTest.invalidHostname(ConnectCommandAcceptanceTest.java:59)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-7237) CI failure: ConnectCommandAcceptanceTest.invalidHostname
[
https://issues.apache.org/jira/browse/GEODE-7237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16938032#comment-16938032
]
ASF subversion and git services commented on GEODE-7237:
Commit 3efb71d8a5eedb0c70d9fbe7d77b2872b1dce5cb in geode's branch
refs/heads/develop from Kirk Lund
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=3efb71d ]
GEODE-7237: Remove log4j-core manipulation from GfshRule (#4089)
Creation of geode-log4j widened a race condition in GfshRule in which
the process being forked would start printing output before the
ProcessLogger had been created and started in order to intercept that
output.
The widening of that race condition resulted in CI failures of
ConnectCommandAcceptanceTest.
ProcessLogger does not appear to have any real need for manipulating
log4j-core which is what widens the race condition far enough to fail
in CI.
Removing the manipulation of log4j-core from ProcessLogger reduces
the race condition for consistent passing. The window itself is still
there but without resorting to something like MainLauncher [1], there's
no way to completely close the window.
[1] geode-junit: org.apache.geode.test.process.MainLauncher
If ConnectCommandAcceptanceTest or other tests using GfshRule fail
after this commit, then we'll need to use something like MainLauncher.
> CI failure: ConnectCommandAcceptanceTest.invalidHostname
>
>
> Key: GEODE-7237
> URL: https://issues.apache.org/jira/browse/GEODE-7237
> Project: Geode
> Issue Type: Bug
> Components: ci, tests
>Reporter: Aaron Lindsey
>Assignee: Kirk Lund
>Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> [https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/AcceptanceTestOpenJDK8/builds/1101]
> {code:java}
> org.apache.geode.management.internal.cli.commands.ConnectCommandAcceptanceTest
> > invalidHostname FAILED
> java.lang.AssertionError:
> Expecting:
> <"">
> to contain:
> <"can't be reached. Hostname or IP address could not be found.">
> at
> org.apache.geode.management.internal.cli.commands.ConnectCommandAcceptanceTest.invalidHostname(ConnectCommandAcceptanceTest.java:59)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-7237) CI failure: ConnectCommandAcceptanceTest.invalidHostname
[
https://issues.apache.org/jira/browse/GEODE-7237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16937165#comment-16937165
]
Kirk Lund commented on GEODE-7237:
--
This is caused by a race condition in the implementation of GfshRule. After
forking the process, ProcessLogger is created to read the output from that
process. ProcessLogger uses log4j-core to reconfigure logging. Meanwhile, the
process may have already started printing output which has been missed which
causes the assertion in this bug to fail.
I cannot find any good reason for ProcessLogger to actually need to use
log4j-core to reconfigure logging. If I change it to just grab a logger without
reconfiguring log4j, the test runs must faster and passes consistently.
> CI failure: ConnectCommandAcceptanceTest.invalidHostname
>
>
> Key: GEODE-7237
> URL: https://issues.apache.org/jira/browse/GEODE-7237
> Project: Geode
> Issue Type: Bug
> Components: ci, tests
>Reporter: Aaron Lindsey
>Assignee: Kirk Lund
>Priority: Major
>
> [https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/AcceptanceTestOpenJDK8/builds/1101]
> {code:java}
> org.apache.geode.management.internal.cli.commands.ConnectCommandAcceptanceTest
> > invalidHostname FAILED
> java.lang.AssertionError:
> Expecting:
> <"">
> to contain:
> <"can't be reached. Hostname or IP address could not be found.">
> at
> org.apache.geode.management.internal.cli.commands.ConnectCommandAcceptanceTest.invalidHostname(ConnectCommandAcceptanceTest.java:59)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
