[jira] [Commented] (GEODE-8112) Need to add a member option in query command
[ https://issues.apache.org/jira/browse/GEODE-8112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114165#comment-17114165 ] ASF subversion and git services commented on GEODE-8112: Commit d08847baebcd2c975941be4641e8db2b7612ab6b in geode's branch refs/heads/feature/GEODE-8067 from Eric Shu [ https://gitbox.apache.org/repos/asf?p=geode.git;h=d08847b ] GEODE-8112: Add --member option in query command. (#5102) > Need to add a member option in query command > > > Key: GEODE-8112 > URL: https://issues.apache.org/jira/browse/GEODE-8112 > Project: Geode > Issue Type: Bug > Components: gfsh, querying >Reporter: Eric Shu >Assignee: Eric Shu >Priority: Major > Labels: caching-applications > Fix For: 1.14.0 > > > When gfsh query running on replicate proxy region, it will return 0 results > as no data stored on the proxy region. > To help solving this issue, gfsh querying can add a member option so that > query can route to a particular data host member to get the needed results. > User can use "describe region" to find out which data host, then use it in > the query. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8112) Need to add a member option in query command
[ https://issues.apache.org/jira/browse/GEODE-8112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114154#comment-17114154 ] ASF subversion and git services commented on GEODE-8112: Commit d08847baebcd2c975941be4641e8db2b7612ab6b in geode's branch refs/heads/feature/GEODE-8067 from Eric Shu [ https://gitbox.apache.org/repos/asf?p=geode.git;h=d08847b ] GEODE-8112: Add --member option in query command. (#5102) > Need to add a member option in query command > > > Key: GEODE-8112 > URL: https://issues.apache.org/jira/browse/GEODE-8112 > Project: Geode > Issue Type: Bug > Components: gfsh, querying >Reporter: Eric Shu >Assignee: Eric Shu >Priority: Major > Labels: caching-applications > Fix For: 1.14.0 > > > When gfsh query running on replicate proxy region, it will return 0 results > as no data stored on the proxy region. > To help solving this issue, gfsh querying can add a member option so that > query can route to a particular data host member to get the needed results. > User can use "describe region" to find out which data host, then use it in > the query. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8112) Need to add a member option in query command
[ https://issues.apache.org/jira/browse/GEODE-8112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17113340#comment-17113340 ] ASF subversion and git services commented on GEODE-8112: Commit d08847baebcd2c975941be4641e8db2b7612ab6b in geode's branch refs/heads/develop from Eric Shu [ https://gitbox.apache.org/repos/asf?p=geode.git;h=d08847b ] GEODE-8112: Add --member option in query command. (#5102) > Need to add a member option in query command > > > Key: GEODE-8112 > URL: https://issues.apache.org/jira/browse/GEODE-8112 > Project: Geode > Issue Type: Bug > Components: gfsh, querying >Reporter: Eric Shu >Assignee: Eric Shu >Priority: Major > Labels: caching-applications > > When gfsh query running on replicate proxy region, it will return 0 results > as no data stored on the proxy region. > To help solving this issue, gfsh querying can add a member option so that > query can route to a particular data host member to get the needed results. > User can use "describe region" to find out which data host, then use it in > the query. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8112) Need to add a member option in query command
[ https://issues.apache.org/jira/browse/GEODE-8112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17113339#comment-17113339 ] ASF GitHub Bot commented on GEODE-8112: --- pivotal-eshu merged pull request #5102: URL: https://github.com/apache/geode/pull/5102 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Need to add a member option in query command > > > Key: GEODE-8112 > URL: https://issues.apache.org/jira/browse/GEODE-8112 > Project: Geode > Issue Type: Bug > Components: gfsh, querying >Reporter: Eric Shu >Assignee: Eric Shu >Priority: Major > Labels: caching-applications > > When gfsh query running on replicate proxy region, it will return 0 results > as no data stored on the proxy region. > To help solving this issue, gfsh querying can add a member option so that > query can route to a particular data host member to get the needed results. > User can use "describe region" to find out which data host, then use it in > the query. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8112) Need to add a member option in query command
[
https://issues.apache.org/jira/browse/GEODE-8112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17112465#comment-17112465
]
ASF GitHub Bot commented on GEODE-8112:
---
DonalEvans commented on a change in pull request #5102:
URL: https://github.com/apache/geode/pull/5102#discussion_r428183715
##
File path:
geode-dunit/src/main/java/org/apache/geode/management/internal/cli/commands/QueryCommandDUnitTestBase.java
##
@@ -332,31 +333,18 @@ public void testSimpleQueryWithProxyRegion() {
server1.invoke(() ->
prepareDataForRegion(DATA_REGION_WITH_PROXY_NAME_PATH));
-String member = getHostingMember();
+String member = "server-2";
Random random = new Random(System.nanoTime());
int randomInteger = random.nextInt(COUNT);
-String query = "query --member=" + member
-+ " --query=\"select ID , status , createTime , pk, floatMinValue from
"
-+ DATA_REGION_WITH_PROXY_NAME_PATH + " where ID <= " + randomInteger
-+ "\" --interactive=false";
-
-CommandResult commandResult = gfsh.executeCommand(query);
+StringBuilder queryString = new StringBuilder();
Review comment:
I think there was some confusion about my original review comment. I
meant to use the Geode `CommandStringBuilder` class, not the Java
`StringBuilder`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Need to add a member option in query command
>
>
> Key: GEODE-8112
> URL: https://issues.apache.org/jira/browse/GEODE-8112
> Project: Geode
> Issue Type: Bug
> Components: gfsh, querying
>Reporter: Eric Shu
>Assignee: Eric Shu
>Priority: Major
> Labels: caching-applications
>
> When gfsh query running on replicate proxy region, it will return 0 results
> as no data stored on the proxy region.
> To help solving this issue, gfsh querying can add a member option so that
> query can route to a particular data host member to get the needed results.
> User can use "describe region" to find out which data host, then use it in
> the query.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8112) Need to add a member option in query command
[
https://issues.apache.org/jira/browse/GEODE-8112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17112452#comment-17112452
]
ASF GitHub Bot commented on GEODE-8112:
---
pivotal-eshu commented on a change in pull request #5102:
URL: https://github.com/apache/geode/pull/5102#discussion_r428172327
##
File path:
geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/QueryCommand.java
##
@@ -60,12 +60,17 @@ public ResultModel query(
@CliOption(key = "file", help = "File in which to output the results.",
optionContext = ConverterHint.FILE) final File outputFile,
@CliOption(key = CliStrings.QUERY__INTERACTIVE, unspecifiedDefaultValue
= "false",
- help = CliStrings.QUERY__INTERACTIVE__HELP) final boolean
interactive) {
-DataCommandResult dataResult = select(query);
+ help = CliStrings.QUERY__INTERACTIVE__HELP) final boolean
interactive,
+ @CliOption(key = CliStrings.MEMBER,
+ optionContext = ConverterHint.MEMBERIDNAME,
+ help = CliStrings.QUERY__MEMBER__HELP) final String memberNameOrId) {
Review comment:
Thanks Dave for helping on the docs.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Need to add a member option in query command
>
>
> Key: GEODE-8112
> URL: https://issues.apache.org/jira/browse/GEODE-8112
> Project: Geode
> Issue Type: Bug
> Components: gfsh, querying
>Reporter: Eric Shu
>Assignee: Eric Shu
>Priority: Major
> Labels: caching-applications
>
> When gfsh query running on replicate proxy region, it will return 0 results
> as no data stored on the proxy region.
> To help solving this issue, gfsh querying can add a member option so that
> query can route to a particular data host member to get the needed results.
> User can use "describe region" to find out which data host, then use it in
> the query.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8112) Need to add a member option in query command
[
https://issues.apache.org/jira/browse/GEODE-8112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17112453#comment-17112453
]
ASF GitHub Bot commented on GEODE-8112:
---
pivotal-eshu commented on a change in pull request #5102:
URL: https://github.com/apache/geode/pull/5102#discussion_r428172456
##
File path:
geode-dunit/src/main/java/org/apache/geode/management/internal/cli/commands/QueryCommandDUnitTestBase.java
##
@@ -256,6 +260,15 @@ private static void setupReplicatedRegion(String
regionName) {
assertThat(dataRegion.getFullPath()).contains(regionName);
}
+ private static void setupReplicatedProxyRegion(String regionName) {
+InternalCache cache = ClusterStartupRule.getCache();
+RegionFactory regionFactory =
cache.createRegionFactory(RegionShortcut.REPLICATE_PROXY);
+
+Region proxyRegion = regionFactory.create(regionName);
+assertThat(proxyRegion).isNotNull();
+assertThat(proxyRegion.getFullPath()).contains(regionName);
+ }
+
Review comment:
Fixed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Need to add a member option in query command
>
>
> Key: GEODE-8112
> URL: https://issues.apache.org/jira/browse/GEODE-8112
> Project: Geode
> Issue Type: Bug
> Components: gfsh, querying
>Reporter: Eric Shu
>Assignee: Eric Shu
>Priority: Major
> Labels: caching-applications
>
> When gfsh query running on replicate proxy region, it will return 0 results
> as no data stored on the proxy region.
> To help solving this issue, gfsh querying can add a member option so that
> query can route to a particular data host member to get the needed results.
> User can use "describe region" to find out which data host, then use it in
> the query.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8112) Need to add a member option in query command
[
https://issues.apache.org/jira/browse/GEODE-8112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17112451#comment-17112451
]
ASF GitHub Bot commented on GEODE-8112:
---
pivotal-eshu commented on a change in pull request #5102:
URL: https://github.com/apache/geode/pull/5102#discussion_r428171595
##
File path:
geode-dunit/src/main/java/org/apache/geode/management/internal/cli/commands/QueryCommandDUnitTestBase.java
##
@@ -310,4 +323,40 @@ public void setValue1(Value1 value1) {
this.value1 = value1;
}
}
+
+ @Test
+ public void testSimpleQueryWithProxyRegion() {
+server1.invoke(() ->
setupReplicatedProxyRegion(DATA_REGION_WITH_PROXY_NAME));
+server2.invoke(() -> setupReplicatedRegion(DATA_REGION_WITH_PROXY_NAME));
+
locator.waitUntilRegionIsReadyOnExactlyThisManyServers(DATA_REGION_WITH_PROXY_NAME_PATH,
2);
+
+server1.invoke(() ->
prepareDataForRegion(DATA_REGION_WITH_PROXY_NAME_PATH));
+
+String member = getHostingMember();
+Random random = new Random(System.nanoTime());
+int randomInteger = random.nextInt(COUNT);
+String query = "query --member=" + member
++ " --query=\"select ID , status , createTime , pk, floatMinValue from
"
++ DATA_REGION_WITH_PROXY_NAME_PATH + " where ID <= " + randomInteger
++ "\" --interactive=false";
+
+CommandResult commandResult = gfsh.executeCommand(query);
+validateSelectResult(commandResult, true, (randomInteger + 1),
+new String[] {"ID", "status", "createTime", "pk", "floatMinValue"});
+ }
+
+ private String getHostingMember() {
+String hostingMember = null;
+String findMemberCommand = "describe region --name=" +
DATA_REGION_WITH_PROXY_NAME;
+CommandResult findMemberResult = gfsh.executeCommand(findMemberCommand);
Review comment:
Fixed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Need to add a member option in query command
>
>
> Key: GEODE-8112
> URL: https://issues.apache.org/jira/browse/GEODE-8112
> Project: Geode
> Issue Type: Bug
> Components: gfsh, querying
>Reporter: Eric Shu
>Assignee: Eric Shu
>Priority: Major
> Labels: caching-applications
>
> When gfsh query running on replicate proxy region, it will return 0 results
> as no data stored on the proxy region.
> To help solving this issue, gfsh querying can add a member option so that
> query can route to a particular data host member to get the needed results.
> User can use "describe region" to find out which data host, then use it in
> the query.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8112) Need to add a member option in query command
[ https://issues.apache.org/jira/browse/GEODE-8112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17112344#comment-17112344 ] ASF GitHub Bot commented on GEODE-8112: --- davebarnes97 commented on pull request #5102: URL: https://github.com/apache/geode/pull/5102#issuecomment-631542172 Update to the gfsh query command documentation has been pushed. Should we also add something about intended usage in the Developing -> Querying section of the User Guide? For example, “Querying a Partitioned Region on a Single Node”, https://geode.apache.org/docs/guide/112/developing/query_additional/query_on_a_single_node.html#concept_30B18A6507534993BD55C2C9E0544A97 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Need to add a member option in query command > > > Key: GEODE-8112 > URL: https://issues.apache.org/jira/browse/GEODE-8112 > Project: Geode > Issue Type: Bug > Components: gfsh, querying >Reporter: Eric Shu >Assignee: Eric Shu >Priority: Major > Labels: caching-applications > > When gfsh query running on replicate proxy region, it will return 0 results > as no data stored on the proxy region. > To help solving this issue, gfsh querying can add a member option so that > query can route to a particular data host member to get the needed results. > User can use "describe region" to find out which data host, then use it in > the query. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8112) Need to add a member option in query command
[ https://issues.apache.org/jira/browse/GEODE-8112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17112300#comment-17112300 ] ASF subversion and git services commented on GEODE-8112: Commit 5b7ea1a49f1d630e0ffe552e9e48ac145b6b in geode's branch refs/heads/feature/GEODE-8112 from Eric Shu [ https://gitbox.apache.org/repos/asf?p=geode.git;h=5b7ea1a ] GEODE-8112: Add --member option in query command. > Need to add a member option in query command > > > Key: GEODE-8112 > URL: https://issues.apache.org/jira/browse/GEODE-8112 > Project: Geode > Issue Type: Bug > Components: gfsh, querying >Reporter: Eric Shu >Assignee: Eric Shu >Priority: Major > Labels: caching-applications > > When gfsh query running on replicate proxy region, it will return 0 results > as no data stored on the proxy region. > To help solving this issue, gfsh querying can add a member option so that > query can route to a particular data host member to get the needed results. > User can use "describe region" to find out which data host, then use it in > the query. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8112) Need to add a member option in query command
[
https://issues.apache.org/jira/browse/GEODE-8112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17109284#comment-17109284
]
ASF GitHub Bot commented on GEODE-8112:
---
jinmeiliao commented on a change in pull request #5102:
URL: https://github.com/apache/geode/pull/5102#discussion_r426211284
##
File path:
geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/QueryCommand.java
##
@@ -60,12 +60,17 @@ public ResultModel query(
@CliOption(key = "file", help = "File in which to output the results.",
optionContext = ConverterHint.FILE) final File outputFile,
@CliOption(key = CliStrings.QUERY__INTERACTIVE, unspecifiedDefaultValue
= "false",
- help = CliStrings.QUERY__INTERACTIVE__HELP) final boolean
interactive) {
-DataCommandResult dataResult = select(query);
+ help = CliStrings.QUERY__INTERACTIVE__HELP) final boolean
interactive,
+ @CliOption(key = CliStrings.MEMBER,
+ optionContext = ConverterHint.MEMBERIDNAME,
+ help = CliStrings.QUERY__MEMBER__HELP) final String memberNameOrId) {
Review comment:
`--step-name` and `--interactive` can be removed in the docs since they
are not used by the command anymore, but they can NOT be removed in the option
list for backward compatibility reasons (user with old scripts might break).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Need to add a member option in query command
>
>
> Key: GEODE-8112
> URL: https://issues.apache.org/jira/browse/GEODE-8112
> Project: Geode
> Issue Type: Bug
> Components: gfsh, querying
>Reporter: Eric Shu
>Assignee: Eric Shu
>Priority: Major
> Labels: caching-applications
>
> When gfsh query running on replicate proxy region, it will return 0 results
> as no data stored on the proxy region.
> To help solving this issue, gfsh querying can add a member option so that
> query can route to a particular data host member to get the needed results.
> User can use "describe region" to find out which data host, then use it in
> the query.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8112) Need to add a member option in query command
[
https://issues.apache.org/jira/browse/GEODE-8112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108668#comment-17108668
]
ASF GitHub Bot commented on GEODE-8112:
---
DonalEvans commented on a change in pull request #5102:
URL: https://github.com/apache/geode/pull/5102#discussion_r426051856
##
File path:
geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/QueryCommand.java
##
@@ -60,12 +60,17 @@ public ResultModel query(
@CliOption(key = "file", help = "File in which to output the results.",
optionContext = ConverterHint.FILE) final File outputFile,
@CliOption(key = CliStrings.QUERY__INTERACTIVE, unspecifiedDefaultValue
= "false",
- help = CliStrings.QUERY__INTERACTIVE__HELP) final boolean
interactive) {
-DataCommandResult dataResult = select(query);
+ help = CliStrings.QUERY__INTERACTIVE__HELP) final boolean
interactive,
+ @CliOption(key = CliStrings.MEMBER,
+ optionContext = ConverterHint.MEMBERIDNAME,
+ help = CliStrings.QUERY__MEMBER__HELP) final String memberNameOrId) {
Review comment:
I talked to Jens about it briefly and the `--file` argument is
definitely used, it just gets picked up by the interceptor on the gfsh command,
not used in the actual command itself. If you try to include the `--step-name`
option, then gfsh throws an error: `Option 'step-name' is not available for
this command.` The "step-name" string only appears in this one place too, with
no other occurrences in the codebase or the docs, so I can't think of a reason
to not remove it here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Need to add a member option in query command
>
>
> Key: GEODE-8112
> URL: https://issues.apache.org/jira/browse/GEODE-8112
> Project: Geode
> Issue Type: Bug
> Components: gfsh, querying
>Reporter: Eric Shu
>Assignee: Eric Shu
>Priority: Major
> Labels: caching-applications
>
> When gfsh query running on replicate proxy region, it will return 0 results
> as no data stored on the proxy region.
> To help solving this issue, gfsh querying can add a member option so that
> query can route to a particular data host member to get the needed results.
> User can use "describe region" to find out which data host, then use it in
> the query.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8112) Need to add a member option in query command
[
https://issues.apache.org/jira/browse/GEODE-8112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108661#comment-17108661
]
ASF GitHub Bot commented on GEODE-8112:
---
davebarnes97 commented on a change in pull request #5102:
URL: https://github.com/apache/geode/pull/5102#discussion_r426045897
##
File path:
geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/QueryCommand.java
##
@@ -60,12 +60,17 @@ public ResultModel query(
@CliOption(key = "file", help = "File in which to output the results.",
optionContext = ConverterHint.FILE) final File outputFile,
@CliOption(key = CliStrings.QUERY__INTERACTIVE, unspecifiedDefaultValue
= "false",
- help = CliStrings.QUERY__INTERACTIVE__HELP) final boolean
interactive) {
-DataCommandResult dataResult = select(query);
+ help = CliStrings.QUERY__INTERACTIVE__HELP) final boolean
interactive,
+ @CliOption(key = CliStrings.MEMBER,
+ optionContext = ConverterHint.MEMBERIDNAME,
+ help = CliStrings.QUERY__MEMBER__HELP) final String memberNameOrId) {
Review comment:
I can add --member=value to the gfsh query command description.
Not sure about removing --step-name and --file. Is it possible those are
present for legacy support (like, they used to be supported in earlier
versions, so need to be kept around?)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Need to add a member option in query command
>
>
> Key: GEODE-8112
> URL: https://issues.apache.org/jira/browse/GEODE-8112
> Project: Geode
> Issue Type: Bug
> Components: gfsh, querying
>Reporter: Eric Shu
>Assignee: Eric Shu
>Priority: Major
> Labels: caching-applications
>
> When gfsh query running on replicate proxy region, it will return 0 results
> as no data stored on the proxy region.
> To help solving this issue, gfsh querying can add a member option so that
> query can route to a particular data host member to get the needed results.
> User can use "describe region" to find out which data host, then use it in
> the query.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8112) Need to add a member option in query command
[
https://issues.apache.org/jira/browse/GEODE-8112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108662#comment-17108662
]
ASF GitHub Bot commented on GEODE-8112:
---
davebarnes97 commented on a change in pull request #5102:
URL: https://github.com/apache/geode/pull/5102#discussion_r426045897
##
File path:
geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/QueryCommand.java
##
@@ -60,12 +60,17 @@ public ResultModel query(
@CliOption(key = "file", help = "File in which to output the results.",
optionContext = ConverterHint.FILE) final File outputFile,
@CliOption(key = CliStrings.QUERY__INTERACTIVE, unspecifiedDefaultValue
= "false",
- help = CliStrings.QUERY__INTERACTIVE__HELP) final boolean
interactive) {
-DataCommandResult dataResult = select(query);
+ help = CliStrings.QUERY__INTERACTIVE__HELP) final boolean
interactive,
+ @CliOption(key = CliStrings.MEMBER,
+ optionContext = ConverterHint.MEMBERIDNAME,
+ help = CliStrings.QUERY__MEMBER__HELP) final String memberNameOrId) {
Review comment:
@DonalEvans I can add --member=value to the gfsh query command
description.
Not sure about removing --step-name and --file. Is it possible those are
present for legacy support (like, they used to be supported in earlier
versions, so need to be kept around?)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Need to add a member option in query command
>
>
> Key: GEODE-8112
> URL: https://issues.apache.org/jira/browse/GEODE-8112
> Project: Geode
> Issue Type: Bug
> Components: gfsh, querying
>Reporter: Eric Shu
>Assignee: Eric Shu
>Priority: Major
> Labels: caching-applications
>
> When gfsh query running on replicate proxy region, it will return 0 results
> as no data stored on the proxy region.
> To help solving this issue, gfsh querying can add a member option so that
> query can route to a particular data host member to get the needed results.
> User can use "describe region" to find out which data host, then use it in
> the query.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8112) Need to add a member option in query command
[
https://issues.apache.org/jira/browse/GEODE-8112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108639#comment-17108639
]
ASF GitHub Bot commented on GEODE-8112:
---
davebarnes97 commented on a change in pull request #5102:
URL: https://github.com/apache/geode/pull/5102#discussion_r426033111
##
File path:
geode-core/src/main/java/org/apache/geode/management/internal/i18n/CliStrings.java
##
@@ -1823,6 +1823,8 @@
"Cannot find regions <{0}> in any of the members";
public static final String QUERY__MSG__NOT_SUPPORTED_ON_MEMBERS =
CliStrings.QUERY
+ " command should be used only from shell. Use QueryService API for
running query inside Geode VMs";
+ public static final String QUERY__MEMBER__HELP =
+ "Name/Id of a member which hosts the regions to be queried.";
Review comment:
+1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Need to add a member option in query command
>
>
> Key: GEODE-8112
> URL: https://issues.apache.org/jira/browse/GEODE-8112
> Project: Geode
> Issue Type: Bug
> Components: gfsh, querying
>Reporter: Eric Shu
>Assignee: Eric Shu
>Priority: Major
> Labels: caching-applications
>
> When gfsh query running on replicate proxy region, it will return 0 results
> as no data stored on the proxy region.
> To help solving this issue, gfsh querying can add a member option so that
> query can route to a particular data host member to get the needed results.
> User can use "describe region" to find out which data host, then use it in
> the query.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8112) Need to add a member option in query command
[ https://issues.apache.org/jira/browse/GEODE-8112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17105758#comment-17105758 ] ASF subversion and git services commented on GEODE-8112: Commit a75125115eaef071d0b537b40c69425aaca5e653 in geode's branch refs/heads/feature/GEODE-8112 from Eric Shu [ https://gitbox.apache.org/repos/asf?p=geode.git;h=a751251 ] GEODE-8112: Add --member option in query command. > Need to add a member option in query command > > > Key: GEODE-8112 > URL: https://issues.apache.org/jira/browse/GEODE-8112 > Project: Geode > Issue Type: Bug > Components: gfsh, querying >Reporter: Eric Shu >Assignee: Eric Shu >Priority: Major > Labels: caching-applications > > When gfsh query running on replicate proxy region, it will return 0 results > as no data stored on the proxy region. > To help solving this issue, gfsh querying can add a member option so that > query can route to a particular data host member to get the needed results. > User can use "describe region" to find out which data host, then use it in > the query. -- This message was sent by Atlassian Jira (v8.3.4#803005)
