[jira] [Commented] (GEODE-8181) C++ client defaults statistic-sampling-enabled to true
[
https://issues.apache.org/jira/browse/GEODE-8181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17123988#comment-17123988
]
ASF subversion and git services commented on GEODE-8181:
Commit c19087dfee444d12b5509641693294129a625c6b in geode-native's branch
refs/heads/develop from Jacob Barrett
[ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=c19087d ]
GEODE-8181: Fixes default value for statistic-sampling-enabled. (#606)
> C++ client defaults statistic-sampling-enabled to true
> --
>
> Key: GEODE-8181
> URL: https://issues.apache.org/jira/browse/GEODE-8181
> Project: Geode
> Issue Type: Bug
>Reporter: Jacob Barrett
>Assignee: Jacob Barrett
>Priority: Major
>
> The Geode documentation, Java client and server all say the default value is
> {{false}} but the C++ client library sets the default to {{true}}. This
> causes files to be generated when it is not expected. It can cause failures
> were writing to the current working directory is not allowed. Causes file
> access violations if two caches are created in the same process space without
> setting unique files or explicitly disabling.
> https://geode.apache.org/docs/guide/12/reference/topics/gemfire_properties.html
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8181) C++ client defaults statistic-sampling-enabled to true
[
https://issues.apache.org/jira/browse/GEODE-8181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17123989#comment-17123989
]
ASF GitHub Bot commented on GEODE-8181:
---
pivotal-jbarrett merged pull request #606:
URL: https://github.com/apache/geode-native/pull/606
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> C++ client defaults statistic-sampling-enabled to true
> --
>
> Key: GEODE-8181
> URL: https://issues.apache.org/jira/browse/GEODE-8181
> Project: Geode
> Issue Type: Bug
>Reporter: Jacob Barrett
>Assignee: Jacob Barrett
>Priority: Major
>
> The Geode documentation, Java client and server all say the default value is
> {{false}} but the C++ client library sets the default to {{true}}. This
> causes files to be generated when it is not expected. It can cause failures
> were writing to the current working directory is not allowed. Causes file
> access violations if two caches are created in the same process space without
> setting unique files or explicitly disabling.
> https://geode.apache.org/docs/guide/12/reference/topics/gemfire_properties.html
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8181) C++ client defaults statistic-sampling-enabled to true
[
https://issues.apache.org/jira/browse/GEODE-8181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118819#comment-17118819
]
ASF GitHub Bot commented on GEODE-8181:
---
pivotal-jbarrett commented on a change in pull request #606:
URL: https://github.com/apache/geode-native/pull/606#discussion_r431922763
##
File path: cppcache/integration-test/resources/system.properties
##
@@ -14,7 +14,7 @@
# limitations under the License.
# All the configurable parameters.
statistic-sample-rate=700s
-statistic-sampling-enabled=false
+statistic-sampling-enabled=true
Review comment:
Yeah, when I need more time in C++ again after ACE is gone...
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> C++ client defaults statistic-sampling-enabled to true
> --
>
> Key: GEODE-8181
> URL: https://issues.apache.org/jira/browse/GEODE-8181
> Project: Geode
> Issue Type: Bug
>Reporter: Jacob Barrett
>Assignee: Jacob Barrett
>Priority: Major
>
> The Geode documentation, Java client and server all say the default value is
> {{false}} but the C++ client library sets the default to {{true}}. This
> causes files to be generated when it is not expected. It can cause failures
> were writing to the current working directory is not allowed. Causes file
> access violations if two caches are created in the same process space without
> setting unique files or explicitly disabling.
> https://geode.apache.org/docs/guide/12/reference/topics/gemfire_properties.html
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8181) C++ client defaults statistic-sampling-enabled to true
[
https://issues.apache.org/jira/browse/GEODE-8181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118807#comment-17118807
]
ASF GitHub Bot commented on GEODE-8181:
---
pdxcodemonkey commented on a change in pull request #606:
URL: https://github.com/apache/geode-native/pull/606#discussion_r431915373
##
File path: cppcache/integration-test/resources/system.properties
##
@@ -14,7 +14,7 @@
# limitations under the License.
# All the configurable parameters.
statistic-sample-rate=700s
-statistic-sampling-enabled=false
+statistic-sampling-enabled=true
Review comment:
Ugh. I'd ask that we rename this file to reflect that it's
test-case-specific, but I think time is better spent just getting rid of the
old tests in general. Thanks for the clarification.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> C++ client defaults statistic-sampling-enabled to true
> --
>
> Key: GEODE-8181
> URL: https://issues.apache.org/jira/browse/GEODE-8181
> Project: Geode
> Issue Type: Bug
>Reporter: Jacob Barrett
>Assignee: Jacob Barrett
>Priority: Major
>
> The Geode documentation, Java client and server all say the default value is
> {{false}} but the C++ client library sets the default to {{true}}. This
> causes files to be generated when it is not expected. It can cause failures
> were writing to the current working directory is not allowed. Causes file
> access violations if two caches are created in the same process space without
> setting unique files or explicitly disabling.
> https://geode.apache.org/docs/guide/12/reference/topics/gemfire_properties.html
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8181) C++ client defaults statistic-sampling-enabled to true
[
https://issues.apache.org/jira/browse/GEODE-8181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118798#comment-17118798
]
ASF GitHub Bot commented on GEODE-8181:
---
pivotal-jbarrett commented on a change in pull request #606:
URL: https://github.com/apache/geode-native/pull/606#discussion_r431913457
##
File path: cppcache/integration-test/resources/system.properties
##
@@ -14,7 +14,7 @@
# limitations under the License.
# All the configurable parameters.
statistic-sample-rate=700s
-statistic-sampling-enabled=false
+statistic-sampling-enabled=true
Review comment:
No it’s used by a single integration test.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> C++ client defaults statistic-sampling-enabled to true
> --
>
> Key: GEODE-8181
> URL: https://issues.apache.org/jira/browse/GEODE-8181
> Project: Geode
> Issue Type: Bug
>Reporter: Jacob Barrett
>Assignee: Jacob Barrett
>Priority: Major
>
> The Geode documentation, Java client and server all say the default value is
> {{false}} but the C++ client library sets the default to {{true}}. This
> causes files to be generated when it is not expected. It can cause failures
> were writing to the current working directory is not allowed. Causes file
> access violations if two caches are created in the same process space without
> setting unique files or explicitly disabling.
> https://geode.apache.org/docs/guide/12/reference/topics/gemfire_properties.html
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8181) C++ client defaults statistic-sampling-enabled to true
[
https://issues.apache.org/jira/browse/GEODE-8181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118794#comment-17118794
]
ASF GitHub Bot commented on GEODE-8181:
---
pivotal-jbarrett commented on a change in pull request #606:
URL: https://github.com/apache/geode-native/pull/606#discussion_r431913049
##
File path: cppcache/integration-test/testSystemProperties.cpp
##
@@ -51,7 +51,7 @@ BEGIN_TEST(DEFAULT)
ASSERT(
systemProperties->statisticsSampleInterval() ==
std::chrono::seconds(1),
"expected 1");
-ASSERT(systemProperties->statisticsEnabled() == true, "expected true");
+ASSERT(systemProperties->statisticsEnabled() == false, "expected true");
Review comment:
Ha! Details!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> C++ client defaults statistic-sampling-enabled to true
> --
>
> Key: GEODE-8181
> URL: https://issues.apache.org/jira/browse/GEODE-8181
> Project: Geode
> Issue Type: Bug
>Reporter: Jacob Barrett
>Assignee: Jacob Barrett
>Priority: Major
>
> The Geode documentation, Java client and server all say the default value is
> {{false}} but the C++ client library sets the default to {{true}}. This
> causes files to be generated when it is not expected. It can cause failures
> were writing to the current working directory is not allowed. Causes file
> access violations if two caches are created in the same process space without
> setting unique files or explicitly disabling.
> https://geode.apache.org/docs/guide/12/reference/topics/gemfire_properties.html
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8181) C++ client defaults statistic-sampling-enabled to true
[
https://issues.apache.org/jira/browse/GEODE-8181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118790#comment-17118790
]
ASF GitHub Bot commented on GEODE-8181:
---
pdxcodemonkey commented on a change in pull request #606:
URL: https://github.com/apache/geode-native/pull/606#discussion_r431908122
##
File path: cppcache/integration-test/testSystemProperties.cpp
##
@@ -80,7 +80,7 @@ BEGIN_TEST(NEW_CONFIG)
std::chrono::seconds(700),
"expected 700");
-ASSERT(systemProperties->statisticsEnabled() == false, "expected false");
+ASSERT(systemProperties->statisticsEnabled() == true, "expected false");
Review comment:
Same here
##
File path: cppcache/integration-test/testSystemProperties.cpp
##
@@ -51,7 +51,7 @@ BEGIN_TEST(DEFAULT)
ASSERT(
systemProperties->statisticsSampleInterval() ==
std::chrono::seconds(1),
"expected 1");
-ASSERT(systemProperties->statisticsEnabled() == true, "expected true");
+ASSERT(systemProperties->statisticsEnabled() == false, "expected true");
Review comment:
The string description should now be "expected false," no?
##
File path: cppcache/integration-test/resources/system.properties
##
@@ -14,7 +14,7 @@
# limitations under the License.
# All the configurable parameters.
statistic-sample-rate=700s
-statistic-sampling-enabled=false
+statistic-sampling-enabled=true
Review comment:
I don't understand this change. Doesn't this change the value to true
for _all_ integration tests now? I thought only the expiration tests required
this, i.e. the two places where you're now explicitly enabling them in test
code.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> C++ client defaults statistic-sampling-enabled to true
> --
>
> Key: GEODE-8181
> URL: https://issues.apache.org/jira/browse/GEODE-8181
> Project: Geode
> Issue Type: Bug
>Reporter: Jacob Barrett
>Assignee: Jacob Barrett
>Priority: Major
>
> The Geode documentation, Java client and server all say the default value is
> {{false}} but the C++ client library sets the default to {{true}}. This
> causes files to be generated when it is not expected. It can cause failures
> were writing to the current working directory is not allowed. Causes file
> access violations if two caches are created in the same process space without
> setting unique files or explicitly disabling.
> https://geode.apache.org/docs/guide/12/reference/topics/gemfire_properties.html
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8181) C++ client defaults statistic-sampling-enabled to true
[
https://issues.apache.org/jira/browse/GEODE-8181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118260#comment-17118260
]
ASF GitHub Bot commented on GEODE-8181:
---
pivotal-jbarrett opened a new pull request #606:
URL: https://github.com/apache/geode-native/pull/606
GEODE-8181: Fixes default value for statistic-sampling-enabled.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> C++ client defaults statistic-sampling-enabled to true
> --
>
> Key: GEODE-8181
> URL: https://issues.apache.org/jira/browse/GEODE-8181
> Project: Geode
> Issue Type: Bug
>Reporter: Jacob Barrett
>Assignee: Jacob Barrett
>Priority: Major
>
> The Geode documentation, Java client and server all say the default value is
> {{false}} but the C++ client library sets the default to {{true}}. This
> causes files to be generated when it is not expected. It can cause failures
> were writing to the current working directory is not allowed. Causes file
> access violations if two caches are created in the same process space without
> setting unique files or explicitly disabling.
> https://geode.apache.org/docs/guide/12/reference/topics/gemfire_properties.html
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8181) C++ client defaults statistic-sampling-enabled to true
[
https://issues.apache.org/jira/browse/GEODE-8181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115025#comment-17115025
]
ASF subversion and git services commented on GEODE-8181:
Commit 35b6d5260b2c04cf25e84b34d38bacbf56f0445e in geode-native's branch
refs/heads/develop from Jacob Barrett
[ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=35b6d52 ]
Revert "GEODE-8181: Fixes default value for statistic-sampling-enabled. (#602)"
This reverts commit d5811e9c04ed0179dd9d41f38681ab2cfbd075cf.
> C++ client defaults statistic-sampling-enabled to true
> --
>
> Key: GEODE-8181
> URL: https://issues.apache.org/jira/browse/GEODE-8181
> Project: Geode
> Issue Type: Bug
>Reporter: Jacob Barrett
>Assignee: Jacob Barrett
>Priority: Major
>
> The Geode documentation, Java client and server all say the default value is
> {{false}} but the C++ client library sets the default to {{true}}. This
> causes files to be generated when it is not expected. It can cause failures
> were writing to the current working directory is not allowed. Causes file
> access violations if two caches are created in the same process space without
> setting unique files or explicitly disabling.
> https://geode.apache.org/docs/guide/12/reference/topics/gemfire_properties.html
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8181) C++ client defaults statistic-sampling-enabled to true
[
https://issues.apache.org/jira/browse/GEODE-8181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114916#comment-17114916
]
ASF GitHub Bot commented on GEODE-8181:
---
pdxcodemonkey merged pull request #602:
URL: https://github.com/apache/geode-native/pull/602
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> C++ client defaults statistic-sampling-enabled to true
> --
>
> Key: GEODE-8181
> URL: https://issues.apache.org/jira/browse/GEODE-8181
> Project: Geode
> Issue Type: Bug
>Reporter: Jacob Barrett
>Assignee: Jacob Barrett
>Priority: Major
>
> The Geode documentation, Java client and server all say the default value is
> {{false}} but the C++ client library sets the default to {{true}}. This
> causes files to be generated when it is not expected. It can cause failures
> were writing to the current working directory is not allowed. Causes file
> access violations if two caches are created in the same process space without
> setting unique files or explicitly disabling.
> https://geode.apache.org/docs/guide/12/reference/topics/gemfire_properties.html
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8181) C++ client defaults statistic-sampling-enabled to true
[
https://issues.apache.org/jira/browse/GEODE-8181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114915#comment-17114915
]
ASF subversion and git services commented on GEODE-8181:
Commit d5811e9c04ed0179dd9d41f38681ab2cfbd075cf in geode-native's branch
refs/heads/develop from Jacob Barrett
[ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=d5811e9 ]
GEODE-8181: Fixes default value for statistic-sampling-enabled. (#602)
- Default in native client was set to true, which is the opposite of Java
client and our documentation
> C++ client defaults statistic-sampling-enabled to true
> --
>
> Key: GEODE-8181
> URL: https://issues.apache.org/jira/browse/GEODE-8181
> Project: Geode
> Issue Type: Bug
>Reporter: Jacob Barrett
>Assignee: Jacob Barrett
>Priority: Major
>
> The Geode documentation, Java client and server all say the default value is
> {{false}} but the C++ client library sets the default to {{true}}. This
> causes files to be generated when it is not expected. It can cause failures
> were writing to the current working directory is not allowed. Causes file
> access violations if two caches are created in the same process space without
> setting unique files or explicitly disabling.
> https://geode.apache.org/docs/guide/12/reference/topics/gemfire_properties.html
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8181) C++ client defaults statistic-sampling-enabled to true
[
https://issues.apache.org/jira/browse/GEODE-8181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114913#comment-17114913
]
ASF GitHub Bot commented on GEODE-8181:
---
pivotal-jbarrett opened a new pull request #602:
URL: https://github.com/apache/geode-native/pull/602
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> C++ client defaults statistic-sampling-enabled to true
> --
>
> Key: GEODE-8181
> URL: https://issues.apache.org/jira/browse/GEODE-8181
> Project: Geode
> Issue Type: Bug
>Reporter: Jacob Barrett
>Assignee: Jacob Barrett
>Priority: Major
>
> The Geode documentation, Java client and server all say the default value is
> {{false}} but the C++ client library sets the default to {{true}}. This
> causes files to be generated when it is not expected. It can cause failures
> were writing to the current working directory is not allowed. Causes file
> access violations if two caches are created in the same process space without
> setting unique files or explicitly disabling.
> https://geode.apache.org/docs/guide/12/reference/topics/gemfire_properties.html
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
