[jira] [Updated] (GEODE-5064) Remove unused code and if clause that does not get thrown

2018-04-17 Thread Jason Huynh (JIRA) 

 [ 
https://issues.apache.org/jira/browse/GEODE-5064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Huynh updated GEODE-5064:
---
Fix Version/s: (was: 1.6.0)
   1.7.0

> Remove unused code and if clause that does not get thrown
> -
>
> Key: GEODE-5064
> URL: https://issues.apache.org/jira/browse/GEODE-5064
> Project: Geode
>  Issue Type: Bug
>  Components: querying
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.7.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> There appears to be an exception that should be thrown, but upon futher 
> inspection, this clause can never be hit because the boolean it checks is 
> never set to true;
>  
> In LocalRegion:
> logger.info("Failed to create index {} on region {} with exception: {}",
>  icd.getIndexName(), this.getFullPath(), ex);
> // Check if the region index creation is from cache.xml, in that case throw 
> exception.
> // Other case is when bucket regions are created dynamically, in that case 
> ignore the
> // exception.
> if (internalRegionArgs.getDeclarativeIndexCreation()) {
>  throw new 
> InternalGemFireError(LocalizedStrings.GemFireCache_INDEX_CREATION_EXCEPTION_1
>  .toLocalizedString(icd.getIndexName(), this.getFullPath()), ex);
> }



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (GEODE-5064) Remove unused code and if clause that does not get thrown

2018-04-16 Thread Jason Huynh (JIRA) 

 [ 
https://issues.apache.org/jira/browse/GEODE-5064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Huynh updated GEODE-5064:
---
Fix Version/s: 1.6.0

> Remove unused code and if clause that does not get thrown
> -
>
> Key: GEODE-5064
> URL: https://issues.apache.org/jira/browse/GEODE-5064
> Project: Geode
>  Issue Type: Bug
>  Components: querying
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.6.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> There appears to be an exception that should be thrown, but upon futher 
> inspection, this clause can never be hit because the boolean it checks is 
> never set to true;
>  
> In LocalRegion:
> logger.info("Failed to create index {} on region {} with exception: {}",
>  icd.getIndexName(), this.getFullPath(), ex);
> // Check if the region index creation is from cache.xml, in that case throw 
> exception.
> // Other case is when bucket regions are created dynamically, in that case 
> ignore the
> // exception.
> if (internalRegionArgs.getDeclarativeIndexCreation()) {
>  throw new 
> InternalGemFireError(LocalizedStrings.GemFireCache_INDEX_CREATION_EXCEPTION_1
>  .toLocalizedString(icd.getIndexName(), this.getFullPath()), ex);
> }



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (GEODE-5064) Remove unused code and if clause that does not get thrown

2018-04-12 Thread ASF GitHub Bot (JIRA) 

 [ 
https://issues.apache.org/jira/browse/GEODE-5064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated GEODE-5064:
--
Labels: pull-request-available  (was: )

> Remove unused code and if clause that does not get thrown
> -
>
> Key: GEODE-5064
> URL: https://issues.apache.org/jira/browse/GEODE-5064
> Project: Geode
>  Issue Type: Bug
>  Components: querying
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>Priority: Major
>  Labels: pull-request-available
>
> There appears to be an exception that should be thrown, but upon futher 
> inspection, this clause can never be hit because the boolean it checks is 
> never set to true;
>  
> In LocalRegion:
> logger.info("Failed to create index {} on region {} with exception: {}",
>  icd.getIndexName(), this.getFullPath(), ex);
> // Check if the region index creation is from cache.xml, in that case throw 
> exception.
> // Other case is when bucket regions are created dynamically, in that case 
> ignore the
> // exception.
> if (internalRegionArgs.getDeclarativeIndexCreation()) {
>  throw new 
> InternalGemFireError(LocalizedStrings.GemFireCache_INDEX_CREATION_EXCEPTION_1
>  .toLocalizedString(icd.getIndexName(), this.getFullPath()), ex);
> }



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (GEODE-5064) Remove unused code and if clause that does not get thrown

2018-04-12 Thread Jason Huynh (JIRA) 

 [ 
https://issues.apache.org/jira/browse/GEODE-5064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Huynh updated GEODE-5064:
---
Description: 
There appears to be an exception that should be thrown, but upon futher 
inspection, this clause can never be hit because the boolean it checks is never 
set to true;

 

In LocalRegion:

logger.info("Failed to create index {} on region {} with exception: {}",
 icd.getIndexName(), this.getFullPath(), ex);

// Check if the region index creation is from cache.xml, in that case throw 
exception.
// Other case is when bucket regions are created dynamically, in that case 
ignore the
// exception.
if (internalRegionArgs.getDeclarativeIndexCreation()) {
 throw new 
InternalGemFireError(LocalizedStrings.GemFireCache_INDEX_CREATION_EXCEPTION_1
 .toLocalizedString(icd.getIndexName(), this.getFullPath()), ex);
}

  was:There appears to be an exception that should be thrown, but upon futher 
inspection, this clause can never be hit because the boolean it checks is never 
set to true;


> Remove unused code and if clause that does not get thrown
> -
>
> Key: GEODE-5064
> URL: https://issues.apache.org/jira/browse/GEODE-5064
> Project: Geode
>  Issue Type: Bug
>  Components: querying
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>Priority: Major
>
> There appears to be an exception that should be thrown, but upon futher 
> inspection, this clause can never be hit because the boolean it checks is 
> never set to true;
>  
> In LocalRegion:
> logger.info("Failed to create index {} on region {} with exception: {}",
>  icd.getIndexName(), this.getFullPath(), ex);
> // Check if the region index creation is from cache.xml, in that case throw 
> exception.
> // Other case is when bucket regions are created dynamically, in that case 
> ignore the
> // exception.
> if (internalRegionArgs.getDeclarativeIndexCreation()) {
>  throw new 
> InternalGemFireError(LocalizedStrings.GemFireCache_INDEX_CREATION_EXCEPTION_1
>  .toLocalizedString(icd.getIndexName(), this.getFullPath()), ex);
> }



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)