[GitHub] incubator-hawq pull request #1230: HAWQ-1453. Fixed relation_close() error a...
Github user hsyuan commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1230#discussion_r114932353 --- Diff: src/backend/commands/analyze.c --- @@ -308,7 +308,7 @@ void analyzeStmt(VacuumStmt *stmt, List *relids, int preferred_seg_num) ListCell*le1 = NULL; int successCount = 0, failCount = 0; StringInfoData failNames; - ResourceOwner owner, oldOwner; + ResourceOwner asOwner, oldOwner1; --- End diff -- if `as` of `asOwner` means `analyzeStmt`, we'd better add comments or explanation on the both vars. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1230: HAWQ-1453. Fixed relation_close() error at analy...
Github user paul-guo- commented on the issue: https://github.com/apache/incubator-hawq/pull/1230 Personally I do not like having asOwner and oldOwner1, but it is not a big issue. So +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Resolved] (HAWQ-1452) Remove hawq_rps_address_suffix and hawq_rps_address_host in hawq-site.xml to simplify configuration for RPS High Availability
[ https://issues.apache.org/jira/browse/HAWQ-1452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiang Sheng resolved HAWQ-1452. --- Resolution: Fixed > Remove hawq_rps_address_suffix and hawq_rps_address_host in hawq-site.xml to > simplify configuration for RPS High Availability > - > > Key: HAWQ-1452 > URL: https://issues.apache.org/jira/browse/HAWQ-1452 > Project: Apache HAWQ > Issue Type: Sub-task > Components: Security >Reporter: Xiang Sheng >Assignee: Xiang Sheng > Fix For: 2.3.0.0-incubating > > > Since we designed high availability for RPS, rps will use > hawq_master_host_name and hawq_standby_host_name for the rps HA guarantee, so > we want to simplify the rps url configurations. So hawq_rps_address_suffix > and hawq_rps_address_host is no need anymore. We should remove them. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] incubator-hawq issue #1231: HAWQ-1452. Remove hawq_rps_address_suffix and ha...
Github user stanlyxiang commented on the issue: https://github.com/apache/incubator-hawq/pull/1231 Merged into master. Close this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1231: HAWQ-1452. Remove hawq_rps_address_suffix...
Github user stanlyxiang closed the pull request at: https://github.com/apache/incubator-hawq/pull/1231 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
