[GitHub] incubator-hawq issue #1318: HAWQ-1560. Changed log level to DEBUG1 for data ...

[zhangh43]

Github user zhangh43 commented on the issue:

https://github.com/apache/incubator-hawq/pull/1318
  
These logs will be printed only once for every call of planner.  As 
mentioned in [JIRA-1560](https://issues.apache.org/jira/browse/HAWQ-1560), 
these logs occupy 20% of the overall log. I agree to make it to DEBUG1 level.
Besides, user can still get data locality info from explain analyze.
+1


---

[GitHub] incubator-hawq pull request #1322: Support Hive OpenCSVSerde

[lavjain]

Github user lavjain commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1322#discussion_r156481970
  
--- Diff: 
pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/HiveLineBreakAccessor.java
 ---
@@ -43,7 +43,7 @@
 public HiveLineBreakAccessor(InputData input) throws Exception {
 super(input, new TextInputFormat());
 ((TextInputFormat) inputFormat).configure(jobConf);
-HiveUserData hiveUserData = HiveUtilities.parseHiveUserData(input, 
PXF_HIVE_SERDES.LAZY_SIMPLE_SERDE);
+HiveUserData hiveUserData = HiveUtilities.parseHiveUserData(input, 
PXF_HIVE_SERDES.LAZY_SIMPLE_SERDE, PXF_HIVE_SERDES.CSV_SERDE);
--- End diff --

I second that. We should support all serdes (Hive is responsible for them)


---

[GitHub] incubator-hawq pull request #1322: Support Hive OpenCSVSerde

[denalex]

Github user denalex commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1322#discussion_r156481646
  
--- Diff: 
pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/HiveLineBreakAccessor.java
 ---
@@ -43,7 +43,7 @@
 public HiveLineBreakAccessor(InputData input) throws Exception {
 super(input, new TextInputFormat());
 ((TextInputFormat) inputFormat).configure(jobConf);
-HiveUserData hiveUserData = HiveUtilities.parseHiveUserData(input, 
PXF_HIVE_SERDES.LAZY_SIMPLE_SERDE);
+HiveUserData hiveUserData = HiveUtilities.parseHiveUserData(input, 
PXF_HIVE_SERDES.LAZY_SIMPLE_SERDE, PXF_HIVE_SERDES.CSV_SERDE);
--- End diff --

why do we need to keep a list of supported Serde ? If Serde is transparent 
to us, let support all of them and not restrict the users to use specific ones.


---

[GitHub] incubator-hawq pull request #1322: Support Hive OpenCSVSerde

[shivzone]

GitHub user shivzone opened a pull request:

https://github.com/apache/incubator-hawq/pull/1322

Support Hive OpenCSVSerde



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shivzone/incubator-hawq HAWQ-1571

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hawq/pull/1322.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1322


commit c13aa9f28b054e24f6deea9902e5219ebae7d486
Author: shivzone 
Date:   2017-12-12T17:36:58Z

Support Hive OpenCSVSerde




---

[jira] [Assigned] (HAWQ-1571) Support Hive's OpenCSVSerde

[Shivram Mani (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HAWQ-1571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shivram Mani reassigned HAWQ-1571:
--

Assignee: Shivram Mani  (was: Ed Espino)

> Support Hive's OpenCSVSerde
> ---
>
> Key: HAWQ-1571
> URL: https://issues.apache.org/jira/browse/HAWQ-1571
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: PXF
>Reporter: Shivram Mani
>Assignee: Shivram Mani
>
> Support reading Hive tables created with OpenCSVSerde



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (HAWQ-1571) Support Hive's OpenCSVSerde

[Shivram Mani (JIRA)]

Shivram Mani created HAWQ-1571:
--

 Summary: Support Hive's OpenCSVSerde
 Key: HAWQ-1571
 URL: https://issues.apache.org/jira/browse/HAWQ-1571
 Project: Apache HAWQ
  Issue Type: Bug
  Components: PXF
Reporter: Shivram Mani
Assignee: Ed Espino


Support reading Hive tables created with OpenCSVSerde



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)