[GitHub] incubator-hawq-site issue #17: HAWQ-1638. Add how to verify downloaded files...
Github user jiny2 commented on the issue: https://github.com/apache/incubator-hawq-site/pull/17 +1, LGTM. Thank you. ---
[GitHub] incubator-hawq issue #1343: HAWQ-1590. bump hawq version to 2.3 in contrib/h...
Github user jiny2 commented on the issue: https://github.com/apache/incubator-hawq/pull/1343 +1 LGTM. Thanks! ---
[GitHub] incubator-hawq issue #1342: HAWQ-1589. bump hawq version to 2.3 in pom.xml f...
Github user jiny2 commented on the issue: https://github.com/apache/incubator-hawq/pull/1342 LGTM +1, Thank for your helping fixing release issues. ---
[GitHub] incubator-hawq issue #1338: HAWQ-1586. Update version from 2.2.0.0 to 2.3.0....
Github user jiny2 commented on the issue: https://github.com/apache/incubator-hawq/pull/1338 Merged into master and 2.3.0.0-incubating branches ---
[GitHub] incubator-hawq pull request #1338: HAWQ-1586. Update version from 2.2.0.0 to...
Github user jiny2 closed the pull request at: https://github.com/apache/incubator-hawq/pull/1338 ---
[GitHub] incubator-hawq issue #1338: HAWQ-1586. Update version from 2.2.0.0 to 2.3.0....
Github user jiny2 commented on the issue: https://github.com/apache/incubator-hawq/pull/1338 @radarwave @huor please help to review this version update ---
[GitHub] incubator-hawq pull request #1338: HAWQ-1586. Update version from 2.2.0.0 to...
GitHub user jiny2 opened a pull request: https://github.com/apache/incubator-hawq/pull/1338 HAWQ-1586. Update version from 2.2.0.0 to 2.3.0.0 postgres=# select version(); version --- PostgreSQL 8.2.15 (Greenplum Database 4.2.0 build 1) (HAWQ 2.3.0.0-incubating build dev) on x86_64-apple-darwin16.7.0, compiled by GCC Apple LLVM version 8.1.0 (clang-802.0.42) compiled on Feb 8 2018 16:34:44 (1 row) You can merge this pull request into a Git repository by running: $ git pull https://github.com/jiny2/incubator-hawq HAWQ-1586 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/1338.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1338 commit 59f69435815035c0d529ecfda694ae99fe2dd67b Author: Yi <yjin@...> Date: 2018-02-08T05:41:09Z HAWQ-1586. Update version from 2.2.0.0 to 2.3.0.0 ---
[GitHub] incubator-hawq pull request #1314: HAWQ-1555. Add access interfaces for prot...
Github user jiny2 commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1314#discussion_r154279848
--- Diff: src/backend/access/external/plugstorage.c ---
@@ -0,0 +1,533 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+/*-
+ *
+ * plugstorage.c
+ *
+ *Pluggable storage implementation. Support external table for now.
+ *
+ *-
+ */
+#include "access/plugstorage.h"
+#include "catalog/pg_type.h"
+#include "catalog/pg_proc.h"
+#include "catalog/pg_exttable.h"
+#include "nodes/value.h"
+#include "parser/parse_func.h"
+
+/*
+ * getExternalTableTypeList
+ *
+ *Return the table type for a given external table
+ *
+ *Currently it is an implementation with performance cost due to the
+ *fact that the format types for TEXT, CSV, and ORC external tables
+ *with customer protocol (HDFS) are all 'b' in pg_exttable catalog
+ *table. It needs to visit the format options to get the table type.
+ */
+void getExternalTableTypeList(const char formatType,
+ List *formatOptions,
+ int *formatterType,
+ char **formatterName)
+{
+ if (fmttype_is_custom(formatType))
+ {
+ Assert(formatOptions);
+
+ *formatterName =
getExtTblFormatterTypeInFmtOptsList(formatOptions);
+
+ *formatterType = ExternalTableType_PLUG;
+ }
+ else
+ {
+ *formatterType = ExternalTableType_Invalid;
+ *formatterName = NULL;
+ elog(ERROR, "undefined external table format type: %c",
formatType);
+ }
+}
+
+void getExternalTableTypeStr(const char formatType,
--- End diff --
We need some descriptions like the function above, please add more comments
before delivery
---
[GitHub] incubator-hawq issue #1314: HAWQ-1555. Add access interfaces for protocol an...
Github user jiny2 commented on the issue: https://github.com/apache/incubator-hawq/pull/1314 +1 I think it makes sense to have partial facility code checked in for simplifying the following code merge and delivery work. Therefore, per my understanding, it is not necessary to provide feature test cases in current phase, as all existing HAWQ test cases target end-to-end process. We can do it later when some functions work. Of course test case is a must do. @chiyang1 for this delivery please make sure current existing HAWQ feature test cases pass without unexpected errors raised. ---
[GitHub] incubator-hawq pull request #1314: HAWQ-1555. Add access interfaces for prot...
Github user jiny2 commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1314#discussion_r154278905 --- Diff: src/backend/access/external/Makefile --- @@ -26,7 +26,7 @@ subdir = src/backend/access/external top_builddir = ../../../.. include $(top_builddir)/src/Makefile.global -OBJS = fileam.o url.o libchurl.o hd_work_mgr.o pxfuriparser.o pxfheaders.o \ +OBJS = fileam.o plugstorage.o url.o libchurl.o hd_work_mgr.o pxfuriparser.o pxfheaders.o \ --- End diff -- I think it is better to add this new object to the tail of OBJS list ---
[GitHub] incubator-hawq pull request #1314: HAWQ-1555. Add access interfaces for prot...
Github user jiny2 commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1314#discussion_r154278719
--- Diff: src/include/access/plugstorage.h ---
@@ -0,0 +1,221 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+/*-
+ *
+ * plugstorage.h
+ *
+ *Pluggable storage definitions. Support external table for now.
+ *
+ *-
+ */
+
+#ifndef PLUGSTORAGE_H
+#define PLUGSTORAGE_H
+
+#include "postgres.h"
+#include "postgres_ext.h"
+#include "fmgr.h"
+#include "nodes/pg_list.h"
+#include "nodes/plannodes.h"
+#include "nodes/execnodes.h"
+#include "access/sdir.h"
+#include "access/relscan.h"
+#include "access/extprotocol.h"
+#include "access/tupdesc.h"
+#include "access/fileam.h"
+#include "utils/relcache.h"
+#include "executor/tuptable.h"
+
+/* From src/include/access/fileam.h */
+extern char *getExtTblCategoryInFmtOptsStr(char *fmtStr);
+extern char *getExtTblFormatterTypeInFmtOptsStr(char *fmtStr);
+extern char *getExtTblFormatterTypeInFmtOptsList(List *fmtOpts);
+
+
+/*
+ * ExternalTableType
+ *
+ *enum for different types of external tables.
+ *
+ *The different types of external tables can be combinations of
different
+ *protocols and formats. To be specific:
+ *{GPFDIST, GPFDISTS, HTTP, COMMAND, HDFS} X {TEXT, CSV, ORC}
+ *
+ *NOTE:
+ *
+ *The GENERIC external table type is used to simplify the call back
+ *implementation for different combination of external table formats
+ *and protocols. It need to be improved so that each external table
+ *type should get its access method with minimum cost during runtime.
+ *
+ *The fact is that for custom protocol (HDFS), the format types for
+ *TEXT, CSV, and ORC external tables are all 'b' in pg_exttable catalog
+ *table. The formatter information is stored in format options which is
+ *a list strings. Thus, during read and write access of these tables,
+ *there will be performance issue if we get the format type and access
+ *method for them for each tuple.
+ *
+ */
+typedef enum
+{
+ ExternalTableType_GENERIC, /* GENERIC external table format and
protocol */
+ ExternalTableType_PLUG,/* Pluggable format with hdfs protocol,
i.e., ORC */
+ ExternalTableType_Invalid
+} ExternalTableType;
+
+/*
+ * PlugStorageValidatorData is the node type that is passed as fmgr
"context"
+ * info when a function is called by the Pluggable Storage Framework.
+ */
+typedef struct PlugStorageValidatorData
+{
+ /* see T_PlugStorageValidatorData */
+ NodeTag type;
+
+ /* check if format interfaces are implemented in pg_proc */
+ char*format_name;
+
+ /* check if format options and their values are valid */
+ List*format_opts;
+ char*format_str;
+ char*encoding_name;
+ boolis_writable;
+
+ /* check if format data types are supported in table definition */
+ TupleDesc tuple_desc;
+
+} PlugStorageValidatorData;
+
+typedef struct PlugStorageValidatorData *PlugStorageValidator;
+
+/*
+ * PlugStorageData is used to pass args between hawq and pluggable data
formats.
+ */
+typedef struct PlugStorageData
+{
+ NodeTagtype; /* see T_PlugStorageData */
+ intps_table_type;
+ intps_formatter_type;
+ char *ps_formatter_name;
+ intps_error_ao
[GitHub] incubator-hawq issue #1310: HAWQ-1548 Correct ambiguous message while loggin...
Github user jiny2 commented on the issue: https://github.com/apache/incubator-hawq/pull/1310 @outofmem0ry Per my design, the first log is to output dynamic total YARN cluster capacity change, not per node value, that log is output only when total YARN capacity changes. The second log is output only when available YARN capacity for HAWQ changes, not for per node. So basically, we cannot say that is for per node. ---
[GitHub] incubator-hawq pull request #1308: HAWQ-1530. Illegally killing a JDBC selec...
Github user jiny2 commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1308#discussion_r149832325 --- Diff: src/backend/cdb/dispatcher.c --- @@ -1414,9 +1415,12 @@ dispatch_cleanup(DispatchData *data) if (dispatcher_is_state_error(data)) --- End diff -- The same logic, no special performance improvement in my opinion ---
[GitHub] incubator-hawq pull request #1308: HAWQ-1530. Illegally killing a JDBC selec...
Github user jiny2 closed the pull request at: https://github.com/apache/incubator-hawq/pull/1308 ---
[GitHub] incubator-hawq issue #1308: HAWQ-1530. Illegally killing a JDBC select query...
Github user jiny2 commented on the issue: https://github.com/apache/incubator-hawq/pull/1308 @kuien please check this fix ---
[GitHub] incubator-hawq pull request #1308: HAWQ-1530. Illegally killing a JDBC selec...
GitHub user jiny2 opened a pull request: https://github.com/apache/incubator-hawq/pull/1308 HAWQ-1530. Illegally killing a JDBC select query causes locking problems This bug root cause maybe twice FATAL error throwing, I cannot exactly reproduce it according to this issue's comment, just based on my understanding and previous bug fix experiences. We cannot allow a FATAL throwed again when anohter FATAL causes process into exit phase. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jiny2/incubator-hawq HAWQ-1530 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/1308.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1308 commit 7a103541d11cebd3872dc1b7108ab636f7f53ddf Author: Yi <y...@apache.org> Date: 2017-11-07T20:47:02Z HAWQ-1530. Illegally killing a JDBC select query causes locking problems ---
[GitHub] incubator-hawq issue #1308: HAWQ-1530. Illegally killing a JDBC select query...
Github user jiny2 commented on the issue: https://github.com/apache/incubator-hawq/pull/1308 @radarwave @linwen @changleicn please review and comment ---
[GitHub] incubator-hawq issue #1296: HAWQ-1496. Add DISCLAIMER, LICENSE and NOTICE fi...
Github user jiny2 commented on the issue: https://github.com/apache/incubator-hawq/pull/1296 Thank you ed! @edespino +1 Look good to me . ---
[GitHub] incubator-hawq issue #1243: HAWQ-1458. Fix share input scan bug for writer p...
Github user jiny2 commented on the issue: https://github.com/apache/incubator-hawq/pull/1243 +1 LGTM, in my opinion, this is a good sample fix for future potential inter-process failure detection. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1279: HAWQ-1310. Reformat resource_negotiator().
Github user jiny2 commented on the issue: https://github.com/apache/incubator-hawq/pull/1279 Please close this pr as per my understanding it has been delivered last week. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1278: HAWQ-1498. Segments keep open file descri...
Github user jiny2 closed the pull request at: https://github.com/apache/incubator-hawq/pull/1278 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1279: HAWQ-1310. Reformat resource_negotiator().
Github user jiny2 commented on the issue: https://github.com/apache/incubator-hawq/pull/1279 +1 LGTM. Thanks for fixing this so quickly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1278: HAWQ-1498. Segments keep open file descriptors f...
Github user jiny2 commented on the issue: https://github.com/apache/incubator-hawq/pull/1278 I manually tested this fix in my environment, please review and comment. @linwen @radarwave --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1278: HAWQ-1498. Segments keep open file descri...
GitHub user jiny2 opened a pull request: https://github.com/apache/incubator-hawq/pull/1278 HAWQ-1498. Segments keep open file descriptors for deleted files The idea is to hold a list of all connections ever used for dropping objects in HDFS, then when the transaction ends, no matter commit or rollback, those connections are forced to close. Those connections cached but never used for dropping, are not touched. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jiny2/incubator-hawq HAWQ-1498-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/1278.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1278 commit ad5d4d9995d8e47c863b3c532cee40166d790cf8 Author: Yi <y...@apache.org> Date: 2017-08-10T09:15:06Z HAWQ-1498. Segments keep open file descriptors for deleted files --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1275: HAWQ-1333. Change access mode of source files fo...
Github user jiny2 commented on the issue: https://github.com/apache/incubator-hawq/pull/1275 Good job ! please have it delivered asap. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1243: HAWQ-1458. Fix share input scan bug for writer p...
Github user jiny2 commented on the issue: https://github.com/apache/incubator-hawq/pull/1243 +1 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1238: HAWQ-1460. WAL Send Server process should exit i...
Github user jiny2 commented on the issue: https://github.com/apache/incubator-hawq/pull/1238 +1 LGTM. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1223: HAWQ-1439. tolerate system time being cha...
Github user jiny2 closed the pull request at: https://github.com/apache/incubator-hawq/pull/1223 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1223: HAWQ-1439. tolerate system time being changed to...
Github user jiny2 commented on the issue: https://github.com/apache/incubator-hawq/pull/1223 Applied @paul-guo- 's comment to change the time getting implementation --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1223: HAWQ-1439. tolerate system time being changed to...
Github user jiny2 commented on the issue: https://github.com/apache/incubator-hawq/pull/1223 Seems clock_gettime() does not work for C99. network_utils.c:52:11: warning: implicit declaration of function 'clock_gettime' is invalid in C99 [-Wimplicit-function-declaration] status = clock_gettime(CLOCK_MONOTONIC, ); ^ network_utils.c:52:25: error: use of undeclared identifier 'CLOCK_MONOTONIC' status = clock_gettime(CLOCK_MONOTONIC, ); ^ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1223: HAWQ-1439. tolerate system time being changed to...
Github user jiny2 commented on the issue: https://github.com/apache/incubator-hawq/pull/1223 I think as we discussed, we will do a simple fix firstly for this problem. Changing gettime_microsec() may have side effect which is not clear yet. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1223: HAWQ-1439. tolerate system time being changed to...
Github user jiny2 commented on the issue: https://github.com/apache/incubator-hawq/pull/1223 @paul-guo- @liming01 please review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1223: HAWQ-1439. tolerate system time being cha...
GitHub user jiny2 opened a pull request: https://github.com/apache/incubator-hawq/pull/1223 HAWQ-1439. tolerate system time being changed to earlier point when checking resource context timeout You can merge this pull request into a Git repository by running: $ git pull https://github.com/jiny2/incubator-hawq HAWQ-1439 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/1223.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1223 commit d1d9ae7fb44974d0c29c1a665f6affe0aa08fabb Author: Yi <y...@pivotal.io> Date: 2017-04-24T09:40:30Z HAWQ-1439. tolerate system time being changed to earlier point when checking resource context timeout --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1219: HAWQ-1433. ALTER RESOURCE QUEUE DDL does not che...
Github user jiny2 commented on the issue: https://github.com/apache/incubator-hawq/pull/1219 +1 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1183: HAWQ-1400. An improvement in SQL Util des...
Github user jiny2 closed the pull request at: https://github.com/apache/incubator-hawq/pull/1183 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1183: HAWQ-1400. An improvement in SQL Util destructor...
Github user jiny2 commented on the issue: https://github.com/apache/incubator-hawq/pull/1183 comment is added to explain the sleep --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1183: HAWQ-1400. An improvement in SQL Util destructor...
Github user jiny2 commented on the issue: https://github.com/apache/incubator-hawq/pull/1183 Sure, I will add comment here to explain it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1183: HAWQ-1400. An improvement in SQL Util destructor...
Github user jiny2 commented on the issue: https://github.com/apache/incubator-hawq/pull/1183 @huor @paul-guo- @stanlyxiang Please review, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1183: HAWQ-1400. An improvement in SQL Util destructor...
Github user jiny2 commented on the issue: https://github.com/apache/incubator-hawq/pull/1183 This is an external improvement from test tool side to make more stable CI testing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1183: HAWQ-1400. An improvement in SQL Util des...
GitHub user jiny2 opened a pull request: https://github.com/apache/incubator-hawq/pull/1183 HAWQ-1400. An improvement in SQL Util destructor function for feature test You can merge this pull request into a Git repository by running: $ git pull https://github.com/jiny2/incubator-hawq HAWQ-1400 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/1183.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1183 commit 775a2d8f282c5c383c839aa3e888757bcf4b6d4f Author: Yi <y...@pivotal.io> Date: 2017-03-22T00:04:01Z HAWQ-1400. An improvement in SQL Util destructor function for feature test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1150: HAWQ-1361. Remove some installcheck-good cases s...
Github user jiny2 commented on the issue: https://github.com/apache/incubator-hawq/pull/1150 +1 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1125: HAWQ-1315. Function validateResourcePoolStatus()...
Github user jiny2 commented on the issue: https://github.com/apache/incubator-hawq/pull/1125 pushed into master branch --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1113: HAWQ-1321. failNames wrongly uses memory ...
Github user jiny2 closed the pull request at: https://github.com/apache/incubator-hawq/pull/1113 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1125: HAWQ-1315. Function validateResourcePoolStatus()...
Github user jiny2 commented on the issue: https://github.com/apache/incubator-hawq/pull/1125 +1 LGMT --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1113: HAWQ-1321. failNames wrongly uses memory ...
GitHub user jiny2 opened a pull request: https://github.com/apache/incubator-hawq/pull/1113 HAWQ-1321. failNames wrongly uses memory context to build message when ANALYZE failed set failNames use statement level context and when it potentially repallocs, switch memory context back to statement level context. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jiny2/incubator-hawq HAWQ-1321 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/1113.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1113 commit 5fee149a868ef58acf353e2342825dd908b27b2d Author: Yi <y...@pivotal.io> Date: 2017-02-10T05:53:15Z HAWQ-1321. failNames wrongly uses memory context to build message when ANALYZE failed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1108: HAWQ-1317. Port "Fix some regex issues with out-...
Github user jiny2 commented on the issue: https://github.com/apache/incubator-hawq/pull/1108 +1 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1097: HAWQ-1285. resource manager outputs uninitialize...
Github user jiny2 commented on the issue: https://github.com/apache/incubator-hawq/pull/1097 Applied comment from @huor for the log content --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1097: HAWQ-1285. resource manager outputs uninitialize...
Github user jiny2 commented on the issue: https://github.com/apache/incubator-hawq/pull/1097 @huor for review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1097: HAWQ-1285. resource manager outputs uninitialize...
Github user jiny2 commented on the issue: https://github.com/apache/incubator-hawq/pull/1097 @wcl14 @stanlyxiang please review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1097: HAWQ-1285. resource manager outputs unini...
GitHub user jiny2 opened a pull request: https://github.com/apache/incubator-hawq/pull/1097 HAWQ-1285. resource manager outputs uninitialized string as host name When the segstat instance is created from YARN cluster report, the hostname field is not set, so should now output it directly into log. This bug causes unreadable string output in log file. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jiny2/incubator-hawq HAWQ-1285 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/1097.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1097 commit 10409408a6c49ee0dba88dd1355dc04a1b5449a5 Author: Yi <y...@pivotal.io> Date: 2017-01-19T22:28:57Z HAWQ-1285. resource manager outputs uninitialized string as host name --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1093: HAWQ-1193. Add createEncryption, getEZForPath, l...
Github user jiny2 commented on the issue: https://github.com/apache/incubator-hawq/pull/1093 +1 LGTM, please add some comments to explain the logic if necessary. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1078: HAWQ-1258. segment resource manager does ...
Github user jiny2 closed the pull request at: https://github.com/apache/incubator-hawq/pull/1078 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1078: HAWQ-1258. segment resource manager does ...
Github user jiny2 commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1078#discussion_r95706815 --- Diff: src/backend/utils/misc/guc.c --- @@ -8200,7 +8200,7 @@ static struct config_string ConfigureNamesString[] = NULL }, _addr_host, - "localhost", NULL, NULL + "none", NULL, NULL --- End diff -- https://issues.apache.org/jira/browse/HAWQ-1266 this jira is created for discussion. Thanks @paul-guo- 's thorough think. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1078: HAWQ-1258. segment resource manager does ...
Github user jiny2 commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1078#discussion_r95522787 --- Diff: src/backend/utils/misc/guc.c --- @@ -8200,7 +8200,7 @@ static struct config_string ConfigureNamesString[] = NULL }, _addr_host, - "localhost", NULL, NULL + "none", NULL, NULL --- End diff -- No, segment rm process does not care what are saved in python code. So, it only knows there is a standby host named "none". So deleting from hawq_dict does not help. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1078: HAWQ-1258. segment resource manager does ...
Github user jiny2 commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1078#discussion_r95513917 --- Diff: src/backend/utils/misc/guc.c --- @@ -8200,7 +8200,7 @@ static struct config_string ConfigureNamesString[] = NULL }, _addr_host, - "localhost", NULL, NULL + "none", NULL, NULL --- End diff -- So that's why we need another fix if necessary. the fix should fix script and code together. @paul-guo- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1078: HAWQ-1258. segment resource manager does ...
Github user jiny2 commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1078#discussion_r95513882 --- Diff: src/backend/utils/misc/guc.c --- @@ -8200,7 +8200,7 @@ static struct config_string ConfigureNamesString[] = NULL }, _addr_host, - "localhost", NULL, NULL + "none", NULL, NULL --- End diff -- This will cause behavior inconsistency, when "none" is set script thinks there is no standby, but rm segment will try to resolve "none", which is not necessary. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1078: HAWQ-1258. segment resource manager does ...
Github user jiny2 commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1078#discussion_r95310043 --- Diff: src/backend/utils/misc/guc.c --- @@ -8200,7 +8200,7 @@ static struct config_string ConfigureNamesString[] = NULL }, _addr_host, - "localhost", NULL, NULL + "none", NULL, NULL --- End diff -- If we support "" instead of "none", we have segment keep connecting to "none" as a server. I think if necessary, we need another fix for this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1078: HAWQ-1258. segment resource manager does ...
Github user jiny2 commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1078#discussion_r95294321 --- Diff: src/backend/utils/misc/guc.c --- @@ -8200,7 +8200,7 @@ static struct config_string ConfigureNamesString[] = NULL }, _addr_host, - "localhost", NULL, NULL + "none", NULL, NULL --- End diff -- That needs @radarwave 's comment, I have similar question, but currently from script implementation, "none" means no standby. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1078: HAWQ-1258. segment resource manager does not swi...
Github user jiny2 commented on the issue: https://github.com/apache/incubator-hawq/pull/1078 @paul-guo- @linwen Please review, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1078: HAWQ-1258. segment resource manager does ...
GitHub user jiny2 opened a pull request: https://github.com/apache/incubator-hawq/pull/1078 HAWQ-1258. segment resource manager does not switch back when it cannot resolve standby host name If use does not configure standby host, segment will not switch to standby server; If segment cannot resolve target server no matter the master server or the standby server, the target server for sending IMAlive heart-beat is switched as well. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jiny2/incubator-hawq HAWQ-1258 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/1078.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1078 commit 67ebb204e65a2b65b48acc75db0a41332858d688 Author: Yi <y...@pivotal.io> Date: 2017-01-10T02:33:16Z HAWQ-1258. segment resource manager does not switch back when it cannot resolve standby host name --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1071: HAWQ-1242. hawq-site.xml default content ...
Github user jiny2 closed the pull request at: https://github.com/apache/incubator-hawq/pull/1071 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1071: HAWQ-1242. hawq-site.xml default content has wro...
Github user jiny2 commented on the issue: https://github.com/apache/incubator-hawq/pull/1071 In fact some gucs are not used by reading from hawq-site.xml, for example, hawq_master_directory. But for standby_addr_host, it is useful for RM as RM switches its heart-beat to standby server when master server is not achievable. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1071: HAWQ-1242. hawq-site.xml default content has wro...
Github user jiny2 commented on the issue: https://github.com/apache/incubator-hawq/pull/1071 @huor @stanlyxiang @paul-guo- @stanlyxiang is right, the correct approach is to fix guc.c as all external scripts and documentation are using hawq_* names. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1071: HAWQ-1242. hawq-site.xml default content has wro...
Github user jiny2 commented on the issue: https://github.com/apache/incubator-hawq/pull/1071 I find there is some python script logic using the hawq_* guc names, I will keep those hawq_* guc names to avoid changing python scripts. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1029: HAWQ-1174. double type core counter of co...
Github user jiny2 closed the pull request at: https://github.com/apache/incubator-hawq/pull/1029 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1071: HAWQ-1242. hawq-site.xml default content has wro...
Github user jiny2 commented on the issue: https://github.com/apache/incubator-hawq/pull/1071 @huor @radarwave Please have a review. Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1071: HAWQ-1242. hawq-site.xml default content ...
GitHub user jiny2 opened a pull request: https://github.com/apache/incubator-hawq/pull/1071 HAWQ-1242. hawq-site.xml default content has wrong guc variable names Fixed the wrong names in hawq-site.xml and its template file. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jiny2/incubator-hawq HAWQ-1242 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/1071.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1071 commit 4b2655bc17aceaa67e9db7b53147584f7860c61e Author: Yi <y...@pivotal.io> Date: 2016-12-29T04:03:11Z HAWQ-1242. hawq-site.xml default content has wrong guc variable names --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1014: HAWQ-858. Fix parser to understand case / when e...
Github user jiny2 commented on the issue: https://github.com/apache/incubator-hawq/pull/1014 +1 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1042: HAWQ-1199. guc enable_prefer_list_to_rm does not...
Github user jiny2 commented on the issue: https://github.com/apache/incubator-hawq/pull/1042 LGTM +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1029: HAWQ-1174. double type core counter of container...
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1029
@zhangh43 YARN mode, 2 segments, each segment has 75gb mem, 15core
resource, and the default queue has 25% capacity, 80% maximum capacity. Then
allocated and return 12 x 256mb vsegs, then wait more than 5 min. RM will try
to return yarn containers but due to precision problem, there are always some
yarn containers cannot be returned. because 0.99... is less than 1. As
to EPSILON, I adopted previous definition introduce by Wen. I think it should
work appropriately.
(gdb) p *containerset
$6 = {Allocated = {MemoryMB = 5120, Core = 1, Ratio = 0}, Available =
{MemoryMB = 5120,
Core = 0.99956, Ratio = 0}, Containers = 0x7ff07a93c870}
(gdb) quit
A debugging session is active.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1029: HAWQ-1174. double type core counter of container...
Github user jiny2 commented on the issue: https://github.com/apache/incubator-hawq/pull/1029 @huor please review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1029: HAWQ-1174. double type core counter of co...
Github user jiny2 commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1029#discussion_r89943290 --- Diff: src/backend/resourcemanager/include/resourcepool.h --- @@ -715,6 +715,7 @@ SimpStringPtr build_segment_status_description(SegStat segstat); #define EPSILON 1e-7 #define IS_DOUBLE_ZERO(d) (fabs(d) < EPSILON) #define IS_DOUBLE_EQ(x, y) ((fabs((x) - (y))) <= (EPSILON)) +#define IS_DOUBLE_EQGREATER(x, y) (((x) + EPSILON) >= (y)) --- End diff -- Fixed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1029: HAWQ-1174. double type core counter of container...
Github user jiny2 commented on the issue: https://github.com/apache/incubator-hawq/pull/1029 @linwen @ictmalili please help to review and comment, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1018: HAWQ-1162. Resource manager does not reference d...
Github user jiny2 commented on the issue: https://github.com/apache/incubator-hawq/pull/1018 +1 This change is ok to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #827: HAWQ-899. Add feature test for nested null...
Github user jiny2 closed the pull request at: https://github.com/apache/incubator-hawq/pull/827 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #815: HAWQ-898. Add feature test for COPY with n...
Github user jiny2 closed the pull request at: https://github.com/apache/incubator-hawq/pull/815 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #849: HAWQ-834. Refactor goh_portals checkinstal...
GitHub user jiny2 opened a pull request: https://github.com/apache/incubator-hawq/pull/849 HAWQ-834. Refactor goh_portals checkinstall cases using new test framework You can merge this pull request into a Git repository by running: $ git pull https://github.com/jiny2/incubator-hawq HAWQ-834 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/849.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #849 commit 83ecf9edb55d93b2c9d39ba6f14130ec8adca212 Author: Yi <y...@pivotal.io> Date: 2016-08-16T01:30:44Z HAWQ-834. Refactor goh_portals checkinstall cases using new test framework --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #840: HAWQ-985. Add feature test for agg with groupings...
Github user jiny2 commented on the issue: https://github.com/apache/incubator-hawq/pull/840 LGTM +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #836: HAWQ-979. Resource Broker Should Reconnect Hadoop...
Github user jiny2 commented on the issue: https://github.com/apache/incubator-hawq/pull/836 +1 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #832: Hawq-970. Provide More Accurate Information When ...
Github user jiny2 commented on the issue: https://github.com/apache/incubator-hawq/pull/832 LGTM +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #827: HAWQ-899. Add feature test for nested null...
GitHub user jiny2 opened a pull request: https://github.com/apache/incubator-hawq/pull/827 HAWQ-899. Add feature test for nested null case with new test framework You can merge this pull request into a Git repository by running: $ git pull https://github.com/jiny2/incubator-hawq HAWQ-899 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/827.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #827 commit 324680e259a032a50b2286629893348c98c4ce14 Author: YI JIN <y...@pivotal.io> Date: 2016-08-01T04:42:46Z HAWQ-899. Add feature test for nested null case with new test framework --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #815: HAWQ-898. Add feature test for COPY with new test...
Github user jiny2 commented on the issue: https://github.com/apache/incubator-hawq/pull/815 Revert COPY checkinstall-good case because transactions and row_types need this to prepare data --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #815: HAWQ-898. Add feature test for COPY with n...
GitHub user jiny2 opened a pull request: https://github.com/apache/incubator-hawq/pull/815 HAWQ-898. Add feature test for COPY with new test framework You can merge this pull request into a Git repository by running: $ git pull https://github.com/jiny2/incubator-hawq HAWQ-898 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/815.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #815 commit 60097693b1eb18dd904f7d4e6518d3e526121492 Author: YI JIN <y...@pivotal.io> Date: 2016-07-26T06:16:19Z HAWQ-898. Add feature test for COPY with new test framework --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #804: HAWQ-940. Fix Kerberos ticket expired for libyarn...
Github user jiny2 commented on the issue: https://github.com/apache/incubator-hawq/pull/804 LGTM +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #807: HAWQ-897. Add feature test for create tabl...
GitHub user jiny2 opened a pull request: https://github.com/apache/incubator-hawq/pull/807 HAWQ-897. Add feature test for create table distribution with new test framework You can merge this pull request into a Git repository by running: $ git pull https://github.com/jiny2/incubator-hawq HAWQ-897 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/807.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #807 commit 5fb757d8597b6dfa3e64cda81260e4d819e1793c Author: YI JIN <jinyi.smilo...@gmail.com> Date: 2016-07-21T04:28:24Z HAWQ-897. Add feature test for create table distribution with new test framework --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #798: HAWQ-896. Add feature test for create tabl...
Github user jiny2 closed the pull request at: https://github.com/apache/incubator-hawq/pull/798 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #798: HAWQ-896. Add feature test for create tabl...
GitHub user jiny2 opened a pull request: https://github.com/apache/incubator-hawq/pull/798 HAWQ-896. Add feature test for create table with new test framework You can merge this pull request into a Git repository by running: $ git pull https://github.com/jiny2/incubator-hawq HAWQ-896 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/798.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #798 commit a79e1d72aa9b5f0c611125975245b9b5d12fd5ff Author: YI JIN <y...@pivotal.io> Date: 2016-07-18T05:26:37Z HAWQ-896. Add feature test for create table with new test framework --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #791: HAWQ-894. Add feature test for polymorphis...
Github user jiny2 closed the pull request at: https://github.com/apache/incubator-hawq/pull/791 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #744: HAWQ-855. Make resource manager ask for cl...
Github user jiny2 closed the pull request at: https://github.com/apache/incubator-hawq/pull/744 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #784: HAWQ-912. Skip temporary Directories checking for...
Github user jiny2 commented on the issue: https://github.com/apache/incubator-hawq/pull/784 +1 lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #776: HAWQ-891. Fix functiontest build error
Github user jiny2 commented on the issue: https://github.com/apache/incubator-hawq/pull/776 +1 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #744: HAWQ-855. Make resource manager ask for cl...
GitHub user jiny2 opened a pull request: https://github.com/apache/incubator-hawq/pull/744 HAWQ-855. Make resource manager ask for cluster report quickly when YARN is detected down You can merge this pull request into a Git repository by running: $ git pull https://github.com/jiny2/incubator-hawq HAWQ-855-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/744.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #744 commit dd64de1f660430c1a712c469eb10f13ca846b040 Author: YI JIN <y...@pivotal.io> Date: 2016-06-23T03:20:25Z HAWQ-855. Make resource manager ask for cluster report quickly when YARN is detected down --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #739: HAWQ-853. Master standby should avoid incomplete ...
Github user jiny2 commented on the issue: https://github.com/apache/incubator-hawq/pull/739 +1 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #726: HAWQ-755. Fix validateResourcePoolStatus assertio...
Github user jiny2 commented on the issue: https://github.com/apache/incubator-hawq/pull/726 +1 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #702: HAWQ-802. Refactor alter owner installchec...
Github user jiny2 closed the pull request at: https://github.com/apache/incubator-hawq/pull/702 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #719: HAWQ-817. Remove deprecated test cases fro...
Github user jiny2 closed the pull request at: https://github.com/apache/incubator-hawq/pull/719 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #718: HAWQ-776. Refactor alter table checkinstal...
Github user jiny2 closed the pull request at: https://github.com/apache/incubator-hawq/pull/718 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #719: HAWQ-817. Remove deprecated test cases fro...
GitHub user jiny2 opened a pull request: https://github.com/apache/incubator-hawq/pull/719 HAWQ-817. Remove deprecated test cases from checkinstall-good You can merge this pull request into a Git repository by running: $ git pull https://github.com/jiny2/incubator-hawq HAWQ-817 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/719.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #719 commit e4678cec152c4c3e761c714f61e334d7f6fb9552 Author: YI JIN <y...@pivotal.io> Date: 2016-06-15T13:22:17Z HAWQ-817. Remove deprecated test cases from checkinstall-good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #718: HAWQ-776. Refactor alter table checkinstal...
GitHub user jiny2 opened a pull request: https://github.com/apache/incubator-hawq/pull/718 HAWQ-776. Refactor alter table checkinstall cases using new test framework You can merge this pull request into a Git repository by running: $ git pull https://github.com/jiny2/incubator-hawq HAWQ-776 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/718.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #718 commit 455816b307972dcb77e360b6d633b76e9f4456a0 Author: YI JIN <y...@pivotal.io> Date: 2016-06-15T12:58:00Z HAWQ-776. Refactor alter table checkinstall cases using new test framework --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #707: HAWQ-810. Add stringFormat for feature test libra...
Github user jiny2 commented on the issue: https://github.com/apache/incubator-hawq/pull/707 +1 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
