[GitHub] incubator-hawq issue #1287: HAWQ-1527 Enabled partition filtering for integr...
Github user outofmem0ry commented on the issue: https://github.com/apache/incubator-hawq/pull/1287 Thanks @radarwave ---
[GitHub] incubator-hawq pull request #1287: HAWQ-1527 Enabled partition filtering for...
Github user outofmem0ry closed the pull request at: https://github.com/apache/incubator-hawq/pull/1287 ---
[GitHub] incubator-hawq pull request #1323: HAWQ-1572 Fix travis ci build failure. Th...
GitHub user outofmem0ry opened a pull request: https://github.com/apache/incubator-hawq/pull/1323 HAWQ-1572 Fix travis ci build failure. Thrift/Boost incompatibility You can merge this pull request into a Git repository by running: $ git pull https://github.com/outofmem0ry/incubator-hawq fix/HAWQ-1572 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/1323.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1323 commit 85fd30570adc59551bd600c1bb3b8c12c8b84f0a Author: Shubham Sharma <shubham.uc...@gmail.com> Date: 2017-12-15T00:53:33Z HAWQ-1572 Fix travis ci build failure. Thrift/Boost incompatibility ---
[GitHub] incubator-hawq pull request #1312: HAWQ-1368 Add option to hawq register to ...
Github user outofmem0ry closed the pull request at: https://github.com/apache/incubator-hawq/pull/1312 ---
[GitHub] incubator-hawq pull request #1313: HAWQ-1553 Add option to hawq extract to s...
Github user outofmem0ry closed the pull request at: https://github.com/apache/incubator-hawq/pull/1313 ---
[GitHub] incubator-hawq issue #1312: HAWQ-1368 Add option to hawq register to specify...
Github user outofmem0ry commented on the issue: https://github.com/apache/incubator-hawq/pull/1312 Submitted PR for documentation https://github.com/apache/incubator-hawq-docs/pull/135 ---
[GitHub] incubator-hawq issue #1313: HAWQ-1553 Add option to hawq extract to specify ...
Github user outofmem0ry commented on the issue: https://github.com/apache/incubator-hawq/pull/1313 @radarwave Submitted PR for documentation https://github.com/apache/incubator-hawq-docs/pull/134 ---
[GitHub] incubator-hawq pull request #1317: HAWQ-1559 - Fix travis ci build failure d...
GitHub user outofmem0ry opened a pull request: https://github.com/apache/incubator-hawq/pull/1317 HAWQ-1559 - Fix travis ci build failure due to missing apr package You can merge this pull request into a Git repository by running: $ git pull https://github.com/outofmem0ry/incubator-hawq feature/HAWQ-1559 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/1317.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1317 commit aa518ad8ec38e44680d37979b1467ded98db3efb Author: Shubham Sharma <shubham.uc...@gmail.com> Date: 2017-12-01T01:19:06Z HAWQ-1559 - Fix travis ci build failure due to missing apr package ---
[GitHub] incubator-hawq issue #1315: HAWQ-1556. enable ALTER SCHEMA RENAME/OWNER
Github user outofmem0ry commented on the issue: https://github.com/apache/incubator-hawq/pull/1315 @kuien yes, you are right this is not relevant to the PR. Please see https://issues.apache.org/jira/browse/HAWQ-1559, just created it. Also, initiated a discussion on mailing thread. ---
[GitHub] incubator-hawq pull request #1313: HAWQ-1553 Add option to hawq extract to s...
Github user outofmem0ry commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1313#discussion_r152174954
--- Diff: tools/bin/hawqextract ---
@@ -558,13 +558,15 @@ def create_opt_parser(version):
parser.add_option('-o', '--output', help="the output metadata file,
defaults to stdout", metavar='FILE')
parser.add_option('-W', action='store_true', dest='use_getpass',
help="force password authentication")
parser.add_option('-v', '--verbose', action='store_true')
+parser.add_option('-l', '--logdir', dest='logDir', help="Sets the
directory for log files")
return parser
def main(args=None):
parser = create_opt_parser('%prog version $Revision: #1 $')
options, args = parser.parse_args(args)
+setup_tool_logging(EXECNAME, getLocalHostname(), getUserName(),
logdir=options.logDir)
--- End diff --
@interma - setup_tool_logging defaults the value of logdir to None and
handles it inside the function as seen from
[here](https://github.com/apache/incubator-hawq/blob/e082d3adbb89a9e5ccb341da324ea9514cff5a35/tools/bin/gppylib/gplog.py#L130).
I tested it locally and it works fine.
---
[GitHub] incubator-hawq issue #1312: HAWQ-1368 Add option to hawq register to specify...
Github user outofmem0ry commented on the issue: https://github.com/apache/incubator-hawq/pull/1312 @radarwave Can you please review this, will be submitting a different PR to docs repo to update documentation. ---
[GitHub] incubator-hawq issue #1313: HAWQ-1553 Add option to hawq extract to specify ...
Github user outofmem0ry commented on the issue: https://github.com/apache/incubator-hawq/pull/1313 @radarwave Can you please review this, will be submitting a different PR to docs repo to update documentation. ---
[GitHub] incubator-hawq pull request #1313: HAWQ-1553 Add option to hawq extract to s...
GitHub user outofmem0ry opened a pull request: https://github.com/apache/incubator-hawq/pull/1313 HAWQ-1553 Add option to hawq extract to specify log directory You can merge this pull request into a Git repository by running: $ git pull https://github.com/outofmem0ry/incubator-hawq feature/HAWQ-1553 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/1313.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1313 commit 72a82e0a7693e17109486369ce10cc58d3d0b369 Author: Shubham Sharma <shubham.uc...@gmail.com> Date: 2017-11-21T01:54:07Z HAWQ-1553 Add option to hawq extract to specify log directory ---
[GitHub] incubator-hawq pull request #1312: HAWQ-1368 Add option to hawq register to ...
GitHub user outofmem0ry opened a pull request: https://github.com/apache/incubator-hawq/pull/1312 HAWQ-1368 Add option to hawq register to specify log directory You can merge this pull request into a Git repository by running: $ git pull https://github.com/outofmem0ry/incubator-hawq feature/HAWQ-1368 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/1312.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1312 commit 4f39d4e46b61d4441458fdfee7472183abf8b28a Author: Shubham Sharma <shubham.uc...@gmail.com> Date: 2017-11-21T01:28:44Z HAWQ-1368 Add option to hawq register to specify log directory ---
[GitHub] incubator-hawq issue #1310: HAWQ-1548 Correct ambiguous message while loggin...
Github user outofmem0ry commented on the issue: https://github.com/apache/incubator-hawq/pull/1310 @stanlyxiang - @jiny2 explained to me that `second log is output only when available YARN capacity for HAWQ changes, not for per node`, no need for this change anymore. I will close this pull request, thank you all for your time on this. ---
[GitHub] incubator-hawq pull request #1310: HAWQ-1548 Correct ambiguous message while...
Github user outofmem0ry closed the pull request at: https://github.com/apache/incubator-hawq/pull/1310 ---
[GitHub] incubator-hawq issue #1287: HAWQ-1527 Enabled partition filtering for integr...
Github user outofmem0ry commented on the issue: https://github.com/apache/incubator-hawq/pull/1287 Thanks @shivzone. @sansanichfb Could you review this as well. ---
[GitHub] incubator-hawq issue #1311: HAWQ-1549 Fix standby resync when using -M smart...
Github user outofmem0ry commented on the issue: https://github.com/apache/incubator-hawq/pull/1311 @radarwave this is for JIRA HAWQ-1549 and recent discussion on dev thread. ---
[GitHub] incubator-hawq pull request #1311: HAWQ-1549 Fix standby resync when using -...
GitHub user outofmem0ry opened a pull request: https://github.com/apache/incubator-hawq/pull/1311 HAWQ-1549 Fix standby resync when using -M smart/fast/immediate You can merge this pull request into a Git repository by running: $ git pull https://github.com/outofmem0ry/incubator-hawq feature/HAWQ-1549 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/1311.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1311 commit 1ccf01b3dc49e19f6c2979f68264d48071a8e421 Author: Shubham Sharma <shubham.uc...@gmail.com> Date: 2017-11-14T03:02:26Z HAWQ-1549 Enable standby resync using -M smart/fast/immediate ---
[GitHub] incubator-hawq issue #1310: HAWQ-1548 Correct ambiguous message while loggin...
Github user outofmem0ry commented on the issue: https://github.com/apache/incubator-hawq/pull/1310 @linwen saw that the JIRA was assigned to you, what are your thoughts? ---
[GitHub] incubator-hawq pull request #1310: HAWQ-1548 Correct ambiguous message while...
GitHub user outofmem0ry opened a pull request: https://github.com/apache/incubator-hawq/pull/1310 HAWQ-1548 Correct ambiguous message while logging hawq utilization You can merge this pull request into a Git repository by running: $ git pull https://github.com/outofmem0ry/incubator-hawq feature/HAWQ-1548 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/1310.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1310 commit 5f94913ec53471ff03f3c21b07c7daadf9f1241b Author: Shubham Sharma <shubham.uc...@gmail.com> Date: 2017-11-14T01:41:03Z HAWQ-1548 Correct ambiguous message while logging hawq utilization ---
[GitHub] incubator-hawq pull request #1287: HAWQ-1527 Enabled partition filtering for...
Github user outofmem0ry commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1287#discussion_r141186627
--- Diff:
pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/HiveDataFragmenter.java
---
@@ -418,8 +427,15 @@ private boolean buildSingleFilter(Object filter,
return false;
}
- if
(!partitionkeyTypes.get(filterColumnName).equalsIgnoreCase(serdeConstants.STRING_TYPE_NAME))
{
-LOG.debug("Filter type is not string type , ignore this filter
for hive: "
+/*
+ * HAWQ-1527 - Filtering only supported for partition columns of
type string or
+ * intgeral datatype. Integral datatypes include - TINYINT,
SMALLINT, INT, BIGINT.
+ * Note that with integral data types only equals("=") and not
equals("!=") operators
+ * are supported. There are no operator restrictions with String.
+ */
+if (!colType.equalsIgnoreCase(serdeConstants.STRING_TYPE_NAME)
+&& (!isIntegralSupported ||
!serdeConstants.IntegralTypes.contains(colType))) {
--- End diff --
@lavjain - This takes care of data types that are neither integral nor
string. For example, if the column's data type is date, we don't support
filtering on any operator. It should return false. If this would have been an
OR , pxf will construct a filter since
`!colType.equalsIgnoreCase(serdeConstants.STRING_TYPE_NAME)` is true. This
filter will then be passed to hive which will throw an error as filtering is
not supported for date data when accessing hive through hcatalog.
Keeping this in mind, I have added a unit test case for the above scenario.
---
[GitHub] incubator-hawq pull request #1287: HAWQ-1527 Enabled partition filtering for...
GitHub user outofmem0ry opened a pull request: https://github.com/apache/incubator-hawq/pull/1287 HAWQ-1527 Enabled partition filtering for integral data types You can merge this pull request into a Git repository by running: $ git pull https://github.com/outofmem0ry/incubator-hawq feature/HAWQ-1527 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/1287.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1287 commit 883571eba141d63ff770fa10764842c81f4da01a Author: Shubham Sharma <shubham.uc...@gmail.com> Date: 2017-09-15T23:05:19Z HAWQ-1527 Added feature to enable partition filtering for integral data types ---
[GitHub] incubator-hawq pull request #1272: HAWQ-1198 - Fix to filter out irrelevant ...
Github user outofmem0ry closed the pull request at: https://github.com/apache/incubator-hawq/pull/1272 ---
[GitHub] incubator-hawq issue #1272: HAWQ-1198 - Fix to filter out irrelevant fragmen...
Github user outofmem0ry commented on the issue: https://github.com/apache/incubator-hawq/pull/1272 @sansanichfb Test cases added. ---
[GitHub] incubator-hawq pull request #1263: HAWQ-1495 Corrected answer file to match ...
Github user outofmem0ry closed the pull request at: https://github.com/apache/incubator-hawq/pull/1263 ---
[GitHub] incubator-hawq issue #1263: HAWQ-1495 Corrected answer file to match insert ...
Github user outofmem0ry commented on the issue: https://github.com/apache/incubator-hawq/pull/1263 @radarwave Done. Thank you for the review ---
[GitHub] incubator-hawq pull request #1267: HAWQ-1504 - Fixed namenode hang during do...
Github user outofmem0ry closed the pull request at: https://github.com/apache/incubator-hawq/pull/1267 ---
[GitHub] incubator-hawq issue #1263: HAWQ-1495 Corrected answer file to match insert ...
Github user outofmem0ry commented on the issue: https://github.com/apache/incubator-hawq/pull/1263 @paul-guo- @radarwave do you need any other inputs needed from my side ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1284: HAWQ-1524 - Fix travis ci build failure c...
GitHub user outofmem0ry opened a pull request: https://github.com/apache/incubator-hawq/pull/1284 HAWQ-1524 - Fix travis ci build failure caused after protobuf upgrade to 3.4 You can merge this pull request into a Git repository by running: $ git pull https://github.com/outofmem0ry/incubator-hawq feature/HAWQ-1524 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/1284.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1284 commit a4357501040f2e1a25356976d1de3d5fbfef8af1 Author: Shubham Sharma <shubham.uc...@gmail.com> Date: 2017-08-31T15:52:21Z HAWQ-1524 - Fix travis ci build failure after protobuf upgrade to 3.4 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1272: HAWQ-1198 - Fix to filter out irrelevant fragmen...
Github user outofmem0ry commented on the issue: https://github.com/apache/incubator-hawq/pull/1272 @edespino didn't get a chance to work on the unit cases yet, started some research around it but I need to read more about the testing frameworks used in pxf. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1263: HAWQ-1495 Corrected answer file to match insert ...
Github user outofmem0ry commented on the issue: https://github.com/apache/incubator-hawq/pull/1263 @paul-guo- updated the doc as per the review comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1272: HAWQ-1198 - Fix to filter out irrelevant ...
GitHub user outofmem0ry opened a pull request: https://github.com/apache/incubator-hawq/pull/1272 HAWQ-1198 - Fix to filter out irrelevant fragments while accessing Hive You can merge this pull request into a Git repository by running: $ git pull https://github.com/outofmem0ry/incubator-hawq feature/HAWQ-1198 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/1272.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1272 commit 4289b1c2a178e713b152fed705614c16341db01b Author: Shubham Sharma <shubham.uc...@gmail.com> Date: 2017-07-27T15:17:55Z HAWQ-1198 - Fix to filter out irrelevant fragments while accesing Hive --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1263: HAWQ-1495 Corrected answer file to match ...
Github user outofmem0ry commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1263#discussion_r127881478
--- Diff: src/test/feature/README.md ---
@@ -16,7 +16,10 @@ Before building the code of feature tests part, just
make sure your compiler sup
2. Load environment configuration by running `source
$INSTALL_PREFIX/greenplum_path.sh`.
3. Load hdfs configuration. For example, `export
HADOOP_HOME=/Users/wuhong/hadoop-2.7.2 && export
PATH=${PATH}:${HADOOP_HOME}/bin`. Since some test cases need `hdfs` and
`hadoop` command, just ensure these commands work before running. Otherwise you
will get failure.
4. Run the cases with`./parallel-run-feature-test.sh 8 ./feature-test`(in
this case 8 threads in parallel), you could use `--gtest_filter` option to
filter test cases(both positive and negative patterns are supported). Please
see more options by running `./feature-test --help`.
-5.You can also run cases with `./parallel-run-feature-test.sh 8
./feature-test --gtest_schedule` (eg. --gtest_schedule=./full_tests.txt) if you
want to run cases in both parallel way and serial way.The schedule file sample
is full_tests.txt which stays in the same directory.
+5. You can also run cases with `./parallel-run-feature-test.sh 8
./feature-test --gtest_schedule` (eg. --gtest_schedule=./full_tests.txt) if you
want to run cases in both parallel way and serial way.The schedule file sample
is full_tests.txt which stays in the same
+directory.
--- End diff --
@paul-guo- Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1268: HAWQ-1273 - Removed incorrect references ...
GitHub user outofmem0ry opened a pull request: https://github.com/apache/incubator-hawq/pull/1268 HAWQ-1273 - Removed incorrect references from gplogfilter You can merge this pull request into a Git repository by running: $ git pull https://github.com/outofmem0ry/incubator-hawq feature/HAWQ-1273-gplogfilter Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/1268.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1268 commit 993a918fbd24487cde88831b194977f4c8d43fbf Author: Shubham Sharma <shubham.uc...@gmail.com> Date: 2017-07-18T03:10:14Z HAWQ-1273 - Removed incorrect references from gplogfilter --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1266: HAWQ-1503 - Fixed ftp link causing build ...
Github user outofmem0ry closed the pull request at: https://github.com/apache/incubator-hawq/pull/1266 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1266: HAWQ-1503 - Fixed ftp link causing build failure...
Github user outofmem0ry commented on the issue: https://github.com/apache/incubator-hawq/pull/1266 @sansanichfb Thank you for the merge. Marking this closed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1266: HAWQ-1503 - Fixed ftp link causing build ...
GitHub user outofmem0ry opened a pull request: https://github.com/apache/incubator-hawq/pull/1266 HAWQ-1503 - Fixed ftp link causing build failure on centos-6 docker You can merge this pull request into a Git repository by running: $ git pull https://github.com/outofmem0ry/incubator-hawq feature/HAWQ-1503 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/1266.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1266 commit 042297486809cc7c789d014e3ee1cbb625699b54 Author: Shubham Sharma <shubham.uc...@gmail.com> Date: 2017-07-14T16:18:18Z HAWQ-1503 - Fixed unavailable ftp link causing build failure on centos6 docker --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1254: HAWQ-1373 - Added feature to reload GUC v...
Github user outofmem0ry closed the pull request at: https://github.com/apache/incubator-hawq/pull/1254 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1254: HAWQ-1373 - Added feature to reload GUC values u...
Github user outofmem0ry commented on the issue: https://github.com/apache/incubator-hawq/pull/1254 Thank you @linwen @radarwave . Closing this PR, will also submit a PR for documentation changes to apache/incubator-hawq-docs repo. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1254: HAWQ-1373 - Added feature to reload GUC values u...
Github user outofmem0ry commented on the issue: https://github.com/apache/incubator-hawq/pull/1254 @radarwave - Fixed and incorporated above comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1254: HAWQ-1373 - Added feature to reload GUC v...
Github user outofmem0ry commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1254#discussion_r125390001 --- Diff: src/test/feature/ManagementTool/test_hawq_reload.cpp --- @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#include +#include +#include "lib/command.h" +#include "lib/sql_util.h" +#include "lib/string_util.h" +#include "lib/hawq_config.h" +#include "test_hawq_reload.h" + +#include "gtest/gtest.h" + +using std::string; +using hawq::test::SQLUtility; +using hawq::test::Command; + +/* +Test case for hawq reload . This test changes the value of GUC +log_min_messages to debug. Reloads the cluster and verifies if the change +was reloaded successfully. After the test it resets the valueof GUC to --- End diff -- Thank you for pointing it out, will correct it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1254: HAWQ-1373 - Added feature to reload GUC v...
Github user outofmem0ry commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1254#discussion_r125389996
--- Diff: tools/bin/hawq ---
@@ -120,6 +120,23 @@ def main():
if second_arg not in cluster_type_list:
print STOP_HELP
sys.exit(1)
+# Prints deprecation warning when using old syntax "hawq stop
-u" to reload GUC
+if len(sub_args.split("-")) > 1:
+if "-u" in sub_args or "--reload" in sub_args or "u" in
sub_args.split("-")[1]:
+deprecationMessage = """
+hawq stop -u is being deprecated and replaced by
'hawq reload '
--- End diff --
@radarwave - I deliberately kept the messages printing different so that it
is noticeable to the user, as it is a deprecation warning.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1254: HAWQ-1373 - Added feature to reload GUC values u...
Github user outofmem0ry commented on the issue: https://github.com/apache/incubator-hawq/pull/1254 @radarwave committed the final changes, doc changes pending. Will submit a PR in docs repo. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1263: HAWQ-1495 Corrected answer file to match ...
GitHub user outofmem0ry opened a pull request:
https://github.com/apache/incubator-hawq/pull/1263
HAWQ-1495 Corrected answer file to match insert statement
In `src/test/feature/query/sql/rowtypes.sql` the value inserted into the
table is `"insert into people values ('(Joe,Blow)', '1984-01-10');"`, where
date is in the format - `1984-01-10`. But in
`src/test/feature/query/ans/rowtypes.ans`, whenever doing a "select * from
people" the answer is stored as `01-10-1984`. This causes the test to fail.
Corrected the date format and test executes successfully.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/outofmem0ry/incubator-hawq
feature/TestRowTypes-HAWQ-1495
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/1263.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1263
commit 3a6d182462ac237883b8f5702dc74ea212dcfc07
Author: Shubham Sharma <shubham.uc...@gmail.com>
Date: 2017-07-03T23:40:19Z
HAWQ-1495 Corrected answer file to match insert statements
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1254: HAWQ-1373 - Added feature to reload GUC values u...
Github user outofmem0ry commented on the issue: https://github.com/apache/incubator-hawq/pull/1254 @radarwave - am in the process of making final changes for this pull request, I don't see any existing test infrastructure for management utilities, am I missing something here. Can you point me to some existing test cases and how they are plugged into hawq code base. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1254: HAWQ-1373 - Added feature to reload GUC values u...
Github user outofmem0ry commented on the issue: https://github.com/apache/incubator-hawq/pull/1254 @linwen @stanlyxiang @radarwave - Thank you for the comments and suggestions. @radarwave - Please see the comments inline 1. I think we should keep the legacy command to do reload in case it's hard coded in some user cases, print a deprecated message should be fine. > The change that is committed prints a message as seen below and exits. I can change the message and let the command continue. ``` hawq stop cluster -u To reload GUC values without restarting hawq cluster use 'hawq reload-config ' ``` 2. Make sure all the related help messages and documents are updated. > This is something that will go into incubator-hawq-docs and am working on scoping the change for this. 3. Chose a proper name for this option before user start to use it, 'reload' or 'reload-config' or something else? > reload sounds good. Also, am open for any other suggestions 4. Add test for this option. > Sure, let me see how we plug test into the codebase. Any pointers are appreciated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1251: HAWQ-1480 - Added feature for packing a c...
Github user outofmem0ry closed the pull request at: https://github.com/apache/incubator-hawq/pull/1251 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1254: HAWQ-1373 - Added feature to reload GUC values u...
Github user outofmem0ry commented on the issue: https://github.com/apache/incubator-hawq/pull/1254 Scoped out some documentation changes which are detailed below - [Files with hawq stop cluster -u](https://github.com/apache/incubator-hawq-docs/search?utf8=%E2%9C%93=%22hawq+stop+cluster+-u%22=) [Files with hawq stop cluster --reload](https://github.com/apache/incubator-hawq-docs/search?utf8=%E2%9C%93=%22hawq+stop+cluster+--reload%22=) [Files with references to reload](https://github.com/apache/incubator-hawq-docs/search?p=1=reload+==%E2%9C%93) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1254: HAWQ-1373 - Added feature to reload GUC v...
GitHub user outofmem0ry opened a pull request: https://github.com/apache/incubator-hawq/pull/1254 HAWQ-1373 - Added feature to reload GUC values using hawq reload-config This commit introduces `hawq reload-config ` as a replacement of `hawq stop -u|--reload`, to reload GUC values without restarting the cluster. You can merge this pull request into a Git repository by running: $ git pull https://github.com/outofmem0ry/incubator-hawq feature/reload-config Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/1254.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1254 commit ce25db4e0cda2b87c25ca44fd29807380f61dafb Author: Shubham Sharma <shubham.uc...@gmail.com> Date: 2017-06-13T15:02:33Z HAWQ-1373 - Added feature to reload GUC values using hawq reload-config deprecating hawq stop -u --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1251: HAWQ-1480 - Added feature for packing a core fil...
Github user outofmem0ry commented on the issue: https://github.com/apache/incubator-hawq/pull/1251 @dyozie correct, it is not documented in greenplum. @edespino - Totally agree with your point. Keeping that in mind, earlier, I suggested documenting it under incubator-hawq-docs/markdown/admin/ as this tool is more in an administrative capacity. Let me know if that sounds good and I can start with the documentation. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1251: HAWQ-1480 - Added feature for packing a core fil...
Github user outofmem0ry commented on the issue: https://github.com/apache/incubator-hawq/pull/1251 @edespino @vVineet @linwen - Thank you for the reviews and comments. I have incorporated the changes and removed the copyright for now. @linwen What kind of documentation do you have in mind? Here are some options - - A separate markdown explaining the use case and how to, committed to this repository - Use case and how to use packcore, committed under - incubator-hawq-docs/markdown/admin/ Additional suggestions are welcomed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1251: HAWQ-1480 - Added feature for packing a c...
Github user outofmem0ry commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1251#discussion_r120470730 --- Diff: tools/sbin/packcore --- @@ -0,0 +1,262 @@ +#!/bin/env python +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# Copyright Pivotal 2014 --- End diff -- @linwen It was in the original code repo I merged it from. Wanted to keep it there for reference/credits. Something similar to what is done here- incubator-hawq/tools/sbin/hawqstandbywatch.py Let me know if it is feasible removing copyright from merged code. I can update my branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1251: HAWQ-1480 - Added feature for packing a c...
GitHub user outofmem0ry opened a pull request: https://github.com/apache/incubator-hawq/pull/1251 HAWQ-1480 - Added feature for packing a core file Currently there is no way to packing a core file with its context â executable, application and system shared libraries in hawq. This information can be later unpacked on another system and helps in debugging. It is a useful feature to quickly gather all the data needed from a crash/core generated on the system to analyze it later. Another open source project, greenplum, uses a script https://github.com/greenplum-db/gpdb/blob/master/gpMgmt/sbin/packcore to collect this information. Merging this into hawq. You can merge this pull request into a Git repository by running: $ git pull https://github.com/outofmem0ry/incubator-hawq feature-packcore Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/1251.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1251 commit c412f500e7f2020def4fd31da7ded56d8afed5b6 Author: Shubham Sharma <shubham.uc...@gmail.com> Date: 2017-06-06T04:32:15Z HAWQ-1480 - Added feature for packing a core file --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
