[GitHub] incubator-hawq pull request #1216: HAWQ-1429. Do not use AggBridge when WHER...
Github user sansanichfb closed the pull request at: https://github.com/apache/incubator-hawq/pull/1216 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1216: HAWQ-1429. Do not use AggBridge when WHER...
Github user shivzone commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1216#discussion_r111259106 --- Diff: pxf/pxf-api/src/main/java/org/apache/hawq/pxf/api/utilities/Utilities.java --- @@ -209,7 +209,8 @@ public static boolean useAggBridge(InputData inputData) { LOG.error("Unable to load accessor class: " + e.getMessage()); return false; } -return (inputData != null) && (inputData.getAggType() != null) +return (inputData != null) && !inputData.hasFilter() --- End diff -- Add an additional check to filter out queries that have aggregate that is not count(*) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1216: HAWQ-1429. Do not use AggBridge when WHER...
Github user sansanichfb commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1216#discussion_r111216993 --- Diff: pxf/pxf-api/src/main/java/org/apache/hawq/pxf/api/utilities/Utilities.java --- @@ -209,7 +209,8 @@ public static boolean useAggBridge(InputData inputData) { LOG.error("Unable to load accessor class: " + e.getMessage()); return false; } -return (inputData != null) && (inputData.getAggType() != null) +return (inputData != null) && !inputData.hasFilter() --- End diff -- Sure, added --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1216: HAWQ-1429. Do not use AggBridge when WHER...
Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1216#discussion_r90746 --- Diff: pxf/pxf-api/src/main/java/org/apache/hawq/pxf/api/utilities/Utilities.java --- @@ -209,7 +209,8 @@ public static boolean useAggBridge(InputData inputData) { LOG.error("Unable to load accessor class: " + e.getMessage()); return false; } -return (inputData != null) && (inputData.getAggType() != null) +return (inputData != null) && !inputData.hasFilter() --- End diff -- Maybe add a comment for why so many checks are required --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1216: HAWQ-1429. Do not use AggBridge when WHER...
GitHub user sansanichfb opened a pull request: https://github.com/apache/incubator-hawq/pull/1216 HAWQ-1429. Do not use AggBridge when WHERE clause specified. You can merge this pull request into a Git repository by running: $ git pull https://github.com/sansanichfb/incubator-hawq HAWQ-1429 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/1216.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1216 commit aa3c14ab123e914851adda5313741e6fe24fda56 Author: Oleksandr Diachenko Date: 2017-04-12T00:51:40Z HAWQ-1429. Do not use AggBridge when WHERE clause specified. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---