[GitHub] incubator-hawq pull request #1230: HAWQ-1453. Fixed relation_close() error a...

[liming01]

Github user liming01 closed the pull request at:

https://github.com/apache/incubator-hawq/pull/1230


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1230: HAWQ-1453. Fixed relation_close() error a...

[liming01]

Github user liming01 commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1230#discussion_r114936060
  
--- Diff: src/backend/commands/analyze.c ---
@@ -308,7 +308,7 @@ void analyzeStmt(VacuumStmt *stmt, List *relids, int 
preferred_seg_num)
ListCell*le1 = NULL;
int successCount = 0, failCount = 0;
StringInfoData  failNames;
-   ResourceOwner owner, oldOwner;
+   ResourceOwner asOwner, oldOwner1;
--- End diff --

@hsyuan and @paul-guo-,  Add comments for asOwner. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1230: HAWQ-1453. Fixed relation_close() error a...

[hsyuan]

Github user hsyuan commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1230#discussion_r114932353
  
--- Diff: src/backend/commands/analyze.c ---
@@ -308,7 +308,7 @@ void analyzeStmt(VacuumStmt *stmt, List *relids, int 
preferred_seg_num)
ListCell*le1 = NULL;
int successCount = 0, failCount = 0;
StringInfoData  failNames;
-   ResourceOwner owner, oldOwner;
+   ResourceOwner asOwner, oldOwner1;
--- End diff --

if `as` of `asOwner` means `analyzeStmt`,  we'd better add comments or 
explanation on the both vars. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1230: HAWQ-1453. Fixed relation_close() error a...

[liming01]

GitHub user liming01 opened a pull request:

https://github.com/apache/incubator-hawq/pull/1230

HAWQ-1453. Fixed relation_close() error at analyzeStmt(): not owned b…

…y resource owner TopTransaction (resowner.c:814)

The relation opened at TopResourceOwner, while close at a new transaction 
resource owner.
So when we close these relations, we need to firstly switch back to the 
TopResourceOwner.

Verified on reproducible environment. Please help me to review it. Thanks.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/liming01/incubator-hawq mli/resowner_analyze

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hawq/pull/1230.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1230


commit 03ce5ebdfab658446dd278ee99e0a5f6de40d9c5
Author: Ming LI 
Date:   2017-05-03T09:01:03Z

HAWQ-1453. Fixed relation_close() error at analyzeStmt(): not owned by 
resource owner TopTransaction (resowner.c:814)

The relation opened at TopResourceOwner, while close at a new transaction 
resource owner.
So when we close these relations, we need to firstly switch back to the 
TopResourceOwner.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---