[jira] [Commented] (HBASE-5848) Create table with EMPTY_START_ROW passed as splitKey causes the HMaster to abort
[
https://issues.apache.org/jira/browse/HBASE-5848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259411#comment-13259411
]
ramkrishna.s.vasudevan commented on HBASE-5848:
---
@Lars
I have analysed this problem.
First thing is if we pass an empty byte array it is trying to form two regions
with empty start and end keys.
But the reason for it to abort is when it tries to form the two regions it so
happens that the region id generated from the System.currenttimeInMillis
becomes same and it tries to create the same node twice. And hence we get that
aborting from the asyncSetOfflineInZooKeeper
{code}
CreateUnassignedAsyncCallback cb =
new CreateUnassignedAsyncCallback(this.watcher, destination, counter);
for (RegionState state: states) {
if (!asyncSetOfflineInZooKeeper(state, cb, state)) {
return;
}
}
{code}
The region Id is formed from
{code}
public HRegionInfo(final byte[] tableName, final byte[] startKey,
final byte[] endKey, final boolean split)
throws IllegalArgumentException {
this(tableName, startKey, endKey, split, System.currentTimeMillis());
}
{code}
So there is always a chance that we get same region id but just because the
start key and end key changes we were not encountering this problem.
I suggest we add a logic explicitly to avoid 2 regions from getting formed and
also the main thing is can we take System.nanoTime for the region id.?
Even i was not able to get this repeatedly in testcases but a real cluster
gives you the problem.
Create table with EMPTY_START_ROW passed as splitKey causes the HMaster to
abort
Key: HBASE-5848
URL: https://issues.apache.org/jira/browse/HBASE-5848
Project: HBase
Issue Type: Bug
Components: client
Reporter: Lars Hofhansl
Assignee: Lars Hofhansl
Priority: Minor
A coworker of mine just had this scenario. It does not make sense the
EMPTY_START_ROW as splitKey (since the region with the empty start key is
implicit), but it should not cause the HMaster to abort.
The abort happens because it tries to bulk assign the same region twice and
then runs into race conditions with ZK.
The same would (presumably) happen when two identical split keys are passed,
but the client blocks that. The simplest solution here is to also block
passed null or EMPTY_START_ROW as split key by the client.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5833) 0.92 build has been failing pretty consistently on TestMasterFailover....
[ https://issues.apache.org/jira/browse/HBASE-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259421#comment-13259421 ] Hudson commented on HBASE-5833: --- Integrated in HBase-0.92 #382 (See [https://builds.apache.org/job/HBase-0.92/382/]) HBASE-5833 0.92 build has been failing pretty consistently on TestMasterFailover; PART2 (Revision 1329052) Result = SUCCESS stack : Files : * /hbase/branches/0.92/CHANGES.txt * /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/client/HTable.java * /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java * /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/metrics/histogram/ExponentiallyDecayingSample.java * /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/util/JVMClusterUtil.java * /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/HBaseTestCase.java * /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/filter/TestColumnPrefixFilter.java * /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/filter/TestDependentColumnFilter.java * /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/filter/TestFilter.java * /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/filter/TestMultipleColumnPrefixFilter.java * /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/master/TestMasterFailover.java * /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/master/TestOpenedRegionHandler.java * /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/TestBlocksRead.java * /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/TestColumnSeeking.java * /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactSelection.java * /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java * /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/TestMinVersions.java * /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/TestMultiColumnScanner.java * /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/TestResettingCounters.java * /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/TestScanWithBloomError.java * /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransaction.java * /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/handler/TestCloseRegionHandler.java * /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/handler/TestOpenRegionHandler.java * /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALReplay.java * /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/util/TestMergeTool.java 0.92 build has been failing pretty consistently on TestMasterFailover - Key: HBASE-5833 URL: https://issues.apache.org/jira/browse/HBASE-5833 Project: HBase Issue Type: Bug Reporter: stack Assignee: stack Fix For: 0.92.2 Attachments: 5833-trunk.txt, 5833-v2.092.txt, 5833.txt, 5833v3092.txt, 5833v4092.txt, closehregions.txt Trunk seems fine but 0.92 fails on this test pretty regularly. Running it local it seems to hang for me. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5654) [findbugs] Address dodgy bugs
[
https://issues.apache.org/jira/browse/HBASE-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259434#comment-13259434
]
Jonathan Hsieh commented on HBASE-5654:
---
@Ashotosh - sorry for the delay on review. Looks good.
I believe this isn't needed - looks like it was fixed in code. I'll submit a
new version of the patch with this excluded and to get the new findbug numbers,
and commit.
{code}
+ Match
+ Class
name=org.apache.hadoop.hbase.regionserver.StoreFile$Comparators$1/
+ Or
+ Method name=apply /
+ /Or
+ Bug pattern=NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE /
+ /Match
{code}
[findbugs] Address dodgy bugs
-
Key: HBASE-5654
URL: https://issues.apache.org/jira/browse/HBASE-5654
Project: HBase
Issue Type: Sub-task
Components: scripts
Affects Versions: 0.96.0
Reporter: Jonathan Hsieh
Assignee: Ashutosh Jindal
Labels: patch
Fix For: 0.96.0
Attachments: Hbase 5654_v3.patch, Hbase-5654.patch,
Hbase_5654_V2.patch
See
https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html#Warnings_STYLE
This may be broken down further.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5654) [findbugs] Address dodgy bugs
[ https://issues.apache.org/jira/browse/HBASE-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Hsieh updated HBASE-5654: -- Attachment: hbase-5654-tweak.patch [findbugs] Address dodgy bugs - Key: HBASE-5654 URL: https://issues.apache.org/jira/browse/HBASE-5654 Project: HBase Issue Type: Sub-task Components: scripts Affects Versions: 0.96.0 Reporter: Jonathan Hsieh Assignee: Ashutosh Jindal Labels: patch Fix For: 0.96.0 Attachments: Hbase 5654_v3.patch, Hbase-5654.patch, Hbase_5654_V2.patch, hbase-5654-tweak.patch See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html#Warnings_STYLE This may be broken down further. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5652) [findbugs] Fix lock release on all paths
[ https://issues.apache.org/jira/browse/HBASE-5652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259439#comment-13259439 ] Jonathan Hsieh commented on HBASE-5652: --- I side with Greg here. I'd rather we only add excludes for things that *must* be put there. In that particular case, we have readable and reasonable code that does not require the exclude. [findbugs] Fix lock release on all paths - Key: HBASE-5652 URL: https://issues.apache.org/jira/browse/HBASE-5652 Project: HBase Issue Type: Sub-task Components: scripts Reporter: Jonathan Hsieh Assignee: Gregory Chanan Attachments: HBASE-5652-v0.patch See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html#Warnings_MT_CORRECTNESS Category UL -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5801) [hbck] Hbck should handle case where some regions have different HTD settings in .regioninfo files (0.90 specific)
[ https://issues.apache.org/jira/browse/HBASE-5801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259449#comment-13259449 ] jirapos...@reviews.apache.org commented on HBASE-5801: -- --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4833/#review7126 --- Hey Jimmy, looks pretty nice but there are few things to take care of. Can you follow up on some of the comments below? src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java https://reviews.apache.org/r/4833/#comment15741 Check return value and warn / throw exn if fails. src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java https://reviews.apache.org/r/4833/#comment15742 Check return value and warn / throw exn if fails. src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java https://reviews.apache.org/r/4833/#comment15745 I think this warning should always be emitted whenever we have != 1 htds.size(). src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java https://reviews.apache.org/r/4833/#comment15747 Did you intend for this to always happen or only if the user had set the fixTableDesc option? src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java https://reviews.apache.org/r/4833/#comment15746 This should probably at least WARN. src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java https://reviews.apache.org/r/4833/#comment15743 typo: Mutliple src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java https://reviews.apache.org/r/4833/#comment15744 nit: awkward comment. - jmhsieh On 2012-04-20 22:45:47, Jimmy Xiang wrote: bq. bq. --- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/4833/ bq. --- bq. bq. (Updated 2012-04-20 22:45:47) bq. bq. bq. Review request for hbase and jmhsieh. bq. bq. bq. Summary bq. --- bq. bq. Added option to fix inconsistent table descriptors: bq. 1. sideline the current .regioninfo file bq. 2. create a new one with HTD from HBaseAdmin (meta, first entry) bq. 3. offline the region and wait till it assigned again bq. bq. bq. This addresses bug HBASE-5801. bq. https://issues.apache.org/jira/browse/HBASE-5801 bq. bq. bq. Diffs bq. - bq. bq.src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 50f9128 bq.src/main/java/org/apache/hadoop/hbase/util/HBaseFsckRepair.java 06d2b73 bq.src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java 103d8bf bq. bq. Diff: https://reviews.apache.org/r/4833/diff bq. bq. bq. Testing bq. --- bq. bq. TestHBaseFsck* are green. On live cluster, it does the fix as expected. bq. bq. bq. Thanks, bq. bq. Jimmy bq. bq. [hbck] Hbck should handle case where some regions have different HTD settings in .regioninfo files (0.90 specific) --- Key: HBASE-5801 URL: https://issues.apache.org/jira/browse/HBASE-5801 Project: HBase Issue Type: Improvement Components: hbck Affects Versions: 0.90.7 Reporter: Jonathan Hsieh Assignee: Jimmy Xiang Recently, we encountered a case where some regions in a table have different HTableDescriptor settings serialized into HDFS their HRegionInfo .regioninfo file. hbck expects all HTDs within a table to be the same and currently bails out in this situation. We need to either point out a proper set of actions for the user to execute or automatically convert the region to a common HTD (likely the most common on, or possibly the first one.) Not sure if this requires reformatting data but may require closing and restarting a region. This issue is hbase 0.90.x specific -- 0.92+ keep all table info in a single .tableinfo file. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5654) [findbugs] Address dodgy bugs
[ https://issues.apache.org/jira/browse/HBASE-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259459#comment-13259459 ] Hadoop QA commented on HBASE-5654: -- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12523764/hbase-5654-tweak.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1605//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1605//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1605//console This message is automatically generated. [findbugs] Address dodgy bugs - Key: HBASE-5654 URL: https://issues.apache.org/jira/browse/HBASE-5654 Project: HBase Issue Type: Sub-task Components: scripts Affects Versions: 0.96.0 Reporter: Jonathan Hsieh Assignee: Ashutosh Jindal Labels: patch Fix For: 0.96.0 Attachments: Hbase 5654_v3.patch, Hbase-5654.patch, Hbase_5654_V2.patch, hbase-5654-tweak.patch See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html#Warnings_STYLE This may be broken down further. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (HBASE-5853) java.lang.RuntimeException: readObject can't find class org.apache.hadoop.hdfs.protocol.HdfsFileStatus
jiafeng.zhang created HBASE-5853: Summary: java.lang.RuntimeException: readObject can't find class org.apache.hadoop.hdfs.protocol.HdfsFileStatus Key: HBASE-5853 URL: https://issues.apache.org/jira/browse/HBASE-5853 Project: HBase Issue Type: Bug Components: regionserver Affects Versions: 0.92.1 Environment: hadoop-0.23.1 hbase-0.92.1 Reporter: jiafeng.zhang Fix For: 0.92.1 2012-04-23 12:51:07,474 WARN org.apache.hadoop.ipc.Client: Unexpected error reading responses on connection Thread[IPC Client (1260987126) connection to server121/172.16.40.121:9000 from smp,5,main] java.lang.RuntimeException: readObject can't find class org.apache.hadoop.hdfs.protocol.HdfsFileStatus at org.apache.hadoop.io.ObjectWritable.loadClass(ObjectWritable.java:372) at org.apache.hadoop.io.ObjectWritable.readObject(ObjectWritable.java:223) at org.apache.hadoop.io.ObjectWritable.readFields(ObjectWritable.java:75) at org.apache.hadoop.ipc.Client$Connection.receiveResponse(Client.java:832) at org.apache.hadoop.ipc.Client$Connection.run(Client.java:756) Caused by: java.lang.ClassNotFoundException: Class org.apache.hadoop.hdfs.protocol.HdfsFileStatus not found at org.apache.hadoop.conf.Configuration.getClassByName(Configuration.java:1151) at org.apache.hadoop.io.ObjectWritable.loadClass(ObjectWritable.java:368) ... 4 more 2012-04-23 12:51:07,797 FATAL org.apache.hadoop.hbase.regionserver.HRegionServer: ABORTING region server server124,60020,1335152900476: Replay of HLog required. Forcing server shutdown org.apache.hadoop.hbase.DroppedSnapshotException: region: hbase_cdr,e0072b2b-5e19-431f-bb69-a6427765eac4,1334902272934.8365a7cbf90dd558f297d70224113c8a. at org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:1278) at org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:1162) at org.apache.hadoop.hbase.regionserver.HRegion.flushcache(HRegion.java:1104) at org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:400) at org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushOneForGlobalPressure(MemStoreFlusher.java:202) at org.apache.hadoop.hbase.regionserver.MemStoreFlusher.run(MemStoreFlusher.java:223) at java.lang.Thread.run(Thread.java:662) Caused by: java.io.IOException: Failed on local exception: java.io.IOException: Error reading responses; Host Details : local host is: server124/172.16.40.124; destination host is: server121:9000; at org.apache.hadoop.net.NetUtils.wrapException(NetUtils.java:724) at org.apache.hadoop.ipc.Client.call(Client.java:1094) at org.apache.hadoop.ipc.WritableRpcEngine$Invoker.invoke(WritableRpcEngine.java:193) at $Proxy10.getFileInfo(Unknown Source) at sun.reflect.GeneratedMethodAccessor15.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.apache.hadoop.io.retry.RetryInvocationHandler.invokeMethod(RetryInvocationHandler.java:100) at org.apache.hadoop.io.retry.RetryInvocationHandler.invoke(RetryInvocationHandler.java:65) at $Proxy10.getFileInfo(Unknown Source) at org.apache.hadoop.hdfs.DFSClient.getFileInfo(DFSClient.java:1172) at org.apache.hadoop.hdfs.DistributedFileSystem.getFileStatus(DistributedFileSystem.java:725) at org.apache.hadoop.hbase.regionserver.StoreFile.computeHDFSBlockDistribution(StoreFile.java:449) at org.apache.hadoop.hbase.regionserver.StoreFile.open(StoreFile.java:473) at org.apache.hadoop.hbase.regionserver.StoreFile.createReader(StoreFile.java:548) at org.apache.hadoop.hbase.regionserver.Store.internalFlushCache(Store.java:595) at org.apache.hadoop.hbase.regionserver.Store.flushCache(Store.java:506) at org.apache.hadoop.hbase.regionserver.Store.access$100(Store.java:89) at org.apache.hadoop.hbase.regionserver.Store$StoreFlusherImpl.flushCache(Store.java:1905) at org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:1254) ... 6 more Caused by: java.io.IOException: Error reading responses at org.apache.hadoop.ipc.Client$Connection.run(Client.java:763) Caused by: java.lang.RuntimeException: readObject can't find class org.apache.hadoop.hdfs.protocol.HdfsFileStatus at org.apache.hadoop.io.ObjectWritable.loadClass(ObjectWritable.java:372) at org.apache.hadoop.io.ObjectWritable.readObject(ObjectWritable.java:223) at org.apache.hadoop.io.ObjectWritable.readFields(ObjectWritable.java:75) at
[jira] [Created] (HBASE-5854) [findbugs] Fix hbck findubugs warnings
Jonathan Hsieh created HBASE-5854: - Summary: [findbugs] Fix hbck findubugs warnings Key: HBASE-5854 URL: https://issues.apache.org/jira/browse/HBASE-5854 Project: HBase Issue Type: Sub-task Components: hbck Reporter: Jonathan Hsieh Assignee: Jonathan Hsieh In the reviews for HBASE-5654, Jon said he'd take on fixing the hbck findbugs warnings. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (HBASE-5855) [findbugs] address remaining findbugs warnings
Jonathan Hsieh created HBASE-5855: - Summary: [findbugs] address remaining findbugs warnings Key: HBASE-5855 URL: https://issues.apache.org/jira/browse/HBASE-5855 Project: HBase Issue Type: Sub-task Reporter: Jonathan Hsieh As we've been cleaning up the code related to findbugs warnings, new patches are coming in that introduce new warnings. This would is the last sub-isuse that will cleanup any recently introduced warnings. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (HBASE-5855) [findbugs] address remaining findbugs warnings
[ https://issues.apache.org/jira/browse/HBASE-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259460#comment-13259460 ] Jonathan Hsieh edited comment on HBASE-5855 at 4/23/12 8:40 AM: This includes any new warnings in the Dodgy, Perf, Correctness classes. was (Author: jmhsieh): This includes anything new warnings in the Dodgy, Perf, Correctness classes. [findbugs] address remaining findbugs warnings --- Key: HBASE-5855 URL: https://issues.apache.org/jira/browse/HBASE-5855 Project: HBase Issue Type: Sub-task Reporter: Jonathan Hsieh As we've been cleaning up the code related to findbugs warnings, new patches are coming in that introduce new warnings. This would is the last sub-isuse that will cleanup any recently introduced warnings. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5855) [findbugs] address remaining findbugs warnings
[ https://issues.apache.org/jira/browse/HBASE-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259460#comment-13259460 ] Jonathan Hsieh commented on HBASE-5855: --- This includes anything new warnings in the Dodgy, Perf, Correctness classes. [findbugs] address remaining findbugs warnings --- Key: HBASE-5855 URL: https://issues.apache.org/jira/browse/HBASE-5855 Project: HBase Issue Type: Sub-task Reporter: Jonathan Hsieh As we've been cleaning up the code related to findbugs warnings, new patches are coming in that introduce new warnings. This would is the last sub-isuse that will cleanup any recently introduced warnings. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5654) [findbugs] Address dodgy bugs
[ https://issues.apache.org/jira/browse/HBASE-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Hsieh updated HBASE-5654: -- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) There are a few new issues in this category so I've filed follow on Jiras (HBASE-5854, HBASE-5855) for them. The findbugs count on the previous run was 523 so I've modified the patch to change to that number. Committed to trunk/0.96. Thanks Ashutosh! [findbugs] Address dodgy bugs - Key: HBASE-5654 URL: https://issues.apache.org/jira/browse/HBASE-5654 Project: HBase Issue Type: Sub-task Components: scripts Affects Versions: 0.96.0 Reporter: Jonathan Hsieh Assignee: Ashutosh Jindal Labels: patch Fix For: 0.96.0 Attachments: Hbase 5654_v3.patch, Hbase-5654.patch, Hbase_5654_V2.patch, hbase-5654-tweak.patch See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html#Warnings_STYLE This may be broken down further. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5654) [findbugs] Address dodgy bugs
[ https://issues.apache.org/jira/browse/HBASE-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Hsieh updated HBASE-5654: -- Attachment: hbase-5654_v5.patch [findbugs] Address dodgy bugs - Key: HBASE-5654 URL: https://issues.apache.org/jira/browse/HBASE-5654 Project: HBase Issue Type: Sub-task Components: scripts Affects Versions: 0.96.0 Reporter: Jonathan Hsieh Assignee: Ashutosh Jindal Labels: patch Fix For: 0.96.0 Attachments: Hbase 5654_v3.patch, Hbase-5654.patch, Hbase_5654_V2.patch, hbase-5654-tweak.patch, hbase-5654_v5.patch See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html#Warnings_STYLE This may be broken down further. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5654) [findbugs] Address dodgy bugs
[ https://issues.apache.org/jira/browse/HBASE-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259486#comment-13259486 ] Hudson commented on HBASE-5654: --- Integrated in HBase-TRUNK #2797 (See [https://builds.apache.org/job/HBase-TRUNK/2797/]) HBASE-5654 [findbugs] Address dodgy bugs (Ashutosh Jindal) (Revision 1329132) Result = FAILURE jmhsieh : Files : * /hbase/trunk/dev-support/findbugs-exclude.xml * /hbase/trunk/dev-support/test-patch.properties * /hbase/trunk/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/HServerLoad.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/FilterList.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/AbstractHFileWriter.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/IncreasingToUpperBoundRegionSplitPolicy.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreLAB.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionProgress.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/ByteBloomFilter.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/CompoundBloomFilterWriter.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/CompressionTest.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/FSHDFSUtils.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/PoolMap.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/RegionSplitter.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java [findbugs] Address dodgy bugs - Key: HBASE-5654 URL: https://issues.apache.org/jira/browse/HBASE-5654 Project: HBase Issue Type: Sub-task Components: scripts Affects Versions: 0.96.0 Reporter: Jonathan Hsieh Assignee: Ashutosh Jindal Labels: patch Fix For: 0.96.0 Attachments: Hbase 5654_v3.patch, Hbase-5654.patch, Hbase_5654_V2.patch, hbase-5654-tweak.patch, hbase-5654_v5.patch See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html#Warnings_STYLE This may be broken down further. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (HBASE-5856) byte - String is not consistent between HBaseAdmin and HRegionInfo
binlijin created HBASE-5856:
---
Summary: byte - String is not consistent between HBaseAdmin and
HRegionInfo
Key: HBASE-5856
URL: https://issues.apache.org/jira/browse/HBASE-5856
Project: HBase
Issue Type: Bug
Components: client
Affects Versions: 0.92.1, 0.90.6
Reporter: binlijin
In HBaseAdmin
public void split(final String tableNameOrRegionName)
throws IOException, InterruptedException {
split(Bytes.toBytes(tableNameOrRegionName)); // string - byte
}
In HRegionInfo
this.regionNameStr = Bytes.toStringBinary(this.regionName); // byte - string
Should we use Bytes.toBytesBinary in HBaseAdmin ？
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5856) byte - String is not consistent between HBaseAdmin and HRegionInfo
[
https://issues.apache.org/jira/browse/HBASE-5856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259491#comment-13259491
]
binlijin commented on HBASE-5856:
-
for example, one region's information HRegionInfo is :
regionNameStr：
testsplit,\x00\x00\x00\x00\x00\x00\x00\x00,1335169851181.79d80fbc6c4f6cfc2cdca8a5310b7223.
regionName ：
[116, 101, 115, 116, 115, 112, 108, 105, 116, 44, 0, 0, 0, 0, 0, 0, 0, 0, 44,
49, 51, 51, 53, 49, 54, 57, 56, 53, 49, 49, 56, 49, 46, 55, 57, 100, 56, 48,
102, 98, 99, 54, 99, 52, 102, 54, 99, 102, 99, 50, 99, 100, 99, 97, 56, 97, 53,
51, 49, 48, 98, 55, 50, 50, 51, 46]
if we use HBaseAdmin.split(regionName), this is correct, but if we use
HBaseAdmin.split(regionNameStr); this is wrong.
Because Bytes.toBytes(regionNameStr) will get byte : [116, 101, 115, 116, 115,
112, 108, 105, 116, 44, 92, 120, 48, 48, 92, 120, 48, 48, 92, 120, 48, 48, 92,
120, 48, 48, 92, 120, 48, 48, 92, 120, 48, 48, 92, 120, 48, 48, 92, 120, 48,
48, 44, 49, 51, 51, 53, 49, 54, 57, 56, 53, 49, 49, 56, 49, 46, 55, 57, 100,
56, 48, 102, 98, 99, 54, 99, 52, 102, 54, 99, 102, 99, 50, 99, 100, 99, 97, 56,
97, 53, 51, 49, 48, 98, 55, 50, 50, 51, 46], this will get a
TableNotFoundException in 0.92
byte - String is not consistent between HBaseAdmin and HRegionInfo
Key: HBASE-5856
URL: https://issues.apache.org/jira/browse/HBASE-5856
Project: HBase
Issue Type: Bug
Components: client
Affects Versions: 0.90.6, 0.92.1
Reporter: binlijin
In HBaseAdmin
public void split(final String tableNameOrRegionName)
throws IOException, InterruptedException {
split(Bytes.toBytes(tableNameOrRegionName)); // string - byte
}
In HRegionInfo
this.regionNameStr = Bytes.toStringBinary(this.regionName); // byte -
string
Should we use Bytes.toBytesBinary in HBaseAdmin ？
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (HBASE-5857) RIT map in RS not getting cleared while region opening
Chinna Rao Lalam created HBASE-5857:
---
Summary: RIT map in RS not getting cleared while region opening
Key: HBASE-5857
URL: https://issues.apache.org/jira/browse/HBASE-5857
Project: HBase
Issue Type: Bug
Affects Versions: 0.90.6
Reporter: Chinna Rao Lalam
Fix For: 0.92.2, 0.96.0, 0.94.1
While opening the region in RS after adding the region to
regionsInTransitionInRS if tableDescriptors.get() throws exception the region
wont be cleared from regionsInTransitionInRS. So next time if it tries to open
the region in the same RS it will throw the RegionAlreadyInTransitionException.
if swap the below statement this issue wont come.
{code}
this.regionsInTransitionInRS.putIfAbsent(region.getEncodedNameAsBytes(),true);
HTableDescriptor htd = this.tableDescriptors.get(region.getTableName());
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5857) RIT map in RS not getting cleared while region opening
[
https://issues.apache.org/jira/browse/HBASE-5857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259495#comment-13259495
]
Chinna Rao Lalam commented on HBASE-5857:
-
I will upload the patch with test case if test case is possible.
RIT map in RS not getting cleared while region opening
--
Key: HBASE-5857
URL: https://issues.apache.org/jira/browse/HBASE-5857
Project: HBase
Issue Type: Bug
Affects Versions: 0.90.6
Reporter: Chinna Rao Lalam
Fix For: 0.92.2, 0.96.0, 0.94.1
While opening the region in RS after adding the region to
regionsInTransitionInRS if tableDescriptors.get() throws exception the region
wont be cleared from regionsInTransitionInRS. So next time if it tries to
open the region in the same RS it will throw the
RegionAlreadyInTransitionException.
if swap the below statement this issue wont come.
{code}
this.regionsInTransitionInRS.putIfAbsent(region.getEncodedNameAsBytes(),true);
HTableDescriptor htd = this.tableDescriptors.get(region.getTableName());
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5857) RIT map in RS not getting cleared while region opening
[
https://issues.apache.org/jira/browse/HBASE-5857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259497#comment-13259497
]
ramkrishna.s.vasudevan commented on HBASE-5857:
---
Yes.. Good one. we can try writing a test case.
RIT map in RS not getting cleared while region opening
--
Key: HBASE-5857
URL: https://issues.apache.org/jira/browse/HBASE-5857
Project: HBase
Issue Type: Bug
Affects Versions: 0.90.6
Reporter: Chinna Rao Lalam
Fix For: 0.92.2, 0.96.0, 0.94.1
While opening the region in RS after adding the region to
regionsInTransitionInRS if tableDescriptors.get() throws exception the region
wont be cleared from regionsInTransitionInRS. So next time if it tries to
open the region in the same RS it will throw the
RegionAlreadyInTransitionException.
if swap the below statement this issue wont come.
{code}
this.regionsInTransitionInRS.putIfAbsent(region.getEncodedNameAsBytes(),true);
HTableDescriptor htd = this.tableDescriptors.get(region.getTableName());
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5654) [findbugs] Address dodgy bugs
[ https://issues.apache.org/jira/browse/HBASE-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259498#comment-13259498 ] Ashutosh Jindal commented on HBASE-5654: @Jon Thanks for your review and patch you attached for the remaining bugs. [findbugs] Address dodgy bugs - Key: HBASE-5654 URL: https://issues.apache.org/jira/browse/HBASE-5654 Project: HBase Issue Type: Sub-task Components: scripts Affects Versions: 0.96.0 Reporter: Jonathan Hsieh Assignee: Ashutosh Jindal Labels: patch Fix For: 0.96.0 Attachments: Hbase 5654_v3.patch, Hbase-5654.patch, Hbase_5654_V2.patch, hbase-5654-tweak.patch, hbase-5654_v5.patch See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html#Warnings_STYLE This may be broken down further. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5773) HtablePool constructor not reading config files in certain cases
[
https://issues.apache.org/jira/browse/HBASE-5773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259505#comment-13259505
]
Hudson commented on HBASE-5773:
---
Integrated in HBase-0.92-security #105 (See
[https://builds.apache.org/job/HBase-0.92-security/105/])
HBASE-5773 HtablePool constructor not reading config files in certain cases
(Revision 1325383)
Result = FAILURE
stack :
Files :
* /hbase/branches/0.92/CHANGES.txt
*
/hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java
HtablePool constructor not reading config files in certain cases
Key: HBASE-5773
URL: https://issues.apache.org/jira/browse/HBASE-5773
Project: HBase
Issue Type: Bug
Components: client
Affects Versions: 0.90.6, 0.92.1, 0.94.1
Reporter: Ioan Eugen Stan
Priority: Minor
Fix For: 0.90.7, 0.92.2, 0.94.0
Attachments: different-config-behaviour.90.patch,
different-config-behaviour.90.patch, different-config-behaviour.patch
Creating a HtablePool can issue two behaviour depanding on the constructor
called.
Case 1: loads the configs from hbase-site
public HTablePool() {
this(HBaseConfiguration.create(), Integer.MAX_VALUE);
}
Calling this with null values for Configuration:
public HTablePool(final Configuration config, final int maxSize) {
this(config, maxSize, null, null);
}
will issue:
public HTablePool(final Configuration config, final int maxSize,
final HTableInterfaceFactory tableFactory, PoolType poolType) {
// Make a new configuration instance so I can safely cleanup when
// done with the pool.
this.config = config == null ? new Configuration() : config;
which does not read the hbase-site config files as
HBaseConfiguration.create() does.
I've tracked this problem to all versions of hbase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5787) Table owner can't disable/delete its own table
[
https://issues.apache.org/jira/browse/HBASE-5787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259506#comment-13259506
]
Hudson commented on HBASE-5787:
---
Integrated in HBase-0.92-security #105 (See
[https://builds.apache.org/job/HBase-0.92-security/105/])
HBASE-5787 Table owner can't disable/delete its own table (Matteo)
(Revision 1327758)
Result = FAILURE
tedyu :
Files :
* /hbase/branches/0.92/CHANGES.txt
*
/hbase/branches/0.92/security/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java
*
/hbase/branches/0.92/security/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java
Table owner can't disable/delete its own table
--
Key: HBASE-5787
URL: https://issues.apache.org/jira/browse/HBASE-5787
Project: HBase
Issue Type: Bug
Components: security
Affects Versions: 0.92.1, 0.94.0, 0.96.0
Reporter: Matteo Bertozzi
Assignee: Matteo Bertozzi
Priority: Minor
Labels: acl, security
Fix For: 0.92.2, 0.96.0, 0.94.1
Attachments: HBASE-5787-tests-wrong-names.patch, HBASE-5787-v0.patch,
HBASE-5787-v1.patch
An user with CREATE privileges can create a table, but can not disable it,
because disable operation require ADMIN privileges. Also if a table is
already disabled, anyone can remove it.
{code}
public void preDeleteTable(ObserverContextMasterCoprocessorEnvironment c,
byte[] tableName) throws IOException {
requirePermission(Permission.Action.CREATE);
}
public void preDisableTable(ObserverContextMasterCoprocessorEnvironment c,
byte[] tableName) throws IOException {
/* TODO: Allow for users with global CREATE permission and the table owner
*/
requirePermission(Permission.Action.ADMIN);
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5488) OfflineMetaRepair doesn't support hadoop 0.20's fs.default.name property
[ https://issues.apache.org/jira/browse/HBASE-5488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259503#comment-13259503 ] Hudson commented on HBASE-5488: --- Integrated in HBase-0.92-security #105 (See [https://builds.apache.org/job/HBase-0.92-security/105/]) HBASE-5488 OfflineMetaRepair doesn't support hadoop 0.20's fs.default.name property (gaojinchao) (Revision 1325627) Result = FAILURE jmhsieh : Files : * /hbase/branches/0.92/CHANGES.txt * /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/util/hbck/OfflineMetaRepair.java OfflineMetaRepair doesn't support hadoop 0.20's fs.default.name property Key: HBASE-5488 URL: https://issues.apache.org/jira/browse/HBASE-5488 Project: HBase Issue Type: Bug Affects Versions: 0.90.6 Reporter: gaojinchao Assignee: gaojinchao Priority: Minor Fix For: 0.90.7, 0.92.2, 0.94.0, 0.96.0 Attachments: HBASE-5488-branch92.patch, HBASE-5488-trunk.patch, HBASE-5488_branch90.txt, hbase-5488-v2.patch I want to use OfflineMetaRepair tools and found onbody fix this bugs. I will make a patch. 12/01/05 23:23:30 ERROR util.HBaseFsck: Bailed out due to: java.lang.IllegalArgumentException: Wrong FS: hdfs:// us01-ciqps1-name01.carrieriq.com:9000/hbase/M2M-INTEGRATION-MM_TION-13 25190318714/0003d2ede27668737e192d8430dbe5d0/.regioninfo, expected: file:/// at org.apache.hadoop.fs.FileSystem.checkPath(FileSystem.java:352) at org.apache.hadoop.fs.RawLocalFileSystem.pathToFile(RawLocalFileSystem.java:47) at org.apache.hadoop.fs.RawLocalFileSystem.getFileStatus(RawLocalFileSystem.java:368) at org.apache.hadoop.fs.FilterFileSystem.getFileStatus(FilterFileSystem.java:251) at org.apache.hadoop.fs.ChecksumFileSystem$ChecksumFSInputChecker.init(ChecksumFileSystem.java:126) at org.apache.hadoop.fs.ChecksumFileSystem.open(ChecksumFileSystem.java:284) at org.apache.hadoop.fs.FileSystem.open(FileSystem.java:398) at org.apache.hadoop.hbase.util.HBaseFsck.loadMetaEntry(HBaseFsck.java:256) at org.apache.hadoop.hbase.util.HBaseFsck.loadTableInfo(HBaseFsck.java:284) at org.apache.hadoop.hbase.util.HBaseFsck.rebuildMeta(HBaseFsck.java:402) at org.apache.hadoop.hbase.util.hbck.OfflineMetaRepair.main(OfflineMetaRe -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5680) Improve compatibility warning about HBase with Hadoop 0.23.x
[ https://issues.apache.org/jira/browse/HBASE-5680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259507#comment-13259507 ] Hudson commented on HBASE-5680: --- Integrated in HBase-0.92-security #105 (See [https://builds.apache.org/job/HBase-0.92-security/105/]) HBASE-5680 Improve compatibility warning about HBase with Hadoop 0.23.x (Revision 1310434) Result = FAILURE jmhsieh : Files : * /hbase/branches/0.92/CHANGES.txt * /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/master/HMaster.java Improve compatibility warning about HBase with Hadoop 0.23.x Key: HBASE-5680 URL: https://issues.apache.org/jira/browse/HBASE-5680 Project: HBase Issue Type: Bug Components: master Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0 Reporter: Kristam Subba Swathi Assignee: Jonathan Hsieh Fix For: 0.90.7, 0.92.2, 0.94.0, 0.96.0 Attachments: hbase-5680-94.patch Hmaster is not able to start because of the following error Please find the following error 2012-03-30 11:12:19,487 FATAL org.apache.hadoop.hbase.master.HMaster: Unhandled exception. Starting shutdown. java.lang.NoClassDefFoundError: org/apache/hadoop/hdfs/protocol/FSConstants$SafeModeAction at org.apache.hadoop.hbase.util.FSUtils.waitOnSafeMode(FSUtils.java:524) at org.apache.hadoop.hbase.master.MasterFileSystem.checkRootDir(MasterFileSystem.java:324) at org.apache.hadoop.hbase.master.MasterFileSystem.createInitialFileSystemLayout(MasterFileSystem.java:127) at org.apache.hadoop.hbase.master.MasterFileSystem.init(MasterFileSystem.java:112) at org.apache.hadoop.hbase.master.HMaster.finishInitialization(HMaster.java:496) at org.apache.hadoop.hbase.master.HMaster.run(HMaster.java:363) at java.lang.Thread.run(Thread.java:662) Caused by: java.lang.ClassNotFoundException: org.apache.hadoop.hdfs.protocol.FSConstants$SafeModeAction at java.net.URLClassLoader$1.run(URLClassLoader.java:202) at java.security.AccessController.doPrivileged(Native Method) at java.net.URLClassLoader.findClass(URLClassLoader.java:190) at java.lang.ClassLoader.loadClass(ClassLoader.java:306) at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:301) at java.lang.ClassLoader.loadClass(ClassLoader.java:247) ... 7 more There is a change in the FSConstants -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5793) TestHBaseFsck#TestNoHdfsTable test hangs after client retries increased
[
https://issues.apache.org/jira/browse/HBASE-5793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259504#comment-13259504
]
Hudson commented on HBASE-5793:
---
Integrated in HBase-0.92-security #105 (See
[https://builds.apache.org/job/HBase-0.92-security/105/])
HBASE-5793 TestHBaseFsck#testNoHdfsTable test hangs after client retries
increased (Revision 1326436)
Result = FAILURE
jmhsieh :
Files :
* /hbase/branches/0.92/CHANGES.txt
*
/hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java
TestHBaseFsck#TestNoHdfsTable test hangs after client retries increased
---
Key: HBASE-5793
URL: https://issues.apache.org/jira/browse/HBASE-5793
Project: HBase
Issue Type: Sub-task
Affects Versions: 0.96.0
Reporter: Jonathan Hsieh
Assignee: Jonathan Hsieh
Fix For: 0.90.7, 0.92.2, 0.94.0, 0.96.0
Attachments: hbase-5793.patch
After the HBASE-5747 modification, this one particular case hangs.
{code}
mvn test -PlocalTests -Dtest=TestHBaseFsck
{code}
It was hanging on a scan of a table that the test deleted. It expected a call
to thrown an exception after a timeout. HBASE-5747 changed the timeout to a
larger number of retries which caused mvn to fail the test.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5618) SplitLogManager - prevent unnecessary attempts to resubmits
[ https://issues.apache.org/jira/browse/HBASE-5618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259508#comment-13259508 ] Hudson commented on HBASE-5618: --- Integrated in HBase-0.92-security #105 (See [https://builds.apache.org/job/HBase-0.92-security/105/]) HBASE-5618 SplitLogManager - prevent unnecessary attempts to resubmits (Revision 1310921) Result = FAILURE stack : Files : * /hbase/branches/0.92/CHANGES.txt * /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java SplitLogManager - prevent unnecessary attempts to resubmits --- Key: HBASE-5618 URL: https://issues.apache.org/jira/browse/HBASE-5618 Project: HBase Issue Type: Improvement Components: wal, zookeeper Reporter: Prakash Khemani Assignee: Prakash Khemani Fix For: 0.92.2, 0.94.0 Attachments: 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch Currently once a watch fires that the task node has been updated (hearbeated) by the worker, the splitlogmanager still quite some time before it updates the last heard from time. This is because the manager currently schedules another getDataSetWatch() and only after that finishes will it update the task's last heard from time. This leads to a large number of zk-BadVersion warnings when resubmission is continuously attempted and it fails. Two changes should be made (1) On a resubmission failure because of BadVersion the task's lastUpdate time should get upped. (2) The task's lastUpdate time should get upped as soon as the nodeDataChanged() watch fires and without waiting for getDataSetWatch() to complete. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5748) Enable lib directory in jar file for coprocessor
[ https://issues.apache.org/jira/browse/HBASE-5748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259511#comment-13259511 ] Hudson commented on HBASE-5748: --- Integrated in HBase-0.92-security #105 (See [https://builds.apache.org/job/HBase-0.92-security/105/]) HBASE-5748 Enable lib directory in jar file for coprocessor (Revision 1311503) Result = FAILURE stack : Files : * /hbase/branches/0.92/CHANGES.txt * /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java * /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java Enable lib directory in jar file for coprocessor Key: HBASE-5748 URL: https://issues.apache.org/jira/browse/HBASE-5748 Project: HBase Issue Type: Improvement Components: coprocessors Affects Versions: 0.92.1, 0.94.0 Reporter: Takuya Ueshin Assignee: Takuya Ueshin Fix For: 0.92.2, 0.94.0 Attachments: HBASE-5748.patch Hadoop MapReduce job can use external libraries in 'lib' directory in the job.jar file. It is useful that jar files for coprocessor can use external libraries in the same way. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5735) Clearer warning message when connecting a non-secure HBase client to a secure HBase server
[ https://issues.apache.org/jira/browse/HBASE-5735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259513#comment-13259513 ] Hudson commented on HBASE-5735: --- Integrated in HBase-0.92-security #105 (See [https://builds.apache.org/job/HBase-0.92-security/105/]) HBASE-5735 Clearer warning message when connecting a non-secure HBase client to a secure HBase server (Revision 1310916) Result = FAILURE stack : Files : * /hbase/branches/0.92/CHANGES.txt * /hbase/branches/0.92/security/src/main/java/org/apache/hadoop/hbase/ipc/SecureServer.java Clearer warning message when connecting a non-secure HBase client to a secure HBase server -- Key: HBASE-5735 URL: https://issues.apache.org/jira/browse/HBASE-5735 Project: HBase Issue Type: Improvement Components: security Affects Versions: 0.92.1, 0.94.0 Reporter: Shaneal Manek Assignee: Shaneal Manek Priority: Trivial Fix For: 0.92.2, 0.94.0 Attachments: HBASE-5375-v2.patch, HBASE-5375.patch, HBASE-5735-v3.patch When a connection from a non secure-rpc-engine client is attempted the warning message you get is related to version mismatch: Mar 28, 3:27:13 PM WARN org.apache.hadoop.ipc.SecureServer Incorrect header or version mismatch from 172.29.82.121:43849 got version 3 expected version 4 While this is true, it isn't as useful as it could be. A more specific error message warning end users that they're connecting with a non-secure client may be more useful. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5823) Hbck should be able to print help
[ https://issues.apache.org/jira/browse/HBASE-5823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259512#comment-13259512 ] Hudson commented on HBASE-5823: --- Integrated in HBase-0.92-security #105 (See [https://builds.apache.org/job/HBase-0.92-security/105/]) HBASE-5823 Hbck should be able to print help (Revision 1327641) Result = FAILURE stack : Files : * /hbase/branches/0.92/CHANGES.txt * /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java Hbck should be able to print help - Key: HBASE-5823 URL: https://issues.apache.org/jira/browse/HBASE-5823 Project: HBase Issue Type: Improvement Affects Versions: 0.92.1, 0.96.0, 0.94.1 Reporter: Enis Soztutar Assignee: Enis Soztutar Priority: Minor Fix For: 0.92.2, 0.94.0 Attachments: hbase-hbck.patch bin/hbase hbck -h and -help should print the help message. It used to print help when unrecognized options are passed. We can backport this to 0.92/0.94 branches as well. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5711) Tests are failing with incorrect data directory permissions.
[
https://issues.apache.org/jira/browse/HBASE-5711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259514#comment-13259514
]
Hudson commented on HBASE-5711:
---
Integrated in HBase-0.92-security #105 (See
[https://builds.apache.org/job/HBase-0.92-security/105/])
HBASE-5711 Tests are failing with incorrect data directory permissions --
REVERT (Revision 1310107)
HBASE-5711 Tests are failing with incorrect data directory permissions.
(Revision 1310053)
Result = FAILURE
stack :
Files :
* /hbase/branches/0.92/CHANGES.txt
*
/hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
stack :
Files :
* /hbase/branches/0.92/CHANGES.txt
*
/hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
Tests are failing with incorrect data directory permissions.
Key: HBASE-5711
URL: https://issues.apache.org/jira/browse/HBASE-5711
Project: HBase
Issue Type: Bug
Components: test
Reporter: Uma Maheswara Rao G
Assignee: Uma Maheswara Rao G
Fix For: 0.92.2, 0.94.1
Attachments: HBASE-5711.patch
When we run some tests in Hbase (TestAdmin), it is failing with following
error.
{quote}
Starting DataNode 0 with dfs.data.dir:
E:\Repositories\Hbase\target\test-data\5ff23198-892e-4f1c-8022-b3d9969fcf0b\dfscluster_0ecc6984-1925-4870-ac7c-439fceede4cb\dfs\data\data1,E:\Repositories\Hbase\target\test-data\5ff23198-892e-4f1c-8022-b3d9969fcf0b\dfscluster_0ecc6984-1925-4870-ac7c-439fceede4cb\dfs\data\data2
2012-04-04 18:04:51,036 WARN [main] impl.MetricsSystemImpl(137): Metrics
system not started: Cannot locate configuration: tried
hadoop-metrics2-datanode.properties, hadoop-metrics2.properties
2012-04-04 18:04:51,255 WARN [main] datanode.DataNode(1548): Invalid
directory in dfs.data.dir: Incorrect permission for
E:/Repositories/Hbase/target/test-data/5ff23198-892e-4f1c-8022-b3d9969fcf0b/dfscluster_0ecc6984-1925-4870-ac7c-439fceede4cb/dfs/data/data1,
expected: rwxr-xr-x, while actual: rwx--
2012-04-04 18:04:51,411 WARN [main] datanode.DataNode(1548): Invalid
directory in dfs.data.dir: Incorrect permission for
E:/Repositories/Hbase/target/test-data/5ff23198-892e-4f1c-8022-b3d9969fcf0b/dfscluster_0ecc6984-1925-4870-ac7c-439fceede4cb/dfs/data/data2,
expected: rwxr-xr-x, while actual: rwx--
2012-04-04 18:04:51,411 ERROR [main] datanode.DataNode(1554): All directories
in dfs.data.dir are invalid.
2012-04-04 18:04:51,411 INFO [main] hbase.HBaseTestingUtility(684): Shutting
down minicluster
2012-04-04 18:04:51,646 WARN [main] hbase.HBaseTestingUtility(696): Failed
delete of
E:\Repositories\Hbase\target\test-data\5ff23198-892e-4f1c-8022-b3d9969fcf0b\dfscluster_0ecc6984-1925-4870-ac7c-439fceede4cb
2012-04-04 18:04:51,646 INFO [main] hbase.HBaseTestingUtility(700):
Minicluster is down
{quote}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5615) the master never does balance because of balancing the parent region
[ https://issues.apache.org/jira/browse/HBASE-5615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259509#comment-13259509 ] Hudson commented on HBASE-5615: --- Integrated in HBase-0.92-security #105 (See [https://builds.apache.org/job/HBase-0.92-security/105/]) HBASE-5615 revert due to race condition in case master dies (Revision 1310321) Result = FAILURE tedyu : Files : * /hbase/branches/0.92/CHANGES.txt * /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java the master never does balance because of balancing the parent region Key: HBASE-5615 URL: https://issues.apache.org/jira/browse/HBASE-5615 Project: HBase Issue Type: Bug Affects Versions: 0.90.7 Reporter: xufeng Assignee: xufeng Priority: Critical Fix For: 0.90.7, 0.92.2, 0.96.0, 0.94.1 Attachments: 5615-trunk.txt, HBASE-5615-90.patch, HBASE-5615.patch, NoPatched-surefire-report-5615-90.html, Patched_surefire-report-5615-90.html the master never do balance becauseof when master do rebuildUserRegions()，it will add the parent region into AssignmentManager#servers, if balancer let the parent region to move,the parent will in RIT forever.thus balance will never be executed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5724) Row cache of KeyValue should be cleared in readFields().
[ https://issues.apache.org/jira/browse/HBASE-5724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259515#comment-13259515 ] Hudson commented on HBASE-5724: --- Integrated in HBase-0.92-security #105 (See [https://builds.apache.org/job/HBase-0.92-security/105/]) HBASE-5724 Row cache of KeyValue should be cleared in readFields() -- add missing import (Revision 1310148) HBASE-5724 Row cache of KeyValue should be cleared in readFields() (Revision 1310068) Result = FAILURE stack : Files : * /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/TestKeyValue.java stack : Files : * /hbase/branches/0.92/CHANGES.txt * /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/KeyValue.java * /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/TestKeyValue.java Row cache of KeyValue should be cleared in readFields(). Key: HBASE-5724 URL: https://issues.apache.org/jira/browse/HBASE-5724 Project: HBase Issue Type: Bug Affects Versions: 0.92.1 Reporter: Teruyoshi Zenmyo Assignee: Teruyoshi Zenmyo Fix For: 0.90.7, 0.92.2, 0.94.0 Attachments: 5724.092.txt, HBASE-5724.txt, HBASE-5724v2.txt KeyValue does not clear its row cache in reading new values (readFields()). Therefore, If a KeyValue (kv) which caches its row bytes reads another KeyValue instance, kv.getRow() returns a wrong value. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5758) Forward port HBASE-4109 Hostname returned via reverse dns lookup contains trailing period if configured interface is not 'default'
[ https://issues.apache.org/jira/browse/HBASE-5758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259510#comment-13259510 ] Hudson commented on HBASE-5758: --- Integrated in HBase-0.92-security #105 (See [https://builds.apache.org/job/HBase-0.92-security/105/]) HBASE-5758 Forward port HBASE-4109 Hostname returned via reverse dns lookup contains trailing period if configured interface is not default (Revision 1311827) HBASE-5758 Forward port HBASE-4109 Hostname returned via reverse dns lookup contains trailing period if configured interface is not default (Revision 1311825) Result = FAILURE stack : Files : * /hbase/branches/0.92/CHANGES.txt stack : Files : * /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/master/HMaster.java * /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java * /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/util/Strings.java * /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/zookeeper/HQuorumPeer.java Forward port HBASE-4109 Hostname returned via reverse dns lookup contains trailing period if configured interface is not 'default' Key: HBASE-5758 URL: https://issues.apache.org/jira/browse/HBASE-5758 Project: HBase Issue Type: Task Reporter: stack Assignee: stack Fix For: 0.92.2, 0.94.0 Attachments: 5758.txt -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5656) LoadIncrementalHFiles createTable should detect and set compression algorithm
[ https://issues.apache.org/jira/browse/HBASE-5656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259516#comment-13259516 ] Hudson commented on HBASE-5656: --- Integrated in HBase-0.92-security #105 (See [https://builds.apache.org/job/HBase-0.92-security/105/]) HBASE-5656 LoadIncrementalHFiles createTable should detect and set compression algorithm(Cosmin Lehene) (Revision 1311105) Result = FAILURE larsh : Files : * /hbase/branches/0.92/CHANGES.txt * /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java LoadIncrementalHFiles createTable should detect and set compression algorithm - Key: HBASE-5656 URL: https://issues.apache.org/jira/browse/HBASE-5656 Project: HBase Issue Type: Bug Components: util Affects Versions: 0.92.1 Reporter: Cosmin Lehene Assignee: Cosmin Lehene Fix For: 0.92.2, 0.94.0, 0.96.0 Attachments: 5656-simple.txt, HBASE-5656-0.92.patch, HBASE-5656-0.92.patch, HBASE-5656-0.92.patch, HBASE-5656-0.92.patch Original Estimate: 1h Remaining Estimate: 1h LoadIncrementalHFiles doesn't set compression when creating the the table. This can be detected from the files within each family dir. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4109) Hostname returned via reverse dns lookup contains trailing period if configured interface is not default
[
https://issues.apache.org/jira/browse/HBASE-4109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259517#comment-13259517
]
Hudson commented on HBASE-4109:
---
Integrated in HBase-0.92-security #105 (See
[https://builds.apache.org/job/HBase-0.92-security/105/])
HBASE-5758 Forward port HBASE-4109 Hostname returned via reverse dns
lookup contains trailing period if configured interface is not default
(Revision 1311827)
HBASE-5758 Forward port HBASE-4109 Hostname returned via reverse dns lookup
contains trailing period if configured interface is not default (Revision
1311825)
Result = FAILURE
stack :
Files :
* /hbase/branches/0.92/CHANGES.txt
stack :
Files :
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
*
/hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/util/Strings.java
*
/hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/zookeeper/HQuorumPeer.java
Hostname returned via reverse dns lookup contains trailing period if
configured interface is not default
--
Key: HBASE-4109
URL: https://issues.apache.org/jira/browse/HBASE-4109
Project: HBase
Issue Type: Bug
Components: master, regionserver
Affects Versions: 0.90.3
Reporter: Shrijeet Paliwal
Assignee: Shrijeet Paliwal
Fix For: 0.90.4
Attachments:
0001-HBASE-4109-Sanitize-hostname-returned-from-DNS-class.patch
If you are using an interface anything other than 'default' (literally that
keyword) DNS.java 's getDefaultHost will return a string which will
have a trailing period at the end. It seems javadoc of reverseDns in DNS.java
(see below) is conflicting with what that function is actually doing.
It is returning a PTR record while claims it returns a hostname. The PTR
record always has period at the end , RFC:
http://irbs.net/bog-4.9.5/bog47.html
We make call to DNS.getDefaultHost at more than one places and treat that as
actual hostname.
Quoting HRegionServer for example
{code}
String machineName = DNS.getDefaultHost(conf.get(
hbase.regionserver.dns.interface, default), conf.get(
hbase.regionserver.dns.nameserver, default));
{code}
This causes inconsistencies. An example of such inconsistency was observed
while debugging the issue Regions not getting reassigned if RS is brought
down. More here
http://search-hadoop.com/m/CANUA1qRCkQ1
We may want to sanitize the string returned from DNS class. Or better we can
take a path of overhauling the way we do DNS name matching all over.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5734) Change hbck sideline root
[ https://issues.apache.org/jira/browse/HBASE-5734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259518#comment-13259518 ] Hudson commented on HBASE-5734: --- Integrated in HBase-0.92-security #105 (See [https://builds.apache.org/job/HBase-0.92-security/105/]) HBASE-5734 Change hbck sideline root (Jimmy Xiang) (Revision 1310627) Result = FAILURE jmhsieh : Files : * /hbase/branches/0.92/CHANGES.txt * /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java Change hbck sideline root - Key: HBASE-5734 URL: https://issues.apache.org/jira/browse/HBASE-5734 Project: HBase Issue Type: Improvement Components: hbck Affects Versions: 0.94.0, 0.96.0 Reporter: Jimmy Xiang Assignee: Jimmy Xiang Priority: Trivial Fix For: 0.90.7, 0.92.2, 0.94.0, 0.96.0 Attachments: hbase-5734-90.patch, hbase-5734.patch Currently hbck sideline root is the root which can run into permission issue. We can change it to /hbck -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5780) Fix race in HBase regionserver startup vs ZK SASL authentication
[ https://issues.apache.org/jira/browse/HBASE-5780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259523#comment-13259523 ] Hudson commented on HBASE-5780: --- Integrated in HBase-0.92-security #105 (See [https://builds.apache.org/job/HBase-0.92-security/105/]) HBASE-5780 Fix race in HBase regionserver startup vs ZK SASL authentication (Shaneal) (Revision 1326815) Result = FAILURE tedyu : Files : * /hbase/branches/0.92/CHANGES.txt * /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperNodeTracker.java Fix race in HBase regionserver startup vs ZK SASL authentication Key: HBASE-5780 URL: https://issues.apache.org/jira/browse/HBASE-5780 Project: HBase Issue Type: Bug Components: security Affects Versions: 0.92.1, 0.94.0 Reporter: Shaneal Manek Assignee: Shaneal Manek Fix For: 0.92.2, 0.94.0, 0.96.0 Attachments: HBASE-5780-v2.patch, HBASE-5780.patch, TestReplicationPeer-Security-output.log, TestReplicationPeer-output.log, testoutput.tar.gz Secure RegionServers sometimes fail to start with the following backtrace: 2012-03-22 17:20:16,737 FATAL org.apache.hadoop.hbase.regionserver.HRegionServer: ABORTING region server centos60-20.ent.cloudera.com,60020,1332462015929: Unexpected exception during initialization, aborting org.apache.zookeeper.KeeperException$NoAuthException: KeeperErrorCode = NoAuth for /hbase/shutdown at org.apache.zookeeper.KeeperException.create(KeeperException.java:113) at org.apache.zookeeper.KeeperException.create(KeeperException.java:51) at org.apache.zookeeper.ZooKeeper.getData(ZooKeeper.java:1131) at org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.getData(RecoverableZooKeeper.java:295) at org.apache.hadoop.hbase.zookeeper.ZKUtil.getDataInternal(ZKUtil.java:518) at org.apache.hadoop.hbase.zookeeper.ZKUtil.getDataAndWatch(ZKUtil.java:494) at org.apache.hadoop.hbase.zookeeper.ZooKeeperNodeTracker.start(ZooKeeperNodeTracker.java:77) at org.apache.hadoop.hbase.regionserver.HRegionServer.initializeZooKeeper(HRegionServer.java:569) at org.apache.hadoop.hbase.regionserver.HRegionServer.preRegistrationInitialization(HRegionServer.java:532) at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:634) at java.lang.Thread.run(Thread.java:662) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5599) [hbck] handle NO_VERSION_FILE and SHOULD_NOT_BE_DEPLOYED inconsistencies
[ https://issues.apache.org/jira/browse/HBASE-5599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259524#comment-13259524 ] Hudson commented on HBASE-5599: --- Integrated in HBase-0.92-security #105 (See [https://builds.apache.org/job/HBase-0.92-security/105/]) HBASE-5599 [hbck] handle NO_VERSION_FILE and SHOULD_NOT_BE_DEPLOYED inconsistencies (fulin wang) (Revision 1324879) Result = FAILURE jmhsieh : Files : * /hbase/branches/0.92/CHANGES.txt * /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java * /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java * /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/util/hbck/HbckTestingUtil.java [hbck] handle NO_VERSION_FILE and SHOULD_NOT_BE_DEPLOYED inconsistencies Key: HBASE-5599 URL: https://issues.apache.org/jira/browse/HBASE-5599 Project: HBase Issue Type: New Feature Components: hbck Affects Versions: 0.90.6 Reporter: fulin wang Assignee: fulin wang Fix For: 0.90.7, 0.92.2, 0.94.0, 0.96.0 Attachments: 0.90-surefire-report-hbck.html, hbase-5599-0.90.patch, hbase-5599-0.90_v2.patch, hbase-5599-0.90_v3.patch, hbase-5599-0.90_v5.patch, hbase-5599-0.90_v6.patch, hbase-5599-0.90_v7.patch, hbase-5599-0.90_v8, hbase-5599-0.92_v5.patch, hbase-5599-0.94_v5.patch, hbase-5599-92-v8.patch, hbase-5599-trunk_v5.patch, hbase-5599-trunk_v7.patch, hbase-5599-trunk_v8.patch, license.png The hbck tool can not fix the six scenarios. 1. Version file does not exist in root dir. Fix: I try to create a version file by 'FSUtils.setVersion' method. 2. [REGIONNAME][KEY] on HDFS, but not listed in META or deployed on any region server. Fix: I get region info form the hdfs file, this region info write to '.META.' table. 3. [REGIONNAME][KEY] not in META, but deployed on [SERVERNAME] Fix: I get region info form the hdfs file, this region info write to '.META.' table. 4. [REGIONNAME] should not be deployed according to META, but is deployed on [SERVERNAME] Fix: Close this region. 5. First region should start with an empty key. You need to create a new region and regioninfo in HDFS to plug the hole. Fix: The region info is not in hdfs and .META., so it create a empty region for this error. 6. There is a hole in the region chain between [KEY] and [KEY]. You need to create a new regioninfo and region dir in hdfs to plug the hole. Fix: The region info is not in hdfs and .META., so it create a empty region for this hole. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5821) Incorrect handling of null value in Coprocessor aggregation function min()
[ https://issues.apache.org/jira/browse/HBASE-5821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259519#comment-13259519 ] Hudson commented on HBASE-5821: --- Integrated in HBase-0.92-security #105 (See [https://builds.apache.org/job/HBase-0.92-security/105/]) HBASE-5821 Incorrect handling of null value in Coprocessor aggregation function min() (Maryann Xue) (Revision 1328025) Result = FAILURE tedyu : Files : * /hbase/branches/0.92/CHANGES.txt * /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/client/coprocessor/AggregationClient.java * /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/coprocessor/AggregateImplementation.java Incorrect handling of null value in Coprocessor aggregation function min() -- Key: HBASE-5821 URL: https://issues.apache.org/jira/browse/HBASE-5821 Project: HBase Issue Type: Bug Components: coprocessors Affects Versions: 0.92.1 Reporter: Maryann Xue Assignee: Maryann Xue Fix For: 0.92.2, 0.96.0, 0.94.1 Attachments: HBASE-5821.patch Both in AggregateImplementation and AggregationClient, the evaluation of the current minimum value is like: min = (min == null || ci.compare(result, min) 0) ? result : min; The LongColumnInterpreter takes null value is treated as the least value, while the above expression takes min as the greater value when it is null. Thus, the real minimum value gets discarded if a null value comes later. max() could also be wrong if a different ColumnInterpreter other than LongColumnInterpreter treats null value differently (as the greatest). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5719) Enhance hbck to sideline overlapped mega regions
[ https://issues.apache.org/jira/browse/HBASE-5719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259521#comment-13259521 ] Hudson commented on HBASE-5719: --- Integrated in HBase-0.92-security #105 (See [https://builds.apache.org/job/HBase-0.92-security/105/]) HBASE-5719 Enhance hbck to sideline overlapped mega regions (Jimmy Xiang) (Revision 1325405) Result = FAILURE jmhsieh : Files : * /hbase/branches/0.92/CHANGES.txt * /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java * /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java * /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/util/TestRegionSplitCalculator.java Enhance hbck to sideline overlapped mega regions Key: HBASE-5719 URL: https://issues.apache.org/jira/browse/HBASE-5719 Project: HBase Issue Type: New Feature Components: hbck Affects Versions: 0.94.0, 0.96.0 Reporter: Jimmy Xiang Assignee: Jimmy Xiang Fix For: 0.90.7, 0.92.2, 0.94.0, 0.96.0 Attachments: 5719.patch, 5719_0.90.patch, 5719_0.92.patch, 5719_0.94.patch, hbase-5719.patch, hbase-5719_0.90.patch, hbase-5719_0.92.patch, hbase-5719_0.94.patch, hbase-5719_v3-new.patch, hbase-5719_v3.patch If there are too many regions in one overlapped group (by default, more than 10), hbck currently doesn't merge them since it takes time. In this case, we can sideline some regions in the group and break the overlapping to fix the inconsistency. Later on, sidelined regions can be bulk loaded manually. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5833) 0.92 build has been failing pretty consistently on TestMasterFailover....
[ https://issues.apache.org/jira/browse/HBASE-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259522#comment-13259522 ] Hudson commented on HBASE-5833: --- Integrated in HBase-0.92-security #105 (See [https://builds.apache.org/job/HBase-0.92-security/105/]) HBASE-5833 0.92 build has been failing pretty consistently on TestMasterFailover; PART2 (Revision 1329052) HBASE-5833 0.92 build has been failing pretty consistently on TestMasterFailover (Revision 1328098) Result = FAILURE stack : Files : * /hbase/branches/0.92/CHANGES.txt * /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/client/HTable.java * /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java * /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/metrics/histogram/ExponentiallyDecayingSample.java * /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/util/JVMClusterUtil.java * /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/HBaseTestCase.java * /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/filter/TestColumnPrefixFilter.java * /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/filter/TestDependentColumnFilter.java * /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/filter/TestFilter.java * /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/filter/TestMultipleColumnPrefixFilter.java * /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/master/TestMasterFailover.java * /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/master/TestOpenedRegionHandler.java * /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/TestBlocksRead.java * /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/TestColumnSeeking.java * /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactSelection.java * /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java * /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/TestMinVersions.java * /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/TestMultiColumnScanner.java * /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/TestResettingCounters.java * /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/TestScanWithBloomError.java * /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransaction.java * /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/handler/TestCloseRegionHandler.java * /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/handler/TestOpenRegionHandler.java * /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALReplay.java * /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/util/TestMergeTool.java stack : Files : * /hbase/branches/0.92/CHANGES.txt * /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/master/TestMasterFailover.java 0.92 build has been failing pretty consistently on TestMasterFailover - Key: HBASE-5833 URL: https://issues.apache.org/jira/browse/HBASE-5833 Project: HBase Issue Type: Bug Reporter: stack Assignee: stack Fix For: 0.92.2 Attachments: 5833-trunk.txt, 5833-v2.092.txt, 5833.txt, 5833v3092.txt, 5833v4092.txt, closehregions.txt Trunk seems fine but 0.92 fails on this test pretty regularly. Running it local it seems to hang for me. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5781) Zookeeper session got closed while trying to assign the region to RS using hbck -fix
[
https://issues.apache.org/jira/browse/HBASE-5781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259520#comment-13259520
]
Hudson commented on HBASE-5781:
---
Integrated in HBase-0.92-security #105 (See
[https://builds.apache.org/job/HBase-0.92-security/105/])
HBASE-5781 Zookeeper session got closed while trying to assign the region
to RS using hbck -fix (Revision 1326282)
Result = FAILURE
jmhsieh :
Files :
* /hbase/branches/0.92/CHANGES.txt
*
/hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/util/HBaseFsckRepair.java
Zookeeper session got closed while trying to assign the region to RS using
hbck -fix
Key: HBASE-5781
URL: https://issues.apache.org/jira/browse/HBASE-5781
Project: HBase
Issue Type: Bug
Components: hbck
Affects Versions: 0.90.7, 0.92.1, 0.94.0, 0.96.0
Reporter: Kristam Subba Swathi
Assignee: Jonathan Hsieh
Priority: Critical
Fix For: 0.90.7, 0.92.2, 0.94.0, 0.96.0
Attachments: hbase-5781.patch
After running the hbck in the cluster ,it is found that one region is not
assigned
So the hbck -fix is used to fix this
But the assignment didnt happen since the zookeeper session is closed
Please find the attached trace for more details
-
Trying to fix unassigned region...
12/04/03 11:02:57 INFO util.HBaseFsckRepair: Region still in transition,
waiting for it to become assigned: {NAME =
'ufdr,002300,179123498.00871fbd7583512e12c4eb38e900be8d.', STARTKEY =
'002300', ENDKEY = '002311', ENCODED = 00871fbd7583512e12c4eb38e900be8d,}
12/04/03 11:02:58 INFO client.HConnectionManager$HConnectionImplementation:
Closed zookeeper sessionid=0x236738a263a
12/04/03 11:02:58 INFO zookeeper.ZooKeeper: Session: 0x236738a263a closed
ERROR: Region { meta =
ufdr,010444,179123857.01594219211d0035b9586f98954462e1., hdfs =
hdfs://10.18.40.25:9000/hbase/ufdr/01594219211d0035b9586f98954462e1, deployed
= } not deployed on any region server.
Trying to fix unassigned region...
12/04/03 11:02:58 INFO zookeeper.ClientCnxn: EventThread shut down
12/04/03 11:02:58 WARN zookeeper.ZKUtil: hconnection-0x236738a263a Unable
to set watcher on znode (/hbase)
org.apache.zookeeper.KeeperException$SessionExpiredException: KeeperErrorCode
= Session expired for /hbase
at org.apache.zookeeper.KeeperException.create(KeeperException.java:127)
at org.apache.zookeeper.KeeperException.create(KeeperException.java:51)
at org.apache.zookeeper.ZooKeeper.exists(ZooKeeper.java:1021)
at
org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.exists(RecoverableZooKeeper.java:150)
at org.apache.hadoop.hbase.zookeeper.ZKUtil.checkExists(ZKUtil.java:263)
at
org.apache.hadoop.hbase.zookeeper.ZooKeeperNodeTracker.checkIfBaseNodeAvailable(ZooKeeperNodeTracker.java:208)
at
org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.checkIfBaseNodeAvailable(HConnectionManager.java:695)
at
org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.getMaster(HConnectionManager.java:626)
at org.apache.hadoop.hbase.client.HBaseAdmin.getMaster(HBaseAdmin.java:211)
at org.apache.hadoop.hbase.client.HBaseAdmin.assign(HBaseAdmin.java:1325)
at
org.apache.hadoop.hbase.util.HBaseFsckRepair.forceOfflineInZK(HBaseFsckRepair.java:109)
at
org.apache.hadoop.hbase.util.HBaseFsckRepair.fixUnassigned(HBaseFsckRepair.java:92)
at
org.apache.hadoop.hbase.util.HBaseFsck.tryAssignmentRepair(HBaseFsck.java:1235)
at
org.apache.hadoop.hbase.util.HBaseFsck.checkRegionConsistency(HBaseFsck.java:1351)
at
org.apache.hadoop.hbase.util.HBaseFsck.checkAndFixConsistency(HBaseFsck.java:1114)
at
org.apache.hadoop.hbase.util.HBaseFsck.onlineConsistencyRepair(HBaseFsck.java:356)
at org.apache.hadoop.hbase.util.HBaseFsck.onlineHbck(HBaseFsck.java:375)
at org.apache.hadoop.hbase.util.HBaseFsck.main(HBaseFsck.java:2894)
12/04/03 11:02:58 ERROR zookeeper.ZooKeeperWatcher:
hconnection-0x236738a263a Received unexpected KeeperException,
re-throwing exception
org.apache.zookeeper.KeeperException$SessionExpiredException: KeeperErrorCode
= Session expired for /hbase
at org.apache.zookeeper.KeeperException.create(KeeperException.java:127)
at org.apache.zookeeper.KeeperException.create(KeeperException.java:51)
at org.apache.zookeeper.ZooKeeper.exists(ZooKeeper.java:1021)
at
org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.exists(RecoverableZooKeeper.java:150)
at org.apache.hadoop.hbase.zookeeper.ZKUtil.checkExists(ZKUtil.java:263)
at
org.apache.hadoop.hbase.zookeeper.ZooKeeperNodeTracker.checkIfBaseNodeAvailable(ZooKeeperNodeTracker.java:208)
at
[jira] [Updated] (HBASE-5850) Backport HBASE-5454 to 90 and 92 Refuse operations from Admin before master is initialized
[ https://issues.apache.org/jira/browse/HBASE-5850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xufeng updated HBASE-5850: -- Attachment: backport-5454-to-90-surefire-report.html No_patch_90_surefire-report.html I try to merge the HBASE-5833 patch to 0.90 version,but failed. Many compile errors happend. So I delete the TestMasterFailover java file and test again. There are some error but also exist if no patch. I also check the TestMasterFailover file and I think it is no relation with the patch. Backport HBASE-5454 to 90 and 92 Refuse operations from Admin before master is initialized --- Key: HBASE-5850 URL: https://issues.apache.org/jira/browse/HBASE-5850 Project: HBase Issue Type: Bug Reporter: xufeng Assignee: xufeng Fix For: 0.90.7, 0.92.2, 0.94.1 Attachments: 5850-trunk.txt, No_patch_90_surefire-report.html, backport-5454(createTable)-to-94.patch, backport-5454(createTable)-to-94_surefire-report.html, backport-5454(createTable)-to-trunk.patch, backport-5454(createTable)-to-trunk_surefire-report.html, backport-5454-to-90-surefire-report.html, backport-5454-to-90.patch, backport-5454-to-92.patch, backport-5454-to-92_surefire-report.html This issue is needed in 0.90 0.92 also. And update the hbase-5454 patch that add the checkInitialized() into HMaster#createTable(). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5850) Backport HBASE-5454 to 90 and 92 Refuse operations from Admin before master is initialized
[ https://issues.apache.org/jira/browse/HBASE-5850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259589#comment-13259589 ] Hadoop QA commented on HBASE-5850: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12523736/5850-trunk.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.util.TestProcessBasedCluster Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1606//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1606//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1606//console This message is automatically generated. Backport HBASE-5454 to 90 and 92 Refuse operations from Admin before master is initialized --- Key: HBASE-5850 URL: https://issues.apache.org/jira/browse/HBASE-5850 Project: HBase Issue Type: Bug Reporter: xufeng Assignee: xufeng Fix For: 0.90.7, 0.92.2, 0.94.1 Attachments: 5850-trunk.txt, No_patch_90_surefire-report.html, backport-5454(createTable)-to-94.patch, backport-5454(createTable)-to-94_surefire-report.html, backport-5454(createTable)-to-trunk.patch, backport-5454(createTable)-to-trunk_surefire-report.html, backport-5454-to-90-surefire-report.html, backport-5454-to-90.patch, backport-5454-to-92.patch, backport-5454-to-92_surefire-report.html This issue is needed in 0.90 0.92 also. And update the hbase-5454 patch that add the checkInitialized() into HMaster#createTable(). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5773) HtablePool constructor not reading config files in certain cases
[
https://issues.apache.org/jira/browse/HBASE-5773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jonathan Hsieh updated HBASE-5773:
--
Fix Version/s: 0.96.0
Assignee: Ioan Eugen Stan
HtablePool constructor not reading config files in certain cases
Key: HBASE-5773
URL: https://issues.apache.org/jira/browse/HBASE-5773
Project: HBase
Issue Type: Bug
Components: client
Affects Versions: 0.90.6, 0.92.1, 0.94.1
Reporter: Ioan Eugen Stan
Assignee: Ioan Eugen Stan
Priority: Minor
Fix For: 0.90.7, 0.92.2, 0.94.0, 0.96.0
Attachments: different-config-behaviour.90.patch,
different-config-behaviour.90.patch, different-config-behaviour.patch
Creating a HtablePool can issue two behaviour depanding on the constructor
called.
Case 1: loads the configs from hbase-site
public HTablePool() {
this(HBaseConfiguration.create(), Integer.MAX_VALUE);
}
Calling this with null values for Configuration:
public HTablePool(final Configuration config, final int maxSize) {
this(config, maxSize, null, null);
}
will issue:
public HTablePool(final Configuration config, final int maxSize,
final HTableInterfaceFactory tableFactory, PoolType poolType) {
// Make a new configuration instance so I can safely cleanup when
// done with the pool.
this.config = config == null ? new Configuration() : config;
which does not read the hbase-site config files as
HBaseConfiguration.create() does.
I've tracked this problem to all versions of hbase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5833) 0.92 build has been failing pretty consistently on TestMasterFailover....
[ https://issues.apache.org/jira/browse/HBASE-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-5833: - Attachment: 5833v4090.txt Here is patch for 0.90. Ran all tests and all pass. Will commit. 0.92 build has been failing pretty consistently on TestMasterFailover - Key: HBASE-5833 URL: https://issues.apache.org/jira/browse/HBASE-5833 Project: HBase Issue Type: Bug Reporter: stack Assignee: stack Fix For: 0.92.2 Attachments: 5833-trunk.txt, 5833-v2.092.txt, 5833.txt, 5833v3092.txt, 5833v4090.txt, 5833v4092.txt, closehregions.txt Trunk seems fine but 0.92 fails on this test pretty regularly. Running it local it seems to hang for me. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5857) RIT map in RS not getting cleared while region opening
[
https://issues.apache.org/jira/browse/HBASE-5857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chinna Rao Lalam updated HBASE-5857:
Attachment: HBASE-5857_trunk.patch
HBASE-5857_94.patch
HBASE-5857_0.92.patch
RIT map in RS not getting cleared while region opening
--
Key: HBASE-5857
URL: https://issues.apache.org/jira/browse/HBASE-5857
Project: HBase
Issue Type: Bug
Affects Versions: 0.90.6
Reporter: Chinna Rao Lalam
Fix For: 0.92.2, 0.96.0, 0.94.1
Attachments: HBASE-5857_0.92.patch, HBASE-5857_94.patch,
HBASE-5857_trunk.patch
While opening the region in RS after adding the region to
regionsInTransitionInRS if tableDescriptors.get() throws exception the region
wont be cleared from regionsInTransitionInRS. So next time if it tries to
open the region in the same RS it will throw the
RegionAlreadyInTransitionException.
if swap the below statement this issue wont come.
{code}
this.regionsInTransitionInRS.putIfAbsent(region.getEncodedNameAsBytes(),true);
HTableDescriptor htd = this.tableDescriptors.get(region.getTableName());
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5857) RIT map in RS not getting cleared while region opening
[
https://issues.apache.org/jira/browse/HBASE-5857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chinna Rao Lalam updated HBASE-5857:
Status: Patch Available (was: Open)
RIT map in RS not getting cleared while region opening
--
Key: HBASE-5857
URL: https://issues.apache.org/jira/browse/HBASE-5857
Project: HBase
Issue Type: Bug
Affects Versions: 0.90.6
Reporter: Chinna Rao Lalam
Fix For: 0.92.2, 0.96.0, 0.94.1
Attachments: HBASE-5857_0.92.patch, HBASE-5857_94.patch,
HBASE-5857_trunk.patch
While opening the region in RS after adding the region to
regionsInTransitionInRS if tableDescriptors.get() throws exception the region
wont be cleared from regionsInTransitionInRS. So next time if it tries to
open the region in the same RS it will throw the
RegionAlreadyInTransitionException.
if swap the below statement this issue wont come.
{code}
this.regionsInTransitionInRS.putIfAbsent(region.getEncodedNameAsBytes(),true);
HTableDescriptor htd = this.tableDescriptors.get(region.getTableName());
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-5855) [findbugs] address remaining findbugs warnings
[ https://issues.apache.org/jira/browse/HBASE-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uma Maheswara Rao G reassigned HBASE-5855: -- Assignee: Uma Maheswara Rao G [findbugs] address remaining findbugs warnings --- Key: HBASE-5855 URL: https://issues.apache.org/jira/browse/HBASE-5855 Project: HBase Issue Type: Sub-task Reporter: Jonathan Hsieh Assignee: Uma Maheswara Rao G As we've been cleaning up the code related to findbugs warnings, new patches are coming in that introduce new warnings. This would is the last sub-isuse that will cleanup any recently introduced warnings. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5833) 0.92 build has been failing pretty consistently on TestMasterFailover....
[ https://issues.apache.org/jira/browse/HBASE-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259635#comment-13259635 ] Hadoop QA commented on HBASE-5833: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12523792/5833v4090.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 34 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1608//console This message is automatically generated. 0.92 build has been failing pretty consistently on TestMasterFailover - Key: HBASE-5833 URL: https://issues.apache.org/jira/browse/HBASE-5833 Project: HBase Issue Type: Bug Reporter: stack Assignee: stack Fix For: 0.92.2 Attachments: 5833-trunk.txt, 5833-v2.092.txt, 5833.txt, 5833v3092.txt, 5833v4090.txt, 5833v4092.txt, closehregions.txt Trunk seems fine but 0.92 fails on this test pretty regularly. Running it local it seems to hang for me. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5857) RIT map in RS not getting cleared while region opening
[
https://issues.apache.org/jira/browse/HBASE-5857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259649#comment-13259649
]
stack commented on HBASE-5857:
--
@Chinna Good find. Nice use of Mockito Whitebox too. Does your test confirm
the fix though? Maybe I'm not reading it right. Should it check the
regionserver instance does not have the test region in its
this.regionsInTransitionInRS Map? Thanks.
RIT map in RS not getting cleared while region opening
--
Key: HBASE-5857
URL: https://issues.apache.org/jira/browse/HBASE-5857
Project: HBase
Issue Type: Bug
Affects Versions: 0.90.6
Reporter: Chinna Rao Lalam
Fix For: 0.92.2, 0.96.0, 0.94.1
Attachments: HBASE-5857_0.92.patch, HBASE-5857_94.patch,
HBASE-5857_trunk.patch
While opening the region in RS after adding the region to
regionsInTransitionInRS if tableDescriptors.get() throws exception the region
wont be cleared from regionsInTransitionInRS. So next time if it tries to
open the region in the same RS it will throw the
RegionAlreadyInTransitionException.
if swap the below statement this issue wont come.
{code}
this.regionsInTransitionInRS.putIfAbsent(region.getEncodedNameAsBytes(),true);
HTableDescriptor htd = this.tableDescriptors.get(region.getTableName());
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5857) RIT map in RS not getting cleared while region opening
[
https://issues.apache.org/jira/browse/HBASE-5857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259661#comment-13259661
]
Hadoop QA commented on HBASE-5857:
--
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12523796/HBASE-5857_trunk.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.io.hfile.TestLruBlockCache
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/1607//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/1607//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/1607//console
This message is automatically generated.
RIT map in RS not getting cleared while region opening
--
Key: HBASE-5857
URL: https://issues.apache.org/jira/browse/HBASE-5857
Project: HBase
Issue Type: Bug
Affects Versions: 0.90.6
Reporter: Chinna Rao Lalam
Fix For: 0.92.2, 0.96.0, 0.94.1
Attachments: HBASE-5857_0.92.patch, HBASE-5857_94.patch,
HBASE-5857_trunk.patch
While opening the region in RS after adding the region to
regionsInTransitionInRS if tableDescriptors.get() throws exception the region
wont be cleared from regionsInTransitionInRS. So next time if it tries to
open the region in the same RS it will throw the
RegionAlreadyInTransitionException.
if swap the below statement this issue wont come.
{code}
this.regionsInTransitionInRS.putIfAbsent(region.getEncodedNameAsBytes(),true);
HTableDescriptor htd = this.tableDescriptors.get(region.getTableName());
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (HBASE-5858) When HBase gets executed against Hadoop 2.X SLF4j:CLASSPATH contains multiple SLF4j binding warning is displayed
Roman Shaposhnik created HBASE-5858: --- Summary: When HBase gets executed against Hadoop 2.X SLF4j:CLASSPATH contains multiple SLF4j binding warning is displayed Key: HBASE-5858 URL: https://issues.apache.org/jira/browse/HBASE-5858 Project: HBase Issue Type: Bug Components: scripts Affects Versions: 0.92.1, 0.92.0 Reporter: Roman Shaposhnik Assignee: Roman Shaposhnik Priority: Minor Since HBase tries to find locations of the Hadoop jars from the environment in certain cases it ends up with extra SLF4j jars coming from Hadoop classpath. When that happens SLF4j:CLASSPATH contains multiple SLF4j binding warning gets displayed. The good news here is that the warning is just that -- a warning. The bad news is that it seems this issue will be tricky to fix properly. On one hand we would like Hadoop itself to give us transitive closure of the set of jar files required (computing that in the HBase script is a maintenance nightmare). On the other hand that set of jar files could contain some of the very same jars shipped with HBase. This problem existed for quiet some time. SLF4j is just the first component to complain. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5844) Delete the region servers znode after a regions server crash
[ https://issues.apache.org/jira/browse/HBASE-5844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nkeywal updated HBASE-5844: --- Attachment: 5844.v2.patch Delete the region servers znode after a regions server crash Key: HBASE-5844 URL: https://issues.apache.org/jira/browse/HBASE-5844 Project: HBase Issue Type: Improvement Components: regionserver, scripts Affects Versions: 0.96.0 Reporter: nkeywal Assignee: nkeywal Attachments: 5844.v1.patch, 5844.v2.patch today, if the regions server crashes, its znode is not deleted in ZooKeeper. So the recovery process will stop only after a timeout, usually 30s. By deleting the znode in start script, we remove this delay and the recovery starts immediately. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5844) Delete the region servers znode after a regions server crash
[ https://issues.apache.org/jira/browse/HBASE-5844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259692#comment-13259692 ] nkeywal commented on HBASE-5844: v2 should be ok. It does not include anymore the fix for HBASE-5666, so it cannot be tested locally but I tried it before removing the workaround. Delete the region servers znode after a regions server crash Key: HBASE-5844 URL: https://issues.apache.org/jira/browse/HBASE-5844 Project: HBase Issue Type: Improvement Components: regionserver, scripts Affects Versions: 0.96.0 Reporter: nkeywal Assignee: nkeywal Attachments: 5844.v1.patch, 5844.v2.patch today, if the regions server crashes, its znode is not deleted in ZooKeeper. So the recovery process will stop only after a timeout, usually 30s. By deleting the znode in start script, we remove this delay and the recovery starts immediately. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5621) Convert admin protocol of HRegionInterface to PB
[ https://issues.apache.org/jira/browse/HBASE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jimmy Xiang updated HBASE-5621: --- Status: Open (was: Patch Available) Convert admin protocol of HRegionInterface to PB Key: HBASE-5621 URL: https://issues.apache.org/jira/browse/HBASE-5621 Project: HBase Issue Type: Sub-task Components: ipc, master, migration, regionserver Reporter: Jimmy Xiang Assignee: Jimmy Xiang Fix For: 0.96.0 Attachments: hbase-5621_v3.patch, hbase_5621_v4.patch, hbase_5621_v4.patch, hbase_5621_v5.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5621) Convert admin protocol of HRegionInterface to PB
[ https://issues.apache.org/jira/browse/HBASE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jimmy Xiang updated HBASE-5621: --- Status: Patch Available (was: Open) Convert admin protocol of HRegionInterface to PB Key: HBASE-5621 URL: https://issues.apache.org/jira/browse/HBASE-5621 Project: HBase Issue Type: Sub-task Components: ipc, master, migration, regionserver Reporter: Jimmy Xiang Assignee: Jimmy Xiang Fix For: 0.96.0 Attachments: hbase-5621_v3.patch, hbase_5621_v4.patch, hbase_5621_v4.patch, hbase_5621_v5.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5621) Convert admin protocol of HRegionInterface to PB
[ https://issues.apache.org/jira/browse/HBASE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jimmy Xiang updated HBASE-5621: --- Attachment: hbase_5621_v5.patch Convert admin protocol of HRegionInterface to PB Key: HBASE-5621 URL: https://issues.apache.org/jira/browse/HBASE-5621 Project: HBase Issue Type: Sub-task Components: ipc, master, migration, regionserver Reporter: Jimmy Xiang Assignee: Jimmy Xiang Fix For: 0.96.0 Attachments: hbase-5621_v3.patch, hbase_5621_v4.patch, hbase_5621_v4.patch, hbase_5621_v5.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5621) Convert admin protocol of HRegionInterface to PB
[ https://issues.apache.org/jira/browse/HBASE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259699#comment-13259699 ] Jimmy Xiang commented on HBASE-5621: I addressed the naming issue Ted pointed out. I think I got all regular tests passed: 537 small + 648 medium + 297 large = 1482 With security, there are couple tests failed. I am looking into them. I don't think it's caused by this patch. Should we handle them in a different jira? Convert admin protocol of HRegionInterface to PB Key: HBASE-5621 URL: https://issues.apache.org/jira/browse/HBASE-5621 Project: HBase Issue Type: Sub-task Components: ipc, master, migration, regionserver Reporter: Jimmy Xiang Assignee: Jimmy Xiang Fix For: 0.96.0 Attachments: hbase-5621_v3.patch, hbase_5621_v4.patch, hbase_5621_v4.patch, hbase_5621_v5.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (HBASE-5859) Optimize the rolling restart script
nkeywal created HBASE-5859:
--
Summary: Optimize the rolling restart script
Key: HBASE-5859
URL: https://issues.apache.org/jira/browse/HBASE-5859
Project: HBase
Issue Type: Improvement
Components: regionserver, scripts
Affects Versions: 0.96.0
Reporter: nkeywal
Priority: Minor
There is a graceful_stop script. This algorithm:
{noformat}
for i = 0 to servers.size {
regionsInServer = servers[i].regions
move servers[i].regions to random
stop servers[i]
start servers[i]
move regionsInServer to servers[i] //filled back with the same regions
}
{noformat}
It would be possible to optimize it while keeping data locality with
{noformat}
for i = 0 to servers.size {
start servers[i*2+1] on the computer of servers[i] // Two RS on the same box
move servers[i].regions to servers[i*2+1] // The one on the same box
stop servers[i]
}
{noformat}
There would be an impact with a fixed port configuration. To fix this, we could:
- use a range of port instead of a single port. This could be an issue for the
web port.
- start on a port then reuse the fixed ones when they become available. This is
not very elegant if a client code is already using the previous code. Moreover
the region server code is written in the meta table.
- do a mix of the two solutions: a range for the server itself, while waiting
for the web port to be available.
To be discussed...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-5787) Table owner can't disable/delete its own table
[
https://issues.apache.org/jira/browse/HBASE-5787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zhihong Yu resolved HBASE-5787.
---
Resolution: Fixed
Table owner can't disable/delete its own table
--
Key: HBASE-5787
URL: https://issues.apache.org/jira/browse/HBASE-5787
Project: HBase
Issue Type: Bug
Components: security
Affects Versions: 0.92.1, 0.94.0, 0.96.0
Reporter: Matteo Bertozzi
Assignee: Matteo Bertozzi
Priority: Minor
Labels: acl, security
Fix For: 0.92.2, 0.96.0, 0.94.1
Attachments: HBASE-5787-tests-wrong-names.patch, HBASE-5787-v0.patch,
HBASE-5787-v1.patch
An user with CREATE privileges can create a table, but can not disable it,
because disable operation require ADMIN privileges. Also if a table is
already disabled, anyone can remove it.
{code}
public void preDeleteTable(ObserverContextMasterCoprocessorEnvironment c,
byte[] tableName) throws IOException {
requirePermission(Permission.Action.CREATE);
}
public void preDisableTable(ObserverContextMasterCoprocessorEnvironment c,
byte[] tableName) throws IOException {
/* TODO: Allow for users with global CREATE permission and the table owner
*/
requirePermission(Permission.Action.ADMIN);
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5787) Table owner can't disable/delete his/her own table
[
https://issues.apache.org/jira/browse/HBASE-5787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zhihong Yu updated HBASE-5787:
--
Summary: Table owner can't disable/delete his/her own table (was: Table
owner can't disable/delete its own table)
Table owner can't disable/delete his/her own table
--
Key: HBASE-5787
URL: https://issues.apache.org/jira/browse/HBASE-5787
Project: HBase
Issue Type: Bug
Components: security
Affects Versions: 0.92.1, 0.94.0, 0.96.0
Reporter: Matteo Bertozzi
Assignee: Matteo Bertozzi
Priority: Minor
Labels: acl, security
Fix For: 0.92.2, 0.96.0, 0.94.1
Attachments: HBASE-5787-tests-wrong-names.patch, HBASE-5787-v0.patch,
HBASE-5787-v1.patch
An user with CREATE privileges can create a table, but can not disable it,
because disable operation require ADMIN privileges. Also if a table is
already disabled, anyone can remove it.
{code}
public void preDeleteTable(ObserverContextMasterCoprocessorEnvironment c,
byte[] tableName) throws IOException {
requirePermission(Permission.Action.CREATE);
}
public void preDisableTable(ObserverContextMasterCoprocessorEnvironment c,
byte[] tableName) throws IOException {
/* TODO: Allow for users with global CREATE permission and the table owner
*/
requirePermission(Permission.Action.ADMIN);
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5621) Convert admin protocol of HRegionInterface to PB
[ https://issues.apache.org/jira/browse/HBASE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259709#comment-13259709 ] Zhihong Yu commented on HBASE-5621: --- Can you list the tests that failed on your machine ? For security profile, TestProcessBasedCluster.testProcessBasedCluster fails consistently and is tracked by HBASE-5851. Other than that test, we should be careful. Convert admin protocol of HRegionInterface to PB Key: HBASE-5621 URL: https://issues.apache.org/jira/browse/HBASE-5621 Project: HBase Issue Type: Sub-task Components: ipc, master, migration, regionserver Reporter: Jimmy Xiang Assignee: Jimmy Xiang Fix For: 0.96.0 Attachments: hbase-5621_v3.patch, hbase_5621_v4.patch, hbase_5621_v4.patch, hbase_5621_v5.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5635) If getTaskList() returns null, splitlogWorker would go down and it won't serve any requests
[
https://issues.apache.org/jira/browse/HBASE-5635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ramkrishna.s.vasudevan updated HBASE-5635:
--
Resolution: Fixed
Assignee: Christopher Gist
Status: Resolved (was: Patch Available)
If getTaskList() returns null, splitlogWorker would go down and it won't
serve any requests
---
Key: HBASE-5635
URL: https://issues.apache.org/jira/browse/HBASE-5635
Project: HBase
Issue Type: Bug
Components: wal
Affects Versions: 0.92.1
Reporter: Kristam Subba Swathi
Assignee: Christopher Gist
Attachments: HBASE-5635.1.patch, HBASE-5635.2.patch,
HBASE-5635._trunk.patch, HBASE-5635.patch, HBASE-5635_0.94.patch
During the hlog split operation if all the zookeepers are down ,then the
paths will be returned as null and the splitworker thread wil be exited
Now this regionserver wil not be able to acquire any other tasks since the
splitworker thread is exited
Please find the attached code for more details
{code}
private ListString getTaskList() {
for (int i = 0; i zkretries; i++) {
try {
return (ZKUtil.listChildrenAndWatchForNewChildren(this.watcher,
this.watcher.splitLogZNode));
} catch (KeeperException e) {
LOG.warn(Could not get children of znode +
this.watcher.splitLogZNode, e);
try {
Thread.sleep(1000);
} catch (InterruptedException e1) {
LOG.warn(Interrupted while trying to get task list ..., e1);
Thread.currentThread().interrupt();
return null;
}
}
}
{code}
in the org.apache.hadoop.hbase.regionserver.SplitLogWorker
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5635) If getTaskList() returns null, splitlogWorker would go down and it won't serve any requests
[
https://issues.apache.org/jira/browse/HBASE-5635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259710#comment-13259710
]
ramkrishna.s.vasudevan commented on HBASE-5635:
---
Committed to trunk and 0.94. The testcase failure is not due to this patch.
Ran TestSplitLogManager multiple times and did not fail.
Thanks for the patch Chinna.
Thanks for the review Ted, Lars and Anoop.
If getTaskList() returns null, splitlogWorker would go down and it won't
serve any requests
---
Key: HBASE-5635
URL: https://issues.apache.org/jira/browse/HBASE-5635
Project: HBase
Issue Type: Bug
Components: wal
Affects Versions: 0.92.1
Reporter: Kristam Subba Swathi
Attachments: HBASE-5635.1.patch, HBASE-5635.2.patch,
HBASE-5635._trunk.patch, HBASE-5635.patch, HBASE-5635_0.94.patch
During the hlog split operation if all the zookeepers are down ,then the
paths will be returned as null and the splitworker thread wil be exited
Now this regionserver wil not be able to acquire any other tasks since the
splitworker thread is exited
Please find the attached code for more details
{code}
private ListString getTaskList() {
for (int i = 0; i zkretries; i++) {
try {
return (ZKUtil.listChildrenAndWatchForNewChildren(this.watcher,
this.watcher.splitLogZNode));
} catch (KeeperException e) {
LOG.warn(Could not get children of znode +
this.watcher.splitLogZNode, e);
try {
Thread.sleep(1000);
} catch (InterruptedException e1) {
LOG.warn(Interrupted while trying to get task list ..., e1);
Thread.currentThread().interrupt();
return null;
}
}
}
{code}
in the org.apache.hadoop.hbase.regionserver.SplitLogWorker
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-5635) If getTaskList() returns null, splitlogWorker would go down and it won't serve any requests
[
https://issues.apache.org/jira/browse/HBASE-5635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ramkrishna.s.vasudevan reassigned HBASE-5635:
-
Assignee: chinna (was: Christopher Gist)
If getTaskList() returns null, splitlogWorker would go down and it won't
serve any requests
---
Key: HBASE-5635
URL: https://issues.apache.org/jira/browse/HBASE-5635
Project: HBase
Issue Type: Bug
Components: wal
Affects Versions: 0.92.1
Reporter: Kristam Subba Swathi
Assignee: chinna
Attachments: HBASE-5635.1.patch, HBASE-5635.2.patch,
HBASE-5635._trunk.patch, HBASE-5635.patch, HBASE-5635_0.94.patch
During the hlog split operation if all the zookeepers are down ,then the
paths will be returned as null and the splitworker thread wil be exited
Now this regionserver wil not be able to acquire any other tasks since the
splitworker thread is exited
Please find the attached code for more details
{code}
private ListString getTaskList() {
for (int i = 0; i zkretries; i++) {
try {
return (ZKUtil.listChildrenAndWatchForNewChildren(this.watcher,
this.watcher.splitLogZNode));
} catch (KeeperException e) {
LOG.warn(Could not get children of znode +
this.watcher.splitLogZNode, e);
try {
Thread.sleep(1000);
} catch (InterruptedException e1) {
LOG.warn(Interrupted while trying to get task list ..., e1);
Thread.currentThread().interrupt();
return null;
}
}
}
{code}
in the org.apache.hadoop.hbase.regionserver.SplitLogWorker
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-5635) If getTaskList() returns null, splitlogWorker would go down and it won't serve any requests
[
https://issues.apache.org/jira/browse/HBASE-5635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ramkrishna.s.vasudevan reassigned HBASE-5635:
-
Assignee: Chinna Rao Lalam (was: chinna)
If getTaskList() returns null, splitlogWorker would go down and it won't
serve any requests
---
Key: HBASE-5635
URL: https://issues.apache.org/jira/browse/HBASE-5635
Project: HBase
Issue Type: Bug
Components: wal
Affects Versions: 0.92.1
Reporter: Kristam Subba Swathi
Assignee: Chinna Rao Lalam
Attachments: HBASE-5635.1.patch, HBASE-5635.2.patch,
HBASE-5635._trunk.patch, HBASE-5635.patch, HBASE-5635_0.94.patch
During the hlog split operation if all the zookeepers are down ,then the
paths will be returned as null and the splitworker thread wil be exited
Now this regionserver wil not be able to acquire any other tasks since the
splitworker thread is exited
Please find the attached code for more details
{code}
private ListString getTaskList() {
for (int i = 0; i zkretries; i++) {
try {
return (ZKUtil.listChildrenAndWatchForNewChildren(this.watcher,
this.watcher.splitLogZNode));
} catch (KeeperException e) {
LOG.warn(Could not get children of znode +
this.watcher.splitLogZNode, e);
try {
Thread.sleep(1000);
} catch (InterruptedException e1) {
LOG.warn(Interrupted while trying to get task list ..., e1);
Thread.currentThread().interrupt();
return null;
}
}
}
{code}
in the org.apache.hadoop.hbase.regionserver.SplitLogWorker
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5635) If getTaskList() returns null, splitlogWorker would go down and it won't serve any requests
[
https://issues.apache.org/jira/browse/HBASE-5635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ramkrishna.s.vasudevan updated HBASE-5635:
--
Fix Version/s: 0.94.1
0.96.0
If getTaskList() returns null, splitlogWorker would go down and it won't
serve any requests
---
Key: HBASE-5635
URL: https://issues.apache.org/jira/browse/HBASE-5635
Project: HBase
Issue Type: Bug
Components: wal
Affects Versions: 0.92.1
Reporter: Kristam Subba Swathi
Assignee: Chinna Rao Lalam
Fix For: 0.96.0, 0.94.1
Attachments: HBASE-5635.1.patch, HBASE-5635.2.patch,
HBASE-5635._trunk.patch, HBASE-5635.patch, HBASE-5635_0.94.patch
During the hlog split operation if all the zookeepers are down ,then the
paths will be returned as null and the splitworker thread wil be exited
Now this regionserver wil not be able to acquire any other tasks since the
splitworker thread is exited
Please find the attached code for more details
{code}
private ListString getTaskList() {
for (int i = 0; i zkretries; i++) {
try {
return (ZKUtil.listChildrenAndWatchForNewChildren(this.watcher,
this.watcher.splitLogZNode));
} catch (KeeperException e) {
LOG.warn(Could not get children of znode +
this.watcher.splitLogZNode, e);
try {
Thread.sleep(1000);
} catch (InterruptedException e1) {
LOG.warn(Interrupted while trying to get task list ..., e1);
Thread.currentThread().interrupt();
return null;
}
}
}
{code}
in the org.apache.hadoop.hbase.regionserver.SplitLogWorker
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (HBASE-5860) splitlogmanager should not unnecessarily resubmit tasks when zk unavailable
Prakash Khemani created HBASE-5860: -- Summary: splitlogmanager should not unnecessarily resubmit tasks when zk unavailable Key: HBASE-5860 URL: https://issues.apache.org/jira/browse/HBASE-5860 Project: HBase Issue Type: Improvement Reporter: Prakash Khemani Assignee: Prakash Khemani (Doesn't really impact the run time or correctness of log splitting) say the master has lost connection to zk. splitlogmanager's timeoutmanager will realize that all the tasks that were submitted are still unassigned. It will resubmit those tasks (i.e. create dummy znodes) splitlogmanager should realze that the tasks are unassigned but their znodes have not been created. 012-04-20 13:11:20,516 INFO org.apache.hadoop.hbase.master.SplitLogManager: dead splitlog worker msgstore295.snc4.facebook.com,60020,1334948757026 2012-04-20 13:11:20,517 DEBUG org.apache.hadoop.hbase.master.SplitLogManager: Scheduling batch of logs to split 2012-04-20 13:11:20,517 INFO org.apache.hadoop.hbase.master.SplitLogManager: started splitting logs in [hdfs://msgstore215.snc4.facebook.com:9000/MSGSTORE215-SNC4-HBASE/.logs/msgstore295.snc4.facebook.com,60020,1334948757026-splitting] 2012-04-20 13:11:20,565 INFO org.apache.zookeeper.ClientCnxn: Opening socket connection to server msgstore235.snc4.facebook.com/10.30.222.186:2181 2012-04-20 13:11:20,566 INFO org.apache.zookeeper.ClientCnxn: Socket connection established to msgstore235.snc4.facebook.com/10.30.222.186:2181, initiating session 2012-04-20 13:11:20,575 INFO org.apache.hadoop.hbase.master.SplitLogManager: total tasks = 4 unassigned = 4 2012-04-20 13:11:20,576 DEBUG org.apache.hadoop.hbase.master.SplitLogManager: resubmitting unassigned task(s) after timeout 2012-04-20 13:11:21,577 DEBUG org.apache.hadoop.hbase.master.SplitLogManager: resubmitting unassigned task(s) after timeout 2012-04-20 13:11:21,683 INFO org.apache.zookeeper.ClientCnxn: Unable to read additional data from server sessionid 0x36ccb0f8010002, likely server has closed socket, closing socket connection and attempting reconnect 2012-04-20 13:11:21,683 INFO org.apache.zookeeper.ClientCnxn: Unable to read additional data from server sessionid 0x136ccb0f489, likely server has closed socket, closing socket connection and attempting reconnect 2012-04-20 13:11:21,786 WARN org.apache.hadoop.hbase.master.SplitLogManager$CreateAsyncCallback: create rc =CONNECTIONLOSS for /hbase/splitlog/hdfs%3A%2F%2Fmsgstore215.snc4.facebook.com%3A9000%2FMSGSTORE215-SNC4-HBASE%2F.logs%2Fmsgstore295.snc4.facebook.com%2C60020%2C1334948757026-splitting%2F10.30.251.186%253A60020.1334951586677 retry=3 2012-04-20 13:11:21,786 WARN org.apache.hadoop.hbase.master.SplitLogManager$CreateAsyncCallback: create rc =CONNECTIONLOSS for /hbase/splitlog/hdfs%3A%2F%2Fmsgstore215.snc4.facebook.com%3A9000%2FMSGSTORE215-SNC4-HBASE%2F.logs%2Fmsgstore295.snc4.facebook.com%2C60020%2C1334948757026-splitting%2F10.30.251.186%253A60020.1334951920332 retry=3 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5848) Create table with EMPTY_START_ROW passed as splitKey causes the HMaster to abort
[ https://issues.apache.org/jira/browse/HBASE-5848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259721#comment-13259721 ] ramkrishna.s.vasudevan commented on HBASE-5848: --- @Lars Are you working on this? If not i will take up this? Create table with EMPTY_START_ROW passed as splitKey causes the HMaster to abort Key: HBASE-5848 URL: https://issues.apache.org/jira/browse/HBASE-5848 Project: HBase Issue Type: Bug Components: client Reporter: Lars Hofhansl Assignee: Lars Hofhansl Priority: Minor A coworker of mine just had this scenario. It does not make sense the EMPTY_START_ROW as splitKey (since the region with the empty start key is implicit), but it should not cause the HMaster to abort. The abort happens because it tries to bulk assign the same region twice and then runs into race conditions with ZK. The same would (presumably) happen when two identical split keys are passed, but the client blocks that. The simplest solution here is to also block passed null or EMPTY_START_ROW as split key by the client. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5851) TestProcessBasedCluster sometimes fails
[
https://issues.apache.org/jira/browse/HBASE-5851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259728#comment-13259728
]
Jimmy Xiang commented on HBASE-5851:
I can look into it.
TestProcessBasedCluster sometimes fails
---
Key: HBASE-5851
URL: https://issues.apache.org/jira/browse/HBASE-5851
Project: HBase
Issue Type: Test
Reporter: Zhihong Yu
Assignee: Jimmy Xiang
TestProcessBasedCluster failed in
https://builds.apache.org/job/HBase-TRUNK-security/178
Looks like cluster failed to start:
{code}
2012-04-21 14:22:32,666 INFO [Thread-1]
util.ProcessBasedLocalHBaseCluster(176): Waiting for HBase to startup.
Retries left: 2
java.io.IOException: Giving up trying to location region in meta: thread is
interrupted.
at
org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.locateRegionInMeta(HConnectionManager.java:1173)
at
org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.locateRegion(HConnectionManager.java:956)
at
org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.locateRegion(HConnectionManager.java:917)
at org.apache.hadoop.hbase.client.HTable.finishSetup(HTable.java:252)
at org.apache.hadoop.hbase.client.HTable.init(HTable.java:192)
at
org.apache.hadoop.hbase.util.ProcessBasedLocalHBaseCluster.startHBase(ProcessBasedLocalHBaseCluster.java:174)
at
org.apache.hadoop.hbase.util.TestProcessBasedCluster.testProcessBasedCluster(TestProcessBasedCluster.java:56)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
at
org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:62)
java.lang.InterruptedException: sleep interrupted at
java.lang.Thread.sleep(Native Method)
at org.apache.hadoop.hbase.util.Threads.sleep(Threads.java:134)
at
org.apache.hadoop.hbase.util.ProcessBasedLocalHBaseCluster.startHBase(ProcessBasedLocalHBaseCluster.java:178)
at
org.apache.hadoop.hbase.util.TestProcessBasedCluster.testProcessBasedCluster(TestProcessBasedCluster.java:56)
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-5851) TestProcessBasedCluster sometimes fails
[
https://issues.apache.org/jira/browse/HBASE-5851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jimmy Xiang reassigned HBASE-5851:
--
Assignee: Jimmy Xiang
TestProcessBasedCluster sometimes fails
---
Key: HBASE-5851
URL: https://issues.apache.org/jira/browse/HBASE-5851
Project: HBase
Issue Type: Test
Reporter: Zhihong Yu
Assignee: Jimmy Xiang
TestProcessBasedCluster failed in
https://builds.apache.org/job/HBase-TRUNK-security/178
Looks like cluster failed to start:
{code}
2012-04-21 14:22:32,666 INFO [Thread-1]
util.ProcessBasedLocalHBaseCluster(176): Waiting for HBase to startup.
Retries left: 2
java.io.IOException: Giving up trying to location region in meta: thread is
interrupted.
at
org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.locateRegionInMeta(HConnectionManager.java:1173)
at
org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.locateRegion(HConnectionManager.java:956)
at
org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.locateRegion(HConnectionManager.java:917)
at org.apache.hadoop.hbase.client.HTable.finishSetup(HTable.java:252)
at org.apache.hadoop.hbase.client.HTable.init(HTable.java:192)
at
org.apache.hadoop.hbase.util.ProcessBasedLocalHBaseCluster.startHBase(ProcessBasedLocalHBaseCluster.java:174)
at
org.apache.hadoop.hbase.util.TestProcessBasedCluster.testProcessBasedCluster(TestProcessBasedCluster.java:56)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
at
org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:62)
java.lang.InterruptedException: sleep interrupted at
java.lang.Thread.sleep(Native Method)
at org.apache.hadoop.hbase.util.Threads.sleep(Threads.java:134)
at
org.apache.hadoop.hbase.util.ProcessBasedLocalHBaseCluster.startHBase(ProcessBasedLocalHBaseCluster.java:178)
at
org.apache.hadoop.hbase.util.TestProcessBasedCluster.testProcessBasedCluster(TestProcessBasedCluster.java:56)
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5621) Convert admin protocol of HRegionInterface to PB
[ https://issues.apache.org/jira/browse/HBASE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259729#comment-13259729 ] Jimmy Xiang commented on HBASE-5621: Good to know there is already a jira to track TestProcessBasedCluster.testProcessBasedCluster failure. Besides that one, I also have this one failed sometimes (not always): TestServerCustomProtocol. It is flaky. Convert admin protocol of HRegionInterface to PB Key: HBASE-5621 URL: https://issues.apache.org/jira/browse/HBASE-5621 Project: HBase Issue Type: Sub-task Components: ipc, master, migration, regionserver Reporter: Jimmy Xiang Assignee: Jimmy Xiang Fix For: 0.96.0 Attachments: hbase-5621_v3.patch, hbase_5621_v4.patch, hbase_5621_v4.patch, hbase_5621_v5.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5851) TestProcessBasedCluster sometimes fails
[
https://issues.apache.org/jira/browse/HBASE-5851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259734#comment-13259734
]
Jimmy Xiang commented on HBASE-5851:
I have looked into it and know the root cause, don't have time to fix it yet.
The root cause is because the server is not in secure mode while the client
expects it to be a secure sever.
TestProcessBasedCluster sometimes fails
---
Key: HBASE-5851
URL: https://issues.apache.org/jira/browse/HBASE-5851
Project: HBase
Issue Type: Test
Reporter: Zhihong Yu
Assignee: Jimmy Xiang
TestProcessBasedCluster failed in
https://builds.apache.org/job/HBase-TRUNK-security/178
Looks like cluster failed to start:
{code}
2012-04-21 14:22:32,666 INFO [Thread-1]
util.ProcessBasedLocalHBaseCluster(176): Waiting for HBase to startup.
Retries left: 2
java.io.IOException: Giving up trying to location region in meta: thread is
interrupted.
at
org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.locateRegionInMeta(HConnectionManager.java:1173)
at
org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.locateRegion(HConnectionManager.java:956)
at
org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.locateRegion(HConnectionManager.java:917)
at org.apache.hadoop.hbase.client.HTable.finishSetup(HTable.java:252)
at org.apache.hadoop.hbase.client.HTable.init(HTable.java:192)
at
org.apache.hadoop.hbase.util.ProcessBasedLocalHBaseCluster.startHBase(ProcessBasedLocalHBaseCluster.java:174)
at
org.apache.hadoop.hbase.util.TestProcessBasedCluster.testProcessBasedCluster(TestProcessBasedCluster.java:56)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
at
org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:62)
java.lang.InterruptedException: sleep interrupted at
java.lang.Thread.sleep(Native Method)
at org.apache.hadoop.hbase.util.Threads.sleep(Threads.java:134)
at
org.apache.hadoop.hbase.util.ProcessBasedLocalHBaseCluster.startHBase(ProcessBasedLocalHBaseCluster.java:178)
at
org.apache.hadoop.hbase.util.TestProcessBasedCluster.testProcessBasedCluster(TestProcessBasedCluster.java:56)
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5848) Create table with EMPTY_START_ROW passed as splitKey causes the HMaster to abort
[ https://issues.apache.org/jira/browse/HBASE-5848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259740#comment-13259740 ] Zhihong Yu commented on HBASE-5848: --- According to http://docs.oracle.com/javase/6/docs/api/java/lang/System.html#nanoTime%28%29: This method can only be used to measure elapsed time and is not related to any other notion of system or wall-clock time So we shouldn't use nanoTime(). Create table with EMPTY_START_ROW passed as splitKey causes the HMaster to abort Key: HBASE-5848 URL: https://issues.apache.org/jira/browse/HBASE-5848 Project: HBase Issue Type: Bug Components: client Reporter: Lars Hofhansl Assignee: Lars Hofhansl Priority: Minor A coworker of mine just had this scenario. It does not make sense the EMPTY_START_ROW as splitKey (since the region with the empty start key is implicit), but it should not cause the HMaster to abort. The abort happens because it tries to bulk assign the same region twice and then runs into race conditions with ZK. The same would (presumably) happen when two identical split keys are passed, but the client blocks that. The simplest solution here is to also block passed null or EMPTY_START_ROW as split key by the client. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5621) Convert admin protocol of HRegionInterface to PB
[ https://issues.apache.org/jira/browse/HBASE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259742#comment-13259742 ] Hadoop QA commented on HBASE-5621: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12523812/hbase_5621_v5.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 42 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.master.TestAssignmentManager Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1609//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1609//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1609//console This message is automatically generated. Convert admin protocol of HRegionInterface to PB Key: HBASE-5621 URL: https://issues.apache.org/jira/browse/HBASE-5621 Project: HBase Issue Type: Sub-task Components: ipc, master, migration, regionserver Reporter: Jimmy Xiang Assignee: Jimmy Xiang Fix For: 0.96.0 Attachments: hbase-5621_v3.patch, hbase_5621_v4.patch, hbase_5621_v4.patch, hbase_5621_v5.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5621) Convert admin protocol of HRegionInterface to PB
[ https://issues.apache.org/jira/browse/HBASE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259748#comment-13259748 ] Jimmy Xiang commented on HBASE-5621: TestAssignmentManager passed locally. For secure profile, TestHRegion also has some issue. Convert admin protocol of HRegionInterface to PB Key: HBASE-5621 URL: https://issues.apache.org/jira/browse/HBASE-5621 Project: HBase Issue Type: Sub-task Components: ipc, master, migration, regionserver Reporter: Jimmy Xiang Assignee: Jimmy Xiang Fix For: 0.96.0 Attachments: hbase-5621_v3.patch, hbase_5621_v4.patch, hbase_5621_v4.patch, hbase_5621_v5.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5826) Improve sync of HLog edits
[ https://issues.apache.org/jira/browse/HBASE-5826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhihong Yu updated HBASE-5826: -- Attachment: 5826.txt Todd's patch, for trunk. Improve sync of HLog edits -- Key: HBASE-5826 URL: https://issues.apache.org/jira/browse/HBASE-5826 Project: HBase Issue Type: Improvement Reporter: Zhihong Yu Attachments: 5826.txt HBASE-5782 solved the correctness issue for the sync of HLog edits. Todd provided a patch that would achieve higher throughput. This JIRA is a continuation of Todd's work submitted there. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5654) [findbugs] Address dodgy bugs
[ https://issues.apache.org/jira/browse/HBASE-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259760#comment-13259760 ] Hudson commented on HBASE-5654: --- Integrated in HBase-TRUNK-security #181 (See [https://builds.apache.org/job/HBase-TRUNK-security/181/]) HBASE-5654 [findbugs] Address dodgy bugs (Ashutosh Jindal) (Revision 1329132) Result = FAILURE jmhsieh : Files : * /hbase/trunk/dev-support/findbugs-exclude.xml * /hbase/trunk/dev-support/test-patch.properties * /hbase/trunk/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/HServerLoad.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/FilterList.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/AbstractHFileWriter.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/IncreasingToUpperBoundRegionSplitPolicy.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreLAB.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionProgress.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/ByteBloomFilter.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/CompoundBloomFilterWriter.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/CompressionTest.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/FSHDFSUtils.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/PoolMap.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/RegionSplitter.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java [findbugs] Address dodgy bugs - Key: HBASE-5654 URL: https://issues.apache.org/jira/browse/HBASE-5654 Project: HBase Issue Type: Sub-task Components: scripts Affects Versions: 0.96.0 Reporter: Jonathan Hsieh Assignee: Ashutosh Jindal Labels: patch Fix For: 0.96.0 Attachments: Hbase 5654_v3.patch, Hbase-5654.patch, Hbase_5654_V2.patch, hbase-5654-tweak.patch, hbase-5654_v5.patch See https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html#Warnings_STYLE This may be broken down further. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5830) Cleanup SequenceFileLogWriter to use syncFs api from SequenceFile#Writer directly in trunk.
[ https://issues.apache.org/jira/browse/HBASE-5830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uma Maheswara Rao G updated HBASE-5830: --- Attachment: HBASE-5830.patch Cleanup SequenceFileLogWriter to use syncFs api from SequenceFile#Writer directly in trunk. --- Key: HBASE-5830 URL: https://issues.apache.org/jira/browse/HBASE-5830 Project: HBase Issue Type: Bug Components: wal Affects Versions: 0.96.0 Reporter: Uma Maheswara Rao G Assignee: Uma Maheswara Rao G Attachments: HBASE-5830.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5830) Cleanup SequenceFileLogWriter to use syncFs api from SequenceFile#Writer directly in trunk.
[ https://issues.apache.org/jira/browse/HBASE-5830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259767#comment-13259767 ] Uma Maheswara Rao G commented on HBASE-5830: Attached the patch. SequenceFileLogWriter will use the syncFs api from SequenceFile writer. Cleanup SequenceFileLogWriter to use syncFs api from SequenceFile#Writer directly in trunk. --- Key: HBASE-5830 URL: https://issues.apache.org/jira/browse/HBASE-5830 Project: HBase Issue Type: Bug Components: wal Affects Versions: 0.96.0 Reporter: Uma Maheswara Rao G Assignee: Uma Maheswara Rao G Attachments: HBASE-5830.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5861) Hadoop 23 compile broken due to tests introduced in HBASE-5064
[
https://issues.apache.org/jira/browse/HBASE-5861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jonathan Hsieh updated HBASE-5861:
--
Fix Version/s: 0.96.0
0.94.0
Hadoop 23 compile broken due to tests introduced in HBASE-5064
---
Key: HBASE-5861
URL: https://issues.apache.org/jira/browse/HBASE-5861
Project: HBase
Issue Type: Bug
Components: test
Affects Versions: 0.94.0, 0.96.0
Reporter: Jonathan Hsieh
Priority: Blocker
Fix For: 0.94.0, 0.96.0
When attempting to compile HBase 0.94rc1 against hadoop 23, I got this set of
compilation error messages:
{code}
jon@swoop:~/proj/hbase-0.94$ mvn clean test -Dhadoop.profile=23 -DskipTests
...
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 18.926s
[INFO] Finished at: Mon Apr 23 10:38:47 PDT 2012
[INFO] Final Memory: 55M/555M
[INFO]
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:2.0.2:testCompile
(default-testCompile) on project hbase: Compilation failure: Compilation
failure:
[ERROR]
/home/jon/proj/hbase-0.94/src/test/java/org/apache/hadoop/hbase/mapreduce/TestHLogRecordReader.java:[147,46]
org.apache.hadoop.mapreduce.JobContext is abstract; cannot be instantiated
[ERROR]
[ERROR]
/home/jon/proj/hbase-0.94/src/test/java/org/apache/hadoop/hbase/mapreduce/TestHLogRecordReader.java:[153,29]
org.apache.hadoop.mapreduce.JobContext is abstract; cannot be instantiated
[ERROR]
[ERROR]
/home/jon/proj/hbase-0.94/src/test/java/org/apache/hadoop/hbase/mapreduce/TestHLogRecordReader.java:[194,46]
org.apache.hadoop.mapreduce.JobContext is abstract; cannot be instantiated
[ERROR]
[ERROR]
/home/jon/proj/hbase-0.94/src/test/java/org/apache/hadoop/hbase/mapreduce/TestHLogRecordReader.java:[206,29]
org.apache.hadoop.mapreduce.JobContext is abstract; cannot be instantiated
[ERROR]
[ERROR]
/home/jon/proj/hbase-0.94/src/test/java/org/apache/hadoop/hbase/mapreduce/TestHLogRecordReader.java:[213,29]
org.apache.hadoop.mapreduce.JobContext is abstract; cannot be instantiated
[ERROR]
[ERROR]
/home/jon/proj/hbase-0.94/src/test/java/org/apache/hadoop/hbase/mapreduce/TestHLogRecordReader.java:[226,29]
org.apache.hadoop.mapreduce.TaskAttemptContext is abstract; cannot be
instantiated
[ERROR] - [Help 1]
{code}
Upon further investigation this issue is due to code introduced in HBASE-5064
and is also present in trunk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (HBASE-5861) Hadoop 23 compile broken due to tests introduced in HBASE-5064
Jonathan Hsieh created HBASE-5861:
-
Summary: Hadoop 23 compile broken due to tests introduced in
HBASE-5064
Key: HBASE-5861
URL: https://issues.apache.org/jira/browse/HBASE-5861
Project: HBase
Issue Type: Bug
Components: test
Affects Versions: 0.94.0, 0.96.0
Reporter: Jonathan Hsieh
Priority: Blocker
When attempting to compile HBase 0.94rc1 against hadoop 23, I got this set of
compilation error messages:
{code}
jon@swoop:~/proj/hbase-0.94$ mvn clean test -Dhadoop.profile=23 -DskipTests
...
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 18.926s
[INFO] Finished at: Mon Apr 23 10:38:47 PDT 2012
[INFO] Final Memory: 55M/555M
[INFO]
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:2.0.2:testCompile
(default-testCompile) on project hbase: Compilation failure: Compilation
failure:
[ERROR]
/home/jon/proj/hbase-0.94/src/test/java/org/apache/hadoop/hbase/mapreduce/TestHLogRecordReader.java:[147,46]
org.apache.hadoop.mapreduce.JobContext is abstract; cannot be instantiated
[ERROR]
[ERROR]
/home/jon/proj/hbase-0.94/src/test/java/org/apache/hadoop/hbase/mapreduce/TestHLogRecordReader.java:[153,29]
org.apache.hadoop.mapreduce.JobContext is abstract; cannot be instantiated
[ERROR]
[ERROR]
/home/jon/proj/hbase-0.94/src/test/java/org/apache/hadoop/hbase/mapreduce/TestHLogRecordReader.java:[194,46]
org.apache.hadoop.mapreduce.JobContext is abstract; cannot be instantiated
[ERROR]
[ERROR]
/home/jon/proj/hbase-0.94/src/test/java/org/apache/hadoop/hbase/mapreduce/TestHLogRecordReader.java:[206,29]
org.apache.hadoop.mapreduce.JobContext is abstract; cannot be instantiated
[ERROR]
[ERROR]
/home/jon/proj/hbase-0.94/src/test/java/org/apache/hadoop/hbase/mapreduce/TestHLogRecordReader.java:[213,29]
org.apache.hadoop.mapreduce.JobContext is abstract; cannot be instantiated
[ERROR]
[ERROR]
/home/jon/proj/hbase-0.94/src/test/java/org/apache/hadoop/hbase/mapreduce/TestHLogRecordReader.java:[226,29]
org.apache.hadoop.mapreduce.TaskAttemptContext is abstract; cannot be
instantiated
[ERROR] - [Help 1]
{code}
Upon further investigation this issue is due to code introduced in HBASE-5064
and is also present in trunk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5861) Hadoop 23 compile broken due to tests introduced in HBASE-5064
[
https://issues.apache.org/jira/browse/HBASE-5861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259773#comment-13259773
]
stack commented on HBASE-5861:
--
@Jon Which code breaks the build? The hbase-5064 changes have been in there
with a good while now.
Hadoop 23 compile broken due to tests introduced in HBASE-5064
---
Key: HBASE-5861
URL: https://issues.apache.org/jira/browse/HBASE-5861
Project: HBase
Issue Type: Bug
Components: test
Affects Versions: 0.94.0, 0.96.0
Reporter: Jonathan Hsieh
Priority: Blocker
Fix For: 0.94.0, 0.96.0
When attempting to compile HBase 0.94rc1 against hadoop 23, I got this set of
compilation error messages:
{code}
jon@swoop:~/proj/hbase-0.94$ mvn clean test -Dhadoop.profile=23 -DskipTests
...
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 18.926s
[INFO] Finished at: Mon Apr 23 10:38:47 PDT 2012
[INFO] Final Memory: 55M/555M
[INFO]
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:2.0.2:testCompile
(default-testCompile) on project hbase: Compilation failure: Compilation
failure:
[ERROR]
/home/jon/proj/hbase-0.94/src/test/java/org/apache/hadoop/hbase/mapreduce/TestHLogRecordReader.java:[147,46]
org.apache.hadoop.mapreduce.JobContext is abstract; cannot be instantiated
[ERROR]
[ERROR]
/home/jon/proj/hbase-0.94/src/test/java/org/apache/hadoop/hbase/mapreduce/TestHLogRecordReader.java:[153,29]
org.apache.hadoop.mapreduce.JobContext is abstract; cannot be instantiated
[ERROR]
[ERROR]
/home/jon/proj/hbase-0.94/src/test/java/org/apache/hadoop/hbase/mapreduce/TestHLogRecordReader.java:[194,46]
org.apache.hadoop.mapreduce.JobContext is abstract; cannot be instantiated
[ERROR]
[ERROR]
/home/jon/proj/hbase-0.94/src/test/java/org/apache/hadoop/hbase/mapreduce/TestHLogRecordReader.java:[206,29]
org.apache.hadoop.mapreduce.JobContext is abstract; cannot be instantiated
[ERROR]
[ERROR]
/home/jon/proj/hbase-0.94/src/test/java/org/apache/hadoop/hbase/mapreduce/TestHLogRecordReader.java:[213,29]
org.apache.hadoop.mapreduce.JobContext is abstract; cannot be instantiated
[ERROR]
[ERROR]
/home/jon/proj/hbase-0.94/src/test/java/org/apache/hadoop/hbase/mapreduce/TestHLogRecordReader.java:[226,29]
org.apache.hadoop.mapreduce.TaskAttemptContext is abstract; cannot be
instantiated
[ERROR] - [Help 1]
{code}
Upon further investigation this issue is due to code introduced in HBASE-5064
and is also present in trunk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5830) Cleanup SequenceFileLogWriter to use syncFs api from SequenceFile#Writer directly in trunk.
[ https://issues.apache.org/jira/browse/HBASE-5830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uma Maheswara Rao G updated HBASE-5830: --- Status: Patch Available (was: Open) Cleanup SequenceFileLogWriter to use syncFs api from SequenceFile#Writer directly in trunk. --- Key: HBASE-5830 URL: https://issues.apache.org/jira/browse/HBASE-5830 Project: HBase Issue Type: Bug Components: wal Affects Versions: 0.96.0 Reporter: Uma Maheswara Rao G Assignee: Uma Maheswara Rao G Attachments: HBASE-5830.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5635) If getTaskList() returns null, splitlogWorker would go down and it won't serve any requests
[
https://issues.apache.org/jira/browse/HBASE-5635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259778#comment-13259778
]
Hudson commented on HBASE-5635:
---
Integrated in HBase-TRUNK #2798 (See
[https://builds.apache.org/job/HBase-TRUNK/2798/])
HBASE-5635 If getTaskList() returns null, splitlogWorker would go down and
it won't serve any requests (Ram) (Revision 1329322)
Result = FAILURE
ramkrishna :
Files :
*
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/SplitLogWorker.java
If getTaskList() returns null, splitlogWorker would go down and it won't
serve any requests
---
Key: HBASE-5635
URL: https://issues.apache.org/jira/browse/HBASE-5635
Project: HBase
Issue Type: Bug
Components: wal
Affects Versions: 0.92.1
Reporter: Kristam Subba Swathi
Assignee: Chinna Rao Lalam
Fix For: 0.96.0, 0.94.1
Attachments: HBASE-5635.1.patch, HBASE-5635.2.patch,
HBASE-5635._trunk.patch, HBASE-5635.patch, HBASE-5635_0.94.patch
During the hlog split operation if all the zookeepers are down ,then the
paths will be returned as null and the splitworker thread wil be exited
Now this regionserver wil not be able to acquire any other tasks since the
splitworker thread is exited
Please find the attached code for more details
{code}
private ListString getTaskList() {
for (int i = 0; i zkretries; i++) {
try {
return (ZKUtil.listChildrenAndWatchForNewChildren(this.watcher,
this.watcher.splitLogZNode));
} catch (KeeperException e) {
LOG.warn(Could not get children of znode +
this.watcher.splitLogZNode, e);
try {
Thread.sleep(1000);
} catch (InterruptedException e1) {
LOG.warn(Interrupted while trying to get task list ..., e1);
Thread.currentThread().interrupt();
return null;
}
}
}
{code}
in the org.apache.hadoop.hbase.regionserver.SplitLogWorker
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-5857) RIT map in RS not getting cleared while region opening
[
https://issues.apache.org/jira/browse/HBASE-5857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chinna Rao Lalam reassigned HBASE-5857:
---
Assignee: Chinna Rao Lalam
RIT map in RS not getting cleared while region opening
--
Key: HBASE-5857
URL: https://issues.apache.org/jira/browse/HBASE-5857
Project: HBase
Issue Type: Bug
Affects Versions: 0.90.6
Reporter: Chinna Rao Lalam
Assignee: Chinna Rao Lalam
Fix For: 0.92.2, 0.96.0, 0.94.1
Attachments: HBASE-5857_0.92.patch, HBASE-5857_94.patch,
HBASE-5857_trunk.patch
While opening the region in RS after adding the region to
regionsInTransitionInRS if tableDescriptors.get() throws exception the region
wont be cleared from regionsInTransitionInRS. So next time if it tries to
open the region in the same RS it will throw the
RegionAlreadyInTransitionException.
if swap the below statement this issue wont come.
{code}
this.regionsInTransitionInRS.putIfAbsent(region.getEncodedNameAsBytes(),true);
HTableDescriptor htd = this.tableDescriptors.get(region.getTableName());
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5826) Improve sync of HLog edits
[ https://issues.apache.org/jira/browse/HBASE-5826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhihong Yu updated HBASE-5826: -- Status: Patch Available (was: Open) Improve sync of HLog edits -- Key: HBASE-5826 URL: https://issues.apache.org/jira/browse/HBASE-5826 Project: HBase Issue Type: Improvement Reporter: Zhihong Yu Attachments: 5826.txt HBASE-5782 solved the correctness issue for the sync of HLog edits. Todd provided a patch that would achieve higher throughput. This JIRA is a continuation of Todd's work submitted there. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5635) If getTaskList() returns null, splitlogWorker would go down and it won't serve any requests
[
https://issues.apache.org/jira/browse/HBASE-5635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259780#comment-13259780
]
Hudson commented on HBASE-5635:
---
Integrated in HBase-0.94 #136 (See
[https://builds.apache.org/job/HBase-0.94/136/])
HBASE-5635 If getTaskList() returns null, splitlogWorker would go down and
it won't serve any requests (Chinna) (Revision 1329325)
Result = SUCCESS
ramkrishna :
Files :
*
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/SplitLogWorker.java
If getTaskList() returns null, splitlogWorker would go down and it won't
serve any requests
---
Key: HBASE-5635
URL: https://issues.apache.org/jira/browse/HBASE-5635
Project: HBase
Issue Type: Bug
Components: wal
Affects Versions: 0.92.1
Reporter: Kristam Subba Swathi
Assignee: Chinna Rao Lalam
Fix For: 0.96.0, 0.94.1
Attachments: HBASE-5635.1.patch, HBASE-5635.2.patch,
HBASE-5635._trunk.patch, HBASE-5635.patch, HBASE-5635_0.94.patch
During the hlog split operation if all the zookeepers are down ,then the
paths will be returned as null and the splitworker thread wil be exited
Now this regionserver wil not be able to acquire any other tasks since the
splitworker thread is exited
Please find the attached code for more details
{code}
private ListString getTaskList() {
for (int i = 0; i zkretries; i++) {
try {
return (ZKUtil.listChildrenAndWatchForNewChildren(this.watcher,
this.watcher.splitLogZNode));
} catch (KeeperException e) {
LOG.warn(Could not get children of znode +
this.watcher.splitLogZNode, e);
try {
Thread.sleep(1000);
} catch (InterruptedException e1) {
LOG.warn(Interrupted while trying to get task list ..., e1);
Thread.currentThread().interrupt();
return null;
}
}
}
{code}
in the org.apache.hadoop.hbase.regionserver.SplitLogWorker
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5857) RIT map in RS not getting cleared while region opening
[
https://issues.apache.org/jira/browse/HBASE-5857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259782#comment-13259782
]
Chinna Rao Lalam commented on HBASE-5857:
-
@Stack : Thanks for the review.
That is also good way of verifying instead of doing another opertion.I will
update the patch with this change.
RIT map in RS not getting cleared while region opening
--
Key: HBASE-5857
URL: https://issues.apache.org/jira/browse/HBASE-5857
Project: HBase
Issue Type: Bug
Affects Versions: 0.90.6
Reporter: Chinna Rao Lalam
Assignee: Chinna Rao Lalam
Fix For: 0.92.2, 0.96.0, 0.94.1
Attachments: HBASE-5857_0.92.patch, HBASE-5857_94.patch,
HBASE-5857_trunk.patch
While opening the region in RS after adding the region to
regionsInTransitionInRS if tableDescriptors.get() throws exception the region
wont be cleared from regionsInTransitionInRS. So next time if it tries to
open the region in the same RS it will throw the
RegionAlreadyInTransitionException.
if swap the below statement this issue wont come.
{code}
this.regionsInTransitionInRS.putIfAbsent(region.getEncodedNameAsBytes(),true);
HTableDescriptor htd = this.tableDescriptors.get(region.getTableName());
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5861) Hadoop 23 compile broken due to tests introduced in HBASE-5064
[
https://issues.apache.org/jira/browse/HBASE-5861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259785#comment-13259785
]
Uma Maheswara Rao G commented on HBASE-5861:
In branch-1, JobContext is a class.
{code}
public class JobContext {
{code}
Now in hadoop trunk or hadoop-2, that is changed to interface.
{code}
@InterfaceAudience.Public
@InterfaceStability.Evolving
public interface JobContext extends MRJobConfig {
{code}
Hadoop 23 compile broken due to tests introduced in HBASE-5064
---
Key: HBASE-5861
URL: https://issues.apache.org/jira/browse/HBASE-5861
Project: HBase
Issue Type: Bug
Components: test
Affects Versions: 0.94.0, 0.96.0
Reporter: Jonathan Hsieh
Priority: Blocker
Fix For: 0.94.0, 0.96.0
When attempting to compile HBase 0.94rc1 against hadoop 23, I got this set of
compilation error messages:
{code}
jon@swoop:~/proj/hbase-0.94$ mvn clean test -Dhadoop.profile=23 -DskipTests
...
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 18.926s
[INFO] Finished at: Mon Apr 23 10:38:47 PDT 2012
[INFO] Final Memory: 55M/555M
[INFO]
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:2.0.2:testCompile
(default-testCompile) on project hbase: Compilation failure: Compilation
failure:
[ERROR]
/home/jon/proj/hbase-0.94/src/test/java/org/apache/hadoop/hbase/mapreduce/TestHLogRecordReader.java:[147,46]
org.apache.hadoop.mapreduce.JobContext is abstract; cannot be instantiated
[ERROR]
[ERROR]
/home/jon/proj/hbase-0.94/src/test/java/org/apache/hadoop/hbase/mapreduce/TestHLogRecordReader.java:[153,29]
org.apache.hadoop.mapreduce.JobContext is abstract; cannot be instantiated
[ERROR]
[ERROR]
/home/jon/proj/hbase-0.94/src/test/java/org/apache/hadoop/hbase/mapreduce/TestHLogRecordReader.java:[194,46]
org.apache.hadoop.mapreduce.JobContext is abstract; cannot be instantiated
[ERROR]
[ERROR]
/home/jon/proj/hbase-0.94/src/test/java/org/apache/hadoop/hbase/mapreduce/TestHLogRecordReader.java:[206,29]
org.apache.hadoop.mapreduce.JobContext is abstract; cannot be instantiated
[ERROR]
[ERROR]
/home/jon/proj/hbase-0.94/src/test/java/org/apache/hadoop/hbase/mapreduce/TestHLogRecordReader.java:[213,29]
org.apache.hadoop.mapreduce.JobContext is abstract; cannot be instantiated
[ERROR]
[ERROR]
/home/jon/proj/hbase-0.94/src/test/java/org/apache/hadoop/hbase/mapreduce/TestHLogRecordReader.java:[226,29]
org.apache.hadoop.mapreduce.TaskAttemptContext is abstract; cannot be
instantiated
[ERROR] - [Help 1]
{code}
Upon further investigation this issue is due to code introduced in HBASE-5064
and is also present in trunk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5830) Cleanup SequenceFileLogWriter to use syncFs api from SequenceFile#Writer directly in trunk.
[ https://issues.apache.org/jira/browse/HBASE-5830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259784#comment-13259784 ] stack commented on HBASE-5830: -- This will work for hadoop 1.0.x and for hadoop 2.x Uma? Cleanup SequenceFileLogWriter to use syncFs api from SequenceFile#Writer directly in trunk. --- Key: HBASE-5830 URL: https://issues.apache.org/jira/browse/HBASE-5830 Project: HBase Issue Type: Bug Components: wal Affects Versions: 0.96.0 Reporter: Uma Maheswara Rao G Assignee: Uma Maheswara Rao G Attachments: HBASE-5830.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5104) Provide a reliable intra-row pagination mechanism
[ https://issues.apache.org/jira/browse/HBASE-5104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259787#comment-13259787 ] Phabricator commented on HBASE-5104: madhuvaidya has commented on the revision [jira] [HBASE-5104] Provide a reliable intra-row pagination mechanism. LGTM (at least all the non-protocol buffer related stuff). REVISION DETAIL https://reviews.facebook.net/D2799 Provide a reliable intra-row pagination mechanism - Key: HBASE-5104 URL: https://issues.apache.org/jira/browse/HBASE-5104 Project: HBase Issue Type: Bug Reporter: Kannan Muthukkaruppan Assignee: Madhuwanti Vaidya Attachments: D2799.1.patch, D2799.2.patch, D2799.3.patch, jira-HBASE-5104-Provide-a-reliable-intra-row-paginat-2012-04-16_12_39_42.patch, testFilterList.rb Addendum: Doing pagination (retrieving at most limit number of KVs at a particular offset) is currently supported via the ColumnPaginationFilter. However, it is not a very clean way of supporting pagination. Some of the problems with it are: * Normally, one would expect a query with (Filter(A) AND Filter(B)) to have same results as (query with Filter(A)) INTERSECT (query with Filter(B)). This is not the case for ColumnPaginationFilter as its internal state gets updated depending on whether or not Filter(A) returns TRUE/FALSE for a particular cell. * When this Filter is used in combination with other filters (e.g., doing AND with another filter using FilterList), the behavior of the query depends on the order of filters in the FilterList. This is not ideal. * ColumnPaginationFilter is a stateful filter which ends up counting multiple versions of the cell as separate values even if another filter upstream or the ScanQueryMatcher is going to reject the value for other reasons. Seems like we need a reliable way to do pagination. The particular use case that prompted this JIRA is pagination within the same rowKey. For example, for a given row key R, get columns with prefix P, starting at offset X (among columns which have prefix P) and limit Y. Some possible fixes might be: 1) enhance ColumnPrefixFilter to support another constructor which supports limit/offset. 2) Support pagination (limit/offset) at the Scan/Get API level (rather than as a filter) [Like SQL]. Original Post: Thanks Jiakai Liu for reporting this issue and doing the initial investigation. Email from Jiakai below: Assuming that we have an index column family with the following entries: tag0:001:thread1 ... tag1:001:thread1 tag1:002:thread2 ... tag1:010:thread10 ... tag2:001:thread1 tag2:005:thread5 ... To get threads with tag1 in range [5, 10), I tried the following code: ColumnPrefixFilter filter1 = new ColumnPrefixFilter(Bytes.toBytes(tag1)); ColumnPaginationFilter filter2 = new ColumnPaginationFilter(5 /* limit */, 5 /* offset */); FilterList filters = new FilterList(Operator.MUST_PASS_ALL); filters.addFilter(filter1); filters.addFilter(filter2); Get get = new Get(USER); get.addFamily(COLUMN_FAMILY); get.setMaxVersions(1); get.setFilter(filters); Somehow it didn't work as expected. It returned the entries as if the filter1 were not set. Turns out the ColumnPrefixFilter returns SEEK_NEXT_USING_HINT in some cases. The FilterList filter does not handle this return code properly (treat it as INCLUDE). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5621) Convert admin protocol of HRegionInterface to PB
[ https://issues.apache.org/jira/browse/HBASE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259788#comment-13259788 ] stack commented on HBASE-5621: -- TestHRegion has a problem the way its written. Will fix in 5833 commit that is coming up. Convert admin protocol of HRegionInterface to PB Key: HBASE-5621 URL: https://issues.apache.org/jira/browse/HBASE-5621 Project: HBase Issue Type: Sub-task Components: ipc, master, migration, regionserver Reporter: Jimmy Xiang Assignee: Jimmy Xiang Fix For: 0.96.0 Attachments: hbase-5621_v3.patch, hbase_5621_v4.patch, hbase_5621_v4.patch, hbase_5621_v5.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5621) Convert admin protocol of HRegionInterface to PB
[ https://issues.apache.org/jira/browse/HBASE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-5621: - Resolution: Fixed Status: Resolved (was: Patch Available) Applied to trunk. Thanks for the patch Jimmy. Convert admin protocol of HRegionInterface to PB Key: HBASE-5621 URL: https://issues.apache.org/jira/browse/HBASE-5621 Project: HBase Issue Type: Sub-task Components: ipc, master, migration, regionserver Reporter: Jimmy Xiang Assignee: Jimmy Xiang Fix For: 0.96.0 Attachments: hbase-5621_v3.patch, hbase_5621_v4.patch, hbase_5621_v4.patch, hbase_5621_v5.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5830) Cleanup SequenceFileLogWriter to use syncFs api from SequenceFile#Writer directly in trunk.
[
https://issues.apache.org/jira/browse/HBASE-5830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259800#comment-13259800
]
Uma Maheswara Rao G commented on HBASE-5830:
Yes, both has the public api:
Hadoop-2 or trunk code:
SequenceFile#Writer:
{code}
/** flush all currently written data to the file system */
public void syncFs() throws IOException {
if (out != null) {
out.hflush(); // flush contents to file system
}
}
{code}
Branch-1:
SequenceFile#Writer:
{code}
/** flush all currently written data to the file system */
public void syncFs() throws IOException {
if (out != null) {
out.sync(); // flush contents to file
system
}
}
{code}
Cleanup SequenceFileLogWriter to use syncFs api from SequenceFile#Writer
directly in trunk.
---
Key: HBASE-5830
URL: https://issues.apache.org/jira/browse/HBASE-5830
Project: HBase
Issue Type: Bug
Components: wal
Affects Versions: 0.96.0
Reporter: Uma Maheswara Rao G
Assignee: Uma Maheswara Rao G
Attachments: HBASE-5830.patch
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5830) Cleanup SequenceFileLogWriter to use syncFs api from SequenceFile#Writer directly in trunk.
[ https://issues.apache.org/jira/browse/HBASE-5830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259802#comment-13259802 ] stack commented on HBASE-5830: -- +1 on patch then. Cleanup SequenceFileLogWriter to use syncFs api from SequenceFile#Writer directly in trunk. --- Key: HBASE-5830 URL: https://issues.apache.org/jira/browse/HBASE-5830 Project: HBase Issue Type: Bug Components: wal Affects Versions: 0.96.0 Reporter: Uma Maheswara Rao G Assignee: Uma Maheswara Rao G Attachments: HBASE-5830.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5851) TestProcessBasedCluster sometimes fails
[
https://issues.apache.org/jira/browse/HBASE-5851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259805#comment-13259805
]
stack commented on HBASE-5851:
--
This is secure hbase only? We should change the subject. Thanks for digging
in Jimmy. Make it a blocker too?
TestProcessBasedCluster sometimes fails
---
Key: HBASE-5851
URL: https://issues.apache.org/jira/browse/HBASE-5851
Project: HBase
Issue Type: Test
Reporter: Zhihong Yu
Assignee: Jimmy Xiang
TestProcessBasedCluster failed in
https://builds.apache.org/job/HBase-TRUNK-security/178
Looks like cluster failed to start:
{code}
2012-04-21 14:22:32,666 INFO [Thread-1]
util.ProcessBasedLocalHBaseCluster(176): Waiting for HBase to startup.
Retries left: 2
java.io.IOException: Giving up trying to location region in meta: thread is
interrupted.
at
org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.locateRegionInMeta(HConnectionManager.java:1173)
at
org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.locateRegion(HConnectionManager.java:956)
at
org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.locateRegion(HConnectionManager.java:917)
at org.apache.hadoop.hbase.client.HTable.finishSetup(HTable.java:252)
at org.apache.hadoop.hbase.client.HTable.init(HTable.java:192)
at
org.apache.hadoop.hbase.util.ProcessBasedLocalHBaseCluster.startHBase(ProcessBasedLocalHBaseCluster.java:174)
at
org.apache.hadoop.hbase.util.TestProcessBasedCluster.testProcessBasedCluster(TestProcessBasedCluster.java:56)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
at
org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:62)
java.lang.InterruptedException: sleep interrupted at
java.lang.Thread.sleep(Native Method)
at org.apache.hadoop.hbase.util.Threads.sleep(Threads.java:134)
at
org.apache.hadoop.hbase.util.ProcessBasedLocalHBaseCluster.startHBase(ProcessBasedLocalHBaseCluster.java:178)
at
org.apache.hadoop.hbase.util.TestProcessBasedCluster.testProcessBasedCluster(TestProcessBasedCluster.java:56)
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5851) TestProcessBasedCluster sometimes fails
[
https://issues.apache.org/jira/browse/HBASE-5851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259810#comment-13259810
]
Zhihong Yu commented on HBASE-5851:
---
The test sometime failed in trunk build as well:
https://builds.apache.org/view/G-L/view/HBase/job/HBase-TRUNK/2793/
TestProcessBasedCluster sometimes fails
---
Key: HBASE-5851
URL: https://issues.apache.org/jira/browse/HBASE-5851
Project: HBase
Issue Type: Test
Reporter: Zhihong Yu
Assignee: Jimmy Xiang
TestProcessBasedCluster failed in
https://builds.apache.org/job/HBase-TRUNK-security/178
Looks like cluster failed to start:
{code}
2012-04-21 14:22:32,666 INFO [Thread-1]
util.ProcessBasedLocalHBaseCluster(176): Waiting for HBase to startup.
Retries left: 2
java.io.IOException: Giving up trying to location region in meta: thread is
interrupted.
at
org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.locateRegionInMeta(HConnectionManager.java:1173)
at
org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.locateRegion(HConnectionManager.java:956)
at
org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.locateRegion(HConnectionManager.java:917)
at org.apache.hadoop.hbase.client.HTable.finishSetup(HTable.java:252)
at org.apache.hadoop.hbase.client.HTable.init(HTable.java:192)
at
org.apache.hadoop.hbase.util.ProcessBasedLocalHBaseCluster.startHBase(ProcessBasedLocalHBaseCluster.java:174)
at
org.apache.hadoop.hbase.util.TestProcessBasedCluster.testProcessBasedCluster(TestProcessBasedCluster.java:56)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
at
org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:62)
java.lang.InterruptedException: sleep interrupted at
java.lang.Thread.sleep(Native Method)
at org.apache.hadoop.hbase.util.Threads.sleep(Threads.java:134)
at
org.apache.hadoop.hbase.util.ProcessBasedLocalHBaseCluster.startHBase(ProcessBasedLocalHBaseCluster.java:178)
at
org.apache.hadoop.hbase.util.TestProcessBasedCluster.testProcessBasedCluster(TestProcessBasedCluster.java:56)
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
