[jira] [Updated] (HBASE-12047) Avoid usage of KeyValueUtil#ensureKeyValue in simple cases
[ https://issues.apache.org/jira/browse/HBASE-12047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-12047: --- Attachment: HBASE-12047_V3.patch Small change from V2 and use estimatedLengthOf(Cell) for metric purpose. Let us see what QA reports. Many tests seems flaky! Avoid usage of KeyValueUtil#ensureKeyValue in simple cases -- Key: HBASE-12047 URL: https://issues.apache.org/jira/browse/HBASE-12047 Project: HBase Issue Type: Sub-task Components: regionserver Reporter: Anoop Sam John Assignee: Anoop Sam John Fix For: 2.0.0, 0.99.1 Attachments: HBASE-12047.patch, HBASE-12047_V2.patch, HBASE-12047_V3.patch The patch avoids the usage from some obvious simple cases. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-10536) ImportTsv should fail fast if any of the column family passed to the job is not present in the table
[
https://issues.apache.org/jira/browse/HBASE-10536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14144427#comment-14144427
]
Hadoop QA commented on HBASE-10536:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12670607/HBASE-10536.patch
against trunk revision .
ATTACHMENT ID: 12670607
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 8
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11026//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11026//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11026//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11026//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11026//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11026//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11026//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11026//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11026//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11026//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11026//console
This message is automatically generated.
ImportTsv should fail fast if any of the column family passed to the job is
not present in the table
Key: HBASE-10536
URL: https://issues.apache.org/jira/browse/HBASE-10536
Project: HBase
Issue Type: Bug
Components: mapreduce
Affects Versions: 0.98.0
Reporter: rajeshbabu
Fix For: 2.0.0
Attachments: HBASE-10536.patch, HBASE-10536.patch
While checking 0.98 rc, running bulkload tools. By mistake passed wrong
column family to importtsv. LoadIncrementalHfiles failed with following
exception
{code}
Exception in thread main java.io.IOException: Unmatched family names found:
unmatched family names in HFiles to be bulkloaded: [f1]; valid family names
of table test are: [f]
at
org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.doBulkLoad(LoadIncrementalHFiles.java:241)
at
org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.run(LoadIncrementalHFiles.java:823)
at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84)
at
org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.main(LoadIncrementalHFiles.java:828)
{code}
Its better to fail fast if any of the passed column family is not present in
table.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (HBASE-12063) wal.ProtobufLogWriter: Got IOException while writing trailer
wangshizhe created HBASE-12063: -- Summary: wal.ProtobufLogWriter: Got IOException while writing trailer Key: HBASE-12063 URL: https://issues.apache.org/jira/browse/HBASE-12063 Project: HBase Issue Type: Bug Components: regionserver Affects Versions: 0.98.0 Reporter: wangshizhe 2014-09-23 14:57:02,161 DEBUG [RS_OPEN_META-logs05:60020-0-WAL.AsyncWriter] wal.FSHLog: RS_OPEN_META-logs05:60020-0-WAL.AsyncWriter interrupted while waiting for newer writes added to local buffer 2014-09-23 14:57:02,161 INFO [RS_OPEN_META-logs05:60020-0-WAL.AsyncWriter] wal.FSHLog: RS_OPEN_META-logs05:60020-0-WAL.AsyncWriter exiting 2014-09-23 14:57:02,161 DEBUG [regionserver60020] wal.FSHLog: Closing WAL writer in hdfs://logs01.yz.bj.uar.nsn:8020/apps/hbase/data/WALs/logs05.yz.bj.uar.nsn,60020,1411454591351 2014-09-23 14:57:02,161 ERROR [regionserver60020] wal.ProtobufLogWriter: Got IOException while writing trailer java.io.IOException: All datanodes 10.136.172.105:50010 are bad. Aborting... at org.apache.hadoop.hdfs.DFSOutputStream$DataStreamer.setupPipelineForAppendOrRecovery(DFSOutputStream.java:1128) at org.apache.hadoop.hdfs.DFSOutputStream$DataStreamer.processDatanodeError(DFSOutputStream.java:924) at org.apache.hadoop.hdfs.DFSOutputStream$DataStreamer.run(DFSOutputStream.java:486) 2014-09-23 14:57:02,163 ERROR [regionserver60020] regionserver.HRegionServer: Metalog close and delete failed java.io.IOException: All datanodes 10.136.172.105:50010 are bad. Aborting... at org.apache.hadoop.hdfs.DFSOutputStream$DataStreamer.setupPipelineForAppendOrRecovery(DFSOutputStream.java:1128) at org.apache.hadoop.hdfs.DFSOutputStream$DataStreamer.processDatanodeError(DFSOutputStream.java:924) at org.apache.hadoop.hdfs.DFSOutputStream$DataStreamer.run(DFSOutputStream.java:486) 2014-09-23 14:57:02,163 DEBUG [regionserver60020-WAL.AsyncNotifier] wal.FSHLog: regionserver60020-WAL.AsyncNotifier interrupted while waiting for notification from AsyncSyncer thread 2014-09-23 14:57:02,163 INFO [regionserver60020-WAL.AsyncNotifier] wal.FSHLog: regionserver60020-WAL.AsyncNotifier exiting 2014-09-23 14:57:02,163 DEBUG [regionserver60020-WAL.AsyncSyncer0] wal.FSHLog: regionserver60020-WAL.AsyncSyncer0 interrupted while waiting for notification from AsyncWriter thread 2014-09-23 14:57:02,163 INFO [regionserver60020-WAL.AsyncSyncer0] wal.FSHLog: regionserver60020-WAL.AsyncSyncer0 exiting 2014-09-23 14:57:02,163 DEBUG [regionserver60020-WAL.AsyncSyncer1] wal.FSHLog: regionserver60020-WAL.AsyncSyncer1 interrupted while waiting for notification from AsyncWriter thread 2014-09-23 14:57:02,163 INFO [regionserver60020-WAL.AsyncSyncer1] wal.FSHLog: regionserver60020-WAL.AsyncSyncer1 exiting 2014-09-23 14:57:02,164 DEBUG [regionserver60020-WAL.AsyncSyncer2] wal.FSHLog: regionserver60020-WAL.AsyncSyncer2 interrupted while waiting for notification from AsyncWriter thread 2014-09-23 14:57:02,164 INFO [regionserver60020-WAL.AsyncSyncer2] wal.FSHLog: regionserver60020-WAL.AsyncSyncer2 exiting 2014-09-23 14:57:02,164 DEBUG [regionserver60020-WAL.AsyncSyncer3] wal.FSHLog: regionserver60020-WAL.AsyncSyncer3 interrupted while waiting for notification from AsyncWriter thread 2014-09-23 14:57:02,164 INFO [regionserver60020-WAL.AsyncSyncer3] wal.FSHLog: regionserver60020-WAL.AsyncSyncer3 exiting 2014-09-23 14:57:02,164 DEBUG [regionserver60020-WAL.AsyncSyncer4] wal.FSHLog: regionserver60020-WAL.AsyncSyncer4 interrupted while waiting for notification from AsyncWriter thread 2014-09-23 14:57:02,164 INFO [regionserver60020-WAL.AsyncSyncer4] wal.FSHLog: regionserver60020-WAL.AsyncSyncer4 exiting 2014-09-23 14:57:02,164 DEBUG [regionserver60020-WAL.AsyncWriter] wal.FSHLog: regionserver60020-WAL.AsyncWriter interrupted while waiting for newer writes added to local buffer 2014-09-23 14:57:02,164 INFO [regionserver60020-WAL.AsyncWriter] wal.FSHLog: regionserver60020-WAL.AsyncWriter exiting 2014-09-23 14:57:02,165 DEBUG [regionserver60020] wal.FSHLog: Closing WAL writer in hdfs://logs01.yz.bj.uar.nsn:8020/apps/hbase/data/WALs/logs05.yz.bj.uar.nsn,60020,1411454591351 2014-09-23 14:57:02,591 ERROR [regionserver60020] regionserver.HRegionServer: Close and delete failed org.apache.hadoop.hdfs.server.namenode.LeaseExpiredException: No lease on /apps/hbase/data/WALs/logs05.yz.bj.uar.nsn,60020,1411454591351/logs05.yz.bj.uar.nsn%2C60020%2C1411454591351.1411454597278: File does not exist. [Lease. Holder: DFSClient_hb_rs_logs05.yz.bj.uar.nsn,60020,1411454591351_1603749335_33, pendingcreates: 1] at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.checkLease(FSNamesystem.java:2946) at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.completeFileInternal(FSNamesystem.java:3010) at
[jira] [Commented] (HBASE-12047) Avoid usage of KeyValueUtil#ensureKeyValue in simple cases
[
https://issues.apache.org/jira/browse/HBASE-12047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14144519#comment-14144519
]
Hadoop QA commented on HBASE-12047:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12670624/HBASE-12047_V3.patch
against trunk revision .
ATTACHMENT ID: 12670624
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 8
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11027//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11027//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11027//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11027//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11027//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11027//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11027//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11027//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11027//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11027//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11027//console
This message is automatically generated.
Avoid usage of KeyValueUtil#ensureKeyValue in simple cases
--
Key: HBASE-12047
URL: https://issues.apache.org/jira/browse/HBASE-12047
Project: HBase
Issue Type: Sub-task
Components: regionserver
Reporter: Anoop Sam John
Assignee: Anoop Sam John
Fix For: 2.0.0, 0.99.1
Attachments: HBASE-12047.patch, HBASE-12047_V2.patch,
HBASE-12047_V3.patch
The patch avoids the usage from some obvious simple cases.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-12059) Create hbase-annotations module
[ https://issues.apache.org/jira/browse/HBASE-12059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-12059: -- Status: Patch Available (was: Open) Create hbase-annotations module --- Key: HBASE-12059 URL: https://issues.apache.org/jira/browse/HBASE-12059 Project: HBase Issue Type: Sub-task Reporter: Elliott Clark Assignee: Elliott Clark Attachments: 0001-HBASE-12059-Create-hbase-annotations-module.patch Different versions of hadoop have different annotations. We can smooth this out by providing our own. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-11990) Make setting the start and stop row for a specific prefix easier
[
https://issues.apache.org/jira/browse/HBASE-11990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Niels Basjes updated HBASE-11990:
-
Status: Open (was: Patch Available)
Make setting the start and stop row for a specific prefix easier
Key: HBASE-11990
URL: https://issues.apache.org/jira/browse/HBASE-11990
Project: HBase
Issue Type: New Feature
Components: Client
Reporter: Niels Basjes
Attachments: 11990v4.txt, HBASE-11990-20140916-v2.patch,
HBASE-11990-20140916-v3.patch, HBASE-11990-20140916-v5.patch,
HBASE-11990-20140916-v6.patch, HBASE-11990-20140916.patch,
HBASE-11990-20140917-v7.patch, HBASE-11990-20140919-v8.patch,
HBASE-11990-20140921-v9.patch
If you want to set a scan from your application to scan for a specific row
prefix this is actually quite hard.
As described in several places you can set the startRow to the prefix; yet
the stopRow should be set to the prefix '+1'
If the prefix 'ASCII' put into a byte[] then this is easy because you can
simply increment the last byte of the array.
But if your application uses real binary rowids you may run into the scenario
that your prefix is something like
{code}{ 0x12, 0x23, 0xFF, 0xFF }{code} Then the increment should be {code}{
0x12, 0x24 }{code}
I have prepared a proposed patch that makes setting these values correctly a
lot easier.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-11990) Make setting the start and stop row for a specific prefix easier
[
https://issues.apache.org/jira/browse/HBASE-11990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Niels Basjes updated HBASE-11990:
-
Status: Patch Available (was: Open)
Make setting the start and stop row for a specific prefix easier
Key: HBASE-11990
URL: https://issues.apache.org/jira/browse/HBASE-11990
Project: HBase
Issue Type: New Feature
Components: Client
Reporter: Niels Basjes
Attachments: 11990v4.txt, HBASE-11990-20140916-v2.patch,
HBASE-11990-20140916-v3.patch, HBASE-11990-20140916-v5.patch,
HBASE-11990-20140916-v6.patch, HBASE-11990-20140916.patch,
HBASE-11990-20140917-v7.patch, HBASE-11990-20140919-v8.patch,
HBASE-11990-20140921-v9.patch, HBASE-11990-20140923-v10.patch
If you want to set a scan from your application to scan for a specific row
prefix this is actually quite hard.
As described in several places you can set the startRow to the prefix; yet
the stopRow should be set to the prefix '+1'
If the prefix 'ASCII' put into a byte[] then this is easy because you can
simply increment the last byte of the array.
But if your application uses real binary rowids you may run into the scenario
that your prefix is something like
{code}{ 0x12, 0x23, 0xFF, 0xFF }{code} Then the increment should be {code}{
0x12, 0x24 }{code}
I have prepared a proposed patch that makes setting these values correctly a
lot easier.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-11990) Make setting the start and stop row for a specific prefix easier
[
https://issues.apache.org/jira/browse/HBASE-11990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Niels Basjes updated HBASE-11990:
-
Attachment: HBASE-11990-20140923-v10.patch
This patch reverts back to the method of calculating the correct the stopRow
and startRow to scan for the desired rows.
The method indicated by Lars is easier to understand, yet when doing a
multithreaded query of the data (i.e. MapReduce) will start many mappers that
are not needed at all and that could have been avoided beforehand.
I have revised and clarified both the documentation and method naming to better
clarify the distinction between the start/stop *Row* and the fact that we are
looking for rowKey *Prefixes*.
Just to be clear; Doing a prefix scan right is a hard problem. Just look at all
the good discussion that this ticket triggered about all the ways it can be
done and what the various pros and cons are. My intend with this patch has
always been to solve this problem in such a way that doing a prefix scan will
be a trivial task in the future.
Make setting the start and stop row for a specific prefix easier
Key: HBASE-11990
URL: https://issues.apache.org/jira/browse/HBASE-11990
Project: HBase
Issue Type: New Feature
Components: Client
Reporter: Niels Basjes
Attachments: 11990v4.txt, HBASE-11990-20140916-v2.patch,
HBASE-11990-20140916-v3.patch, HBASE-11990-20140916-v5.patch,
HBASE-11990-20140916-v6.patch, HBASE-11990-20140916.patch,
HBASE-11990-20140917-v7.patch, HBASE-11990-20140919-v8.patch,
HBASE-11990-20140921-v9.patch, HBASE-11990-20140923-v10.patch
If you want to set a scan from your application to scan for a specific row
prefix this is actually quite hard.
As described in several places you can set the startRow to the prefix; yet
the stopRow should be set to the prefix '+1'
If the prefix 'ASCII' put into a byte[] then this is easy because you can
simply increment the last byte of the array.
But if your application uses real binary rowids you may run into the scenario
that your prefix is something like
{code}{ 0x12, 0x23, 0xFF, 0xFF }{code} Then the increment should be {code}{
0x12, 0x24 }{code}
I have prepared a proposed patch that makes setting these values correctly a
lot easier.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12056) RPC logging too much in DEBUG mode
[
https://issues.apache.org/jira/browse/HBASE-12056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14144625#comment-14144625
]
Nicolas Liochon commented on HBASE-12056:
-
Yep, I'm ok with the split you've done between debug trace.
+1
RPC logging too much in DEBUG mode
--
Key: HBASE-12056
URL: https://issues.apache.org/jira/browse/HBASE-12056
Project: HBase
Issue Type: Bug
Reporter: Enis Soztutar
Assignee: Enis Soztutar
Attachments: hbase-12056_v1.patch
I think we are logging too much info in RPC layer with recent changes there
in DEBUG mode. All tests run with DEBUG log enabled.
{code}
2014-09-18 07:04:26,098 DEBUG [RpcServer.reader=3,port=60020] ipc.RpcServer:
Have read input token of size 820 for processing by saslServer.unwrap()
2014-09-18 07:04:26,100 DEBUG [RpcServer.reader=3,port=60020] ipc.RpcServer:
Have read input token of size 1597 for processing by saslServer.unwrap()
2014-09-18 07:04:26,101 DEBUG [RpcServer.reader=3,port=60020] ipc.RpcServer:
Have read input token of size 1681 for processing by saslServer.unwrap()
2014-09-18 07:04:26,101 DEBUG [RpcServer.reader=3,port=60020] ipc.RpcServer:
Have read input token of size 1414 for processing by saslServer.unwrap()
2014-09-18 07:04:26,101 DEBUG [RpcServer.reader=3,port=60020] ipc.RpcServer:
Have read input token of size 1108 for processing by saslServer.unwrap()
2014-09-18 07:04:26,101 DEBUG [RpcServer.reader=3,port=60020] ipc.RpcServer:
Have read input token of size 1158 for processing by saslServer.unwrap()
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (HBASE-12064) hbase.master.balancer.stochastic.numRegionLoadsToRemember is not used
Junegunn Choi created HBASE-12064: - Summary: hbase.master.balancer.stochastic.numRegionLoadsToRemember is not used Key: HBASE-12064 URL: https://issues.apache.org/jira/browse/HBASE-12064 Project: HBase Issue Type: Bug Components: Balancer Affects Versions: 0.98.6.1 Reporter: Junegunn Choi Priority: Minor StochasticLoadBalancer is supposed to use the value of hbase.master.balancer.stochastic.numRegionLoadsToRemember, but it is simply ignored and hardcoded number 15 is used instead. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12064) hbase.master.balancer.stochastic.numRegionLoadsToRemember is not used
[ https://issues.apache.org/jira/browse/HBASE-12064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junegunn Choi updated HBASE-12064: -- Attachment: HBASE-12064-Replace-hardcoded-value.patch hbase.master.balancer.stochastic.numRegionLoadsToRemember is not used - Key: HBASE-12064 URL: https://issues.apache.org/jira/browse/HBASE-12064 Project: HBase Issue Type: Bug Components: Balancer Affects Versions: 0.98.6.1 Reporter: Junegunn Choi Priority: Minor Attachments: HBASE-12064-Replace-hardcoded-value.patch StochasticLoadBalancer is supposed to use the value of hbase.master.balancer.stochastic.numRegionLoadsToRemember, but it is simply ignored and hardcoded number 15 is used instead. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (HBASE-12060) Replace enhanced for statement with basic for statement where possible
[
https://issues.apache.org/jira/browse/HBASE-12060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashish Singhi reassigned HBASE-12060:
-
Assignee: Ashish Singhi
Replace enhanced for statement with basic for statement where possible
--
Key: HBASE-12060
URL: https://issues.apache.org/jira/browse/HBASE-12060
Project: HBase
Issue Type: Sub-task
Reporter: Andrew Purtell
Assignee: Ashish Singhi
Labels: beginner, beginners
Wherever we use the enhanced for construction:
{noformat}
for ( FormalParameter : Expression ) Statement
{noformat}
where the Expression evaluates to an array or collection type that supports
random access, we can avoid creating iterator objects, unless we are also
using the iterator to remove items while iterating by using the basic for
statement instead:
{noformat}
for ( ForInit ; Expression ; ForUpdate ) Statement
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12059) Create hbase-annotations module
[
https://issues.apache.org/jira/browse/HBASE-12059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14144656#comment-14144656
]
Hadoop QA commented on HBASE-12059:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12670597/0001-HBASE-12059-Create-hbase-annotations-module.patch
against trunk revision .
ATTACHMENT ID: 12670597
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
14 warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestMultiParallel
org.apache.hadoop.hbase.util.TestProcessBasedCluster
org.apache.hadoop.hbase.mapreduce.TestImportExport
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11028//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11028//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11028//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11028//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11028//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11028//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11028//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11028//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11028//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11028//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11028//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11028//console
This message is automatically generated.
Create hbase-annotations module
---
Key: HBASE-12059
URL: https://issues.apache.org/jira/browse/HBASE-12059
Project: HBase
Issue Type: Sub-task
Reporter: Elliott Clark
Assignee: Elliott Clark
Attachments: 0001-HBASE-12059-Create-hbase-annotations-module.patch
Different versions of hadoop have different annotations. We can smooth this
out by providing our own.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-12047) Avoid usage of KeyValueUtil#ensureKeyValue in simple cases
[ https://issues.apache.org/jira/browse/HBASE-12047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-12047: --- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) bq.-1 javadoc. The javadoc tool appears to have generated 8 warning messages. Not related to this patch. Pushed to 0.99+ Thanks for the reviews. Avoid usage of KeyValueUtil#ensureKeyValue in simple cases -- Key: HBASE-12047 URL: https://issues.apache.org/jira/browse/HBASE-12047 Project: HBase Issue Type: Sub-task Components: regionserver Reporter: Anoop Sam John Assignee: Anoop Sam John Fix For: 2.0.0, 0.99.1 Attachments: HBASE-12047.patch, HBASE-12047_V2.patch, HBASE-12047_V3.patch The patch avoids the usage from some obvious simple cases. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12047) Avoid usage of KeyValueUtil#ensureKeyValue in simple cases
[ https://issues.apache.org/jira/browse/HBASE-12047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-12047: --- Attachment: HBASE-12047_0.99.patch Version which went into 0.99 Avoid usage of KeyValueUtil#ensureKeyValue in simple cases -- Key: HBASE-12047 URL: https://issues.apache.org/jira/browse/HBASE-12047 Project: HBase Issue Type: Sub-task Components: regionserver Reporter: Anoop Sam John Assignee: Anoop Sam John Fix For: 2.0.0, 0.99.1 Attachments: HBASE-12047.patch, HBASE-12047_0.99.patch, HBASE-12047_V2.patch, HBASE-12047_V3.patch The patch avoids the usage from some obvious simple cases. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12050) Avoid KeyValueUtil#ensureKeyValue from DefaultMemStore
[ https://issues.apache.org/jira/browse/HBASE-12050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14144675#comment-14144675 ] Anoop Sam John commented on HBASE-12050: Ping [~enis] for branch-1 Avoid KeyValueUtil#ensureKeyValue from DefaultMemStore -- Key: HBASE-12050 URL: https://issues.apache.org/jira/browse/HBASE-12050 Project: HBase Issue Type: Sub-task Components: regionserver Reporter: Anoop Sam John Assignee: Anoop Sam John Fix For: 2.0.0, 0.99.1 Attachments: HBASE-12050.patch, HBASE-12050_V2.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12050) Avoid KeyValueUtil#ensureKeyValue from DefaultMemStore
[ https://issues.apache.org/jira/browse/HBASE-12050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-12050: --- Status: Open (was: Patch Available) Avoid KeyValueUtil#ensureKeyValue from DefaultMemStore -- Key: HBASE-12050 URL: https://issues.apache.org/jira/browse/HBASE-12050 Project: HBase Issue Type: Sub-task Components: regionserver Reporter: Anoop Sam John Assignee: Anoop Sam John Fix For: 2.0.0, 0.99.1 Attachments: HBASE-12050.patch, HBASE-12050_V2.patch, HBASE-12050_V2.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12050) Avoid KeyValueUtil#ensureKeyValue from DefaultMemStore
[ https://issues.apache.org/jira/browse/HBASE-12050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-12050: --- Attachment: HBASE-12050_V2.patch Attaching same V2 patch for a new QA run Avoid KeyValueUtil#ensureKeyValue from DefaultMemStore -- Key: HBASE-12050 URL: https://issues.apache.org/jira/browse/HBASE-12050 Project: HBase Issue Type: Sub-task Components: regionserver Reporter: Anoop Sam John Assignee: Anoop Sam John Fix For: 2.0.0, 0.99.1 Attachments: HBASE-12050.patch, HBASE-12050_V2.patch, HBASE-12050_V2.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12050) Avoid KeyValueUtil#ensureKeyValue from DefaultMemStore
[ https://issues.apache.org/jira/browse/HBASE-12050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-12050: --- Status: Patch Available (was: Open) Avoid KeyValueUtil#ensureKeyValue from DefaultMemStore -- Key: HBASE-12050 URL: https://issues.apache.org/jira/browse/HBASE-12050 Project: HBase Issue Type: Sub-task Components: regionserver Reporter: Anoop Sam John Assignee: Anoop Sam John Fix For: 2.0.0, 0.99.1 Attachments: HBASE-12050.patch, HBASE-12050_V2.patch, HBASE-12050_V2.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-11990) Make setting the start and stop row for a specific prefix easier
[
https://issues.apache.org/jira/browse/HBASE-11990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14144702#comment-14144702
]
Hadoop QA commented on HBASE-11990:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12670676/HBASE-11990-20140923-v10.patch
against trunk revision .
ATTACHMENT ID: 12670676
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 7 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 8
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.master.TestSplitLogManager
org.apache.hadoop.hbase.client.TestMultiParallel
org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
at
org.apache.phoenix.end2end.QueryIT.testSumOverNullIntegerColumn(QueryIT.java:841)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11029//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11029//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11029//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11029//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11029//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11029//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11029//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11029//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11029//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11029//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11029//console
This message is automatically generated.
Make setting the start and stop row for a specific prefix easier
Key: HBASE-11990
URL: https://issues.apache.org/jira/browse/HBASE-11990
Project: HBase
Issue Type: New Feature
Components: Client
Reporter: Niels Basjes
Attachments: 11990v4.txt, HBASE-11990-20140916-v2.patch,
HBASE-11990-20140916-v3.patch, HBASE-11990-20140916-v5.patch,
HBASE-11990-20140916-v6.patch, HBASE-11990-20140916.patch,
HBASE-11990-20140917-v7.patch, HBASE-11990-20140919-v8.patch,
HBASE-11990-20140921-v9.patch, HBASE-11990-20140923-v10.patch
If you want to set a scan from your application to scan for a specific row
prefix this is actually quite hard.
As described in several places you can set the startRow to the prefix; yet
the stopRow should be set to the prefix '+1'
If the prefix 'ASCII' put into a byte[] then this is easy because you can
simply increment the last byte of the array.
But if your application uses real binary rowids you may run into the scenario
that your prefix is something like
{code}{ 0x12, 0x23, 0xFF, 0xFF }{code} Then the increment should be {code}{
0x12, 0x24 }{code}
I have prepared a proposed patch that makes setting these values correctly a
lot easier.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (HBASE-12065) Import tool is not restoring multiple DeleteFamily markers of a row
Maddineni Sukumar created HBASE-12065: - Summary: Import tool is not restoring multiple DeleteFamily markers of a row Key: HBASE-12065 URL: https://issues.apache.org/jira/browse/HBASE-12065 Project: HBase Issue Type: Bug Components: util Affects Versions: 0.98.2 Reporter: Maddineni Sukumar Assignee: Maddineni Sukumar Priority: Minor When a row has more than one DeleteFamily markers, Import tool is not restoring all DeleteFamily markers. Scenario: Insert entries into hbase in below order Put Row1 with Value-A Delete Row1 with DeleteFamily Marker Put Row1 with Value-B Delete Row1 with DeleteFamily Marker Using Export tool export this data and Import it into another table, you will see below entries Delete Row1 with DeleteFamily Marker Put Row1 with Value-B Put Row1 with Value-A One DeleteFamily marker is missing here... In Import tool, Importer.writeResult() method we are batching all deletes into a single Delete request and pushing into hbase. Here we are pushing only one delete family marker into hbase table. I tried same with normal HTable.delete command also. If you pass multiple DeleteFamily markers of a row in a single Delete request to hbase then table is maintaining only one. If that is the expected behavior of hbase then we should change logic in Import tool to push DeleteFamily markers individually one by one. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12065) Import tool is not restoring multiple DeleteFamily markers of a row
[ https://issues.apache.org/jira/browse/HBASE-12065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14144720#comment-14144720 ] Maddineni Sukumar commented on HBASE-12065: --- FYI - [~lhofhansl] [~apurtell] Import tool is not restoring multiple DeleteFamily markers of a row Key: HBASE-12065 URL: https://issues.apache.org/jira/browse/HBASE-12065 Project: HBase Issue Type: Bug Components: util Affects Versions: 0.98.2 Reporter: Maddineni Sukumar Assignee: Maddineni Sukumar Priority: Minor When a row has more than one DeleteFamily markers, Import tool is not restoring all DeleteFamily markers. Scenario: Insert entries into hbase in below order Put Row1 with Value-A Delete Row1 with DeleteFamily Marker Put Row1 with Value-B Delete Row1 with DeleteFamily Marker Using Export tool export this data and Import it into another table, you will see below entries Delete Row1 with DeleteFamily Marker Put Row1 with Value-B Put Row1 with Value-A One DeleteFamily marker is missing here... In Import tool, Importer.writeResult() method we are batching all deletes into a single Delete request and pushing into hbase. Here we are pushing only one delete family marker into hbase table. I tried same with normal HTable.delete command also. If you pass multiple DeleteFamily markers of a row in a single Delete request to hbase then table is maintaining only one. If that is the expected behavior of hbase then we should change logic in Import tool to push DeleteFamily markers individually one by one. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12047) Avoid usage of KeyValueUtil#ensureKeyValue in simple cases
[ https://issues.apache.org/jira/browse/HBASE-12047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14144723#comment-14144723 ] Hudson commented on HBASE-12047: FAILURE: Integrated in HBase-1.0 #218 (See [https://builds.apache.org/job/HBase-1.0/218/]) HBASE-12047 Avoid usage of KeyValueUtil#ensureKeyValue in simple cases. (anoopsamjohn: rev 11e612c28cdae86d018bb1c454c63ee7ffec3c0b) * hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FuzzyRowFilter.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFlusher.java * hbase-server/src/main/java/org/apache/hadoop/hbase/client/ClientSideRegionScanner.java * hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/Append.java * hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/ScannerCallable.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java * hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java * hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/BufferedDataBlockEncoder.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/CellModel.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftUtilities.java * hbase-server/src/main/java/org/apache/hadoop/hbase/rest/client/RemoteHTable.java Avoid usage of KeyValueUtil#ensureKeyValue in simple cases -- Key: HBASE-12047 URL: https://issues.apache.org/jira/browse/HBASE-12047 Project: HBase Issue Type: Sub-task Components: regionserver Reporter: Anoop Sam John Assignee: Anoop Sam John Fix For: 2.0.0, 0.99.1 Attachments: HBASE-12047.patch, HBASE-12047_0.99.patch, HBASE-12047_V2.patch, HBASE-12047_V3.patch The patch avoids the usage from some obvious simple cases. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12048) Remove deprecated APIs from Filter
[ https://issues.apache.org/jira/browse/HBASE-12048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-12048: --- Fix Version/s: (was: 0.99.1) Remove deprecated APIs from Filter -- Key: HBASE-12048 URL: https://issues.apache.org/jira/browse/HBASE-12048 Project: HBase Issue Type: Sub-task Components: regionserver Reporter: Anoop Sam John Assignee: Anoop Sam John Fix For: 2.0.0 Attachments: HBASE-12048.patch, HBASE-12048_V2.patch To be removed KeyValue transform(final KeyValue currentKV) KeyValue getNextKeyHint(final KeyValue currentKV) These are deprecated since 0.96 and can get removed from 1.0 time. Any objections? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12050) Avoid KeyValueUtil#ensureKeyValue from DefaultMemStore
[
https://issues.apache.org/jira/browse/HBASE-12050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14144745#comment-14144745
]
Hadoop QA commented on HBASE-12050:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12670692/HBASE-12050_V2.patch
against trunk revision .
ATTACHMENT ID: 12670692
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 25 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 8
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestMultiParallel
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11030//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11030//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11030//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11030//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11030//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11030//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11030//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11030//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11030//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11030//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11030//console
This message is automatically generated.
Avoid KeyValueUtil#ensureKeyValue from DefaultMemStore
--
Key: HBASE-12050
URL: https://issues.apache.org/jira/browse/HBASE-12050
Project: HBase
Issue Type: Sub-task
Components: regionserver
Reporter: Anoop Sam John
Assignee: Anoop Sam John
Fix For: 2.0.0, 0.99.1
Attachments: HBASE-12050.patch, HBASE-12050_V2.patch,
HBASE-12050_V2.patch
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (HBASE-12060) Replace enhanced for statement with basic for statement where possible
[
https://issues.apache.org/jira/browse/HBASE-12060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashish Singhi reassigned HBASE-12060:
-
Assignee: (was: Ashish Singhi)
Replace enhanced for statement with basic for statement where possible
--
Key: HBASE-12060
URL: https://issues.apache.org/jira/browse/HBASE-12060
Project: HBase
Issue Type: Sub-task
Reporter: Andrew Purtell
Labels: beginner, beginners
Wherever we use the enhanced for construction:
{noformat}
for ( FormalParameter : Expression ) Statement
{noformat}
where the Expression evaluates to an array or collection type that supports
random access, we can avoid creating iterator objects, unless we are also
using the iterator to remove items while iterating by using the basic for
statement instead:
{noformat}
for ( ForInit ; Expression ; ForUpdate ) Statement
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-11871) Avoid usage of KeyValueUtil#ensureKeyValue
[ https://issues.apache.org/jira/browse/HBASE-11871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-11871: --- Issue Type: Umbrella (was: Improvement) Avoid usage of KeyValueUtil#ensureKeyValue -- Key: HBASE-11871 URL: https://issues.apache.org/jira/browse/HBASE-11871 Project: HBase Issue Type: Umbrella Components: regionserver Reporter: Anoop Sam John Assignee: Anoop Sam John Now we try to use diff impls of Cells (other than KV) in server side for optimizations. (HBASE-11870 is one like this) Having code KeyValueUtil#ensureKeyValue can be dangerous as it recreate the Cell and do buffer copy. This is an umbrella issue. Will raise small sub tasks in specific areas and tackle this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12047) Avoid usage of KeyValueUtil#ensureKeyValue in simple cases
[ https://issues.apache.org/jira/browse/HBASE-12047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14144777#comment-14144777 ] Hudson commented on HBASE-12047: FAILURE: Integrated in HBase-TRUNK #5544 (See [https://builds.apache.org/job/HBase-TRUNK/5544/]) HBASE-12047 Avoid usage of KeyValueUtil#ensureKeyValue in simple cases. (anoopsamjohn: rev 791a03b40ff31f92ade454ffe00c57b39d3ccfde) * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftUtilities.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java * hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FuzzyRowFilter.java * hbase-server/src/main/java/org/apache/hadoop/hbase/rest/client/RemoteHTable.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/ScannerCallable.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java * hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/BufferedDataBlockEncoder.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/Append.java * hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/CellModel.java * hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java * hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFlusher.java * hbase-server/src/main/java/org/apache/hadoop/hbase/client/ClientSideRegionScanner.java Avoid usage of KeyValueUtil#ensureKeyValue in simple cases -- Key: HBASE-12047 URL: https://issues.apache.org/jira/browse/HBASE-12047 Project: HBase Issue Type: Sub-task Components: regionserver Reporter: Anoop Sam John Assignee: Anoop Sam John Fix For: 2.0.0, 0.99.1 Attachments: HBASE-12047.patch, HBASE-12047_0.99.patch, HBASE-12047_V2.patch, HBASE-12047_V3.patch The patch avoids the usage from some obvious simple cases. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (HBASE-10748) hbase-daemon.sh fails to execute with 'sh' command
[ https://issues.apache.org/jira/browse/HBASE-10748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Singhi reassigned HBASE-10748: - Assignee: Ashish Singhi hbase-daemon.sh fails to execute with 'sh' command -- Key: HBASE-10748 URL: https://issues.apache.org/jira/browse/HBASE-10748 Project: HBase Issue Type: Bug Components: scripts Affects Versions: 0.94.11 Reporter: Ashish Singhi Assignee: Ashish Singhi Attachments: HBASE-10748.patch, HBASE-10748.patch hostname:HBASE_HOME/bin # sh hbase-daemon.sh restart master *hbase-daemon.sh: line 188: hbase-daemon.sh: command not found* *hbase-daemon.sh: line 196: hbase-daemon.sh: command not found* -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12065) Import tool is not restoring multiple DeleteFamily markers of a row
[ https://issues.apache.org/jira/browse/HBASE-12065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14144827#comment-14144827 ] Anoop Sam John commented on HBASE-12065: bq.If you pass multiple DeleteFamily markers of a row in a single Delete request to hbase then table is maintaining only one. The markers are for different family or same (with different ts)? this is FamilyVersion delete? Can you attach a small test for this pls? Import tool is not restoring multiple DeleteFamily markers of a row Key: HBASE-12065 URL: https://issues.apache.org/jira/browse/HBASE-12065 Project: HBase Issue Type: Bug Components: util Affects Versions: 0.98.2 Reporter: Maddineni Sukumar Assignee: Maddineni Sukumar Priority: Minor When a row has more than one DeleteFamily markers, Import tool is not restoring all DeleteFamily markers. Scenario: Insert entries into hbase in below order Put Row1 with Value-A Delete Row1 with DeleteFamily Marker Put Row1 with Value-B Delete Row1 with DeleteFamily Marker Using Export tool export this data and Import it into another table, you will see below entries Delete Row1 with DeleteFamily Marker Put Row1 with Value-B Put Row1 with Value-A One DeleteFamily marker is missing here... In Import tool, Importer.writeResult() method we are batching all deletes into a single Delete request and pushing into hbase. Here we are pushing only one delete family marker into hbase table. I tried same with normal HTable.delete command also. If you pass multiple DeleteFamily markers of a row in a single Delete request to hbase then table is maintaining only one. If that is the expected behavior of hbase then we should change logic in Import tool to push DeleteFamily markers individually one by one. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12060) Replace enhanced for statement with basic for statement where possible
[
https://issues.apache.org/jira/browse/HBASE-12060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14144834#comment-14144834
]
Ashish Singhi commented on HBASE-12060:
---
There are around 4000 for loops in trunk source code.
I was thinking whether is it possible to divide this jira into sub task module
wise to avoid rebase of patch if someone commits something into the trunk code
and also reviewer will be able to review easily.
Also we can take up critical module first and then the rest.
Replace enhanced for statement with basic for statement where possible
--
Key: HBASE-12060
URL: https://issues.apache.org/jira/browse/HBASE-12060
Project: HBase
Issue Type: Sub-task
Reporter: Andrew Purtell
Labels: beginner, beginners
Wherever we use the enhanced for construction:
{noformat}
for ( FormalParameter : Expression ) Statement
{noformat}
where the Expression evaluates to an array or collection type that supports
random access, we can avoid creating iterator objects, unless we are also
using the iterator to remove items while iterating by using the basic for
statement instead:
{noformat}
for ( ForInit ; Expression ; ForUpdate ) Statement
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-12024) Fix javadoc warning
[
https://issues.apache.org/jira/browse/HBASE-12024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anoop Sam John updated HBASE-12024:
---
Attachment: HBASE-12024_latest.patch
Fix javadoc warning
---
Key: HBASE-12024
URL: https://issues.apache.org/jira/browse/HBASE-12024
Project: HBase
Issue Type: Bug
Components: documentation
Affects Versions: 2.0.0
Reporter: Matteo Bertozzi
Priority: Trivial
Fix For: 2.0.0
Attachments: HBASE-12024-v0.patch, HBASE-12024_latest.patch
There are a couple of javadoc warning
{noformat}
[WARNING]
/home/th30z/asf/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java:175:
warning - @return tag has no arguments.
[WARNING] Javadoc Warnings
[WARNING]
/home/th30z/asf/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionFactory.java:56:
warning - End Delimiter } missing for possible See Tag in comment string: A
non-instantiable class that manages creation of {@link Connection}s.
[WARNING] Managing the lifecycle of the {@link Connection}s to the cluster is
the responsibility of
[WARNING] the caller.
[WARNING] From this {@link Connection} {@link Table} implementations are
retrieved
[WARNING] with {@link Connection#getTable(TableName)}. Example:
[WARNING] pre
[WARNING] {@code
[WARNING] Connection connection = ConnectionFactory.createConnection(config);
[WARNING] Table table = connection.getTable(TableName.valueOf(table1));
[WARNING] try {
[WARNING] // Use the table as needed, for a single operation and a single
thread
[WARNING] } finally {
[WARNING] table.close();
[WARNING] connection.close();
[WARNING] }
[WARNING] /pre
[WARNING]
[WARNING] Similarly, {@link Connection} also returns {@link RegionLocator}
implementations.
[WARNING] This class replaces {@link HConnectionManager}, which is now
deprecated.
[WARNING]
/home/th30z/asf/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java:144:
warning - End Delimiter } missing for possible See Tag in comment string:
Create a new HConnection instance using the passed codeconf/code
instance.
[WARNING] pNote: This bypasses the usual HConnection life cycle management
done by
[WARNING] {@link #getConnection(Configuration)}. The caller is responsible for
[WARNING] calling {@link HConnection#close()} on the returned connection
instance.
[WARNING] This is the recommended way to create HConnections.
[WARNING] {@code
[WARNING] HConnection connection = HConnectionManager.createConnection(conf);
[WARNING] HTableInterface table = connection.getTable(mytable);
[WARNING] try {
[WARNING] table.get(...);
[WARNING] ...
[WARNING] } finally {
[WARNING] table.close();
[WARNING] connection.close();
[WARNING] }
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12024) Fix javadoc warning
[
https://issues.apache.org/jira/browse/HBASE-12024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14144855#comment-14144855
]
Anoop Sam John commented on HBASE-12024:
These are the latest javadocs from build
{noformat}
[WARNING]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java:175:
warning - @return tag has no arguments.
[WARNING] Javadoc Warnings
[WARNING]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionFactory.java:56:
warning - End Delimiter } missing for possible See Tag in comment string: A
non-instantiable class that manages creation of {@link Connection}s.
[WARNING] Managing the lifecycle of the {@link Connection}s to the cluster is
the responsibility of
[WARNING] the caller.
[WARNING] From this {@link Connection} {@link Table} implementations are
retrieved
[WARNING] with {@link Connection#getTable(TableName)}. Example:
[WARNING] pre
[WARNING] {@code
[WARNING] Connection connection = ConnectionFactory.createConnection(config);
[WARNING] Table table = connection.getTable(TableName.valueOf(table1));
[WARNING] try {
[WARNING] // Use the table as needed, for a single operation and a single thread
[WARNING] } finally {
[WARNING] table.close();
[WARNING] connection.close();
[WARNING] }
[WARNING] /pre
[WARNING]
[WARNING] Similarly, {@link Connection} also returns {@link RegionLocator}
implementations.
[WARNING] This class replaces {@link HConnectionManager}, which is now
deprecated.
[WARNING]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java:144:
warning - End Delimiter } missing for possible See Tag in comment string:
Create a new HConnection instance using the passed codeconf/code instance.
[WARNING] pNote: This bypasses the usual HConnection life cycle management
done by
[WARNING] {@link #getConnection(Configuration)}. The caller is responsible for
[WARNING] calling {@link HConnection#close()} on the returned connection
instance.
[WARNING] This is the recommended way to create HConnections.
[WARNING] {@code
[WARNING] HConnection connection = HConnectionManager.createConnection(conf);
[WARNING] HTableInterface table = connection.getTable(mytable);
[WARNING] try {
[WARNING] table.get(...);
[WARNING] ...
[WARNING] } finally {
[WARNING] table.close();
[WARNING] connection.close();
[WARNING] }
[WARNING]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/main/java/org/apache/hadoop/hbase/client/UnmodifyableHTableDescriptor.java:67:
warning - @return tag has no arguments.
[WARNING]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/main/java/org/apache/hadoop/hbase/client/UnmodifyableHTableDescriptor.java:86:
warning - @return tag has no arguments.
[WARNING]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/main/java/org/apache/hadoop/hbase/client/UnmodifyableHTableDescriptor.java:95:
warning - @return tag has no arguments.
[WARNING]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/main/java/org/apache/hadoop/hbase/client/UnmodifyableHTableDescriptor.java:104:
warning - @return tag has no arguments.
[WARNING]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/main/java/org/apache/hadoop/hbase/client/UnmodifyableHTableDescriptor.java:113:
warning - @return tag has no arguments.
[WARNING]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/main/java/org/apache/hadoop/hbase/client/UnmodifyableHTableDescriptor.java:122:
warning - @return tag has
{noformat}
Fix javadoc warning
---
Key: HBASE-12024
URL: https://issues.apache.org/jira/browse/HBASE-12024
Project: HBase
Issue Type: Bug
Components: documentation
Affects Versions: 2.0.0
Reporter: Matteo Bertozzi
Priority: Trivial
Fix For: 2.0.0
Attachments: HBASE-12024-v0.patch
There are a couple of javadoc warning
{noformat}
[WARNING]
/home/th30z/asf/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java:175:
warning - @return tag has no arguments.
[WARNING] Javadoc Warnings
[WARNING]
/home/th30z/asf/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionFactory.java:56:
warning - End Delimiter } missing for possible See Tag in comment string: A
non-instantiable class that manages creation of {@link Connection}s.
[WARNING] Managing the lifecycle of the {@link Connection}s to the cluster is
the responsibility of
[WARNING] the caller.
[WARNING] From this {@link Connection} {@link Table} implementations are
retrieved
[WARNING] with {@link
[jira] [Created] (HBASE-12066) Avoid major compaction in TestMobSweeper
Jonathan Hsieh created HBASE-12066: -- Summary: Avoid major compaction in TestMobSweeper Key: HBASE-12066 URL: https://issues.apache.org/jira/browse/HBASE-12066 Project: HBase Issue Type: Bug Reporter: Jonathan Hsieh TestMobSweeper is flaky on some machines. This is due to major compactions happening and blocking the unit test's sweep job from running. This patch bumps up the min hfiles before compaction to properly exercise the sweeper. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12066) Avoid major compaction in TestMobSweeper
[ https://issues.apache.org/jira/browse/HBASE-12066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Hsieh updated HBASE-12066: --- Issue Type: Sub-task (was: Bug) Parent: HBASE-11339 Avoid major compaction in TestMobSweeper Key: HBASE-12066 URL: https://issues.apache.org/jira/browse/HBASE-12066 Project: HBase Issue Type: Sub-task Reporter: Jonathan Hsieh TestMobSweeper is flaky on some machines. This is due to major compactions happening and blocking the unit test's sweep job from running. This patch bumps up the min hfiles before compaction to properly exercise the sweeper. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (HBASE-12066) Avoid major compaction in TestMobSweeper
[ https://issues.apache.org/jira/browse/HBASE-12066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Hsieh reassigned HBASE-12066: -- Assignee: Jonathan Hsieh Avoid major compaction in TestMobSweeper Key: HBASE-12066 URL: https://issues.apache.org/jira/browse/HBASE-12066 Project: HBase Issue Type: Sub-task Reporter: Jonathan Hsieh Assignee: Jonathan Hsieh TestMobSweeper is flaky on some machines. This is due to major compactions happening and blocking the unit test's sweep job from running. This patch bumps up the min hfiles before compaction to properly exercise the sweeper. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12066) Avoid major compaction in TestMobSweeper
[ https://issues.apache.org/jira/browse/HBASE-12066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Hsieh updated HBASE-12066: --- Attachment: hbase-12066.patch Avoid major compaction in TestMobSweeper Key: HBASE-12066 URL: https://issues.apache.org/jira/browse/HBASE-12066 Project: HBase Issue Type: Sub-task Reporter: Jonathan Hsieh Assignee: Jonathan Hsieh Attachments: hbase-12066.patch TestMobSweeper is flaky on some machines. This is due to major compactions happening and blocking the unit test's sweep job from running. This patch bumps up the min hfiles before compaction to properly exercise the sweeper. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12066) Avoid major compaction in TestMobSweeper
[ https://issues.apache.org/jira/browse/HBASE-12066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Hsieh updated HBASE-12066: --- Status: Patch Available (was: Open) Avoid major compaction in TestMobSweeper Key: HBASE-12066 URL: https://issues.apache.org/jira/browse/HBASE-12066 Project: HBase Issue Type: Sub-task Reporter: Jonathan Hsieh Assignee: Jonathan Hsieh Attachments: hbase-12066.patch TestMobSweeper is flaky on some machines. This is due to major compactions happening and blocking the unit test's sweep job from running. This patch bumps up the min hfiles before compaction to properly exercise the sweeper. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12066) Avoid major compaction in TestMobSweeper
[
https://issues.apache.org/jira/browse/HBASE-12066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14144926#comment-14144926
]
Hadoop QA commented on HBASE-12066:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12670719/hbase-12066.patch
against trunk revision .
ATTACHMENT ID: 12670719
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11032//console
This message is automatically generated.
Avoid major compaction in TestMobSweeper
Key: HBASE-12066
URL: https://issues.apache.org/jira/browse/HBASE-12066
Project: HBase
Issue Type: Sub-task
Reporter: Jonathan Hsieh
Assignee: Jonathan Hsieh
Attachments: hbase-12066.patch
TestMobSweeper is flaky on some machines. This is due to major compactions
happening and blocking the unit test's sweep job from running.
This patch bumps up the min hfiles before compaction to properly exercise the
sweeper.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-12054) bad state after NamespaceUpgrade with reserved table names
[ https://issues.apache.org/jira/browse/HBASE-12054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matteo Bertozzi updated HBASE-12054: Attachment: HBASE-12054-branch1.patch bad state after NamespaceUpgrade with reserved table names -- Key: HBASE-12054 URL: https://issues.apache.org/jira/browse/HBASE-12054 Project: HBase Issue Type: Bug Affects Versions: 0.96.2, 0.99.0, 0.98.6.1 Reporter: Matteo Bertozzi Assignee: Matteo Bertozzi Fix For: 1.0.0, 0.98.7 Attachments: HBASE-11006-v5.patch, HBASE-12054-branch1.patch If 94 has a table called data NamespaceUpgrade will fail to bring that table up and the generated layout will be dirty with stuff like /hbase/data/.data and so on. (the reserved names that we have no longer apply in 96+ since the data is separate from the root dir) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12054) bad state after NamespaceUpgrade with reserved table names
[ https://issues.apache.org/jira/browse/HBASE-12054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matteo Bertozzi updated HBASE-12054: Attachment: (was: HBASE-11006-v5.patch) bad state after NamespaceUpgrade with reserved table names -- Key: HBASE-12054 URL: https://issues.apache.org/jira/browse/HBASE-12054 Project: HBase Issue Type: Bug Affects Versions: 0.96.2, 0.99.0, 0.98.6.1 Reporter: Matteo Bertozzi Assignee: Matteo Bertozzi Fix For: 1.0.0, 0.98.7 Attachments: HBASE-12054-branch1.patch If 94 has a table called data NamespaceUpgrade will fail to bring that table up and the generated layout will be dirty with stuff like /hbase/data/.data and so on. (the reserved names that we have no longer apply in 96+ since the data is separate from the root dir) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12029) Use Table and RegionLocator in HTable.getRegionLocations()
[ https://issues.apache.org/jira/browse/HBASE-12029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Solomon Duskis updated HBASE-12029: --- Attachment: HBASE-12029.patch Adding getAllRegionLocations() to the RegionLocator interface. Replaced ClusterConnection with Connection in MetaScanner. Update RegionSizeCalculator to use a RegionLocator instead of HTable. Removed an unused parameter from MetaScanner.allTableRegions(). Use Table and RegionLocator in HTable.getRegionLocations() --- Key: HBASE-12029 URL: https://issues.apache.org/jira/browse/HBASE-12029 Project: HBase Issue Type: Bug Affects Versions: 0.99.0, 2.0.0 Reporter: Solomon Duskis Assignee: Solomon Duskis Attachments: HBASE-12029.patch HTable.getRegionLocations() is an internal deprecated API. There are plenty of internal uses of the method, and it would be ideal to use the Table and RegionLocator interfaces instead of the HTable method. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12029) Use Table and RegionLocator in HTable.getRegionLocations()
[ https://issues.apache.org/jira/browse/HBASE-12029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Solomon Duskis updated HBASE-12029: --- Affects Version/s: (was: 0.99.0) 0.99.1 Status: Patch Available (was: Open) Use Table and RegionLocator in HTable.getRegionLocations() --- Key: HBASE-12029 URL: https://issues.apache.org/jira/browse/HBASE-12029 Project: HBase Issue Type: Bug Affects Versions: 2.0.0, 0.99.1 Reporter: Solomon Duskis Assignee: Solomon Duskis Attachments: HBASE-12029.patch HTable.getRegionLocations() is an internal deprecated API. There are plenty of internal uses of the method, and it would be ideal to use the Table and RegionLocator interfaces instead of the HTable method. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12060) Replace enhanced for statement with basic for statement where possible
[
https://issues.apache.org/jira/browse/HBASE-12060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14144972#comment-14144972
]
Andrew Purtell commented on HBASE-12060:
bq. I was thinking whether is it possible to divide this jira into sub task
module wise
It's a shame that JIRA does not let one nest subtasks in subtasks. Sure, if
there is a contribution relevant to this issue we could file a subtask on the
parent and link it here. The parent subtask HBASE-12023 is already an example
of this.
Replace enhanced for statement with basic for statement where possible
--
Key: HBASE-12060
URL: https://issues.apache.org/jira/browse/HBASE-12060
Project: HBase
Issue Type: Sub-task
Reporter: Andrew Purtell
Labels: beginner, beginners
Wherever we use the enhanced for construction:
{noformat}
for ( FormalParameter : Expression ) Statement
{noformat}
where the Expression evaluates to an array or collection type that supports
random access, we can avoid creating iterator objects, unless we are also
using the iterator to remove items while iterating by using the basic for
statement instead:
{noformat}
for ( ForInit ; Expression ; ForUpdate ) Statement
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-12054) bad state after NamespaceUpgrade with reserved table names
[ https://issues.apache.org/jira/browse/HBASE-12054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matteo Bertozzi updated HBASE-12054: Attachment: HBASE-12054-trunk.patch bad state after NamespaceUpgrade with reserved table names -- Key: HBASE-12054 URL: https://issues.apache.org/jira/browse/HBASE-12054 Project: HBase Issue Type: Bug Affects Versions: 0.96.2, 0.99.0, 0.98.6.1 Reporter: Matteo Bertozzi Assignee: Matteo Bertozzi Fix For: 1.0.0, 0.98.7 Attachments: HBASE-12054-branch1.patch, HBASE-12054-trunk.patch If 94 has a table called data NamespaceUpgrade will fail to bring that table up and the generated layout will be dirty with stuff like /hbase/data/.data and so on. (the reserved names that we have no longer apply in 96+ since the data is separate from the root dir) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12054) bad state after NamespaceUpgrade with reserved table names
[ https://issues.apache.org/jira/browse/HBASE-12054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matteo Bertozzi updated HBASE-12054: Status: Patch Available (was: Open) bad state after NamespaceUpgrade with reserved table names -- Key: HBASE-12054 URL: https://issues.apache.org/jira/browse/HBASE-12054 Project: HBase Issue Type: Bug Affects Versions: 0.98.6.1, 0.99.0, 0.96.2 Reporter: Matteo Bertozzi Assignee: Matteo Bertozzi Fix For: 1.0.0, 0.98.7 Attachments: HBASE-12054-branch1.patch, HBASE-12054-trunk.patch If 94 has a table called data NamespaceUpgrade will fail to bring that table up and the generated layout will be dirty with stuff like /hbase/data/.data and so on. (the reserved names that we have no longer apply in 96+ since the data is separate from the root dir) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12062) Fix usage of Collections.toArray
[
https://issues.apache.org/jira/browse/HBASE-12062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14144978#comment-14144978
]
Andrew Purtell commented on HBASE-12062:
+1
Is this hunk better?
{code}
diff --git
a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java
b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java
index 56d8349..bae71fc 100644
---
a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java
+++
b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java
@@ -1221,7 +1221,7 @@ class FSHLog implements HLog, Syncable {
void offer(final long sequence, final SyncFuture [] syncFutures, final int
syncFutureCount) {
// Set sequence first because the add to the queue will wake the thread
if sleeping.
this.sequence = sequence;
- for (int i = 0; i syncFutureCount; i++)
this.syncFutures.add(syncFutures[i]);
+ this.syncFutures.addAll(Arrays.asList(syncFutures).subList(0,
syncFutureCount));
}
/**
{code}
Fix usage of Collections.toArray
Key: HBASE-12062
URL: https://issues.apache.org/jira/browse/HBASE-12062
Project: HBase
Issue Type: Sub-task
Reporter: Elliott Clark
Assignee: Elliott Clark
Attachments: 0001-HBASE-12062-Fix-usage-of-Collections.toArray.patch
Need to give the correctly sized array when possible.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (HBASE-12063) wal.ProtobufLogWriter: Got IOException while writing trailer
[ https://issues.apache.org/jira/browse/HBASE-12063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell resolved HBASE-12063. Resolution: Invalid Please contact u...@hbase.apache.org for troubleshooting help. wal.ProtobufLogWriter: Got IOException while writing trailer Key: HBASE-12063 URL: https://issues.apache.org/jira/browse/HBASE-12063 Project: HBase Issue Type: Bug Components: regionserver Affects Versions: 0.98.0 Reporter: wangshizhe 2014-09-23 14:57:02,161 DEBUG [RS_OPEN_META-logs05:60020-0-WAL.AsyncWriter] wal.FSHLog: RS_OPEN_META-logs05:60020-0-WAL.AsyncWriter interrupted while waiting for newer writes added to local buffer 2014-09-23 14:57:02,161 INFO [RS_OPEN_META-logs05:60020-0-WAL.AsyncWriter] wal.FSHLog: RS_OPEN_META-logs05:60020-0-WAL.AsyncWriter exiting 2014-09-23 14:57:02,161 DEBUG [regionserver60020] wal.FSHLog: Closing WAL writer in hdfs://logs01.yz.bj.uar.nsn:8020/apps/hbase/data/WALs/logs05.yz.bj.uar.nsn,60020,1411454591351 2014-09-23 14:57:02,161 ERROR [regionserver60020] wal.ProtobufLogWriter: Got IOException while writing trailer java.io.IOException: All datanodes 10.136.172.105:50010 are bad. Aborting... at org.apache.hadoop.hdfs.DFSOutputStream$DataStreamer.setupPipelineForAppendOrRecovery(DFSOutputStream.java:1128) at org.apache.hadoop.hdfs.DFSOutputStream$DataStreamer.processDatanodeError(DFSOutputStream.java:924) at org.apache.hadoop.hdfs.DFSOutputStream$DataStreamer.run(DFSOutputStream.java:486) 2014-09-23 14:57:02,163 ERROR [regionserver60020] regionserver.HRegionServer: Metalog close and delete failed java.io.IOException: All datanodes 10.136.172.105:50010 are bad. Aborting... at org.apache.hadoop.hdfs.DFSOutputStream$DataStreamer.setupPipelineForAppendOrRecovery(DFSOutputStream.java:1128) at org.apache.hadoop.hdfs.DFSOutputStream$DataStreamer.processDatanodeError(DFSOutputStream.java:924) at org.apache.hadoop.hdfs.DFSOutputStream$DataStreamer.run(DFSOutputStream.java:486) 2014-09-23 14:57:02,163 DEBUG [regionserver60020-WAL.AsyncNotifier] wal.FSHLog: regionserver60020-WAL.AsyncNotifier interrupted while waiting for notification from AsyncSyncer thread 2014-09-23 14:57:02,163 INFO [regionserver60020-WAL.AsyncNotifier] wal.FSHLog: regionserver60020-WAL.AsyncNotifier exiting 2014-09-23 14:57:02,163 DEBUG [regionserver60020-WAL.AsyncSyncer0] wal.FSHLog: regionserver60020-WAL.AsyncSyncer0 interrupted while waiting for notification from AsyncWriter thread 2014-09-23 14:57:02,163 INFO [regionserver60020-WAL.AsyncSyncer0] wal.FSHLog: regionserver60020-WAL.AsyncSyncer0 exiting 2014-09-23 14:57:02,163 DEBUG [regionserver60020-WAL.AsyncSyncer1] wal.FSHLog: regionserver60020-WAL.AsyncSyncer1 interrupted while waiting for notification from AsyncWriter thread 2014-09-23 14:57:02,163 INFO [regionserver60020-WAL.AsyncSyncer1] wal.FSHLog: regionserver60020-WAL.AsyncSyncer1 exiting 2014-09-23 14:57:02,164 DEBUG [regionserver60020-WAL.AsyncSyncer2] wal.FSHLog: regionserver60020-WAL.AsyncSyncer2 interrupted while waiting for notification from AsyncWriter thread 2014-09-23 14:57:02,164 INFO [regionserver60020-WAL.AsyncSyncer2] wal.FSHLog: regionserver60020-WAL.AsyncSyncer2 exiting 2014-09-23 14:57:02,164 DEBUG [regionserver60020-WAL.AsyncSyncer3] wal.FSHLog: regionserver60020-WAL.AsyncSyncer3 interrupted while waiting for notification from AsyncWriter thread 2014-09-23 14:57:02,164 INFO [regionserver60020-WAL.AsyncSyncer3] wal.FSHLog: regionserver60020-WAL.AsyncSyncer3 exiting 2014-09-23 14:57:02,164 DEBUG [regionserver60020-WAL.AsyncSyncer4] wal.FSHLog: regionserver60020-WAL.AsyncSyncer4 interrupted while waiting for notification from AsyncWriter thread 2014-09-23 14:57:02,164 INFO [regionserver60020-WAL.AsyncSyncer4] wal.FSHLog: regionserver60020-WAL.AsyncSyncer4 exiting 2014-09-23 14:57:02,164 DEBUG [regionserver60020-WAL.AsyncWriter] wal.FSHLog: regionserver60020-WAL.AsyncWriter interrupted while waiting for newer writes added to local buffer 2014-09-23 14:57:02,164 INFO [regionserver60020-WAL.AsyncWriter] wal.FSHLog: regionserver60020-WAL.AsyncWriter exiting 2014-09-23 14:57:02,165 DEBUG [regionserver60020] wal.FSHLog: Closing WAL writer in hdfs://logs01.yz.bj.uar.nsn:8020/apps/hbase/data/WALs/logs05.yz.bj.uar.nsn,60020,1411454591351 2014-09-23 14:57:02,591 ERROR [regionserver60020] regionserver.HRegionServer: Close and delete failed org.apache.hadoop.hdfs.server.namenode.LeaseExpiredException: No lease on /apps/hbase/data/WALs/logs05.yz.bj.uar.nsn,60020,1411454591351/logs05.yz.bj.uar.nsn%2C60020%2C1411454591351.1411454597278: File does not exist. [Lease. Holder:
[jira] [Commented] (HBASE-12029) Use Table and RegionLocator in HTable.getRegionLocations()
[
https://issues.apache.org/jira/browse/HBASE-12029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14144995#comment-14144995
]
Hadoop QA commented on HBASE-12029:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12670728/HBASE-12029.patch
against trunk revision .
ATTACHMENT ID: 12670728
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 12 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 8
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestClientNoCluster
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11033//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11033//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11033//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11033//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11033//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11033//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11033//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11033//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11033//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11033//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11033//console
This message is automatically generated.
Use Table and RegionLocator in HTable.getRegionLocations()
---
Key: HBASE-12029
URL: https://issues.apache.org/jira/browse/HBASE-12029
Project: HBase
Issue Type: Bug
Affects Versions: 2.0.0, 0.99.1
Reporter: Solomon Duskis
Assignee: Solomon Duskis
Attachments: HBASE-12029.patch
HTable.getRegionLocations() is an internal deprecated API. There are plenty
of internal uses of the method, and it would be ideal to use the Table and
RegionLocator interfaces instead of the HTable method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-12054) bad state after NamespaceUpgrade with reserved table names
[ https://issues.apache.org/jira/browse/HBASE-12054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-12054: --- Attachment: HBASE-12054-0.98.patch Ported branch-1 patch to 0.98 bad state after NamespaceUpgrade with reserved table names -- Key: HBASE-12054 URL: https://issues.apache.org/jira/browse/HBASE-12054 Project: HBase Issue Type: Bug Affects Versions: 0.96.2, 0.99.0, 0.98.6.1 Reporter: Matteo Bertozzi Assignee: Matteo Bertozzi Fix For: 1.0.0, 0.98.7 Attachments: HBASE-12054-0.98.patch, HBASE-12054-branch1.patch, HBASE-12054-trunk.patch If 94 has a table called data NamespaceUpgrade will fail to bring that table up and the generated layout will be dirty with stuff like /hbase/data/.data and so on. (the reserved names that we have no longer apply in 96+ since the data is separate from the root dir) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12066) Avoid major compaction in TestMobSweeper
[ https://issues.apache.org/jira/browse/HBASE-12066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-12066: --- Fix Version/s: hbase-11339 Avoid major compaction in TestMobSweeper Key: HBASE-12066 URL: https://issues.apache.org/jira/browse/HBASE-12066 Project: HBase Issue Type: Sub-task Reporter: Jonathan Hsieh Assignee: Jonathan Hsieh Fix For: hbase-11339 Attachments: hbase-12066.patch TestMobSweeper is flaky on some machines. This is due to major compactions happening and blocking the unit test's sweep job from running. This patch bumps up the min hfiles before compaction to properly exercise the sweeper. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12066) Avoid major compaction in TestMobSweeper
[ https://issues.apache.org/jira/browse/HBASE-12066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14145009#comment-14145009 ] Anoop Sam John commented on HBASE-12066: +1 if the setting avoids major compaction always. Thanks Jon Avoid major compaction in TestMobSweeper Key: HBASE-12066 URL: https://issues.apache.org/jira/browse/HBASE-12066 Project: HBase Issue Type: Sub-task Reporter: Jonathan Hsieh Assignee: Jonathan Hsieh Fix For: hbase-11339 Attachments: hbase-12066.patch TestMobSweeper is flaky on some machines. This is due to major compactions happening and blocking the unit test's sweep job from running. This patch bumps up the min hfiles before compaction to properly exercise the sweeper. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12030) Wrong compaction report and assert when MOB compaction switches to minor
[
https://issues.apache.org/jira/browse/HBASE-12030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14145013#comment-14145013
]
Matteo Bertozzi commented on HBASE-12030:
-
looks ok to me,
it will be nice having a test to cover the path when zk throws an exception..
maybe the easiest way there is mocking zk?
Wrong compaction report and assert when MOB compaction switches to minor
Key: HBASE-12030
URL: https://issues.apache.org/jira/browse/HBASE-12030
Project: HBase
Issue Type: Bug
Components: Compaction, regionserver
Affects Versions: hbase-11339
Reporter: Matteo Bertozzi
Priority: Critical
Fix For: hbase-11339
Attachments: HBASE-12030.patch
when zookeeper is down during a major compaction or a sweep tool run in
progress, we switch to a minor.
{code}
try {
zk = MobZookeeper.newInstance(this.conf, compactionName);
} catch (KeeperException e) {
LOG.error(Cannot connect to the zookeeper, ready to perform the minor
compaction instead, e);
// change the major compaction into a minor one
compaction.getRequest().setIsMajor(false);
return super.compact(compaction);
}
{code}
but the request start (HRegion.reportCompactionRequestStart) is major and
increments the major-compactions counter
while the request end (HRegion.reportCompactionRequestEnd) is minor and
decrements the minor-compactions counter
triggering the assert newValue = 0, since we are decrementing the wrong
counter
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12054) bad state after NamespaceUpgrade with reserved table names
[
https://issues.apache.org/jira/browse/HBASE-12054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14145015#comment-14145015
]
Hadoop QA commented on HBASE-12054:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12670739/HBASE-12054-0.98.patch
against trunk revision .
ATTACHMENT ID: 12670739
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 8 new
or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11035//console
This message is automatically generated.
bad state after NamespaceUpgrade with reserved table names
--
Key: HBASE-12054
URL: https://issues.apache.org/jira/browse/HBASE-12054
Project: HBase
Issue Type: Bug
Affects Versions: 0.96.2, 0.99.0, 0.98.6.1
Reporter: Matteo Bertozzi
Assignee: Matteo Bertozzi
Fix For: 1.0.0, 0.98.7
Attachments: HBASE-12054-0.98.patch, HBASE-12054-branch1.patch,
HBASE-12054-trunk.patch
If 94 has a table called data NamespaceUpgrade will fail to bring that
table up and the generated layout will be dirty with stuff like
/hbase/data/.data and so on.
(the reserved names that we have no longer apply in 96+ since the data is
separate from the root dir)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12062) Fix usage of Collections.toArray
[ https://issues.apache.org/jira/browse/HBASE-12062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14145014#comment-14145014 ] Elliott Clark commented on HBASE-12062: --- Yeah that surprised me too. Intellij suggests that it's better. Fix usage of Collections.toArray Key: HBASE-12062 URL: https://issues.apache.org/jira/browse/HBASE-12062 Project: HBase Issue Type: Sub-task Reporter: Elliott Clark Assignee: Elliott Clark Attachments: 0001-HBASE-12062-Fix-usage-of-Collections.toArray.patch Need to give the correctly sized array when possible. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12066) Avoid major compaction in TestMobSweeper
[ https://issues.apache.org/jira/browse/HBASE-12066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14145020#comment-14145020 ] Sean Busbey commented on HBASE-12066: - +1 lgtm Avoid major compaction in TestMobSweeper Key: HBASE-12066 URL: https://issues.apache.org/jira/browse/HBASE-12066 Project: HBase Issue Type: Sub-task Reporter: Jonathan Hsieh Assignee: Jonathan Hsieh Fix For: hbase-11339 Attachments: hbase-12066.patch TestMobSweeper is flaky on some machines. This is due to major compactions happening and blocking the unit test's sweep job from running. This patch bumps up the min hfiles before compaction to properly exercise the sweeper. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12062) Fix usage of Collections.toArray
[ https://issues.apache.org/jira/browse/HBASE-12062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14145021#comment-14145021 ] Andrew Purtell commented on HBASE-12062: bq. Yeah that surprised me too. Can we leave it out? All of the other changes look good. But my +1 above stands. Fix usage of Collections.toArray Key: HBASE-12062 URL: https://issues.apache.org/jira/browse/HBASE-12062 Project: HBase Issue Type: Sub-task Reporter: Elliott Clark Assignee: Elliott Clark Attachments: 0001-HBASE-12062-Fix-usage-of-Collections.toArray.patch Need to give the correctly sized array when possible. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12062) Fix usage of Collections.toArray
[ https://issues.apache.org/jira/browse/HBASE-12062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14145033#comment-14145033 ] Elliott Clark commented on HBASE-12062: --- Oops sorry committed when I saw your +1. Let me dig a little to see if we need to revert that chunk Fix usage of Collections.toArray Key: HBASE-12062 URL: https://issues.apache.org/jira/browse/HBASE-12062 Project: HBase Issue Type: Sub-task Reporter: Elliott Clark Assignee: Elliott Clark Attachments: 0001-HBASE-12062-Fix-usage-of-Collections.toArray.patch Need to give the correctly sized array when possible. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12062) Fix usage of Collections.toArray
[ https://issues.apache.org/jira/browse/HBASE-12062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-12062: -- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Fix usage of Collections.toArray Key: HBASE-12062 URL: https://issues.apache.org/jira/browse/HBASE-12062 Project: HBase Issue Type: Sub-task Reporter: Elliott Clark Assignee: Elliott Clark Attachments: 0001-HBASE-12062-Fix-usage-of-Collections.toArray.patch Need to give the correctly sized array when possible. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12024) Fix javadoc warning
[
https://issues.apache.org/jira/browse/HBASE-12024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14145042#comment-14145042
]
Hadoop QA commented on HBASE-12024:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12670715/HBASE-12024_latest.patch
against trunk revision .
ATTACHMENT ID: 12670715
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+0 tests included{color}. The patch appears to be a
documentation patch that doesn't require tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.master.TestSplitLogManager
org.apache.hadoop.hbase.client.TestMultiParallel
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
at
org.apache.hadoop.hbase.mapreduce.TestMultithreadedTableMapper.testMultithreadedTableMapper(TestMultithreadedTableMapper.java:128)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11031//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11031//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11031//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11031//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11031//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11031//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11031//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11031//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11031//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11031//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11031//console
This message is automatically generated.
Fix javadoc warning
---
Key: HBASE-12024
URL: https://issues.apache.org/jira/browse/HBASE-12024
Project: HBase
Issue Type: Bug
Components: documentation
Affects Versions: 2.0.0
Reporter: Matteo Bertozzi
Priority: Trivial
Fix For: 2.0.0
Attachments: HBASE-12024-v0.patch, HBASE-12024_latest.patch
There are a couple of javadoc warning
{noformat}
[WARNING]
/home/th30z/asf/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java:175:
warning - @return tag has no arguments.
[WARNING] Javadoc Warnings
[WARNING]
/home/th30z/asf/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionFactory.java:56:
warning - End Delimiter } missing for possible See Tag in comment string: A
non-instantiable class that manages creation of {@link Connection}s.
[WARNING] Managing the lifecycle of the {@link Connection}s to the cluster is
the responsibility of
[WARNING] the caller.
[WARNING] From this {@link Connection} {@link Table} implementations are
retrieved
[WARNING] with {@link Connection#getTable(TableName)}. Example:
[WARNING] pre
[WARNING] {@code
[WARNING] Connection connection = ConnectionFactory.createConnection(config);
[WARNING] Table table = connection.getTable(TableName.valueOf(table1));
[WARNING] try {
[WARNING] // Use the table as needed, for a single operation and a single
thread
[WARNING] } finally {
[WARNING] table.close();
[WARNING] connection.close();
[WARNING] }
[WARNING] /pre
[WARNING]
[jira] [Commented] (HBASE-12062) Fix usage of Collections.toArray
[ https://issues.apache.org/jira/browse/HBASE-12062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14145053#comment-14145053 ] Elliott Clark commented on HBASE-12062: --- Ok for us that chunk is neither better nor worse. Intellij suggests it to keep from resizing this.syncFutures. In our case syncFutures is a linkedlist so there's no resizing. However it ends up running though the exact same thing. Fix usage of Collections.toArray Key: HBASE-12062 URL: https://issues.apache.org/jira/browse/HBASE-12062 Project: HBase Issue Type: Sub-task Reporter: Elliott Clark Assignee: Elliott Clark Attachments: 0001-HBASE-12062-Fix-usage-of-Collections.toArray.patch Need to give the correctly sized array when possible. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12066) Avoid major compaction in TestMobSweeper
[ https://issues.apache.org/jira/browse/HBASE-12066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14145055#comment-14145055 ] Jonathan Hsieh commented on HBASE-12066: Well the test cast creates 10 files so setting the min before compaction to 15 prevents it from reaching the trigger condition. Avoid major compaction in TestMobSweeper Key: HBASE-12066 URL: https://issues.apache.org/jira/browse/HBASE-12066 Project: HBase Issue Type: Sub-task Reporter: Jonathan Hsieh Assignee: Jonathan Hsieh Fix For: hbase-11339 Attachments: hbase-12066.patch TestMobSweeper is flaky on some machines. This is due to major compactions happening and blocking the unit test's sweep job from running. This patch bumps up the min hfiles before compaction to properly exercise the sweeper. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12024) Fix javadoc warning
[
https://issues.apache.org/jira/browse/HBASE-12024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14145057#comment-14145057
]
stack commented on HBASE-12024:
---
I don't think you need a +1 fixing javadoc but here is my +1 anyway
[~anoop.hbase]
Fix javadoc warning
---
Key: HBASE-12024
URL: https://issues.apache.org/jira/browse/HBASE-12024
Project: HBase
Issue Type: Bug
Components: documentation
Affects Versions: 2.0.0
Reporter: Matteo Bertozzi
Priority: Trivial
Fix For: 2.0.0
Attachments: HBASE-12024-v0.patch, HBASE-12024_latest.patch
There are a couple of javadoc warning
{noformat}
[WARNING]
/home/th30z/asf/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java:175:
warning - @return tag has no arguments.
[WARNING] Javadoc Warnings
[WARNING]
/home/th30z/asf/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionFactory.java:56:
warning - End Delimiter } missing for possible See Tag in comment string: A
non-instantiable class that manages creation of {@link Connection}s.
[WARNING] Managing the lifecycle of the {@link Connection}s to the cluster is
the responsibility of
[WARNING] the caller.
[WARNING] From this {@link Connection} {@link Table} implementations are
retrieved
[WARNING] with {@link Connection#getTable(TableName)}. Example:
[WARNING] pre
[WARNING] {@code
[WARNING] Connection connection = ConnectionFactory.createConnection(config);
[WARNING] Table table = connection.getTable(TableName.valueOf(table1));
[WARNING] try {
[WARNING] // Use the table as needed, for a single operation and a single
thread
[WARNING] } finally {
[WARNING] table.close();
[WARNING] connection.close();
[WARNING] }
[WARNING] /pre
[WARNING]
[WARNING] Similarly, {@link Connection} also returns {@link RegionLocator}
implementations.
[WARNING] This class replaces {@link HConnectionManager}, which is now
deprecated.
[WARNING]
/home/th30z/asf/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java:144:
warning - End Delimiter } missing for possible See Tag in comment string:
Create a new HConnection instance using the passed codeconf/code
instance.
[WARNING] pNote: This bypasses the usual HConnection life cycle management
done by
[WARNING] {@link #getConnection(Configuration)}. The caller is responsible for
[WARNING] calling {@link HConnection#close()} on the returned connection
instance.
[WARNING] This is the recommended way to create HConnections.
[WARNING] {@code
[WARNING] HConnection connection = HConnectionManager.createConnection(conf);
[WARNING] HTableInterface table = connection.getTable(mytable);
[WARNING] try {
[WARNING] table.get(...);
[WARNING] ...
[WARNING] } finally {
[WARNING] table.close();
[WARNING] connection.close();
[WARNING] }
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-12066) Avoid major compaction in TestMobSweeper
[ https://issues.apache.org/jira/browse/HBASE-12066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Hsieh updated HBASE-12066: --- Component/s: Compaction mob Affects Version/s: hbase-11339 Avoid major compaction in TestMobSweeper Key: HBASE-12066 URL: https://issues.apache.org/jira/browse/HBASE-12066 Project: HBase Issue Type: Sub-task Components: Compaction, mob Affects Versions: hbase-11339 Reporter: Jonathan Hsieh Assignee: Jonathan Hsieh Fix For: hbase-11339 Attachments: hbase-12066.patch TestMobSweeper is flaky on some machines. This is due to major compactions happening and blocking the unit test's sweep job from running. This patch bumps up the min hfiles before compaction to properly exercise the sweeper. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12066) Avoid major compaction in TestMobSweeper
[ https://issues.apache.org/jira/browse/HBASE-12066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Hsieh updated HBASE-12066: --- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) thanks for the reviews anoop, sean. committed to hbase-11339 branch. Avoid major compaction in TestMobSweeper Key: HBASE-12066 URL: https://issues.apache.org/jira/browse/HBASE-12066 Project: HBase Issue Type: Sub-task Components: Compaction, mob Affects Versions: hbase-11339 Reporter: Jonathan Hsieh Assignee: Jonathan Hsieh Fix For: hbase-11339 Attachments: hbase-12066.patch TestMobSweeper is flaky on some machines. This is due to major compactions happening and blocking the unit test's sweep job from running. This patch bumps up the min hfiles before compaction to properly exercise the sweeper. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12048) Remove deprecated APIs from Filter
[ https://issues.apache.org/jira/browse/HBASE-12048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14145062#comment-14145062 ] stack commented on HBASE-12048: --- [~anoop.hbase] So, +1 on v2 for master. Needs fat release note and need to mark this as incompatible change. What about workaround you described in off-list email? A new issue? Remove deprecated APIs from Filter -- Key: HBASE-12048 URL: https://issues.apache.org/jira/browse/HBASE-12048 Project: HBase Issue Type: Sub-task Components: regionserver Reporter: Anoop Sam John Assignee: Anoop Sam John Fix For: 2.0.0 Attachments: HBASE-12048.patch, HBASE-12048_V2.patch To be removed KeyValue transform(final KeyValue currentKV) KeyValue getNextKeyHint(final KeyValue currentKV) These are deprecated since 0.96 and can get removed from 1.0 time. Any objections? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12054) bad state after NamespaceUpgrade with reserved table names
[ https://issues.apache.org/jira/browse/HBASE-12054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-12054: -- Fix Version/s: (was: 1.0.0) 0.99.1 bad state after NamespaceUpgrade with reserved table names -- Key: HBASE-12054 URL: https://issues.apache.org/jira/browse/HBASE-12054 Project: HBase Issue Type: Bug Affects Versions: 0.96.2, 0.99.0, 0.98.6.1 Reporter: Matteo Bertozzi Assignee: Matteo Bertozzi Fix For: 0.98.7, 0.99.1 Attachments: HBASE-12054-0.98.patch, HBASE-12054-branch1.patch, HBASE-12054-trunk.patch If 94 has a table called data NamespaceUpgrade will fail to bring that table up and the generated layout will be dirty with stuff like /hbase/data/.data and so on. (the reserved names that we have no longer apply in 96+ since the data is separate from the root dir) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12024) Fix javadoc warning
[
https://issues.apache.org/jira/browse/HBASE-12024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anoop Sam John updated HBASE-12024:
---
Fix Version/s: 0.99.1
Fix javadoc warning
---
Key: HBASE-12024
URL: https://issues.apache.org/jira/browse/HBASE-12024
Project: HBase
Issue Type: Bug
Components: documentation
Affects Versions: 2.0.0
Reporter: Matteo Bertozzi
Priority: Trivial
Fix For: 2.0.0, 0.99.1
Attachments: HBASE-12024-v0.patch, HBASE-12024_latest.patch
There are a couple of javadoc warning
{noformat}
[WARNING]
/home/th30z/asf/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java:175:
warning - @return tag has no arguments.
[WARNING] Javadoc Warnings
[WARNING]
/home/th30z/asf/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionFactory.java:56:
warning - End Delimiter } missing for possible See Tag in comment string: A
non-instantiable class that manages creation of {@link Connection}s.
[WARNING] Managing the lifecycle of the {@link Connection}s to the cluster is
the responsibility of
[WARNING] the caller.
[WARNING] From this {@link Connection} {@link Table} implementations are
retrieved
[WARNING] with {@link Connection#getTable(TableName)}. Example:
[WARNING] pre
[WARNING] {@code
[WARNING] Connection connection = ConnectionFactory.createConnection(config);
[WARNING] Table table = connection.getTable(TableName.valueOf(table1));
[WARNING] try {
[WARNING] // Use the table as needed, for a single operation and a single
thread
[WARNING] } finally {
[WARNING] table.close();
[WARNING] connection.close();
[WARNING] }
[WARNING] /pre
[WARNING]
[WARNING] Similarly, {@link Connection} also returns {@link RegionLocator}
implementations.
[WARNING] This class replaces {@link HConnectionManager}, which is now
deprecated.
[WARNING]
/home/th30z/asf/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java:144:
warning - End Delimiter } missing for possible See Tag in comment string:
Create a new HConnection instance using the passed codeconf/code
instance.
[WARNING] pNote: This bypasses the usual HConnection life cycle management
done by
[WARNING] {@link #getConnection(Configuration)}. The caller is responsible for
[WARNING] calling {@link HConnection#close()} on the returned connection
instance.
[WARNING] This is the recommended way to create HConnections.
[WARNING] {@code
[WARNING] HConnection connection = HConnectionManager.createConnection(conf);
[WARNING] HTableInterface table = connection.getTable(mytable);
[WARNING] try {
[WARNING] table.get(...);
[WARNING] ...
[WARNING] } finally {
[WARNING] table.close();
[WARNING] connection.close();
[WARNING] }
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-12031) Parallel Scanners inside Region
[ https://issues.apache.org/jira/browse/HBASE-12031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Rodionov updated HBASE-12031: -- Attachment: HBASE-12031.3.patch Corrected indentation patch. Parallel Scanners inside Region --- Key: HBASE-12031 URL: https://issues.apache.org/jira/browse/HBASE-12031 Project: HBase Issue Type: New Feature Components: Performance, Scanners Affects Versions: 0.98.6 Reporter: Vladimir Rodionov Assignee: Vladimir Rodionov Fix For: 1.0.0, 2.0.0, 0.98.7, 0.99.1 Attachments: HBASE-12031.2.patch, HBASE-12031.3.patch, HBASE-12031.patch, ParallelScannerDesign.pdf, hbase-12031-tests.tar.gz This JIRA to improve performance of multiple scanners running on a same region in parallel. The scenarios where we will get the performance benefits: * New TableInputFormat with input splits smaller than HBase Region. * Scanning during compaction (Compaction scanner and application scanner over the same Region). Some JIRAs related to this one: https://issues.apache.org/jira/browse/HBASE-7336 https://issues.apache.org/jira/browse/HBASE-5979 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12024) Fix javadoc warning
[
https://issues.apache.org/jira/browse/HBASE-12024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14145069#comment-14145069
]
Anoop Sam John commented on HBASE-12024:
Thanks Stack. Pushed to master (and branch-1 too)
Fix javadoc warning
---
Key: HBASE-12024
URL: https://issues.apache.org/jira/browse/HBASE-12024
Project: HBase
Issue Type: Bug
Components: documentation
Affects Versions: 2.0.0
Reporter: Matteo Bertozzi
Priority: Trivial
Fix For: 2.0.0, 0.99.1
Attachments: HBASE-12024-v0.patch, HBASE-12024_latest.patch
There are a couple of javadoc warning
{noformat}
[WARNING]
/home/th30z/asf/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java:175:
warning - @return tag has no arguments.
[WARNING] Javadoc Warnings
[WARNING]
/home/th30z/asf/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionFactory.java:56:
warning - End Delimiter } missing for possible See Tag in comment string: A
non-instantiable class that manages creation of {@link Connection}s.
[WARNING] Managing the lifecycle of the {@link Connection}s to the cluster is
the responsibility of
[WARNING] the caller.
[WARNING] From this {@link Connection} {@link Table} implementations are
retrieved
[WARNING] with {@link Connection#getTable(TableName)}. Example:
[WARNING] pre
[WARNING] {@code
[WARNING] Connection connection = ConnectionFactory.createConnection(config);
[WARNING] Table table = connection.getTable(TableName.valueOf(table1));
[WARNING] try {
[WARNING] // Use the table as needed, for a single operation and a single
thread
[WARNING] } finally {
[WARNING] table.close();
[WARNING] connection.close();
[WARNING] }
[WARNING] /pre
[WARNING]
[WARNING] Similarly, {@link Connection} also returns {@link RegionLocator}
implementations.
[WARNING] This class replaces {@link HConnectionManager}, which is now
deprecated.
[WARNING]
/home/th30z/asf/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java:144:
warning - End Delimiter } missing for possible See Tag in comment string:
Create a new HConnection instance using the passed codeconf/code
instance.
[WARNING] pNote: This bypasses the usual HConnection life cycle management
done by
[WARNING] {@link #getConnection(Configuration)}. The caller is responsible for
[WARNING] calling {@link HConnection#close()} on the returned connection
instance.
[WARNING] This is the recommended way to create HConnections.
[WARNING] {@code
[WARNING] HConnection connection = HConnectionManager.createConnection(conf);
[WARNING] HTableInterface table = connection.getTable(mytable);
[WARNING] try {
[WARNING] table.get(...);
[WARNING] ...
[WARNING] } finally {
[WARNING] table.close();
[WARNING] connection.close();
[WARNING] }
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-12024) Fix javadoc warning
[
https://issues.apache.org/jira/browse/HBASE-12024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anoop Sam John updated HBASE-12024:
---
Resolution: Fixed
Assignee: Anoop Sam John
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Fix javadoc warning
---
Key: HBASE-12024
URL: https://issues.apache.org/jira/browse/HBASE-12024
Project: HBase
Issue Type: Bug
Components: documentation
Affects Versions: 2.0.0
Reporter: Matteo Bertozzi
Assignee: Anoop Sam John
Priority: Trivial
Fix For: 2.0.0, 0.99.1
Attachments: HBASE-12024-v0.patch, HBASE-12024_latest.patch
There are a couple of javadoc warning
{noformat}
[WARNING]
/home/th30z/asf/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java:175:
warning - @return tag has no arguments.
[WARNING] Javadoc Warnings
[WARNING]
/home/th30z/asf/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionFactory.java:56:
warning - End Delimiter } missing for possible See Tag in comment string: A
non-instantiable class that manages creation of {@link Connection}s.
[WARNING] Managing the lifecycle of the {@link Connection}s to the cluster is
the responsibility of
[WARNING] the caller.
[WARNING] From this {@link Connection} {@link Table} implementations are
retrieved
[WARNING] with {@link Connection#getTable(TableName)}. Example:
[WARNING] pre
[WARNING] {@code
[WARNING] Connection connection = ConnectionFactory.createConnection(config);
[WARNING] Table table = connection.getTable(TableName.valueOf(table1));
[WARNING] try {
[WARNING] // Use the table as needed, for a single operation and a single
thread
[WARNING] } finally {
[WARNING] table.close();
[WARNING] connection.close();
[WARNING] }
[WARNING] /pre
[WARNING]
[WARNING] Similarly, {@link Connection} also returns {@link RegionLocator}
implementations.
[WARNING] This class replaces {@link HConnectionManager}, which is now
deprecated.
[WARNING]
/home/th30z/asf/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java:144:
warning - End Delimiter } missing for possible See Tag in comment string:
Create a new HConnection instance using the passed codeconf/code
instance.
[WARNING] pNote: This bypasses the usual HConnection life cycle management
done by
[WARNING] {@link #getConnection(Configuration)}. The caller is responsible for
[WARNING] calling {@link HConnection#close()} on the returned connection
instance.
[WARNING] This is the recommended way to create HConnections.
[WARNING] {@code
[WARNING] HConnection connection = HConnectionManager.createConnection(conf);
[WARNING] HTableInterface table = connection.getTable(mytable);
[WARNING] try {
[WARNING] table.get(...);
[WARNING] ...
[WARNING] } finally {
[WARNING] table.close();
[WARNING] connection.close();
[WARNING] }
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-12031) Parallel Scanners inside Region
[ https://issues.apache.org/jira/browse/HBASE-12031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Rodionov updated HBASE-12031: -- Status: Patch Available (was: Open) Let us try the patch. Parallel Scanners inside Region --- Key: HBASE-12031 URL: https://issues.apache.org/jira/browse/HBASE-12031 Project: HBase Issue Type: New Feature Components: Performance, Scanners Affects Versions: 0.98.6 Reporter: Vladimir Rodionov Assignee: Vladimir Rodionov Fix For: 1.0.0, 2.0.0, 0.98.7, 0.99.1 Attachments: HBASE-12031.2.patch, HBASE-12031.3.patch, HBASE-12031.patch, ParallelScannerDesign.pdf, hbase-12031-tests.tar.gz This JIRA to improve performance of multiple scanners running on a same region in parallel. The scenarios where we will get the performance benefits: * New TableInputFormat with input splits smaller than HBase Region. * Scanning during compaction (Compaction scanner and application scanner over the same Region). Some JIRAs related to this one: https://issues.apache.org/jira/browse/HBASE-7336 https://issues.apache.org/jira/browse/HBASE-5979 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12048) Remove deprecated APIs from Filter
[ https://issues.apache.org/jira/browse/HBASE-12048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14145081#comment-14145081 ] Anoop Sam John commented on HBASE-12048: Thanks Stack. Will commit in some time to master. Yes this issue I marked for 2.0 only now. bq.What about workaround you described in off-list email? A new issue? Yep a new issue would be better as the patch will be totally different from master patch. Will come soon. Remove deprecated APIs from Filter -- Key: HBASE-12048 URL: https://issues.apache.org/jira/browse/HBASE-12048 Project: HBase Issue Type: Sub-task Components: regionserver Reporter: Anoop Sam John Assignee: Anoop Sam John Fix For: 2.0.0 Attachments: HBASE-12048.patch, HBASE-12048_V2.patch To be removed KeyValue transform(final KeyValue currentKV) KeyValue getNextKeyHint(final KeyValue currentKV) These are deprecated since 0.96 and can get removed from 1.0 time. Any objections? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12048) Remove deprecated APIs from Filter
[ https://issues.apache.org/jira/browse/HBASE-12048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-12048: --- Release Note: The following APIs are removed from Filter KeyValue transform(KeyValue) KeyValue getNextKeyHint(KeyValue) and replaced with Cell transformCell(Cell) Cell getNextCellHint(Cell) respectively. If a custom Filter implementation have overridden any of these methods, we will no longer call them. User has to change the custom Filter to override cell based methods as shown above Hadoop Flags: Incompatible change,Reviewed Remove deprecated APIs from Filter -- Key: HBASE-12048 URL: https://issues.apache.org/jira/browse/HBASE-12048 Project: HBase Issue Type: Sub-task Components: regionserver Reporter: Anoop Sam John Assignee: Anoop Sam John Fix For: 2.0.0 Attachments: HBASE-12048.patch, HBASE-12048_V2.patch To be removed KeyValue transform(final KeyValue currentKV) KeyValue getNextKeyHint(final KeyValue currentKV) These are deprecated since 0.96 and can get removed from 1.0 time. Any objections? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12048) Remove deprecated APIs from Filter
[ https://issues.apache.org/jira/browse/HBASE-12048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-12048: --- Resolution: Fixed Status: Resolved (was: Patch Available) Remove deprecated APIs from Filter -- Key: HBASE-12048 URL: https://issues.apache.org/jira/browse/HBASE-12048 Project: HBase Issue Type: Sub-task Components: regionserver Reporter: Anoop Sam John Assignee: Anoop Sam John Fix For: 2.0.0 Attachments: HBASE-12048.patch, HBASE-12048_V2.patch To be removed KeyValue transform(final KeyValue currentKV) KeyValue getNextKeyHint(final KeyValue currentKV) These are deprecated since 0.96 and can get removed from 1.0 time. Any objections? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12061) Ensure LOG.isXXXEnabled() wrapper around LOG.XXX() calls
[ https://issues.apache.org/jira/browse/HBASE-12061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14145115#comment-14145115 ] Nick Dimiduk commented on HBASE-12061: -- Could this be broken out into a couple critical path commits, or by package? Rolling back such a big commit down the road (for whatever reason) sounds like a painfully manual process. Ensure LOG.isXXXEnabled() wrapper around LOG.XXX() calls Key: HBASE-12061 URL: https://issues.apache.org/jira/browse/HBASE-12061 Project: HBase Issue Type: Sub-task Components: Performance Reporter: Vladimir Rodionov Assignee: Vladimir Rodionov The common anti-pattern in Java is using LOG.xxx() calls w/o wrapping them into LOG.isXXXEnabled(). This results in unnecessary object serializations/ string concatenations/ garbage object production even if XXX log level is disabled. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HBASE-12067) Remove deprecated metrics classes.
Elliott Clark created HBASE-12067: - Summary: Remove deprecated metrics classes. Key: HBASE-12067 URL: https://issues.apache.org/jira/browse/HBASE-12067 Project: HBase Issue Type: Bug Components: metrics Reporter: Elliott Clark Assignee: Elliott Clark After the metrics2 move some replacement metrics classes were deprecated in 0.96. We should remove them now. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12054) bad state after NamespaceUpgrade with reserved table names
[ https://issues.apache.org/jira/browse/HBASE-12054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14145128#comment-14145128 ] Matteo Bertozzi commented on HBASE-12054: - [~jmhsieh] you are looking at the trunk patch, take a look at branch-1 there is a new data table added to the upgrade migration. In trunk the migration test is gone but the main code is still there (blame on jimmy HBASE-11611). I think the migration tool is supposed to be removed from trunk tool. In trunk the patch is just removing the list of reserved names. bad state after NamespaceUpgrade with reserved table names -- Key: HBASE-12054 URL: https://issues.apache.org/jira/browse/HBASE-12054 Project: HBase Issue Type: Bug Affects Versions: 0.96.2, 0.99.0, 0.98.6.1 Reporter: Matteo Bertozzi Assignee: Matteo Bertozzi Fix For: 0.98.7, 0.99.1 Attachments: HBASE-12054-0.98.patch, HBASE-12054-branch1.patch, HBASE-12054-trunk.patch If 94 has a table called data NamespaceUpgrade will fail to bring that table up and the generated layout will be dirty with stuff like /hbase/data/.data and so on. (the reserved names that we have no longer apply in 96+ since the data is separate from the root dir) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12054) bad state after NamespaceUpgrade with reserved table names
[ https://issues.apache.org/jira/browse/HBASE-12054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14145120#comment-14145120 ] Jonathan Hsieh commented on HBASE-12054: nit: I see a modified test but not a new test for the invalid case. is this is because we don't need the archive test since it is global as opposed to in a particular namespace? bad state after NamespaceUpgrade with reserved table names -- Key: HBASE-12054 URL: https://issues.apache.org/jira/browse/HBASE-12054 Project: HBase Issue Type: Bug Affects Versions: 0.96.2, 0.99.0, 0.98.6.1 Reporter: Matteo Bertozzi Assignee: Matteo Bertozzi Fix For: 0.98.7, 0.99.1 Attachments: HBASE-12054-0.98.patch, HBASE-12054-branch1.patch, HBASE-12054-trunk.patch If 94 has a table called data NamespaceUpgrade will fail to bring that table up and the generated layout will be dirty with stuff like /hbase/data/.data and so on. (the reserved names that we have no longer apply in 96+ since the data is separate from the root dir) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HBASE-12068) [Branch-1] Avoid need to always do KeyValueUtil#ensureKeyValue for Filter transformCell
Anoop Sam John created HBASE-12068:
--
Summary: [Branch-1] Avoid need to always do
KeyValueUtil#ensureKeyValue for Filter transformCell
Key: HBASE-12068
URL: https://issues.apache.org/jira/browse/HBASE-12068
Project: HBase
Issue Type: Sub-task
Components: Filters
Affects Versions: 0.99.0
Reporter: Anoop Sam John
Assignee: Anoop Sam John
Fix For: 0.99.1
During read with Filters added to Scan/Get, the core code calls
transformCell(Cell) on the Filter. Most of the filters do not implement
transform API so the method from FilterBase will get executed
{code}
@Override
public Cell transformCell(Cell v) throws IOException {
// Old filters based off of this class will override KeyValue
transform(KeyValue).
// Thus to maintain compatibility we need to call the old version.
return transform(KeyValueUtil.ensureKeyValue(v));
}
{code}
Here always it do KeyValueUtil.ensureKeyValue. When a non KV cell comes in, we
need recreate KV and do deep copy of key and value!
We have to stick with this model in branch-1 for BC.
So as a workaround to avoid possible KV convert, we can implement
transformCell(Cell) method in all of our individual Filter classes which just
return the incoming cell (So that method from FilterBase wont get executed)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-12062) Fix usage of Collections.toArray
[ https://issues.apache.org/jira/browse/HBASE-12062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-12062: --- Fix Version/s: 0.99.1 0.98.7 2.0.0 Ok. I see this in branch-1 and master. Setting fix versions. Will cherry pick to 0.98 and push shortly. Fix usage of Collections.toArray Key: HBASE-12062 URL: https://issues.apache.org/jira/browse/HBASE-12062 Project: HBase Issue Type: Sub-task Reporter: Elliott Clark Assignee: Elliott Clark Fix For: 2.0.0, 0.98.7, 0.99.1 Attachments: 0001-HBASE-12062-Fix-usage-of-Collections.toArray.patch Need to give the correctly sized array when possible. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12054) bad state after NamespaceUpgrade with reserved table names
[
https://issues.apache.org/jira/browse/HBASE-12054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14145142#comment-14145142
]
Hadoop QA commented on HBASE-12054:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12670733/HBASE-12054-trunk.patch
against trunk revision .
ATTACHMENT ID: 12670733
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 8
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestMultiParallel
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11034//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11034//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11034//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11034//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11034//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11034//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11034//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11034//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11034//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11034//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11034//console
This message is automatically generated.
bad state after NamespaceUpgrade with reserved table names
--
Key: HBASE-12054
URL: https://issues.apache.org/jira/browse/HBASE-12054
Project: HBase
Issue Type: Bug
Affects Versions: 0.96.2, 0.99.0, 0.98.6.1
Reporter: Matteo Bertozzi
Assignee: Matteo Bertozzi
Fix For: 0.98.7, 0.99.1
Attachments: HBASE-12054-0.98.patch, HBASE-12054-branch1.patch,
HBASE-12054-trunk.patch
If 94 has a table called data NamespaceUpgrade will fail to bring that
table up and the generated layout will be dirty with stuff like
/hbase/data/.data and so on.
(the reserved names that we have no longer apply in 96+ since the data is
separate from the root dir)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12062) Fix usage of Collections.toArray
[ https://issues.apache.org/jira/browse/HBASE-12062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14145146#comment-14145146 ] Elliott Clark commented on HBASE-12062: --- The cherry-pick to 0.98 wasn't as clean. I can post a new patch for that if you want. Fix usage of Collections.toArray Key: HBASE-12062 URL: https://issues.apache.org/jira/browse/HBASE-12062 Project: HBase Issue Type: Sub-task Reporter: Elliott Clark Assignee: Elliott Clark Fix For: 2.0.0, 0.98.7, 0.99.1 Attachments: 0001-HBASE-12062-Fix-usage-of-Collections.toArray.patch Need to give the correctly sized array when possible. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12068) [Branch-1] Avoid need to always do KeyValueUtil#ensureKeyValue for Filter transformCell
[
https://issues.apache.org/jira/browse/HBASE-12068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anoop Sam John updated HBASE-12068:
---
Attachment: HBASE-12068.patch
The patch also avoids KeyValueUtil#ensureKeyValue calls from
DependentColumnFilter, SingleColumnValueExcludeFilter and
SingleColumnValueFilter. All where simple cases for removal. (These calls not
present trunk code)
[Branch-1] Avoid need to always do KeyValueUtil#ensureKeyValue for Filter
transformCell
---
Key: HBASE-12068
URL: https://issues.apache.org/jira/browse/HBASE-12068
Project: HBase
Issue Type: Sub-task
Components: Filters
Affects Versions: 0.99.0
Reporter: Anoop Sam John
Assignee: Anoop Sam John
Fix For: 0.99.1
Attachments: HBASE-12068.patch
During read with Filters added to Scan/Get, the core code calls
transformCell(Cell) on the Filter. Most of the filters do not implement
transform API so the method from FilterBase will get executed
{code}
@Override
public Cell transformCell(Cell v) throws IOException {
// Old filters based off of this class will override KeyValue
transform(KeyValue).
// Thus to maintain compatibility we need to call the old version.
return transform(KeyValueUtil.ensureKeyValue(v));
}
{code}
Here always it do KeyValueUtil.ensureKeyValue. When a non KV cell comes in,
we need recreate KV and do deep copy of key and value!
We have to stick with this model in branch-1 for BC.
So as a workaround to avoid possible KV convert, we can implement
transformCell(Cell) method in all of our individual Filter classes which just
return the incoming cell (So that method from FilterBase wont get executed)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-12067) Remove deprecated metrics classes.
[ https://issues.apache.org/jira/browse/HBASE-12067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-12067: -- Attachment: 0001-HBASE-12067-Remove-deprecated-metrics-classes.patch Remove deprecated metrics classes. -- Key: HBASE-12067 URL: https://issues.apache.org/jira/browse/HBASE-12067 Project: HBase Issue Type: Bug Components: metrics Reporter: Elliott Clark Assignee: Elliott Clark Attachments: 0001-HBASE-12067-Remove-deprecated-metrics-classes.patch After the metrics2 move some replacement metrics classes were deprecated in 0.96. We should remove them now. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12067) Remove deprecated metrics classes.
[ https://issues.apache.org/jira/browse/HBASE-12067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-12067: -- Status: Patch Available (was: Open) Remove deprecated metrics classes. -- Key: HBASE-12067 URL: https://issues.apache.org/jira/browse/HBASE-12067 Project: HBase Issue Type: Bug Components: metrics Reporter: Elliott Clark Assignee: Elliott Clark Attachments: 0001-HBASE-12067-Remove-deprecated-metrics-classes.patch After the metrics2 move some replacement metrics classes were deprecated in 0.96. We should remove them now. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12062) Fix usage of Collections.toArray
[ https://issues.apache.org/jira/browse/HBASE-12062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14145167#comment-14145167 ] Hudson commented on HBASE-12062: SUCCESS: Integrated in HBase-TRUNK #5545 (See [https://builds.apache.org/job/HBase-TRUNK/5545/]) HBASE-12062 Fix usage of Collections.toArray (eclark: rev 26357910277b906c1763c4ffdf1269dd79c79dbd) * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeStoreFileManager.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestSnapshotMetadata.java * hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestUser.java * hbase-common/src/test/java/org/apache/hadoop/hbase/TestKeyValue.java * hbase-server/src/main/java/org/apache/hadoop/hbase/replication/ChainWALEntryFilter.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java * hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java * hbase-server/src/main/java/org/apache/hadoop/hbase/util/MunkresAssignment.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java * hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java * hbase-server/src/main/java/org/apache/hadoop/hbase/rest/RowSpec.java * hbase-server/src/main/java/org/apache/hadoop/hbase/util/CollectionBackedScanner.java * hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java * hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerCmdLine.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RollingBatchRestartRsAction.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/compactions/TestStripeCompactionPolicy.java * hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestConcatenatedLists.java * hbase-server/src/main/java/org/apache/hadoop/hbase/metrics/MetricsMBeanBase.java * hbase-client/src/main/java/org/apache/hadoop/hbase/security/visibility/Authorizations.java * hbase-client/src/main/java/org/apache/hadoop/hbase/ServerLoad.java * hbase-examples/src/main/java/org/apache/hadoop/hbase/mapreduce/IndexBuilder.java * hbase-server/src/main/java/org/apache/hadoop/hbase/io/FileLink.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java * hbase-server/src/main/java/org/apache/hadoop/hbase/util/RegionSplitter.java * hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestInvocationRecordFilter.java * hbase-server/src/test/java/org/apache/hadoop/hbase/util/LoadTestTool.java * hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/expression/NonLeafExpressionNode.java * hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java Fix usage of Collections.toArray Key: HBASE-12062 URL: https://issues.apache.org/jira/browse/HBASE-12062 Project: HBase Issue Type: Sub-task Reporter: Elliott Clark Assignee: Elliott Clark Fix For: 2.0.0, 0.98.7, 0.99.1 Attachments: 0001-HBASE-12062-Fix-usage-of-Collections.toArray.patch Need to give the correctly sized array when possible. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12062) Fix usage of Collections.toArray
[ https://issues.apache.org/jira/browse/HBASE-12062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-12062: -- Attachment: 0001-HBASE-12062-Fix-usage-of-Collections.toArray.patch Here's what I'm going to commit to 0.98. It's smaller as lots of chunks weren't applicable. Fix usage of Collections.toArray Key: HBASE-12062 URL: https://issues.apache.org/jira/browse/HBASE-12062 Project: HBase Issue Type: Sub-task Reporter: Elliott Clark Assignee: Elliott Clark Fix For: 2.0.0, 0.98.7, 0.99.1 Attachments: 0001-HBASE-12062-Fix-usage-of-Collections.toArray.patch, 0001-HBASE-12062-Fix-usage-of-Collections.toArray.patch Need to give the correctly sized array when possible. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12062) Fix usage of Collections.toArray
[ https://issues.apache.org/jira/browse/HBASE-12062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14145178#comment-14145178 ] Andrew Purtell commented on HBASE-12062: Thanks, you beat me to the push. We had the same patch staged. Fix usage of Collections.toArray Key: HBASE-12062 URL: https://issues.apache.org/jira/browse/HBASE-12062 Project: HBase Issue Type: Sub-task Reporter: Elliott Clark Assignee: Elliott Clark Fix For: 2.0.0, 0.98.7, 0.99.1 Attachments: 0001-HBASE-12062-Fix-usage-of-Collections.toArray.patch, 0001-HBASE-12062-Fix-usage-of-Collections.toArray.patch Need to give the correctly sized array when possible. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12061) Ensure LOG.isXXXEnabled() wrapper around LOG.XXX() calls
[ https://issues.apache.org/jira/browse/HBASE-12061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14145180#comment-14145180 ] Andrew Purtell commented on HBASE-12061: bq. Could this be broken out into a couple critical path commits, or by package? It's a shame that JIRA does not let one nest subtasks in subtasks but we could file a subtask on the parent and link it here. The parent subtask HBASE-12023 is already an example of that with respect to HBASE-12060. Ensure LOG.isXXXEnabled() wrapper around LOG.XXX() calls Key: HBASE-12061 URL: https://issues.apache.org/jira/browse/HBASE-12061 Project: HBase Issue Type: Sub-task Components: Performance Reporter: Vladimir Rodionov Assignee: Vladimir Rodionov The common anti-pattern in Java is using LOG.xxx() calls w/o wrapping them into LOG.isXXXEnabled(). This results in unnecessary object serializations/ string concatenations/ garbage object production even if XXX log level is disabled. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12062) Fix usage of Collections.toArray
[ https://issues.apache.org/jira/browse/HBASE-12062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14145182#comment-14145182 ] Elliott Clark commented on HBASE-12062: --- Sorry I hit the resolve button too soon. My mistake I'm still a little rusty on expecting all patches to apply cleanly everywhere. Thanks for the review. Fix usage of Collections.toArray Key: HBASE-12062 URL: https://issues.apache.org/jira/browse/HBASE-12062 Project: HBase Issue Type: Sub-task Reporter: Elliott Clark Assignee: Elliott Clark Fix For: 2.0.0, 0.98.7, 0.99.1 Attachments: 0001-HBASE-12062-Fix-usage-of-Collections.toArray.patch, 0001-HBASE-12062-Fix-usage-of-Collections.toArray.patch Need to give the correctly sized array when possible. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12067) Remove deprecated metrics classes.
[ https://issues.apache.org/jira/browse/HBASE-12067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14145186#comment-14145186 ] stack commented on HBASE-12067: --- Looks like unused, internal classes. +1 Remove deprecated metrics classes. -- Key: HBASE-12067 URL: https://issues.apache.org/jira/browse/HBASE-12067 Project: HBase Issue Type: Bug Components: metrics Reporter: Elliott Clark Assignee: Elliott Clark Attachments: 0001-HBASE-12067-Remove-deprecated-metrics-classes.patch After the metrics2 move some replacement metrics classes were deprecated in 0.96. We should remove them now. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12067) Remove deprecated metrics classes.
[ https://issues.apache.org/jira/browse/HBASE-12067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14145187#comment-14145187 ] Jonathan Hsieh commented on HBASE-12067: is this just dead code removal or is there actually particular metrics being removed here? Remove deprecated metrics classes. -- Key: HBASE-12067 URL: https://issues.apache.org/jira/browse/HBASE-12067 Project: HBase Issue Type: Bug Components: metrics Reporter: Elliott Clark Assignee: Elliott Clark Attachments: 0001-HBASE-12067-Remove-deprecated-metrics-classes.patch After the metrics2 move some replacement metrics classes were deprecated in 0.96. We should remove them now. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12067) Remove deprecated metrics classes.
[ https://issues.apache.org/jira/browse/HBASE-12067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14145199#comment-14145199 ] Elliott Clark commented on HBASE-12067: --- Just dead code removal. We stopped using them in 0.96 but they were public classes (before the annotations) so we kept them just in case external users were still depending on them. Time to remove them now. However I don't think we should port this to 98 just to make sure that we don't break people in a dot release. Remove deprecated metrics classes. -- Key: HBASE-12067 URL: https://issues.apache.org/jira/browse/HBASE-12067 Project: HBase Issue Type: Bug Components: metrics Reporter: Elliott Clark Assignee: Elliott Clark Attachments: 0001-HBASE-12067-Remove-deprecated-metrics-classes.patch After the metrics2 move some replacement metrics classes were deprecated in 0.96. We should remove them now. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12061) Ensure LOG.isXXXEnabled() wrapper around LOG.XXX() calls
[ https://issues.apache.org/jira/browse/HBASE-12061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14145203#comment-14145203 ] Enis Soztutar commented on HBASE-12061: --- I think the practice we try to follow so far was use wrappers for DEBUG, and TRACE calls, but not for INFO or any level higher. The assumption is that mostly INFO level or WARN level is on anyways. Do we want to do the wrapper for every level? Ensure LOG.isXXXEnabled() wrapper around LOG.XXX() calls Key: HBASE-12061 URL: https://issues.apache.org/jira/browse/HBASE-12061 Project: HBase Issue Type: Sub-task Components: Performance Reporter: Vladimir Rodionov Assignee: Vladimir Rodionov The common anti-pattern in Java is using LOG.xxx() calls w/o wrapping them into LOG.isXXXEnabled(). This results in unnecessary object serializations/ string concatenations/ garbage object production even if XXX log level is disabled. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12067) Remove deprecated metrics classes.
[ https://issues.apache.org/jira/browse/HBASE-12067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14145205#comment-14145205 ] Enis Soztutar commented on HBASE-12067: --- Looks fine for branch-1. These should be internal classes. Remove deprecated metrics classes. -- Key: HBASE-12067 URL: https://issues.apache.org/jira/browse/HBASE-12067 Project: HBase Issue Type: Bug Components: metrics Reporter: Elliott Clark Assignee: Elliott Clark Attachments: 0001-HBASE-12067-Remove-deprecated-metrics-classes.patch After the metrics2 move some replacement metrics classes were deprecated in 0.96. We should remove them now. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12067) Remove deprecated metrics classes.
[ https://issues.apache.org/jira/browse/HBASE-12067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enis Soztutar updated HBASE-12067: -- Fix Version/s: 0.99.1 2.0.0 Remove deprecated metrics classes. -- Key: HBASE-12067 URL: https://issues.apache.org/jira/browse/HBASE-12067 Project: HBase Issue Type: Bug Components: metrics Reporter: Elliott Clark Assignee: Elliott Clark Fix For: 2.0.0, 0.99.1 Attachments: 0001-HBASE-12067-Remove-deprecated-metrics-classes.patch After the metrics2 move some replacement metrics classes were deprecated in 0.96. We should remove them now. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12061) Ensure LOG.isXXXEnabled() wrapper around LOG.XXX() calls
[ https://issues.apache.org/jira/browse/HBASE-12061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14145207#comment-14145207 ] Andrew Purtell commented on HBASE-12061: Maybe INFO and below ? Ensure LOG.isXXXEnabled() wrapper around LOG.XXX() calls Key: HBASE-12061 URL: https://issues.apache.org/jira/browse/HBASE-12061 Project: HBase Issue Type: Sub-task Components: Performance Reporter: Vladimir Rodionov Assignee: Vladimir Rodionov The common anti-pattern in Java is using LOG.xxx() calls w/o wrapping them into LOG.isXXXEnabled(). This results in unnecessary object serializations/ string concatenations/ garbage object production even if XXX log level is disabled. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12061) Ensure LOG.isXXXEnabled() wrapper around LOG.XXX() calls
[ https://issues.apache.org/jira/browse/HBASE-12061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14145215#comment-14145215 ] Jean-Marc Spaggiari commented on HBASE-12061: - +1 for INFO and below. I have seen many places where the moved to WARN to reduce log size. Ensure LOG.isXXXEnabled() wrapper around LOG.XXX() calls Key: HBASE-12061 URL: https://issues.apache.org/jira/browse/HBASE-12061 Project: HBase Issue Type: Sub-task Components: Performance Reporter: Vladimir Rodionov Assignee: Vladimir Rodionov The common anti-pattern in Java is using LOG.xxx() calls w/o wrapping them into LOG.isXXXEnabled(). This results in unnecessary object serializations/ string concatenations/ garbage object production even if XXX log level is disabled. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12067) Remove deprecated metrics classes.
[ https://issues.apache.org/jira/browse/HBASE-12067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-12067: -- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Remove deprecated metrics classes. -- Key: HBASE-12067 URL: https://issues.apache.org/jira/browse/HBASE-12067 Project: HBase Issue Type: Bug Components: metrics Reporter: Elliott Clark Assignee: Elliott Clark Fix For: 2.0.0, 0.99.1 Attachments: 0001-HBASE-12067-Remove-deprecated-metrics-classes.patch After the metrics2 move some replacement metrics classes were deprecated in 0.96. We should remove them now. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
