[jira] [Commented] (HBASE-17931) Assign system tables to servers with highest version
[ https://issues.apache.org/jira/browse/HBASE-17931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071950#comment-16071950 ] Hudson commented on HBASE-17931: FAILURE: Integrated in Jenkins build HBase-1.4 #798 (See [https://builds.apache.org/job/HBase-1.4/798/]) HBASE-17931 Assign system tables to servers with highest version (yangzhe1991: rev 3381c6c453627a35b1ba401f8d2b23cf88dd1cda) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/MockNoopMasterServices.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/TestDrainingServer.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterServices.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/util/VersionInfo.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/RegionServerTracker.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestAssignmentListener.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java * (add) hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestVersionInfo.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java > Assign system tables to servers with highest version > > > Key: HBASE-17931 > URL: https://issues.apache.org/jira/browse/HBASE-17931 > Project: HBase > Issue Type: Bug > Components: Region Assignment, scan >Reporter: Phil Yang >Assignee: Phil Yang >Priority: Blocker > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-17931.branch-1.v01.patch, > HBASE-17931.branch-1.v02.patch, HBASE-17931.branch-1.v03.patch, > HBASE-17931.branch-1.v04.patch, HBASE-17931.branch-1.v04.patch, > HBASE-17931.branch-1.v05.patch, HBASE-17931.branch-1.v05.patch, > HBASE-17931.branch-1.v06.patch, HBASE-17931.v01.patch, HBASE-17931.v02.patch, > HBASE-17931.v03.patch > > > In branch-1 and master we have some improvement and new features on scanning > which is not compatible. > A client of old version to a server of new version is compatible (must be a > bug if not, maybe need some test?). > A client of new version may not be able to read from a server of old version > correctly (because of scan limit, moreResults flag, etc), which is ok for > major/minor upgrade and we can tell users to upgrade server before upgrading > client. But RS also use scan to read meta. If meta table is in RS of old > version, all RSs of new version may have trouble while scanning meta table. > So we should make sure meta table always in servers of new version. Force > meta table in Master and upgrade Master first, or assign meta table in region > servers with latest version? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18295) The result contains the cells across different rows
[
https://issues.apache.org/jira/browse/HBASE-18295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071944#comment-16071944
]
ramkrishna.s.vasudevan commented on HBASE-18295:
Nice work [~chia7712]. Few questions on the patch
While doing next() - if the return code is to do seekOrSkipToNextColumn(cell),
we check if the flush has happened and if so reopenAfterFlush() is done.
Currently the return value is not used when a reseek() call happens.
Now if this reseek() happens during a next() call even if the lastTop has
changed the cell to the nextRow, the subsquent call to matcher.match() on the
heap.peek() (which should ideally be the lastTop) should say
{code}
// if row key is changed, then we know that we have moved over to the next
row
if (rowComparator.compareRows(currentRow, cell) != 0) {
return MatchCode.DONE;
}
{code}
And also should the cases as in the patch be handled in other places where we
call seekAsDirection() during the course of a next()?
> The result contains the cells across different rows
>
>
> Key: HBASE-18295
> URL: https://issues.apache.org/jira/browse/HBASE-18295
> Project: HBase
> Issue Type: Bug
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
>Priority: Blocker
> Fix For: 3.0.0, 1.4.0, 1.3.2, 2.0.0-alpha-2
>
> Attachments: HBASE-18295.branch-1.3.v0.patch,
> HBASE-18295.branch-1.v0.patch, HBASE-18295.v0.patch, HBASE-18295.v1.patch
>
>
> From the [flaky
> dashboard|https://builds.apache.org/job/HBASE-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html]
> If we use the cell which won't be flushed into disk as the top cell to reopen
> the scanners, the new top cell will change. If the new top cell is in
> different row, the matcher will reset, and then matcher will accept the new
> top cell...
> The TestStore# testFlushBeforeCompletingScan reproduces the bug.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18241) Change client.Table, client.Admin, Region, and Store to not use HTableDescriptor or HColumnDescriptor
[
https://issues.apache.org/jira/browse/HBASE-18241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated HBASE-18241:
---
Attachment: HBASE-18241.v3.patch
> Change client.Table, client.Admin, Region, and Store to not use
> HTableDescriptor or HColumnDescriptor
> -
>
> Key: HBASE-18241
> URL: https://issues.apache.org/jira/browse/HBASE-18241
> Project: HBase
> Issue Type: Task
>Reporter: Biju Nair
>Assignee: Chia-Ping Tsai
>Priority: Critical
> Fix For: 3.0.0, 2.0.0-alpha-2
>
> Attachments: HBASE-18241.v0.patch, HBASE-18241.v1.patch,
> HBASE-18241.v2.patch, HBASE-18241.v2.patch, HBASE-18241.v3.patch,
> HBASE-18241.v3.patch
>
>
> {{HTableDescriptor}} is deprecated and scheduled to be removed in 3.0. But
> [client.Table|https://github.com/apache/hbase/blob/a66d491892514fd4a188d6ca87d6260d8ae46184/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Table.java#L69]
> and
> [client.Admin|https://github.com/apache/hbase/blob/a66d491892514fd4a188d6ca87d6260d8ae46184/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java#L198]
> method {{getTableDescriptor}} returns {{HTableDescriptor}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18241) Change client.Table, client.Admin, Region, and Store to not use HTableDescriptor or HColumnDescriptor
[
https://issues.apache.org/jira/browse/HBASE-18241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated HBASE-18241:
---
Status: Patch Available (was: Open)
> Change client.Table, client.Admin, Region, and Store to not use
> HTableDescriptor or HColumnDescriptor
> -
>
> Key: HBASE-18241
> URL: https://issues.apache.org/jira/browse/HBASE-18241
> Project: HBase
> Issue Type: Task
>Reporter: Biju Nair
>Assignee: Chia-Ping Tsai
>Priority: Critical
> Fix For: 3.0.0, 2.0.0-alpha-2
>
> Attachments: HBASE-18241.v0.patch, HBASE-18241.v1.patch,
> HBASE-18241.v2.patch, HBASE-18241.v2.patch, HBASE-18241.v3.patch,
> HBASE-18241.v3.patch
>
>
> {{HTableDescriptor}} is deprecated and scheduled to be removed in 3.0. But
> [client.Table|https://github.com/apache/hbase/blob/a66d491892514fd4a188d6ca87d6260d8ae46184/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Table.java#L69]
> and
> [client.Admin|https://github.com/apache/hbase/blob/a66d491892514fd4a188d6ca87d6260d8ae46184/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java#L198]
> method {{getTableDescriptor}} returns {{HTableDescriptor}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18241) Change client.Table, client.Admin, Region, and Store to not use HTableDescriptor or HColumnDescriptor
[
https://issues.apache.org/jira/browse/HBASE-18241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated HBASE-18241:
---
Status: Open (was: Patch Available)
> Change client.Table, client.Admin, Region, and Store to not use
> HTableDescriptor or HColumnDescriptor
> -
>
> Key: HBASE-18241
> URL: https://issues.apache.org/jira/browse/HBASE-18241
> Project: HBase
> Issue Type: Task
>Reporter: Biju Nair
>Assignee: Chia-Ping Tsai
>Priority: Critical
> Fix For: 3.0.0, 2.0.0-alpha-2
>
> Attachments: HBASE-18241.v0.patch, HBASE-18241.v1.patch,
> HBASE-18241.v2.patch, HBASE-18241.v2.patch, HBASE-18241.v3.patch,
> HBASE-18241.v3.patch
>
>
> {{HTableDescriptor}} is deprecated and scheduled to be removed in 3.0. But
> [client.Table|https://github.com/apache/hbase/blob/a66d491892514fd4a188d6ca87d6260d8ae46184/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Table.java#L69]
> and
> [client.Admin|https://github.com/apache/hbase/blob/a66d491892514fd4a188d6ca87d6260d8ae46184/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java#L198]
> method {{getTableDescriptor}} returns {{HTableDescriptor}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-16120) Add shell test for truncate_preserve
[ https://issues.apache.org/jira/browse/HBASE-16120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071940#comment-16071940 ] Ashish Singhi commented on HBASE-16120: --- I don't think the patch is really testing the behavior of truncate_preserve command. The test you have added is same as truncate command. Correct me if I am missing something ? I think in the test for truncate_preserve we need to assert that the table after truncate_preserve, still maintains the previous region boundaries as it was before. > Add shell test for truncate_preserve > > > Key: HBASE-16120 > URL: https://issues.apache.org/jira/browse/HBASE-16120 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0, 1.4.0 >Reporter: Appy >Assignee: Guangxu Cheng >Priority: Minor > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-16120-master-v0.patch, > HBASE-16120-master-v0.patch, HBASE-16120-master-v0.patch > > > There's no shell test for truncate_preserve, should add one. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-15042) refactor so that site materials are in the Standard Maven Place
[
https://issues.apache.org/jira/browse/HBASE-15042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071932#comment-16071932
]
stack commented on HBASE-15042:
---
Sorry this rotted [~Jan Hentschel] If you redo I'll commit. Thanks.
> refactor so that site materials are in the Standard Maven Place
> ---
>
> Key: HBASE-15042
> URL: https://issues.apache.org/jira/browse/HBASE-15042
> Project: HBase
> Issue Type: Task
> Components: build, website
>Reporter: Sean Busbey
>Assignee: Jan Hentschel
>Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HBASE-15042.master.001.patch,
> HBASE-15042.master.002.patch, HBASE-15042.master.002.patch
>
>
> for some reason we currently have our site materials in {{src/main/site}}
> rather than the maven prescribed {{src/site}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-16120) Add shell test for truncate_preserve
[ https://issues.apache.org/jira/browse/HBASE-16120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071930#comment-16071930 ] stack commented on HBASE-16120: --- That looks good [~andrewcheng] Commit it? > Add shell test for truncate_preserve > > > Key: HBASE-16120 > URL: https://issues.apache.org/jira/browse/HBASE-16120 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0, 1.4.0 >Reporter: Appy >Assignee: Guangxu Cheng >Priority: Minor > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-16120-master-v0.patch, > HBASE-16120-master-v0.patch, HBASE-16120-master-v0.patch > > > There's no shell test for truncate_preserve, should add one. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-15042) refactor so that site materials are in the Standard Maven Place
[
https://issues.apache.org/jira/browse/HBASE-15042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071926#comment-16071926
]
Hadoop QA commented on HBASE-15042:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 9s{color}
| {color:red} HBASE-15042 does not apply to master. Rebase required? Wrong
Branch? See https://yetus.apache.org/documentation/0.4.0/precommit-patchnames
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-15042 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12875445/HBASE-15042.master.002.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/7471/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> refactor so that site materials are in the Standard Maven Place
> ---
>
> Key: HBASE-15042
> URL: https://issues.apache.org/jira/browse/HBASE-15042
> Project: HBase
> Issue Type: Task
> Components: build, website
>Reporter: Sean Busbey
>Assignee: Jan Hentschel
>Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HBASE-15042.master.001.patch,
> HBASE-15042.master.002.patch, HBASE-15042.master.002.patch
>
>
> for some reason we currently have our site materials in {{src/main/site}}
> rather than the maven prescribed {{src/site}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18241) Change client.Table, client.Admin, Region, and Store to not use HTableDescriptor or HColumnDescriptor
[
https://issues.apache.org/jira/browse/HBASE-18241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071925#comment-16071925
]
Chia-Ping Tsai commented on HBASE-18241:
bq. Pls mark the jira as 'Incompatible change' while closing. We have changed
some of the CP exposed APIs. Pls mention that very specifically in the notes.
Thanks for the nice cleanup.
Copy that.
> Change client.Table, client.Admin, Region, and Store to not use
> HTableDescriptor or HColumnDescriptor
> -
>
> Key: HBASE-18241
> URL: https://issues.apache.org/jira/browse/HBASE-18241
> Project: HBase
> Issue Type: Task
>Reporter: Biju Nair
>Assignee: Chia-Ping Tsai
>Priority: Critical
> Fix For: 3.0.0, 2.0.0-alpha-2
>
> Attachments: HBASE-18241.v0.patch, HBASE-18241.v1.patch,
> HBASE-18241.v2.patch, HBASE-18241.v2.patch, HBASE-18241.v3.patch
>
>
> {{HTableDescriptor}} is deprecated and scheduled to be removed in 3.0. But
> [client.Table|https://github.com/apache/hbase/blob/a66d491892514fd4a188d6ca87d6260d8ae46184/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Table.java#L69]
> and
> [client.Admin|https://github.com/apache/hbase/blob/a66d491892514fd4a188d6ca87d6260d8ae46184/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java#L198]
> method {{getTableDescriptor}} returns {{HTableDescriptor}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18241) Change client.Table, client.Admin, Region, and Store to not use HTableDescriptor or HColumnDescriptor
[
https://issues.apache.org/jira/browse/HBASE-18241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated HBASE-18241:
---
Summary: Change client.Table, client.Admin, Region, and Store to not use
HTableDescriptor or HColumnDescriptor (was: Change client.Table and
client.Admin to not use HTableDescriptor)
> Change client.Table, client.Admin, Region, and Store to not use
> HTableDescriptor or HColumnDescriptor
> -
>
> Key: HBASE-18241
> URL: https://issues.apache.org/jira/browse/HBASE-18241
> Project: HBase
> Issue Type: Task
>Reporter: Biju Nair
>Assignee: Chia-Ping Tsai
>Priority: Critical
> Fix For: 3.0.0, 2.0.0-alpha-2
>
> Attachments: HBASE-18241.v0.patch, HBASE-18241.v1.patch,
> HBASE-18241.v2.patch, HBASE-18241.v2.patch, HBASE-18241.v3.patch
>
>
> {{HTableDescriptor}} is deprecated and scheduled to be removed in 3.0. But
> [client.Table|https://github.com/apache/hbase/blob/a66d491892514fd4a188d6ca87d6260d8ae46184/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Table.java#L69]
> and
> [client.Admin|https://github.com/apache/hbase/blob/a66d491892514fd4a188d6ca87d6260d8ae46184/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java#L198]
> method {{getTableDescriptor}} returns {{HTableDescriptor}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18241) Change client.Table and client.Admin to not use HTableDescriptor
[
https://issues.apache.org/jira/browse/HBASE-18241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated HBASE-18241:
---
Release Note:
*Region class*
||*Removed API*||*New API*||
|HTableDescriptor getTableDesc()|TableDescriptor getTableDescriptor()|
*Store class*
||*Removed API*||*New API*||
|HColumnDescriptor getFamily()|ColumnFamilyDescriptor
getColumnFamilyDescriptor()|
*Table class*
||*Deprecated API*||*New API*||
|HTableDescriptor getTableDescriptor()|TableDescriptor getDescriptor()|
*Admin class*
||*Deprecated API*||*New API*||
|HTableDescriptor getTableDescriptor(TableName)|List
listTableDescriptor(TableName)|
|HTableDescriptor[] getTableDescriptors(List)|N/A|
|HTableDescriptor[]
getTableDescriptorsByTableName(List)|List
listTableDescriptors(List)|
|HTableDescriptor[] listTables()|List listTableDescriptors()|
|HTableDescriptor[] listTables(Pattern)|List
listTableDescriptors(Pattern)|
|HTableDescriptor[] listTables(String)|List
listTableDescriptors(String)|
|HTableDescriptor[] listTables(Pattern, boolean)|List
listTableDescriptors(Pattern, boolean)|
|HTableDescriptor[] listTables(String, boolean)|List
listTableDescriptors(String, boolean)|
|HTableDescriptor[] deleteTables(String)|N/A|
|HTableDescriptor[] deleteTables(Pattern)|N/A|
|HTableDescriptor[] enableTables(String)|N/A|
|HTableDescriptor[] enableTables(Pattern)|N/A|
|HTableDescriptor[] disableTables(String)|N/A|
|HTableDescriptor[] disableTables(Pattern)|N/A|
|void modifyTable(TableName, HTableDescriptor)|void
modifyTable(TableDescriptor)|
|void modifyTableAsync(TableName, HTableDescriptor)|void
modifyTableAsync(TableDescriptor)|
|HTableDescriptor[]
listTableDescriptorsByNamespace(String)|List
listTableDescriptorsByNamespace(byte[])|
||*Removed API*||*New API*||
|void createTable({color:red}HTableDescriptor{color})|void
createTable({color:red}TableDescriptor{color})|
|void createTable({color:red}HTableDescriptor{color}, byte[], byte[], int)|void
createTable({color:red}TableDescriptor{color}, byte[], byte[], int)|
|void createTable({color:red}HTableDescriptor{color}, byte[][])|void
createTable({color:red}TableDescriptor{color}, byte[][])|
|Future createTableAsync({color:red}HTableDescriptor{color},
byte[][])|Future createTableAsync({color:red}TableDescriptor{color},
byte[][])|
> Change client.Table and client.Admin to not use HTableDescriptor
>
>
> Key: HBASE-18241
> URL: https://issues.apache.org/jira/browse/HBASE-18241
> Project: HBase
> Issue Type: Task
>Reporter: Biju Nair
>Assignee: Chia-Ping Tsai
>Priority: Critical
> Fix For: 3.0.0, 2.0.0-alpha-2
>
> Attachments: HBASE-18241.v0.patch, HBASE-18241.v1.patch,
> HBASE-18241.v2.patch, HBASE-18241.v2.patch, HBASE-18241.v3.patch
>
>
> {{HTableDescriptor}} is deprecated and scheduled to be removed in 3.0. But
> [client.Table|https://github.com/apache/hbase/blob/a66d491892514fd4a188d6ca87d6260d8ae46184/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Table.java#L69]
> and
> [client.Admin|https://github.com/apache/hbase/blob/a66d491892514fd4a188d6ca87d6260d8ae46184/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java#L198]
> method {{getTableDescriptor}} returns {{HTableDescriptor}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-15042) refactor so that site materials are in the Standard Maven Place
[
https://issues.apache.org/jira/browse/HBASE-15042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stack updated HBASE-15042:
--
Attachment: HBASE-15042.master.002.patch
Retry
> refactor so that site materials are in the Standard Maven Place
> ---
>
> Key: HBASE-15042
> URL: https://issues.apache.org/jira/browse/HBASE-15042
> Project: HBase
> Issue Type: Task
> Components: build, website
>Reporter: Sean Busbey
>Assignee: Jan Hentschel
>Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HBASE-15042.master.001.patch,
> HBASE-15042.master.002.patch, HBASE-15042.master.002.patch
>
>
> for some reason we currently have our site materials in {{src/main/site}}
> rather than the maven prescribed {{src/site}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-15062) IntegrationTestMTTR conditionally run some tests
[ https://issues.apache.org/jira/browse/HBASE-15062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-15062: -- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Pushed to branch-2 and master. Thanks for the patch [~asamir] > IntegrationTestMTTR conditionally run some tests > - > > Key: HBASE-15062 > URL: https://issues.apache.org/jira/browse/HBASE-15062 > Project: HBase > Issue Type: Improvement > Components: integration tests >Affects Versions: 2.0.0 >Reporter: Samir Ahmic >Assignee: Samir Ahmic >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-15062-v0.patch, HBASE-15062-v1.patch, > HBASE-15062-v1.patch, HBASE-15062-v1.patch > > > On master branch master-rs collocation is on by default which cause that > following test in IntegrationTestMTTR is same test as restartMaster > - testKillRsHoldingMeta > I will add condition so that if we have system tables on master test above > will be skipped else we will run it -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-12527) Remove padding around parens
[
https://issues.apache.org/jira/browse/HBASE-12527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071922#comment-16071922
]
Hadoop QA commented on HBASE-12527:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 4s{color}
| {color:red} HBASE-12527 does not apply to master. Rebase required? Wrong
Branch? See https://yetus.apache.org/documentation/0.4.0/precommit-patchnames
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-12527 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12684273/HBASE-12527-v2.patch |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/7470/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> Remove padding around parens
>
>
> Key: HBASE-12527
> URL: https://issues.apache.org/jira/browse/HBASE-12527
> Project: HBase
> Issue Type: Sub-task
>Reporter: Sean Busbey
>Assignee: Varun Saxena
>Priority: Minor
> Attachments: HBASE-12527-0.98.patch, HBASE-12527-branch-1.patch,
> HBASE-12527.patch, HBASE-12527-v2.patch
>
>
> We have checkstyle [enforcing no padding around
> parenthesis|http://checkstyle.sourceforge.net/config_whitespace.html#ParenPad]
> and that matches [our ref
> guide|http://hbase.apache.org/book.html#common.patch.feedback.space.invaders].
> Right now we have ~150 instances of not meeting this standard.
> list impacted files:
> {code}
> grep -rl -E "(\( |[^ ] \))" */src/* | grep java | grep -v generated
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-11590) use a specific ThreadPoolExecutor
[
https://issues.apache.org/jira/browse/HBASE-11590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071921#comment-16071921
]
Hadoop QA commented on HBASE-11590:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 7s{color}
| {color:red} HBASE-11590 does not apply to master. Rebase required? Wrong
Branch? See https://yetus.apache.org/documentation/0.4.0/precommit-patchnames
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-11590 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12766789/HBASE-11590.v1.patch |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/7469/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> use a specific ThreadPoolExecutor
> -
>
> Key: HBASE-11590
> URL: https://issues.apache.org/jira/browse/HBASE-11590
> Project: HBase
> Issue Type: Bug
> Components: Client, Performance
>Affects Versions: 1.0.0, 2.0.0
>Reporter: Nicolas Liochon
>Assignee: Nicolas Liochon
>Priority: Minor
> Attachments: ExecutorServiceTest.java, HBASE-11590.v1.patch,
> LifoThreadPoolExecutorSQP.java, tp.patch, UnitQueueP.java, UnitQueuePU.java
>
>
> The JDK TPE creates all the threads in the pool. As a consequence, we create
> (by default) 256 threads even if we just need a few.
> The attached TPE create threads only if we have something in the queue.
> On a PE test with replica on, it improved the 99 latency percentile by 5%.
> Warning: there are likely some race conditions, but I'm posting it here
> because there is may be an implementation available somewhere we can use, or
> a good reason not to do that. So feedback welcome as usual.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-12816) GC logs are lost upon Region Server restart if GCLogFileRotation is enabled
[ https://issues.apache.org/jira/browse/HBASE-12816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-12816: -- Fix Version/s: (was: 2.0.0) > GC logs are lost upon Region Server restart if GCLogFileRotation is enabled > --- > > Key: HBASE-12816 > URL: https://issues.apache.org/jira/browse/HBASE-12816 > Project: HBase > Issue Type: Bug > Components: scripts >Reporter: Abhishek Singh Chouhan >Assignee: Abhishek Singh Chouhan >Priority: Minor > Attachments: HBASE-12816.patch > > > When -XX:+UseGCLogFileRotation is used gc log files end with .gc.0 instead of > .gc. hbase_rotate_log () in hbase-daemon.sh does not handle this correctly > and hence when a RS is restarted old gc logs are lost(overwritten). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-12527) Remove padding around parens
[
https://issues.apache.org/jira/browse/HBASE-12527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stack updated HBASE-12527:
--
Fix Version/s: (was: 2.0.0)
> Remove padding around parens
>
>
> Key: HBASE-12527
> URL: https://issues.apache.org/jira/browse/HBASE-12527
> Project: HBase
> Issue Type: Sub-task
>Reporter: Sean Busbey
>Assignee: Varun Saxena
>Priority: Minor
> Attachments: HBASE-12527-0.98.patch, HBASE-12527-branch-1.patch,
> HBASE-12527.patch, HBASE-12527-v2.patch
>
>
> We have checkstyle [enforcing no padding around
> parenthesis|http://checkstyle.sourceforge.net/config_whitespace.html#ParenPad]
> and that matches [our ref
> guide|http://hbase.apache.org/book.html#common.patch.feedback.space.invaders].
> Right now we have ~150 instances of not meeting this standard.
> list impacted files:
> {code}
> grep -rl -E "(\( |[^ ] \))" */src/* | grep java | grep -v generated
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-11590) use a specific ThreadPoolExecutor
[ https://issues.apache.org/jira/browse/HBASE-11590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-11590: -- Fix Version/s: (was: 2.0.0) > use a specific ThreadPoolExecutor > - > > Key: HBASE-11590 > URL: https://issues.apache.org/jira/browse/HBASE-11590 > Project: HBase > Issue Type: Bug > Components: Client, Performance >Affects Versions: 1.0.0, 2.0.0 >Reporter: Nicolas Liochon >Assignee: Nicolas Liochon >Priority: Minor > Attachments: ExecutorServiceTest.java, HBASE-11590.v1.patch, > LifoThreadPoolExecutorSQP.java, tp.patch, UnitQueueP.java, UnitQueuePU.java > > > The JDK TPE creates all the threads in the pool. As a consequence, we create > (by default) 256 threads even if we just need a few. > The attached TPE create threads only if we have something in the queue. > On a PE test with replica on, it improved the 99 latency percentile by 5%. > Warning: there are likely some race conditions, but I'm posting it here > because there is may be an implementation available somewhere we can use, or > a good reason not to do that. So feedback welcome as usual. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-12457) Regions in transition for a long time when CLOSE interleaves with a slow compaction
[
https://issues.apache.org/jira/browse/HBASE-12457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071919#comment-16071919
]
Hadoop QA commented on HBASE-12457:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m
3s{color} | {color:blue} The patch file was not named according to hbase's
naming conventions. Please see
https://yetus.apache.org/documentation/0.4.0/precommit-patchnames for
instructions. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 7s{color}
| {color:red} HBASE-12457 does not apply to master. Rebase required? Wrong
Branch? See https://yetus.apache.org/documentation/0.4.0/precommit-patchnames
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-12457 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12681485/12457-trunk-v3.txt |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/7468/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> Regions in transition for a long time when CLOSE interleaves with a slow
> compaction
> ---
>
> Key: HBASE-12457
> URL: https://issues.apache.org/jira/browse/HBASE-12457
> Project: HBase
> Issue Type: Bug
>Affects Versions: 0.98.7
>Reporter: Lars Hofhansl
>Assignee: Lars Hofhansl
> Attachments: 12457-combined-0.98.txt, 12457-combined-0.98-v2.txt,
> 12457-combined-trunk.txt, 12457.interrupt.txt, 12457.interrupt-v2.txt,
> 12457-minifix.txt, 12457-trunk-v3.txt, HBASE-12457_addendum.patch,
> HBASE-12457.patch, TestRegionReplicas-jstack.txt
>
>
> Under heave load we have observed regions remaining in transition for 20
> minutes when the master requests a close while a slow compaction is running.
> The pattern is always something like this:
> # RS starts a compaction
> # HM request the region to be closed on this RS
> # Compaction is not aborted for another 20 minutes
> # The region is in transition and not usable.
> In every case I tracked down so far the time between the requested CLOSE and
> abort of the compaction is almost exactly 20 minutes, which is suspicious.
> Of course part of the issue is having compactions that take over 20 minutes,
> but maybe we can do better here.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-12457) Regions in transition for a long time when CLOSE interleaves with a slow compaction
[ https://issues.apache.org/jira/browse/HBASE-12457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-12457: -- Fix Version/s: (was: 2.0.0) > Regions in transition for a long time when CLOSE interleaves with a slow > compaction > --- > > Key: HBASE-12457 > URL: https://issues.apache.org/jira/browse/HBASE-12457 > Project: HBase > Issue Type: Bug >Affects Versions: 0.98.7 >Reporter: Lars Hofhansl >Assignee: Lars Hofhansl > Attachments: 12457-combined-0.98.txt, 12457-combined-0.98-v2.txt, > 12457-combined-trunk.txt, 12457.interrupt.txt, 12457.interrupt-v2.txt, > 12457-minifix.txt, 12457-trunk-v3.txt, HBASE-12457_addendum.patch, > HBASE-12457.patch, TestRegionReplicas-jstack.txt > > > Under heave load we have observed regions remaining in transition for 20 > minutes when the master requests a close while a slow compaction is running. > The pattern is always something like this: > # RS starts a compaction > # HM request the region to be closed on this RS > # Compaction is not aborted for another 20 minutes > # The region is in transition and not usable. > In every case I tracked down so far the time between the requested CLOSE and > abort of the compaction is almost exactly 20 minutes, which is suspicious. > Of course part of the issue is having compactions that take over 20 minutes, > but maybe we can do better here. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-12457) Regions in transition for a long time when CLOSE interleaves with a slow compaction
[ https://issues.apache.org/jira/browse/HBASE-12457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071917#comment-16071917 ] stack commented on HBASE-12457: --- Unscheduling old issue from 2.0.0. > Regions in transition for a long time when CLOSE interleaves with a slow > compaction > --- > > Key: HBASE-12457 > URL: https://issues.apache.org/jira/browse/HBASE-12457 > Project: HBase > Issue Type: Bug >Affects Versions: 0.98.7 >Reporter: Lars Hofhansl >Assignee: Lars Hofhansl > Attachments: 12457-combined-0.98.txt, 12457-combined-0.98-v2.txt, > 12457-combined-trunk.txt, 12457.interrupt.txt, 12457.interrupt-v2.txt, > 12457-minifix.txt, 12457-trunk-v3.txt, HBASE-12457_addendum.patch, > HBASE-12457.patch, TestRegionReplicas-jstack.txt > > > Under heave load we have observed regions remaining in transition for 20 > minutes when the master requests a close while a slow compaction is running. > The pattern is always something like this: > # RS starts a compaction > # HM request the region to be closed on this RS > # Compaction is not aborted for another 20 minutes > # The region is in transition and not usable. > In every case I tracked down so far the time between the requested CLOSE and > abort of the compaction is almost exactly 20 minutes, which is suspicious. > Of course part of the issue is having compactions that take over 20 minutes, > but maybe we can do better here. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-15227) HBase Backup Phase 3: Fault tolerance (client/server) support
[ https://issues.apache.org/jira/browse/HBASE-15227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-15227: -- Priority: Major (was: Blocker) > HBase Backup Phase 3: Fault tolerance (client/server) support > - > > Key: HBASE-15227 > URL: https://issues.apache.org/jira/browse/HBASE-15227 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov > Labels: backup > Fix For: 2.0.0 > > Attachments: HBASE-15227-v3.patch, HBASE-15277-v1.patch > > > System must be tolerant to faults: > # Backup operations MUST be atomic (no partial completion state in the backup > system table) > # Process must detect any type of failures which can result in a data loss > (partial backup or partial restore) > # Proper system table state restore and cleanup must be done in case of a > failure > # Additional utility to repair backup system table and corresponding file > system cleanup must be implemented > h3. Backup > h4. General FT framework implementation > Before actual backup operation starts, snapshot of a backup system table is > taken and system table is updated with *ACTIVE_SNAPSHOT* flag. The flag will > be removed upon backup completion. > In case of *any* server-side failures, client catches errors/exceptions and > handles them: > # Cleans up backup destination (removes partial backup data) > # Cleans up any temporary data > # Deletes any active snapshots of a tables being backed up (during full > backup we snapshot tables) > # Restores backup system table from snapshot > # Deletes backup system table snapshot (we read snapshot name from backup > system table before) > In case of *any* client-side failures: > Before any backup or restore operation run we check backup system table on > *ACTIVE_SNAPSHOT*, if flag is present, operation aborts with a message that > backup repair tool (see below) must be run > h4. Backup repair tool > The command line tool *backup repair* which executes the following steps: > # Reads info of a last failed backup session > # Cleans up backup destination (removes partial backup data) > # Cleans up any temporary data > # Deletes any active snapshots of a tables being backed up (during full > backup we snapshot tables) > # Restores backup system table from snapshot > # Deletes backup system table snapshot (we read snapshot name from backup > system table before) > h4. Detection of a partial loss of data > h5. Full backup > Export snapshot operation (?). > We count files and check sizes before and after DistCp run > h5. Incremental backup > Conversion of WAL to HFiles, when WAL file is moved from active to archive > directory. The code is in place to handle this situation > During DistCp run (same as above) > h3. Restore > This operation does not modify backup system table and is idempotent. No > special FT is required. > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-16120) Add shell test for truncate_preserve
[
https://issues.apache.org/jira/browse/HBASE-16120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071914#comment-16071914
]
Hadoop QA commented on HBASE-16120:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
26s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} rubocop {color} | {color:blue} 0m
7s{color} | {color:blue} rubocop was not available. {color} |
| {color:blue}0{color} | {color:blue} ruby-lint {color} | {color:blue} 0m
7s{color} | {color:blue} Ruby-lint was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
10s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
68m 54s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha3. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 7m
57s{color} | {color:green} hbase-shell in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
17s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 85m 1s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.03.0-ce Server=17.03.0-ce Image:yetus/hbase:757bf37 |
| JIRA Issue | HBASE-16120 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12875436/HBASE-16120-master-v0.patch
|
| Optional Tests | asflicense unit rubocop ruby_lint |
| uname | Linux 07309059c8f1 4.8.3-std-1 #1 SMP Fri Oct 21 11:15:43 UTC 2016
x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / f1b97a6 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/7465/testReport/ |
| modules | C: hbase-shell U: hbase-shell |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/7465/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> Add shell test for truncate_preserve
>
>
> Key: HBASE-16120
> URL: https://issues.apache.org/jira/browse/HBASE-16120
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.0.0, 1.4.0
>Reporter: Appy
>Assignee: Guangxu Cheng
>Priority: Minor
> Fix For: 2.0.0, 1.4.0
>
> Attachments: HBASE-16120-master-v0.patch,
> HBASE-16120-master-v0.patch, HBASE-16120-master-v0.patch
>
>
> There's no shell test for truncate_preserve, should add one.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-16730) Exclude junit as a transitive dependency from hadoop-common
[ https://issues.apache.org/jira/browse/HBASE-16730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-16730: -- Attachment: HBASE-16730.master.002 (1).patch > Exclude junit as a transitive dependency from hadoop-common > --- > > Key: HBASE-16730 > URL: https://issues.apache.org/jira/browse/HBASE-16730 > Project: HBase > Issue Type: Improvement > Components: hbase >Reporter: Nils Larsgård >Assignee: Jan Hentschel >Priority: Trivial > Labels: hbase-client, junit > Fix For: 2.0.0 > > Attachments: HBASE-16730.master.001.patch, HBASE-16730.master.002 > (1).patch, HBASE-16730.master.002.patch, HBASE-16730.master.002.patch, > HBASE-16730.master.002.patch > > Original Estimate: 20m > Remaining Estimate: 20m > > add exclusion to the hadoop-common dependency in hbase-client: exclude junit -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18241) Change client.Table and client.Admin to not use HTableDescriptor
[
https://issues.apache.org/jira/browse/HBASE-18241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071898#comment-16071898
]
Anoop Sam John commented on HBASE-18241:
Pls mark the jira as 'Incompatible change' while closing. We have changed some
of the CP exposed APIs. Pls mention that very specifically in the notes.
Thanks for the nice cleanup.
> Change client.Table and client.Admin to not use HTableDescriptor
>
>
> Key: HBASE-18241
> URL: https://issues.apache.org/jira/browse/HBASE-18241
> Project: HBase
> Issue Type: Task
>Reporter: Biju Nair
>Assignee: Chia-Ping Tsai
>Priority: Critical
> Fix For: 3.0.0, 2.0.0-alpha-2
>
> Attachments: HBASE-18241.v0.patch, HBASE-18241.v1.patch,
> HBASE-18241.v2.patch, HBASE-18241.v2.patch, HBASE-18241.v3.patch
>
>
> {{HTableDescriptor}} is deprecated and scheduled to be removed in 3.0. But
> [client.Table|https://github.com/apache/hbase/blob/a66d491892514fd4a188d6ca87d6260d8ae46184/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Table.java#L69]
> and
> [client.Admin|https://github.com/apache/hbase/blob/a66d491892514fd4a188d6ca87d6260d8ae46184/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java#L198]
> method {{getTableDescriptor}} returns {{HTableDescriptor}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18308) Eliminate the findbugs warnings for hbase-server
[ https://issues.apache.org/jira/browse/HBASE-18308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18308: --- Fix Version/s: (was: 1.1.12) (was: 1.2.7) (was: 1.3.2) (was: 1.4.0) > Eliminate the findbugs warnings for hbase-server > > > Key: HBASE-18308 > URL: https://issues.apache.org/jira/browse/HBASE-18308 > Project: HBase > Issue Type: Sub-task >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 3.0.0, 2.0.0-alpha-2 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-18308) Eliminate the findbugs warnings for hbase-server
Chia-Ping Tsai created HBASE-18308: -- Summary: Eliminate the findbugs warnings for hbase-server Key: HBASE-18308 URL: https://issues.apache.org/jira/browse/HBASE-18308 Project: HBase Issue Type: Sub-task Reporter: Chia-Ping Tsai Assignee: Chia-Ping Tsai -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (HBASE-18241) Change client.Table and client.Admin to not use HTableDescriptor
[
https://issues.apache.org/jira/browse/HBASE-18241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071677#comment-16071677
]
Chia-Ping Tsai edited comment on HBASE-18241 at 7/3/17 4:08 AM:
v3.patch
There are plenty of changes as Region#getTableDesc() and Store#getFamily() are
often used in code base.
--
*Region class*
||*Previous API*||*New API*||
|HTableDescriptor getTableDesc()|TableDescriptor getTableDescriptor()|
*Store class*
||*Previous API*||*New API*||
|HColumnDescriptor getFamily()|ColumnFamilyDescriptor
getColumnFamilyDescriptor()|
*Table class*
||*Deprecated API*||*New API*||
|HTableDescriptor getTableDescriptor()|TableDescriptor getDescriptor()|
*Admin class*
||*Deprecated API*||*New API*||
|HTableDescriptor getTableDescriptor(TableName)|List
listTableDescriptor(TableName)|
|HTableDescriptor[] getTableDescriptors(List)|N/A|
|HTableDescriptor[]
getTableDescriptorsByTableName(List)|List
listTableDescriptors(List)|
|HTableDescriptor[] listTables()|List listTableDescriptors()|
|HTableDescriptor[] listTables(Pattern)|List
listTableDescriptors(Pattern)|
|HTableDescriptor[] listTables(String)|List
listTableDescriptors(String)|
|HTableDescriptor[] listTables(Pattern, boolean)|List
listTableDescriptors(Pattern, boolean)|
|HTableDescriptor[] listTables(String, boolean)|List
listTableDescriptors(String, boolean)|
|HTableDescriptor[] deleteTables(String)|N/A|
|HTableDescriptor[] deleteTables(Pattern)|N/A|
|HTableDescriptor[] enableTables(String)|N/A|
|HTableDescriptor[] enableTables(Pattern)|N/A|
|HTableDescriptor[] disableTables(String)|N/A|
|HTableDescriptor[] disableTables(Pattern)|N/A|
|void modifyTable(TableName, HTableDescriptor)|void
modifyTable(TableDescriptor)|
|void modifyTableAsync(TableName, HTableDescriptor)|void
modifyTableAsync(TableDescriptor)|
|HTableDescriptor[]
listTableDescriptorsByNamespace(String)|List
listTableDescriptorsByNamespace(byte[])|
||*Previous API*||*New API*||
|void createTable({color:red}HTableDescriptor{color})|void
createTable({color:red}TableDescriptor{color})|
|void createTable({color:red}HTableDescriptor{color}, byte[], byte[], int)|void
createTable({color:red}TableDescriptor{color}, byte[], byte[], int)|
|void createTable({color:red}HTableDescriptor{color}, byte[][])|void
createTable({color:red}TableDescriptor{color}, byte[][])|
|Future createTableAsync({color:red}HTableDescriptor{color},
byte[][])|Future createTableAsync({color:red}TableDescriptor{color},
byte[][])|
was (Author: chia7712):
v3.patch
There are plenty of changes as Region#getTableDesc() and Store#getFamily() are
often used in code base.
--
*Region class*
||*Previous API*||*New API*||
|HTableDescriptor getTableDesc()|TableDescriptor getTableDescriptor()|
*Store class*
||*Previous API*||*New API*||
|HColumnDescriptor getFamily()|ColumnFamilyDescriptor getDescriptor()|
*Table class*
||*Deprecated API*||*New API*||
|HTableDescriptor getTableDescriptor()|TableDescriptor getDescriptor()|
*Admin class*
||*Deprecated API*||*New API*||
|HTableDescriptor getTableDescriptor(TableName)|List
listTableDescriptor(TableName)|
|HTableDescriptor[] getTableDescriptors(List)|N/A|
|HTableDescriptor[]
getTableDescriptorsByTableName(List)|List
listTableDescriptors(List)|
|HTableDescriptor[] listTables()|List listTableDescriptors()|
|HTableDescriptor[] listTables(Pattern)|List
listTableDescriptors(Pattern)|
|HTableDescriptor[] listTables(String)|List
listTableDescriptors(String)|
|HTableDescriptor[] listTables(Pattern, boolean)|List
listTableDescriptors(Pattern, boolean)|
|HTableDescriptor[] listTables(String, boolean)|List
listTableDescriptors(String, boolean)|
|HTableDescriptor[] deleteTables(String)|N/A|
|HTableDescriptor[] deleteTables(Pattern)|N/A|
|HTableDescriptor[] enableTables(String)|N/A|
|HTableDescriptor[] enableTables(Pattern)|N/A|
|HTableDescriptor[] disableTables(String)|N/A|
|HTableDescriptor[] disableTables(Pattern)|N/A|
|void modifyTable(TableName, HTableDescriptor)|void
modifyTable(TableDescriptor)|
|void modifyTableAsync(TableName, HTableDescriptor)|void
modifyTableAsync(TableDescriptor)|
|HTableDescriptor[]
listTableDescriptorsByNamespace(String)|List
listTableDescriptorsByNamespace(byte[])|
||*Previous API*||*New API*||
|void createTable({color:red}HTableDescriptor{color})|void
createTable({color:red}TableDescriptor{color})|
|void createTable({color:red}HTableDescriptor{color}, byte[], byte[], int)|void
createTable({color:red}TableDescriptor{color}, byte[], byte[], int)|
|void createTable({color:red}HTableDescriptor{color}, byte[][])|void
createTable({color:red}TableDescriptor{color}, byte[][])|
|Future createTableAsync({color:red}HTableDescriptor{color},
byte[][])|Future createTableAsync({color:red}TableDescriptor{color},
byte[][])|
> Change client.Table and client.Admin to not use HTableDescriptor
>
[jira] [Updated] (HBASE-18295) The result contains the cells across different rows
[ https://issues.apache.org/jira/browse/HBASE-18295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18295: --- Attachment: HBASE-18295.branch-1.3.v0.patch > The result contains the cells across different rows > > > Key: HBASE-18295 > URL: https://issues.apache.org/jira/browse/HBASE-18295 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Blocker > Fix For: 3.0.0, 1.4.0, 1.3.2, 2.0.0-alpha-2 > > Attachments: HBASE-18295.branch-1.3.v0.patch, > HBASE-18295.branch-1.v0.patch, HBASE-18295.v0.patch, HBASE-18295.v1.patch > > > From the [flaky > dashboard|https://builds.apache.org/job/HBASE-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html] > If we use the cell which won't be flushed into disk as the top cell to reopen > the scanners, the new top cell will change. If the new top cell is in > different row, the matcher will reset, and then matcher will accept the new > top cell... > The TestStore# testFlushBeforeCompletingScan reproduces the bug. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18295) The result contains the cells across different rows
[ https://issues.apache.org/jira/browse/HBASE-18295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18295: --- Status: Patch Available (was: Open) > The result contains the cells across different rows > > > Key: HBASE-18295 > URL: https://issues.apache.org/jira/browse/HBASE-18295 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Blocker > Fix For: 3.0.0, 1.4.0, 1.3.2, 2.0.0-alpha-2 > > Attachments: HBASE-18295.branch-1.3.v0.patch, > HBASE-18295.branch-1.v0.patch, HBASE-18295.v0.patch, HBASE-18295.v1.patch > > > From the [flaky > dashboard|https://builds.apache.org/job/HBASE-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html] > If we use the cell which won't be flushed into disk as the top cell to reopen > the scanners, the new top cell will change. If the new top cell is in > different row, the matcher will reset, and then matcher will accept the new > top cell... > The TestStore# testFlushBeforeCompletingScan reproduces the bug. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18295) The result contains the cells across different rows
[ https://issues.apache.org/jira/browse/HBASE-18295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071894#comment-16071894 ] Chia-Ping Tsai commented on HBASE-18295: v0.patch for branch-1 -- All failed Procedure UTs are traced by HBASE-18216. > The result contains the cells across different rows > > > Key: HBASE-18295 > URL: https://issues.apache.org/jira/browse/HBASE-18295 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Blocker > Fix For: 3.0.0, 1.4.0, 1.3.2, 2.0.0-alpha-2 > > Attachments: HBASE-18295.branch-1.v0.patch, HBASE-18295.v0.patch, > HBASE-18295.v1.patch > > > From the [flaky > dashboard|https://builds.apache.org/job/HBASE-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html] > If we use the cell which won't be flushed into disk as the top cell to reopen > the scanners, the new top cell will change. If the new top cell is in > different row, the matcher will reset, and then matcher will accept the new > top cell... > The TestStore# testFlushBeforeCompletingScan reproduces the bug. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18295) The result contains the cells across different rows
[ https://issues.apache.org/jira/browse/HBASE-18295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18295: --- Status: Open (was: Patch Available) > The result contains the cells across different rows > > > Key: HBASE-18295 > URL: https://issues.apache.org/jira/browse/HBASE-18295 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Blocker > Fix For: 3.0.0, 1.4.0, 1.3.2, 2.0.0-alpha-2 > > Attachments: HBASE-18295.branch-1.v0.patch, HBASE-18295.v0.patch, > HBASE-18295.v1.patch > > > From the [flaky > dashboard|https://builds.apache.org/job/HBASE-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html] > If we use the cell which won't be flushed into disk as the top cell to reopen > the scanners, the new top cell will change. If the new top cell is in > different row, the matcher will reset, and then matcher will accept the new > top cell... > The TestStore# testFlushBeforeCompletingScan reproduces the bug. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17931) Assign system tables to servers with highest version
[ https://issues.apache.org/jira/browse/HBASE-17931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071887#comment-16071887 ] Phil Yang commented on HBASE-17931: --- Yes. I'll push the patch to branch-1 and prepare a new patch for master/branch-2. > Assign system tables to servers with highest version > > > Key: HBASE-17931 > URL: https://issues.apache.org/jira/browse/HBASE-17931 > Project: HBase > Issue Type: Bug > Components: Region Assignment, scan >Reporter: Phil Yang >Assignee: Phil Yang >Priority: Blocker > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-17931.branch-1.v01.patch, > HBASE-17931.branch-1.v02.patch, HBASE-17931.branch-1.v03.patch, > HBASE-17931.branch-1.v04.patch, HBASE-17931.branch-1.v04.patch, > HBASE-17931.branch-1.v05.patch, HBASE-17931.branch-1.v05.patch, > HBASE-17931.branch-1.v06.patch, HBASE-17931.v01.patch, HBASE-17931.v02.patch, > HBASE-17931.v03.patch > > > In branch-1 and master we have some improvement and new features on scanning > which is not compatible. > A client of old version to a server of new version is compatible (must be a > bug if not, maybe need some test?). > A client of new version may not be able to read from a server of old version > correctly (because of scan limit, moreResults flag, etc), which is ok for > major/minor upgrade and we can tell users to upgrade server before upgrading > client. But RS also use scan to read meta. If meta table is in RS of old > version, all RSs of new version may have trouble while scanning meta table. > So we should make sure meta table always in servers of new version. Force > meta table in Master and upgrade Master first, or assign meta table in region > servers with latest version? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-16120) Add shell test for truncate_preserve
[ https://issues.apache.org/jira/browse/HBASE-16120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guangxu Cheng updated HBASE-16120: -- Attachment: (was: HBASE-16120-master-v0.patch) > Add shell test for truncate_preserve > > > Key: HBASE-16120 > URL: https://issues.apache.org/jira/browse/HBASE-16120 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0, 1.4.0 >Reporter: Appy >Assignee: Guangxu Cheng >Priority: Minor > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-16120-master-v0.patch, > HBASE-16120-master-v0.patch, HBASE-16120-master-v0.patch > > > There's no shell test for truncate_preserve, should add one. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-16120) Add shell test for truncate_preserve
[ https://issues.apache.org/jira/browse/HBASE-16120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guangxu Cheng updated HBASE-16120: -- Attachment: HBASE-16120-master-v0.patch > Add shell test for truncate_preserve > > > Key: HBASE-16120 > URL: https://issues.apache.org/jira/browse/HBASE-16120 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0, 1.4.0 >Reporter: Appy >Assignee: Guangxu Cheng >Priority: Minor > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-16120-master-v0.patch, > HBASE-16120-master-v0.patch, HBASE-16120-master-v0.patch > > > There's no shell test for truncate_preserve, should add one. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Work started] (HBASE-18147) nightly job to check health of active branches
[ https://issues.apache.org/jira/browse/HBASE-18147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-18147 started by Sean Busbey. --- > nightly job to check health of active branches > -- > > Key: HBASE-18147 > URL: https://issues.apache.org/jira/browse/HBASE-18147 > Project: HBase > Issue Type: Test > Components: community, test >Reporter: Sean Busbey >Assignee: Sean Busbey > Attachments: HBASE-18147.0.patch > > > We should set up a job that runs Apache Yetus Test Patch's nightly mode. > Essentially, it produces a report that considers how the branch measures up > against the things we check in our precommit checks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (HBASE-18147) nightly job to check health of active branches
[ https://issues.apache.org/jira/browse/HBASE-18147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey reassigned HBASE-18147: --- Assignee: Sean Busbey > nightly job to check health of active branches > -- > > Key: HBASE-18147 > URL: https://issues.apache.org/jira/browse/HBASE-18147 > Project: HBase > Issue Type: Test > Components: community, test >Reporter: Sean Busbey >Assignee: Sean Busbey > Attachments: HBASE-18147.0.patch > > > We should set up a job that runs Apache Yetus Test Patch's nightly mode. > Essentially, it produces a report that considers how the branch measures up > against the things we check in our precommit checks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18294) Flush is based on data size instead of heap size
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071856#comment-16071856 ] Anoop Sam John commented on HBASE-18294: When the data size of the memstore is high (choosing one to flush), the heap occupancy of it also will be on higher side no? Am speaking abt the common case. We have basic flattening as the default now and CompactingMemstore is the default. So we can expect all the memstores to be in this way not like some are flattened and some are never. (Am speaking wrt defaults configs as we have now). One can tune the region flush size as per the new changes. May be the default itself we can change now. But considering data size only for the per region flush decision is more inline with a normal user thinking. 128MB size I have configured and the data is flushed at that data size reach. What is the heap overhead (we have some with DefaultMemstore and some thing else when compacting memstore basic mode in place etc. Tomorrow if a new algorithm comes it may even reduce) is not a user headache. Still we have to consider that as we can not make our RS to OOME or have GC bad impacts. That any way at global level we are doing. In normal cases also flushes due to global pressure might be happening. Say we have 100 regions per RS and then as per default settings, the ideal heap size need for global memstores is 100 * 128 MB = 12.5 GB 12.5 * 4 = 50 GB. We allow the memstores size to grow 4 times 128 MB before blocking. So configuring this big size might not be the usual case. Agree that we will kick start the flush of region once the size is 128 MB. But if the write pressure is high the size can grow beyond 2x . > Flush is based on data size instead of heap size > > > Key: HBASE-18294 > URL: https://issues.apache.org/jira/browse/HBASE-18294 > Project: HBase > Issue Type: Bug >Reporter: Eshcar Hillel >Assignee: Eshcar Hillel > > A region is flushed if its memory component exceed a threshold (default size > is 128MB). > A flush policy decides whether to flush a store by comparing the size of the > store to another threshold (that can be configured with > hbase.hregion.percolumnfamilyflush.size.lower.bound). > Currently the implementation (in both cases) compares the data size > (key-value only) to the threshold where it should compare the heap size > (which includes index size, and metadata). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-16120) Add shell test for truncate_preserve
[ https://issues.apache.org/jira/browse/HBASE-16120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071855#comment-16071855 ] Guangxu Cheng commented on HBASE-16120: --- stack ,Thanks for your review. All tests pass locally. Resubmit the patch and try again.Thanks > Add shell test for truncate_preserve > > > Key: HBASE-16120 > URL: https://issues.apache.org/jira/browse/HBASE-16120 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0, 1.4.0 >Reporter: Appy >Assignee: Guangxu Cheng >Priority: Minor > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-16120-master-v0.patch, > HBASE-16120-master-v0.patch, HBASE-16120-master-v0.patch > > > There's no shell test for truncate_preserve, should add one. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-16120) Add shell test for truncate_preserve
[ https://issues.apache.org/jira/browse/HBASE-16120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guangxu Cheng updated HBASE-16120: -- Attachment: HBASE-16120-master-v0.patch > Add shell test for truncate_preserve > > > Key: HBASE-16120 > URL: https://issues.apache.org/jira/browse/HBASE-16120 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0, 1.4.0 >Reporter: Appy >Assignee: Guangxu Cheng >Priority: Minor > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-16120-master-v0.patch, > HBASE-16120-master-v0.patch, HBASE-16120-master-v0.patch > > > There's no shell test for truncate_preserve, should add one. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17893) Allow HBase to build against Hadoop 2.8.0
[
https://issues.apache.org/jira/browse/HBASE-17893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071799#comment-16071799
]
Hadoop QA commented on HBASE-17893:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
15s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
47s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
22s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
13s{color} | {color:green} branch-1.3 passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
7s{color} | {color:green} branch-1.3 passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
7s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git
apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
16m 39s{color} | {color:green} The patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
6s{color} | {color:green} the patch passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
8s{color} | {color:green} the patch passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
8s{color} | {color:green} hbase-resource-bundle in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
12s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 25m 28s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:9ba21e3 |
| JIRA Issue | HBASE-17893 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12875424/17893.branch-1.3.patch
|
| Optional Tests | asflicense javac javadoc unit xml |
| uname | Linux 048b45ef2c12 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/hbase.sh |
| git revision | branch-1.3 / 70386cb |
| Default Java | 1.7.0_131 |
| Multi-JDK versions | /usr/lib/jvm/java-8-oracle:1.8.0_131
/usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131 |
| whitespace |
https://builds.apache.org/job/PreCommit-HBASE-Build/7463/artifact/patchprocess/whitespace-eol.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/7463/testReport/ |
| modules | C: hbase-resource-bundle U: hbase-resource-bundle |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/7463/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> Allow HBase to build against Hadoop 2.8.0
> -
>
> Key: HBASE-17893
> URL: https://issues.apache.org/jira/browse/HBASE-17893
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.2.5
>Reporter: Lars Hofhansl
> Fix For: 1.3.2, 1.2.7
>
> Attachments: 17883-1.2-BROKEN.txt, 17893-1.3-backport-rebased.txt,
> 17893-1.3-backport.txt, 17893.branch-1.3.patch
>
>
> {code}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-remote-resources-plugin:1.5:process (default)
> on project hbase-assembly: Error rendering velocity resource. Error invoking
> method
[jira] [Commented] (HBASE-17893) Allow HBase to build against Hadoop 2.8.0
[
https://issues.apache.org/jira/browse/HBASE-17893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071789#comment-16071789
]
Lars Hofhansl commented on HBASE-17893:
---
Attached patch hopefully named correctly to be tried against the 1.3 branch.
> Allow HBase to build against Hadoop 2.8.0
> -
>
> Key: HBASE-17893
> URL: https://issues.apache.org/jira/browse/HBASE-17893
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.2.5
>Reporter: Lars Hofhansl
> Fix For: 1.3.2, 1.2.7
>
> Attachments: 17883-1.2-BROKEN.txt, 17893-1.3-backport-rebased.txt,
> 17893-1.3-backport.txt, 17893.branch-1.3.patch
>
>
> {code}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-remote-resources-plugin:1.5:process (default)
> on project hbase-assembly: Error rendering velocity resource. Error invoking
> method 'get(java.lang.Integer)' in java.util.ArrayList at
> META-INF/LICENSE.vm[line 1671, column 8]: InvocationTargetException: Index:
> 0, Size: 0 -> [Help 1]
> {code}
> The in the generated LICENSE.
> {code}
> This product includes Nimbus JOSE+JWT licensed under the The Apache Software
> License, Version 2.0.
> ${dep.licenses[0].comments}
> Please check this License for acceptability here:
> https://www.apache.org/legal/resolved
> If it is okay, then update the list named 'non_aggregate_fine' in the
> LICENSE.vm file.
> If it isn't okay, then revert the change that added the dependency.
> More info on the dependency:
> com.nimbusds
> nimbus-jose-jwt
> 3.9
> maven central search
> g:com.nimbusds AND a:nimbus-jose-jwt AND v:3.9
> project website
> https://bitbucket.org/connect2id/nimbus-jose-jwt
> project source
> https://bitbucket.org/connect2id/nimbus-jose-jwt
> {code}
> Maybe the problem is just that it says: Apache _Software_ License
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-17893) Allow HBase to build against Hadoop 2.8.0
[
https://issues.apache.org/jira/browse/HBASE-17893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lars Hofhansl updated HBASE-17893:
--
Attachment: 17893.branch-1.3.patch
> Allow HBase to build against Hadoop 2.8.0
> -
>
> Key: HBASE-17893
> URL: https://issues.apache.org/jira/browse/HBASE-17893
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.2.5
>Reporter: Lars Hofhansl
> Fix For: 1.3.2, 1.2.7
>
> Attachments: 17883-1.2-BROKEN.txt, 17893-1.3-backport-rebased.txt,
> 17893-1.3-backport.txt, 17893.branch-1.3.patch
>
>
> {code}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-remote-resources-plugin:1.5:process (default)
> on project hbase-assembly: Error rendering velocity resource. Error invoking
> method 'get(java.lang.Integer)' in java.util.ArrayList at
> META-INF/LICENSE.vm[line 1671, column 8]: InvocationTargetException: Index:
> 0, Size: 0 -> [Help 1]
> {code}
> The in the generated LICENSE.
> {code}
> This product includes Nimbus JOSE+JWT licensed under the The Apache Software
> License, Version 2.0.
> ${dep.licenses[0].comments}
> Please check this License for acceptability here:
> https://www.apache.org/legal/resolved
> If it is okay, then update the list named 'non_aggregate_fine' in the
> LICENSE.vm file.
> If it isn't okay, then revert the change that added the dependency.
> More info on the dependency:
> com.nimbusds
> nimbus-jose-jwt
> 3.9
> maven central search
> g:com.nimbusds AND a:nimbus-jose-jwt AND v:3.9
> project website
> https://bitbucket.org/connect2id/nimbus-jose-jwt
> project source
> https://bitbucket.org/connect2id/nimbus-jose-jwt
> {code}
> Maybe the problem is just that it says: Apache _Software_ License
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-17436) Add facility to provide more information for Other Regions seen on Master UI
[
https://issues.apache.org/jira/browse/HBASE-17436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071745#comment-16071745
]
Hadoop QA commented on HBASE-17436:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
32s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
49s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
53s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
51s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
39s{color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 7m
36s{color} | {color:red} hbase-server in master has 10 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
24s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
38s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 3 line(s) that end in whitespace. Use git
apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
1s{color} | {color:red} The patch 3 line(s) with tabs. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
69m 55s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha3. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 8m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
59s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}230m 45s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
32s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}340m 4s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.master.procedure.TestProcedureAdmin |
| Timed out junit tests |
org.apache.hadoop.hbase.filter.TestFuzzyRowFilterEndToEnd |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.03.0-ce Server=17.03.0-ce Image:yetus/hbase:757bf37 |
| JIRA Issue | HBASE-17436 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12875406/HBASE-17436-v6.patch |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 99125934eaba 4.8.3-std-1 #1 SMP Fri Oct 21 11:15:43 UTC 2016
x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / f1b97a6 |
| Default Java | 1.8.0_131 |
| findbugs | v3.1.0-RC1 |
| findbugs |
https://builds.apache.org/job/PreCommit-HBASE-Build/7456/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html
|
| whitespace |
https://builds.apache.org/job/PreCommit-HBASE-Build/7456/artifact/patchprocess/whitespace-eol.txt
|
|
[jira] [Commented] (HBASE-17908) Upgrade guava
[ https://issues.apache.org/jira/browse/HBASE-17908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071743#comment-16071743 ] stack commented on HBASE-17908: --- .015 Removed mentions of unused (for now) shaded-netty; was messy us up when building on Unix (classloader if I were to guess). > Upgrade guava > - > > Key: HBASE-17908 > URL: https://issues.apache.org/jira/browse/HBASE-17908 > Project: HBase > Issue Type: Sub-task > Components: dependencies >Reporter: Balazs Meszaros >Assignee: stack >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-17908.master.001.patch, > HBASE-17908.master.002.patch, HBASE-17908.master.003.patch, > HBASE-17908.master.004.patch, HBASE-17908.master.005.patch, > HBASE-17908.master.006.patch, HBASE-17908.master.007.patch, > HBASE-17908.master.008.patch, HBASE-17908.master.009.patch, > HBASE-17908.master.010.patch, HBASE-17908.master.011.patch, > HBASE-17908.master.012.patch, HBASE-17908.master.013.patch, > HBASE-17908.master.013.patch, HBASE-17908.master.014.patch, > HBASE-17908.master.015.patch > > > Currently we are using guava 12.0.1, but the latest version is 21.0. > Upgrading guava is always a hassle because it is not always backward > compatible with itself. > Currently I think there are to approaches: > 1. Upgrade guava to the newest version (21.0) and shade it. > 2. Upgrade guava to a version which does not break or builds (15.0). > If we can update it, some dependencies should be removed: > commons-collections, commons-codec, ... -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18295) The result contains the cells across different rows
[
https://issues.apache.org/jira/browse/HBASE-18295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071744#comment-16071744
]
Hadoop QA commented on HBASE-18295:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 2m
29s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
5s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
34s{color} | {color:green} branch-1 passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
36s{color} | {color:green} branch-1 passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
56s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
17s{color} | {color:green} branch-1 passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m
56s{color} | {color:red} hbase-server in branch-1 has 2 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
28s{color} | {color:green} branch-1 passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
39s{color} | {color:green} branch-1 passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
33s{color} | {color:green} the patch passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
35s{color} | {color:green} the patch passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
16m 51s{color} | {color:green} The patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
28s{color} | {color:green} the patch passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
34s{color} | {color:green} the patch passed with JDK v1.7.0_131 {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}105m 59s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
18s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}140m 8s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
hadoop.hbase.master.procedure.TestDeleteNamespaceProcedure |
| | hadoop.hbase.master.procedure.TestCreateNamespaceProcedure |
| | hadoop.hbase.master.procedure.TestDeleteTableProcedure |
| | hadoop.hbase.master.procedure.TestDisableTableProcedure |
| | hadoop.hbase.master.procedure.TestCreateTableProcedure |
| | hadoop.hbase.master.procedure.TestEnableTableProcedure |
| Timed out junit tests |
org.apache.hadoop.hbase.master.procedure.TestModifyTableProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestDeleteColumnFamilyProcedure |
| |
[jira] [Updated] (HBASE-17908) Upgrade guava
[ https://issues.apache.org/jira/browse/HBASE-17908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-17908: -- Attachment: HBASE-17908.master.015.patch > Upgrade guava > - > > Key: HBASE-17908 > URL: https://issues.apache.org/jira/browse/HBASE-17908 > Project: HBase > Issue Type: Sub-task > Components: dependencies >Reporter: Balazs Meszaros >Assignee: stack >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-17908.master.001.patch, > HBASE-17908.master.002.patch, HBASE-17908.master.003.patch, > HBASE-17908.master.004.patch, HBASE-17908.master.005.patch, > HBASE-17908.master.006.patch, HBASE-17908.master.007.patch, > HBASE-17908.master.008.patch, HBASE-17908.master.009.patch, > HBASE-17908.master.010.patch, HBASE-17908.master.011.patch, > HBASE-17908.master.012.patch, HBASE-17908.master.013.patch, > HBASE-17908.master.013.patch, HBASE-17908.master.014.patch, > HBASE-17908.master.015.patch > > > Currently we are using guava 12.0.1, but the latest version is 21.0. > Upgrading guava is always a hassle because it is not always backward > compatible with itself. > Currently I think there are to approaches: > 1. Upgrade guava to the newest version (21.0) and shade it. > 2. Upgrade guava to a version which does not break or builds (15.0). > If we can update it, some dependencies should be removed: > commons-collections, commons-codec, ... -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18241) Change client.Table and client.Admin to not use HTableDescriptor
[
https://issues.apache.org/jira/browse/HBASE-18241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071741#comment-16071741
]
stack commented on HBASE-18241:
---
Excellent. Put above table into release note if you can. +1
> Change client.Table and client.Admin to not use HTableDescriptor
>
>
> Key: HBASE-18241
> URL: https://issues.apache.org/jira/browse/HBASE-18241
> Project: HBase
> Issue Type: Task
>Reporter: Biju Nair
>Assignee: Chia-Ping Tsai
>Priority: Critical
> Fix For: 3.0.0, 2.0.0-alpha-2
>
> Attachments: HBASE-18241.v0.patch, HBASE-18241.v1.patch,
> HBASE-18241.v2.patch, HBASE-18241.v2.patch, HBASE-18241.v3.patch
>
>
> {{HTableDescriptor}} is deprecated and scheduled to be removed in 3.0. But
> [client.Table|https://github.com/apache/hbase/blob/a66d491892514fd4a188d6ca87d6260d8ae46184/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Table.java#L69]
> and
> [client.Admin|https://github.com/apache/hbase/blob/a66d491892514fd4a188d6ca87d6260d8ae46184/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java#L198]
> method {{getTableDescriptor}} returns {{HTableDescriptor}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18264) Update pom plugins
[ https://issues.apache.org/jira/browse/HBASE-18264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18264: -- Attachment: HBASE-18264.master.003.patch Retry. Flakies. > Update pom plugins > -- > > Key: HBASE-18264 > URL: https://issues.apache.org/jira/browse/HBASE-18264 > Project: HBase > Issue Type: Sub-task >Reporter: stack >Assignee: Peter Somogyi > Fix For: 2.0.0, 3.0.0 > > Attachments: HBASE-18264.master.001.patch, > HBASE-18264.master.002.patch, HBASE-18264.master.003.patch, > HBASE-18264.master.003.patch, HBASE-18264.master.003.patch, > HBASE-18264.master.003.patch, HBASE-18264.master.003.patch > > > A bunch are old. Lets update. [~balazs.meszaros] you want to have a go at > this sir? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-17453) add Ping into HBase server for deprecated GetProtocolVersion
[ https://issues.apache.org/jira/browse/HBASE-17453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-17453: -- Resolution: Later Fix Version/s: (was: 1.4.0) (was: 2.0.0) Status: Resolved (was: Patch Available) Resolving as 'later'. Can call a method on the RegionServer service... to see if Connection still up. > add Ping into HBase server for deprecated GetProtocolVersion > > > Key: HBASE-17453 > URL: https://issues.apache.org/jira/browse/HBASE-17453 > Project: HBase > Issue Type: Improvement > Components: regionserver >Affects Versions: 1.2.2 >Reporter: Tianying Chang >Assignee: Tianying Chang >Priority: Minor > Attachments: HBASE-17453-1.2.patch, > HBASE-17453-master-fixWhiteSpace.patch, HBASE-17453-master.patch, > HBASE-17453-master-v1.patch, HBASE-17453-master-v2.patch > > > Our HBase service is hosted in AWS. We saw cases where the connection between > the client (Asynchbase in our case) and server stop working but did not throw > any exception, therefore traffic stuck. So we added a "Ping" feature in > AsyncHBase 1.5 by utilizing the GetProtocolVersion() API provided at RS side, > if no traffic for given time, we send the "Ping", if no response back for > "Ping", we assume the connect is bad and reconnect. > Now we are upgrading cluster from 94 to 1.2. However, GetProtocolVersion() is > deprecated. To be able to support same detect/reconnect feature, we added > Ping() in our internal HBase 1.2 branch, and also patched accordingly in > Asynchbase 1.7. > We would like to open source this feature since it is useful for use case in > AWS environment. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17436) Add facility to provide more information for Other Regions seen on Master UI
[
https://issues.apache.org/jira/browse/HBASE-17436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071697#comment-16071697
]
Ted Yu commented on HBASE-17436:
{code}
+public class RegionStateJsonServlet extends HttpServlet {
{code}
Add javadoc explaining the purpose for the servlet. Add annotation for audience.
{code}
+if (!HttpServer.hasAdministratorAccess(getServletContext(), request,
response))
+ return;
{code}
Either move the 'return' to same line as if or, enclose with curly braces.
{code}
+// querying for a certain table
{code}
Move the above comment into if block below.
{code}
+ if (entry1 == null || entry1.getValue()==null) {
{code}
Did you mean to call .getKey above (value is of type RegionLoad which is not
used in the patch) ?
{code}
+ state = regionState.toString();
+ break;
+ }
{code}
Adjust indentation.
If display layout changes, please attach some screenshots.
Thanks
> Add facility to provide more information for Other Regions seen on Master UI
>
>
> Key: HBASE-17436
> URL: https://issues.apache.org/jira/browse/HBASE-17436
> Project: HBase
> Issue Type: Improvement
>Reporter: Ted Yu
>Assignee: Janos Gub
> Labels: ui, usability
> Fix For: 2.0.0
>
> Attachments: HBASE-17436.patch, HBASE-17436-v2.patch,
> HBASE-17436-v5.patch, HBASE-17436-v6.patch, HBASE-17436-v6.patch,
> HBASE-17779-v3.patch, HBASE-17779-v4.patch, initial.patch, Screen Shot
> 2017-04-24 at 8.43.31 PM.png, Screen Shot 2017-04-26 at 4.39.49 PM.png
>
>
> [~rpednekar] and I were looking at a case where the count displayed under
> Other Regions was high (~1200).
> Since the table page just maintains a count instead of List of region names,
> it is very difficult for user to determine which regions belong to this
> category.
> We should provide facility to provide more details for this category (LOG,
> JMX, etc).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18295) The result contains the cells across different rows
[ https://issues.apache.org/jira/browse/HBASE-18295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18295: --- Status: Patch Available (was: Open) > The result contains the cells across different rows > > > Key: HBASE-18295 > URL: https://issues.apache.org/jira/browse/HBASE-18295 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Blocker > Fix For: 3.0.0, 1.3.2, 2.0.0-alpha-2 > > Attachments: HBASE-18295.branch-1.v0.patch, HBASE-18295.v0.patch, > HBASE-18295.v1.patch > > > From the [flaky > dashboard|https://builds.apache.org/job/HBASE-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html] > If we use the cell which won't be flushed into disk as the top cell to reopen > the scanners, the new top cell will change. If the new top cell is in > different row, the matcher will reset, and then matcher will accept the new > top cell... > The TestStore# testFlushBeforeCompletingScan reproduces the bug. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18295) The result contains the cells across different rows
[ https://issues.apache.org/jira/browse/HBASE-18295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18295: --- Fix Version/s: 1.4.0 > The result contains the cells across different rows > > > Key: HBASE-18295 > URL: https://issues.apache.org/jira/browse/HBASE-18295 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Blocker > Fix For: 3.0.0, 1.4.0, 1.3.2, 2.0.0-alpha-2 > > Attachments: HBASE-18295.branch-1.v0.patch, HBASE-18295.v0.patch, > HBASE-18295.v1.patch > > > From the [flaky > dashboard|https://builds.apache.org/job/HBASE-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html] > If we use the cell which won't be flushed into disk as the top cell to reopen > the scanners, the new top cell will change. If the new top cell is in > different row, the matcher will reset, and then matcher will accept the new > top cell... > The TestStore# testFlushBeforeCompletingScan reproduces the bug. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18295) The result contains the cells across different rows
[ https://issues.apache.org/jira/browse/HBASE-18295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18295: --- Attachment: HBASE-18295.branch-1.v0.patch > The result contains the cells across different rows > > > Key: HBASE-18295 > URL: https://issues.apache.org/jira/browse/HBASE-18295 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Blocker > Fix For: 3.0.0, 1.3.2, 2.0.0-alpha-2 > > Attachments: HBASE-18295.branch-1.v0.patch, HBASE-18295.v0.patch, > HBASE-18295.v1.patch > > > From the [flaky > dashboard|https://builds.apache.org/job/HBASE-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html] > If we use the cell which won't be flushed into disk as the top cell to reopen > the scanners, the new top cell will change. If the new top cell is in > different row, the matcher will reset, and then matcher will accept the new > top cell... > The TestStore# testFlushBeforeCompletingScan reproduces the bug. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18295) The result contains the cells across different rows
[ https://issues.apache.org/jira/browse/HBASE-18295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18295: --- Status: Open (was: Patch Available) v1.patch -- All failed tests pass on my machine. > The result contains the cells across different rows > > > Key: HBASE-18295 > URL: https://issues.apache.org/jira/browse/HBASE-18295 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Blocker > Fix For: 3.0.0, 1.3.2, 2.0.0-alpha-2 > > Attachments: HBASE-18295.branch-1.v0.patch, HBASE-18295.v0.patch, > HBASE-18295.v1.patch > > > From the [flaky > dashboard|https://builds.apache.org/job/HBASE-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html] > If we use the cell which won't be flushed into disk as the top cell to reopen > the scanners, the new top cell will change. If the new top cell is in > different row, the matcher will reset, and then matcher will accept the new > top cell... > The TestStore# testFlushBeforeCompletingScan reproduces the bug. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18295) The result contains the cells across different rows
[
https://issues.apache.org/jira/browse/HBASE-18295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071688#comment-16071688
]
Hadoop QA commented on HBASE-18295:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
14s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
49s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
42s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
53s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
14s{color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m
39s{color} | {color:red} hbase-server in master has 10 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
28s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
31m 18s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha3. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
29s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}115m 24s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
19s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}162m 7s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:757bf37 |
| JIRA Issue | HBASE-18295 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12875409/HBASE-18295.v1.patch |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 7907b7f73829 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / f1b97a6 |
| Default Java | 1.8.0_131 |
| findbugs | v3.1.0-RC1 |
| findbugs |
https://builds.apache.org/job/PreCommit-HBASE-Build/7457/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/7457/artifact/patchprocess/patch-unit-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/7457/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/7457/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> The result contains the cells across different rows
>
>
> Key: HBASE-18295
> URL:
[jira] [Commented] (HBASE-18264) Update pom plugins
[
https://issues.apache.org/jira/browse/HBASE-18264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071684#comment-16071684
]
Hadoop QA commented on HBASE-18264:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
24s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
30s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
7s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 22m
38s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 14m
27s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 18m
33s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
55s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 23m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 21m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 21m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 11m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 1m
4s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
66m 42s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha3. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 15m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 4m
20s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
17s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
22s{color} | {color:green} hbase-metrics-api in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 4m
42s{color} | {color:green} hbase-procedure in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
48s{color} | {color:green} hbase-hadoop-compat in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
31s{color} | {color:green} hbase-metrics in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
58s{color} | {color:green} hbase-hadoop2-compat in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
43s{color} | {color:green} hbase-protocol in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 4m
27s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
3s{color} | {color:green} hbase-prefix-tree in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}298m 27s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
20s{color} | {color:green} hbase-thrift in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
48s{color} | {color:green} hbase-rsgroup in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 7m
55s{color} | {color:green} hbase-shell in the patch passed.
[jira] [Updated] (HBASE-18241) Change client.Table and client.Admin to not use HTableDescriptor
[
https://issues.apache.org/jira/browse/HBASE-18241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated HBASE-18241:
---
Attachment: HBASE-18241.v3.patch
> Change client.Table and client.Admin to not use HTableDescriptor
>
>
> Key: HBASE-18241
> URL: https://issues.apache.org/jira/browse/HBASE-18241
> Project: HBase
> Issue Type: Task
>Reporter: Biju Nair
>Assignee: Chia-Ping Tsai
>Priority: Critical
> Fix For: 3.0.0, 2.0.0-alpha-2
>
> Attachments: HBASE-18241.v0.patch, HBASE-18241.v1.patch,
> HBASE-18241.v2.patch, HBASE-18241.v2.patch, HBASE-18241.v3.patch
>
>
> {{HTableDescriptor}} is deprecated and scheduled to be removed in 3.0. But
> [client.Table|https://github.com/apache/hbase/blob/a66d491892514fd4a188d6ca87d6260d8ae46184/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Table.java#L69]
> and
> [client.Admin|https://github.com/apache/hbase/blob/a66d491892514fd4a188d6ca87d6260d8ae46184/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java#L198]
> method {{getTableDescriptor}} returns {{HTableDescriptor}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18241) Change client.Table and client.Admin to not use HTableDescriptor
[
https://issues.apache.org/jira/browse/HBASE-18241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated HBASE-18241:
---
Status: Patch Available (was: Open)
> Change client.Table and client.Admin to not use HTableDescriptor
>
>
> Key: HBASE-18241
> URL: https://issues.apache.org/jira/browse/HBASE-18241
> Project: HBase
> Issue Type: Task
>Reporter: Biju Nair
>Assignee: Chia-Ping Tsai
>Priority: Critical
> Fix For: 3.0.0, 2.0.0-alpha-2
>
> Attachments: HBASE-18241.v0.patch, HBASE-18241.v1.patch,
> HBASE-18241.v2.patch, HBASE-18241.v2.patch, HBASE-18241.v3.patch
>
>
> {{HTableDescriptor}} is deprecated and scheduled to be removed in 3.0. But
> [client.Table|https://github.com/apache/hbase/blob/a66d491892514fd4a188d6ca87d6260d8ae46184/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Table.java#L69]
> and
> [client.Admin|https://github.com/apache/hbase/blob/a66d491892514fd4a188d6ca87d6260d8ae46184/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java#L198]
> method {{getTableDescriptor}} returns {{HTableDescriptor}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18241) Change client.Table and client.Admin to not use HTableDescriptor
[
https://issues.apache.org/jira/browse/HBASE-18241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071677#comment-16071677
]
Chia-Ping Tsai commented on HBASE-18241:
v3.patch
There are plenty of changes as Region#getTableDesc() and Store#getFamily() are
often used in code base.
--
*Region class*
||*Previous API*||*New API*||
|HTableDescriptor getTableDesc()|TableDescriptor getTableDescriptor()|
*Store class*
||*Previous API*||*New API*||
|HColumnDescriptor getFamily()|ColumnFamilyDescriptor getDescriptor()|
*Table class*
||*Deprecated API*||*New API*||
|HTableDescriptor getTableDescriptor()|TableDescriptor getDescriptor()|
*Admin class*
||*Deprecated API*||*New API*||
|HTableDescriptor getTableDescriptor(TableName)|List
listTableDescriptor(TableName)|
|HTableDescriptor[] getTableDescriptors(List)|N/A|
|HTableDescriptor[]
getTableDescriptorsByTableName(List)|List
listTableDescriptors(List)|
|HTableDescriptor[] listTables()|List listTableDescriptors()|
|HTableDescriptor[] listTables(Pattern)|List
listTableDescriptors(Pattern)|
|HTableDescriptor[] listTables(String)|List
listTableDescriptors(String)|
|HTableDescriptor[] listTables(Pattern, boolean)|List
listTableDescriptors(Pattern, boolean)|
|HTableDescriptor[] listTables(String, boolean)|List
listTableDescriptors(String, boolean)|
|HTableDescriptor[] deleteTables(String)|N/A|
|HTableDescriptor[] deleteTables(Pattern)|N/A|
|HTableDescriptor[] enableTables(String)|N/A|
|HTableDescriptor[] enableTables(Pattern)|N/A|
|HTableDescriptor[] disableTables(String)|N/A|
|HTableDescriptor[] disableTables(Pattern)|N/A|
|void modifyTable(TableName, HTableDescriptor)|void
modifyTable(TableDescriptor)|
|void modifyTableAsync(TableName, HTableDescriptor)|void
modifyTableAsync(TableDescriptor)|
|HTableDescriptor[]
listTableDescriptorsByNamespace(String)|List
listTableDescriptorsByNamespace(byte[])|
||*Previous API*||*New API*||
|void createTable({color:red}HTableDescriptor{color})|void
createTable({color:red}TableDescriptor{color})|
|void createTable({color:red}HTableDescriptor{color}, byte[], byte[], int)|void
createTable({color:red}TableDescriptor{color}, byte[], byte[], int)|
|void createTable({color:red}HTableDescriptor{color}, byte[][])|void
createTable({color:red}TableDescriptor{color}, byte[][])|
|Future createTableAsync({color:red}HTableDescriptor{color},
byte[][])|Future createTableAsync({color:red}TableDescriptor{color},
byte[][])|
> Change client.Table and client.Admin to not use HTableDescriptor
>
>
> Key: HBASE-18241
> URL: https://issues.apache.org/jira/browse/HBASE-18241
> Project: HBase
> Issue Type: Task
>Reporter: Biju Nair
>Assignee: Chia-Ping Tsai
>Priority: Critical
> Fix For: 3.0.0, 2.0.0-alpha-2
>
> Attachments: HBASE-18241.v0.patch, HBASE-18241.v1.patch,
> HBASE-18241.v2.patch, HBASE-18241.v2.patch
>
>
> {{HTableDescriptor}} is deprecated and scheduled to be removed in 3.0. But
> [client.Table|https://github.com/apache/hbase/blob/a66d491892514fd4a188d6ca87d6260d8ae46184/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Table.java#L69]
> and
> [client.Admin|https://github.com/apache/hbase/blob/a66d491892514fd4a188d6ca87d6260d8ae46184/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java#L198]
> method {{getTableDescriptor}} returns {{HTableDescriptor}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18241) Change client.Table and client.Admin to not use HTableDescriptor
[
https://issues.apache.org/jira/browse/HBASE-18241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated HBASE-18241:
---
Status: Open (was: Patch Available)
> Change client.Table and client.Admin to not use HTableDescriptor
>
>
> Key: HBASE-18241
> URL: https://issues.apache.org/jira/browse/HBASE-18241
> Project: HBase
> Issue Type: Task
>Reporter: Biju Nair
>Assignee: Chia-Ping Tsai
>Priority: Critical
> Fix For: 3.0.0, 2.0.0-alpha-2
>
> Attachments: HBASE-18241.v0.patch, HBASE-18241.v1.patch,
> HBASE-18241.v2.patch, HBASE-18241.v2.patch
>
>
> {{HTableDescriptor}} is deprecated and scheduled to be removed in 3.0. But
> [client.Table|https://github.com/apache/hbase/blob/a66d491892514fd4a188d6ca87d6260d8ae46184/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Table.java#L69]
> and
> [client.Admin|https://github.com/apache/hbase/blob/a66d491892514fd4a188d6ca87d6260d8ae46184/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java#L198]
> method {{getTableDescriptor}} returns {{HTableDescriptor}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18295) The result contains the cells across different rows
[ https://issues.apache.org/jira/browse/HBASE-18295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071655#comment-16071655 ] Ted Yu commented on HBASE-18295: TestStore passes. lgtm > The result contains the cells across different rows > > > Key: HBASE-18295 > URL: https://issues.apache.org/jira/browse/HBASE-18295 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Blocker > Fix For: 3.0.0, 1.3.2, 2.0.0-alpha-2 > > Attachments: HBASE-18295.v0.patch, HBASE-18295.v1.patch > > > From the [flaky > dashboard|https://builds.apache.org/job/HBASE-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html] > If we use the cell which won't be flushed into disk as the top cell to reopen > the scanners, the new top cell will change. If the new top cell is in > different row, the matcher will reset, and then matcher will accept the new > top cell... > The TestStore# testFlushBeforeCompletingScan reproduces the bug. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18283) Provide a construct method which accept a thread pool for AsyncAdmin
[ https://issues.apache.org/jira/browse/HBASE-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-18283: --- Attachment: HBASE-18283.master.003.patch > Provide a construct method which accept a thread pool for AsyncAdmin > > > Key: HBASE-18283 > URL: https://issues.apache.org/jira/browse/HBASE-18283 > Project: HBase > Issue Type: Sub-task > Components: Client >Affects Versions: 3.0.0, 2.0.0-alpha-2 >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Fix For: 2.0.0, 3.0.0 > > Attachments: HBASE-18283.master.001.patch, > HBASE-18283.master.002.patch, HBASE-18283.master.003.patch > > > Similar to AsyncTable, provide a construct method which accept a thread pool > for normal user. User need provide a thread pool to get a AsyncAdmin > instance. Then the callbacks registered to the returned CompletableFuture can > be executed in that thread pool. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-9969) Improve KeyValueHeap using loser tree
[ https://issues.apache.org/jira/browse/HBASE-9969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071624#comment-16071624 ] Lars Hofhansl commented on HBASE-9969: -- I always felt that a class as core to HBase as this should not be based on the JDK's PriorityQueue, but be rather implemented directly. Matt's patch does that, and it seems that his custom priority queue beats the JDK's in every case. > Improve KeyValueHeap using loser tree > - > > Key: HBASE-9969 > URL: https://issues.apache.org/jira/browse/HBASE-9969 > Project: HBase > Issue Type: Improvement > Components: Performance, regionserver >Reporter: Chao Shi >Assignee: Chao Shi > Attachments: 9969-0.94.txt, hbase-9969.patch, hbase-9969.patch, > hbase-9969-pq-v1.patch, hbase-9969-pq-v2.patch, hbase-9969-v2.patch, > hbase-9969-v3.patch, KeyValueHeapBenchmark_v1.ods, > KeyValueHeapBenchmark_v2.ods, kvheap-benchmark.png, kvheap-benchmark.txt > > > LoserTree is the better data structure than binary heap. It saves half of the > comparisons on each next(), though the time complexity is on O(logN). > Currently A scan or get will go through two KeyValueHeaps, one is merging KVs > read from multiple HFiles in a single store, the other is merging results > from multiple stores. This patch should improve the both cases whenever CPU > is the bottleneck (e.g. scan with filter over cached blocks, HBASE-9811). > All of the optimization work is done in KeyValueHeap and does not change its > public interfaces. The new code looks more cleaner and simpler to understand. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18295) The result contains the cells across different rows
[ https://issues.apache.org/jira/browse/HBASE-18295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18295: --- Attachment: HBASE-18295.v1.patch v1 for master -- # all failed tests pass on my local # move out the log from the if block (Ted's comment) > The result contains the cells across different rows > > > Key: HBASE-18295 > URL: https://issues.apache.org/jira/browse/HBASE-18295 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Blocker > Fix For: 3.0.0, 1.3.2, 2.0.0-alpha-2 > > Attachments: HBASE-18295.v0.patch, HBASE-18295.v1.patch > > > From the [flaky > dashboard|https://builds.apache.org/job/HBASE-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html] > If we use the cell which won't be flushed into disk as the top cell to reopen > the scanners, the new top cell will change. If the new top cell is in > different row, the matcher will reset, and then matcher will accept the new > top cell... > The TestStore# testFlushBeforeCompletingScan reproduces the bug. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18295) The result contains the cells across different rows
[ https://issues.apache.org/jira/browse/HBASE-18295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18295: --- Status: Patch Available (was: Open) > The result contains the cells across different rows > > > Key: HBASE-18295 > URL: https://issues.apache.org/jira/browse/HBASE-18295 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Blocker > Fix For: 3.0.0, 1.3.2, 2.0.0-alpha-2 > > Attachments: HBASE-18295.v0.patch, HBASE-18295.v1.patch > > > From the [flaky > dashboard|https://builds.apache.org/job/HBASE-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html] > If we use the cell which won't be flushed into disk as the top cell to reopen > the scanners, the new top cell will change. If the new top cell is in > different row, the matcher will reset, and then matcher will accept the new > top cell... > The TestStore# testFlushBeforeCompletingScan reproduces the bug. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18295) The result contains the cells across different rows
[ https://issues.apache.org/jira/browse/HBASE-18295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18295: --- Status: Open (was: Patch Available) > The result contains the cells across different rows > > > Key: HBASE-18295 > URL: https://issues.apache.org/jira/browse/HBASE-18295 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Blocker > Fix For: 3.0.0, 1.3.2, 2.0.0-alpha-2 > > Attachments: HBASE-18295.v0.patch > > > From the [flaky > dashboard|https://builds.apache.org/job/HBASE-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html] > If we use the cell which won't be flushed into disk as the top cell to reopen > the scanners, the new top cell will change. If the new top cell is in > different row, the matcher will reset, and then matcher will accept the new > top cell... > The TestStore# testFlushBeforeCompletingScan reproduces the bug. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-17436) Add facility to provide more information for Other Regions seen on Master UI
[ https://issues.apache.org/jira/browse/HBASE-17436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Janos Gub updated HBASE-17436: -- Attachment: HBASE-17436-v6.patch > Add facility to provide more information for Other Regions seen on Master UI > > > Key: HBASE-17436 > URL: https://issues.apache.org/jira/browse/HBASE-17436 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Janos Gub > Labels: ui, usability > Fix For: 2.0.0 > > Attachments: HBASE-17436.patch, HBASE-17436-v2.patch, > HBASE-17436-v5.patch, HBASE-17436-v6.patch, HBASE-17436-v6.patch, > HBASE-17779-v3.patch, HBASE-17779-v4.patch, initial.patch, Screen Shot > 2017-04-24 at 8.43.31 PM.png, Screen Shot 2017-04-26 at 4.39.49 PM.png > > > [~rpednekar] and I were looking at a case where the count displayed under > Other Regions was high (~1200). > Since the table page just maintains a count instead of List of region names, > it is very difficult for user to determine which regions belong to this > category. > We should provide facility to provide more details for this category (LOG, > JMX, etc). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17436) Add facility to provide more information for Other Regions seen on Master UI
[
https://issues.apache.org/jira/browse/HBASE-17436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071609#comment-16071609
]
Hadoop QA commented on HBASE-17436:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
20s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
54s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
17s{color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 3m
5s{color} | {color:red} hbase-server in master has 10 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
33s{color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
25s{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
28s{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 28s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
15s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 3 line(s) that end in whitespace. Use git
apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch 3 line(s) with tabs. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 1m
30s{color} | {color:red} The patch causes 28 errors with Hadoop v2.6.1. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 2m
52s{color} | {color:red} The patch causes 28 errors with Hadoop v2.6.2. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 4m
11s{color} | {color:red} The patch causes 28 errors with Hadoop v2.6.3. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 5m
29s{color} | {color:red} The patch causes 28 errors with Hadoop v2.6.4. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 6m
40s{color} | {color:red} The patch causes 28 errors with Hadoop v2.6.5. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 7m
50s{color} | {color:red} The patch causes 28 errors with Hadoop v2.7.1. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 9m
0s{color} | {color:red} The patch causes 28 errors with Hadoop v2.7.2. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 10m
9s{color} | {color:red} The patch causes 28 errors with Hadoop v2.7.3. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 11m
17s{color} | {color:red} The patch causes 28 errors with Hadoop v3.0.0-alpha3.
{color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
22s{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
29s{color} | {color:red} hbase-server generated 2 new + 0 unchanged - 0 fixed =
2 total (was 0) {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 27s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
9s{color} | {color:green} The patch does not generate
[jira] [Commented] (HBASE-18295) The result contains the cells across different rows
[
https://issues.apache.org/jira/browse/HBASE-18295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071607#comment-16071607
]
Hadoop QA commented on HBASE-18295:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
23s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
42s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
45s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
37s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
39s{color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 7m
17s{color} | {color:red} hbase-server in master has 10 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
13s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
65m 54s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha3. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
0s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}145m 43s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 2m
19s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}248m 53s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.regionserver.TestRegionReplicaFailover |
| | hadoop.hbase.regionserver.TestPerColumnFamilyFlush |
| | hadoop.hbase.coprocessor.TestRegionObserverInterface |
| | hadoop.hbase.regionserver.TestRegionMergeTransactionOnCluster |
| Timed out junit tests |
org.apache.hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint
|
| | org.apache.hadoop.hbase.replication.regionserver.TestWALEntryStream |
| | org.apache.hadoop.hbase.TestIOFencing |
| | org.apache.hadoop.hbase.replication.TestMultiSlaveReplication |
| | org.apache.hadoop.hbase.filter.TestFuzzyRowFilterEndToEnd |
| | org.apache.hadoop.hbase.replication.TestSerialReplication |
| | org.apache.hadoop.hbase.replication.TestMasterReplication |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.03.0-ce Server=17.03.0-ce Image:yetus/hbase:757bf37 |
| JIRA Issue | HBASE-18295 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12875401/HBASE-18295.v0.patch |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux b979ee189a8c 4.8.3-std-1 #1 SMP Fri Oct 21 11:15:43 UTC 2016
x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / f1b97a6 |
| Default Java | 1.8.0_131 |
| findbugs | v3.1.0-RC1
[jira] [Updated] (HBASE-17436) Add facility to provide more information for Other Regions seen on Master UI
[ https://issues.apache.org/jira/browse/HBASE-17436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Janos Gub updated HBASE-17436: -- Status: Patch Available (was: Open) > Add facility to provide more information for Other Regions seen on Master UI > > > Key: HBASE-17436 > URL: https://issues.apache.org/jira/browse/HBASE-17436 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Janos Gub > Labels: ui, usability > Fix For: 2.0.0 > > Attachments: HBASE-17436.patch, HBASE-17436-v2.patch, > HBASE-17436-v5.patch, HBASE-17436-v6.patch, HBASE-17779-v3.patch, > HBASE-17779-v4.patch, initial.patch, Screen Shot 2017-04-24 at 8.43.31 > PM.png, Screen Shot 2017-04-26 at 4.39.49 PM.png > > > [~rpednekar] and I were looking at a case where the count displayed under > Other Regions was high (~1200). > Since the table page just maintains a count instead of List of region names, > it is very difficult for user to determine which regions belong to this > category. > We should provide facility to provide more details for this category (LOG, > JMX, etc). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-17436) Add facility to provide more information for Other Regions seen on Master UI
[ https://issues.apache.org/jira/browse/HBASE-17436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Janos Gub updated HBASE-17436: -- Attachment: HBASE-17436-v6.patch Attaching new patch. Also included a new servlet for dumping region states as json. > Add facility to provide more information for Other Regions seen on Master UI > > > Key: HBASE-17436 > URL: https://issues.apache.org/jira/browse/HBASE-17436 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Janos Gub > Labels: ui, usability > Fix For: 2.0.0 > > Attachments: HBASE-17436.patch, HBASE-17436-v2.patch, > HBASE-17436-v5.patch, HBASE-17436-v6.patch, HBASE-17779-v3.patch, > HBASE-17779-v4.patch, initial.patch, Screen Shot 2017-04-24 at 8.43.31 > PM.png, Screen Shot 2017-04-26 at 4.39.49 PM.png > > > [~rpednekar] and I were looking at a case where the count displayed under > Other Regions was high (~1200). > Since the table page just maintains a count instead of List of region names, > it is very difficult for user to determine which regions belong to this > category. > We should provide facility to provide more details for this category (LOG, > JMX, etc). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18294) Flush is based on data size instead of heap size
[ https://issues.apache.org/jira/browse/HBASE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071594#comment-16071594 ] Eshcar Hillel commented on HBASE-18294: --- Considering heap size for triggering global heap pressure reduction is fine, however, we expect the system to get to this point rarely. As you mention in your document disregarding heap size can cause blocking, excessive GC and even OOME. Following HBASE-16747 there are 3 cases where considering data size and not heap size (1) when choosing biggest region to flush following global heap pressure (2) when choosing large stores to flush within the region (3) when deciding to trigger region level flush (exceeding the 128MB threshold). Lets consider the on-heap scenario first: For (1)+(2) it is already decided that there is a flush and now we are looking to choose biggest memory consumers (biggest region/largest store). Therefore we should compare heap size. Otherwise, we may choose a smaller region/store simply because its data is bigger but it may actually take less heap space. For (3) the configurable threshold gives the admin a way to compute how many regions the RS can handle with a given memory. That was documented in blogs etc. Now with the change we actually have no way to predict what is the maximum memory size of a region. This may come as a surprise to some admins. bq. For the off heap based memstores also the data size alone based region flush is better. bq. Offheap memstores need this change so that we are able to decide the region flush based on data size alone as the whole data is offheap. Then lets make a different policy for off-heap cases. Enforcing the same policy for on/off-heap doesn't seem to be optimal for both. I suggest to make different policies for on-heap data (to consider heap size in all the cases above), and off-heap that considers heap/data size any way you think is best for off-heap. > Flush is based on data size instead of heap size > > > Key: HBASE-18294 > URL: https://issues.apache.org/jira/browse/HBASE-18294 > Project: HBase > Issue Type: Bug >Reporter: Eshcar Hillel >Assignee: Eshcar Hillel > > A region is flushed if its memory component exceed a threshold (default size > is 128MB). > A flush policy decides whether to flush a store by comparing the size of the > store to another threshold (that can be configured with > hbase.hregion.percolumnfamilyflush.size.lower.bound). > Currently the implementation (in both cases) compares the data size > (key-value only) to the threshold where it should compare the heap size > (which includes index size, and metadata). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18010) Connect CellChunkMap to be used for flattening in CompactingMemStore
[ https://issues.apache.org/jira/browse/HBASE-18010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071583#comment-16071583 ] Anastasia Braginsky commented on HBASE-18010: - I can not recreate the failures on my machines, I believe they are not related to the new code. Also findbugs issues are not on the files that were changed by this patch. I will wait, rebase and retry to submit the patch. In the meanwhile [~anoop.hbase], [~ram_krish], [~stack], [~eshcar], you are welcome to review and comment on the recent patch on the RB. So the process of commit will be faster, once it passes QA. > Connect CellChunkMap to be used for flattening in CompactingMemStore > > > Key: HBASE-18010 > URL: https://issues.apache.org/jira/browse/HBASE-18010 > Project: HBase > Issue Type: Sub-task >Reporter: Anastasia Braginsky >Assignee: Anastasia Braginsky > Attachments: HBASE-18010-V04.patch, HBASE-18010-V06.patch, > HBASE-18010-V07.patch, HBASE-18010-V08.patch, HBASE-18010-V09.patch, > HBASE-18010-V10.patch > > > The CellChunkMap helps to create a new type of ImmutableSegment, where the > index (CellSet's delegatee) is going to be CellChunkMap. No big cells or > upserted cells are going to be supported here. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18295) The result contains the cells across different rows
[ https://issues.apache.org/jira/browse/HBASE-18295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071548#comment-16071548 ] Chia-Ping Tsai commented on HBASE-18295: bq. You changed one debug log to info but the log statement is in if block. Thanks for the reviews! > The result contains the cells across different rows > > > Key: HBASE-18295 > URL: https://issues.apache.org/jira/browse/HBASE-18295 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Blocker > Fix For: 3.0.0, 1.3.2, 2.0.0-alpha-2 > > Attachments: HBASE-18295.v0.patch > > > From the [flaky > dashboard|https://builds.apache.org/job/HBASE-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html] > If we use the cell which won't be flushed into disk as the top cell to reopen > the scanners, the new top cell will change. If the new top cell is in > different row, the matcher will reset, and then matcher will accept the new > top cell... > The TestStore# testFlushBeforeCompletingScan reproduces the bug. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18295) The result contains the cells across different rows
[ https://issues.apache.org/jira/browse/HBASE-18295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071547#comment-16071547 ] Ted Yu commented on HBASE-18295: Nice discovery. Nit: You changed one debug log to info but the log statement is in if block. > The result contains the cells across different rows > > > Key: HBASE-18295 > URL: https://issues.apache.org/jira/browse/HBASE-18295 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Blocker > Fix For: 3.0.0, 1.3.2, 2.0.0-alpha-2 > > Attachments: HBASE-18295.v0.patch > > > From the [flaky > dashboard|https://builds.apache.org/job/HBASE-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html] > If we use the cell which won't be flushed into disk as the top cell to reopen > the scanners, the new top cell will change. If the new top cell is in > different row, the matcher will reset, and then matcher will accept the new > top cell... > The TestStore# testFlushBeforeCompletingScan reproduces the bug. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-16730) Exclude junit as a transitive dependency from hadoop-common
[
https://issues.apache.org/jira/browse/HBASE-16730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071542#comment-16071542
]
Hadoop QA commented on HBASE-16730:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
12s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
13s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
5s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
37s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
34s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
16s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
12s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 3m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
3s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
28m 32s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha3. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 4m
40s{color} | {color:green} hbase-spark in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}125m 43s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
42s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}182m 28s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
hadoop.hbase.master.procedure.TestMasterProcedureWalLease |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:757bf37 |
| JIRA Issue | HBASE-16730 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12875398/HBASE-16730.master.002.patch
|
| Optional Tests | asflicense javac javadoc unit xml compile |
| uname | Linux 0f8447ac408f 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12
13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / f1b97a6 |
| Default Java | 1.8.0_131 |
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/7452/artifact/patchprocess/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/7452/testReport/ |
| modules | C: hbase-spark . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/7452/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> Exclude junit as a transitive dependency from hadoop-common
> ---
>
> Key: HBASE-16730
> URL: https://issues.apache.org/jira/browse/HBASE-16730
> Project: HBase
> Issue Type: Improvement
> Components:
[jira] [Commented] (HBASE-18283) Provide a construct method which accept a thread pool for AsyncAdmin
[ https://issues.apache.org/jira/browse/HBASE-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071541#comment-16071541 ] Guanghao Zhang commented on HBASE-18283: The failed ut was related. Let me fix them. Thanks. > Provide a construct method which accept a thread pool for AsyncAdmin > > > Key: HBASE-18283 > URL: https://issues.apache.org/jira/browse/HBASE-18283 > Project: HBase > Issue Type: Sub-task > Components: Client >Affects Versions: 3.0.0, 2.0.0-alpha-2 >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Fix For: 2.0.0, 3.0.0 > > Attachments: HBASE-18283.master.001.patch, > HBASE-18283.master.002.patch > > > Similar to AsyncTable, provide a construct method which accept a thread pool > for normal user. User need provide a thread pool to get a AsyncAdmin > instance. Then the callbacks registered to the returned CompletableFuture can > be executed in that thread pool. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18295) The result contains the cells across different rows
[ https://issues.apache.org/jira/browse/HBASE-18295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18295: --- Attachment: HBASE-18295.v0.patch > The result contains the cells across different rows > > > Key: HBASE-18295 > URL: https://issues.apache.org/jira/browse/HBASE-18295 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Blocker > Fix For: 3.0.0, 1.3.2, 2.0.0-alpha-2 > > Attachments: HBASE-18295.v0.patch > > > From the [flaky > dashboard|https://builds.apache.org/job/HBASE-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html] > If we use the cell which won't be flushed into disk as the top cell to reopen > the scanners, the new top cell will change. If the new top cell is in > different row, the matcher will reset, and then matcher will accept the new > top cell... > The TestStore# testFlushBeforeCompletingScan reproduces the bug. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18295) The result contains the cells across different rows
[ https://issues.apache.org/jira/browse/HBASE-18295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18295: --- Fix Version/s: 1.3.2 > The result contains the cells across different rows > > > Key: HBASE-18295 > URL: https://issues.apache.org/jira/browse/HBASE-18295 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Blocker > Fix For: 3.0.0, 1.3.2, 2.0.0-alpha-2 > > Attachments: HBASE-18295.v0.patch > > > From the [flaky > dashboard|https://builds.apache.org/job/HBASE-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html] > If we use the cell which won't be flushed into disk as the top cell to reopen > the scanners, the new top cell will change. If the new top cell is in > different row, the matcher will reset, and then matcher will accept the new > top cell... > The TestStore# testFlushBeforeCompletingScan reproduces the bug. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18295) The result contains the cells across different rows
[ https://issues.apache.org/jira/browse/HBASE-18295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18295: --- Description: >From the [flaky >dashboard|https://builds.apache.org/job/HBASE-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html] If we use the cell which won't be flushed into disk as the top cell to reopen the scanners, the new top cell will change. If the new top cell is in different row, the matcher will reset, and then matcher will accept the new top cell... The TestStore# testFlushBeforeCompletingScan reproduces the bug. was:From the [flaky dashboard|https://builds.apache.org/job/HBASE-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html] > The result contains the cells across different rows > > > Key: HBASE-18295 > URL: https://issues.apache.org/jira/browse/HBASE-18295 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Blocker > Fix For: 3.0.0, 1.3.2, 2.0.0-alpha-2 > > Attachments: HBASE-18295.v0.patch > > > From the [flaky > dashboard|https://builds.apache.org/job/HBASE-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html] > If we use the cell which won't be flushed into disk as the top cell to reopen > the scanners, the new top cell will change. If the new top cell is in > different row, the matcher will reset, and then matcher will accept the new > top cell... > The TestStore# testFlushBeforeCompletingScan reproduces the bug. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18295) The result contains the cells across different rows
[ https://issues.apache.org/jira/browse/HBASE-18295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18295: --- Status: Patch Available (was: Open) > The result contains the cells across different rows > > > Key: HBASE-18295 > URL: https://issues.apache.org/jira/browse/HBASE-18295 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Blocker > Fix For: 3.0.0, 1.3.2, 2.0.0-alpha-2 > > Attachments: HBASE-18295.v0.patch > > > From the [flaky > dashboard|https://builds.apache.org/job/HBASE-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html] > If we use the cell which won't be flushed into disk as the top cell to reopen > the scanners, the new top cell will change. If the new top cell is in > different row, the matcher will reset, and then matcher will accept the new > top cell... > The TestStore# testFlushBeforeCompletingScan reproduces the bug. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17908) Upgrade guava
[
https://issues.apache.org/jira/browse/HBASE-17908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071536#comment-16071536
]
Hadoop QA commented on HBASE-17908:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
42s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:red}-1{color} | {color:red} @author {color} | {color:red} 0m
0s{color} | {color:red} The patch appears to contain 5 @author tags which the
community has agreed to not allow in code contributions. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 210 new or modified
test files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
40s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
36s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 23m
53s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 17m
3s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 13m
34s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hbase-testing-util hbase-assembly . {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m
14s{color} | {color:red} hbase-common in master has 2 extant Findbugs warnings.
{color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 5m
48s{color} | {color:red} hbase-protocol-shaded in master has 27 extant Findbugs
warnings. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m
27s{color} | {color:red} hbase-client in master has 4 extant Findbugs warnings.
{color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 7m
23s{color} | {color:red} hbase-server in master has 10 extant Findbugs
warnings. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
56s{color} | {color:red} hbase-examples in master has 2 extant Findbugs
warnings. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m
19s{color} | {color:red} hbase-rest in master has 3 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 15m
9s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
33s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
50s{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 1m
33s{color} | {color:red} hbase-spark in the patch failed. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 20m
37s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 1m 21s{color}
| {color:red} hbase-protocol-shaded generated 4 new + 6 unchanged - 2 fixed =
10 total (was 8) {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 6m 31s{color}
| {color:red} root generated 4 new + 38 unchanged - 2 fixed = 42 total (was 40)
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 14m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 11m
7s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 6 line(s) that end in whitespace. Use git
apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 1m
8s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
79m 16s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha3. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hbase-testing-util hbase-assembly . {color} |
[jira] [Commented] (HBASE-18264) Update pom plugins
[
https://issues.apache.org/jira/browse/HBASE-18264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071529#comment-16071529
]
Hadoop QA commented on HBASE-18264:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
23s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
34s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
7s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 13m
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 8m
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 9m
33s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
35s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 12m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 11m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
17s{color} | {color:green} hbase-common generated 0 new + 26 unchanged - 26
fixed = 26 total (was 52) {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
38s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
11s{color} | {color:green} hbase-metrics-api in the patch passed. {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
13s{color} | {color:green} hbase-procedure in the patch passed. {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
10s{color} | {color:green} hbase-hadoop-compat in the patch passed. {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
10s{color} | {color:green} hbase-metrics in the patch passed. {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
12s{color} | {color:green} hbase-hadoop2-compat in the patch passed. {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
21s{color} | {color:green} hbase-protocol in the patch passed. {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
20s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
12s{color} | {color:green} hbase-prefix-tree in the patch passed. {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
45s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
23s{color} | {color:green} hbase-thrift in the patch passed. {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
17s{color} | {color:green} hbase-rsgroup in the patch passed. {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
15s{color} | {color:green} hbase-shell in the patch passed. {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
17s{color} | {color:green} hbase-endpoint in the patch passed. {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
19s{color} | {color:green} hbase-it in the patch passed. {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
16s{color} | {color:green} hbase-examples in the patch passed. {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
19s{color} | {color:green} hbase-rest in the patch passed. {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
13s{color} | {color:green} hbase-external-blockcache in the patch passed.
{color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
3s{color} | {color:green}
