[jira] [Commented] (HBASE-18899) Make Fileinfo more readable in HFilePrettyPrinter

2017-10-07 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195959#comment-16195959
 ] 

Hudson commented on HBASE-18899:


FAILURE: Integrated in Jenkins build HBase-2.0 #645 (See 
[https://builds.apache.org/job/HBase-2.0/645/])
HBASE-18899 Make Fileinfo more readable in HFilePrettyPrinter (chia7712: rev 
9ae2750588594a8d02e63d8e1f61967314b0)
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java


> Make Fileinfo more readable in HFilePrettyPrinter
> -
>
> Key: HBASE-18899
> URL: https://issues.apache.org/jira/browse/HBASE-18899
> Project: HBase
>  Issue Type: Improvement
>  Components: HFile
>Affects Versions: 3.0.0, 1.5.0, 2.0.0-alpha-4
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-18899.master.v1.patch, 
> HBASE-18899.master.v2.patch, HBASE-18899.patch
>
>
> Fileinfo as follows. some fields can print  readable values.
> {code}
> Fileinfo:
> BLOOM_FILTER_TYPE = ROW
> DELETE_FAMILY_COUNT = \x00\x00\x00\x00\x00\x00\x00\x00
> EARLIEST_PUT_TS = \x00\x00\x01^Q\xF6\x0E\xCF
> KEY_VALUE_VERSION = \x00\x00\x00\x01
> LAST_BLOOM_KEY = f
> MAJOR_COMPACTION_KEY = \xFF
> MAX_MEMSTORE_TS_KEY = \x00\x00\x00\x00\x00\x00\x00\x18
> MAX_SEQ_ID_KEY = 27
> TIMERANGE = 15046136337431506570582061
> hfile.AVG_KEY_LEN = 14
> hfile.AVG_VALUE_LEN = 3
> hfile.CREATE_TIME_TS = \x00\x00\x01^\xC6\xB4J\xF9
> hfile.LASTKEY = \x00\x01f\x01i\x00\x00\x01^\xC6\x9A\xB8-\x04
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18921) Result.current() throws ArrayIndexOutOfBoundsException after calling advance()

2017-10-07 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195958#comment-16195958
 ] 

Hudson commented on HBASE-18921:


FAILURE: Integrated in Jenkins build HBase-2.0 #645 (See 
[https://builds.apache.org/job/HBase-2.0/645/])
HBASE-18921 Fix Result.current ArrayIndexOutOfBoundsException (chia7712: rev 
9cd7619b5c858130e92806c40747148a89a02940)
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Result.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestResult.java


> Result.current() throws ArrayIndexOutOfBoundsException after calling advance()
> --
>
> Key: HBASE-18921
> URL: https://issues.apache.org/jira/browse/HBASE-18921
> Project: HBase
>  Issue Type: Bug
>Reporter: Maytee Chinavanichkit
>Assignee: Maytee Chinavanichkit
>Priority: Minor
> Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7
>
> Attachments: HBASE-18921.master.001.patch, 
> HBASE-18921.master.002.patch, master.patch
>
>
> On a Result object, if current() method is called after advance() returns 
> false, this throws an ArrayIndexOutOfBoundsException. The expectation here is 
> that it should return a null value. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18921) Result.current() throws ArrayIndexOutOfBoundsException after calling advance()

2017-10-07 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195952#comment-16195952
 ] 

Hudson commented on HBASE-18921:


FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3846 (See 
[https://builds.apache.org/job/HBase-Trunk_matrix/3846/])
HBASE-18921 Fix Result.current ArrayIndexOutOfBoundsException (chia7712: rev 
08274045c9d4688cc175f96a484b8b8fc2e161da)
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Result.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestResult.java


> Result.current() throws ArrayIndexOutOfBoundsException after calling advance()
> --
>
> Key: HBASE-18921
> URL: https://issues.apache.org/jira/browse/HBASE-18921
> Project: HBase
>  Issue Type: Bug
>Reporter: Maytee Chinavanichkit
>Assignee: Maytee Chinavanichkit
>Priority: Minor
> Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7
>
> Attachments: HBASE-18921.master.001.patch, 
> HBASE-18921.master.002.patch, master.patch
>
>
> On a Result object, if current() method is called after advance() returns 
> false, this throws an ArrayIndexOutOfBoundsException. The expectation here is 
> that it should return a null value. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18899) Make Fileinfo more readable in HFilePrettyPrinter

2017-10-07 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195953#comment-16195953
 ] 

Hudson commented on HBASE-18899:


FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3846 (See 
[https://builds.apache.org/job/HBase-Trunk_matrix/3846/])
HBASE-18899 Make Fileinfo more readable in HFilePrettyPrinter (chia7712: rev 
bb28a3b4660a64bb513ffe4399e72679fc2dcec5)
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java


> Make Fileinfo more readable in HFilePrettyPrinter
> -
>
> Key: HBASE-18899
> URL: https://issues.apache.org/jira/browse/HBASE-18899
> Project: HBase
>  Issue Type: Improvement
>  Components: HFile
>Affects Versions: 3.0.0, 1.5.0, 2.0.0-alpha-4
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-18899.master.v1.patch, 
> HBASE-18899.master.v2.patch, HBASE-18899.patch
>
>
> Fileinfo as follows. some fields can print  readable values.
> {code}
> Fileinfo:
> BLOOM_FILTER_TYPE = ROW
> DELETE_FAMILY_COUNT = \x00\x00\x00\x00\x00\x00\x00\x00
> EARLIEST_PUT_TS = \x00\x00\x01^Q\xF6\x0E\xCF
> KEY_VALUE_VERSION = \x00\x00\x00\x01
> LAST_BLOOM_KEY = f
> MAJOR_COMPACTION_KEY = \xFF
> MAX_MEMSTORE_TS_KEY = \x00\x00\x00\x00\x00\x00\x00\x18
> MAX_SEQ_ID_KEY = 27
> TIMERANGE = 15046136337431506570582061
> hfile.AVG_KEY_LEN = 14
> hfile.AVG_VALUE_LEN = 3
> hfile.CREATE_TIME_TS = \x00\x00\x01^\xC6\xB4J\xF9
> hfile.LASTKEY = \x00\x01f\x01i\x00\x00\x01^\xC6\x9A\xB8-\x04
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-16338) update jackson to 2.y

2017-10-07 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-16338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195930#comment-16195930
 ] 

Hadoop QA commented on HBASE-16338:
---

(!) A patch to the testing environment has been detected. 
Re-executing against the patched versions to perform further tests. 
The console is at 
https://builds.apache.org/job/PreCommit-HBASE-Build/8994/console in case of 
problems.


> update jackson to 2.y
> -
>
> Key: HBASE-16338
> URL: https://issues.apache.org/jira/browse/HBASE-16338
> Project: HBase
>  Issue Type: Task
>  Components: dependencies
>Reporter: Sean Busbey
>Assignee: Mike Drob
> Fix For: 2.0.0-beta-2
>
> Attachments: 16338.txt, HBASE-16338.v2.patch, HBASE-16338.v3.patch, 
> HBASE-16338.v5.patch
>
>
> Our jackson dependency is from ~3 years ago. Update to the jackson 2.y line, 
> using 2.7.0+.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (HBASE-16338) update jackson to 2.y

2017-10-07 Thread Mike Drob (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-16338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mike Drob updated HBASE-16338:
--
Attachment: HBASE-16338.v5.patch

This rabbit hole went pretty deep. I discovered that we were mix and matching 
some jackson 1 and jackson 2 annotations, which would fail in interesting and 
difficult to diagnose ways.

The bright side is that consumers using Jackson 1 to consume our JSON output 
should largely be fine, and not need changes, since it's still well-formed JSON 
from their perspective. The problem was trying to use Jackson 2 mappers with 
Jackson 1 annotations, and some other bad idea combinations.

This patch ballooned in size pretty quickly from fixing the imports, so I'm 
also attaching it to RB.

> update jackson to 2.y
> -
>
> Key: HBASE-16338
> URL: https://issues.apache.org/jira/browse/HBASE-16338
> Project: HBase
>  Issue Type: Task
>  Components: dependencies
>Reporter: Sean Busbey
>Assignee: Mike Drob
> Fix For: 2.0.0-beta-2
>
> Attachments: 16338.txt, HBASE-16338.v2.patch, HBASE-16338.v3.patch, 
> HBASE-16338.v5.patch
>
>
> Our jackson dependency is from ~3 years ago. Update to the jackson 2.y line, 
> using 2.7.0+.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (HBASE-18968) Update anti-pattern check for yetus audience annotations

2017-10-07 Thread Mike Drob (JIRA)
Mike Drob created HBASE-18968:
-

 Summary: Update anti-pattern check for yetus audience annotations
 Key: HBASE-18968
 URL: https://issues.apache.org/jira/browse/HBASE-18968
 Project: HBase
  Issue Type: Bug
  Components: build
Reporter: Mike Drob


In HBASE-17823 we migrated to Yetus audience annotations, but we did not update 
the anti-pattern check in the yetus personality. We should do that.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18921) Result.current() throws ArrayIndexOutOfBoundsException after calling advance()

2017-10-07 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195912#comment-16195912
 ] 

Hudson commented on HBASE-18921:


SUCCESS: Integrated in Jenkins build HBase-1.2-JDK8 #227 (See 
[https://builds.apache.org/job/HBase-1.2-JDK8/227/])
HBASE-18921 Fix Result.current ArrayIndexOutOfBoundsException (chia7712: rev 
0205109c0d15daa781d5eb4380a657ad34c5)
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestResult.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Result.java


> Result.current() throws ArrayIndexOutOfBoundsException after calling advance()
> --
>
> Key: HBASE-18921
> URL: https://issues.apache.org/jira/browse/HBASE-18921
> Project: HBase
>  Issue Type: Bug
>Reporter: Maytee Chinavanichkit
>Assignee: Maytee Chinavanichkit
>Priority: Minor
> Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7
>
> Attachments: HBASE-18921.master.001.patch, 
> HBASE-18921.master.002.patch, master.patch
>
>
> On a Result object, if current() method is called after advance() returns 
> false, this throws an ArrayIndexOutOfBoundsException. The expectation here is 
> that it should return a null value. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18921) Result.current() throws ArrayIndexOutOfBoundsException after calling advance()

2017-10-07 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195910#comment-16195910
 ] 

Hudson commented on HBASE-18921:


FAILURE: Integrated in Jenkins build HBase-1.5 #86 (See 
[https://builds.apache.org/job/HBase-1.5/86/])
HBASE-18921 Fix Result.current ArrayIndexOutOfBoundsException (chia7712: rev 
50ef066c89d57f17ba51b04ba248e8c8c9ff3d8d)
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestResult.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Result.java


> Result.current() throws ArrayIndexOutOfBoundsException after calling advance()
> --
>
> Key: HBASE-18921
> URL: https://issues.apache.org/jira/browse/HBASE-18921
> Project: HBase
>  Issue Type: Bug
>Reporter: Maytee Chinavanichkit
>Assignee: Maytee Chinavanichkit
>Priority: Minor
> Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7
>
> Attachments: HBASE-18921.master.001.patch, 
> HBASE-18921.master.002.patch, master.patch
>
>
> On a Result object, if current() method is called after advance() returns 
> false, this throws an ArrayIndexOutOfBoundsException. The expectation here is 
> that it should return a null value. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18921) Result.current() throws ArrayIndexOutOfBoundsException after calling advance()

2017-10-07 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195909#comment-16195909
 ] 

Hudson commented on HBASE-18921:


FAILURE: Integrated in Jenkins build HBase-1.4 #942 (See 
[https://builds.apache.org/job/HBase-1.4/942/])
HBASE-18921 Fix Result.current ArrayIndexOutOfBoundsException (chia7712: rev 
b6f14bd2e58ad302d8413173515ecbe5bdfa6e36)
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Result.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestResult.java


> Result.current() throws ArrayIndexOutOfBoundsException after calling advance()
> --
>
> Key: HBASE-18921
> URL: https://issues.apache.org/jira/browse/HBASE-18921
> Project: HBase
>  Issue Type: Bug
>Reporter: Maytee Chinavanichkit
>Assignee: Maytee Chinavanichkit
>Priority: Minor
> Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7
>
> Attachments: HBASE-18921.master.001.patch, 
> HBASE-18921.master.002.patch, master.patch
>
>
> On a Result object, if current() method is called after advance() returns 
> false, this throws an ArrayIndexOutOfBoundsException. The expectation here is 
> that it should return a null value. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18601) Update Htrace to 4.2

2017-10-07 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195897#comment-16195897
 ] 

Hadoop QA commented on HBASE-18601:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
19s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 7 new or modified test 
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
16s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 
32s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  9m 
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  2m 
39s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  6m 
 6s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  3m 
57s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Skipped patched modules with no Java source: 
hbase-testing-util . {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 11m 
32s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  6m 
44s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
16s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m 
14s{color} | {color:red} hbase-rest in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m 
34s{color} | {color:red} hbase-spark in the patch failed. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  9m 
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  9m 
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  2m 
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  6m 
 8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} rubocop {color} | {color:green}  0m  
3s{color} | {color:green} There were no new rubocop issues. {color} |
| {color:green}+1{color} | {color:green} ruby-lint {color} | {color:green}  0m  
1s{color} | {color:green} There were no new ruby-lint issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m 
25s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
21s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
39m 34s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Skipped patched modules with no Java source: 
hbase-testing-util . {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 16m 
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  7m 
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
28s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m 
26s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | 

[jira] [Commented] (HBASE-18909) Deprecate Admin's methods which used String regex

2017-10-07 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195890#comment-16195890
 ] 

Hudson commented on HBASE-18909:


SUCCESS: Integrated in Jenkins build HBase-2.0 #644 (See 
[https://builds.apache.org/job/HBase-2.0/644/])
HBASE-18909 Deprecate Admin's methods which used String regex (zghao: rev 
8e5d88366db317d07213b7473189d1e5a92e32f9)
* (edit) 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationAdmin.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/tool/TestLoadIncrementalHFilesSplitRecovery.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestSnapshotCloneIndependence.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestSnapshotFromClient.java
* (edit) 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
* (edit) hbase-shell/src/main/ruby/hbase/admin.rb


> Deprecate Admin's methods which used String regex
> -
>
> Key: HBASE-18909
> URL: https://issues.apache.org/jira/browse/HBASE-18909
> Project: HBase
>  Issue Type: Sub-task
>  Components: Admin
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-18909.master.001.patch, 
> HBASE-18909.master.002.patch, HBASE-18909.master.003.patch, 
> HBASE-18909.master.004.patch, HBASE-18909.master.005.patch, 
> HBASE-18909.master.006.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (HBASE-7690) Improve metadata printing in HFilePrettyPrinter

2017-10-07 Thread Chia-Ping Tsai (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-7690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chia-Ping Tsai resolved HBASE-7690.
---
Resolution: Duplicate

see HBASE-18899

> Improve metadata printing in HFilePrettyPrinter
> ---
>
> Key: HBASE-7690
> URL: https://issues.apache.org/jira/browse/HBASE-7690
> Project: HBase
>  Issue Type: Improvement
>  Components: HFile
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Minor
> Attachments: 
> 0001-HBASE-7690-Improve-printing-of-HFile-metadata.patch, 
> 0001-HBASE-7690-Improve-printing-of-HFile-metadata.patch
>
>
> The pretty printer could do a better job with metadata. For example:
> {noformat}
> ...
> Fileinfo:
> BULKLOAD_SOURCE_TASK = attempt_201301272014_0001_r_00_0
> BULKLOAD_TIMESTAMP = \x00\x00\x01<\x7FcG\x8E
> DELETE_FAMILY_COUNT = \x00\x00\x00\x00\x00\x00\x00\x00
> EARLIEST_PUT_TS = \x00\x00\x01<\x7Fc
> EXCLUDE_FROM_MINOR_COMPACTION = \x00
> KEY_VALUE_VERSION = \x00\x00\x00\x01
> MAJOR_COMPACTION_KEY = \xFF
> MAX_MEMSTORE_TS_KEY = \x00\x00\x00\x00\x00\x00\x00\x00
> TIMERANGE = 13593468698301359346869830
> hfile.AVG_KEY_LEN = 19
> hfile.AVG_VALUE_LEN = 2
> hfile.LASTKEY = \x00\x04row9\x01dc2\x00\x00\x01<\x7Fc\x04
> ...
> {noformat}
> May of these fields could be cleaned up to print in human-readable values.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18921) Result.current() throws ArrayIndexOutOfBoundsException after calling advance()

2017-10-07 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195860#comment-16195860
 ] 

Hudson commented on HBASE-18921:


SUCCESS: Integrated in Jenkins build HBase-1.2-IT #964 (See 
[https://builds.apache.org/job/HBase-1.2-IT/964/])
HBASE-18921 Fix Result.current ArrayIndexOutOfBoundsException (chia7712: rev 
0205109c0d15daa781d5eb4380a657ad34c5)
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestResult.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Result.java


> Result.current() throws ArrayIndexOutOfBoundsException after calling advance()
> --
>
> Key: HBASE-18921
> URL: https://issues.apache.org/jira/browse/HBASE-18921
> Project: HBase
>  Issue Type: Bug
>Reporter: Maytee Chinavanichkit
>Assignee: Maytee Chinavanichkit
>Priority: Minor
> Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7
>
> Attachments: HBASE-18921.master.001.patch, 
> HBASE-18921.master.002.patch, master.patch
>
>
> On a Result object, if current() method is called after advance() returns 
> false, this throws an ArrayIndexOutOfBoundsException. The expectation here is 
> that it should return a null value. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (HBASE-18899) Make Fileinfo more readable in HFilePrettyPrinter

2017-10-07 Thread Chia-Ping Tsai (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chia-Ping Tsai updated HBASE-18899:
---
  Resolution: Fixed
Hadoop Flags: Reviewed
  Status: Resolved  (was: Patch Available)

Push to master and branch-2.
Thanks for the patch. [~andrewcheng]

> Make Fileinfo more readable in HFilePrettyPrinter
> -
>
> Key: HBASE-18899
> URL: https://issues.apache.org/jira/browse/HBASE-18899
> Project: HBase
>  Issue Type: Improvement
>  Components: HFile
>Affects Versions: 3.0.0, 1.5.0, 2.0.0-alpha-4
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-18899.master.v1.patch, 
> HBASE-18899.master.v2.patch, HBASE-18899.patch
>
>
> Fileinfo as follows. some fields can print  readable values.
> {code}
> Fileinfo:
> BLOOM_FILTER_TYPE = ROW
> DELETE_FAMILY_COUNT = \x00\x00\x00\x00\x00\x00\x00\x00
> EARLIEST_PUT_TS = \x00\x00\x01^Q\xF6\x0E\xCF
> KEY_VALUE_VERSION = \x00\x00\x00\x01
> LAST_BLOOM_KEY = f
> MAJOR_COMPACTION_KEY = \xFF
> MAX_MEMSTORE_TS_KEY = \x00\x00\x00\x00\x00\x00\x00\x18
> MAX_SEQ_ID_KEY = 27
> TIMERANGE = 15046136337431506570582061
> hfile.AVG_KEY_LEN = 14
> hfile.AVG_VALUE_LEN = 3
> hfile.CREATE_TIME_TS = \x00\x00\x01^\xC6\xB4J\xF9
> hfile.LASTKEY = \x00\x01f\x01i\x00\x00\x01^\xC6\x9A\xB8-\x04
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (HBASE-18899) Make Fileinfo more readable in HFilePrettyPrinter

2017-10-07 Thread Chia-Ping Tsai (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chia-Ping Tsai updated HBASE-18899:
---
Fix Version/s: 2.0.0-beta-1

> Make Fileinfo more readable in HFilePrettyPrinter
> -
>
> Key: HBASE-18899
> URL: https://issues.apache.org/jira/browse/HBASE-18899
> Project: HBase
>  Issue Type: Improvement
>  Components: HFile
>Affects Versions: 3.0.0, 1.5.0, 2.0.0-alpha-4
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-18899.master.v1.patch, 
> HBASE-18899.master.v2.patch, HBASE-18899.patch
>
>
> Fileinfo as follows. some fields can print  readable values.
> {code}
> Fileinfo:
> BLOOM_FILTER_TYPE = ROW
> DELETE_FAMILY_COUNT = \x00\x00\x00\x00\x00\x00\x00\x00
> EARLIEST_PUT_TS = \x00\x00\x01^Q\xF6\x0E\xCF
> KEY_VALUE_VERSION = \x00\x00\x00\x01
> LAST_BLOOM_KEY = f
> MAJOR_COMPACTION_KEY = \xFF
> MAX_MEMSTORE_TS_KEY = \x00\x00\x00\x00\x00\x00\x00\x18
> MAX_SEQ_ID_KEY = 27
> TIMERANGE = 15046136337431506570582061
> hfile.AVG_KEY_LEN = 14
> hfile.AVG_VALUE_LEN = 3
> hfile.CREATE_TIME_TS = \x00\x00\x01^\xC6\xB4J\xF9
> hfile.LASTKEY = \x00\x01f\x01i\x00\x00\x01^\xC6\x9A\xB8-\x04
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18921) Result.current() throws ArrayIndexOutOfBoundsException after calling advance()

2017-10-07 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195859#comment-16195859
 ] 

Hudson commented on HBASE-18921:


SUCCESS: Integrated in Jenkins build HBase-1.3-IT #224 (See 
[https://builds.apache.org/job/HBase-1.3-IT/224/])
HBASE-18921 Fix Result.current ArrayIndexOutOfBoundsException (chia7712: rev 
15288c055896eabc804d8a4b45e869ec1ce70b1f)
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestResult.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Result.java


> Result.current() throws ArrayIndexOutOfBoundsException after calling advance()
> --
>
> Key: HBASE-18921
> URL: https://issues.apache.org/jira/browse/HBASE-18921
> Project: HBase
>  Issue Type: Bug
>Reporter: Maytee Chinavanichkit
>Assignee: Maytee Chinavanichkit
>Priority: Minor
> Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7
>
> Attachments: HBASE-18921.master.001.patch, 
> HBASE-18921.master.002.patch, master.patch
>
>
> On a Result object, if current() method is called after advance() returns 
> false, this throws an ArrayIndexOutOfBoundsException. The expectation here is 
> that it should return a null value. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18921) Result.current() throws ArrayIndexOutOfBoundsException after calling advance()

2017-10-07 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195855#comment-16195855
 ] 

Hudson commented on HBASE-18921:


FAILURE: Integrated in Jenkins build HBase-1.3-JDK8 #309 (See 
[https://builds.apache.org/job/HBase-1.3-JDK8/309/])
HBASE-18921 Fix Result.current ArrayIndexOutOfBoundsException (chia7712: rev 
15288c055896eabc804d8a4b45e869ec1ce70b1f)
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Result.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestResult.java


> Result.current() throws ArrayIndexOutOfBoundsException after calling advance()
> --
>
> Key: HBASE-18921
> URL: https://issues.apache.org/jira/browse/HBASE-18921
> Project: HBase
>  Issue Type: Bug
>Reporter: Maytee Chinavanichkit
>Assignee: Maytee Chinavanichkit
>Priority: Minor
> Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7
>
> Attachments: HBASE-18921.master.001.patch, 
> HBASE-18921.master.002.patch, master.patch
>
>
> On a Result object, if current() method is called after advance() returns 
> false, this throws an ArrayIndexOutOfBoundsException. The expectation here is 
> that it should return a null value. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18921) Result.current() throws ArrayIndexOutOfBoundsException after calling advance()

2017-10-07 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195854#comment-16195854
 ] 

Hudson commented on HBASE-18921:


FAILURE: Integrated in Jenkins build HBase-1.2-JDK7 #231 (See 
[https://builds.apache.org/job/HBase-1.2-JDK7/231/])
HBASE-18921 Fix Result.current ArrayIndexOutOfBoundsException (chia7712: rev 
0205109c0d15daa781d5eb4380a657ad34c5)
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestResult.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Result.java


> Result.current() throws ArrayIndexOutOfBoundsException after calling advance()
> --
>
> Key: HBASE-18921
> URL: https://issues.apache.org/jira/browse/HBASE-18921
> Project: HBase
>  Issue Type: Bug
>Reporter: Maytee Chinavanichkit
>Assignee: Maytee Chinavanichkit
>Priority: Minor
> Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7
>
> Attachments: HBASE-18921.master.001.patch, 
> HBASE-18921.master.002.patch, master.patch
>
>
> On a Result object, if current() method is called after advance() returns 
> false, this throws an ArrayIndexOutOfBoundsException. The expectation here is 
> that it should return a null value. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18921) Result.current() throws ArrayIndexOutOfBoundsException after calling advance()

2017-10-07 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195853#comment-16195853
 ] 

Hudson commented on HBASE-18921:


FAILURE: Integrated in Jenkins build HBase-1.3-JDK7 #296 (See 
[https://builds.apache.org/job/HBase-1.3-JDK7/296/])
HBASE-18921 Fix Result.current ArrayIndexOutOfBoundsException (chia7712: rev 
15288c055896eabc804d8a4b45e869ec1ce70b1f)
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestResult.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Result.java


> Result.current() throws ArrayIndexOutOfBoundsException after calling advance()
> --
>
> Key: HBASE-18921
> URL: https://issues.apache.org/jira/browse/HBASE-18921
> Project: HBase
>  Issue Type: Bug
>Reporter: Maytee Chinavanichkit
>Assignee: Maytee Chinavanichkit
>Priority: Minor
> Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7
>
> Attachments: HBASE-18921.master.001.patch, 
> HBASE-18921.master.002.patch, master.patch
>
>
> On a Result object, if current() method is called after advance() returns 
> false, this throws an ArrayIndexOutOfBoundsException. The expectation here is 
> that it should return a null value. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-12260) MasterServices needs a short-back-and-sides; pare-back exposure of internals and IA.Private classes

2017-10-07 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-12260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195847#comment-16195847
 ] 

Hadoop QA commented on HBASE-12260:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
21s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 42 new or modified test 
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
39s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
14s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
49s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
58s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  6m 
58s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m 
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
23s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
19s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  1m 
 7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 1s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
18s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
40m 12s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m 
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m 
39s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 24m  9s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
32s{color} | {color:green} hbase-rsgroup in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 10m 
40s{color} | {color:green} hbase-backup in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
44s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}112m 45s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | 
hadoop.hbase.master.normalizer.TestSimpleRegionNormalizer |
|   | hadoop.hbase.master.TestClockSkewDetection |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123 |
| JIRA Issue | HBASE-12260 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12890871/HBASE-12260.master.009.patch
 |
| Optional Tests |  

[jira] [Updated] (HBASE-18921) Result.current() throws ArrayIndexOutOfBoundsException after calling advance()

2017-10-07 Thread Chia-Ping Tsai (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chia-Ping Tsai updated HBASE-18921:
---
  Resolution: Fixed
Hadoop Flags: Reviewed
  Status: Resolved  (was: Patch Available)

Push to master, branch-2, branch-1, branch-1.4, branch-1.3, and branch-1.2.
Thanks for the patch. [~mchinavan]

> Result.current() throws ArrayIndexOutOfBoundsException after calling advance()
> --
>
> Key: HBASE-18921
> URL: https://issues.apache.org/jira/browse/HBASE-18921
> Project: HBase
>  Issue Type: Bug
>Reporter: Maytee Chinavanichkit
>Assignee: Maytee Chinavanichkit
>Priority: Minor
> Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7
>
> Attachments: HBASE-18921.master.001.patch, 
> HBASE-18921.master.002.patch, master.patch
>
>
> On a Result object, if current() method is called after advance() returns 
> false, this throws an ArrayIndexOutOfBoundsException. The expectation here is 
> that it should return a null value. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18899) Make Fileinfo more readable in HFilePrettyPrinter

2017-10-07 Thread Chia-Ping Tsai (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195827#comment-16195827
 ] 

Chia-Ping Tsai commented on HBASE-18899:


Will commit it later.

> Make Fileinfo more readable in HFilePrettyPrinter
> -
>
> Key: HBASE-18899
> URL: https://issues.apache.org/jira/browse/HBASE-18899
> Project: HBase
>  Issue Type: Improvement
>  Components: HFile
>Affects Versions: 3.0.0, 1.5.0, 2.0.0-alpha-4
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
> Attachments: HBASE-18899.master.v1.patch, 
> HBASE-18899.master.v2.patch, HBASE-18899.patch
>
>
> Fileinfo as follows. some fields can print  readable values.
> {code}
> Fileinfo:
> BLOOM_FILTER_TYPE = ROW
> DELETE_FAMILY_COUNT = \x00\x00\x00\x00\x00\x00\x00\x00
> EARLIEST_PUT_TS = \x00\x00\x01^Q\xF6\x0E\xCF
> KEY_VALUE_VERSION = \x00\x00\x00\x01
> LAST_BLOOM_KEY = f
> MAJOR_COMPACTION_KEY = \xFF
> MAX_MEMSTORE_TS_KEY = \x00\x00\x00\x00\x00\x00\x00\x18
> MAX_SEQ_ID_KEY = 27
> TIMERANGE = 15046136337431506570582061
> hfile.AVG_KEY_LEN = 14
> hfile.AVG_VALUE_LEN = 3
> hfile.CREATE_TIME_TS = \x00\x00\x01^\xC6\xB4J\xF9
> hfile.LASTKEY = \x00\x01f\x01i\x00\x00\x01^\xC6\x9A\xB8-\x04
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (HBASE-18967) Backport HBASE-17181 to branch-1.3

2017-10-07 Thread Chia-Ping Tsai (JIRA)
Chia-Ping Tsai created HBASE-18967:
--

 Summary: Backport HBASE-17181 to branch-1.3
 Key: HBASE-18967
 URL: https://issues.apache.org/jira/browse/HBASE-18967
 Project: HBase
  Issue Type: Sub-task
Reporter: Chia-Ping Tsai
 Fix For: 1.3.2






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18954) Make *CoprocessorHost classes private

2017-10-07 Thread Chia-Ping Tsai (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195824#comment-16195824
 ] 

Chia-Ping Tsai commented on HBASE-18954:


Making *CoprocessorHost IA.Private means that they are internal use only, yet 
user can get the {{RegionCoprocessorHost}} via {{Store#getCoprocessorHost}}. 
Maybe {{Store#getCoprocessorHost}} should be removed.

> Make *CoprocessorHost classes private
> -
>
> Key: HBASE-18954
> URL: https://issues.apache.org/jira/browse/HBASE-18954
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Appy
>Assignee: Appy
>  Labels: incompatible
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18954.master.001.patch, 
> HBASE-18954.master.002.patch
>
>
> Move out configuration name constants (into Coprocessor class?) and made Host 
> classes private.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18957) add test that establishes branch-1 behavior for filterlist w/OR

2017-10-07 Thread Mike Drob (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195811#comment-16195811
 ] 

Mike Drob commented on HBASE-18957:
---

Should we link this to the revertible issues?

> add test that establishes branch-1 behavior for filterlist w/OR
> ---
>
> Key: HBASE-18957
> URL: https://issues.apache.org/jira/browse/HBASE-18957
> Project: HBase
>  Issue Type: Sub-task
>  Components: Filters
>Reporter: Sean Busbey
>Assignee: Peter Somogyi
>Priority: Critical
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18957-branch-1.2.v0.patch, 
> HBASE-18957-branch-1.2.v1.patch, HBASE-18957-branch-1.4.v1.patch, 
> HBASE-18957-branch-1.v1.patch, HBASE-18957-master.v1.patch
>
>
> we need a test that shows the expected behavior for filter lists that rely on 
> OR prior to our filterlist improvements so we have a baseline to show 
> compatibility (and/or document incompatibilities that end up being 
> introduced).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18911) Unify Admin and AsyncAdmin's methods name

2017-10-07 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195806#comment-16195806
 ] 

stack commented on HBASE-18911:
---

This is a great issue [~zghaobac] Thanks for starting it.

Related, over in HBASE-12260, I added getServers to return list of Region 
Servers. In AsyncAdmin it is getRegionServers. I made it getServers because 
that is name of the ClusterStatus method and the name of the method used 
elsewhere getting list of region servers.

On you general list, I think you have to favor the Admin names unless good 
reason because it is a pain deprecating the old to put in place the new (We 
have lots of deprecation already in Admin...).

I'm not mad about setNormalizerOn because you can use the method to set the 
normalizer off too. If you have a better name than normalizerSwitch for the 
method, lets do it... As you say they are new additions not yet in a release so 
we can change them.

execProcedureWithRet is bad. As you suggest, execProcedureWithReturn is better.

+1 on the getRegions instead of getOnlineRegions.



> Unify Admin and AsyncAdmin's methods name
> -
>
> Key: HBASE-18911
> URL: https://issues.apache.org/jira/browse/HBASE-18911
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
> Fix For: 2.0.0-beta-1
>
>
> Different Methods
> || AsyncAdmin || Admin || unified name ||
> | listTables | listTableDescriptors | listTableDescriptors |
> | getOnlineRegions | getRegions | getRegions |
> | getTableRegions | getRegions | getRegions |
> | getTableDescriptor | getDescriptor | getDescriptor |
> | getRegionLoads | getRegionLoad | getRegionLoads |
> | execProcedureWithRet | execProcedureWithReturn | execProcedureWithReturn |
> | setNormalizerOn | normalizerSwitch | setNormalizerOn |
> | isNormalizerOn | isNormalizerEnabled | isNormalizerOn |
> | setBalancerOn | balancerSwitch | setBalancerOn |
> | isBalancerOn | isBalancerEnabled | isBalancerOn |
> | setCleanerChoreOn | cleanerChoreSwitch | setCleanerChoreOn |
> | isCleanerChoreOn | isCleanerChoreEnabled | isCleanerChoreOn |
> | setSplitOn/setMergeOn | splitOrMergeEnabledSwitch | setSplitOn/setMergeOn |
> Methods only in AsyncAdmin
> || AsyncAdmin ||
> | isSplitOn |
> | isMergeOn |
> | majorCompactRegionServer |
> | stopRegionServer |



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18909) Deprecate Admin's methods which used String regex

2017-10-07 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195804#comment-16195804
 ] 

Hudson commented on HBASE-18909:


FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3844 (See 
[https://builds.apache.org/job/HBase-Trunk_matrix/3844/])
HBASE-18909 Deprecate Admin's methods which used String regex (zghao: rev 
63440a9c7d76e82bb0d90e7db098f0b9b5595244)
* (edit) hbase-shell/src/main/ruby/hbase/admin.rb
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestSnapshotCloneIndependence.java
* (edit) 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationAdmin.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestSnapshotFromClient.java
* (edit) 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/tool/TestLoadIncrementalHFilesSplitRecovery.java


> Deprecate Admin's methods which used String regex
> -
>
> Key: HBASE-18909
> URL: https://issues.apache.org/jira/browse/HBASE-18909
> Project: HBase
>  Issue Type: Sub-task
>  Components: Admin
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-18909.master.001.patch, 
> HBASE-18909.master.002.patch, HBASE-18909.master.003.patch, 
> HBASE-18909.master.004.patch, HBASE-18909.master.005.patch, 
> HBASE-18909.master.006.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-12260) MasterServices needs a short-back-and-sides; pare-back exposure of internals and IA.Private classes

2017-10-07 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-12260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195802#comment-16195802
 ] 

stack commented on HBASE-12260:
---

.009 implements a [~chia7712] suggestion; use existing rpc rather than add a 
new one. Also s/getRegionServers/getServers/ in the Admin Interface.

> MasterServices needs a short-back-and-sides; pare-back exposure of internals 
> and IA.Private classes
> ---
>
> Key: HBASE-12260
> URL: https://issues.apache.org/jira/browse/HBASE-12260
> Project: HBase
>  Issue Type: Sub-task
>  Components: master
>Reporter: ryan rawson
>Assignee: stack
>Priority: Critical
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-12260.master.001.patch, 
> HBASE-12260.master.002.patch, HBASE-12260.master.003.patch, 
> HBASE-12260.master.004.patch, HBASE-12260.master.005.patch, 
> HBASE-12260.master.006.patch, HBASE-12260.master.007.patch, 
> HBASE-12260.master.008.patch, HBASE-12260.master.009.patch
>
>
> A major issue with MasterServices is the MasterCoprocessorEnvironment exposes 
> this class even though MasterServices is tagged with 
> @InterfaceAudience.Private
> This means that the entire internals of the HMaster is essentially part of 
> the coprocessor API.  Many of the classes returned by the MasterServices API 
> are highly internal, extremely powerful, and subject to constant change.  
> Perhaps a new API to replace MasterServices that is use-case focused, and 
> justified based on real world co-processors would suit things better.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (HBASE-12260) MasterServices needs a short-back-and-sides; pare-back exposure of internals and IA.Private classes

2017-10-07 Thread stack (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-12260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-12260:
--
Attachment: HBASE-12260.master.009.patch

> MasterServices needs a short-back-and-sides; pare-back exposure of internals 
> and IA.Private classes
> ---
>
> Key: HBASE-12260
> URL: https://issues.apache.org/jira/browse/HBASE-12260
> Project: HBase
>  Issue Type: Sub-task
>  Components: master
>Reporter: ryan rawson
>Assignee: stack
>Priority: Critical
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-12260.master.001.patch, 
> HBASE-12260.master.002.patch, HBASE-12260.master.003.patch, 
> HBASE-12260.master.004.patch, HBASE-12260.master.005.patch, 
> HBASE-12260.master.006.patch, HBASE-12260.master.007.patch, 
> HBASE-12260.master.008.patch, HBASE-12260.master.009.patch
>
>
> A major issue with MasterServices is the MasterCoprocessorEnvironment exposes 
> this class even though MasterServices is tagged with 
> @InterfaceAudience.Private
> This means that the entire internals of the HMaster is essentially part of 
> the coprocessor API.  Many of the classes returned by the MasterServices API 
> are highly internal, extremely powerful, and subject to constant change.  
> Perhaps a new API to replace MasterServices that is use-case focused, and 
> justified based on real world co-processors would suit things better.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-12260) MasterServices needs a short-back-and-sides; pare-back exposure of internals and IA.Private classes

2017-10-07 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-12260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195789#comment-16195789
 ] 

stack commented on HBASE-12260:
---

[~zghaobac] Is it ok if I change AsyncAdmin#getRegionServers to 
AsyncAdmin#getServers? ClusterStatus has getServers, not getRegionServers, and 
this is how AsyncAdmin (and now Admin) implements getServers/getRegionServers? 
Thanks.

(Thanks too for reviews)

> MasterServices needs a short-back-and-sides; pare-back exposure of internals 
> and IA.Private classes
> ---
>
> Key: HBASE-12260
> URL: https://issues.apache.org/jira/browse/HBASE-12260
> Project: HBase
>  Issue Type: Sub-task
>  Components: master
>Reporter: ryan rawson
>Assignee: stack
>Priority: Critical
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-12260.master.001.patch, 
> HBASE-12260.master.002.patch, HBASE-12260.master.003.patch, 
> HBASE-12260.master.004.patch, HBASE-12260.master.005.patch, 
> HBASE-12260.master.006.patch, HBASE-12260.master.007.patch, 
> HBASE-12260.master.008.patch
>
>
> A major issue with MasterServices is the MasterCoprocessorEnvironment exposes 
> this class even though MasterServices is tagged with 
> @InterfaceAudience.Private
> This means that the entire internals of the HMaster is essentially part of 
> the coprocessor API.  Many of the classes returned by the MasterServices API 
> are highly internal, extremely powerful, and subject to constant change.  
> Perhaps a new API to replace MasterServices that is use-case focused, and 
> justified based on real world co-processors would suit things better.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (HBASE-18966) In-memory compaction/merge should update its TimeRange

2017-10-07 Thread Chia-Ping Tsai (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chia-Ping Tsai updated HBASE-18966:
---
Description: The in-memory compaction/merge do the great job of optimizing 
the memory layout for cells, but they don't update its {{TimeRange}}. It don't 
cause any bugs currently because the {{TimeRange}} is used for store-level ts 
filter only and the default {{TimeRange}} of {{ImmutableSegment}} created by 
in-memory compaction/merge has the maximum ts range.(was: The in-memory 
compaction/merge do the great job of optimizing the memory layout for cells, 
but they don't update its {{TimeRange}}. It don't cause any bugs currently 
because the {{TimeRange}} is used for store-level ts filter only.)

> In-memory compaction/merge should update its TimeRange
> --
>
> Key: HBASE-18966
> URL: https://issues.apache.org/jira/browse/HBASE-18966
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 2.0.0-beta-1
>
>
> The in-memory compaction/merge do the great job of optimizing the memory 
> layout for cells, but they don't update its {{TimeRange}}. It don't cause any 
> bugs currently because the {{TimeRange}} is used for store-level ts filter 
> only and the default {{TimeRange}} of {{ImmutableSegment}} created by 
> in-memory compaction/merge has the maximum ts range.  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18752) Recalculate the TimeRange in flushing snapshot to store file

2017-10-07 Thread Chia-Ping Tsai (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195773#comment-16195773
 ] 

Chia-Ping Tsai commented on HBASE-18752:


bq. Also in COmpacting MemStore when Policy is EAGER, for each of the 
ImmutableSegment creation, we will recalculate this TR? There also dropping of 
dup cells etc happens. Pls double check once. May be a test case also for that 
would be nice to have.
see HBASE-18966

> Recalculate the TimeRange in flushing snapshot to store file
> 
>
> Key: HBASE-18752
> URL: https://issues.apache.org/jira/browse/HBASE-18752
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-18752.v0.patch, HBASE-18752.v1.patch
>
>
> We drop superfluous cells in flushing, hence the TimeRange from snapshot is 
> inaccurate for the storefile. We should recalculate the TimeRange for the 
> storefile, but the side-effect is the extra cost - we need to extract the 
> timestamp from cell (ByteBufferCell).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (HBASE-18966) In-memory compaction/merge should update its TimeRange

2017-10-07 Thread Chia-Ping Tsai (JIRA)
Chia-Ping Tsai created HBASE-18966:
--

 Summary: In-memory compaction/merge should update its TimeRange
 Key: HBASE-18966
 URL: https://issues.apache.org/jira/browse/HBASE-18966
 Project: HBase
  Issue Type: Sub-task
Reporter: Chia-Ping Tsai
Assignee: Chia-Ping Tsai


The in-memory compaction/merge do the great job of optimizing the memory layout 
for cells, but they don't update its {{TimeRange}}. It don't cause any bugs 
currently because the {{TimeRange}} is used for store-level ts filter only.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (HBASE-18601) Update Htrace to 4.2

2017-10-07 Thread Tamas Penzes (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Penzes updated HBASE-18601:
-
Status: Open  (was: Patch Available)

> Update Htrace to 4.2
> 
>
> Key: HBASE-18601
> URL: https://issues.apache.org/jira/browse/HBASE-18601
> Project: HBase
>  Issue Type: Task
>Affects Versions: 2.0.0, 3.0.0
>Reporter: Tamas Penzes
>Assignee: Tamas Penzes
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18601.master.001.patch, 
> HBASE-18601.master.002.patch, HBASE-18601.master.003 (3).patch, 
> HBASE-18601.master.003.patch, HBASE-18601.master.004.patch, 
> HBASE-18601.master.004.patch, HBASE-18601.master.005.patch, 
> HBASE-18601.master.006.patch, HBASE-18601.master.006.patch, 
> HBASE-18601.master.007.patch, HBASE-18601.master.007.patch, 
> HBASE-18601.master.007.patch, HBASE-18601.master.008.patch, 
> HBASE-18601.master.009.patch, HBASE-18601.master.009.patch
>
>
> HTrace is not perfectly integrated into HBase, the version 3.2.0 is buggy, 
> the upgrade to 4.x is not trivial and would take time. It might not worth to 
> keep it in this state, so would be better to remove it.
> Of course it doesn't mean tracing would be useless, just that in this form 
> the use of HTrace 3.2 might not add any value to the project and fixing it 
> would be far too much effort.
> -
> Based on the decision of the community we keep htrace now and update version



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (HBASE-18601) Update Htrace to 4.2

2017-10-07 Thread Tamas Penzes (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Penzes updated HBASE-18601:
-
Status: Patch Available  (was: Open)

> Update Htrace to 4.2
> 
>
> Key: HBASE-18601
> URL: https://issues.apache.org/jira/browse/HBASE-18601
> Project: HBase
>  Issue Type: Task
>Affects Versions: 2.0.0, 3.0.0
>Reporter: Tamas Penzes
>Assignee: Tamas Penzes
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18601.master.001.patch, 
> HBASE-18601.master.002.patch, HBASE-18601.master.003 (3).patch, 
> HBASE-18601.master.003.patch, HBASE-18601.master.004.patch, 
> HBASE-18601.master.004.patch, HBASE-18601.master.005.patch, 
> HBASE-18601.master.006.patch, HBASE-18601.master.006.patch, 
> HBASE-18601.master.007.patch, HBASE-18601.master.007.patch, 
> HBASE-18601.master.007.patch, HBASE-18601.master.008.patch, 
> HBASE-18601.master.009.patch, HBASE-18601.master.009.patch
>
>
> HTrace is not perfectly integrated into HBase, the version 3.2.0 is buggy, 
> the upgrade to 4.x is not trivial and would take time. It might not worth to 
> keep it in this state, so would be better to remove it.
> Of course it doesn't mean tracing would be useless, just that in this form 
> the use of HTrace 3.2 might not add any value to the project and fixing it 
> would be far too much effort.
> -
> Based on the decision of the community we keep htrace now and update version



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (HBASE-18601) Update Htrace to 4.2

2017-10-07 Thread Tamas Penzes (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Penzes updated HBASE-18601:
-
Attachment: HBASE-18601.master.009.patch

retry

> Update Htrace to 4.2
> 
>
> Key: HBASE-18601
> URL: https://issues.apache.org/jira/browse/HBASE-18601
> Project: HBase
>  Issue Type: Task
>Affects Versions: 2.0.0, 3.0.0
>Reporter: Tamas Penzes
>Assignee: Tamas Penzes
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18601.master.001.patch, 
> HBASE-18601.master.002.patch, HBASE-18601.master.003 (3).patch, 
> HBASE-18601.master.003.patch, HBASE-18601.master.004.patch, 
> HBASE-18601.master.004.patch, HBASE-18601.master.005.patch, 
> HBASE-18601.master.006.patch, HBASE-18601.master.006.patch, 
> HBASE-18601.master.007.patch, HBASE-18601.master.007.patch, 
> HBASE-18601.master.007.patch, HBASE-18601.master.008.patch, 
> HBASE-18601.master.009.patch, HBASE-18601.master.009.patch
>
>
> HTrace is not perfectly integrated into HBase, the version 3.2.0 is buggy, 
> the upgrade to 4.x is not trivial and would take time. It might not worth to 
> keep it in this state, so would be better to remove it.
> Of course it doesn't mean tracing would be useless, just that in this form 
> the use of HTrace 3.2 might not add any value to the project and fixing it 
> would be far too much effort.
> -
> Based on the decision of the community we keep htrace now and update version



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18960) A few bug fixes and minor improvements around batchMutate()

2017-10-07 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195761#comment-16195761
 ] 

Hadoop QA commented on HBASE-18960:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
12s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
27s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 
46s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
53s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
41s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
26s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
 3s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
37s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
42s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
18s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  3m 
57s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
33m 14s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  3m 
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m 
16s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}935m 43s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
41s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}993m 16s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | 
hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpointNoMaster
 |
|   | hadoop.hbase.regionserver.TestRegionReplicaFailover |
|   | hadoop.hbase.regionserver.TestHRegionReplayEvents |
|   | 
hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123 |
| JIRA Issue | HBASE-18960 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12890834/hbase-18960.master.001.patch
 |
| 

[jira] [Commented] (HBASE-16417) In-Memory MemStore Policy for Flattening and Compactions

2017-10-07 Thread Eshcar Hillel (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-16417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195745#comment-16195745
 ] 

Eshcar Hillel commented on HBASE-16417:
---

Thanks all for your questions.

bq. Can this go into branch-2?
Sure why not :)

bq. How long did the tests run for in each of the five cases?
Write-only runs started from an empty table and performed 500M puts. This took 
over an hour in SSD and less than 2 hours in HDD.
Read-write runs first loaded 10GB data and then ran 500K reads with heavy 
writes running in the background. These runs took 2-4 hours each.

bq. What would you recommend as default? Should we enable adaptive by default?
This is a good question.
We performed rigorous benchmarks, however these are still only 
micro-benchmarks, namely rely on synthetic workloads.
I think it is best to have Basic as default for 2.0 since its behavior is more 
predictive, and it requires no configuration.
Once we have users feedback we can suggest them also to try playing with 
adaptive and see where it can further improve their performance.  
For sure they can configure it for specific column families which can benefit 
from data reduction.

bq. The effect of HDD/SSDs does it come from the fact as how fast these 
segments in the pipeline are released after flushes?
In write-only workload we see that the improvement in throughput has high 
correlation with reduction of total GC time. With fast SSD hardware this has 
higher affect on throughput as memory management is more of a bottleneck.

bq. here we capture the throughput of writes and flushes are not in the hot 
path so does it mean that we get blocking updates and the throughput depends on 
how fast the blocking udpates are cleared and that depends on the segment count?
You can see in the parameter tuning report throughput increases as the number 
of segments in the pipeline increases (up to some point), so I don't think we 
get more blocking updates with more segments in the pipeline.
Also note that the number of segments in the snapshot depends on the timing of 
the flush, it could be less than the limit.

bq. So these tests were done with changing back to the old way of per region 
flush decision based on heap size NOT on data size?
NO. 
Did not have time to apply these changes yet. I plan to do this next.
However, global pressure triggered many flushes, and there as you know it does 
check heap size and not data size 

bq. The more the data size, the lesser will be the gain. To have a fair eval 
what should be the val size to used?
I agree. With greater values the gain will be smaller. But I believe we'll 
still see gain. Flat index not only takes less space but is also more friendly 
for memory management which is an advantage. Moreover with adaptive we'll still 
see reduction in space, flushes, disk compaction etc.
AND a recent work  claim that small values are typical in production workloads 
like in Facebook and Twitter (see "LSM-trie: An lsm-tree-based ultra-large 
key-value store for small data items").
We ran experiments with large values in the past.
We can repeat some of the experiments with 500B which are also reported in this 
work.

I need a rebase plus will implement the comments above or other comments you 
put on RB.
Anyway happy to answer any further question/concerns you may have.


> In-Memory MemStore Policy for Flattening and Compactions
> 
>
> Key: HBASE-16417
> URL: https://issues.apache.org/jira/browse/HBASE-16417
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Anastasia Braginsky
>Assignee: Eshcar Hillel
> Fix For: 3.0.0
>
> Attachments: HBASE-16417.01.patch, HBASE-16417 - Adaptive Compaction 
> Policy - 20171001.pdf, HBASE-16417-benchmarkresults-20161101.pdf, 
> HBASE-16417-benchmarkresults-20161110.pdf, 
> HBASE-16417-benchmarkresults-20161123.pdf, 
> HBASE-16417-benchmarkresults-20161205.pdf, 
> HBASE-16417-benchmarkresults-20170309.pdf, 
> HBASE-16417-benchmarkresults-20170317.pdf, HBASE-16417 - parameter tuning - 
> 20171001.pdf, HBASE-16417-V01.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18911) Unify Admin and AsyncAdmin's methods name

2017-10-07 Thread Chia-Ping Tsai (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195719#comment-16195719
 ] 

Chia-Ping Tsai commented on HBASE-18911:


Let us carry over the discussion in HBASE-18914 now.
{code}
HTableDescriptor[] deleteTables(Pattern)
HTableDescriptor[] enableTables(Pattern)
HTableDescriptor[] disableTables(Pattern)
{code}
If they are useful to user, we must have them new name as they return the 
deprecated HTD. The candidate are shown below.
# enableTables/disableTables -> setTablesOn(Pattern, Boolean)
# deleteTables -> dropTables

There are many of methods called xxxOn, hence the {{setTablesOn}} should be 
fine.Reflecting this philosophy, the {{isTableEnabled}} can be renamed 
{{isTableOn}}. The {{dropTables}} references to our shell command. 

> Unify Admin and AsyncAdmin's methods name
> -
>
> Key: HBASE-18911
> URL: https://issues.apache.org/jira/browse/HBASE-18911
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
> Fix For: 2.0.0-beta-1
>
>
> Different Methods
> || AsyncAdmin || Admin || unified name ||
> | listTables | listTableDescriptors | listTableDescriptors |
> | getOnlineRegions | getRegions | getRegions |
> | getTableRegions | getRegions | getRegions |
> | getTableDescriptor | getDescriptor | getDescriptor |
> | getRegionLoads | getRegionLoad | getRegionLoads |
> | execProcedureWithRet | execProcedureWithReturn | execProcedureWithReturn |
> | setNormalizerOn | normalizerSwitch | setNormalizerOn |
> | isNormalizerOn | isNormalizerEnabled | isNormalizerOn |
> | setBalancerOn | balancerSwitch | setBalancerOn |
> | isBalancerOn | isBalancerEnabled | isBalancerOn |
> | setCleanerChoreOn | cleanerChoreSwitch | setCleanerChoreOn |
> | isCleanerChoreOn | isCleanerChoreEnabled | isCleanerChoreOn |
> | setSplitOn/setMergeOn | splitOrMergeEnabledSwitch | setSplitOn/setMergeOn |
> Methods only in AsyncAdmin
> || AsyncAdmin ||
> | isSplitOn |
> | isMergeOn |
> | majorCompactRegionServer |
> | stopRegionServer |



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18914) Remove AsyncAdmin's methods which were already deprecated in Admin interface

2017-10-07 Thread Guanghao Zhang (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195697#comment-16195697
 ] 

Guanghao Zhang commented on HBASE-18914:


bq. should we introduce the alternative ways to replace the deprecated methods 
in Admin?
I am +1 for Admin has same methods with AsyncAdmin in 2.0. This can be 
discussed in HBASE-18911 or a new issue.

bq. They are ugly names but we must come up with a workaround.
Yeah, these names is ugly.. If the pattern is null, it means delete all 
tables or no delete tables..

> Remove AsyncAdmin's methods which were already deprecated in Admin interface
> 
>
> Key: HBASE-18914
> URL: https://issues.apache.org/jira/browse/HBASE-18914
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-18914.master.001.patch
>
>
> Since we are not release hbase 2.0 now, I thought it is ok to remove the 
> methods which were already de deprecated in Admin interface.
> The methods which were marked as deprecated in HBASE-18241.
> HTableDescriptor[] deleteTables(Pattern)
> HTableDescriptor[] enableTables(Pattern)
> HTableDescriptor[] disableTables(Pattern)
> getAlterStatus()
> closeRegion()



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (HBASE-18909) Deprecate Admin's methods which used String regex

2017-10-07 Thread Guanghao Zhang (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-18909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guanghao Zhang updated HBASE-18909:
---
  Resolution: Fixed
Hadoop Flags: Reviewed
Release Note: Pushed to master and branch-2. Thanks all for reviewing.
  Status: Resolved  (was: Patch Available)

> Deprecate Admin's methods which used String regex
> -
>
> Key: HBASE-18909
> URL: https://issues.apache.org/jira/browse/HBASE-18909
> Project: HBase
>  Issue Type: Sub-task
>  Components: Admin
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-18909.master.001.patch, 
> HBASE-18909.master.002.patch, HBASE-18909.master.003.patch, 
> HBASE-18909.master.004.patch, HBASE-18909.master.005.patch, 
> HBASE-18909.master.006.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18601) Update Htrace to 4.2

2017-10-07 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195608#comment-16195608
 ] 

Hadoop QA commented on HBASE-18601:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
26s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 7 new or modified test 
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
33s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
 7s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 12m  
0s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  3m 
19s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  7m 
34s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
17s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Skipped patched modules with no Java source: 
hbase-testing-util . {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 14m  
8s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  8m 
19s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
18s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m 
16s{color} | {color:red} hbase-rest in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m 
42s{color} | {color:red} hbase-spark in the patch failed. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 10m 
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 10m 
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  2m 
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  7m 
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} rubocop {color} | {color:green}  0m  
5s{color} | {color:green} There were no new rubocop issues. {color} |
| {color:green}+1{color} | {color:green} ruby-lint {color} | {color:green}  0m  
1s{color} | {color:green} There were no new ruby-lint issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m 
30s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
 2s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
66m 17s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Skipped patched modules with no Java source: 
hbase-testing-util . {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 39m 
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 20m 
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  1m  
8s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  4m 
41s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | 

[jira] [Commented] (HBASE-12260) MasterServices needs a short-back-and-sides; pare-back exposure of internals and IA.Private classes

2017-10-07 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-12260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195595#comment-16195595
 ] 

Hadoop QA commented on HBASE-12260:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
19s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 42 new or modified test 
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
16s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 
31s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  1m 
 3s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
43s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  6m 
10s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
19s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
18s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m 
23s{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m 
15s{color} | {color:red} hbase-rsgroup in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m 
14s{color} | {color:red} hbase-backup in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red}  0m 
23s{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red}  0m 
14s{color} | {color:red} hbase-rsgroup in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red}  0m 
15s{color} | {color:red} hbase-backup in the patch failed. {color} |
| {color:red}-1{color} | {color:red} cc {color} | {color:red}  0m 23s{color} | 
{color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} cc {color} | {color:red}  0m 14s{color} | 
{color:red} hbase-rsgroup in the patch failed. {color} |
| {color:red}-1{color} | {color:red} cc {color} | {color:red}  0m 15s{color} | 
{color:red} hbase-backup in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red}  0m 23s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red}  0m 14s{color} 
| {color:red} hbase-rsgroup in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red}  0m 15s{color} 
| {color:red} hbase-backup in the patch failed. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  1m 
 2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red}  2m 
17s{color} | {color:red} patch has 38 errors when building our shaded 
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  3m 
33s{color} | {color:red} The patch causes 38 errors with Hadoop v2.6.1. {color} 
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  4m 
46s{color} | {color:red} The patch causes 38 errors with Hadoop v2.6.2. {color} 
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  6m  
0s{color} | {color:red} The patch causes 38 errors with Hadoop v2.6.3. {color} |
| {color:red}-1{color} | 

[jira] [Updated] (HBASE-12260) MasterServices needs a short-back-and-sides; pare-back exposure of internals and IA.Private classes

2017-10-07 Thread stack (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-12260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-12260:
--
Attachment: HBASE-12260.master.008.patch

> MasterServices needs a short-back-and-sides; pare-back exposure of internals 
> and IA.Private classes
> ---
>
> Key: HBASE-12260
> URL: https://issues.apache.org/jira/browse/HBASE-12260
> Project: HBase
>  Issue Type: Sub-task
>  Components: master
>Reporter: ryan rawson
>Assignee: stack
>Priority: Critical
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-12260.master.001.patch, 
> HBASE-12260.master.002.patch, HBASE-12260.master.003.patch, 
> HBASE-12260.master.004.patch, HBASE-12260.master.005.patch, 
> HBASE-12260.master.006.patch, HBASE-12260.master.007.patch, 
> HBASE-12260.master.008.patch
>
>
> A major issue with MasterServices is the MasterCoprocessorEnvironment exposes 
> this class even though MasterServices is tagged with 
> @InterfaceAudience.Private
> This means that the entire internals of the HMaster is essentially part of 
> the coprocessor API.  Many of the classes returned by the MasterServices API 
> are highly internal, extremely powerful, and subject to constant change.  
> Perhaps a new API to replace MasterServices that is use-case focused, and 
> justified based on real world co-processors would suit things better.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18957) add test that establishes branch-1 behavior for filterlist w/OR

2017-10-07 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195585#comment-16195585
 ] 

Hadoop QA commented on HBASE-18957:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
27s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 2 new or modified test 
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  1m 
20s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  6m 
33s{color} | {color:green} branch-1.4 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
26s{color} | {color:green} branch-1.4 passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
21s{color} | {color:green} branch-1.4 passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
35s{color} | {color:green} branch-1.4 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  1m 
 2s{color} | {color:green} branch-1.4 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
21s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m  
4s{color} | {color:green} branch-1.4 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
12s{color} | {color:green} branch-1.4 passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
19s{color} | {color:green} branch-1.4 passed with JDK v1.7.0_151 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
13s{color} | {color:green} the patch passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
15s{color} | {color:green} the patch passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  2m 
33s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 19m 
32s{color} | {color:red} The patch causes 178 errors with Hadoop v3.0.0-alpha4. 
{color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  5m  
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
7s{color} | {color:green} the patch passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
18s{color} | {color:green} the patch passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  1m 
51s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m  
8s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}402m 19s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} |