[jira] [Commented] (HBASE-21412) HBase putBatch Metrics update date to put Metrics
[
https://issues.apache.org/jira/browse/HBASE-21412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669570#comment-16669570
]
Allan Yang commented on HBASE-21412:
Which branch are you refer to? I don't see this in branch-2.0+.
> HBase putBatch Metrics update date to put Metrics
> -
>
> Key: HBASE-21412
> URL: https://issues.apache.org/jira/browse/HBASE-21412
> Project: HBase
> Issue Type: Bug
> Components: findbugs, metrics
>Reporter: xijiawen
>Priority: Major
>
> org.apache.hadoop.hbase.regionserver
> The method of updatePutBatch execute
> latencies.updatePut(table.getNameAsString(), time)，and
> latencies.updatePutBatch(table.getNameAsString(), time) never be used。It's
> wrong。
> The diff
> {quote}
> -/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/
> RegionServerTableMetrics.java
> + hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/
> RegionServerTableMetrics.java
> public void updatePutBatch(TableName table, long time)
> {
> --- latencies.updatePut(table.getNameAsString(), time);
> +++ latencies.updatePutBatch(table.getNameAsString(), time);
> }
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)
[
https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Reid Chan updated HBASE-21255:
--
Fix Version/s: 2.2.0
3.0.0
> [acl] Refactor TablePermission into three classes (Global, Namespace, Table)
>
>
> Key: HBASE-21255
> URL: https://issues.apache.org/jira/browse/HBASE-21255
> Project: HBase
> Issue Type: Improvement
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: HBASE-21225.master.001.patch,
> HBASE-21225.master.002.patch, HBASE-21255.master.003.patch,
> HBASE-21255.master.004.patch
>
>
> A TODO in {{TablePermission.java}}
> {code:java}
> //TODO refactor this class
> //we need to refacting this into three classes (Global, Table, Namespace)
> {code}
> Change Notes:
> * Divide origin TablePermission into three classes GlobalPermission,
> NamespacePermission, TablePermission
> * New UserPermission consists of a user name and a permission in one of
> [Global, Namespace, Table]Permission.
> * Rename TableAuthManager to AuthManager(it is IA.P), and rename some
> methods for readability.
> * Make PermissionCache thread safe, and the ListMultiMap is changed to Set.
> * User cache and group cache in AuthManager is combined together.
> * Wire proto is kept, BC should be under guarantee。
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)
[
https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Reid Chan updated HBASE-21255:
--
Description:
A TODO in {{TablePermission.java}}
{code:java}
//TODO refactor this class
//we need to refacting this into three classes (Global, Table, Namespace)
{code}
Change Notes:
* Divide origin TablePermission into three classes GlobalPermission,
NamespacePermission, TablePermission
* New UserPermission consists of a user name and a permission in one of
[Global, Namespace, Table]Permission.
* Rename TableAuthManager to AuthManager(it is IA.P), and rename some methods
for readability.
* Make PermissionCache thread safe, and the ListMultiMap is changed to Set.
* User cache and group cache in AuthManager is combined together.
* Wire proto is kept, BC should be under guarantee。
was:
A TODO in {{TablePermission.java}}
{code}
//TODO refactor this class
//we need to refacting this into three classes (Global, Table, Namespace)
{code}
Change Note:
* Divide origin TablePermission into three classes GlobalPermission,
NamespacePermission, TablePermission
* New UserPermission consists of a user name and a permission in one of
[Global, Namespace, Table]Permission.
> [acl] Refactor TablePermission into three classes (Global, Namespace, Table)
>
>
> Key: HBASE-21255
> URL: https://issues.apache.org/jira/browse/HBASE-21255
> Project: HBase
> Issue Type: Improvement
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Attachments: HBASE-21225.master.001.patch,
> HBASE-21225.master.002.patch, HBASE-21255.master.003.patch,
> HBASE-21255.master.004.patch
>
>
> A TODO in {{TablePermission.java}}
> {code:java}
> //TODO refactor this class
> //we need to refacting this into three classes (Global, Table, Namespace)
> {code}
> Change Notes:
> * Divide origin TablePermission into three classes GlobalPermission,
> NamespacePermission, TablePermission
> * New UserPermission consists of a user name and a permission in one of
> [Global, Namespace, Table]Permission.
> * Rename TableAuthManager to AuthManager(it is IA.P), and rename some
> methods for readability.
> * Make PermissionCache thread safe, and the ListMultiMap is changed to Set.
> * User cache and group cache in AuthManager is combined together.
> * Wire proto is kept, BC should be under guarantee。
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-21412) HBase putBatch Metrics update date to put Metrics
[
https://issues.apache.org/jira/browse/HBASE-21412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xijiawen updated HBASE-21412:
-
Description:
org.apache.hadoop.hbase.regionserver
The method of updatePutBatch execute
latencies.updatePut(table.getNameAsString(), time)，and
latencies.updatePutBatch(table.getNameAsString(), time) never be used。It's
wrong。
The diff
{quote}
-/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/
RegionServerTableMetrics.java
+ hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/
RegionServerTableMetrics.java
public void updatePutBatch(TableName table, long time)
{
--- latencies.updatePut(table.getNameAsString(), time);
+++ latencies.updatePutBatch(table.getNameAsString(), time);
}
was:
org.apache.hadoop.hbase.regionserver
The method of updatePutBatch execute
latencies.updatePut(table.getNameAsString(), time)，and
latencies.updatePutBatch(table.getNameAsString(), time) never be used。It's
wrong。
The diff
{quote}
-/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/
RegionServerTableMetrics.java
+ hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/
RegionServerTableMetrics.java
public void updatePutBatch(TableName table, long time)
{
--- latencies.updatePut(table.getNameAsString(), time);
+++ latencies.updatePutBatch(table.getNameAsString(), time);
}
{quote}
> HBase putBatch Metrics update date to put Metrics
> -
>
> Key: HBASE-21412
> URL: https://issues.apache.org/jira/browse/HBASE-21412
> Project: HBase
> Issue Type: Bug
> Components: findbugs, metrics
>Reporter: xijiawen
>Priority: Major
>
> org.apache.hadoop.hbase.regionserver
> The method of updatePutBatch execute
> latencies.updatePut(table.getNameAsString(), time)，and
> latencies.updatePutBatch(table.getNameAsString(), time) never be used。It's
> wrong。
> The diff
> {quote}
> -/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/
> RegionServerTableMetrics.java
> + hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/
> RegionServerTableMetrics.java
> public void updatePutBatch(TableName table, long time)
> {
> --- latencies.updatePut(table.getNameAsString(), time);
> +++ latencies.updatePutBatch(table.getNameAsString(), time);
> }
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-21412) HBase putBatch Metrics update date to put Metrics
[
https://issues.apache.org/jira/browse/HBASE-21412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xijiawen updated HBASE-21412:
-
Description:
org.apache.hadoop.hbase.regionserver
The method of updatePutBatch execute
latencies.updatePut(table.getNameAsString(), time)，and
latencies.updatePutBatch(table.getNameAsString(), time) never be used。It's
wrong。
The diff
{quote}
-/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/
RegionServerTableMetrics.java
+ hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/
RegionServerTableMetrics.java
public void updatePutBatch(TableName table, long time)
{
--- latencies.updatePut(table.getNameAsString(), time);
+++ latencies.updatePutBatch(table.getNameAsString(), time);
}
{quote}
was:
org.apache.hadoop.hbase.regionserver
The method of updatePutBatch execute
latencies.updatePut(table.getNameAsString(), time)，and
latencies.updatePutBatch(table.getNameAsString(), time) never be used。It's
wrong。
The diff
-/hbaseserver/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerTableMetrics.java
+
hbaseserver/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerTableMetrics.java
public void updatePutBatch(TableName table, long time)
{
--- latencies.updatePut(table.getNameAsString(), time);
+++ latencies.updatePutBatch(table.getNameAsString(), time);
}
> HBase putBatch Metrics update date to put Metrics
> -
>
> Key: HBASE-21412
> URL: https://issues.apache.org/jira/browse/HBASE-21412
> Project: HBase
> Issue Type: Bug
> Components: findbugs, metrics
>Reporter: xijiawen
>Priority: Major
>
> org.apache.hadoop.hbase.regionserver
> The method of updatePutBatch execute
> latencies.updatePut(table.getNameAsString(), time)，and
> latencies.updatePutBatch(table.getNameAsString(), time) never be used。It's
> wrong。
> The diff
> {quote}
> -/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/
> RegionServerTableMetrics.java
> + hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/
> RegionServerTableMetrics.java
> public void updatePutBatch(TableName table, long time)
> {
> --- latencies.updatePut(table.getNameAsString(), time);
> +++ latencies.updatePutBatch(table.getNameAsString(), time);
> }
> {quote}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (HBASE-21412) HBase putBatch Metrics update date to put Metrics
xijiawen created HBASE-21412:
Summary: HBase putBatch Metrics update date to put Metrics
Key: HBASE-21412
URL: https://issues.apache.org/jira/browse/HBASE-21412
Project: HBase
Issue Type: Bug
Components: findbugs, metrics
Reporter: xijiawen
org.apache.hadoop.hbase.regionserver
The method of updatePutBatch execute
latencies.updatePut(table.getNameAsString(), time)，and
latencies.updatePutBatch(table.getNameAsString(), time) never be used。It's
wrong。
The diff
-/hbaseserver/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerTableMetrics.java
+
hbaseserver/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerTableMetrics.java
public void updatePutBatch(TableName table, long time)
{
--- latencies.updatePut(table.getNameAsString(), time);
+++ latencies.updatePutBatch(table.getNameAsString(), time);
}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)
[
https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Reid Chan updated HBASE-21255:
--
Attachment: HBASE-21255.master.004.patch
> [acl] Refactor TablePermission into three classes (Global, Namespace, Table)
>
>
> Key: HBASE-21255
> URL: https://issues.apache.org/jira/browse/HBASE-21255
> Project: HBase
> Issue Type: Improvement
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Attachments: HBASE-21225.master.001.patch,
> HBASE-21225.master.002.patch, HBASE-21255.master.003.patch,
> HBASE-21255.master.004.patch
>
>
> A TODO in {{TablePermission.java}}
> {code}
> //TODO refactor this class
> //we need to refacting this into three classes (Global, Table, Namespace)
> {code}
> Change Note:
> * Divide origin TablePermission into three classes GlobalPermission,
> NamespacePermission, TablePermission
> * New UserPermission consists of a user name and a permission in one of
> [Global, Namespace, Table]Permission.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21407) Resolve NPE in backup Master UI
[ https://issues.apache.org/jira/browse/HBASE-21407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669541#comment-16669541 ] Jingyun Tian commented on HBASE-21407: -- [~stack] seems due to OOM. Thanks for your help. > Resolve NPE in backup Master UI > > > Key: HBASE-21407 > URL: https://issues.apache.org/jira/browse/HBASE-21407 > Project: HBase > Issue Type: Bug > Components: UI >Affects Versions: 3.0.0, 2.1.0, 2.2.0 >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Minor > Fix For: 3.0.0, 2.1.0, 2.2.0 > > Attachments: hbase-21407.master.001.patch, > hbase-21407.master.001.patch > > > Since some pages of our UI are using jsp instead of jamon, the fix of > HBASE-18263 is not enough. Added the fix of HBASE-18263 to the header.jsp. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21410) A helper page that help find all problematic regions and procedures
[ https://issues.apache.org/jira/browse/HBASE-21410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669539#comment-16669539 ] Jingyun Tian commented on HBASE-21410: -- [~stack] Haha. RIT queue is a directly translate of how we call the RITs in Chinese. I got your point. I'll try to add the a link of all RITs to table section and also a page of RITs in table x. I'll upload the screen shot and patch later. > A helper page that help find all problematic regions and procedures > --- > > Key: HBASE-21410 > URL: https://issues.apache.org/jira/browse/HBASE-21410 > Project: HBase > Issue Type: Improvement >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Attachments: Screenshot from 2018-10-30 19-06-21.png, Screenshot from > 2018-10-30 19-06-42.png, Screenshot from 2018-10-31 10-11-38.png, Screenshot > from 2018-10-31 10-11-56.png > > > *This page is mainly focus on finding the regions stuck in some state that > cannot be assigned. My proposal of the page is as follows:* > !Screenshot from 2018-10-30 19-06-21.png! > *From this page we can see all regions in RIT queue and their related > procedures. If we can determine that these regions' state are abnormal, we > can click the link 'Procedures as TXT' to get a full list of procedure IDs to > bypass them. Then click 'Regions as TXT' to get a full list of encoded region > names to assign.* > !Screenshot from 2018-10-30 19-06-42.png! > *Some region names are covered by the navigator bar, I'll fix it later.* -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21407) Resolve NPE in backup Master UI
[ https://issues.apache.org/jira/browse/HBASE-21407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669537#comment-16669537 ] stack commented on HBASE-21407: --- +1 on the patch. > Resolve NPE in backup Master UI > > > Key: HBASE-21407 > URL: https://issues.apache.org/jira/browse/HBASE-21407 > Project: HBase > Issue Type: Bug > Components: UI >Affects Versions: 3.0.0, 2.1.0, 2.2.0 >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Minor > Fix For: 3.0.0, 2.1.0, 2.2.0 > > Attachments: hbase-21407.master.001.patch, > hbase-21407.master.001.patch > > > Since some pages of our UI are using jsp instead of jamon, the fix of > HBASE-18263 is not enough. Added the fix of HBASE-18263 to the header.jsp. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21407) Resolve NPE in backup Master UI
[ https://issues.apache.org/jira/browse/HBASE-21407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-21407: -- Attachment: hbase-21407.master.001.patch > Resolve NPE in backup Master UI > > > Key: HBASE-21407 > URL: https://issues.apache.org/jira/browse/HBASE-21407 > Project: HBase > Issue Type: Bug > Components: UI >Affects Versions: 3.0.0, 2.1.0, 2.2.0 >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Minor > Fix For: 3.0.0, 2.1.0, 2.2.0 > > Attachments: hbase-21407.master.001.patch, > hbase-21407.master.001.patch > > > Since some pages of our UI are using jsp instead of jamon, the fix of > HBASE-18263 is not enough. Added the fix of HBASE-18263 to the header.jsp. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21407) Resolve NPE in backup Master UI
[ https://issues.apache.org/jira/browse/HBASE-21407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669531#comment-16669531 ] stack commented on HBASE-21407: --- I can commit it [~tianjingyun]. Why the hbase-server unit test fail? Let me retry it. > Resolve NPE in backup Master UI > > > Key: HBASE-21407 > URL: https://issues.apache.org/jira/browse/HBASE-21407 > Project: HBase > Issue Type: Bug > Components: UI >Affects Versions: 3.0.0, 2.1.0, 2.2.0 >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Minor > Fix For: 3.0.0, 2.1.0, 2.2.0 > > Attachments: hbase-21407.master.001.patch > > > Since some pages of our UI are using jsp instead of jamon, the fix of > HBASE-18263 is not enough. Added the fix of HBASE-18263 to the header.jsp. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21410) A helper page that help find all problematic regions and procedures
[ https://issues.apache.org/jira/browse/HBASE-21410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669530#comment-16669530 ] stack commented on HBASE-21410: --- [~tianjingyun] To be clear, anything you can do will help. Above are just suggestions. If you have better idea, go for it. > A helper page that help find all problematic regions and procedures > --- > > Key: HBASE-21410 > URL: https://issues.apache.org/jira/browse/HBASE-21410 > Project: HBase > Issue Type: Improvement >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Attachments: Screenshot from 2018-10-30 19-06-21.png, Screenshot from > 2018-10-30 19-06-42.png, Screenshot from 2018-10-31 10-11-38.png, Screenshot > from 2018-10-31 10-11-56.png > > > *This page is mainly focus on finding the regions stuck in some state that > cannot be assigned. My proposal of the page is as follows:* > !Screenshot from 2018-10-30 19-06-21.png! > *From this page we can see all regions in RIT queue and their related > procedures. If we can determine that these regions' state are abnormal, we > can click the link 'Procedures as TXT' to get a full list of procedure IDs to > bypass them. Then click 'Regions as TXT' to get a full list of encoded region > names to assign.* > !Screenshot from 2018-10-30 19-06-42.png! > *Some region names are covered by the navigator bar, I'll fix it later.* -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21410) A helper page that help find all problematic regions and procedures
[ https://issues.apache.org/jira/browse/HBASE-21410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669520#comment-16669520 ] stack commented on HBASE-21410: --- bq. But when the number of table is like more than 1000, it seems hard to find all problematic regions? That is true. Our UI needs to scale. When there are 1000s of RITs, it draw little tabs on the bottom. This table stuff should move to another screen rather than be in the home page? If 1000s of tables, that is another issue? We have that problem anyways? For RITs, I think being able to view by table and then for the whole cluster would be good: i.e. a page listing all Regions that are OPENING in table x, then another view that is all OPENING regions on the whole cluster? What is 'RIT Queue'? Do we have to have it along the top? We can't just have links from this table section? > A helper page that help find all problematic regions and procedures > --- > > Key: HBASE-21410 > URL: https://issues.apache.org/jira/browse/HBASE-21410 > Project: HBase > Issue Type: Improvement >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Attachments: Screenshot from 2018-10-30 19-06-21.png, Screenshot from > 2018-10-30 19-06-42.png, Screenshot from 2018-10-31 10-11-38.png, Screenshot > from 2018-10-31 10-11-56.png > > > *This page is mainly focus on finding the regions stuck in some state that > cannot be assigned. My proposal of the page is as follows:* > !Screenshot from 2018-10-30 19-06-21.png! > *From this page we can see all regions in RIT queue and their related > procedures. If we can determine that these regions' state are abnormal, we > can click the link 'Procedures as TXT' to get a full list of procedure IDs to > bypass them. Then click 'Regions as TXT' to get a full list of encoded region > names to assign.* > !Screenshot from 2018-10-30 19-06-42.png! > *Some region names are covered by the navigator bar, I'll fix it later.* -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21393) Add an API ScheduleSCP() to HBCK2
[ https://issues.apache.org/jira/browse/HBASE-21393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669519#comment-16669519 ] Jingyun Tian commented on HBASE-21393: -- [~stack] Thanks for your review. I'll modify the code based on these. > Add an API ScheduleSCP() to HBCK2 > -- > > Key: HBASE-21393 > URL: https://issues.apache.org/jira/browse/HBASE-21393 > Project: HBase > Issue Type: Sub-task > Components: hbase-operator-tools, hbck2 >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Attachments: 0001-HBASE-21393-Add-an-API-ScheduleSCP-to-HBCK2.patch > > > Add the API of ScheduleSCP() to hbase-operator-tools so that operators can > schedule ServerCrashProcedures of specified regionservers. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21407) Resolve NPE in backup Master UI
[ https://issues.apache.org/jira/browse/HBASE-21407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669515#comment-16669515 ] Ted Yu commented on HBASE-21407: [~openinx]: Can you commit this patch ? Thanks > Resolve NPE in backup Master UI > > > Key: HBASE-21407 > URL: https://issues.apache.org/jira/browse/HBASE-21407 > Project: HBase > Issue Type: Bug > Components: UI >Affects Versions: 3.0.0, 2.1.0, 2.2.0 >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Minor > Fix For: 3.0.0, 2.1.0, 2.2.0 > > Attachments: hbase-21407.master.001.patch > > > Since some pages of our UI are using jsp instead of jamon, the fix of > HBASE-18263 is not enough. Added the fix of HBASE-18263 to the header.jsp. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21407) Resolve NPE in backup Master UI
[ https://issues.apache.org/jira/browse/HBASE-21407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669511#comment-16669511 ] Jingyun Tian commented on HBASE-21407: -- Thanks a lot. Could you help commit this patch? > Resolve NPE in backup Master UI > > > Key: HBASE-21407 > URL: https://issues.apache.org/jira/browse/HBASE-21407 > Project: HBase > Issue Type: Bug > Components: UI >Affects Versions: 3.0.0, 2.1.0, 2.2.0 >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Minor > Fix For: 3.0.0, 2.1.0, 2.2.0 > > Attachments: hbase-21407.master.001.patch > > > Since some pages of our UI are using jsp instead of jamon, the fix of > HBASE-18263 is not enough. Added the fix of HBASE-18263 to the header.jsp. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21410) A helper page that help find all problematic regions and procedures
[ https://issues.apache.org/jira/browse/HBASE-21410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669509#comment-16669509 ] Jingyun Tian commented on HBASE-21410: -- [~stack] yes, RIT Queue is the new Item. For Master UI, there is already a section to show regions in transition. But it is not complete. !Screenshot from 2018-10-31 10-11-56.png! Do you mean make the number of table section a link to this page? It sounds good. But when the number of table is like more than 1000, it seems hard to find all problematic regions? I actually shows the region's table, state, related procedure and its state in the page. The screen shot is too big to see. !Screenshot from 2018-10-31 10-11-38.png! Do you mean show these too when we list regions as txt? For procedures, my point is to easily find these stuck procedures related to region assignment. It is also reasonable to put this in procedures page. What do you think? Thanks for your review. > A helper page that help find all problematic regions and procedures > --- > > Key: HBASE-21410 > URL: https://issues.apache.org/jira/browse/HBASE-21410 > Project: HBase > Issue Type: Improvement >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Attachments: Screenshot from 2018-10-30 19-06-21.png, Screenshot from > 2018-10-30 19-06-42.png, Screenshot from 2018-10-31 10-11-38.png, Screenshot > from 2018-10-31 10-11-56.png > > > *This page is mainly focus on finding the regions stuck in some state that > cannot be assigned. My proposal of the page is as follows:* > !Screenshot from 2018-10-30 19-06-21.png! > *From this page we can see all regions in RIT queue and their related > procedures. If we can determine that these regions' state are abnormal, we > can click the link 'Procedures as TXT' to get a full list of procedure IDs to > bypass them. Then click 'Regions as TXT' to get a full list of encoded region > names to assign.* > !Screenshot from 2018-10-30 19-06-42.png! > *Some region names are covered by the navigator bar, I'll fix it later.* -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21410) A helper page that help find all problematic regions and procedures
[ https://issues.apache.org/jira/browse/HBASE-21410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-21410: - Attachment: Screenshot from 2018-10-31 10-11-38.png > A helper page that help find all problematic regions and procedures > --- > > Key: HBASE-21410 > URL: https://issues.apache.org/jira/browse/HBASE-21410 > Project: HBase > Issue Type: Improvement >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Attachments: Screenshot from 2018-10-30 19-06-21.png, Screenshot from > 2018-10-30 19-06-42.png, Screenshot from 2018-10-31 10-11-38.png, Screenshot > from 2018-10-31 10-11-56.png > > > *This page is mainly focus on finding the regions stuck in some state that > cannot be assigned. My proposal of the page is as follows:* > !Screenshot from 2018-10-30 19-06-21.png! > *From this page we can see all regions in RIT queue and their related > procedures. If we can determine that these regions' state are abnormal, we > can click the link 'Procedures as TXT' to get a full list of procedure IDs to > bypass them. Then click 'Regions as TXT' to get a full list of encoded region > names to assign.* > !Screenshot from 2018-10-30 19-06-42.png! > *Some region names are covered by the navigator bar, I'll fix it later.* -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21410) A helper page that help find all problematic regions and procedures
[ https://issues.apache.org/jira/browse/HBASE-21410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-21410: - Attachment: Screenshot from 2018-10-31 10-11-56.png > A helper page that help find all problematic regions and procedures > --- > > Key: HBASE-21410 > URL: https://issues.apache.org/jira/browse/HBASE-21410 > Project: HBase > Issue Type: Improvement >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Attachments: Screenshot from 2018-10-30 19-06-21.png, Screenshot from > 2018-10-30 19-06-42.png, Screenshot from 2018-10-31 10-11-56.png > > > *This page is mainly focus on finding the regions stuck in some state that > cannot be assigned. My proposal of the page is as follows:* > !Screenshot from 2018-10-30 19-06-21.png! > *From this page we can see all regions in RIT queue and their related > procedures. If we can determine that these regions' state are abnormal, we > can click the link 'Procedures as TXT' to get a full list of procedure IDs to > bypass them. Then click 'Regions as TXT' to get a full list of encoded region > names to assign.* > !Screenshot from 2018-10-30 19-06-42.png! > *Some region names are covered by the navigator bar, I'll fix it later.* -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21388) No need to instantiate MemStoreLAB for master which not carry table
[ https://issues.apache.org/jira/browse/HBASE-21388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-21388: --- Attachment: HBASE-21388.master.004.patch > No need to instantiate MemStoreLAB for master which not carry table > --- > > Key: HBASE-21388 > URL: https://issues.apache.org/jira/browse/HBASE-21388 > Project: HBase > Issue Type: Improvement >Affects Versions: 3.0.0, 2.2.0, 2.1.1, 2.0.2 >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Major > Attachments: HBASE-21388.master.001.patch, > HBASE-21388.master.002.patch, HBASE-21388.master.003.patch, > HBASE-21388.master.004.patch > > > We found this log in our master. > 2018-10-26,10:00:00,449 INFO > [master/c4-hadoop-tst-ct16:42900:becomeActiveMaster] > org.apache.hadoop.hbase.regionserver.ChunkCreator: Allocating data > MemStoreChunkPool with chunk size 2 MB, max count 737, initial count 0 > 2018-10-26,10:00:00,452 INFO > [master/c4-hadoop-tst-ct16:42900:becomeActiveMaster] > org.apache.hadoop.hbase.regionserver.ChunkCreator: Allocating index > MemStoreChunkPool with chunk size 204.80 KB, max count 819, initial count 0 > > Same with HBASE-21290, we don't need to instantiate MemStore for master which > not carry table. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21407) Resolve NPE in backup Master UI
[ https://issues.apache.org/jira/browse/HBASE-21407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669505#comment-16669505 ] Ted Yu commented on HBASE-21407: lgtm > Resolve NPE in backup Master UI > > > Key: HBASE-21407 > URL: https://issues.apache.org/jira/browse/HBASE-21407 > Project: HBase > Issue Type: Bug > Components: UI >Affects Versions: 3.0.0, 2.1.0, 2.2.0 >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Minor > Fix For: 3.0.0, 2.1.0, 2.2.0 > > Attachments: hbase-21407.master.001.patch > > > Since some pages of our UI are using jsp instead of jamon, the fix of > HBASE-18263 is not enough. Added the fix of HBASE-18263 to the header.jsp. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21351) The force update thread may have race with PE worker when the procedure is rolling back
[ https://issues.apache.org/jira/browse/HBASE-21351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669501#comment-16669501 ] Duo Zhang commented on HBASE-21351: --- Review board link: https://reviews.apache.org/r/69219/ > The force update thread may have race with PE worker when the procedure is > rolling back > --- > > Key: HBASE-21351 > URL: https://issues.apache.org/jira/browse/HBASE-21351 > Project: HBase > Issue Type: Sub-task > Components: proc-v2 >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Critical > Fix For: 3.0.0, 2.2.0, 2.0.3, 2.1.2 > > Attachments: HBASE-21351-v1.patch, HBASE-21351.patch > > > We will acquire the procExecutionLock for a procedure when force updating its > state to prevent race with PE worker, but this does not work then the > procedure is rolling back. > If a procedure is failed, we will mark the root procedure stack as FAILED, > and then start to rollback the whole procedure stack. We will pop every > procedure in the stack and try to rollback them. So we may change the state > of a procedure without holding its procExecutionLock when rolling back. > This means we may persist an intermediate state of a procedure and cause > corruption when loading procedures. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21407) Resolve NPE in backup Master UI
[ https://issues.apache.org/jira/browse/HBASE-21407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669498#comment-16669498 ] Jingyun Tian commented on HBASE-21407: -- [~yuzhih...@gmail.com] Could you help check this out? > Resolve NPE in backup Master UI > > > Key: HBASE-21407 > URL: https://issues.apache.org/jira/browse/HBASE-21407 > Project: HBase > Issue Type: Bug > Components: UI >Affects Versions: 3.0.0, 2.1.0, 2.2.0 >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Minor > Fix For: 3.0.0, 2.1.0, 2.2.0 > > Attachments: hbase-21407.master.001.patch > > > Since some pages of our UI are using jsp instead of jamon, the fix of > HBASE-18263 is not enough. Added the fix of HBASE-18263 to the header.jsp. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21351) The force update thread may have race with PE worker when the procedure is rolling back
[ https://issues.apache.org/jira/browse/HBASE-21351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-21351: -- Attachment: HBASE-21351-v1.patch > The force update thread may have race with PE worker when the procedure is > rolling back > --- > > Key: HBASE-21351 > URL: https://issues.apache.org/jira/browse/HBASE-21351 > Project: HBase > Issue Type: Sub-task > Components: proc-v2 >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Critical > Fix For: 3.0.0, 2.2.0, 2.0.3, 2.1.2 > > Attachments: HBASE-21351-v1.patch, HBASE-21351.patch > > > We will acquire the procExecutionLock for a procedure when force updating its > state to prevent race with PE worker, but this does not work then the > procedure is rolling back. > If a procedure is failed, we will mark the root procedure stack as FAILED, > and then start to rollback the whole procedure stack. We will pop every > procedure in the stack and try to rollback them. So we may change the state > of a procedure without holding its procExecutionLock when rolling back. > This means we may persist an intermediate state of a procedure and cause > corruption when loading procedures. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21389) Revisit the procedure lock for sync replication
[
https://issues.apache.org/jira/browse/HBASE-21389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669449#comment-16669449
]
Hudson commented on HBASE-21389:
Results for branch master
[build #577 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/577/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Revisit the procedure lock for sync replication
> ---
>
> Key: HBASE-21389
> URL: https://issues.apache.org/jira/browse/HBASE-21389
> Project: HBase
> Issue Type: Sub-task
> Components: proc-v2, Replication
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-21389-v1.patch, HBASE-21389-v1.patch,
> HBASE-21389.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21237) Use CompatRemoteProcedureResolver to dispatch open/close region requests to RS
[
https://issues.apache.org/jira/browse/HBASE-21237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669448#comment-16669448
]
Hudson commented on HBASE-21237:
Results for branch branch-2.0
[build #1038 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1038/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1005//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1005//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1005//JDK8_Nightly_Build_Report_(Hadoop3)/]
(x) {color:red}-1 source release artifact{color}
-- See build output for details.
> Use CompatRemoteProcedureResolver to dispatch open/close region requests to RS
> --
>
> Key: HBASE-21237
> URL: https://issues.apache.org/jira/browse/HBASE-21237
> Project: HBase
> Issue Type: Sub-task
>Affects Versions: 2.1.0, 2.0.2
>Reporter: Allan Yang
>Assignee: Allan Yang
>Priority: Blocker
> Fix For: 2.0.3, 2.1.2
>
> Attachments: HBASE-21237-branch-2.1-v1.patch,
> HBASE-21237-branch-2.1.patch, HBASE-21237.branch-2.0.001.patch
>
>
> As discussed in HBASE-21217, in branch-2.0 and branch-2.1, we should use
> CompatRemoteProcedureResolver instead of ExecuteProceduresRemoteCall to
> dispatch region open/close requests to RS. Since ExecuteProceduresRemoteCall
> will group all the open/close operations in one call and execute them
> sequentially on the target RS. If one operation fails, all the operation will
> be marked as failure. Actually, some of the operations(like open region) is
> already executing in the open region handler thread. But master thinks these
> operations fails and reassign the regions to another RS. So when the previous
> RS report to the master that the region is online, master will kill the RS
> since it already assign the region to another RS.
> For branch-2.2+, HBASE-21217 will fix this issue.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-21411) Need to document the snapshot metric data that is shown in HBase Master Web UI
[ https://issues.apache.org/jira/browse/HBASE-21411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roland Teague updated HBASE-21411: -- Flags: (was: Patch) > Need to document the snapshot metric data that is shown in HBase Master Web UI > -- > > Key: HBASE-21411 > URL: https://issues.apache.org/jira/browse/HBASE-21411 > Project: HBase > Issue Type: Improvement > Components: documentation >Affects Versions: 1.3.0, 2.0.0 >Reporter: Roland Teague >Priority: Major > Attachments: HBASE-21411.master.001.patch > > > We need to add documentation into the Reference Guide for the work that was > done in HBASE-15415. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21411) Need to document the snapshot metric data that is shown in HBase Master Web UI
[ https://issues.apache.org/jira/browse/HBASE-21411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roland Teague updated HBASE-21411: -- Flags: Patch > Need to document the snapshot metric data that is shown in HBase Master Web UI > -- > > Key: HBASE-21411 > URL: https://issues.apache.org/jira/browse/HBASE-21411 > Project: HBase > Issue Type: Improvement > Components: documentation >Affects Versions: 1.3.0, 2.0.0 >Reporter: Roland Teague >Priority: Major > Attachments: HBASE-21411.master.001.patch > > > We need to add documentation into the Reference Guide for the work that was > done in HBASE-15415. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21411) Need to document the snapshot metric data that is shown in HBase Master Web UI
[ https://issues.apache.org/jira/browse/HBASE-21411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669430#comment-16669430 ] Roland Teague commented on HBASE-21411: --- I have submitted a patch for the HBase Ref Guide for this doc update. I've added the documentation for Snapshot usage data in the "HBase Monitoring" section under Apache HBase Operational Management. If there is a more appropriate section please let me know. I've included the binary png images in the patch file. > Need to document the snapshot metric data that is shown in HBase Master Web UI > -- > > Key: HBASE-21411 > URL: https://issues.apache.org/jira/browse/HBASE-21411 > Project: HBase > Issue Type: Improvement > Components: documentation >Affects Versions: 1.3.0, 2.0.0 >Reporter: Roland Teague >Priority: Major > Attachments: HBASE-21411.master.001.patch > > > We need to add documentation into the Reference Guide for the work that was > done in HBASE-15415. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21411) Need to document the snapshot metric data that is shown in HBase Master Web UI
[ https://issues.apache.org/jira/browse/HBASE-21411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roland Teague updated HBASE-21411: -- Attachment: HBASE-21411.master.001.patch > Need to document the snapshot metric data that is shown in HBase Master Web UI > -- > > Key: HBASE-21411 > URL: https://issues.apache.org/jira/browse/HBASE-21411 > Project: HBase > Issue Type: Improvement > Components: documentation >Affects Versions: 1.3.0, 2.0.0 >Reporter: Roland Teague >Priority: Major > Attachments: HBASE-21411.master.001.patch > > > We need to add documentation into the Reference Guide for the work that was > done in HBASE-15415. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (HBASE-21411) Need to document the snapshot metric data that is shown in HBase Master Web UI
Roland Teague created HBASE-21411: - Summary: Need to document the snapshot metric data that is shown in HBase Master Web UI Key: HBASE-21411 URL: https://issues.apache.org/jira/browse/HBASE-21411 Project: HBase Issue Type: Improvement Components: documentation Affects Versions: 2.0.0, 1.3.0 Reporter: Roland Teague We need to add documentation into the Reference Guide for the work that was done in HBASE-15415. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (HBASE-21141) Enable MOB in backup / restore test involving incremental backup
[ https://issues.apache.org/jira/browse/HBASE-21141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Artem Ervits reassigned HBASE-21141: Assignee: Artem Ervits > Enable MOB in backup / restore test involving incremental backup > > > Key: HBASE-21141 > URL: https://issues.apache.org/jira/browse/HBASE-21141 > Project: HBase > Issue Type: Test > Components: backuprestore >Reporter: Ted Yu >Assignee: Artem Ervits >Priority: Major > Labels: mob > > Currently we only have one test (TestRemoteBackup) where MOB feature is > enabled. The test only performs full backup. > This issue is to enable MOB in backup / restore test(s) involving incremental > backup. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (HBASE-21405) [DOC] Add Details about Output of "status 'replication'"
[
https://issues.apache.org/jira/browse/HBASE-21405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wellington Chevreuil reassigned HBASE-21405:
Assignee: Wellington Chevreuil
> [DOC] Add Details about Output of "status 'replication'"
>
>
> Key: HBASE-21405
> URL: https://issues.apache.org/jira/browse/HBASE-21405
> Project: HBase
> Issue Type: Improvement
> Components: documentation
>Affects Versions: 1.2.0, 1.4.0, 2.0.0
>Reporter: Daisuke Kobayashi
>Assignee: Wellington Chevreuil
>Priority: Minor
>
> Add more information about the meaning of each metric on to
> [http://hbase.apache.org/book.html#_monitoring_replication_status].
> {noformat}
> SOURCE:
> PeerID
> AgeOfLastShippedOp
> SizeOfLogQueue
> TimeStampsOfLastShippedOp
> Replication Lag
> SINK
> AgeOfLastAppliedOp
> TimeStampsOfLastAppliedOp
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (HBASE-21406) "status 'replication'" should not show SINK if the cluster does not act as sink
[
https://issues.apache.org/jira/browse/HBASE-21406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wellington Chevreuil reassigned HBASE-21406:
Assignee: Wellington Chevreuil
> "status 'replication'" should not show SINK if the cluster does not act as
> sink
> ---
>
> Key: HBASE-21406
> URL: https://issues.apache.org/jira/browse/HBASE-21406
> Project: HBase
> Issue Type: Improvement
>Reporter: Daisuke Kobayashi
>Assignee: Wellington Chevreuil
>Priority: Minor
>
> When replicating in 1 way, from source to target, {{status 'replication'}} on
> source always dumps SINK with meaningless metrics. It only makes sense when
> running the command on target cluster.
> {{status 'replication'}} on source, for example. {{AgeOfLastAppliedOp}} is
> always zero and {{TimeStampsOfLastAppliedOp}} does not get updated from the
> time the RS started since it's not acting as sink.
> {noformat}
> source-1.com
>SOURCE: PeerID=1, AgeOfLastShippedOp=0, SizeOfLogQueue=0,
> TimeStampsOfLastShippedOp=Mon Oct 29 23:44:14 PDT 2018, Replication Lag=0
>SINK : AgeOfLastAppliedOp=0, TimeStampsOfLastAppliedOp=Thu Oct 25
> 23:56:53 PDT 2018
> {noformat}
> {{status 'replication'}} on target works as expected. SOURCE is empty as it's
> not acting as source:
> {noformat}
> target-1.com
>SOURCE:
>SINK : AgeOfLastAppliedOp=70, TimeStampsOfLastAppliedOp=Mon Oct 29
> 23:44:08 PDT 2018
> {noformat}
> This is because {{getReplicationLoadSink}}, called in {{admin.rb}}, always
> returns a value (not null).
> 1.X
> https://github.com/apache/hbase/blob/rel/1.4.0/hbase-client/src/main/java/org/apache/hadoop/hbase/ServerLoad.java#L194-L204
> 2.X
> https://github.com/apache/hbase/blob/rel/2.0.0/hbase-client/src/main/java/org/apache/hadoop/hbase/ServerLoad.java#L392-L399
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21131) HBase shell 'status replication' command does not track recovery replication in sizeOfLogQueue
[ https://issues.apache.org/jira/browse/HBASE-21131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669267#comment-16669267 ] Wellington Chevreuil commented on HBASE-21131: -- I believe this is a duplicate of HBASE-16870, where the issue is apparently fixed by the extra account for metrics of recovery queues sources. > HBase shell 'status replication' command does not track recovery replication > in sizeOfLogQueue > -- > > Key: HBASE-21131 > URL: https://issues.apache.org/jira/browse/HBASE-21131 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.0 >Reporter: Mitch Barnett >Assignee: Guangxu Cheng >Priority: Minor > > If replication is enabled for HBase and a RegionServer is restarted, it's > replication queue will be moved to another RegionServer. > When checking the 'dumpReplicationQueue' output, it's clearly visible the > total size of the recovery replication which is left on the RegionServer that > took over. > However, the 'status replication' command in hbase shell does not list any > difference in the 'sizeOfLogQueue' - in most cases it remains at or near 0. > Filing this JIRA as a bug since (in theory) 'status replication' should > include that recovered replication queue in the sizeOfLogQueue output. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)
[
https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669254#comment-16669254
]
Hadoop QA commented on HBASE-21255:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
19s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 8 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
25s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
10s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
26s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
23s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
13s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
0s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
25s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
15s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
26s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 1m 46s{color}
| {color:red} hbase-server generated 3 new + 185 unchanged - 3 fixed = 188
total (was 188) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
34s{color} | {color:red} hbase-client: The patch generated 7 new + 79 unchanged
- 30 fixed = 86 total (was 109) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
12s{color} | {color:red} hbase-server: The patch generated 4 new + 101
unchanged - 53 fixed = 105 total (was 154) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
14s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
10m 28s{color} | {color:green} Patch does not cause any errors with Hadoop
2.7.4 or 3.0.0. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m
3s{color} | {color:red} hbase-client generated 1 new + 0 unchanged - 0 fixed =
1 total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
24s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 30s{color}
| {color:red} hbase-common in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 32s{color}
| {color:red} hbase-client in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 3m 38s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 24s{color}
| {color:red} hbase-rsgroup in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
36s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 60m 6s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hbase-client |
| | Equals method for org.apache.hadoop.hbase.security.access.Permission
assumes the argument is of type Permission At
[jira] [Commented] (HBASE-21410) A helper page that help find all problematic regions and procedures
[ https://issues.apache.org/jira/browse/HBASE-21410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669126#comment-16669126 ] stack commented on HBASE-21410: --- "RIT Queue" is new item along top? How is this related to the Tables section down the Master UI home page? When we list the regions, we should say their state too? Table? Or in the tables panel on home page, you'd choose table and state? Procedures as text? Should that be off the Procedures page? Looks good sir. > A helper page that help find all problematic regions and procedures > --- > > Key: HBASE-21410 > URL: https://issues.apache.org/jira/browse/HBASE-21410 > Project: HBase > Issue Type: Improvement >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Attachments: Screenshot from 2018-10-30 19-06-21.png, Screenshot from > 2018-10-30 19-06-42.png > > > *This page is mainly focus on finding the regions stuck in some state that > cannot be assigned. My proposal of the page is as follows:* > !Screenshot from 2018-10-30 19-06-21.png! > *From this page we can see all regions in RIT queue and their related > procedures. If we can determine that these regions' state are abnormal, we > can click the link 'Procedures as TXT' to get a full list of procedure IDs to > bypass them. Then click 'Regions as TXT' to get a full list of encoded region > names to assign.* > !Screenshot from 2018-10-30 19-06-42.png! > *Some region names are covered by the navigator bar, I'll fix it later.* -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21351) The force update thread may have race with PE worker when the procedure is rolling back
[
https://issues.apache.org/jira/browse/HBASE-21351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669069#comment-16669069
]
Hadoop QA commented on HBASE-21351:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
28s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
28s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
49s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
37s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
17s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
0s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
30s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
48s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
13s{color} | {color:red} hbase-procedure: The patch generated 1 new + 8
unchanged - 0 fixed = 9 total (was 8) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
17s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
10m 51s{color} | {color:green} Patch does not cause any errors with Hadoop
2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
30s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 29s{color}
| {color:red} hbase-common in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 21s{color}
| {color:red} hbase-procedure in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
17s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 38m 56s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
| JIRA Issue | HBASE-21351 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12946183/HBASE-21351.patch |
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux c05f4b11a8f5 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14
08:52:28 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 02f5f171f5 |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
[jira] [Commented] (HBASE-21246) Introduce WALIdentity interface
[ https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669058#comment-16669058 ] stack commented on HBASE-21246: --- bq. But WAL system's architecture is not very clear, and api/class abstraction which it is very important IMO is not clean enough, as well as the relations/work flows between WALFactory/WAL/WALIdentity/WAL***.class. (Hoping diagrams will help!) bq. However, we are so eager to taste the fruit of the WAL system that had started quickly and bumps into a lot of details at the beginning which i doubt it is a good thing. bq. What about just introducing WALIdentity interface and implementing related abstract classes with some TestMockImpl(or TestFSBasedImpl) to show what apis looks like, rather than embedding into code base immediately, it may help us discussions, reviews and collating with the design docs. That sounds like a sensible approach (including diagrams bit.. ). [~reidchan] doing it doesn't seem right though. > Introduce WALIdentity interface > --- > > Key: HBASE-21246 > URL: https://issues.apache.org/jira/browse/HBASE-21246 > Project: HBase > Issue Type: Sub-task >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Major > Fix For: HBASE-20952 > > Attachments: 21246.003.patch, 21246.20.txt, 21246.21.txt, > 21246.23.txt, 21246.HBASE-20952.001.patch, 21246.HBASE-20952.002.patch, > 21246.HBASE-20952.004.patch, 21246.HBASE-20952.005.patch, > 21246.HBASE-20952.007.patch, 21246.HBASE-20952.008.patch > > > We are introducing WALIdentity interface so that the WAL representation can > be decoupled from distributed filesystem. > The interface provides getName method whose return value can represent > filename in distributed filesystem environment or, the name of the stream > when the WAL is backed by log stream. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21408) Add hbase.wal.dir clean operation also to hbase cleanup script.
[
https://issues.apache.org/jira/browse/HBASE-21408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669034#comment-16669034
]
Hadoop QA commented on HBASE-21408:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
26s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m
1s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:red}-1{color} | {color:red} shellcheck {color} | {color:red} 0m
2s{color} | {color:red} The patch generated 2 new + 57 unchanged - 0 fixed = 59
total (was 57) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
16s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 1m 1s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
| JIRA Issue | HBASE-21408 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12946190/HBASE-21408.001.patch
|
| Optional Tests | dupname asflicense shellcheck shelldocs |
| uname | Linux af0aedaaebee 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14
08:52:28 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 02f5f171f5 |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| shellcheck | v0.4.4 |
| shellcheck |
https://builds.apache.org/job/PreCommit-HBASE-Build/14902/artifact/patchprocess/diff-patch-shellcheck.txt
|
| Max. process+thread count | 43 (vs. ulimit of 1) |
| modules | C: . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/14902/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> Add hbase.wal.dir clean operation also to hbase cleanup script.
> ---
>
> Key: HBASE-21408
> URL: https://issues.apache.org/jira/browse/HBASE-21408
> Project: HBase
> Issue Type: Improvement
> Components: scripts
>Affects Versions: 2.1.0
>Reporter: Y. SREENIVASULU REDDY
>Priority: Major
> Fix For: 2.1.1
>
> Attachments: HBASE-21408.001.patch
>
>
> If user configured hbase.wal.dir explicitly.
> cleaning scripts should handle this too.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21407) Resolve NPE in backup Master UI
[
https://issues.apache.org/jira/browse/HBASE-21407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669030#comment-16669030
]
Hadoop QA commented on HBASE-21407:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
13s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
30s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
29s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 3m 28s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
10s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 15m 33s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
| JIRA Issue | HBASE-21407 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12946182/hbase-21407.master.001.patch
|
| Optional Tests | dupname asflicense javac javadoc unit |
| uname | Linux b69141b13376 3.13.0-143-generic #192-Ubuntu SMP Tue Feb 27
10:45:36 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 02f5f171f5 |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/14900/artifact/patchprocess/patch-unit-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/14900/testReport/ |
| Max. process+thread count | 89 (vs. ulimit of 1) |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/14900/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> Resolve NPE in backup Master UI
>
>
> Key: HBASE-21407
> URL: https://issues.apache.org/jira/browse/HBASE-21407
> Project: HBase
> Issue Type: Bug
> Components: UI
>Affects Versions: 3.0.0, 2.1.0, 2.2.0
>Reporter: Jingyun Tian
>Assignee: Jingyun Tian
>Priority: Minor
> Fix For: 3.0.0, 2.1.0, 2.2.0
>
> Attachments: hbase-21407.master.001.patch
>
>
> Since some pages of our UI are using jsp instead of jamon, the fix of
> HBASE-18263 is not enough. Added the fix of HBASE-18263 to the header.jsp.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21246) Introduce WALIdentity interface
[ https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668955#comment-16668955 ] Ted Yu commented on HBASE-21246: bq. Missed push-down into WALProvider The push-down is implemented in patch v23. > Introduce WALIdentity interface > --- > > Key: HBASE-21246 > URL: https://issues.apache.org/jira/browse/HBASE-21246 > Project: HBase > Issue Type: Sub-task >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Major > Fix For: HBASE-20952 > > Attachments: 21246.003.patch, 21246.20.txt, 21246.21.txt, > 21246.23.txt, 21246.HBASE-20952.001.patch, 21246.HBASE-20952.002.patch, > 21246.HBASE-20952.004.patch, 21246.HBASE-20952.005.patch, > 21246.HBASE-20952.007.patch, 21246.HBASE-20952.008.patch > > > We are introducing WALIdentity interface so that the WAL representation can > be decoupled from distributed filesystem. > The interface provides getName method whose return value can represent > filename in distributed filesystem environment or, the name of the stream > when the WAL is backed by log stream. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21246) Introduce WALIdentity interface
[ https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21246: --- Attachment: 21246.23.txt > Introduce WALIdentity interface > --- > > Key: HBASE-21246 > URL: https://issues.apache.org/jira/browse/HBASE-21246 > Project: HBase > Issue Type: Sub-task >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Major > Fix For: HBASE-20952 > > Attachments: 21246.003.patch, 21246.20.txt, 21246.21.txt, > 21246.23.txt, 21246.HBASE-20952.001.patch, 21246.HBASE-20952.002.patch, > 21246.HBASE-20952.004.patch, 21246.HBASE-20952.005.patch, > 21246.HBASE-20952.007.patch, 21246.HBASE-20952.008.patch > > > We are introducing WALIdentity interface so that the WAL representation can > be decoupled from distributed filesystem. > The interface provides getName method whose return value can represent > filename in distributed filesystem environment or, the name of the stream > when the WAL is backed by log stream. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21393) Add an API ScheduleSCP() to HBCK2
[ https://issues.apache.org/jira/browse/HBASE-21393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668949#comment-16668949 ] stack commented on HBASE-21393: --- I took a look at our Admin and HBaseAdmin implementation and at Table and HTable. They use our internal protobuf internally so it ok for you to do same. So, leave it. Our proto files are part of our For guava, we should say what version we want in local pom rather than rely on transitive include or depend on the internal hbase version by doing import org.apache.hbase.shaded.com.google.common.collect.Lists; Can do the guava dependency in a follow-on? Rather than this: private static final String SCHEDULE_SCP = "scheduleSCP"; ... perhaps do private static final String SCHEDULE_SCP = "serverCrashProcedures"; Make it plural like assigns and unassigns. In the help say something like below to explain 'SCP'. " Schedule serverCrashProcedure (SCP) for specified ServerName." ... then you can use SCP in the rest of the help text in place of serverCrashProcedures. Thanks [~tianjingyun] > Add an API ScheduleSCP() to HBCK2 > -- > > Key: HBASE-21393 > URL: https://issues.apache.org/jira/browse/HBASE-21393 > Project: HBase > Issue Type: Sub-task > Components: hbase-operator-tools, hbck2 >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Attachments: 0001-HBASE-21393-Add-an-API-ScheduleSCP-to-HBCK2.patch > > > Add the API of ScheduleSCP() to hbase-operator-tools so that operators can > schedule ServerCrashProcedures of specified regionservers. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21246) Introduce WALIdentity interface
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668840#comment-16668840
]
Ted Yu commented on HBASE-21246:
bq. This is extracting the creation time, right?
The start time is extracted.
Good catch, rewritten in patch v21 with {{walProvider.getWALStartTime}}.
bq. to make sure we aren't breaking what he and Zach are doing
Agreed.
>From my investigation so far, there is no conflict between WAL refactoring and
>what's in place on the master branch.
With HBASE-20734, the location for WAL and recovered edits is unified. This
actually benefits WAL refactoring - we can get FileSystem from WAL Identity
(Path).
> Introduce WALIdentity interface
> ---
>
> Key: HBASE-21246
> URL: https://issues.apache.org/jira/browse/HBASE-21246
> Project: HBase
> Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Major
> Fix For: HBASE-20952
>
> Attachments: 21246.003.patch, 21246.20.txt, 21246.21.txt,
> 21246.HBASE-20952.001.patch, 21246.HBASE-20952.002.patch,
> 21246.HBASE-20952.004.patch, 21246.HBASE-20952.005.patch,
> 21246.HBASE-20952.007.patch, 21246.HBASE-20952.008.patch
>
>
> We are introducing WALIdentity interface so that the WAL representation can
> be decoupled from distributed filesystem.
> The interface provides getName method whose return value can represent
> filename in distributed filesystem environment or, the name of the stream
> when the WAL is backed by log stream.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-21246) Introduce WALIdentity interface
[ https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21246: --- Attachment: 21246.21.txt > Introduce WALIdentity interface > --- > > Key: HBASE-21246 > URL: https://issues.apache.org/jira/browse/HBASE-21246 > Project: HBase > Issue Type: Sub-task >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Major > Fix For: HBASE-20952 > > Attachments: 21246.003.patch, 21246.20.txt, 21246.21.txt, > 21246.HBASE-20952.001.patch, 21246.HBASE-20952.002.patch, > 21246.HBASE-20952.004.patch, 21246.HBASE-20952.005.patch, > 21246.HBASE-20952.007.patch, 21246.HBASE-20952.008.patch > > > We are introducing WALIdentity interface so that the WAL representation can > be decoupled from distributed filesystem. > The interface provides getName method whose return value can represent > filename in distributed filesystem environment or, the name of the stream > when the WAL is backed by log stream. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21246) Introduce WALIdentity interface
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668830#comment-16668830
]
Ted Yu commented on HBASE-21246:
Thanks for detailed comments, Josh.
bq. This still banks on the assumption that recovered.edits are always on the
storefile FS?
To be more precise, the assumption is that recovered.edits are always on the
FileSystem specified by hbase.wal.dir config.
See HBASE-20734
bq. Is there a reason to keep the static "helper" methods around?
The number of static methods for creating Reader has been reduced to 1.
Without this, many classes would have to create WALFactory, get hold of
WALProvider and call createReader on the provider.
I think having 1 static method is equivalent to the above.
bq. You couldn't possibly know that this is a SyncReplicationWALProvider?
The getFullPath and getWalFromArchivePath methods are only defined by
SyncReplicationWALProvider.
Let me think more about how to abstract these methods. Probably when
replication part of the design doc is refreshed, we would have different
perspectives.
bq. Missed push-down into WALProvider
Looking at the init method for the FSHLogProvider.Writer:
{code}
public void init(FileSystem fs, Path path, Configuration conf, boolean
overwritable,
long blocksize) throws IOException, StreamLacksCapabilityException {
{code}
There are several things specific to distributed FileSystem (such as blocksize).
StreamLacksCapabilityException extends Exception. Probably it can extend IOE so
that the init method can declare to throw IOE, instead of exception tied to
distributed FileSystem.
> Introduce WALIdentity interface
> ---
>
> Key: HBASE-21246
> URL: https://issues.apache.org/jira/browse/HBASE-21246
> Project: HBase
> Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Major
> Fix For: HBASE-20952
>
> Attachments: 21246.003.patch, 21246.20.txt,
> 21246.HBASE-20952.001.patch, 21246.HBASE-20952.002.patch,
> 21246.HBASE-20952.004.patch, 21246.HBASE-20952.005.patch,
> 21246.HBASE-20952.007.patch, 21246.HBASE-20952.008.patch
>
>
> We are introducing WALIdentity interface so that the WAL representation can
> be decoupled from distributed filesystem.
> The interface provides getName method whose return value can represent
> filename in distributed filesystem environment or, the name of the stream
> when the WAL is backed by log stream.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21247) Custom WAL Provider cannot be specified by configuration whose value is outside the enums in Providers
[ https://issues.apache.org/jira/browse/HBASE-21247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668811#comment-16668811 ] Josh Elser commented on HBASE-21247: I think I saw Stack saw that Busbey was traveling at the fore-front of this week, ICYMI > Custom WAL Provider cannot be specified by configuration whose value is > outside the enums in Providers > -- > > Key: HBASE-21247 > URL: https://issues.apache.org/jira/browse/HBASE-21247 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Major > Fix For: 3.0.0 > > Attachments: 21247.v1.txt, 21247.v10.txt, 21247.v11.txt, > 21247.v2.txt, 21247.v3.txt, 21247.v4.tst, 21247.v4.txt, 21247.v5.txt, > 21247.v6.txt, 21247.v7.txt, 21247.v8.txt, 21247.v9.txt > > > Currently all the WAL Providers acceptable to hbase are specified in > Providers enum of WALFactory. > This restricts the ability for additional WAL Providers to be supplied - by > class name. > This issue fixes the bug by allowing the specification of new WAL Provider > class name using the config "hbase.wal.provider". -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21401) Sanity check in BaseDecoder#parseCell
[ https://issues.apache.org/jira/browse/HBASE-21401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668755#comment-16668755 ] Zheng Hu commented on HBASE-21401: -- [~anoop.hbase], PTAL. Thanks. > Sanity check in BaseDecoder#parseCell > - > > Key: HBASE-21401 > URL: https://issues.apache.org/jira/browse/HBASE-21401 > Project: HBase > Issue Type: Sub-task > Components: regionserver >Reporter: Zheng Hu >Assignee: Zheng Hu >Priority: Critical > Fix For: 3.0.0, 2.2.0, 2.0.3, 2.1.2 > > Attachments: HBASE-21401.v1.patch, HBASE-21401.v2.patch, > HBASE-21401.v3.patch > > > In KeyValueDecoder & ByteBuffKeyValueDecoder, we pass a byte buffer to > initialize the Cell without a sanity check (check each field's offset > exceed the byte buffer or not), so ArrayIndexOutOfBoundsException may happen > when read the cell's fields, such as HBASE-21379, it's hard to debug this > kind of bug. > An earlier check will help to find such kind of bugs. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21401) Sanity check in BaseDecoder#parseCell
[ https://issues.apache.org/jira/browse/HBASE-21401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zheng Hu updated HBASE-21401: - Attachment: HBASE-21401.v3.patch > Sanity check in BaseDecoder#parseCell > - > > Key: HBASE-21401 > URL: https://issues.apache.org/jira/browse/HBASE-21401 > Project: HBase > Issue Type: Sub-task > Components: regionserver >Reporter: Zheng Hu >Assignee: Zheng Hu >Priority: Critical > Fix For: 3.0.0, 2.2.0, 2.0.3, 2.1.2 > > Attachments: HBASE-21401.v1.patch, HBASE-21401.v2.patch, > HBASE-21401.v3.patch > > > In KeyValueDecoder & ByteBuffKeyValueDecoder, we pass a byte buffer to > initialize the Cell without a sanity check (check each field's offset > exceed the byte buffer or not), so ArrayIndexOutOfBoundsException may happen > when read the cell's fields, such as HBASE-21379, it's hard to debug this > kind of bug. > An earlier check will help to find such kind of bugs. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21246) Introduce WALIdentity interface
[ https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668607#comment-16668607 ] Reid Chan commented on HBASE-21246: --- bq. Diagrams would have helped. from sir [~stack] Let me help to picture it at weekends, it gives us an overview and also helps me to get involved. Just my personal feelings, Ted already listed all the details and things needed to be taken care,. But WAL system's architecture is not very clear, and api/class abstraction which it is very important IMO is not clean enough, as well as the relations/work flows between WALFactory/WAL/WALIdentity/WAL***.class. (Hoping diagrams will help!) However, we are so eager to taste the fruit of the WAL system that had started quickly and bumps into a lot of details at the beginning which i doubt it is a good thing. What about just introducing WALIdentity interface and implementing related abstract classes with some TestMockImpl(or TestFSBasedImpl) to show what apis looks like, rather than embedding into code base immediately, it may help us discussions, reviews and collating with the design docs. > Introduce WALIdentity interface > --- > > Key: HBASE-21246 > URL: https://issues.apache.org/jira/browse/HBASE-21246 > Project: HBase > Issue Type: Sub-task >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Major > Fix For: HBASE-20952 > > Attachments: 21246.003.patch, 21246.20.txt, > 21246.HBASE-20952.001.patch, 21246.HBASE-20952.002.patch, > 21246.HBASE-20952.004.patch, 21246.HBASE-20952.005.patch, > 21246.HBASE-20952.007.patch, 21246.HBASE-20952.008.patch > > > We are introducing WALIdentity interface so that the WAL representation can > be decoupled from distributed filesystem. > The interface provides getName method whose return value can represent > filename in distributed filesystem environment or, the name of the stream > when the WAL is backed by log stream. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21410) A helper page that help find all problematic regions and procedures
[ https://issues.apache.org/jira/browse/HBASE-21410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668576#comment-16668576 ] Jingyun Tian commented on HBASE-21410: -- [~stack] Please check this out. > A helper page that help find all problematic regions and procedures > --- > > Key: HBASE-21410 > URL: https://issues.apache.org/jira/browse/HBASE-21410 > Project: HBase > Issue Type: Improvement >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Attachments: Screenshot from 2018-10-30 19-06-21.png, Screenshot from > 2018-10-30 19-06-42.png > > > *This page is mainly focus on finding the regions stuck in some state that > cannot be assigned. My proposal of the page is as follows:* > !Screenshot from 2018-10-30 19-06-21.png! > *From this page we can see all regions in RIT queue and their related > procedures. If we can determine that these regions' state are abnormal, we > can click the link 'Procedures as TXT' to get a full list of procedure IDs to > bypass them. Then click 'Regions as TXT' to get a full list of encoded region > names to assign.* > !Screenshot from 2018-10-30 19-06-42.png! > *Some region names are covered by the navigator bar, I'll fix it later.* -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21410) A helper page that help find all problematic regions and procedures
[ https://issues.apache.org/jira/browse/HBASE-21410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-21410: - Description: *This page is mainly focus on finding the regions stuck in some state that cannot be assigned. My proposal of the page is as follows:* !Screenshot from 2018-10-30 19-06-21.png! *From this page we can see all regions in RIT queue and their related procedures. If we can determine that these regions' state are abnormal, we can click the link 'Procedures as TXT' to get a full list of procedure IDs to bypass them. Then click 'Regions as TXT' to get a full list of encoded region names to assign.* !Screenshot from 2018-10-30 19-06-42.png! *Some region names are covered by the navigator bar, I'll fix it later.* was: This page is mainly focus on finding the regions stuck in some state that cannot be assigned. My proposal of the page is as follows: !Screenshot from 2018-10-30 19-06-21.png! >From this page we can see all regions in RIT queue and their related >procedures. If we can determine that these regions' state are abnormal, we can >click the link 'Procedures as TXT' to get a full list of procedure IDs to >bypass them. Then click 'Regions as TXT' to get a full list of encoded region >names to assign. !Screenshot from 2018-10-30 19-06-42.png! Some region names are covered by the navigator bar, I'll fix it later. > A helper page that help find all problematic regions and procedures > --- > > Key: HBASE-21410 > URL: https://issues.apache.org/jira/browse/HBASE-21410 > Project: HBase > Issue Type: Improvement >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Attachments: Screenshot from 2018-10-30 19-06-21.png, Screenshot from > 2018-10-30 19-06-42.png > > > *This page is mainly focus on finding the regions stuck in some state that > cannot be assigned. My proposal of the page is as follows:* > !Screenshot from 2018-10-30 19-06-21.png! > *From this page we can see all regions in RIT queue and their related > procedures. If we can determine that these regions' state are abnormal, we > can click the link 'Procedures as TXT' to get a full list of procedure IDs to > bypass them. Then click 'Regions as TXT' to get a full list of encoded region > names to assign.* > !Screenshot from 2018-10-30 19-06-42.png! > *Some region names are covered by the navigator bar, I'll fix it later.* -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21410) A helper page that help find all problematic regions and procedures
[ https://issues.apache.org/jira/browse/HBASE-21410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-21410: - Description: This page is mainly focus on finding the regions stuck in some state that cannot be assigned. My proposal of the page is as follows: !Screenshot from 2018-10-30 19-06-21.png! >From this page we can see all regions in RIT queue and their related >procedures. If we can determine that these regions' state are abnormal, we can >click the link 'Procedures as TXT' to get a full list of procedure IDs to >bypass them. Then click 'Regions as TXT' to get a full list of encoded region >names to assign. !Screenshot from 2018-10-30 19-06-42.png! Some region names are covered by the navigator bar, I'll fix it later. was: This page is mainly focus on finding the regions stuck in some state that cannot be assigned. My proposal of the page is as follows: !Screenshot from 2018-10-30 19-06-21.png! >From this page we can see all regions in RIT queue and their related >procedures. If we can determine that these regions' state are abnormal, we can >click the link 'Procedures as TXT' to get a full list of procedure IDs to >bypass them. Then click 'Regions as TXT' to get a full list of encoded region >names to assign. !Screenshot from 2018-10-30 19-06-42.png! Some region names are covered by the navigator bar, I'll fix it later. > A helper page that help find all problematic regions and procedures > --- > > Key: HBASE-21410 > URL: https://issues.apache.org/jira/browse/HBASE-21410 > Project: HBase > Issue Type: Improvement >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Attachments: Screenshot from 2018-10-30 19-06-21.png, Screenshot from > 2018-10-30 19-06-42.png > > > This page is mainly focus on finding the regions stuck in some state that > cannot be assigned. My proposal of the page is as follows: > !Screenshot from 2018-10-30 19-06-21.png! > From this page we can see all regions in RIT queue and their related > procedures. If we can determine that these regions' state are abnormal, we > can click the link 'Procedures as TXT' to get a full list of procedure IDs to > bypass them. Then click 'Regions as TXT' to get a full list of encoded region > names to assign. > !Screenshot from 2018-10-30 19-06-42.png! > Some region names are covered by the navigator bar, I'll fix it later. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (HBASE-21410) A helper page that help find all problematic regions and procedures
Jingyun Tian created HBASE-21410: Summary: A helper page that help find all problematic regions and procedures Key: HBASE-21410 URL: https://issues.apache.org/jira/browse/HBASE-21410 Project: HBase Issue Type: Improvement Reporter: Jingyun Tian Assignee: Jingyun Tian Attachments: Screenshot from 2018-10-30 19-06-21.png, Screenshot from 2018-10-30 19-06-42.png This page is mainly focus on finding the regions stuck in some state that cannot be assigned. My proposal of the page is as follows: !Screenshot from 2018-10-30 19-06-21.png! >From this page we can see all regions in RIT queue and their related >procedures. If we can determine that these regions' state are abnormal, we can >click the link 'Procedures as TXT' to get a full list of procedure IDs to >bypass them. Then click 'Regions as TXT' to get a full list of encoded region >names to assign. !Screenshot from 2018-10-30 19-06-42.png! Some region names are covered by the navigator bar, I'll fix it later. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21409) RS dead cause of InvalidProtocolBufferException
[ https://issues.apache.org/jira/browse/HBASE-21409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] justice updated HBASE-21409: Attachment: logs.tgz > RS dead cause of InvalidProtocolBufferException > --- > > Key: HBASE-21409 > URL: https://issues.apache.org/jira/browse/HBASE-21409 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 3.0.0 >Reporter: justice >Priority: Major > Attachments: logs.tgz > > > 2018-10-30 17:13:05,373 ERROR [regionserver/11-5-131-100:50020.logRoller] > regionserver.LogRoller: Log rolling failed > org.apache.hbase.thirdparty.io.netty.handler.codec.DecoderException: > com.google.protobuf.InvalidProtocolBufferException: Message missing required > fields: status > at > org.apache.hbase.thirdparty.io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:98) > at > org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362) > at > org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348) > at > org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340) > at > org.apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:310) > at > org.apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:297) > at > org.apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:413) > at > org.apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:265) > at > org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362) > at > org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348) > at > org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340) > at > org.apache.hbase.thirdparty.io.netty.handler.timeout.IdleStateHandler.channelRead(IdleStateHandler.java:286) > at > org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362) > at > org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348) > at > org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340) > at > org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1359) > at > org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362) > at > org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348) > at > org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:935) > at > org.apache.hbase.thirdparty.io.netty.channel.epoll.AbstractEpollStreamChannel$EpollStreamUnsafe.epollInReady(AbstractEpollStreamChannel.java:801) > at > org.apache.hbase.thirdparty.io.netty.channel.epoll.EpollEventLoop.processReady(EpollEventLoop.java:404) > at > org.apache.hbase.thirdparty.io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:304) > at > org.apache.hbase.thirdparty.io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:858) > at > org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:138) > at java.lang.Thread.run(Thread.java:748) > Caused by: com.google.protobuf.InvalidProtocolBufferException: Message > missing required fields: status > at > com.google.protobuf.UninitializedMessageException.asInvalidProtocolBufferException(UninitializedMessageException.java:81) > at > com.google.protobuf.AbstractParser.checkMessageInitialized(AbstractParser.java:71) > at com.google.protobuf.AbstractParser.parseFrom(AbstractParser.java:176) > at com.google.protobuf.AbstractParser.parseFrom(AbstractParser.java:182) > at com.google.protobuf.AbstractParser.parseFrom(AbstractParser.java:49) > at > org.apache.hbase.thirdparty.io.netty.handler.codec.protobuf.ProtobufDecoder.decode(ProtobufDecoder.java:121) > at > org.apache.hbase.thirdparty.io.netty.handler.codec.protobuf.ProtobufDecoder.decode(ProtobufDecoder.java:64) > at >
[jira] [Created] (HBASE-21409) RS dead cause of InvalidProtocolBufferException
justice created HBASE-21409: --- Summary: RS dead cause of InvalidProtocolBufferException Key: HBASE-21409 URL: https://issues.apache.org/jira/browse/HBASE-21409 Project: HBase Issue Type: Bug Components: regionserver Affects Versions: 3.0.0 Reporter: justice 2018-10-30 17:13:05,373 ERROR [regionserver/11-5-131-100:50020.logRoller] regionserver.LogRoller: Log rolling failed org.apache.hbase.thirdparty.io.netty.handler.codec.DecoderException: com.google.protobuf.InvalidProtocolBufferException: Message missing required fields: status at org.apache.hbase.thirdparty.io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:98) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340) at org.apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:310) at org.apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:297) at org.apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:413) at org.apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:265) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340) at org.apache.hbase.thirdparty.io.netty.handler.timeout.IdleStateHandler.channelRead(IdleStateHandler.java:286) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340) at org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1359) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348) at org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:935) at org.apache.hbase.thirdparty.io.netty.channel.epoll.AbstractEpollStreamChannel$EpollStreamUnsafe.epollInReady(AbstractEpollStreamChannel.java:801) at org.apache.hbase.thirdparty.io.netty.channel.epoll.EpollEventLoop.processReady(EpollEventLoop.java:404) at org.apache.hbase.thirdparty.io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:304) at org.apache.hbase.thirdparty.io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:858) at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:138) at java.lang.Thread.run(Thread.java:748) Caused by: com.google.protobuf.InvalidProtocolBufferException: Message missing required fields: status at com.google.protobuf.UninitializedMessageException.asInvalidProtocolBufferException(UninitializedMessageException.java:81) at com.google.protobuf.AbstractParser.checkMessageInitialized(AbstractParser.java:71) at com.google.protobuf.AbstractParser.parseFrom(AbstractParser.java:176) at com.google.protobuf.AbstractParser.parseFrom(AbstractParser.java:182) at com.google.protobuf.AbstractParser.parseFrom(AbstractParser.java:49) at org.apache.hbase.thirdparty.io.netty.handler.codec.protobuf.ProtobufDecoder.decode(ProtobufDecoder.java:121) at org.apache.hbase.thirdparty.io.netty.handler.codec.protobuf.ProtobufDecoder.decode(ProtobufDecoder.java:64) at org.apache.hbase.thirdparty.io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:88) ... 24 more -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21389) Revisit the procedure lock for sync replication
[ https://issues.apache.org/jira/browse/HBASE-21389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-21389: -- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Pushed to master. Thanks [~zghaobac] for reviewing. > Revisit the procedure lock for sync replication > --- > > Key: HBASE-21389 > URL: https://issues.apache.org/jira/browse/HBASE-21389 > Project: HBase > Issue Type: Sub-task > Components: proc-v2, Replication >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0 > > Attachments: HBASE-21389-v1.patch, HBASE-21389-v1.patch, > HBASE-21389.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21237) Use CompatRemoteProcedureResolver to dispatch open/close region requests to RS
[ https://issues.apache.org/jira/browse/HBASE-21237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-21237: -- Resolution: Fixed Status: Resolved (was: Patch Available) Pushed to branch-2.1 and branch-2.0. Thanks all for reviewing. > Use CompatRemoteProcedureResolver to dispatch open/close region requests to RS > -- > > Key: HBASE-21237 > URL: https://issues.apache.org/jira/browse/HBASE-21237 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.1.0, 2.0.2 >Reporter: Allan Yang >Assignee: Allan Yang >Priority: Blocker > Fix For: 2.0.3, 2.1.2 > > Attachments: HBASE-21237-branch-2.1-v1.patch, > HBASE-21237-branch-2.1.patch, HBASE-21237.branch-2.0.001.patch > > > As discussed in HBASE-21217, in branch-2.0 and branch-2.1, we should use > CompatRemoteProcedureResolver instead of ExecuteProceduresRemoteCall to > dispatch region open/close requests to RS. Since ExecuteProceduresRemoteCall > will group all the open/close operations in one call and execute them > sequentially on the target RS. If one operation fails, all the operation will > be marked as failure. Actually, some of the operations(like open region) is > already executing in the open region handler thread. But master thinks these > operations fails and reassign the regions to another RS. So when the previous > RS report to the master that the region is online, master will kill the RS > since it already assign the region to another RS. > For branch-2.2+, HBASE-21217 will fix this issue. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21407) Resolve NPE in backup Master UI
[ https://issues.apache.org/jira/browse/HBASE-21407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668421#comment-16668421 ] Nihal Jain commented on HBASE-21407: Correct. In jsp based pages it will show "procedure" tab even on backup master. +1 for the patch. > Resolve NPE in backup Master UI > > > Key: HBASE-21407 > URL: https://issues.apache.org/jira/browse/HBASE-21407 > Project: HBase > Issue Type: Bug > Components: UI >Affects Versions: 3.0.0, 2.1.0, 2.2.0 >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Minor > Fix For: 3.0.0, 2.1.0, 2.2.0 > > Attachments: hbase-21407.master.001.patch > > > Since some pages of our UI are using jsp instead of jamon, the fix of > HBASE-18263 is not enough. Added the fix of HBASE-18263 to the header.jsp. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21408) Add hbase.wal.dir clean operation also to hbase cleanup script.
[ https://issues.apache.org/jira/browse/HBASE-21408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Y. SREENIVASULU REDDY updated HBASE-21408: -- Fix Version/s: 2.1.1 Status: Patch Available (was: Open) > Add hbase.wal.dir clean operation also to hbase cleanup script. > --- > > Key: HBASE-21408 > URL: https://issues.apache.org/jira/browse/HBASE-21408 > Project: HBase > Issue Type: Improvement > Components: scripts >Affects Versions: 2.1.0 >Reporter: Y. SREENIVASULU REDDY >Priority: Major > Fix For: 2.1.1 > > Attachments: HBASE-21408.001.patch > > > If user configured hbase.wal.dir explicitly. > cleaning scripts should handle this too. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21408) Add hbase.wal.dir clean operation also to hbase cleanup script.
[ https://issues.apache.org/jira/browse/HBASE-21408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668416#comment-16668416 ] Y. SREENIVASULU REDDY commented on HBASE-21408: --- Added the patch. please review. few more changes done in this patch for some more information update in the scripts, and removed deprecated commands also. > Add hbase.wal.dir clean operation also to hbase cleanup script. > --- > > Key: HBASE-21408 > URL: https://issues.apache.org/jira/browse/HBASE-21408 > Project: HBase > Issue Type: Improvement > Components: scripts >Affects Versions: 2.1.0 >Reporter: Y. SREENIVASULU REDDY >Priority: Major > Attachments: HBASE-21408.001.patch > > > If user configured hbase.wal.dir explicitly. > cleaning scripts should handle this too. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21408) Add hbase.wal.dir clean operation also to hbase cleanup script.
[ https://issues.apache.org/jira/browse/HBASE-21408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Y. SREENIVASULU REDDY updated HBASE-21408: -- Attachment: HBASE-21408.001.patch > Add hbase.wal.dir clean operation also to hbase cleanup script. > --- > > Key: HBASE-21408 > URL: https://issues.apache.org/jira/browse/HBASE-21408 > Project: HBase > Issue Type: Improvement > Components: scripts >Affects Versions: 2.1.0 >Reporter: Y. SREENIVASULU REDDY >Priority: Major > Attachments: HBASE-21408.001.patch > > > If user configured hbase.wal.dir explicitly. > cleaning scripts should handle this too. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (HBASE-21408) Add hbase.wal.dir clean operation also to hbase cleanup script.
Y. SREENIVASULU REDDY created HBASE-21408: - Summary: Add hbase.wal.dir clean operation also to hbase cleanup script. Key: HBASE-21408 URL: https://issues.apache.org/jira/browse/HBASE-21408 Project: HBase Issue Type: Improvement Components: scripts Affects Versions: 2.1.0 Reporter: Y. SREENIVASULU REDDY If user configured hbase.wal.dir explicitly. cleaning scripts should handle this too. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21351) The force update thread may have race with PE worker when the procedure is rolling back
[ https://issues.apache.org/jira/browse/HBASE-21351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-21351: -- Assignee: Duo Zhang Fix Version/s: 2.1.2 2.0.3 Status: Patch Available (was: Open) > The force update thread may have race with PE worker when the procedure is > rolling back > --- > > Key: HBASE-21351 > URL: https://issues.apache.org/jira/browse/HBASE-21351 > Project: HBase > Issue Type: Sub-task > Components: proc-v2 >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Critical > Fix For: 3.0.0, 2.2.0, 2.0.3, 2.1.2 > > Attachments: HBASE-21351.patch > > > We will acquire the procExecutionLock for a procedure when force updating its > state to prevent race with PE worker, but this does not work then the > procedure is rolling back. > If a procedure is failed, we will mark the root procedure stack as FAILED, > and then start to rollback the whole procedure stack. We will pop every > procedure in the stack and try to rollback them. So we may change the state > of a procedure without holding its procExecutionLock when rolling back. > This means we may persist an intermediate state of a procedure and cause > corruption when loading procedures. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21351) The force update thread may have race with PE worker when the procedure is rolling back
[ https://issues.apache.org/jira/browse/HBASE-21351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-21351: -- Attachment: HBASE-21351.patch > The force update thread may have race with PE worker when the procedure is > rolling back > --- > > Key: HBASE-21351 > URL: https://issues.apache.org/jira/browse/HBASE-21351 > Project: HBase > Issue Type: Sub-task > Components: proc-v2 >Reporter: Duo Zhang >Priority: Critical > Fix For: 3.0.0, 2.2.0 > > Attachments: HBASE-21351.patch > > > We will acquire the procExecutionLock for a procedure when force updating its > state to prevent race with PE worker, but this does not work then the > procedure is rolling back. > If a procedure is failed, we will mark the root procedure stack as FAILED, > and then start to rollback the whole procedure stack. We will pop every > procedure in the stack and try to rollback them. So we may change the state > of a procedure without holding its procExecutionLock when rolling back. > This means we may persist an intermediate state of a procedure and cause > corruption when loading procedures. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21407) Resolve NPE in backup Master UI
[ https://issues.apache.org/jira/browse/HBASE-21407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-21407: - Fix Version/s: 2.1.0 2.2.0 3.0.0 Status: Patch Available (was: Open) > Resolve NPE in backup Master UI > > > Key: HBASE-21407 > URL: https://issues.apache.org/jira/browse/HBASE-21407 > Project: HBase > Issue Type: Bug > Components: UI >Affects Versions: 2.1.0, 3.0.0, 2.2.0 >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Minor > Fix For: 3.0.0, 2.2.0, 2.1.0 > > Attachments: hbase-21407.master.001.patch > > > Since some pages of our UI are using jsp instead of jamon, the fix of > HBASE-18263 is not enough. Added the fix of HBASE-18263 to the header.jsp. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)
[
https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668354#comment-16668354
]
Reid Chan commented on HBASE-21255:
---
Let's see what will QA says before updating RB.
> [acl] Refactor TablePermission into three classes (Global, Namespace, Table)
>
>
> Key: HBASE-21255
> URL: https://issues.apache.org/jira/browse/HBASE-21255
> Project: HBase
> Issue Type: Improvement
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Attachments: HBASE-21225.master.001.patch,
> HBASE-21225.master.002.patch, HBASE-21255.master.003.patch
>
>
> A TODO in {{TablePermission.java}}
> {code}
> //TODO refactor this class
> //we need to refacting this into three classes (Global, Table, Namespace)
> {code}
> Change Note:
> * Divide origin TablePermission into three classes GlobalPermission,
> NamespacePermission, TablePermission
> * New UserPermission consists of a user name and a permission in one of
> [Global, Namespace, Table]Permission.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-21255) [acl] Refactor TablePermission into three classes (Global, Namespace, Table)
[
https://issues.apache.org/jira/browse/HBASE-21255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Reid Chan updated HBASE-21255:
--
Attachment: HBASE-21255.master.003.patch
> [acl] Refactor TablePermission into three classes (Global, Namespace, Table)
>
>
> Key: HBASE-21255
> URL: https://issues.apache.org/jira/browse/HBASE-21255
> Project: HBase
> Issue Type: Improvement
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Attachments: HBASE-21225.master.001.patch,
> HBASE-21225.master.002.patch, HBASE-21255.master.003.patch
>
>
> A TODO in {{TablePermission.java}}
> {code}
> //TODO refactor this class
> //we need to refacting this into three classes (Global, Table, Namespace)
> {code}
> Change Note:
> * Divide origin TablePermission into three classes GlobalPermission,
> NamespacePermission, TablePermission
> * New UserPermission consists of a user name and a permission in one of
> [Global, Namespace, Table]Permission.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-21407) Resolve NPE in backup Master UI
[ https://issues.apache.org/jira/browse/HBASE-21407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-21407: - Attachment: hbase-21407.master.001.patch > Resolve NPE in backup Master UI > > > Key: HBASE-21407 > URL: https://issues.apache.org/jira/browse/HBASE-21407 > Project: HBase > Issue Type: Bug > Components: UI >Affects Versions: 3.0.0, 2.1.0, 2.2.0 >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Minor > Attachments: hbase-21407.master.001.patch > > > Since some pages of our UI are using jsp instead of jamon, the fix of > HBASE-18263 is not enough. Added the fix of HBASE-18263 to the header.jsp. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21407) Resolve NPE in backup Master UI
[ https://issues.apache.org/jira/browse/HBASE-21407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-21407: - Description: Since some pages of our UI are using jsp instead of jamon, the fix of HBASE-18263 is not enough. Added the fix of HBASE-18263 to the header.jsp. (was: Since some pages of our UI is using jsp instead of jamon, the fix of HBASE-18263 is not enough. Added the fix of HBASE-18263 to the header.jsp.) > Resolve NPE in backup Master UI > > > Key: HBASE-21407 > URL: https://issues.apache.org/jira/browse/HBASE-21407 > Project: HBase > Issue Type: Bug > Components: UI >Affects Versions: 3.0.0, 2.1.0, 2.2.0 >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Minor > > Since some pages of our UI are using jsp instead of jamon, the fix of > HBASE-18263 is not enough. Added the fix of HBASE-18263 to the header.jsp. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (HBASE-21407) Resolve NPE in backup Master UI
Jingyun Tian created HBASE-21407: Summary: Resolve NPE in backup Master UI Key: HBASE-21407 URL: https://issues.apache.org/jira/browse/HBASE-21407 Project: HBase Issue Type: Bug Components: UI Affects Versions: 2.1.0, 3.0.0, 2.2.0 Reporter: Jingyun Tian Assignee: Jingyun Tian Since some pages of our UI is using jsp instead of jamon, the fix of HBASE-18263 is not enough. Added the fix of HBASE-18263 to the header.jsp. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21404) Master/RS navbar active state does not work
[ https://issues.apache.org/jira/browse/HBASE-21404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668304#comment-16668304 ] Nihal Jain commented on HBASE-21404: Failed as jenkins assumed png to be the patch. Will resubmit patch once in vicinity of my laptop. > Master/RS navbar active state does not work > --- > > Key: HBASE-21404 > URL: https://issues.apache.org/jira/browse/HBASE-21404 > Project: HBase > Issue Type: Bug > Components: UI >Affects Versions: 3.0.0, 2.0.0 >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Minor > Fix For: 3.0.0 > > Attachments: HBASE-21404.master.001.patch, master_after_patch.png, > master_before.png, rs_after_patch.png, rs_before.png > > > In master/rs web UI, the current active tab is not updated when user switches > to any tab other than "Home" tab. > For example: even though say if we are on "tabledetailed.jsp", the navbar > does not update the active state of that tab. See master_before.png -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21322) Add a scheduleServerCrashProcedure() API to HbckService
[
https://issues.apache.org/jira/browse/HBASE-21322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668302#comment-16668302
]
Hudson commented on HBASE-21322:
Results for branch branch-2.1
[build #556 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/556/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/556//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/556//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/556//JDK8_Nightly_Build_Report_(Hadoop3)/]
(x) {color:red}-1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
-- Something went wrong with this stage, [check relevant console
output|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/556//console].
> Add a scheduleServerCrashProcedure() API to HbckService
> ---
>
> Key: HBASE-21322
> URL: https://issues.apache.org/jira/browse/HBASE-21322
> Project: HBase
> Issue Type: Sub-task
> Components: hbck2
>Reporter: Jingyun Tian
>Assignee: Jingyun Tian
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.0.3, 2.1.2
>
> Attachments: HBASE-21322.branch-2.1.001.patch,
> HBASE-21322.master.001.patch, HBASE-21322.master.002.patch,
> HBASE-21322.master.003.patch, HBASE-21322.master.004.patch,
> HBASE-21322.master.005.patch, HBASE-21322.master.006.patch, Screenshot from
> 2018-10-17 13-35-58.png, Screenshot from 2018-10-17 13-38-41.png, Screenshot
> from 2018-10-17 13-47-06.png
>
>
> According to my test, if one RS is down, then all procedure logs are deleted,
> it will lead to that no ServerCrashProcedure is scheduled. And restarting
> master cannot help. Thus we need to schedule a ServerCrashProcedure manually
> to solve the problem. I plan to add a scheduleServerCrashProcedure() API to
> HbckService, then add this API to HBCK2.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21322) Add a scheduleServerCrashProcedure() API to HbckService
[
https://issues.apache.org/jira/browse/HBASE-21322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668295#comment-16668295
]
Hudson commented on HBASE-21322:
Results for branch branch-2
[build #1465 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1465/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1465//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1465//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1465//JDK8_Nightly_Build_Report_(Hadoop3)/]
(x) {color:red}-1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
-- Something went wrong with this stage, [check relevant console
output|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1465//console].
> Add a scheduleServerCrashProcedure() API to HbckService
> ---
>
> Key: HBASE-21322
> URL: https://issues.apache.org/jira/browse/HBASE-21322
> Project: HBase
> Issue Type: Sub-task
> Components: hbck2
>Reporter: Jingyun Tian
>Assignee: Jingyun Tian
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.0.3, 2.1.2
>
> Attachments: HBASE-21322.branch-2.1.001.patch,
> HBASE-21322.master.001.patch, HBASE-21322.master.002.patch,
> HBASE-21322.master.003.patch, HBASE-21322.master.004.patch,
> HBASE-21322.master.005.patch, HBASE-21322.master.006.patch, Screenshot from
> 2018-10-17 13-35-58.png, Screenshot from 2018-10-17 13-38-41.png, Screenshot
> from 2018-10-17 13-47-06.png
>
>
> According to my test, if one RS is down, then all procedure logs are deleted,
> it will lead to that no ServerCrashProcedure is scheduled. And restarting
> master cannot help. Thus we need to schedule a ServerCrashProcedure manually
> to solve the problem. I plan to add a scheduleServerCrashProcedure() API to
> HbckService, then add this API to HBCK2.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21403) Give sort arrows on Master UI some attention...
[ https://issues.apache.org/jira/browse/HBASE-21403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668293#comment-16668293 ] Archana Katiyar commented on HBASE-21403: - Sure, let's wait and watch. > Give sort arrows on Master UI some attention... > --- > > Key: HBASE-21403 > URL: https://issues.apache.org/jira/browse/HBASE-21403 > Project: HBase > Issue Type: Sub-task > Components: UI >Reporter: stack >Priority: Trivial > Attachments: Screen Shot 2018-10-29 at 11.10.52 PM.png > > > Parent issue added some helpful sort functionality to the Master UI. The > arrows though are a bit small and can crowd the text in the table section in > the RIT rows. On the revent vote thread, > http://mail-archives.apache.org/mod_mbox/hbase-dev/201810.mbox/browser, > fellas were a little confused as to what they were for. This issue is about > given them a little attention to see if can be made more plain what they are > about. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21322) Add a scheduleServerCrashProcedure() API to HbckService
[
https://issues.apache.org/jira/browse/HBASE-21322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668288#comment-16668288
]
Hudson commented on HBASE-21322:
Results for branch branch-2.0
[build #1036 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1036/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1036//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1036//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1036//JDK8_Nightly_Build_Report_(Hadoop3)/]
(x) {color:red}-1 source release artifact{color}
-- See build output for details.
> Add a scheduleServerCrashProcedure() API to HbckService
> ---
>
> Key: HBASE-21322
> URL: https://issues.apache.org/jira/browse/HBASE-21322
> Project: HBase
> Issue Type: Sub-task
> Components: hbck2
>Reporter: Jingyun Tian
>Assignee: Jingyun Tian
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.0.3, 2.1.2
>
> Attachments: HBASE-21322.branch-2.1.001.patch,
> HBASE-21322.master.001.patch, HBASE-21322.master.002.patch,
> HBASE-21322.master.003.patch, HBASE-21322.master.004.patch,
> HBASE-21322.master.005.patch, HBASE-21322.master.006.patch, Screenshot from
> 2018-10-17 13-35-58.png, Screenshot from 2018-10-17 13-38-41.png, Screenshot
> from 2018-10-17 13-47-06.png
>
>
> According to my test, if one RS is down, then all procedure logs are deleted,
> it will lead to that no ServerCrashProcedure is scheduled. And restarting
> master cannot help. Thus we need to schedule a ServerCrashProcedure manually
> to solve the problem. I plan to add a scheduleServerCrashProcedure() API to
> HbckService, then add this API to HBCK2.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-21406) "status 'replication'" should not show SINK if the cluster does not act as sink
[
https://issues.apache.org/jira/browse/HBASE-21406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daisuke Kobayashi updated HBASE-21406:
--
Description:
When replicating in 1 way, from source to target, {{status 'replication'}} on
source always dumps SINK with meaningless metrics. It only makes sense when
running the command on target cluster.
{{status 'replication'}} on source, for example. {{AgeOfLastAppliedOp}} is
always zero and {{TimeStampsOfLastAppliedOp}} does not get updated from the
time the RS started since it's not acting as sink.
{noformat}
source-1.com
SOURCE: PeerID=1, AgeOfLastShippedOp=0, SizeOfLogQueue=0,
TimeStampsOfLastShippedOp=Mon Oct 29 23:44:14 PDT 2018, Replication Lag=0
SINK : AgeOfLastAppliedOp=0, TimeStampsOfLastAppliedOp=Thu Oct 25
23:56:53 PDT 2018
{noformat}
{{status 'replication'}} on target works as expected. SOURCE is empty as it's
not acting as source:
{noformat}
target-1.com
SOURCE:
SINK : AgeOfLastAppliedOp=70, TimeStampsOfLastAppliedOp=Mon Oct 29
23:44:08 PDT 2018
{noformat}
This is because {{getReplicationLoadSink}}, called in {{admin.rb}}, always
returns a value (not null).
1.X
https://github.com/apache/hbase/blob/rel/1.4.0/hbase-client/src/main/java/org/apache/hadoop/hbase/ServerLoad.java#L194-L204
2.X
https://github.com/apache/hbase/blob/rel/2.0.0/hbase-client/src/main/java/org/apache/hadoop/hbase/ServerLoad.java#L392-L399
> "status 'replication'" should not show SINK if the cluster does not act as
> sink
> ---
>
> Key: HBASE-21406
> URL: https://issues.apache.org/jira/browse/HBASE-21406
> Project: HBase
> Issue Type: Improvement
>Reporter: Daisuke Kobayashi
>Priority: Minor
>
> When replicating in 1 way, from source to target, {{status 'replication'}} on
> source always dumps SINK with meaningless metrics. It only makes sense when
> running the command on target cluster.
> {{status 'replication'}} on source, for example. {{AgeOfLastAppliedOp}} is
> always zero and {{TimeStampsOfLastAppliedOp}} does not get updated from the
> time the RS started since it's not acting as sink.
> {noformat}
> source-1.com
>SOURCE: PeerID=1, AgeOfLastShippedOp=0, SizeOfLogQueue=0,
> TimeStampsOfLastShippedOp=Mon Oct 29 23:44:14 PDT 2018, Replication Lag=0
>SINK : AgeOfLastAppliedOp=0, TimeStampsOfLastAppliedOp=Thu Oct 25
> 23:56:53 PDT 2018
> {noformat}
> {{status 'replication'}} on target works as expected. SOURCE is empty as it's
> not acting as source:
> {noformat}
> target-1.com
>SOURCE:
>SINK : AgeOfLastAppliedOp=70, TimeStampsOfLastAppliedOp=Mon Oct 29
> 23:44:08 PDT 2018
> {noformat}
> This is because {{getReplicationLoadSink}}, called in {{admin.rb}}, always
> returns a value (not null).
> 1.X
> https://github.com/apache/hbase/blob/rel/1.4.0/hbase-client/src/main/java/org/apache/hadoop/hbase/ServerLoad.java#L194-L204
> 2.X
> https://github.com/apache/hbase/blob/rel/2.0.0/hbase-client/src/main/java/org/apache/hadoop/hbase/ServerLoad.java#L392-L399
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21388) No need to instantiate MemStoreLAB for master which not carry table
[
https://issues.apache.org/jira/browse/HBASE-21388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668252#comment-16668252
]
Hadoop QA commented on HBASE-21388:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
29s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
34s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
47s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
15s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
22s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
4s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
30s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
51s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
11m 3s{color} | {color:green} Patch does not cause any errors with Hadoop
2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
29s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}221m
3s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
24s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}265m 8s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
| JIRA Issue | HBASE-21388 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12946144/HBASE-21388.master.003.patch
|
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 4e18b93b3c6d 3.13.0-143-generic #192-Ubuntu SMP Tue Feb 27
10:45:36 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 4b86dd248a |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.0-RC3 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/14897/testReport/ |
| Max. process+thread count | 4892 (vs. ulimit of 1) |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/14897/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> No need to
[jira] [Commented] (HBASE-21393) Add an API ScheduleSCP() to HBCK2
[ https://issues.apache.org/jira/browse/HBASE-21393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668250#comment-16668250 ] Jingyun Tian commented on HBASE-21393: -- [~stack] I got this. So how do we deal with this? Revert the commit and made the api accept string again? If so guava is no more a problem too. > Add an API ScheduleSCP() to HBCK2 > -- > > Key: HBASE-21393 > URL: https://issues.apache.org/jira/browse/HBASE-21393 > Project: HBase > Issue Type: Sub-task > Components: hbase-operator-tools, hbck2 >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Attachments: 0001-HBASE-21393-Add-an-API-ScheduleSCP-to-HBCK2.patch > > > Add the API of ScheduleSCP() to hbase-operator-tools so that operators can > schedule ServerCrashProcedures of specified regionservers. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21237) Use CompatRemoteProcedureResolver to dispatch open/close region requests to RS
[
https://issues.apache.org/jira/browse/HBASE-21237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668236#comment-16668236
]
Hadoop QA commented on HBASE-21237:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
27s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} branch-2.1 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
17s{color} | {color:green} branch-2.1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
47s{color} | {color:green} branch-2.1 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
13s{color} | {color:green} branch-2.1 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
39s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
6s{color} | {color:green} branch-2.1 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
34s{color} | {color:green} branch-2.1 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
52s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 1m 52s{color}
| {color:red} hbase-server generated 1 new + 187 unchanged - 1 fixed = 188
total (was 188) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
45s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
8m 57s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4
or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
38s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}176m
3s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
23s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}214m 44s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:42ca976 |
| JIRA Issue | HBASE-21237 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12946151/HBASE-21237-branch-2.1-v1.patch
|
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux a851a7b6f8e6 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14
08:52:28 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | branch-2.1 / 644ac13850 |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.0-RC3 |
| javac |
https://builds.apache.org/job/PreCommit-HBASE-Build/14898/artifact/patchprocess/diff-compile-javac-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/14898/testReport/ |
| Max. process+thread count | 4455 (vs. ulimit of 1) |
| modules | C: hbase-server U: hbase-server |
|
[jira] [Updated] (HBASE-21406) "status 'replication'" should not show SINK if the cluster does not act as sink
[ https://issues.apache.org/jira/browse/HBASE-21406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daisuke Kobayashi updated HBASE-21406: -- Priority: Minor (was: Major) > "status 'replication'" should not show SINK if the cluster does not act as > sink > --- > > Key: HBASE-21406 > URL: https://issues.apache.org/jira/browse/HBASE-21406 > Project: HBase > Issue Type: Improvement >Reporter: Daisuke Kobayashi >Priority: Minor > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21406) "status 'replication'" should not show SINK if the cluster does not act as sink
[ https://issues.apache.org/jira/browse/HBASE-21406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daisuke Kobayashi updated HBASE-21406: -- Summary: "status 'replication'" should not show SINK if the cluster does not act as sink (was: "status 'replication') > "status 'replication'" should not show SINK if the cluster does not act as > sink > --- > > Key: HBASE-21406 > URL: https://issues.apache.org/jira/browse/HBASE-21406 > Project: HBase > Issue Type: Improvement >Reporter: Daisuke Kobayashi >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (HBASE-21406) "status 'replication'
Daisuke Kobayashi created HBASE-21406: - Summary: "status 'replication' Key: HBASE-21406 URL: https://issues.apache.org/jira/browse/HBASE-21406 Project: HBase Issue Type: Improvement Reporter: Daisuke Kobayashi -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (HBASE-21405) [DOC] Add Details about Output of "status 'replication'"
Daisuke Kobayashi created HBASE-21405:
-
Summary: [DOC] Add Details about Output of "status 'replication'"
Key: HBASE-21405
URL: https://issues.apache.org/jira/browse/HBASE-21405
Project: HBase
Issue Type: Improvement
Components: documentation
Affects Versions: 2.0.0, 1.4.0, 1.2.0
Reporter: Daisuke Kobayashi
Add more information about the meaning of each metric on to
[http://hbase.apache.org/book.html#_monitoring_replication_status].
{noformat}
SOURCE:
PeerID
AgeOfLastShippedOp
SizeOfLogQueue
TimeStampsOfLastShippedOp
Replication Lag
SINK
AgeOfLastAppliedOp
TimeStampsOfLastAppliedOp
{noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21371) Hbase unable to compile against Hadoop trunk (3.3.0-SNAPSHOT) due to license error
[
https://issues.apache.org/jira/browse/HBASE-21371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668221#comment-16668221
]
Hudson commented on HBASE-21371:
Results for branch branch-2.1
[build #555 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/555/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/555//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/555//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/555//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Hbase unable to compile against Hadoop trunk (3.3.0-SNAPSHOT) due to license
> error
> --
>
> Key: HBASE-21371
> URL: https://issues.apache.org/jira/browse/HBASE-21371
> Project: HBase
> Issue Type: Bug
>Reporter: Wei-Chiu Chuang
>Assignee: Wei-Chiu Chuang
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.0.3, 2.1.2
>
> Attachments: HBASE-21371.master.001.patch
>
>
> Hadoop 3.3.0 (trunk) updated various dependencies, which adds additional
> licenses that break HBase's license check plugin.
> CDDL/GPLv2+CE license
> {quote}This product includes JavaBeans Activation Framework API jar licensed
> under the CDDL/GPLv2+CE.
> CDDL or GPL version 2 plus the Classpath Exception
> ERROR: Please check this License for acceptability here:
> [https://www.apache.org/legal/resolved]
> If it is okay, then update the list named 'non_aggregate_fine' in the
> LICENSE.vm file.
> If it isn't okay, then revert the change that added the dependency.
> More info on the dependency:
> javax.activation
> javax.activation-api
> 1.2.0
> maven central search
> g:javax.activation AND a:javax.activation-api AND v:1.2.0
> project website
> [http://java.net/all/javax.activation-api/]
> project source
> [https://github.com/javaee/activation/javax.activation-api]
> {quote}
> Bouncy Castle License
> {quote}–
> This product includes Bouncy Castle PKIX, CMS, EAC, TSP, PKCS, OCSP, CMP,
> and CRMF APIs licensed under the Bouncy Castle Licence.
> ERROR: Please check this License for acceptability here:
> [https://www.apache.org/legal/resolved]
> If it is okay, then update the list named 'non_aggregate_fine' in the
> LICENSE.vm file.
> If it isn't okay, then revert the change that added the dependency.
> More info on the dependency:
> org.bouncycastle
> bcpkix-jdk15on
> 1.60
> maven central search
> g:org.bouncycastle AND a:bcpkix-jdk15on AND v:1.60
> project website
> [http://www.bouncycastle.org/java.html]
> project source
> [https://github.com/bcgit/bc-java]
> –
> {quote}
>
> And a long list of "Apache Software License - Version 2.0" licensed Jetty
> dependencies like this:
> {quote}
> This product includes Jetty :: Servlet Annotations licensed under the Apache
> Software License - Version 2.0.
> ERROR: Please check this License for acceptability here:
> [https://www.apache.org/legal/resolved]
> If it is okay, then update the list named 'non_aggregate_fine' in the
> LICENSE.vm file.
> If it isn't okay, then revert the change that added the dependency.
> More info on the dependency:
> org.eclipse.jetty
> jetty-annotations
> 9.3.19.v20170502
> maven central search
> g:org.eclipse.jetty AND a:jetty-annotations AND v:9.3.19.v20170502
> project website
> [http://www.eclipse.org/jetty]
> project source
> [https://github.com/eclipse/jetty.project/jetty-annotations]
> {quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21403) Give sort arrows on Master UI some attention...
[ https://issues.apache.org/jira/browse/HBASE-21403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668206#comment-16668206 ] stack commented on HBASE-21403: --- [~archana.katiyar] Maybe the arrows are fine. Sometimes they crowd the text a little in the table section. But they look fine too... Maybe just leave this issue open and wait to see if we get more commentary? Let me add a picture !Screen Shot 2018-10-29 at 11.10.52 PM.png! > Give sort arrows on Master UI some attention... > --- > > Key: HBASE-21403 > URL: https://issues.apache.org/jira/browse/HBASE-21403 > Project: HBase > Issue Type: Sub-task > Components: UI >Reporter: stack >Priority: Trivial > Attachments: Screen Shot 2018-10-29 at 11.10.52 PM.png > > > Parent issue added some helpful sort functionality to the Master UI. The > arrows though are a bit small and can crowd the text in the table section in > the RIT rows. On the revent vote thread, > http://mail-archives.apache.org/mod_mbox/hbase-dev/201810.mbox/browser, > fellas were a little confused as to what they were for. This issue is about > given them a little attention to see if can be made more plain what they are > about. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21403) Give sort arrows on Master UI some attention...
[ https://issues.apache.org/jira/browse/HBASE-21403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-21403: -- Attachment: Screen Shot 2018-10-29 at 11.10.52 PM.png > Give sort arrows on Master UI some attention... > --- > > Key: HBASE-21403 > URL: https://issues.apache.org/jira/browse/HBASE-21403 > Project: HBase > Issue Type: Sub-task > Components: UI >Reporter: stack >Priority: Trivial > Attachments: Screen Shot 2018-10-29 at 11.10.52 PM.png > > > Parent issue added some helpful sort functionality to the Master UI. The > arrows though are a bit small and can crowd the text in the table section in > the RIT rows. On the revent vote thread, > http://mail-archives.apache.org/mod_mbox/hbase-dev/201810.mbox/browser, > fellas were a little confused as to what they were for. This issue is about > given them a little attention to see if can be made more plain what they are > about. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21393) Add an API ScheduleSCP() to HBCK2
[ https://issues.apache.org/jira/browse/HBASE-21393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668204#comment-16668204 ] stack commented on HBASE-21393: --- Oh. You want to import protobuf? Its to make the ServerName as pb? Dang. I told you do that. I think I made a mistake. The below protos are for hbase internals only: import org.apache.hadoop.hbase.shaded.protobuf.generated.HBaseProtos; If the server-side was String instead of ServerName, you wouldn't have to have the hbase internals on the client-side? That might be better? Loose-coupling. Using guava is probably not so bad only you don't say what version of guava we are to use here in hbck2. We seem to be transitively depending on what is on the CLASSPATH? When hbck2 is on same classpath as hbase and hadoop, it might cause pain. Have to have the hbck dependencies come first. > Add an API ScheduleSCP() to HBCK2 > -- > > Key: HBASE-21393 > URL: https://issues.apache.org/jira/browse/HBASE-21393 > Project: HBase > Issue Type: Sub-task > Components: hbase-operator-tools, hbck2 >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Attachments: 0001-HBASE-21393-Add-an-API-ScheduleSCP-to-HBCK2.patch > > > Add the API of ScheduleSCP() to hbase-operator-tools so that operators can > schedule ServerCrashProcedures of specified regionservers. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
