[jira] [Commented] (HBASE-21647) Add status track for splitting WAL tasks

2019-01-02 Thread Jingyun Tian (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732729#comment-16732729
 ] 

Jingyun Tian commented on HBASE-21647:
--

Add status like the figure shows:
 !Screenshot from 2019-01-03 15-31-26.png! 
 !Screenshot from 2019-01-03 15-31-36.png! 
 It tracks the progress of ServerCrashProcedure. For region assign and WAL 
splitting, it will shows the remaining running child procedure.

I will upload the patch after HBASE-21588 committed.

> Add status track for splitting WAL tasks
> 
>
> Key: HBASE-21647
> URL: https://issues.apache.org/jira/browse/HBASE-21647
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Jingyun Tian
>Assignee: Jingyun Tian
>Priority: Major
> Attachments: Screenshot from 2019-01-03 15-31-26.png, Screenshot from 
> 2019-01-03 15-31-36.png
>
>
> add status track to help operator check the status of splitting WAL



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-21647) Add status track for splitting WAL tasks

2019-01-02 Thread Jingyun Tian (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-21647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jingyun Tian updated HBASE-21647:
-
Attachment: Screenshot from 2019-01-03 15-31-36.png

> Add status track for splitting WAL tasks
> 
>
> Key: HBASE-21647
> URL: https://issues.apache.org/jira/browse/HBASE-21647
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Jingyun Tian
>Assignee: Jingyun Tian
>Priority: Major
> Attachments: Screenshot from 2019-01-03 15-31-26.png, Screenshot from 
> 2019-01-03 15-31-36.png
>
>
> add status track to help operator check the status of splitting WAL



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-21647) Add status track for splitting WAL tasks

2019-01-02 Thread Jingyun Tian (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-21647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jingyun Tian updated HBASE-21647:
-
Attachment: Screenshot from 2019-01-03 15-31-26.png

> Add status track for splitting WAL tasks
> 
>
> Key: HBASE-21647
> URL: https://issues.apache.org/jira/browse/HBASE-21647
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Jingyun Tian
>Assignee: Jingyun Tian
>Priority: Major
> Attachments: Screenshot from 2019-01-03 15-31-26.png, Screenshot from 
> 2019-01-03 15-31-36.png
>
>
> add status track to help operator check the status of splitting WAL



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21652) Refactor ThriftServer making thrift2 server inherited from thrift1 server

2019-01-02 Thread Allan Yang (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732706#comment-16732706
 ] 

Allan Yang commented on HBASE-21652:


[~stack], I'm currently working on HBASE-21661, after complete this one, I will 
open a discussion thread in the mail list to discuss about deprecate thrift1.

> Refactor ThriftServer making thrift2 server inherited from thrift1 server
> -
>
> Key: HBASE-21652
> URL: https://issues.apache.org/jira/browse/HBASE-21652
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Allan Yang
>Assignee: Allan Yang
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: HBASE-21652.branch-2.patch, HBASE-21652.patch, 
> HBASE-21652.v2.patch, HBASE-21652.v3.patch, HBASE-21652.v4.patch, 
> HBASE-21652.v5.patch, HBASE-21652.v6.patch, HBASE-21652.v7.patch
>
>
> Except the different protocol, thrift2 Server should have no much difference 
> from thrift1 Server.  So refactoring the thrift server, making thrift2 server 
> inherit from thrift1 server. Getting rid of many duplicated code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21588) Procedure v2 wal splitting implementation

2019-01-02 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732709#comment-16732709
 ] 

Hadoop QA commented on HBASE-21588:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
14s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 7 new or modified test 
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
27s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  3m 
32s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
50s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
35s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  5m  
7s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
57s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
15s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  3m 
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green}  3m 
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  3m 
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
 9s{color} | {color:green} The patch passed checkstyle in hbase-protocol-shaded 
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
24s{color} | {color:green} The patch passed checkstyle in hbase-common {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
15s{color} | {color:green} hbase-server: The patch generated 0 new + 271 
unchanged - 1 fixed = 271 total (was 272) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
31s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}  
9m 36s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4 
or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green}  
1m 31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  5m 
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
57s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
34s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m 
31s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}131m 54s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  1m 
 9s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}191m  4s{color} | 
{color:black} {color} |
\\
\\
|| 

[jira] [Commented] (HBASE-21665) OfflineMetaRepair tool fails with NPE

2019-01-02 Thread stack (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732703#comment-16732703
 ] 

stack commented on HBASE-21665:
---

Oh, we should make a call though. Currently failing w/ a NPE is not right.

> OfflineMetaRepair tool fails with NPE
> -
>
> Key: HBASE-21665
> URL: https://issues.apache.org/jira/browse/HBASE-21665
> Project: HBase
>  Issue Type: Bug
>  Components: hbck
>Affects Versions: 2.1.0, 2.0.0
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Critical
>
> OfflineMetaRepair fails with NPE, execute below command
> hbase org.apache.hadoop.hbase.util.hbck.OfflineMetaRepair -fix
>  
> {noformat}
> 2019-01-02 16:22:56,387 INFO [main] regionserver.HRegion: Opened 1588230740; 
> next sequenceid=28
> 2019-01-02 16:22:56,459 ERROR [main] hbck.OfflineMetaRepair: Bailed out due 
> to: 
> java.lang.NullPointerException
>  at 
> org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.getOrMakeChunk(MemStoreLABImpl.java:335)
>  at 
> org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.copyCellInto(MemStoreLABImpl.java:193)
>  at 
> org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.copyCellInto(MemStoreLABImpl.java:115)
>  at 
> org.apache.hadoop.hbase.regionserver.Segment.maybeCloneWithAllocator(Segment.java:183)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.maybeCloneWithAllocator(AbstractMemStore.java:334)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.doAdd(AbstractMemStore.java:157)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.doAddOrUpsert(AbstractMemStore.java:147)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.add(AbstractMemStore.java:117)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.add(AbstractMemStore.java:111)
>  at org.apache.hadoop.hbase.regionserver.HStore.add(HStore.java:750)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.applyToMemStore(HRegion.java:4435)
>  at org.apache.hadoop.hbase.regionserver.HRegion.access$500(HRegion.java:228)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.applyFamilyMapToMemStore(HRegion.java:3495)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.lambda$writeMiniBatchOperationsToMemStore$0(HRegion.java:3186)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.visitBatchOperations(HRegion.java:3119)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.writeMiniBatchOperationsToMemStore(HRegion.java:3178)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$MutationBatchOperation.writeMiniBatchOperationsToMemStore(HRegion.java:3660)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.doMiniBatchMutate(HRegion.java:4073)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:4006)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:3937)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:3928)
>  at org.apache.hadoop.hbase.util.HBaseFsck.rebuildMeta(HBaseFsck.java:1665)
>  at 
> org.apache.hadoop.hbase.util.hbck.OfflineMetaRepair.main(OfflineMetaRepair.java:121)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21665) OfflineMetaRepair tool fails with NPE

2019-01-02 Thread stack (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732696#comment-16732696
 ] 

stack commented on HBASE-21665:
---

Hello [~pankaj2461]

The offline meta rebuild tool and hbase2 have had no work done.

My opinion on the offline rebuild tool is that it was always a hack. It might 
get you 95% of the way toward an hbase:meta table but the final 5% would be 
guesswork and dataloss. I suppose this better than nothing but I was hoping we 
could just leave it behind. Do folks totally destroy their hbase:meta tables 
and need to rebuild from scratch?

I was hoping we could drop the .regioninfo files from under region dir. Ditto 
on the .tableinfo files under table dir. They are inevitably stale and were 
always a just-in-case. Was also hoping to make it so less tools and scripts 
were dependent on particular fs layouts and expecting to find certain files in 
certain locations. Only the master should know the internals otherwise its 
harder for us to change the fs or particulars of the layout. Could we ask the 
master to do a hbase:meta rebuild for us via hbck2. It might have more info 
than just layout in hdfs?

In your scenario, could you not copy the hbase1 meta table too? You'd need to 
upgrade it so the extra column family got added before you started up hbase2?

Thanks.


> OfflineMetaRepair tool fails with NPE
> -
>
> Key: HBASE-21665
> URL: https://issues.apache.org/jira/browse/HBASE-21665
> Project: HBase
>  Issue Type: Bug
>  Components: hbck
>Affects Versions: 2.1.0, 2.0.0
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Critical
>
> OfflineMetaRepair fails with NPE, execute below command
> hbase org.apache.hadoop.hbase.util.hbck.OfflineMetaRepair -fix
>  
> {noformat}
> 2019-01-02 16:22:56,387 INFO [main] regionserver.HRegion: Opened 1588230740; 
> next sequenceid=28
> 2019-01-02 16:22:56,459 ERROR [main] hbck.OfflineMetaRepair: Bailed out due 
> to: 
> java.lang.NullPointerException
>  at 
> org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.getOrMakeChunk(MemStoreLABImpl.java:335)
>  at 
> org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.copyCellInto(MemStoreLABImpl.java:193)
>  at 
> org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.copyCellInto(MemStoreLABImpl.java:115)
>  at 
> org.apache.hadoop.hbase.regionserver.Segment.maybeCloneWithAllocator(Segment.java:183)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.maybeCloneWithAllocator(AbstractMemStore.java:334)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.doAdd(AbstractMemStore.java:157)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.doAddOrUpsert(AbstractMemStore.java:147)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.add(AbstractMemStore.java:117)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.add(AbstractMemStore.java:111)
>  at org.apache.hadoop.hbase.regionserver.HStore.add(HStore.java:750)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.applyToMemStore(HRegion.java:4435)
>  at org.apache.hadoop.hbase.regionserver.HRegion.access$500(HRegion.java:228)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.applyFamilyMapToMemStore(HRegion.java:3495)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.lambda$writeMiniBatchOperationsToMemStore$0(HRegion.java:3186)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.visitBatchOperations(HRegion.java:3119)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.writeMiniBatchOperationsToMemStore(HRegion.java:3178)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$MutationBatchOperation.writeMiniBatchOperationsToMemStore(HRegion.java:3660)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.doMiniBatchMutate(HRegion.java:4073)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:4006)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:3937)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:3928)
>  at org.apache.hadoop.hbase.util.HBaseFsck.rebuildMeta(HBaseFsck.java:1665)
>  at 
> org.apache.hadoop.hbase.util.hbck.OfflineMetaRepair.main(OfflineMetaRepair.java:121)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21652) Refactor ThriftServer making thrift2 server inherited from thrift1 server

2019-01-02 Thread stack (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732697#comment-16732697
 ] 

stack commented on HBASE-21652:
---

Thanks [~allan163]. What else has to be done on this project? Can we deprecate 
thrift1 now (Can start a topic on dev list) or still need to fill out thrift2 
functionality more? 

> Refactor ThriftServer making thrift2 server inherited from thrift1 server
> -
>
> Key: HBASE-21652
> URL: https://issues.apache.org/jira/browse/HBASE-21652
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Allan Yang
>Assignee: Allan Yang
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: HBASE-21652.branch-2.patch, HBASE-21652.patch, 
> HBASE-21652.v2.patch, HBASE-21652.v3.patch, HBASE-21652.v4.patch, 
> HBASE-21652.v5.patch, HBASE-21652.v6.patch, HBASE-21652.v7.patch
>
>
> Except the different protocol, thrift2 Server should have no much difference 
> from thrift1 Server.  So refactoring the thrift server, making thrift2 server 
> inherit from thrift1 server. Getting rid of many duplicated code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21588) Procedure v2 wal splitting implementation

2019-01-02 Thread stack (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732700#comment-16732700
 ] 

stack commented on HBASE-21588:
---

Carrying my +1 over from rb. Let me rerun the patch build to see if failure 
related (probably not)

> Procedure v2 wal splitting implementation
> -
>
> Key: HBASE-21588
> URL: https://issues.apache.org/jira/browse/HBASE-21588
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Jingyun Tian
>Assignee: Jingyun Tian
>Priority: Major
> Attachments: HBASE-21588.master.003.patch, 
> HBASE-21588.master.004.patch, HBASE-21588.master.005.patch, 
> HBASE-21588.master.006.patch, HBASE-21588.master.007.patch, 
> HBASE-21588.master.008.patch, HBASE-21588.master.009.patch, 
> HBASE-21588.master.010.patch, HBASE-21588.master.011.patch, 
> HBASE-21588.master.012.patch, HBASE-21588.master.013.patch, 
> HBASE-21588.master.014.patch, HBASE-21588.master.015.patch, 
> HBASE-21588.master.016.patch, HBASE-21588.master.017.patch, 
> HBASE-21588.master.018.patch, HBASE-21588.master.018.patch
>
>
> create a sub task to submit the implementation of procedure v2 wal splitting



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-21588) Procedure v2 wal splitting implementation

2019-01-02 Thread stack (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-21588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-21588:
--
Attachment: HBASE-21588.master.018.patch

> Procedure v2 wal splitting implementation
> -
>
> Key: HBASE-21588
> URL: https://issues.apache.org/jira/browse/HBASE-21588
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Jingyun Tian
>Assignee: Jingyun Tian
>Priority: Major
> Attachments: HBASE-21588.master.003.patch, 
> HBASE-21588.master.004.patch, HBASE-21588.master.005.patch, 
> HBASE-21588.master.006.patch, HBASE-21588.master.007.patch, 
> HBASE-21588.master.008.patch, HBASE-21588.master.009.patch, 
> HBASE-21588.master.010.patch, HBASE-21588.master.011.patch, 
> HBASE-21588.master.012.patch, HBASE-21588.master.013.patch, 
> HBASE-21588.master.014.patch, HBASE-21588.master.015.patch, 
> HBASE-21588.master.016.patch, HBASE-21588.master.017.patch, 
> HBASE-21588.master.018.patch, HBASE-21588.master.018.patch
>
>
> create a sub task to submit the implementation of procedure v2 wal splitting



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21665) OfflineMetaRepair tool fails with NPE

2019-01-02 Thread Pankaj Kumar (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732655#comment-16732655
 ] 

Pankaj Kumar commented on HBASE-21665:
--

Here we are skipping region load during master startup in 
AssignmentManager.visitRegionState() based on below conditions,

{code}

if (state == null && regionLocation == null && lastHost == null &&
 openSeqNum == SequenceId.NO_SEQUENCE_ID) {
 // This is a row with nothing in it.
 LOG.warn("Skipping empty row={}", result);
 return;
 }

{code}

 

> OfflineMetaRepair tool fails with NPE
> -
>
> Key: HBASE-21665
> URL: https://issues.apache.org/jira/browse/HBASE-21665
> Project: HBase
>  Issue Type: Bug
>  Components: hbck
>Affects Versions: 2.1.0, 2.0.0
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Critical
>
> OfflineMetaRepair fails with NPE, execute below command
> hbase org.apache.hadoop.hbase.util.hbck.OfflineMetaRepair -fix
>  
> {noformat}
> 2019-01-02 16:22:56,387 INFO [main] regionserver.HRegion: Opened 1588230740; 
> next sequenceid=28
> 2019-01-02 16:22:56,459 ERROR [main] hbck.OfflineMetaRepair: Bailed out due 
> to: 
> java.lang.NullPointerException
>  at 
> org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.getOrMakeChunk(MemStoreLABImpl.java:335)
>  at 
> org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.copyCellInto(MemStoreLABImpl.java:193)
>  at 
> org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.copyCellInto(MemStoreLABImpl.java:115)
>  at 
> org.apache.hadoop.hbase.regionserver.Segment.maybeCloneWithAllocator(Segment.java:183)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.maybeCloneWithAllocator(AbstractMemStore.java:334)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.doAdd(AbstractMemStore.java:157)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.doAddOrUpsert(AbstractMemStore.java:147)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.add(AbstractMemStore.java:117)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.add(AbstractMemStore.java:111)
>  at org.apache.hadoop.hbase.regionserver.HStore.add(HStore.java:750)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.applyToMemStore(HRegion.java:4435)
>  at org.apache.hadoop.hbase.regionserver.HRegion.access$500(HRegion.java:228)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.applyFamilyMapToMemStore(HRegion.java:3495)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.lambda$writeMiniBatchOperationsToMemStore$0(HRegion.java:3186)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.visitBatchOperations(HRegion.java:3119)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.writeMiniBatchOperationsToMemStore(HRegion.java:3178)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$MutationBatchOperation.writeMiniBatchOperationsToMemStore(HRegion.java:3660)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.doMiniBatchMutate(HRegion.java:4073)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:4006)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:3937)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:3928)
>  at org.apache.hadoop.hbase.util.HBaseFsck.rebuildMeta(HBaseFsck.java:1665)
>  at 
> org.apache.hadoop.hbase.util.hbck.OfflineMetaRepair.main(OfflineMetaRepair.java:121)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21665) OfflineMetaRepair tool fails with NPE

2019-01-02 Thread Pankaj Kumar (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732643#comment-16732643
 ] 

Pankaj Kumar commented on HBASE-21665:
--

What is the future of OfflineMetaRepair tool, however this is an important tool 
IMO for rebuilding meta in case of meta corruption or upgrade.

What is your opinion? Should we fix this problem here and make the region 
assignment on master startup?

or
{quote}read the regions from FS and assign them
{quote}
Add option in HBCK2 to read the regions from FS and assign them.

> OfflineMetaRepair tool fails with NPE
> -
>
> Key: HBASE-21665
> URL: https://issues.apache.org/jira/browse/HBASE-21665
> Project: HBase
>  Issue Type: Bug
>  Components: hbck
>Affects Versions: 2.1.0, 2.0.0
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Critical
>
> OfflineMetaRepair fails with NPE, execute below command
> hbase org.apache.hadoop.hbase.util.hbck.OfflineMetaRepair -fix
>  
> {noformat}
> 2019-01-02 16:22:56,387 INFO [main] regionserver.HRegion: Opened 1588230740; 
> next sequenceid=28
> 2019-01-02 16:22:56,459 ERROR [main] hbck.OfflineMetaRepair: Bailed out due 
> to: 
> java.lang.NullPointerException
>  at 
> org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.getOrMakeChunk(MemStoreLABImpl.java:335)
>  at 
> org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.copyCellInto(MemStoreLABImpl.java:193)
>  at 
> org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.copyCellInto(MemStoreLABImpl.java:115)
>  at 
> org.apache.hadoop.hbase.regionserver.Segment.maybeCloneWithAllocator(Segment.java:183)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.maybeCloneWithAllocator(AbstractMemStore.java:334)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.doAdd(AbstractMemStore.java:157)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.doAddOrUpsert(AbstractMemStore.java:147)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.add(AbstractMemStore.java:117)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.add(AbstractMemStore.java:111)
>  at org.apache.hadoop.hbase.regionserver.HStore.add(HStore.java:750)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.applyToMemStore(HRegion.java:4435)
>  at org.apache.hadoop.hbase.regionserver.HRegion.access$500(HRegion.java:228)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.applyFamilyMapToMemStore(HRegion.java:3495)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.lambda$writeMiniBatchOperationsToMemStore$0(HRegion.java:3186)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.visitBatchOperations(HRegion.java:3119)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.writeMiniBatchOperationsToMemStore(HRegion.java:3178)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$MutationBatchOperation.writeMiniBatchOperationsToMemStore(HRegion.java:3660)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.doMiniBatchMutate(HRegion.java:4073)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:4006)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:3937)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:3928)
>  at org.apache.hadoop.hbase.util.HBaseFsck.rebuildMeta(HBaseFsck.java:1665)
>  at 
> org.apache.hadoop.hbase.util.hbck.OfflineMetaRepair.main(OfflineMetaRepair.java:121)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-21652) Refactor ThriftServer making thrift2 server inherited from thrift1 server

2019-01-02 Thread Allan Yang (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-21652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Allan Yang updated HBASE-21652:
---
Release Note: Before this issue, thrift1 server and thrift2 server are 
totally different servers. If a new feature is added to thrift1 server, thrfit2 
server have to make the same change to support it(e.g. authorization). After 
this issue, thrift2 server is inherited from thrift1, thrift2 server now have 
all the features thrift1 server has(e.g http support, which thrift2 server 
doesn't have before).  The way to start thrift1 or thrift2 server remain the 
same after this issue.  (was: Before this issue, thrift1 server and thrift2 
server are totally different servers. If a new feature is added to thrift1 
server, thrfit2 server have to make the same change to support it(e.g. 
authorization). After this issue, thrift2 server is inherited from thrift1, 
thrift2 server now have all the features thrift1 server has(e.g http support, 
which thrift2 server doesn't have before). )

> Refactor ThriftServer making thrift2 server inherited from thrift1 server
> -
>
> Key: HBASE-21652
> URL: https://issues.apache.org/jira/browse/HBASE-21652
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Allan Yang
>Assignee: Allan Yang
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: HBASE-21652.branch-2.patch, HBASE-21652.patch, 
> HBASE-21652.v2.patch, HBASE-21652.v3.patch, HBASE-21652.v4.patch, 
> HBASE-21652.v5.patch, HBASE-21652.v6.patch, HBASE-21652.v7.patch
>
>
> Except the different protocol, thrift2 Server should have no much difference 
> from thrift1 Server.  So refactoring the thrift server, making thrift2 server 
> inherit from thrift1 server. Getting rid of many duplicated code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (HBASE-18569) Add prefetch support for async region locator

2019-01-02 Thread Duo Zhang (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-18569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang resolved HBASE-18569.
---
   Resolution: Fixed
Fix Version/s: 2.0.5

Pushed to branch-2.0.

> Add prefetch support for async region locator
> -
>
> Key: HBASE-18569
> URL: https://issues.apache.org/jira/browse/HBASE-18569
> Project: HBase
>  Issue Type: Sub-task
>  Components: asyncclient, Client
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.0.5, 2.1.0
>
> Attachments: HBASE-18569-v1.patch, HBASE-18569.patch
>
>
> It will be useful for large tables.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21652) Refactor ThriftServer making thrift2 server inherited from thrift1 server

2019-01-02 Thread Allan Yang (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732636#comment-16732636
 ] 

Allan Yang commented on HBASE-21652:


[~stack], no, they are not, I will add it to RN, thanks for reminding.

> Refactor ThriftServer making thrift2 server inherited from thrift1 server
> -
>
> Key: HBASE-21652
> URL: https://issues.apache.org/jira/browse/HBASE-21652
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Allan Yang
>Assignee: Allan Yang
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: HBASE-21652.branch-2.patch, HBASE-21652.patch, 
> HBASE-21652.v2.patch, HBASE-21652.v3.patch, HBASE-21652.v4.patch, 
> HBASE-21652.v5.patch, HBASE-21652.v6.patch, HBASE-21652.v7.patch
>
>
> Except the different protocol, thrift2 Server should have no much difference 
> from thrift1 Server.  So refactoring the thrift server, making thrift2 server 
> inherit from thrift1 server. Getting rid of many duplicated code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-17356) Add replica get support

2019-01-02 Thread Duo Zhang (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-17356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang updated HBASE-17356:
--
  Resolution: Fixed
Hadoop Flags: Reviewed
  Status: Resolved  (was: Patch Available)

Pushed to branch-2.0+.

Thanks [~zghaobac] for reviewing.

> Add replica get support
> ---
>
> Key: HBASE-17356
> URL: https://issues.apache.org/jira/browse/HBASE-17356
> Project: HBase
>  Issue Type: Sub-task
>  Components: Client
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.1.3, 2.0.5
>
> Attachments: HBASE-17356-v1.patch, HBASE-17356-v2.patch, 
> HBASE-17356-v2.patch, HBASE-17356-v3.patch, HBASE-17356-v4.patch, 
> HBASE-17356-v5.patch, HBASE-17356-v5.patch, HBASE-17356.patch
>
>
> I think we can do better for scan at least as now we will pass the mvcc to 
> client. We can use the mvcc to determine if we can get a consistent view when 
> reading from replicas other than primary.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21652) Refactor ThriftServer making thrift2 server inherited from thrift1 server

2019-01-02 Thread stack (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732621#comment-16732621
 ] 

stack commented on HBASE-21652:
---

Sorry [~allan163]. I meant, is there any change in how start a thrift1 server 
(or a thrift2 server) after this change?

> Refactor ThriftServer making thrift2 server inherited from thrift1 server
> -
>
> Key: HBASE-21652
> URL: https://issues.apache.org/jira/browse/HBASE-21652
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Allan Yang
>Assignee: Allan Yang
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: HBASE-21652.branch-2.patch, HBASE-21652.patch, 
> HBASE-21652.v2.patch, HBASE-21652.v3.patch, HBASE-21652.v4.patch, 
> HBASE-21652.v5.patch, HBASE-21652.v6.patch, HBASE-21652.v7.patch
>
>
> Except the different protocol, thrift2 Server should have no much difference 
> from thrift1 Server.  So refactoring the thrift server, making thrift2 server 
> inherit from thrift1 server. Getting rid of many duplicated code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-21588) Procedure v2 wal splitting implementation

2019-01-02 Thread Jingyun Tian (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-21588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jingyun Tian updated HBASE-21588:
-
Attachment: HBASE-21588.master.018.patch

> Procedure v2 wal splitting implementation
> -
>
> Key: HBASE-21588
> URL: https://issues.apache.org/jira/browse/HBASE-21588
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Jingyun Tian
>Assignee: Jingyun Tian
>Priority: Major
> Attachments: HBASE-21588.master.003.patch, 
> HBASE-21588.master.004.patch, HBASE-21588.master.005.patch, 
> HBASE-21588.master.006.patch, HBASE-21588.master.007.patch, 
> HBASE-21588.master.008.patch, HBASE-21588.master.009.patch, 
> HBASE-21588.master.010.patch, HBASE-21588.master.011.patch, 
> HBASE-21588.master.012.patch, HBASE-21588.master.013.patch, 
> HBASE-21588.master.014.patch, HBASE-21588.master.015.patch, 
> HBASE-21588.master.016.patch, HBASE-21588.master.017.patch, 
> HBASE-21588.master.018.patch
>
>
> create a sub task to submit the implementation of procedure v2 wal splitting



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21665) OfflineMetaRepair tool fails with NPE

2019-01-02 Thread Sean Busbey (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732617#comment-16732617
 ] 

Sean Busbey commented on HBASE-21665:
-

{quote}
bq. Probably HBCK2 is what you should be using to try to fix things.

I have checked HBCK2, there we dont have such option to read the regions from 
FS and assign them (please correct me if I'm wrong).
{quote}

You're correct. I'll keep watching. :)

> OfflineMetaRepair tool fails with NPE
> -
>
> Key: HBASE-21665
> URL: https://issues.apache.org/jira/browse/HBASE-21665
> Project: HBase
>  Issue Type: Bug
>  Components: hbck
>Affects Versions: 2.1.0, 2.0.0
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Critical
>
> OfflineMetaRepair fails with NPE, execute below command
> hbase org.apache.hadoop.hbase.util.hbck.OfflineMetaRepair -fix
>  
> {noformat}
> 2019-01-02 16:22:56,387 INFO [main] regionserver.HRegion: Opened 1588230740; 
> next sequenceid=28
> 2019-01-02 16:22:56,459 ERROR [main] hbck.OfflineMetaRepair: Bailed out due 
> to: 
> java.lang.NullPointerException
>  at 
> org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.getOrMakeChunk(MemStoreLABImpl.java:335)
>  at 
> org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.copyCellInto(MemStoreLABImpl.java:193)
>  at 
> org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.copyCellInto(MemStoreLABImpl.java:115)
>  at 
> org.apache.hadoop.hbase.regionserver.Segment.maybeCloneWithAllocator(Segment.java:183)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.maybeCloneWithAllocator(AbstractMemStore.java:334)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.doAdd(AbstractMemStore.java:157)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.doAddOrUpsert(AbstractMemStore.java:147)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.add(AbstractMemStore.java:117)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.add(AbstractMemStore.java:111)
>  at org.apache.hadoop.hbase.regionserver.HStore.add(HStore.java:750)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.applyToMemStore(HRegion.java:4435)
>  at org.apache.hadoop.hbase.regionserver.HRegion.access$500(HRegion.java:228)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.applyFamilyMapToMemStore(HRegion.java:3495)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.lambda$writeMiniBatchOperationsToMemStore$0(HRegion.java:3186)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.visitBatchOperations(HRegion.java:3119)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.writeMiniBatchOperationsToMemStore(HRegion.java:3178)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$MutationBatchOperation.writeMiniBatchOperationsToMemStore(HRegion.java:3660)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.doMiniBatchMutate(HRegion.java:4073)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:4006)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:3937)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:3928)
>  at org.apache.hadoop.hbase.util.HBaseFsck.rebuildMeta(HBaseFsck.java:1665)
>  at 
> org.apache.hadoop.hbase.util.hbck.OfflineMetaRepair.main(OfflineMetaRepair.java:121)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-21159) Add shell command to switch throttle on or off

2019-01-02 Thread Yi Mei (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-21159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yi Mei updated HBASE-21159:
---
Attachment: HBASE-21159.master.006.patch

> Add shell command to switch throttle on or off
> --
>
> Key: HBASE-21159
> URL: https://issues.apache.org/jira/browse/HBASE-21159
> Project: HBase
>  Issue Type: Sub-task
>Affects Versions: 3.0.0, 2.2.0
>Reporter: Yi Mei
>Assignee: Yi Mei
>Priority: Major
> Attachments: HBASE-21159.master.001.patch, 
> HBASE-21159.master.002.patch, HBASE-21159.master.003.patch, 
> HBASE-21159.master.004.patch, HBASE-21159.master.005.patch, 
> HBASE-21159.master.006.patch
>
>
> Add shell command to switch throttle on or off. When throttle is off, HBase 
> will not throttle any request. This feature may be useful in production 
> environment.
> We can use the following commands to switch throttle:
> throttle_switch true / throttle_switch false



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21665) OfflineMetaRepair tool fails with NPE

2019-01-02 Thread Pankaj Kumar (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732605#comment-16732605
 ] 

Pankaj Kumar commented on HBASE-21665:
--

{quote}What was the original problme you were hoping to solve?
{quote}
We have a use case where we migrate (say from 1.3.x to 2.1.x) old cluster data 
(copy data directory) to new cluster, rebuild the meta using OfflineMetaRepair 
and start the cluster.

 
{quote}Probably HBCK2 is what you should be using to try to fix things.
{quote}
I have checked HBCK2, there we dont have such option to read the regions from 
FS and assign them (please correct me if I'm wrong).

> OfflineMetaRepair tool fails with NPE
> -
>
> Key: HBASE-21665
> URL: https://issues.apache.org/jira/browse/HBASE-21665
> Project: HBase
>  Issue Type: Bug
>  Components: hbck
>Affects Versions: 2.1.0, 2.0.0
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Critical
>
> OfflineMetaRepair fails with NPE, execute below command
> hbase org.apache.hadoop.hbase.util.hbck.OfflineMetaRepair -fix
>  
> {noformat}
> 2019-01-02 16:22:56,387 INFO [main] regionserver.HRegion: Opened 1588230740; 
> next sequenceid=28
> 2019-01-02 16:22:56,459 ERROR [main] hbck.OfflineMetaRepair: Bailed out due 
> to: 
> java.lang.NullPointerException
>  at 
> org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.getOrMakeChunk(MemStoreLABImpl.java:335)
>  at 
> org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.copyCellInto(MemStoreLABImpl.java:193)
>  at 
> org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.copyCellInto(MemStoreLABImpl.java:115)
>  at 
> org.apache.hadoop.hbase.regionserver.Segment.maybeCloneWithAllocator(Segment.java:183)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.maybeCloneWithAllocator(AbstractMemStore.java:334)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.doAdd(AbstractMemStore.java:157)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.doAddOrUpsert(AbstractMemStore.java:147)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.add(AbstractMemStore.java:117)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.add(AbstractMemStore.java:111)
>  at org.apache.hadoop.hbase.regionserver.HStore.add(HStore.java:750)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.applyToMemStore(HRegion.java:4435)
>  at org.apache.hadoop.hbase.regionserver.HRegion.access$500(HRegion.java:228)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.applyFamilyMapToMemStore(HRegion.java:3495)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.lambda$writeMiniBatchOperationsToMemStore$0(HRegion.java:3186)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.visitBatchOperations(HRegion.java:3119)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.writeMiniBatchOperationsToMemStore(HRegion.java:3178)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$MutationBatchOperation.writeMiniBatchOperationsToMemStore(HRegion.java:3660)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.doMiniBatchMutate(HRegion.java:4073)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:4006)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:3937)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:3928)
>  at org.apache.hadoop.hbase.util.HBaseFsck.rebuildMeta(HBaseFsck.java:1665)
>  at 
> org.apache.hadoop.hbase.util.hbck.OfflineMetaRepair.main(OfflineMetaRepair.java:121)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-21662) Add append_peer_exclude_namespaces and remove_peer_exclude_namespaces shell commands

2019-01-02 Thread Guanghao Zhang (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-21662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guanghao Zhang updated HBASE-21662:
---
Fix Version/s: 2.0.5
   2.1.3
   2.2.0
   3.0.0

> Add append_peer_exclude_namespaces and remove_peer_exclude_namespaces shell 
> commands
> 
>
> Key: HBASE-21662
> URL: https://issues.apache.org/jira/browse/HBASE-21662
> Project: HBase
>  Issue Type: Improvement
>Reporter: Yi Mei
>Assignee: Yi Mei
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.1.3, 2.0.5
>
> Attachments: HBASE-21662.master.001.patch, 
> HBASE-21662.master.002.patch
>
>
> To add or remove a namespace to peers' exclude namespace list, the current 
> way is use set_peer_exclude_namespaces. But one have to copy all exclude 
> namespaces of the peer firstly and modify it, which is error-prone and 
> time-consuming.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-21662) Add append_peer_exclude_namespaces and remove_peer_exclude_namespaces shell commands

2019-01-02 Thread Guanghao Zhang (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-21662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guanghao Zhang updated HBASE-21662:
---
Resolution: Fixed
Status: Resolved  (was: Patch Available)

Pushed to branch-2.0+. Thanks [~Yi Mei] for contributing.

> Add append_peer_exclude_namespaces and remove_peer_exclude_namespaces shell 
> commands
> 
>
> Key: HBASE-21662
> URL: https://issues.apache.org/jira/browse/HBASE-21662
> Project: HBase
>  Issue Type: Improvement
>Reporter: Yi Mei
>Assignee: Yi Mei
>Priority: Major
> Attachments: HBASE-21662.master.001.patch, 
> HBASE-21662.master.002.patch
>
>
> To add or remove a namespace to peers' exclude namespace list, the current 
> way is use set_peer_exclude_namespaces. But one have to copy all exclude 
> namespaces of the peer firstly and modify it, which is error-prone and 
> time-consuming.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (HBASE-18569) Add prefetch support for async region locator

2019-01-02 Thread Duo Zhang (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-18569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang reopened HBASE-18569:
---

Reopen for cherry-picking to branch-2.0.

> Add prefetch support for async region locator
> -
>
> Key: HBASE-18569
> URL: https://issues.apache.org/jira/browse/HBASE-18569
> Project: HBase
>  Issue Type: Sub-task
>  Components: asyncclient, Client
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.1.0
>
> Attachments: HBASE-18569-v1.patch, HBASE-18569.patch
>
>
> It will be useful for large tables.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21665) OfflineMetaRepair tool fails with NPE

2019-01-02 Thread Sean Busbey (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732597#comment-16732597
 ] 

Sean Busbey commented on HBASE-21665:
-

I'm not sure this tool is expected to work on an HBase 2 cluster, primarily 
because it resides in the "hbck" package space and that tool is known capable 
of destroying an HBase 2 cluster.

What was the original problme you were hoping to solve? Probably HBCK2 is what 
you should be using to try to fix things.

> OfflineMetaRepair tool fails with NPE
> -
>
> Key: HBASE-21665
> URL: https://issues.apache.org/jira/browse/HBASE-21665
> Project: HBase
>  Issue Type: Bug
>  Components: hbck
>Affects Versions: 2.1.0, 2.0.0
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Critical
>
> OfflineMetaRepair fails with NPE, execute below command
> hbase org.apache.hadoop.hbase.util.hbck.OfflineMetaRepair -fix
>  
> {noformat}
> 2019-01-02 16:22:56,387 INFO [main] regionserver.HRegion: Opened 1588230740; 
> next sequenceid=28
> 2019-01-02 16:22:56,459 ERROR [main] hbck.OfflineMetaRepair: Bailed out due 
> to: 
> java.lang.NullPointerException
>  at 
> org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.getOrMakeChunk(MemStoreLABImpl.java:335)
>  at 
> org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.copyCellInto(MemStoreLABImpl.java:193)
>  at 
> org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.copyCellInto(MemStoreLABImpl.java:115)
>  at 
> org.apache.hadoop.hbase.regionserver.Segment.maybeCloneWithAllocator(Segment.java:183)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.maybeCloneWithAllocator(AbstractMemStore.java:334)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.doAdd(AbstractMemStore.java:157)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.doAddOrUpsert(AbstractMemStore.java:147)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.add(AbstractMemStore.java:117)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.add(AbstractMemStore.java:111)
>  at org.apache.hadoop.hbase.regionserver.HStore.add(HStore.java:750)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.applyToMemStore(HRegion.java:4435)
>  at org.apache.hadoop.hbase.regionserver.HRegion.access$500(HRegion.java:228)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.applyFamilyMapToMemStore(HRegion.java:3495)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.lambda$writeMiniBatchOperationsToMemStore$0(HRegion.java:3186)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.visitBatchOperations(HRegion.java:3119)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.writeMiniBatchOperationsToMemStore(HRegion.java:3178)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$MutationBatchOperation.writeMiniBatchOperationsToMemStore(HRegion.java:3660)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.doMiniBatchMutate(HRegion.java:4073)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:4006)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:3937)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:3928)
>  at org.apache.hadoop.hbase.util.HBaseFsck.rebuildMeta(HBaseFsck.java:1665)
>  at 
> org.apache.hadoop.hbase.util.hbck.OfflineMetaRepair.main(OfflineMetaRepair.java:121)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-21665) OfflineMetaRepair tool fails with NPE

2019-01-02 Thread Sean Busbey (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-21665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey updated HBASE-21665:

Affects Version/s: 2.1.0
   2.0.0

> OfflineMetaRepair tool fails with NPE
> -
>
> Key: HBASE-21665
> URL: https://issues.apache.org/jira/browse/HBASE-21665
> Project: HBase
>  Issue Type: Bug
>  Components: hbck
>Affects Versions: 2.1.0, 2.0.0
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Critical
>
> OfflineMetaRepair fails with NPE, execute below command
> hbase org.apache.hadoop.hbase.util.hbck.OfflineMetaRepair -fix
>  
> {noformat}
> 2019-01-02 16:22:56,387 INFO [main] regionserver.HRegion: Opened 1588230740; 
> next sequenceid=28
> 2019-01-02 16:22:56,459 ERROR [main] hbck.OfflineMetaRepair: Bailed out due 
> to: 
> java.lang.NullPointerException
>  at 
> org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.getOrMakeChunk(MemStoreLABImpl.java:335)
>  at 
> org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.copyCellInto(MemStoreLABImpl.java:193)
>  at 
> org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.copyCellInto(MemStoreLABImpl.java:115)
>  at 
> org.apache.hadoop.hbase.regionserver.Segment.maybeCloneWithAllocator(Segment.java:183)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.maybeCloneWithAllocator(AbstractMemStore.java:334)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.doAdd(AbstractMemStore.java:157)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.doAddOrUpsert(AbstractMemStore.java:147)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.add(AbstractMemStore.java:117)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.add(AbstractMemStore.java:111)
>  at org.apache.hadoop.hbase.regionserver.HStore.add(HStore.java:750)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.applyToMemStore(HRegion.java:4435)
>  at org.apache.hadoop.hbase.regionserver.HRegion.access$500(HRegion.java:228)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.applyFamilyMapToMemStore(HRegion.java:3495)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.lambda$writeMiniBatchOperationsToMemStore$0(HRegion.java:3186)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.visitBatchOperations(HRegion.java:3119)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.writeMiniBatchOperationsToMemStore(HRegion.java:3178)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$MutationBatchOperation.writeMiniBatchOperationsToMemStore(HRegion.java:3660)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.doMiniBatchMutate(HRegion.java:4073)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:4006)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:3937)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:3928)
>  at org.apache.hadoop.hbase.util.HBaseFsck.rebuildMeta(HBaseFsck.java:1665)
>  at 
> org.apache.hadoop.hbase.util.hbck.OfflineMetaRepair.main(OfflineMetaRepair.java:121)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-21665) OfflineMetaRepair tool fails with NPE

2019-01-02 Thread Sean Busbey (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-21665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey updated HBASE-21665:

Component/s: hbck

> OfflineMetaRepair tool fails with NPE
> -
>
> Key: HBASE-21665
> URL: https://issues.apache.org/jira/browse/HBASE-21665
> Project: HBase
>  Issue Type: Bug
>  Components: hbck
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Critical
>
> OfflineMetaRepair fails with NPE, execute below command
> hbase org.apache.hadoop.hbase.util.hbck.OfflineMetaRepair -fix
>  
> {noformat}
> 2019-01-02 16:22:56,387 INFO [main] regionserver.HRegion: Opened 1588230740; 
> next sequenceid=28
> 2019-01-02 16:22:56,459 ERROR [main] hbck.OfflineMetaRepair: Bailed out due 
> to: 
> java.lang.NullPointerException
>  at 
> org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.getOrMakeChunk(MemStoreLABImpl.java:335)
>  at 
> org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.copyCellInto(MemStoreLABImpl.java:193)
>  at 
> org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.copyCellInto(MemStoreLABImpl.java:115)
>  at 
> org.apache.hadoop.hbase.regionserver.Segment.maybeCloneWithAllocator(Segment.java:183)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.maybeCloneWithAllocator(AbstractMemStore.java:334)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.doAdd(AbstractMemStore.java:157)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.doAddOrUpsert(AbstractMemStore.java:147)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.add(AbstractMemStore.java:117)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.add(AbstractMemStore.java:111)
>  at org.apache.hadoop.hbase.regionserver.HStore.add(HStore.java:750)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.applyToMemStore(HRegion.java:4435)
>  at org.apache.hadoop.hbase.regionserver.HRegion.access$500(HRegion.java:228)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.applyFamilyMapToMemStore(HRegion.java:3495)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.lambda$writeMiniBatchOperationsToMemStore$0(HRegion.java:3186)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.visitBatchOperations(HRegion.java:3119)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.writeMiniBatchOperationsToMemStore(HRegion.java:3178)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$MutationBatchOperation.writeMiniBatchOperationsToMemStore(HRegion.java:3660)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.doMiniBatchMutate(HRegion.java:4073)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:4006)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:3937)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:3928)
>  at org.apache.hadoop.hbase.util.HBaseFsck.rebuildMeta(HBaseFsck.java:1665)
>  at 
> org.apache.hadoop.hbase.util.hbck.OfflineMetaRepair.main(OfflineMetaRepair.java:121)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-21665) OfflineMetaRepair tool fails with NPE

2019-01-02 Thread Pankaj Kumar (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-21665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pankaj Kumar updated HBASE-21665:
-
Priority: Critical  (was: Major)

> OfflineMetaRepair tool fails with NPE
> -
>
> Key: HBASE-21665
> URL: https://issues.apache.org/jira/browse/HBASE-21665
> Project: HBase
>  Issue Type: Bug
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Critical
>
> OfflineMetaRepair fails with NPE, execute below command
> hbase org.apache.hadoop.hbase.util.hbck.OfflineMetaRepair -fix
>  
> {noformat}
> 2019-01-02 16:22:56,387 INFO [main] regionserver.HRegion: Opened 1588230740; 
> next sequenceid=28
> 2019-01-02 16:22:56,459 ERROR [main] hbck.OfflineMetaRepair: Bailed out due 
> to: 
> java.lang.NullPointerException
>  at 
> org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.getOrMakeChunk(MemStoreLABImpl.java:335)
>  at 
> org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.copyCellInto(MemStoreLABImpl.java:193)
>  at 
> org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.copyCellInto(MemStoreLABImpl.java:115)
>  at 
> org.apache.hadoop.hbase.regionserver.Segment.maybeCloneWithAllocator(Segment.java:183)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.maybeCloneWithAllocator(AbstractMemStore.java:334)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.doAdd(AbstractMemStore.java:157)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.doAddOrUpsert(AbstractMemStore.java:147)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.add(AbstractMemStore.java:117)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.add(AbstractMemStore.java:111)
>  at org.apache.hadoop.hbase.regionserver.HStore.add(HStore.java:750)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.applyToMemStore(HRegion.java:4435)
>  at org.apache.hadoop.hbase.regionserver.HRegion.access$500(HRegion.java:228)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.applyFamilyMapToMemStore(HRegion.java:3495)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.lambda$writeMiniBatchOperationsToMemStore$0(HRegion.java:3186)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.visitBatchOperations(HRegion.java:3119)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.writeMiniBatchOperationsToMemStore(HRegion.java:3178)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$MutationBatchOperation.writeMiniBatchOperationsToMemStore(HRegion.java:3660)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.doMiniBatchMutate(HRegion.java:4073)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:4006)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:3937)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:3928)
>  at org.apache.hadoop.hbase.util.HBaseFsck.rebuildMeta(HBaseFsck.java:1665)
>  at 
> org.apache.hadoop.hbase.util.hbck.OfflineMetaRepair.main(OfflineMetaRepair.java:121)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21665) OfflineMetaRepair tool fails with NPE

2019-01-02 Thread Pankaj Kumar (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732595#comment-16732595
 ] 

Pankaj Kumar commented on HBASE-21665:
--

Here mslab is not required in case of OfflineMetaRepair, so NPE can be resolved 
by
{code}
conf.setBoolean("hbase.hregion.memstore.mslab.enabled", false);
{code}

After modification meta is rebuild successfully with the "table:state" & 
"info:regioninfo" for non-meta and user tables.

But on HBase cluster startup none of the regions are assigned and HMaster is 
getting aborted due to Namespace init timeout. Will further check this issue.

> OfflineMetaRepair tool fails with NPE
> -
>
> Key: HBASE-21665
> URL: https://issues.apache.org/jira/browse/HBASE-21665
> Project: HBase
>  Issue Type: Bug
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Major
>
> OfflineMetaRepair fails with NPE, execute below command
> hbase org.apache.hadoop.hbase.util.hbck.OfflineMetaRepair -fix
>  
> {noformat}
> 2019-01-02 16:22:56,387 INFO [main] regionserver.HRegion: Opened 1588230740; 
> next sequenceid=28
> 2019-01-02 16:22:56,459 ERROR [main] hbck.OfflineMetaRepair: Bailed out due 
> to: 
> java.lang.NullPointerException
>  at 
> org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.getOrMakeChunk(MemStoreLABImpl.java:335)
>  at 
> org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.copyCellInto(MemStoreLABImpl.java:193)
>  at 
> org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.copyCellInto(MemStoreLABImpl.java:115)
>  at 
> org.apache.hadoop.hbase.regionserver.Segment.maybeCloneWithAllocator(Segment.java:183)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.maybeCloneWithAllocator(AbstractMemStore.java:334)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.doAdd(AbstractMemStore.java:157)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.doAddOrUpsert(AbstractMemStore.java:147)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.add(AbstractMemStore.java:117)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.add(AbstractMemStore.java:111)
>  at org.apache.hadoop.hbase.regionserver.HStore.add(HStore.java:750)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.applyToMemStore(HRegion.java:4435)
>  at org.apache.hadoop.hbase.regionserver.HRegion.access$500(HRegion.java:228)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.applyFamilyMapToMemStore(HRegion.java:3495)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.lambda$writeMiniBatchOperationsToMemStore$0(HRegion.java:3186)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.visitBatchOperations(HRegion.java:3119)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.writeMiniBatchOperationsToMemStore(HRegion.java:3178)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$MutationBatchOperation.writeMiniBatchOperationsToMemStore(HRegion.java:3660)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.doMiniBatchMutate(HRegion.java:4073)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:4006)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:3937)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:3928)
>  at org.apache.hadoop.hbase.util.HBaseFsck.rebuildMeta(HBaseFsck.java:1665)
>  at 
> org.apache.hadoop.hbase.util.hbck.OfflineMetaRepair.main(OfflineMetaRepair.java:121)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21652) Refactor ThriftServer making thrift2 server inherited from thrift1 server

2019-01-02 Thread Allan Yang (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732586#comment-16732586
 ] 

Allan Yang commented on HBASE-21652:


{quote}
Does how you invoke thrift1 or thrift2 change 
{quote}
[~stack], sorry, I don't get your point.

> Refactor ThriftServer making thrift2 server inherited from thrift1 server
> -
>
> Key: HBASE-21652
> URL: https://issues.apache.org/jira/browse/HBASE-21652
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Allan Yang
>Assignee: Allan Yang
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: HBASE-21652.branch-2.patch, HBASE-21652.patch, 
> HBASE-21652.v2.patch, HBASE-21652.v3.patch, HBASE-21652.v4.patch, 
> HBASE-21652.v5.patch, HBASE-21652.v6.patch, HBASE-21652.v7.patch
>
>
> Except the different protocol, thrift2 Server should have no much difference 
> from thrift1 Server.  So refactoring the thrift server, making thrift2 server 
> inherit from thrift1 server. Getting rid of many duplicated code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-17356) Add replica get support

2019-01-02 Thread Duo Zhang (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-17356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732575#comment-16732575
 ] 

Duo Zhang commented on HBASE-17356:
---

Pushed to branch-2.1+ first. For branch-2.0, we need HBASE-18569 first...

> Add replica get support
> ---
>
> Key: HBASE-17356
> URL: https://issues.apache.org/jira/browse/HBASE-17356
> Project: HBase
>  Issue Type: Sub-task
>  Components: Client
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.1.3, 2.0.5
>
> Attachments: HBASE-17356-v1.patch, HBASE-17356-v2.patch, 
> HBASE-17356-v2.patch, HBASE-17356-v3.patch, HBASE-17356-v4.patch, 
> HBASE-17356-v5.patch, HBASE-17356-v5.patch, HBASE-17356.patch
>
>
> I think we can do better for scan at least as now we will pass the mvcc to 
> client. We can use the mvcc to determine if we can get a consistent view when 
> reading from replicas other than primary.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21599) Fix findbugs and javadoc warnings from HBASE-21246

2019-01-02 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732570#comment-16732570
 ] 

Hadoop QA commented on HBASE-21599:
---

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
12s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}  
0m  0s{color} | {color:orange} The patch doesn't appear to include any new or 
modified tests. Please justify why no new tests are needed for this patch. Also 
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} HBASE-20952 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
15s{color} | {color:green} HBASE-20952 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
46s{color} | {color:green} HBASE-20952 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
 3s{color} | {color:green} HBASE-20952 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  3m 
50s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  2m  
1s{color} | {color:blue} hbase-server in HBASE-20952 has 1 extant Findbugs 
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
29s{color} | {color:green} HBASE-20952 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
 1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
 4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  3m 
47s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}  
8m 26s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4 
or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
16s{color} | {color:green} hbase-server generated 0 new + 0 unchanged - 1 fixed 
= 0 total (was 1) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
30s{color} | {color:green} hbase-server generated 0 new + 0 unchanged - 2 fixed 
= 0 total (was 2) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}132m 
57s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
19s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}169m 17s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
| JIRA Issue | HBASE-21599 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12953539/HBASE-21599.HBASE-20952.002.patch
 |
| Optional Tests |  dupname  asflicense  javac  javadoc  unit  findbugs  
shadedjars  hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux b09662cfda7c 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | HBASE-20952 / c738e1575f |
| maven | version: Apache Maven 3.5.4 
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.0-RC3 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/15450/testReport/ |

[jira] [Commented] (HBASE-21652) Refactor ThriftServer making thrift2 server inherited from thrift1 server

2019-01-02 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732515#comment-16732515
 ] 

Hudson commented on HBASE-21652:


Results for branch branch-2
[build #1589 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1589/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1589//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1589//JDK8_Nightly_Build_Report_(Hadoop2)/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1589//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Refactor ThriftServer making thrift2 server inherited from thrift1 server
> -
>
> Key: HBASE-21652
> URL: https://issues.apache.org/jira/browse/HBASE-21652
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Allan Yang
>Assignee: Allan Yang
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: HBASE-21652.branch-2.patch, HBASE-21652.patch, 
> HBASE-21652.v2.patch, HBASE-21652.v3.patch, HBASE-21652.v4.patch, 
> HBASE-21652.v5.patch, HBASE-21652.v6.patch, HBASE-21652.v7.patch
>
>
> Except the different protocol, thrift2 Server should have no much difference 
> from thrift1 Server.  So refactoring the thrift server, making thrift2 server 
> inherit from thrift1 server. Getting rid of many duplicated code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21547) Precommit uses master flaky list for other branches

2019-01-02 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732514#comment-16732514
 ] 

Hudson commented on HBASE-21547:


Results for branch branch-2
[build #1589 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1589/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1589//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1589//JDK8_Nightly_Build_Report_(Hadoop2)/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1589//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Precommit uses master flaky list for other branches
> ---
>
> Key: HBASE-21547
> URL: https://issues.apache.org/jira/browse/HBASE-21547
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.2.0, 1.2.10, 1.4.10, 2.1.3, 2.0.5, 1.3.4
>
> Attachments: HBASE-21547.master.001.patch, 
> HBASE-21547.master.002.patch
>
>
> Precommit job downloads the flaky exclude list for master branch when the 
> uploaded patch file is made for different branches.
> As an example check 
> [https://builds.apache.org/job/PreCommit-HBASE-Build/15192] which was against 
> branch-1 but the unit test downloaded master's flaky list.
> {noformat}
> 15:26:05 [Tue Dec  4 14:26:04 UTC 2018 INFO]: Personality: patch unit
> 15:26:05 [Tue Dec  4 14:26:04 UTC 2018 INFO]: 
> EXCLUDE_TESTS_URL=https://builds.apache.org/job/HBase-Find-Flaky-Tests/job/master/lastSuccessfulBuild/artifact/excludes/
> 15:26:05 [Tue Dec  4 14:26:04 UTC 2018 INFO]: INCLUDE_TESTS_URL=
> 15:26:05 --2018-12-04 14:26:04--  
> https://builds.apache.org/job/HBase-Find-Flaky-Tests/job/master/lastSuccessfulBuild/artifact/excludes/
> 15:26:05 Resolving builds.apache.org (builds.apache.org)... 195.201.213.130, 
> 2a01:4f8:c0:2cc9::2
> 15:26:05 Connecting to builds.apache.org 
> (builds.apache.org)|195.201.213.130|:443... connected.
> 15:26:06 HTTP request sent, awaiting response... 200 
> 15:26:06 Length: 866 [application/octet-stream]
> 15:26:06 Saving to: 'excludes'
> 15:26:06 
> 15:26:06  0K   100% 
> 43.0M=0s
> 15:26:06 
> 15:26:06 2018-12-04 14:26:06 (43.0 MB/s) - 'excludes' saved [866/866]
> 15:26:06 
> 15:26:09 cd /testptch/hbase/hbase-thrift
> 15:26:09 mvn --batch-mode 
> -Dmaven.repo.local=/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/yetus-m2/hbase-branch-1-patch-1
>  -DHBasePatchProcess -Dhttps.protocols=TLSv1.2 -PrunAllTests 
> -Dtest.exclude.pattern=**/master.cleaner.TestSnapshotFromMaster.java,**/client.TestRestoreSnapshotFromClientAfterSplittingRegions.java,**/regionserver.TestRegionMergeTransactionOnCluster.java,**/client.TestCloneSnapshotFromClientAfterSplittingRegion.java,**/master.assignment.TestAssignmentManager.java,**/master.assignment.TestAMAssignWithRandExec.java,**/client.TestMobCloneSnapshotFromClientAfterSplittingRegion.java,**/regionserver.TestCompactingToCellFlatMapMemStore.java,**/replication.TestReplicationSmallTestsSync.java,**/TestMultiVersions.java,**/client.TestMobRestoreSnapshotFromClientAfterSplittingRegions.java,**/client.TestRestoreSnapshotFromClientWithRegionReplicas.java,**/regionserver.TestRegionServerAbortTimeout.java,**/replication.TestMasterReplication.java,**/backup.TestIncrementalBackupWithBulkLoad.java,**/master.replication.TestRegisterPeerWorkerWhenRestarting.java
>  clean test -fae > /testptch/patchprocess/patch-unit-hbase-thrift.txt 2>&1
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-19863) java.lang.IllegalStateException: isDelete failed when SingleColumnValueFilter is used

2019-01-02 Thread Josh Elser (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732500#comment-16732500
 ] 

Josh Elser commented on HBASE-19863:


{quote}
Looks back on this... Isn't it cheaper to just detect the fake key the same way 
that ScanQueryMatcher does it - by checking the timestamp for 
HConstants.OLDEST_TIMESTAMP, instead of doing the compare?

If the last K/V is fake we seek, no need to compare the bytes (which is 
expensive).
{quote}

Digging back into the archives, [~lhofhansl]. I'm inclined to agree with you at 
a glance, but I remember being a bit confused by this one the first time around.

Any chance I could convince you to throw up a patch in a new Jira issue and see 
how the test that Sergey added does with the change?

> java.lang.IllegalStateException: isDelete failed when SingleColumnValueFilter 
> is used
> -
>
> Key: HBASE-19863
> URL: https://issues.apache.org/jira/browse/HBASE-19863
> Project: HBase
>  Issue Type: Bug
>  Components: Filters
>Affects Versions: 1.4.1
>Reporter: Sergey Soldatov
>Assignee: Sergey Soldatov
>Priority: Major
> Fix For: 1.5.0, 2.0.0-beta-2, 1.4.3, 2.0.0
>
> Attachments: HBASE-19863-branch-2.patch, HBASE-19863-branch1.patch, 
> HBASE-19863-test.patch, HBASE-19863.v2-branch-2.patch, 
> HBASE-19863.v3-branch-2.patch, HBASE-19863.v4-branch-2.patch, 
> HBASE-19863.v4-master.patch, HBASE-19863.v5-branch-1.4.patch, 
> HBASE-19863.v5-branch-1.patch, HBASE-19863.v5-branch-2.patch
>
>
> Under some circumstances scan with SingleColumnValueFilter may fail with an 
> exception
> {noformat} 
> java.lang.IllegalStateException: isDelete failed: deleteBuffer=C3, 
> qualifier=C2, timestamp=1516433595543, comparison result: 1 
> at 
> org.apache.hadoop.hbase.regionserver.ScanDeleteTracker.isDeleted(ScanDeleteTracker.java:149)
>   at 
> org.apache.hadoop.hbase.regionserver.ScanQueryMatcher.match(ScanQueryMatcher.java:386)
>   at 
> org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:545)
>   at 
> org.apache.hadoop.hbase.regionserver.KeyValueHeap.next(KeyValueHeap.java:147)
>   at 
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.populateResult(HRegion.java:5876)
>   at 
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextInternal(HRegion.java:6027)
>   at 
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextRaw(HRegion.java:5814)
>   at 
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2552)
>   at 
> org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:32385)
>   at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2150)
>   at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:112)
>   at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:187)
>   at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:167)
> {noformat}
> Conditions:
> table T with a single column family 0 that uses ROWCOL bloom filter 
> (important)  and column qualifiers C1,C2,C3,C4,C5. 
> When we fill the table for every row we put deleted cell for C3.
> The table has a single region with two HStore:
> A: start row: 0, stop row: 99 
> B: start row: 10 stop row: 99
> B has newer versions of rows 10-99. Store files have several blocks each 
> (important). 
> Store A is the result of major compaction,  so it doesn't have any deleted 
> cells (important).
> So, we are running a scan like:
> {noformat}
> scan 'T', { COLUMNS => ['0:C3','0:C5'], FILTER => "SingleColumnValueFilter 
> ('0','C5',=,'binary:whatever')"}
> {noformat}  
> How the scan performs:
> First, we iterate A for rows 0 and 1 without any problems. 
> Next, we start to iterate A for row 10, so read the first cell and set hfs 
> scanner to A :
> 10:0/C1/0/Put/x but found that we have a newer version of the cell in B : 
> 10:0/C1/1/Put/x, 
> so we make B as our current store scanner. Since we are looking for 
> particular columns 
> C3 and C5, we perform the optimization StoreScanner.seekOrSkipToNextColumn 
> which 
> would run reseek for all store scanners.
> For store A the following magic would happen in requestSeek:
>   1. bloom filter check passesGeneralBloomFilter would set haveToSeek to 
> false because row 10 doesn't have C3 qualifier in store A.  
>   2. Since we don't have to seek we just create a fake row 
> 10:0/C3/OLDEST_TIMESTAMP/Maximum, an optimization that is quite important for 
> us and it commented with :
> {noformat}
>  // Multi-column Bloom filter optimization.
> // Create a fake key/value, so that this scanner only bubbles up to the 
> top
> // of the KeyValueHeap in 

[jira] [Commented] (HBASE-21600) Investigate non-null check on FSWALIdentity

2019-01-02 Thread Josh Elser (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732493#comment-16732493
 ] 

Josh Elser commented on HBASE-21600:


Great! Thanks for the offer, Reid!

> Investigate non-null check on FSWALIdentity
> ---
>
> Key: HBASE-21600
> URL: https://issues.apache.org/jira/browse/HBASE-21600
> Project: HBase
>  Issue Type: Task
>Reporter: Josh Elser
>Assignee: Reid Chan
>Priority: Trivial
> Fix For: HBASE-20952
>
>
> {code:java}
> public FSWALIdentity(Path path) 
> public FSWALIdentity(String name)
> {code}
> bq. Can we add a pre-null check or annotation NotNullable or javadoc to raise 
> attention of no-null? Passing a null object to WALIdentity makes no sense to 
> me.
> Reid had the above suggestion on HBASE-21246. Should make a check throughout 
> the code and make sure nothing else breaks if we start asserting that the 
> path/name is always non-null (I fear something might :P).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21547) Precommit uses master flaky list for other branches

2019-01-02 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732490#comment-16732490
 ] 

Hudson commented on HBASE-21547:


Results for branch branch-1.3
[build #595 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/595/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/595//General_Nightly_Build_Report/]


(/) {color:green}+1 jdk7 checks{color}
-- For more information [see jdk7 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/595//JDK7_Nightly_Build_Report/]


(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- Something went wrong running this stage, please [check relevant console 
output|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/595//console].




(x) {color:red}-1 source release artifact{color}
-- See build output for details.


> Precommit uses master flaky list for other branches
> ---
>
> Key: HBASE-21547
> URL: https://issues.apache.org/jira/browse/HBASE-21547
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.2.0, 1.2.10, 1.4.10, 2.1.3, 2.0.5, 1.3.4
>
> Attachments: HBASE-21547.master.001.patch, 
> HBASE-21547.master.002.patch
>
>
> Precommit job downloads the flaky exclude list for master branch when the 
> uploaded patch file is made for different branches.
> As an example check 
> [https://builds.apache.org/job/PreCommit-HBASE-Build/15192] which was against 
> branch-1 but the unit test downloaded master's flaky list.
> {noformat}
> 15:26:05 [Tue Dec  4 14:26:04 UTC 2018 INFO]: Personality: patch unit
> 15:26:05 [Tue Dec  4 14:26:04 UTC 2018 INFO]: 
> EXCLUDE_TESTS_URL=https://builds.apache.org/job/HBase-Find-Flaky-Tests/job/master/lastSuccessfulBuild/artifact/excludes/
> 15:26:05 [Tue Dec  4 14:26:04 UTC 2018 INFO]: INCLUDE_TESTS_URL=
> 15:26:05 --2018-12-04 14:26:04--  
> https://builds.apache.org/job/HBase-Find-Flaky-Tests/job/master/lastSuccessfulBuild/artifact/excludes/
> 15:26:05 Resolving builds.apache.org (builds.apache.org)... 195.201.213.130, 
> 2a01:4f8:c0:2cc9::2
> 15:26:05 Connecting to builds.apache.org 
> (builds.apache.org)|195.201.213.130|:443... connected.
> 15:26:06 HTTP request sent, awaiting response... 200 
> 15:26:06 Length: 866 [application/octet-stream]
> 15:26:06 Saving to: 'excludes'
> 15:26:06 
> 15:26:06  0K   100% 
> 43.0M=0s
> 15:26:06 
> 15:26:06 2018-12-04 14:26:06 (43.0 MB/s) - 'excludes' saved [866/866]
> 15:26:06 
> 15:26:09 cd /testptch/hbase/hbase-thrift
> 15:26:09 mvn --batch-mode 
> -Dmaven.repo.local=/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/yetus-m2/hbase-branch-1-patch-1
>  -DHBasePatchProcess -Dhttps.protocols=TLSv1.2 -PrunAllTests 
> -Dtest.exclude.pattern=**/master.cleaner.TestSnapshotFromMaster.java,**/client.TestRestoreSnapshotFromClientAfterSplittingRegions.java,**/regionserver.TestRegionMergeTransactionOnCluster.java,**/client.TestCloneSnapshotFromClientAfterSplittingRegion.java,**/master.assignment.TestAssignmentManager.java,**/master.assignment.TestAMAssignWithRandExec.java,**/client.TestMobCloneSnapshotFromClientAfterSplittingRegion.java,**/regionserver.TestCompactingToCellFlatMapMemStore.java,**/replication.TestReplicationSmallTestsSync.java,**/TestMultiVersions.java,**/client.TestMobRestoreSnapshotFromClientAfterSplittingRegions.java,**/client.TestRestoreSnapshotFromClientWithRegionReplicas.java,**/regionserver.TestRegionServerAbortTimeout.java,**/replication.TestMasterReplication.java,**/backup.TestIncrementalBackupWithBulkLoad.java,**/master.replication.TestRegisterPeerWorkerWhenRestarting.java
>  clean test -fae > /testptch/patchprocess/patch-unit-hbase-thrift.txt 2>&1
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-21599) Fix findbugs and javadoc warnings from HBASE-21246

2019-01-02 Thread Josh Elser (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-21599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Josh Elser updated HBASE-21599:
---
Attachment: HBASE-21599.HBASE-20952.002.patch

> Fix findbugs and javadoc warnings from HBASE-21246
> --
>
> Key: HBASE-21599
> URL: https://issues.apache.org/jira/browse/HBASE-21599
> Project: HBase
>  Issue Type: Bug
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Trivial
> Fix For: HBASE-20952
>
> Attachments: HBASE-21599.HBASE-20952.001.patch, 
> HBASE-21599.HBASE-20952.002.patch
>
>
> {noformat}
> [WARNING] 
> /testptch/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java:125:
>  warning - Tag @link: can't find preLogRoll(Path) in 
> org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceManager
> [WARNING] 
> /testptch/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java:125:
>  warning - Tag @link: can't find preLogRoll(Path) in 
> org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceManager
> {noformat}
> and
> {noformat}
> org.apache.hadoop.hbase.wal.DisabledWALProvider$1.equals(Object) always 
> returns true{noformat}
> Pretty trivial stuff to clean up now.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21599) Fix findbugs and javadoc warnings from HBASE-21246

2019-01-02 Thread Josh Elser (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732462#comment-16732462
 ] 

Josh Elser commented on HBASE-21599:


Thanks Ankit! Let me rebase and fix the checkstyle warnings.

> Fix findbugs and javadoc warnings from HBASE-21246
> --
>
> Key: HBASE-21599
> URL: https://issues.apache.org/jira/browse/HBASE-21599
> Project: HBase
>  Issue Type: Bug
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Trivial
> Fix For: HBASE-20952
>
> Attachments: HBASE-21599.HBASE-20952.001.patch
>
>
> {noformat}
> [WARNING] 
> /testptch/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java:125:
>  warning - Tag @link: can't find preLogRoll(Path) in 
> org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceManager
> [WARNING] 
> /testptch/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java:125:
>  warning - Tag @link: can't find preLogRoll(Path) in 
> org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceManager
> {noformat}
> and
> {noformat}
> org.apache.hadoop.hbase.wal.DisabledWALProvider$1.equals(Object) always 
> returns true{noformat}
> Pretty trivial stuff to clean up now.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21547) Precommit uses master flaky list for other branches

2019-01-02 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732446#comment-16732446
 ] 

Hudson commented on HBASE-21547:


Results for branch branch-1.2
[build #607 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.2/607/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.2/607//General_Nightly_Build_Report/]


(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.2/607//JDK7_Nightly_Build_Report/]


(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.2/607//JDK8_Nightly_Build_Report_(Hadoop2)/]




(x) {color:red}-1 source release artifact{color}
-- See build output for details.


> Precommit uses master flaky list for other branches
> ---
>
> Key: HBASE-21547
> URL: https://issues.apache.org/jira/browse/HBASE-21547
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.2.0, 1.2.10, 1.4.10, 2.1.3, 2.0.5, 1.3.4
>
> Attachments: HBASE-21547.master.001.patch, 
> HBASE-21547.master.002.patch
>
>
> Precommit job downloads the flaky exclude list for master branch when the 
> uploaded patch file is made for different branches.
> As an example check 
> [https://builds.apache.org/job/PreCommit-HBASE-Build/15192] which was against 
> branch-1 but the unit test downloaded master's flaky list.
> {noformat}
> 15:26:05 [Tue Dec  4 14:26:04 UTC 2018 INFO]: Personality: patch unit
> 15:26:05 [Tue Dec  4 14:26:04 UTC 2018 INFO]: 
> EXCLUDE_TESTS_URL=https://builds.apache.org/job/HBase-Find-Flaky-Tests/job/master/lastSuccessfulBuild/artifact/excludes/
> 15:26:05 [Tue Dec  4 14:26:04 UTC 2018 INFO]: INCLUDE_TESTS_URL=
> 15:26:05 --2018-12-04 14:26:04--  
> https://builds.apache.org/job/HBase-Find-Flaky-Tests/job/master/lastSuccessfulBuild/artifact/excludes/
> 15:26:05 Resolving builds.apache.org (builds.apache.org)... 195.201.213.130, 
> 2a01:4f8:c0:2cc9::2
> 15:26:05 Connecting to builds.apache.org 
> (builds.apache.org)|195.201.213.130|:443... connected.
> 15:26:06 HTTP request sent, awaiting response... 200 
> 15:26:06 Length: 866 [application/octet-stream]
> 15:26:06 Saving to: 'excludes'
> 15:26:06 
> 15:26:06  0K   100% 
> 43.0M=0s
> 15:26:06 
> 15:26:06 2018-12-04 14:26:06 (43.0 MB/s) - 'excludes' saved [866/866]
> 15:26:06 
> 15:26:09 cd /testptch/hbase/hbase-thrift
> 15:26:09 mvn --batch-mode 
> -Dmaven.repo.local=/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/yetus-m2/hbase-branch-1-patch-1
>  -DHBasePatchProcess -Dhttps.protocols=TLSv1.2 -PrunAllTests 
> -Dtest.exclude.pattern=**/master.cleaner.TestSnapshotFromMaster.java,**/client.TestRestoreSnapshotFromClientAfterSplittingRegions.java,**/regionserver.TestRegionMergeTransactionOnCluster.java,**/client.TestCloneSnapshotFromClientAfterSplittingRegion.java,**/master.assignment.TestAssignmentManager.java,**/master.assignment.TestAMAssignWithRandExec.java,**/client.TestMobCloneSnapshotFromClientAfterSplittingRegion.java,**/regionserver.TestCompactingToCellFlatMapMemStore.java,**/replication.TestReplicationSmallTestsSync.java,**/TestMultiVersions.java,**/client.TestMobRestoreSnapshotFromClientAfterSplittingRegions.java,**/client.TestRestoreSnapshotFromClientWithRegionReplicas.java,**/regionserver.TestRegionServerAbortTimeout.java,**/replication.TestMasterReplication.java,**/backup.TestIncrementalBackupWithBulkLoad.java,**/master.replication.TestRegisterPeerWorkerWhenRestarting.java
>  clean test -fae > /testptch/patchprocess/patch-unit-hbase-thrift.txt 2>&1
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21547) Precommit uses master flaky list for other branches

2019-01-02 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732371#comment-16732371
 ] 

Hudson commented on HBASE-21547:


Results for branch branch-1.4
[build #612 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/612/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(x) {color:red}-1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/612//General_Nightly_Build_Report/]


(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/612//JDK7_Nightly_Build_Report/]


(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/612//JDK8_Nightly_Build_Report_(Hadoop2)/]




(x) {color:red}-1 source release artifact{color}
-- See build output for details.


> Precommit uses master flaky list for other branches
> ---
>
> Key: HBASE-21547
> URL: https://issues.apache.org/jira/browse/HBASE-21547
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.2.0, 1.2.10, 1.4.10, 2.1.3, 2.0.5, 1.3.4
>
> Attachments: HBASE-21547.master.001.patch, 
> HBASE-21547.master.002.patch
>
>
> Precommit job downloads the flaky exclude list for master branch when the 
> uploaded patch file is made for different branches.
> As an example check 
> [https://builds.apache.org/job/PreCommit-HBASE-Build/15192] which was against 
> branch-1 but the unit test downloaded master's flaky list.
> {noformat}
> 15:26:05 [Tue Dec  4 14:26:04 UTC 2018 INFO]: Personality: patch unit
> 15:26:05 [Tue Dec  4 14:26:04 UTC 2018 INFO]: 
> EXCLUDE_TESTS_URL=https://builds.apache.org/job/HBase-Find-Flaky-Tests/job/master/lastSuccessfulBuild/artifact/excludes/
> 15:26:05 [Tue Dec  4 14:26:04 UTC 2018 INFO]: INCLUDE_TESTS_URL=
> 15:26:05 --2018-12-04 14:26:04--  
> https://builds.apache.org/job/HBase-Find-Flaky-Tests/job/master/lastSuccessfulBuild/artifact/excludes/
> 15:26:05 Resolving builds.apache.org (builds.apache.org)... 195.201.213.130, 
> 2a01:4f8:c0:2cc9::2
> 15:26:05 Connecting to builds.apache.org 
> (builds.apache.org)|195.201.213.130|:443... connected.
> 15:26:06 HTTP request sent, awaiting response... 200 
> 15:26:06 Length: 866 [application/octet-stream]
> 15:26:06 Saving to: 'excludes'
> 15:26:06 
> 15:26:06  0K   100% 
> 43.0M=0s
> 15:26:06 
> 15:26:06 2018-12-04 14:26:06 (43.0 MB/s) - 'excludes' saved [866/866]
> 15:26:06 
> 15:26:09 cd /testptch/hbase/hbase-thrift
> 15:26:09 mvn --batch-mode 
> -Dmaven.repo.local=/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/yetus-m2/hbase-branch-1-patch-1
>  -DHBasePatchProcess -Dhttps.protocols=TLSv1.2 -PrunAllTests 
> -Dtest.exclude.pattern=**/master.cleaner.TestSnapshotFromMaster.java,**/client.TestRestoreSnapshotFromClientAfterSplittingRegions.java,**/regionserver.TestRegionMergeTransactionOnCluster.java,**/client.TestCloneSnapshotFromClientAfterSplittingRegion.java,**/master.assignment.TestAssignmentManager.java,**/master.assignment.TestAMAssignWithRandExec.java,**/client.TestMobCloneSnapshotFromClientAfterSplittingRegion.java,**/regionserver.TestCompactingToCellFlatMapMemStore.java,**/replication.TestReplicationSmallTestsSync.java,**/TestMultiVersions.java,**/client.TestMobRestoreSnapshotFromClientAfterSplittingRegions.java,**/client.TestRestoreSnapshotFromClientWithRegionReplicas.java,**/regionserver.TestRegionServerAbortTimeout.java,**/replication.TestMasterReplication.java,**/backup.TestIncrementalBackupWithBulkLoad.java,**/master.replication.TestRegisterPeerWorkerWhenRestarting.java
>  clean test -fae > /testptch/patchprocess/patch-unit-hbase-thrift.txt 2>&1
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21652) Refactor ThriftServer making thrift2 server inherited from thrift1 server

2019-01-02 Thread stack (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732356#comment-16732356
 ] 

stack commented on HBASE-21652:
---

Does how you invoke thrift1 or thrift2 change [~allan163] ? If not, say so in 
RN? If it does, say so in RN (smile). Thanks. This is nice work.

> Refactor ThriftServer making thrift2 server inherited from thrift1 server
> -
>
> Key: HBASE-21652
> URL: https://issues.apache.org/jira/browse/HBASE-21652
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Allan Yang
>Assignee: Allan Yang
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: HBASE-21652.branch-2.patch, HBASE-21652.patch, 
> HBASE-21652.v2.patch, HBASE-21652.v3.patch, HBASE-21652.v4.patch, 
> HBASE-21652.v5.patch, HBASE-21652.v6.patch, HBASE-21652.v7.patch
>
>
> Except the different protocol, thrift2 Server should have no much difference 
> from thrift1 Server.  So refactoring the thrift server, making thrift2 server 
> inherit from thrift1 server. Getting rid of many duplicated code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21665) OfflineMetaRepair tool fails with NPE

2019-01-02 Thread Pankaj Kumar (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732313#comment-16732313
 ] 

Pankaj Kumar commented on HBASE-21665:
--

branch-2, I tried in 2.1.1 & 2.2.0.

> OfflineMetaRepair tool fails with NPE
> -
>
> Key: HBASE-21665
> URL: https://issues.apache.org/jira/browse/HBASE-21665
> Project: HBase
>  Issue Type: Bug
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Major
>
> OfflineMetaRepair fails with NPE, execute below command
> hbase org.apache.hadoop.hbase.util.hbck.OfflineMetaRepair -fix
>  
> {noformat}
> 2019-01-02 16:22:56,387 INFO [main] regionserver.HRegion: Opened 1588230740; 
> next sequenceid=28
> 2019-01-02 16:22:56,459 ERROR [main] hbck.OfflineMetaRepair: Bailed out due 
> to: 
> java.lang.NullPointerException
>  at 
> org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.getOrMakeChunk(MemStoreLABImpl.java:335)
>  at 
> org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.copyCellInto(MemStoreLABImpl.java:193)
>  at 
> org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.copyCellInto(MemStoreLABImpl.java:115)
>  at 
> org.apache.hadoop.hbase.regionserver.Segment.maybeCloneWithAllocator(Segment.java:183)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.maybeCloneWithAllocator(AbstractMemStore.java:334)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.doAdd(AbstractMemStore.java:157)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.doAddOrUpsert(AbstractMemStore.java:147)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.add(AbstractMemStore.java:117)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.add(AbstractMemStore.java:111)
>  at org.apache.hadoop.hbase.regionserver.HStore.add(HStore.java:750)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.applyToMemStore(HRegion.java:4435)
>  at org.apache.hadoop.hbase.regionserver.HRegion.access$500(HRegion.java:228)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.applyFamilyMapToMemStore(HRegion.java:3495)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.lambda$writeMiniBatchOperationsToMemStore$0(HRegion.java:3186)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.visitBatchOperations(HRegion.java:3119)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.writeMiniBatchOperationsToMemStore(HRegion.java:3178)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$MutationBatchOperation.writeMiniBatchOperationsToMemStore(HRegion.java:3660)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.doMiniBatchMutate(HRegion.java:4073)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:4006)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:3937)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:3928)
>  at org.apache.hadoop.hbase.util.HBaseFsck.rebuildMeta(HBaseFsck.java:1665)
>  at 
> org.apache.hadoop.hbase.util.hbck.OfflineMetaRepair.main(OfflineMetaRepair.java:121)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (HBASE-21666) Break up the TestExportSnapshot UTs; they can timeout

2019-01-02 Thread stack (JIRA)
stack created HBASE-21666:
-

 Summary: Break up the TestExportSnapshot UTs; they can timeout
 Key: HBASE-21666
 URL: https://issues.apache.org/jira/browse/HBASE-21666
 Project: HBase
  Issue Type: Bug
  Components: test
Reporter: stack


These timed out for [~Apache9] when he ran with the -PrunAllTests. Suggests 
breaking them up into smaller tests so less likely they'll timeout.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21547) Precommit uses master flaky list for other branches

2019-01-02 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732204#comment-16732204
 ] 

Hudson commented on HBASE-21547:


Results for branch branch-2.1
[build #736 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/736/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/736//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- Something went wrong running this stage, please [check relevant console 
output|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/736//console].


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/736//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Precommit uses master flaky list for other branches
> ---
>
> Key: HBASE-21547
> URL: https://issues.apache.org/jira/browse/HBASE-21547
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.2.0, 1.2.10, 1.4.10, 2.1.3, 2.0.5, 1.3.4
>
> Attachments: HBASE-21547.master.001.patch, 
> HBASE-21547.master.002.patch
>
>
> Precommit job downloads the flaky exclude list for master branch when the 
> uploaded patch file is made for different branches.
> As an example check 
> [https://builds.apache.org/job/PreCommit-HBASE-Build/15192] which was against 
> branch-1 but the unit test downloaded master's flaky list.
> {noformat}
> 15:26:05 [Tue Dec  4 14:26:04 UTC 2018 INFO]: Personality: patch unit
> 15:26:05 [Tue Dec  4 14:26:04 UTC 2018 INFO]: 
> EXCLUDE_TESTS_URL=https://builds.apache.org/job/HBase-Find-Flaky-Tests/job/master/lastSuccessfulBuild/artifact/excludes/
> 15:26:05 [Tue Dec  4 14:26:04 UTC 2018 INFO]: INCLUDE_TESTS_URL=
> 15:26:05 --2018-12-04 14:26:04--  
> https://builds.apache.org/job/HBase-Find-Flaky-Tests/job/master/lastSuccessfulBuild/artifact/excludes/
> 15:26:05 Resolving builds.apache.org (builds.apache.org)... 195.201.213.130, 
> 2a01:4f8:c0:2cc9::2
> 15:26:05 Connecting to builds.apache.org 
> (builds.apache.org)|195.201.213.130|:443... connected.
> 15:26:06 HTTP request sent, awaiting response... 200 
> 15:26:06 Length: 866 [application/octet-stream]
> 15:26:06 Saving to: 'excludes'
> 15:26:06 
> 15:26:06  0K   100% 
> 43.0M=0s
> 15:26:06 
> 15:26:06 2018-12-04 14:26:06 (43.0 MB/s) - 'excludes' saved [866/866]
> 15:26:06 
> 15:26:09 cd /testptch/hbase/hbase-thrift
> 15:26:09 mvn --batch-mode 
> -Dmaven.repo.local=/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/yetus-m2/hbase-branch-1-patch-1
>  -DHBasePatchProcess -Dhttps.protocols=TLSv1.2 -PrunAllTests 
> -Dtest.exclude.pattern=**/master.cleaner.TestSnapshotFromMaster.java,**/client.TestRestoreSnapshotFromClientAfterSplittingRegions.java,**/regionserver.TestRegionMergeTransactionOnCluster.java,**/client.TestCloneSnapshotFromClientAfterSplittingRegion.java,**/master.assignment.TestAssignmentManager.java,**/master.assignment.TestAMAssignWithRandExec.java,**/client.TestMobCloneSnapshotFromClientAfterSplittingRegion.java,**/regionserver.TestCompactingToCellFlatMapMemStore.java,**/replication.TestReplicationSmallTestsSync.java,**/TestMultiVersions.java,**/client.TestMobRestoreSnapshotFromClientAfterSplittingRegions.java,**/client.TestRestoreSnapshotFromClientWithRegionReplicas.java,**/regionserver.TestRegionServerAbortTimeout.java,**/replication.TestMasterReplication.java,**/backup.TestIncrementalBackupWithBulkLoad.java,**/master.replication.TestRegisterPeerWorkerWhenRestarting.java
>  clean test -fae > /testptch/patchprocess/patch-unit-hbase-thrift.txt 2>&1
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21547) Precommit uses master flaky list for other branches

2019-01-02 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732194#comment-16732194
 ] 

Hudson commented on HBASE-21547:


Results for branch branch-2.0
[build #1220 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1220/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1220//General_Nightly_Build_Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1220//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- Something went wrong running this stage, please [check relevant console 
output|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1220//console].


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


> Precommit uses master flaky list for other branches
> ---
>
> Key: HBASE-21547
> URL: https://issues.apache.org/jira/browse/HBASE-21547
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.2.0, 1.2.10, 1.4.10, 2.1.3, 2.0.5, 1.3.4
>
> Attachments: HBASE-21547.master.001.patch, 
> HBASE-21547.master.002.patch
>
>
> Precommit job downloads the flaky exclude list for master branch when the 
> uploaded patch file is made for different branches.
> As an example check 
> [https://builds.apache.org/job/PreCommit-HBASE-Build/15192] which was against 
> branch-1 but the unit test downloaded master's flaky list.
> {noformat}
> 15:26:05 [Tue Dec  4 14:26:04 UTC 2018 INFO]: Personality: patch unit
> 15:26:05 [Tue Dec  4 14:26:04 UTC 2018 INFO]: 
> EXCLUDE_TESTS_URL=https://builds.apache.org/job/HBase-Find-Flaky-Tests/job/master/lastSuccessfulBuild/artifact/excludes/
> 15:26:05 [Tue Dec  4 14:26:04 UTC 2018 INFO]: INCLUDE_TESTS_URL=
> 15:26:05 --2018-12-04 14:26:04--  
> https://builds.apache.org/job/HBase-Find-Flaky-Tests/job/master/lastSuccessfulBuild/artifact/excludes/
> 15:26:05 Resolving builds.apache.org (builds.apache.org)... 195.201.213.130, 
> 2a01:4f8:c0:2cc9::2
> 15:26:05 Connecting to builds.apache.org 
> (builds.apache.org)|195.201.213.130|:443... connected.
> 15:26:06 HTTP request sent, awaiting response... 200 
> 15:26:06 Length: 866 [application/octet-stream]
> 15:26:06 Saving to: 'excludes'
> 15:26:06 
> 15:26:06  0K   100% 
> 43.0M=0s
> 15:26:06 
> 15:26:06 2018-12-04 14:26:06 (43.0 MB/s) - 'excludes' saved [866/866]
> 15:26:06 
> 15:26:09 cd /testptch/hbase/hbase-thrift
> 15:26:09 mvn --batch-mode 
> -Dmaven.repo.local=/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/yetus-m2/hbase-branch-1-patch-1
>  -DHBasePatchProcess -Dhttps.protocols=TLSv1.2 -PrunAllTests 
> -Dtest.exclude.pattern=**/master.cleaner.TestSnapshotFromMaster.java,**/client.TestRestoreSnapshotFromClientAfterSplittingRegions.java,**/regionserver.TestRegionMergeTransactionOnCluster.java,**/client.TestCloneSnapshotFromClientAfterSplittingRegion.java,**/master.assignment.TestAssignmentManager.java,**/master.assignment.TestAMAssignWithRandExec.java,**/client.TestMobCloneSnapshotFromClientAfterSplittingRegion.java,**/regionserver.TestCompactingToCellFlatMapMemStore.java,**/replication.TestReplicationSmallTestsSync.java,**/TestMultiVersions.java,**/client.TestMobRestoreSnapshotFromClientAfterSplittingRegions.java,**/client.TestRestoreSnapshotFromClientWithRegionReplicas.java,**/regionserver.TestRegionServerAbortTimeout.java,**/replication.TestMasterReplication.java,**/backup.TestIncrementalBackupWithBulkLoad.java,**/master.replication.TestRegisterPeerWorkerWhenRestarting.java
>  clean test -fae > /testptch/patchprocess/patch-unit-hbase-thrift.txt 2>&1
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21665) OfflineMetaRepair tool fails with NPE

2019-01-02 Thread Sean Busbey (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732159#comment-16732159
 ] 

Sean Busbey commented on HBASE-21665:
-

What version?

> OfflineMetaRepair tool fails with NPE
> -
>
> Key: HBASE-21665
> URL: https://issues.apache.org/jira/browse/HBASE-21665
> Project: HBase
>  Issue Type: Bug
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Major
>
> OfflineMetaRepair fails with NPE, execute below command
> hbase org.apache.hadoop.hbase.util.hbck.OfflineMetaRepair -fix
>  
> {noformat}
> 2019-01-02 16:22:56,387 INFO [main] regionserver.HRegion: Opened 1588230740; 
> next sequenceid=28
> 2019-01-02 16:22:56,459 ERROR [main] hbck.OfflineMetaRepair: Bailed out due 
> to: 
> java.lang.NullPointerException
>  at 
> org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.getOrMakeChunk(MemStoreLABImpl.java:335)
>  at 
> org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.copyCellInto(MemStoreLABImpl.java:193)
>  at 
> org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.copyCellInto(MemStoreLABImpl.java:115)
>  at 
> org.apache.hadoop.hbase.regionserver.Segment.maybeCloneWithAllocator(Segment.java:183)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.maybeCloneWithAllocator(AbstractMemStore.java:334)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.doAdd(AbstractMemStore.java:157)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.doAddOrUpsert(AbstractMemStore.java:147)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.add(AbstractMemStore.java:117)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.add(AbstractMemStore.java:111)
>  at org.apache.hadoop.hbase.regionserver.HStore.add(HStore.java:750)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.applyToMemStore(HRegion.java:4435)
>  at org.apache.hadoop.hbase.regionserver.HRegion.access$500(HRegion.java:228)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.applyFamilyMapToMemStore(HRegion.java:3495)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.lambda$writeMiniBatchOperationsToMemStore$0(HRegion.java:3186)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.visitBatchOperations(HRegion.java:3119)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.writeMiniBatchOperationsToMemStore(HRegion.java:3178)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$MutationBatchOperation.writeMiniBatchOperationsToMemStore(HRegion.java:3660)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.doMiniBatchMutate(HRegion.java:4073)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:4006)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:3937)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:3928)
>  at org.apache.hadoop.hbase.util.HBaseFsck.rebuildMeta(HBaseFsck.java:1665)
>  at 
> org.apache.hadoop.hbase.util.hbck.OfflineMetaRepair.main(OfflineMetaRepair.java:121)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21512) Introduce an AsyncClusterConnection and replace the usage of ClusterConnection

2019-01-02 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732114#comment-16732114
 ] 

Hudson commented on HBASE-21512:


Results for branch HBASE-21512
[build #37 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21512/37/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(x) {color:red}-1 general checks{color}
-- Something went wrong running this stage, please [check relevant console 
output|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21512/37//console].




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21512/37//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21512/37//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Introduce an AsyncClusterConnection and replace the usage of ClusterConnection
> --
>
> Key: HBASE-21512
> URL: https://issues.apache.org/jira/browse/HBASE-21512
> Project: HBase
>  Issue Type: Umbrella
>Reporter: Duo Zhang
>Priority: Major
> Fix For: 3.0.0
>
>
> At least for the RSProcedureDispatcher, with CompletableFuture we do not need 
> to set a delay and use a thread pool any more, which could reduce the 
> resource usage and also the latency.
> Once this is done, I think we can remove the ClusterConnection completely, 
> and start to rewrite the old sync client based on the async client, which 
> could reduce the code base a lot for our client.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21573) More sensible client default timeout values

2019-01-02 Thread Peter Somogyi (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732061#comment-16732061
 ] 

Peter Somogyi commented on HBASE-21573:
---

Additionally to the ones that [~lhofhansl] mentioned earlier I also found 
hbase.rpc.shortoperation.timeout.

>From all of these properties users should mainly focus on hbase.rpc.timeout, 
>hbase.client.operation.timeout and hbase.client.scanner.timeout.period (for 
>scan operations). Only users who want to fine tune read or write rpc timeout 
>should set hbase.rpc.read.timeout and hbase.rpc.write.timeout values, when 
>these properties are not set these will fall back to hbase.rpc.timeout. This 
>is similar to hbase.client.operation.timeout and 
>hbase.client.meta.operation.timeout values. So 
>hbase.client.meta.operation.timeout will fall back to 
>hbase.client.operation.timeout.

For quick RPC operations within cluster HBase relies on 
hbase.rpc.shortoperation.timeout property but this does not have client related 
effect.

There is a deprecated hbase.regionserver.lease.period config which is marked as 
being removed after 0.96 release. I'll remove this property and also pointers 
in the reference guide.

I'm not against the fail fast approach but I don't know what values are still 
reasonable as a default configuration.

> More sensible client default timeout values
> ---
>
> Key: HBASE-21573
> URL: https://issues.apache.org/jira/browse/HBASE-21573
> Project: HBase
>  Issue Type: Wish
>  Components: Client
>Affects Versions: 2.1.1
>Reporter: Cosmin Lehene
>Priority: Critical
> Fix For: 2.1.3
>
>
> I guess the goal is to have operations allow enough time to recover from 
> major failures.
> While this may make sense for large jobs, it's a PITA for OLTP scenarios and 
> could probably benefit from a faster failure mode in default
>  
> hbase.rpc.timeout = 6
> hbase.client.operation.timeout = 120
> hbase.client.meta.operation.timeout = 120
> The client meta ops timeout is not in defaults-xml and not documented in the 
> book either.
> [https://hbase.apache.org/book.html#config_timeouts]
>  
> Would it make sense to have aggressive defaults instead?
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21588) Procedure v2 wal splitting implementation

2019-01-02 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732059#comment-16732059
 ] 

Hadoop QA commented on HBASE-21588:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
12s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 7 new or modified test 
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
13s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
 5s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  3m 
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
42s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
 8s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m 
58s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
58s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
16s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
 6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  3m 
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green}  3m 
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  3m 
18s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  1m 
10s{color} | {color:red} hbase-server: The patch generated 1 new + 271 
unchanged - 1 fixed = 272 total (was 272) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
 9s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}  
8m 33s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4 
or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green}  
1m 30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  5m 
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
59s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
33s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m 
44s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}141m 22s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  1m 
20s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}196m 43s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.master.locking.TestLockManager |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
| JIRA Issue | HBASE-21588 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12953494/HBASE-21588.master.017.patch
 |
| 

[jira] [Commented] (HBASE-21659) Avoid to load duplicate coprocessors in system config and table descriptor

2019-01-02 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16731991#comment-16731991
 ] 

Hudson commented on HBASE-21659:


Results for branch master
[build #692 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/692/]: (x) 
*{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/692//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- Something went wrong running this stage, please [check relevant console 
output|https://builds.apache.org/job/HBase%20Nightly/job/master/692//console].


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/692//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Avoid to load duplicate coprocessors in system config and table descriptor
> --
>
> Key: HBASE-21659
> URL: https://issues.apache.org/jira/browse/HBASE-21659
> Project: HBase
>  Issue Type: Improvement
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Minor
> Fix For: 3.0.0, 2.2.0
>
> Attachments: HBASE-21659.master.001.patch, 
> HBASE-21659.master.002.patch, HBASE-21659.master.003.patch, 
> HBASE-21659.master.004.patch
>
>
> When there are same coprocessor in system coprocessor config and table 
> descriptor. It will load the coprocessor twice and the coprocessor method may 
> run twice, too. It should avoid to load duplicate coprocessors.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21660) Apply the cell to right memstore for increment/append operation

2019-01-02 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16731990#comment-16731990
 ] 

Hudson commented on HBASE-21660:


Results for branch master
[build #692 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/692/]: (x) 
*{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/692//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- Something went wrong running this stage, please [check relevant console 
output|https://builds.apache.org/job/HBase%20Nightly/job/master/692//console].


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/692//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Apply the cell to right memstore for increment/append operation
> ---
>
> Key: HBASE-21660
> URL: https://issues.apache.org/jira/browse/HBASE-21660
> Project: HBase
>  Issue Type: Bug
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: HBASE-21660.master.001.patch, 
> HBASE-21660.master.002.patch, HBASE-21660.master.003.patch
>
>
> HBASE-21643 introduced two new coprocessor methods postIncrementBeforeWAL and 
> postAppendBeforeWAL instead of the old coprocessor postMutationsBeforeWAL. 
> These coprocessor methods give coprocessors to update the new cells before 
> apply to WAL or memstore. But the cell's column family may be changed, too. 
> So it should apply the new cell to memstore depend on the cell's column 
> family.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-21665) OfflineMetaRepair tool fails with NPE

2019-01-02 Thread Pankaj Kumar (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-21665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pankaj Kumar updated HBASE-21665:
-
Summary: OfflineMetaRepair tool fails with NPE  (was: OfflineMetaRepair 
fails with NPE)

> OfflineMetaRepair tool fails with NPE
> -
>
> Key: HBASE-21665
> URL: https://issues.apache.org/jira/browse/HBASE-21665
> Project: HBase
>  Issue Type: Bug
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Major
>
> OfflineMetaRepair fails with NPE, execute below command
> hbase org.apache.hadoop.hbase.util.hbck.OfflineMetaRepair -fix
>  
> {noformat}
> 2019-01-02 16:22:56,387 INFO [main] regionserver.HRegion: Opened 1588230740; 
> next sequenceid=28
> 2019-01-02 16:22:56,459 ERROR [main] hbck.OfflineMetaRepair: Bailed out due 
> to: 
> java.lang.NullPointerException
>  at 
> org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.getOrMakeChunk(MemStoreLABImpl.java:335)
>  at 
> org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.copyCellInto(MemStoreLABImpl.java:193)
>  at 
> org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.copyCellInto(MemStoreLABImpl.java:115)
>  at 
> org.apache.hadoop.hbase.regionserver.Segment.maybeCloneWithAllocator(Segment.java:183)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.maybeCloneWithAllocator(AbstractMemStore.java:334)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.doAdd(AbstractMemStore.java:157)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.doAddOrUpsert(AbstractMemStore.java:147)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.add(AbstractMemStore.java:117)
>  at 
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.add(AbstractMemStore.java:111)
>  at org.apache.hadoop.hbase.regionserver.HStore.add(HStore.java:750)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.applyToMemStore(HRegion.java:4435)
>  at org.apache.hadoop.hbase.regionserver.HRegion.access$500(HRegion.java:228)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.applyFamilyMapToMemStore(HRegion.java:3495)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.lambda$writeMiniBatchOperationsToMemStore$0(HRegion.java:3186)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.visitBatchOperations(HRegion.java:3119)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.writeMiniBatchOperationsToMemStore(HRegion.java:3178)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$MutationBatchOperation.writeMiniBatchOperationsToMemStore(HRegion.java:3660)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.doMiniBatchMutate(HRegion.java:4073)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:4006)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:3937)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:3928)
>  at org.apache.hadoop.hbase.util.HBaseFsck.rebuildMeta(HBaseFsck.java:1665)
>  at 
> org.apache.hadoop.hbase.util.hbck.OfflineMetaRepair.main(OfflineMetaRepair.java:121)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (HBASE-21665) OfflineMetaRepair fails with NPE

2019-01-02 Thread Pankaj Kumar (JIRA)
Pankaj Kumar created HBASE-21665:


 Summary: OfflineMetaRepair fails with NPE
 Key: HBASE-21665
 URL: https://issues.apache.org/jira/browse/HBASE-21665
 Project: HBase
  Issue Type: Bug
Reporter: Pankaj Kumar
Assignee: Pankaj Kumar


OfflineMetaRepair fails with NPE, execute below command

hbase org.apache.hadoop.hbase.util.hbck.OfflineMetaRepair -fix

 

{noformat}

2019-01-02 16:22:56,387 INFO [main] regionserver.HRegion: Opened 1588230740; 
next sequenceid=28
2019-01-02 16:22:56,459 ERROR [main] hbck.OfflineMetaRepair: Bailed out due to: 
java.lang.NullPointerException
 at 
org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.getOrMakeChunk(MemStoreLABImpl.java:335)
 at 
org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.copyCellInto(MemStoreLABImpl.java:193)
 at 
org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.copyCellInto(MemStoreLABImpl.java:115)
 at 
org.apache.hadoop.hbase.regionserver.Segment.maybeCloneWithAllocator(Segment.java:183)
 at 
org.apache.hadoop.hbase.regionserver.AbstractMemStore.maybeCloneWithAllocator(AbstractMemStore.java:334)
 at 
org.apache.hadoop.hbase.regionserver.AbstractMemStore.doAdd(AbstractMemStore.java:157)
 at 
org.apache.hadoop.hbase.regionserver.AbstractMemStore.doAddOrUpsert(AbstractMemStore.java:147)
 at 
org.apache.hadoop.hbase.regionserver.AbstractMemStore.add(AbstractMemStore.java:117)
 at 
org.apache.hadoop.hbase.regionserver.AbstractMemStore.add(AbstractMemStore.java:111)
 at org.apache.hadoop.hbase.regionserver.HStore.add(HStore.java:750)
 at 
org.apache.hadoop.hbase.regionserver.HRegion.applyToMemStore(HRegion.java:4435)
 at org.apache.hadoop.hbase.regionserver.HRegion.access$500(HRegion.java:228)
 at 
org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.applyFamilyMapToMemStore(HRegion.java:3495)
 at 
org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.lambda$writeMiniBatchOperationsToMemStore$0(HRegion.java:3186)
 at 
org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.visitBatchOperations(HRegion.java:3119)
 at 
org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.writeMiniBatchOperationsToMemStore(HRegion.java:3178)
 at 
org.apache.hadoop.hbase.regionserver.HRegion$MutationBatchOperation.writeMiniBatchOperationsToMemStore(HRegion.java:3660)
 at 
org.apache.hadoop.hbase.regionserver.HRegion.doMiniBatchMutate(HRegion.java:4073)
 at org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:4006)
 at org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:3937)
 at org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:3928)
 at org.apache.hadoop.hbase.util.HBaseFsck.rebuildMeta(HBaseFsck.java:1665)
 at 
org.apache.hadoop.hbase.util.hbck.OfflineMetaRepair.main(OfflineMetaRepair.java:121)

{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-21652) Refactor ThriftServer making thrift2 server inherited from thrift1 server

2019-01-02 Thread Allan Yang (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-21652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Allan Yang updated HBASE-21652:
---
Resolution: Fixed
Status: Resolved  (was: Patch Available)

> Refactor ThriftServer making thrift2 server inherited from thrift1 server
> -
>
> Key: HBASE-21652
> URL: https://issues.apache.org/jira/browse/HBASE-21652
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Allan Yang
>Assignee: Allan Yang
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: HBASE-21652.branch-2.patch, HBASE-21652.patch, 
> HBASE-21652.v2.patch, HBASE-21652.v3.patch, HBASE-21652.v4.patch, 
> HBASE-21652.v5.patch, HBASE-21652.v6.patch, HBASE-21652.v7.patch
>
>
> Except the different protocol, thrift2 Server should have no much difference 
> from thrift1 Server.  So refactoring the thrift server, making thrift2 server 
> inherit from thrift1 server. Getting rid of many duplicated code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21512) Introduce an AsyncClusterConnection and replace the usage of ClusterConnection

2019-01-02 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16731942#comment-16731942
 ] 

Hudson commented on HBASE-21512:


Results for branch HBASE-21512
[build #36 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21512/36/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21512/36//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21512/36//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21512/36//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Introduce an AsyncClusterConnection and replace the usage of ClusterConnection
> --
>
> Key: HBASE-21512
> URL: https://issues.apache.org/jira/browse/HBASE-21512
> Project: HBase
>  Issue Type: Umbrella
>Reporter: Duo Zhang
>Priority: Major
> Fix For: 3.0.0
>
>
> At least for the RSProcedureDispatcher, with CompletableFuture we do not need 
> to set a delay and use a thread pool any more, which could reduce the 
> resource usage and also the latency.
> Once this is done, I think we can remove the ClusterConnection completely, 
> and start to rewrite the old sync client based on the async client, which 
> could reduce the code base a lot for our client.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-21588) Procedure v2 wal splitting implementation

2019-01-02 Thread Jingyun Tian (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-21588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jingyun Tian updated HBASE-21588:
-
Attachment: HBASE-21588.master.017.patch

> Procedure v2 wal splitting implementation
> -
>
> Key: HBASE-21588
> URL: https://issues.apache.org/jira/browse/HBASE-21588
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Jingyun Tian
>Assignee: Jingyun Tian
>Priority: Major
> Attachments: HBASE-21588.master.003.patch, 
> HBASE-21588.master.004.patch, HBASE-21588.master.005.patch, 
> HBASE-21588.master.006.patch, HBASE-21588.master.007.patch, 
> HBASE-21588.master.008.patch, HBASE-21588.master.009.patch, 
> HBASE-21588.master.010.patch, HBASE-21588.master.011.patch, 
> HBASE-21588.master.012.patch, HBASE-21588.master.013.patch, 
> HBASE-21588.master.014.patch, HBASE-21588.master.015.patch, 
> HBASE-21588.master.016.patch, HBASE-21588.master.017.patch
>
>
> create a sub task to submit the implementation of procedure v2 wal splitting



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21659) Avoid to load duplicate coprocessors in system config and table descriptor

2019-01-02 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16731921#comment-16731921
 ] 

Hudson commented on HBASE-21659:


Results for branch branch-2
[build #1588 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1588/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1588//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- Something went wrong running this stage, please [check relevant console 
output|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1588//console].


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1588//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Avoid to load duplicate coprocessors in system config and table descriptor
> --
>
> Key: HBASE-21659
> URL: https://issues.apache.org/jira/browse/HBASE-21659
> Project: HBase
>  Issue Type: Improvement
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Minor
> Fix For: 3.0.0, 2.2.0
>
> Attachments: HBASE-21659.master.001.patch, 
> HBASE-21659.master.002.patch, HBASE-21659.master.003.patch, 
> HBASE-21659.master.004.patch
>
>
> When there are same coprocessor in system coprocessor config and table 
> descriptor. It will load the coprocessor twice and the coprocessor method may 
> run twice, too. It should avoid to load duplicate coprocessors.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21159) Add shell command to switch throttle on or off

2019-01-02 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16731901#comment-16731901
 ] 

Hadoop QA commented on HBASE-21159:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
11s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 4 new or modified test 
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
14s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
 6s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  3m 
51s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  2m 
 8s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
 9s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  5m 
18s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
13s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
15s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
 5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  3m 
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green}  3m 
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  3m 
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  2m 
 7s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} rubocop {color} | {color:red}  0m 
11s{color} | {color:red} The patch generated 6 new + 149 unchanged - 2 fixed = 
155 total (was 151) {color} |
| {color:orange}-0{color} | {color:orange} ruby-lint {color} | {color:orange}  
0m  8s{color} | {color:orange} The patch generated 14 new + 270 unchanged - 0 
fixed = 284 total (was 270) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
 9s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}  
8m 40s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4 
or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green}  
1m 55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  5m 
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
14s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
33s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  3m 
16s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}129m 42s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  7m  
6s{color} | {color:green} hbase-shell in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  1m 
44s{color} | {color:green} The patch does not generate ASF License warnings. 

[jira] [Commented] (HBASE-21652) Refactor ThriftServer making thrift2 server inherited from thrift1 server

2019-01-02 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16731882#comment-16731882
 ] 

Hudson commented on HBASE-21652:


Results for branch master
[build #693 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/693/]: (x) 
*{color:red}-1 overall{color}*

details (if available):

(x) {color:red}-1 general checks{color}
-- Something went wrong running this stage, please [check relevant console 
output|https://builds.apache.org/job/HBase%20Nightly/job/master/693//console].




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- Something went wrong running this stage, please [check relevant console 
output|https://builds.apache.org/job/HBase%20Nightly/job/master/693//console].


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- Something went wrong running this stage, please [check relevant console 
output|https://builds.apache.org/job/HBase%20Nightly/job/master/693//console].


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Refactor ThriftServer making thrift2 server inherited from thrift1 server
> -
>
> Key: HBASE-21652
> URL: https://issues.apache.org/jira/browse/HBASE-21652
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Allan Yang
>Assignee: Allan Yang
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: HBASE-21652.branch-2.patch, HBASE-21652.patch, 
> HBASE-21652.v2.patch, HBASE-21652.v3.patch, HBASE-21652.v4.patch, 
> HBASE-21652.v5.patch, HBASE-21652.v6.patch, HBASE-21652.v7.patch
>
>
> Except the different protocol, thrift2 Server should have no much difference 
> from thrift1 Server.  So refactoring the thrift server, making thrift2 server 
> inherit from thrift1 server. Getting rid of many duplicated code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21547) Precommit uses master flaky list for other branches

2019-01-02 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16731881#comment-16731881
 ] 

Hudson commented on HBASE-21547:


Results for branch master
[build #693 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/693/]: (x) 
*{color:red}-1 overall{color}*

details (if available):

(x) {color:red}-1 general checks{color}
-- Something went wrong running this stage, please [check relevant console 
output|https://builds.apache.org/job/HBase%20Nightly/job/master/693//console].




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- Something went wrong running this stage, please [check relevant console 
output|https://builds.apache.org/job/HBase%20Nightly/job/master/693//console].


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- Something went wrong running this stage, please [check relevant console 
output|https://builds.apache.org/job/HBase%20Nightly/job/master/693//console].


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Precommit uses master flaky list for other branches
> ---
>
> Key: HBASE-21547
> URL: https://issues.apache.org/jira/browse/HBASE-21547
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.2.0, 1.2.10, 1.4.10, 2.1.3, 2.0.5, 1.3.4
>
> Attachments: HBASE-21547.master.001.patch, 
> HBASE-21547.master.002.patch
>
>
> Precommit job downloads the flaky exclude list for master branch when the 
> uploaded patch file is made for different branches.
> As an example check 
> [https://builds.apache.org/job/PreCommit-HBASE-Build/15192] which was against 
> branch-1 but the unit test downloaded master's flaky list.
> {noformat}
> 15:26:05 [Tue Dec  4 14:26:04 UTC 2018 INFO]: Personality: patch unit
> 15:26:05 [Tue Dec  4 14:26:04 UTC 2018 INFO]: 
> EXCLUDE_TESTS_URL=https://builds.apache.org/job/HBase-Find-Flaky-Tests/job/master/lastSuccessfulBuild/artifact/excludes/
> 15:26:05 [Tue Dec  4 14:26:04 UTC 2018 INFO]: INCLUDE_TESTS_URL=
> 15:26:05 --2018-12-04 14:26:04--  
> https://builds.apache.org/job/HBase-Find-Flaky-Tests/job/master/lastSuccessfulBuild/artifact/excludes/
> 15:26:05 Resolving builds.apache.org (builds.apache.org)... 195.201.213.130, 
> 2a01:4f8:c0:2cc9::2
> 15:26:05 Connecting to builds.apache.org 
> (builds.apache.org)|195.201.213.130|:443... connected.
> 15:26:06 HTTP request sent, awaiting response... 200 
> 15:26:06 Length: 866 [application/octet-stream]
> 15:26:06 Saving to: 'excludes'
> 15:26:06 
> 15:26:06  0K   100% 
> 43.0M=0s
> 15:26:06 
> 15:26:06 2018-12-04 14:26:06 (43.0 MB/s) - 'excludes' saved [866/866]
> 15:26:06 
> 15:26:09 cd /testptch/hbase/hbase-thrift
> 15:26:09 mvn --batch-mode 
> -Dmaven.repo.local=/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/yetus-m2/hbase-branch-1-patch-1
>  -DHBasePatchProcess -Dhttps.protocols=TLSv1.2 -PrunAllTests 
> -Dtest.exclude.pattern=**/master.cleaner.TestSnapshotFromMaster.java,**/client.TestRestoreSnapshotFromClientAfterSplittingRegions.java,**/regionserver.TestRegionMergeTransactionOnCluster.java,**/client.TestCloneSnapshotFromClientAfterSplittingRegion.java,**/master.assignment.TestAssignmentManager.java,**/master.assignment.TestAMAssignWithRandExec.java,**/client.TestMobCloneSnapshotFromClientAfterSplittingRegion.java,**/regionserver.TestCompactingToCellFlatMapMemStore.java,**/replication.TestReplicationSmallTestsSync.java,**/TestMultiVersions.java,**/client.TestMobRestoreSnapshotFromClientAfterSplittingRegions.java,**/client.TestRestoreSnapshotFromClientWithRegionReplicas.java,**/regionserver.TestRegionServerAbortTimeout.java,**/replication.TestMasterReplication.java,**/backup.TestIncrementalBackupWithBulkLoad.java,**/master.replication.TestRegisterPeerWorkerWhenRestarting.java
>  clean test -fae > /testptch/patchprocess/patch-unit-hbase-thrift.txt 2>&1
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21652) Refactor ThriftServer making thrift2 server inherited from thrift1 server

2019-01-02 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16731865#comment-16731865
 ] 

Hadoop QA commented on HBASE-21652:
---

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
19s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 7 new or modified test 
files. {color} |
|| || || || {color:brown} branch-2 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
12s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
55s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
36s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
38s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
32s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
29s{color} | {color:green} branch-2 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
 4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
53s{color} | {color:green} hbase-thrift generated 0 new + 18 unchanged - 2 
fixed = 18 total (was 20) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
35s{color} | {color:green} hbase-thrift: The patch generated 0 new + 53 
unchanged - 44 fixed = 53 total (was 97) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
45s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
10m  8s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
29s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  3m 
44s{color} | {color:green} hbase-thrift in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
11s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 41m 48s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:42ca976 |
| JIRA Issue | HBASE-21652 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12953487/HBASE-21652.branch-2.patch
 |
| Optional Tests |  dupname  asflicense  javac  javadoc  unit  findbugs  
shadedjars  hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 06e5230caaf8 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | branch-2 / 0b086087b2 |
| maven | version: Apache Maven 3.5.4 
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.0-RC3 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/15448/testReport/ |
| Max. process+thread count | 1730 (vs. ulimit of 1) |
| modules | C: hbase-thrift U: hbase-thrift |
| Console output | 

[jira] [Commented] (HBASE-21547) Precommit uses master flaky list for other branches

2019-01-02 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16731841#comment-16731841
 ] 

Hudson commented on HBASE-21547:


FAILURE: Integrated in Jenkins build HBase-1.2-IT #1194 (See 
[https://builds.apache.org/job/HBase-1.2-IT/1194/])
HBASE-21547 Precommit uses master flaky list for other branches (psomogyi: rev 
2ef33e1515dcbc2b23c05edb3e41478b0421654c)
* (edit) dev-support/hbase-personality.sh


> Precommit uses master flaky list for other branches
> ---
>
> Key: HBASE-21547
> URL: https://issues.apache.org/jira/browse/HBASE-21547
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.2.0, 1.2.10, 1.4.10, 2.1.3, 2.0.5, 1.3.4
>
> Attachments: HBASE-21547.master.001.patch, 
> HBASE-21547.master.002.patch
>
>
> Precommit job downloads the flaky exclude list for master branch when the 
> uploaded patch file is made for different branches.
> As an example check 
> [https://builds.apache.org/job/PreCommit-HBASE-Build/15192] which was against 
> branch-1 but the unit test downloaded master's flaky list.
> {noformat}
> 15:26:05 [Tue Dec  4 14:26:04 UTC 2018 INFO]: Personality: patch unit
> 15:26:05 [Tue Dec  4 14:26:04 UTC 2018 INFO]: 
> EXCLUDE_TESTS_URL=https://builds.apache.org/job/HBase-Find-Flaky-Tests/job/master/lastSuccessfulBuild/artifact/excludes/
> 15:26:05 [Tue Dec  4 14:26:04 UTC 2018 INFO]: INCLUDE_TESTS_URL=
> 15:26:05 --2018-12-04 14:26:04--  
> https://builds.apache.org/job/HBase-Find-Flaky-Tests/job/master/lastSuccessfulBuild/artifact/excludes/
> 15:26:05 Resolving builds.apache.org (builds.apache.org)... 195.201.213.130, 
> 2a01:4f8:c0:2cc9::2
> 15:26:05 Connecting to builds.apache.org 
> (builds.apache.org)|195.201.213.130|:443... connected.
> 15:26:06 HTTP request sent, awaiting response... 200 
> 15:26:06 Length: 866 [application/octet-stream]
> 15:26:06 Saving to: 'excludes'
> 15:26:06 
> 15:26:06  0K   100% 
> 43.0M=0s
> 15:26:06 
> 15:26:06 2018-12-04 14:26:06 (43.0 MB/s) - 'excludes' saved [866/866]
> 15:26:06 
> 15:26:09 cd /testptch/hbase/hbase-thrift
> 15:26:09 mvn --batch-mode 
> -Dmaven.repo.local=/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/yetus-m2/hbase-branch-1-patch-1
>  -DHBasePatchProcess -Dhttps.protocols=TLSv1.2 -PrunAllTests 
> -Dtest.exclude.pattern=**/master.cleaner.TestSnapshotFromMaster.java,**/client.TestRestoreSnapshotFromClientAfterSplittingRegions.java,**/regionserver.TestRegionMergeTransactionOnCluster.java,**/client.TestCloneSnapshotFromClientAfterSplittingRegion.java,**/master.assignment.TestAssignmentManager.java,**/master.assignment.TestAMAssignWithRandExec.java,**/client.TestMobCloneSnapshotFromClientAfterSplittingRegion.java,**/regionserver.TestCompactingToCellFlatMapMemStore.java,**/replication.TestReplicationSmallTestsSync.java,**/TestMultiVersions.java,**/client.TestMobRestoreSnapshotFromClientAfterSplittingRegions.java,**/client.TestRestoreSnapshotFromClientWithRegionReplicas.java,**/regionserver.TestRegionServerAbortTimeout.java,**/replication.TestMasterReplication.java,**/backup.TestIncrementalBackupWithBulkLoad.java,**/master.replication.TestRegisterPeerWorkerWhenRestarting.java
>  clean test -fae > /testptch/patchprocess/patch-unit-hbase-thrift.txt 2>&1
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-21652) Refactor ThriftServer making thrift2 server inherited from thrift1 server

2019-01-02 Thread Allan Yang (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-21652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Allan Yang updated HBASE-21652:
---
Attachment: HBASE-21652.branch-2.patch

> Refactor ThriftServer making thrift2 server inherited from thrift1 server
> -
>
> Key: HBASE-21652
> URL: https://issues.apache.org/jira/browse/HBASE-21652
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Allan Yang
>Assignee: Allan Yang
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: HBASE-21652.branch-2.patch, HBASE-21652.patch, 
> HBASE-21652.v2.patch, HBASE-21652.v3.patch, HBASE-21652.v4.patch, 
> HBASE-21652.v5.patch, HBASE-21652.v6.patch, HBASE-21652.v7.patch
>
>
> Except the different protocol, thrift2 Server should have no much difference 
> from thrift1 Server.  So refactoring the thrift server, making thrift2 server 
> inherit from thrift1 server. Getting rid of many duplicated code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21547) Precommit uses master flaky list for other branches

2019-01-02 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16731829#comment-16731829
 ] 

Hudson commented on HBASE-21547:


FAILURE: Integrated in Jenkins build HBase-1.3-IT #513 (See 
[https://builds.apache.org/job/HBase-1.3-IT/513/])
HBASE-21547 Precommit uses master flaky list for other branches (psomogyi: rev 
4b9622429eae5a6c93d69867f3c1610353e9a0a7)
* (edit) dev-support/hbase-personality.sh


> Precommit uses master flaky list for other branches
> ---
>
> Key: HBASE-21547
> URL: https://issues.apache.org/jira/browse/HBASE-21547
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.2.0, 1.2.10, 1.4.10, 2.1.3, 2.0.5, 1.3.4
>
> Attachments: HBASE-21547.master.001.patch, 
> HBASE-21547.master.002.patch
>
>
> Precommit job downloads the flaky exclude list for master branch when the 
> uploaded patch file is made for different branches.
> As an example check 
> [https://builds.apache.org/job/PreCommit-HBASE-Build/15192] which was against 
> branch-1 but the unit test downloaded master's flaky list.
> {noformat}
> 15:26:05 [Tue Dec  4 14:26:04 UTC 2018 INFO]: Personality: patch unit
> 15:26:05 [Tue Dec  4 14:26:04 UTC 2018 INFO]: 
> EXCLUDE_TESTS_URL=https://builds.apache.org/job/HBase-Find-Flaky-Tests/job/master/lastSuccessfulBuild/artifact/excludes/
> 15:26:05 [Tue Dec  4 14:26:04 UTC 2018 INFO]: INCLUDE_TESTS_URL=
> 15:26:05 --2018-12-04 14:26:04--  
> https://builds.apache.org/job/HBase-Find-Flaky-Tests/job/master/lastSuccessfulBuild/artifact/excludes/
> 15:26:05 Resolving builds.apache.org (builds.apache.org)... 195.201.213.130, 
> 2a01:4f8:c0:2cc9::2
> 15:26:05 Connecting to builds.apache.org 
> (builds.apache.org)|195.201.213.130|:443... connected.
> 15:26:06 HTTP request sent, awaiting response... 200 
> 15:26:06 Length: 866 [application/octet-stream]
> 15:26:06 Saving to: 'excludes'
> 15:26:06 
> 15:26:06  0K   100% 
> 43.0M=0s
> 15:26:06 
> 15:26:06 2018-12-04 14:26:06 (43.0 MB/s) - 'excludes' saved [866/866]
> 15:26:06 
> 15:26:09 cd /testptch/hbase/hbase-thrift
> 15:26:09 mvn --batch-mode 
> -Dmaven.repo.local=/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/yetus-m2/hbase-branch-1-patch-1
>  -DHBasePatchProcess -Dhttps.protocols=TLSv1.2 -PrunAllTests 
> -Dtest.exclude.pattern=**/master.cleaner.TestSnapshotFromMaster.java,**/client.TestRestoreSnapshotFromClientAfterSplittingRegions.java,**/regionserver.TestRegionMergeTransactionOnCluster.java,**/client.TestCloneSnapshotFromClientAfterSplittingRegion.java,**/master.assignment.TestAssignmentManager.java,**/master.assignment.TestAMAssignWithRandExec.java,**/client.TestMobCloneSnapshotFromClientAfterSplittingRegion.java,**/regionserver.TestCompactingToCellFlatMapMemStore.java,**/replication.TestReplicationSmallTestsSync.java,**/TestMultiVersions.java,**/client.TestMobRestoreSnapshotFromClientAfterSplittingRegions.java,**/client.TestRestoreSnapshotFromClientWithRegionReplicas.java,**/regionserver.TestRegionServerAbortTimeout.java,**/replication.TestMasterReplication.java,**/backup.TestIncrementalBackupWithBulkLoad.java,**/master.replication.TestRegisterPeerWorkerWhenRestarting.java
>  clean test -fae > /testptch/patchprocess/patch-unit-hbase-thrift.txt 2>&1
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21652) Refactor ThriftServer making thrift2 server inherited from thrift1 server

2019-01-02 Thread Allan Yang (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16731823#comment-16731823
 ] 

Allan Yang commented on HBASE-21652:


OK, all green, will push to master and branch-2, thanks for reviewing![~Apache9]

> Refactor ThriftServer making thrift2 server inherited from thrift1 server
> -
>
> Key: HBASE-21652
> URL: https://issues.apache.org/jira/browse/HBASE-21652
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Allan Yang
>Assignee: Allan Yang
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: HBASE-21652.patch, HBASE-21652.v2.patch, 
> HBASE-21652.v3.patch, HBASE-21652.v4.patch, HBASE-21652.v5.patch, 
> HBASE-21652.v6.patch, HBASE-21652.v7.patch
>
>
> Except the different protocol, thrift2 Server should have no much difference 
> from thrift1 Server.  So refactoring the thrift server, making thrift2 server 
> inherit from thrift1 server. Getting rid of many duplicated code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-21652) Refactor ThriftServer making thrift2 server inherited from thrift1 server

2019-01-02 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-21652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16731819#comment-16731819
 ] 

Hadoop QA commented on HBASE-21652:
---

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
11s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 7 new or modified test 
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
58s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
28s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
35s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
14s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
24s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
45s{color} | {color:green} hbase-thrift generated 0 new + 18 unchanged - 2 
fixed = 18 total (was 20) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
29s{color} | {color:green} hbase-thrift: The patch generated 0 new + 0 
unchanged - 1 fixed = 0 total (was 1) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
34s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}  
9m 37s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4 
or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
24s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m 
29s{color} | {color:green} hbase-thrift in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
 9s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 37m 39s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
| JIRA Issue | HBASE-21652 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12953482/HBASE-21652.v7.patch |
| Optional Tests |  dupname  asflicense  javac  javadoc  unit  findbugs  
shadedjars  hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux bf25c690c6ad 4.4.0-134-generic #160~14.04.1-Ubuntu SMP Fri Aug 
17 11:07:07 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / ec948f5d90 |
| maven | version: Apache Maven 3.5.4 
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.0-RC3 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/15447/testReport/ |
| Max. process+thread count | 1966 (vs. ulimit of 1) |
| modules | C: hbase-thrift U: hbase-thrift |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/15447/console |
| Powered 

[jira] [Updated] (HBASE-21547) Precommit uses master flaky list for other branches

2019-01-02 Thread Peter Somogyi (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-21547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Somogyi updated HBASE-21547:
--
   Resolution: Fixed
Fix Version/s: 2.0.5
   2.1.3
   1.4.10
   1.2.10
   2.2.0
   1.5.0
   3.0.0
   1.3.4
   Status: Resolved  (was: Patch Available)

Thanks for the review. Pushed to all branches.

> Precommit uses master flaky list for other branches
> ---
>
> Key: HBASE-21547
> URL: https://issues.apache.org/jira/browse/HBASE-21547
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Major
> Fix For: 1.3.4, 3.0.0, 1.5.0, 2.2.0, 1.2.10, 1.4.10, 2.1.3, 2.0.5
>
> Attachments: HBASE-21547.master.001.patch, 
> HBASE-21547.master.002.patch
>
>
> Precommit job downloads the flaky exclude list for master branch when the 
> uploaded patch file is made for different branches.
> As an example check 
> [https://builds.apache.org/job/PreCommit-HBASE-Build/15192] which was against 
> branch-1 but the unit test downloaded master's flaky list.
> {noformat}
> 15:26:05 [Tue Dec  4 14:26:04 UTC 2018 INFO]: Personality: patch unit
> 15:26:05 [Tue Dec  4 14:26:04 UTC 2018 INFO]: 
> EXCLUDE_TESTS_URL=https://builds.apache.org/job/HBase-Find-Flaky-Tests/job/master/lastSuccessfulBuild/artifact/excludes/
> 15:26:05 [Tue Dec  4 14:26:04 UTC 2018 INFO]: INCLUDE_TESTS_URL=
> 15:26:05 --2018-12-04 14:26:04--  
> https://builds.apache.org/job/HBase-Find-Flaky-Tests/job/master/lastSuccessfulBuild/artifact/excludes/
> 15:26:05 Resolving builds.apache.org (builds.apache.org)... 195.201.213.130, 
> 2a01:4f8:c0:2cc9::2
> 15:26:05 Connecting to builds.apache.org 
> (builds.apache.org)|195.201.213.130|:443... connected.
> 15:26:06 HTTP request sent, awaiting response... 200 
> 15:26:06 Length: 866 [application/octet-stream]
> 15:26:06 Saving to: 'excludes'
> 15:26:06 
> 15:26:06  0K   100% 
> 43.0M=0s
> 15:26:06 
> 15:26:06 2018-12-04 14:26:06 (43.0 MB/s) - 'excludes' saved [866/866]
> 15:26:06 
> 15:26:09 cd /testptch/hbase/hbase-thrift
> 15:26:09 mvn --batch-mode 
> -Dmaven.repo.local=/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/yetus-m2/hbase-branch-1-patch-1
>  -DHBasePatchProcess -Dhttps.protocols=TLSv1.2 -PrunAllTests 
> -Dtest.exclude.pattern=**/master.cleaner.TestSnapshotFromMaster.java,**/client.TestRestoreSnapshotFromClientAfterSplittingRegions.java,**/regionserver.TestRegionMergeTransactionOnCluster.java,**/client.TestCloneSnapshotFromClientAfterSplittingRegion.java,**/master.assignment.TestAssignmentManager.java,**/master.assignment.TestAMAssignWithRandExec.java,**/client.TestMobCloneSnapshotFromClientAfterSplittingRegion.java,**/regionserver.TestCompactingToCellFlatMapMemStore.java,**/replication.TestReplicationSmallTestsSync.java,**/TestMultiVersions.java,**/client.TestMobRestoreSnapshotFromClientAfterSplittingRegions.java,**/client.TestRestoreSnapshotFromClientWithRegionReplicas.java,**/regionserver.TestRegionServerAbortTimeout.java,**/replication.TestMasterReplication.java,**/backup.TestIncrementalBackupWithBulkLoad.java,**/master.replication.TestRegisterPeerWorkerWhenRestarting.java
>  clean test -fae > /testptch/patchprocess/patch-unit-hbase-thrift.txt 2>&1
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)