[jira] [Commented] (HBASE-21955) Auto insert release changes and releasenotes in release scripts
[
https://issues.apache.org/jira/browse/HBASE-21955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778927#comment-16778927
]
stack commented on HBASE-21955:
---
Here's some script that may help here:
{code}
wget http://apache.claz.org/yetus/0.9.0/apache-yetus-0.9.0-bin.tar.gz
# Could check md5/signature
tar xfz apache-yetus-0.9.0-bin.tar.gz
cd apache-yetus-0.9.0/
# Needs /usr/lib/python2 in PATH -- might have to ln -s.
./bin/releasedocmaker -p HBASE --fileversions -v 2.0.5 -l --sortorder=newer
--skip-credits
# This generates RELEASENOTES.2.0.5.md and CHANGELOG.2.0.5.md
# To insert into hbase changes.md...need to cut the top off the
CHANGELOG.2.0.5.md file removing license and first line and then insert it
after the license comment.
# Here is how to trip the top
sed -i -e '/## Release/,$!d' CHANGELOG.2.0.5.md
# Now insert into hbase.git/CHANGES.md after the license
sed -i -e '/-->/r CHANGELOG.2.0.5.md' ../hbase.git/CHANGES.md
# Similar for RELEASENOTES but slightly different.
sed -i -e '/Release Notes/,$!d' RELEASENOTES.2.0.5.md
sed -i -e '/-->/r RELEASENOTES.2.0.5.md' ../hbase.git/RELEASENOTES.md
[code}
> Auto insert release changes and releasenotes in release scripts
> ---
>
> Key: HBASE-21955
> URL: https://issues.apache.org/jira/browse/HBASE-21955
> Project: HBase
> Issue Type: Sub-task
>Reporter: stack
>Priority: Major
>
> Should be able to script updating changes and releasenotes as part of
> create-releases/release-build.sh.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20724) Sometimes some compacted storefiles are still opened after region failover
[ https://issues.apache.org/jira/browse/HBASE-20724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16779004#comment-16779004 ] Guanghao Zhang commented on HBASE-20724: org.junit.runners.model.TestTimedOutException: test timed out after 780 seconds at org.apache.hadoop.hbase.master.procedure.TestServerCrashProcedureWithReplicas.createTable(TestServerCrashProcedureWithReplicas.java:53) Run this ut in master branch and timeout on my local PC, too. Not realted. Will dig them in other issues. > Sometimes some compacted storefiles are still opened after region failover > -- > > Key: HBASE-20724 > URL: https://issues.apache.org/jira/browse/HBASE-20724 > Project: HBase > Issue Type: Bug >Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0 >Reporter: Francis Liu >Assignee: Guanghao Zhang >Priority: Critical > Attachments: HBASE-20724.master.001.patch, > HBASE-20724.master.002.patch, HBASE-20724.master.003.patch, > HBASE-20724.master.004.patch, HBASE-20724.master.005.patch, > HBASE-20724.master.006.patch, HBASE-20724.master.007.patch, > HBASE-20724.master.008.patch, HBASE-20724.master.009.patch, > HBASE-20724.master.010.patch, HBASE-20724.master.011.patch, > HBASE-20724.master.012.patch, HBASE-20724.master.013.patch, > HBASE-20724.master.013.patch, HBASE-20724.master.014.patch > > > It is important that compacted storefiles of a given compaction execution are > wholly opened or archived to insure data consistency. ie a storefile > containing delete tombstones can be archived while older storefiles > containing cells that were supposed to be deleted are left unarchived thereby > undeleting those cells. > When a server fails compaction markers (in the wal edit) are used to > determine which storefiles are compacted and should be excluded during region > open (during failover). But the WALs containing compaction markers can be > prematurely archived even though there are still compacted storefiles for > that particular compaction event that hasn't been archived yet. Thus losing > compaction information that needs to be replayed in the event of an RS crash. > This is because hlog archiving logic only keeps track of flushed storefiles > and not compacted ones. > https://issues.apache.org/jira/browse/HBASE-20704?focusedCommentId=16507680&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16507680 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20724) Sometimes some compacted storefiles are still opened after region failover
[ https://issues.apache.org/jira/browse/HBASE-20724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16779002#comment-16779002 ] Guanghao Zhang commented on HBASE-20724: Ok. All green. And the javac warning is not related. > Sometimes some compacted storefiles are still opened after region failover > -- > > Key: HBASE-20724 > URL: https://issues.apache.org/jira/browse/HBASE-20724 > Project: HBase > Issue Type: Bug >Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0 >Reporter: Francis Liu >Assignee: Guanghao Zhang >Priority: Critical > Attachments: HBASE-20724.master.001.patch, > HBASE-20724.master.002.patch, HBASE-20724.master.003.patch, > HBASE-20724.master.004.patch, HBASE-20724.master.005.patch, > HBASE-20724.master.006.patch, HBASE-20724.master.007.patch, > HBASE-20724.master.008.patch, HBASE-20724.master.009.patch, > HBASE-20724.master.010.patch, HBASE-20724.master.011.patch, > HBASE-20724.master.012.patch, HBASE-20724.master.013.patch, > HBASE-20724.master.013.patch, HBASE-20724.master.014.patch > > > It is important that compacted storefiles of a given compaction execution are > wholly opened or archived to insure data consistency. ie a storefile > containing delete tombstones can be archived while older storefiles > containing cells that were supposed to be deleted are left unarchived thereby > undeleting those cells. > When a server fails compaction markers (in the wal edit) are used to > determine which storefiles are compacted and should be excluded during region > open (during failover). But the WALs containing compaction markers can be > prematurely archived even though there are still compacted storefiles for > that particular compaction event that hasn't been archived yet. Thus losing > compaction information that needs to be replayed in the event of an RS crash. > This is because hlog archiving logic only keeps track of flushed storefiles > and not compacted ones. > https://issues.apache.org/jira/browse/HBASE-20704?focusedCommentId=16507680&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16507680 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21962) Filters do not work in ThriftTable
[ https://issues.apache.org/jira/browse/HBASE-21962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16779000#comment-16779000 ] Guanghao Zhang commented on HBASE-21962: +1 > Filters do not work in ThriftTable > -- > > Key: HBASE-21962 > URL: https://issues.apache.org/jira/browse/HBASE-21962 > Project: HBase > Issue Type: Sub-task > Components: Thrift >Reporter: Allan Yang >Assignee: Allan Yang >Priority: Major > Fix For: 3.0.0, 2.2.0 > > Attachments: HBASE-21962.patch, HBASE-21962.v2.patch > > > Filters in ThriftTable is not working, this issue is to fix it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20724) Sometimes some compacted storefiles are still opened after region failover
[
https://issues.apache.org/jira/browse/HBASE-20724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778999#comment-16778999
]
Hadoop QA commented on HBASE-20724:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
11s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 6 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
26s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
47s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
3s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
32s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 2m
28s{color} | {color:blue} hbase-server in master has 1 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
10s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
15s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 4m
7s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 2m 15s{color}
| {color:red} hbase-server generated 1 new + 187 unchanged - 1 fixed = 188
total (was 188) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
12s{color} | {color:green} The patch passed checkstyle in hbase-protocol-shaded
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
40s{color} | {color:green} The patch passed checkstyle in hbase-client {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
23s{color} | {color:green} hbase-server: The patch generated 0 new + 63
unchanged - 3 fixed = 63 total (was 66) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
13s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
9m 53s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4
or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green}
1m 54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 7m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
10s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
41s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
30s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}142m
45s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
59s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
|
[jira] [Commented] (HBASE-21961) Infinite loop in AsyncNonMetaRegionLocator if there is only one region and we tried to locate before a non empty row
[
https://issues.apache.org/jira/browse/HBASE-21961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778973#comment-16778973
]
Hadoop QA commented on HBASE-21961:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
12s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
31s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
33s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
47s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
45s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
35s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 2m
39s{color} | {color:blue} hbase-server in master has 1 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
54s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
51s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
33s{color} | {color:red} hbase-client: The patch generated 2 new + 0 unchanged
- 0 fixed = 2 total (was 0) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
36s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
8m 44s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4
or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
23s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}167m
20s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
37s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}217m 50s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
| JIRA Issue | HBASE-21961 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12960282/HBASE-21961.patch |
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 48b2f54473b9 4.4.0-139-generic #165~14.04.1-Ubuntu SMP Wed Oct
31 10:55:11 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / c33ceb23d3 |
| maven | version: Apache Maven 3
[jira] [Created] (HBASE-21966) Fix region holes, overlaps, and other region related errors
Jingyun Tian created HBASE-21966: Summary: Fix region holes, overlaps, and other region related errors Key: HBASE-21966 URL: https://issues.apache.org/jira/browse/HBASE-21966 Project: HBase Issue Type: Sub-task Reporter: Jingyun Tian Assignee: Jingyun Tian -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21965) Fix failed split and merge transactions that have failed to roll back
[ https://issues.apache.org/jira/browse/HBASE-21965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-21965: - Description: Make HBCK2 be able to fix failed split and merge transactions that have failed to roll back. > Fix failed split and merge transactions that have failed to roll back > - > > Key: HBASE-21965 > URL: https://issues.apache.org/jira/browse/HBASE-21965 > Project: HBase > Issue Type: Sub-task >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > > Make HBCK2 be able to fix failed split and merge transactions that have > failed to roll back. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Reopened] (HBASE-21965) Fix failed split and merge transactions that have failed to roll back
[ https://issues.apache.org/jira/browse/HBASE-21965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian reopened HBASE-21965: -- > Fix failed split and merge transactions that have failed to roll back > - > > Key: HBASE-21965 > URL: https://issues.apache.org/jira/browse/HBASE-21965 > Project: HBase > Issue Type: Sub-task >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21965) Fix failed split and merge transactions that have failed to roll back
[ https://issues.apache.org/jira/browse/HBASE-21965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-21965: - Issue Type: Sub-task (was: Task) Parent: HBASE-21745 > Fix failed split and merge transactions that have failed to roll back > - > > Key: HBASE-21965 > URL: https://issues.apache.org/jira/browse/HBASE-21965 > Project: HBase > Issue Type: Sub-task >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (HBASE-21965) Fix failed split and merge transactions that have failed to roll back
[ https://issues.apache.org/jira/browse/HBASE-21965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian resolved HBASE-21965. -- Resolution: Invalid > Fix failed split and merge transactions that have failed to roll back > - > > Key: HBASE-21965 > URL: https://issues.apache.org/jira/browse/HBASE-21965 > Project: HBase > Issue Type: Task >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (HBASE-21965) Fix failed split and merge transactions that have failed to roll back
Jingyun Tian created HBASE-21965: Summary: Fix failed split and merge transactions that have failed to roll back Key: HBASE-21965 URL: https://issues.apache.org/jira/browse/HBASE-21965 Project: HBase Issue Type: Task Reporter: Jingyun Tian Assignee: Jingyun Tian -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21906) Backport the CallQueueTooBigException related changes in HBASE-21875 to branch-2.1
[
https://issues.apache.org/jira/browse/HBASE-21906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778951#comment-16778951
]
Hadoop QA commented on HBASE-21906:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
13s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} branch-2.1 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
21s{color} | {color:green} branch-2.1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
0s{color} | {color:green} branch-2.1 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
14s{color} | {color:green} branch-2.1 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
5s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 2m
9s{color} | {color:blue} hbase-server in branch-2.1 has 1 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
30s{color} | {color:green} branch-2.1 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
4s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
8m 19s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4
or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
29s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}137m
4s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
26s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}174m 51s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:42ca976 |
| JIRA Issue | HBASE-21906 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12960284/HBASE-21906-branch-2.1.patch
|
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 5b8de966ef3d 4.4.0-138-generic #164~14.04.1-Ubuntu SMP Fri Oct
5 08:56:16 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | branch-2.1 / bc71447a0d |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.11 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/16144/testReport/ |
| Max. process+thread count | 5185 (vs. ulimit of 1) |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/16144/console |
| Powered by | Apache Yetus 0.8.0 http://yetu
[jira] [Commented] (HBASE-21745) Make HBCK2 be able to fix issues other than region assignment
[
https://issues.apache.org/jira/browse/HBASE-21745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778944#comment-16778944
]
Jingyun Tian commented on HBASE-21745:
--
{quote} - Fix region holes, overlaps, and other errors in the region chain
- Fix failed split and merge transactions that have failed to roll back
due to some bug (related to previous){quote}
I think HBCK2 should be able to fix these two problems. They may be caused by
master restart during some procedures running and procedure logs lost. Although
this should rarely happens, we should be able to fix these.
Let add subtasks for fixing them.
> Make HBCK2 be able to fix issues other than region assignment
> -
>
> Key: HBASE-21745
> URL: https://issues.apache.org/jira/browse/HBASE-21745
> Project: HBase
> Issue Type: Umbrella
> Components: hbase-operator-tools, hbck2
>Reporter: Duo Zhang
>Assignee: stack
>Priority: Critical
>
> This is what [~apurtell] posted on mailing-list, HBCK2 should support
> {quote}
>- Rebuild meta from region metadata in the filesystem, aka offline meta
>rebuild.
>- Fix assignment errors (undeployed regions, double assignments (yes,
>should not be possible), etc)
>- Fix region holes, overlaps, and other errors in the region chain
>- Fix failed split and merge transactions that have failed to roll back
>due to some bug (related to previous)
>- Enumerate store files to determine file level corruption and sideline
>corrupt files
>- Fix hfile link problems (dangling / broken)
> {quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Reopened] (HBASE-21836) Generate CHANGES.md and RELEASENOTES.md for 2.0.5
[
https://issues.apache.org/jira/browse/HBASE-21836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stack reopened HBASE-21836:
---
Reopen to push new edits to changes and RNs.
> Generate CHANGES.md and RELEASENOTES.md for 2.0.5
> -
>
> Key: HBASE-21836
> URL: https://issues.apache.org/jira/browse/HBASE-21836
> Project: HBase
> Issue Type: Sub-task
>Reporter: Duo Zhang
>Assignee: stack
>Priority: Major
> Fix For: 2.0.5
>
>
> {noformat}
> $ cd /Users/stack/checkouts/yetus.git
> $ ./release-doc-maker/releasedocmaker.py -p HBASE --fileversions -v 2.0.5 -l
> --sortorder=newer --skip-credits
> {noformat}
> ... produces CHANGELOG.2.0.5.md and RELEASENOTES.2.0.5.md.
> Then in hbase.git checkout of branch-2.0 tip, edit the CHANGES.md.
> Set the 2.0.4 released date.
> Read in the generated yetus file. Drop the license and the Changelog header
> (already license and header in the file we are reading into). Ditto for RNs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21963) Add a script for building and verifying release candidate
[
https://issues.apache.org/jira/browse/HBASE-21963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778935#comment-16778935
]
Hadoop QA commented on HBASE-21963:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
12s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m
0s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:red}-1{color} | {color:red} shellcheck {color} | {color:red} 0m
2s{color} | {color:red} The patch generated 32 new + 0 unchanged - 0 fixed = 32
total (was 0) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
10s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 0m 41s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
| JIRA Issue | HBASE-21963 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12960300/HBASE-21963.master.001.patch
|
| Optional Tests | dupname asflicense shellcheck shelldocs |
| uname | Linux 639eb3d39832 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 18f07455ea |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| shellcheck | v0.4.4 |
| shellcheck |
https://builds.apache.org/job/PreCommit-HBASE-Build/16147/artifact/patchprocess/diff-patch-shellcheck.txt
|
| Max. process+thread count | 48 (vs. ulimit of 1) |
| modules | C: . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/16147/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> Add a script for building and verifying release candidate
> -
>
> Key: HBASE-21963
> URL: https://issues.apache.org/jira/browse/HBASE-21963
> Project: HBase
> Issue Type: Test
> Components: release
>Affects Versions: 3.0.0, 2.1.3
>Reporter: Tak Lon (Stephen) Wu
>Assignee: Tak Lon (Stephen) Wu
>Priority: Minor
> Attachments: HBASE-21963.master.001.patch
>
>
> During the release vote for HBase 2.1.3RC1, a driver/helper script was
> mentioned and can potentially help contributors prepare to vote for a release
> candidate. As recommended, we decided to move toward this tool to under
> {{dev-support/}}
> Here the driver script provides the following automation:
> 1. Import and check publisher key(s)
> 2. Checksum of sources and binaries
> 3. Signature of sources and binaries
> 4. Rat check
> 5. Built from source
> 6. Verify unit tests
> {code}
> # example usage
> $ bash dev-support/hbase-vote.sh -s
> https://dist.apache.org/repos/dist/dev/hbase/hbase-1.5.0RC2/
> $ bash dev-support/hbase-vote.sh -h
> hbase-vote. A script for standard vote which verifies the following items
> 1. Checksum of sources and binaries
> 2. Signature of sources and binaries
> 3. Rat check
> 4. Built from source
> 5. Unit tests
> Usage: hbase-vote.sh -s | --source [-k | --key ] [-f |
> --keys-file-url ]
>hbase-vote.sh -h | --help
> -h | --help Show this screen.
> -s | --source '' A URL pointing to the release candidate
> sources and binaries
> e.g.
> https://dist.apache.org/repos/dist/dev/hbase/hbase-RC0/
> -k | --key '' A signature of the public key, e.g. 9AD2AE49
> -f | --keys-file-url '' the URL of the key file, default is
> http://www.apache.org/dist/hbase/KEYS
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-21963) Add a script for building and verifying release candidate
[
https://issues.apache.org/jira/browse/HBASE-21963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tak Lon (Stephen) Wu updated HBASE-21963:
-
Attachment: HBASE-21963.master.001.patch
> Add a script for building and verifying release candidate
> -
>
> Key: HBASE-21963
> URL: https://issues.apache.org/jira/browse/HBASE-21963
> Project: HBase
> Issue Type: Test
> Components: release
>Affects Versions: 3.0.0, 2.1.3
>Reporter: Tak Lon (Stephen) Wu
>Assignee: Tak Lon (Stephen) Wu
>Priority: Minor
> Attachments: HBASE-21963.master.001.patch
>
>
> During the release vote for HBase 2.1.3RC1, a driver/helper script was
> mentioned and can potentially help contributors prepare to vote for a release
> candidate. As recommended, we decided to move toward this tool to under
> {{dev-support/}}
> Here the driver script provides the following automation:
> 1. Import and check publisher key(s)
> 2. Checksum of sources and binaries
> 3. Signature of sources and binaries
> 4. Rat check
> 5. Built from source
> 6. Verify unit tests
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-21963) Add a script for building and verifying release candidate
[
https://issues.apache.org/jira/browse/HBASE-21963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tak Lon (Stephen) Wu updated HBASE-21963:
-
Description:
During the release vote for HBase 2.1.3RC1, a driver/helper script was
mentioned and can potentially help contributors prepare to vote for a release
candidate. As recommended, we decided to move toward this tool to under
{{dev-support/}}
Here the driver script provides the following automation:
1. Import and check publisher key(s)
2. Checksum of sources and binaries
3. Signature of sources and binaries
4. Rat check
5. Built from source
6. Verify unit tests
{code}
# example usage
$ bash dev-support/hbase-vote.sh -s
https://dist.apache.org/repos/dist/dev/hbase/hbase-1.5.0RC2/
$ bash dev-support/hbase-vote.sh -h
hbase-vote. A script for standard vote which verifies the following items
1. Checksum of sources and binaries
2. Signature of sources and binaries
3. Rat check
4. Built from source
5. Unit tests
Usage: hbase-vote.sh -s | --source [-k | --key ] [-f |
--keys-file-url ]
hbase-vote.sh -h | --help
-h | --help Show this screen.
-s | --source '' A URL pointing to the release candidate sources
and binaries
e.g.
https://dist.apache.org/repos/dist/dev/hbase/hbase-RC0/
-k | --key '' A signature of the public key, e.g. 9AD2AE49
-f | --keys-file-url '' the URL of the key file, default is
http://www.apache.org/dist/hbase/KEYS
{code}
was:
During the release vote for HBase 2.1.3RC1, a driver/helper script was
mentioned and can potentially help contributors prepare to vote for a release
candidate. As recommended, we decided to move toward this tool to under
{{dev-support/}}
Here the driver script provides the following automation:
1. Import and check publisher key(s)
2. Checksum of sources and binaries
3. Signature of sources and binaries
4. Rat check
5. Built from source
6. Verify unit tests
> Add a script for building and verifying release candidate
> -
>
> Key: HBASE-21963
> URL: https://issues.apache.org/jira/browse/HBASE-21963
> Project: HBase
> Issue Type: Test
> Components: release
>Affects Versions: 3.0.0, 2.1.3
>Reporter: Tak Lon (Stephen) Wu
>Assignee: Tak Lon (Stephen) Wu
>Priority: Minor
> Attachments: HBASE-21963.master.001.patch
>
>
> During the release vote for HBase 2.1.3RC1, a driver/helper script was
> mentioned and can potentially help contributors prepare to vote for a release
> candidate. As recommended, we decided to move toward this tool to under
> {{dev-support/}}
> Here the driver script provides the following automation:
> 1. Import and check publisher key(s)
> 2. Checksum of sources and binaries
> 3. Signature of sources and binaries
> 4. Rat check
> 5. Built from source
> 6. Verify unit tests
> {code}
> # example usage
> $ bash dev-support/hbase-vote.sh -s
> https://dist.apache.org/repos/dist/dev/hbase/hbase-1.5.0RC2/
> $ bash dev-support/hbase-vote.sh -h
> hbase-vote. A script for standard vote which verifies the following items
> 1. Checksum of sources and binaries
> 2. Signature of sources and binaries
> 3. Rat check
> 4. Built from source
> 5. Unit tests
> Usage: hbase-vote.sh -s | --source [-k | --key ] [-f |
> --keys-file-url ]
>hbase-vote.sh -h | --help
> -h | --help Show this screen.
> -s | --source '' A URL pointing to the release candidate
> sources and binaries
> e.g.
> https://dist.apache.org/repos/dist/dev/hbase/hbase-RC0/
> -k | --key '' A signature of the public key, e.g. 9AD2AE49
> -f | --keys-file-url '' the URL of the key file, default is
> http://www.apache.org/dist/hbase/KEYS
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (HBASE-21836) Generate CHANGES.md and RELEASENOTES.md for 2.0.5
[
https://issues.apache.org/jira/browse/HBASE-21836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stack resolved HBASE-21836.
---
Resolution: Fixed
Pushed. Re-resolving.
> Generate CHANGES.md and RELEASENOTES.md for 2.0.5
> -
>
> Key: HBASE-21836
> URL: https://issues.apache.org/jira/browse/HBASE-21836
> Project: HBase
> Issue Type: Sub-task
>Reporter: Duo Zhang
>Assignee: stack
>Priority: Major
> Fix For: 2.0.5
>
>
> {noformat}
> $ cd /Users/stack/checkouts/yetus.git
> $ ./release-doc-maker/releasedocmaker.py -p HBASE --fileversions -v 2.0.5 -l
> --sortorder=newer --skip-credits
> {noformat}
> ... produces CHANGELOG.2.0.5.md and RELEASENOTES.2.0.5.md.
> Then in hbase.git checkout of branch-2.0 tip, edit the CHANGES.md.
> Set the 2.0.4 released date.
> Read in the generated yetus file. Drop the license and the Changelog header
> (already license and header in the file we are reading into). Ditto for RNs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-21963) Add a script for building and verifying release candidate
[
https://issues.apache.org/jira/browse/HBASE-21963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tak Lon (Stephen) Wu updated HBASE-21963:
-
Status: Patch Available (was: Open)
> Add a script for building and verifying release candidate
> -
>
> Key: HBASE-21963
> URL: https://issues.apache.org/jira/browse/HBASE-21963
> Project: HBase
> Issue Type: Test
> Components: release
>Affects Versions: 2.1.3, 3.0.0
>Reporter: Tak Lon (Stephen) Wu
>Assignee: Tak Lon (Stephen) Wu
>Priority: Minor
> Attachments: HBASE-21963.master.001.patch
>
>
> During the release vote for HBase 2.1.3RC1, a driver/helper script was
> mentioned and can potentially help contributors prepare to vote for a release
> candidate. As recommended, we decided to move toward this tool to under
> {{dev-support/}}
> Here the driver script provides the following automation:
> 1. Import and check publisher key(s)
> 2. Checksum of sources and binaries
> 3. Signature of sources and binaries
> 4. Rat check
> 5. Built from source
> 6. Verify unit tests
> {code}
> # example usage
> $ bash dev-support/hbase-vote.sh -s
> https://dist.apache.org/repos/dist/dev/hbase/hbase-1.5.0RC2/
> $ bash dev-support/hbase-vote.sh -h
> hbase-vote. A script for standard vote which verifies the following items
> 1. Checksum of sources and binaries
> 2. Signature of sources and binaries
> 3. Rat check
> 4. Built from source
> 5. Unit tests
> Usage: hbase-vote.sh -s | --source [-k | --key ] [-f |
> --keys-file-url ]
>hbase-vote.sh -h | --help
> -h | --help Show this screen.
> -s | --source '' A URL pointing to the release candidate
> sources and binaries
> e.g.
> https://dist.apache.org/repos/dist/dev/hbase/hbase-RC0/
> -k | --key '' A signature of the public key, e.g. 9AD2AE49
> -f | --keys-file-url '' the URL of the key file, default is
> http://www.apache.org/dist/hbase/KEYS
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21916) Abstract an ByteBuffAllocator to allocate/free ByteBuffer in ByteBufferPool
[
https://issues.apache.org/jira/browse/HBASE-21916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778925#comment-16778925
]
Hadoop QA commented on HBASE-21916:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
13s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 4 new or modified test
files. {color} |
|| || || || {color:brown} HBASE-21879 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
24s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
11s{color} | {color:green} HBASE-21879 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
3s{color} | {color:green} HBASE-21879 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
2s{color} | {color:green} HBASE-21879 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
7s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
44s{color} | {color:green} HBASE-21879 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
6s{color} | {color:green} HBASE-21879 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 3m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
24s{color} | {color:green} hbase-common: The patch generated 0 new + 104
unchanged - 2 fixed = 104 total (was 106) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
31s{color} | {color:green} The patch passed checkstyle in hbase-client {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
5s{color} | {color:green} hbase-server: The patch generated 0 new + 46
unchanged - 5 fixed = 46 total (was 51) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
8s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
8m 41s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4
or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
8s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
33s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
7s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}136m
38s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
20s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}191m 7s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Doc
[jira] [Commented] (HBASE-21836) Generate CHANGES.md and RELEASENOTES.md for 2.0.5
[
https://issues.apache.org/jira/browse/HBASE-21836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778924#comment-16778924
]
stack commented on HBASE-21836:
---
Deleted old notes because a few changes have come in. Here's how did update
after doing delete:
{code}
wget http://apache.claz.org/yetus/0.9.0/apache-yetus-0.9.0-bin.tar.gz
tar xfz apache-yetus-0.9.0-bin.tar.gz
cd apache-yetus-0.9.0/
# Needs /usr/lib/python2 in PATH -- might have to ln -s.
./bin/releasedocmaker -p HBASE --fileversions -v 2.0.5 -l --sortorder=newer
--skip-credits
# This generates RELEASENOTES.2.0.5.md and CHANGELOG.2.0.5.md
# To insert into hbase changes.md...need to cut the top off the
CHANGELOG.2.0.5.md file removing license and first line and then insert it
after the license comment.
# Here is how to trip the top
sed -i -e '/## Release/,$!d' CHANGELOG.2.0.5.md
# Now insert into hbase.git/CHANGES.md after the license
sed -i -e '/-->/r CHANGELOG.2.0.5.md' ../hbase.git/CHANGES.md
# Similar for RELEASENOTES but slightly different.
sed -i -e '/Release Notes/,$!d' RELEASENOTES.2.0.5.md
sed -i -e '/-->/r RELEASENOTES.2.0.5.md' ../hbase.git/RELEASENOTES.md
{code}
Recommitted the changes after checking they looked good.
> Generate CHANGES.md and RELEASENOTES.md for 2.0.5
> -
>
> Key: HBASE-21836
> URL: https://issues.apache.org/jira/browse/HBASE-21836
> Project: HBase
> Issue Type: Sub-task
>Reporter: Duo Zhang
>Assignee: stack
>Priority: Major
> Fix For: 2.0.5
>
>
> {noformat}
> $ cd /Users/stack/checkouts/yetus.git
> $ ./release-doc-maker/releasedocmaker.py -p HBASE --fileversions -v 2.0.5 -l
> --sortorder=newer --skip-credits
> {noformat}
> ... produces CHANGELOG.2.0.5.md and RELEASENOTES.2.0.5.md.
> Then in hbase.git checkout of branch-2.0 tip, edit the CHANGES.md.
> Set the 2.0.4 released date.
> Read in the generated yetus file. Drop the license and the Changelog header
> (already license and header in the file we are reading into). Ditto for RNs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (HBASE-21964) unset Quota by Throttle Type
yaojingyi created HBASE-21964:
-
Summary: unset Quota by Throttle Type
Key: HBASE-21964
URL: https://issues.apache.org/jira/browse/HBASE-21964
Project: HBase
Issue Type: Improvement
Components: master
Affects Versions: 1.4.8
Reporter: yaojingyi
Attachments: unthrottleByType.patch
{code:java}
//first set_quota to USER=> 'u1'
set_quota TYPE => THROTTLE, USER => 'u1', THROTTLE_TYPE => WRITE, LIMIT =>
'1000req/sec'
//then
hbase(main):004:0> set_quota TYPE => THROTTLE, THROTTLE_TYPE => WRITE, USER =>
'u1', LIMIT => NONE
ERROR: Unexpected arguments: {"THROTTLE_TYPE"=>"WRITE"}
// or try "THROTTLE_TYPE"=>"WRITE_NUMBER"
hbase(main):012:0* set_quota TYPE => THROTTLE, THROTTLE_TYPE => WRITE_NUMBER,
USER => 'u1', LIMIT => NONE
NameError: uninitialized constant WRITE_NUMBER
{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20690) Moving table to target rsgroup needs to handle TableStateNotFoundException
[
https://issues.apache.org/jira/browse/HBASE-20690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778910#comment-16778910
]
Xiang Li commented on HBASE-20690:
--
Would like to continue [~andrewcheng]'s work on this JIRA, as I encountered the
same issue as recorded in HBASE-21919.
Currently blocked by [this
issue|https://issues.apache.org/jira/browse/HBASE-20690?focusedCommentId=16776326&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16776326]
> Moving table to target rsgroup needs to handle TableStateNotFoundException
> --
>
> Key: HBASE-20690
> URL: https://issues.apache.org/jira/browse/HBASE-20690
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Guangxu Cheng
>Priority: Major
> Attachments: HBASE-20690.master.001.patch,
> HBASE-20690.master.002.patch
>
>
> This is related code:
> {code}
> if (targetGroup != null) {
> for (TableName table: tables) {
> if (master.getAssignmentManager().isTableDisabled(table)) {
> LOG.debug("Skipping move regions because the table" + table + "
> is disabled.");
> continue;
> }
> {code}
> In a stack trace [~rmani] showed me:
> {code}
> 2018-06-06 07:10:44,893 ERROR
> [RpcServer.default.FPBQ.Fifo.handler=29,queue=2,port=2]
> master.TableStateManager: Unable to get table demo:tbl1 state
> org.apache.hadoop.hbase.master.TableStateManager$TableStateNotFoundException:
> demo:tbl1
> at
> org.apache.hadoop.hbase.master.TableStateManager.getTableState(TableStateManager.java:193)
> at
> org.apache.hadoop.hbase.master.TableStateManager.isTableState(TableStateManager.java:143)
> at
> org.apache.hadoop.hbase.master.assignment.AssignmentManager.isTableDisabled(AssignmentManager.java:346)
> at
> org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.moveTables(RSGroupAdminServer.java:407)
> at
> org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.assignTableToGroup(RSGroupAdminEndpoint.java:447)
> at
> org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.postCreateTable(RSGroupAdminEndpoint.java:470)
> at
> org.apache.hadoop.hbase.master.MasterCoprocessorHost$12.call(MasterCoprocessorHost.java:334)
> at
> org.apache.hadoop.hbase.master.MasterCoprocessorHost$12.call(MasterCoprocessorHost.java:331)
> at
> org.apache.hadoop.hbase.coprocessor.CoprocessorHost$ObserverOperationWithoutResult.callObserver(CoprocessorHost.java:540)
> at
> org.apache.hadoop.hbase.coprocessor.CoprocessorHost.execOperation(CoprocessorHost.java:614)
> at
> org.apache.hadoop.hbase.master.MasterCoprocessorHost.postCreateTable(MasterCoprocessorHost.java:331)
> at org.apache.hadoop.hbase.master.HMaster$3.run(HMaster.java:1768)
> at
> org.apache.hadoop.hbase.master.procedure.MasterProcedureUtil.submitProcedure(MasterProcedureUtil.java:131)
> at org.apache.hadoop.hbase.master.HMaster.createTable(HMaster.java:1750)
> at
> org.apache.hadoop.hbase.master.MasterRpcServices.createTable(MasterRpcServices.java:593)
> at
> org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:409)
> at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:131)
> at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324)
> at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304)
> {code}
> The logic should take potential TableStateNotFoundException into account.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (HBASE-20690) Moving table to target rsgroup needs to handle TableStateNotFoundException
[
https://issues.apache.org/jira/browse/HBASE-20690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16776326#comment-16776326
]
Xiang Li edited comment on HBASE-20690 at 2/27/19 5:31 AM:
---
Tried with patch v002 and could see a NPE in master's log, thrown from the
following statement:
{code}
String groupName =
master.getClusterSchema().getNamespace(desc.getTableName().getNamespaceAsString())
.getConfigurationValue(RSGroupInfo.NAMESPACE_DESC_PROP_GROUP);
{code}
master.getClusterSchema() is null (means cluster schema service is null)
was (Author: water):
Tried with patch v002 and could see a NPE in master's log, thrown from the
following statement:
{code}
String groupName =
master.getClusterSchema().getNamespace(desc.getTableName().getNamespaceAsString())
.getConfigurationValue(RSGroupInfo.NAMESPACE_DESC_PROP_GROUP);
{code}
master.ClusterSchema() is null and I guess the the cause is that the cluster
schema service is not initialized yet
> Moving table to target rsgroup needs to handle TableStateNotFoundException
> --
>
> Key: HBASE-20690
> URL: https://issues.apache.org/jira/browse/HBASE-20690
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Guangxu Cheng
>Priority: Major
> Attachments: HBASE-20690.master.001.patch,
> HBASE-20690.master.002.patch
>
>
> This is related code:
> {code}
> if (targetGroup != null) {
> for (TableName table: tables) {
> if (master.getAssignmentManager().isTableDisabled(table)) {
> LOG.debug("Skipping move regions because the table" + table + "
> is disabled.");
> continue;
> }
> {code}
> In a stack trace [~rmani] showed me:
> {code}
> 2018-06-06 07:10:44,893 ERROR
> [RpcServer.default.FPBQ.Fifo.handler=29,queue=2,port=2]
> master.TableStateManager: Unable to get table demo:tbl1 state
> org.apache.hadoop.hbase.master.TableStateManager$TableStateNotFoundException:
> demo:tbl1
> at
> org.apache.hadoop.hbase.master.TableStateManager.getTableState(TableStateManager.java:193)
> at
> org.apache.hadoop.hbase.master.TableStateManager.isTableState(TableStateManager.java:143)
> at
> org.apache.hadoop.hbase.master.assignment.AssignmentManager.isTableDisabled(AssignmentManager.java:346)
> at
> org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.moveTables(RSGroupAdminServer.java:407)
> at
> org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.assignTableToGroup(RSGroupAdminEndpoint.java:447)
> at
> org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.postCreateTable(RSGroupAdminEndpoint.java:470)
> at
> org.apache.hadoop.hbase.master.MasterCoprocessorHost$12.call(MasterCoprocessorHost.java:334)
> at
> org.apache.hadoop.hbase.master.MasterCoprocessorHost$12.call(MasterCoprocessorHost.java:331)
> at
> org.apache.hadoop.hbase.coprocessor.CoprocessorHost$ObserverOperationWithoutResult.callObserver(CoprocessorHost.java:540)
> at
> org.apache.hadoop.hbase.coprocessor.CoprocessorHost.execOperation(CoprocessorHost.java:614)
> at
> org.apache.hadoop.hbase.master.MasterCoprocessorHost.postCreateTable(MasterCoprocessorHost.java:331)
> at org.apache.hadoop.hbase.master.HMaster$3.run(HMaster.java:1768)
> at
> org.apache.hadoop.hbase.master.procedure.MasterProcedureUtil.submitProcedure(MasterProcedureUtil.java:131)
> at org.apache.hadoop.hbase.master.HMaster.createTable(HMaster.java:1750)
> at
> org.apache.hadoop.hbase.master.MasterRpcServices.createTable(MasterRpcServices.java:593)
> at
> org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:409)
> at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:131)
> at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324)
> at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304)
> {code}
> The logic should take potential TableStateNotFoundException into account.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21962) Filters do not work in ThriftTable
[ https://issues.apache.org/jira/browse/HBASE-21962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778897#comment-16778897 ] Allan Yang commented on HBASE-21962: OK, QA passed, [~zghaobac], any other concerns? > Filters do not work in ThriftTable > -- > > Key: HBASE-21962 > URL: https://issues.apache.org/jira/browse/HBASE-21962 > Project: HBase > Issue Type: Sub-task > Components: Thrift >Reporter: Allan Yang >Assignee: Allan Yang >Priority: Major > Fix For: 3.0.0, 2.2.0 > > Attachments: HBASE-21962.patch, HBASE-21962.v2.patch > > > Filters in ThriftTable is not working, this issue is to fix it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (HBASE-21963) Add a script for building and verifying release candidate
Tak Lon (Stephen) Wu created HBASE-21963:
Summary: Add a script for building and verifying release candidate
Key: HBASE-21963
URL: https://issues.apache.org/jira/browse/HBASE-21963
Project: HBase
Issue Type: Test
Components: release
Affects Versions: 2.1.3, 3.0.0
Reporter: Tak Lon (Stephen) Wu
Assignee: Tak Lon (Stephen) Wu
During the release vote for HBase 2.1.3RC1, a driver/helper script was
mentioned and can potentially help contributors prepare to vote for a release
candidate. As recommended, we decided to move toward this tool to under
{{dev-support/}}
Here the driver script provides the following automation:
1. Import and check publisher key(s)
2. Checksum of sources and binaries
3. Signature of sources and binaries
4. Rat check
5. Built from source
6. Verify unit tests
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (HBASE-20754) quickstart guide should instruct folks to set JAVA_HOME to a JDK installation.
[
https://issues.apache.org/jira/browse/HBASE-20754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gokul reassigned HBASE-20754:
-
Assignee: Gokul
> quickstart guide should instruct folks to set JAVA_HOME to a JDK installation.
> --
>
> Key: HBASE-20754
> URL: https://issues.apache.org/jira/browse/HBASE-20754
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Reporter: Sean Busbey
>Assignee: Gokul
>Priority: Major
> Labels: beginner
>
> The quickstart guide currently instructs folks to set JAVA_HOME, but to the
> wrong place
> {code}
> The JAVA_HOME variable should be set to a directory which contains the
> executable file bin/java. Most modern Linux operating systems provide a
> mechanism, such as /usr/bin/alternatives on RHEL or CentOS, for transparently
> switching between versions of executables such as Java. In this case, you can
> set JAVA_HOME to the directory containing the symbolic link to bin/java,
> which is usually /usr.
> JAVA_HOME=/usr
> {code}
> instead, it should tell folks to point it to a jdk installation and help them
> on how to find that.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21962) Filters do not work in ThriftTable
[
https://issues.apache.org/jira/browse/HBASE-21962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778892#comment-16778892
]
Hadoop QA commented on HBASE-21962:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
23s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
0s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
46s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
30s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
32s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
46s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
9m 14s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4
or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
28s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
47s{color} | {color:green} hbase-thrift in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
13s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 39m 16s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
| JIRA Issue | HBASE-21962 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12960289/HBASE-21962.v2.patch |
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux f7d80db7130b 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14
08:52:28 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 18f07455ea |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.11 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/16146/testReport/ |
| Max. process+thread count | 1798 (vs. ulimit of 1) |
| modules | C: hbase-thrift U: hbase-thrift |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/16146/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> Filters do not w
[jira] [Commented] (HBASE-21481) [acl] Superuser's permissions should not be granted or revoked by any non-su global admin
[
https://issues.apache.org/jira/browse/HBASE-21481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778875#comment-16778875
]
Reid Chan commented on HBASE-21481:
---
Got your point, i will clean them up in v12.
> [acl] Superuser's permissions should not be granted or revoked by any non-su
> global admin
> -
>
> Key: HBASE-21481
> URL: https://issues.apache.org/jira/browse/HBASE-21481
> Project: HBase
> Issue Type: Improvement
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Labels: ACL, security-issue
> Fix For: 3.0.0, 2.2.0, 2.3.0
>
> Attachments: HBASE-21481.master.001.patch,
> HBASE-21481.master.002.patch, HBASE-21481.master.003.patch,
> HBASE-21481.master.004.patch, HBASE-21481.master.005.patch,
> HBASE-21481.master.006.patch, HBASE-21481.master.007.patch,
> HBASE-21481.master.008.patch, HBASE-21481.master.009.patch,
> HBASE-21481.master.010.patch, HBASE-21481.master.011.patch
>
>
> Superusers are {{hbase.superuser}} listed in configuration and plus the one
> who start master process, these two may be overlap.
> A superuser must be a global admin, but a global admin may not be a
> superuser, possibly granted afterwards.
> For now, an non-su global admin with a Global.ADMIN permission can grant or
> revoke any superuser's permission, accidentally or deliberately.
> The purpose of this issue is to ban this action.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-21962) Filters do not work in ThriftTable
[ https://issues.apache.org/jira/browse/HBASE-21962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allan Yang updated HBASE-21962: --- Attachment: HBASE-21962.v2.patch > Filters do not work in ThriftTable > -- > > Key: HBASE-21962 > URL: https://issues.apache.org/jira/browse/HBASE-21962 > Project: HBase > Issue Type: Sub-task > Components: Thrift >Reporter: Allan Yang >Assignee: Allan Yang >Priority: Major > Fix For: 3.0.0, 2.2.0 > > Attachments: HBASE-21962.patch, HBASE-21962.v2.patch > > > Filters in ThriftTable is not working, this issue is to fix it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21481) [acl] Superuser's permissions should not be granted or revoked by any non-su global admin
[
https://issues.apache.org/jira/browse/HBASE-21481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guanghao Zhang updated HBASE-21481:
---
Fix Version/s: 2.3.0
> [acl] Superuser's permissions should not be granted or revoked by any non-su
> global admin
> -
>
> Key: HBASE-21481
> URL: https://issues.apache.org/jira/browse/HBASE-21481
> Project: HBase
> Issue Type: Improvement
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Labels: ACL, security-issue
> Fix For: 3.0.0, 2.2.0, 2.3.0
>
> Attachments: HBASE-21481.master.001.patch,
> HBASE-21481.master.002.patch, HBASE-21481.master.003.patch,
> HBASE-21481.master.004.patch, HBASE-21481.master.005.patch,
> HBASE-21481.master.006.patch, HBASE-21481.master.007.patch,
> HBASE-21481.master.008.patch, HBASE-21481.master.009.patch,
> HBASE-21481.master.010.patch, HBASE-21481.master.011.patch
>
>
> Superusers are {{hbase.superuser}} listed in configuration and plus the one
> who start master process, these two may be overlap.
> A superuser must be a global admin, but a global admin may not be a
> superuser, possibly granted afterwards.
> For now, an non-su global admin with a Global.ADMIN permission can grant or
> revoke any superuser's permission, accidentally or deliberately.
> The purpose of this issue is to ban this action.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-20724) Sometimes some compacted storefiles are still opened after region failover
[ https://issues.apache.org/jira/browse/HBASE-20724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-20724: --- Attachment: HBASE-20724.master.014.patch > Sometimes some compacted storefiles are still opened after region failover > -- > > Key: HBASE-20724 > URL: https://issues.apache.org/jira/browse/HBASE-20724 > Project: HBase > Issue Type: Bug >Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0 >Reporter: Francis Liu >Assignee: Guanghao Zhang >Priority: Critical > Attachments: HBASE-20724.master.001.patch, > HBASE-20724.master.002.patch, HBASE-20724.master.003.patch, > HBASE-20724.master.004.patch, HBASE-20724.master.005.patch, > HBASE-20724.master.006.patch, HBASE-20724.master.007.patch, > HBASE-20724.master.008.patch, HBASE-20724.master.009.patch, > HBASE-20724.master.010.patch, HBASE-20724.master.011.patch, > HBASE-20724.master.012.patch, HBASE-20724.master.013.patch, > HBASE-20724.master.013.patch, HBASE-20724.master.014.patch > > > It is important that compacted storefiles of a given compaction execution are > wholly opened or archived to insure data consistency. ie a storefile > containing delete tombstones can be archived while older storefiles > containing cells that were supposed to be deleted are left unarchived thereby > undeleting those cells. > When a server fails compaction markers (in the wal edit) are used to > determine which storefiles are compacted and should be excluded during region > open (during failover). But the WALs containing compaction markers can be > prematurely archived even though there are still compacted storefiles for > that particular compaction event that hasn't been archived yet. Thus losing > compaction information that needs to be replayed in the event of an RS crash. > This is because hlog archiving logic only keeps track of flushed storefiles > and not compacted ones. > https://issues.apache.org/jira/browse/HBASE-20704?focusedCommentId=16507680&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16507680 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20724) Sometimes some compacted storefiles are still opened after region failover
[
https://issues.apache.org/jira/browse/HBASE-20724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778861#comment-16778861
]
Guanghao Zhang commented on HBASE-20724:
TestServerCrashProcedure passed but take 12min...
{code:java}
Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 722.7 s - in
org.apache.hadoop.hbase.master.procedure.TestServerCrashProcedure{code}
> Sometimes some compacted storefiles are still opened after region failover
> --
>
> Key: HBASE-20724
> URL: https://issues.apache.org/jira/browse/HBASE-20724
> Project: HBase
> Issue Type: Bug
>Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0
>Reporter: Francis Liu
>Assignee: Guanghao Zhang
>Priority: Critical
> Attachments: HBASE-20724.master.001.patch,
> HBASE-20724.master.002.patch, HBASE-20724.master.003.patch,
> HBASE-20724.master.004.patch, HBASE-20724.master.005.patch,
> HBASE-20724.master.006.patch, HBASE-20724.master.007.patch,
> HBASE-20724.master.008.patch, HBASE-20724.master.009.patch,
> HBASE-20724.master.010.patch, HBASE-20724.master.011.patch,
> HBASE-20724.master.012.patch, HBASE-20724.master.013.patch,
> HBASE-20724.master.013.patch
>
>
> It is important that compacted storefiles of a given compaction execution are
> wholly opened or archived to insure data consistency. ie a storefile
> containing delete tombstones can be archived while older storefiles
> containing cells that were supposed to be deleted are left unarchived thereby
> undeleting those cells.
> When a server fails compaction markers (in the wal edit) are used to
> determine which storefiles are compacted and should be excluded during region
> open (during failover). But the WALs containing compaction markers can be
> prematurely archived even though there are still compacted storefiles for
> that particular compaction event that hasn't been archived yet. Thus losing
> compaction information that needs to be replayed in the event of an RS crash.
> This is because hlog archiving logic only keeps track of flushed storefiles
> and not compacted ones.
> https://issues.apache.org/jira/browse/HBASE-20704?focusedCommentId=16507680&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16507680
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21934) RemoteProcedureDispatcher should track the ongoing dispatched calls
[ https://issues.apache.org/jira/browse/HBASE-21934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778858#comment-16778858 ] Jingyun Tian commented on HBASE-21934: -- [~Apache9] Sir, all tests passed. Could you help check this out? > RemoteProcedureDispatcher should track the ongoing dispatched calls > --- > > Key: HBASE-21934 > URL: https://issues.apache.org/jira/browse/HBASE-21934 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.x >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Fix For: 3. > > Attachments: HBASE-21934.master.001.patch, > HBASE-21934.master.002.patch, HBASE-21934.master.003.patch, > HBASE-21934.master.004.patch, HBASE-21934.master.005.patch, > HBASE-21934.master.006.patch > > > I encounter the problem that when master assign a splitWALRemoteProcedure to > a region server. The log of this region server says it failed to recover the > lease of this file. Then this region server is killed by chaosMonkey. As the > result, this procedure is not timeout and hang there forever. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21481) [acl] Superuser's permissions should not be granted or revoked by any non-su global admin
[
https://issues.apache.org/jira/browse/HBASE-21481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778857#comment-16778857
]
Guanghao Zhang commented on HBASE-21481:
Got it. The callee only is a String: user name or group. Sorry for not very
familiar with this.
But why don't add a Superusers.isSuperUser(String) method? Then we don't need
store the superUsers and groups in AuthManager, again.
> [acl] Superuser's permissions should not be granted or revoked by any non-su
> global admin
> -
>
> Key: HBASE-21481
> URL: https://issues.apache.org/jira/browse/HBASE-21481
> Project: HBase
> Issue Type: Improvement
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Labels: ACL, security-issue
> Fix For: 3.0.0, 2.2.0
>
> Attachments: HBASE-21481.master.001.patch,
> HBASE-21481.master.002.patch, HBASE-21481.master.003.patch,
> HBASE-21481.master.004.patch, HBASE-21481.master.005.patch,
> HBASE-21481.master.006.patch, HBASE-21481.master.007.patch,
> HBASE-21481.master.008.patch, HBASE-21481.master.009.patch,
> HBASE-21481.master.010.patch, HBASE-21481.master.011.patch
>
>
> Superusers are {{hbase.superuser}} listed in configuration and plus the one
> who start master process, these two may be overlap.
> A superuser must be a global admin, but a global admin may not be a
> superuser, possibly granted afterwards.
> For now, an non-su global admin with a Global.ADMIN permission can grant or
> revoke any superuser's permission, accidentally or deliberately.
> The purpose of this issue is to ban this action.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-21960) RESTServletContainer not configured for REST Jetty server
[ https://issues.apache.org/jira/browse/HBASE-21960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HBASE-21960: --- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Thanks for the review today, Stack. Fixed the checkstyle nits from QA on commit. Slightly different test-code on branch-2.0 and branch-2.1 due to missing test-config changes. > RESTServletContainer not configured for REST Jetty server > - > > Key: HBASE-21960 > URL: https://issues.apache.org/jira/browse/HBASE-21960 > Project: HBase > Issue Type: Bug > Components: REST >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Blocker > Fix For: 3.0.0, 2.2.0, 2.0.5, 2.1.4 > > Attachments: HBASE-21960.001.patch, HBASE-21960.002.patch, > HBASE-21960.003.patch, HBASE-21960.004.patch, HBASE-21960.005.patch > > > The upgrade to Jetty 9 (HBASE-12894) appears to have missed including the > RESTServletContainer as the base servlet for Jetty. Make sure we configure > that class. > I also have some testing to prevent a regression again in the future. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21481) [acl] Superuser's permissions should not be granted or revoked by any non-su global admin
[
https://issues.apache.org/jira/browse/HBASE-21481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778852#comment-16778852
]
Reid Chan commented on HBASE-21481:
---
Let's say: A grant|revoke B permissions, caller A(a User object) and callee B(a
String object) will be passed to server.
Hoping i make it clear.
> [acl] Superuser's permissions should not be granted or revoked by any non-su
> global admin
> -
>
> Key: HBASE-21481
> URL: https://issues.apache.org/jira/browse/HBASE-21481
> Project: HBase
> Issue Type: Improvement
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Labels: ACL, security-issue
> Fix For: 3.0.0, 2.2.0
>
> Attachments: HBASE-21481.master.001.patch,
> HBASE-21481.master.002.patch, HBASE-21481.master.003.patch,
> HBASE-21481.master.004.patch, HBASE-21481.master.005.patch,
> HBASE-21481.master.006.patch, HBASE-21481.master.007.patch,
> HBASE-21481.master.008.patch, HBASE-21481.master.009.patch,
> HBASE-21481.master.010.patch, HBASE-21481.master.011.patch
>
>
> Superusers are {{hbase.superuser}} listed in configuration and plus the one
> who start master process, these two may be overlap.
> A superuser must be a global admin, but a global admin may not be a
> superuser, possibly granted afterwards.
> For now, an non-su global admin with a Global.ADMIN permission can grant or
> revoke any superuser's permission, accidentally or deliberately.
> The purpose of this issue is to ban this action.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21962) Filters do not work in ThriftTable
[
https://issues.apache.org/jira/browse/HBASE-21962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778850#comment-16778850
]
Hadoop QA commented on HBASE-21962:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
11s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
28s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
47s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
32s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
27s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
29s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
52s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
33s{color} | {color:red} hbase-thrift: The patch generated 2 new + 0 unchanged
- 0 fixed = 2 total (was 0) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
32s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
8m 51s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4
or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
29s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
15s{color} | {color:green} hbase-thrift in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
8s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 37m 12s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
| JIRA Issue | HBASE-21962 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12960281/HBASE-21962.patch |
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux b3d132f833cd 4.4.0-139-generic #165~14.04.1-Ubuntu SMP Wed Oct
31 10:55:11 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / c33ceb23d3 |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.11 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HBASE-Build/16142/artifact/patchprocess/diff-checkstyle-hbase-thrift.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/16142/testReport/ |
| Max. process+thread count | 1957 (vs. ulimit of 1) |
| modules | C: hbase-thrift U: hbase-thrift |
| Console output |
htt
[jira] [Updated] (HBASE-21082) Reimplement assign/unassign related procedure metrics
[ https://issues.apache.org/jira/browse/HBASE-21082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-21082: -- Hadoop Flags: Incompatible change > Reimplement assign/unassign related procedure metrics > - > > Key: HBASE-21082 > URL: https://issues.apache.org/jira/browse/HBASE-21082 > Project: HBase > Issue Type: Sub-task > Components: amv2, metrics >Reporter: Duo Zhang >Priority: Critical > Fix For: 3.0.0, 2.3.0 > > > As after HBASE-20881, we only have one TRSP procedure to handle all the > assign/unassign/move/reopen operations, we need to reimplement(redefine?) the > metrics for these procedures. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21481) [acl] Superuser's permissions should not be granted or revoked by any non-su global admin
[
https://issues.apache.org/jira/browse/HBASE-21481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778849#comment-16778849
]
Reid Chan commented on HBASE-21481:
---
Callee is not a User object, that's why we can't use that method.
> [acl] Superuser's permissions should not be granted or revoked by any non-su
> global admin
> -
>
> Key: HBASE-21481
> URL: https://issues.apache.org/jira/browse/HBASE-21481
> Project: HBase
> Issue Type: Improvement
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Labels: ACL, security-issue
> Fix For: 3.0.0, 2.2.0
>
> Attachments: HBASE-21481.master.001.patch,
> HBASE-21481.master.002.patch, HBASE-21481.master.003.patch,
> HBASE-21481.master.004.patch, HBASE-21481.master.005.patch,
> HBASE-21481.master.006.patch, HBASE-21481.master.007.patch,
> HBASE-21481.master.008.patch, HBASE-21481.master.009.patch,
> HBASE-21481.master.010.patch, HBASE-21481.master.011.patch
>
>
> Superusers are {{hbase.superuser}} listed in configuration and plus the one
> who start master process, these two may be overlap.
> A superuser must be a global admin, but a global admin may not be a
> superuser, possibly granted afterwards.
> For now, an non-su global admin with a Global.ADMIN permission can grant or
> revoke any superuser's permission, accidentally or deliberately.
> The purpose of this issue is to ban this action.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20724) Sometimes some compacted storefiles are still opened after region failover
[ https://issues.apache.org/jira/browse/HBASE-20724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778843#comment-16778843 ] Duo Zhang commented on HBASE-20724: --- It should be a slow machine. Try them locally? > Sometimes some compacted storefiles are still opened after region failover > -- > > Key: HBASE-20724 > URL: https://issues.apache.org/jira/browse/HBASE-20724 > Project: HBase > Issue Type: Bug >Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0 >Reporter: Francis Liu >Assignee: Guanghao Zhang >Priority: Critical > Attachments: HBASE-20724.master.001.patch, > HBASE-20724.master.002.patch, HBASE-20724.master.003.patch, > HBASE-20724.master.004.patch, HBASE-20724.master.005.patch, > HBASE-20724.master.006.patch, HBASE-20724.master.007.patch, > HBASE-20724.master.008.patch, HBASE-20724.master.009.patch, > HBASE-20724.master.010.patch, HBASE-20724.master.011.patch, > HBASE-20724.master.012.patch, HBASE-20724.master.013.patch, > HBASE-20724.master.013.patch > > > It is important that compacted storefiles of a given compaction execution are > wholly opened or archived to insure data consistency. ie a storefile > containing delete tombstones can be archived while older storefiles > containing cells that were supposed to be deleted are left unarchived thereby > undeleting those cells. > When a server fails compaction markers (in the wal edit) are used to > determine which storefiles are compacted and should be excluded during region > open (during failover). But the WALs containing compaction markers can be > prematurely archived even though there are still compacted storefiles for > that particular compaction event that hasn't been archived yet. Thus losing > compaction information that needs to be replayed in the event of an RS crash. > This is because hlog archiving logic only keeps track of flushed storefiles > and not compacted ones. > https://issues.apache.org/jira/browse/HBASE-20704?focusedCommentId=16507680&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16507680 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20724) Sometimes some compacted storefiles are still opened after region failover
[ https://issues.apache.org/jira/browse/HBASE-20724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778837#comment-16778837 ] Guanghao Zhang commented on HBASE-20724: Seems the failed ut always failed in pre commit job. > Sometimes some compacted storefiles are still opened after region failover > -- > > Key: HBASE-20724 > URL: https://issues.apache.org/jira/browse/HBASE-20724 > Project: HBase > Issue Type: Bug >Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0 >Reporter: Francis Liu >Assignee: Guanghao Zhang >Priority: Critical > Attachments: HBASE-20724.master.001.patch, > HBASE-20724.master.002.patch, HBASE-20724.master.003.patch, > HBASE-20724.master.004.patch, HBASE-20724.master.005.patch, > HBASE-20724.master.006.patch, HBASE-20724.master.007.patch, > HBASE-20724.master.008.patch, HBASE-20724.master.009.patch, > HBASE-20724.master.010.patch, HBASE-20724.master.011.patch, > HBASE-20724.master.012.patch, HBASE-20724.master.013.patch, > HBASE-20724.master.013.patch > > > It is important that compacted storefiles of a given compaction execution are > wholly opened or archived to insure data consistency. ie a storefile > containing delete tombstones can be archived while older storefiles > containing cells that were supposed to be deleted are left unarchived thereby > undeleting those cells. > When a server fails compaction markers (in the wal edit) are used to > determine which storefiles are compacted and should be excluded during region > open (during failover). But the WALs containing compaction markers can be > prematurely archived even though there are still compacted storefiles for > that particular compaction event that hasn't been archived yet. Thus losing > compaction information that needs to be replayed in the event of an RS crash. > This is because hlog archiving logic only keeps track of flushed storefiles > and not compacted ones. > https://issues.apache.org/jira/browse/HBASE-20704?focusedCommentId=16507680&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16507680 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21481) [acl] Superuser's permissions should not be granted or revoked by any non-su global admin
[
https://issues.apache.org/jira/browse/HBASE-21481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778828#comment-16778828
]
Guanghao Zhang commented on HBASE-21481:
{quote}if (authManager.checkSuperPrivileges(name)) {quote}
I mean that if use Superusers.isSuperUser here, no need to change so much code?
> [acl] Superuser's permissions should not be granted or revoked by any non-su
> global admin
> -
>
> Key: HBASE-21481
> URL: https://issues.apache.org/jira/browse/HBASE-21481
> Project: HBase
> Issue Type: Improvement
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Labels: ACL, security-issue
> Fix For: 3.0.0, 2.2.0
>
> Attachments: HBASE-21481.master.001.patch,
> HBASE-21481.master.002.patch, HBASE-21481.master.003.patch,
> HBASE-21481.master.004.patch, HBASE-21481.master.005.patch,
> HBASE-21481.master.006.patch, HBASE-21481.master.007.patch,
> HBASE-21481.master.008.patch, HBASE-21481.master.009.patch,
> HBASE-21481.master.010.patch, HBASE-21481.master.011.patch
>
>
> Superusers are {{hbase.superuser}} listed in configuration and plus the one
> who start master process, these two may be overlap.
> A superuser must be a global admin, but a global admin may not be a
> superuser, possibly granted afterwards.
> For now, an non-su global admin with a Global.ADMIN permission can grant or
> revoke any superuser's permission, accidentally or deliberately.
> The purpose of this issue is to ban this action.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-21943) The usage of RegionLocations.mergeRegionLocations is wrong for async client
[ https://issues.apache.org/jira/browse/HBASE-21943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-21943: -- Attachment: HBASE-21943-addendum-branch-2.1.patch > The usage of RegionLocations.mergeRegionLocations is wrong for async client > --- > > Key: HBASE-21943 > URL: https://issues.apache.org/jira/browse/HBASE-21943 > Project: HBase > Issue Type: Bug > Components: asyncclient, Client >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Critical > Fix For: 3.0.0, 2.2.0, 2.0.5, 2.3.0, 2.1.4 > > Attachments: HBASE-21943-UT-v1.patch, HBASE-21943-UT.patch, > HBASE-21943-UT.patch, HBASE-21943-addendum-branch-2.1.patch, > HBASE-21943-v1.patch, HBASE-21943-v2.patch, HBASE-21943.patch > > > In AsyncRegionLocatorHelper.mergeRegionLocations we create a new > RegionLocations and call mergeRegionLocations on it, expected that it will be > changed by this method, but actually the method will not modify the object > itself, it will return a new one... > And we are lucky that we create the RegionLocations with the new locations, > so usually we will get update result. But when testing HBASE-21717, we meet > another bug in AsyncNonMetaRegionLocator.isEqual, where we missed a '!' when > checking server name equals... -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (HBASE-21943) The usage of RegionLocations.mergeRegionLocations is wrong for async client
[ https://issues.apache.org/jira/browse/HBASE-21943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-21943. --- Resolution: Fixed Pushed the addendum to branch-2.1 > The usage of RegionLocations.mergeRegionLocations is wrong for async client > --- > > Key: HBASE-21943 > URL: https://issues.apache.org/jira/browse/HBASE-21943 > Project: HBase > Issue Type: Bug > Components: asyncclient, Client >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Critical > Fix For: 3.0.0, 2.2.0, 2.0.5, 2.3.0, 2.1.4 > > Attachments: HBASE-21943-UT-v1.patch, HBASE-21943-UT.patch, > HBASE-21943-UT.patch, HBASE-21943-addendum-branch-2.1.patch, > HBASE-21943-v1.patch, HBASE-21943-v2.patch, HBASE-21943.patch > > > In AsyncRegionLocatorHelper.mergeRegionLocations we create a new > RegionLocations and call mergeRegionLocations on it, expected that it will be > changed by this method, but actually the method will not modify the object > itself, it will return a new one... > And we are lucky that we create the RegionLocations with the new locations, > so usually we will get update result. But when testing HBASE-21717, we meet > another bug in AsyncNonMetaRegionLocator.isEqual, where we missed a '!' when > checking server name equals... -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21906) Backport the CallQueueTooBigException related changes in HBASE-21875 to branch-2.1
[ https://issues.apache.org/jira/browse/HBASE-21906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-21906: -- Attachment: HBASE-21906-branch-2.1.patch > Backport the CallQueueTooBigException related changes in HBASE-21875 to > branch-2.1 > -- > > Key: HBASE-21906 > URL: https://issues.apache.org/jira/browse/HBASE-21906 > Project: HBase > Issue Type: Sub-task > Components: proc-v2 >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 2.1.4 > > Attachments: HBASE-21906-branch-2.1.patch, > HBASE-21906-branch-2.1.patch, HBASE-21906-branch-2.1.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Reopened] (HBASE-21943) The usage of RegionLocations.mergeRegionLocations is wrong for async client
[ https://issues.apache.org/jira/browse/HBASE-21943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reopened HBASE-21943: --- Fix 2.1 compile error. > The usage of RegionLocations.mergeRegionLocations is wrong for async client > --- > > Key: HBASE-21943 > URL: https://issues.apache.org/jira/browse/HBASE-21943 > Project: HBase > Issue Type: Bug > Components: asyncclient, Client >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Critical > Fix For: 3.0.0, 2.2.0, 2.0.5, 2.3.0, 2.1.4 > > Attachments: HBASE-21943-UT-v1.patch, HBASE-21943-UT.patch, > HBASE-21943-UT.patch, HBASE-21943-v1.patch, HBASE-21943-v2.patch, > HBASE-21943.patch > > > In AsyncRegionLocatorHelper.mergeRegionLocations we create a new > RegionLocations and call mergeRegionLocations on it, expected that it will be > changed by this method, but actually the method will not modify the object > itself, it will return a new one... > And we are lucky that we create the RegionLocations with the new locations, > so usually we will get update result. But when testing HBASE-21717, we meet > another bug in AsyncNonMetaRegionLocator.isEqual, where we missed a '!' when > checking server name equals... -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21961) Infinite loop in AsyncNonMetaRegionLocator if there is only one region and we tried to locate before a non empty row
[ https://issues.apache.org/jira/browse/HBASE-21961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-21961: -- Status: Patch Available (was: Open) > Infinite loop in AsyncNonMetaRegionLocator if there is only one region and we > tried to locate before a non empty row > > > Key: HBASE-21961 > URL: https://issues.apache.org/jira/browse/HBASE-21961 > Project: HBase > Issue Type: Bug > Components: asyncclient, Client >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Critical > Fix For: 3.0.0, 2.2.0, 2.0.5, 2.3.0, 2.1.4 > > Attachments: HBASE-21961.patch > > > Find this when implementing HBASE-21717, which means it is good that our UTs > for sync client really covers a lot of corner cases. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21961) Infinite loop in AsyncNonMetaRegionLocator if there is only one region and we tried to locate before a non empty row
[ https://issues.apache.org/jira/browse/HBASE-21961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-21961: -- Attachment: HBASE-21961.patch > Infinite loop in AsyncNonMetaRegionLocator if there is only one region and we > tried to locate before a non empty row > > > Key: HBASE-21961 > URL: https://issues.apache.org/jira/browse/HBASE-21961 > Project: HBase > Issue Type: Bug > Components: asyncclient, Client >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Critical > Fix For: 3.0.0, 2.2.0, 2.0.5, 2.3.0, 2.1.4 > > Attachments: HBASE-21961.patch > > > Find this when implementing HBASE-21717, which means it is good that our UTs > for sync client really covers a lot of corner cases. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21962) Filters do not work in ThriftTable
[ https://issues.apache.org/jira/browse/HBASE-21962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allan Yang updated HBASE-21962: --- Attachment: HBASE-21962.patch > Filters do not work in ThriftTable > -- > > Key: HBASE-21962 > URL: https://issues.apache.org/jira/browse/HBASE-21962 > Project: HBase > Issue Type: Sub-task > Components: Thrift >Reporter: Allan Yang >Assignee: Allan Yang >Priority: Major > Fix For: 3.0.0, 2.2.0 > > Attachments: HBASE-21962.patch > > > Filters in ThriftTable is not working, this issue is to fix it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21962) Filters do not work in ThriftTable
[ https://issues.apache.org/jira/browse/HBASE-21962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allan Yang updated HBASE-21962: --- Status: Patch Available (was: In Progress) > Filters do not work in ThriftTable > -- > > Key: HBASE-21962 > URL: https://issues.apache.org/jira/browse/HBASE-21962 > Project: HBase > Issue Type: Sub-task > Components: Thrift >Reporter: Allan Yang >Assignee: Allan Yang >Priority: Major > Fix For: 3.0.0, 2.2.0 > > > Filters in ThriftTable is not working, this issue is to fix it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work started] (HBASE-21962) Filters do not work in ThriftTable
[ https://issues.apache.org/jira/browse/HBASE-21962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-21962 started by Allan Yang. -- > Filters do not work in ThriftTable > -- > > Key: HBASE-21962 > URL: https://issues.apache.org/jira/browse/HBASE-21962 > Project: HBase > Issue Type: Sub-task > Components: Thrift >Reporter: Allan Yang >Assignee: Allan Yang >Priority: Major > Fix For: 3.0.0, 2.2.0 > > > Filters in ThriftTable is not working, this issue is to fix it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21916) Abstract an ByteBuffAllocator to allocate/free ByteBuffer in ByteBufferPool
[ https://issues.apache.org/jira/browse/HBASE-21916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zheng Hu updated HBASE-21916: - Attachment: HBASE-21916.HBASE-21879.v5.patch > Abstract an ByteBuffAllocator to allocate/free ByteBuffer in ByteBufferPool > --- > > Key: HBASE-21916 > URL: https://issues.apache.org/jira/browse/HBASE-21916 > Project: HBase > Issue Type: Sub-task >Reporter: Zheng Hu >Assignee: Zheng Hu >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.1.4 > > Attachments: HBASE-21916.HBASE-21879.v1.patch, > HBASE-21916.HBASE-21879.v2.patch, HBASE-21916.HBASE-21879.v3.patch, > HBASE-21916.HBASE-21879.v3.patch, HBASE-21916.HBASE-21879.v4.patch, > HBASE-21916.HBASE-21879.v5.patch, HBASE-21916.v1.patch, HBASE-21916.v2.patch, > HBASE-21916.v3.patch, HBASE-21916.v4.patch, HBASE-21916.v5.patch > > > Now our read/write path allocate ByteBuffer from the ByteBufferPool, but we > need consider the minSizeForReservoirUse for better utilization, those > allocate/free api are some static methods, not so good to use. > For HBASE-21879, we need an universal ByteBuffer allocator to manage all the > ByteBuffers through the entire read path, so create this issue. > Will upload a patch to abstract an ByteBufAllocator. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21960) RESTServletContainer not configured for REST Jetty server
[
https://issues.apache.org/jira/browse/HBASE-21960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778813#comment-16778813
]
Hadoop QA commented on HBASE-21960:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
14s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 5 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
15s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
45s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
37s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
57s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
21s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
41s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
18s{color} | {color:red} hbase-rest: The patch generated 9 new + 33 unchanged -
9 fixed = 42 total (was 42) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
54s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
9m 33s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4
or 3.0.0. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
55s{color} | {color:red} hbase-rest generated 2 new + 0 unchanged - 0 fixed = 2
total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
19s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 4m
10s{color} | {color:green} hbase-rest in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
10s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 39m 48s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hbase-rest |
| | org.apache.hadoop.hbase.rest.RESTServer.conf isn't final and can't be
protected from malicious code At RESTServer.java:be protected from malicious
code At RESTServer.java:[line 106] |
| | Write to static field org.apache.hadoop.hbase.rest.RESTServer.conf from
instance method new org.apache.hadoop.hbase.rest.RESTServer(Configuration) At
RESTServer.java:from instance method new
org.apache.hadoop.hbase.rest.RESTServer(Configuration) At
RESTServer.java:[line 112] |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
| JIRA Issue | HBASE-21960 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12960268/HBASE-21960.005.patch
|
| Optional Tests | dupname asflicense javac javadoc unit shadedjars
hadoopcheck xml compile findbugs hbaseanti checkstyle |
| uname | Linux 8a3e96228f00 4.4.0-138-generic #164~14.04.1-Ubun
[jira] [Commented] (HBASE-21906) Backport the CallQueueTooBigException related changes in HBASE-21875 to branch-2.1
[
https://issues.apache.org/jira/browse/HBASE-21906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778802#comment-16778802
]
Hadoop QA commented on HBASE-21906:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
32s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} branch-2.1 Compile Tests {color} ||
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 4m
20s{color} | {color:red} root in branch-2.1 failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 2m
32s{color} | {color:red} hbase-server in branch-2.1 failed. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
43s{color} | {color:green} branch-2.1 passed {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 4m
48s{color} | {color:red} branch has 20 errors when building our shaded
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
44s{color} | {color:red} hbase-server in branch-2.1 failed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
30s{color} | {color:green} branch-2.1 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 2m
36s{color} | {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 1m
36s{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 1m 36s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 3m
11s{color} | {color:red} patch has 20 errors when building our shaded
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 1m
56s{color} | {color:red} The patch causes 20 errors with Hadoop v2.7.4. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 3m
51s{color} | {color:red} The patch causes 20 errors with Hadoop v3.0.0. {color}
|
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
32s{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
29s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 47s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
9s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 29m 57s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:42ca976 |
| JIRA Issue | HBASE-21906 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12960270/HBASE-21906-branch-2.1.patch
|
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 3e02d0252def 4.4.0-139-generic #165~14.04.1-Ubuntu SMP Wed Oct
31 10:55:11 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | branch-2.1 / dcc22d3e41 |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| mvninstall |
https://builds.apache.org/job/PreCommit-HBASE-Build/16138/artifact/patchprocess/branch-mvninstall-root.txt
|
| compile |
https://builds.apache.org/job/PreCommit-HBASE-Build/16138/artifact/patchprocess/branch-compi
[jira] [Commented] (HBASE-21820) Implement CLUSTER quota scope
[
https://issues.apache.org/jira/browse/HBASE-21820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778807#comment-16778807
]
Hadoop QA commented on HBASE-21820:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
14s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 5 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
23s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
5s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
13s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source: . {color}
|
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 2m
18s{color} | {color:blue} hbase-server in master has 1 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
33s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 2m
27s{color} | {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 2m
58s{color} | {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 2m 58s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
3s{color} | {color:green} root: The patch generated 0 new + 12 unchanged - 1
fixed = 12 total (was 13) {color} |
| {color:red}-1{color} | {color:red} rubocop {color} | {color:red} 0m
10s{color} | {color:red} The patch generated 16 new + 133 unchanged - 9 fixed =
149 total (was 142) {color} |
| {color:orange}-0{color} | {color:orange} ruby-lint {color} | {color:orange}
0m 10s{color} | {color:orange} The patch generated 46 new + 433 unchanged - 0
fixed = 479 total (was 433) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 3m
14s{color} | {color:red} patch has 396 errors when building our shaded
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 1m
45s{color} | {color:red} The patch causes 396 errors with Hadoop v2.7.4.
{color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 3m
34s{color} | {color:red} The patch causes 396 errors with Hadoop v3.0.0.
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source: . {color}
|
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
35s{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
29s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 12m 15s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
39s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 56m 35s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/
[jira] [Created] (HBASE-21962) Filters do not work in ThriftTable
Allan Yang created HBASE-21962: -- Summary: Filters do not work in ThriftTable Key: HBASE-21962 URL: https://issues.apache.org/jira/browse/HBASE-21962 Project: HBase Issue Type: Sub-task Components: Thrift Reporter: Allan Yang Assignee: Allan Yang Fix For: 3.0.0, 2.2.0 Filters in ThriftTable is not working, this issue is to fix it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (HBASE-21961) Infinite loop in AsyncNonMetaRegionLocator if there is only one region and we tried to locate before a non empty row
Duo Zhang created HBASE-21961: - Summary: Infinite loop in AsyncNonMetaRegionLocator if there is only one region and we tried to locate before a non empty row Key: HBASE-21961 URL: https://issues.apache.org/jira/browse/HBASE-21961 Project: HBase Issue Type: Bug Components: asyncclient, Client Reporter: Duo Zhang Assignee: Duo Zhang Fix For: 3.0.0, 2.2.0, 2.0.5, 2.3.0, 2.1.4 Find this when implementing HBASE-21717, which means it is good that our UTs for sync client really covers a lot of corner cases. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21906) Backport the CallQueueTooBigException related changes in HBASE-21875 to branch-2.1
[ https://issues.apache.org/jira/browse/HBASE-21906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-21906: -- Attachment: HBASE-21906-branch-2.1.patch > Backport the CallQueueTooBigException related changes in HBASE-21875 to > branch-2.1 > -- > > Key: HBASE-21906 > URL: https://issues.apache.org/jira/browse/HBASE-21906 > Project: HBase > Issue Type: Sub-task > Components: proc-v2 >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 2.1.4 > > Attachments: HBASE-21906-branch-2.1.patch, > HBASE-21906-branch-2.1.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21820) Implement CLUSTER quota scope
[ https://issues.apache.org/jira/browse/HBASE-21820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yi Mei updated HBASE-21820: --- Attachment: HBASE-21820.master.007.patch > Implement CLUSTER quota scope > - > > Key: HBASE-21820 > URL: https://issues.apache.org/jira/browse/HBASE-21820 > Project: HBase > Issue Type: Sub-task >Reporter: Yi Mei >Assignee: Yi Mei >Priority: Major > Fix For: 3.0.0, 2.2.0, 2.3.0 > > Attachments: HBASE-21820.master.001.patch, > HBASE-21820.master.002.patch, HBASE-21820.master.003.patch, > HBASE-21820.master.004.patch, HBASE-21820.master.005.patch, > HBASE-21820.master.006.patch, HBASE-21820.master.007.patch > > > There are two kinds of quota scope: CLUSTER and MACHINE. CLUSTER quota means > quota limit is shared by all machines of cluster. MACHINE quota means quota > limit is used by single region server. > Currently, all set quota operations use MACHINE scope as default and CLUSTER > scope has not been implemented. So open this issue to implement CLUSTER quota > scope. > To split cluster quota limit to machines, the basic idea is for user, > namespace, user over namespace quota, use [ClusterLimit / RSNum] as machine > limit. For table and user over table quota, use [ClusterLimit / > TotalTableRegionNum * MachineTableRegionNum] as machine limit. Suggestions > are welcomed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21906) Backport the CallQueueTooBigException related changes in HBASE-21875 to branch-2.1
[ https://issues.apache.org/jira/browse/HBASE-21906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778788#comment-16778788 ] Duo Zhang commented on HBASE-21906: --- Missed this one... > Backport the CallQueueTooBigException related changes in HBASE-21875 to > branch-2.1 > -- > > Key: HBASE-21906 > URL: https://issues.apache.org/jira/browse/HBASE-21906 > Project: HBase > Issue Type: Sub-task > Components: proc-v2 >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 2.1.4 > > Attachments: HBASE-21906-branch-2.1.patch, > HBASE-21906-branch-2.1.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21820) Implement CLUSTER quota scope
[ https://issues.apache.org/jira/browse/HBASE-21820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yi Mei updated HBASE-21820: --- Attachment: (was: HBASE-21820.master.007.patch) > Implement CLUSTER quota scope > - > > Key: HBASE-21820 > URL: https://issues.apache.org/jira/browse/HBASE-21820 > Project: HBase > Issue Type: Sub-task >Reporter: Yi Mei >Assignee: Yi Mei >Priority: Major > Fix For: 3.0.0, 2.2.0, 2.3.0 > > Attachments: HBASE-21820.master.001.patch, > HBASE-21820.master.002.patch, HBASE-21820.master.003.patch, > HBASE-21820.master.004.patch, HBASE-21820.master.005.patch, > HBASE-21820.master.006.patch > > > There are two kinds of quota scope: CLUSTER and MACHINE. CLUSTER quota means > quota limit is shared by all machines of cluster. MACHINE quota means quota > limit is used by single region server. > Currently, all set quota operations use MACHINE scope as default and CLUSTER > scope has not been implemented. So open this issue to implement CLUSTER quota > scope. > To split cluster quota limit to machines, the basic idea is for user, > namespace, user over namespace quota, use [ClusterLimit / RSNum] as machine > limit. For table and user over table quota, use [ClusterLimit / > TotalTableRegionNum * MachineTableRegionNum] as machine limit. Suggestions > are welcomed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21895) Take more care on the error prone plugin and warnings
[ https://issues.apache.org/jira/browse/HBASE-21895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778785#comment-16778785 ] Duo Zhang commented on HBASE-21895: --- OK, seems the output for the error prone is not stable enough? I tried on master, there is no warnings for HMasterCommandLine, but the String.split is still there... And on the error prone guideline, http://errorprone.info/docs/installation It says that for java8 you need to add a bootstrap classpath and use a customized javac, but for us, we added a plexus-compiler-javac-errorprone dependency. Not sure if this is the problem? > Take more care on the error prone plugin and warnings > - > > Key: HBASE-21895 > URL: https://issues.apache.org/jira/browse/HBASE-21895 > Project: HBase > Issue Type: Umbrella >Reporter: Duo Zhang >Priority: Major > > As shown in HBASE-21890 , the error prone warnings are truly useful. > But now, the javac warnings section in the pre commit result is messed up, it > always reports unrelated warnings. Need to take a look at it. > And also, we should try out best to clean up the warnings. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21960) RESTServletContainer not configured for REST Jetty server
[ https://issues.apache.org/jira/browse/HBASE-21960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778784#comment-16778784 ] Josh Elser commented on HBASE-21960: .005 Inadvertently dropped some important config changes for CSRF protections which were chucked into the RESTServer testing utility. > RESTServletContainer not configured for REST Jetty server > - > > Key: HBASE-21960 > URL: https://issues.apache.org/jira/browse/HBASE-21960 > Project: HBase > Issue Type: Bug > Components: REST >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Blocker > Fix For: 3.0.0, 2.2.0, 2.0.5, 2.1.4 > > Attachments: HBASE-21960.001.patch, HBASE-21960.002.patch, > HBASE-21960.003.patch, HBASE-21960.004.patch, HBASE-21960.005.patch > > > The upgrade to Jetty 9 (HBASE-12894) appears to have missed including the > RESTServletContainer as the base servlet for Jetty. Make sure we configure > that class. > I also have some testing to prevent a regression again in the future. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21960) RESTServletContainer not configured for REST Jetty server
[ https://issues.apache.org/jira/browse/HBASE-21960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HBASE-21960: --- Attachment: HBASE-21960.005.patch > RESTServletContainer not configured for REST Jetty server > - > > Key: HBASE-21960 > URL: https://issues.apache.org/jira/browse/HBASE-21960 > Project: HBase > Issue Type: Bug > Components: REST >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Blocker > Fix For: 3.0.0, 2.2.0, 2.0.5, 2.1.4 > > Attachments: HBASE-21960.001.patch, HBASE-21960.002.patch, > HBASE-21960.003.patch, HBASE-21960.004.patch, HBASE-21960.005.patch > > > The upgrade to Jetty 9 (HBASE-12894) appears to have missed including the > RESTServletContainer as the base servlet for Jetty. Make sure we configure > that class. > I also have some testing to prevent a regression again in the future. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21820) Implement CLUSTER quota scope
[ https://issues.apache.org/jira/browse/HBASE-21820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yi Mei updated HBASE-21820: --- Attachment: (was: HBASE-21820.master.007.patch) > Implement CLUSTER quota scope > - > > Key: HBASE-21820 > URL: https://issues.apache.org/jira/browse/HBASE-21820 > Project: HBase > Issue Type: Sub-task >Reporter: Yi Mei >Assignee: Yi Mei >Priority: Major > Fix For: 3.0.0, 2.2.0, 2.3.0 > > Attachments: HBASE-21820.master.001.patch, > HBASE-21820.master.002.patch, HBASE-21820.master.003.patch, > HBASE-21820.master.004.patch, HBASE-21820.master.005.patch, > HBASE-21820.master.006.patch > > > There are two kinds of quota scope: CLUSTER and MACHINE. CLUSTER quota means > quota limit is shared by all machines of cluster. MACHINE quota means quota > limit is used by single region server. > Currently, all set quota operations use MACHINE scope as default and CLUSTER > scope has not been implemented. So open this issue to implement CLUSTER quota > scope. > To split cluster quota limit to machines, the basic idea is for user, > namespace, user over namespace quota, use [ClusterLimit / RSNum] as machine > limit. For table and user over table quota, use [ClusterLimit / > TotalTableRegionNum * MachineTableRegionNum] as machine limit. Suggestions > are welcomed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21820) Implement CLUSTER quota scope
[ https://issues.apache.org/jira/browse/HBASE-21820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yi Mei updated HBASE-21820: --- Attachment: HBASE-21820.master.007.patch > Implement CLUSTER quota scope > - > > Key: HBASE-21820 > URL: https://issues.apache.org/jira/browse/HBASE-21820 > Project: HBase > Issue Type: Sub-task >Reporter: Yi Mei >Assignee: Yi Mei >Priority: Major > Fix For: 3.0.0, 2.2.0, 2.3.0 > > Attachments: HBASE-21820.master.001.patch, > HBASE-21820.master.002.patch, HBASE-21820.master.003.patch, > HBASE-21820.master.004.patch, HBASE-21820.master.005.patch, > HBASE-21820.master.006.patch, HBASE-21820.master.007.patch > > > There are two kinds of quota scope: CLUSTER and MACHINE. CLUSTER quota means > quota limit is shared by all machines of cluster. MACHINE quota means quota > limit is used by single region server. > Currently, all set quota operations use MACHINE scope as default and CLUSTER > scope has not been implemented. So open this issue to implement CLUSTER quota > scope. > To split cluster quota limit to machines, the basic idea is for user, > namespace, user over namespace quota, use [ClusterLimit / RSNum] as machine > limit. For table and user over table quota, use [ClusterLimit / > TotalTableRegionNum * MachineTableRegionNum] as machine limit. Suggestions > are welcomed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21082) Reimplement assign/unassign related procedure metrics
[ https://issues.apache.org/jira/browse/HBASE-21082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778743#comment-16778743 ] Duo Zhang commented on HBASE-21082: --- I think this should be done before we release 2.2.0? [~zghaobac]. As the TRSP stuffs will be shipped in 2.2.0. > Reimplement assign/unassign related procedure metrics > - > > Key: HBASE-21082 > URL: https://issues.apache.org/jira/browse/HBASE-21082 > Project: HBase > Issue Type: Sub-task > Components: amv2, metrics >Reporter: Duo Zhang >Priority: Critical > Fix For: 3.0.0, 2.3.0 > > > As after HBASE-20881, we only have one TRSP procedure to handle all the > assign/unassign/move/reopen operations, we need to reimplement(redefine?) the > metrics for these procedures. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21947) TestShell is broken after we remove the jackson dependencies
[
https://issues.apache.org/jira/browse/HBASE-21947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778689#comment-16778689
]
Hudson commented on HBASE-21947:
Results for branch branch-2.2
[build #69 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/69/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/69//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/69//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/69//JDK8_Nightly_Build_Report_(Hadoop3)/]
(x) {color:red}-1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
-- Something went wrong with this stage, [check relevant console
output|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/69//console].
> TestShell is broken after we remove the jackson dependencies
>
>
> Key: HBASE-21947
> URL: https://issues.apache.org/jira/browse/HBASE-21947
> Project: HBase
> Issue Type: Bug
> Components: dependencies, shell
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.3.0
>
> Attachments: HBASE-21947-v1.patch, HBASE-21947.patch
>
>
> {noformat}
> Error: test_tasksOnHost_should_return_tasks_list(Hbase::TaskMonitorTest):
> NameError: cannot load Java class com.fasterxml.jackson.databind.ObjectMapper
> org/jruby/javasupport/JavaClass.java:286:in `for_name'
> org/jruby/javasupport/JavaUtilities.java:34:in `get_proxy_class'
> uri:classloader:/jruby/java/core_ext/object.rb:49:in `block in java_import'
> org/jruby/RubyArray.java:2486:in `map'
> uri:classloader:/jruby/java/core_ext/object.rb:36:in `java_import'
> /home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests_master-M6IJIUBEFGBLJA2QZFJ5NFMN4UCZCOJZHSKUZTUZSLWEH6TJXWBQ/hbase-shell/src/main/ruby/hbase/taskmonitor.rb:77:in
> `tasksOnHost'
> src/test/ruby/hbase/taskmonitor_test.rb:33:in `block in
> test_tasksOnHost_should_return_tasks_list'
> 30: filter = 'all'
> 31: hosts = admin.getRegionServers()
> 32: hosts.each do |host|
> => 33: tasks = taskmonitor.tasksOnHost(filter,host)
> 34: assert(tasks.length > 0)
> 35: end
> 36: end
> org/jruby/RubyArray.java:1734:in `each'
> src/test/ruby/hbase/taskmonitor_test.rb:32:in `block in
> test_tasksOnHost_should_return_tasks_list'
> {noformat}
> Seems we are using jackson in hbase-shell.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21947) TestShell is broken after we remove the jackson dependencies
[
https://issues.apache.org/jira/browse/HBASE-21947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778645#comment-16778645
]
Hudson commented on HBASE-21947:
Results for branch branch-2
[build #1713 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1713/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1713//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1713//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1713//JDK8_Nightly_Build_Report_(Hadoop3)/]
(x) {color:red}-1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
-- Something went wrong with this stage, [check relevant console
output|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1713//console].
> TestShell is broken after we remove the jackson dependencies
>
>
> Key: HBASE-21947
> URL: https://issues.apache.org/jira/browse/HBASE-21947
> Project: HBase
> Issue Type: Bug
> Components: dependencies, shell
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.3.0
>
> Attachments: HBASE-21947-v1.patch, HBASE-21947.patch
>
>
> {noformat}
> Error: test_tasksOnHost_should_return_tasks_list(Hbase::TaskMonitorTest):
> NameError: cannot load Java class com.fasterxml.jackson.databind.ObjectMapper
> org/jruby/javasupport/JavaClass.java:286:in `for_name'
> org/jruby/javasupport/JavaUtilities.java:34:in `get_proxy_class'
> uri:classloader:/jruby/java/core_ext/object.rb:49:in `block in java_import'
> org/jruby/RubyArray.java:2486:in `map'
> uri:classloader:/jruby/java/core_ext/object.rb:36:in `java_import'
> /home/jenkins/jenkins-slave/workspace/HBase-Flaky-Tests_master-M6IJIUBEFGBLJA2QZFJ5NFMN4UCZCOJZHSKUZTUZSLWEH6TJXWBQ/hbase-shell/src/main/ruby/hbase/taskmonitor.rb:77:in
> `tasksOnHost'
> src/test/ruby/hbase/taskmonitor_test.rb:33:in `block in
> test_tasksOnHost_should_return_tasks_list'
> 30: filter = 'all'
> 31: hosts = admin.getRegionServers()
> 32: hosts.each do |host|
> => 33: tasks = taskmonitor.tasksOnHost(filter,host)
> 34: assert(tasks.length > 0)
> 35: end
> 36: end
> org/jruby/RubyArray.java:1734:in `each'
> src/test/ruby/hbase/taskmonitor_test.rb:32:in `block in
> test_tasksOnHost_should_return_tasks_list'
> {noformat}
> Seems we are using jackson in hbase-shell.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21960) RESTServletContainer not configured for REST Jetty server
[ https://issues.apache.org/jira/browse/HBASE-21960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778630#comment-16778630 ] Josh Elser commented on HBASE-21960: Whew. Over the hurdle now. Looks like these might be valid regressions on my later iterations. Fixing. > RESTServletContainer not configured for REST Jetty server > - > > Key: HBASE-21960 > URL: https://issues.apache.org/jira/browse/HBASE-21960 > Project: HBase > Issue Type: Bug > Components: REST >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Blocker > Fix For: 3.0.0, 2.2.0, 2.0.5, 2.1.4 > > Attachments: HBASE-21960.001.patch, HBASE-21960.002.patch, > HBASE-21960.003.patch, HBASE-21960.004.patch > > > The upgrade to Jetty 9 (HBASE-12894) appears to have missed including the > RESTServletContainer as the base servlet for Jetty. Make sure we configure > that class. > I also have some testing to prevent a regression again in the future. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21960) RESTServletContainer not configured for REST Jetty server
[
https://issues.apache.org/jira/browse/HBASE-21960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778596#comment-16778596
]
Hadoop QA commented on HBASE-21960:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
18s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
46s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
31s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
13s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
11s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
38s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
18s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
35s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
17s{color} | {color:red} hbase-rest: The patch generated 9 new + 31 unchanged -
9 fixed = 40 total (was 40) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
11s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
7m 59s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4
or 3.0.0. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
51s{color} | {color:red} hbase-rest generated 2 new + 0 unchanged - 0 fixed = 2
total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
18s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 7m 41s{color}
| {color:red} hbase-rest in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
9s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 36m 15s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hbase-rest |
| | org.apache.hadoop.hbase.rest.RESTServer.conf isn't final and can't be
protected from malicious code At RESTServer.java:be protected from malicious
code At RESTServer.java:[line 106] |
| | Write to static field org.apache.hadoop.hbase.rest.RESTServer.conf from
instance method new org.apache.hadoop.hbase.rest.RESTServer(Configuration) At
RESTServer.java:from instance method new
org.apache.hadoop.hbase.rest.RESTServer(Configuration) At
RESTServer.java:[line 112] |
| Failed junit tests | hadoop.hbase.rest.TestSchemaResource |
| | hadoop.hbase.rest.TestMultiRowResource |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
| JIRA Issue | HBASE-21960 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12960231/HBASE-21960.004.patch
|
| Optional Tests | dupname asflicense javac javadoc unit shadedjars
hadoopcheck xml compile
[jira] [Commented] (HBASE-21960) RESTServletContainer not configured for REST Jetty server
[ https://issues.apache.org/jira/browse/HBASE-21960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778571#comment-16778571 ] Josh Elser commented on HBASE-21960: .004 At a loss again. Trying to just do proxyuser.user configuration instead of proxyuser.groups configuration. Still passes on both of my boxes. > RESTServletContainer not configured for REST Jetty server > - > > Key: HBASE-21960 > URL: https://issues.apache.org/jira/browse/HBASE-21960 > Project: HBase > Issue Type: Bug > Components: REST >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Blocker > Fix For: 3.0.0, 2.2.0, 2.0.5, 2.1.4 > > Attachments: HBASE-21960.001.patch, HBASE-21960.002.patch, > HBASE-21960.003.patch, HBASE-21960.004.patch > > > The upgrade to Jetty 9 (HBASE-12894) appears to have missed including the > RESTServletContainer as the base servlet for Jetty. Make sure we configure > that class. > I also have some testing to prevent a regression again in the future. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21960) RESTServletContainer not configured for REST Jetty server
[ https://issues.apache.org/jira/browse/HBASE-21960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HBASE-21960: --- Attachment: HBASE-21960.004.patch > RESTServletContainer not configured for REST Jetty server > - > > Key: HBASE-21960 > URL: https://issues.apache.org/jira/browse/HBASE-21960 > Project: HBase > Issue Type: Bug > Components: REST >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Blocker > Fix For: 3.0.0, 2.2.0, 2.0.5, 2.1.4 > > Attachments: HBASE-21960.001.patch, HBASE-21960.002.patch, > HBASE-21960.003.patch, HBASE-21960.004.patch > > > The upgrade to Jetty 9 (HBASE-12894) appears to have missed including the > RESTServletContainer as the base servlet for Jetty. Make sure we configure > that class. > I also have some testing to prevent a regression again in the future. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21935) Replace make_rc.sh with customized spark/dev/create-release
[ https://issues.apache.org/jira/browse/HBASE-21935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778558#comment-16778558 ] stack commented on HBASE-21935: --- bq. This means there'll be an open JIRA with the relevant fix version, no? Yeah. Thats how its been done in past. Need to carry on in this manner or suggest something different bq. Some time ago I set up a nightly test that followed the steps in the book I see. Yeah, would be good to slot this script in if we can. Will look into it. > Replace make_rc.sh with customized spark/dev/create-release > --- > > Key: HBASE-21935 > URL: https://issues.apache.org/jira/browse/HBASE-21935 > Project: HBase > Issue Type: Task > Components: rm >Reporter: stack >Assignee: stack >Priority: Minor > Labels: rm > Attachments: HBASE-21935.branch-2.1.001.patch, > HBASE-21935.branch-2.1.002.patch > > > The spark/dev/create-release is more comprehensive than our hokey make_rc.sh > script. It codifies the bulk of the RM process from tagging, version-setting, > building, signing, and pushing. It does it in a container so environment is > same each time. It has a bunch of spark-specifics as is -- naturally -- but > should be possible to pull it around to suit hbase RM'ing. It'd save a bunch > of time and would allow us to get to a place where RM'ing is canned, > evolvable, and consistent. > I've been hacking on the tooling before the filing of this JIRA and was > polluting branch-2.0 w/ tagging and reverts. Let me make a branch named for > this JIRA to play with (There is a dry-run flag but it too needs work...). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21960) RESTServletContainer not configured for REST Jetty server
[
https://issues.apache.org/jira/browse/HBASE-21960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778549#comment-16778549
]
Hadoop QA commented on HBASE-21960:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
13s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
4s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
33s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
17s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
9s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
41s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
19s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
35s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
16s{color} | {color:red} hbase-rest: The patch generated 4 new + 31 unchanged -
9 fixed = 35 total (was 40) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
12s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
8m 9s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4
or 3.0.0. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
51s{color} | {color:red} hbase-rest generated 2 new + 0 unchanged - 0 fixed = 2
total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
17s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 15m 5s{color}
| {color:red} hbase-rest in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
10s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 44m 15s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hbase-rest |
| | org.apache.hadoop.hbase.rest.RESTServer.conf isn't final and can't be
protected from malicious code At RESTServer.java:be protected from malicious
code At RESTServer.java:[line 106] |
| | Write to static field org.apache.hadoop.hbase.rest.RESTServer.conf from
instance method new org.apache.hadoop.hbase.rest.RESTServer(Configuration) At
RESTServer.java:from instance method new
org.apache.hadoop.hbase.rest.RESTServer(Configuration) At
RESTServer.java:[line 112] |
| Failed junit tests | hadoop.hbase.rest.TestSecureRESTServer |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
| JIRA Issue | HBASE-21960 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12960222/HBASE-21960.003.patch
|
| Optional Tests | dupname asflicense javac javadoc unit shadedjars
hadoopcheck xml compile findbugs hbaseanti checkstyle |
| uname
[jira] [Comment Edited] (HBASE-21935) Replace make_rc.sh with customized spark/dev/create-release
[ https://issues.apache.org/jira/browse/HBASE-21935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778540#comment-16778540 ] Sean Busbey edited comment on HBASE-21935 at 2/26/19 8:15 PM: -- bq. I think us on branch-2 do similar to your practice making a JIRA and then sub-jiras to do each substep (should be less of this w/ this script in place – TODO: write it up). This means there'll be an open JIRA with the relevant fix version, no? bq. What is nightly doing to help out RMing? Some time ago I set up a nightly test that followed the steps in the book, because one time when I went to try to make an RC the steps failed. (I don't remember specifics of the failure any more). here is the start of the test definition on current master: [dev-support/Jenkinsfile line 495|https://github.com/apache/hbase/blob/7377fcd29bf45208214973547facf4853620fba8/dev-support/Jenkinsfile#L495] I only really pay attention to how it's doing for branch-1.2, so I have no idea if it's currently useful for branches-2. was (Author: busbey): bq. I think us on branch-2 do similar to your practice making a JIRA and then sub-jiras to do each substep (should be less of this w/ this script in place – TODO: write it up). This means there'll be an open JIRA with the relevant fix version, no? bq. What is nightly doing to help out RMing? Some time ago I set up a nightly test that followed the steps in the book, because one time when I went to try to make an RC the steps failed. (I don't remember specifics of the failure any more). here is the starts of the test definition: https://github.com/apache/hbase/blob/master/dev-support/Jenkinsfile#L495 I only really pay attention to how it's doing for branch-1.2, so I have no idea if it's currently useful for branches-2. > Replace make_rc.sh with customized spark/dev/create-release > --- > > Key: HBASE-21935 > URL: https://issues.apache.org/jira/browse/HBASE-21935 > Project: HBase > Issue Type: Task > Components: rm >Reporter: stack >Assignee: stack >Priority: Minor > Labels: rm > Attachments: HBASE-21935.branch-2.1.001.patch, > HBASE-21935.branch-2.1.002.patch > > > The spark/dev/create-release is more comprehensive than our hokey make_rc.sh > script. It codifies the bulk of the RM process from tagging, version-setting, > building, signing, and pushing. It does it in a container so environment is > same each time. It has a bunch of spark-specifics as is -- naturally -- but > should be possible to pull it around to suit hbase RM'ing. It'd save a bunch > of time and would allow us to get to a place where RM'ing is canned, > evolvable, and consistent. > I've been hacking on the tooling before the filing of this JIRA and was > polluting branch-2.0 w/ tagging and reverts. Let me make a branch named for > this JIRA to play with (There is a dry-run flag but it too needs work...). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21935) Replace make_rc.sh with customized spark/dev/create-release
[ https://issues.apache.org/jira/browse/HBASE-21935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778540#comment-16778540 ] Sean Busbey commented on HBASE-21935: - bq. I think us on branch-2 do similar to your practice making a JIRA and then sub-jiras to do each substep (should be less of this w/ this script in place – TODO: write it up). This means there'll be an open JIRA with the relevant fix version, no? bq. What is nightly doing to help out RMing? Some time ago I set up a nightly test that followed the steps in the book, because one time when I went to try to make an RC the steps failed. (I don't remember specifics of the failure any more). here is the starts of the test definition: https://github.com/apache/hbase/blob/master/dev-support/Jenkinsfile#L495 I only really pay attention to how it's doing for branch-1.2, so I have no idea if it's currently useful for branches-2. > Replace make_rc.sh with customized spark/dev/create-release > --- > > Key: HBASE-21935 > URL: https://issues.apache.org/jira/browse/HBASE-21935 > Project: HBase > Issue Type: Task > Components: rm >Reporter: stack >Assignee: stack >Priority: Minor > Labels: rm > Attachments: HBASE-21935.branch-2.1.001.patch, > HBASE-21935.branch-2.1.002.patch > > > The spark/dev/create-release is more comprehensive than our hokey make_rc.sh > script. It codifies the bulk of the RM process from tagging, version-setting, > building, signing, and pushing. It does it in a container so environment is > same each time. It has a bunch of spark-specifics as is -- naturally -- but > should be possible to pull it around to suit hbase RM'ing. It'd save a bunch > of time and would allow us to get to a place where RM'ing is canned, > evolvable, and consistent. > I've been hacking on the tooling before the filing of this JIRA and was > polluting branch-2.0 w/ tagging and reverts. Let me make a branch named for > this JIRA to play with (There is a dry-run flag but it too needs work...). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21935) Replace make_rc.sh with customized spark/dev/create-release
[ https://issues.apache.org/jira/browse/HBASE-21935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778528#comment-16778528 ] stack commented on HBASE-21935: --- Thanks for input [~busbey] What is nightly doing to help out RMing? I think us on branch-2 do similar to your practice making a JIRA and then sub-jiras to do each substep (should be less of this w/ this script in place -- TODO: write it up). > Replace make_rc.sh with customized spark/dev/create-release > --- > > Key: HBASE-21935 > URL: https://issues.apache.org/jira/browse/HBASE-21935 > Project: HBase > Issue Type: Task > Components: rm >Reporter: stack >Assignee: stack >Priority: Minor > Labels: rm > Attachments: HBASE-21935.branch-2.1.001.patch, > HBASE-21935.branch-2.1.002.patch > > > The spark/dev/create-release is more comprehensive than our hokey make_rc.sh > script. It codifies the bulk of the RM process from tagging, version-setting, > building, signing, and pushing. It does it in a container so environment is > same each time. It has a bunch of spark-specifics as is -- naturally -- but > should be possible to pull it around to suit hbase RM'ing. It'd save a bunch > of time and would allow us to get to a place where RM'ing is canned, > evolvable, and consistent. > I've been hacking on the tooling before the filing of this JIRA and was > polluting branch-2.0 w/ tagging and reverts. Let me make a branch named for > this JIRA to play with (There is a dry-run flag but it too needs work...). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21935) Replace make_rc.sh with customized spark/dev/create-release
[ https://issues.apache.org/jira/browse/HBASE-21935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778523#comment-16778523 ] Sean Busbey commented on HBASE-21935: - > TODO: Add check that all issues resolved in JIRA before starting? I haven't been tracking how y'all are doing this in branches-2 but in 1.2 land I usually have a "Release 1.2.xx" jira that I use for branch fixups. It's usually open until I have finished all the release steps. How do y'all track that info? > Replace make_rc.sh with customized spark/dev/create-release > --- > > Key: HBASE-21935 > URL: https://issues.apache.org/jira/browse/HBASE-21935 > Project: HBase > Issue Type: Task > Components: rm >Reporter: stack >Assignee: stack >Priority: Minor > Labels: rm > Attachments: HBASE-21935.branch-2.1.001.patch, > HBASE-21935.branch-2.1.002.patch > > > The spark/dev/create-release is more comprehensive than our hokey make_rc.sh > script. It codifies the bulk of the RM process from tagging, version-setting, > building, signing, and pushing. It does it in a container so environment is > same each time. It has a bunch of spark-specifics as is -- naturally -- but > should be possible to pull it around to suit hbase RM'ing. It'd save a bunch > of time and would allow us to get to a place where RM'ing is canned, > evolvable, and consistent. > I've been hacking on the tooling before the filing of this JIRA and was > polluting branch-2.0 w/ tagging and reverts. Let me make a branch named for > this JIRA to play with (There is a dry-run flag but it too needs work...). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21935) Replace make_rc.sh with customized spark/dev/create-release
[ https://issues.apache.org/jira/browse/HBASE-21935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778522#comment-16778522 ] Sean Busbey commented on HBASE-21935: - TODO: update nightly check of RM steps to use this on relevant branches? > Replace make_rc.sh with customized spark/dev/create-release > --- > > Key: HBASE-21935 > URL: https://issues.apache.org/jira/browse/HBASE-21935 > Project: HBase > Issue Type: Task > Components: rm >Reporter: stack >Assignee: stack >Priority: Minor > Labels: rm > Attachments: HBASE-21935.branch-2.1.001.patch, > HBASE-21935.branch-2.1.002.patch > > > The spark/dev/create-release is more comprehensive than our hokey make_rc.sh > script. It codifies the bulk of the RM process from tagging, version-setting, > building, signing, and pushing. It does it in a container so environment is > same each time. It has a bunch of spark-specifics as is -- naturally -- but > should be possible to pull it around to suit hbase RM'ing. It'd save a bunch > of time and would allow us to get to a place where RM'ing is canned, > evolvable, and consistent. > I've been hacking on the tooling before the filing of this JIRA and was > polluting branch-2.0 w/ tagging and reverts. Let me make a branch named for > this JIRA to play with (There is a dry-run flag but it too needs work...). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21960) RESTServletContainer not configured for REST Jetty server
[ https://issues.apache.org/jira/browse/HBASE-21960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HBASE-21960: --- Attachment: HBASE-21960.003.patch > RESTServletContainer not configured for REST Jetty server > - > > Key: HBASE-21960 > URL: https://issues.apache.org/jira/browse/HBASE-21960 > Project: HBase > Issue Type: Bug > Components: REST >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Blocker > Fix For: 3.0.0, 2.2.0, 2.0.5, 2.1.4 > > Attachments: HBASE-21960.001.patch, HBASE-21960.002.patch, > HBASE-21960.003.patch > > > The upgrade to Jetty 9 (HBASE-12894) appears to have missed including the > RESTServletContainer as the base servlet for Jetty. Make sure we configure > that class. > I also have some testing to prevent a regression again in the future. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21820) Implement CLUSTER quota scope
[
https://issues.apache.org/jira/browse/HBASE-21820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778481#comment-16778481
]
Hadoop QA commented on HBASE-21820:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
18s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 5 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
13s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
2s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
3s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
57s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
28s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 2m
34s{color} | {color:blue} hbase-server in master has 1 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
3s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 3m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
33s{color} | {color:green} The patch passed checkstyle in hbase-client {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
13s{color} | {color:green} hbase-server: The patch generated 0 new + 11
unchanged - 1 fixed = 11 total (was 12) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
10s{color} | {color:green} The patch passed checkstyle in hbase-shell {color} |
| {color:red}-1{color} | {color:red} rubocop {color} | {color:red} 0m
11s{color} | {color:red} The patch generated 16 new + 133 unchanged - 9 fixed =
149 total (was 142) {color} |
| {color:orange}-0{color} | {color:orange} ruby-lint {color} | {color:orange}
0m 11s{color} | {color:orange} The patch generated 46 new + 433 unchanged - 0
fixed = 479 total (was 433) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 2669 line(s) that end in whitespace. Use
git apply --whitespace=fix <>. Refer
https://git-scm.com/docs/git-apply {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 1m
26s{color} | {color:red} The patch 300 line(s) with tabs. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
32s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
8m 44s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4
or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
59s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
5s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}132m
1s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit
[jira] [Commented] (HBASE-21960) RESTServletContainer not configured for REST Jetty server
[
https://issues.apache.org/jira/browse/HBASE-21960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778470#comment-16778470
]
Josh Elser commented on HBASE-21960:
{quote}Is this intentional?
{quote}
Yeah, it's silencing all of the stuff sitting behind MiniKDC/Kerby. We care
about it 0%
.003 incoming shortly. Something is different on a real linux box with Hadoop
user lookups. "hard-coding" everythign to be one group fixes it and test passes
for me.
> RESTServletContainer not configured for REST Jetty server
> -
>
> Key: HBASE-21960
> URL: https://issues.apache.org/jira/browse/HBASE-21960
> Project: HBase
> Issue Type: Bug
> Components: REST
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Blocker
> Fix For: 3.0.0, 2.2.0, 2.0.5, 2.1.4
>
> Attachments: HBASE-21960.001.patch, HBASE-21960.002.patch
>
>
> The upgrade to Jetty 9 (HBASE-12894) appears to have missed including the
> RESTServletContainer as the base servlet for Jetty. Make sure we configure
> that class.
> I also have some testing to prevent a regression again in the future.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (HBASE-21666) Break up the TestExportSnapshot UTs; they can timeout
[
https://issues.apache.org/jira/browse/HBASE-21666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778462#comment-16778462
]
Tak Lon (Stephen) Wu edited comment on HBASE-21666 at 2/26/19 6:54 PM:
---
I have done investigation below, and I found the hanging/slow is related to
test node's network setup and local disk issue. I'd like to propose the
solution to be fail fast instead of timeout at 780+ when possible.
First of all, test methods in {{TestExportSnapshot}} contains two phases of
operations, operations in Mini HBase Cluster and operations in Mini MR Cluster,
and we are only snapshotting 50 rows into a test table (the data is very small).
So, the timeout issue is related the followings
1. the building node has an `incorrect` network interface setup such that
a. it hangs the HDFS file operations e.g.
{quote}2019-02-25 22:28:36,099 ERROR [ClientFinalizer-shutdown-hook]
hdfs.DFSClient(949): Failed to close inode 16420
java.io.EOFException: End of File Exception between local host is:
"f45c89a57f29.ant.amazon.com/192.168.1.15"; destination host is:
"localhost":54524; : java.io.EOFException; For more details see:
[http://wiki.apache.org/hadoop/EOFException]
{quote}
b. server (region server or hmaster) cannot be connected or regions cannot
be assigned and kept retrying till timeout, e.g.
{quote}2019-02-26 09:27:54,754 DEBUG
[RpcServer.default.FPBQ.Fifo.handler=4,queue=0,port=57922]
client.RpcRetryingCallerImpl(132): Call exception, tries=10, retries=19,
started=96205 ms ago, cancelled=false, msg=Call to
f45c89a57f29-2.local/10.63.166.57:57926 failed on local exception:
org.apache.hadoop.hbase.ipc.FailedServerException: This server is in the failed
servers list: f45c89a57f29-2.local/10.63.166.57:57926, details=row
'testtb-testExportFileSystemStateWithSkipTmp' on table 'hbase:meta' at
region=hbase:meta,,1.1588230740,
hostname=f45c89a57f29-2.local,57926,1551201763075, seqNum=-1, see
[https://s.apache.org/timeout],
exception=org.apache.hadoop.hbase.ipc.FailedServerException: Call to
f45c89a57f29-2.local/10.63.166.57:57926 failed on local exception:
org.apache.hadoop.hbase.ipc.FailedServerException: This server is in the failed
servers list: f45c89a57f29-2.local/10.63.166.57:57926`
{quote}
2. the building node has an out of disk space issue such node manager is not in
the health state, e.g. I saw from the node manger UI {{1/1 local-dirs are bad:
/yarn/nm; 1/1 log-dirs are bad: /yarn/container-logs}} even if we have set
{{yarn.nodemanager.disk-health-checker.max-disk-utilization-per-disk-percentage}}
to 99%
In above cases, assuming case 1) is an node setup issues (e.g. in
{{/etc/hosts}}) that can be fixed by the infra admin or the contributor who is
running the unit test on their laptop/machine, we don't need to fix it.
for case 2), I'm thinking to set a new value
{{yarn.nodemanager.disk-health-checker.min-free-space-per-disk-mb}} to 128MB
(should be enough for log-dirs and local-dirs) to fail fast when starting the
miniMRCluster by
{{[TestExportSnapshot#setUpBeforeClass|https://github.com/apache/hbase/blob/master/hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/snapshot/TestExportSnapshot.java#L100-L104]}}
instead of timeout for 780+ seconds
In fact, if the building node does not have any of the connections and disk
issues, the average time of running all (7) tests within {{TestExportSnapshot}}
is about 280 seconds and IMO it won't be able to speedup with splitting some of
the test methods into a separate classes and tests of each class are executed
in a sequential order (are we running tests in parallel especially for
{{TestExportSnapshot}} which labeled as {{LargeTests}}? when I tested with
{{mvn test -PrunAllTests -Dtest=TestExportSnapshot}}, I didn't see methods are
running concurrently even if I found the {{surefire.secondPartForkCount=5}} for
{{runAllTests}}, but if anyone confirm it does, we can also separate each
method in {{TestExportSnapshot}} to different classes).
So, if we think disk space issue of YARN's nodemanager should be failed fast
when running tests, proposed code change in
{{HBaseTestingUtility#startMiniMapReduceCluster}} should be as below.
Any comments?
{code:java}
@@ -2736,6 +2736,8 @@ public class HBaseTestingUtility extends
HBaseZKTestingUtility {
conf.setIfUnset(
"yarn.nodemanager.disk-health-checker.max-disk-utilization-per-disk-percentage",
"99.0");
+// Make sure we have enough disk space for log-dirs and local-dirs
+
conf.setIfUnset("yarn.nodemanager.disk-health-checker.min-free-space-per-disk-mb",
"128");
startMiniMapReduceCluster(2);
return mrCluster;
}
{code}
was (Author: taklwu):
I have done investigation below, and I found the hanging/slow is related to
test node's network setup and local disk issue. I'd like to propose the
solution to be
[jira] [Commented] (HBASE-21960) RESTServletContainer not configured for REST Jetty server
[ https://issues.apache.org/jira/browse/HBASE-21960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778451#comment-16778451 ] stack commented on HBASE-21960: --- Took a look. All seems fine. Looks like the hard-won issue of a bunch of trial-and-error. +1 after all tests pass. Nice test. Is this intentional? log4j.logger.org.apache.directory=WARN > RESTServletContainer not configured for REST Jetty server > - > > Key: HBASE-21960 > URL: https://issues.apache.org/jira/browse/HBASE-21960 > Project: HBase > Issue Type: Bug > Components: REST >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Blocker > Fix For: 3.0.0, 2.2.0, 2.0.5, 2.1.4 > > Attachments: HBASE-21960.001.patch, HBASE-21960.002.patch > > > The upgrade to Jetty 9 (HBASE-12894) appears to have missed including the > RESTServletContainer as the base servlet for Jetty. Make sure we configure > that class. > I also have some testing to prevent a regression again in the future. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21666) Break up the TestExportSnapshot UTs; they can timeout
[
https://issues.apache.org/jira/browse/HBASE-21666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778462#comment-16778462
]
Tak Lon (Stephen) Wu commented on HBASE-21666:
--
I have done investigation below, and I found the hanging/slow is related to
test node's network setup and local disk issue. I'd like to propose the
solution to be fail fast instead of timeout at 780+ when possible.
First of all, test methods in {{TestExportSnapshot}} contains two phases of
operations, operations in Mini HBase Cluster and operations in Mini MR Cluster,
and we are only snapshotting 50 rows into a test table (the data is very small).
So, the timeout issue is related the followings
1. the building node has an `incorrect` network interface setup such that
a. it hangs the HDFS file operations e.g.
{quote}2019-02-25 22:28:36,099 ERROR [ClientFinalizer-shutdown-hook]
hdfs.DFSClient(949): Failed to close inode 16420
java.io.EOFException: End of File Exception between local host is:
"f45c89a57f29.ant.amazon.com/192.168.1.15"; destination host is:
"localhost":54524; : java.io.EOFException; For more details see:
[http://wiki.apache.org/hadoop/EOFException]
{quote}
b. server (region server or hmaster) cannot be connected or regions cannot
be assigned and kept retrying till timeout, e.g.
{quote}2019-02-26 09:27:54,754 DEBUG
[RpcServer.default.FPBQ.Fifo.handler=4,queue=0,port=57922]
client.RpcRetryingCallerImpl(132): Call exception, tries=10, retries=19,
started=96205 ms ago, cancelled=false, msg=Call to
f45c89a57f29-2.local/10.63.166.57:57926 failed on local exception:
org.apache.hadoop.hbase.ipc.FailedServerException: This server is in the failed
servers list: f45c89a57f29-2.local/10.63.166.57:57926, details=row
'testtb-testExportFileSystemStateWithSkipTmp' on table 'hbase:meta' at
region=hbase:meta,,1.1588230740,
hostname=f45c89a57f29-2.local,57926,1551201763075, seqNum=-1, see
[https://s.apache.org/timeout],
exception=org.apache.hadoop.hbase.ipc.FailedServerException: Call to
f45c89a57f29-2.local/10.63.166.57:57926 failed on local exception:
org.apache.hadoop.hbase.ipc.FailedServerException: This server is in the failed
servers list: f45c89a57f29-2.local/10.63.166.57:57926`
{quote}
2. the building node has an out of disk space issue such node manager is not in
the health state, e.g. I saw from the node manger UI {{1/1 local-dirs are bad:
/yarn/nm; 1/1 log-dirs are bad: /yarn/container-logs}} even if we have set
{{yarn.nodemanager.disk-health-checker.max-disk-utilization-per-disk-percentage}}
to 99%
In above cases, assuming case 1) is an node setup issues (e.g. in
{{/etc/hosts}}) that can be fixed by the infra admin or the contributor who is
running the unit test on their laptop/machine, we don't need to fix it.
for case 2), I'm thinking to set a new value
{{yarn.nodemanager.disk-health-checker.min-free-space-per-disk-mb}} to 128MB
(should be enough for log-dirs and local-dirs) to fail fast when starting the
miniMRCluster by
{{[TestExportSnapshot#setUpBeforeClass|https://github.com/apache/hbase/blob/master/hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/snapshot/TestExportSnapshot.java#L100-L104]}}
instead of timeout for 780+ seconds
In fact, if the building node does not have any of the connections and disk
issues, the average time of running all tests within {{TestExportSnapshot}} is
about 280 seconds and IMO it won't be able to speedup with splitting some of
the test methods into a separate classes and tests of each class are executed
in a sequential order (are we running tests in parallel especially for
{{TestExportSnapshot}} which labeled as {{LargeTests}}? when I tested with
{{mvn test -PrunAllTests -Dtest=TestExportSnapshot}}, I didn't see methods are
running concurrently even if I found the {{surefire.secondPartForkCount=5}} for
{{runAllTests}}).
So, if we think disk space issue of YARN's nodemanager should be failed fast
when running tests, proposed code change in
{{HBaseTestingUtility#startMiniMapReduceCluster}} should be as below.
Any comments?
{code:java}
@@ -2736,6 +2736,8 @@ public class HBaseTestingUtility extends
HBaseZKTestingUtility {
conf.setIfUnset(
"yarn.nodemanager.disk-health-checker.max-disk-utilization-per-disk-percentage",
"99.0");
+// Make sure we have enough disk space for log-dirs and local-dirs
+
conf.setIfUnset("yarn.nodemanager.disk-health-checker.min-free-space-per-disk-mb",
"128");
startMiniMapReduceCluster(2);
return mrCluster;
}
{code}
> Break up the TestExportSnapshot UTs; they can timeout
> -
>
> Key: HBASE-21666
> URL: https://issues.apache.org/jira/browse/HBASE-21666
> Project: HBase
> Issue Type: Bug
> Components: test
>Reporter: stack
>Assi
[jira] [Commented] (HBASE-21960) RESTServletContainer not configured for REST Jetty server
[ https://issues.apache.org/jira/browse/HBASE-21960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778448#comment-16778448 ] Josh Elser commented on HBASE-21960: I have a first for the first issue, but that uncovers a second where the proxyuser configuration isn't taking effect in the unit test. This passes on my laptop, but it does fail similarly on a linux box that I have. I'm guessing QA will also run into that second issue, so trying to get it passing on my linux box before putting up a third patch. > RESTServletContainer not configured for REST Jetty server > - > > Key: HBASE-21960 > URL: https://issues.apache.org/jira/browse/HBASE-21960 > Project: HBase > Issue Type: Bug > Components: REST >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Blocker > Fix For: 3.0.0, 2.2.0, 2.0.5, 2.1.4 > > Attachments: HBASE-21960.001.patch, HBASE-21960.002.patch > > > The upgrade to Jetty 9 (HBASE-12894) appears to have missed including the > RESTServletContainer as the base servlet for Jetty. Make sure we configure > that class. > I also have some testing to prevent a regression again in the future. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21935) Replace make_rc.sh with customized spark/dev/create-release
[ https://issues.apache.org/jira/browse/HBASE-21935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778456#comment-16778456 ] stack commented on HBASE-21935: --- v2 addresses nice review by [~Apache9] and [~psomogyi] up on rb. Will exercise the script doing the 2.0.5 RC. Waiting on a commit before starting it up. Will update the patch with the fruit of this RM'ing exercise. > Replace make_rc.sh with customized spark/dev/create-release > --- > > Key: HBASE-21935 > URL: https://issues.apache.org/jira/browse/HBASE-21935 > Project: HBase > Issue Type: Task > Components: rm >Reporter: stack >Assignee: stack >Priority: Minor > Labels: rm > Attachments: HBASE-21935.branch-2.1.001.patch, > HBASE-21935.branch-2.1.002.patch > > > The spark/dev/create-release is more comprehensive than our hokey make_rc.sh > script. It codifies the bulk of the RM process from tagging, version-setting, > building, signing, and pushing. It does it in a container so environment is > same each time. It has a bunch of spark-specifics as is -- naturally -- but > should be possible to pull it around to suit hbase RM'ing. It'd save a bunch > of time and would allow us to get to a place where RM'ing is canned, > evolvable, and consistent. > I've been hacking on the tooling before the filing of this JIRA and was > polluting branch-2.0 w/ tagging and reverts. Let me make a branch named for > this JIRA to play with (There is a dry-run flag but it too needs work...). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20724) Sometimes some compacted storefiles are still opened after region failover
[
https://issues.apache.org/jira/browse/HBASE-20724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778441#comment-16778441
]
Hadoop QA commented on HBASE-20724:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
35s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 6 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
31s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
9s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
25s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
45s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
28s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 2m
19s{color} | {color:blue} hbase-server in master has 1 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
59s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
15s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 3m
39s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 1m 59s{color}
| {color:red} hbase-server generated 1 new + 187 unchanged - 1 fixed = 188
total (was 188) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
5s{color} | {color:red} hbase-server: The patch generated 1 new + 63 unchanged
- 3 fixed = 64 total (was 66) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
20s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
8m 32s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4
or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green}
1m 34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
58s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
31s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
27s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}254m 42s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
14s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}314m 13s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.master.TestSplitWALManager |
| | hadoop.hbase.client.TestFromClientSideWithCoprocessor |
| | hadoop.hbase.master.procedure.TestServerCrashProcedureWithReplicas |
| | hadoop.hbas
[jira] [Updated] (HBASE-21935) Replace make_rc.sh with customized spark/dev/create-release
[ https://issues.apache.org/jira/browse/HBASE-21935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-21935: -- Attachment: HBASE-21935.branch-2.1.002.patch > Replace make_rc.sh with customized spark/dev/create-release > --- > > Key: HBASE-21935 > URL: https://issues.apache.org/jira/browse/HBASE-21935 > Project: HBase > Issue Type: Task > Components: rm >Reporter: stack >Assignee: stack >Priority: Minor > Labels: rm > Attachments: HBASE-21935.branch-2.1.001.patch, > HBASE-21935.branch-2.1.002.patch > > > The spark/dev/create-release is more comprehensive than our hokey make_rc.sh > script. It codifies the bulk of the RM process from tagging, version-setting, > building, signing, and pushing. It does it in a container so environment is > same each time. It has a bunch of spark-specifics as is -- naturally -- but > should be possible to pull it around to suit hbase RM'ing. It'd save a bunch > of time and would allow us to get to a place where RM'ing is canned, > evolvable, and consistent. > I've been hacking on the tooling before the filing of this JIRA and was > polluting branch-2.0 w/ tagging and reverts. Let me make a branch named for > this JIRA to play with (There is a dry-run flag but it too needs work...). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21960) RESTServletContainer not configured for REST Jetty server
[
https://issues.apache.org/jira/browse/HBASE-21960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778235#comment-16778235
]
Hadoop QA commented on HBASE-21960:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
12s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
35s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
29s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
41s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
18s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
38s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
16s{color} | {color:red} hbase-rest: The patch generated 12 new + 31 unchanged
- 9 fixed = 43 total (was 40) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
30s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
8m 39s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4
or 3.0.0. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
52s{color} | {color:red} hbase-rest generated 3 new + 0 unchanged - 0 fixed = 3
total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
19s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 1m 36s{color}
| {color:red} hbase-rest in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
9s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 32m 27s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hbase-rest |
| | org.apache.hadoop.hbase.rest.RESTServer.conf isn't final and can't be
protected from malicious code At RESTServer.java:be protected from malicious
code At RESTServer.java:[line 105] |
| | org.apache.hadoop.hbase.rest.RESTServer.SKIP_LOGIN_KEY isn't final but
should be At RESTServer.java:be At RESTServer.java:[line 95] |
| | Write to static field org.apache.hadoop.hbase.rest.RESTServer.conf from
instance method new org.apache.hadoop.hbase.rest.RESTServer(Configuration) At
RESTServer.java:from instance method new
org.apache.hadoop.hbase.rest.RESTServer(Configuration) At
RESTServer.java:[line 111] |
| Failed junit tests | hadoop.hbase.rest.TestSecureRESTServer |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
| JIRA Issue | HBASE-21960 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12960215/HBASE-21960.002.patch
|
|
[jira] [Commented] (HBASE-21960) RESTServletContainer not configured for REST Jetty server
[ https://issues.apache.org/jira/browse/HBASE-21960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778192#comment-16778192 ] Josh Elser commented on HBASE-21960: .002 fixes a missed import. > RESTServletContainer not configured for REST Jetty server > - > > Key: HBASE-21960 > URL: https://issues.apache.org/jira/browse/HBASE-21960 > Project: HBase > Issue Type: Bug > Components: REST >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Blocker > Fix For: 3.0.0, 2.2.0, 2.0.5, 2.1.4 > > Attachments: HBASE-21960.001.patch, HBASE-21960.002.patch > > > The upgrade to Jetty 9 (HBASE-12894) appears to have missed including the > RESTServletContainer as the base servlet for Jetty. Make sure we configure > that class. > I also have some testing to prevent a regression again in the future. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21960) RESTServletContainer not configured for REST Jetty server
[ https://issues.apache.org/jira/browse/HBASE-21960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HBASE-21960: --- Attachment: HBASE-21960.002.patch > RESTServletContainer not configured for REST Jetty server > - > > Key: HBASE-21960 > URL: https://issues.apache.org/jira/browse/HBASE-21960 > Project: HBase > Issue Type: Bug > Components: REST >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Blocker > Fix For: 3.0.0, 2.2.0, 2.0.5, 2.1.4 > > Attachments: HBASE-21960.001.patch, HBASE-21960.002.patch > > > The upgrade to Jetty 9 (HBASE-12894) appears to have missed including the > RESTServletContainer as the base servlet for Jetty. Make sure we configure > that class. > I also have some testing to prevent a regression again in the future. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21960) RESTServletContainer not configured for REST Jetty server
[
https://issues.apache.org/jira/browse/HBASE-21960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778186#comment-16778186
]
Hadoop QA commented on HBASE-21960:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
25s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
43s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
33s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
15s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
3s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
21s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 3m
59s{color} | {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
30s{color} | {color:red} hbase-rest in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 30s{color}
| {color:red} hbase-rest in the patch failed. {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
15s{color} | {color:red} hbase-rest: The patch generated 12 new + 31 unchanged
- 9 fixed = 43 total (was 40) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
3s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
11s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 2m
33s{color} | {color:red} The patch causes 16 errors with Hadoop v2.7.4. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 5m
10s{color} | {color:red} The patch causes 16 errors with Hadoop v3.0.0. {color}
|
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
21s{color} | {color:red} hbase-rest in the patch failed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
18s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 23s{color}
| {color:red} hbase-rest in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
9s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 26m 49s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
| JIRA Issue | HBASE-21960 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12960210/HBASE-21960.001.patch
|
| Optional Tests | dupname asflicense javac javadoc unit shadedjars
hadoopcheck xml compile findbugs hbaseanti checkstyle |
| uname | Linux 36ca420ec00f 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / c33ceb23d3 |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.11 |
| mvninstall |
https://builds.apache.org/job/Pre
[jira] [Updated] (HBASE-21960) RESTServletContainer not configured for REST Jetty server
[ https://issues.apache.org/jira/browse/HBASE-21960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HBASE-21960: --- Description: The upgrade to Jetty 9 (HBASE-12894) appears to have missed including the RESTServletContainer as the base servlet for Jetty. Make sure we configure that class. I also have some testing to prevent a regression again in the future. was: The upgrade to Jetty 9 (HBASE-12894) appears to have missed including the RESTServletContainer in the filterchain for Jetty. Make sure we configure that class. I also have some testing to prevent a regression again in the future. > RESTServletContainer not configured for REST Jetty server > - > > Key: HBASE-21960 > URL: https://issues.apache.org/jira/browse/HBASE-21960 > Project: HBase > Issue Type: Bug > Components: REST >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Blocker > Fix For: 3.0.0, 2.2.0, 2.0.5, 2.1.4 > > Attachments: HBASE-21960.001.patch > > > The upgrade to Jetty 9 (HBASE-12894) appears to have missed including the > RESTServletContainer as the base servlet for Jetty. Make sure we configure > that class. > I also have some testing to prevent a regression again in the future. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21960) RESTServletContainer not configured for REST Jetty server
[ https://issues.apache.org/jira/browse/HBASE-21960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HBASE-21960: --- Attachment: HBASE-21960.001.patch > RESTServletContainer not configured for REST Jetty server > - > > Key: HBASE-21960 > URL: https://issues.apache.org/jira/browse/HBASE-21960 > Project: HBase > Issue Type: Bug > Components: REST >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Blocker > Fix For: 3.0.0, 2.2.0, 2.0.5, 2.1.4 > > Attachments: HBASE-21960.001.patch > > > The upgrade to Jetty 9 (HBASE-12894) appears to have missed including the > RESTServletContainer in the filterchain for Jetty. Make sure we configure > that class. > I also have some testing to prevent a regression again in the future. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21960) RESTServletContainer not configured for REST Jetty server
[ https://issues.apache.org/jira/browse/HBASE-21960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HBASE-21960: --- Status: Patch Available (was: Open) .001 here's a patch to fix the issue. The required change to fix the issue is quite small, but lots of tweaking is required to get RESTServer functional for kerberos-authn unit tests. > RESTServletContainer not configured for REST Jetty server > - > > Key: HBASE-21960 > URL: https://issues.apache.org/jira/browse/HBASE-21960 > Project: HBase > Issue Type: Bug > Components: REST >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Blocker > Fix For: 3.0.0, 2.2.0, 2.0.5, 2.1.4 > > Attachments: HBASE-21960.001.patch > > > The upgrade to Jetty 9 (HBASE-12894) appears to have missed including the > RESTServletContainer in the filterchain for Jetty. Make sure we configure > that class. > I also have some testing to prevent a regression again in the future. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21960) RESTServletContainer not configured for REST Jetty server
[ https://issues.apache.org/jira/browse/HBASE-21960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HBASE-21960: --- Summary: RESTServletContainer not configured for REST Jetty server (was: AuthFilter not configured for REST Jetty server) > RESTServletContainer not configured for REST Jetty server > - > > Key: HBASE-21960 > URL: https://issues.apache.org/jira/browse/HBASE-21960 > Project: HBase > Issue Type: Bug > Components: REST >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Blocker > Fix For: 3.0.0, 2.2.0, 2.0.5, 2.1.4 > > > The upgrade to Jetty 9 (HBASE-12894) appears to have missed including the > AuthFilter in the filterchain for Jetty. Make sure we configure that class. > I also have some testing to prevent a regression again in the future. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
