[jira] [Commented] (HBASE-22208) Create access checker and expose it in RS
[ https://issues.apache.org/jira/browse/HBASE-22208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16817204#comment-16817204 ] Guanghao Zhang commented on HBASE-22208: For 004 patch, need add @Override for method in NoopAccessChecker and no need to add methods' javadoc comment? But need one class's javadoc comment. And the accessChecker may be null in AccessController? > Create access checker and expose it in RS > - > > Key: HBASE-22208 > URL: https://issues.apache.org/jira/browse/HBASE-22208 > Project: HBase > Issue Type: Sub-task >Reporter: Yi Mei >Assignee: Yi Mei >Priority: Major > Attachments: HBASE-22208.master.001.patch, > HBASE-22208.master.002.patch, HBASE-22208.master.003.patch, > HBASE-22208.master.004.patch > > > In HBase access control service, access checker performs authorization checks > for a given user's assigned permissions. The access checker holds a auth > manager instance which cache all global, namespace and table permissions. > A access checker is created when master, RS and region load AccessController, > permission cache is refreshed when acl znode changed. > We can create access checker when master and RS start and expose it in order > to use procedure to refresh its cache rather than watch ZK. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21048) Get LogLevel is not working from console in secure environment
[
https://issues.apache.org/jira/browse/HBASE-21048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wei-Chiu Chuang updated HBASE-21048:
Attachment: HBASE-21048.branch-1.001.patch
> Get LogLevel is not working from console in secure environment
> --
>
> Key: HBASE-21048
> URL: https://issues.apache.org/jira/browse/HBASE-21048
> Project: HBase
> Issue Type: Bug
>Reporter: Chandra Sekhar
>Assignee: Wei-Chiu Chuang
>Priority: Major
> Labels: security
> Attachments: HBASE-21048.001.patch, HBASE-21048.branch-1.001.patch,
> HBASE-21048.master.001.patch, HBASE-21048.master.002.patch,
> HBASE-21048.master.003.patch, HBASE-21048.master.004.patch,
> HBASE-21048.master.005.patch, HBASE-21048.master.006.patch,
> HBASE-21048.master.007.patch, HBASE-21048.master.008.patch
>
>
> When we try to get log level of specific package in secure environment,
> getting SocketException.
> {code:java}
> hbase/master/bin# ./hbase org.apache.hadoop.hbase.http.log.LogLevel -getlevel
> host-:16010 org.apache.hadoop.hbase
> Connecting to http://host-:16010/logLevel?log=org.apache.hadoop.hbase
> java.net.SocketException: Unexpected end of file from server
> {code}
> It is trying to connect http instead of https
> code snippet that handling only http in *LogLevel.java*
> {code:java}
> public static void main(String[] args) {
> if (args.length == 3 && "-getlevel".equals(args[0])) {
> process("http://"; + args[1] + "/logLevel?log=" + args[2]);
> return;
> }
> else if (args.length == 4 && "-setlevel".equals(args[0])) {
> process("http://"; + args[1] + "/logLevel?log=" + args[2]
> + "&level=" + args[3]);
> return;
> }
> System.err.println(USAGES);
> System.exit(-1);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21048) Get LogLevel is not working from console in secure environment
[
https://issues.apache.org/jira/browse/HBASE-21048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16817202#comment-16817202
]
Wei-Chiu Chuang commented on HBASE-21048:
-
Attach branch-1 patch for precommit.
> Get LogLevel is not working from console in secure environment
> --
>
> Key: HBASE-21048
> URL: https://issues.apache.org/jira/browse/HBASE-21048
> Project: HBase
> Issue Type: Bug
>Reporter: Chandra Sekhar
>Assignee: Wei-Chiu Chuang
>Priority: Major
> Labels: security
> Attachments: HBASE-21048.001.patch, HBASE-21048.branch-1.001.patch,
> HBASE-21048.master.001.patch, HBASE-21048.master.002.patch,
> HBASE-21048.master.003.patch, HBASE-21048.master.004.patch,
> HBASE-21048.master.005.patch, HBASE-21048.master.006.patch,
> HBASE-21048.master.007.patch, HBASE-21048.master.008.patch
>
>
> When we try to get log level of specific package in secure environment,
> getting SocketException.
> {code:java}
> hbase/master/bin# ./hbase org.apache.hadoop.hbase.http.log.LogLevel -getlevel
> host-:16010 org.apache.hadoop.hbase
> Connecting to http://host-:16010/logLevel?log=org.apache.hadoop.hbase
> java.net.SocketException: Unexpected end of file from server
> {code}
> It is trying to connect http instead of https
> code snippet that handling only http in *LogLevel.java*
> {code:java}
> public static void main(String[] args) {
> if (args.length == 3 && "-getlevel".equals(args[0])) {
> process("http://"; + args[1] + "/logLevel?log=" + args[2]);
> return;
> }
> else if (args.length == 4 && "-setlevel".equals(args[0])) {
> process("http://"; + args[1] + "/logLevel?log=" + args[2]
> + "&level=" + args[3]);
> return;
> }
> System.err.println(USAGES);
> System.exit(-1);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22192) Delete misc 2.0.5 pom files from branch-2.1
[
https://issues.apache.org/jira/browse/HBASE-22192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16817198#comment-16817198
]
Hudson commented on HBASE-22192:
Results for branch branch-2.1
[build #1051 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1051/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1051//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1051//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1051//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Delete misc 2.0.5 pom files from branch-2.1
> ---
>
> Key: HBASE-22192
> URL: https://issues.apache.org/jira/browse/HBASE-22192
> Project: HBase
> Issue Type: Task
> Components: community
>Affects Versions: 2.1.4, 2.1.5
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Minor
> Fix For: 2.1.5
>
>
> there are a bunch of 2.0.5 pom files in dev-support/create-release
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21048) Get LogLevel is not working from console in secure environment
[
https://issues.apache.org/jira/browse/HBASE-21048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16817179#comment-16817179
]
Wei-Chiu Chuang commented on HBASE-21048:
-
[~reidchan] thanks for the extra work!
It looks like if you cherry pick HBASE-19762
(fc6e3fc9d7781efec6cd142d135a1b339081aa24), you can cherry pick this commit
from master to branch-2, conflict-free.
> Get LogLevel is not working from console in secure environment
> --
>
> Key: HBASE-21048
> URL: https://issues.apache.org/jira/browse/HBASE-21048
> Project: HBase
> Issue Type: Bug
>Reporter: Chandra Sekhar
>Assignee: Wei-Chiu Chuang
>Priority: Major
> Labels: security
> Attachments: HBASE-21048.001.patch, HBASE-21048.master.001.patch,
> HBASE-21048.master.002.patch, HBASE-21048.master.003.patch,
> HBASE-21048.master.004.patch, HBASE-21048.master.005.patch,
> HBASE-21048.master.006.patch, HBASE-21048.master.007.patch,
> HBASE-21048.master.008.patch
>
>
> When we try to get log level of specific package in secure environment,
> getting SocketException.
> {code:java}
> hbase/master/bin# ./hbase org.apache.hadoop.hbase.http.log.LogLevel -getlevel
> host-:16010 org.apache.hadoop.hbase
> Connecting to http://host-:16010/logLevel?log=org.apache.hadoop.hbase
> java.net.SocketException: Unexpected end of file from server
> {code}
> It is trying to connect http instead of https
> code snippet that handling only http in *LogLevel.java*
> {code:java}
> public static void main(String[] args) {
> if (args.length == 3 && "-getlevel".equals(args[0])) {
> process("http://"; + args[1] + "/logLevel?log=" + args[2]);
> return;
> }
> else if (args.length == 4 && "-setlevel".equals(args[0])) {
> process("http://"; + args[1] + "/logLevel?log=" + args[2]
> + "&level=" + args[3]);
> return;
> }
> System.err.println(USAGES);
> System.exit(-1);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22020) upgrade to yetus 0.9.0
[
https://issues.apache.org/jira/browse/HBASE-22020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16817174#comment-16817174
]
Hudson commented on HBASE-22020:
Results for branch HBASE-22020
[build #11 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22020/11/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22020/11//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22020/11//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22020/11//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> upgrade to yetus 0.9.0
> --
>
> Key: HBASE-22020
> URL: https://issues.apache.org/jira/browse/HBASE-22020
> Project: HBase
> Issue Type: Task
> Components: build, community
>Reporter: stack
>Assignee: Sean Busbey
>Priority: Major
> Attachments: HBASE-22020-branch-1.v1.patch, HBASE-22020.0.patch,
> HBASE-22020.1.patch
>
>
> branch-1/jdk7 checkstyle dtd xml parse complaint; "script engine for language
> js can not be found"
> See parent for some context. Checkstyle references dtds that were hosted on
> puppycrawl, then on sourceforge up until ten days ago. Nightlies are failing
> for among other reasons, complaint that there is bad xml in the build...
> notably, the unresolvable DTDs.
> I'd just update the DTDs but there is a need for a js engine some where and
> openjdk7 doesn't ship with one (openjdk8 does). That needs addressing and
> then we can backport the parent issue...
> See
> https://builds.apache.org/view/H-L/view/HBase/job/HBase%20Nightly/job/branch-1/710/artifact/output-general/xml.txt
> ... which in case its rolled away, is filled with this message:
> "script engine for language js can not be found"
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-15547) Balancer should take into account number of PENDING_OPEN regions
[ https://issues.apache.org/jira/browse/HBASE-15547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-15547: Fix Version/s: (was: 1.5.0) > Balancer should take into account number of PENDING_OPEN regions > > > Key: HBASE-15547 > URL: https://issues.apache.org/jira/browse/HBASE-15547 > Project: HBase > Issue Type: Improvement > Components: Balancer, Operability, Region Assignment >Affects Versions: 0.98.0, 1.0.0 >Reporter: Sean Busbey >Priority: Critical > > We recently had a cluster get into a bad state where a subset of region > servers consistently could not open new regions (but could continue serving > the regions they already hosted). > Recovering the cluster was just a matter of restarting region servers in > sequence. However, this led to things getting substantially worse before they > got better since the bulk assigner continued to place an uniform number of > recovered regions across all servers, including onto those that could not > open regions. > It would be useful if the balancer could penalize regionservers with a > backlog of pending_open regions and place more work on those regionservers > that are properly serving. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-15547) Balancer should take into account number of PENDING_OPEN regions
[ https://issues.apache.org/jira/browse/HBASE-15547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16817168#comment-16817168 ] Sean Busbey commented on HBASE-15547: - I think this is still relevant, and I suspect just differently relevant to each branch. For example regions in state "OPENING" in branch-2 should have the same impact. > Balancer should take into account number of PENDING_OPEN regions > > > Key: HBASE-15547 > URL: https://issues.apache.org/jira/browse/HBASE-15547 > Project: HBase > Issue Type: Improvement > Components: Balancer, Operability, Region Assignment >Affects Versions: 0.98.0, 1.0.0 >Reporter: Sean Busbey >Priority: Critical > Fix For: 1.5.0 > > > We recently had a cluster get into a bad state where a subset of region > servers consistently could not open new regions (but could continue serving > the regions they already hosted). > Recovering the cluster was just a matter of restarting region servers in > sequence. However, this led to things getting substantially worse before they > got better since the bulk assigner continued to place an uniform number of > recovered regions across all servers, including onto those that could not > open regions. > It would be useful if the balancer could penalize regionservers with a > backlog of pending_open regions and place more work on those regionservers > that are properly serving. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21965) Fix failed split and merge transactions that have failed to roll back
[ https://issues.apache.org/jira/browse/HBASE-21965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16817164#comment-16817164 ] Sean Busbey commented on HBASE-21965: - bq. but for branch-2.1, we use different procedures to assign/unassign regions so maybe it is not straight-forward. how will we account for this in the hbck2 tooling? > Fix failed split and merge transactions that have failed to roll back > - > > Key: HBASE-21965 > URL: https://issues.apache.org/jira/browse/HBASE-21965 > Project: HBase > Issue Type: Sub-task > Components: hbck2 >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Fix For: 3.0.0, 2.3.0 > > Attachments: HBASE-21965.master.001.patch, > HBASE-21965.master.002.patch, HBASE-21965.master.003.patch, > HBASE-21965.master.004.patch, HBASE-21965.master.005.patch, > HBASE-21965.master.006.patch, HBASE-21965.master.007.patch, > HBASE-21965.master.007.patch, HBASE-21965.master.008.patch, > HBASE-21965.master.009.patch, HBASE-21965.master.010.patch, > HBASE-21965.master.011.patch, HBASE-21965.master.012.patch, > HBASE-21965.master.013.patch, HBASE-21965.master.014.patch, > HBASE-21965.master.014.patch > > > Make HBCK2 be able to fix failed split and merge transactions that have > failed to roll back. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-12081) Considering Java 9
[ https://issues.apache.org/jira/browse/HBASE-12081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16817163#comment-16817163 ] Sean Busbey commented on HBASE-12081: - I think we should close out our "considering Java 9 / 10" jiras and just put the relevant sub-tasks under JDK11, given the existing community discussion about only aiming for working with LTS releases. > Considering Java 9 > -- > > Key: HBASE-12081 > URL: https://issues.apache.org/jira/browse/HBASE-12081 > Project: HBase > Issue Type: Umbrella >Reporter: Andrew Purtell >Priority: Major > Fix For: 3.0.0 > > > Java 9 will ship in 2016. This will be the first Java release that makes a > significant compatibility departure from earlier runtimes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (HBASE-18639) nightly jobs that need to do jdk7 + jdk8 need more than 6 hours
[ https://issues.apache.org/jira/browse/HBASE-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey resolved HBASE-18639. - Resolution: Later Fix Version/s: (was: 1.5.0) these have been pretty consistent at ~6-7 hours to complete. in any case I changed the timeouts a while ago so this issue is OBE. > nightly jobs that need to do jdk7 + jdk8 need more than 6 hours > --- > > Key: HBASE-18639 > URL: https://issues.apache.org/jira/browse/HBASE-18639 > Project: HBase > Issue Type: Task > Components: test >Reporter: Sean Busbey >Priority: Major > Labels: beginner > > looks like the branches that need to do 2 jdks will need more than 6 hours, > at least until we can parallelize things. > e.g. > * > [branch-1.2|https://builds.apache.org/view/H-L/view/HBase/job/HBase%20Nightly/job/branch-1.2/buildTimeTrend] > * > [branch-1.3|https://builds.apache.org/view/H-L/view/HBase/job/HBase%20Nightly/job/branch-1.3/buildTimeTrend] > branch-1.4 and branch-1 are failing in jdk7 checks, so they don't go that > long yet, but once we get those tests fixed presumably they'll need the time > as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20586) SyncTable tool: Add support for cross-realm remote clusters
[
https://issues.apache.org/jira/browse/HBASE-20586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16817157#comment-16817157
]
Sean Busbey commented on HBASE-20586:
-
sure, sounds fine to me.
> SyncTable tool: Add support for cross-realm remote clusters
> ---
>
> Key: HBASE-20586
> URL: https://issues.apache.org/jira/browse/HBASE-20586
> Project: HBase
> Issue Type: Improvement
> Components: mapreduce, Operability, Replication
>Affects Versions: 1.2.0, 2.0.0
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.3.0
>
> Attachments: HBASE-20586.master.001.patch
>
>
> One possible scenario for HashTable/SyncTable is for synchronize different
> clusters, for instance, when replication has been enabled but data existed
> already, or due replication issues that may had caused long lags in the
> replication.
> For secured clusters under different kerberos realms (with cross-realm
> properly set), though, current SyncTable version would fail to authenticate
> with the remote cluster when trying to read HashTable outputs (when
> *sourcehashdir* is remote) and also when trying to read table data on the
> remote cluster (when *sourcezkcluster* is remote).
> The hdfs error would look like this:
> {noformat}
> INFO mapreduce.Job: Task Id : attempt_1524358175778_105392_m_00_0, Status
> : FAILED
> Error: java.io.IOException: Failed on local exception: java.io.IOException:
> org.apache.hadoop.security.AccessControlException: Client cannot authenticate
> via:[TOKEN, KERBEROS]; Host Details : local host is: "local-host/1.1.1.1";
> destination host is: "remote-nn":8020;
> at org.apache.hadoop.net.NetUtils.wrapException(NetUtils.java:772)
> at org.apache.hadoop.ipc.Client.call(Client.java:1506)
> at org.apache.hadoop.ipc.Client.call(Client.java:1439)
> at
> org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:230)
> at com.sun.proxy.$Proxy13.getBlockLocations(Unknown Source)
> at
> org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.getBlockLocations(ClientNamenodeProtocolTranslatorPB.java:256)
> ...
> at
> org.apache.hadoop.hbase.mapreduce.HashTable$TableHash.readPropertiesFile(HashTable.java:144)
> at
> org.apache.hadoop.hbase.mapreduce.HashTable$TableHash.read(HashTable.java:105)
> at
> org.apache.hadoop.hbase.mapreduce.SyncTable$SyncMapper.setup(SyncTable.java:188)
> at org.apache.hadoop.mapreduce.Mapper.run(Mapper.java:142)
> ...
> Caused by: java.io.IOException:
> org.apache.hadoop.security.AccessControlException: Client cannot authenticate
> via:[TOKEN, KERBEROS]{noformat}
> The above can be sorted if the SyncTable job acquires a DT for the remote NN.
> Once hdfs related authentication is done, it's also necessary to authenticate
> against remote HBase, as the below error would arise:
> {noformat}
> INFO mapreduce.Job: Task Id : attempt_1524358175778_172414_m_00_0, Status
> : FAILED
> Error: org.apache.hadoop.hbase.client.RetriesExhaustedException: Can't get
> the location
> at
> org.apache.hadoop.hbase.client.RpcRetryingCallerWithReadReplicas.getRegionLocations(RpcRetryingCallerWithReadReplicas.java:326)
> ...
> at org.apache.hadoop.hbase.client.HTable.getScanner(HTable.java:867)
> at
> org.apache.hadoop.hbase.mapreduce.SyncTable$SyncMapper.syncRange(SyncTable.java:331)
> ...
> Caused by: java.io.IOException: Could not set up IO Streams to
> remote-rs-host/1.1.1.2:60020
> at
> org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection.setupIOstreams(RpcClientImpl.java:786)
> ...
> Caused by: java.lang.RuntimeException: SASL authentication failed. The most
> likely cause is missing or invalid credentials. Consider 'kinit'.
> ...
> Caused by: GSSException: No valid credentials provided (Mechanism level:
> Failed to find any Kerberos tgt)
> ...{noformat}
> The above would need additional authentication logic against the remote hbase
> cluster.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-17984) Document guidance on deleting data under %hbase%/.hbck
[
https://issues.apache.org/jira/browse/HBASE-17984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16817156#comment-16817156
]
Sean Busbey commented on HBASE-17984:
-
I think this would still be a really good addition to our docs. I don't know
why it would need to be scheduled against some release.
> Document guidance on deleting data under %hbase%/.hbck
> --
>
> Key: HBASE-17984
> URL: https://issues.apache.org/jira/browse/HBASE-17984
> Project: HBase
> Issue Type: Improvement
> Components: documentation, hbck
>Reporter: Sean Busbey
>Priority: Major
>
> Per user questions on the mailing list, we ought to document things to
> consider when cleaning up data sitting in the {{.hbck}} directory under
> /hbase.
> [reference email thread on
> user@hbase|https://lists.apache.org/thread.html/6c21b5b85378d4a70c3de413c1034c2bfe1a81d71eb73146eb53c9cc@%3Cuser.hbase.apache.org%3E]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-17984) Document guidance on deleting data under %hbase%/.hbck
[
https://issues.apache.org/jira/browse/HBASE-17984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey updated HBASE-17984:
Fix Version/s: (was: 1.5.0)
> Document guidance on deleting data under %hbase%/.hbck
> --
>
> Key: HBASE-17984
> URL: https://issues.apache.org/jira/browse/HBASE-17984
> Project: HBase
> Issue Type: Improvement
> Components: documentation, hbck
>Reporter: Sean Busbey
>Priority: Major
>
> Per user questions on the mailing list, we ought to document things to
> consider when cleaning up data sitting in the {{.hbck}} directory under
> /hbase.
> [reference email thread on
> user@hbase|https://lists.apache.org/thread.html/6c21b5b85378d4a70c3de413c1034c2bfe1a81d71eb73146eb53c9cc@%3Cuser.hbase.apache.org%3E]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-18162) Backport 'Update jruby to a newer version' to branch-1
[ https://issues.apache.org/jira/browse/HBASE-18162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16817154#comment-16817154 ] Sean Busbey commented on HBASE-18162: - Other than needing to be some branch-1 I don't think it needs to be scheduled. No assignee means there is very likely to be no progress. "branch-1 needs a newer jruby" has come up a few times in other places but no one ever seems to be hindered enough to invest the time. > Backport 'Update jruby to a newer version' to branch-1 > -- > > Key: HBASE-18162 > URL: https://issues.apache.org/jira/browse/HBASE-18162 > Project: HBase > Issue Type: Task > Components: dependencies, shell >Affects Versions: 1.4.0 >Reporter: Sean Busbey >Priority: Major > Fix For: 1.5.0 > > > Work on HBASE-16196 ran into shell failures while attempting a branch-1 > backport. > Start from either the attempted backport or the master branch version. Work > out what's different in branch-1 that causes TestShell to fail. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22206) dist.apache.org must not be used for public downloads
[ https://issues.apache.org/jira/browse/HBASE-22206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16817150#comment-16817150 ] Sean Busbey commented on HBASE-22206: - the site failure is HBASE-2. we can't build the site after this patch until that change goes in anyways, so we might as well wait for this fix until we can verify it. > dist.apache.org must not be used for public downloads > - > > Key: HBASE-22206 > URL: https://issues.apache.org/jira/browse/HBASE-22206 > Project: HBase > Issue Type: Bug > Components: website >Reporter: Sebb >Assignee: Dima Spivak >Priority: Major > Attachments: HBASE-22206.master.001.patch, > HBASE-22206.master.001.patch > > > The dist.apache.org server is only intended for use by developers in staging > releases. > It must not be used on public download pages. > Please use www.apache.org/dist (for KEYS, hashes and sigs) and the mirror > system instead. > The current download page has lots of references to dist.a.o; please replace > thes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22235) OperationStatus.{SUCCESS|FAILURE|NOT_RUN} are not visible to 3rd party coprocessors
[
https://issues.apache.org/jira/browse/HBASE-22235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lars Hofhansl updated HBASE-22235:
--
Description:
preBatchMutate is useless for some operation due to this.
See also TEPHRA-299. This looks like an oversight.
MiniBatchOperationInProgress has limited visibility for coprocessors.
OperationStatus and OperationStatusCode should have the same.
was:
This looks like an oversight.
preBatchMutate is useless for some operation due to this.
See also TEPHRA-299. This looks like an oversight.
MiniBatchOperationInProgress has limited visibility for coprocessors.
OperationStatus and OperationStatusCode should have the same.
> OperationStatus.{SUCCESS|FAILURE|NOT_RUN} are not visible to 3rd party
> coprocessors
> ---
>
> Key: HBASE-22235
> URL: https://issues.apache.org/jira/browse/HBASE-22235
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors
>Reporter: Lars Hofhansl
>Priority: Major
>
> preBatchMutate is useless for some operation due to this.
> See also TEPHRA-299. This looks like an oversight.
> MiniBatchOperationInProgress has limited visibility for coprocessors.
> OperationStatus and OperationStatusCode should have the same.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (HBASE-22235) OperationStatus.{SUCCESS|FAILURE|NOT_RUN} are not visible to 3rd party coprocessors
Lars Hofhansl created HBASE-22235:
-
Summary: OperationStatus.{SUCCESS|FAILURE|NOT_RUN} are not visible
to 3rd party coprocessors
Key: HBASE-22235
URL: https://issues.apache.org/jira/browse/HBASE-22235
Project: HBase
Issue Type: Bug
Components: Coprocessors
Reporter: Lars Hofhansl
This looks like an oversight.
preBatchMutate is useless for some operation due to this.
See also TEPHRA-299. This looks like an oversight.
MiniBatchOperationInProgress has limited visibility for coprocessors.
OperationStatus and OperationStatusCode should have the same.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22233) [hbase-thirdparty] Add error prone annotations dependency explicitly and do not relocate it
[ https://issues.apache.org/jira/browse/HBASE-22233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16817071#comment-16817071 ] Peter Somogyi commented on HBASE-22233: --- Attached a PR with the listed com.google.* packages excluding leaving out com.google.errorprone. Checked the content of hbase-shaded-miscellaneous jar, the errorprone related imports are still under com.google.errorprone and the errorprone classes are not part of the uber jar. Site build succeeds, but I haven't ran a full test suit using the new thirdparty. > [hbase-thirdparty] Add error prone annotations dependency explicitly and do > not relocate it > --- > > Key: HBASE-22233 > URL: https://issues.apache.org/jira/browse/HBASE-22233 > Project: HBase > Issue Type: Sub-task > Components: thirdparty >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: thirdparty-2.2.1 > > Attachments: HBASE-22233.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22233) [hbase-thirdparty] Add error prone annotations dependency explicitly and do not relocate it
[ https://issues.apache.org/jira/browse/HBASE-22233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16817067#comment-16817067 ] Peter Somogyi commented on HBASE-22233: --- The exclude patterns under relocation block don't seem to work. I tried to modify it but in the generated jar file the package names for errorprone moved to o.a.h.t. I did not find better way but to list the packages under com.google under relocations. Would it be a bug in shade plugin? > [hbase-thirdparty] Add error prone annotations dependency explicitly and do > not relocate it > --- > > Key: HBASE-22233 > URL: https://issues.apache.org/jira/browse/HBASE-22233 > Project: HBase > Issue Type: Sub-task > Components: thirdparty >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: thirdparty-2.2.1 > > Attachments: HBASE-22233.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (HBASE-22192) Delete misc 2.0.5 pom files from branch-2.1
[ https://issues.apache.org/jira/browse/HBASE-22192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey resolved HBASE-22192. - Resolution: Fixed > Delete misc 2.0.5 pom files from branch-2.1 > --- > > Key: HBASE-22192 > URL: https://issues.apache.org/jira/browse/HBASE-22192 > Project: HBase > Issue Type: Task > Components: community >Affects Versions: 2.1.4, 2.1.5 >Reporter: Sean Busbey >Assignee: Sean Busbey >Priority: Minor > Fix For: 2.1.5 > > > there are a bunch of 2.0.5 pom files in dev-support/create-release -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [hbase] busbey merged pull request #132: HBASE-22192 Delete misc 2.0.5 pom files from branch-2.1
busbey merged pull request #132: HBASE-22192 Delete misc 2.0.5 pom files from branch-2.1 URL: https://github.com/apache/hbase/pull/132 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22233) [hbase-thirdparty] Add error prone annotations dependency explicitly and do not relocate it
[ https://issues.apache.org/jira/browse/HBASE-22233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16817037#comment-16817037 ] Peter Somogyi commented on HBASE-22233: --- I checked the content of the hbase-shaded-miscellaneous after applied your patch but the annotation specific imports in the classes are incorrect. 2 examples: hbase-shaded-miscellaneous-2.2.1-SNAPSHOT-sources.jar!/org/apache/hbase/thirdparty/com/google/common/hash/AbstractHashFunction.java import *org.apache.hbase.thirdparty.*com.google.errorprone.annotations.Immutable; hbase-shaded-miscellaneous-2.2.1-SNAPSHOT-sources.jar!/org/apache/hbase/thirdparty/com/google/protobuf/util/Timestamps.java import *org.apache.hbase.thirdparty.*com.google.errorprone.annotations.CanIgnoreReturnValue; The errorprone classes are not added to the jars either with the com.google nor the o.a.h.t.com.google package. > [hbase-thirdparty] Add error prone annotations dependency explicitly and do > not relocate it > --- > > Key: HBASE-22233 > URL: https://issues.apache.org/jira/browse/HBASE-22233 > Project: HBase > Issue Type: Sub-task > Components: thirdparty >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: thirdparty-2.2.1 > > Attachments: HBASE-22233.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [hbase] Apache-HBase commented on issue #146: HBASE-21257 misspelled words.[occured -> occurred]
Apache-HBase commented on issue #146: HBASE-21257 misspelled words.[occured -> occurred] URL: https://github.com/apache/hbase/pull/146#issuecomment-482850616 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 25 | Docker mode activated. | ||| _ Prechecks _ | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 26 | Maven dependency ordering for branch | | +1 | mvninstall | 263 | master passed | | +1 | compile | 107 | master passed | | +1 | checkstyle | 95 | master passed | | +1 | shadedjars | 275 | branch has no errors when building our shaded downstream artifacts. | | +1 | findbugs | 231 | master passed | | +1 | javadoc | 69 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 15 | Maven dependency ordering for patch | | +1 | mvninstall | 251 | the patch passed | | +1 | compile | 110 | the patch passed | | +1 | javac | 110 | the patch passed | | +1 | checkstyle | 98 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 280 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 527 | Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. | | +1 | findbugs | 250 | the patch passed | | +1 | javadoc | 65 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 8840 | hbase-server in the patch passed. | | +1 | unit | 70 | hbase-it in the patch passed. | | +1 | unit | 260 | hbase-rest in the patch passed. | | +1 | asflicense | 88 | The patch does not generate ASF License warnings. | | | | 12045 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-146/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/146 | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 6eb425996922 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | master / 16146a1839 | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.11 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-146/1/testReport/ | | Max. process+thread count | 4922 (vs. ulimit of 1) | | modules | C: hbase-server hbase-it hbase-rest U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-146/1/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-21257) misspelled words.[occured -> occurred]
[
https://issues.apache.org/jira/browse/HBASE-21257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16817010#comment-16817010
]
HBase QA commented on HBASE-21257:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
23s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
1s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
46s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
55s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
1s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
5s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
38s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
0s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
37s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
8m 46s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4
or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
58s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}139m
21s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
58s{color} | {color:green} hbase-it in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
47s{color} | {color:green} hbase-rest in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
6s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}191m 7s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/PreCommit-HBASE-Build/79/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-21257 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12965808/HBASE-21257.master.0001.patch
|
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux c2a522fb8d6a 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb
13 15:00:41 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | m
[jira] [Commented] (HBASE-22200) WALSplitter.hasRecoveredEdits should use same FS instance from WAL region dir
[
https://issues.apache.org/jira/browse/HBASE-22200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816994#comment-16816994
]
Wei-Chiu Chuang commented on HBASE-22200:
-
If WAL and root are on different file system, FileSystem cache could cause out
of memory for the WAL file system. (HADOOP-13971)
(fs.SCHEME.impl.disable.cache, SCHEME=s3,hdfs) Many downstreamers disable the
cache as a workaround.
Currently it seems only the file system cache of hfile is disabled, which is
fine as long as the HFile and WAL use the same fs.
> WALSplitter.hasRecoveredEdits should use same FS instance from WAL region dir
> -
>
> Key: HBASE-22200
> URL: https://issues.apache.org/jira/browse/HBASE-22200
> Project: HBase
> Issue Type: Bug
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Major
> Labels: S3, WAL
> Attachments: HBASE-22200-branch-2.1-001.patch,
> HBASE-22200-branch-2.1-002.patch, HBASE-22200-branch-2.1-003.patch,
> HBASE-22200-master-001.patch, HBASE-22200-master-002.patch
>
>
> *WALSplitter.hasRecoveredEdits* should use same FS instance from WAL region
> dir when checking for recovered.edits files, instead of taking FS instance as
> additional method parameter. When specifying different file systems for *wal
> dir* and *root dir*, *WALSplitter.hasRecoveredEdits* current implementation
> will crash or give wrong results. As of now, it's being used indirectly by
> *SplitTableRegionProcedure*. When running tests with *WAL dir* on HDFS and
> *root dir* on S3, for example, noticed region split failing with below error:
> {noformat}
> 2019-04-08 13:53:58,064 ERROR
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor: CODE-BUG: Uncaught
> runtime exception: pid=98,
> state=RUNNABLE:SPLIT_TABLE_REGIONS_CHECK_CLOSED_REGIONS, locked=true;
> SplitTableRegionProcedure table=test-tbl,
> parent=4c5db01611e97e3abbe02e781e867212,
> daughterA=28a0a5e4ef7618899f6bd6dfb5335fe7,
> daughterB=05fa26feaf03ebf9e87e099cbd1eabac
> java.lang.IllegalArgumentException: Path
> hdfs://host-1.example.com:8020/wal_dir/default/test-tbl/4c5db01611e97e3abbe02e781e867212/recovered.edits
> scheme must be s3a
> at
> com.google.common.base.Preconditions.checkArgument(Preconditions.java:115)
> at
> org.apache.hadoop.fs.s3a.s3guard.DynamoDBMetadataStore.checkPath(DynamoDBMetadataStore.java:1127)
> at
> org.apache.hadoop.fs.s3a.s3guard.DynamoDBMetadataStore.get(DynamoDBMetadataStore.java:437)
> at
> org.apache.hadoop.fs.s3a.S3AFileSystem.innerGetFileStatus(S3AFileSystem.java:2110)
> at
> org.apache.hadoop.fs.s3a.S3AFileSystem.getFileStatus(S3AFileSystem.java:2088)
> at
> org.apache.hadoop.fs.FilterFileSystem.getFileStatus(FilterFileSystem.java:442)
> at org.apache.hadoop.fs.FileSystem.exists(FileSystem.java:1668)
> at
> org.apache.hadoop.hbase.wal.WALSplitter.getSplitEditFilesSorted(WALSplitter.java:576)
> at
> org.apache.hadoop.hbase.wal.WALSplitter.hasRecoveredEdits(WALSplitter.java:558)
> at
> org.apache.hadoop.hbase.master.assignment.SplitTableRegionProcedure.hasRecoveredEdits(SplitTableRegionProcedure.java:148)
> at
> org.apache.hadoop.hbase.master.assignment.SplitTableRegionProcedure.executeFromState(SplitTableRegionProcedure.java:255)
> {noformat}
> Since *WALSplitter.hasRecoveredEdits* already resolves the proper WAL dir for
> the region, we can simply re-use FS instance from the path instance for the
> WAL dir region, when searching for recovered.edits.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (HBASE-22200) WALSplitter.hasRecoveredEdits should use same FS instance from WAL region dir
[
https://issues.apache.org/jira/browse/HBASE-22200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816994#comment-16816994
]
Wei-Chiu Chuang edited comment on HBASE-22200 at 4/13/19 4:04 PM:
--
Probably unrelated, but worth noting for s3 root project.
If WAL and root are on different file system, FileSystem cache could cause out
of memory for the WAL file system. (HADOOP-13971)
(fs.SCHEME.impl.disable.cache, SCHEME=s3,hdfs) Many downstreamers disable the
cache as a workaround.
Currently it seems only the file system cache of hfile is disabled, which is
fine as long as the HFile and WAL use the same fs.
was (Author: jojochuang):
If WAL and root are on different file system, FileSystem cache could cause out
of memory for the WAL file system. (HADOOP-13971)
(fs.SCHEME.impl.disable.cache, SCHEME=s3,hdfs) Many downstreamers disable the
cache as a workaround.
Currently it seems only the file system cache of hfile is disabled, which is
fine as long as the HFile and WAL use the same fs.
> WALSplitter.hasRecoveredEdits should use same FS instance from WAL region dir
> -
>
> Key: HBASE-22200
> URL: https://issues.apache.org/jira/browse/HBASE-22200
> Project: HBase
> Issue Type: Bug
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Major
> Labels: S3, WAL
> Attachments: HBASE-22200-branch-2.1-001.patch,
> HBASE-22200-branch-2.1-002.patch, HBASE-22200-branch-2.1-003.patch,
> HBASE-22200-master-001.patch, HBASE-22200-master-002.patch
>
>
> *WALSplitter.hasRecoveredEdits* should use same FS instance from WAL region
> dir when checking for recovered.edits files, instead of taking FS instance as
> additional method parameter. When specifying different file systems for *wal
> dir* and *root dir*, *WALSplitter.hasRecoveredEdits* current implementation
> will crash or give wrong results. As of now, it's being used indirectly by
> *SplitTableRegionProcedure*. When running tests with *WAL dir* on HDFS and
> *root dir* on S3, for example, noticed region split failing with below error:
> {noformat}
> 2019-04-08 13:53:58,064 ERROR
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor: CODE-BUG: Uncaught
> runtime exception: pid=98,
> state=RUNNABLE:SPLIT_TABLE_REGIONS_CHECK_CLOSED_REGIONS, locked=true;
> SplitTableRegionProcedure table=test-tbl,
> parent=4c5db01611e97e3abbe02e781e867212,
> daughterA=28a0a5e4ef7618899f6bd6dfb5335fe7,
> daughterB=05fa26feaf03ebf9e87e099cbd1eabac
> java.lang.IllegalArgumentException: Path
> hdfs://host-1.example.com:8020/wal_dir/default/test-tbl/4c5db01611e97e3abbe02e781e867212/recovered.edits
> scheme must be s3a
> at
> com.google.common.base.Preconditions.checkArgument(Preconditions.java:115)
> at
> org.apache.hadoop.fs.s3a.s3guard.DynamoDBMetadataStore.checkPath(DynamoDBMetadataStore.java:1127)
> at
> org.apache.hadoop.fs.s3a.s3guard.DynamoDBMetadataStore.get(DynamoDBMetadataStore.java:437)
> at
> org.apache.hadoop.fs.s3a.S3AFileSystem.innerGetFileStatus(S3AFileSystem.java:2110)
> at
> org.apache.hadoop.fs.s3a.S3AFileSystem.getFileStatus(S3AFileSystem.java:2088)
> at
> org.apache.hadoop.fs.FilterFileSystem.getFileStatus(FilterFileSystem.java:442)
> at org.apache.hadoop.fs.FileSystem.exists(FileSystem.java:1668)
> at
> org.apache.hadoop.hbase.wal.WALSplitter.getSplitEditFilesSorted(WALSplitter.java:576)
> at
> org.apache.hadoop.hbase.wal.WALSplitter.hasRecoveredEdits(WALSplitter.java:558)
> at
> org.apache.hadoop.hbase.master.assignment.SplitTableRegionProcedure.hasRecoveredEdits(SplitTableRegionProcedure.java:148)
> at
> org.apache.hadoop.hbase.master.assignment.SplitTableRegionProcedure.executeFromState(SplitTableRegionProcedure.java:255)
> {noformat}
> Since *WALSplitter.hasRecoveredEdits* already resolves the proper WAL dir for
> the region, we can simply re-use FS instance from the path instance for the
> WAL dir region, when searching for recovered.edits.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] Apache-HBase commented on issue #144: HBASE-22232 Removed deprecated methods in CompareFilter
Apache-HBase commented on issue #144: HBASE-22232 Removed deprecated methods in CompareFilter URL: https://github.com/apache/hbase/pull/144#issuecomment-482822320 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 24 | Docker mode activated. | ||| _ Prechecks _ | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 15 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 27 | Maven dependency ordering for branch | | +1 | mvninstall | 259 | master passed | | +1 | compile | 172 | master passed | | +1 | checkstyle | 172 | master passed | | +1 | shadedjars | 270 | branch has no errors when building our shaded downstream artifacts. | | +1 | findbugs | 432 | master passed | | +1 | javadoc | 117 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 14 | Maven dependency ordering for patch | | +1 | mvninstall | 262 | the patch passed | | +1 | compile | 170 | the patch passed | | +1 | javac | 170 | the patch passed | | -1 | checkstyle | 34 | hbase-client: The patch generated 2 new + 188 unchanged - 52 fixed = 190 total (was 240) | | -1 | checkstyle | 68 | hbase-server: The patch generated 4 new + 113 unchanged - 12 fixed = 117 total (was 125) | | +1 | checkstyle | 17 | hbase-mapreduce: The patch generated 0 new + 47 unchanged - 2 fixed = 47 total (was 49) | | +1 | checkstyle | 31 | The patch passed checkstyle in hbase-thrift | | +1 | checkstyle | 18 | hbase-rest: The patch generated 0 new + 242 unchanged - 3 fixed = 242 total (was 245) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 271 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 524 | Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. | | +1 | findbugs | 455 | the patch passed | | +1 | javadoc | 121 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 198 | hbase-client in the patch passed. | | +1 | unit | 8531 | hbase-server in the patch passed. | | -1 | unit | 958 | hbase-mapreduce in the patch failed. | | +1 | unit | 212 | hbase-thrift in the patch passed. | | +1 | unit | 284 | hbase-rest in the patch passed. | | +1 | asflicense | 175 | The patch does not generate ASF License warnings. | | | | 13960 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.snapshot.TestExportSnapshotNoCluster | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-144/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/144 | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 3a14f3078894 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | master / 16146a1839 | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.11 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-144/1/artifact/out/diff-checkstyle-hbase-client.txt | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-144/1/artifact/out/diff-checkstyle-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-144/1/artifact/out/patch-unit-hbase-mapreduce.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-144/1/testReport/ | | Max. process+thread count | 5431 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-rest U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-144/1/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-21512) Introduce an AsyncClusterConnection and replace the usage of ClusterConnection
[
https://issues.apache.org/jira/browse/HBASE-21512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816980#comment-16816980
]
Hudson commented on HBASE-21512:
Results for branch HBASE-21512
[build #175 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21512/175/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21512/175//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21512/175//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21512/175//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Introduce an AsyncClusterConnection and replace the usage of ClusterConnection
> --
>
> Key: HBASE-21512
> URL: https://issues.apache.org/jira/browse/HBASE-21512
> Project: HBase
> Issue Type: Umbrella
>Reporter: Duo Zhang
>Priority: Major
> Fix For: 3.0.0
>
>
> At least for the RSProcedureDispatcher, with CompletableFuture we do not need
> to set a delay and use a thread pool any more, which could reduce the
> resource usage and also the latency.
> Once this is done, I think we can remove the ClusterConnection completely,
> and start to rewrite the old sync client based on the async client, which
> could reduce the code base a lot for our client.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22222) Site build fails after hbase-thirdparty upgrade
[
https://issues.apache.org/jira/browse/HBASE-2?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816971#comment-16816971
]
stack commented on HBASE-2:
---
bq. won't this mean that at runtime our thirdparty library will have a
dependency on error prone?
At User API javadoc building time, not at 'runtime' .
bq. What I still don't get is why only userapi reportSet requires the
error_prone_annotations dependency.
I don't know. I'd think adding the thirdparty package to the excludes building
javadoc should have taken care of our issue (but I've not had much luck w/ this
excludes facility building javadoc in the past so not surprised it not working).
bq. Not fully understand here. So we shade the error prone annotation in
hbase-shaded-miscellaneous, but the javadoc plugin will try to load the
unshaded version of error prone annotation?
Pardon me. What [~psomogyi] said. The original error reported by Peter above
complains that the shaded Immutable can't be found (because errorprone is not
in thirdparty -- but because of its package name, references to errorprone
classes are rewritten -- shaded -- in thirdparty). After fixing thirdparty so
as to NOT shade immutable, the javadoc building fails again because errorprone
is not on the classpath at javadoc build time.
bq. Maybe we should just add it back, but do not shade it?
Yeah, thats what the fix proposal does.
[~Apache9]'s change over in HBASE-22233 is better than mine. It is more
generic. Once its in I can roll a thirdparty RC.
> Site build fails after hbase-thirdparty upgrade
> ---
>
> Key: HBASE-2
> URL: https://issues.apache.org/jira/browse/HBASE-2
> Project: HBase
> Issue Type: Bug
> Components: website
>Affects Versions: 3.0.0, 2.2.0
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Critical
> Fix For: 3.0.0
>
> Attachments: HBASE-2.patch
>
>
> After hbase-thirdparty upgrade the hbase_generate_website job is failing in
> mvn site target on javadoc.
>
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.7.1:site (default-site) on
> project hbase: Error generating maven-javadoc-plugin:3.0.1:aggregate report:
> [ERROR] Exit code: 1 -
> /home/jenkins/jenkins-slave/workspace/hbase_generate_website/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java:1034:
> warning - Tag @link: can't find tagsIterator(Cell) in
> org.apache.hadoop.hbase.CellUtil
> [ERROR] javadoc: error - class file for
> org.apache.hbase.thirdparty.com.google.errorprone.annotations.Immutable not
> found{noformat}
> After reverting thirdparty upgrade locally the site build passed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22233) [hbase-thirdparty] Add error prone annotations dependency explicitly and do not relocate it
[ https://issues.apache.org/jira/browse/HBASE-22233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816970#comment-16816970 ] stack commented on HBASE-22233: --- Ok. This is more radical than what I had. It is better. More generic. There are other excludes of CanIgnoreReturnValue in other poms in thirdparty. You want to add this change to the other poms too? Thanks [~Apache9]. Once committed, I can roll an RC. > [hbase-thirdparty] Add error prone annotations dependency explicitly and do > not relocate it > --- > > Key: HBASE-22233 > URL: https://issues.apache.org/jira/browse/HBASE-22233 > Project: HBase > Issue Type: Sub-task > Components: thirdparty >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: thirdparty-2.2.1 > > Attachments: HBASE-22233.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21257) misspelled words.[occured -> occurred]
[ https://issues.apache.org/jira/browse/HBASE-21257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816964#comment-16816964 ] zhanggangxue commented on HBASE-21257: -- A patch file has been added to correspond to [PR#146|[https://github.com/apache/hbase/pull/146]]. For various reasons, PR[[#91|[https://github.com/apache/hbase/pull/91]] has been closed, and the code is not merged into the master branch, so the patch should also be invalid. Please use the new patch file [HBASE-21257.master.0001.patch] and the new PR[[#146|[https://github.com/apache/hbase/pull/146]]. > misspelled words.[occured -> occurred] > -- > > Key: HBASE-21257 > URL: https://issues.apache.org/jira/browse/HBASE-21257 > Project: HBase > Issue Type: Bug >Reporter: zhanggangxue >Assignee: zhanggangxue >Priority: Trivial > Labels: occured, occurred, typo > Attachments: 0001-misspelled-words.-occured-occurred.patch, > HBASE-21257.master.0001.patch > > > I found some spelling errors on the master Branch.Found in [misspelled > words|https://github.com/apache/hbase/pull/91] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [hbase] gangxueZhang commented on issue #91: HBASE-21257 misspelled words.[occured -> occurred]
gangxueZhang commented on issue #91: HBASE-21257 misspelled words.[occured -> occurred] URL: https://github.com/apache/hbase/pull/91#issuecomment-482813506 @Apache9 Hey, this PR has been closed by me, and a new [PR#146](https://github.com/apache/hbase/pull/146) has been created to replace it. If there is no problem, please merge the changes in [PR#146](https://github.com/apache/hbase/pull/146). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] gangxueZhang opened a new pull request #146: HBASE-21257 misspelled words.[occured -> occurred]
gangxueZhang opened a new pull request #146: HBASE-21257 misspelled words.[occured -> occurred] URL: https://github.com/apache/hbase/pull/146 This PR is used to replace [PR#91](https://github.com/apache/hbase/pull/91). The modification only involves spelling errors in the words in the comments, and does not affect the program function. [PR#91](https://github.com/apache/hbase/pull/91) will be closed and the modified content will not be merged into the master branch. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22193) Add backoff when region failed open too many times
[
https://issues.apache.org/jira/browse/HBASE-22193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816953#comment-16816953
]
Hudson commented on HBASE-22193:
Results for branch branch-2
[build #1818 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1818/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1818//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1818//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1818//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Add backoff when region failed open too many times
> --
>
> Key: HBASE-22193
> URL: https://issues.apache.org/jira/browse/HBASE-22193
> Project: HBase
> Issue Type: Improvement
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.3.0
>
>
>
> {code:java}
> public static final String ASSIGN_MAX_ATTEMPTS =
> "hbase.assignment.maximum.attempts";
> private static final int DEFAULT_ASSIGN_MAX_ATTEMPTS = Integer.MAX_VALUE;
> {code}
> Now the default config is Integer.MAX_VALUE.
>
> {code:java}
> 2019-04-09,10:50:44,921 INFO
> org.apache.hadoop.hbase.master.assignment.TransitRegionStateProcedure:
> Retry=170813 of max=2147483647; pid=2849, ppid=2846,
> state=RUNNABLE:REGION_STATE_TRANSITION_CONFIRM_OPENED, locked=true;
> TransitRegionStateProcedure table=IntegrationTestBigLinkedList,
> region=634feb79a583480597e1843647d11228, REOPEN/MOVE; rit=OPENING,
> location=c4-hadoop-tst-st26.bj,29100,1554262369262
> {code}
> The ITBLL failed to open the region as HBASE-22163 and retry 170813 to
> reopen. After I fixed the problem and restart master, I found it need take a
> long time to init the old procedure logs because there are too many old
> logs...
> Code in WALProcedureStore,java.
>
> {code:java}
> private long initOldLogs(FileStatus[] logFiles) throws IOException {
> if (logFiles == null || logFiles.length == 0) {
> return 0L;
> }
> long maxLogId = 0;
> for (int i = 0; i < logFiles.length; ++i) {
> final Path logPath = logFiles[i].getPath();
> leaseRecovery.recoverFileLease(fs, logPath);
> if (!isRunning()) {
> throw new IOException("wal aborting");
> }
> maxLogId = Math.max(maxLogId, getLogIdFromName(logPath.getName()));
> ProcedureWALFile log = initOldLog(logFiles[i], this.walArchiveDir);
> if (log != null) {
> this.logs.add(log);
> }
> }
> initTrackerFromOldLogs();
> return maxLogId;
> }
> {code}
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] gangxueZhang closed pull request #91: HBASE-21257 misspelled words.[occured -> occurred]
gangxueZhang closed pull request #91: HBASE-21257 misspelled words.[occured -> occurred] URL: https://github.com/apache/hbase/pull/91 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22233) [hbase-thirdparty] Add error prone annotations dependency explicitly and do not relocate it
[ https://issues.apache.org/jira/browse/HBASE-22233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816952#comment-16816952 ] Duo Zhang commented on HBASE-22233: --- Ping [~stack] [~psomogyi]. > [hbase-thirdparty] Add error prone annotations dependency explicitly and do > not relocate it > --- > > Key: HBASE-22233 > URL: https://issues.apache.org/jira/browse/HBASE-22233 > Project: HBase > Issue Type: Sub-task > Components: thirdparty >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: thirdparty-2.2.1 > > Attachments: HBASE-22233.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (HBASE-22234) Fix flaky TestHbck#testRecoverSplitAfterMetaUpdated
Jingyun Tian created HBASE-22234: Summary: Fix flaky TestHbck#testRecoverSplitAfterMetaUpdated Key: HBASE-22234 URL: https://issues.apache.org/jira/browse/HBASE-22234 Project: HBase Issue Type: Bug Reporter: Jingyun Tian -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (HBASE-22234) Fix flaky TestHbck#testRecoverSplitAfterMetaUpdated
[ https://issues.apache.org/jira/browse/HBASE-22234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian reassigned HBASE-22234: Assignee: Jingyun Tian > Fix flaky TestHbck#testRecoverSplitAfterMetaUpdated > --- > > Key: HBASE-22234 > URL: https://issues.apache.org/jira/browse/HBASE-22234 > Project: HBase > Issue Type: Bug >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21257) misspelled words.[occured -> occurred]
[ https://issues.apache.org/jira/browse/HBASE-21257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhanggangxue updated HBASE-21257: - Attachment: HBASE-21257.master.0001.patch > misspelled words.[occured -> occurred] > -- > > Key: HBASE-21257 > URL: https://issues.apache.org/jira/browse/HBASE-21257 > Project: HBase > Issue Type: Bug >Reporter: zhanggangxue >Assignee: zhanggangxue >Priority: Trivial > Labels: occured, occurred, typo > Attachments: 0001-misspelled-words.-occured-occurred.patch, > HBASE-21257.master.0001.patch > > > I found some spelling errors on the master Branch.Found in [misspelled > words|https://github.com/apache/hbase/pull/91] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22233) [hbase-thirdparty] Add error prone annotations dependency explicitly and do not relocate it
[ https://issues.apache.org/jira/browse/HBASE-22233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816951#comment-16816951 ] Duo Zhang commented on HBASE-22233: --- Also upgrade protobuf to 3.7.1. > [hbase-thirdparty] Add error prone annotations dependency explicitly and do > not relocate it > --- > > Key: HBASE-22233 > URL: https://issues.apache.org/jira/browse/HBASE-22233 > Project: HBase > Issue Type: Sub-task > Components: thirdparty >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: thirdparty-2.2.1 > > Attachments: HBASE-22233.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22222) Site build fails after hbase-thirdparty upgrade
[
https://issues.apache.org/jira/browse/HBASE-2?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816950#comment-16816950
]
Duo Zhang commented on HBASE-2:
---
The patch can only be applied after we release thirdparty 2.2.1.
> Site build fails after hbase-thirdparty upgrade
> ---
>
> Key: HBASE-2
> URL: https://issues.apache.org/jira/browse/HBASE-2
> Project: HBase
> Issue Type: Bug
> Components: website
>Affects Versions: 3.0.0, 2.2.0
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Critical
> Fix For: 3.0.0
>
> Attachments: HBASE-2.patch
>
>
> After hbase-thirdparty upgrade the hbase_generate_website job is failing in
> mvn site target on javadoc.
>
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.7.1:site (default-site) on
> project hbase: Error generating maven-javadoc-plugin:3.0.1:aggregate report:
> [ERROR] Exit code: 1 -
> /home/jenkins/jenkins-slave/workspace/hbase_generate_website/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java:1034:
> warning - Tag @link: can't find tagsIterator(Cell) in
> org.apache.hadoop.hbase.CellUtil
> [ERROR] javadoc: error - class file for
> org.apache.hbase.thirdparty.com.google.errorprone.annotations.Immutable not
> found{noformat}
> After reverting thirdparty upgrade locally the site build passed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22222) Site build fails after hbase-thirdparty upgrade
[
https://issues.apache.org/jira/browse/HBASE-2?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-2:
--
Attachment: HBASE-2.patch
> Site build fails after hbase-thirdparty upgrade
> ---
>
> Key: HBASE-2
> URL: https://issues.apache.org/jira/browse/HBASE-2
> Project: HBase
> Issue Type: Bug
> Components: website
>Affects Versions: 3.0.0, 2.2.0
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Critical
> Fix For: 3.0.0
>
> Attachments: HBASE-2.patch
>
>
> After hbase-thirdparty upgrade the hbase_generate_website job is failing in
> mvn site target on javadoc.
>
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.7.1:site (default-site) on
> project hbase: Error generating maven-javadoc-plugin:3.0.1:aggregate report:
> [ERROR] Exit code: 1 -
> /home/jenkins/jenkins-slave/workspace/hbase_generate_website/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java:1034:
> warning - Tag @link: can't find tagsIterator(Cell) in
> org.apache.hadoop.hbase.CellUtil
> [ERROR] javadoc: error - class file for
> org.apache.hbase.thirdparty.com.google.errorprone.annotations.Immutable not
> found{noformat}
> After reverting thirdparty upgrade locally the site build passed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (HBASE-22233) [hbase-thirdparty] Add error prone annotations dependency explicitly and do not relocate it
[ https://issues.apache.org/jira/browse/HBASE-22233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-22233: - Assignee: Duo Zhang > [hbase-thirdparty] Add error prone annotations dependency explicitly and do > not relocate it > --- > > Key: HBASE-22233 > URL: https://issues.apache.org/jira/browse/HBASE-22233 > Project: HBase > Issue Type: Sub-task > Components: thirdparty >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: thirdparty-2.2.1 > > Attachments: HBASE-22233.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22233) [hbase-thirdparty] Add error prone annotations dependency explicitly and do not relocate it
[ https://issues.apache.org/jira/browse/HBASE-22233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22233: -- Attachment: HBASE-22233.patch > [hbase-thirdparty] Add error prone annotations dependency explicitly and do > not relocate it > --- > > Key: HBASE-22233 > URL: https://issues.apache.org/jira/browse/HBASE-22233 > Project: HBase > Issue Type: Sub-task > Components: thirdparty >Reporter: Duo Zhang >Priority: Major > Fix For: thirdparty-2.2.1 > > Attachments: HBASE-22233.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (HBASE-22233) [hbase-thirdparty] Add error prone annotations dependency explicitly and do not relocate it
Duo Zhang created HBASE-22233: - Summary: [hbase-thirdparty] Add error prone annotations dependency explicitly and do not relocate it Key: HBASE-22233 URL: https://issues.apache.org/jira/browse/HBASE-22233 Project: HBase Issue Type: Sub-task Components: thirdparty Reporter: Duo Zhang Fix For: thirdparty-2.2.1 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22222) Site build fails after hbase-thirdparty upgrade
[
https://issues.apache.org/jira/browse/HBASE-2?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816945#comment-16816945
]
Duo Zhang commented on HBASE-2:
---
OK, seems passed. Let me file sub tasks to attach patches. Both hbase and
hbase-thirdparth need to be modified.
> Site build fails after hbase-thirdparty upgrade
> ---
>
> Key: HBASE-2
> URL: https://issues.apache.org/jira/browse/HBASE-2
> Project: HBase
> Issue Type: Bug
> Components: website
>Affects Versions: 3.0.0, 2.2.0
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Critical
> Fix For: 3.0.0
>
>
> After hbase-thirdparty upgrade the hbase_generate_website job is failing in
> mvn site target on javadoc.
>
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.7.1:site (default-site) on
> project hbase: Error generating maven-javadoc-plugin:3.0.1:aggregate report:
> [ERROR] Exit code: 1 -
> /home/jenkins/jenkins-slave/workspace/hbase_generate_website/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java:1034:
> warning - Tag @link: can't find tagsIterator(Cell) in
> org.apache.hadoop.hbase.CellUtil
> [ERROR] javadoc: error - class file for
> org.apache.hbase.thirdparty.com.google.errorprone.annotations.Immutable not
> found{noformat}
> After reverting thirdparty upgrade locally the site build passed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22228) Remove deprecated ThrottlingException
[
https://issues.apache.org/jira/browse/HBASE-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816944#comment-16816944
]
Hudson commented on HBASE-8:
Results for branch master
[build #930 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/930/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/930//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/930//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/930//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Remove deprecated ThrottlingException
> -
>
> Key: HBASE-8
> URL: https://issues.apache.org/jira/browse/HBASE-8
> Project: HBase
> Issue Type: Task
> Components: Client
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Trivial
> Fix For: 3.0.0
>
>
> ThrottlingException was deprecated in 2.0.0 and should be removed in 3.0.0.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22193) Add backoff when region failed open too many times
[
https://issues.apache.org/jira/browse/HBASE-22193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816943#comment-16816943
]
Hudson commented on HBASE-22193:
Results for branch master
[build #930 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/930/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/930//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/930//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/930//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Add backoff when region failed open too many times
> --
>
> Key: HBASE-22193
> URL: https://issues.apache.org/jira/browse/HBASE-22193
> Project: HBase
> Issue Type: Improvement
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.3.0
>
>
>
> {code:java}
> public static final String ASSIGN_MAX_ATTEMPTS =
> "hbase.assignment.maximum.attempts";
> private static final int DEFAULT_ASSIGN_MAX_ATTEMPTS = Integer.MAX_VALUE;
> {code}
> Now the default config is Integer.MAX_VALUE.
>
> {code:java}
> 2019-04-09,10:50:44,921 INFO
> org.apache.hadoop.hbase.master.assignment.TransitRegionStateProcedure:
> Retry=170813 of max=2147483647; pid=2849, ppid=2846,
> state=RUNNABLE:REGION_STATE_TRANSITION_CONFIRM_OPENED, locked=true;
> TransitRegionStateProcedure table=IntegrationTestBigLinkedList,
> region=634feb79a583480597e1843647d11228, REOPEN/MOVE; rit=OPENING,
> location=c4-hadoop-tst-st26.bj,29100,1554262369262
> {code}
> The ITBLL failed to open the region as HBASE-22163 and retry 170813 to
> reopen. After I fixed the problem and restart master, I found it need take a
> long time to init the old procedure logs because there are too many old
> logs...
> Code in WALProcedureStore,java.
>
> {code:java}
> private long initOldLogs(FileStatus[] logFiles) throws IOException {
> if (logFiles == null || logFiles.length == 0) {
> return 0L;
> }
> long maxLogId = 0;
> for (int i = 0; i < logFiles.length; ++i) {
> final Path logPath = logFiles[i].getPath();
> leaseRecovery.recoverFileLease(fs, logPath);
> if (!isRunning()) {
> throw new IOException("wal aborting");
> }
> maxLogId = Math.max(maxLogId, getLogIdFromName(logPath.getName()));
> ProcedureWALFile log = initOldLog(logFiles[i], this.walArchiveDir);
> if (log != null) {
> this.logs.add(log);
> }
> }
> initTrackerFromOldLogs();
> return maxLogId;
> }
> {code}
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22227) Remove deprecated fields in ServerSideScanMetrics
[
https://issues.apache.org/jira/browse/HBASE-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816942#comment-16816942
]
Hudson commented on HBASE-7:
Results for branch master
[build #930 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/930/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/930//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/930//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/930//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Remove deprecated fields in ServerSideScanMetrics
> -
>
> Key: HBASE-7
> URL: https://issues.apache.org/jira/browse/HBASE-7
> Project: HBase
> Issue Type: Task
> Components: Client
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Trivial
> Fix For: 3.0.0
>
>
> Two fields in ServerSideScanMetrics got deprecated. They should be removed in
> 3.0.0.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21879) Read HFile's block to ByteBuffer directly instead of to byte for reducing young gc purpose
[
https://issues.apache.org/jira/browse/HBASE-21879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816939#comment-16816939
]
Hudson commented on HBASE-21879:
Results for branch HBASE-21879
[build #62 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/62/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/62//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/62//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/62//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Read HFile's block to ByteBuffer directly instead of to byte for reducing
> young gc purpose
> --
>
> Key: HBASE-21879
> URL: https://issues.apache.org/jira/browse/HBASE-21879
> Project: HBase
> Issue Type: Improvement
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
> Attachments: HBASE-21879.v1.patch, HBASE-21879.v1.patch,
> QPS-latencies-before-HBASE-21879.png, gc-data-before-HBASE-21879.png
>
>
> In HFileBlock#readBlockDataInternal, we have the following:
> {code}
> @VisibleForTesting
> protected HFileBlock readBlockDataInternal(FSDataInputStream is, long offset,
> long onDiskSizeWithHeaderL, boolean pread, boolean verifyChecksum,
> boolean updateMetrics)
> throws IOException {
> // .
> // TODO: Make this ByteBuffer-based. Will make it easier to go to HDFS with
> BBPool (offheap).
> byte [] onDiskBlock = new byte[onDiskSizeWithHeader + hdrSize];
> int nextBlockOnDiskSize = readAtOffset(is, onDiskBlock, preReadHeaderSize,
> onDiskSizeWithHeader - preReadHeaderSize, true, offset +
> preReadHeaderSize, pread);
> if (headerBuf != null) {
> // ...
> }
> // ...
> }
> {code}
> In the read path, we still read the block from hfile to on-heap byte[], then
> copy the on-heap byte[] to offheap bucket cache asynchronously, and in my
> 100% get performance test, I also observed some frequent young gc, The
> largest memory footprint in the young gen should be the on-heap block byte[].
> In fact, we can read HFile's block to ByteBuffer directly instead of to
> byte[] for reducing young gc purpose. we did not implement this before,
> because no ByteBuffer reading interface in the older HDFS client, but 2.7+
> has supported this now, so we can fix this now. I think.
> Will provide an patch and some perf-comparison for this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22222) Site build fails after hbase-thirdparty upgrade
[
https://issues.apache.org/jira/browse/HBASE-2?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816937#comment-16816937
]
Duo Zhang commented on HBASE-2:
---
OK, got the same problem.
{noformat}
javadoc: error - class file for
org.apache.hbase.thirdparty.com.google.errorprone.annotations.Immutable not
found
{noformat}
Let me dig.
> Site build fails after hbase-thirdparty upgrade
> ---
>
> Key: HBASE-2
> URL: https://issues.apache.org/jira/browse/HBASE-2
> Project: HBase
> Issue Type: Bug
> Components: website
>Affects Versions: 3.0.0, 2.2.0
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Critical
> Fix For: 3.0.0
>
>
> After hbase-thirdparty upgrade the hbase_generate_website job is failing in
> mvn site target on javadoc.
>
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.7.1:site (default-site) on
> project hbase: Error generating maven-javadoc-plugin:3.0.1:aggregate report:
> [ERROR] Exit code: 1 -
> /home/jenkins/jenkins-slave/workspace/hbase_generate_website/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java:1034:
> warning - Tag @link: can't find tagsIterator(Cell) in
> org.apache.hadoop.hbase.CellUtil
> [ERROR] javadoc: error - class file for
> org.apache.hbase.thirdparty.com.google.errorprone.annotations.Immutable not
> found{noformat}
> After reverting thirdparty upgrade locally the site build passed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] HorizonNet opened a new pull request #145: HBASE-7003 Moved backup examples into hbase-examples
HorizonNet opened a new pull request #145: HBASE-7003 Moved backup examples into hbase-examples URL: https://github.com/apache/hbase/pull/145 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22222) Site build fails after hbase-thirdparty upgrade
[
https://issues.apache.org/jira/browse/HBASE-2?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816934#comment-16816934
]
Duo Zhang commented on HBASE-2:
---
OK, can be solve by adding supplement... Let me see if I can generate the
site...
> Site build fails after hbase-thirdparty upgrade
> ---
>
> Key: HBASE-2
> URL: https://issues.apache.org/jira/browse/HBASE-2
> Project: HBase
> Issue Type: Bug
> Components: website
>Affects Versions: 3.0.0, 2.2.0
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Critical
> Fix For: 3.0.0
>
>
> After hbase-thirdparty upgrade the hbase_generate_website job is failing in
> mvn site target on javadoc.
>
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.7.1:site (default-site) on
> project hbase: Error generating maven-javadoc-plugin:3.0.1:aggregate report:
> [ERROR] Exit code: 1 -
> /home/jenkins/jenkins-slave/workspace/hbase_generate_website/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java:1034:
> warning - Tag @link: can't find tagsIterator(Cell) in
> org.apache.hadoop.hbase.CellUtil
> [ERROR] javadoc: error - class file for
> org.apache.hbase.thirdparty.com.google.errorprone.annotations.Immutable not
> found{noformat}
> After reverting thirdparty upgrade locally the site build passed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22222) Site build fails after hbase-thirdparty upgrade
[
https://issues.apache.org/jira/browse/HBASE-2?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816932#comment-16816932
]
Duo Zhang commented on HBASE-2:
---
OK, we can add a error_prone_annotation dependency explicitly to the
hbase-thirdparty, but then comes a bad license problem, the license of the
error prone is 'Apache 2.0', not the common used name I believe...
> Site build fails after hbase-thirdparty upgrade
> ---
>
> Key: HBASE-2
> URL: https://issues.apache.org/jira/browse/HBASE-2
> Project: HBase
> Issue Type: Bug
> Components: website
>Affects Versions: 3.0.0, 2.2.0
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Critical
> Fix For: 3.0.0
>
>
> After hbase-thirdparty upgrade the hbase_generate_website job is failing in
> mvn site target on javadoc.
>
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.7.1:site (default-site) on
> project hbase: Error generating maven-javadoc-plugin:3.0.1:aggregate report:
> [ERROR] Exit code: 1 -
> /home/jenkins/jenkins-slave/workspace/hbase_generate_website/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java:1034:
> warning - Tag @link: can't find tagsIterator(Cell) in
> org.apache.hadoop.hbase.CellUtil
> [ERROR] javadoc: error - class file for
> org.apache.hbase.thirdparty.com.google.errorprone.annotations.Immutable not
> found{noformat}
> After reverting thirdparty upgrade locally the site build passed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22222) Site build fails after hbase-thirdparty upgrade
[
https://issues.apache.org/jira/browse/HBASE-2?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816928#comment-16816928
]
Duo Zhang commented on HBASE-2:
---
OK I think the problem is that, I exclude the error prone annotations from the
uber jar, but the maven shade plugin will not add the dependency in the output
pom so we will miss the dependency. So either we added the annotation back in
the shaded jar, or better find a way to let the shade plugin add the dependency
in the dependency-reduced-pom...
> Site build fails after hbase-thirdparty upgrade
> ---
>
> Key: HBASE-2
> URL: https://issues.apache.org/jira/browse/HBASE-2
> Project: HBase
> Issue Type: Bug
> Components: website
>Affects Versions: 3.0.0, 2.2.0
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Critical
> Fix For: 3.0.0
>
>
> After hbase-thirdparty upgrade the hbase_generate_website job is failing in
> mvn site target on javadoc.
>
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.7.1:site (default-site) on
> project hbase: Error generating maven-javadoc-plugin:3.0.1:aggregate report:
> [ERROR] Exit code: 1 -
> /home/jenkins/jenkins-slave/workspace/hbase_generate_website/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java:1034:
> warning - Tag @link: can't find tagsIterator(Cell) in
> org.apache.hadoop.hbase.CellUtil
> [ERROR] javadoc: error - class file for
> org.apache.hbase.thirdparty.com.google.errorprone.annotations.Immutable not
> found{noformat}
> After reverting thirdparty upgrade locally the site build passed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] openinx closed pull request #127: HBASE-21937 Make the Compression#decompress can accept ByteBuff as input
openinx closed pull request #127: HBASE-21937 Make the Compression#decompress can accept ByteBuff as input URL: https://github.com/apache/hbase/pull/127 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] openinx commented on issue #127: HBASE-21937 Make the Compression#decompress can accept ByteBuff as input
openinx commented on issue #127: HBASE-21937 Make the Compression#decompress can accept ByteBuff as input URL: https://github.com/apache/hbase/pull/127#issuecomment-482804457 Out of date now, let's see the patch in RB. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations
[
https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816926#comment-16816926
]
Hudson commented on HBASE-19008:
Results for branch branch-1.4
[build #745 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/745/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/745//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/745//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/745//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Add missing equals or hashCode method(s) to stock Filter implementations
>
>
> Key: HBASE-19008
> URL: https://issues.apache.org/jira/browse/HBASE-19008
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: liubangchen
>Priority: Major
> Labels: filter
> Fix For: 3.0.0, 2.2.0
>
> Attachments: Filters.png, HBASE-19008-1.patch, HBASE-19008-10.patch,
> HBASE-19008-11.patch, HBASE-19008-12.patch, HBASE-19008-13.patch,
> HBASE-19008-14.patch, HBASE-19008-15.patch, HBASE-19008-16.patch,
> HBASE-19008-17.patch, HBASE-19008-18.patch, HBASE-19008-2.patch,
> HBASE-19008-20.patch, HBASE-19008-21.patch, HBASE-19008-3.patch,
> HBASE-19008-4.patch, HBASE-19008-5.patch, HBASE-19008-6.patch,
> HBASE-19008-7.patch, HBASE-19008-8.patch, HBASE-19008-9.patch,
> HBASE-19008.patch
>
>
> In HBASE-15410, [~mdrob] reminded me that Filter implementations may not
> write {{equals}} or {{hashCode}} method(s).
> This issue is to add missing {{equals}} or {{hashCode}} method(s) to stock
> Filter implementations such as KeyOnlyFilter.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22222) Site build fails after hbase-thirdparty upgrade
[
https://issues.apache.org/jira/browse/HBASE-2?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816921#comment-16816921
]
Duo Zhang commented on HBASE-2:
---
IIRC I exclude the error prone annotation from guava. Maybe we should just add
it back, but do not shade it? Usually the annotation will be compatible between
different versions...
> Site build fails after hbase-thirdparty upgrade
> ---
>
> Key: HBASE-2
> URL: https://issues.apache.org/jira/browse/HBASE-2
> Project: HBase
> Issue Type: Bug
> Components: website
>Affects Versions: 3.0.0, 2.2.0
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Critical
> Fix For: 3.0.0
>
>
> After hbase-thirdparty upgrade the hbase_generate_website job is failing in
> mvn site target on javadoc.
>
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.7.1:site (default-site) on
> project hbase: Error generating maven-javadoc-plugin:3.0.1:aggregate report:
> [ERROR] Exit code: 1 -
> /home/jenkins/jenkins-slave/workspace/hbase_generate_website/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java:1034:
> warning - Tag @link: can't find tagsIterator(Cell) in
> org.apache.hadoop.hbase.CellUtil
> [ERROR] javadoc: error - class file for
> org.apache.hbase.thirdparty.com.google.errorprone.annotations.Immutable not
> found{noformat}
> After reverting thirdparty upgrade locally the site build passed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22222) Site build fails after hbase-thirdparty upgrade
[
https://issues.apache.org/jira/browse/HBASE-2?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816919#comment-16816919
]
Peter Somogyi commented on HBASE-2:
---
We change the imported class from com.google.errorprone.annotations.Immutable
to org.apache.hbase.thirdparty.com.google.errorprone.annotations.Immutable.
During javadoc (I don't know yet why) we try to load the shaded class but it is
not relocated into the hbase-shaded-miscellaneous module.
> Site build fails after hbase-thirdparty upgrade
> ---
>
> Key: HBASE-2
> URL: https://issues.apache.org/jira/browse/HBASE-2
> Project: HBase
> Issue Type: Bug
> Components: website
>Affects Versions: 3.0.0, 2.2.0
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Critical
> Fix For: 3.0.0
>
>
> After hbase-thirdparty upgrade the hbase_generate_website job is failing in
> mvn site target on javadoc.
>
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.7.1:site (default-site) on
> project hbase: Error generating maven-javadoc-plugin:3.0.1:aggregate report:
> [ERROR] Exit code: 1 -
> /home/jenkins/jenkins-slave/workspace/hbase_generate_website/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java:1034:
> warning - Tag @link: can't find tagsIterator(Cell) in
> org.apache.hadoop.hbase.CellUtil
> [ERROR] javadoc: error - class file for
> org.apache.hbase.thirdparty.com.google.errorprone.annotations.Immutable not
> found{noformat}
> After reverting thirdparty upgrade locally the site build passed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] HorizonNet opened a new pull request #144: HBASE-22232 Removed deprecated methods in CompareFilter
HorizonNet opened a new pull request #144: HBASE-22232 Removed deprecated methods in CompareFilter URL: https://github.com/apache/hbase/pull/144 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22222) Site build fails after hbase-thirdparty upgrade
[
https://issues.apache.org/jira/browse/HBASE-2?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816916#comment-16816916
]
Peter Somogyi commented on HBASE-2:
---
The errorProne profile is not enabled during site build. The error happens only
during user api javadoc generation.
> Site build fails after hbase-thirdparty upgrade
> ---
>
> Key: HBASE-2
> URL: https://issues.apache.org/jira/browse/HBASE-2
> Project: HBase
> Issue Type: Bug
> Components: website
>Affects Versions: 3.0.0, 2.2.0
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Critical
> Fix For: 3.0.0
>
>
> After hbase-thirdparty upgrade the hbase_generate_website job is failing in
> mvn site target on javadoc.
>
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.7.1:site (default-site) on
> project hbase: Error generating maven-javadoc-plugin:3.0.1:aggregate report:
> [ERROR] Exit code: 1 -
> /home/jenkins/jenkins-slave/workspace/hbase_generate_website/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java:1034:
> warning - Tag @link: can't find tagsIterator(Cell) in
> org.apache.hadoop.hbase.CellUtil
> [ERROR] javadoc: error - class file for
> org.apache.hbase.thirdparty.com.google.errorprone.annotations.Immutable not
> found{noformat}
> After reverting thirdparty upgrade locally the site build passed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22222) Site build fails after hbase-thirdparty upgrade
[
https://issues.apache.org/jira/browse/HBASE-2?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816915#comment-16816915
]
Duo Zhang commented on HBASE-2:
---
{quote}
So, protobuf-util, a jar apart from protobuf, uses error prone annotations. In
third-party build, we shade using com.google pattern so the error prone gets
shaded. The addition of the Immutable annotation to protobuf-util, the
dependency on errorprone, is new since our previous thirdparty release*. When
we go to build user javadoc api, we're trying to load the protobuf-util and
missing the error prone annotation – it is explicitly not included.
{quote}
Not fully understand here. So we shade the error prone annotation in
hbase-shaded-miscellaneous, but the javadoc plugin will try to load the
unshaded version of error prone annotation? Why?
> Site build fails after hbase-thirdparty upgrade
> ---
>
> Key: HBASE-2
> URL: https://issues.apache.org/jira/browse/HBASE-2
> Project: HBase
> Issue Type: Bug
> Components: website
>Affects Versions: 3.0.0, 2.2.0
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Critical
> Fix For: 3.0.0
>
>
> After hbase-thirdparty upgrade the hbase_generate_website job is failing in
> mvn site target on javadoc.
>
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.7.1:site (default-site) on
> project hbase: Error generating maven-javadoc-plugin:3.0.1:aggregate report:
> [ERROR] Exit code: 1 -
> /home/jenkins/jenkins-slave/workspace/hbase_generate_website/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java:1034:
> warning - Tag @link: can't find tagsIterator(Cell) in
> org.apache.hadoop.hbase.CellUtil
> [ERROR] javadoc: error - class file for
> org.apache.hbase.thirdparty.com.google.errorprone.annotations.Immutable not
> found{noformat}
> After reverting thirdparty upgrade locally the site build passed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work started] (HBASE-22232) Remove deprecated methods in CompareFilter
[ https://issues.apache.org/jira/browse/HBASE-22232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-22232 started by Jan Hentschel. - > Remove deprecated methods in CompareFilter > -- > > Key: HBASE-22232 > URL: https://issues.apache.org/jira/browse/HBASE-22232 > Project: HBase > Issue Type: Task > Components: Client >Affects Versions: 3.0.0 >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Minor > > CompareFilter has some deprecated methods. These should be removed, as well > as their usages. This is for 3.0.0 only. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (HBASE-22232) Remove deprecated methods in CompareFilter
Jan Hentschel created HBASE-22232: - Summary: Remove deprecated methods in CompareFilter Key: HBASE-22232 URL: https://issues.apache.org/jira/browse/HBASE-22232 Project: HBase Issue Type: Task Components: Client Affects Versions: 3.0.0 Reporter: Jan Hentschel Assignee: Jan Hentschel CompareFilter has some deprecated methods. These should be removed, as well as their usages. This is for 3.0.0 only. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22222) Site build fails after hbase-thirdparty upgrade
[
https://issues.apache.org/jira/browse/HBASE-2?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816911#comment-16816911
]
Duo Zhang commented on HBASE-2:
---
Just do not enable errorProne profile when building the site? What is the
purpose of enabling it?
> Site build fails after hbase-thirdparty upgrade
> ---
>
> Key: HBASE-2
> URL: https://issues.apache.org/jira/browse/HBASE-2
> Project: HBase
> Issue Type: Bug
> Components: website
>Affects Versions: 3.0.0, 2.2.0
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Critical
> Fix For: 3.0.0
>
>
> After hbase-thirdparty upgrade the hbase_generate_website job is failing in
> mvn site target on javadoc.
>
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.7.1:site (default-site) on
> project hbase: Error generating maven-javadoc-plugin:3.0.1:aggregate report:
> [ERROR] Exit code: 1 -
> /home/jenkins/jenkins-slave/workspace/hbase_generate_website/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java:1034:
> warning - Tag @link: can't find tagsIterator(Cell) in
> org.apache.hadoop.hbase.CellUtil
> [ERROR] javadoc: error - class file for
> org.apache.hbase.thirdparty.com.google.errorprone.annotations.Immutable not
> found{noformat}
> After reverting thirdparty upgrade locally the site build passed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-16002) Many DataType constructors are not public
[
https://issues.apache.org/jira/browse/HBASE-16002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816910#comment-16816910
]
HBase QA commented on HBASE-16002:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 6s{color}
| {color:red} HBASE-16002 does not apply to master. Rebase required? Wrong
Branch? See
https://yetus.apache.org/documentation/in-progress/precommit-patchnames for
help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-16002 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12839612/HBASE-16002.master.001.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/78/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |
This message was automatically generated.
> Many DataType constructors are not public
> -
>
> Key: HBASE-16002
> URL: https://issues.apache.org/jira/browse/HBASE-16002
> Project: HBase
> Issue Type: Bug
>Reporter: Nick Dimiduk
>Assignee: Jan Hentschel
>Priority: Major
> Attachments: HBASE-16002.master.001.patch
>
>
> Using the {{Struct}} class to build a rowkey, I noticed than many of the
> provided {{DataType}} implementations' constructors are protected. They
> should be public in most (all?) cases.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-16002) Many DataType constructors are not public
[
https://issues.apache.org/jira/browse/HBASE-16002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816906#comment-16816906
]
Jan Hentschel commented on HBASE-16002:
---
[~ndimiduk] How should we proceed with this one? Should I close it?
> Many DataType constructors are not public
> -
>
> Key: HBASE-16002
> URL: https://issues.apache.org/jira/browse/HBASE-16002
> Project: HBase
> Issue Type: Bug
>Reporter: Nick Dimiduk
>Assignee: Jan Hentschel
>Priority: Major
> Attachments: HBASE-16002.master.001.patch
>
>
> Using the {{Struct}} class to build a rowkey, I noticed than many of the
> provided {{DataType}} implementations' constructors are protected. They
> should be public in most (all?) cases.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-21048) Get LogLevel is not working from console in secure environment
[
https://issues.apache.org/jira/browse/HBASE-21048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Reid Chan updated HBASE-21048:
--
Labels: l security (was: )
> Get LogLevel is not working from console in secure environment
> --
>
> Key: HBASE-21048
> URL: https://issues.apache.org/jira/browse/HBASE-21048
> Project: HBase
> Issue Type: Bug
>Reporter: Chandra Sekhar
>Assignee: Wei-Chiu Chuang
>Priority: Major
> Labels: l, security
> Attachments: HBASE-21048.001.patch, HBASE-21048.master.001.patch,
> HBASE-21048.master.002.patch, HBASE-21048.master.003.patch,
> HBASE-21048.master.004.patch, HBASE-21048.master.005.patch,
> HBASE-21048.master.006.patch, HBASE-21048.master.007.patch,
> HBASE-21048.master.008.patch
>
>
> When we try to get log level of specific package in secure environment,
> getting SocketException.
> {code:java}
> hbase/master/bin# ./hbase org.apache.hadoop.hbase.http.log.LogLevel -getlevel
> host-:16010 org.apache.hadoop.hbase
> Connecting to http://host-:16010/logLevel?log=org.apache.hadoop.hbase
> java.net.SocketException: Unexpected end of file from server
> {code}
> It is trying to connect http instead of https
> code snippet that handling only http in *LogLevel.java*
> {code:java}
> public static void main(String[] args) {
> if (args.length == 3 && "-getlevel".equals(args[0])) {
> process("http://"; + args[1] + "/logLevel?log=" + args[2]);
> return;
> }
> else if (args.length == 4 && "-setlevel".equals(args[0])) {
> process("http://"; + args[1] + "/logLevel?log=" + args[2]
> + "&level=" + args[3]);
> return;
> }
> System.err.println(USAGES);
> System.exit(-1);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (HBASE-22222) Site build fails after hbase-thirdparty upgrade
[
https://issues.apache.org/jira/browse/HBASE-2?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816904#comment-16816904
]
Peter Somogyi edited comment on HBASE-2 at 4/13/19 11:11 AM:
-
I also tried to add the Immutable class to the list in thirdparty
but couldn't go further at that time.
This change in thirdparty looks ok with the additionalDependency in
maven-javadoc-plugin.
{noformat}
-
com.google.errorprone.annotations.CanIgnoreReturnValue
+com.google.errorprone.annotations.*
{noformat}
What I still don't get is why only userapi reportSet requires the
error_prone_annotations dependency.
was (Author: psomogyi):
I also tried to add the Immutable class to the list in thirdparty
but couldn't go further at that time.
This change in thirdparty looks ok with the additionalDependency in
maven-javadoc-plugin.
{noformat}
-
com.google.errorprone.annotations.CanIgnoreReturnValue
+com.google.errorprone.annotations.*
{noformat}
> Site build fails after hbase-thirdparty upgrade
> ---
>
> Key: HBASE-2
> URL: https://issues.apache.org/jira/browse/HBASE-2
> Project: HBase
> Issue Type: Bug
> Components: website
>Affects Versions: 3.0.0, 2.2.0
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Critical
> Fix For: 3.0.0
>
>
> After hbase-thirdparty upgrade the hbase_generate_website job is failing in
> mvn site target on javadoc.
>
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.7.1:site (default-site) on
> project hbase: Error generating maven-javadoc-plugin:3.0.1:aggregate report:
> [ERROR] Exit code: 1 -
> /home/jenkins/jenkins-slave/workspace/hbase_generate_website/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java:1034:
> warning - Tag @link: can't find tagsIterator(Cell) in
> org.apache.hadoop.hbase.CellUtil
> [ERROR] javadoc: error - class file for
> org.apache.hbase.thirdparty.com.google.errorprone.annotations.Immutable not
> found{noformat}
> After reverting thirdparty upgrade locally the site build passed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22222) Site build fails after hbase-thirdparty upgrade
[
https://issues.apache.org/jira/browse/HBASE-2?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816904#comment-16816904
]
Peter Somogyi commented on HBASE-2:
---
I also tried to add the Immutable class to the list in thirdparty
but couldn't go further at that time.
This change in thirdparty looks ok with the additionalDependency in
maven-javadoc-plugin.
{noformat}
-
com.google.errorprone.annotations.CanIgnoreReturnValue
+com.google.errorprone.annotations.*
{noformat}
> Site build fails after hbase-thirdparty upgrade
> ---
>
> Key: HBASE-2
> URL: https://issues.apache.org/jira/browse/HBASE-2
> Project: HBase
> Issue Type: Bug
> Components: website
>Affects Versions: 3.0.0, 2.2.0
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Critical
> Fix For: 3.0.0
>
>
> After hbase-thirdparty upgrade the hbase_generate_website job is failing in
> mvn site target on javadoc.
>
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.7.1:site (default-site) on
> project hbase: Error generating maven-javadoc-plugin:3.0.1:aggregate report:
> [ERROR] Exit code: 1 -
> /home/jenkins/jenkins-slave/workspace/hbase_generate_website/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java:1034:
> warning - Tag @link: can't find tagsIterator(Cell) in
> org.apache.hadoop.hbase.CellUtil
> [ERROR] javadoc: error - class file for
> org.apache.hbase.thirdparty.com.google.errorprone.annotations.Immutable not
> found{noformat}
> After reverting thirdparty upgrade locally the site build passed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21048) Get LogLevel is not working from console in secure environment
[
https://issues.apache.org/jira/browse/HBASE-21048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816903#comment-16816903
]
Reid Chan commented on HBASE-21048:
---
I amended the check-style warning in v8 patch, and pushed to master branch.
Would you minding providing patches for back-porting branch-2 (tried, but with
some conflicts) and branch-1.
Thanks [~jojochuang]
> Get LogLevel is not working from console in secure environment
> --
>
> Key: HBASE-21048
> URL: https://issues.apache.org/jira/browse/HBASE-21048
> Project: HBase
> Issue Type: Bug
>Reporter: Chandra Sekhar
>Assignee: Wei-Chiu Chuang
>Priority: Major
> Attachments: HBASE-21048.001.patch, HBASE-21048.master.001.patch,
> HBASE-21048.master.002.patch, HBASE-21048.master.003.patch,
> HBASE-21048.master.004.patch, HBASE-21048.master.005.patch,
> HBASE-21048.master.006.patch, HBASE-21048.master.007.patch,
> HBASE-21048.master.008.patch
>
>
> When we try to get log level of specific package in secure environment,
> getting SocketException.
> {code:java}
> hbase/master/bin# ./hbase org.apache.hadoop.hbase.http.log.LogLevel -getlevel
> host-:16010 org.apache.hadoop.hbase
> Connecting to http://host-:16010/logLevel?log=org.apache.hadoop.hbase
> java.net.SocketException: Unexpected end of file from server
> {code}
> It is trying to connect http instead of https
> code snippet that handling only http in *LogLevel.java*
> {code:java}
> public static void main(String[] args) {
> if (args.length == 3 && "-getlevel".equals(args[0])) {
> process("http://"; + args[1] + "/logLevel?log=" + args[2]);
> return;
> }
> else if (args.length == 4 && "-setlevel".equals(args[0])) {
> process("http://"; + args[1] + "/logLevel?log=" + args[2]
> + "&level=" + args[3]);
> return;
> }
> System.err.println(USAGES);
> System.exit(-1);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations
[
https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816899#comment-16816899
]
Hudson commented on HBASE-19008:
Results for branch branch-1
[build #771 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/771/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/771//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/771//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/771//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Add missing equals or hashCode method(s) to stock Filter implementations
>
>
> Key: HBASE-19008
> URL: https://issues.apache.org/jira/browse/HBASE-19008
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: liubangchen
>Priority: Major
> Labels: filter
> Fix For: 3.0.0, 2.2.0
>
> Attachments: Filters.png, HBASE-19008-1.patch, HBASE-19008-10.patch,
> HBASE-19008-11.patch, HBASE-19008-12.patch, HBASE-19008-13.patch,
> HBASE-19008-14.patch, HBASE-19008-15.patch, HBASE-19008-16.patch,
> HBASE-19008-17.patch, HBASE-19008-18.patch, HBASE-19008-2.patch,
> HBASE-19008-20.patch, HBASE-19008-21.patch, HBASE-19008-3.patch,
> HBASE-19008-4.patch, HBASE-19008-5.patch, HBASE-19008-6.patch,
> HBASE-19008-7.patch, HBASE-19008-8.patch, HBASE-19008-9.patch,
> HBASE-19008.patch
>
>
> In HBASE-15410, [~mdrob] reminded me that Filter implementations may not
> write {{equals}} or {{hashCode}} method(s).
> This issue is to add missing {{equals}} or {{hashCode}} method(s) to stock
> Filter implementations such as KeyOnlyFilter.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] HorizonNet opened a new pull request #143: HBASE-22231 Removed unused and '*' imports
HorizonNet opened a new pull request #143: HBASE-22231 Removed unused and '*' imports URL: https://github.com/apache/hbase/pull/143 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Work started] (HBASE-22231) Remove unused and * imports
[ https://issues.apache.org/jira/browse/HBASE-22231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-22231 started by Jan Hentschel. - > Remove unused and * imports > --- > > Key: HBASE-22231 > URL: https://issues.apache.org/jira/browse/HBASE-22231 > Project: HBase > Issue Type: Task >Affects Versions: 3.0.0 >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Minor > > Currently there are a lot of unused imports, as well as '*' imports, are > used. They should be removed or replaced. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (HBASE-22231) Remove unused and * imports
Jan Hentschel created HBASE-22231: - Summary: Remove unused and * imports Key: HBASE-22231 URL: https://issues.apache.org/jira/browse/HBASE-22231 Project: HBase Issue Type: Task Affects Versions: 3.0.0 Reporter: Jan Hentschel Assignee: Jan Hentschel Currently there are a lot of unused imports, as well as '*' imports, are used. They should be removed or replaced. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22193) Add backoff when region failed open too many times
[
https://issues.apache.org/jira/browse/HBASE-22193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816886#comment-16816886
]
Hudson commented on HBASE-22193:
Results for branch branch-2.2
[build #183 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/183/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/183//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/183//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/183//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Add backoff when region failed open too many times
> --
>
> Key: HBASE-22193
> URL: https://issues.apache.org/jira/browse/HBASE-22193
> Project: HBase
> Issue Type: Improvement
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.3.0
>
>
>
> {code:java}
> public static final String ASSIGN_MAX_ATTEMPTS =
> "hbase.assignment.maximum.attempts";
> private static final int DEFAULT_ASSIGN_MAX_ATTEMPTS = Integer.MAX_VALUE;
> {code}
> Now the default config is Integer.MAX_VALUE.
>
> {code:java}
> 2019-04-09,10:50:44,921 INFO
> org.apache.hadoop.hbase.master.assignment.TransitRegionStateProcedure:
> Retry=170813 of max=2147483647; pid=2849, ppid=2846,
> state=RUNNABLE:REGION_STATE_TRANSITION_CONFIRM_OPENED, locked=true;
> TransitRegionStateProcedure table=IntegrationTestBigLinkedList,
> region=634feb79a583480597e1843647d11228, REOPEN/MOVE; rit=OPENING,
> location=c4-hadoop-tst-st26.bj,29100,1554262369262
> {code}
> The ITBLL failed to open the region as HBASE-22163 and retry 170813 to
> reopen. After I fixed the problem and restart master, I found it need take a
> long time to init the old procedure logs because there are too many old
> logs...
> Code in WALProcedureStore,java.
>
> {code:java}
> private long initOldLogs(FileStatus[] logFiles) throws IOException {
> if (logFiles == null || logFiles.length == 0) {
> return 0L;
> }
> long maxLogId = 0;
> for (int i = 0; i < logFiles.length; ++i) {
> final Path logPath = logFiles[i].getPath();
> leaseRecovery.recoverFileLease(fs, logPath);
> if (!isRunning()) {
> throw new IOException("wal aborting");
> }
> maxLogId = Math.max(maxLogId, getLogIdFromName(logPath.getName()));
> ProcedureWALFile log = initOldLog(logFiles[i], this.walArchiveDir);
> if (log != null) {
> this.logs.add(log);
> }
> }
> initTrackerFromOldLogs();
> return maxLogId;
> }
> {code}
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (HBASE-22230) REST Server drops connection on long scans
Pankaj Kumar created HBASE-22230: Summary: REST Server drops connection on long scans Key: HBASE-22230 URL: https://issues.apache.org/jira/browse/HBASE-22230 Project: HBase Issue Type: Bug Reporter: Pankaj Kumar Assignee: Pankaj Kumar REST sever uses ConnectionCache and connection will be dropped after hbase.rest.connection.max-idletime from the last time a connection object was accessed. Similar problem was fixed for Thrift in HBASE-16221, need to fix it for REST also. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (HBASE-22228) Remove deprecated ThrottlingException
[ https://issues.apache.org/jira/browse/HBASE-8?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel resolved HBASE-8. --- Resolution: Fixed Fix Version/s: 3.0.0 > Remove deprecated ThrottlingException > - > > Key: HBASE-8 > URL: https://issues.apache.org/jira/browse/HBASE-8 > Project: HBase > Issue Type: Task > Components: Client >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Trivial > Fix For: 3.0.0 > > > ThrottlingException was deprecated in 2.0.0 and should be removed in 3.0.0. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (HBASE-22227) Remove deprecated fields in ServerSideScanMetrics
[ https://issues.apache.org/jira/browse/HBASE-7?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel resolved HBASE-7. --- Resolution: Fixed Fix Version/s: 3.0.0 > Remove deprecated fields in ServerSideScanMetrics > - > > Key: HBASE-7 > URL: https://issues.apache.org/jira/browse/HBASE-7 > Project: HBase > Issue Type: Task > Components: Client >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Trivial > Fix For: 3.0.0 > > > Two fields in ServerSideScanMetrics got deprecated. They should be removed in > 3.0.0. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [hbase] HorizonNet merged pull request #142: HBASE-22228 Removed deprecated ThrottlingException
HorizonNet merged pull request #142: HBASE-8 Removed deprecated ThrottlingException URL: https://github.com/apache/hbase/pull/142 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] HorizonNet merged pull request #141: HBASE-22227 Removed deprecated fields in ServerSideScanMetrics
HorizonNet merged pull request #141: HBASE-7 Removed deprecated fields in ServerSideScanMetrics URL: https://github.com/apache/hbase/pull/141 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Work started] (HBASE-22228) Remove deprecated ThrottlingException
[ https://issues.apache.org/jira/browse/HBASE-8?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-8 started by Jan Hentschel. - > Remove deprecated ThrottlingException > - > > Key: HBASE-8 > URL: https://issues.apache.org/jira/browse/HBASE-8 > Project: HBase > Issue Type: Task > Components: Client >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Trivial > > ThrottlingException was deprecated in 2.0.0 and should be removed in 3.0.0. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21048) Get LogLevel is not working from console in secure environment
[
https://issues.apache.org/jira/browse/HBASE-21048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816855#comment-16816855
]
HBase QA commented on HBASE-21048:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
22s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
34s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
13s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
43s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
31s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
14s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
19s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
12s{color} | {color:red} hbase-http: The patch generated 1 new + 0 unchanged -
0 fixed = 1 total (was 0) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
39s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
9m 0s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4
or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
12s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
56s{color} | {color:green} hbase-http in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
8s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 31m 51s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/PreCommit-HBASE-Build/77/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-21048 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12965797/HBASE-21048.master.008.patch
|
| Optional Tests | dupname asflicense javac javadoc unit shadedjars
hadoopcheck xml compile findbugs hbaseanti checkstyle |
| uname | Linux cff5ec512df5 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb
13 15:00:41 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / cfd74a68ad |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.11 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HBASE-Build/77/artifact/patchprocess/diff-checkstyle-hbase-http.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-B
