[jira] [Resolved] (HBASE-22160) Add sorting functionality in regionserver web UI for user regions
[ https://issues.apache.org/jira/browse/HBASE-22160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang resolved HBASE-22160. Resolution: Fixed Pushed to branch-2.2. > Add sorting functionality in regionserver web UI for user regions > - > > Key: HBASE-22160 > URL: https://issues.apache.org/jira/browse/HBASE-22160 > Project: HBase > Issue Type: Improvement > Components: monitoring, regionserver, UI, Usability >Reporter: Daisuke Kobayashi >Assignee: Daisuke Kobayashi >Priority: Minor > Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6 > > Attachments: HBASE-22160.branch2.001.patch, > HBASE-22160.master.001.patch, HBASE-22160.master.001.patch, > HBASE-22160.master.002.patch, HBASE-22160.master.003.patch, Screen Shot > 2019-04-03 at 15.56.02.png, Screen Shot 2019-05-28 at 6.45.46 PM.png, Screen > Shot 2019-05-29 at 11.42.29.png, Screen Shot 2019-05-30 at 1.03.15 AM.png, > Screen Shot 2019-05-30 at 1.04.40 AM.png, Screen Shot 2019-05-30 at > 14.23.34.png > > > Should be good to have the same sort of sorting functionality, like hmaster > via HBASE-21207, in regionserver web UI for the list of regions too. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (HBASE-22116) HttpDoAsClient to support keytab and principal in command line argument.
[ https://issues.apache.org/jira/browse/HBASE-22116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang resolved HBASE-22116. Resolution: Fixed Pushed to branch-2.2. > HttpDoAsClient to support keytab and principal in command line argument. > > > Key: HBASE-22116 > URL: https://issues.apache.org/jira/browse/HBASE-22116 > Project: HBase > Issue Type: Improvement >Reporter: Subrat Mishra >Assignee: Subrat Mishra >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.2.1 > > Attachments: HBASE-22116.branch-2.001.patch, > HBASE-22116.master.001.patch, HBASE-22116.master.002.patch, > HBASE-22116.master.002.patch, HBASE-22116.master.003.patch, > HBASE-22116.master.004.patch > > > Currently, HttpDoAsClient relies only on kinit. It's good to add support for > keytab and principal in command line argument. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22581) user with "CREATE" permission can grant, but not revoke permissions on created table
[
https://issues.apache.org/jira/browse/HBASE-22581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864591#comment-16864591
]
István Tóth commented on HBASE-22581:
-
patch 003 fixes the checkstyle error.
> user with "CREATE" permission can grant, but not revoke permissions on
> created table
>
>
> Key: HBASE-22581
> URL: https://issues.apache.org/jira/browse/HBASE-22581
> Project: HBase
> Issue Type: Bug
> Components: security
>Affects Versions: 2.1.1, 2.1.5, 2.1.6
>Reporter: István Tóth
>Assignee: István Tóth
>Priority: Major
> Attachments: HBASE-22581.branch-2.1.001.patch,
> HBASE-22581.branch-2.1.002.patch, HBASE-22581.branch-2.1.003.patch,
> HBASE-22581.master.001.patch
>
>
> A user that only has global or namespace "CREATE" permission can grant
> permissions to another user on its created table, but cannot revoke them.
> This bug exists on branch-2.1, from 2.1.1
> 2.0, 2.1.0, master, and branch-2.2 are not effected.
> The bug can be triggered via hbase shell:
> {code:java}
> #Start hbase shell as superuse
> #export HADOOP_USER_NAME=hbase
> hbase shell
> grant 'regularUser1', 'C'
> exit
> #Run hbase shell as regularUser1
> #grant, then revoke 'RX' permission to regularUser2
> #export HADOOP_USER_NAME=regularUser1
> hbase shell
> create 'nunuke','nunuke'
> grant 'regularUser2', 'RX', 'nunuke'
> #This will fail on 2.1.1+
> revoke 'regularUser2', 'nunuke'
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22581) user with "CREATE" permission can grant, but not revoke permissions on created table
[
https://issues.apache.org/jira/browse/HBASE-22581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
István Tóth updated HBASE-22581:
Attachment: HBASE-22581.branch-2.1.003.patch
> user with "CREATE" permission can grant, but not revoke permissions on
> created table
>
>
> Key: HBASE-22581
> URL: https://issues.apache.org/jira/browse/HBASE-22581
> Project: HBase
> Issue Type: Bug
> Components: security
>Affects Versions: 2.1.1, 2.1.5, 2.1.6
>Reporter: István Tóth
>Assignee: István Tóth
>Priority: Major
> Attachments: HBASE-22581.branch-2.1.001.patch,
> HBASE-22581.branch-2.1.002.patch, HBASE-22581.branch-2.1.003.patch,
> HBASE-22581.master.001.patch
>
>
> A user that only has global or namespace "CREATE" permission can grant
> permissions to another user on its created table, but cannot revoke them.
> This bug exists on branch-2.1, from 2.1.1
> 2.0, 2.1.0, master, and branch-2.2 are not effected.
> The bug can be triggered via hbase shell:
> {code:java}
> #Start hbase shell as superuse
> #export HADOOP_USER_NAME=hbase
> hbase shell
> grant 'regularUser1', 'C'
> exit
> #Run hbase shell as regularUser1
> #grant, then revoke 'RX' permission to regularUser2
> #export HADOOP_USER_NAME=regularUser1
> hbase shell
> create 'nunuke','nunuke'
> grant 'regularUser2', 'RX', 'nunuke'
> #This will fail on 2.1.1+
> revoke 'regularUser2', 'nunuke'
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22584) Downloads page is out of date for 1.4 and 1.3 release lines
[
https://issues.apache.org/jira/browse/HBASE-22584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864582#comment-16864582
]
Hudson commented on HBASE-22584:
Results for branch master
[build #1143 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1143/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1143//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1143//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1143//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Downloads page is out of date for 1.4 and 1.3 release lines
> ---
>
> Key: HBASE-22584
> URL: https://issues.apache.org/jira/browse/HBASE-22584
> Project: HBase
> Issue Type: Bug
> Components: community
>Affects Versions: 1.4.10, 1.3.4, 1.3.5
>Reporter: Sean Busbey
>Assignee: Andrew Purtell
>Priority: Critical
> Attachments: HBASE-22584.patch
>
>
> The downloads page (http://hbase.apache.org/downloads.html) still shows 1.3.3
> and 1.4.9 releases. The links are mostly dead since dist.a.o has been updated
> for later releases.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21284) Forward port HBASE-21000 to branch-2
[
https://issues.apache.org/jira/browse/HBASE-21284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864580#comment-16864580
]
HBase QA commented on HBASE-21284:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
48s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
17s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
29s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} refguide {color} | {color:blue} 8m
5s{color} | {color:blue} branch has no errors when building the reference
guide. See footer for rendered docs, which you should manually inspect. {color}
|
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
40s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source: . {color}
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
27s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
42s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
12s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:blue}0{color} | {color:blue} refguide {color} | {color:blue} 7m
55s{color} | {color:blue} patch has no errors when building the reference
guide. See footer for rendered docs, which you should manually inspect. {color}
|
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
39s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
13m 5s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source: . {color}
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
24s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}273m 38s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
32s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
|
[jira] [Commented] (HBASE-21747) Release 2.2.0
[ https://issues.apache.org/jira/browse/HBASE-21747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864579#comment-16864579 ] Guanghao Zhang commented on HBASE-21747: I only pushed a 2.2.0RC6 tag. Need a tag named rel/2.2.0? > Release 2.2.0 > - > > Key: HBASE-21747 > URL: https://issues.apache.org/jira/browse/HBASE-21747 > Project: HBase > Issue Type: Umbrella >Reporter: Duo Zhang >Assignee: Guanghao Zhang >Priority: Major > Fix For: 2.2.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (HBASE-22589) Change our RpcServices to implement protobuf Interface instead of BlockingInterface
Duo Zhang created HBASE-22589: - Summary: Change our RpcServices to implement protobuf Interface instead of BlockingInterface Key: HBASE-22589 URL: https://issues.apache.org/jira/browse/HBASE-22589 Project: HBase Issue Type: Umbrella Reporter: Duo Zhang In HBASE-21512, we removed the ShortCircultConnection as now we will only use Interface at client side but our RpcServices only implement BlockingInterface. We should change them to implement Interface instead. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [hbase] Apache-HBase commented on issue #287: HBASE-21512 Reimplement sync client based on async client
Apache-HBase commented on issue #287: HBASE-21512 Reimplement sync client based on async client URL: https://github.com/apache/hbase/pull/287#issuecomment-502327737 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 0 | Docker mode activated. | | -1 | patch | 8 | https://github.com/apache/hbase/pull/287 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help. | | Subsystem | Report/Notes | |--:|:-| | GITHUB PR | https://github.com/apache/hbase/pull/287 | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-287/18/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22588) Upgrade jaxws-ri dependency to 2.3.2
[
https://issues.apache.org/jira/browse/HBASE-22588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864570#comment-16864570
]
Duo Zhang commented on HBASE-22588:
---
{noformat}
This product includes istack common utility code runtime licensed under the
Eclipse Distribution License - v 1.0.
{noformat}
But I think this is in the Category A...
https://www.apache.org/legal/resolved
Let me see why this happens.
> Upgrade jaxws-ri dependency to 2.3.2
>
>
> Key: HBASE-22588
> URL: https://issues.apache.org/jira/browse/HBASE-22588
> Project: HBase
> Issue Type: Task
>Reporter: Duo Zhang
>Priority: Major
>
> The 2.3.1 depends on some legacy libraries so let's upgrade it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (HBASE-22588) Upgrade jaxws-ri dependency to 2.3.2
Duo Zhang created HBASE-22588: - Summary: Upgrade jaxws-ri dependency to 2.3.2 Key: HBASE-22588 URL: https://issues.apache.org/jira/browse/HBASE-22588 Project: HBase Issue Type: Task Reporter: Duo Zhang The 2.3.1 depends on some legacy libraries so let's upgrade it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22264) Separate out jars related to JDK 11 into a folder in /lib
[
https://issues.apache.org/jira/browse/HBASE-22264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864566#comment-16864566
]
Duo Zhang commented on HBASE-22264:
---
Tried upgrade the dependency to 2.3.2 and I got license error...
Let me open a issue for this.
> Separate out jars related to JDK 11 into a folder in /lib
> -
>
> Key: HBASE-22264
> URL: https://issues.apache.org/jira/browse/HBASE-22264
> Project: HBase
> Issue Type: Task
> Components: java
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
> Labels: jdk11
> Fix For: 3.0.0, 2.3.0
>
> Attachments: hbase-22264.master.001.patch,
> hbase-22264.master.002.patch, hbase-22264.master.003.patch,
> hbase-22264.master.004.patch, hbase-22264.master.005.patch,
> hbase-22264.master.006.patch, hbase-22264_jdks.txt,
> run_ITD_with_REST_ClusterManager.log
>
>
> UPDATE:
> Separate out the the jars related to JDK 11 and add control their addition to
> the classpath using an environment variable or auto-detection of the jdk
> version installed.
> OLD:
> This is in continuation with HBASE-22249. When compiled with jdk 8 and run on
> jdk 11, the master branch throws the following exception during an attempt to
> start the hbase rest server:
> {code:java}
> Exception in thread "main" java.lang.NoClassDefFoundError:
> javax/annotation/Priority
> at
> org.glassfish.jersey.model.internal.ComponentBag.modelFor(ComponentBag.java:483)
> at
> org.glassfish.jersey.model.internal.ComponentBag.access$100(ComponentBag.java:89)
> at
> org.glassfish.jersey.model.internal.ComponentBag$5.call(ComponentBag.java:408)
> at
> org.glassfish.jersey.model.internal.ComponentBag$5.call(ComponentBag.java:398)
> at org.glassfish.jersey.internal.Errors.process(Errors.java:315)
> at org.glassfish.jersey.internal.Errors.process(Errors.java:297)
> at org.glassfish.jersey.internal.Errors.process(Errors.java:228)
> at
> org.glassfish.jersey.model.internal.ComponentBag.registerModel(ComponentBag.java:398)
> at
> org.glassfish.jersey.model.internal.ComponentBag.register(ComponentBag.java:235)
> at
> org.glassfish.jersey.model.internal.CommonConfig.register(CommonConfig.java:420)
> at
> org.glassfish.jersey.server.ResourceConfig.register(ResourceConfig.java:425)
> at org.apache.hadoop.hbase.rest.RESTServer.run(RESTServer.java:245)
> at org.apache.hadoop.hbase.rest.RESTServer.main(RESTServer.java:421)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22264) Separate out jars related to JDK 11 into a folder in /lib
[
https://issues.apache.org/jira/browse/HBASE-22264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864543#comment-16864543
]
Duo Zhang commented on HBASE-22264:
---
The jaxws-ri dependency pulls in commonj.sdo with version 2.1.1.v201112051852
which is not in central...
Could we exclude this dependency? Or add the dependency with version 2.1.1
explicitly?
Thanks.
> Separate out jars related to JDK 11 into a folder in /lib
> -
>
> Key: HBASE-22264
> URL: https://issues.apache.org/jira/browse/HBASE-22264
> Project: HBase
> Issue Type: Task
> Components: java
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
> Labels: jdk11
> Fix For: 3.0.0, 2.3.0
>
> Attachments: hbase-22264.master.001.patch,
> hbase-22264.master.002.patch, hbase-22264.master.003.patch,
> hbase-22264.master.004.patch, hbase-22264.master.005.patch,
> hbase-22264.master.006.patch, hbase-22264_jdks.txt,
> run_ITD_with_REST_ClusterManager.log
>
>
> UPDATE:
> Separate out the the jars related to JDK 11 and add control their addition to
> the classpath using an environment variable or auto-detection of the jdk
> version installed.
> OLD:
> This is in continuation with HBASE-22249. When compiled with jdk 8 and run on
> jdk 11, the master branch throws the following exception during an attempt to
> start the hbase rest server:
> {code:java}
> Exception in thread "main" java.lang.NoClassDefFoundError:
> javax/annotation/Priority
> at
> org.glassfish.jersey.model.internal.ComponentBag.modelFor(ComponentBag.java:483)
> at
> org.glassfish.jersey.model.internal.ComponentBag.access$100(ComponentBag.java:89)
> at
> org.glassfish.jersey.model.internal.ComponentBag$5.call(ComponentBag.java:408)
> at
> org.glassfish.jersey.model.internal.ComponentBag$5.call(ComponentBag.java:398)
> at org.glassfish.jersey.internal.Errors.process(Errors.java:315)
> at org.glassfish.jersey.internal.Errors.process(Errors.java:297)
> at org.glassfish.jersey.internal.Errors.process(Errors.java:228)
> at
> org.glassfish.jersey.model.internal.ComponentBag.registerModel(ComponentBag.java:398)
> at
> org.glassfish.jersey.model.internal.ComponentBag.register(ComponentBag.java:235)
> at
> org.glassfish.jersey.model.internal.CommonConfig.register(CommonConfig.java:420)
> at
> org.glassfish.jersey.server.ResourceConfig.register(ResourceConfig.java:425)
> at org.apache.hadoop.hbase.rest.RESTServer.run(RESTServer.java:245)
> at org.apache.hadoop.hbase.rest.RESTServer.main(RESTServer.java:421)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] Apache9 commented on issue #305: HBASE-22577 BufferedMutatorOverAsyncBufferedMutator.tryCompleteFuture…
Apache9 commented on issue #305: HBASE-22577 BufferedMutatorOverAsyncBufferedMutator.tryCompleteFuture… URL: https://github.com/apache/hbase/pull/305#issuecomment-502318221 Any other concerns? Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22565) Javadoc Warnings: @see cannot be used in inline documentation
[
https://issues.apache.org/jira/browse/HBASE-22565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864537#comment-16864537
]
Hudson commented on HBASE-22565:
Results for branch branch-2.0
[build #1671 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1671/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1671//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1671//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1671//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Javadoc Warnings: @see cannot be used in inline documentation
> -
>
> Key: HBASE-22565
> URL: https://issues.apache.org/jira/browse/HBASE-22565
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Affects Versions: 3.0.0
>Reporter: Murtaza Hassan
>Assignee: Murtaza Hassan
>Priority: Trivial
> Labels: beginner
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
>
> mvn site gives Javadoc Warnings: @see cannot be used in inline documentation.
> Fix them.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22581) user with "CREATE" permission can grant, but not revoke permissions on created table
[
https://issues.apache.org/jira/browse/HBASE-22581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864509#comment-16864509
]
HBase QA commented on HBASE-22581:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
48s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} branch-2.1 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
23s{color} | {color:green} branch-2.1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
53s{color} | {color:green} branch-2.1 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
16s{color} | {color:green} branch-2.1 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
7s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
24s{color} | {color:green} branch-2.1 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
34s{color} | {color:green} branch-2.1 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
14s{color} | {color:red} hbase-server: The patch generated 1 new + 35 unchanged
- 0 fixed = 36 total (was 35) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
10s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
16m 49s{color} | {color:green} Patch does not cause any errors with Hadoop
2.7.7 2.8.5 or 3.0.3 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
29s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}135m
42s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
24s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}184m 59s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/PreCommit-HBASE-Build/543/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22581 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12971837/HBASE-22581.branch-2.1.002.patch
|
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 2b8ae79413ca 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb
13 15:00:41 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2.1 / cf63fbac05 |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.11 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HBASE-Build/543/artifact/patchprocess/diff-checkstyle-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/543/testReport/ |
| Max. process+thread count | 5328 (vs. ulimit of 1) |
| modules | C: hbase-server U:
[jira] [Updated] (HBASE-22584) Downloads page is out of date for 1.4 and 1.3 release lines
[ https://issues.apache.org/jira/browse/HBASE-22584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-22584: --- Resolution: Fixed Status: Resolved (was: Patch Available) PR merged and closed > Downloads page is out of date for 1.4 and 1.3 release lines > --- > > Key: HBASE-22584 > URL: https://issues.apache.org/jira/browse/HBASE-22584 > Project: HBase > Issue Type: Bug > Components: community >Affects Versions: 1.4.10, 1.3.4, 1.3.5 >Reporter: Sean Busbey >Assignee: Andrew Purtell >Priority: Critical > Attachments: HBASE-22584.patch > > > The downloads page (http://hbase.apache.org/downloads.html) still shows 1.3.3 > and 1.4.9 releases. The links are mostly dead since dist.a.o has been updated > for later releases. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [hbase] apurtell merged pull request #308: HBASE-22584 Downloads page is out of date for 1.4 and 1.3 release lines
apurtell merged pull request #308: HBASE-22584 Downloads page is out of date for 1.4 and 1.3 release lines URL: https://github.com/apache/hbase/pull/308 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Comment Edited] (HBASE-21284) Forward port HBASE-21000 to branch-2
[ https://issues.apache.org/jira/browse/HBASE-21284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864498#comment-16864498 ] Andrew Purtell edited comment on HBASE-21284 at 6/14/19 10:52 PM: -- +1 I was author of the change to branch-1. See benchmarks there supporting the change. was (Author: apurtell): +1 from me > Forward port HBASE-21000 to branch-2 > > > Key: HBASE-21284 > URL: https://issues.apache.org/jira/browse/HBASE-21284 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Mingliang Liu >Priority: Major > Attachments: HBASE-21284.001.patch, HBASE-21284.002.patch > > > See parent for details. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21284) Forward port HBASE-21000 to branch-2
[ https://issues.apache.org/jira/browse/HBASE-21284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864498#comment-16864498 ] Andrew Purtell commented on HBASE-21284: +1 from me > Forward port HBASE-21000 to branch-2 > > > Key: HBASE-21284 > URL: https://issues.apache.org/jira/browse/HBASE-21284 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Mingliang Liu >Priority: Major > Attachments: HBASE-21284.001.patch, HBASE-21284.002.patch > > > See parent for details. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22574) hbase-filesystem does not build against HBase 1
[ https://issues.apache.org/jira/browse/HBASE-22574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864495#comment-16864495 ] Sean Mackrory commented on HBASE-22574: --- +1 (non-binding) on the rebased PR > hbase-filesystem does not build against HBase 1 > --- > > Key: HBASE-22574 > URL: https://issues.apache.org/jira/browse/HBASE-22574 > Project: HBase > Issue Type: Bug > Components: Filesystem Integration >Affects Versions: hbase-filesystem-1.0.0-alpha1 >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Major > Attachments: > 0001-HBASE-22574-hbase-filesystem-does-not-build-against-.patch, > HBASE-22574-sean.patch, HBASE-22574.patch, HBASE-22574.patch, > HBASE-22574.patch > > > hbase-filesystem does not build against HBase 1 because HBase 1 does not > provide a hbase-zookeeper module, which is a required dependency. This could > be moved into a version specific build profile. > $ mvn clean install package -Dhbase.version=1.4.10 -Dhadoop.version=2.9.2 > ... > [ERROR] Failed to execute goal on project hbase-oss: > Could not resolve dependencies for project > org.apache.hbase.filesystem:hbase-oss:jar:1.0.0-alpha1: > The following artifacts could not be resolved: > org.apache.hbase:hbase-zookeeper:jar:1.4.10, > org.apache.hbase:hbase-zookeeper:jar:tests:1.4.10: > Could not find artifact org.apache.hbase:hbase-zookeeper:jar:1.4.10 in > central (https://repo.maven.apache.org/maven2) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21284) Forward port HBASE-21000 to branch-2
[ https://issues.apache.org/jira/browse/HBASE-21284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HBASE-21284: -- Attachment: HBASE-21284.002.patch > Forward port HBASE-21000 to branch-2 > > > Key: HBASE-21284 > URL: https://issues.apache.org/jira/browse/HBASE-21284 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Mingliang Liu >Priority: Major > Attachments: HBASE-21284.001.patch, HBASE-21284.002.patch > > > See parent for details. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [hbase] Apache-HBase commented on issue #305: HBASE-22577 BufferedMutatorOverAsyncBufferedMutator.tryCompleteFuture…
Apache-HBase commented on issue #305: HBASE-22577 BufferedMutatorOverAsyncBufferedMutator.tryCompleteFuture… URL: https://github.com/apache/hbase/pull/305#issuecomment-502262569 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 143 | Docker mode activated. | ||| _ Prechecks _ | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ HBASE-21512 Compile Tests _ | | 0 | mvndep | 31 | Maven dependency ordering for branch | | +1 | mvninstall | 251 | HBASE-21512 passed | | +1 | compile | 74 | HBASE-21512 passed | | +1 | checkstyle | 97 | HBASE-21512 passed | | +1 | shadedjars | 257 | branch has no errors when building our shaded downstream artifacts. | | +1 | findbugs | 234 | HBASE-21512 passed | | +1 | javadoc | 55 | HBASE-21512 passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 17 | Maven dependency ordering for patch | | +1 | mvninstall | 255 | the patch passed | | +1 | compile | 79 | the patch passed | | +1 | javac | 79 | the patch passed | | -1 | checkstyle | 29 | hbase-client: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 260 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 727 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | findbugs | 267 | the patch passed | | +1 | javadoc | 57 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 108 | hbase-client in the patch passed. | | -1 | unit | 15277 | hbase-server in the patch failed. | | +1 | asflicense | 55 | The patch does not generate ASF License warnings. | | | | 18687 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestFromClientSide | | | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas | | | hadoop.hbase.quotas.TestQuotaAdmin | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-305/4/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/305 | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux b4d16958a66c 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | HBASE-21512 / c3420640f5 | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.11 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-305/4/artifact/out/diff-checkstyle-hbase-client.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-305/4/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-305/4/testReport/ | | Max. process+thread count | 5289 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-305/4/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-21512) Reimplement sync client based on async client
[
https://issues.apache.org/jira/browse/HBASE-21512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864439#comment-16864439
]
Hudson commented on HBASE-21512:
Results for branch HBASE-21512
[build #287 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21512/287/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21512/287//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21512/287//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21512/287//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Reimplement sync client based on async client
> -
>
> Key: HBASE-21512
> URL: https://issues.apache.org/jira/browse/HBASE-21512
> Project: HBase
> Issue Type: Umbrella
>Reporter: Duo Zhang
>Priority: Major
> Fix For: 3.0.0
>
>
> At least for the RSProcedureDispatcher, with CompletableFuture we do not need
> to set a delay and use a thread pool any more, which could reduce the
> resource usage and also the latency.
> Once this is done, I think we can remove the ClusterConnection completely,
> and start to rewrite the old sync client based on the async client, which
> could reduce the code base a lot for our client.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22561) modify HFilePrettyPrinter to accept non-hbase.rootdir directories
[
https://issues.apache.org/jira/browse/HBASE-22561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Artem Ervits updated HBASE-22561:
-
Attachment: root_dir.png
non_root_dir.png
> modify HFilePrettyPrinter to accept non-hbase.rootdir directories
> -
>
> Key: HBASE-22561
> URL: https://issues.apache.org/jira/browse/HBASE-22561
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0, 2.2.0, 2.3.0, 2.1.5
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Minor
> Attachments: HBASE-22561.v06.patch, HBASE-22561.v07.patch,
> non_root_dir.png, root_dir.png
>
>
> Today {{hbase hfile}} utility accepts only _hbase.rootDir_ directory. It is
> more useful to pass other locations with HFile as well.
> {code:java}
> hbase org.apache.hadoop.hbase.io.hfile.HFilePrettyPrinter hfileoutput
> ...
> ERROR, file (hfileoutput) is not in HBase's root directory
> (hdfs://hadoop.example.com:9000/apps/hbase/)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22561) modify HFilePrettyPrinter to accept non-hbase.rootdir directories
[
https://issues.apache.org/jira/browse/HBASE-22561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864434#comment-16864434
]
Artem Ervits commented on HBASE-22561:
--
[~openinx] spoke with [~elserj] and tend to agree that check for rootDir needs
to happen in the jsp not in the utility. Moved that code block to
storeFile.jsp, attaching images for validation. I will work on a test case for
the webpage and attaching .v07 patch for posterity as well as anything I've
missed.
> modify HFilePrettyPrinter to accept non-hbase.rootdir directories
> -
>
> Key: HBASE-22561
> URL: https://issues.apache.org/jira/browse/HBASE-22561
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0, 2.2.0, 2.3.0, 2.1.5
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Minor
> Attachments: HBASE-22561.v06.patch, HBASE-22561.v07.patch
>
>
> Today {{hbase hfile}} utility accepts only _hbase.rootDir_ directory. It is
> more useful to pass other locations with HFile as well.
> {code:java}
> hbase org.apache.hadoop.hbase.io.hfile.HFilePrettyPrinter hfileoutput
> ...
> ERROR, file (hfileoutput) is not in HBase's root directory
> (hdfs://hadoop.example.com:9000/apps/hbase/)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22561) modify HFilePrettyPrinter to accept non-hbase.rootdir directories
[
https://issues.apache.org/jira/browse/HBASE-22561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Artem Ervits updated HBASE-22561:
-
Attachment: HBASE-22561.v07.patch
> modify HFilePrettyPrinter to accept non-hbase.rootdir directories
> -
>
> Key: HBASE-22561
> URL: https://issues.apache.org/jira/browse/HBASE-22561
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0, 2.2.0, 2.3.0, 2.1.5
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Minor
> Attachments: HBASE-22561.v06.patch, HBASE-22561.v07.patch
>
>
> Today {{hbase hfile}} utility accepts only _hbase.rootDir_ directory. It is
> more useful to pass other locations with HFile as well.
> {code:java}
> hbase org.apache.hadoop.hbase.io.hfile.HFilePrettyPrinter hfileoutput
> ...
> ERROR, file (hfileoutput) is not in HBase's root directory
> (hdfs://hadoop.example.com:9000/apps/hbase/)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22492) HBase server doesn't preserve SASL sequence number on the network
[
https://issues.apache.org/jira/browse/HBASE-22492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864412#comment-16864412
]
Sebastien Barnoud commented on HBASE-22492:
---
I put the patch on one of our cluster today. It solves the issue and no
regression observed.
Thanks for your feed-back.
> HBase server doesn't preserve SASL sequence number on the network
> -
>
> Key: HBASE-22492
> URL: https://issues.apache.org/jira/browse/HBASE-22492
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Affects Versions: 1.1.2
> Environment: HDP 2.6.5.108-1
>
>Reporter: Sébastien BARNOUD
>Priority: Major
> Attachments: HBASE-22492.001.branch-1.patch,
> HBASE-22492.002.branch-1.patch
>
>
> When auth-conf is enabled on RPC, the server encrypt response in setReponse()
> using saslServer. The generated cryptogram included a sequence number manage
> by saslServer. But then, when the response is sent over the network, the
> sequence number order is not preserved.
> The client receives reply in the wrong order, leading to a log message from
> DigestMD5Base:
> {code:java}
> sasl:1481 - DIGEST41:Unmatched MACs
> {code}
> Then the message is discarded, leading the client to a timeout.
> I propose a fix here:
> [https://github.com/sbarnoud/hbase-release/commit/ce9894ffe0e4039deecd1ed51fa135f64b311d41]
> It seems that any HBase 1.x is affected.
> This part of code has been fully rewritten in HBase 2.x, and i haven't do the
> analysis on HBase 2.x which may be affected.
>
> Here, an extract of client log that i added to help me to understand:
> {code:java}
> …
> 2019-05-28 12:53:48,644 DEBUG [Default-IPC-NioEventLoopGroup-1-32]
> NettyRpcDuplexHandler:80 - callId: 5846 /192.163.201.65:58870 ->
> dtltstap004.fr.world.socgen/192.163.201.72:16020
> 2019-05-28 12:53:48,651 INFO [Default-IPC-NioEventLoopGroup-1-18]
> NioEventLoop:101 - SG: Channel ready to read 1315913615 unsafe 1493023957
> /192.163.201.65:44236 -> dtltstap008.fr.world.socgen/192.163.201.109:16020
> 2019-05-28 12:53:48,651 INFO [Default-IPC-NioEventLoopGroup-1-18]
> SaslUnwrapHandler:78 - SG: after unwrap:46 -> 29 for /192.163.201.65:44236
> -> dtltstap008.fr.world.socgen/192.163.201.109:16020 seqNum 150
> 2019-05-28 12:53:48,652 DEBUG [Default-IPC-NioEventLoopGroup-1-18]
> NettyRpcDuplexHandler:192 - callId: 5801 received totalSize:25 Message:20
> scannerSize:(null)/192.163.201.65:44236 ->
> dtltstap008.fr.world.socgen/192.163.201.109:16020
> 2019-05-28 12:53:48,652 INFO [Default-IPC-NioEventLoopGroup-1-18] sasl:1481
> - DIGEST41:Unmatched MACs
> 2019-05-28 12:53:48,652 WARN [Default-IPC-NioEventLoopGroup-1-18]
> SaslUnwrapHandler:70 - Sasl error (probably invalid MAC) detected for
> /192.163.201.65:44236 -> dtltstap008.fr.world.socgen/192.163.201.109:16020
> saslClient @4ac31121 ctx @14fb001d msg @140313192718406 len 118
> data:1c^G?^P?3??h?k??"??x?$^_??^D;^]7^Es??Em?c?w^R^BL?x??omG?z?I???45}???dE?^\^S>D?^/4f?^^??
> ?^Ed?D?kM^@^A^@^@^@? readerIndex 118 writerIndex 118 seqNum
> 152{code}
> We can see that the client unwraps the Sasl message with sequence number 152
> before sequence number 151 and fails with the unmatched MAC.
>
> I opened a case to Oracle because we should had an error (and not the message
> ignored). That's because the JDK doesn't controls integrity in the right way.
> [https://github.com/openjdk/jdk/blob/master/src/java.security.sasl/share/classes/com/sun/security/sasl/digest/DigestMD5Base.java]
> The actual JDK controls the HMac before the sequence number and hides the
> real error (bad sequence number) because SASL is stateful. The JDK should
> check FIRST the sequence number and THEN the HMac.
> When (and if) the JDK will be patched, and accordingly to
> [https://www.ietf.org/rfc/rfc2831.txt|https://www.ietf.org/rfc/rfc2831.txt,]
> , we will get an exception in that case instead of having the message ignored.
> h3.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22584) Downloads page is out of date for 1.4 and 1.3 release lines
[
https://issues.apache.org/jira/browse/HBASE-22584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864406#comment-16864406
]
HBase QA commented on HBASE-22584:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
57s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
45s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 21m
37s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 16m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
19s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 48m 29s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/PreCommit-HBASE-Build/542/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22584 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12971836/HBASE-22584.patch |
| Optional Tests | dupname asflicense mvnsite xml |
| uname | Linux efecb5fe09df 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / ab4453158a |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Max. process+thread count | 95 (vs. ulimit of 1) |
| modules | C: . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/542/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |
This message was automatically generated.
> Downloads page is out of date for 1.4 and 1.3 release lines
> ---
>
> Key: HBASE-22584
> URL: https://issues.apache.org/jira/browse/HBASE-22584
> Project: HBase
> Issue Type: Bug
> Components: community
>Affects Versions: 1.4.10, 1.3.4, 1.3.5
>Reporter: Sean Busbey
>Assignee: Andrew Purtell
>Priority: Critical
> Attachments: HBASE-22584.patch
>
>
> The downloads page (http://hbase.apache.org/downloads.html) still shows 1.3.3
> and 1.4.9 releases. The links are mostly dead since dist.a.o has been updated
> for later releases.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] Apache-HBase commented on issue #308: HBASE-22584 Downloads page is out of date for 1.4 and 1.3 release lines
Apache-HBase commented on issue #308: HBASE-22584 Downloads page is out of date for 1.4 and 1.3 release lines URL: https://github.com/apache/hbase/pull/308#issuecomment-502248001 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 59 | Docker mode activated. | ||| _ Prechecks _ | | +1 | @author | 0 | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 | mvninstall | 268 | master passed | | +1 | mvnsite | 1069 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 248 | the patch passed | | +1 | mvnsite | 1016 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | xml | 1 | The patch has no ill-formed XML file. | ||| _ Other Tests _ | | +1 | asflicense | 16 | The patch does not generate ASF License warnings. | | | | 2747 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-308/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/308 | | Optional Tests | dupname asflicense mvnsite xml | | uname | Linux a00c83910707 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | master / ab4453158a | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Max. process+thread count | 93 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-308/1/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] HorizonNet commented on issue #308: HBASE-22584 Downloads page is out of date for 1.4 and 1.3 release lines
HorizonNet commented on issue #308: HBASE-22584 Downloads page is out of date for 1.4 and 1.3 release lines URL: https://github.com/apache/hbase/pull/308#issuecomment-502245245 LGTM, pending Q (which shouldn't complain at all). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22581) user with "CREATE" permission can grant, but not revoke permissions on created table
[
https://issues.apache.org/jira/browse/HBASE-22581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864395#comment-16864395
]
István Tóth commented on HBASE-22581:
-
Thanks [~reidchan]!
The 002 patch (hopefully) fixes both the List immutability issue, and the
whitespace warning.
> user with "CREATE" permission can grant, but not revoke permissions on
> created table
>
>
> Key: HBASE-22581
> URL: https://issues.apache.org/jira/browse/HBASE-22581
> Project: HBase
> Issue Type: Bug
> Components: security
>Affects Versions: 2.1.1, 2.1.5, 2.1.6
>Reporter: István Tóth
>Assignee: István Tóth
>Priority: Major
> Attachments: HBASE-22581.branch-2.1.001.patch,
> HBASE-22581.branch-2.1.002.patch, HBASE-22581.master.001.patch
>
>
> A user that only has global or namespace "CREATE" permission can grant
> permissions to another user on its created table, but cannot revoke them.
> This bug exists on branch-2.1, from 2.1.1
> 2.0, 2.1.0, master, and branch-2.2 are not effected.
> The bug can be triggered via hbase shell:
> {code:java}
> #Start hbase shell as superuse
> #export HADOOP_USER_NAME=hbase
> hbase shell
> grant 'regularUser1', 'C'
> exit
> #Run hbase shell as regularUser1
> #grant, then revoke 'RX' permission to regularUser2
> #export HADOOP_USER_NAME=regularUser1
> hbase shell
> create 'nunuke','nunuke'
> grant 'regularUser2', 'RX', 'nunuke'
> #This will fail on 2.1.1+
> revoke 'regularUser2', 'nunuke'
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22492) HBase server doesn't preserve SASL sequence number on the network
[
https://issues.apache.org/jira/browse/HBASE-22492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864394#comment-16864394
]
Josh Elser commented on HBASE-22492:
FYI, I've been able to reproduce this on a standalone test harness. Not
suitable for a unit test, but at I can see the error now.
> HBase server doesn't preserve SASL sequence number on the network
> -
>
> Key: HBASE-22492
> URL: https://issues.apache.org/jira/browse/HBASE-22492
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Affects Versions: 1.1.2
> Environment: HDP 2.6.5.108-1
>
>Reporter: Sébastien BARNOUD
>Priority: Major
> Attachments: HBASE-22492.001.branch-1.patch,
> HBASE-22492.002.branch-1.patch
>
>
> When auth-conf is enabled on RPC, the server encrypt response in setReponse()
> using saslServer. The generated cryptogram included a sequence number manage
> by saslServer. But then, when the response is sent over the network, the
> sequence number order is not preserved.
> The client receives reply in the wrong order, leading to a log message from
> DigestMD5Base:
> {code:java}
> sasl:1481 - DIGEST41:Unmatched MACs
> {code}
> Then the message is discarded, leading the client to a timeout.
> I propose a fix here:
> [https://github.com/sbarnoud/hbase-release/commit/ce9894ffe0e4039deecd1ed51fa135f64b311d41]
> It seems that any HBase 1.x is affected.
> This part of code has been fully rewritten in HBase 2.x, and i haven't do the
> analysis on HBase 2.x which may be affected.
>
> Here, an extract of client log that i added to help me to understand:
> {code:java}
> …
> 2019-05-28 12:53:48,644 DEBUG [Default-IPC-NioEventLoopGroup-1-32]
> NettyRpcDuplexHandler:80 - callId: 5846 /192.163.201.65:58870 ->
> dtltstap004.fr.world.socgen/192.163.201.72:16020
> 2019-05-28 12:53:48,651 INFO [Default-IPC-NioEventLoopGroup-1-18]
> NioEventLoop:101 - SG: Channel ready to read 1315913615 unsafe 1493023957
> /192.163.201.65:44236 -> dtltstap008.fr.world.socgen/192.163.201.109:16020
> 2019-05-28 12:53:48,651 INFO [Default-IPC-NioEventLoopGroup-1-18]
> SaslUnwrapHandler:78 - SG: after unwrap:46 -> 29 for /192.163.201.65:44236
> -> dtltstap008.fr.world.socgen/192.163.201.109:16020 seqNum 150
> 2019-05-28 12:53:48,652 DEBUG [Default-IPC-NioEventLoopGroup-1-18]
> NettyRpcDuplexHandler:192 - callId: 5801 received totalSize:25 Message:20
> scannerSize:(null)/192.163.201.65:44236 ->
> dtltstap008.fr.world.socgen/192.163.201.109:16020
> 2019-05-28 12:53:48,652 INFO [Default-IPC-NioEventLoopGroup-1-18] sasl:1481
> - DIGEST41:Unmatched MACs
> 2019-05-28 12:53:48,652 WARN [Default-IPC-NioEventLoopGroup-1-18]
> SaslUnwrapHandler:70 - Sasl error (probably invalid MAC) detected for
> /192.163.201.65:44236 -> dtltstap008.fr.world.socgen/192.163.201.109:16020
> saslClient @4ac31121 ctx @14fb001d msg @140313192718406 len 118
> data:1c^G?^P?3??h?k??"??x?$^_??^D;^]7^Es??Em?c?w^R^BL?x??omG?z?I???45}???dE?^\^S>D?^/4f?^^??
> ?^Ed?D?kM^@^A^@^@^@? readerIndex 118 writerIndex 118 seqNum
> 152{code}
> We can see that the client unwraps the Sasl message with sequence number 152
> before sequence number 151 and fails with the unmatched MAC.
>
> I opened a case to Oracle because we should had an error (and not the message
> ignored). That's because the JDK doesn't controls integrity in the right way.
> [https://github.com/openjdk/jdk/blob/master/src/java.security.sasl/share/classes/com/sun/security/sasl/digest/DigestMD5Base.java]
> The actual JDK controls the HMac before the sequence number and hides the
> real error (bad sequence number) because SASL is stateful. The JDK should
> check FIRST the sequence number and THEN the HMac.
> When (and if) the JDK will be patched, and accordingly to
> [https://www.ietf.org/rfc/rfc2831.txt|https://www.ietf.org/rfc/rfc2831.txt,]
> , we will get an exception in that case instead of having the message ignored.
> h3.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] HorizonNet commented on a change in pull request #306: HBASE-22572 Javadoc Warnings: @link reference not found
HorizonNet commented on a change in pull request #306: HBASE-22572 Javadoc
Warnings: @link reference not found
URL: https://github.com/apache/hbase/pull/306#discussion_r293954761
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestCase.java
##
@@ -183,7 +183,7 @@ protected HTableDescriptor createTableDescriptor(final
String name) {
}
/**
- * Create a table of name name with {@link COLUMNS} for
+ * Create a table of name name with {@link #COLUMNS} for
Review comment:
Ditto.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #306: HBASE-22572 Javadoc Warnings: @link reference not found
HorizonNet commented on a change in pull request #306: HBASE-22572 Javadoc Warnings: @link reference not found URL: https://github.com/apache/hbase/pull/306#discussion_r293954504 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java ## @@ -28,6 +28,8 @@ import java.util.List; import java.util.Map; import java.util.Random; + +import org.apache.commons.math3.stat.descriptive.DescriptiveStatistics; Review comment: Please don't import a class just to resolve a link in a Javadoc. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #306: HBASE-22572 Javadoc Warnings: @link reference not found
HorizonNet commented on a change in pull request #306: HBASE-22572 Javadoc
Warnings: @link reference not found
URL: https://github.com/apache/hbase/pull/306#discussion_r293954726
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestCase.java
##
@@ -173,7 +173,7 @@ protected HRegion openClosedRegion(final HRegion
closedRegion)
}
/**
- * Create a table of name name with {@link COLUMNS} for
+ * Create a table of name name with {@link #COLUMNS} for
Review comment:
Please also change `` to its Javadoc version.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #306: HBASE-22572 Javadoc Warnings: @link reference not found
HorizonNet commented on a change in pull request #306: HBASE-22572 Javadoc
Warnings: @link reference not found
URL: https://github.com/apache/hbase/pull/306#discussion_r293954804
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestCase.java
##
@@ -196,7 +196,7 @@ protected HTableDescriptor createTableDescriptor(final
String name,
}
/**
- * Create a table of name name with {@link COLUMNS} for
+ * Create a table of name name with {@link #COLUMNS} for
Review comment:
Ditto.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (HBASE-15557) Add guidance on HashTable/SyncTable to the RefGuide
[
https://issues.apache.org/jira/browse/HBASE-15557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864393#comment-16864393
]
Hudson commented on HBASE-15557:
Results for branch branch-2
[build #1997 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1997/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1997//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1997//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1997//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Add guidance on HashTable/SyncTable to the RefGuide
> ---
>
> Key: HBASE-15557
> URL: https://issues.apache.org/jira/browse/HBASE-15557
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Affects Versions: 1.2.0
>Reporter: Sean Busbey
>Assignee: Wellington Chevreuil
>Priority: Critical
> Fix For: 3.0.0
>
> Attachments: HBASE-15557.master.001.patch,
> HBASE-15557.master.002.patch
>
>
> The docs for SyncTable are insufficient. Brief description from [~davelatham]
> HBASE-13639 comment:
> {quote}
> Sorry for the lack of better documentation, Abhishek Soni. Thanks for
> bringing it up. I'll try to provide a better explanation. You may have
> already seen it, but if not, the design doc linked in the description above
> may also give you some better clues as to how it should be used.
> Briefly, the feature is intended to start with a pair of tables in remote
> clusters that are already substantially similar and make them identical by
> comparing hashes of the data and copying only the diffs instead of having to
> copy the entire table. So it is targeted at a very specific use case (with
> some work it could generalize to cover things like CopyTable and
> VerifyRepliaction but it's not there yet). To use it, you choose one table to
> be the "source", and the other table is the "target". After the process is
> complete the target table should end up being identical to the source table.
> In the source table's cluster, run
> org.apache.hadoop.hbase.mapreduce.HashTable and pass it the name of the
> source table and an output directory in HDFS. HashTable will scan the source
> table, break the data up into row key ranges (default of 8kB per range) and
> produce a hash of the data for each range.
> Make the hashes available to the target cluster - I'd recommend using DistCp
> to copy it across.
> In the target table's cluster, run
> org.apache.hadoop.hbase.mapreduce.SyncTable and pass it the directory where
> you put the hashes, and the names of the source and destination tables. You
> will likely also need to specify the source table's ZK quorum via the
> --sourcezkcluster option. SyncTable will then read the hash information, and
> compute the hashes of the same row ranges for the target table. For any row
> range where the hash fails to match, it will open a remote scanner to the
> source table, read the data for that range, and do Puts and Deletes to the
> target table to update it to match the source.
> I hope that clarifies it a bit. Let me know if you need a hand. If anyone
> wants to work on getting some documentation into the book, I can try to write
> some more but would love a hand on turning it into an actual book patch.
> {quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22556) [DOCS] Backport HBASE-15557 to branch-1 and branch-2
[
https://issues.apache.org/jira/browse/HBASE-22556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864392#comment-16864392
]
Hudson commented on HBASE-22556:
Results for branch branch-2
[build #1997 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1997/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1997//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1997//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1997//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> [DOCS] Backport HBASE-15557 to branch-1 and branch-2
> -
>
> Key: HBASE-22556
> URL: https://issues.apache.org/jira/browse/HBASE-22556
> Project: HBase
> Issue Type: Bug
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Major
> Fix For: 1.5.0, 2.3.0
>
> Attachments: HBASE-22556.branch-1.patch, HBASE-22556.branch-2.patch
>
>
> On HBASE-22495, noticed branch-1 and branch-2 are lacking HBASE-15557 commit,
> which adds the whole section about HashTable/SyncTable. We need to backport
> HBASE-15557 on these branches, to make sure any released ref guide for those
> versions also cover it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] HorizonNet commented on a change in pull request #302: HBASE-22571 Javadoc Warnings related to @return tag
HorizonNet commented on a change in pull request #302: HBASE-22571 Javadoc
Warnings related to @return tag
URL: https://github.com/apache/hbase/pull/302#discussion_r293953130
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHStore.java
##
@@ -794,7 +794,7 @@ private static void flushStore(HStore store, long id)
throws IOException {
* @param numRows
* @param qualifier
* @param family
- * @return
+ * @return KeyValues list
Review comment:
What kind of key value list?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #302: HBASE-22571 Javadoc Warnings related to @return tag
HorizonNet commented on a change in pull request #302: HBASE-22571 Javadoc
Warnings related to @return tag
URL: https://github.com/apache/hbase/pull/302#discussion_r293952456
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/TestServerSideScanMetricsFromClientSide.java
##
@@ -113,7 +113,7 @@ public static void tearDownAfterClass() throws Exception {
* @param families
* @param qualifiers
* @param value
- * @return
+ * @return the putted values added in puts
Review comment:
Sounds a little bit off, but don't know how to better phrase it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #302: HBASE-22571 Javadoc Warnings related to @return tag
HorizonNet commented on a change in pull request #302: HBASE-22571 Javadoc Warnings related to @return tag URL: https://github.com/apache/hbase/pull/302#discussion_r293953169 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHStoreFile.java ## @@ -844,7 +844,7 @@ private HStoreFile mockStoreFile(boolean bulkLoad, * @param numRows * @param qualifier * @param family - * @return + * @return KeyValues list Review comment: Ditto This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #302: HBASE-22571 Javadoc Warnings related to @return tag
HorizonNet commented on a change in pull request #302: HBASE-22571 Javadoc
Warnings related to @return tag
URL: https://github.com/apache/hbase/pull/302#discussion_r293953485
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/util/test/LoadTestDataGenerator.java
##
@@ -165,8 +165,7 @@ public Get beforeGet(long rowkeyBase, Get get) throws
IOException {
}
/**
- * Return the arguments passed to the generator as list of object
- * @return
+ * @return Return the arguments passed to the generator as list of object
Review comment:
Remove the `Return` word. It's redundant. Minor spelling mistake `... to the
generator as a list of objects`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #302: HBASE-22571 Javadoc Warnings related to @return tag
HorizonNet commented on a change in pull request #302: HBASE-22571 Javadoc Warnings related to @return tag URL: https://github.com/apache/hbase/pull/302#discussion_r293951642 ## File path: hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapred/TestTableInputFormat.java ## @@ -147,7 +147,7 @@ public static Table createTable(byte[] tableName, byte[][] families) throws IOEx * @param key * @param expectedKey * @param expectedValue - * @return + * @return true if succeed Review comment: What succeeds? Would be great if it was in the format `true if xxx succeeds, false otherwise`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #302: HBASE-22571 Javadoc Warnings related to @return tag
HorizonNet commented on a change in pull request #302: HBASE-22571 Javadoc
Warnings related to @return tag
URL: https://github.com/apache/hbase/pull/302#discussion_r293952197
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
##
@@ -4089,8 +4089,8 @@ public void completeMiniBatchOperations(
/**
* Called to do a piece of the batch that came in to {@link
#batchMutate(Mutation[], long, long)}
- * In here we also handle replay of edits on region recover.
- * @return Change in size brought about by applying batchOp
+ * In here we also handle replay of edits on region recover. Also gets
change in size brought
+ * about by applying batchOp
Review comment:
Change the `` stuff to the Javadoc version (`{@code ...} `).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #302: HBASE-22571 Javadoc Warnings related to @return tag
HorizonNet commented on a change in pull request #302: HBASE-22571 Javadoc
Warnings related to @return tag
URL: https://github.com/apache/hbase/pull/302#discussion_r293952715
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestOpenTableInCoprocessor.java
##
@@ -94,9 +94,8 @@ public void prePut(final
ObserverContext e, final
public static class CustomThreadPoolCoprocessor implements
RegionCoprocessor, RegionObserver {
/**
- * Get a pool that has only ever one thread. A second action added to the
pool (running
+ * @return a pool that has only ever one thread. A second action added to
the pool (running
Review comment:
`a pool that has one thread only at every time.`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #302: HBASE-22571 Javadoc Warnings related to @return tag
HorizonNet commented on a change in pull request #302: HBASE-22571 Javadoc
Warnings related to @return tag
URL: https://github.com/apache/hbase/pull/302#discussion_r293951975
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/client/locking/EntityLock.java
##
@@ -218,8 +218,7 @@ public LockHeartbeatWorker(final String desc) {
}
/**
- * Shutdown the thread cleanly, quietly. We done.
- * @return
+ * @return Shutdown the thread cleanly, quietly. We done.
Review comment:
What does `We done` mean in this context. Minor typo `Shuts down the thread
clean and quietly`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #302: HBASE-22571 Javadoc Warnings related to @return tag
HorizonNet commented on a change in pull request #302: HBASE-22571 Javadoc
Warnings related to @return tag
URL: https://github.com/apache/hbase/pull/302#discussion_r293951419
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/SimpleRequestController.java
##
@@ -434,7 +434,7 @@ private void waitForRegion() throws InterruptedIOException
{
*
* @param loc
* @param heapSizeOfRow
- * @return
+ * @return either Include ReturnCode or Skip ReturnCode
Review comment:
I would suggest to put a Javadoc link on the `ReturnCode`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #302: HBASE-22571 Javadoc Warnings related to @return tag
HorizonNet commented on a change in pull request #302: HBASE-22571 Javadoc
Warnings related to @return tag
URL: https://github.com/apache/hbase/pull/302#discussion_r293953050
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/BalancerTestBase.java
##
@@ -328,7 +328,7 @@ protected String printMock(List
balancedCluster) {
*
* @param list
* @param plans
- * @return
+ * @return the result which has all added map ServerAndLoad values
Review comment:
Better `a list of all added {@link ServerAndLoad} values`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #302: HBASE-22571 Javadoc Warnings related to @return tag
HorizonNet commented on a change in pull request #302: HBASE-22571 Javadoc Warnings related to @return tag URL: https://github.com/apache/hbase/pull/302#discussion_r293951697 ## File path: hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableInputFormat.java ## @@ -145,7 +145,7 @@ public static Table createTable(byte[] tableName, byte[][] families) throws IOEx * @param key * @param expectedKey * @param expectedValue - * @return + * @return true if succeed Review comment: Ditto. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-22581) user with "CREATE" permission can grant, but not revoke permissions on created table
[
https://issues.apache.org/jira/browse/HBASE-22581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
István Tóth updated HBASE-22581:
Attachment: HBASE-22581.branch-2.1.002.patch
> user with "CREATE" permission can grant, but not revoke permissions on
> created table
>
>
> Key: HBASE-22581
> URL: https://issues.apache.org/jira/browse/HBASE-22581
> Project: HBase
> Issue Type: Bug
> Components: security
>Affects Versions: 2.1.1, 2.1.5, 2.1.6
>Reporter: István Tóth
>Assignee: István Tóth
>Priority: Major
> Attachments: HBASE-22581.branch-2.1.001.patch,
> HBASE-22581.branch-2.1.002.patch, HBASE-22581.master.001.patch
>
>
> A user that only has global or namespace "CREATE" permission can grant
> permissions to another user on its created table, but cannot revoke them.
> This bug exists on branch-2.1, from 2.1.1
> 2.0, 2.1.0, master, and branch-2.2 are not effected.
> The bug can be triggered via hbase shell:
> {code:java}
> #Start hbase shell as superuse
> #export HADOOP_USER_NAME=hbase
> hbase shell
> grant 'regularUser1', 'C'
> exit
> #Run hbase shell as regularUser1
> #grant, then revoke 'RX' permission to regularUser2
> #export HADOOP_USER_NAME=regularUser1
> hbase shell
> create 'nunuke','nunuke'
> grant 'regularUser2', 'RX', 'nunuke'
> #This will fail on 2.1.1+
> revoke 'regularUser2', 'nunuke'
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22264) Separate out jars related to JDK 11 into a folder in /lib
[
https://issues.apache.org/jira/browse/HBASE-22264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864384#comment-16864384
]
Hudson commented on HBASE-22264:
Results for branch branch-2
[build #1998 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1998/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1998//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1998//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1998//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Separate out jars related to JDK 11 into a folder in /lib
> -
>
> Key: HBASE-22264
> URL: https://issues.apache.org/jira/browse/HBASE-22264
> Project: HBase
> Issue Type: Task
> Components: java
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
> Labels: jdk11
> Fix For: 3.0.0, 2.3.0
>
> Attachments: hbase-22264.master.001.patch,
> hbase-22264.master.002.patch, hbase-22264.master.003.patch,
> hbase-22264.master.004.patch, hbase-22264.master.005.patch,
> hbase-22264.master.006.patch, hbase-22264_jdks.txt,
> run_ITD_with_REST_ClusterManager.log
>
>
> UPDATE:
> Separate out the the jars related to JDK 11 and add control their addition to
> the classpath using an environment variable or auto-detection of the jdk
> version installed.
> OLD:
> This is in continuation with HBASE-22249. When compiled with jdk 8 and run on
> jdk 11, the master branch throws the following exception during an attempt to
> start the hbase rest server:
> {code:java}
> Exception in thread "main" java.lang.NoClassDefFoundError:
> javax/annotation/Priority
> at
> org.glassfish.jersey.model.internal.ComponentBag.modelFor(ComponentBag.java:483)
> at
> org.glassfish.jersey.model.internal.ComponentBag.access$100(ComponentBag.java:89)
> at
> org.glassfish.jersey.model.internal.ComponentBag$5.call(ComponentBag.java:408)
> at
> org.glassfish.jersey.model.internal.ComponentBag$5.call(ComponentBag.java:398)
> at org.glassfish.jersey.internal.Errors.process(Errors.java:315)
> at org.glassfish.jersey.internal.Errors.process(Errors.java:297)
> at org.glassfish.jersey.internal.Errors.process(Errors.java:228)
> at
> org.glassfish.jersey.model.internal.ComponentBag.registerModel(ComponentBag.java:398)
> at
> org.glassfish.jersey.model.internal.ComponentBag.register(ComponentBag.java:235)
> at
> org.glassfish.jersey.model.internal.CommonConfig.register(CommonConfig.java:420)
> at
> org.glassfish.jersey.server.ResourceConfig.register(ResourceConfig.java:425)
> at org.apache.hadoop.hbase.rest.RESTServer.run(RESTServer.java:245)
> at org.apache.hadoop.hbase.rest.RESTServer.main(RESTServer.java:421)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22574) hbase-filesystem does not build against HBase 1
[
https://issues.apache.org/jira/browse/HBASE-22574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864382#comment-16864382
]
Andrew Purtell commented on HBASE-22574:
Tested with
{noformat}
mvn clean verify -Dhbase.profile=1 -Dhadoop.profile=2
mvn clean verify -Dhbase.profile=1 -Dhadoop.profile=3
mvn clean verify -Dhbase.profile=2 -Dhadoop.profile=2
mvn clean verify -Dhbase.profile=2 -Dhadoop.profile=3
mvn clean verify
{noformat}
Looks good here
> hbase-filesystem does not build against HBase 1
> ---
>
> Key: HBASE-22574
> URL: https://issues.apache.org/jira/browse/HBASE-22574
> Project: HBase
> Issue Type: Bug
> Components: Filesystem Integration
>Affects Versions: hbase-filesystem-1.0.0-alpha1
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
>Priority: Major
> Attachments:
> 0001-HBASE-22574-hbase-filesystem-does-not-build-against-.patch,
> HBASE-22574-sean.patch, HBASE-22574.patch, HBASE-22574.patch,
> HBASE-22574.patch
>
>
> hbase-filesystem does not build against HBase 1 because HBase 1 does not
> provide a hbase-zookeeper module, which is a required dependency. This could
> be moved into a version specific build profile.
> $ mvn clean install package -Dhbase.version=1.4.10 -Dhadoop.version=2.9.2
> ...
> [ERROR] Failed to execute goal on project hbase-oss:
> Could not resolve dependencies for project
> org.apache.hbase.filesystem:hbase-oss:jar:1.0.0-alpha1:
> The following artifacts could not be resolved:
> org.apache.hbase:hbase-zookeeper:jar:1.4.10,
> org.apache.hbase:hbase-zookeeper:jar:tests:1.4.10:
> Could not find artifact org.apache.hbase:hbase-zookeeper:jar:1.4.10 in
> central (https://repo.maven.apache.org/maven2)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase-filesystem] apurtell commented on issue #5: HBASE-22574 hbase-filesystem does not build against HBase 1
apurtell commented on issue #5: HBASE-22574 hbase-filesystem does not build against HBase 1 URL: https://github.com/apache/hbase-filesystem/pull/5#issuecomment-502238421 Tested with mvn clean verify -Dhbase.profile=1 -Dhadoop.profile=2 mvn clean verify -Dhbase.profile=1 -Dhadoop.profile=3 mvn clean verify -Dhbase.profile=2 -Dhadoop.profile=2 mvn clean verify -Dhbase.profile=2 -Dhadoop.profile=3 mvn clean verify Looks good here This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22574) hbase-filesystem does not build against HBase 1
[ https://issues.apache.org/jira/browse/HBASE-22574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864380#comment-16864380 ] Andrew Purtell commented on HBASE-22574: I rebased the PR using [~mackrorysd]'s attached patch 0001... > hbase-filesystem does not build against HBase 1 > --- > > Key: HBASE-22574 > URL: https://issues.apache.org/jira/browse/HBASE-22574 > Project: HBase > Issue Type: Bug > Components: Filesystem Integration >Affects Versions: hbase-filesystem-1.0.0-alpha1 >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Major > Attachments: > 0001-HBASE-22574-hbase-filesystem-does-not-build-against-.patch, > HBASE-22574-sean.patch, HBASE-22574.patch, HBASE-22574.patch, > HBASE-22574.patch > > > hbase-filesystem does not build against HBase 1 because HBase 1 does not > provide a hbase-zookeeper module, which is a required dependency. This could > be moved into a version specific build profile. > $ mvn clean install package -Dhbase.version=1.4.10 -Dhadoop.version=2.9.2 > ... > [ERROR] Failed to execute goal on project hbase-oss: > Could not resolve dependencies for project > org.apache.hbase.filesystem:hbase-oss:jar:1.0.0-alpha1: > The following artifacts could not be resolved: > org.apache.hbase:hbase-zookeeper:jar:1.4.10, > org.apache.hbase:hbase-zookeeper:jar:tests:1.4.10: > Could not find artifact org.apache.hbase:hbase-zookeeper:jar:1.4.10 in > central (https://repo.maven.apache.org/maven2) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [hbase-filesystem] apurtell commented on issue #5: HBASE-22574 hbase-filesystem does not build against HBase 1
apurtell commented on issue #5: HBASE-22574 hbase-filesystem does not build against HBase 1 URL: https://github.com/apache/hbase-filesystem/pull/5#issuecomment-502236533 I rebased the patch here on https://jira.apache.org/jira/secure/attachment/12971822/0001-HBASE-22574-hbase-filesystem-does-not-build-against-.patch This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-22584) Downloads page is out of date for 1.4 and 1.3 release lines
[ https://issues.apache.org/jira/browse/HBASE-22584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-22584: --- Attachment: HBASE-22584.patch > Downloads page is out of date for 1.4 and 1.3 release lines > --- > > Key: HBASE-22584 > URL: https://issues.apache.org/jira/browse/HBASE-22584 > Project: HBase > Issue Type: Bug > Components: community >Affects Versions: 1.4.10, 1.3.4, 1.3.5 >Reporter: Sean Busbey >Assignee: Andrew Purtell >Priority: Critical > Attachments: HBASE-22584.patch > > > The downloads page (http://hbase.apache.org/downloads.html) still shows 1.3.3 > and 1.4.9 releases. The links are mostly dead since dist.a.o has been updated > for later releases. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22584) Downloads page is out of date for 1.4 and 1.3 release lines
[ https://issues.apache.org/jira/browse/HBASE-22584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-22584: --- Status: Patch Available (was: Open) > Downloads page is out of date for 1.4 and 1.3 release lines > --- > > Key: HBASE-22584 > URL: https://issues.apache.org/jira/browse/HBASE-22584 > Project: HBase > Issue Type: Bug > Components: community >Affects Versions: 1.3.5, 1.3.4, 1.4.10 >Reporter: Sean Busbey >Assignee: Andrew Purtell >Priority: Critical > Attachments: HBASE-22584.patch > > > The downloads page (http://hbase.apache.org/downloads.html) still shows 1.3.3 > and 1.4.9 releases. The links are mostly dead since dist.a.o has been updated > for later releases. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [hbase] apurtell commented on issue #308: HBASE-22584 Downloads page is out of date for 1.4 and 1.3 release lines
apurtell commented on issue #308: HBASE-22584 Downloads page is out of date for 1.4 and 1.3 release lines URL: https://github.com/apache/hbase/pull/308#issuecomment-502234523 Short URLs created, but please sanity check. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] apurtell opened a new pull request #308: HBASE-22584 Downloads page is out of date for 1.4 and 1.3 release lines
apurtell opened a new pull request #308: HBASE-22584 Downloads page is out of date for 1.4 and 1.3 release lines URL: https://github.com/apache/hbase/pull/308 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Assigned] (HBASE-22584) Downloads page is out of date for 1.4 and 1.3 release lines
[ https://issues.apache.org/jira/browse/HBASE-22584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell reassigned HBASE-22584: -- Assignee: Andrew Purtell > Downloads page is out of date for 1.4 and 1.3 release lines > --- > > Key: HBASE-22584 > URL: https://issues.apache.org/jira/browse/HBASE-22584 > Project: HBase > Issue Type: Bug > Components: community >Affects Versions: 1.4.10, 1.3.4, 1.3.5 >Reporter: Sean Busbey >Assignee: Andrew Purtell >Priority: Critical > > The downloads page (http://hbase.apache.org/downloads.html) still shows 1.3.3 > and 1.4.9 releases. The links are mostly dead since dist.a.o has been updated > for later releases. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (HBASE-22565) Javadoc Warnings: @see cannot be used in inline documentation
[ https://issues.apache.org/jira/browse/HBASE-22565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel resolved HBASE-22565. --- Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 2.0.6 Pushed to the appropriate branches. Thanks for the contribution [~murtaza.hassan] > Javadoc Warnings: @see cannot be used in inline documentation > - > > Key: HBASE-22565 > URL: https://issues.apache.org/jira/browse/HBASE-22565 > Project: HBase > Issue Type: Bug > Components: documentation >Affects Versions: 3.0.0 >Reporter: Murtaza Hassan >Assignee: Murtaza Hassan >Priority: Trivial > Labels: beginner > Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6 > > > mvn site gives Javadoc Warnings: @see cannot be used in inline documentation. > Fix them. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22537) Split happened Replica region can not be deleted after deleting table successfully and restarting RegionServer
[ https://issues.apache.org/jira/browse/HBASE-22537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864342#comment-16864342 ] Wellington Chevreuil commented on HBASE-22537: -- Thanks for confirming on this, [~sreenivasulureddy]! I actually managed to run the tests, and could also reproduce it manually. I think I have a good understanding of this problem. The point I was missing was crashing the RS that used to hold the read replica. And yes, your test consistently fails with the current branch-2.1 base. My assumption on my previous comment was wrong, create *UnassignProcedure* with _removeAfterUnassign_ set to false does cause the Master AM cache to get fully cleaned, as your tests showed, however, it may do more than we want when closing region replicas, so I thought better to add extra cleaning logic in _UnassignProcedure.finishTransition_, instead. I had created a [PR|https://github.com/apache/hbase/pull/307] and linked this jira. It has a commit with your original changes, plus my mentioned suggestion. Had commented on some additional small improvements, feel free to share your thoughts and push additional commits to this PR. Obviously, other folks suggestions are also welcome. > Split happened Replica region can not be deleted after deleting table > successfully and restarting RegionServer > -- > > Key: HBASE-22537 > URL: https://issues.apache.org/jira/browse/HBASE-22537 > Project: HBase > Issue Type: Bug > Components: Region Assignment >Affects Versions: 2.1.1 >Reporter: Y. SREENIVASULU REDDY >Priority: Minor > Fix For: 2.1.6 > > Attachments: HBASE-22537.branch-2.1.002.patch, > HBASE-22537.branch-2.1.patch > > > [Test step] > 1.create a table (set RegionReplication=2). > 2.insert data to the table utill region be splitted. > 3.Disable and Drop the table. > 4.Parent replica region holding Regionserver, Kill forcefully > 5.HBase WebUI will show that the replica regions will be in RIT. > [Expect Output] > Parent replica region should be deleted. > [Actual Output] > Parent replica region still exists. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21284) Forward port HBASE-21000 to branch-2
[ https://issues.apache.org/jira/browse/HBASE-21284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864339#comment-16864339 ] Mingliang Liu commented on HBASE-21284: --- [~elserj] Thanks for providing more context. I can provide simple fix here to update the default values in the book, no problem, sir. My understanding about this is that [HBASE-20486] changed default throughput controller to PressureAwareThroughputController in branch-1. The section you added in [HBASE-22566] was for HBase 2. Do we need to update that section a little bit to make it vague as to from which version compaction throttling is enabled? Thanks! > Forward port HBASE-21000 to branch-2 > > > Key: HBASE-21284 > URL: https://issues.apache.org/jira/browse/HBASE-21284 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Mingliang Liu >Priority: Major > Attachments: HBASE-21284.001.patch > > > See parent for details. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22565) Javadoc Warnings: @see cannot be used in inline documentation
[
https://issues.apache.org/jira/browse/HBASE-22565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864337#comment-16864337
]
Hudson commented on HBASE-22565:
Results for branch branch-2.1
[build #1269 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1269/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1269//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1269//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1269//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Javadoc Warnings: @see cannot be used in inline documentation
> -
>
> Key: HBASE-22565
> URL: https://issues.apache.org/jira/browse/HBASE-22565
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Affects Versions: 3.0.0
>Reporter: Murtaza Hassan
>Assignee: Murtaza Hassan
>Priority: Trivial
> Labels: beginner
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6
>
>
> mvn site gives Javadoc Warnings: @see cannot be used in inline documentation.
> Fix them.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22585) Build fails on Java 11
[
https://issues.apache.org/jira/browse/HBASE-22585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864326#comment-16864326
]
HBase QA commented on HBASE-22585:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
59s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
21s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
2s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
45s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
40s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
26s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
3s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
36s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
16m 25s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
27s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
27s{color} | {color:green} hbase-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
16s{color} | {color:green} hbase-shaded-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
23s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 50m 25s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/PreCommit-HBASE-Build/541/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22585 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12971824/hbase-22585.master.001.patch
|
| Optional Tests | dupname asflicense javac javadoc unit shadedjars
hadoopcheck xml compile |
| uname | Linux e50e9633b62f 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb
13 15:00:41 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / ab4453158a |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/541/testReport/ |
| Max. process+thread count | 85 (vs. ulimit of 1) |
| modules | C: hbase-shaded hbase-shaded/hbase-shaded-client U: hbase-shaded |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/541/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |
This message was automatically
[GitHub] [hbase] wchevreuil commented on a change in pull request #307: HBase 22537
wchevreuil commented on a change in pull request #307: HBase 22537 URL: https://github.com/apache/hbase/pull/307#discussion_r293922569 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncNonMetaRegionLocator.java ## @@ -34,6 +34,7 @@ import java.util.concurrent.ExecutionException; Review comment: So the fix is either on SplitTableRegionProcedure (your suggestion), or UnassignProcedure (my proposal). In either case, shouldn't the added test go to the related "fixed" class, for consistency? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] wchevreuil commented on a change in pull request #307: HBase 22537
wchevreuil commented on a change in pull request #307: HBase 22537
URL: https://github.com/apache/hbase/pull/307#discussion_r293921574
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncNonMetaRegionLocator.java
##
@@ -390,6 +404,98 @@ public RegionLocations getRegionLocations(TableName
tableName, int replicaId, bo
});
}
+ @Test
+ public void testRegionReplicaRitRecovery() throws Exception {
+int startRowNum = 11;
+int rowCount = 60;
+
+final TableName tableName = TableName.valueOf(name.getMethodName());
+final ProcedureExecutor procExec =
getMasterProcedureExecutor();
+TEST_UTIL.getAdmin().createTable(
+ TableDescriptorBuilder.newBuilder(tableName)
+
.setColumnFamily(ColumnFamilyDescriptorBuilder.of(FAMILY)).setRegionReplication(2)
+ .build());
+TEST_UTIL.waitUntilAllRegionsAssigned(tableName);
+RegionLocations locs = new Locator() {
+
+ @Override
+ public void updateCachedLocationOnError(HRegionLocation loc, Throwable
error)
+ throws Exception {
+LOCATOR.updateCachedLocationOnError(loc, error);
+ }
+
+ @Override
+ public RegionLocations getRegionLocations(TableName tableName, int
replicaId, boolean reload)
+ throws Exception {
+return LOCATOR.getRegionLocations(tableName, EMPTY_START_ROW,
replicaId,
+ RegionLocateType.CURRENT, reload).get();
+ }
+}.getRegionLocations(tableName, 0, false);
+ServerName serverName =
+RegionReplicaTestHelper.getRSCarryingReplica(TEST_UTIL, tableName,
1).get();
+List regions = TEST_UTIL.getAdmin().getRegions(tableName);
+insertData(tableName);
+int splitRowNum = startRowNum + rowCount / 2;
+byte[] splitKey = Bytes.toBytes("" + splitRowNum);
+
+// Split region of the table
+long procId =
+procExec.submitProcedure(new
SplitTableRegionProcedure(procExec.getEnvironment(), regions
+.get(0), splitKey));
+// Wait the completion
+ProcedureTestingUtility.waitProcedure(procExec, procId);
+
+// Disable the table
+long procId1 =
+procExec.submitProcedure(new
DisableTableProcedure(procExec.getEnvironment(), tableName,
+false));
+// Wait the completion
+ProcedureTestingUtility.waitProcedure(procExec, procId1);
+
+long procId2 =
+procExec.submitProcedure(new
DeleteTableProcedure(procExec.getEnvironment(), tableName));
+// Wait the completion
+ProcedureTestingUtility.waitProcedure(procExec, procId2);
+
+AssignmentTestingUtil.killRs(TEST_UTIL, serverName);
+long procId3 = getSCPProcId(procExec);
+Threads.sleepWithoutInterrupt(5000);
+
+boolean hasRegionsInTransition =
+
TEST_UTIL.getMiniHBaseCluster().getMaster().getAssignmentManager().getRegionStates()
+.hasRegionsInTransition();
+
+assertEquals(false, hasRegionsInTransition);
+
+ }
+
+ private ProcedureExecutor getMasterProcedureExecutor() {
+return
TEST_UTIL.getHBaseCluster().getMaster().getMasterProcedureExecutor();
+ }
+
+ private long getSCPProcId(ProcedureExecutor procExec) {
+TEST_UTIL.waitFor(35000, () -> !procExec.getProcedures().isEmpty());
+return
procExec.getActiveProcIds().stream().mapToLong(Long::longValue).min().getAsLong();
+ }
+
+ private void insertData(final TableName tableName) throws IOException,
InterruptedException {
Review comment:
We may simplify this loop, it seems to me we don't really need force
flushes, nor the simultaneous puts on the two halves of the region.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] wchevreuil commented on a change in pull request #307: HBase 22537
wchevreuil commented on a change in pull request #307: HBase 22537
URL: https://github.com/apache/hbase/pull/307#discussion_r293919137
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncNonMetaRegionLocator.java
##
@@ -390,6 +404,98 @@ public RegionLocations getRegionLocations(TableName
tableName, int replicaId, bo
});
}
+ @Test
+ public void testRegionReplicaRitRecovery() throws Exception {
+int startRowNum = 11;
+int rowCount = 60;
+
+final TableName tableName = TableName.valueOf(name.getMethodName());
+final ProcedureExecutor procExec =
getMasterProcedureExecutor();
+TEST_UTIL.getAdmin().createTable(
+ TableDescriptorBuilder.newBuilder(tableName)
+
.setColumnFamily(ColumnFamilyDescriptorBuilder.of(FAMILY)).setRegionReplication(2)
+ .build());
+TEST_UTIL.waitUntilAllRegionsAssigned(tableName);
+RegionLocations locs = new Locator() {
Review comment:
Seems we are not using this _locs_ variable anywhere else in the test. Is
this really needed? Otherwise we can remove lines #419 to #433
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] wchevreuil commented on a change in pull request #307: HBase 22537
wchevreuil commented on a change in pull request #307: HBase 22537
URL: https://github.com/apache/hbase/pull/307#discussion_r293916468
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/SplitTableRegionProcedure.java
##
@@ -854,7 +854,8 @@ private ServerName getParentRegionServerName(final
MasterProcedureEnv env) {
for (int i = 0; i < procs.length; ++i) {
final RegionInfo hri =
RegionReplicaUtil.getRegionInfoForReplica(getParentRegion(), i);
procs[i] = env.getAssignmentManager().
- createUnassignProcedure(hri, null, true,
!RegionReplicaUtil.isDefaultReplica(hri));
+ createUnassignProcedure(hri, null, true,
+!RegionReplicaUtil.isDefaultReplica(hri));
Review comment:
@sreenivasulureddy , the original fix that I had reverted, as explained on
the PR description.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] wchevreuil opened a new pull request #307: HBase 22537
wchevreuil opened a new pull request #307: HBase 22537 URL: https://github.com/apache/hbase/pull/307 This PR consists of two commits on top of branch-2.1: 1) Changes from original patch proposed by sreenivasulureddy; 2) My suggestion to just remove the "non-primary" replica from AM map of regions per RS. I had proposed a minor change in my commit because original fix would cause region close notification eve for read replicas, I'm not sure this is ideal. Additional work may be needed on existing test, so it may be easy to collaborate via this PR. I can then squash all commits into a single one once we are ready to apply the fix. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] wchevreuil commented on a change in pull request #307: HBase 22537
wchevreuil commented on a change in pull request #307: HBase 22537
URL: https://github.com/apache/hbase/pull/307#discussion_r293917693
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/UnassignProcedure.java
##
@@ -231,6 +231,7 @@ protected void finishTransition(final MasterProcedureEnv
env, final RegionStateN
} else {
// Remove from in-memory states
am.getRegionStates().deleteRegion(regionInfo);
+
am.getRegionStates().removeRegionFromServer(regionNode.getRegionLocation(),
regionNode);
env.getMasterServices().getServerManager().removeRegion(regionInfo);
Review comment:
This is my proposal. The main reason for the issue is that we are missing
removing read replicas from this cache. Once the RS the replica once was
assigned to crashes, the originated SCP will read this cache and find the
**read replica** (that does not really exist anywhere else, at this point), and
will submit an AP for it. Adding this extra cleanup, allowed your test to
succeed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (HBASE-22556) [DOCS] Backport HBASE-15557 to branch-1 and branch-2
[
https://issues.apache.org/jira/browse/HBASE-22556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864252#comment-16864252
]
Hudson commented on HBASE-22556:
Results for branch branch-1
[build #895 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/895/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/895//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/895//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/895//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> [DOCS] Backport HBASE-15557 to branch-1 and branch-2
> -
>
> Key: HBASE-22556
> URL: https://issues.apache.org/jira/browse/HBASE-22556
> Project: HBase
> Issue Type: Bug
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Major
> Fix For: 1.5.0, 2.3.0
>
> Attachments: HBASE-22556.branch-1.patch, HBASE-22556.branch-2.patch
>
>
> On HBASE-22495, noticed branch-1 and branch-2 are lacking HBASE-15557 commit,
> which adds the whole section about HashTable/SyncTable. We need to backport
> HBASE-15557 on these branches, to make sure any released ref guide for those
> versions also cover it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-15557) Add guidance on HashTable/SyncTable to the RefGuide
[
https://issues.apache.org/jira/browse/HBASE-15557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864253#comment-16864253
]
Hudson commented on HBASE-15557:
Results for branch branch-1
[build #895 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/895/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/895//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/895//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/895//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Add guidance on HashTable/SyncTable to the RefGuide
> ---
>
> Key: HBASE-15557
> URL: https://issues.apache.org/jira/browse/HBASE-15557
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Affects Versions: 1.2.0
>Reporter: Sean Busbey
>Assignee: Wellington Chevreuil
>Priority: Critical
> Fix For: 3.0.0
>
> Attachments: HBASE-15557.master.001.patch,
> HBASE-15557.master.002.patch
>
>
> The docs for SyncTable are insufficient. Brief description from [~davelatham]
> HBASE-13639 comment:
> {quote}
> Sorry for the lack of better documentation, Abhishek Soni. Thanks for
> bringing it up. I'll try to provide a better explanation. You may have
> already seen it, but if not, the design doc linked in the description above
> may also give you some better clues as to how it should be used.
> Briefly, the feature is intended to start with a pair of tables in remote
> clusters that are already substantially similar and make them identical by
> comparing hashes of the data and copying only the diffs instead of having to
> copy the entire table. So it is targeted at a very specific use case (with
> some work it could generalize to cover things like CopyTable and
> VerifyRepliaction but it's not there yet). To use it, you choose one table to
> be the "source", and the other table is the "target". After the process is
> complete the target table should end up being identical to the source table.
> In the source table's cluster, run
> org.apache.hadoop.hbase.mapreduce.HashTable and pass it the name of the
> source table and an output directory in HDFS. HashTable will scan the source
> table, break the data up into row key ranges (default of 8kB per range) and
> produce a hash of the data for each range.
> Make the hashes available to the target cluster - I'd recommend using DistCp
> to copy it across.
> In the target table's cluster, run
> org.apache.hadoop.hbase.mapreduce.SyncTable and pass it the directory where
> you put the hashes, and the names of the source and destination tables. You
> will likely also need to specify the source table's ZK quorum via the
> --sourcezkcluster option. SyncTable will then read the hash information, and
> compute the hashes of the same row ranges for the target table. For any row
> range where the hash fails to match, it will open a remote scanner to the
> source table, read the data for that range, and do Puts and Deletes to the
> target table to update it to match the source.
> I hope that clarifies it a bit. Let me know if you need a hand. If anyone
> wants to work on getting some documentation into the book, I can try to write
> some more but would love a hand on turning it into an actual book patch.
> {quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (HBASE-22578) HFileCleaner should not delete empty ns/table directories used for user san snapshot feature
[ https://issues.apache.org/jira/browse/HBASE-22578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864238#comment-16864238 ] Reid Chan edited comment on HBASE-22578 at 6/14/19 4:30 PM: bq. When we delete a file (once compacted away), 1st we archive that and later the cleaner cleans this. So there after the file is cleaned by the cleaner, if no more files, the dir also getting cleaned now? Did not check the code. Totally right, sir [~anoop.hbase]. [~Yi Mei], what i meant in 1st Q, can those snapshot scan takes just go in another directory rather than /hbase/archive? 2nd Q, will those stale hfiles which are called scan snapshot in new feature being kept forever? if user enable it. was (Author: reidchan): bq. When we delete a file (once compacted away), 1st we archive that and later the cleaner cleans this. So there after the file is cleaned by the cleaner, if no more files, the dir also getting cleaned now? Did not check the code. Totally right, sir. [~Yi Mei], what i meant in 1st Q, can those snapshot scan takes just go in another directory rather than /hbase/archive? 2nd Q, will those stale hfiles which are called scan snapshot in new feature being kept forever? if user enable it. > HFileCleaner should not delete empty ns/table directories used for user san > snapshot feature > > > Key: HBASE-22578 > URL: https://issues.apache.org/jira/browse/HBASE-22578 > Project: HBase > Issue Type: Sub-task >Reporter: Yi Mei >Priority: Major > > HBASE-21995 add a coprocessor to set HDFS acls for HBase users who own HBase > read permission to mask users have the ability to scan snapshot directly. > It creates empty directories for namespace and table under archive directory > and set HDFS acls to these directories after namespace or table is created, > in this way, users can read files under archive directory. > But the HFileCleaner will delete empty directories and this will break this > feature. So if the user scan snapshot feature is enabled, HFileCleaner should > not delete empty ns/table directories. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22578) HFileCleaner should not delete empty ns/table directories used for user san snapshot feature
[ https://issues.apache.org/jira/browse/HBASE-22578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864238#comment-16864238 ] Reid Chan commented on HBASE-22578: --- bq. When we delete a file (once compacted away), 1st we archive that and later the cleaner cleans this. So there after the file is cleaned by the cleaner, if no more files, the dir also getting cleaned now? Did not check the code. Totally right, sir. [~Yi Mei], what i meant in 1st Q, can those snapshot scan takes just go in another directory rather than /hbase/archive? 2nd Q, will those stale hfiles which are called scan snapshot in new feature being kept forever? if user enable it. > HFileCleaner should not delete empty ns/table directories used for user san > snapshot feature > > > Key: HBASE-22578 > URL: https://issues.apache.org/jira/browse/HBASE-22578 > Project: HBase > Issue Type: Sub-task >Reporter: Yi Mei >Priority: Major > > HBASE-21995 add a coprocessor to set HDFS acls for HBase users who own HBase > read permission to mask users have the ability to scan snapshot directly. > It creates empty directories for namespace and table under archive directory > and set HDFS acls to these directories after namespace or table is created, > in this way, users can read files under archive directory. > But the HFileCleaner will delete empty directories and this will break this > feature. So if the user scan snapshot feature is enabled, HFileCleaner should > not delete empty ns/table directories. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22585) Build fails on Java 11
[ https://issues.apache.org/jira/browse/HBASE-22585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sakthi updated HBASE-22585: --- Status: Patch Available (was: In Progress) > Build fails on Java 11 > -- > > Key: HBASE-22585 > URL: https://issues.apache.org/jira/browse/HBASE-22585 > Project: HBase > Issue Type: Bug > Components: build, java >Reporter: Sakthi >Assignee: Sakthi >Priority: Major > Labels: jdk11 > Attachments: hbase-22585.master.001.patch > > > Branch-2 build fails on Java 11. Complaints about the > hbase-shaded-check-invariants. Will paste the stacktrace if needed in the > comments. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22585) Build fails on Java 11
[ https://issues.apache.org/jira/browse/HBASE-22585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864237#comment-16864237 ] Sakthi commented on HBASE-22585: With the patch in place, the build passes on both Java 11 & 8 on both branches. > Build fails on Java 11 > -- > > Key: HBASE-22585 > URL: https://issues.apache.org/jira/browse/HBASE-22585 > Project: HBase > Issue Type: Bug > Components: build, java >Reporter: Sakthi >Assignee: Sakthi >Priority: Major > Labels: jdk11 > Attachments: hbase-22585.master.001.patch > > > Branch-2 build fails on Java 11. Complaints about the > hbase-shaded-check-invariants. Will paste the stacktrace if needed in the > comments. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22585) Build fails on Java 11
[ https://issues.apache.org/jira/browse/HBASE-22585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sakthi updated HBASE-22585: --- Attachment: hbase-22585.master.001.patch > Build fails on Java 11 > -- > > Key: HBASE-22585 > URL: https://issues.apache.org/jira/browse/HBASE-22585 > Project: HBase > Issue Type: Bug > Components: build, java >Reporter: Sakthi >Assignee: Sakthi >Priority: Major > Labels: jdk11 > Attachments: hbase-22585.master.001.patch > > > Branch-2 build fails on Java 11. Complaints about the > hbase-shaded-check-invariants. Will paste the stacktrace if needed in the > comments. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work started] (HBASE-22585) Build fails on Java 11
[ https://issues.apache.org/jira/browse/HBASE-22585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-22585 started by Sakthi. -- > Build fails on Java 11 > -- > > Key: HBASE-22585 > URL: https://issues.apache.org/jira/browse/HBASE-22585 > Project: HBase > Issue Type: Bug > Components: build, java >Reporter: Sakthi >Assignee: Sakthi >Priority: Major > Labels: jdk11 > Attachments: hbase-22585.master.001.patch > > > Branch-2 build fails on Java 11. Complaints about the > hbase-shaded-check-invariants. Will paste the stacktrace if needed in the > comments. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22581) user with "CREATE" permission can grant, but not revoke permissions on created table
[
https://issues.apache.org/jira/browse/HBASE-22581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864225#comment-16864225
]
HBase QA commented on HBASE-22581:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
41s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
47s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
55s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
15s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
39s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
55s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
39s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
23s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git
apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
44s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
16m 28s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
36s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}217m
47s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
26s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}276m 11s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/PreCommit-HBASE-Build/540/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22581 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12971808/HBASE-22581.master.001.patch
|
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux be41b69ab7e1 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb
13 15:00:41 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / ab4453158a |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.11 |
| whitespace |
https://builds.apache.org/job/PreCommit-HBASE-Build/540/artifact/patchprocess/whitespace-eol.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/540/testReport/ |
| Max. process+thread count | 5140 (vs. ulimit of 1) |
| modules | C: hbase-server U: hbase-server |
| Console output |
[jira] [Commented] (HBASE-22585) Build fails on Java 11
[ https://issues.apache.org/jira/browse/HBASE-22585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864223#comment-16864223 ] Sakthi commented on HBASE-22585: Fails both on master & branch-2 > Build fails on Java 11 > -- > > Key: HBASE-22585 > URL: https://issues.apache.org/jira/browse/HBASE-22585 > Project: HBase > Issue Type: Bug > Components: build, java >Reporter: Sakthi >Assignee: Sakthi >Priority: Major > Labels: jdk11 > > Branch-2 build fails on Java 11. Complaints about the > hbase-shaded-check-invariants. Will paste the stacktrace if needed in the > comments. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (HBASE-22585) Build fails on Java 11
[ https://issues.apache.org/jira/browse/HBASE-22585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sakthi reassigned HBASE-22585: -- Assignee: Sakthi > Build fails on Java 11 > -- > > Key: HBASE-22585 > URL: https://issues.apache.org/jira/browse/HBASE-22585 > Project: HBase > Issue Type: Bug > Components: build, java >Reporter: Sakthi >Assignee: Sakthi >Priority: Major > Labels: jdk11 > > Branch-2 build fails on Java 11. Complaints about the > hbase-shaded-check-invariants. Will paste the stacktrace if needed in the > comments. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22585) Build fails on Java 11
[ https://issues.apache.org/jira/browse/HBASE-22585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sakthi updated HBASE-22585: --- Summary: Build fails on Java 11 (was: Branch-2 build fails on Java 11) > Build fails on Java 11 > -- > > Key: HBASE-22585 > URL: https://issues.apache.org/jira/browse/HBASE-22585 > Project: HBase > Issue Type: Bug > Components: build, java >Reporter: Sakthi >Priority: Major > Labels: jdk11 > > Branch-2 build fails on Java 11. Complaints about the > hbase-shaded-check-invariants. Will paste the stacktrace if needed in the > comments. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22581) user with "CREATE" permission can grant, but not revoke permissions on created table
[
https://issues.apache.org/jira/browse/HBASE-22581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864215#comment-16864215
]
Reid Chan commented on HBASE-22581:
---
Pretty nice find! [~stoty]
Not knowing the full story of HBASE-21385, i may spend time on HBASE-21385.
And please address QA warning.
> user with "CREATE" permission can grant, but not revoke permissions on
> created table
>
>
> Key: HBASE-22581
> URL: https://issues.apache.org/jira/browse/HBASE-22581
> Project: HBase
> Issue Type: Bug
> Components: security
>Affects Versions: 2.1.1, 2.1.5, 2.1.6
>Reporter: István Tóth
>Assignee: István Tóth
>Priority: Major
> Attachments: HBASE-22581.branch-2.1.001.patch,
> HBASE-22581.master.001.patch
>
>
> A user that only has global or namespace "CREATE" permission can grant
> permissions to another user on its created table, but cannot revoke them.
> This bug exists on branch-2.1, from 2.1.1
> 2.0, 2.1.0, master, and branch-2.2 are not effected.
> The bug can be triggered via hbase shell:
> {code:java}
> #Start hbase shell as superuse
> #export HADOOP_USER_NAME=hbase
> hbase shell
> grant 'regularUser1', 'C'
> exit
> #Run hbase shell as regularUser1
> #grant, then revoke 'RX' permission to regularUser2
> #export HADOOP_USER_NAME=regularUser1
> hbase shell
> create 'nunuke','nunuke'
> grant 'regularUser2', 'RX', 'nunuke'
> #This will fail on 2.1.1+
> revoke 'regularUser2', 'nunuke'
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] Apache9 commented on a change in pull request #305: HBASE-22577 BufferedMutatorOverAsyncBufferedMutator.tryCompleteFuture…
Apache9 commented on a change in pull request #305: HBASE-22577
BufferedMutatorOverAsyncBufferedMutator.tryCompleteFuture…
URL: https://github.com/apache/hbase/pull/305#discussion_r293868097
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/BufferedMutatorOverAsyncBufferedMutator.java
##
@@ -100,62 +107,64 @@ private RetriesExhaustedWithDetailsException makeError()
{
return new RetriesExhaustedWithDetailsException(throwables, rows,
hostnameAndPorts);
}
+ private void internalFlush() throws RetriesExhaustedWithDetailsException {
+// should get the future array before calling mutator.flush, otherwise we
may hit an infinite
+// wait, since someone may add new future to the map after we calling the
flush.
+CompletableFuture[] toWait = futures.keySet().toArray(new
CompletableFuture[0]);
+mutator.flush();
+try {
+ CompletableFuture.allOf(toWait).join();
+} catch (CompletionException e) {
+ // just ignore, we will record the actual error in the errors field
+ LOG.debug("Flush failed, you should get an exception thrown to your
code", e);
+}
+if (!errors.isEmpty()) {
+ RetriesExhaustedWithDetailsException error = makeError();
+ listener.onException(error, this);
+}
+ }
+
@Override
public void mutate(List mutations) throws IOException {
-List> toBuffered = new ArrayList<>();
List> fs = mutator.mutate(mutations);
for (int i = 0, n = fs.size(); i < n; i++) {
CompletableFuture toComplete = new CompletableFuture<>();
- final int index = i;
- addListener(fs.get(index), (r, e) -> {
+ futures.put(toComplete, toComplete);
+ Mutation mutation = mutations.get(i);
+ long heapSize = mutation.heapSize();
+ bufferedSize.addAndGet(heapSize);
+ addListener(fs.get(i), (r, e) -> {
+futures.remove(toComplete);
+bufferedSize.addAndGet(-heapSize);
if (e != null) {
- errors.add(Pair.newPair(mutations.get(index), e));
+ errors.add(Pair.newPair(mutation, e));
toComplete.completeExceptionally(e);
} else {
toComplete.complete(r);
}
});
- toBuffered.add(toComplete);
}
synchronized (this) {
- futures.addAll(toBuffered);
- if (futures.size() > BUFFERED_FUTURES_THRESHOLD) {
-tryCompleteFuture();
- }
- if (!errors.isEmpty()) {
+ if (bufferedSize.get() > mutator.getWriteBufferSize() * 2) {
Review comment:
Add more comments about why *2 here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #287: HBASE-21512 Reimplement sync client based on async client
Apache-HBase commented on issue #287: HBASE-21512 Reimplement sync client based on async client URL: https://github.com/apache/hbase/pull/287#issuecomment-502162076 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 0 | Docker mode activated. | | -1 | patch | 8 | https://github.com/apache/hbase/pull/287 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help. | | Subsystem | Report/Notes | |--:|:-| | GITHUB PR | https://github.com/apache/hbase/pull/287 | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-287/17/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (HBASE-22587) Add a REST server to the nightly test that uses a cluster for simple operations
Sakthi created HBASE-22587: -- Summary: Add a REST server to the nightly test that uses a cluster for simple operations Key: HBASE-22587 URL: https://issues.apache.org/jira/browse/HBASE-22587 Project: HBase Issue Type: Task Components: REST, test Reporter: Sakthi Let's add rest server to the nightly test that uses a cluster for simple operations to catch any possible rest server issues related to dependencies, cnfe, npe etc. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22574) hbase-filesystem does not build against HBase 1
[ https://issues.apache.org/jira/browse/HBASE-22574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Mackrory updated HBASE-22574: -- Attachment: 0001-HBASE-22574-hbase-filesystem-does-not-build-against-.patch > hbase-filesystem does not build against HBase 1 > --- > > Key: HBASE-22574 > URL: https://issues.apache.org/jira/browse/HBASE-22574 > Project: HBase > Issue Type: Bug > Components: Filesystem Integration >Affects Versions: hbase-filesystem-1.0.0-alpha1 >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Major > Attachments: > 0001-HBASE-22574-hbase-filesystem-does-not-build-against-.patch, > HBASE-22574-sean.patch, HBASE-22574.patch, HBASE-22574.patch, > HBASE-22574.patch > > > hbase-filesystem does not build against HBase 1 because HBase 1 does not > provide a hbase-zookeeper module, which is a required dependency. This could > be moved into a version specific build profile. > $ mvn clean install package -Dhbase.version=1.4.10 -Dhadoop.version=2.9.2 > ... > [ERROR] Failed to execute goal on project hbase-oss: > Could not resolve dependencies for project > org.apache.hbase.filesystem:hbase-oss:jar:1.0.0-alpha1: > The following artifacts could not be resolved: > org.apache.hbase:hbase-zookeeper:jar:1.4.10, > org.apache.hbase:hbase-zookeeper:jar:tests:1.4.10: > Could not find artifact org.apache.hbase:hbase-zookeeper:jar:1.4.10 in > central (https://repo.maven.apache.org/maven2) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22574) hbase-filesystem does not build against HBase 1
[ https://issues.apache.org/jira/browse/HBASE-22574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864197#comment-16864197 ] Sean Mackrory commented on HBASE-22574: --- See attached 0001-HBASE-22574-hbase-filesystem-does-not-build-against-.patch > hbase-filesystem does not build against HBase 1 > --- > > Key: HBASE-22574 > URL: https://issues.apache.org/jira/browse/HBASE-22574 > Project: HBase > Issue Type: Bug > Components: Filesystem Integration >Affects Versions: hbase-filesystem-1.0.0-alpha1 >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Major > Attachments: > 0001-HBASE-22574-hbase-filesystem-does-not-build-against-.patch, > HBASE-22574-sean.patch, HBASE-22574.patch, HBASE-22574.patch, > HBASE-22574.patch > > > hbase-filesystem does not build against HBase 1 because HBase 1 does not > provide a hbase-zookeeper module, which is a required dependency. This could > be moved into a version specific build profile. > $ mvn clean install package -Dhbase.version=1.4.10 -Dhadoop.version=2.9.2 > ... > [ERROR] Failed to execute goal on project hbase-oss: > Could not resolve dependencies for project > org.apache.hbase.filesystem:hbase-oss:jar:1.0.0-alpha1: > The following artifacts could not be resolved: > org.apache.hbase:hbase-zookeeper:jar:1.4.10, > org.apache.hbase:hbase-zookeeper:jar:tests:1.4.10: > Could not find artifact org.apache.hbase:hbase-zookeeper:jar:1.4.10 in > central (https://repo.maven.apache.org/maven2) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [hbase] Apache-HBase commented on issue #306: HBASE-22572 Javadoc Warnings: @link reference not found
Apache-HBase commented on issue #306: HBASE-22572 Javadoc Warnings: @link reference not found URL: https://github.com/apache/hbase/pull/306#issuecomment-502159271 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 192 | Docker mode activated. | ||| _ Prechecks _ | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 8 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 35 | Maven dependency ordering for branch | | +1 | mvninstall | 259 | master passed | | +1 | compile | 135 | master passed | | +1 | checkstyle | 131 | master passed | | +1 | shadedjars | 264 | branch has no errors when building our shaded downstream artifacts. | | 0 | findbugs | 0 | Skipped patched modules with no Java source: hbase-annotations | | +1 | findbugs | 321 | master passed | | +1 | javadoc | 92 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 15 | Maven dependency ordering for patch | | +1 | mvninstall | 252 | the patch passed | | +1 | compile | 129 | the patch passed | | +1 | javac | 129 | the patch passed | | -1 | checkstyle | 63 | hbase-server: The patch generated 2 new + 85 unchanged - 8 fixed = 87 total (was 93) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 261 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 748 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | 0 | findbugs | 0 | Skipped patched modules with no Java source: hbase-annotations | | +1 | findbugs | 347 | the patch passed | | +1 | javadoc | 12 | hbase-annotations in the patch passed. | | +1 | javadoc | 21 | hbase-common generated 0 new + 1 unchanged - 1 fixed = 1 total (was 2) | | +1 | javadoc | 33 | hbase-server in the patch passed. | | +1 | javadoc | 17 | hbase-mapreduce in the patch passed. | | +1 | javadoc | 14 | hbase-endpoint in the patch passed. | ||| _ Other Tests _ | | +1 | unit | 14 | hbase-annotations in the patch passed. | | +1 | unit | 170 | hbase-common in the patch passed. | | +1 | unit | 13745 | hbase-server in the patch passed. | | +1 | unit | 1383 | hbase-mapreduce in the patch passed. | | +1 | unit | 267 | hbase-endpoint in the patch passed. | | +1 | asflicense | 175 | The patch does not generate ASF License warnings. | | | | 19520 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-306/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/306 | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 1135bbe78868 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | master / ab4453158a | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.11 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-306/1/artifact/out/diff-checkstyle-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-306/1/testReport/ | | Max. process+thread count | 5608 (vs. ulimit of 1) | | modules | C: hbase-annotations hbase-common hbase-server hbase-mapreduce hbase-endpoint U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-306/1/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22574) hbase-filesystem does not build against HBase 1
[
https://issues.apache.org/jira/browse/HBASE-22574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864192#comment-16864192
]
Sean Busbey commented on HBASE-22574:
-
[~mackrorysd] can you regenerate your patch with {{format-patch}} and include
the two previous commits currently on the PR?
that will let me check with a single {{smart-apply-patch}} invocation. at the
moment I'll have to pull together the pieces manually.
> hbase-filesystem does not build against HBase 1
> ---
>
> Key: HBASE-22574
> URL: https://issues.apache.org/jira/browse/HBASE-22574
> Project: HBase
> Issue Type: Bug
> Components: Filesystem Integration
>Affects Versions: hbase-filesystem-1.0.0-alpha1
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
>Priority: Major
> Attachments: HBASE-22574-sean.patch, HBASE-22574.patch,
> HBASE-22574.patch, HBASE-22574.patch
>
>
> hbase-filesystem does not build against HBase 1 because HBase 1 does not
> provide a hbase-zookeeper module, which is a required dependency. This could
> be moved into a version specific build profile.
> $ mvn clean install package -Dhbase.version=1.4.10 -Dhadoop.version=2.9.2
> ...
> [ERROR] Failed to execute goal on project hbase-oss:
> Could not resolve dependencies for project
> org.apache.hbase.filesystem:hbase-oss:jar:1.0.0-alpha1:
> The following artifacts could not be resolved:
> org.apache.hbase:hbase-zookeeper:jar:1.4.10,
> org.apache.hbase:hbase-zookeeper:jar:tests:1.4.10:
> Could not find artifact org.apache.hbase:hbase-zookeeper:jar:1.4.10 in
> central (https://repo.maven.apache.org/maven2)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22586) Javadoc Warnings related to @param tag
[ https://issues.apache.org/jira/browse/HBASE-22586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Murtaza Hassan updated HBASE-22586: --- Description: Fix javadoc warnings related to @param tag. > Javadoc Warnings related to @param tag > -- > > Key: HBASE-22586 > URL: https://issues.apache.org/jira/browse/HBASE-22586 > Project: HBase > Issue Type: Bug > Components: documentation >Affects Versions: 3.0.0 >Reporter: Murtaza Hassan >Assignee: Murtaza Hassan >Priority: Trivial > Labels: beginner > Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6 > > > Fix javadoc warnings related to @param tag. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22586) Javadoc Warnings related to @param tag
[ https://issues.apache.org/jira/browse/HBASE-22586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Murtaza Hassan updated HBASE-22586: --- Fix Version/s: 2.1.6 2.2.1 2.3.0 3.0.0 > Javadoc Warnings related to @param tag > -- > > Key: HBASE-22586 > URL: https://issues.apache.org/jira/browse/HBASE-22586 > Project: HBase > Issue Type: Bug > Components: documentation >Affects Versions: 3.0.0 >Reporter: Murtaza Hassan >Assignee: Murtaza Hassan >Priority: Trivial > Labels: beginner > Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22586) Javadoc Warnings related to @param tag
[ https://issues.apache.org/jira/browse/HBASE-22586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Murtaza Hassan updated HBASE-22586: --- Labels: beginner (was: ) > Javadoc Warnings related to @param tag > -- > > Key: HBASE-22586 > URL: https://issues.apache.org/jira/browse/HBASE-22586 > Project: HBase > Issue Type: Bug > Components: documentation >Affects Versions: 3.0.0 >Reporter: Murtaza Hassan >Assignee: Murtaza Hassan >Priority: Trivial > Labels: beginner > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work started] (HBASE-22586) Javadoc Warnings related to @param tag
[ https://issues.apache.org/jira/browse/HBASE-22586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-22586 started by Murtaza Hassan. -- > Javadoc Warnings related to @param tag > -- > > Key: HBASE-22586 > URL: https://issues.apache.org/jira/browse/HBASE-22586 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Murtaza Hassan >Assignee: Murtaza Hassan >Priority: Trivial > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22586) Javadoc Warnings related to @param tag
[ https://issues.apache.org/jira/browse/HBASE-22586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Murtaza Hassan updated HBASE-22586: --- Affects Version/s: 3.0.0 > Javadoc Warnings related to @param tag > -- > > Key: HBASE-22586 > URL: https://issues.apache.org/jira/browse/HBASE-22586 > Project: HBase > Issue Type: Bug > Components: documentation >Affects Versions: 3.0.0 >Reporter: Murtaza Hassan >Assignee: Murtaza Hassan >Priority: Trivial > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (HBASE-22586) Javadoc Warnings related to @param tag
Murtaza Hassan created HBASE-22586: -- Summary: Javadoc Warnings related to @param tag Key: HBASE-22586 URL: https://issues.apache.org/jira/browse/HBASE-22586 Project: HBase Issue Type: Bug Components: documentation Reporter: Murtaza Hassan Assignee: Murtaza Hassan -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22585) Branch-2 build fails on Java 11
[ https://issues.apache.org/jira/browse/HBASE-22585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-22585: Component/s: java build > Branch-2 build fails on Java 11 > --- > > Key: HBASE-22585 > URL: https://issues.apache.org/jira/browse/HBASE-22585 > Project: HBase > Issue Type: Bug > Components: build, java >Reporter: Sakthi >Priority: Major > Labels: jdk11 > > Branch-2 build fails on Java 11. Complaints about the > hbase-shaded-check-invariants. Will paste the stacktrace if needed in the > comments. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (HBASE-22585) Branch-2 build fails on Java 11
Sakthi created HBASE-22585: -- Summary: Branch-2 build fails on Java 11 Key: HBASE-22585 URL: https://issues.apache.org/jira/browse/HBASE-22585 Project: HBase Issue Type: Bug Reporter: Sakthi Branch-2 build fails on Java 11. Complaints about the hbase-shaded-check-invariants. Will paste the stacktrace if needed in the comments. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
