[GitHub] [hbase] Apache-HBase commented on issue #424: HBASE-22758 Remove the unneccesary info cf deletion in DeleteTableProcedure#deleteFromMeta
Apache-HBase commented on issue #424: HBASE-22758 Remove the unneccesary info cf deletion in DeleteTableProcedure#deleteFromMeta URL: https://github.com/apache/hbase/pull/424#issuecomment-516274546 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 39 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 29 | Maven dependency ordering for branch | | +1 | mvninstall | 321 | master passed | | +1 | compile | 79 | master passed | | +1 | checkstyle | 110 | master passed | | +1 | shadedjars | 274 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 58 | master passed | | 0 | spotbugs | 251 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 314 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 14 | Maven dependency ordering for patch | | +1 | mvninstall | 306 | the patch passed | | +1 | compile | 81 | the patch passed | | +1 | javac | 81 | the patch passed | | +1 | checkstyle | 105 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 272 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 985 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 59 | the patch passed | | +1 | findbugs | 361 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 124 | hbase-client in the patch passed. | | +1 | unit | 8467 | hbase-server in the patch passed. | | +1 | asflicense | 45 | The patch does not generate ASF License warnings. | | | | 12458 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-424/9/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/424 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux d53ab8f09884 4.4.0-157-generic #185-Ubuntu SMP Tue Jul 23 09:17:01 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-424/out/precommit/personality/provided.sh | | git revision | master / 0c80d5b42b | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-424/9/testReport/ | | Max. process+thread count | 4560 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-424/9/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend
Apache-HBase commented on issue #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend URL: https://github.com/apache/hbase/pull/390#issuecomment-516274437 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 74 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 366 | master passed | | +1 | compile | 67 | master passed | | +1 | checkstyle | 96 | master passed | | +1 | shadedjars | 342 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 42 | master passed | | 0 | spotbugs | 313 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 310 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 384 | the patch passed | | +1 | compile | 71 | the patch passed | | +1 | javac | 71 | the patch passed | | -1 | checkstyle | 98 | hbase-server: The patch generated 12 new + 345 unchanged - 0 fixed = 357 total (was 345) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 340 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1152 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | -1 | javadoc | 43 | hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 | findbugs | 321 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 17239 | hbase-server in the patch failed. | | +1 | asflicense | 26 | The patch does not generate ASF License warnings. | | | | 21431 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestFromClientSide3 | | | hadoop.hbase.regionserver.TestHRegion | | | hadoop.hbase.TestZooKeeper | | | hadoop.hbase.client.TestFromClientSideWithCoprocessor | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/6/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/390 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 111f31787674 4.4.0-143-generic #169-Ubuntu SMP Thu Feb 7 07:56:38 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-390/out/precommit/personality/provided.sh | | git revision | master / 0c80d5b42b | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/6/artifact/out/diff-checkstyle-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/6/artifact/out/diff-javadoc-javadoc-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/6/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/6/testReport/ | | Max. process+thread count | 4762 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/6/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22723) Have CatalogJanitor report holes and overlaps; i.e. problems it sees when doing its regular scan of hbase:meta
[
https://issues.apache.org/jira/browse/HBASE-22723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895808#comment-16895808
]
Hudson commented on HBASE-22723:
Results for branch master
[build #1289 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1289/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1289//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1289//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1289//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Have CatalogJanitor report holes and overlaps; i.e. problems it sees when
> doing its regular scan of hbase:meta
> --
>
> Key: HBASE-22723
> URL: https://issues.apache.org/jira/browse/HBASE-22723
> Project: HBase
> Issue Type: Sub-task
>Reporter: stack
>Assignee: stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
> Attachments: HBASE-22723.branch-2.001.patch,
> HBASE-22723.branch-2.002.patch, HBASE-22723.branch-2.003.patch,
> HBASE-22723.branch-2.004.patch, HBASE-22723.branch-2.005.patch,
> HBASE-22723.branch-2.006.patch, HBASE-22723.branch-2.007.patch
>
>
> CatalogJanitor scans hbase:meta on a configurable period. Currently it just
> looks for splits and merges to gc. Might as well generate a report on stuff
> like holds, overlaps, empty regioninfos, and unknown servers while it is at
> it.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #420: HBASE-22753 Removed deprecated ImmutableHRegionInfo
Apache-HBase commented on issue #420: HBASE-22753 Removed deprecated ImmutableHRegionInfo URL: https://github.com/apache/hbase/pull/420#issuecomment-516270732 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 68 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 28 | Maven dependency ordering for branch | | -1 | mvninstall | 194 | root in master failed. | | +1 | compile | 106 | master passed | | +1 | checkstyle | 147 | master passed | | +1 | shadedjars | 388 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 67 | master passed | | 0 | spotbugs | 321 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 405 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 15 | Maven dependency ordering for patch | | -1 | mvninstall | 185 | root in the patch failed. | | +1 | compile | 103 | the patch passed | | +1 | javac | 103 | the patch passed | | +1 | checkstyle | 40 | hbase-client: The patch generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) | | +1 | checkstyle | 107 | hbase-server: The patch generated 0 new + 215 unchanged - 4 fixed = 215 total (was 219) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 363 | patch has no errors when building our shaded downstream artifacts. | | -1 | hadoopcheck | 120 | The patch causes 10 errors with Hadoop v2.8.5. | | -1 | hadoopcheck | 240 | The patch causes 10 errors with Hadoop v2.9.2. | | -1 | hadoopcheck | 368 | The patch causes 10 errors with Hadoop v3.1.2. | | +1 | javadoc | 69 | the patch passed | | +1 | findbugs | 407 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 129 | hbase-client in the patch passed. | | -1 | unit | 17254 | hbase-server in the patch failed. | | +1 | asflicense | 51 | The patch does not generate ASF License warnings. | | | | 20613 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.TestMasterShutdown | | | hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory | | | hadoop.hbase.client.TestFromClientSideWithCoprocessor | | | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas | | | hadoop.hbase.client.TestAsyncTableAdminApi | | | hadoop.hbase.client.TestFromClientSide3 | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-420/9/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/420 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux c1728ea06ad9 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-420/out/precommit/personality/provided.sh | | git revision | master / 0c80d5b42b | | Default Java | 1.8.0_181 | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-420/9/artifact/out/branch-mvninstall-root.txt | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-420/9/artifact/out/patch-mvninstall-root.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-420/9/artifact/out/patch-javac-2.8.5.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-420/9/artifact/out/patch-javac-2.9.2.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-420/9/artifact/out/patch-javac-3.1.2.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-420/9/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-420/9/testReport/ | | Max. process+thread count | 4963 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-420/9/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To
[jira] [Commented] (HBASE-21745) Make HBCK2 be able to fix issues other than region assignment
[ https://issues.apache.org/jira/browse/HBASE-21745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895796#comment-16895796 ] stack commented on HBASE-21745: --- Back after [~zghaobac] landed his new 'HBCK Report' in HBase UI and after adding reporting by CatalogJanitor on various issues w/ hbase:meta. UI is coming along so now to outstanding fixHoles, fixOverlaps, and orphans. On fixHoles: * Need to add to Hbck Interface a fixMeta method. It'll plug holes and overlaps found in hbase:meta by the new CatalogJanitor additions in HBASE-22723. If available on the server, HBCK2 would call it (later, could add an hbck shell command and it would call it instead -- could be part of a general plan of gradually moving hbck2 functionality over into server). Otherwise, if not available, HBCK2 would run its own attempt at fixing client-side where it did a scan of hbase:meta to find problems and then work on trying to fix anything it found -- a copy of the code we've added server-side. * But before fixing holes, operator should call addMissingRegionsToMeta -- the [~wchevreuil] addition over in HBASE-22567. It does better than hole fixing looking for candidate regions in fs with which it can plug holes. Could have the hole-fixer in HBCK2 call it first always (or maybe not if we are doing HBCK2 is made up of plumbing tools not trying to be porcelain). * fix overlaps is done by merging. The merge tool probably needs expansion. For example, it currently takes region names only. Would be handy if could pass rows in table so operator could ask merge all between two marker rows. Outstanding then is adopting orphans in hdfs. > Make HBCK2 be able to fix issues other than region assignment > - > > Key: HBASE-21745 > URL: https://issues.apache.org/jira/browse/HBASE-21745 > Project: HBase > Issue Type: Umbrella > Components: hbase-operator-tools, hbck2 >Reporter: Duo Zhang >Assignee: stack >Priority: Critical > > This is what [~apurtell] posted on mailing-list, HBCK2 should support > * -Rebuild meta from region metadata in the filesystem, aka offline meta > rebuild.- > * -Fix assignment errors (undeployed regions, double assignments (yes, > should not be possible), etc)- (See > https://issues.apache.org/jira/browse/HBASE-21745?focusedCommentId=16888302=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16888302) > * Fix region holes, overlaps, and other errors in the region chain > * Fix failed split and merge transactions that have failed to roll back due > to some bug (related to previous) > * -Enumerate store files to determine file level corruption and sideline > corrupt files- > * -Fix hfile link problems (dangling / broken)- -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #419: HBASE-22752 Removed the deprecated ImmutableHColumnDescriptor and ImmutableHTableDescriptor
Apache-HBase commented on issue #419: HBASE-22752 Removed the deprecated ImmutableHColumnDescriptor and ImmutableHTableDescriptor URL: https://github.com/apache/hbase/pull/419#issuecomment-516263851 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 213 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 3 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 28 | Maven dependency ordering for branch | | +1 | mvninstall | 312 | master passed | | +1 | compile | 72 | master passed | | +1 | checkstyle | 101 | master passed | | +1 | shadedjars | 265 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 55 | master passed | | 0 | spotbugs | 234 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 297 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 18 | Maven dependency ordering for patch | | +1 | mvninstall | 302 | the patch passed | | +1 | compile | 78 | the patch passed | | +1 | javac | 78 | the patch passed | | +1 | checkstyle | 30 | hbase-client: The patch generated 0 new + 0 unchanged - 4 fixed = 0 total (was 4) | | +1 | checkstyle | 76 | The patch passed checkstyle in hbase-server | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 270 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 900 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 55 | the patch passed | | +1 | findbugs | 309 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 110 | hbase-client in the patch passed. | | -1 | unit | 14771 | hbase-server in the patch failed. | | +1 | asflicense | 46 | The patch does not generate ASF License warnings. | | | | 18692 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-419/9/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/419 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 4db347ae7b67 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-419/out/precommit/personality/provided.sh | | git revision | master / 0c80d5b42b | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-419/9/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-419/9/testReport/ | | Max. process+thread count | 5082 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-419/9/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22735) list_regions may throw an error if a region is RIT
[
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895780#comment-16895780
]
stack commented on HBASE-22735:
---
lgtm
Mind pasting in a sample of what the output looks like now with your changes?
Thanks.
> list_regions may throw an error if a region is RIT
> --
>
> Key: HBASE-22735
> URL: https://issues.apache.org/jira/browse/HBASE-22735
> Project: HBase
> Issue Type: Bug
> Components: shell
>Affects Versions: 1.5.0
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22735.branch-1.01.patch,
> HBASE-22735.master.01.patch
>
>
> The 'list_regions' shell command gets a list of regions for a given table and
> then prints them and some attributes such as the server where they are
> located, current request count, data locality, and such.
> However if a region is in transition the command might fail with
> {{ERROR: undefined method `getDataLocality' for nil:NilClass}}
> and there may be other ways this can happen. Protect against use of nil
> references and just display what we can.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22741) Show catalogjanitor consistency complaints in new 'HBCK Report' page
[ https://issues.apache.org/jira/browse/HBASE-22741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895765#comment-16895765 ] stack commented on HBASE-22741: --- .002 addresses [~zghaobac] and [~openinx] review up on rb. > Show catalogjanitor consistency complaints in new 'HBCK Report' page > > > Key: HBASE-22741 > URL: https://issues.apache.org/jira/browse/HBASE-22741 > Project: HBase > Issue Type: Sub-task > Components: hbck2, UI >Reporter: stack >Assignee: stack >Priority: Major > Attachments: > 0001-HBASE-22741-Show-catalogjanitor-consistency-complain.patch, > HBASE-22741.master.001.patch, HBASE-22741.master.002.patch, Screen Shot > 2019-07-25 at 11.12.40 PM.png > > > HBASE-22723 makes it so catalogjanitor looks for holes and overlaps when it > scans hbase:meta. HBASE-22709 added a new HBCK Report page to the master in > which it notes findings its figured looking at regionserver reports and > current state of Master. > This issue is about exposing the inconsistencies found scanning hbase:meta in > the HBCK Report page. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22741) Show catalogjanitor consistency complaints in new 'HBCK Report' page
[ https://issues.apache.org/jira/browse/HBASE-22741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-22741: -- Attachment: HBASE-22741.master.002.patch > Show catalogjanitor consistency complaints in new 'HBCK Report' page > > > Key: HBASE-22741 > URL: https://issues.apache.org/jira/browse/HBASE-22741 > Project: HBase > Issue Type: Sub-task > Components: hbck2, UI >Reporter: stack >Assignee: stack >Priority: Major > Attachments: > 0001-HBASE-22741-Show-catalogjanitor-consistency-complain.patch, > HBASE-22741.master.001.patch, HBASE-22741.master.002.patch, Screen Shot > 2019-07-25 at 11.12.40 PM.png > > > HBASE-22723 makes it so catalogjanitor looks for holes and overlaps when it > scans hbase:meta. HBASE-22709 added a new HBCK Report page to the master in > which it notes findings its figured looking at regionserver reports and > current state of Master. > This issue is about exposing the inconsistencies found scanning hbase:meta in > the HBCK Report page. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22765) add move server & move table command in shell
[
https://issues.apache.org/jira/browse/HBASE-22765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zheng Hu updated HBASE-22765:
-
Description:
We add move_server and move_table command in shell internally to fix problems
like restarting the regionserver etc and find it is very useful, so plan to
port to branch-2 & branch-1
{code}
hbase(main):001:0> move_server
ERROR: wrong number of arguments (0 for 1)
Here is some help for this command:
Move all regions of the source server to a given target server, or randomly to
other servers if no target server specified
NOTE:
A server name is its host, port plus startcode. For example:
host187.example.com,60020,1289493121758
Examples:
hbase> move_server 'SOURCE_SEREVR', 'TARGET_SERVER'
hbase> move_server 'SOURCE_SERVER'
hbase(main):002:0> move_table
ERROR: wrong number of arguments (0 for 1)
Here is some help for this command:
Move all regions of the table to a regionserver. All regions will be moved to
the
given regionserver if the 'SERVER_NAME' is specified, or to a random
regionserver if
'SERVER_NAME' is absent
NOTE:
A server name is its host, port plus startcode. For example:
host187.example.com,60020,1289493121758
Examples:
hbase> move_table 'TABLENAME', 'SERVER_NAME'
hbase> move_table 'TABLENAME'
{code}
was:We add move_server and move_table command in shell internally to fix
problems like restarting the regionserver etc and find it is very useful, so
backport it
> add move server & move table command in shell
> --
>
> Key: HBASE-22765
> URL: https://issues.apache.org/jira/browse/HBASE-22765
> Project: HBase
> Issue Type: Improvement
>Reporter: Junhong Xu
>Assignee: Junhong Xu
>Priority: Major
>
> We add move_server and move_table command in shell internally to fix problems
> like restarting the regionserver etc and find it is very useful, so plan to
> port to branch-2 & branch-1
> {code}
> hbase(main):001:0> move_server
> ERROR: wrong number of arguments (0 for 1)
> Here is some help for this command:
> Move all regions of the source server to a given target server, or randomly to
> other servers if no target server specified
> NOTE:
> A server name is its host, port plus startcode. For example:
> host187.example.com,60020,1289493121758
> Examples:
> hbase> move_server 'SOURCE_SEREVR', 'TARGET_SERVER'
> hbase> move_server 'SOURCE_SERVER'
> hbase(main):002:0> move_table
> ERROR: wrong number of arguments (0 for 1)
> Here is some help for this command:
> Move all regions of the table to a regionserver. All regions will be moved to
> the
> given regionserver if the 'SERVER_NAME' is specified, or to a random
> regionserver if
> 'SERVER_NAME' is absent
> NOTE:
> A server name is its host, port plus startcode. For example:
> host187.example.com,60020,1289493121758
> Examples:
> hbase> move_table 'TABLENAME', 'SERVER_NAME'
> hbase> move_table 'TABLENAME'
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #419: HBASE-22752 Removed the deprecated ImmutableHColumnDescriptor and ImmutableHTableDescriptor
Apache-HBase commented on issue #419: HBASE-22752 Removed the deprecated ImmutableHColumnDescriptor and ImmutableHTableDescriptor URL: https://github.com/apache/hbase/pull/419#issuecomment-516246971 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 94 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 3 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 54 | Maven dependency ordering for branch | | -1 | mvninstall | 312 | root in master failed. | | +1 | compile | 73 | master passed | | +1 | checkstyle | 109 | master passed | | +1 | shadedjars | 295 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 56 | master passed | | 0 | spotbugs | 255 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 327 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 16 | Maven dependency ordering for patch | | -1 | mvninstall | 351 | root in the patch failed. | | +1 | compile | 81 | the patch passed | | +1 | javac | 81 | the patch passed | | +1 | checkstyle | 29 | hbase-client: The patch generated 0 new + 0 unchanged - 4 fixed = 0 total (was 4) | | +1 | checkstyle | 79 | The patch passed checkstyle in hbase-server | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 284 | patch has no errors when building our shaded downstream artifacts. | | -1 | hadoopcheck | 154 | The patch causes 10 errors with Hadoop v2.8.5. | | -1 | hadoopcheck | 339 | The patch causes 10 errors with Hadoop v2.9.2. | | -1 | hadoopcheck | 528 | The patch causes 10 errors with Hadoop v3.1.2. | | +1 | javadoc | 60 | the patch passed | | +1 | findbugs | 333 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 101 | hbase-client in the patch passed. | | -1 | unit | 16202 | hbase-server in the patch failed. | | +1 | asflicense | 54 | The patch does not generate ASF License warnings. | | | | 19538 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas | | | hadoop.hbase.client.TestFromClientSide3 | | | hadoop.hbase.client.TestCloneSnapshotFromClientNormal | | | hadoop.hbase.client.TestSnapshotCloneIndependence | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-419/8/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/419 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 61a974591462 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-419/out/precommit/personality/provided.sh | | git revision | master / f68cda32e1 | | Default Java | 1.8.0_181 | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-419/8/artifact/out/branch-mvninstall-root.txt | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-419/8/artifact/out/patch-mvninstall-root.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-419/8/artifact/out/patch-javac-2.8.5.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-419/8/artifact/out/patch-javac-2.9.2.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-419/8/artifact/out/patch-javac-3.1.2.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-419/8/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-419/8/testReport/ | | Max. process+thread count | 4946 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-419/8/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries
[GitHub] [hbase] Apache-HBase commented on issue #420: HBASE-22753 Removed deprecated ImmutableHRegionInfo
Apache-HBase commented on issue #420: HBASE-22753 Removed deprecated ImmutableHRegionInfo URL: https://github.com/apache/hbase/pull/420#issuecomment-516246231 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 70 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 41 | Maven dependency ordering for branch | | +1 | mvninstall | 329 | master passed | | +1 | compile | 85 | master passed | | +1 | checkstyle | 112 | master passed | | +1 | shadedjars | 298 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 58 | master passed | | 0 | spotbugs | 233 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 300 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 16 | Maven dependency ordering for patch | | +1 | mvninstall | 299 | the patch passed | | +1 | compile | 84 | the patch passed | | +1 | javac | 84 | the patch passed | | +1 | checkstyle | 30 | hbase-client: The patch generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) | | +1 | checkstyle | 81 | hbase-server: The patch generated 0 new + 215 unchanged - 4 fixed = 215 total (was 219) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 293 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 949 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 56 | the patch passed | | +1 | findbugs | 320 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 112 | hbase-client in the patch passed. | | -1 | unit | 15346 | hbase-server in the patch failed. | | +1 | asflicense | 53 | The patch does not generate ASF License warnings. | | | | 19315 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas | | | hadoop.hbase.client.TestFromClientSide3 | | | hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-420/8/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/420 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 95c24c411ca3 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-420/out/precommit/personality/provided.sh | | git revision | master / f68cda32e1 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-420/8/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-420/8/testReport/ | | Max. process+thread count | 4964 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-420/8/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #414: HBASE-22744 Removed deprecated status and load classes in client module
Apache-HBase commented on issue #414: HBASE-22744 Removed deprecated status and load classes in client module URL: https://github.com/apache/hbase/pull/414#issuecomment-516245714 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 72 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 6 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 15 | Maven dependency ordering for branch | | +1 | mvninstall | 331 | master passed | | +1 | compile | 126 | master passed | | +1 | checkstyle | 152 | master passed | | +1 | shadedjars | 293 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 90 | master passed | | 0 | spotbugs | 55 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 404 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 14 | Maven dependency ordering for patch | | +1 | mvninstall | 324 | the patch passed | | +1 | compile | 126 | the patch passed | | +1 | javac | 126 | the patch passed | | +1 | checkstyle | 36 | hbase-client: The patch generated 0 new + 180 unchanged - 3 fixed = 180 total (was 183) | | +1 | checkstyle | 13 | The patch passed checkstyle in hbase-zookeeper | | +1 | checkstyle | 88 | The patch passed checkstyle in hbase-server | | +1 | checkstyle | 18 | The patch passed checkstyle in hbase-rest | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 300 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 995 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 90 | the patch passed | | +1 | findbugs | 424 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 109 | hbase-client in the patch passed. | | +1 | unit | 48 | hbase-zookeeper in the patch passed. | | -1 | unit | 14003 | hbase-server in the patch failed. | | +1 | unit | 496 | hbase-rest in the patch passed. | | +1 | asflicense | 104 | The patch does not generate ASF License warnings. | | | | 19119 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.TestMasterShutdown | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-414/11/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/414 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux fb13be7fe543 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-414/out/precommit/personality/provided.sh | | git revision | master / f68cda32e1 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-414/11/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-414/11/testReport/ | | Max. process+thread count | 4739 (vs. ulimit of 1) | | modules | C: hbase-client hbase-zookeeper hbase-server hbase-rest U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-414/11/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (HBASE-22765) add move server & move table command in shell
Junhong Xu created HBASE-22765: -- Summary: add move server & move table command in shell Key: HBASE-22765 URL: https://issues.apache.org/jira/browse/HBASE-22765 Project: HBase Issue Type: Improvement Reporter: Junhong Xu Assignee: Junhong Xu We add move_server and move_table command in shell internally to fix problems like restarting the regionserver etc and find it is very useful, so backport it -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #403: HBASE-22707 [HBCK2] MasterRpcServices assigns method should try to reload regions from meta if the passed regions isn't found under AssignmentMan
Apache-HBase commented on issue #403: HBASE-22707 [HBCK2] MasterRpcServices assigns method should try to reload regions from meta if the passed regions isn't found under AssignmentManager RegionsStateStore URL: https://github.com/apache/hbase/pull/403#issuecomment-516245115 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 40 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 3 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 22 | Maven dependency ordering for branch | | +1 | mvninstall | 307 | master passed | | +1 | compile | 82 | master passed | | +1 | checkstyle | 107 | master passed | | +1 | shadedjars | 273 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 56 | master passed | | 0 | spotbugs | 254 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 324 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 14 | Maven dependency ordering for patch | | +1 | mvninstall | 321 | the patch passed | | +1 | compile | 83 | the patch passed | | +1 | javac | 83 | the patch passed | | -1 | checkstyle | 77 | hbase-server: The patch generated 3 new + 39 unchanged - 0 fixed = 42 total (was 39) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 282 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 981 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 53 | the patch passed | | +1 | findbugs | 352 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 108 | hbase-client in the patch passed. | | +1 | unit | 8454 | hbase-server in the patch passed. | | +1 | asflicense | 41 | The patch does not generate ASF License warnings. | | | | 12421 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/27/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/403 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux f250f5816b3e 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-403/out/precommit/personality/provided.sh | | git revision | master / 0c80d5b42b | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/27/artifact/out/diff-checkstyle-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/27/testReport/ | | Max. process+thread count | 4793 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/27/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #416: HBASE-22746 Removed deprecated methods from Delete
Apache-HBase commented on issue #416: HBASE-22746 Removed deprecated methods from Delete URL: https://github.com/apache/hbase/pull/416#issuecomment-516243446 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 40 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | 0 | mvndep | 18 | Maven dependency ordering for branch | | +1 | mvninstall | 306 | master passed | | +1 | compile | 79 | master passed | | +1 | checkstyle | 105 | master passed | | +1 | shadedjars | 271 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 55 | master passed | | 0 | spotbugs | 233 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 296 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 16 | Maven dependency ordering for patch | | +1 | mvninstall | 298 | the patch passed | | +1 | compile | 76 | the patch passed | | +1 | javac | 76 | the patch passed | | +1 | checkstyle | 30 | hbase-client: The patch generated 0 new + 5 unchanged - 1 fixed = 5 total (was 6) | | +1 | checkstyle | 78 | The patch passed checkstyle in hbase-server | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 268 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 918 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 52 | the patch passed | | +1 | findbugs | 315 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 108 | hbase-client in the patch passed. | | +1 | unit | 8107 | hbase-server in the patch passed. | | +1 | asflicense | 43 | The patch does not generate ASF License warnings. | | | | 11891 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-416/12/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/416 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 1d7a7fa14e07 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-416/out/precommit/personality/provided.sh | | git revision | master / 0c80d5b42b | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-416/12/testReport/ | | Max. process+thread count | 4937 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-416/12/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22751) table.jsp fails if ugly regions in table
[
https://issues.apache.org/jira/browse/HBASE-22751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895720#comment-16895720
]
Hudson commented on HBASE-22751:
Results for branch master
[build #1288 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1288/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1288//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1288//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1288//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> table.jsp fails if ugly regions in table
>
>
> Key: HBASE-22751
> URL: https://issues.apache.org/jira/browse/HBASE-22751
> Project: HBase
> Issue Type: Bug
> Components: UI
>Reporter: stack
>Assignee: stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
> Attachments: HBASE-22751.master.001.patch,
> HBASE-22751.master.001.patch
>
>
> I'm playing w/ messing up hbase:meta as part of hbck2 messings. Noticed that
> a bad server or an unknown region makes it so the table.jsp fails.
> I noticed that Admin trying to get the compaction stats for the table will
> get stuck trying to contact an unknown region and that when it does complete
> eventually (tens of minutes...), it will spew an exception in the compaction
> state location.
> The listing of servers has an issue where if unknown server, then we'll try
> to use a null address which does another spew of jsp complaint instead of
> just logging an unknown
> I tried messing around with Admin trying to set its Operation Timeout... but
> Operation Timeout is not really settable unless you get a new Configuration
> for a new Connection -- which is madness -- so instead just used the new
> AsyncAdminBuilder where I can set operation timeout
> It times out too quick but thats another issue the UI at least draws with
> a messy hbase;meta.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22751) table.jsp fails if ugly regions in table
[
https://issues.apache.org/jira/browse/HBASE-22751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895708#comment-16895708
]
Hudson commented on HBASE-22751:
Results for branch branch-2
[build #2128 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2128/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2128//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2128//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2128//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> table.jsp fails if ugly regions in table
>
>
> Key: HBASE-22751
> URL: https://issues.apache.org/jira/browse/HBASE-22751
> Project: HBase
> Issue Type: Bug
> Components: UI
>Reporter: stack
>Assignee: stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
> Attachments: HBASE-22751.master.001.patch,
> HBASE-22751.master.001.patch
>
>
> I'm playing w/ messing up hbase:meta as part of hbck2 messings. Noticed that
> a bad server or an unknown region makes it so the table.jsp fails.
> I noticed that Admin trying to get the compaction stats for the table will
> get stuck trying to contact an unknown region and that when it does complete
> eventually (tens of minutes...), it will spew an exception in the compaction
> state location.
> The listing of servers has an issue where if unknown server, then we'll try
> to use a null address which does another spew of jsp complaint instead of
> just logging an unknown
> I tried messing around with Admin trying to set its Operation Timeout... but
> Operation Timeout is not really settable unless you get a new Configuration
> for a new Connection -- which is madness -- so instead just used the new
> AsyncAdminBuilder where I can set operation timeout
> It times out too quick but thats another issue the UI at least draws with
> a messy hbase;meta.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22723) Have CatalogJanitor report holes and overlaps; i.e. problems it sees when doing its regular scan of hbase:meta
[
https://issues.apache.org/jira/browse/HBASE-22723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895704#comment-16895704
]
Hudson commented on HBASE-22723:
Results for branch branch-2.0
[build #1806 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1806/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1806//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1806//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1806//JDK8_Nightly_Build_Report_(Hadoop3)/]
(x) {color:red}-1 source release artifact{color}
-- See build output for details.
> Have CatalogJanitor report holes and overlaps; i.e. problems it sees when
> doing its regular scan of hbase:meta
> --
>
> Key: HBASE-22723
> URL: https://issues.apache.org/jira/browse/HBASE-22723
> Project: HBase
> Issue Type: Sub-task
>Reporter: stack
>Assignee: stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
> Attachments: HBASE-22723.branch-2.001.patch,
> HBASE-22723.branch-2.002.patch, HBASE-22723.branch-2.003.patch,
> HBASE-22723.branch-2.004.patch, HBASE-22723.branch-2.005.patch,
> HBASE-22723.branch-2.006.patch, HBASE-22723.branch-2.007.patch
>
>
> CatalogJanitor scans hbase:meta on a configurable period. Currently it just
> looks for splits and merges to gc. Might as well generate a report on stuff
> like holds, overlaps, empty regioninfos, and unknown servers while it is at
> it.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #419: HBASE-22752 Removed the deprecated ImmutableHColumnDescriptor and ImmutableHTableDescriptor
Apache-HBase commented on issue #419: HBASE-22752 Removed the deprecated ImmutableHColumnDescriptor and ImmutableHTableDescriptor URL: https://github.com/apache/hbase/pull/419#issuecomment-516230976 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 76 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 3 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 13 | Maven dependency ordering for branch | | -1 | mvninstall | 336 | root in master failed. | | +1 | compile | 83 | master passed | | +1 | checkstyle | 112 | master passed | | +1 | shadedjars | 278 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 55 | master passed | | 0 | spotbugs | 239 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 304 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 15 | Maven dependency ordering for patch | | -1 | mvninstall | 302 | root in the patch failed. | | +1 | compile | 77 | the patch passed | | +1 | javac | 77 | the patch passed | | +1 | checkstyle | 30 | hbase-client: The patch generated 0 new + 0 unchanged - 4 fixed = 0 total (was 4) | | +1 | checkstyle | 77 | The patch passed checkstyle in hbase-server | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 275 | patch has no errors when building our shaded downstream artifacts. | | -1 | hadoopcheck | 306 | The patch causes 10 errors with Hadoop v2.8.5. | | -1 | hadoopcheck | 624 | The patch causes 10 errors with Hadoop v2.9.2. | | -1 | hadoopcheck | 948 | The patch causes 10 errors with Hadoop v3.1.2. | | +1 | javadoc | 57 | the patch passed | | +1 | findbugs | 301 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 103 | hbase-client in the patch passed. | | -1 | unit | 20755 | hbase-server in the patch failed. | | +1 | asflicense | 60 | The patch does not generate ASF License warnings. | | | | 24347 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestCloneSnapshotFromClientNormal | | | hadoop.hbase.tool.TestSecureBulkLoadHFiles | | | hadoop.hbase.regionserver.TestRegionReplicaFailover | | | hadoop.hbase.client.TestConnection | | | hadoop.hbase.master.procedure.TestProcedurePriority | | | hadoop.hbase.client.TestAsyncTableAdminApi | | | hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated | | | hadoop.hbase.replication.TestReplicationSmallTestsSync | | | hadoop.hbase.tool.TestBulkLoadHFiles | | | hadoop.hbase.util.TestFromClientSide3WoUnsafe | | | hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory | | | hadoop.hbase.client.TestSnapshotTemporaryDirectory | | | hadoop.hbase.master.procedure.TestSCPWithReplicas | | | hadoop.hbase.replication.TestReplicationSmallTests | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-419/7/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/419 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 894f3edb89bb 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-419/out/precommit/personality/provided.sh | | git revision | master / 11f30de2cf | | Default Java | 1.8.0_181 | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-419/7/artifact/out/branch-mvninstall-root.txt | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-419/7/artifact/out/patch-mvninstall-root.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-419/7/artifact/out/patch-javac-2.8.5.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-419/7/artifact/out/patch-javac-2.9.2.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-419/7/artifact/out/patch-javac-3.1.2.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-419/7/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-419/7/testReport/ | | Max. process+thread count | 5032 (vs. ulimit of 1) | |
[jira] [Commented] (HBASE-22723) Have CatalogJanitor report holes and overlaps; i.e. problems it sees when doing its regular scan of hbase:meta
[
https://issues.apache.org/jira/browse/HBASE-22723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895701#comment-16895701
]
Hudson commented on HBASE-22723:
Results for branch branch-2.2
[build #477 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/477/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/477//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/477//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/477//JDK8_Nightly_Build_Report_(Hadoop3)/]
(x) {color:red}-1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
-- Something went wrong with this stage, [check relevant console
output|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/477//console].
> Have CatalogJanitor report holes and overlaps; i.e. problems it sees when
> doing its regular scan of hbase:meta
> --
>
> Key: HBASE-22723
> URL: https://issues.apache.org/jira/browse/HBASE-22723
> Project: HBase
> Issue Type: Sub-task
>Reporter: stack
>Assignee: stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
> Attachments: HBASE-22723.branch-2.001.patch,
> HBASE-22723.branch-2.002.patch, HBASE-22723.branch-2.003.patch,
> HBASE-22723.branch-2.004.patch, HBASE-22723.branch-2.005.patch,
> HBASE-22723.branch-2.006.patch, HBASE-22723.branch-2.007.patch
>
>
> CatalogJanitor scans hbase:meta on a configurable period. Currently it just
> looks for splits and merges to gc. Might as well generate a report on stuff
> like holds, overlaps, empty regioninfos, and unknown servers while it is at
> it.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22723) Have CatalogJanitor report holes and overlaps; i.e. problems it sees when doing its regular scan of hbase:meta
[
https://issues.apache.org/jira/browse/HBASE-22723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895699#comment-16895699
]
Hudson commented on HBASE-22723:
Results for branch branch-2.1
[build #1426 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1426/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1426//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1426//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1426//JDK8_Nightly_Build_Report_(Hadoop3)/]
(x) {color:red}-1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
-- Something went wrong with this stage, [check relevant console
output|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1426//console].
> Have CatalogJanitor report holes and overlaps; i.e. problems it sees when
> doing its regular scan of hbase:meta
> --
>
> Key: HBASE-22723
> URL: https://issues.apache.org/jira/browse/HBASE-22723
> Project: HBase
> Issue Type: Sub-task
>Reporter: stack
>Assignee: stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
> Attachments: HBASE-22723.branch-2.001.patch,
> HBASE-22723.branch-2.002.patch, HBASE-22723.branch-2.003.patch,
> HBASE-22723.branch-2.004.patch, HBASE-22723.branch-2.005.patch,
> HBASE-22723.branch-2.006.patch, HBASE-22723.branch-2.007.patch
>
>
> CatalogJanitor scans hbase:meta on a configurable period. Currently it just
> looks for splits and merges to gc. Might as well generate a report on stuff
> like holds, overlaps, empty regioninfos, and unknown servers while it is at
> it.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #425: HBASE-22737 Add a new admin method and shell cmd to trigger the hbck …
Apache-HBase commented on issue #425: HBASE-22737 Add a new admin method and shell cmd to trigger the hbck … URL: https://github.com/apache/hbase/pull/425#issuecomment-516227742 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 38 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 15 | Maven dependency ordering for branch | | +1 | mvninstall | 294 | master passed | | +1 | compile | 162 | master passed | | +1 | checkstyle | 152 | master passed | | +1 | shadedjars | 255 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 107 | master passed | | 0 | spotbugs | 88 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 523 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 13 | Maven dependency ordering for patch | | +1 | mvninstall | 273 | the patch passed | | +1 | compile | 159 | the patch passed | | +1 | cc | 159 | the patch passed | | +1 | javac | 159 | the patch passed | | +1 | checkstyle | 8 | The patch passed checkstyle in hbase-protocol-shaded | | -1 | checkstyle | 29 | hbase-client: The patch generated 2 new + 48 unchanged - 0 fixed = 50 total (was 48) | | +1 | checkstyle | 73 | hbase-server: The patch generated 0 new + 136 unchanged - 9 fixed = 136 total (was 145) | | +1 | checkstyle | 36 | The patch passed checkstyle in hbase-thrift | | +1 | checkstyle | 9 | The patch passed checkstyle in hbase-shell | | -1 | rubocop | 11 | The patch generated 3 new + 294 unchanged - 0 fixed = 297 total (was 294) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 260 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 868 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | hbaseprotoc | 149 | the patch passed | | +1 | javadoc | 107 | the patch passed | | +1 | findbugs | 558 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 35 | hbase-protocol-shaded in the patch passed. | | +1 | unit | 105 | hbase-client in the patch passed. | | +1 | unit | 8185 | hbase-server in the patch passed. | | +1 | unit | 214 | hbase-thrift in the patch passed. | | +1 | unit | 420 | hbase-shell in the patch passed. | | +1 | asflicense | 97 | The patch does not generate ASF License warnings. | | | | 13566 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/425 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc rubocop | | uname | Linux 9913453f4182 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-425/out/precommit/personality/provided.sh | | git revision | master / f68cda32e1 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/3/artifact/out/diff-checkstyle-hbase-client.txt | | rubocop | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/3/artifact/out/diff-patch-rubocop.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/3/testReport/ | | Max. process+thread count | 4643 (vs. ulimit of 1) | | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/3/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 rubocop=0.73.0 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] infraio commented on a change in pull request #425: HBASE-22737 Add a new admin method and shell cmd to trigger the hbck …
infraio commented on a change in pull request #425: HBASE-22737 Add a new admin
method and shell cmd to trigger the hbck …
URL: https://github.com/apache/hbase/pull/425#discussion_r308500878
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java
##
@@ -1499,6 +1492,17 @@ public RunCatalogScanResponse
runCatalogScan(RpcController c,
}
}
+ @Override
+ public RunHbckChoreResponse runHbckChore(RpcController c,
RunHbckChoreRequest req)
+ throws ServiceException {
+rpcPreCheck("runHbckChore");
+HbckChore hbckChore = master.getHbckChore();
+if (!hbckChore.isRunning()) {
Review comment:
Ok. Return false if the HBCK chore already running.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] infraio commented on a change in pull request #425: HBASE-22737 Add a new admin method and shell cmd to trigger the hbck …
infraio commented on a change in pull request #425: HBASE-22737 Add a new admin method and shell cmd to trigger the hbck … URL: https://github.com/apache/hbase/pull/425#discussion_r308500993 ## File path: hbase-shell/src/main/ruby/hbase/admin.rb ## @@ -266,6 +266,12 @@ def in_maintenance_mode? @admin.isMasterInMaintenanceMode end + #-- +# Request HBCK chore to run +def hbck_chore_run + @admin.runHbckChore Review comment: OK. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] infraio commented on a change in pull request #425: HBASE-22737 Add a new admin method and shell cmd to trigger the hbck …
infraio commented on a change in pull request #425: HBASE-22737 Add a new admin
method and shell cmd to trigger the hbck …
URL: https://github.com/apache/hbase/pull/425#discussion_r308500798
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HbckChore.java
##
@@ -47,11 +47,11 @@
*/
@InterfaceAudience.Private
@InterfaceStability.Evolving
-public class HbckChecker extends ScheduledChore {
- private static final Logger LOG =
LoggerFactory.getLogger(HbckChecker.class.getName());
+public class HbckChore extends ScheduledChore {
+ private static final Logger LOG =
LoggerFactory.getLogger(HbckChore.class.getName());
- private static final String HBCK_CHECKER_INTERVAL =
"hbase.master.hbck.checker.interval";
- private static final int DEFAULT_HBCK_CHECKER_INTERVAL = 60 * 60 * 1000;
+ private static final String HBCK_CHORE_INTERVAL =
"hbase.master.hbck.chore.interval";
+ private static final int DEFAULT_HBCK_CHORE_INTERVAL = 60 * 60 * 1000;
Review comment:
Updated HBASE-22709's RN.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #424: HBASE-22758 Remove the unneccesary info cf deletion in DeleteTableProcedure#deleteFromMeta
Apache-HBase commented on issue #424: HBASE-22758 Remove the unneccesary info cf deletion in DeleteTableProcedure#deleteFromMeta URL: https://github.com/apache/hbase/pull/424#issuecomment-516222681 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 37 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | 0 | mvndep | 12 | Maven dependency ordering for branch | | +1 | mvninstall | 280 | master passed | | +1 | compile | 78 | master passed | | +1 | checkstyle | 100 | master passed | | +1 | shadedjars | 261 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 53 | master passed | | 0 | spotbugs | 229 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 290 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 14 | Maven dependency ordering for patch | | +1 | mvninstall | 280 | the patch passed | | +1 | compile | 79 | the patch passed | | +1 | javac | 79 | the patch passed | | +1 | checkstyle | 97 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 254 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 855 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 52 | the patch passed | | +1 | findbugs | 304 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 104 | hbase-client in the patch passed. | | +1 | unit | 8380 | hbase-server in the patch passed. | | +1 | asflicense | 43 | The patch does not generate ASF License warnings. | | | | 11934 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-424/7/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/424 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux c164298a26ff 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-424/out/precommit/personality/provided.sh | | git revision | master / f68cda32e1 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-424/7/testReport/ | | Max. process+thread count | 4838 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-424/7/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-22709) Add a chore thread in master to do hbck checking and display results in 'HBCK Report' page
[ https://issues.apache.org/jira/browse/HBASE-22709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-22709: --- Release Note: 1. Add a new chore thread in master to do hbck checking 2. Add a new web ui "HBCK Report" page to display checking results. This feature is enabled by default. And the hbck chore run per 60 minutes by default. You can config "hbase.master.hbck.checker.interval" to change the period. Notice: the config "hbase.master.hbck.checker.interval" was renamed to "hbase.master.hbck.chore.interval" in HBASE-22737. was: 1. Add a new chore thread in master to do hbck checking 2. Add a new web ui "HBCK Report" page to display checking results. This feature is enabled by default. And the hbck chore run per 60 minutes by default. You can config "hbase.master.hbck.checker.interval" to change the period. > Add a chore thread in master to do hbck checking and display results in 'HBCK > Report' page > -- > > Key: HBASE-22709 > URL: https://issues.apache.org/jira/browse/HBASE-22709 > Project: HBase > Issue Type: Sub-task >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6 > > Attachments: HBASE-22709.master.001.patch > > > See HBASE-21965. There may have two type of failed splited/merged regions. > One is orphan region on filesystem. Another one is unassigned daughter > regions or merged regions. Plan to add a seperate hbck.jsp for them. Will add > more hbck problems to this UI in future. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] openinx commented on issue #424: HBASE-22758 Remove the unneccesary info cf deletion in DeleteTableProcedure#deleteFromMeta
openinx commented on issue #424: HBASE-22758 Remove the unneccesary info cf deletion in DeleteTableProcedure#deleteFromMeta URL: https://github.com/apache/hbase/pull/424#issuecomment-516221227 OK, the new introduced TestCatalogJanitorCluster is depending on the deleteRegions now, it will broke the compiling. Let me update the patch. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend
Apache-HBase commented on issue #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend URL: https://github.com/apache/hbase/pull/390#issuecomment-516219231 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 96 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 286 | master passed | | +1 | compile | 52 | master passed | | +1 | checkstyle | 74 | master passed | | +1 | shadedjars | 264 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 33 | master passed | | 0 | spotbugs | 236 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 235 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 297 | the patch passed | | +1 | compile | 53 | the patch passed | | +1 | javac | 53 | the patch passed | | -1 | checkstyle | 80 | hbase-server: The patch generated 12 new + 345 unchanged - 0 fixed = 357 total (was 345) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 272 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 910 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | -1 | javadoc | 33 | hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 | findbugs | 249 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 7482 | hbase-server in the patch failed. | | +1 | asflicense | 24 | The patch does not generate ASF License warnings. | | | | 10802 | | | Reason | Tests | |---:|:--| | Failed junit tests | TEST-[1] | | | hadoop.hbase.client.TestSnapshotFromClientWithRegionReplicas | | | hadoop.hbase.TestNamespace | | | hadoop.hbase.regionserver.TestEncryptionRandomKeying | | | hadoop.hbase.filter.TestScanRowPrefix | | | hadoop.hbase.client.TestMobCloneSnapshotFromClientAfterSplittingRegion | | | hadoop.hbase.security.token.TestDelegationTokenWithEncryption | | | hadoop.hbase.client.TestScannerTimeout | | | hadoop.hbase.filter.TestFilterListOnMini | | | hadoop.hbase.client.TestAsyncTableLocatePrefetch | | | hadoop.hbase.client.TestServerBusyException | | | hadoop.hbase.regionserver.TestHRegion | | | hadoop.hbase.security.token.TestZKSecretWatcher | | | hadoop.hbase.regionserver.wal.TestAsyncWALReplayCompressed | | | hadoop.hbase.replication.multiwal.TestReplicationKillMasterRSCompressedWithMultipleAsyncWAL | | | hadoop.hbase.client.TestAsyncReplicationAdminApi | | | hadoop.hbase.client.TestAsyncClusterAdminApi | | | hadoop.hbase.client.TestMobRestoreSnapshotFromClientClone | | | hadoop.hbase.client.TestResultFromCoprocessor | | | hadoop.hbase.replication.TestReplicationWithTags | | | hadoop.hbase.client.TestAsyncNonMetaRegionLocator | | | hadoop.hbase.client.TestAsyncRegionAdminApi | | | hadoop.hbase.client.TestMobRestoreSnapshotFromClientGetCompactionState | | | hadoop.hbase.fs.TestBlockReorderMultiBlocks | | | hadoop.hbase.TestMultiVersions | | | hadoop.hbase.TestAcidGuaranteesWithNoInMemCompaction | | | hadoop.hbase.client.TestReplicasClient | | | hadoop.hbase.client.TestAvoidCellReferencesIntoShippedBlocks | | | hadoop.hbase.wal.TestWALSplitCompressed | | | hadoop.hbase.replication.regionserver.TestSyncReplicationShipperQuit | | | hadoop.hbase.client.TestUpdateConfiguration | | | hadoop.hbase.replication.TestVerifyCellsReplicationEndpoint | | | hadoop.hbase.security.visibility.TestVisibilityLabelReplicationWithExpAsString | | | hadoop.hbase.client.TestClientOperationInterrupt | | | hadoop.hbase.security.token.TestGenerateDelegationToken | | | hadoop.hbase.client.TestRegionLocator | | | hadoop.hbase.client.TestAdmin1 | | | hadoop.hbase.client.TestAsyncTableScan | | | hadoop.hbase.client.TestCIGetOperationTimeout | | | hadoop.hbase.replication.regionserver.TestReplicationSink | | | hadoop.hbase.fs.TestBlockReorderBlockLocation | | | hadoop.hbase.replication.regionserver.TestReplicationSource | | | hadoop.hbase.client.TestAsyncTableGetMultiThreaded | | | hadoop.hbase.replication.TestReplicationStatusSourceStartedTargetStoppedNewOp | | | hadoop.hbase.util.TestRegionMover | | | hadoop.hbase.client.TestAsyncClientPauseForCallQueueTooBig | | | hadoop.hbase.replication.TestSyncReplicationActive | | |
[GitHub] [hbase] Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent
Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent URL: https://github.com/apache/hbase/pull/387#issuecomment-516216540 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 64 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 295 | master passed | | +1 | compile | 25 | master passed | | +1 | checkstyle | 15 | master passed | | +1 | shadedjars | 272 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 20 | master passed | | 0 | spotbugs | 42 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 39 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 297 | the patch passed | | +1 | compile | 23 | the patch passed | | +1 | javac | 23 | the patch passed | | +1 | checkstyle | 12 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 266 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 870 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 21 | the patch passed | | +1 | findbugs | 50 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 689 | hbase-rsgroup in the patch passed. | | +1 | asflicense | 26 | The patch does not generate ASF License warnings. | | | | 3345 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/30/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/387 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 2e7c3cba9c84 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-387/out/precommit/personality/provided.sh | | git revision | master / 0c80d5b42b | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/30/testReport/ | | Max. process+thread count | 4514 (vs. ulimit of 1) | | modules | C: hbase-rsgroup U: hbase-rsgroup | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/30/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #374: HBASE-22677 Add unit tests for org.apache.hadoop.hbase.util.ByteRangeUtils and Classes
Apache-HBase commented on issue #374: HBASE-22677 Add unit tests for org.apache.hadoop.hbase.util.ByteRangeUtils and Classes URL: https://github.com/apache/hbase/pull/374#issuecomment-516216306 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 88 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 333 | master passed | | +1 | compile | 24 | master passed | | +1 | checkstyle | 26 | master passed | | +1 | shadedjars | 299 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 21 | master passed | | 0 | spotbugs | 54 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 52 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 335 | the patch passed | | +1 | compile | 23 | the patch passed | | +1 | javac | 23 | the patch passed | | -1 | checkstyle | 27 | hbase-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 304 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1019 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 21 | the patch passed | | +1 | findbugs | 63 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 177 | hbase-common in the patch passed. | | +1 | asflicense | 12 | The patch does not generate ASF License warnings. | | | | 3251 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/32/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/374 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 34d0fb9275f5 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-374/out/precommit/personality/provided.sh | | git revision | master / 0c80d5b42b | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/32/artifact/out/diff-checkstyle-hbase-common.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/32/testReport/ | | Max. process+thread count | 258 (vs. ulimit of 1) | | modules | C: hbase-common U: hbase-common | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/32/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #431: HBASE-22764 Fixed remaining Checkstyle issues in the hbase-rsgroup module
Apache-HBase commented on issue #431: HBASE-22764 Fixed remaining Checkstyle issues in the hbase-rsgroup module URL: https://github.com/apache/hbase/pull/431#issuecomment-516215115 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 84 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 348 | master passed | | +1 | compile | 26 | master passed | | +1 | checkstyle | 14 | master passed | | +1 | shadedjars | 298 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 26 | master passed | | 0 | spotbugs | 49 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 47 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 347 | the patch passed | | +1 | compile | 29 | the patch passed | | +1 | javac | 29 | the patch passed | | +1 | checkstyle | 15 | hbase-rsgroup: The patch generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 317 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1010 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 20 | the patch passed | | +1 | findbugs | 62 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 405 | hbase-rsgroup in the patch passed. | | +1 | asflicense | 10 | The patch does not generate ASF License warnings. | | | | 3468 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-431/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/431 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 56343110144a 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-431/out/precommit/personality/provided.sh | | git revision | master / 0c80d5b42b | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-431/3/testReport/ | | Max. process+thread count | 4553 (vs. ulimit of 1) | | modules | C: hbase-rsgroup U: hbase-rsgroup | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-431/3/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator
Apache-HBase commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator URL: https://github.com/apache/hbase/pull/343#issuecomment-516215097 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 113 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-2.1 Compile Tests _ | | -1 | mvninstall | 180 | root in branch-2.1 failed. | | +1 | compile | 23 | branch-2.1 passed | | +1 | checkstyle | 33 | branch-2.1 passed | | -1 | shadedjars | 180 | branch has 36 errors when building our shaded downstream artifacts. | | +1 | javadoc | 22 | branch-2.1 passed | | 0 | spotbugs | 77 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 74 | branch-2.1 passed | ||| _ Patch Compile Tests _ | | -1 | mvninstall | 164 | root in the patch failed. | | +1 | compile | 23 | the patch passed | | +1 | javac | 23 | the patch passed | | +1 | checkstyle | 33 | hbase-client: The patch generated 0 new + 58 unchanged - 4 fixed = 58 total (was 62) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | -1 | shadedjars | 180 | patch has 36 errors when building our shaded downstream artifacts. | | -1 | hadoopcheck | 104 | The patch causes 36 errors with Hadoop v2.7.7. | | -1 | hadoopcheck | 233 | The patch causes 36 errors with Hadoop v2.8.5. | | -1 | hadoopcheck | 375 | The patch causes 36 errors with Hadoop v3.0.3. | | -1 | hadoopcheck | 505 | The patch causes 36 errors with Hadoop v3.1.2. | | +1 | javadoc | 24 | the patch passed | | +1 | findbugs | 85 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 202 | hbase-client in the patch passed. | | +1 | asflicense | 10 | The patch does not generate ASF License warnings. | | | | 1921 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/20/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/343 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux c4b55657540c 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-343/out/precommit/personality/provided.sh | | git revision | branch-2.1 / 65a6b270dd | | Default Java | 1.8.0_181 | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/20/artifact/out/branch-mvninstall-root.txt | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/20/artifact/out/branch-shadedjars.txt | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/20/artifact/out/patch-mvninstall-root.txt | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/20/artifact/out/patch-shadedjars.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/20/artifact/out/patch-javac-2.7.7.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/20/artifact/out/patch-javac-2.8.5.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/20/artifact/out/patch-javac-3.0.3.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/20/artifact/out/patch-javac-3.1.2.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/20/testReport/ | | Max. process+thread count | 299 (vs. ulimit of 1) | | modules | C: hbase-client U: hbase-client | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/20/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #430: HBASE-22763 Fixed remaining Checkstyle issue in hbase-procedure
Apache-HBase commented on issue #430: HBASE-22763 Fixed remaining Checkstyle issue in hbase-procedure URL: https://github.com/apache/hbase/pull/430#issuecomment-516214457 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 81 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 333 | master passed | | +1 | compile | 18 | master passed | | +1 | checkstyle | 14 | master passed | | +1 | shadedjars | 309 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 16 | master passed | | 0 | spotbugs | 37 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 35 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 329 | the patch passed | | +1 | compile | 18 | the patch passed | | +1 | javac | 18 | the patch passed | | +1 | checkstyle | 16 | hbase-procedure: The patch generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 304 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1030 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 16 | the patch passed | | +1 | findbugs | 46 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 210 | hbase-procedure in the patch passed. | | +1 | asflicense | 11 | The patch does not generate ASF License warnings. | | | | 3200 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-430/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/430 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 0dfed9118db4 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-430/out/precommit/personality/provided.sh | | git revision | master / 0c80d5b42b | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-430/3/testReport/ | | Max. process+thread count | 291 (vs. ulimit of 1) | | modules | C: hbase-procedure U: hbase-procedure | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-430/3/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #392: HBASE-22714 - Fix opertationTimeout typo
Apache-HBase commented on issue #392: HBASE-22714 - Fix opertationTimeout typo URL: https://github.com/apache/hbase/pull/392#issuecomment-516214070 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 64 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | -1 | mvninstall | 312 | root in master failed. | | +1 | compile | 25 | master passed | | +1 | checkstyle | 28 | master passed | | +1 | shadedjars | 258 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 21 | master passed | | 0 | spotbugs | 65 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 64 | master passed | ||| _ Patch Compile Tests _ | | -1 | mvninstall | 316 | root in the patch failed. | | +1 | compile | 26 | the patch passed | | +1 | javac | 26 | the patch passed | | +1 | checkstyle | 31 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 301 | patch has no errors when building our shaded downstream artifacts. | | -1 | hadoopcheck | 274 | The patch causes 10 errors with Hadoop v2.8.5. | | -1 | hadoopcheck | 552 | The patch causes 10 errors with Hadoop v2.9.2. | | -1 | hadoopcheck | 795 | The patch causes 10 errors with Hadoop v3.1.2. | | -1 | javadoc | 21 | hbase-client generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2) | | +1 | findbugs | 72 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 107 | hbase-client in the patch passed. | | +1 | asflicense | 10 | The patch does not generate ASF License warnings. | | | | 2513 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-392/33/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/392 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux a86341ab074d 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-392/out/precommit/personality/provided.sh | | git revision | master / 0c80d5b42b | | Default Java | 1.8.0_181 | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-392/33/artifact/out/branch-mvninstall-root.txt | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-392/33/artifact/out/patch-mvninstall-root.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-392/33/artifact/out/patch-javac-2.8.5.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-392/33/artifact/out/patch-javac-2.9.2.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-392/33/artifact/out/patch-javac-3.1.2.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-392/33/artifact/out/diff-javadoc-javadoc-hbase-client.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-392/33/testReport/ | | Max. process+thread count | 296 (vs. ulimit of 1) | | modules | C: hbase-client U: hbase-client | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-392/33/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #424: HBASE-22758 Remove the unneccesary info cf deletion in DeleteTableProcedure#deleteFromMeta
Apache-HBase commented on issue #424: HBASE-22758 Remove the unneccesary info cf deletion in DeleteTableProcedure#deleteFromMeta URL: https://github.com/apache/hbase/pull/424#issuecomment-516213931 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 67 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | 0 | mvndep | 17 | Maven dependency ordering for branch | | +1 | mvninstall | 316 | master passed | | +1 | compile | 84 | master passed | | +1 | checkstyle | 108 | master passed | | +1 | shadedjars | 272 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 58 | master passed | | 0 | spotbugs | 248 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 316 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 14 | Maven dependency ordering for patch | | -1 | mvninstall | 165 | root in the patch failed. | | -1 | compile | 52 | hbase-server in the patch failed. | | -1 | javac | 52 | hbase-server in the patch failed. | | +1 | checkstyle | 107 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | -1 | shadedjars | 215 | patch has 16 errors when building our shaded downstream artifacts. | | -1 | hadoopcheck | 123 | The patch causes 16 errors with Hadoop v2.8.5. | | -1 | hadoopcheck | 248 | The patch causes 16 errors with Hadoop v2.9.2. | | -1 | hadoopcheck | 380 | The patch causes 16 errors with Hadoop v3.1.2. | | +1 | javadoc | 57 | the patch passed | | -1 | findbugs | 56 | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 | unit | 111 | hbase-client in the patch passed. | | -1 | unit | 53 | hbase-server in the patch failed. | | +1 | asflicense | 22 | The patch does not generate ASF License warnings. | | | | 2649 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-424/8/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/424 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 65feddcc6fb7 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-424/out/precommit/personality/provided.sh | | git revision | master / 0c80d5b42b | | Default Java | 1.8.0_181 | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-424/8/artifact/out/patch-mvninstall-root.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-424/8/artifact/out/patch-compile-hbase-server.txt | | javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-424/8/artifact/out/patch-compile-hbase-server.txt | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-424/8/artifact/out/patch-shadedjars.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-424/8/artifact/out/patch-javac-2.8.5.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-424/8/artifact/out/patch-javac-2.9.2.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-424/8/artifact/out/patch-javac-3.1.2.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-424/8/artifact/out/patch-findbugs-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-424/8/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-424/8/testReport/ | | Max. process+thread count | 293 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-424/8/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the
[GitHub] [hbase] Apache-HBase commented on issue #411: HBASE-22739 check bound where removeRegion
Apache-HBase commented on issue #411: HBASE-22739 check bound where removeRegion URL: https://github.com/apache/hbase/pull/411#issuecomment-516213599 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 63 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-2.1 Compile Tests _ | | -1 | mvninstall | 134 | root in branch-2.1 failed. | | -1 | compile | 33 | hbase-server in branch-2.1 failed. | | +1 | checkstyle | 69 | branch-2.1 passed | | -1 | shadedjars | 159 | branch has 36 errors when building our shaded downstream artifacts. | | +1 | javadoc | 29 | branch-2.1 passed | | 0 | spotbugs | 222 | Used deprecated FindBugs config; considering switching to SpotBugs. | | -1 | findbugs | 33 | hbase-server in branch-2.1 failed. | ||| _ Patch Compile Tests _ | | -1 | mvninstall | 131 | root in the patch failed. | | -1 | compile | 34 | hbase-server in the patch failed. | | -1 | javac | 34 | hbase-server in the patch failed. | | -1 | checkstyle | 71 | hbase-server: The patch generated 1 new + 61 unchanged - 0 fixed = 62 total (was 61) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | -1 | shadedjars | 160 | patch has 36 errors when building our shaded downstream artifacts. | | -1 | hadoopcheck | 89 | The patch causes 36 errors with Hadoop v2.7.7. | | -1 | hadoopcheck | 186 | The patch causes 36 errors with Hadoop v2.8.5. | | -1 | hadoopcheck | 284 | The patch causes 36 errors with Hadoop v3.0.3. | | -1 | hadoopcheck | 378 | The patch causes 36 errors with Hadoop v3.1.2. | | +1 | javadoc | 29 | the patch passed | | -1 | findbugs | 33 | hbase-server in the patch failed. | ||| _ Other Tests _ | | -1 | unit | 33 | hbase-server in the patch failed. | | +1 | asflicense | 9 | The patch does not generate ASF License warnings. | | | | 1453 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/8/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/411 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 2f7040e2a26e 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-411/out/precommit/personality/provided.sh | | git revision | branch-2.1 / 65a6b270dd | | Default Java | 1.8.0_181 | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/8/artifact/out/branch-mvninstall-root.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/8/artifact/out/branch-compile-hbase-server.txt | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/8/artifact/out/branch-shadedjars.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/8/artifact/out/branch-findbugs-hbase-server.txt | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/8/artifact/out/patch-mvninstall-root.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/8/artifact/out/patch-compile-hbase-server.txt | | javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/8/artifact/out/patch-compile-hbase-server.txt | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/8/artifact/out/diff-checkstyle-hbase-server.txt | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/8/artifact/out/patch-shadedjars.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/8/artifact/out/patch-javac-2.7.7.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/8/artifact/out/patch-javac-2.8.5.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/8/artifact/out/patch-javac-3.0.3.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/8/artifact/out/patch-javac-3.1.2.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/8/artifact/out/patch-findbugs-hbase-server.txt | | unit |
[GitHub] [hbase] Apache-HBase commented on issue #427: HBASE-22759 Add user info to AUDITLOG events when doing grant/revoke (2.1)
Apache-HBase commented on issue #427: HBASE-22759 Add user info to AUDITLOG events when doing grant/revoke (2.1) URL: https://github.com/apache/hbase/pull/427#issuecomment-516211985 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 71 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-2.1 Compile Tests _ | | -1 | mvninstall | 79 | root in branch-2.1 failed. | | -1 | compile | 12 | hbase-server in branch-2.1 failed. | | -1 | checkstyle | 9 | The patch fails to run checkstyle in hbase-server | | -1 | shadedjars | 169 | branch has 36 errors when building our shaded downstream artifacts. | | -1 | javadoc | 8 | hbase-server in branch-2.1 failed. | | 0 | spotbugs | 187 | Used deprecated FindBugs config; considering switching to SpotBugs. | | -1 | findbugs | 8 | hbase-server in branch-2.1 failed. | ||| _ Patch Compile Tests _ | | -1 | mvninstall | 71 | root in the patch failed. | | -1 | compile | 8 | hbase-server in the patch failed. | | -1 | javac | 8 | hbase-server in the patch failed. | | -1 | checkstyle | 6 | The patch fails to run checkstyle in hbase-server | | +1 | whitespace | 0 | The patch has no whitespace issues. | | -1 | shadedjars | 171 | patch has 36 errors when building our shaded downstream artifacts. | | -1 | hadoopcheck | 65 | The patch causes 10 errors with Hadoop v2.7.7. | | -1 | hadoopcheck | 133 | The patch causes 10 errors with Hadoop v2.8.5. | | -1 | hadoopcheck | 204 | The patch causes 10 errors with Hadoop v3.0.3. | | -1 | hadoopcheck | 275 | The patch causes 10 errors with Hadoop v3.1.2. | | -1 | javadoc | 10 | hbase-server in the patch failed. | | -1 | findbugs | 9 | hbase-server in the patch failed. | ||| _ Other Tests _ | | -1 | unit | 10 | hbase-server in the patch failed. | | +1 | asflicense | 10 | The patch does not generate ASF License warnings. | | | | 1004 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/427 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux b1fb3c3ba2e7 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-427/out/precommit/personality/provided.sh | | git revision | branch-2.1 / 65a6b270dd | | Default Java | 1.8.0_181 | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/3/artifact/out/branch-mvninstall-root.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/3/artifact/out/branch-compile-hbase-server.txt | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/3/artifact/out//home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-427/out/maven-branch-checkstyle-hbase-server.txt | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/3/artifact/out/branch-shadedjars.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/3/artifact/out/branch-javadoc-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/3/artifact/out/branch-findbugs-hbase-server.txt | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/3/artifact/out/patch-mvninstall-root.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/3/artifact/out/patch-compile-hbase-server.txt | | javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/3/artifact/out/patch-compile-hbase-server.txt | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/3/artifact/out//home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-427/out/maven-patch-checkstyle-hbase-server.txt | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/3/artifact/out/patch-shadedjars.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/3/artifact/out/patch-javac-2.7.7.txt | | hadoopcheck |
[GitHub] [hbase] Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien…
Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien… URL: https://github.com/apache/hbase/pull/361#issuecomment-516211533 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 89 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 23 | Maven dependency ordering for branch | | -1 | mvninstall | 77 | root in master failed. | | -1 | compile | 19 | hbase-client in master failed. | | -1 | compile | 35 | hbase-server in master failed. | | +1 | checkstyle | 98 | master passed | | +1 | shadedjars | 278 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 53 | master passed | | 0 | spotbugs | 387 | Used deprecated FindBugs config; considering switching to SpotBugs. | | -1 | findbugs | 20 | hbase-client in master failed. | | -1 | findbugs | 35 | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | 0 | mvndep | 15 | Maven dependency ordering for patch | | -1 | mvninstall | 82 | root in the patch failed. | | -1 | compile | 20 | hbase-client in the patch failed. | | -1 | compile | 34 | hbase-server in the patch failed. | | -1 | javac | 20 | hbase-client in the patch failed. | | -1 | javac | 34 | hbase-server in the patch failed. | | +1 | checkstyle | 102 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 268 | patch has no errors when building our shaded downstream artifacts. | | -1 | hadoopcheck | 55 | The patch causes 10 errors with Hadoop v2.8.5. | | -1 | hadoopcheck | 109 | The patch causes 10 errors with Hadoop v2.9.2. | | -1 | hadoopcheck | 166 | The patch causes 10 errors with Hadoop v3.1.2. | | -1 | javadoc | 33 | hbase-server generated 28 new + 7 unchanged - 0 fixed = 35 total (was 7) | | -1 | findbugs | 20 | hbase-client in the patch failed. | | -1 | findbugs | 37 | hbase-server in the patch failed. | ||| _ Other Tests _ | | -1 | unit | 21 | hbase-client in the patch failed. | | -1 | unit | 36 | hbase-server in the patch failed. | | +1 | asflicense | 18 | The patch does not generate ASF License warnings. | | | | 1669 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/41/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/361 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux c3b4928aca78 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh | | git revision | master / 0c80d5b42b | | Default Java | 1.8.0_181 | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/41/artifact/out/branch-mvninstall-root.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/41/artifact/out/branch-compile-hbase-client.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/41/artifact/out/branch-compile-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/41/artifact/out/branch-findbugs-hbase-client.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/41/artifact/out/branch-findbugs-hbase-server.txt | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/41/artifact/out/patch-mvninstall-root.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/41/artifact/out/patch-compile-hbase-client.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/41/artifact/out/patch-compile-hbase-server.txt | | javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/41/artifact/out/patch-compile-hbase-client.txt | | javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/41/artifact/out/patch-compile-hbase-server.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/41/artifact/out/patch-javac-2.8.5.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/41/artifact/out/patch-javac-2.9.2.txt |
[jira] [Commented] (HBASE-22751) table.jsp fails if ugly regions in table
[
https://issues.apache.org/jira/browse/HBASE-22751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895670#comment-16895670
]
Hudson commented on HBASE-22751:
Results for branch branch-2.0
[build #1805 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1805/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1805//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1805//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1805//JDK8_Nightly_Build_Report_(Hadoop3)/]
(x) {color:red}-1 source release artifact{color}
-- See build output for details.
> table.jsp fails if ugly regions in table
>
>
> Key: HBASE-22751
> URL: https://issues.apache.org/jira/browse/HBASE-22751
> Project: HBase
> Issue Type: Bug
> Components: UI
>Reporter: stack
>Assignee: stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
> Attachments: HBASE-22751.master.001.patch,
> HBASE-22751.master.001.patch
>
>
> I'm playing w/ messing up hbase:meta as part of hbck2 messings. Noticed that
> a bad server or an unknown region makes it so the table.jsp fails.
> I noticed that Admin trying to get the compaction stats for the table will
> get stuck trying to contact an unknown region and that when it does complete
> eventually (tens of minutes...), it will spew an exception in the compaction
> state location.
> The listing of servers has an issue where if unknown server, then we'll try
> to use a null address which does another spew of jsp complaint instead of
> just logging an unknown
> I tried messing around with Admin trying to set its Operation Timeout... but
> Operation Timeout is not really settable unless you get a new Configuration
> for a new Connection -- which is madness -- so instead just used the new
> AsyncAdminBuilder where I can set operation timeout
> It times out too quick but thats another issue the UI at least draws with
> a messy hbase;meta.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (HBASE-22741) Show catalogjanitor consistency complaints in new 'HBCK Report' page
[ https://issues.apache.org/jira/browse/HBASE-22741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-22741: -- Assignee: stack Status: Patch Available (was: Open) .001 adds CJ Consistency issues to new HBCK Report page. Does some fixup to get it all working and integrated w/ existing page. > Show catalogjanitor consistency complaints in new 'HBCK Report' page > > > Key: HBASE-22741 > URL: https://issues.apache.org/jira/browse/HBASE-22741 > Project: HBase > Issue Type: Sub-task > Components: hbck2, UI >Reporter: stack >Assignee: stack >Priority: Major > Attachments: > 0001-HBASE-22741-Show-catalogjanitor-consistency-complain.patch, > HBASE-22741.master.001.patch, Screen Shot 2019-07-25 at 11.12.40 PM.png > > > HBASE-22723 makes it so catalogjanitor looks for holes and overlaps when it > scans hbase:meta. HBASE-22709 added a new HBCK Report page to the master in > which it notes findings its figured looking at regionserver reports and > current state of Master. > This issue is about exposing the inconsistencies found scanning hbase:meta in > the HBCK Report page. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22741) Show catalogjanitor consistency complaints in new 'HBCK Report' page
[ https://issues.apache.org/jira/browse/HBASE-22741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-22741: -- Attachment: HBASE-22741.master.001.patch > Show catalogjanitor consistency complaints in new 'HBCK Report' page > > > Key: HBASE-22741 > URL: https://issues.apache.org/jira/browse/HBASE-22741 > Project: HBase > Issue Type: Sub-task > Components: hbck2, UI >Reporter: stack >Priority: Major > Attachments: > 0001-HBASE-22741-Show-catalogjanitor-consistency-complain.patch, > HBASE-22741.master.001.patch, Screen Shot 2019-07-25 at 11.12.40 PM.png > > > HBASE-22723 makes it so catalogjanitor looks for holes and overlaps when it > scans hbase:meta. HBASE-22709 added a new HBCK Report page to the master in > which it notes findings its figured looking at regionserver reports and > current state of Master. > This issue is about exposing the inconsistencies found scanning hbase:meta in > the HBCK Report page. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #429: HBASE-22735 : list_regions show basic info for region currently in tr…
Apache-HBase commented on issue #429: HBASE-22735 : list_regions show basic info for region currently in tr… URL: https://github.com/apache/hbase/pull/429#issuecomment-516208065 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 38 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 287 | master passed | | +1 | javadoc | 14 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 290 | the patch passed | | -1 | rubocop | 4 | The patch generated 12 new + 13 unchanged - 8 fixed = 25 total (was 21) | | +1 | whitespace | 1 | The patch has no whitespace issues. | | +1 | javadoc | 20 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 425 | hbase-shell in the patch passed. | | +1 | asflicense | 10 | The patch does not generate ASF License warnings. | | | | 1158 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-429/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/429 | | Optional Tests | dupname asflicense javac javadoc unit rubocop | | uname | Linux fc824420fdb9 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-429/out/precommit/personality/provided.sh | | git revision | master / 0c80d5b42b | | Default Java | 1.8.0_181 | | rubocop | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-429/3/artifact/out/diff-patch-rubocop.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-429/3/testReport/ | | Max. process+thread count | 2655 (vs. ulimit of 1) | | modules | C: hbase-shell U: hbase-shell | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-429/3/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) rubocop=0.73.0 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22751) table.jsp fails if ugly regions in table
[
https://issues.apache.org/jira/browse/HBASE-22751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895663#comment-16895663
]
Hudson commented on HBASE-22751:
Results for branch branch-2.1
[build #1425 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1425/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1425//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1425//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1425//JDK8_Nightly_Build_Report_(Hadoop3)/]
(x) {color:red}-1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
-- Something went wrong with this stage, [check relevant console
output|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1425//console].
> table.jsp fails if ugly regions in table
>
>
> Key: HBASE-22751
> URL: https://issues.apache.org/jira/browse/HBASE-22751
> Project: HBase
> Issue Type: Bug
> Components: UI
>Reporter: stack
>Assignee: stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
> Attachments: HBASE-22751.master.001.patch,
> HBASE-22751.master.001.patch
>
>
> I'm playing w/ messing up hbase:meta as part of hbck2 messings. Noticed that
> a bad server or an unknown region makes it so the table.jsp fails.
> I noticed that Admin trying to get the compaction stats for the table will
> get stuck trying to contact an unknown region and that when it does complete
> eventually (tens of minutes...), it will spew an exception in the compaction
> state location.
> The listing of servers has an issue where if unknown server, then we'll try
> to use a null address which does another spew of jsp complaint instead of
> just logging an unknown
> I tried messing around with Admin trying to set its Operation Timeout... but
> Operation Timeout is not really settable unless you get a new Configuration
> for a new Connection -- which is madness -- so instead just used the new
> AsyncAdminBuilder where I can set operation timeout
> It times out too quick but thats another issue the UI at least draws with
> a messy hbase;meta.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase-connectors] asf-ci commented on issue #40: Add rdd function for snapshot read
asf-ci commented on issue #40: Add rdd function for snapshot read URL: https://github.com/apache/hbase-connectors/pull/40#issuecomment-516206403 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-HBASE-CONNECTORS-Build/65/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #428: HBASE-22759 Add user info to AUDITLOG events when doing grant/revoke (master)
Apache-HBase commented on issue #428: HBASE-22759 Add user info to AUDITLOG events when doing grant/revoke (master) URL: https://github.com/apache/hbase/pull/428#issuecomment-516205985 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 155 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 483 | master passed | | +1 | compile | 75 | master passed | | +1 | checkstyle | 102 | master passed | | +1 | shadedjars | 358 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 49 | master passed | | 0 | spotbugs | 298 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 294 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 428 | the patch passed | | +1 | compile | 81 | the patch passed | | +1 | javac | 81 | the patch passed | | +1 | checkstyle | 105 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 379 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1345 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 45 | the patch passed | | +1 | findbugs | 314 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 1766 | hbase-server in the patch failed. | | +1 | asflicense | 15 | The patch does not generate ASF License warnings. | | | | 6532 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.regionserver.TestScanner | | | hadoop.hbase.regionserver.TestBlocksScanned | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/428 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 4c077dda3b1e 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-428/out/precommit/personality/provided.sh | | git revision | master / f68cda32e1 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/2/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/2/testReport/ | | Max. process+thread count | 670 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/2/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #425: HBASE-22737 Add a new admin method and shell cmd to trigger the hbck …
Apache-HBase commented on issue #425: HBASE-22737 Add a new admin method and shell cmd to trigger the hbck … URL: https://github.com/apache/hbase/pull/425#issuecomment-516205469 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 0 | Docker mode activated. | | -1 | patch | 10 | https://github.com/apache/hbase/pull/425 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help. | | Subsystem | Report/Notes | |--:|:-| | GITHUB PR | https://github.com/apache/hbase/pull/425 | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/4/console | | versions | git=2.7.4 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22723) Have CatalogJanitor report holes and overlaps; i.e. problems it sees when doing its regular scan of hbase:meta
[
https://issues.apache.org/jira/browse/HBASE-22723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895659#comment-16895659
]
HBase QA commented on HBASE-22723:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 2m
38s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
|| || || || {color:brown} branch-2 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
37s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
14s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
25s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m
13s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 6m
6s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
56s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
48s{color} | {color:green} branch-2 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
16s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
40s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
30s{color} | {color:red} hbase-server: The patch generated 1 new + 39 unchanged
- 23 fixed = 40 total (was 62) {color} |
| {color:red}-1{color} | {color:red} rubocop {color} | {color:red} 0m
8s{color} | {color:red} The patch generated 3 new + 92 unchanged - 3 fixed = 95
total (was 95) {color} |
| {color:green}+1{color} | {color:green} ruby-lint {color} | {color:green} 0m
1s{color} | {color:green} There were no new ruby-lint issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
27s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
18m 1s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
41s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
12s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
52s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}265m 27s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 10m
3s{color} | {color:green} hbase-shell in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
19s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}361m 33s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
hadoop.hbase.master.balancer.TestStochasticLoadBalancerRegionReplicaSameHosts |
[jira] [Commented] (HBASE-22751) table.jsp fails if ugly regions in table
[
https://issues.apache.org/jira/browse/HBASE-22751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895658#comment-16895658
]
Hudson commented on HBASE-22751:
Results for branch branch-2.2
[build #476 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/476/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/476//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/476//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/476//JDK8_Nightly_Build_Report_(Hadoop3)/]
(x) {color:red}-1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
-- Something went wrong with this stage, [check relevant console
output|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/476//console].
> table.jsp fails if ugly regions in table
>
>
> Key: HBASE-22751
> URL: https://issues.apache.org/jira/browse/HBASE-22751
> Project: HBase
> Issue Type: Bug
> Components: UI
>Reporter: stack
>Assignee: stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
> Attachments: HBASE-22751.master.001.patch,
> HBASE-22751.master.001.patch
>
>
> I'm playing w/ messing up hbase:meta as part of hbck2 messings. Noticed that
> a bad server or an unknown region makes it so the table.jsp fails.
> I noticed that Admin trying to get the compaction stats for the table will
> get stuck trying to contact an unknown region and that when it does complete
> eventually (tens of minutes...), it will spew an exception in the compaction
> state location.
> The listing of servers has an issue where if unknown server, then we'll try
> to use a null address which does another spew of jsp complaint instead of
> just logging an unknown
> I tried messing around with Admin trying to set its Operation Timeout... but
> Operation Timeout is not really settable unless you get a new Configuration
> for a new Connection -- which is madness -- so instead just used the new
> AsyncAdminBuilder where I can set operation timeout
> It times out too quick but thats another issue the UI at least draws with
> a messy hbase;meta.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22728) Upgrade jackson dependencies in branch-1
[
https://issues.apache.org/jira/browse/HBASE-22728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895654#comment-16895654
]
Andrew Purtell commented on HBASE-22728:
I looked at the attached output of {{mvn dependency:tree}} and is this what we
want? Still pulling in jackson at compile scope for hbase-client and others.
Maybe set the scope to 'provided' so it is pulled into our build for compile
but is not recorded as a transitive dependency for projects that import our
artifacts?
The removal of jackson classes from the shaded jars looks right.
bq. script engine for language js can not be found
Ignore the XML parse errors, this is an environmental issue that will
(eventually) be addressed:
bq. Above QA failure message for shadedjar is: Found Banned Dependency:
jdk.tools:jdk.tools:jar:1.8 (which also comes without the patch applied on
branch-1). Hope it is not a concern.
I'm not sure what that is about. [~busbey]?
For releasing, we require the RM to build branch-1 based releases with JDK 7,
so it isn't a problem for releases.
> Upgrade jackson dependencies in branch-1
>
>
> Key: HBASE-22728
> URL: https://issues.apache.org/jira/browse/HBASE-22728
> Project: HBase
> Issue Type: Sub-task
>Affects Versions: 1.4.10, 1.3.5
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Major
> Fix For: 1.5.0, 1.3.6, 1.4.11
>
> Attachments: HBASE-22728.branch-1.01.patch,
> HBASE-22728.branch-1.02.patch, dependency_codehaus.out
>
>
> Avoid Jackson versions and dependencies with known CVEs
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22735) list_regions may throw an error if a region is RIT
[
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895650#comment-16895650
]
Andrew Purtell commented on HBASE-22735:
I know some of those rubocop warnings aren't due to your changes but would you
mind taking one pass to clean them up a bit? The ones that look not onerous to
address are EmptyLines, LineLength, MethodCallWithoutArgsParentheses,
StringLiterals, and VariableName.
Otherwise lgtm
> list_regions may throw an error if a region is RIT
> --
>
> Key: HBASE-22735
> URL: https://issues.apache.org/jira/browse/HBASE-22735
> Project: HBase
> Issue Type: Bug
> Components: shell
>Affects Versions: 1.5.0
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22735.branch-1.01.patch,
> HBASE-22735.master.01.patch
>
>
> The 'list_regions' shell command gets a list of regions for a given table and
> then prints them and some attributes such as the server where they are
> located, current request count, data locality, and such.
> However if a region is in transition the command might fail with
> {{ERROR: undefined method `getDataLocality' for nil:NilClass}}
> and there may be other ways this can happen. Protect against use of nil
> references and just display what we can.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator
Apache-HBase commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator URL: https://github.com/apache/hbase/pull/343#issuecomment-516199324 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 39 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-2.1 Compile Tests _ | | -1 | mvninstall | 140 | root in branch-2.1 failed. | | +1 | compile | 22 | branch-2.1 passed | | +1 | checkstyle | 31 | branch-2.1 passed | | -1 | shadedjars | 164 | branch has 24 errors when building our shaded downstream artifacts. | | +1 | javadoc | 20 | branch-2.1 passed | | 0 | spotbugs | 67 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 64 | branch-2.1 passed | ||| _ Patch Compile Tests _ | | -1 | mvninstall | 131 | root in the patch failed. | | +1 | compile | 23 | the patch passed | | +1 | javac | 23 | the patch passed | | +1 | checkstyle | 32 | hbase-client: The patch generated 0 new + 58 unchanged - 4 fixed = 58 total (was 62) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | -1 | shadedjars | 165 | patch has 24 errors when building our shaded downstream artifacts. | | -1 | hadoopcheck | 99 | The patch causes 24 errors with Hadoop v2.7.7. | | -1 | hadoopcheck | 195 | The patch causes 24 errors with Hadoop v2.8.5. | | -1 | hadoopcheck | 295 | The patch causes 24 errors with Hadoop v3.0.3. | | -1 | hadoopcheck | 393 | The patch causes 24 errors with Hadoop v3.1.2. | | +1 | javadoc | 20 | the patch passed | | +1 | findbugs | 72 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 189 | hbase-client in the patch passed. | | +1 | asflicense | 10 | The patch does not generate ASF License warnings. | | | | 1579 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/19/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/343 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux e43a10aca674 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-343/out/precommit/personality/provided.sh | | git revision | branch-2.1 / d45b2d4469 | | Default Java | 1.8.0_181 | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/19/artifact/out/branch-mvninstall-root.txt | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/19/artifact/out/branch-shadedjars.txt | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/19/artifact/out/patch-mvninstall-root.txt | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/19/artifact/out/patch-shadedjars.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/19/artifact/out/patch-javac-2.7.7.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/19/artifact/out/patch-javac-2.8.5.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/19/artifact/out/patch-javac-3.0.3.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/19/artifact/out/patch-javac-3.1.2.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/19/testReport/ | | Max. process+thread count | 302 (vs. ulimit of 1) | | modules | C: hbase-client U: hbase-client | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/19/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Comment Edited] (HBASE-22723) Have CatalogJanitor report holes and overlaps; i.e. problems it sees when doing its regular scan of hbase:meta
[ https://issues.apache.org/jira/browse/HBASE-22723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895649#comment-16895649 ] stack edited comment on HBASE-22723 at 7/29/19 11:24 PM: - Pushed to branch-2.0+. Thanks for review [~apurtell] and [~psomogyi] was (Author: stack): Pushed to branch-2.0+. Thanks for review [~apurtell] and [~wchevreuil] > Have CatalogJanitor report holes and overlaps; i.e. problems it sees when > doing its regular scan of hbase:meta > -- > > Key: HBASE-22723 > URL: https://issues.apache.org/jira/browse/HBASE-22723 > Project: HBase > Issue Type: Sub-task >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6 > > Attachments: HBASE-22723.branch-2.001.patch, > HBASE-22723.branch-2.002.patch, HBASE-22723.branch-2.003.patch, > HBASE-22723.branch-2.004.patch, HBASE-22723.branch-2.005.patch, > HBASE-22723.branch-2.006.patch, HBASE-22723.branch-2.007.patch > > > CatalogJanitor scans hbase:meta on a configurable period. Currently it just > looks for splits and merges to gc. Might as well generate a report on stuff > like holds, overlaps, empty regioninfos, and unknown servers while it is at > it. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22723) Have CatalogJanitor report holes and overlaps; i.e. problems it sees when doing its regular scan of hbase:meta
[ https://issues.apache.org/jira/browse/HBASE-22723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-22723: -- Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 2.1.6 2.2.1 2.0.6 2.3.0 3.0.0 Release Note: When CatalogJanitor runs, it now checks for holes, overlaps, empty info:regioninfo columns and bad servers. Dumps findings into log. Follow-up adds report to new 'HBCK Report' linked off the Master UI. Status: Resolved (was: Patch Available) Pushed to branch-2.0+. Thanks for review [~apurtell] and [~wchevreuil] > Have CatalogJanitor report holes and overlaps; i.e. problems it sees when > doing its regular scan of hbase:meta > -- > > Key: HBASE-22723 > URL: https://issues.apache.org/jira/browse/HBASE-22723 > Project: HBase > Issue Type: Sub-task >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6 > > Attachments: HBASE-22723.branch-2.001.patch, > HBASE-22723.branch-2.002.patch, HBASE-22723.branch-2.003.patch, > HBASE-22723.branch-2.004.patch, HBASE-22723.branch-2.005.patch, > HBASE-22723.branch-2.006.patch, HBASE-22723.branch-2.007.patch > > > CatalogJanitor scans hbase:meta on a configurable period. Currently it just > looks for splits and merges to gc. Might as well generate a report on stuff > like holds, overlaps, empty regioninfos, and unknown servers while it is at > it. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase-connectors] asf-ci commented on issue #40: Add rdd function for snapshot read
asf-ci commented on issue #40: Add rdd function for snapshot read URL: https://github.com/apache/hbase-connectors/pull/40#issuecomment-516196884 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-HBASE-CONNECTORS-Build/64/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #430: HBASE-22763 Fixed remaining Checkstyle issue in hbase-procedure
Apache-HBase commented on issue #430: HBASE-22763 Fixed remaining Checkstyle issue in hbase-procedure URL: https://github.com/apache/hbase/pull/430#issuecomment-516196549 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 65 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 384 | master passed | | +1 | compile | 22 | master passed | | +1 | checkstyle | 18 | master passed | | +1 | shadedjars | 344 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 19 | master passed | | 0 | spotbugs | 43 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 42 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 381 | the patch passed | | +1 | compile | 21 | the patch passed | | +1 | javac | 21 | the patch passed | | +1 | checkstyle | 16 | hbase-procedure: The patch generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 355 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1247 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 18 | the patch passed | | +1 | findbugs | 53 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 254 | hbase-procedure in the patch passed. | | +1 | asflicense | 12 | The patch does not generate ASF License warnings. | | | | 3743 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-430/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/430 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux fdbeaf51018b 4.4.0-143-generic #169-Ubuntu SMP Thu Feb 7 07:56:38 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-430/out/precommit/personality/provided.sh | | git revision | master / f68cda32e1 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-430/2/testReport/ | | Max. process+thread count | 318 (vs. ulimit of 1) | | modules | C: hbase-procedure U: hbase-procedure | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-430/2/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #374: HBASE-22677 Add unit tests for org.apache.hadoop.hbase.util.ByteRangeUtils and Classes
Apache-HBase commented on issue #374: HBASE-22677 Add unit tests for org.apache.hadoop.hbase.util.ByteRangeUtils and Classes URL: https://github.com/apache/hbase/pull/374#issuecomment-516195200 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 88 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 469 | master passed | | +1 | compile | 20 | master passed | | +1 | checkstyle | 26 | master passed | | +1 | shadedjars | 274 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 20 | master passed | | 0 | spotbugs | 50 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 48 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 348 | the patch passed | | +1 | compile | 23 | the patch passed | | +1 | javac | 23 | the patch passed | | -1 | checkstyle | 26 | hbase-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 307 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1025 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 21 | the patch passed | | +1 | findbugs | 58 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 182 | hbase-common in the patch passed. | | +1 | asflicense | 11 | The patch does not generate ASF License warnings. | | | | 3363 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/31/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/374 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 707702c619ca 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-374/out/precommit/personality/provided.sh | | git revision | master / f68cda32e1 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/31/artifact/out/diff-checkstyle-hbase-common.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/31/testReport/ | | Max. process+thread count | 289 (vs. ulimit of 1) | | modules | C: hbase-common U: hbase-common | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/31/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #411: HBASE-22739 check bound where removeRegion
Apache-HBase commented on issue #411: HBASE-22739 check bound where removeRegion URL: https://github.com/apache/hbase/pull/411#issuecomment-516194311 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 78 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 1 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-2.1 Compile Tests _ | | -1 | mvninstall | 133 | root in branch-2.1 failed. | | -1 | compile | 38 | hbase-server in branch-2.1 failed. | | +1 | checkstyle | 73 | branch-2.1 passed | | -1 | shadedjars | 166 | branch has 24 errors when building our shaded downstream artifacts. | | +1 | javadoc | 29 | branch-2.1 passed | | 0 | spotbugs | 231 | Used deprecated FindBugs config; considering switching to SpotBugs. | | -1 | findbugs | 35 | hbase-server in branch-2.1 failed. | ||| _ Patch Compile Tests _ | | -1 | mvninstall | 134 | root in the patch failed. | | -1 | compile | 37 | hbase-server in the patch failed. | | -1 | javac | 37 | hbase-server in the patch failed. | | -1 | checkstyle | 71 | hbase-server: The patch generated 1 new + 61 unchanged - 0 fixed = 62 total (was 61) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | -1 | shadedjars | 166 | patch has 24 errors when building our shaded downstream artifacts. | | -1 | hadoopcheck | 95 | The patch causes 24 errors with Hadoop v2.7.7. | | -1 | hadoopcheck | 194 | The patch causes 24 errors with Hadoop v2.8.5. | | -1 | hadoopcheck | 293 | The patch causes 24 errors with Hadoop v3.0.3. | | -1 | hadoopcheck | 395 | The patch causes 24 errors with Hadoop v3.1.2. | | +1 | javadoc | 29 | the patch passed | | -1 | findbugs | 35 | hbase-server in the patch failed. | ||| _ Other Tests _ | | -1 | unit | 36 | hbase-server in the patch failed. | | +1 | asflicense | 10 | The patch does not generate ASF License warnings. | | | | 1526 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/7/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/411 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 66bc47482314 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-411/out/precommit/personality/provided.sh | | git revision | branch-2.1 / d45b2d4469 | | Default Java | 1.8.0_181 | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/7/artifact/out/branch-mvninstall-root.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/7/artifact/out/branch-compile-hbase-server.txt | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/7/artifact/out/branch-shadedjars.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/7/artifact/out/branch-findbugs-hbase-server.txt | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/7/artifact/out/patch-mvninstall-root.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/7/artifact/out/patch-compile-hbase-server.txt | | javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/7/artifact/out/patch-compile-hbase-server.txt | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/7/artifact/out/diff-checkstyle-hbase-server.txt | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/7/artifact/out/patch-shadedjars.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/7/artifact/out/patch-javac-2.7.7.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/7/artifact/out/patch-javac-2.8.5.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/7/artifact/out/patch-javac-3.0.3.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/7/artifact/out/patch-javac-3.1.2.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/7/artifact/out/patch-findbugs-hbase-server.txt | | unit |
[GitHub] [hbase] Apache-HBase commented on issue #427: HBASE-22759 Add user info to AUDITLOG events when doing grant/revoke (2.1)
Apache-HBase commented on issue #427: HBASE-22759 Add user info to AUDITLOG events when doing grant/revoke (2.1) URL: https://github.com/apache/hbase/pull/427#issuecomment-516194204 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 79 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-2.1 Compile Tests _ | | -1 | mvninstall | 133 | root in branch-2.1 failed. | | -1 | compile | 37 | hbase-server in branch-2.1 failed. | | +1 | checkstyle | 72 | branch-2.1 passed | | -1 | shadedjars | 163 | branch has 24 errors when building our shaded downstream artifacts. | | +1 | javadoc | 30 | branch-2.1 passed | | 0 | spotbugs | 230 | Used deprecated FindBugs config; considering switching to SpotBugs. | | -1 | findbugs | 36 | hbase-server in branch-2.1 failed. | ||| _ Patch Compile Tests _ | | -1 | mvninstall | 134 | root in the patch failed. | | -1 | compile | 35 | hbase-server in the patch failed. | | -1 | javac | 35 | hbase-server in the patch failed. | | +1 | checkstyle | 70 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | -1 | shadedjars | 162 | patch has 24 errors when building our shaded downstream artifacts. | | -1 | hadoopcheck | 95 | The patch causes 24 errors with Hadoop v2.7.7. | | -1 | hadoopcheck | 190 | The patch causes 24 errors with Hadoop v2.8.5. | | -1 | hadoopcheck | 291 | The patch causes 24 errors with Hadoop v3.0.3. | | -1 | hadoopcheck | 389 | The patch causes 24 errors with Hadoop v3.1.2. | | +1 | javadoc | 30 | the patch passed | | -1 | findbugs | 35 | hbase-server in the patch failed. | ||| _ Other Tests _ | | -1 | unit | 35 | hbase-server in the patch failed. | | +1 | asflicense | 10 | The patch does not generate ASF License warnings. | | | | 1521 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/427 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 32c46b39628c 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-427/out/precommit/personality/provided.sh | | git revision | branch-2.1 / d45b2d4469 | | Default Java | 1.8.0_181 | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/2/artifact/out/branch-mvninstall-root.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/2/artifact/out/branch-compile-hbase-server.txt | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/2/artifact/out/branch-shadedjars.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/2/artifact/out/branch-findbugs-hbase-server.txt | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/2/artifact/out/patch-mvninstall-root.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/2/artifact/out/patch-compile-hbase-server.txt | | javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/2/artifact/out/patch-compile-hbase-server.txt | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/2/artifact/out/patch-shadedjars.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/2/artifact/out/patch-javac-2.7.7.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/2/artifact/out/patch-javac-2.8.5.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/2/artifact/out/patch-javac-3.0.3.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/2/artifact/out/patch-javac-3.1.2.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/2/artifact/out/patch-findbugs-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/2/artifact/out/patch-unit-hbase-server.txt | | Test Results |
[GitHub] [hbase] Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent
Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent URL: https://github.com/apache/hbase/pull/387#issuecomment-516193697 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 36 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 291 | master passed | | +1 | compile | 24 | master passed | | +1 | checkstyle | 11 | master passed | | +1 | shadedjars | 266 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 18 | master passed | | 0 | spotbugs | 45 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 44 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 289 | the patch passed | | +1 | compile | 24 | the patch passed | | +1 | javac | 24 | the patch passed | | +1 | checkstyle | 12 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 270 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 881 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 18 | the patch passed | | +1 | findbugs | 51 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 392 | hbase-rsgroup in the patch passed. | | +1 | asflicense | 11 | The patch does not generate ASF License warnings. | | | | 2990 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/29/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/387 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux caac864c46a9 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-387/out/precommit/personality/provided.sh | | git revision | master / f68cda32e1 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/29/testReport/ | | Max. process+thread count | 4404 (vs. ulimit of 1) | | modules | C: hbase-rsgroup U: hbase-rsgroup | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/29/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #392: HBASE-22714 - Fix opertationTimeout typo
Apache-HBase commented on issue #392: HBASE-22714 - Fix opertationTimeout typo URL: https://github.com/apache/hbase/pull/392#issuecomment-516193647 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 86 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 393 | master passed | | +1 | compile | 23 | master passed | | +1 | checkstyle | 31 | master passed | | +1 | shadedjars | 269 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 22 | master passed | | 0 | spotbugs | 67 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 66 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 289 | the patch passed | | +1 | compile | 23 | the patch passed | | +1 | javac | 23 | the patch passed | | +1 | checkstyle | 29 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 268 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 909 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | -1 | javadoc | 22 | hbase-client generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2) | | +1 | findbugs | 75 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 109 | hbase-client in the patch passed. | | +1 | asflicense | 13 | The patch does not generate ASF License warnings. | | | | 2981 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-392/32/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/392 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 5eb055b5efc6 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-392/out/precommit/personality/provided.sh | | git revision | master / f68cda32e1 | | Default Java | 1.8.0_181 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-392/32/artifact/out/diff-javadoc-javadoc-hbase-client.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-392/32/testReport/ | | Max. process+thread count | 292 (vs. ulimit of 1) | | modules | C: hbase-client U: hbase-client | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-392/32/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #431: HBASE-22764 Fixed remaining Checkstyle issues in the hbase-rsgroup module
Apache-HBase commented on issue #431: HBASE-22764 Fixed remaining Checkstyle issues in the hbase-rsgroup module URL: https://github.com/apache/hbase/pull/431#issuecomment-516193215 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 38 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 283 | master passed | | +1 | compile | 24 | master passed | | +1 | checkstyle | 13 | master passed | | +1 | shadedjars | 270 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 20 | master passed | | 0 | spotbugs | 46 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 45 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 304 | the patch passed | | +1 | compile | 23 | the patch passed | | +1 | javac | 23 | the patch passed | | +1 | checkstyle | 11 | hbase-rsgroup: The patch generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 254 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 877 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 18 | the patch passed | | +1 | findbugs | 50 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 277 | hbase-rsgroup in the patch passed. | | +1 | asflicense | 9 | The patch does not generate ASF License warnings. | | | | 2884 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-431/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/431 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 3e203de3058c 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-431/out/precommit/personality/provided.sh | | git revision | master / f68cda32e1 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-431/2/testReport/ | | Max. process+thread count | 4583 (vs. ulimit of 1) | | modules | C: hbase-rsgroup U: hbase-rsgroup | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-431/2/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #429: HBASE-22735 : list_regions show basic info for region currently in tr…
Apache-HBase commented on issue #429: HBASE-22735 : list_regions show basic info for region currently in tr… URL: https://github.com/apache/hbase/pull/429#issuecomment-516188607 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 60 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 388 | master passed | | +1 | javadoc | 15 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 384 | the patch passed | | -1 | rubocop | 5 | The patch generated 12 new + 13 unchanged - 8 fixed = 25 total (was 21) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | javadoc | 14 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 709 | hbase-shell in the patch passed. | | +1 | asflicense | 13 | The patch does not generate ASF License warnings. | | | | 1664 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-429/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/429 | | Optional Tests | dupname asflicense javac javadoc unit rubocop | | uname | Linux c10e88046908 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-429/out/precommit/personality/provided.sh | | git revision | master / f68cda32e1 | | Default Java | 1.8.0_181 | | rubocop | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-429/2/artifact/out/diff-patch-rubocop.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-429/2/testReport/ | | Max. process+thread count | 2489 (vs. ulimit of 1) | | modules | C: hbase-shell U: hbase-shell | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-429/2/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) rubocop=0.73.0 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #416: HBASE-22746 Removed deprecated methods from Delete
Apache-HBase commented on issue #416: HBASE-22746 Removed deprecated methods from Delete URL: https://github.com/apache/hbase/pull/416#issuecomment-516188339 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 71 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | 0 | mvndep | 13 | Maven dependency ordering for branch | | -1 | mvninstall | 74 | root in master failed. | | -1 | compile | 22 | hbase-client in master failed. | | -1 | compile | 37 | hbase-server in master failed. | | +1 | checkstyle | 97 | master passed | | +1 | shadedjars | 260 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 51 | master passed | | 0 | spotbugs | 364 | Used deprecated FindBugs config; considering switching to SpotBugs. | | -1 | findbugs | 18 | hbase-client in master failed. | | -1 | findbugs | 34 | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | 0 | mvndep | 12 | Maven dependency ordering for patch | | -1 | mvninstall | 74 | root in the patch failed. | | -1 | compile | 18 | hbase-client in the patch failed. | | -1 | compile | 33 | hbase-server in the patch failed. | | -1 | javac | 18 | hbase-client in the patch failed. | | -1 | javac | 33 | hbase-server in the patch failed. | | +1 | checkstyle | 26 | hbase-client: The patch generated 0 new + 5 unchanged - 1 fixed = 5 total (was 6) | | +1 | checkstyle | 70 | The patch passed checkstyle in hbase-server | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 254 | patch has no errors when building our shaded downstream artifacts. | | -1 | hadoopcheck | 56 | The patch causes 10 errors with Hadoop v2.8.5. | | -1 | hadoopcheck | 109 | The patch causes 10 errors with Hadoop v2.9.2. | | -1 | hadoopcheck | 163 | The patch causes 10 errors with Hadoop v3.1.2. | | +1 | javadoc | 51 | the patch passed | | -1 | findbugs | 19 | hbase-client in the patch failed. | | -1 | findbugs | 33 | hbase-server in the patch failed. | ||| _ Other Tests _ | | -1 | unit | 19 | hbase-client in the patch failed. | | -1 | unit | 34 | hbase-server in the patch failed. | | +1 | asflicense | 17 | The patch does not generate ASF License warnings. | | | | 1566 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-416/11/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/416 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 84e6157b308c 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-416/out/precommit/personality/provided.sh | | git revision | master / f68cda32e1 | | Default Java | 1.8.0_181 | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-416/11/artifact/out/branch-mvninstall-root.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-416/11/artifact/out/branch-compile-hbase-client.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-416/11/artifact/out/branch-compile-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-416/11/artifact/out/branch-findbugs-hbase-client.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-416/11/artifact/out/branch-findbugs-hbase-server.txt | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-416/11/artifact/out/patch-mvninstall-root.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-416/11/artifact/out/patch-compile-hbase-client.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-416/11/artifact/out/patch-compile-hbase-server.txt | | javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-416/11/artifact/out/patch-compile-hbase-client.txt | | javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-416/11/artifact/out/patch-compile-hbase-server.txt | | hadoopcheck |
[GitHub] [hbase] Apache-HBase commented on issue #403: HBASE-22707 [HBCK2] MasterRpcServices assigns method should try to reload regions from meta if the passed regions isn't found under AssignmentMan
Apache-HBase commented on issue #403: HBASE-22707 [HBCK2] MasterRpcServices assigns method should try to reload regions from meta if the passed regions isn't found under AssignmentManager RegionsStateStore URL: https://github.com/apache/hbase/pull/403#issuecomment-516188291 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 72 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 3 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 13 | Maven dependency ordering for branch | | -1 | mvninstall | 78 | root in master failed. | | -1 | compile | 22 | hbase-client in master failed. | | -1 | compile | 37 | hbase-server in master failed. | | +1 | checkstyle | 97 | master passed | | +1 | shadedjars | 254 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 51 | master passed | | 0 | spotbugs | 360 | Used deprecated FindBugs config; considering switching to SpotBugs. | | -1 | findbugs | 19 | hbase-client in master failed. | | -1 | findbugs | 34 | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | 0 | mvndep | 13 | Maven dependency ordering for patch | | -1 | mvninstall | 73 | root in the patch failed. | | -1 | compile | 18 | hbase-client in the patch failed. | | -1 | compile | 35 | hbase-server in the patch failed. | | -1 | javac | 18 | hbase-client in the patch failed. | | -1 | javac | 35 | hbase-server in the patch failed. | | -1 | checkstyle | 68 | hbase-server: The patch generated 3 new + 41 unchanged - 0 fixed = 44 total (was 41) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 254 | patch has no errors when building our shaded downstream artifacts. | | -1 | hadoopcheck | 51 | The patch causes 10 errors with Hadoop v2.8.5. | | -1 | hadoopcheck | 104 | The patch causes 10 errors with Hadoop v2.9.2. | | -1 | hadoopcheck | 155 | The patch causes 10 errors with Hadoop v3.1.2. | | +1 | javadoc | 50 | the patch passed | | -1 | findbugs | 19 | hbase-client in the patch failed. | | -1 | findbugs | 33 | hbase-server in the patch failed. | ||| _ Other Tests _ | | -1 | unit | 19 | hbase-client in the patch failed. | | -1 | unit | 33 | hbase-server in the patch failed. | | +1 | asflicense | 17 | The patch does not generate ASF License warnings. | | | | 1558 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/26/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/403 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux e50fd78a02f4 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-403/out/precommit/personality/provided.sh | | git revision | master / f68cda32e1 | | Default Java | 1.8.0_181 | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/26/artifact/out/branch-mvninstall-root.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/26/artifact/out/branch-compile-hbase-client.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/26/artifact/out/branch-compile-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/26/artifact/out/branch-findbugs-hbase-client.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/26/artifact/out/branch-findbugs-hbase-server.txt | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/26/artifact/out/patch-mvninstall-root.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/26/artifact/out/patch-compile-hbase-client.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/26/artifact/out/patch-compile-hbase-server.txt | | javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/26/artifact/out/patch-compile-hbase-client.txt | | javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/26/artifact/out/patch-compile-hbase-server.txt | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-403/26/artifact/out/diff-checkstyle-hbase-server.txt | |
[GitHub] [hbase] Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien…
Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien… URL: https://github.com/apache/hbase/pull/361#issuecomment-516187575 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 60 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 22 | Maven dependency ordering for branch | | -1 | mvninstall | 15 | root in master failed. | | -1 | compile | 22 | hbase-client in master failed. | | -1 | compile | 35 | hbase-server in master failed. | | +1 | checkstyle | 99 | master passed | | +1 | shadedjars | 276 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 51 | master passed | | 0 | spotbugs | 382 | Used deprecated FindBugs config; considering switching to SpotBugs. | | -1 | findbugs | 21 | hbase-client in master failed. | | -1 | findbugs | 32 | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | 0 | mvndep | 14 | Maven dependency ordering for patch | | -1 | mvninstall | 13 | root in the patch failed. | | -1 | compile | 20 | hbase-client in the patch failed. | | -1 | compile | 33 | hbase-server in the patch failed. | | -1 | javac | 20 | hbase-client in the patch failed. | | -1 | javac | 33 | hbase-server in the patch failed. | | +1 | checkstyle | 99 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 271 | patch has no errors when building our shaded downstream artifacts. | | -1 | hadoopcheck | 12 | The patch causes 10 errors with Hadoop v2.8.5. | | -1 | hadoopcheck | 23 | The patch causes 10 errors with Hadoop v2.9.2. | | -1 | hadoopcheck | 35 | The patch causes 10 errors with Hadoop v3.1.2. | | -1 | javadoc | 32 | hbase-server generated 28 new + 4 unchanged - 0 fixed = 32 total (was 4) | | -1 | findbugs | 20 | hbase-client in the patch failed. | | -1 | findbugs | 35 | hbase-server in the patch failed. | ||| _ Other Tests _ | | -1 | unit | 21 | hbase-client in the patch failed. | | -1 | unit | 36 | hbase-server in the patch failed. | | +1 | asflicense | 20 | The patch does not generate ASF License warnings. | | | | 1372 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/40/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/361 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux fda974c08d1d 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh | | git revision | master / f68cda32e1 | | Default Java | 1.8.0_181 | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/40/artifact/out/branch-mvninstall-root.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/40/artifact/out/branch-compile-hbase-client.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/40/artifact/out/branch-compile-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/40/artifact/out/branch-findbugs-hbase-client.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/40/artifact/out/branch-findbugs-hbase-server.txt | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/40/artifact/out/patch-mvninstall-root.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/40/artifact/out/patch-compile-hbase-client.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/40/artifact/out/patch-compile-hbase-server.txt | | javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/40/artifact/out/patch-compile-hbase-client.txt | | javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/40/artifact/out/patch-compile-hbase-server.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/40/artifact/out/patch-javac-2.8.5.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/40/artifact/out/patch-javac-2.9.2.txt |
[jira] [Commented] (HBASE-22749) HBase MOB 2.0
[ https://issues.apache.org/jira/browse/HBASE-22749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895629#comment-16895629 ] Vladimir Rodionov commented on HBASE-22749: --- Design doc v2.1 adds clarification on *CompactType.MOB* support. > HBase MOB 2.0 > - > > Key: HBASE-22749 > URL: https://issues.apache.org/jira/browse/HBASE-22749 > Project: HBase > Issue Type: New Feature > Components: mob >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Major > Attachments: HBase-MOB-2.0-v1.pdf, HBase-MOB-2.0-v2.1.pdf, > HBase-MOB-2.0-v2.pdf > > > There are several drawbacks in the original MOB 1.0 (Moderate Object > Storage) implementation, which can limit the adoption of the MOB feature: > # MOB compactions are executed in a Master as a chore, which limits > scalability because all I/O goes through a single HBase Master server. > # Yarn/Mapreduce framework is required to run MOB compactions in a scalable > way, but this won’t work in a stand-alone HBase cluster. > # Two separate compactors for MOB and for regular store files and their > interactions can result in a data loss (see HBASE-22075) > The design goals for MOB 2.0 were to provide 100% MOB 1.0 - compatible > implementation, which is free of the above drawbacks and can be used as a > drop in replacement in existing MOB deployments. So, these are design goals > of a MOB 2.0: > # Make MOB compactions scalable without relying on Yarn/Mapreduce framework > # Provide unified compactor for both MOB and regular store files > # Make it more robust especially w.r.t. to data losses. > # Simplify and reduce the overall MOB code. > # Provide 100% compatible implementation with MOB 1.0. > # No migration of data should be required between MOB 1.0 and MOB 2.0 - just > software upgrade. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase-connectors] mini666 opened a new pull request #40: Add rdd function for snapshot read
mini666 opened a new pull request #40: Add rdd function for snapshot read URL: https://github.com/apache/hbase-connectors/pull/40 I added RDD function to HBaseContext. It is much better to read and access HDFS directly than to read through RegionServer. This is a method that does not burden HBase. Working in a single cluster is OK, but HBase 2.1.4 or later is required for working with multiple clusters. Ref: [HBASE-18484 VerifyRep by snapshot does not work when Yarn/SourceHBase…](https://github.com/apache/hbase/commit/fca1ece03ce95a73888bcbe3a8aaf4ba0a9c59a8#diff-6205e907851ed4f650499f7111cbd91c) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-22749) HBase MOB 2.0
[ https://issues.apache.org/jira/browse/HBASE-22749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Rodionov updated HBASE-22749: -- Attachment: HBase-MOB-2.0-v2.1.pdf > HBase MOB 2.0 > - > > Key: HBASE-22749 > URL: https://issues.apache.org/jira/browse/HBASE-22749 > Project: HBase > Issue Type: New Feature > Components: mob >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Major > Attachments: HBase-MOB-2.0-v1.pdf, HBase-MOB-2.0-v2.1.pdf, > HBase-MOB-2.0-v2.pdf > > > There are several drawbacks in the original MOB 1.0 (Moderate Object > Storage) implementation, which can limit the adoption of the MOB feature: > # MOB compactions are executed in a Master as a chore, which limits > scalability because all I/O goes through a single HBase Master server. > # Yarn/Mapreduce framework is required to run MOB compactions in a scalable > way, but this won’t work in a stand-alone HBase cluster. > # Two separate compactors for MOB and for regular store files and their > interactions can result in a data loss (see HBASE-22075) > The design goals for MOB 2.0 were to provide 100% MOB 1.0 - compatible > implementation, which is free of the above drawbacks and can be used as a > drop in replacement in existing MOB deployments. So, these are design goals > of a MOB 2.0: > # Make MOB compactions scalable without relying on Yarn/Mapreduce framework > # Provide unified compactor for both MOB and regular store files > # Make it more robust especially w.r.t. to data losses. > # Simplify and reduce the overall MOB code. > # Provide 100% compatible implementation with MOB 1.0. > # No migration of data should be required between MOB 1.0 and MOB 2.0 - just > software upgrade. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22751) table.jsp fails if ugly regions in table
[ https://issues.apache.org/jira/browse/HBASE-22751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-22751: -- Resolution: Fixed Fix Version/s: 2.1.6 2.2.1 2.0.6 2.3.0 3.0.0 Status: Resolved (was: Patch Available) Pushed on branch-2.0+ > table.jsp fails if ugly regions in table > > > Key: HBASE-22751 > URL: https://issues.apache.org/jira/browse/HBASE-22751 > Project: HBase > Issue Type: Bug > Components: UI >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6 > > Attachments: HBASE-22751.master.001.patch, > HBASE-22751.master.001.patch > > > I'm playing w/ messing up hbase:meta as part of hbck2 messings. Noticed that > a bad server or an unknown region makes it so the table.jsp fails. > I noticed that Admin trying to get the compaction stats for the table will > get stuck trying to contact an unknown region and that when it does complete > eventually (tens of minutes...), it will spew an exception in the compaction > state location. > The listing of servers has an issue where if unknown server, then we'll try > to use a null address which does another spew of jsp complaint instead of > just logging an unknown > I tried messing around with Admin trying to set its Operation Timeout... but > Operation Timeout is not really settable unless you get a new Configuration > for a new Connection -- which is madness -- so instead just used the new > AsyncAdminBuilder where I can set operation timeout > It times out too quick but thats another issue the UI at least draws with > a messy hbase;meta. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Comment Edited] (HBASE-22751) table.jsp fails if ugly regions in table
[ https://issues.apache.org/jira/browse/HBASE-22751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895623#comment-16895623 ] stack edited comment on HBASE-22751 at 7/29/19 10:11 PM: - One is flakey seen in other hadoopqa submissions. The other has no relation. I've run both locally repeatedly. Pushing. was (Author: stack): One is flakey seen in other hadoopqa submissions. The other has not relation. I've run both locally repeatedly. Pushing. > table.jsp fails if ugly regions in table > > > Key: HBASE-22751 > URL: https://issues.apache.org/jira/browse/HBASE-22751 > Project: HBase > Issue Type: Bug > Components: UI >Reporter: stack >Assignee: stack >Priority: Major > Attachments: HBASE-22751.master.001.patch, > HBASE-22751.master.001.patch > > > I'm playing w/ messing up hbase:meta as part of hbck2 messings. Noticed that > a bad server or an unknown region makes it so the table.jsp fails. > I noticed that Admin trying to get the compaction stats for the table will > get stuck trying to contact an unknown region and that when it does complete > eventually (tens of minutes...), it will spew an exception in the compaction > state location. > The listing of servers has an issue where if unknown server, then we'll try > to use a null address which does another spew of jsp complaint instead of > just logging an unknown > I tried messing around with Admin trying to set its Operation Timeout... but > Operation Timeout is not really settable unless you get a new Configuration > for a new Connection -- which is madness -- so instead just used the new > AsyncAdminBuilder where I can set operation timeout > It times out too quick but thats another issue the UI at least draws with > a messy hbase;meta. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22751) table.jsp fails if ugly regions in table
[ https://issues.apache.org/jira/browse/HBASE-22751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895623#comment-16895623 ] stack commented on HBASE-22751: --- One is flakey seen in other hadoopqa submissions. The other has not relation. I've run both locally repeatedly. Pushing. > table.jsp fails if ugly regions in table > > > Key: HBASE-22751 > URL: https://issues.apache.org/jira/browse/HBASE-22751 > Project: HBase > Issue Type: Bug > Components: UI >Reporter: stack >Assignee: stack >Priority: Major > Attachments: HBASE-22751.master.001.patch, > HBASE-22751.master.001.patch > > > I'm playing w/ messing up hbase:meta as part of hbck2 messings. Noticed that > a bad server or an unknown region makes it so the table.jsp fails. > I noticed that Admin trying to get the compaction stats for the table will > get stuck trying to contact an unknown region and that when it does complete > eventually (tens of minutes...), it will spew an exception in the compaction > state location. > The listing of servers has an issue where if unknown server, then we'll try > to use a null address which does another spew of jsp complaint instead of > just logging an unknown > I tried messing around with Admin trying to set its Operation Timeout... but > Operation Timeout is not really settable unless you get a new Configuration > for a new Connection -- which is madness -- so instead just used the new > AsyncAdminBuilder where I can set operation timeout > It times out too quick but thats another issue the UI at least draws with > a messy hbase;meta. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22539) Potential WAL corruption due to early DBBs re-use.
[
https://issues.apache.org/jira/browse/HBASE-22539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895620#comment-16895620
]
Wellington Chevreuil commented on HBASE-22539:
--
Hey [~stack], thanks for chiming in.
{quote}The buffer used by the append must have been recycled and is in re-use
by another rcp call concurrently.{quote}
Yep, that was my thought after latest comment from [~Apache9]. I guess this may
be reproducible via test, say if we implement a dummy
_ByteBufferWriterOutputStream_ that always delays its work, while we bombard
the cluster with RPCs in the other end, we could get to this situation. Let me
try write this.
> Potential WAL corruption due to early DBBs re-use.
> ---
>
> Key: HBASE-22539
> URL: https://issues.apache.org/jira/browse/HBASE-22539
> Project: HBase
> Issue Type: Bug
> Components: rpc, wal
>Affects Versions: 2.1.1
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Blocker
>
> Summary
> We had been chasing a WAL corruption issue reported on one of our customers
> deployments running release 2.1.1 (CDH 6.1.0). After providing a custom
> modified jar with the extra sanity checks implemented by HBASE-21401 applied
> on some code points, plus additional debugging messages, we believe it is
> related to DirectByteBuffer usage, and Unsafe copy from offheap memory to
> on-heap array triggered
> [here|https://github.com/apache/hbase/blob/branch-2.1/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteBufferUtils.java#L1157],
> such as when writing into a non ByteBufferWriter type, as done
> [here|https://github.com/apache/hbase/blob/branch-2.1/hbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteBufferWriterOutputStream.java#L84].
> More details on the following comment.
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22751) table.jsp fails if ugly regions in table
[
https://issues.apache.org/jira/browse/HBASE-22751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895605#comment-16895605
]
HBase QA commented on HBASE-22751:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 2m
12s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m
23s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
38s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
31s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}270m 6s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
30s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}288m 48s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint |
| | hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base:
https://builds.apache.org/job/PreCommit-HBASE-Build/687/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22751 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12976129/HBASE-22751.master.001.patch
|
| Optional Tests | dupname asflicense javac javadoc unit |
| uname | Linux 5f9329e7c879 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 11f30de2cf |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/687/artifact/patchprocess/patch-unit-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/687/testReport/ |
| Max. process+thread count | 5249 (vs. ulimit of 1) |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/687/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |
This message was automatically generated.
> table.jsp fails if ugly regions in table
>
>
> Key: HBASE-22751
> URL: https://issues.apache.org/jira/browse/HBASE-22751
> Project: HBase
> Issue Type: Bug
> Components: UI
>Reporter: stack
>Assignee: stack
>Priority: Major
> Attachments: HBASE-22751.master.001.patch,
> HBASE-22751.master.001.patch
>
>
> I'm playing w/ messing up hbase:meta as part of hbck2 messings. Noticed that
> a bad server or an unknown region makes it so the table.jsp fails.
> I noticed that Admin trying to get the compaction stats for the table will
> get stuck trying to contact an unknown region and that when it does complete
> eventually (tens of minutes...), it will spew an exception in the compaction
> state location.
> The listing of servers has an issue where if unknown server, then we'll try
> to use a null address which does another spew of jsp complaint instead of
> just logging an unknown
> I tried messing around with Admin trying to set its Operation Timeout... but
> Operation Timeout is not really settable unless you get a new Configuration
> for a new Connection -- which is madness -- so instead just used the new
> AsyncAdminBuilder where I can set
[jira] [Comment Edited] (HBASE-22749) HBase MOB 2.0
[
https://issues.apache.org/jira/browse/HBASE-22749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895593#comment-16895593
]
Vladimir Rodionov edited comment on HBASE-22749 at 7/29/19 9:28 PM:
{quote}
Why is it called MOB 2.0? Seems to be just a change in compaction.
{quote}
Compaction changes are just first step. Yes, we are collecting feedback from
the community for features to add/change in MOB, such as already mentioned -
streaming access to MOB data.
{quote}
There is no more special compactor for MOB files, but the class that is doing
the compaction is named DefaultMobStoreCompactor; i.e. a compactor that is
'default' but for 'MOB'?
{quote}
DefaultMobStoreCompactor does not do MOB compactions in original MOB -
PartitionedMobCompactor does, which is gone now as all the mob.compactions
sub-package.
{quote}
On #3, to compact MOB, need to submit a major_compaction request. Does that
mean we major compact all in the target table – MOB and other files? Can I do
one or the other (MOB or HFiles).
{quote}
We are still considering support for *CompactType.MOB*. If there is request to
support that we will add it. In this case to start MOB compaction, user must
submit *major_compact* with type=CompactType.MOB request.
Upd.
Having thought about this - no it is not possible major compact only MOB files.
The CompactType.MOB request will have to compact both MOB and regular store
files and CompactType.NORMAL will compact only store files. This change can be
added.
{quote}
After finishing 'Unified Compactor' section, how does this differ from what was
there before? Why superior?
{quote}
Code reduction and unification is an advantage as well. But the overall
"superiority" comes from overall MOB 2.0 feature - not from Unified compactor
along. We describe the advantages in the design document.
was (Author: vrodionov):
{quote}
Why is it called MOB 2.0? Seems to be just a change in compaction.
{quote}
Compaction changes are just first step. Yes, we are collecting feedback from
the community for features to add/change in MOB, such as already mentioned -
streaming access to MOB data.
{quote}
There is no more special compactor for MOB files, but the class that is doing
the compaction is named DefaultMobStoreCompactor; i.e. a compactor that is
'default' but for 'MOB'?
{quote}
DefaultMobStoreCompactor does not do MOB compactions in original MOB -
PartitionedMobCompactor does, which is gone now as all the mob.compactions
sub-package.
{quote}
On #3, to compact MOB, need to submit a major_compaction request. Does that
mean we major compact all in the target table – MOB and other files? Can I do
one or the other (MOB or HFiles).
{quote}
We are still considering support for *CompactType.MOB*. If there is request to
support that we will add it. In this case to start MOB compaction, user must
submit *major_compact* with type=CompactType.MOB request.
{quote}
After finishing 'Unified Compactor' section, how does this differ from what was
there before? Why superior?
{quote}
Code reduction and unification is an advantage as well. But the overall
"superiority" comes from overall MOB 2.0 feature - not from Unified compactor
along. We describe the advantages in the design document.
> HBase MOB 2.0
> -
>
> Key: HBASE-22749
> URL: https://issues.apache.org/jira/browse/HBASE-22749
> Project: HBase
> Issue Type: New Feature
> Components: mob
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
>Priority: Major
> Attachments: HBase-MOB-2.0-v1.pdf, HBase-MOB-2.0-v2.pdf
>
>
> There are several drawbacks in the original MOB 1.0 (Moderate Object
> Storage) implementation, which can limit the adoption of the MOB feature:
> # MOB compactions are executed in a Master as a chore, which limits
> scalability because all I/O goes through a single HBase Master server.
> # Yarn/Mapreduce framework is required to run MOB compactions in a scalable
> way, but this won’t work in a stand-alone HBase cluster.
> # Two separate compactors for MOB and for regular store files and their
> interactions can result in a data loss (see HBASE-22075)
> The design goals for MOB 2.0 were to provide 100% MOB 1.0 - compatible
> implementation, which is free of the above drawbacks and can be used as a
> drop in replacement in existing MOB deployments. So, these are design goals
> of a MOB 2.0:
> # Make MOB compactions scalable without relying on Yarn/Mapreduce framework
> # Provide unified compactor for both MOB and regular store files
> # Make it more robust especially w.r.t. to data losses.
> # Simplify and reduce the overall MOB code.
> # Provide 100% compatible implementation with MOB 1.0.
> # No migration of data should be required between MOB 1.0 and MOB 2.0 - just
> software
[jira] [Commented] (HBASE-22749) HBase MOB 2.0
[
https://issues.apache.org/jira/browse/HBASE-22749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895593#comment-16895593
]
Vladimir Rodionov commented on HBASE-22749:
---
{quote}
Why is it called MOB 2.0? Seems to be just a change in compaction.
{quote}
Compaction changes are just first step. Yes, we are collecting feedback from
the community for features to add/change in MOB, such as already mentioned -
streaming access to MOB data.
{quote}
There is no more special compactor for MOB files, but the class that is doing
the compaction is named DefaultMobStoreCompactor; i.e. a compactor that is
'default' but for 'MOB'?
{quote}
DefaultMobStoreCompactor does not do MOB compactions in original MOB -
PartitionedMobCompactor does, which is gone now as all the mob.compactions
sub-package.
{quote}
On #3, to compact MOB, need to submit a major_compaction request. Does that
mean we major compact all in the target table – MOB and other files? Can I do
one or the other (MOB or HFiles).
{quote}
We are still considering support for *CompactType.MOB*. If there is request to
support that we will add it. In this case to start MOB compaction, user must
submit *major_compact* with type=CompactType.MOB request.
{quote}
After finishing 'Unified Compactor' section, how does this differ from what was
there before? Why superior?
{quote}
Code reduction and unification is an advantage as well. But the overall
"superiority" comes from overall MOB 2.0 feature - not from Unified compactor
along. We describe the advantages in the design document.
> HBase MOB 2.0
> -
>
> Key: HBASE-22749
> URL: https://issues.apache.org/jira/browse/HBASE-22749
> Project: HBase
> Issue Type: New Feature
> Components: mob
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
>Priority: Major
> Attachments: HBase-MOB-2.0-v1.pdf, HBase-MOB-2.0-v2.pdf
>
>
> There are several drawbacks in the original MOB 1.0 (Moderate Object
> Storage) implementation, which can limit the adoption of the MOB feature:
> # MOB compactions are executed in a Master as a chore, which limits
> scalability because all I/O goes through a single HBase Master server.
> # Yarn/Mapreduce framework is required to run MOB compactions in a scalable
> way, but this won’t work in a stand-alone HBase cluster.
> # Two separate compactors for MOB and for regular store files and their
> interactions can result in a data loss (see HBASE-22075)
> The design goals for MOB 2.0 were to provide 100% MOB 1.0 - compatible
> implementation, which is free of the above drawbacks and can be used as a
> drop in replacement in existing MOB deployments. So, these are design goals
> of a MOB 2.0:
> # Make MOB compactions scalable without relying on Yarn/Mapreduce framework
> # Provide unified compactor for both MOB and regular store files
> # Make it more robust especially w.r.t. to data losses.
> # Simplify and reduce the overall MOB code.
> # Provide 100% compatible implementation with MOB 1.0.
> # No migration of data should be required between MOB 1.0 and MOB 2.0 - just
> software upgrade.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend
Apache-HBase commented on issue #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend URL: https://github.com/apache/hbase/pull/390#issuecomment-516161562 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 43 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 282 | master passed | | -1 | compile | 33 | hbase-server in master failed. | | +1 | checkstyle | 73 | master passed | | +1 | shadedjars | 254 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 33 | master passed | | 0 | spotbugs | 241 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 240 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 281 | the patch passed | | +1 | compile | 51 | the patch passed | | +1 | javac | 51 | hbase-server generated 0 new + 6 unchanged - 2 fixed = 6 total (was 8) | | -1 | checkstyle | 78 | hbase-server: The patch generated 12 new + 345 unchanged - 0 fixed = 357 total (was 345) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 264 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 891 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | -1 | javadoc | 33 | hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 | findbugs | 234 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 9033 | hbase-server in the patch failed. | | +1 | asflicense | 26 | The patch does not generate ASF License warnings. | | | | 12213 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.regionserver.TestHRegion | | | hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/390 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux f8da6b92ce29 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-390@2/out/precommit/personality/provided.sh | | git revision | master / 11f30de2cf | | Default Java | 1.8.0_181 | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/3/artifact/out/branch-compile-hbase-server.txt | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/3/artifact/out/diff-checkstyle-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/3/artifact/out/diff-javadoc-javadoc-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/3/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/3/testReport/ | | Max. process+thread count | 4896 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/3/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-22749) HBase MOB 2.0
[ https://issues.apache.org/jira/browse/HBASE-22749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Rodionov updated HBASE-22749: -- Attachment: HBase-MOB-2.0-v2.pdf > HBase MOB 2.0 > - > > Key: HBASE-22749 > URL: https://issues.apache.org/jira/browse/HBASE-22749 > Project: HBase > Issue Type: New Feature > Components: mob >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Major > Attachments: HBase-MOB-2.0-v1.pdf, HBase-MOB-2.0-v2.pdf > > > There are several drawbacks in the original MOB 1.0 (Moderate Object > Storage) implementation, which can limit the adoption of the MOB feature: > # MOB compactions are executed in a Master as a chore, which limits > scalability because all I/O goes through a single HBase Master server. > # Yarn/Mapreduce framework is required to run MOB compactions in a scalable > way, but this won’t work in a stand-alone HBase cluster. > # Two separate compactors for MOB and for regular store files and their > interactions can result in a data loss (see HBASE-22075) > The design goals for MOB 2.0 were to provide 100% MOB 1.0 - compatible > implementation, which is free of the above drawbacks and can be used as a > drop in replacement in existing MOB deployments. So, these are design goals > of a MOB 2.0: > # Make MOB compactions scalable without relying on Yarn/Mapreduce framework > # Provide unified compactor for both MOB and regular store files > # Make it more robust especially w.r.t. to data losses. > # Simplify and reduce the overall MOB code. > # Provide 100% compatible implementation with MOB 1.0. > # No migration of data should be required between MOB 1.0 and MOB 2.0 - just > software upgrade. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22539) Potential WAL corruption due to early DBBs re-use.
[ https://issues.apache.org/jira/browse/HBASE-22539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895563#comment-16895563 ] stack commented on HBASE-22539: --- Is that not the ringbuffer eventhandler servicing thread, the one that pulls from the ringbuffer and does all appends? A single thread. The buffer used by the append must have been recycled and is in re-use by another rcp call concurrently. (Nice debugging in here on ugly issue [~wchevreuil]). > Potential WAL corruption due to early DBBs re-use. > --- > > Key: HBASE-22539 > URL: https://issues.apache.org/jira/browse/HBASE-22539 > Project: HBase > Issue Type: Bug > Components: rpc, wal >Affects Versions: 2.1.1 >Reporter: Wellington Chevreuil >Assignee: Wellington Chevreuil >Priority: Blocker > > Summary > We had been chasing a WAL corruption issue reported on one of our customers > deployments running release 2.1.1 (CDH 6.1.0). After providing a custom > modified jar with the extra sanity checks implemented by HBASE-21401 applied > on some code points, plus additional debugging messages, we believe it is > related to DirectByteBuffer usage, and Unsafe copy from offheap memory to > on-heap array triggered > [here|https://github.com/apache/hbase/blob/branch-2.1/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteBufferUtils.java#L1157], > such as when writing into a non ByteBufferWriter type, as done > [here|https://github.com/apache/hbase/blob/branch-2.1/hbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteBufferWriterOutputStream.java#L84]. > More details on the following comment. > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #426: HBASE-22695 Store the rsgroup of a table in table configuration
Apache-HBase commented on issue #426: HBASE-22695 Store the rsgroup of a table in table configuration URL: https://github.com/apache/hbase/pull/426#issuecomment-516143469 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 149 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 10 new or modified test files. | ||| _ HBASE-22514 Compile Tests _ | | 0 | mvndep | 46 | Maven dependency ordering for branch | | +1 | mvninstall | 472 | HBASE-22514 passed | | +1 | compile | 145 | HBASE-22514 passed | | +1 | checkstyle | 182 | HBASE-22514 passed | | +1 | shadedjars | 381 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 115 | HBASE-22514 passed | | 0 | spotbugs | 339 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 495 | HBASE-22514 passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 17 | Maven dependency ordering for patch | | +1 | mvninstall | 418 | the patch passed | | +1 | compile | 139 | the patch passed | | +1 | javac | 139 | the patch passed | | -1 | checkstyle | 111 | hbase-server: The patch generated 4 new + 136 unchanged - 17 fixed = 140 total (was 153) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 360 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1314 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 100 | the patch passed | | -1 | findbugs | 343 | hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | +1 | unit | 196 | hbase-common in the patch passed. | | +1 | unit | 130 | hbase-client in the patch passed. | | -1 | unit | 13823 | hbase-server in the patch failed. | | +1 | asflicense | 72 | The patch does not generate ASF License warnings. | | | | 19818 | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-server | | | Nullcheck of info at line 344 of value previously dereferenced in org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer.getMisplacedRegions(Map) At RSGroupBasedLoadBalancer.java:344 of value previously dereferenced in org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer.getMisplacedRegions(Map) At RSGroupBasedLoadBalancer.java:[line 344] | | Failed junit tests | hadoop.hbase.master.TestMasterShutdown | | | hadoop.hbase.rsgroup.TestRSGroupsKillRS | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/426 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux a511b186dc25 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-426/out/precommit/personality/provided.sh | | git revision | HBASE-22514 / 47d6533186 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/2/artifact/out/diff-checkstyle-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/2/artifact/out/new-findbugs-hbase-server.html | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/2/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/2/testReport/ | | Max. process+thread count | 4884 (vs. ulimit of 1) | | modules | C: hbase-common hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/2/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #431: HBASE-22764 Fixed remaining Checkstyle issues in the hbase-rsgroup module
Apache-HBase commented on issue #431: HBASE-22764 Fixed remaining Checkstyle issues in the hbase-rsgroup module URL: https://github.com/apache/hbase/pull/431#issuecomment-516139606 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 36 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 289 | master passed | | +1 | compile | 26 | master passed | | +1 | checkstyle | 12 | master passed | | +1 | shadedjars | 267 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 20 | master passed | | 0 | spotbugs | 45 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 42 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 293 | the patch passed | | +1 | compile | 25 | the patch passed | | +1 | javac | 25 | the patch passed | | +1 | checkstyle | 13 | hbase-rsgroup: The patch generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 264 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 879 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 18 | the patch passed | | +1 | findbugs | 48 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 274 | hbase-rsgroup in the patch passed. | | +1 | asflicense | 12 | The patch does not generate ASF License warnings. | | | | 2902 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-431/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/431 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux d12653f55680 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-431/out/precommit/personality/provided.sh | | git revision | master / 11f30de2cf | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-431/1/testReport/ | | Max. process+thread count | 4776 (vs. ulimit of 1) | | modules | C: hbase-rsgroup U: hbase-rsgroup | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-431/1/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #428: HBASE-22759 Add user info to AUDITLOG events when doing grant/revoke (master)
Apache-HBase commented on issue #428: HBASE-22759 Add user info to AUDITLOG events when doing grant/revoke (master) URL: https://github.com/apache/hbase/pull/428#issuecomment-516134536 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 145 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 464 | master passed | | +1 | compile | 75 | master passed | | +1 | checkstyle | 99 | master passed | | +1 | shadedjars | 363 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 48 | master passed | | 0 | spotbugs | 315 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 312 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 427 | the patch passed | | +1 | compile | 75 | the patch passed | | +1 | javac | 75 | the patch passed | | +1 | checkstyle | 99 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 353 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1418 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 46 | the patch passed | | +1 | findbugs | 312 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 14534 | hbase-server in the patch failed. | | +1 | asflicense | 35 | The patch does not generate ASF License warnings. | | | | 19357 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/428 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 76cf1366ad5d 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-428/out/precommit/personality/provided.sh | | git revision | master / 11f30de2cf | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/1/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/1/testReport/ | | Max. process+thread count | 4577 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/1/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22313) Add a method to FsDelegationToken to accept token kind
[ https://issues.apache.org/jira/browse/HBASE-22313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895542#comment-16895542 ] Peter Somogyi commented on HBASE-22313: --- For an example take a look at HBASE-22148. It is enough if you mention what token kind supports were added via this JIRA. > Add a method to FsDelegationToken to accept token kind > -- > > Key: HBASE-22313 > URL: https://issues.apache.org/jira/browse/HBASE-22313 > Project: HBase > Issue Type: New Feature > Components: security >Reporter: Venkatesh Sridharan >Assignee: Venkatesh Sridharan >Priority: Minor > Fix For: 3.0.0, 1.5.0, 2.3.0 > > Attachments: HBASE-22313.patch > > > The acquireDelegationToken method [1] defaults to checking for delegation > token of kind "HDFS_DELEGATION_TOKEN" before fetching it from the FileSystem. > It would be helpful to have a method that accepts the token kind and fetches > delegation token from UserProvider for that token kind. > [1] - > [https://github.com/apache/hbase/blob/rel/2.1.4/hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/FsDelegationToken.java#L67] > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #430: HBASE-22763 Fixed remaining Checkstyle issue in hbase-procedure
Apache-HBase commented on issue #430: HBASE-22763 Fixed remaining Checkstyle issue in hbase-procedure URL: https://github.com/apache/hbase/pull/430#issuecomment-516126413 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 40 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 1 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 312 | master passed | | +1 | compile | 19 | master passed | | +1 | checkstyle | 15 | master passed | | +1 | shadedjars | 287 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 17 | master passed | | 0 | spotbugs | 34 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 32 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 315 | the patch passed | | +1 | compile | 18 | the patch passed | | +1 | javac | 18 | the patch passed | | +1 | checkstyle | 14 | hbase-procedure: The patch generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 289 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 954 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 14 | the patch passed | | +1 | findbugs | 42 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 217 | hbase-procedure in the patch passed. | | +1 | asflicense | 9 | The patch does not generate ASF License warnings. | | | | 2986 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-430/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/430 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux e2d4bd5534ba 4.4.0-157-generic #185-Ubuntu SMP Tue Jul 23 09:17:01 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-430/out/precommit/personality/provided.sh | | git revision | master / 11f30de2cf | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-430/1/testReport/ | | Max. process+thread count | 315 (vs. ulimit of 1) | | modules | C: hbase-procedure U: hbase-procedure | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-430/1/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend
Apache-HBase commented on issue #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend URL: https://github.com/apache/hbase/pull/390#issuecomment-516124378 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 37 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 288 | master passed | | +1 | compile | 52 | master passed | | +1 | checkstyle | 81 | master passed | | +1 | shadedjars | 272 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 34 | master passed | | 0 | spotbugs | 226 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 224 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 291 | the patch passed | | +1 | compile | 53 | the patch passed | | +1 | javac | 53 | the patch passed | | -1 | checkstyle | 81 | hbase-server: The patch generated 12 new + 345 unchanged - 0 fixed = 357 total (was 345) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 271 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 908 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | -1 | javadoc | 33 | hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 | findbugs | 234 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 1759 | hbase-server in the patch failed. | | +1 | asflicense | 13 | The patch does not generate ASF License warnings. | | | | 5006 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.ipc.TestSimpleRpcScheduler | | | hadoop.hbase.ipc.TestBlockingIPC | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/4/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/390 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 2cab6ff06634 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-390/out/precommit/personality/provided.sh | | git revision | master / 11f30de2cf | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/4/artifact/out/diff-checkstyle-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/4/artifact/out/diff-javadoc-javadoc-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/4/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/4/testReport/ | | Max. process+thread count | 636 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/4/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] HorizonNet opened a new pull request #431: HBASE-22764 Fixed remaining Checkstyle issues in the hbase-rsgroup module
HorizonNet opened a new pull request #431: HBASE-22764 Fixed remaining Checkstyle issues in the hbase-rsgroup module URL: https://github.com/apache/hbase/pull/431 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend
Apache-HBase commented on issue #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend URL: https://github.com/apache/hbase/pull/390#issuecomment-516110778 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 44 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 314 | master passed | | +1 | compile | 57 | master passed | | +1 | checkstyle | 83 | master passed | | +1 | shadedjars | 274 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 35 | master passed | | 0 | spotbugs | 242 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 241 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 313 | the patch passed | | +1 | compile | 53 | the patch passed | | +1 | javac | 53 | the patch passed | | -1 | checkstyle | 82 | hbase-server: The patch generated 13 new + 345 unchanged - 0 fixed = 358 total (was 345) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 270 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 895 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | -1 | javadoc | 32 | hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 | findbugs | 237 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 1701 | hbase-server in the patch failed. | | +1 | asflicense | 13 | The patch does not generate ASF License warnings. | | | | 5015 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestIntraRowPagination | | | hadoop.hbase.io.encoding.TestSeekBeforeWithReverseScan | | | hadoop.hbase.regionserver.TestMinVersions | | | hadoop.hbase.filter.TestFilter | | | hadoop.hbase.io.hfile.TestScannerSelectionUsingKeyRange | | | hadoop.hbase.regionserver.TestKeepDeletes | | | hadoop.hbase.regionserver.TestScanner | | | hadoop.hbase.regionserver.TestScanWithBloomError | | | hadoop.hbase.filter.TestDependentColumnFilter | | | hadoop.hbase.filter.TestInvocationRecordFilter | | | hadoop.hbase.client.TestAsyncAccessControlAdminApi | | | hadoop.hbase.filter.TestFilterFromRegionSide | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/390 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux de8e8d4d0e16 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-390/out/precommit/personality/provided.sh | | git revision | master / 11f30de2cf | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/2/artifact/out/diff-checkstyle-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/2/artifact/out/diff-javadoc-javadoc-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/2/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/2/testReport/ | | Max. process+thread count | 700 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/2/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (HBASE-22764) Fix remaining Checkstyle issues in hbase-rsgroup
Jan Hentschel created HBASE-22764:
-
Summary: Fix remaining Checkstyle issues in hbase-rsgroup
Key: HBASE-22764
URL: https://issues.apache.org/jira/browse/HBASE-22764
Project: HBase
Issue Type: Improvement
Components: rsgroup
Affects Versions: 3.0.0
Reporter: Jan Hentschel
Assignee: Jan Hentschel
There are two Checkstyle issues left in the {{hbase-rsgroup}} module, which
need to be resolved.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Work started] (HBASE-22764) Fix remaining Checkstyle issues in hbase-rsgroup
[
https://issues.apache.org/jira/browse/HBASE-22764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HBASE-22764 started by Jan Hentschel.
-
> Fix remaining Checkstyle issues in hbase-rsgroup
>
>
> Key: HBASE-22764
> URL: https://issues.apache.org/jira/browse/HBASE-22764
> Project: HBase
> Issue Type: Improvement
> Components: rsgroup
>Affects Versions: 3.0.0
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Trivial
>
> There are two Checkstyle issues left in the {{hbase-rsgroup}} module, which
> need to be resolved.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] HorizonNet opened a new pull request #430: HBASE-22763 Fixed remaining Checkstyle issue in hbase-procedure
HorizonNet opened a new pull request #430: HBASE-22763 Fixed remaining Checkstyle issue in hbase-procedure URL: https://github.com/apache/hbase/pull/430 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Work started] (HBASE-22763) Fix remaining Checkstyle issue in hbase-procedure
[
https://issues.apache.org/jira/browse/HBASE-22763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HBASE-22763 started by Jan Hentschel.
-
> Fix remaining Checkstyle issue in hbase-procedure
> -
>
> Key: HBASE-22763
> URL: https://issues.apache.org/jira/browse/HBASE-22763
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Trivial
>
> There's a single Checkstyle issue left in the {{hbase-procedure}} module,
> which should be resolved.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Created] (HBASE-22763) Fix remaining Checkstyle issue in hbase-procedure
Jan Hentschel created HBASE-22763:
-
Summary: Fix remaining Checkstyle issue in hbase-procedure
Key: HBASE-22763
URL: https://issues.apache.org/jira/browse/HBASE-22763
Project: HBase
Issue Type: Improvement
Affects Versions: 3.0.0
Reporter: Jan Hentschel
Assignee: Jan Hentschel
There's a single Checkstyle issue left in the {{hbase-procedure}} module, which
should be resolved.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] gjacoby126 commented on a change in pull request #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend
gjacoby126 commented on a change in pull request #390: HBASE-22623 - Add
RegionObserver coprocessor hook for preWALAppend
URL: https://github.com/apache/hbase/pull/390#discussion_r308353738
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java
##
@@ -1104,4 +1105,18 @@ default DeleteTracker postInstantiateDeleteTracker(
throws IOException {
return delTracker;
}
+
+ /**
+ * Called just before the WAL Entry is appended to the WAL. Implementing
this hook allows
+ * coprocessors to add extended attributes to the WALKey that then get
persisted to the
+ * WAL, and are available to replication endpoints to use in processing WAL
Entries.
+ * @param ctx
+ * @param key
+ * @return
+ * @throws IOException
+ */
+ default WALKeyImpl
preWALAppend(ObserverContext ctx, WALKeyImpl key)
Review comment:
Also, it can't easily be WALEntry preWALAppend(ctx, entry), because
doWALAppend does not currently create a WALEntry (it passes the WALKey and
WALEdit as separate parameters)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] gjacoby126 commented on a change in pull request #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend
gjacoby126 commented on a change in pull request #390: HBASE-22623 - Add
RegionObserver coprocessor hook for preWALAppend
URL: https://github.com/apache/hbase/pull/390#discussion_r308353171
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
##
@@ -7934,8 +7934,9 @@ private WriteEntry doWALAppend(WALEdit walEdit,
Durability durability, List clusterIds,
- long now, long nonceGroup, long nonce, long origLogSeqNum) throws
IOException {
+ private WriteEntry doWALAppend( WALEdit walEdit, Durability durability,
List clusterIds,
Review comment:
Undid the accidental whitespace changes.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] gjacoby126 commented on a change in pull request #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend
gjacoby126 commented on a change in pull request #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend URL: https://github.com/apache/hbase/pull/390#discussion_r308353061 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -7953,6 +7954,7 @@ private WriteEntry doWALAppend(WALEdit walEdit, Durability durability, List
[jira] [Commented] (HBASE-22723) Have CatalogJanitor report holes and overlaps; i.e. problems it sees when doing its regular scan of hbase:meta
[ https://issues.apache.org/jira/browse/HBASE-22723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895472#comment-16895472 ] stack commented on HBASE-22723: --- .007 is same as .006. Retry. Checking tests locally, they pass. > Have CatalogJanitor report holes and overlaps; i.e. problems it sees when > doing its regular scan of hbase:meta > -- > > Key: HBASE-22723 > URL: https://issues.apache.org/jira/browse/HBASE-22723 > Project: HBase > Issue Type: Sub-task >Reporter: stack >Assignee: stack >Priority: Major > Attachments: HBASE-22723.branch-2.001.patch, > HBASE-22723.branch-2.002.patch, HBASE-22723.branch-2.003.patch, > HBASE-22723.branch-2.004.patch, HBASE-22723.branch-2.005.patch, > HBASE-22723.branch-2.006.patch, HBASE-22723.branch-2.007.patch > > > CatalogJanitor scans hbase:meta on a configurable period. Currently it just > looks for splits and merges to gc. Might as well generate a report on stuff > like holds, overlaps, empty regioninfos, and unknown servers while it is at > it. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22723) Have CatalogJanitor report holes and overlaps; i.e. problems it sees when doing its regular scan of hbase:meta
[ https://issues.apache.org/jira/browse/HBASE-22723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-22723: -- Attachment: HBASE-22723.branch-2.007.patch > Have CatalogJanitor report holes and overlaps; i.e. problems it sees when > doing its regular scan of hbase:meta > -- > > Key: HBASE-22723 > URL: https://issues.apache.org/jira/browse/HBASE-22723 > Project: HBase > Issue Type: Sub-task >Reporter: stack >Assignee: stack >Priority: Major > Attachments: HBASE-22723.branch-2.001.patch, > HBASE-22723.branch-2.002.patch, HBASE-22723.branch-2.003.patch, > HBASE-22723.branch-2.004.patch, HBASE-22723.branch-2.005.patch, > HBASE-22723.branch-2.006.patch, HBASE-22723.branch-2.007.patch > > > CatalogJanitor scans hbase:meta on a configurable period. Currently it just > looks for splits and merges to gc. Might as well generate a report on stuff > like holds, overlaps, empty regioninfos, and unknown servers while it is at > it. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22735) list_regions may throw an error if a region is RIT
[
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895466#comment-16895466
]
HBase QA commented on HBASE-22735:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 2m
27s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
4s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
15s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
25s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} rubocop {color} | {color:red} 0m
8s{color} | {color:red} The patch generated 12 new + 13 unchanged - 8 fixed =
25 total (was 21) {color} |
| {color:green}+1{color} | {color:green} ruby-lint {color} | {color:green} 0m
1s{color} | {color:green} There were no new ruby-lint issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
12s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 12m
19s{color} | {color:green} hbase-shell in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
11s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 30m 26s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base:
https://builds.apache.org/job/PreCommit-HBASE-Build/686/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22735 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12976128/HBASE-22735.master.01.patch
|
| Optional Tests | dupname asflicense javac javadoc unit rubocop
ruby_lint |
| uname | Linux 7a34870bbf1c 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4
22:49:08 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 11f30de2cf |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| rubocop | v0.73.0 |
| rubocop |
https://builds.apache.org/job/PreCommit-HBASE-Build/686/artifact/patchprocess/diff-patch-rubocop.txt
|
| ruby-lint | v2.3.1 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/686/testReport/ |
| Max. process+thread count | 2481 (vs. ulimit of 1) |
| modules | C: hbase-shell U: hbase-shell |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/686/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |
This message was automatically generated.
> list_regions may throw an error if a region is RIT
> --
>
> Key: HBASE-22735
> URL: https://issues.apache.org/jira/browse/HBASE-22735
> Project: HBase
> Issue Type: Bug
> Components: shell
>Affects Versions: 1.5.0
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22735.branch-1.01.patch,
> HBASE-22735.master.01.patch
>
>
> The 'list_regions' shell command gets a list of regions for a given table and
> then prints them and some attributes such as the server where they are
> located, current request count, data locality, and such.
> However if a region is in transition the command might fail with
> {{ERROR: undefined method `getDataLocality' for nil:NilClass}}
> and there may be other ways this can happen. Protect against use of nil
> references and just display what we can.
--
This message was sent by Atlassian JIRA
[jira] [Commented] (HBASE-22749) HBase MOB 2.0
[ https://issues.apache.org/jira/browse/HBASE-22749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895463#comment-16895463 ] stack commented on HBASE-22749: --- Skimmed PDF. Looks good. Why is it called MOB 2.0? Seems to be just a change in compaction. Can we have a true 2.0? Streaming/Chunking of big values writing smaller more hbase-friendly Cells that client aggregates rather than the big-Cell abuse that currently is MOB? On the first section: * It says, "There is no more special compactor for MOB files", but the class that is doing the compaction is named DefaultMobStoreCompactor; i.e. a compactor that is 'default' but for 'MOB'? * On #3, to compact MOB, need to submit a major_compaction request. Does that mean we major compact all in the target table -- MOB and other files? Can I do one or the other (MOB or HFiles). Operator has to manually run compactions? (But next section describes a chore to do this?) * After finishing 'Unified Compactor' section, how does this differ from what was there before? Why superior? ... ok, done. > HBase MOB 2.0 > - > > Key: HBASE-22749 > URL: https://issues.apache.org/jira/browse/HBASE-22749 > Project: HBase > Issue Type: New Feature > Components: mob >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Major > Attachments: HBase-MOB-2.0-v1.pdf > > > There are several drawbacks in the original MOB 1.0 (Moderate Object > Storage) implementation, which can limit the adoption of the MOB feature: > # MOB compactions are executed in a Master as a chore, which limits > scalability because all I/O goes through a single HBase Master server. > # Yarn/Mapreduce framework is required to run MOB compactions in a scalable > way, but this won’t work in a stand-alone HBase cluster. > # Two separate compactors for MOB and for regular store files and their > interactions can result in a data loss (see HBASE-22075) > The design goals for MOB 2.0 were to provide 100% MOB 1.0 - compatible > implementation, which is free of the above drawbacks and can be used as a > drop in replacement in existing MOB deployments. So, these are design goals > of a MOB 2.0: > # Make MOB compactions scalable without relying on Yarn/Mapreduce framework > # Provide unified compactor for both MOB and regular store files > # Make it more robust especially w.r.t. to data losses. > # Simplify and reduce the overall MOB code. > # Provide 100% compatible implementation with MOB 1.0. > # No migration of data should be required between MOB 1.0 and MOB 2.0 - just > software upgrade. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
