[GitHub] [hbase] Apache-HBase commented on issue #463: HBASE-22725 Remove all remaining javadoc warnings
Apache-HBase commented on issue #463: HBASE-22725 Remove all remaining javadoc warnings URL: https://github.com/apache/hbase/pull/463#issuecomment-519374789 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 56 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 3 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 37 | Maven dependency ordering for branch | | +1 | mvninstall | 331 | master passed | | +1 | compile | 183 | master passed | | +1 | checkstyle | 158 | master passed | | +1 | shadedjars | 284 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 254 | master passed | | 0 | spotbugs | 232 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 1285 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 14 | Maven dependency ordering for patch | | +1 | mvninstall | 319 | the patch passed | | +1 | compile | 185 | the patch passed | | +1 | javac | 185 | the patch passed | | -1 | checkstyle | 164 | root: The patch generated 1 new + 476 unchanged - 18 fixed = 477 total (was 494) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | xml | 1 | The patch has no ill-formed XML file. | | +1 | shadedjars | 287 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1016 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 23 | hbase-client generated 0 new + 2 unchanged - 1 fixed = 2 total (was 3) | | +1 | javadoc | 36 | hbase-server in the patch passed. | | +1 | javadoc | 17 | hbase-mapreduce in the patch passed. | | +1 | javadoc | 180 | root generated 0 new + 3 unchanged - 1 fixed = 3 total (was 4) | | +1 | findbugs | 1399 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 17735 | root in the patch failed. | | +1 | asflicense | 107 | The patch does not generate ASF License warnings. | | | | 24523 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestFromClientSide | | | hadoop.hbase.client.TestAsyncTableGetMultiThreaded | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-463/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/463 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile xml | | uname | Linux 50c70de1f89f 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-463/out/precommit/personality/provided.sh | | git revision | master / 1b168cd6de | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-463/3/artifact/out/diff-checkstyle-root.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-463/3/artifact/out/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-463/3/testReport/ | | Max. process+thread count | 5023 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server hbase-mapreduce . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-463/3/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22777) Add a multi-region merge (for fixing overlaps, etc.)
[ https://issues.apache.org/jira/browse/HBASE-22777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902699#comment-16902699 ] stack commented on HBASE-22777: --- Committed to branch-2.2+. Put up 2.1.001 for backport to branch-2.1. It needs work. Lets see what it breaks. > Add a multi-region merge (for fixing overlaps, etc.) > > > Key: HBASE-22777 > URL: https://issues.apache.org/jira/browse/HBASE-22777 > Project: HBase > Issue Type: Sub-task > Components: hbck2, proc-v2 >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.2.1 > > Attachments: HBASE-22777.branch-2.1.001.patch, > HBASE-22777.master.001.patch, HBASE-22777.master.002.patch, > HBASE-22777.master.003.patch, HBASE-22777.master.004.patch, > HBASE-22777.master.005.patch > > > MergeTableRegionProcedure does two regions at a time only. We have hardcoded > notion that merge has an 'A' and 'B' parent. > This issue is about making it so we merge N regions all in the one go. We > need this facility generally; will simplify operator's life being able to > merge up in one go rather than in steps of two. In particular, would make > fixing overlaps easier if could just merge all regions in the overlapping > area. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22777) Add a multi-region merge (for fixing overlaps, etc.)
[ https://issues.apache.org/jira/browse/HBASE-22777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-22777: -- Fix Version/s: 2.2.1 2.3.0 3.0.0 > Add a multi-region merge (for fixing overlaps, etc.) > > > Key: HBASE-22777 > URL: https://issues.apache.org/jira/browse/HBASE-22777 > Project: HBase > Issue Type: Sub-task > Components: hbck2, proc-v2 >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.2.1 > > Attachments: HBASE-22777.branch-2.1.001.patch, > HBASE-22777.master.001.patch, HBASE-22777.master.002.patch, > HBASE-22777.master.003.patch, HBASE-22777.master.004.patch, > HBASE-22777.master.005.patch > > > MergeTableRegionProcedure does two regions at a time only. We have hardcoded > notion that merge has an 'A' and 'B' parent. > This issue is about making it so we merge N regions all in the one go. We > need this facility generally; will simplify operator's life being able to > merge up in one go rather than in steps of two. In particular, would make > fixing overlaps easier if could just merge all regions in the overlapping > area. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22777) Add a multi-region merge (for fixing overlaps, etc.)
[ https://issues.apache.org/jira/browse/HBASE-22777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-22777: -- Attachment: HBASE-22777.branch-2.1.001.patch > Add a multi-region merge (for fixing overlaps, etc.) > > > Key: HBASE-22777 > URL: https://issues.apache.org/jira/browse/HBASE-22777 > Project: HBase > Issue Type: Sub-task > Components: hbck2, proc-v2 >Reporter: stack >Assignee: stack >Priority: Major > Attachments: HBASE-22777.branch-2.1.001.patch, > HBASE-22777.master.001.patch, HBASE-22777.master.002.patch, > HBASE-22777.master.003.patch, HBASE-22777.master.004.patch, > HBASE-22777.master.005.patch > > > MergeTableRegionProcedure does two regions at a time only. We have hardcoded > notion that merge has an 'A' and 'B' parent. > This issue is about making it so we merge N regions all in the one go. We > need this facility generally; will simplify operator's life being able to > merge up in one go rather than in steps of two. In particular, would make > fixing overlaps easier if could just merge all regions in the overlapping > area. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #456: HBASE-22631 assign failed may make gced parent region appear again
Apache-HBase commented on issue #456: HBASE-22631 assign failed may make gced parent region appear again URL: https://github.com/apache/hbase/pull/456#issuecomment-519367507 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 116 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-2.1 Compile Tests _ | | +1 | mvninstall | 367 | branch-2.1 passed | | +1 | compile | 60 | branch-2.1 passed | | +1 | checkstyle | 94 | branch-2.1 passed | | +1 | shadedjars | 285 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 40 | branch-2.1 passed | | 0 | spotbugs | 190 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 187 | branch-2.1 passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 338 | the patch passed | | +1 | compile | 61 | the patch passed | | +1 | javac | 61 | the patch passed | | +1 | checkstyle | 90 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 268 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1327 | Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2. | | +1 | javadoc | 35 | the patch passed | | +1 | findbugs | 183 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 11260 | hbase-server in the patch failed. | | +1 | asflicense | 38 | The patch does not generate ASF License warnings. | | | | 15145 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-456/13/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/456 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 2b3c150af251 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 18:22:20 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-456/out/precommit/personality/provided.sh | | git revision | branch-2.1 / 5cec62f0f9 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-456/13/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-456/13/testReport/ | | Max. process+thread count | 4807 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-456/13/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] gjacoby126 commented on a change in pull request #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend
gjacoby126 commented on a change in pull request #390: HBASE-22623 - Add
RegionObserver coprocessor hook for preWALAppend
URL: https://github.com/apache/hbase/pull/390#discussion_r311857487
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java
##
@@ -1104,4 +1104,16 @@ default DeleteTracker postInstantiateDeleteTracker(
throws IOException {
return delTracker;
}
+
+ /**
+ * Called just before the WAL Entry is appended to the WAL. Implementing
this hook allows
+ * coprocessors to add extended attributes to the WALKey that then get
persisted to the
+ * WAL, and are available to replication endpoints to use in processing WAL
Entries.
+ * @param ctx the environment provided by the region server
+ * @param key the WALKey associated with a particular append to a WAL
+ */
+ default void preWALAppend(ObserverContext ctx,
WALKey key,
Review comment:
@Apache9 Just to make sure I understand you right...you want me to write a
method which is Deprecated, as of the moment of its creation?
Adding a method to a public interface tells people they can use it.
Deprecating a method tells people they should stop using it or refrain from
starting to. Adding a deprecated method...just adds dead code.
Someday soon, there's going to be a Phoenix code review for changes I'll
make that use this method, and someone's going to say, "You can't use this
method; it's deprecated. -1" And they'll be completely right to say so.
Huh?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Reidddddd commented on issue #460: HBASE-22774 [WAL] RegionGroupingStrategy loses its function after split
Reidd commented on issue #460: HBASE-22774 [WAL] RegionGroupingStrategy loses its function after split URL: https://github.com/apache/hbase/pull/460#issuecomment-519366233 2nd commit, improve some naming readability. Original version is this kind of format (under RegionGroupingProvider): factoryID.providerID.***. In fact, factoryID and providerID is the same thing which is hostname,port,startcode. It repeats twice, that's why i remove them in second commit. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache9 commented on a change in pull request #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend
Apache9 commented on a change in pull request #390: HBASE-22623 - Add
RegionObserver coprocessor hook for preWALAppend
URL: https://github.com/apache/hbase/pull/390#discussion_r311854158
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java
##
@@ -1104,4 +1104,16 @@ default DeleteTracker postInstantiateDeleteTracker(
throws IOException {
return delTracker;
}
+
+ /**
+ * Called just before the WAL Entry is appended to the WAL. Implementing
this hook allows
+ * coprocessors to add extended attributes to the WALKey that then get
persisted to the
+ * WAL, and are available to replication endpoints to use in processing WAL
Entries.
+ * @param ctx the environment provided by the region server
+ * @param key the WALKey associated with a particular append to a WAL
+ */
+ default void preWALAppend(ObserverContext ctx,
WALKey key,
Review comment:
Please mark this method as deprecated so we keep consistent on that WALEdit
should not be exposed directly.
And no postWALAppend seems a bit strange to users but I think it is fine
here. We can add it when we actually want to use it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902674#comment-16902674 ] Duo Zhang commented on HBASE-22623: --- I mean the newly added coprocessor method. Let me comment on github. > Add RegionObserver coprocessor hook for preWALAppend > > > Key: HBASE-22623 > URL: https://issues.apache.org/jira/browse/HBASE-22623 > Project: HBase > Issue Type: New Feature >Reporter: Geoffrey Jacoby >Assignee: Geoffrey Jacoby >Priority: Major > Fix For: 3.0.0, 1.5.0, 2.3.0 > > > While many coprocessor hooks expose the WALEdit to implementing coprocs, > there aren't any that expose the WALKey before it's created and added to the > WALEntry. > It's sometimes useful for coprocessors to be able to edit the WALKey, for > example to add extended attributes using the fields to be added in > HBASE-22622. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #440: HBASE-22776 Rename config names in user scan snapshot feature
Apache-HBase commented on issue #440: HBASE-22776 Rename config names in user scan snapshot feature URL: https://github.com/apache/hbase/pull/440#issuecomment-519360660 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 54 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 323 | master passed | | +1 | compile | 54 | master passed | | +1 | checkstyle | 74 | master passed | | +1 | shadedjars | 273 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 37 | master passed | | 0 | spotbugs | 248 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 247 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 334 | the patch passed | | +1 | compile | 59 | the patch passed | | +1 | javac | 59 | the patch passed | | +1 | checkstyle | 75 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 296 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 914 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 35 | the patch passed | | +1 | findbugs | 249 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 17038 | hbase-server in the patch failed. | | +1 | asflicense | 43 | The patch does not generate ASF License warnings. | | | | 20531 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestFromClientSide | | | hadoop.hbase.master.TestAssignmentManagerMetrics | | | hadoop.hbase.client.TestCloneSnapshotFromClientNormal | | | hadoop.hbase.replication.TestReplicationSmallTests | | | hadoop.hbase.client.TestAsyncTableAdminApi | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-440/26/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/440 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 511868bfa7b7 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-440/out/precommit/personality/provided.sh | | git revision | master / 1b168cd6de | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-440/26/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-440/26/testReport/ | | Max. process+thread count | 5140 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-440/26/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902673#comment-16902673 ] Geoffrey Jacoby commented on HBASE-22623: - [~Apache9] - I apologize for being rude in my last reply. WALObserver vs RegionObserver's an easy mistake to make. What method would you like to be marked as deprecated? preWALWrite? Looks like it already is. As for WALEdit, the original comments warning developers not to touch it remain in the current version of the patch, as do the IA.Private attributes on the mutator methods like add. > Add RegionObserver coprocessor hook for preWALAppend > > > Key: HBASE-22623 > URL: https://issues.apache.org/jira/browse/HBASE-22623 > Project: HBase > Issue Type: New Feature >Reporter: Geoffrey Jacoby >Assignee: Geoffrey Jacoby >Priority: Major > Fix For: 3.0.0, 1.5.0, 2.3.0 > > > While many coprocessor hooks expose the WALEdit to implementing coprocs, > there aren't any that expose the WALKey before it's created and added to the > WALEntry. > It's sometimes useful for coprocessors to be able to edit the WALKey, for > example to add extended attributes using the fields to be added in > HBASE-22622. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #461: HBASE-22807 HBCK Report showed wrong orphans regions on FileSystem
Apache-HBase commented on issue #461: HBASE-22807 HBCK Report showed wrong orphans regions on FileSystem URL: https://github.com/apache/hbase/pull/461#issuecomment-519360591 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 67 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 386 | master passed | | +1 | compile | 54 | master passed | | +1 | checkstyle | 74 | master passed | | +1 | shadedjars | 273 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 37 | master passed | | 0 | spotbugs | 248 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 246 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 300 | the patch passed | | +1 | compile | 55 | the patch passed | | +1 | javac | 55 | the patch passed | | +1 | checkstyle | 77 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 278 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 936 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 37 | the patch passed | | +1 | findbugs | 253 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 17041 | hbase-server in the patch failed. | | +1 | asflicense | 27 | The patch does not generate ASF License warnings. | | | | 20511 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.regionserver.TestSplitTransactionOnCluster | | | hadoop.hbase.client.TestFromClientSide | | | hadoop.hbase.client.TestSnapshotTemporaryDirectory | | | hadoop.hbase.master.assignment.TestOpenRegionProcedureHang | | | hadoop.hbase.client.TestAsyncTableBatch | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-461/4/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/461 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux d0fca3344f76 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-461/out/precommit/personality/provided.sh | | git revision | master / 1b168cd6de | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-461/4/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-461/4/testReport/ | | Max. process+thread count | 4992 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-461/4/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Reidddddd commented on a change in pull request #460: HBASE-22774 [WAL] RegionGroupingStrategy loses its function after split
Reidd commented on a change in pull request #460: HBASE-22774 [WAL] RegionGroupingStrategy loses its function after split URL: https://github.com/apache/hbase/pull/460#discussion_r311851536 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -7177,8 +7177,8 @@ HRegion createDaughterRegionFromSplits(final HRegionInfo hri) throws IOException fs.commitDaughterRegion(hri); // Create the daughter HRegion instance -HRegion r = HRegion.newHRegion(this.fs.getTableDir(), this.getWAL(), fs.getFileSystem(), -this.getBaseConf(), hri, this.getTableDesc(), rsServices); +HRegion r = HRegion.newHRegion(this.fs.getTableDir(), rsServices.getWAL(hri), Review comment: > rsServices.getWAL(hri) Based on WALProvider impl, it will create a new wal according to strategy or inherit parent by default mode. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Reidddddd commented on a change in pull request #460: HBASE-22774 [WAL] RegionGroupingStrategy loses its function after split
Reidd commented on a change in pull request #460: HBASE-22774 [WAL] RegionGroupingStrategy loses its function after split URL: https://github.com/apache/hbase/pull/460#discussion_r311851536 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -7177,8 +7177,8 @@ HRegion createDaughterRegionFromSplits(final HRegionInfo hri) throws IOException fs.commitDaughterRegion(hri); // Create the daughter HRegion instance -HRegion r = HRegion.newHRegion(this.fs.getTableDir(), this.getWAL(), fs.getFileSystem(), -this.getBaseConf(), hri, this.getTableDesc(), rsServices); +HRegion r = HRegion.newHRegion(this.fs.getTableDir(), rsServices.getWAL(hri), Review comment: > rsServices.getWAL(hri) Based on WALProvider impl, it will create a new wal according to strategy or inherit parent by default mode. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-22774) [WAL] RegionGroupingStrategy loses its function after split
[
https://issues.apache.org/jira/browse/HBASE-22774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Reid Chan updated HBASE-22774:
--
Status: Patch Available (was: Open)
> [WAL] RegionGroupingStrategy loses its function after split
> ---
>
> Key: HBASE-22774
> URL: https://issues.apache.org/jira/browse/HBASE-22774
> Project: HBase
> Issue Type: Bug
> Components: wal
>Affects Versions: 1.4.6
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Attachments: HBASE-22774.branch-1.001.patch
>
>
> Having {{hbase.wal.provider}} set {{multiwal}}, it works fine on regionserver
> restart, at the beginning.
> But when region split happened, those daughter regions would inherit her
> parent's WAL, which violates the setting. For example, when
> {{hbase.wal.regiongrouping.strategy}} set {{identity}}, each daughter regions
> should create its own WAL instead of inheriting.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22806) Recreating a deleted column family brings back the deleted cells
[ https://issues.apache.org/jira/browse/HBASE-22806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902668#comment-16902668 ] Huon Wilson commented on HBASE-22806: - Thanks. It would only be a waste of time if it wasn't actually a problem (for example, if we spent two days trying to fix the issue, only for our patch to be rejected because the current behaviour is correct), so I wanted to make sure we had confirmation that it was a bug. > Recreating a deleted column family brings back the deleted cells > > > Key: HBASE-22806 > URL: https://issues.apache.org/jira/browse/HBASE-22806 > Project: HBase > Issue Type: Bug > Components: API >Affects Versions: 2.1.3 > Environment: Scala > HBase Java Client > Mac/Linux >Reporter: Chao >Priority: Major > > Steps to reproduce the bug: > # Create a table with column family CF > # Add some cells C1, C2 in CF > # Remove CF using either: > ** TableDescriptorBuilder.removeColumnFamily() and Admin.modifyTable() > ** Admin.deleteColumnFamily() > # Create CF again > Expected: no cells (all cells marked as deleted) in CF > Actual: C1, C2 shows up automatically in CF > Extra information: in step 3, if doing Admin.modifyColumnFamily() without > actually changing anything, then after step 4 the cells won't come back. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22806) Recreating a deleted column family brings back the deleted cells
[ https://issues.apache.org/jira/browse/HBASE-22806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902666#comment-16902666 ] Reid Chan commented on HBASE-22806: --- bq. it should do nothing .. have the same TableDescriptor.. ,the cells are deleted when that call does run. Yes, it is unreasonable. Community encourages volunteering, but under your context 'waste time' which sounds unwilling and being forced, I'd suggest you just set it aside and let someone have interest to take it.:) > Recreating a deleted column family brings back the deleted cells > > > Key: HBASE-22806 > URL: https://issues.apache.org/jira/browse/HBASE-22806 > Project: HBase > Issue Type: Bug > Components: API >Affects Versions: 2.1.3 > Environment: Scala > HBase Java Client > Mac/Linux >Reporter: Chao >Priority: Major > > Steps to reproduce the bug: > # Create a table with column family CF > # Add some cells C1, C2 in CF > # Remove CF using either: > ** TableDescriptorBuilder.removeColumnFamily() and Admin.modifyTable() > ** Admin.deleteColumnFamily() > # Create CF again > Expected: no cells (all cells marked as deleted) in CF > Actual: C1, C2 shows up automatically in CF > Extra information: in step 3, if doing Admin.modifyColumnFamily() without > actually changing anything, then after step 4 the cells won't come back. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #439: HBASE-22618 Provide a way to have Heterogeneous deployment
Apache-HBase commented on issue #439: HBASE-22618 Provide a way to have Heterogeneous deployment URL: https://github.com/apache/hbase/pull/439#issuecomment-519356400 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 33 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 415 | master passed | | +1 | compile | 60 | master passed | | +1 | checkstyle | 105 | master passed | | +1 | shadedjars | 352 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 44 | master passed | | 0 | spotbugs | 330 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 327 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 383 | the patch passed | | +1 | compile | 64 | the patch passed | | +1 | javac | 64 | the patch passed | | -1 | checkstyle | 113 | hbase-server: The patch generated 1 new + 64 unchanged - 0 fixed = 65 total (was 64) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 378 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1186 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 50 | the patch passed | | +1 | findbugs | 359 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 9936 | hbase-server in the patch passed. | | +1 | asflicense | 28 | The patch does not generate ASF License warnings. | | | | 14321 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/29/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/439 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 0026129e4ffe 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 18:22:20 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-439@2/out/precommit/personality/provided.sh | | git revision | master / 547cec4078 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/29/artifact/out/diff-checkstyle-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/29/testReport/ | | Max. process+thread count | 4436 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/29/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien…
Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien… URL: https://github.com/apache/hbase/pull/361#issuecomment-519356279 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 193 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 36 | Maven dependency ordering for branch | | +1 | mvninstall | 337 | master passed | | +1 | compile | 81 | master passed | | +1 | checkstyle | 123 | master passed | | +1 | shadedjars | 297 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 57 | master passed | | 0 | spotbugs | 257 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 324 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 17 | Maven dependency ordering for patch | | +1 | mvninstall | 324 | the patch passed | | +1 | compile | 81 | the patch passed | | +1 | javac | 81 | the patch passed | | +1 | checkstyle | 121 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 296 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1032 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 62 | the patch passed | | +1 | findbugs | 362 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 112 | hbase-client in the patch passed. | | -1 | unit | 14753 | hbase-server in the patch failed. | | +1 | asflicense | 48 | The patch does not generate ASF License warnings. | | | | 19075 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.regionserver.TestSplitTransactionOnCluster | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/80/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/361 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux fe369b5e3b29 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh | | git revision | master / 1b168cd6de | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/80/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/80/testReport/ | | Max. process+thread count | 4961 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/80/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22806) Recreating a deleted column family brings back the deleted cells
[
https://issues.apache.org/jira/browse/HBASE-22806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902658#comment-16902658
]
Huon Wilson commented on HBASE-22806:
-
I think it's clear that there is _something_ weird going on, because
{{admin.modifyTable(currentDesc)}} seems like it should do nothing at all (it
is "modifying" the table to have the same {{TableDescriptor}}), but:
* the cells are _not_ deleted when that call doesn't run
* the cells are deleted when that call does run
Do you agree that this is unreasonable?
Please confirm whether this is behaviour is correct or not, before we waste
time trying to fix it.
> Recreating a deleted column family brings back the deleted cells
>
>
> Key: HBASE-22806
> URL: https://issues.apache.org/jira/browse/HBASE-22806
> Project: HBase
> Issue Type: Bug
> Components: API
>Affects Versions: 2.1.3
> Environment: Scala
> HBase Java Client
> Mac/Linux
>Reporter: Chao
>Priority: Major
>
> Steps to reproduce the bug:
> # Create a table with column family CF
> # Add some cells C1, C2 in CF
> # Remove CF using either:
> ** TableDescriptorBuilder.removeColumnFamily() and Admin.modifyTable()
> ** Admin.deleteColumnFamily()
> # Create CF again
> Expected: no cells (all cells marked as deleted) in CF
> Actual: C1, C2 shows up automatically in CF
> Extra information: in step 3, if doing Admin.modifyColumnFamily() without
> actually changing anything, then after step 4 the cells won't come back.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] infraio commented on a change in pull request #465: HBASE-22808 HBCK Report showed the offline regions which belong to di…
infraio commented on a change in pull request #465: HBASE-22808 HBCK Report
showed the offline regions which belong to di…
URL: https://github.com/apache/hbase/pull/465#discussion_r311846631
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/CatalogJanitor.java
##
@@ -672,6 +672,11 @@ private void checkServer(byte [] metaTableRow,
RegionLocations locations) {
if (sn == null) {
continue;
}
+// skip the offline regions which belong to disabled table.
+if (services.getTableStateManager()
+.isTableState(location.getRegion().getTable(),
TableState.State.DISABLED)) {
Review comment:
There already a method which call isTableDisabled. Let me change to use that
one.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (HBASE-22816) confusion about the HBASE-11403 race condition issue
[ https://issues.apache.org/jira/browse/HBASE-22816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902642#comment-16902642 ] Reid Chan commented on HBASE-22816: --- Better ask this question in email where all devs and users can notice and answer your question, instead of raising a ticket. > confusion about the HBASE-11403 race condition issue > > > Key: HBASE-22816 > URL: https://issues.apache.org/jira/browse/HBASE-22816 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 1.0.0 > Environment: >Reporter: jay >Priority: Major > Fix For: 1.3.4 > > > Recently, when I read the hbase source code of version 1.0.0, I found a > method which I don't understand very much. That is the class > AsyncProcess.java in client package, I did not understand why the code if > (tasksInProgress.get() != oldInProgress) break exist in the private void > waitForMaximumCurrentTasks(int max) method, if the passed parameter max = > 0,then it is possible that the tasksInProgress.get() > 0 but > tasksInProgress.get() != oldInProgress,then the loop breaks,it is not what we > want, we need all the previous jobs is done before the loop breaks,right? In > the HBASE-11403, it is added to fix the race condition issue,I do not know > what will cause race condition. When I click the url of the Test results, it > is missing. Who can tell me why the code tasksInProgress.get() != > oldInProgress shoud be added there? -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22802) Avoid temp ByteBuffer allocation in FileIOEngine#read
[
https://issues.apache.org/jira/browse/HBASE-22802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902638#comment-16902638
]
chenxu commented on HBASE-22802:
a PR was add, hope you can review this [~openinx] , [~anoop.hbase]
> Avoid temp ByteBuffer allocation in FileIOEngine#read
> -
>
> Key: HBASE-22802
> URL: https://issues.apache.org/jira/browse/HBASE-22802
> Project: HBase
> Issue Type: Improvement
> Components: BucketCache
>Reporter: chenxu
>Assignee: chenxu
>Priority: Major
> Attachments: profile_mem_alloc.png
>
>
> a temp ByteBuffer was allocated each time FileIOEngine#read was called
> {code:java}
> public Cacheable read(BucketEntry be) throws IOException {
> long offset = be.offset();
> int length = be.getLength();
> Preconditions.checkArgument(length >= 0, "Length of read can not be less
> than 0.");
> ByteBuffer dstBuffer = ByteBuffer.allocate(length);
> ...
> }
> {code}
> we can avoid this by use of ByteBuffAllocator#allocate(length) after
> HBASE-21879
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22806) Recreating a deleted column family brings back the deleted cells
[
https://issues.apache.org/jira/browse/HBASE-22806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902637#comment-16902637
]
Reid Chan commented on HBASE-22806:
---
Please check source code: {{HMaster#modifyColumn, HMaster#deleteColumn,
HMaster#modifyTable}}
if you find any unreasonable or bug, feel free to attach patches.
> Recreating a deleted column family brings back the deleted cells
>
>
> Key: HBASE-22806
> URL: https://issues.apache.org/jira/browse/HBASE-22806
> Project: HBase
> Issue Type: Bug
> Components: API
>Affects Versions: 2.1.3
> Environment: Scala
> HBase Java Client
> Mac/Linux
>Reporter: Chao
>Priority: Major
>
> Steps to reproduce the bug:
> # Create a table with column family CF
> # Add some cells C1, C2 in CF
> # Remove CF using either:
> ** TableDescriptorBuilder.removeColumnFamily() and Admin.modifyTable()
> ** Admin.deleteColumnFamily()
> # Create CF again
> Expected: no cells (all cells marked as deleted) in CF
> Actual: C1, C2 shows up automatically in CF
> Extra information: in step 3, if doing Admin.modifyColumnFamily() without
> actually changing anything, then after step 4 the cells won't come back.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] saintstack commented on a change in pull request #465: HBASE-22808 HBCK Report showed the offline regions which belong to di…
saintstack commented on a change in pull request #465: HBASE-22808 HBCK Report
showed the offline regions which belong to di…
URL: https://github.com/apache/hbase/pull/465#discussion_r311845480
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/CatalogJanitor.java
##
@@ -672,6 +672,11 @@ private void checkServer(byte [] metaTableRow,
RegionLocations locations) {
if (sn == null) {
continue;
}
+// skip the offline regions which belong to disabled table.
+if (services.getTableStateManager()
+.isTableState(location.getRegion().getTable(),
TableState.State.DISABLED)) {
Review comment:
Oh. I see. I didn't see it in my reproduction of the issue.
Could be DISABLED or DISABLING. Thats what we check in other places IIRC.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] chenxu14 opened a new pull request #467: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read
chenxu14 opened a new pull request #467: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read URL: https://github.com/apache/hbase/pull/467 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache9 commented on a change in pull request #464: HBASE-22809 Allow creating table in group when rs group contains no l…
Apache9 commented on a change in pull request #464: HBASE-22809 Allow creating
table in group when rs group contains no l…
URL: https://github.com/apache/hbase/pull/464#discussion_r311845164
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminEndpoint.java
##
@@ -108,85 +108,119 @@ RSGroupAdminServiceImpl getGroupAdminService() {
@Override
public void
postClearDeadServers(ObserverContext ctx,
- List servers, List notClearedServers) throws
IOException {
+List servers, List notClearedServers) throws
IOException {
Set clearedServer =
-servers.stream().filter(server -> !notClearedServers.contains(server))
-.map(ServerName::getAddress).collect(Collectors.toSet());
+ servers.stream().filter(server -> !notClearedServers.contains(server))
+.map(ServerName::getAddress).collect(Collectors.toSet());
if (!clearedServer.isEmpty()) {
groupAdminServer.removeServers(clearedServer);
}
}
- private void checkGroupExists(Optional optGroupName) throws
IOException {
+ private RSGroupInfo checkGroupExists(Optional optGroupName) throws
IOException {
if (optGroupName.isPresent()) {
String groupName = optGroupName.get();
- if (groupAdminServer.getRSGroupInfo(groupName) == null) {
+ RSGroupInfo group = groupAdminServer.getRSGroupInfo(groupName);
+ if (group == null) {
throw new ConstraintException("Region server group " + groupName + "
does not exit");
}
+ return group;
}
+return null;
}
- private boolean rsgroupHasServersOnline(TableDescriptor desc) throws
IOException {
+ // Do not allow creating new tables which has an empty rs group, expect the
default rs group.
+ // Notice that we do not check for online servers, as this is not stable
because region server can
+ // die at any time.
+ private void checkForEmptyGroup(TableDescriptor desc) throws IOException {
+if (desc.getTableName().isSystemTable()) {
+ // do not check for system tables as we may block the bootstrap.
+ return;
+}
RSGroupInfo rsGroupInfo;
Optional optGroupName = desc.getRegionServerGroup();
if (optGroupName.isPresent()) {
String groupName = optGroupName.get();
if (groupName.equals(RSGroupInfo.DEFAULT_GROUP)) {
// do not check for default group
-return true;
+return;
}
rsGroupInfo = groupAdminServer.getRSGroupInfo(groupName);
if (rsGroupInfo == null) {
throw new ConstraintException(
-"RSGroup " + groupName + " for table " + desc.getTableName() + "
does not exist");
+ "RSGroup " + groupName + " for table " + desc.getTableName() + "
does not exist");
}
} else {
NamespaceDescriptor nd =
-
master.getClusterSchema().getNamespace(desc.getTableName().getNamespaceAsString());
+
master.getClusterSchema().getNamespace(desc.getTableName().getNamespaceAsString());
String groupNameOfNs =
nd.getConfigurationValue(RSGroupInfo.NAMESPACE_DESC_PROP_GROUP);
if (groupNameOfNs == null ||
groupNameOfNs.equals(RSGroupInfo.DEFAULT_GROUP)) {
// do not check for default group
-return true;
+return;
}
rsGroupInfo = groupAdminServer.getRSGroupInfo(groupNameOfNs);
if (rsGroupInfo == null) {
throw new ConstraintException("RSGroup " + groupNameOfNs + " for table
" +
-desc.getTableName() + "(inherit from namespace) does not exist");
+ desc.getTableName() + "(inherit from namespace) does not exist");
}
}
-return master.getServerManager().createDestinationServersList().stream()
-.anyMatch(onlineServer ->
rsGroupInfo.containsServer(onlineServer.getAddress()));
+if (rsGroupInfo.getServers().isEmpty()) {
+ throw new ConstraintException(
+"No servers in the rsgroup " + rsGroupInfo.getName() + " for " + desc);
+}
}
@Override
public void
preCreateTableAction(ObserverContext ctx,
- TableDescriptor desc, RegionInfo[] regions) throws IOException {
+TableDescriptor desc, RegionInfo[] regions) throws IOException {
checkGroupExists(desc.getRegionServerGroup());
-if (!desc.getTableName().isSystemTable() &&
!rsgroupHasServersOnline(desc)) {
- throw new HBaseIOException("No online servers in the rsgroup for " +
desc);
-}
+checkForEmptyGroup(desc);
}
@Override
public TableDescriptor
preModifyTable(ObserverContext ctx,
- TableName tableName, TableDescriptor currentDescriptor, TableDescriptor
newDescriptor)
- throws IOException {
-checkGroupExists(newDescriptor.getRegionServerGroup());
+TableName tableName, TableDescriptor currentDescriptor, TableDescriptor
newDescriptor)
+throws IOException {
+if
(!currentDescriptor.getRegionServerGroup().equals(newDescriptor.getRegionServerGroup()))
{
+ RSGroupInfo group =
[jira] [Updated] (HBASE-22816) confusion about the HBASE-11403 race condition issue
[ https://issues.apache.org/jira/browse/HBASE-22816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jay updated HBASE-22816: Issue Type: Bug (was: Wish) > confusion about the HBASE-11403 race condition issue > > > Key: HBASE-22816 > URL: https://issues.apache.org/jira/browse/HBASE-22816 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 1.0.0 > Environment: >Reporter: jay >Priority: Major > Fix For: 1.3.4 > > > Recently, when I read the hbase source code of version 1.0.0, I found a > method which I don't understand very much. That is the class > AsyncProcess.java in client package, I did not understand why the code if > (tasksInProgress.get() != oldInProgress) break exist in the private void > waitForMaximumCurrentTasks(int max) method, if the passed parameter max = > 0,then it is possible that the tasksInProgress.get() > 0 but > tasksInProgress.get() != oldInProgress,then the loop breaks,it is not what we > want, we need all the previous jobs is done before the loop breaks,right? In > the HBASE-11403, it is added to fix the race condition issue,I do not know > what will cause race condition. When I click the url of the Test results, it > is missing. Who can tell me why the code tasksInProgress.get() != > oldInProgress shoud be added there? -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22816) confusion about the HBASE-11403 race condition issue
[ https://issues.apache.org/jira/browse/HBASE-22816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jay updated HBASE-22816: Description: Recently, when I read the hbase source code, I found a method which I don't understand very much. That is the class AsyncProcess.java in client package, I did not understand why the code if (tasksInProgress.get() != oldInProgress) break exist in the private void waitForMaximumCurrentTasks(int max) method, if the passed parameter max = 0,then it is possible that the tasksInProgress.get() > 0 but tasksInProgress.get() != oldInProgress,then the loop breaks,it is not what we want, we need all the previous jobs is done before the loop breaks,right? In the HBASE-11403, it is added to fix the race condition issue,I do not know what will cause race condition. When I click the url of the Test results, it is missing. Who can tell me why the code tasksInProgress.get() != oldInProgress shoud be added there? (was: Recently, when I read the hbase source code, I found a menthod which I don't understand very much. That is the class AsyncProcess.java in client package, I did not understand why the code if (tasksInProgress.get() != oldInProgress) break exist in the private void waitForMaximumCurrentTasks(int max) method, if the passed parameter max = 0,then it is possible that the tasksInProgress.get() > 0 but tasksInProgress.get() != oldInProgress,then the loop breaks,it is not what we want, we need all the previous jobs is done before the loop breaks,right? In the HBASE-11403, it is added to fix the race condition issue,I do not know what will cause race condition. When I click the url of the Test results, it is missing. Who can tell me why the code tasksInProgress.get() != oldInProgress shoud be added there?) > confusion about the HBASE-11403 race condition issue > > > Key: HBASE-22816 > URL: https://issues.apache.org/jira/browse/HBASE-22816 > Project: HBase > Issue Type: Wish > Components: Client >Affects Versions: 1.0.0 > Environment: >Reporter: jay >Priority: Major > Fix For: 1.3.4 > > > Recently, when I read the hbase source code, I found a method which I don't > understand very much. That is the class AsyncProcess.java in client package, > I did not understand why the code if (tasksInProgress.get() != > oldInProgress) break exist in the private void > waitForMaximumCurrentTasks(int max) method, if the passed parameter max = > 0,then it is possible that the tasksInProgress.get() > 0 but > tasksInProgress.get() != oldInProgress,then the loop breaks,it is not what we > want, we need all the previous jobs is done before the loop breaks,right? In > the HBASE-11403, it is added to fix the race condition issue,I do not know > what will cause race condition. When I click the url of the Test results, it > is missing. Who can tell me why the code tasksInProgress.get() != > oldInProgress shoud be added there? -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22816) confusion about the HBASE-11403 race condition issue
[ https://issues.apache.org/jira/browse/HBASE-22816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jay updated HBASE-22816: Description: Recently, when I read the hbase source code of version 1.0.0, I found a method which I don't understand very much. That is the class AsyncProcess.java in client package, I did not understand why the code if (tasksInProgress.get() != oldInProgress) break exist in the private void waitForMaximumCurrentTasks(int max) method, if the passed parameter max = 0,then it is possible that the tasksInProgress.get() > 0 but tasksInProgress.get() != oldInProgress,then the loop breaks,it is not what we want, we need all the previous jobs is done before the loop breaks,right? In the HBASE-11403, it is added to fix the race condition issue,I do not know what will cause race condition. When I click the url of the Test results, it is missing. Who can tell me why the code tasksInProgress.get() != oldInProgress shoud be added there? (was: Recently, when I read the hbase source code, I found a method which I don't understand very much. That is the class AsyncProcess.java in client package, I did not understand why the code if (tasksInProgress.get() != oldInProgress) break exist in the private void waitForMaximumCurrentTasks(int max) method, if the passed parameter max = 0,then it is possible that the tasksInProgress.get() > 0 but tasksInProgress.get() != oldInProgress,then the loop breaks,it is not what we want, we need all the previous jobs is done before the loop breaks,right? In the HBASE-11403, it is added to fix the race condition issue,I do not know what will cause race condition. When I click the url of the Test results, it is missing. Who can tell me why the code tasksInProgress.get() != oldInProgress shoud be added there?) > confusion about the HBASE-11403 race condition issue > > > Key: HBASE-22816 > URL: https://issues.apache.org/jira/browse/HBASE-22816 > Project: HBase > Issue Type: Wish > Components: Client >Affects Versions: 1.0.0 > Environment: >Reporter: jay >Priority: Major > Fix For: 1.3.4 > > > Recently, when I read the hbase source code of version 1.0.0, I found a > method which I don't understand very much. That is the class > AsyncProcess.java in client package, I did not understand why the code if > (tasksInProgress.get() != oldInProgress) break exist in the private void > waitForMaximumCurrentTasks(int max) method, if the passed parameter max = > 0,then it is possible that the tasksInProgress.get() > 0 but > tasksInProgress.get() != oldInProgress,then the loop breaks,it is not what we > want, we need all the previous jobs is done before the loop breaks,right? In > the HBASE-11403, it is added to fix the race condition issue,I do not know > what will cause race condition. When I click the url of the Test results, it > is missing. Who can tell me why the code tasksInProgress.get() != > oldInProgress shoud be added there? -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22816) confusion about the HBASE-11403 race condition issue
[ https://issues.apache.org/jira/browse/HBASE-22816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jay updated HBASE-22816: Description: Recently, when I read the hbase source code, I found a menthod which I don't understand very much. That is the class AsyncProcess.java in client package, I did not understand why the code if (tasksInProgress.get() != oldInProgress) break exist in the private void waitForMaximumCurrentTasks(int max) method, if the passed parameter max = 0,then it is possible that the tasksInProgress.get() > 0 but tasksInProgress.get() != oldInProgress,then the loop breaks,it is not what we want, we need all the previous jobs is done before the loop breaks,right? In the HBASE-11403, it is added to fix the race condition issue,I do not know what will cause race condition. When I click the url of the Test results, it is missing. Who can tell me why the code tasksInProgress.get() != oldInProgress shoud be added there? (was: Recently, when I read the hbase source code, I found a menthod which I don't understand very much. That is the class AsyncProcess.java in client package, I did not understand why the code if (tasksInProgress.get() != oldInProgress) break exist in the private void waitForMaximumCurrentTasks(int max) method, if the passed parameter max = 0,then it is possible that the tasksInProgress.get() > 0 but tasksInProgress.get() != oldInProgress,then the loop breaks,it is not what we want, we need all the previos jobs is done before the loop breaks,right? In the HBASE-11403, it is added to fix the race condition,I do not know what will cause race condition. When I click the url of the Test results, it is missing. Who can tell me why the code tasksInProgress.get() != oldInProgress shoud be added there?) > confusion about the HBASE-11403 race condition issue > > > Key: HBASE-22816 > URL: https://issues.apache.org/jira/browse/HBASE-22816 > Project: HBase > Issue Type: Wish > Components: Client >Affects Versions: 1.0.0 > Environment: >Reporter: jay >Priority: Major > Fix For: 1.3.4 > > > Recently, when I read the hbase source code, I found a menthod which I don't > understand very much. That is the class AsyncProcess.java in client package, > I did not understand why the code if (tasksInProgress.get() != > oldInProgress) break exist in the private void > waitForMaximumCurrentTasks(int max) method, if the passed parameter max = > 0,then it is possible that the tasksInProgress.get() > 0 but > tasksInProgress.get() != oldInProgress,then the loop breaks,it is not what we > want, we need all the previous jobs is done before the loop breaks,right? In > the HBASE-11403, it is added to fix the race condition issue,I do not know > what will cause race condition. When I click the url of the Test results, it > is missing. Who can tell me why the code tasksInProgress.get() != > oldInProgress shoud be added there? -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Created] (HBASE-22816) confusion about the HBASE-11403 race condition issue
jay created HBASE-22816: --- Summary: confusion about the HBASE-11403 race condition issue Key: HBASE-22816 URL: https://issues.apache.org/jira/browse/HBASE-22816 Project: HBase Issue Type: Wish Components: Client Affects Versions: 1.0.0 Environment: Reporter: jay Fix For: 1.3.4 Recently, when I read the hbase source code, I found a menthod which I don't understand very much. That is the class AsyncProcess.java in client package, I did not understand why the code if (tasksInProgress.get() != oldInProgress) break exist in the private void waitForMaximumCurrentTasks(int max) method, if the passed parameter max = 0,then it is possible that the tasksInProgress.get() > 0 but tasksInProgress.get() != oldInProgress,then the loop breaks,it is not what we want, we need all the previos jobs is done before the loop breaks,right? In the HBASE-11403, it is added to fix the race condition,I do not know what will cause race condition. When I click the url of the Test results, it is missing. Who can tell me why the code tasksInProgress.get() != oldInProgress shoud be added there? -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] infraio commented on a change in pull request #466: HBASE-22803 Modify config value range to enable turning off of the hbck chore
infraio commented on a change in pull request #466: HBASE-22803 Modify config
value range to enable turning off of the hbck chore
URL: https://github.com/apache/hbase/pull/466#discussion_r311842813
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HbckChore.java
##
@@ -98,29 +98,49 @@
private volatile long checkingStartTimestamp = 0;
private volatile long checkingEndTimestamp = 0;
+ private boolean stopped = false;
+
public HbckChore(MasterServices master) {
super("HbckChore-", master,
master.getConfiguration().getInt(HBCK_CHORE_INTERVAL,
DEFAULT_HBCK_CHORE_INTERVAL));
this.master = master;
+int interval =
+master.getConfiguration().getInt(HBCK_CHORE_INTERVAL,
DEFAULT_HBCK_CHORE_INTERVAL);
+if (interval <= 0) {
+ LOG.warn(HBCK_CHORE_INTERVAL + "is <=0 hence disabling hbck chore");
Review comment:
Need a whitespace before "is".
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] infraio commented on a change in pull request #466: HBASE-22803 Modify config value range to enable turning off of the hbck chore
infraio commented on a change in pull request #466: HBASE-22803 Modify config value range to enable turning off of the hbck chore URL: https://github.com/apache/hbase/pull/466#discussion_r311842749 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HbckChore.java ## @@ -98,29 +98,49 @@ private volatile long checkingStartTimestamp = 0; private volatile long checkingEndTimestamp = 0; + private boolean stopped = false; Review comment: stopped ==> disabled? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Comment Edited] (HBASE-22806) Recreating a deleted column family brings back the deleted cells
[
https://issues.apache.org/jira/browse/HBASE-22806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902623#comment-16902623
]
Chao edited comment on HBASE-22806 at 8/8/19 3:23 AM:
--
{quote}How do you build the {{ColumnFamilyDescriptor}}?
{quote}
Using {{ColumnFamilyDescriptorBuilder.newBuilder(existingCf)}} without changing
any config will give the expected result.
[~reidchan]
was (Author: lichaoir):
[~reidchan]
> Recreating a deleted column family brings back the deleted cells
>
>
> Key: HBASE-22806
> URL: https://issues.apache.org/jira/browse/HBASE-22806
> Project: HBase
> Issue Type: Bug
> Components: API
>Affects Versions: 2.1.3
> Environment: Scala
> HBase Java Client
> Mac/Linux
>Reporter: Chao
>Priority: Major
>
> Steps to reproduce the bug:
> # Create a table with column family CF
> # Add some cells C1, C2 in CF
> # Remove CF using either:
> ** TableDescriptorBuilder.removeColumnFamily() and Admin.modifyTable()
> ** Admin.deleteColumnFamily()
> # Create CF again
> Expected: no cells (all cells marked as deleted) in CF
> Actual: C1, C2 shows up automatically in CF
> Extra information: in step 3, if doing Admin.modifyColumnFamily() without
> actually changing anything, then after step 4 the cells won't come back.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Comment Edited] (HBASE-22806) Recreating a deleted column family brings back the deleted cells
[
https://issues.apache.org/jira/browse/HBASE-22806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902623#comment-16902623
]
Chao edited comment on HBASE-22806 at 8/8/19 3:21 AM:
--
[~reidchan]
was (Author: lichaoir):
bq. How do you build the {{ColumnFamilyDescriptor}}?
Using {{ColumnFamilyDescriptorBuilder.newBuilder(existingCf))}} without
changing anything will give the expected result.
> Recreating a deleted column family brings back the deleted cells
>
>
> Key: HBASE-22806
> URL: https://issues.apache.org/jira/browse/HBASE-22806
> Project: HBase
> Issue Type: Bug
> Components: API
>Affects Versions: 2.1.3
> Environment: Scala
> HBase Java Client
> Mac/Linux
>Reporter: Chao
>Priority: Major
>
> Steps to reproduce the bug:
> # Create a table with column family CF
> # Add some cells C1, C2 in CF
> # Remove CF using either:
> ** TableDescriptorBuilder.removeColumnFamily() and Admin.modifyTable()
> ** Admin.deleteColumnFamily()
> # Create CF again
> Expected: no cells (all cells marked as deleted) in CF
> Actual: C1, C2 shows up automatically in CF
> Extra information: in step 3, if doing Admin.modifyColumnFamily() without
> actually changing anything, then after step 4 the cells won't come back.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22806) Recreating a deleted column family brings back the deleted cells
[
https://issues.apache.org/jira/browse/HBASE-22806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902623#comment-16902623
]
Chao commented on HBASE-22806:
--
bq. How do you build the {{ColumnFamilyDescriptor}}?
Using {{ColumnFamilyDescriptorBuilder.newBuilder(existingCf))}} without
changing anything will give the expected result.
> Recreating a deleted column family brings back the deleted cells
>
>
> Key: HBASE-22806
> URL: https://issues.apache.org/jira/browse/HBASE-22806
> Project: HBase
> Issue Type: Bug
> Components: API
>Affects Versions: 2.1.3
> Environment: Scala
> HBase Java Client
> Mac/Linux
>Reporter: Chao
>Priority: Major
>
> Steps to reproduce the bug:
> # Create a table with column family CF
> # Add some cells C1, C2 in CF
> # Remove CF using either:
> ** TableDescriptorBuilder.removeColumnFamily() and Admin.modifyTable()
> ** Admin.deleteColumnFamily()
> # Create CF again
> Expected: no cells (all cells marked as deleted) in CF
> Actual: C1, C2 shows up automatically in CF
> Extra information: in step 3, if doing Admin.modifyColumnFamily() without
> actually changing anything, then after step 4 the cells won't come back.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22806) Recreating a deleted column family brings back the deleted cells
[
https://issues.apache.org/jira/browse/HBASE-22806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902622#comment-16902622
]
Reid Chan commented on HBASE-22806:
---
{{admin.modifyTable(currentDesc);}} this method may delete cf on HDFS as you
said, but not {{deleteColumnFamily}} and {{modify***}} this kind of CF levels.
[~tmoschou]
> Recreating a deleted column family brings back the deleted cells
>
>
> Key: HBASE-22806
> URL: https://issues.apache.org/jira/browse/HBASE-22806
> Project: HBase
> Issue Type: Bug
> Components: API
>Affects Versions: 2.1.3
> Environment: Scala
> HBase Java Client
> Mac/Linux
>Reporter: Chao
>Priority: Major
>
> Steps to reproduce the bug:
> # Create a table with column family CF
> # Add some cells C1, C2 in CF
> # Remove CF using either:
> ** TableDescriptorBuilder.removeColumnFamily() and Admin.modifyTable()
> ** Admin.deleteColumnFamily()
> # Create CF again
> Expected: no cells (all cells marked as deleted) in CF
> Actual: C1, C2 shows up automatically in CF
> Extra information: in step 3, if doing Admin.modifyColumnFamily() without
> actually changing anything, then after step 4 the cells won't come back.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902621#comment-16902621 ] Duo Zhang commented on HBASE-22623: --- Oh, I misread the patch. I thought it is in WALObserver. Sorry. Then please mark it as deprecated, and mention that WALEdit is IA.Private so do not touch it if possible. Thanks. > Add RegionObserver coprocessor hook for preWALAppend > > > Key: HBASE-22623 > URL: https://issues.apache.org/jira/browse/HBASE-22623 > Project: HBase > Issue Type: New Feature >Reporter: Geoffrey Jacoby >Assignee: Geoffrey Jacoby >Priority: Major > Fix For: 3.0.0, 1.5.0, 2.3.0 > > > While many coprocessor hooks expose the WALEdit to implementing coprocs, > there aren't any that expose the WALKey before it's created and added to the > WALEntry. > It's sometimes useful for coprocessors to be able to edit the WALKey, for > example to add extended attributes using the fields to be added in > HBASE-22622. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902619#comment-16902619 ] Andrew Purtell commented on HBASE-22623: I think we’re just having a bit of a miscommunication. I read Duo’s comment as a suggestion to move the current WALObserver method over to RegionObserver. However I believe that the wrong approach because it breaks both interfaces. At least with the current patch we are binary compatible and source incompatible only in RegionObserver. I plan to commit it tomorrow > Add RegionObserver coprocessor hook for preWALAppend > > > Key: HBASE-22623 > URL: https://issues.apache.org/jira/browse/HBASE-22623 > Project: HBase > Issue Type: New Feature >Reporter: Geoffrey Jacoby >Assignee: Geoffrey Jacoby >Priority: Major > Fix For: 3.0.0, 1.5.0, 2.3.0 > > > While many coprocessor hooks expose the WALEdit to implementing coprocs, > there aren't any that expose the WALKey before it's created and added to the > WALEntry. > It's sometimes useful for coprocessors to be able to edit the WALKey, for > example to add extended attributes using the fields to be added in > HBASE-22622. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22806) Recreating a deleted column family brings back the deleted cells
[ https://issues.apache.org/jira/browse/HBASE-22806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902618#comment-16902618 ] Reid Chan commented on HBASE-22806: --- [~wchevreuil] hmm no, different story IMO. > Recreating a deleted column family brings back the deleted cells > > > Key: HBASE-22806 > URL: https://issues.apache.org/jira/browse/HBASE-22806 > Project: HBase > Issue Type: Bug > Components: API >Affects Versions: 2.1.3 > Environment: Scala > HBase Java Client > Mac/Linux >Reporter: Chao >Priority: Major > > Steps to reproduce the bug: > # Create a table with column family CF > # Add some cells C1, C2 in CF > # Remove CF using either: > ** TableDescriptorBuilder.removeColumnFamily() and Admin.modifyTable() > ** Admin.deleteColumnFamily() > # Create CF again > Expected: no cells (all cells marked as deleted) in CF > Actual: C1, C2 shows up automatically in CF > Extra information: in step 3, if doing Admin.modifyColumnFamily() without > actually changing anything, then after step 4 the cells won't come back. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22806) Recreating a deleted column family brings back the deleted cells
[ https://issues.apache.org/jira/browse/HBASE-22806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902617#comment-16902617 ] Reid Chan commented on HBASE-22806: --- bq. is this not the case with HBase's implementation? No, it is not. bq. Does this have the potential for data, once protected by a column family scoped ACL, to no longer be secure? To be more specific? Can't understand the question. > Recreating a deleted column family brings back the deleted cells > > > Key: HBASE-22806 > URL: https://issues.apache.org/jira/browse/HBASE-22806 > Project: HBase > Issue Type: Bug > Components: API >Affects Versions: 2.1.3 > Environment: Scala > HBase Java Client > Mac/Linux >Reporter: Chao >Priority: Major > > Steps to reproduce the bug: > # Create a table with column family CF > # Add some cells C1, C2 in CF > # Remove CF using either: > ** TableDescriptorBuilder.removeColumnFamily() and Admin.modifyTable() > ** Admin.deleteColumnFamily() > # Create CF again > Expected: no cells (all cells marked as deleted) in CF > Actual: C1, C2 shows up automatically in CF > Extra information: in step 3, if doing Admin.modifyColumnFamily() without > actually changing anything, then after step 4 the cells won't come back. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902615#comment-16902615 ] Geoffrey Jacoby commented on HBASE-22623: - [~Apache9] - the new method is in RegionObserver, and always has been. Did you read the patch you rejected? > Add RegionObserver coprocessor hook for preWALAppend > > > Key: HBASE-22623 > URL: https://issues.apache.org/jira/browse/HBASE-22623 > Project: HBase > Issue Type: New Feature >Reporter: Geoffrey Jacoby >Assignee: Geoffrey Jacoby >Priority: Major > Fix For: 3.0.0, 1.5.0, 2.3.0 > > > While many coprocessor hooks expose the WALEdit to implementing coprocs, > there aren't any that expose the WALKey before it's created and added to the > WALEntry. > It's sometimes useful for coprocessors to be able to edit the WALKey, for > example to add extended attributes using the fields to be added in > HBASE-22622. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902616#comment-16902616 ] Andrew Purtell commented on HBASE-22623: This patch does place the method in RegionObserver. Without making any incompatible changes elsewhere. > Add RegionObserver coprocessor hook for preWALAppend > > > Key: HBASE-22623 > URL: https://issues.apache.org/jira/browse/HBASE-22623 > Project: HBase > Issue Type: New Feature >Reporter: Geoffrey Jacoby >Assignee: Geoffrey Jacoby >Priority: Major > Fix For: 3.0.0, 1.5.0, 2.3.0 > > > While many coprocessor hooks expose the WALEdit to implementing coprocs, > there aren't any that expose the WALKey before it's created and added to the > WALEntry. > It's sometimes useful for coprocessors to be able to edit the WALKey, for > example to add extended attributes using the fields to be added in > HBASE-22622. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] jatsakthi opened a new pull request #466: HBASE-22803 Modify config value range to enable turning off of the hbck chore
jatsakthi opened a new pull request #466: HBASE-22803 Modify config value range to enable turning off of the hbck chore URL: https://github.com/apache/hbase/pull/466 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-22803) Modify config value range to enable turning off of the hbck chore
[ https://issues.apache.org/jira/browse/HBASE-22803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sakthi updated HBASE-22803: --- Summary: Modify config value range to enable turning off of the hbck chore (was: Add a config to turn off the hbck chore) > Modify config value range to enable turning off of the hbck chore > - > > Key: HBASE-22803 > URL: https://issues.apache.org/jira/browse/HBASE-22803 > Project: HBase > Issue Type: Sub-task >Reporter: Sakthi >Assignee: Sakthi >Priority: Major > > hbck chore was added in HBASE-22709. To trigger it we can use the shell cmd > added in HBASE-22737. Also by default the chore runs every 1 hour. Let's add > a config to turn it off so that operators can use it and do rolling restart > when they want to stop this chore. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend
[
https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902612#comment-16902612
]
Duo Zhang commented on HBASE-22623:
---
{quote}
Oh sorry. Please pardon the brevity. Not at home right now. The new
RegionObserver hook is needed because the thread context of the WALobserver is
not the right one, we need the hook to have the RPC thread context. The latest
patch lgtm
{quote}
Then I think this method should be placed in RegionObserver, not WALObserver...
> Add RegionObserver coprocessor hook for preWALAppend
>
>
> Key: HBASE-22623
> URL: https://issues.apache.org/jira/browse/HBASE-22623
> Project: HBase
> Issue Type: New Feature
>Reporter: Geoffrey Jacoby
>Assignee: Geoffrey Jacoby
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.3.0
>
>
> While many coprocessor hooks expose the WALEdit to implementing coprocs,
> there aren't any that expose the WALKey before it's created and added to the
> WALEntry.
> It's sometimes useful for coprocessors to be able to edit the WALKey, for
> example to add extended attributes using the fields to be added in
> HBASE-22622.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902611#comment-16902611 ] Andrew Purtell commented on HBASE-22623: I think pre WAL write is in WALObserver but is not called from the right thread context. > Add RegionObserver coprocessor hook for preWALAppend > > > Key: HBASE-22623 > URL: https://issues.apache.org/jira/browse/HBASE-22623 > Project: HBase > Issue Type: New Feature >Reporter: Geoffrey Jacoby >Assignee: Geoffrey Jacoby >Priority: Major > Fix For: 3.0.0, 1.5.0, 2.3.0 > > > While many coprocessor hooks expose the WALEdit to implementing coprocs, > there aren't any that expose the WALKey before it's created and added to the > WALEntry. > It's sometimes useful for coprocessors to be able to edit the WALKey, for > example to add extended attributes using the fields to be added in > HBASE-22622. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22808) HBCK Report showed the offline regions which belong to disabled table
[ https://issues.apache.org/jira/browse/HBASE-22808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902610#comment-16902610 ] Guanghao Zhang commented on HBASE-22808: The unknown servers had same problem, too. [~stack] Please review the pull request. Thanks. > HBCK Report showed the offline regions which belong to disabled table > - > > Key: HBASE-22808 > URL: https://issues.apache.org/jira/browse/HBASE-22808 > Project: HBase > Issue Type: Sub-task >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Major > > For disabled table, the regions were offline and the info:server may be an > unknownserver. The HBCK report should not show these regions in UI. Because > these regions no need to fix. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902608#comment-16902608 ] Geoffrey Jacoby commented on HBASE-22623: - 1. There does not appear to be a preWALWrite in RegionObserver that I can see in master, and I don't see it called in doWALAppend. If I'm missing something, please let me know -- figuring out the hooks and their ordering isn't well-documented. The coprocessor hook needs to be in RegionObserver along with all the other mutation-related coprocessor hooks, because of shared context. 2. For my particular use case, annotating the WALKey as provided in HBASE-22622 is sufficient. [~apurtell] pointed out during the review that other use cases might have need of the edit, and that it would be trivial to add it now rather than need a breaking change later, which I agree with. (3). In the hypothetical, no-longer-relevant case where you added extra Cells to the WALEdit but not the MemStore, you would presumably have the replication endpoint that consumed them filter them out from being replicated to the remote peer cluster. The are Cell-level filtering APIs in the replication code. > Add RegionObserver coprocessor hook for preWALAppend > > > Key: HBASE-22623 > URL: https://issues.apache.org/jira/browse/HBASE-22623 > Project: HBase > Issue Type: New Feature >Reporter: Geoffrey Jacoby >Assignee: Geoffrey Jacoby >Priority: Major > Fix For: 3.0.0, 1.5.0, 2.3.0 > > > While many coprocessor hooks expose the WALEdit to implementing coprocs, > there aren't any that expose the WALKey before it's created and added to the > WALEntry. > It's sometimes useful for coprocessors to be able to edit the WALKey, for > example to add extended attributes using the fields to be added in > HBASE-22622. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] infraio opened a new pull request #465: HBASE-22808 HBCK Report showed the offline regions which belong to di…
infraio opened a new pull request #465: HBASE-22808 HBCK Report showed the offline regions which belong to di… URL: https://github.com/apache/hbase/pull/465 …sabled table This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend
Apache-HBase commented on issue #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend URL: https://github.com/apache/hbase/pull/390#issuecomment-519342804 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 41 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 3 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 363 | master passed | | +1 | compile | 64 | master passed | | +1 | checkstyle | 89 | master passed | | +1 | shadedjars | 294 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 40 | master passed | | 0 | spotbugs | 275 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 272 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 324 | the patch passed | | +1 | compile | 63 | the patch passed | | +1 | javac | 63 | the patch passed | | +1 | checkstyle | 85 | hbase-server: The patch generated 0 new + 376 unchanged - 1 fixed = 376 total (was 377) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 289 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1014 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 40 | the patch passed | | +1 | findbugs | 271 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 10360 | hbase-server in the patch failed. | | +1 | asflicense | 29 | The patch does not generate ASF License warnings. | | | | 14009 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.assignment.TestOpenRegionProcedureHang | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/51/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/390 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 7028724f2470 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-390@2/out/precommit/personality/provided.sh | | git revision | master / 1b168cd6de | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/51/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/51/testReport/ | | Max. process+thread count | 4624 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/51/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902605#comment-16902605 ] Andrew Purtell commented on HBASE-22623: The thread context is not the RPC thread. Without this we have no means to get the right state in place unless Geoffrey has another idea. > Add RegionObserver coprocessor hook for preWALAppend > > > Key: HBASE-22623 > URL: https://issues.apache.org/jira/browse/HBASE-22623 > Project: HBase > Issue Type: New Feature >Reporter: Geoffrey Jacoby >Assignee: Geoffrey Jacoby >Priority: Major > Fix For: 3.0.0, 1.5.0, 2.3.0 > > > While many coprocessor hooks expose the WALEdit to implementing coprocs, > there aren't any that expose the WALKey before it's created and added to the > WALEntry. > It's sometimes useful for coprocessors to be able to edit the WALKey, for > example to add extended attributes using the fields to be added in > HBASE-22622. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902603#comment-16902603 ] Duo Zhang commented on HBASE-22623: --- Can anyone answer my first question? I've asked several times, what is the difference between the old preWALWrite and the new preWALAppend? Your logic can not be implemented using the old preWALWrite? Why? > Add RegionObserver coprocessor hook for preWALAppend > > > Key: HBASE-22623 > URL: https://issues.apache.org/jira/browse/HBASE-22623 > Project: HBase > Issue Type: New Feature >Reporter: Geoffrey Jacoby >Assignee: Geoffrey Jacoby >Priority: Major > Fix For: 3.0.0, 1.5.0, 2.3.0 > > > While many coprocessor hooks expose the WALEdit to implementing coprocs, > there aren't any that expose the WALKey before it's created and added to the > WALEntry. > It's sometimes useful for coprocessors to be able to edit the WALKey, for > example to add extended attributes using the fields to be added in > HBASE-22622. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902602#comment-16902602 ] Andrew Purtell commented on HBASE-22623: Oh sorry. Please pardon the brevity. Not at home right now. The new RegionObserver hook is needed because the thread context of the WALobserver is not the right one, we need the hook to have the RPC thread context. The latest patch lgtm > Add RegionObserver coprocessor hook for preWALAppend > > > Key: HBASE-22623 > URL: https://issues.apache.org/jira/browse/HBASE-22623 > Project: HBase > Issue Type: New Feature >Reporter: Geoffrey Jacoby >Assignee: Geoffrey Jacoby >Priority: Major > Fix For: 3.0.0, 1.5.0, 2.3.0 > > > While many coprocessor hooks expose the WALEdit to implementing coprocs, > there aren't any that expose the WALKey before it's created and added to the > WALEntry. > It's sometimes useful for coprocessors to be able to edit the WALKey, for > example to add extended attributes using the fields to be added in > HBASE-22622. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22806) Recreating a deleted column family brings back the deleted cells
[
https://issues.apache.org/jira/browse/HBASE-22806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902600#comment-16902600
]
Terry Moschou commented on HBASE-22806:
---
{quote}Please try imagine your CF have billions of cells in production env,
it's an unacceptable to tomb every cells just after calling
Admin#deleteColumnFamily.
{quote}
My understanding is CFs are physically different files/directories on HDFS and
therefore a delete column family should be a simple HDFS atomic delete or
move/rename operation; tombing cells, I would think, should not be necessary -
is this not the case with HBase's implementation?
I will note that Google Bigtable [explicitly calls out|
[https://cloud.google.com/bigtable/docs/managing-tables#deleting_column_families]]
data from deleted column families are unrecoverable.
Does this have the potential for data, once protected by a column family scoped
ACL, to no longer be secure?
> Recreating a deleted column family brings back the deleted cells
>
>
> Key: HBASE-22806
> URL: https://issues.apache.org/jira/browse/HBASE-22806
> Project: HBase
> Issue Type: Bug
> Components: API
>Affects Versions: 2.1.3
> Environment: Scala
> HBase Java Client
> Mac/Linux
>Reporter: Chao
>Priority: Major
>
> Steps to reproduce the bug:
> # Create a table with column family CF
> # Add some cells C1, C2 in CF
> # Remove CF using either:
> ** TableDescriptorBuilder.removeColumnFamily() and Admin.modifyTable()
> ** Admin.deleteColumnFamily()
> # Create CF again
> Expected: no cells (all cells marked as deleted) in CF
> Actual: C1, C2 shows up automatically in CF
> Extra information: in step 3, if doing Admin.modifyColumnFamily() without
> actually changing anything, then after step 4 the cells won't come back.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] infraio commented on a change in pull request #464: HBASE-22809 Allow creating table in group when rs group contains no l…
infraio commented on a change in pull request #464: HBASE-22809 Allow creating
table in group when rs group contains no l…
URL: https://github.com/apache/hbase/pull/464#discussion_r311836400
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminEndpoint.java
##
@@ -108,85 +108,119 @@ RSGroupAdminServiceImpl getGroupAdminService() {
@Override
public void
postClearDeadServers(ObserverContext ctx,
- List servers, List notClearedServers) throws
IOException {
+List servers, List notClearedServers) throws
IOException {
Set clearedServer =
-servers.stream().filter(server -> !notClearedServers.contains(server))
-.map(ServerName::getAddress).collect(Collectors.toSet());
+ servers.stream().filter(server -> !notClearedServers.contains(server))
+.map(ServerName::getAddress).collect(Collectors.toSet());
if (!clearedServer.isEmpty()) {
groupAdminServer.removeServers(clearedServer);
}
}
- private void checkGroupExists(Optional optGroupName) throws
IOException {
+ private RSGroupInfo checkGroupExists(Optional optGroupName) throws
IOException {
if (optGroupName.isPresent()) {
String groupName = optGroupName.get();
- if (groupAdminServer.getRSGroupInfo(groupName) == null) {
+ RSGroupInfo group = groupAdminServer.getRSGroupInfo(groupName);
+ if (group == null) {
throw new ConstraintException("Region server group " + groupName + "
does not exit");
}
+ return group;
}
+return null;
}
- private boolean rsgroupHasServersOnline(TableDescriptor desc) throws
IOException {
+ // Do not allow creating new tables which has an empty rs group, expect the
default rs group.
+ // Notice that we do not check for online servers, as this is not stable
because region server can
+ // die at any time.
+ private void checkForEmptyGroup(TableDescriptor desc) throws IOException {
+if (desc.getTableName().isSystemTable()) {
+ // do not check for system tables as we may block the bootstrap.
+ return;
+}
RSGroupInfo rsGroupInfo;
Optional optGroupName = desc.getRegionServerGroup();
if (optGroupName.isPresent()) {
String groupName = optGroupName.get();
if (groupName.equals(RSGroupInfo.DEFAULT_GROUP)) {
// do not check for default group
-return true;
+return;
}
rsGroupInfo = groupAdminServer.getRSGroupInfo(groupName);
if (rsGroupInfo == null) {
throw new ConstraintException(
-"RSGroup " + groupName + " for table " + desc.getTableName() + "
does not exist");
+ "RSGroup " + groupName + " for table " + desc.getTableName() + "
does not exist");
}
} else {
NamespaceDescriptor nd =
-
master.getClusterSchema().getNamespace(desc.getTableName().getNamespaceAsString());
+
master.getClusterSchema().getNamespace(desc.getTableName().getNamespaceAsString());
String groupNameOfNs =
nd.getConfigurationValue(RSGroupInfo.NAMESPACE_DESC_PROP_GROUP);
if (groupNameOfNs == null ||
groupNameOfNs.equals(RSGroupInfo.DEFAULT_GROUP)) {
// do not check for default group
-return true;
+return;
}
rsGroupInfo = groupAdminServer.getRSGroupInfo(groupNameOfNs);
if (rsGroupInfo == null) {
throw new ConstraintException("RSGroup " + groupNameOfNs + " for table
" +
-desc.getTableName() + "(inherit from namespace) does not exist");
+ desc.getTableName() + "(inherit from namespace) does not exist");
}
}
-return master.getServerManager().createDestinationServersList().stream()
-.anyMatch(onlineServer ->
rsGroupInfo.containsServer(onlineServer.getAddress()));
+if (rsGroupInfo.getServers().isEmpty()) {
+ throw new ConstraintException(
+"No servers in the rsgroup " + rsGroupInfo.getName() + " for " + desc);
+}
}
@Override
public void
preCreateTableAction(ObserverContext ctx,
- TableDescriptor desc, RegionInfo[] regions) throws IOException {
+TableDescriptor desc, RegionInfo[] regions) throws IOException {
checkGroupExists(desc.getRegionServerGroup());
-if (!desc.getTableName().isSystemTable() &&
!rsgroupHasServersOnline(desc)) {
- throw new HBaseIOException("No online servers in the rsgroup for " +
desc);
-}
+checkForEmptyGroup(desc);
}
@Override
public TableDescriptor
preModifyTable(ObserverContext ctx,
- TableName tableName, TableDescriptor currentDescriptor, TableDescriptor
newDescriptor)
- throws IOException {
-checkGroupExists(newDescriptor.getRegionServerGroup());
+TableName tableName, TableDescriptor currentDescriptor, TableDescriptor
newDescriptor)
+throws IOException {
+if
(!currentDescriptor.getRegionServerGroup().equals(newDescriptor.getRegionServerGroup()))
{
+ RSGroupInfo group =
[GitHub] [hbase] Apache-HBase commented on issue #439: HBASE-22618 Provide a way to have Heterogeneous deployment
Apache-HBase commented on issue #439: HBASE-22618 Provide a way to have Heterogeneous deployment URL: https://github.com/apache/hbase/pull/439#issuecomment-519340597 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 116 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 362 | master passed | | +1 | compile | 59 | master passed | | +1 | checkstyle | 90 | master passed | | +1 | shadedjars | 299 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 39 | master passed | | 0 | spotbugs | 275 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 273 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 327 | the patch passed | | +1 | compile | 57 | the patch passed | | +1 | javac | 57 | the patch passed | | -1 | checkstyle | 88 | hbase-server: The patch generated 1 new + 64 unchanged - 0 fixed = 65 total (was 64) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 297 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1000 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 33 | the patch passed | | +1 | findbugs | 255 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 9602 | hbase-server in the patch passed. | | +1 | asflicense | 27 | The patch does not generate ASF License warnings. | | | | 13316 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/28/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/439 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 3050eed37989 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 18:22:20 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-439/out/precommit/personality/provided.sh | | git revision | master / 1b168cd6de | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/28/artifact/out/diff-checkstyle-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/28/testReport/ | | Max. process+thread count | 4840 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/28/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #435: HBASE-22767 System table RIT STUCK if their RSGroup has no highest ve…
Apache-HBase commented on issue #435: HBASE-22767 System table RIT STUCK if their RSGroup has no highest ve… URL: https://github.com/apache/hbase/pull/435#issuecomment-519340379 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 39 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | 0 | shelldocs | 0 | Shelldocs was not available. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 39 | Maven dependency ordering for branch | | +1 | mvninstall | 315 | master passed | | +1 | compile | 101 | master passed | | +1 | checkstyle | 113 | master passed | | +1 | shadedjars | 273 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 78 | master passed | | 0 | spotbugs | 237 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 328 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 18 | Maven dependency ordering for patch | | +1 | mvninstall | 302 | the patch passed | | +1 | compile | 99 | the patch passed | | +1 | javac | 99 | the patch passed | | -1 | checkstyle | 75 | hbase-server: The patch generated 1 new + 9 unchanged - 0 fixed = 10 total (was 9) | | +1 | shellcheck | 0 | There were no new shellcheck issues. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 271 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 925 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 72 | the patch passed | | -1 | findbugs | 56 | hbase-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | +1 | unit | 177 | hbase-common in the patch passed. | | -1 | unit | 8796 | hbase-server in the patch failed. | | +1 | unit | 351 | hbase-rsgroup in the patch passed. | | +1 | asflicense | 67 | The patch does not generate ASF License warnings. | | | | 13249 | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-common | | | org.apache.hadoop.hbase.Version.() invokes inefficient new String(String) constructor At Version.java:inefficient new String(String) constructor At Version.java:[line 10] | | Failed junit tests | hadoop.hbase.client.TestAsyncTable | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/26/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/435 | | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux ece922526f56 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-435/out/precommit/personality/provided.sh | | git revision | master / 1b168cd6de | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/26/artifact/out/diff-checkstyle-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/26/artifact/out/new-findbugs-hbase-common.html | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/26/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/26/testReport/ | | Max. process+thread count | 4772 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server hbase-rsgroup U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/26/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] infraio commented on a change in pull request #464: HBASE-22809 Allow creating table in group when rs group contains no l…
infraio commented on a change in pull request #464: HBASE-22809 Allow creating
table in group when rs group contains no l…
URL: https://github.com/apache/hbase/pull/464#discussion_r311835695
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminEndpoint.java
##
@@ -108,85 +108,119 @@ RSGroupAdminServiceImpl getGroupAdminService() {
@Override
public void
postClearDeadServers(ObserverContext ctx,
- List servers, List notClearedServers) throws
IOException {
+List servers, List notClearedServers) throws
IOException {
Set clearedServer =
-servers.stream().filter(server -> !notClearedServers.contains(server))
-.map(ServerName::getAddress).collect(Collectors.toSet());
+ servers.stream().filter(server -> !notClearedServers.contains(server))
+.map(ServerName::getAddress).collect(Collectors.toSet());
if (!clearedServer.isEmpty()) {
groupAdminServer.removeServers(clearedServer);
}
}
- private void checkGroupExists(Optional optGroupName) throws
IOException {
+ private RSGroupInfo checkGroupExists(Optional optGroupName) throws
IOException {
if (optGroupName.isPresent()) {
String groupName = optGroupName.get();
- if (groupAdminServer.getRSGroupInfo(groupName) == null) {
+ RSGroupInfo group = groupAdminServer.getRSGroupInfo(groupName);
+ if (group == null) {
throw new ConstraintException("Region server group " + groupName + "
does not exit");
}
+ return group;
}
+return null;
}
- private boolean rsgroupHasServersOnline(TableDescriptor desc) throws
IOException {
+ // Do not allow creating new tables which has an empty rs group, expect the
default rs group.
+ // Notice that we do not check for online servers, as this is not stable
because region server can
+ // die at any time.
+ private void checkForEmptyGroup(TableDescriptor desc) throws IOException {
+if (desc.getTableName().isSystemTable()) {
+ // do not check for system tables as we may block the bootstrap.
+ return;
+}
RSGroupInfo rsGroupInfo;
Optional optGroupName = desc.getRegionServerGroup();
if (optGroupName.isPresent()) {
String groupName = optGroupName.get();
if (groupName.equals(RSGroupInfo.DEFAULT_GROUP)) {
// do not check for default group
-return true;
+return;
}
rsGroupInfo = groupAdminServer.getRSGroupInfo(groupName);
if (rsGroupInfo == null) {
throw new ConstraintException(
-"RSGroup " + groupName + " for table " + desc.getTableName() + "
does not exist");
+ "RSGroup " + groupName + " for table " + desc.getTableName() + "
does not exist");
}
} else {
NamespaceDescriptor nd =
-
master.getClusterSchema().getNamespace(desc.getTableName().getNamespaceAsString());
+
master.getClusterSchema().getNamespace(desc.getTableName().getNamespaceAsString());
String groupNameOfNs =
nd.getConfigurationValue(RSGroupInfo.NAMESPACE_DESC_PROP_GROUP);
if (groupNameOfNs == null ||
groupNameOfNs.equals(RSGroupInfo.DEFAULT_GROUP)) {
// do not check for default group
-return true;
+return;
}
rsGroupInfo = groupAdminServer.getRSGroupInfo(groupNameOfNs);
if (rsGroupInfo == null) {
throw new ConstraintException("RSGroup " + groupNameOfNs + " for table
" +
-desc.getTableName() + "(inherit from namespace) does not exist");
+ desc.getTableName() + "(inherit from namespace) does not exist");
}
}
-return master.getServerManager().createDestinationServersList().stream()
-.anyMatch(onlineServer ->
rsGroupInfo.containsServer(onlineServer.getAddress()));
+if (rsGroupInfo.getServers().isEmpty()) {
+ throw new ConstraintException(
+"No servers in the rsgroup " + rsGroupInfo.getName() + " for " + desc);
+}
}
@Override
public void
preCreateTableAction(ObserverContext ctx,
- TableDescriptor desc, RegionInfo[] regions) throws IOException {
+TableDescriptor desc, RegionInfo[] regions) throws IOException {
checkGroupExists(desc.getRegionServerGroup());
-if (!desc.getTableName().isSystemTable() &&
!rsgroupHasServersOnline(desc)) {
- throw new HBaseIOException("No online servers in the rsgroup for " +
desc);
-}
+checkForEmptyGroup(desc);
}
@Override
public TableDescriptor
preModifyTable(ObserverContext ctx,
- TableName tableName, TableDescriptor currentDescriptor, TableDescriptor
newDescriptor)
- throws IOException {
-checkGroupExists(newDescriptor.getRegionServerGroup());
+TableName tableName, TableDescriptor currentDescriptor, TableDescriptor
newDescriptor)
+throws IOException {
+if
(!currentDescriptor.getRegionServerGroup().equals(newDescriptor.getRegionServerGroup()))
{
+ RSGroupInfo group =
[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902598#comment-16902598 ] Andrew Purtell commented on HBASE-22623: It is about the WALkey for earlier described reasons. I have also explained my position about why also including a parameter for WALedit in multiple earlier comments and don’t need to repeat it again. The latest patch seems to strike the right balance by avoiding concerns about WALedit as you rightly point out is not needed now anyway so is a bit theoretical. > Add RegionObserver coprocessor hook for preWALAppend > > > Key: HBASE-22623 > URL: https://issues.apache.org/jira/browse/HBASE-22623 > Project: HBase > Issue Type: New Feature >Reporter: Geoffrey Jacoby >Assignee: Geoffrey Jacoby >Priority: Major > Fix For: 3.0.0, 1.5.0, 2.3.0 > > > While many coprocessor hooks expose the WALEdit to implementing coprocs, > there aren't any that expose the WALKey before it's created and added to the > WALEntry. > It's sometimes useful for coprocessors to be able to edit the WALKey, for > example to add extended attributes using the fields to be added in > HBASE-22622. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend
Apache-HBase commented on issue #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend URL: https://github.com/apache/hbase/pull/390#issuecomment-519338580 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 38 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 3 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 334 | master passed | | +1 | compile | 54 | master passed | | +1 | checkstyle | 79 | master passed | | +1 | shadedjars | 275 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 37 | master passed | | 0 | spotbugs | 259 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 257 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 330 | the patch passed | | +1 | compile | 60 | the patch passed | | +1 | javac | 60 | the patch passed | | +1 | checkstyle | 84 | hbase-server: The patch generated 0 new + 376 unchanged - 1 fixed = 376 total (was 377) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 294 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1060 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 39 | the patch passed | | +1 | findbugs | 285 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 10174 | hbase-server in the patch failed. | | +1 | asflicense | 33 | The patch does not generate ASF License warnings. | | | | 13839 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.replication.TestTransitPeerSyncReplicationStateProcedureRetry | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/50/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/390 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux a598d542e648 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-390/out/precommit/personality/provided.sh | | git revision | master / 49839e4075 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/50/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/50/testReport/ | | Max. process+thread count | 4830 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/50/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #446: HBASE-22781 optimize the test case TestStoreScanner.testScanSameTimes…
Apache-HBase commented on issue #446: HBASE-22781 optimize the test case TestStoreScanner.testScanSameTimes… URL: https://github.com/apache/hbase/pull/446#issuecomment-519336914 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 76 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 329 | master passed | | +1 | compile | 52 | master passed | | +1 | checkstyle | 74 | master passed | | +1 | shadedjars | 276 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 37 | master passed | | 0 | spotbugs | 243 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 241 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 297 | the patch passed | | +1 | compile | 55 | the patch passed | | +1 | javac | 55 | the patch passed | | +1 | checkstyle | 75 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 272 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 937 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 34 | the patch passed | | +1 | findbugs | 261 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 8738 | hbase-server in the patch passed. | | +1 | asflicense | 25 | The patch does not generate ASF License warnings. | | | | 12156 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/24/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/446 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux d36513e6bbcc 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-446/out/precommit/personality/provided.sh | | git revision | master / 1b168cd6de | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/24/testReport/ | | Max. process+thread count | 4949 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/24/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22815) mvn build throws a repeated "pattern never triggered..."
[
https://issues.apache.org/jira/browse/HBASE-22815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902593#comment-16902593
]
Sean Busbey commented on HBASE-22815:
-
IIRC it's because different patterns were needed for different versions of
Hadoop.
Since our set of permissable Hadoop versions have changed maybe some of them
are no longer needed.
> mvn build throws a repeated "pattern never triggered..."
> -
>
> Key: HBASE-22815
> URL: https://issues.apache.org/jira/browse/HBASE-22815
> Project: HBase
> Issue Type: Bug
>Reporter: Sakthi
>Priority: Minor
>
> {code:java}
> $mvn clean package assembly:single install -DskipTests
> ...
> ...
> [INFO] --- maven-assembly-plugin:3.0.0:single (default-cli) @ hbase-assembly
> ---
> [INFO] Reading assembly descriptor: src/main/assembly/hadoop-two-compat.xml
> [INFO] Reading assembly descriptor: src/main/assembly/client.xml
> [WARNING] The following patterns were never triggered in this artifact
> exclusion filter:
> o 'org.apache.htrace:htrace-core'
> [WARNING] The following patterns were never triggered in this artifact
> exclusion filter:
> o 'org.apache.htrace:htrace-core'
> [WARNING] The following patterns were never triggered in this artifact
> exclusion filter:
> o 'org.apache.htrace:htrace-core'
> [WARNING] The following patterns were never triggered in this artifact
> exclusion filter:
> o 'org.apache.htrace:htrace-core'
> [WARNING] The following patterns were never triggered in this artifact
> exclusion filter:
> o 'org.apache.htrace:htrace-core'
> [WARNING] The following patterns were never triggered in this artifact
> exclusion filter:
> o 'org.apache.htrace:htrace-core'
> [WARNING] The following patterns were never triggered in this artifact
> exclusion filter:
> o 'org.apache.htrace:htrace-core'
> ...{code}
> Looks pretty ugly.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902590#comment-16902590 ] Duo Zhang commented on HBASE-22623: --- Two problems: 1. Why not just use the old preWALWrite method? Althrough it is marked as deprecated, we will not remove it unless we find an alternate method which can do almost the same thing. The new preWALAppend is almost the same with preWALWrite, just with a different method name. 2. I thought you guys just want to add some attributes to WALKey, although I still have some concerns but at least, I do not think adding extended atrributes will break critical assumptions. Then why here we changed the topic to amending the WALEdit? What is the usage? IIRC, in another issue, Stack and I suggest that you could use META_FAMILY without adding new attributes to WALKey but you guys refused? Then what's going on here? I'm a bit confused. And what's more, adding cells to WALEdit but no memstore is a no no. After replication, the data will be replicated to peer cluster, with the cells not in memstore but in WALEdit, and also, when replaying, you will see the cells in WALEdit but not in memstore. That means, you have to intercept the put/delete operations, both in the normal write path and the fail recovery path, then why not put all the logic there, instead of implementing a sperated logic at the WAL layer? This does not make sense... > Add RegionObserver coprocessor hook for preWALAppend > > > Key: HBASE-22623 > URL: https://issues.apache.org/jira/browse/HBASE-22623 > Project: HBase > Issue Type: New Feature >Reporter: Geoffrey Jacoby >Assignee: Geoffrey Jacoby >Priority: Major > Fix For: 3.0.0, 1.5.0, 2.3.0 > > > While many coprocessor hooks expose the WALEdit to implementing coprocs, > there aren't any that expose the WALKey before it's created and added to the > WALEntry. > It's sometimes useful for coprocessors to be able to edit the WALKey, for > example to add extended attributes using the fields to be added in > HBASE-22622. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22759) Add user info to AUDITLOG events when doing grant/revoke
[
https://issues.apache.org/jira/browse/HBASE-22759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902586#comment-16902586
]
Hudson commented on HBASE-22759:
Results for branch master
[build #1317 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1317/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1317//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1317//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1317//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Add user info to AUDITLOG events when doing grant/revoke
>
>
> Key: HBASE-22759
> URL: https://issues.apache.org/jira/browse/HBASE-22759
> Project: HBase
> Issue Type: Improvement
> Components: logging, security
>Affects Versions: 3.0.0, 2.2.0, 2.1.5
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6
>
>
> On *branch-2.1* the AUDITLOG events is raised like this:
> {noformat}
> AUDITLOG.trace("Granted permission " + perm.toString());{noformat}
> I'd like to extend this line with "caller" user info like this:
> {noformat}
> AUDITLOG.trace("User {} granted permission {}", caller,
> perm.toString());{noformat}
> Similar change is proposed for Revoke event.
> On branch-2.2+ grant() and revoke() methods in AccessController have been
> deprecated and logic was moved to {{MasterRpcServices}}, but that class
> doesn't do any audit logging. I'm not sure about why audit logging has been
> removed and about any replacement in the refactored logic, but Audit logging
> is a crucial security tool in our environment to track change events on ACLs.
> I'm planning to add AUDITLOG to {{MasterRpcServices}} to bring back this
> functionality, but please FIXME and point me in the right direction if needed.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22812) InterfaceAudience annotation in CatalogJanitor uses fully-qualified name
[
https://issues.apache.org/jira/browse/HBASE-22812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902588#comment-16902588
]
Hudson commented on HBASE-22812:
Results for branch master
[build #1317 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1317/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1317//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1317//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1317//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> InterfaceAudience annotation in CatalogJanitor uses fully-qualified name
>
>
> Key: HBASE-22812
> URL: https://issues.apache.org/jira/browse/HBASE-22812
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>Reporter: Peter Somogyi
>Assignee: Murtaza Hassan
>Priority: Minor
> Labels: beginner
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
>
> CatalogJanitor class's InterfaceAudience annotation uses the fully-qualified
> name instead of just @InterfaceAudience.Private.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22417) DeleteTableProcedure.deleteFromMeta method should remove table from Master's table descriptors cache
[
https://issues.apache.org/jira/browse/HBASE-22417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902587#comment-16902587
]
Hudson commented on HBASE-22417:
Results for branch master
[build #1317 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1317/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1317//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1317//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1317//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> DeleteTableProcedure.deleteFromMeta method should remove table from Master's
> table descriptors cache
>
>
> Key: HBASE-22417
> URL: https://issues.apache.org/jira/browse/HBASE-22417
> Project: HBase
> Issue Type: Bug
>Affects Versions: 3.0.0, 2.2.0, 2.1.5
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Major
> Fix For: 3.0.0, 2.2.1, 2.1.6
>
> Attachments: HBASE-22417.master.001.patch,
> HBASE-22417.master.002.patch, HBASE-22417.master.003.patch,
> HBASE-22417.master.004.patch, HBASE-22417.master.005.patch
>
>
> DeleteTableProcedure defines a static deleteFromMeta method that's currently
> used both by DeleteTableProcedure itself and TruncateTableProcedure.
> Sometimes, depending on the table size (and under slower, under performing
> FileSystems), truncation can take longer to complete
> *TRUNCATE_TABLE_CLEAR_FS_LAYOUT* stage, but the given table has already been
> deleted from meta on previous *TRUNCATE_TABLE_REMOVE_FROM_META* stage. In
> this case, features relying on Master's table descriptor's cache might
> wrongly try to reference this truncating table. Master Web UI, for example,
> would try to check this table state and end up showing a 500 error.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator
Apache-HBase commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator URL: https://github.com/apache/hbase/pull/343#issuecomment-519333847 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 118 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-2.1 Compile Tests _ | | +1 | mvninstall | 371 | branch-2.1 passed | | +1 | compile | 24 | branch-2.1 passed | | +1 | checkstyle | 39 | branch-2.1 passed | | +1 | shadedjars | 276 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 26 | branch-2.1 passed | | 0 | spotbugs | 79 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 77 | branch-2.1 passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 320 | the patch passed | | +1 | compile | 26 | the patch passed | | +1 | javac | 26 | the patch passed | | +1 | checkstyle | 39 | hbase-client: The patch generated 0 new + 58 unchanged - 4 fixed = 58 total (was 62) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 264 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1388 | Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2. | | +1 | javadoc | 26 | the patch passed | | +1 | findbugs | 85 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 206 | hbase-client in the patch passed. | | +1 | asflicense | 11 | The patch does not generate ASF License warnings. | | | | 3715 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/50/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/343 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux ad1443169a5a 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 18:22:20 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-343/out/precommit/personality/provided.sh | | git revision | branch-2.1 / 5cec62f0f9 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/50/testReport/ | | Max. process+thread count | 257 (vs. ulimit of 1) | | modules | C: hbase-client U: hbase-client | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/50/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-22815) mvn build throws a repeated "pattern never triggered..."
[
https://issues.apache.org/jira/browse/HBASE-22815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sakthi updated HBASE-22815:
---
Issue Type: Bug (was: Task)
> mvn build throws a repeated "pattern never triggered..."
> -
>
> Key: HBASE-22815
> URL: https://issues.apache.org/jira/browse/HBASE-22815
> Project: HBase
> Issue Type: Bug
>Reporter: Sakthi
>Priority: Minor
>
> {code:java}
> $mvn clean package assembly:single install -DskipTests
> ...
> ...
> [INFO] --- maven-assembly-plugin:3.0.0:single (default-cli) @ hbase-assembly
> ---
> [INFO] Reading assembly descriptor: src/main/assembly/hadoop-two-compat.xml
> [INFO] Reading assembly descriptor: src/main/assembly/client.xml
> [WARNING] The following patterns were never triggered in this artifact
> exclusion filter:
> o 'org.apache.htrace:htrace-core'
> [WARNING] The following patterns were never triggered in this artifact
> exclusion filter:
> o 'org.apache.htrace:htrace-core'
> [WARNING] The following patterns were never triggered in this artifact
> exclusion filter:
> o 'org.apache.htrace:htrace-core'
> [WARNING] The following patterns were never triggered in this artifact
> exclusion filter:
> o 'org.apache.htrace:htrace-core'
> [WARNING] The following patterns were never triggered in this artifact
> exclusion filter:
> o 'org.apache.htrace:htrace-core'
> [WARNING] The following patterns were never triggered in this artifact
> exclusion filter:
> o 'org.apache.htrace:htrace-core'
> [WARNING] The following patterns were never triggered in this artifact
> exclusion filter:
> o 'org.apache.htrace:htrace-core'
> ...{code}
> Looks pretty ugly.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (HBASE-22815) mvn build throws a repeated "pattern never triggered..."
[
https://issues.apache.org/jira/browse/HBASE-22815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sakthi updated HBASE-22815:
---
Description:
{code:java}
$mvn clean package assembly:single install -DskipTests
...
...
[INFO] --- maven-assembly-plugin:3.0.0:single (default-cli) @ hbase-assembly ---
[INFO] Reading assembly descriptor: src/main/assembly/hadoop-two-compat.xml
[INFO] Reading assembly descriptor: src/main/assembly/client.xml
[WARNING] The following patterns were never triggered in this artifact
exclusion filter:
o 'org.apache.htrace:htrace-core'
[WARNING] The following patterns were never triggered in this artifact
exclusion filter:
o 'org.apache.htrace:htrace-core'
[WARNING] The following patterns were never triggered in this artifact
exclusion filter:
o 'org.apache.htrace:htrace-core'
[WARNING] The following patterns were never triggered in this artifact
exclusion filter:
o 'org.apache.htrace:htrace-core'
[WARNING] The following patterns were never triggered in this artifact
exclusion filter:
o 'org.apache.htrace:htrace-core'
[WARNING] The following patterns were never triggered in this artifact
exclusion filter:
o 'org.apache.htrace:htrace-core'
[WARNING] The following patterns were never triggered in this artifact
exclusion filter:
o 'org.apache.htrace:htrace-core'
...{code}
Looks pretty ugly.
was:
{code:java}
$mvn clean package assembly:single install -DskipTests
...
...
[INFO] --- maven-assembly-plugin:3.0.0:single (default-cli) @ hbase-assembly ---
[INFO] Reading assembly descriptor: src/main/assembly/hadoop-two-compat.xml
[INFO] Reading assembly descriptor: src/main/assembly/client.xml
[WARNING] The following patterns were never triggered in this artifact
exclusion filter:
o 'org.apache.htrace:htrace-core'
[WARNING] The following patterns were never triggered in this artifact
exclusion filter:
o 'org.apache.htrace:htrace-core'
[WARNING] The following patterns were never triggered in this artifact
exclusion filter:
o 'org.apache.htrace:htrace-core'
[WARNING] The following patterns were never triggered in this artifact
exclusion filter:
o 'org.apache.htrace:htrace-core'
[WARNING] The following patterns were never triggered in this artifact
exclusion filter:
o 'org.apache.htrace:htrace-core'
[WARNING] The following patterns were never triggered in this artifact
exclusion filter:
o 'org.apache.htrace:htrace-core'
[WARNING] The following patterns were never triggered in this artifact
exclusion filter:
o 'org.apache.htrace:htrace-core'
...{code}
> mvn build throws a repeated "pattern never triggered..."
> -
>
> Key: HBASE-22815
> URL: https://issues.apache.org/jira/browse/HBASE-22815
> Project: HBase
> Issue Type: Task
>Reporter: Sakthi
>Priority: Minor
>
> {code:java}
> $mvn clean package assembly:single install -DskipTests
> ...
> ...
> [INFO] --- maven-assembly-plugin:3.0.0:single (default-cli) @ hbase-assembly
> ---
> [INFO] Reading assembly descriptor: src/main/assembly/hadoop-two-compat.xml
> [INFO] Reading assembly descriptor: src/main/assembly/client.xml
> [WARNING] The following patterns were never triggered in this artifact
> exclusion filter:
> o 'org.apache.htrace:htrace-core'
> [WARNING] The following patterns were never triggered in this artifact
> exclusion filter:
> o 'org.apache.htrace:htrace-core'
> [WARNING] The following patterns were never triggered in this artifact
> exclusion filter:
> o 'org.apache.htrace:htrace-core'
> [WARNING] The following patterns were never triggered in this artifact
> exclusion filter:
> o 'org.apache.htrace:htrace-core'
> [WARNING] The following patterns were never triggered in this artifact
> exclusion filter:
> o 'org.apache.htrace:htrace-core'
> [WARNING] The following patterns were never triggered in this artifact
> exclusion filter:
> o 'org.apache.htrace:htrace-core'
> [WARNING] The following patterns were never triggered in this artifact
> exclusion filter:
> o 'org.apache.htrace:htrace-core'
> ...{code}
> Looks pretty ugly.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Created] (HBASE-22815) mvn build throws a repeated "pattern never triggered..."
Sakthi created HBASE-22815:
--
Summary: mvn build throws a repeated "pattern never triggered..."
Key: HBASE-22815
URL: https://issues.apache.org/jira/browse/HBASE-22815
Project: HBase
Issue Type: Task
Reporter: Sakthi
{code:java}
$mvn clean package assembly:single install -DskipTests
...
...
[INFO] --- maven-assembly-plugin:3.0.0:single (default-cli) @ hbase-assembly ---
[INFO] Reading assembly descriptor: src/main/assembly/hadoop-two-compat.xml
[INFO] Reading assembly descriptor: src/main/assembly/client.xml
[WARNING] The following patterns were never triggered in this artifact
exclusion filter:
o 'org.apache.htrace:htrace-core'
[WARNING] The following patterns were never triggered in this artifact
exclusion filter:
o 'org.apache.htrace:htrace-core'
[WARNING] The following patterns were never triggered in this artifact
exclusion filter:
o 'org.apache.htrace:htrace-core'
[WARNING] The following patterns were never triggered in this artifact
exclusion filter:
o 'org.apache.htrace:htrace-core'
[WARNING] The following patterns were never triggered in this artifact
exclusion filter:
o 'org.apache.htrace:htrace-core'
[WARNING] The following patterns were never triggered in this artifact
exclusion filter:
o 'org.apache.htrace:htrace-core'
[WARNING] The following patterns were never triggered in this artifact
exclusion filter:
o 'org.apache.htrace:htrace-core'
...{code}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent
Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent URL: https://github.com/apache/hbase/pull/387#issuecomment-51932 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 115 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 397 | master passed | | +1 | compile | 26 | master passed | | +1 | checkstyle | 15 | master passed | | +1 | shadedjars | 306 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 23 | master passed | | 0 | spotbugs | 53 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 51 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 336 | the patch passed | | +1 | compile | 26 | the patch passed | | +1 | javac | 26 | the patch passed | | +1 | checkstyle | 12 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 314 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1082 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 21 | the patch passed | | +1 | findbugs | 60 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 758 | hbase-rsgroup in the patch passed. | | +1 | asflicense | 16 | The patch does not generate ASF License warnings. | | | | 3995 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/71/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/387 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux b9c8c6e4e9aa 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-387/out/precommit/personality/provided.sh | | git revision | master / 547cec4078 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/71/testReport/ | | Max. process+thread count | 4374 (vs. ulimit of 1) | | modules | C: hbase-rsgroup U: hbase-rsgroup | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/71/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22775) Enhance logging for peer related operations
[
https://issues.apache.org/jira/browse/HBASE-22775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902579#comment-16902579
]
HBase QA commented on HBASE-22775:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 4m
55s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
31s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
13s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
29s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
25s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
15s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
14s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
10s{color} | {color:red} hbase-replication: The patch generated 2 new + 0
unchanged - 0 fixed = 2 total (was 0) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
24s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
15m 16s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
12s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
59s{color} | {color:green} hbase-replication in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
10s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 48m 29s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base:
https://builds.apache.org/job/PreCommit-HBASE-Build/730/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22775 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12976970/HBASE-22775.master.001.patch
|
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux c061bc404f5f 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 547cec4078 |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.11 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HBASE-Build/730/artifact/patchprocess/diff-checkstyle-hbase-replication.txt
|
| Test Results |
[GitHub] [hbase] Apache9 commented on issue #436: HBASE-22699 refactor isMetaClearingException
Apache9 commented on issue #436: HBASE-22699 refactor isMetaClearingException URL: https://github.com/apache/hbase/pull/436#issuecomment-519324421 Ping @johnhomsea . Please address the latest review comments? I think we are almost there. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #436: HBASE-22699 refactor isMetaClearingException
Apache-HBase commented on issue #436: HBASE-22699 refactor isMetaClearingException URL: https://github.com/apache/hbase/pull/436#issuecomment-519323392 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 70 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 326 | master passed | | +1 | compile | 25 | master passed | | +1 | checkstyle | 29 | master passed | | +1 | shadedjars | 271 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 23 | master passed | | 0 | spotbugs | 70 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 68 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 298 | the patch passed | | +1 | compile | 24 | the patch passed | | +1 | javac | 24 | the patch passed | | +1 | checkstyle | 29 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 271 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 936 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 21 | the patch passed | | +1 | findbugs | 75 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 109 | hbase-client in the patch passed. | | +1 | asflicense | 11 | The patch does not generate ASF License warnings. | | | | 2966 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/30/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/436 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 1587196345f9 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-436/out/precommit/personality/provided.sh | | git revision | master / 547cec4078 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/30/testReport/ | | Max. process+thread count | 274 (vs. ulimit of 1) | | modules | C: hbase-client U: hbase-client | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/30/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-17932) add manageable call queue
[ https://issues.apache.org/jira/browse/HBASE-17932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-17932: --- Fix Version/s: (was: 1.1.2) > add manageable call queue > - > > Key: HBASE-17932 > URL: https://issues.apache.org/jira/browse/HBASE-17932 > Project: HBase > Issue Type: Improvement > Components: IPC/RPC >Reporter: xinxin fan >Priority: Major > Attachments: ManageableCallQueue.pdf > > > The Manageable Call Queue aims to provide a unified way to build: > 1.Administor can create queue with specified number handler using shell > command > 2.Administor can increase/decrease the handler number for the specified > queue using shell command > 3.Administor can assign the same type request load to one queue, for > example, administor can assign all the large object write requests to one > queue, while assign all the small object write requests to another queue. > the feature allow you to change the ipc queues/handlers at runtime and is a > improvements for running multiple workloads on a single hbase cluster in some > cases. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Resolved] (HBASE-22807) HBCK Report showed wrong orphans regions on FileSystem
[ https://issues.apache.org/jira/browse/HBASE-22807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang resolved HBASE-22807. Resolution: Fixed Fix Version/s: 2.1.6 2.2.1 2.0.6 2.3.0 3.0.0 Pushed to branch-2.0+. Thanks [~jatsakthi] for reviewing. > HBCK Report showed wrong orphans regions on FileSystem > -- > > Key: HBASE-22807 > URL: https://issues.apache.org/jira/browse/HBASE-22807 > Project: HBase > Issue Type: Sub-task >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6 > > > It showed .tabledesc and .tmp as orphans regions. Need to use > FSUtils.getRegionDirs(fs, tableDir) instead of > fs.listStatus(tableDir.getPath()). -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22775) Enhance logging for peer related operations
[ https://issues.apache.org/jira/browse/HBASE-22775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xu Cang updated HBASE-22775: Attachment: HBASE-22775.master.001.patch Status: Patch Available (was: Open) > Enhance logging for peer related operations > --- > > Key: HBASE-22775 > URL: https://issues.apache.org/jira/browse/HBASE-22775 > Project: HBase > Issue Type: Improvement >Reporter: Xu Cang >Assignee: Xu Cang >Priority: Minor > Attachments: HBASE-22775.master.001.patch > > > Now we don't have good logging regarding peer operations, for example addPeer > does not log itself: > [https://github.com/apache/hbase/blob/master/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ZKReplicationPeerStorage.java#L102] > This Jira is aiming to enhancing this area -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] infraio merged pull request #461: HBASE-22807 HBCK Report showed wrong orphans regions on FileSystem
infraio merged pull request #461: HBASE-22807 HBCK Report showed wrong orphans regions on FileSystem URL: https://github.com/apache/hbase/pull/461 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-22807) HBCK Report showed wrong orphans regions on FileSystem
[ https://issues.apache.org/jira/browse/HBASE-22807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-22807: --- Description: It showed .tabledesc and .tmp as orphans regions. Need to use FSUtils.getRegionDirs(fs, tableDir) instead of fs.listStatus(tableDir.getPath()). > HBCK Report showed wrong orphans regions on FileSystem > -- > > Key: HBASE-22807 > URL: https://issues.apache.org/jira/browse/HBASE-22807 > Project: HBase > Issue Type: Sub-task >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Major > > It showed .tabledesc and .tmp as orphans regions. Need to use > FSUtils.getRegionDirs(fs, tableDir) instead of > fs.listStatus(tableDir.getPath()). -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] infraio commented on a change in pull request #461: HBASE-22807 HBCK Report showed wrong orphans regions on FileSystem
infraio commented on a change in pull request #461: HBASE-22807 HBCK Report
showed wrong orphans regions on FileSystem
URL: https://github.com/apache/hbase/pull/461#discussion_r311810719
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HbckChore.java
##
@@ -191,27 +194,24 @@ private void loadRegionsFromFS() throws IOException {
Path rootDir = master.getMasterFileSystem().getRootDir();
FileSystem fs = master.getMasterFileSystem().getFileSystem();
-// list all tables from HDFS
-List tableDirs = Lists.newArrayList();
-List paths = FSUtils.getTableDirs(fs, rootDir);
-for (Path path : paths) {
- tableDirs.add(fs.getFileStatus(path));
-}
-
-for (FileStatus tableDir : tableDirs) {
- FileStatus[] regionDirs = fs.listStatus(tableDir.getPath());
- for (FileStatus regionDir : regionDirs) {
-String encodedRegionName = regionDir.getPath().getName();
+int numRegions = 0;
+List tableDirs = FSUtils.getTableDirs(fs, rootDir);
+for (Path tableDir : tableDirs) {
+ List regionDirs = FSUtils.getRegionDirs(fs, tableDir);
+ for (Path regionDir : regionDirs) {
+String encodedRegionName = regionDir.getName();
HbckRegionInfo hri = regionInfoMap.get(encodedRegionName);
if (hri == null) {
orphanRegionsOnFS.add(encodedRegionName);
continue;
}
-HbckRegionInfo.HdfsEntry hdfsEntry =
Review comment:
Let me try it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] infraio commented on issue #461: HBASE-22807 HBCK Report showed wrong orphans regions on FileSystem
infraio commented on issue #461: HBASE-22807 HBCK Report showed wrong orphans regions on FileSystem URL: https://github.com/apache/hbase/pull/461#issuecomment-519312100 > Okay the fs.listStatus(tableDir.getPath()) lists ._tmp & .tabledesc_. Have verified that the added UT fails without the fix. A small nit. Yes. Thanks for the verify. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary
[ https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caroline updated HBASE-22804: - Attachment: HBASE-22804.master.000.patch HBASE-22804.branch-2.000.patch HBASE-22804.branch-1.000.patch > Provide an API to get list of successful regions and total expected regions > in Canary > - > > Key: HBASE-22804 > URL: https://issues.apache.org/jira/browse/HBASE-22804 > Project: HBase > Issue Type: Improvement > Components: canary >Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1 >Reporter: Caroline >Assignee: Caroline >Priority: Minor > Labels: Canary > Attachments: HBASE-22804.branch-1.000.patch, > HBASE-22804.branch-2.000.patch, HBASE-22804.master.000.patch > > > At present HBase Canary tool only prints the successes as part of logs. > Providing an API to get the list of successes, as well as total number of > expected regions, will make it easier to get a more accurate availability > estimate. > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #438: HBASE-11062 hbtop
Apache-HBase commented on issue #438: HBASE-11062 hbtop URL: https://github.com/apache/hbase/pull/438#issuecomment-519310922 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 143 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | 0 | shelldocs | 1 | Shelldocs was not available. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 19 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 42 | Maven dependency ordering for branch | | +1 | mvninstall | 470 | master passed | | +1 | compile | 242 | master passed | | +1 | checkstyle | 201 | master passed | | +1 | shadedjars | 359 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 238 | master passed | | 0 | spotbugs | 34 | Used deprecated FindBugs config; considering switching to SpotBugs. | | 0 | findbugs | 34 | branch/hbase-assembly no findbugs output file (findbugsXml.xml) | ||| _ Patch Compile Tests _ | | 0 | mvndep | 17 | Maven dependency ordering for patch | | +1 | mvninstall | 451 | the patch passed | | -1 | compile | 223 | root in the patch failed. | | -1 | javac | 223 | root in the patch failed. | | +1 | checkstyle | 186 | the patch passed | | +1 | shellcheck | 2 | There were no new shellcheck issues. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | xml | 5 | The patch has no ill-formed XML file. | | +1 | shadedjars | 359 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1336 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 250 | the patch passed | | -1 | findbugs | 893 | root in the patch failed. | | 0 | findbugs | 29 | hbase-assembly has no data from findbugs | ||| _ Other Tests _ | | -1 | unit | 15543 | root in the patch failed. | | -1 | asflicense | 98 | The patch generated 2 ASF License warnings. | | | | 22828 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestSnapshotTemporaryDirectory | | | hadoop.hbase.master.assignment.TestSplitTableRegionProcedure | | | hadoop.hbase.master.assignment.TestMergeTableRegionsProcedure | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/25/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/438 | | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc unit shadedjars hadoopcheck xml compile spotbugs findbugs hbaseanti checkstyle | | uname | Linux 4a6c6e01f586 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 18:22:20 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-438/out/precommit/personality/provided.sh | | git revision | master / 49839e4075 | | Default Java | 1.8.0_181 | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/25/artifact/out/patch-compile-root.txt | | javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/25/artifact/out/patch-compile-root.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/25/artifact/out/patch-findbugs-root.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/25/artifact/out/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/25/testReport/ | | asflicense | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/25/artifact/out/patch-asflicense-problems.txt | | Max. process+thread count | 4922 (vs. ulimit of 1) | | modules | C: hbase-hbtop . hbase-assembly U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/25/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #436: HBASE-22699 refactor isMetaClearingException
Apache-HBase commented on issue #436: HBASE-22699 refactor isMetaClearingException URL: https://github.com/apache/hbase/pull/436#issuecomment-519309757 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 121 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 537 | master passed | | +1 | compile | 26 | master passed | | +1 | checkstyle | 33 | master passed | | +1 | shadedjars | 273 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 22 | master passed | | 0 | spotbugs | 69 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 66 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 303 | the patch passed | | +1 | compile | 23 | the patch passed | | +1 | javac | 23 | the patch passed | | +1 | checkstyle | 31 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 273 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 938 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 20 | the patch passed | | +1 | findbugs | 71 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 100 | hbase-client in the patch passed. | | +1 | asflicense | 13 | The patch does not generate ASF License warnings. | | | | 3233 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/29/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/436 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 0253a4ec8284 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-436/out/precommit/personality/provided.sh | | git revision | master / 1b168cd6de | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/29/testReport/ | | Max. process+thread count | 258 (vs. ulimit of 1) | | modules | C: hbase-client U: hbase-client | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/29/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent
Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent URL: https://github.com/apache/hbase/pull/387#issuecomment-519309432 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 78 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 373 | master passed | | +1 | compile | 24 | master passed | | +1 | checkstyle | 12 | master passed | | +1 | shadedjars | 263 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 22 | master passed | | 0 | spotbugs | 48 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 47 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 298 | the patch passed | | +1 | compile | 25 | the patch passed | | +1 | javac | 25 | the patch passed | | +1 | checkstyle | 12 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 268 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 927 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 23 | the patch passed | | +1 | findbugs | 51 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 325 | hbase-rsgroup in the patch failed. | | +1 | asflicense | 13 | The patch does not generate ASF License warnings. | | | | 3124 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.rsgroup.TestRSGroupsAdmin2 | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/70/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/387 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux fa43b78ecd6d 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-387/out/precommit/personality/provided.sh | | git revision | master / 1b168cd6de | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/70/artifact/out/patch-unit-hbase-rsgroup.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/70/testReport/ | | Max. process+thread count | 4163 (vs. ulimit of 1) | | modules | C: hbase-rsgroup U: hbase-rsgroup | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/70/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22812) InterfaceAudience annotation in CatalogJanitor uses fully-qualified name
[
https://issues.apache.org/jira/browse/HBASE-22812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902543#comment-16902543
]
Hudson commented on HBASE-22812:
Results for branch branch-2.0
[build #1840 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1840/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1840//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1840//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1840//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> InterfaceAudience annotation in CatalogJanitor uses fully-qualified name
>
>
> Key: HBASE-22812
> URL: https://issues.apache.org/jira/browse/HBASE-22812
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>Reporter: Peter Somogyi
>Assignee: Murtaza Hassan
>Priority: Minor
> Labels: beginner
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
>
> CatalogJanitor class's InterfaceAudience annotation uses the fully-qualified
> name instead of just @InterfaceAudience.Private.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien…
Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien… URL: https://github.com/apache/hbase/pull/361#issuecomment-519305988 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 89 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 41 | Maven dependency ordering for branch | | +1 | mvninstall | 420 | master passed | | +1 | compile | 102 | master passed | | +1 | checkstyle | 140 | master passed | | +1 | shadedjars | 364 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 72 | master passed | | 0 | spotbugs | 328 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 416 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 19 | Maven dependency ordering for patch | | +1 | mvninstall | 400 | the patch passed | | +1 | compile | 99 | the patch passed | | +1 | javac | 99 | the patch passed | | +1 | checkstyle | 145 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 372 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1281 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 68 | the patch passed | | +1 | findbugs | 437 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 128 | hbase-client in the patch passed. | | -1 | unit | 16058 | hbase-server in the patch failed. | | +1 | asflicense | 54 | The patch does not generate ASF License warnings. | | | | 21226 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/79/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/361 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 2325db5631d2 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh | | git revision | master / 49839e4075 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/79/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/79/testReport/ | | Max. process+thread count | 5040 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/79/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #435: HBASE-22767 System table RIT STUCK if their RSGroup has no highest ve…
Apache-HBase commented on issue #435: HBASE-22767 System table RIT STUCK if their RSGroup has no highest ve… URL: https://github.com/apache/hbase/pull/435#issuecomment-519304853 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 71 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | 0 | shelldocs | 0 | Shelldocs was not available. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 40 | Maven dependency ordering for branch | | +1 | mvninstall | 336 | master passed | | +1 | compile | 96 | master passed | | +1 | checkstyle | 108 | master passed | | +1 | shadedjars | 261 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 80 | master passed | | 0 | spotbugs | 246 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 340 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 18 | Maven dependency ordering for patch | | +1 | mvninstall | 291 | the patch passed | | +1 | compile | 96 | the patch passed | | +1 | javac | 96 | the patch passed | | -1 | checkstyle | 75 | hbase-server: The patch generated 1 new + 9 unchanged - 0 fixed = 10 total (was 9) | | +1 | shellcheck | 0 | There were no new shellcheck issues. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 277 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1068 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 69 | the patch passed | | -1 | findbugs | 54 | hbase-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | +1 | unit | 169 | hbase-common in the patch passed. | | -1 | unit | 16081 | hbase-server in the patch failed. | | +1 | unit | 528 | hbase-rsgroup in the patch passed. | | +1 | asflicense | 71 | The patch does not generate ASF License warnings. | | | | 20893 | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-common | | | org.apache.hadoop.hbase.Version.() invokes inefficient new String(String) constructor At Version.java:inefficient new String(String) constructor At Version.java:[line 10] | | Failed junit tests | hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController | | | hadoop.hbase.client.TestFromClientSide | | | hadoop.hbase.master.TestAssignmentManagerMetrics | | | hadoop.hbase.client.TestAdmin1 | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/25/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/435 | | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 546fa53cecb2 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-435/out/precommit/personality/provided.sh | | git revision | master / 49839e4075 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/25/artifact/out/diff-checkstyle-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/25/artifact/out/new-findbugs-hbase-common.html | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/25/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/25/testReport/ | | Max. process+thread count | 4898 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server hbase-rsgroup U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/25/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-21892) If a new table is created inside a namespace then Namespace space quota violation is not working for first time
[ https://issues.apache.org/jira/browse/HBASE-21892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902538#comment-16902538 ] Sakthi commented on HBASE-21892: Ah! This is a nice catch. So this is actually an expected behavior. Here is what's happening: * Namespace quota set & violated. (with 'nfs1' table usage at 12 mb vs the set quota of 10 mb) * A new table 'nfs2' is created. (so by default 1 region initially if no split keys). Let's assume this was just a simple create command rather than using PE again. * The quotaobserverchore at master side lists out this new table under potential list of tables for the set namespace quota * But then because it hasn't yet received usagereport from rs about the only region/ or threshold amount of regions of this table, hence filters it out from considerationand continues to stop writes from nfs1 as the quota is violated. But nfs2 is not observed under quota and hence a put/flush command meanwhile would work fine. * This can go on, until the RS sends in it's first report and the table is not filtered out at master side and the quota violation for nfs2 table is persisted to the quota table. * Even then, till spacerefresherchore from the rs side runs and detects this table being in the list of violated tables from hbase:quota, the puts etc can still carry on. * And finally, when it is detected by that chore, the appropriate policy is enforced. [~elserj], please correct me if I am wrong. But I think it's worthwhile to discuss if we should allow '*create*' of a table when we know that it's for a namespace which is already under violation, and if continue to allow creation anyway then I don't there is any way to completely stop the writes etc till the above mention steps are completed. We can at best try to better the notification mechanism but still it would not be as spontaneous as expected. Josh, what do you think? :) > If a new table is created inside a namespace then Namespace space quota > violation is not working for first time > --- > > Key: HBASE-21892 > URL: https://issues.apache.org/jira/browse/HBASE-21892 > Project: HBase > Issue Type: Bug >Reporter: Ajeet Rai >Assignee: Sakthi >Priority: Minor > Labels: Quota, Space > > If a new table is created inside a namespace then NS quota violation is not > working for first time. > Steps to reproduce: > 1: Set a space quota at NameSpace level > set_quota TYPE => SPACE, NAMESPACE => 'game', LIMIT => '10M', POLICY => > NO_WRITES > 2: create a table and add insert data such that NS quota is violated > create_namespace 'game' > ./hbase pe --table="game:nfs" --nomapred --rows=1200 sequentialWrite 10 > 3: Try to load data in table again and observe that quota is applicable > 4: Now create another table under same NS and put some data > ./hbase pe --table="game:nfs2" --nomapred --rows=120 sequentialWrite 10 > 5: Observe that data is inserted in new table which should not happen due to > namespace quota is already violated -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22759) Add user info to AUDITLOG events when doing grant/revoke
[
https://issues.apache.org/jira/browse/HBASE-22759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902532#comment-16902532
]
Hudson commented on HBASE-22759:
Results for branch branch-2.2
[build #498 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/498/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/498//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/498//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/498//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Add user info to AUDITLOG events when doing grant/revoke
>
>
> Key: HBASE-22759
> URL: https://issues.apache.org/jira/browse/HBASE-22759
> Project: HBase
> Issue Type: Improvement
> Components: logging, security
>Affects Versions: 3.0.0, 2.2.0, 2.1.5
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6
>
>
> On *branch-2.1* the AUDITLOG events is raised like this:
> {noformat}
> AUDITLOG.trace("Granted permission " + perm.toString());{noformat}
> I'd like to extend this line with "caller" user info like this:
> {noformat}
> AUDITLOG.trace("User {} granted permission {}", caller,
> perm.toString());{noformat}
> Similar change is proposed for Revoke event.
> On branch-2.2+ grant() and revoke() methods in AccessController have been
> deprecated and logic was moved to {{MasterRpcServices}}, but that class
> doesn't do any audit logging. I'm not sure about why audit logging has been
> removed and about any replacement in the refactored logic, but Audit logging
> is a crucial security tool in our environment to track change events on ACLs.
> I'm planning to add AUDITLOG to {{MasterRpcServices}} to bring back this
> functionality, but please FIXME and point me in the right direction if needed.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22812) InterfaceAudience annotation in CatalogJanitor uses fully-qualified name
[
https://issues.apache.org/jira/browse/HBASE-22812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902535#comment-16902535
]
Hudson commented on HBASE-22812:
Results for branch branch-2.2
[build #498 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/498/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/498//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/498//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/498//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> InterfaceAudience annotation in CatalogJanitor uses fully-qualified name
>
>
> Key: HBASE-22812
> URL: https://issues.apache.org/jira/browse/HBASE-22812
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>Reporter: Peter Somogyi
>Assignee: Murtaza Hassan
>Priority: Minor
> Labels: beginner
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
>
> CatalogJanitor class's InterfaceAudience annotation uses the fully-qualified
> name instead of just @InterfaceAudience.Private.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22731) ReplicationSource and HBaseInterClusterReplicationEndpoint log messages should include a target Peer identifier
[
https://issues.apache.org/jira/browse/HBASE-22731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902533#comment-16902533
]
Hudson commented on HBASE-22731:
Results for branch branch-2.2
[build #498 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/498/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/498//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/498//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/498//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> ReplicationSource and HBaseInterClusterReplicationEndpoint log messages
> should include a target Peer identifier
> ---
>
> Key: HBASE-22731
> URL: https://issues.apache.org/jira/browse/HBASE-22731
> Project: HBase
> Issue Type: Improvement
> Components: Replication
>Affects Versions: 2.2.0, 2.1.5
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Minor
> Fix For: 3.0.0, 2.2.1, 2.1.6
>
> Attachments: HBASE-22731.branch-2.001.patch,
> HBASE-22731.master.001.patch, HBASE-22731.master.002.patch,
> HBASE-22731.master.003.patch, HBASE-22731.master.004.patch,
> HBASE-22731.master.005.patch
>
>
> _ReplicationSource_ and _HBaseInterClusterReplicationEndpoint_ already
> include a good number of helpful DEBUG and TRACE log messages to help us
> troubleshooting typical replication problems, such as lags or mysteriously
> missing edits on target peer.
> However, for each configured peer, there will be an individual
> _ReplicationSource_/_HBaseInterClusterReplicationEndpoint_ pair running in
> parallel, in scenarios where we need to investigate issues within a source to
> an specific peer, we can't distinguish from which peer specific
> _ReplicationSource_/_HBaseInterClusterReplicationEndpoint._ For such cases it
> would be nice to have an identifier for specific peer the given
> _ReplicationSource_/_HBaseInterClusterReplicationEndpoint_ is related to.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22417) DeleteTableProcedure.deleteFromMeta method should remove table from Master's table descriptors cache
[
https://issues.apache.org/jira/browse/HBASE-22417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902534#comment-16902534
]
Hudson commented on HBASE-22417:
Results for branch branch-2.2
[build #498 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/498/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/498//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/498//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/498//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> DeleteTableProcedure.deleteFromMeta method should remove table from Master's
> table descriptors cache
>
>
> Key: HBASE-22417
> URL: https://issues.apache.org/jira/browse/HBASE-22417
> Project: HBase
> Issue Type: Bug
>Affects Versions: 3.0.0, 2.2.0, 2.1.5
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Major
> Fix For: 3.0.0, 2.2.1, 2.1.6
>
> Attachments: HBASE-22417.master.001.patch,
> HBASE-22417.master.002.patch, HBASE-22417.master.003.patch,
> HBASE-22417.master.004.patch, HBASE-22417.master.005.patch
>
>
> DeleteTableProcedure defines a static deleteFromMeta method that's currently
> used both by DeleteTableProcedure itself and TruncateTableProcedure.
> Sometimes, depending on the table size (and under slower, under performing
> FileSystems), truncation can take longer to complete
> *TRUNCATE_TABLE_CLEAR_FS_LAYOUT* stage, but the given table has already been
> deleted from meta on previous *TRUNCATE_TABLE_REMOVE_FROM_META* stage. In
> this case, features relying on Master's table descriptor's cache might
> wrongly try to reference this truncating table. Master Web UI, for example,
> would try to check this table state and end up showing a 500 error.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22115) HBase RPC aspires to grow an infinite tree of trace scopes; some other places are also unsafe
[
https://issues.apache.org/jira/browse/HBASE-22115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902526#comment-16902526
]
Hudson commented on HBASE-22115:
Results for branch branch-2.1
[build #1460 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1460/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1460//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1460//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1460//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> HBase RPC aspires to grow an infinite tree of trace scopes; some other places
> are also unsafe
> -
>
> Key: HBASE-22115
> URL: https://issues.apache.org/jira/browse/HBASE-22115
> Project: HBase
> Issue Type: Bug
> Components: rpc, tracing
>Reporter: Sergey Shelukhin
>Assignee: Sergey Shelukhin
>Priority: Critical
> Fix For: 3.0.0, 2.2.0, 2.3.0, 2.0.6, 2.1.6
>
> Attachments: Clipboard01.jpg, HBASE-22115.01.patch,
> HBASE-22115.02.patch, HBASE-22115.branch-2.1.001.patch, HBASE-22115.patch
>
>
> !Clipboard01.jpg!
> All of those are ClientServices.Multi in this case.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22417) DeleteTableProcedure.deleteFromMeta method should remove table from Master's table descriptors cache
[
https://issues.apache.org/jira/browse/HBASE-22417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902527#comment-16902527
]
Hudson commented on HBASE-22417:
Results for branch branch-2.1
[build #1460 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1460/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1460//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1460//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1460//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> DeleteTableProcedure.deleteFromMeta method should remove table from Master's
> table descriptors cache
>
>
> Key: HBASE-22417
> URL: https://issues.apache.org/jira/browse/HBASE-22417
> Project: HBase
> Issue Type: Bug
>Affects Versions: 3.0.0, 2.2.0, 2.1.5
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Major
> Fix For: 3.0.0, 2.2.1, 2.1.6
>
> Attachments: HBASE-22417.master.001.patch,
> HBASE-22417.master.002.patch, HBASE-22417.master.003.patch,
> HBASE-22417.master.004.patch, HBASE-22417.master.005.patch
>
>
> DeleteTableProcedure defines a static deleteFromMeta method that's currently
> used both by DeleteTableProcedure itself and TruncateTableProcedure.
> Sometimes, depending on the table size (and under slower, under performing
> FileSystems), truncation can take longer to complete
> *TRUNCATE_TABLE_CLEAR_FS_LAYOUT* stage, but the given table has already been
> deleted from meta on previous *TRUNCATE_TABLE_REMOVE_FROM_META* stage. In
> this case, features relying on Master's table descriptor's cache might
> wrongly try to reference this truncating table. Master Web UI, for example,
> would try to check this table state and end up showing a 500 error.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22812) InterfaceAudience annotation in CatalogJanitor uses fully-qualified name
[
https://issues.apache.org/jira/browse/HBASE-22812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902528#comment-16902528
]
Hudson commented on HBASE-22812:
Results for branch branch-2.1
[build #1460 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1460/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1460//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1460//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1460//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> InterfaceAudience annotation in CatalogJanitor uses fully-qualified name
>
>
> Key: HBASE-22812
> URL: https://issues.apache.org/jira/browse/HBASE-22812
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>Reporter: Peter Somogyi
>Assignee: Murtaza Hassan
>Priority: Minor
> Labels: beginner
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
>
> CatalogJanitor class's InterfaceAudience annotation uses the fully-qualified
> name instead of just @InterfaceAudience.Private.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #463: HBASE-22725 Remove all remaining javadoc warnings
Apache-HBase commented on issue #463: HBASE-22725 Remove all remaining javadoc warnings URL: https://github.com/apache/hbase/pull/463#issuecomment-519294702 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 38 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 3 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 35 | Maven dependency ordering for branch | | +1 | mvninstall | 305 | master passed | | +1 | compile | 170 | master passed | | +1 | checkstyle | 148 | master passed | | +1 | shadedjars | 263 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 233 | master passed | | 0 | spotbugs | 217 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 1163 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 13 | Maven dependency ordering for patch | | +1 | mvninstall | 277 | the patch passed | | +1 | compile | 167 | the patch passed | | +1 | javac | 167 | the patch passed | | -1 | checkstyle | 147 | root: The patch generated 1 new + 476 unchanged - 18 fixed = 477 total (was 494) | | +1 | whitespace | 1 | The patch has no whitespace issues. | | +1 | xml | 1 | The patch has no ill-formed XML file. | | +1 | shadedjars | 264 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 896 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 21 | hbase-client generated 0 new + 2 unchanged - 1 fixed = 2 total (was 3) | | +1 | javadoc | 33 | hbase-server in the patch passed. | | +1 | javadoc | 17 | hbase-mapreduce in the patch passed. | | +1 | javadoc | 159 | root generated 0 new + 3 unchanged - 1 fixed = 3 total (was 4) | | +1 | findbugs | 1301 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 11851 | root in the patch failed. | | +1 | asflicense | 142 | The patch does not generate ASF License warnings. | | | | 18072 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-463/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/463 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile xml | | uname | Linux 54cc3750fc80 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-463/out/precommit/personality/provided.sh | | git revision | master / 49839e4075 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-463/2/artifact/out/diff-checkstyle-root.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-463/2/artifact/out/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-463/2/testReport/ | | Max. process+thread count | 5586 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server hbase-mapreduce . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-463/2/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902517#comment-16902517 ] Geoffrey Jacoby commented on HBASE-22623: - [~apurtell] I have modified the patch to revert the comment and InterfaceAudience changes to WALEdit (so that add is still marked Private) and added a check to HRegion.doWALAppend to not call the new coproc hook when WALEdit.isMetaEdit() is true. I have also included a test to verify the latter. > Add RegionObserver coprocessor hook for preWALAppend > > > Key: HBASE-22623 > URL: https://issues.apache.org/jira/browse/HBASE-22623 > Project: HBase > Issue Type: New Feature >Reporter: Geoffrey Jacoby >Assignee: Geoffrey Jacoby >Priority: Major > Fix For: 3.0.0, 1.5.0, 2.3.0 > > > While many coprocessor hooks expose the WALEdit to implementing coprocs, > there aren't any that expose the WALKey before it's created and added to the > WALEntry. > It's sometimes useful for coprocessors to be able to edit the WALKey, for > example to add extended attributes using the fields to be added in > HBASE-22622. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
