[jira] [Commented] (HBASE-22514) Move rsgroup feature into core of HBase
[
https://issues.apache.org/jira/browse/HBASE-22514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17017781#comment-17017781
]
Hudson commented on HBASE-22514:
Results for branch HBASE-22514
[build #244 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/244/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/244//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/244//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/244//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Move rsgroup feature into core of HBase
> ---
>
> Key: HBASE-22514
> URL: https://issues.apache.org/jira/browse/HBASE-22514
> Project: HBase
> Issue Type: Umbrella
> Components: Admin, Client, rsgroup
>Reporter: Yechao Chen
>Assignee: Duo Zhang
>Priority: Major
> Attachments: HBASE-22514.master.001.patch,
> image-2019-05-31-18-25-38-217.png
>
>
> The class RSGroupAdminClient is not public
> we need to use java api RSGroupAdminClient to manager RSG
> so RSGroupAdminClient should be public
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-23569) Validate that the log cleaner actually cleans oldWALs as expected
[ https://issues.apache.org/jira/browse/HBASE-23569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-23569: - Hadoop Flags: Reviewed Resolution: Fixed Status: Resolved (was: Patch Available) > Validate that the log cleaner actually cleans oldWALs as expected > - > > Key: HBASE-23569 > URL: https://issues.apache.org/jira/browse/HBASE-23569 > Project: HBase > Issue Type: Test > Components: integration tests, master, test >Reporter: Andrew Kyle Purtell >Assignee: Viraj Jasani >Priority: Major > Fix For: 3.0.0, 2.3.0, 1.6.0, 2.2.3 > > Attachments: HBASE-23569.master.000.patch, > HBASE-23569.master.002.patch, HBASE-23569.master.002.patch > > > The fix for HBASE-23287 (LogCleaner is not added to choreService) is in but > we are lacking test coverage that validates that the log cleaner actually > cleans oldWALs as expected. Add the test. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1026: HBASE-23682 Fix NPE when disable DeadServerMetricRegionChore
Apache-HBase commented on issue #1026: HBASE-23682 Fix NPE when disable DeadServerMetricRegionChore URL: https://github.com/apache/hbase/pull/1026#issuecomment-575478318 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m 51s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 33s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 45s | master passed | | +1 :green_heart: | compile | 1m 19s | master passed | | +1 :green_heart: | checkstyle | 1m 47s | master passed | | +1 :green_heart: | shadedjars | 4m 56s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 51s | master passed | | +0 :ok: | spotbugs | 5m 0s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 5m 32s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 26s | the patch passed | | +1 :green_heart: | compile | 1m 23s | the patch passed | | +1 :green_heart: | javac | 1m 23s | the patch passed | | +1 :green_heart: | checkstyle | 1m 45s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 5m 2s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 17m 22s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | javadoc | 0m 54s | the patch passed | | +1 :green_heart: | findbugs | 5m 49s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 3m 44s | hbase-procedure in the patch passed. | | -1 :x: | unit | 167m 37s | hbase-server in the patch failed. | | +1 :green_heart: | asflicense | 0m 47s | The patch does not generate ASF License warnings. | | | | 242m 49s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.assignment.TestRegionMoveAndAbandon | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/7/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1026 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 5fadedbbb580 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1026/out/precommit/personality/provided.sh | | git revision | master / 00fc46756a | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/7/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/7/testReport/ | | Max. process+thread count | 5457 (vs. ulimit of 1) | | modules | C: hbase-procedure hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/7/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] virajjasani commented on a change in pull request #1057: HBASE-23701 Try to converge automated checks around Category
virajjasani commented on a change in pull request #1057: HBASE-23701 Try to
converge automated checks around Category
URL: https://github.com/apache/hbase/pull/1057#discussion_r367768244
##
File path:
hbase-common/src/test/java/org/apache/hadoop/hbase/HBaseClassTestRule.java
##
@@ -59,13 +59,20 @@ private HBaseClassTestRule(Class clazz, Timeout
timeout) {
private static long getTimeoutInSeconds(Class clazz) {
Category[] categories = clazz.getAnnotationsByType(Category.class);
-for (Class c : categories[0].value()) {
- if (c == SmallTests.class || c == MediumTests.class || c ==
LargeTests.class) {
-// All tests have a 13 minutes timeout.
-return TimeUnit.MINUTES.toSeconds(13);
- }
- if (c == IntegrationTests.class) {
-return TimeUnit.MINUTES.toSeconds(Long.MAX_VALUE);
+// This should never happen
+if (categories.length > 1) {
+ throw new IllegalArgumentException("Code-bug: unsure how to handle more
than one Category");
+}
+// Fail gracefully if there is no Category defined
+if (categories.length == 1) {
+ for (Class c : categories[0].value()) {
+if (c == SmallTests.class || c == MediumTests.class || c ==
LargeTests.class) {
Review comment:
nit: good to create immutable final set/list of all 3 values and then check
with `if set.contains(c)`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (HBASE-23653) Expose content of meta table in web ui
[
https://issues.apache.org/jira/browse/HBASE-23653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17017708#comment-17017708
]
Hudson commented on HBASE-23653:
Results for branch branch-2
[build #2418 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2418/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2418//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2418//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2418//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Expose content of meta table in web ui
> --
>
> Key: HBASE-23653
> URL: https://issues.apache.org/jira/browse/HBASE-23653
> Project: HBase
> Issue Type: New Feature
> Components: master, Operability, UI
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Minor
> Fix For: 3.0.0, 2.3.0
>
> Attachments: 23653.0.png, 23653.1.png
>
>
> While testing improvements to hbck2, breaking and fixing a cluster's region
> assignments, we've found that quite a few questions can only be answered by
> dropping into a shell and scanning meta. This is in contrast to the nice web
> view we have on procedures and their locks. It would be nice to have a
> similar view into the content of meta. I've put together and extension to the
> existing {{table.jsp}} that does this. It's had a couple rounds of operator
> feedback. Will post up some screenshots along with the PR.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23347) Pluggable RPC authentication
[
https://issues.apache.org/jira/browse/HBASE-23347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17017707#comment-17017707
]
Hudson commented on HBASE-23347:
Results for branch branch-2
[build #2418 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2418/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2418//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2418//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2418//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Pluggable RPC authentication
>
>
> Key: HBASE-23347
> URL: https://issues.apache.org/jira/browse/HBASE-23347
> Project: HBase
> Issue Type: Improvement
> Components: rpc, security
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> Today in HBase, we rely on SASL to implement Kerberos and delegation token
> authentication. The RPC client and server logic is very tightly coupled to
> our three authentication mechanism (the previously two mentioned plus simple
> auth'n) for no good reason (other than "that's how it was built", best as I
> can tell).
> SASL's function is to decouple the "application" from how a request is being
> authenticated, which means that, to support a variety of other authentication
> approaches, we just need to be a little more flexible in letting developers
> create their own authentication mechanism for HBase.
> This is less for the "average joe" user to write their own authentication
> plugin (eek), but more to allow us HBase developers to start iterating, see
> what is possible.
> I'll attach a full write-up on what I have today as to how I think we can add
> these abstractions, as well as an initial implementation of this idea, with a
> unit test that shows an end-to-end authentication solution against HBase.
> cc/ [~wchevreuil] as he's been working with me behind the scenes, giving lots
> of great feedback and support.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23694) After RegionProcedureStore completes migration of WALProcedureStore, still running WALProcedureStore.syncThread keeps trying to delete now inexistent log files.
[
https://issues.apache.org/jira/browse/HBASE-23694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17017703#comment-17017703
]
Hudson commented on HBASE-23694:
Results for branch branch-2
[build #2418 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2418/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2418//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2418//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2418//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> After RegionProcedureStore completes migration of WALProcedureStore, still
> running WALProcedureStore.syncThread keeps trying to delete now inexistent
> log files.
> --
>
> Key: HBASE-23694
> URL: https://issues.apache.org/jira/browse/HBASE-23694
> Project: HBase
> Issue Type: Bug
> Components: proc-v2, RegionProcedureStore
>Affects Versions: 3.0.0
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> With the introduction of the new procedure store to save procs on a table,
> instead of proc WALs, we added some migration logic to enable a smooth
> upgrade of clusters under previous versions that used to have proc wal files
> as the underlying procedure store.
> While running a fresh install with latest master branch version, I had
> noticed that once the old _WALProcedureStore_ directory is detected, it
> creates and start a WPS instance
> [here|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/procedure2/store/region/RegionProcedureStore.java#L311],
> passing a built-in _ProcedureLoader_
> [here|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/procedure2/store/region/RegionProcedureStore.java#L315]
> to perform the conversion from proc wal files to table based.
> At the end of this conversion, the builtin loader deletes the proc wal dir
> [here|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/procedure2/store/region/RegionProcedureStore.java#L363].
> This may cause a race condition where a running _WALProcedureStore_ internal
> thread may be trying to delete the first proc wal file that may had already
> rolled, then failing with FNFE.
> Even worse is that _WALProcedureStore.syncLoop_ keeps trying indefinitely,
> flooding Master logs with messages such as below:
> {noformat}
> 2020-01-14 06:13:23,331 INFO [master/hbase01:16000:becomeActiveMaster]
> region.RegionProcedureStore: The old WALProcedureStore wal directory
> file:/root/hbase-3.0.0-SNAPSHOT/hbase-data/MasterProcWALs exists, migrating...
> 2020-01-14 06:13:23,361 DEBUG [master/hbase01:16000:becomeActiveMaster]
> wal.WALProcedureStore: Starting WAL Procedure Store lease recovery
> 2020-01-14 06:13:23,453 INFO [master/hbase01:16000:becomeActiveMaster]
> wal.WALProcedureStore: Rolled new Procedure Store WAL, id=1
> 2020-01-14 06:13:23,454 DEBUG [master/hbase01:16000:becomeActiveMaster]
> wal.WALProcedureStore: Lease acquired for flushLogId=1
> 2020-01-14 06:13:23,454 DEBUG [master/hbase01:16000:becomeActiveMaster]
> wal.WALProcedureStore: No state logs to replay.
> 2020-01-14 06:13:23,454 INFO [master/hbase01:16000:becomeActiveMaster]
> region.RegionProcedureStore: The WALProcedureStore max pid is 0, and the max
> pid of all loaded procedures is -1
> 2020-01-14 06:13:23,455 INFO [master/hbase01:16000:becomeActiveMaster]
> region.RegionProcedureStore: Migration of WALProcedureStore finished
> 2020-01-14 06:13:23,455 INFO [master/hbase01:16000:becomeActiveMaster]
> procedure2.ProcedureExecutor: Recovered RegionProcedureStore lease in 784 msec
> 2020-01-14 06:13:23,471 TRACE [WALProcedureStoreSyncThread]
> wal.WALProcedureStore: no active procedures
> 2020-01-14 06:13:23,516 INFO [master/hbase01:16000:becomeActiveMaster]
> procedure2.ProcedureExecutor: Loaded RegionProcedureStore in 61 msec
> 2020-01-14 06:13:23,516 INFO [master/hbase01:16000:becomeActiveMaster]
> procedure2.RemoteProcedureDispatcher: Insta
[jira] [Commented] (HBASE-23677) region.jsp returns 500/NPE when provided encoded region name is not online
[
https://issues.apache.org/jira/browse/HBASE-23677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17017704#comment-17017704
]
Hudson commented on HBASE-23677:
Results for branch branch-2
[build #2418 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2418/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2418//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2418//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2418//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> region.jsp returns 500/NPE when provided encoded region name is not online
> --
>
> Key: HBASE-23677
> URL: https://issues.apache.org/jira/browse/HBASE-23677
> Project: HBase
> Issue Type: Bug
> Components: regionserver, UI
>Affects Versions: 2.2.3
>Reporter: Nick Dimiduk
>Assignee: wenfeiyi666
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.2.4
>
>
> Noticed while testing for HBASE-23653. A link off to a region that is closed
> or otherwise not in the region server's online region map results in a 500.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23695) Fail more gracefully when test class is missing Category
[
https://issues.apache.org/jira/browse/HBASE-23695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17017706#comment-17017706
]
Hudson commented on HBASE-23695:
Results for branch branch-2
[build #2418 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2418/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2418//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2418//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2418//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Fail more gracefully when test class is missing Category
>
>
> Key: HBASE-23695
> URL: https://issues.apache.org/jira/browse/HBASE-23695
> Project: HBase
> Issue Type: Bug
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.2.3, 2.1.9
>
>
> When a test class is missing a category, you might see an error such as:
> {noformat}
> [ERROR] Test mechanism Time elapsed: 0.305 s <<< ERROR!
> java.lang.ArrayIndexOutOfBoundsException: 0[ERROR] Test mechanism Time
> elapsed: 0.102 s <<< ERROR!
> java.lang.ArrayIndexOutOfBoundsException: 0[ERROR] Test mechanism Time
> elapsed: 0.103 s <<< ERROR!
> java.lang.ArrayIndexOutOfBoundsException: 0[ERROR] Test mechanism Time
> elapsed: 0.102 s <<< ERROR!
> java.lang.ArrayIndexOutOfBoundsException: 0[ERROR] Test mechanism Time
> elapsed: 0.098 s <<< ERROR!
> java.lang.ArrayIndexOutOfBoundsException: 0[ERROR] Test mechanism :: 0
> {noformat}
> You have to dig into the dump file to find out the actual error was:
> {noformat}
> org.apache.maven.surefire.testset.TestSetFailedException: Test mechanism :: 0
> at
> org.apache.maven.surefire.common.junit4.JUnit4RunListener.rethrowAnyTestMechanismFailures(JUnit4RunListener.java:192)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:167)
> at
> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:377)
> at
> org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:138)
> at
> org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:465)
> at
> org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:451)
> Caused by: java.lang.ArrayIndexOutOfBoundsException: 0
> at
> org.apache.hadoop.hbase.HBaseClassTestRuleChecker.testStarted(HBaseClassTestRuleChecker.java:44)
> at
> org.junit.runner.notification.RunNotifier$5.notifyListener(RunNotifier.java:156)
> at
> org.junit.runner.notification.RunNotifier$SafeNotifier.run(RunNotifier.java:72)
> at
> org.junit.runner.notification.RunNotifier.fireTestStarted(RunNotifier.java:153)
> at
> org.apache.maven.surefire.common.junit4.Notifier.fireTestStarted(Notifier.java:100)
> at
> org.junit.internal.runners.model.EachTestNotifier.fireTestStarted(EachTestNotifier.java:42)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:364)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
> at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
> at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
> at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)
> ... 4 more {noformat}
> We can fix this up to get a proper exception thrown.
-
[jira] [Commented] (HBASE-23601) OutputSink.WriterThread exception gets stuck and repeated indefinietly
[
https://issues.apache.org/jira/browse/HBASE-23601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17017700#comment-17017700
]
Hudson commented on HBASE-23601:
Results for branch branch-2
[build #2418 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2418/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2418//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2418//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2418//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> OutputSink.WriterThread exception gets stuck and repeated indefinietly
> --
>
> Key: HBASE-23601
> URL: https://issues.apache.org/jira/browse/HBASE-23601
> Project: HBase
> Issue Type: Bug
> Components: read replicas
>Affects Versions: 2.2.2
>Reporter: Szabolcs Bukros
>Assignee: Szabolcs Bukros
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.1.9, 2.2.4
>
>
> When a WriterThread runs into an exception (ie: NotServingRegionException),
> the exception is stored in the controller. It is never removed and can not be
> overwritten either.
>
> {code:java}
> public void run() {
> try {
> doRun();
> } catch (Throwable t) {
> LOG.error("Exiting thread", t);
> controller.writerThreadError(t);
> }
> }{code}
> Thanks to this every time PipelineController.checkForErrors() is called the
> same old exception is rethrown.
>
> For example in RegionReplicaReplicationEndpoint.replicate there is a while
> loop that does the actual replicating. Every time it loops, it calls
> checkForErrors(), catches the rethrown exception, logs it but does nothing
> about it. This results in ~2GB log files in ~5min in my experience.
>
> My proposal would be to clean up the stored exception when it reaches
> RegionReplicaReplicationEndpoint.replicate and make sure we restart the
> WriterThread that died throwing it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23652) Move the unsupported procedure type check before migrating to RegionProcedureStore
[
https://issues.apache.org/jira/browse/HBASE-23652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17017705#comment-17017705
]
Hudson commented on HBASE-23652:
Results for branch branch-2
[build #2418 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2418/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2418//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2418//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2418//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Move the unsupported procedure type check before migrating to
> RegionProcedureStore
> --
>
> Key: HBASE-23652
> URL: https://issues.apache.org/jira/browse/HBASE-23652
> Project: HBase
> Issue Type: Task
> Components: master
>Affects Versions: 2.2.2
>Reporter: Nick Dimiduk
>Assignee: Duo Zhang
>Priority: Blocker
> Fix For: 3.0.0, 2.3.0
>
>
> Per
> [discussion|https://lists.apache.org/thread.html/c5f960e6cf3c89ffbf8f8302afb121462a08fd9a89d384c6795a7b81%40%3Cdev.hbase.apache.org%3E]
> on the list, let's figure out how to make the upgrade from a v2.1 procedure
> store less error-prone. Could be a simple as documenting runbook steps to
> execute during the rolling upgrade, but it would be nice if the software
> could roll over the data versions gracefully.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23674) Too many rit page Numbers show confusion
[
https://issues.apache.org/jira/browse/HBASE-23674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17017701#comment-17017701
]
Hudson commented on HBASE-23674:
Results for branch branch-2
[build #2418 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2418/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2418//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2418//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2418//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Too many rit page Numbers show confusion
>
>
> Key: HBASE-23674
> URL: https://issues.apache.org/jira/browse/HBASE-23674
> Project: HBase
> Issue Type: Improvement
> Components: master
>Affects Versions: 3.0.0
>Reporter: dingbaosheng
>Assignee: dingbaosheng
>Priority: Trivial
> Fix For: 3.0.0, 2.3.0, 2.2.4
>
> Attachments: HBASE-23674.master.0001.patch,
> HBASE-23674.master.0002.patch, HBASE-23674.master.0003.patch, Screen Shot
> 2020-01-14 at 11.01.34 AM.png, rit_2.png, rit_page.jpg, rit_too_many.jpg
>
>
> Too much rits can cause page rendering clutter, which can be resolved by
> adding pagers.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23665) Split unit tests from TestTableName into a separate test only class
[
https://issues.apache.org/jira/browse/HBASE-23665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17017702#comment-17017702
]
Hudson commented on HBASE-23665:
Results for branch branch-2
[build #2418 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2418/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2418//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2418//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2418//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Split unit tests from TestTableName into a separate test only class
> ---
>
> Key: HBASE-23665
> URL: https://issues.apache.org/jira/browse/HBASE-23665
> Project: HBase
> Issue Type: Test
> Components: test
>Reporter: Nick Dimiduk
>Assignee: Bharath Vissapragada
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 1.6.0
>
>
> The class {{TestTableName}} in hbase-common is both a unit test for the
> {{TableName}} class, and a junit {{TestRule}}. This double-duty is strange;
> the Rule functionality is not discoverable at all. Split the Rule out into a
> separate class, maybe {{TableNameRule}} or some such.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23695) Fail more gracefully when test class is missing Category
[
https://issues.apache.org/jira/browse/HBASE-23695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17017695#comment-17017695
]
Hudson commented on HBASE-23695:
Results for branch branch-2.1
[build #1775 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1775/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1775//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1775//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1775//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Fail more gracefully when test class is missing Category
>
>
> Key: HBASE-23695
> URL: https://issues.apache.org/jira/browse/HBASE-23695
> Project: HBase
> Issue Type: Bug
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.2.3, 2.1.9
>
>
> When a test class is missing a category, you might see an error such as:
> {noformat}
> [ERROR] Test mechanism Time elapsed: 0.305 s <<< ERROR!
> java.lang.ArrayIndexOutOfBoundsException: 0[ERROR] Test mechanism Time
> elapsed: 0.102 s <<< ERROR!
> java.lang.ArrayIndexOutOfBoundsException: 0[ERROR] Test mechanism Time
> elapsed: 0.103 s <<< ERROR!
> java.lang.ArrayIndexOutOfBoundsException: 0[ERROR] Test mechanism Time
> elapsed: 0.102 s <<< ERROR!
> java.lang.ArrayIndexOutOfBoundsException: 0[ERROR] Test mechanism Time
> elapsed: 0.098 s <<< ERROR!
> java.lang.ArrayIndexOutOfBoundsException: 0[ERROR] Test mechanism :: 0
> {noformat}
> You have to dig into the dump file to find out the actual error was:
> {noformat}
> org.apache.maven.surefire.testset.TestSetFailedException: Test mechanism :: 0
> at
> org.apache.maven.surefire.common.junit4.JUnit4RunListener.rethrowAnyTestMechanismFailures(JUnit4RunListener.java:192)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:167)
> at
> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:377)
> at
> org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:138)
> at
> org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:465)
> at
> org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:451)
> Caused by: java.lang.ArrayIndexOutOfBoundsException: 0
> at
> org.apache.hadoop.hbase.HBaseClassTestRuleChecker.testStarted(HBaseClassTestRuleChecker.java:44)
> at
> org.junit.runner.notification.RunNotifier$5.notifyListener(RunNotifier.java:156)
> at
> org.junit.runner.notification.RunNotifier$SafeNotifier.run(RunNotifier.java:72)
> at
> org.junit.runner.notification.RunNotifier.fireTestStarted(RunNotifier.java:153)
> at
> org.apache.maven.surefire.common.junit4.Notifier.fireTestStarted(Notifier.java:100)
> at
> org.junit.internal.runners.model.EachTestNotifier.fireTestStarted(EachTestNotifier.java:42)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:364)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
> at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
> at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
> at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)
> ... 4 more {noformat}
> We can fix this up to get a proper exceptio
[jira] [Updated] (HBASE-17265) Region left unassigned in master failover when region failed to open
[
https://issues.apache.org/jira/browse/HBASE-17265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lijin Bin updated HBASE-17265:
--
Component/s: (was: Region Assignment)
> Region left unassigned in master failover when region failed to open
>
>
> Key: HBASE-17265
> URL: https://issues.apache.org/jira/browse/HBASE-17265
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.1.7
>Reporter: Allan Yang
>Assignee: Allan Yang
>Priority: Major
> Fix For: 1.4.0, 1.3.1, 1.2.5, 1.1.9
>
> Attachments: HBASE-17265-branch-1.patch, HBASE-17265-branch-1.v2.patch
>
>
> This problem is very similar with HBASE-13330. It is also a result of
> ServerShutdownHandler and AssignmentManager 'thought' the region will be
> assigned by each other, and left the region remain unassigned.
> But HBASE-13330 only dealed with RS_ZK_REGION_FAILED_OPEN in
> {{processRegionInTransition}}.
> Region failed open may happen after {{processRegionInTransition}}. In my
> case, when master failover, it assigned all RIT regions, but some are failed
> to open(due to HBASE-17264), AssignmentManager received the zk event, and
> skip to assign it(this region was opened on a failed server before and
> already in RIT before master failover). The SSH also skip to assign it
> because it was RIT on another RS.
> Master recevied a zk event of RS_ZK_REGION_FAILED_OPEN and begin to handle it:
> {noformat}
> 2016-11-23 17:11:46,944 DEBUG [AM.ZK.Worker-pool2-t1]
> master.AssignmentManager: Handling RS_ZK_REGION_FAILED_OPEN,
> server=example.org,30003,1479780976834,
> region=57513956a7b671f4e8da1598c2e2970e,
> current_state={57513956a7b671f4e8da1598c2e2970e state=PENDING_OPEN,
> ts=1479892306843, server=example.org,30003,1479780976834}
> 2016-11-23 17:11:46,944 INFO [AM.ZK.Worker-pool2-t1] master.RegionStates:
> Transition {57513956a7b671f4e8da1598c2e2970e state=PENDING_OPEN,
> ts=1479892306843, server=example.org,30003,1479780976834} to
> {57513956a7b671f4e8da1598c2e2970e state=CLOSED, ts=1479892306944,
> server=example.org,30003,1479780976834}
> 2016-11-23 17:11:46,945 WARN [AM.ZK.Worker-pool2-t1] master.RegionStates:
> 57513956a7b671f4e8da1598c2e2970e moved to CLOSED on
> example.org,30003,1479780976834, expected example.org,30003,1475893095003
> 2016-11-23 17:11:46,950 DEBUG [AM.ZK.Worker-pool2-t1]
> master.AssignmentManager: Found an existing plan for
> test,QFO7M,1475986053104.57513956a7b671f4e8da1598c2e2970e. destination server
> is example.org,30003,1479780976834 accepted as a dest server = false
> 2016-11-23 17:11:47,012 DEBUG [AM.ZK.Worker-pool2-t1]
> master.AssignmentManager: No previous transition plan found (or ignoring an
> existing plan) for
> test,QFO7M,1475986053104.57513956a7b671f4e8da1598c2e2970e.; generated random
> plan=hri=test,QFO7M,1475986053104.57513956a7b671f4e8da1598c2e2970e., src=,
> dest=11.239.21.235,30003,1479781410131; 2 (online=3) available servers,
> forceNewPlan=true
> 2016-11-23 17:11:47,014 DEBUG [AM.ZK.Worker-pool2-t1]
> handler.ClosedRegionHandler: Handling CLOSED event for
> 57513956a7b671f4e8da1598c2e2970e
> 2016-11-23 17:11:47,015 WARN [AM.ZK.Worker-pool2-t1] master.RegionStates:
> 57513956a7b671f4e8da1598c2e2970e moved to CLOSED on
> example.org,30003,1479780976834, expected example.org,30003,1475893095003
> {noformat}
> AssignmentManager skip to assign it because the region was on a failed server
> {noformat}
> 2016-11-23 17:11:47,017 INFO [AM.ZK.Worker-pool2-t1]
> master.AssignmentManager: Skip assigning
> test,QFO7M,1475986053104.57513956a7b671f4e8da1598c2e2970e., it's host
> example.org,30003,1475893095003 is dead but not processed yet
> {noformat}
> SSH also skip it because it was RIT on another server
> {noformat}
> 2016-11-23 17:12:17,850 INFO [MASTER_SERVER_OPERATIONS-example.org:30001-0]
> master.RegionStates: Transitioning {57513956a7b671f4e8da1598c2e2970e
> state=CLOSED, ts=1479892307015, server=example.org,30003,1479780976834} will
> be handled by SSH for example.org,30003,1475893095003
> 2016-11-23 17:12:17,910 INFO [MASTER_SERVER_OPERATIONS-example.org:30001-0]
> handler.ServerShutdownHandler: Skip assigning region in transition on other
> server{57513956a7b671f4e8da1598c2e2970e state=CLOSED, ts=1479892307015,
> server=example.org,30003,1479780976834}
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-17265) Region left unassigned in master failover when region failed to open
[
https://issues.apache.org/jira/browse/HBASE-17265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lijin Bin updated HBASE-17265:
--
Component/s: Region Assignment
> Region left unassigned in master failover when region failed to open
>
>
> Key: HBASE-17265
> URL: https://issues.apache.org/jira/browse/HBASE-17265
> Project: HBase
> Issue Type: Bug
> Components: Region Assignment
>Affects Versions: 1.1.7
>Reporter: Allan Yang
>Assignee: Allan Yang
>Priority: Major
> Fix For: 1.4.0, 1.3.1, 1.2.5, 1.1.9
>
> Attachments: HBASE-17265-branch-1.patch, HBASE-17265-branch-1.v2.patch
>
>
> This problem is very similar with HBASE-13330. It is also a result of
> ServerShutdownHandler and AssignmentManager 'thought' the region will be
> assigned by each other, and left the region remain unassigned.
> But HBASE-13330 only dealed with RS_ZK_REGION_FAILED_OPEN in
> {{processRegionInTransition}}.
> Region failed open may happen after {{processRegionInTransition}}. In my
> case, when master failover, it assigned all RIT regions, but some are failed
> to open(due to HBASE-17264), AssignmentManager received the zk event, and
> skip to assign it(this region was opened on a failed server before and
> already in RIT before master failover). The SSH also skip to assign it
> because it was RIT on another RS.
> Master recevied a zk event of RS_ZK_REGION_FAILED_OPEN and begin to handle it:
> {noformat}
> 2016-11-23 17:11:46,944 DEBUG [AM.ZK.Worker-pool2-t1]
> master.AssignmentManager: Handling RS_ZK_REGION_FAILED_OPEN,
> server=example.org,30003,1479780976834,
> region=57513956a7b671f4e8da1598c2e2970e,
> current_state={57513956a7b671f4e8da1598c2e2970e state=PENDING_OPEN,
> ts=1479892306843, server=example.org,30003,1479780976834}
> 2016-11-23 17:11:46,944 INFO [AM.ZK.Worker-pool2-t1] master.RegionStates:
> Transition {57513956a7b671f4e8da1598c2e2970e state=PENDING_OPEN,
> ts=1479892306843, server=example.org,30003,1479780976834} to
> {57513956a7b671f4e8da1598c2e2970e state=CLOSED, ts=1479892306944,
> server=example.org,30003,1479780976834}
> 2016-11-23 17:11:46,945 WARN [AM.ZK.Worker-pool2-t1] master.RegionStates:
> 57513956a7b671f4e8da1598c2e2970e moved to CLOSED on
> example.org,30003,1479780976834, expected example.org,30003,1475893095003
> 2016-11-23 17:11:46,950 DEBUG [AM.ZK.Worker-pool2-t1]
> master.AssignmentManager: Found an existing plan for
> test,QFO7M,1475986053104.57513956a7b671f4e8da1598c2e2970e. destination server
> is example.org,30003,1479780976834 accepted as a dest server = false
> 2016-11-23 17:11:47,012 DEBUG [AM.ZK.Worker-pool2-t1]
> master.AssignmentManager: No previous transition plan found (or ignoring an
> existing plan) for
> test,QFO7M,1475986053104.57513956a7b671f4e8da1598c2e2970e.; generated random
> plan=hri=test,QFO7M,1475986053104.57513956a7b671f4e8da1598c2e2970e., src=,
> dest=11.239.21.235,30003,1479781410131; 2 (online=3) available servers,
> forceNewPlan=true
> 2016-11-23 17:11:47,014 DEBUG [AM.ZK.Worker-pool2-t1]
> handler.ClosedRegionHandler: Handling CLOSED event for
> 57513956a7b671f4e8da1598c2e2970e
> 2016-11-23 17:11:47,015 WARN [AM.ZK.Worker-pool2-t1] master.RegionStates:
> 57513956a7b671f4e8da1598c2e2970e moved to CLOSED on
> example.org,30003,1479780976834, expected example.org,30003,1475893095003
> {noformat}
> AssignmentManager skip to assign it because the region was on a failed server
> {noformat}
> 2016-11-23 17:11:47,017 INFO [AM.ZK.Worker-pool2-t1]
> master.AssignmentManager: Skip assigning
> test,QFO7M,1475986053104.57513956a7b671f4e8da1598c2e2970e., it's host
> example.org,30003,1475893095003 is dead but not processed yet
> {noformat}
> SSH also skip it because it was RIT on another server
> {noformat}
> 2016-11-23 17:12:17,850 INFO [MASTER_SERVER_OPERATIONS-example.org:30001-0]
> master.RegionStates: Transitioning {57513956a7b671f4e8da1598c2e2970e
> state=CLOSED, ts=1479892307015, server=example.org,30003,1479780976834} will
> be handled by SSH for example.org,30003,1475893095003
> 2016-11-23 17:12:17,910 INFO [MASTER_SERVER_OPERATIONS-example.org:30001-0]
> handler.ServerShutdownHandler: Skip assigning region in transition on other
> server{57513956a7b671f4e8da1598c2e2970e state=CLOSED, ts=1479892307015,
> server=example.org,30003,1479780976834}
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-23693) Split failure may cause region hole and data loss when use zk assign
[
https://issues.apache.org/jira/browse/HBASE-23693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
tianhang tang updated HBASE-23693:
--
Summary: Split failure may cause region hole and data loss when use zk
assign (was: Split failure may cause region hole and data loss)
> Split failure may cause region hole and data loss when use zk assign
>
>
> Key: HBASE-23693
> URL: https://issues.apache.org/jira/browse/HBASE-23693
> Project: HBase
> Issue Type: Bug
> Components: master
>Affects Versions: 1.4.8
>Reporter: tianhang tang
>Priority: Critical
>
> to mock this case, I add a sleep code in SplitTransactionImpl.excute after
> the PONR and before openDaughters:
> {code:java}
> public PairOfSameType execute(final Server server,
> final RegionServerServices services, User user) throws IOException {
> this.server = server;
> this.rsServices = services;
> useZKForAssignment = server == null ? true :
> ConfigUtil.useZKForAssignment(server.getConfiguration());
> if (useCoordinatedStateManager(server)) {
> std =
> ((BaseCoordinatedStateManager) server.getCoordinatedStateManager())
> .getSplitTransactionCoordination().getDefaultDetails();
> }
> PairOfSameType regions = createDaughters(server, services, user);
> if (this.parent.getCoprocessorHost() != null) {
> if (user == null) {
> parent.getCoprocessorHost().preSplitAfterPONR();
> } else {
> try {
> user.getUGI().doAs(new PrivilegedExceptionAction() {
> @Override
> public Void run() throws Exception {
> parent.getCoprocessorHost().preSplitAfterPONR();
> return null;
> }
> });
> } catch (InterruptedException ie) {
> InterruptedIOException iioe = new InterruptedIOException();
> iioe.initCause(ie);
> throw iioe;
> }
> }
> }
>
> //sleep here!!!
> try {
> Thread.sleep(1000 * 60 * 60);
> } catch (InterruptedException e) {
> e.printStackTrace();
> }
> regions = stepsAfterPONR(server, services, regions, user);
> transition(SplitTransactionPhase.COMPLETED);
> return regions;
> }
> {code}
> so the split transaction will hang.
> then i try to reproduce this problem:
> 1.Create a test table and move it into a test rsgroup, there is only 1 RS in
> the test group
> 2.Trigger a region split
> 3.The split transaction step after the PONR and sleep, regioninfo in meta has
> been updated
> 4.Kill the RS process to mock machine crash
> 5.ServerCrashProcedure cleanup SPLITING_NEW region, the daughter regions will
> be deleted
> 6.ServerCrashProcedure try to assign the parent region, because RS is down
> and assign fails, the region status is set to FAILED_OPEN and put back into
> regionsInTransition. But at this time, due to RS crash, the node of the
> region under ZK region-in-transition no longer exist
> 7.CatalogJanitor thread is blocked due to RIT
> 8.Switch active master
> 9.The CatalogJanitor thread on the new master executes normally and the
> parent region is cleaned up because split = true && offline = true in the
> meta table
> 10.We have a hole in the test table and loss data.
>
> I modified the code when ServerCrashProcedure cleans up the child regions, it
> will update the parent regioninfo in the meta table, and this problem is no
> longer reproduced.
> I will upload the patch later.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23702) `hbase.hstore.flusher.count` setting to 0 breaks HMaster
[
https://issues.apache.org/jira/browse/HBASE-23702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17017661#comment-17017661
]
HBase QA commented on HBASE-23702:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 2m
8s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m
10s{color} | {color:blue} The patch file was not named according to hbase's
naming conventions. Please see
https://yetus.apache.org/documentation/in-progress/precommit-patchnames for
instructions. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
26s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
54s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
18s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
35s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
34s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 4m
33s{color} | {color:blue} Used deprecated FindBugs config; considering
switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
32s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
54s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
18s{color} | {color:red} hbase-server: The patch generated 3 new + 21 unchanged
- 0 fixed = 24 total (was 21) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch 4 line(s) with tabs. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
34s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
15m 31s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
44s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}157m 29s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
33s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}215m 54s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.master.assignment.TestRegionMoveAndAbandon |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.5 Server=19.03.5 base:
https://builds.apache.org/job/PreCommit-HBASE-Build/1088/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-23702 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12991179/hbase-src-patch.txt |
| Optional Tests | dupname asflice
[GitHub] [hbase] binlijin commented on a change in pull request #1026: HBASE-23682 Fix NPE when disable DeadServerMetricRegionChore
binlijin commented on a change in pull request #1026: HBASE-23682 Fix NPE when
disable DeadServerMetricRegionChore
URL: https://github.com/apache/hbase/pull/1026#discussion_r367736199
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestDeadServerMetricRegionChore.java
##
@@ -0,0 +1,68 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.master.assignment;
+
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.HBaseTestingUtility;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.testclassification.MasterTests;
+import org.apache.hadoop.hbase.testclassification.MediumTests;
+import org.junit.After;
+import org.junit.Before;
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+
+/**
+ * Testcase for HBASE-23682.
+ */
+@Category({ MasterTests.class, MediumTests.class })
+public class TestDeadServerMetricRegionChore {
+
+ @ClassRule
+ public static final HBaseClassTestRule CLASS_RULE =
+HBaseClassTestRule.forClass(TestDeadServerMetricRegionChore.class);
+
+ protected HBaseTestingUtility util;
+
+ @Before
+ public void setUp() throws Exception {
+util = new HBaseTestingUtility();
+// Disable DeadServerMetricRegionChore
+util.getConfiguration()
+
.setInt(AssignmentManager.DEAD_REGION_METRIC_CHORE_INTERVAL_MSEC_CONF_KEY, -1);
+ }
+
+ @After
+ public void tearDown() throws Exception {
+ }
+
+ @Test
+ public void testDeadServerMetricRegionChore() throws Exception {
+try {
+ this.util.startMiniCluster();
Review comment:
Ok, fix it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Updated] (HBASE-23702) `hbase.hstore.flusher.count` setting to 0 breaks HMaster
[ https://issues.apache.org/jira/browse/HBASE-23702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ctest updated HBASE-23702: -- Description: Summary The configuration parameter `hbase.hstore.flusher.count` allows `0` (which turns out to be a bad value after I understand the source code). When we set `hbase.hstore.flusher.count` to 0, HMaster will fail in 200,000 ms without any error message, but ``` java.lang.RuntimeException: Master not initialized after 20ms ``` There’s no messages pinpointing `hbase.hstore.flusher.count` being the root cause. 0 means `MemStoreFlusher` is not alive. During the initialization time of HMaster, `isHealthy()` will be called and it will try to check if `MemStoreFlusher` is alive or not. However, since we set `hbase.hstore.flusher.count` to 0, there will be no flusher created at the first place, which cause`isHealthy()` to return false. As a consequence, HRegionServer does not enter its main loop. *How To Reproduce* The version of HBase: 2.2.3 # Set the value of configuration parameter `hbase.hstore.flusher.count` to `0` in “conf/hbase-site.xml” # Start hbase by running “bin/start-hbase.sh” # Wait for 3-4 minutes # Open the log file “logs/hbase-- master -.log” was: *Summary* The configuration parameter `hbase.hstore.flusher.count` allows `0` (which turns out to be a bad value after I understand the source code). When we set `hbase.hstore.flusher.count` to 0, HMaster will fail in 200,000 ms without any error message, but ``` java.lang.RuntimeException: Master not initialized after 20ms ``` There’s no messages pinpointing `hbase.hstore.flusher.count` being the root cause. 0 means `MemStoreFlusher` is not alive. During the initialization time of HMaster, `isHealthy()` will be called and it will try to check if `MemStoreFlusher` is alive or not. However, since we set `hbase.hstore.flusher.count` to 0, there will be no flusher created at the first place, which cause`isHealthy()` to return false. As a consequence, HRegionServer does not enter its main loop. *How To Reproduce* The version of HBase: 2.2.3 # Set the value of configuration parameter `hbase.hstore.flusher.count` to `0` in “conf/hbase-site.xml” # Start hbase by running “bin/start-hbase.sh” # Wait for 3-4 minutes # Open the log file “logs/hbase--master-.log” > `hbase.hstore.flusher.count` setting to 0 breaks HMaster > > > Key: HBASE-23702 > URL: https://issues.apache.org/jira/browse/HBASE-23702 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 2.2.3 > Environment: HBase-2.2.3 > Java openjdk 1.8.0_222 > Ubuntu 18.04 >Reporter: Ctest >Priority: Major > Attachments: hbase-src-patch.txt > > > Summary > The configuration parameter `hbase.hstore.flusher.count` allows `0` (which > turns out to be a bad value after I understand the source code). > When we set `hbase.hstore.flusher.count` to 0, HMaster will fail in 200,000 > ms without any error message, but > ``` > java.lang.RuntimeException: Master not initialized after 20ms > ``` > > There’s no messages pinpointing `hbase.hstore.flusher.count` being the root > cause. > > 0 means `MemStoreFlusher` is not alive. During the initialization time of > HMaster, `isHealthy()` will be called and it will try to check if > `MemStoreFlusher` is alive or not. However, since we set > `hbase.hstore.flusher.count` to 0, there will be no flusher created at the > first place, which cause`isHealthy()` to return false. As a consequence, > HRegionServer does not enter its main loop. > > *How To Reproduce* > > The version of HBase: 2.2.3 > > # Set the value of configuration parameter `hbase.hstore.flusher.count` to > `0` in “conf/hbase-site.xml” > # Start hbase by running “bin/start-hbase.sh” > # Wait for 3-4 minutes > # Open the log file “logs/hbase-- master -.log” -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23702) `hbase.hstore.flusher.count` setting to 0 breaks HMaster
[ https://issues.apache.org/jira/browse/HBASE-23702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ctest updated HBASE-23702: -- Description: *Summary* The configuration parameter `hbase.hstore.flusher.count` allows `0` (which turns out to be a bad value after I understand the source code). When we set `hbase.hstore.flusher.count` to 0, HMaster will fail in 200,000 ms without any error message, but ``` java.lang.RuntimeException: Master not initialized after 20ms ``` There’s no messages pinpointing `hbase.hstore.flusher.count` being the root cause. 0 means `MemStoreFlusher` is not alive. During the initialization time of HMaster, `isHealthy()` will be called and it will try to check if `MemStoreFlusher` is alive or not. However, since we set `hbase.hstore.flusher.count` to 0, there will be no flusher created at the first place, which cause`isHealthy()` to return false. As a consequence, HRegionServer does not enter its main loop. *How To Reproduce* The version of HBase: 2.2.3 # Set the value of configuration parameter `hbase.hstore.flusher.count` to `0` in “conf/hbase-site.xml” # Start hbase by running “bin/start-hbase.sh” # Wait for 3-4 minutes # Open the log file “logs/hbase--master-.log” was: *Summary* The configuration parameter `hbase.hstore.flusher.count` allows `0` (which turns out to be a bad value after I understand the source code). When we set `hbase.hstore.flusher.count` to 0, HMaster will fail in 200,000 ms without any error message, but ``` java.lang.RuntimeException: Master not initialized after 20ms ``` There’s no messages pinpointing `hbase.hstore.flusher.count` being the root cause. 0 means `MemStoreFlusher` is not alive. During the initialization time of HMaster, `isHealthy()` will be called and it will try to check if `MemStoreFlusher` is alive or not. However, since we set `hbase.hstore.flusher.count` to 0, there will be no flusher created at the first place, which cause`isHealthy()` to return false. As a consequence, HRegionServer does not enter its main loop. *How To Reproduce* The version of Hadoop: 2.2.3 # Set the value of configuration parameter `hbase.hstore.flusher.count` to `0` in “conf/hbase-site.xml” # Start hbase by running “bin/start-hbase.sh” # Wait for 3-4 minutes # Open the log file “logs/hbase--master-.log” > `hbase.hstore.flusher.count` setting to 0 breaks HMaster > > > Key: HBASE-23702 > URL: https://issues.apache.org/jira/browse/HBASE-23702 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 2.2.3 > Environment: HBase-2.2.3 > Java openjdk 1.8.0_222 > Ubuntu 18.04 >Reporter: Ctest >Priority: Major > Attachments: hbase-src-patch.txt > > > *Summary* > The configuration parameter `hbase.hstore.flusher.count` allows `0` (which > turns out to be a bad value after I understand the source code). > When we set `hbase.hstore.flusher.count` to 0, HMaster will fail in 200,000 > ms without any error message, but > ``` > java.lang.RuntimeException: Master not initialized after 20ms > ``` > > There’s no messages pinpointing `hbase.hstore.flusher.count` being the root > cause. > > 0 means `MemStoreFlusher` is not alive. During the initialization time of > HMaster, `isHealthy()` will be called and it will try to check if > `MemStoreFlusher` is alive or not. However, since we set > `hbase.hstore.flusher.count` to 0, there will be no flusher created at the > first place, which cause`isHealthy()` to return false. As a consequence, > HRegionServer does not enter its main loop. > > *How To Reproduce* > > The version of HBase: 2.2.3 > > # Set the value of configuration parameter `hbase.hstore.flusher.count` to > `0` in “conf/hbase-site.xml” > # Start hbase by running “bin/start-hbase.sh” > # Wait for 3-4 minutes > # Open the log file “logs/hbase--master-.log” -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23674) Too many rit page Numbers show confusion
[
https://issues.apache.org/jira/browse/HBASE-23674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17017601#comment-17017601
]
Hudson commented on HBASE-23674:
Results for branch branch-2.2
[build #756 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/756/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/756//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/756//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/756//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Too many rit page Numbers show confusion
>
>
> Key: HBASE-23674
> URL: https://issues.apache.org/jira/browse/HBASE-23674
> Project: HBase
> Issue Type: Improvement
> Components: master
>Affects Versions: 3.0.0
>Reporter: dingbaosheng
>Assignee: dingbaosheng
>Priority: Trivial
> Fix For: 3.0.0, 2.3.0, 2.2.4
>
> Attachments: HBASE-23674.master.0001.patch,
> HBASE-23674.master.0002.patch, HBASE-23674.master.0003.patch, Screen Shot
> 2020-01-14 at 11.01.34 AM.png, rit_2.png, rit_page.jpg, rit_too_many.jpg
>
>
> Too much rits can cause page rendering clutter, which can be resolved by
> adding pagers.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23695) Fail more gracefully when test class is missing Category
[
https://issues.apache.org/jira/browse/HBASE-23695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17017603#comment-17017603
]
Hudson commented on HBASE-23695:
Results for branch branch-2.2
[build #756 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/756/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/756//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/756//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/756//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Fail more gracefully when test class is missing Category
>
>
> Key: HBASE-23695
> URL: https://issues.apache.org/jira/browse/HBASE-23695
> Project: HBase
> Issue Type: Bug
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.2.3, 2.1.9
>
>
> When a test class is missing a category, you might see an error such as:
> {noformat}
> [ERROR] Test mechanism Time elapsed: 0.305 s <<< ERROR!
> java.lang.ArrayIndexOutOfBoundsException: 0[ERROR] Test mechanism Time
> elapsed: 0.102 s <<< ERROR!
> java.lang.ArrayIndexOutOfBoundsException: 0[ERROR] Test mechanism Time
> elapsed: 0.103 s <<< ERROR!
> java.lang.ArrayIndexOutOfBoundsException: 0[ERROR] Test mechanism Time
> elapsed: 0.102 s <<< ERROR!
> java.lang.ArrayIndexOutOfBoundsException: 0[ERROR] Test mechanism Time
> elapsed: 0.098 s <<< ERROR!
> java.lang.ArrayIndexOutOfBoundsException: 0[ERROR] Test mechanism :: 0
> {noformat}
> You have to dig into the dump file to find out the actual error was:
> {noformat}
> org.apache.maven.surefire.testset.TestSetFailedException: Test mechanism :: 0
> at
> org.apache.maven.surefire.common.junit4.JUnit4RunListener.rethrowAnyTestMechanismFailures(JUnit4RunListener.java:192)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:167)
> at
> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:377)
> at
> org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:138)
> at
> org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:465)
> at
> org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:451)
> Caused by: java.lang.ArrayIndexOutOfBoundsException: 0
> at
> org.apache.hadoop.hbase.HBaseClassTestRuleChecker.testStarted(HBaseClassTestRuleChecker.java:44)
> at
> org.junit.runner.notification.RunNotifier$5.notifyListener(RunNotifier.java:156)
> at
> org.junit.runner.notification.RunNotifier$SafeNotifier.run(RunNotifier.java:72)
> at
> org.junit.runner.notification.RunNotifier.fireTestStarted(RunNotifier.java:153)
> at
> org.apache.maven.surefire.common.junit4.Notifier.fireTestStarted(Notifier.java:100)
> at
> org.junit.internal.runners.model.EachTestNotifier.fireTestStarted(EachTestNotifier.java:42)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:364)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
> at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
> at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
> at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)
> ... 4 more {noformat}
> We can fix this up to get a proper exception thr
[jira] [Commented] (HBASE-23677) region.jsp returns 500/NPE when provided encoded region name is not online
[
https://issues.apache.org/jira/browse/HBASE-23677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17017602#comment-17017602
]
Hudson commented on HBASE-23677:
Results for branch branch-2.2
[build #756 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/756/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/756//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/756//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/756//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> region.jsp returns 500/NPE when provided encoded region name is not online
> --
>
> Key: HBASE-23677
> URL: https://issues.apache.org/jira/browse/HBASE-23677
> Project: HBase
> Issue Type: Bug
> Components: regionserver, UI
>Affects Versions: 2.2.3
>Reporter: Nick Dimiduk
>Assignee: wenfeiyi666
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.2.4
>
>
> Noticed while testing for HBASE-23653. A link off to a region that is closed
> or otherwise not in the region server's online region map results in a 500.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1051: HBASE-23665: Split unit tests from TestTableName into a separate test…
Apache-HBase commented on issue #1051: HBASE-23665: Split unit tests from TestTableName into a separate test… URL: https://github.com/apache/hbase/pull/1051#issuecomment-575412531 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 10 new or modified test files. | ||| _ branch-1 Compile Tests _ | | +0 :ok: | mvndep | 1m 20s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 7m 30s | branch-1 passed | | +1 :green_heart: | compile | 0m 59s | branch-1 passed with JDK v1.8.0_232 | | +1 :green_heart: | compile | 1m 14s | branch-1 passed with JDK v1.7.0_242 | | +1 :green_heart: | checkstyle | 2m 8s | branch-1 passed | | +1 :green_heart: | shadedjars | 3m 10s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 54s | branch-1 passed with JDK v1.8.0_232 | | +1 :green_heart: | javadoc | 1m 3s | branch-1 passed with JDK v1.7.0_242 | | +0 :ok: | spotbugs | 2m 36s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 3m 43s | branch-1 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 1m 57s | the patch passed | | +1 :green_heart: | compile | 0m 58s | the patch passed with JDK v1.8.0_232 | | +1 :green_heart: | javac | 0m 58s | the patch passed | | +1 :green_heart: | compile | 1m 10s | the patch passed with JDK v1.7.0_242 | | +1 :green_heart: | javac | 1m 10s | the patch passed | | +1 :green_heart: | checkstyle | 0m 28s | The patch passed checkstyle in hbase-common | | +1 :green_heart: | checkstyle | 1m 32s | hbase-server: The patch generated 0 new + 12 unchanged - 23 fixed = 12 total (was 35) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 2m 52s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 4m 51s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. | | +1 :green_heart: | javadoc | 0m 50s | the patch passed with JDK v1.8.0_232 | | +1 :green_heart: | javadoc | 1m 4s | the patch passed with JDK v1.7.0_242 | | +1 :green_heart: | findbugs | 4m 0s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 38s | hbase-common in the patch passed. | | -1 :x: | unit | 125m 35s | hbase-server in the patch failed. | | +1 :green_heart: | asflicense | 0m 57s | The patch does not generate ASF License warnings. | | | | 176m 12s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestAdmin1 | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1051/5/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1051 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux d6357fdebfe1 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1051/out/precommit/personality/provided.sh | | git revision | branch-1 / 99a328f | | Default Java | 1.7.0_242 | | Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_232 /usr/lib/jvm/zulu-7-amd64:1.7.0_242 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1051/5/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1051/5/testReport/ | | Max. process+thread count | 4204 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1051/5/console | | versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. --
[GitHub] [hbase] Apache-HBase commented on issue #1056: HBASE-23700 Upgrade checkstyle and plugin versions
Apache-HBase commented on issue #1056: HBASE-23700 Upgrade checkstyle and plugin versions URL: https://github.com/apache/hbase/pull/1056#issuecomment-575391167 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 45s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 47s | master passed | | +1 :green_heart: | compile | 3m 18s | master passed | | +1 :green_heart: | checkstyle | 2m 59s | master passed | | +1 :green_heart: | shadedjars | 4m 59s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 3s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 21s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 23s | the patch passed | | +1 :green_heart: | compile | 3m 18s | the patch passed | | +1 :green_heart: | javac | 3m 18s | the patch passed | | +1 :green_heart: | checkstyle | 2m 30s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 4s | The patch has no ill-formed XML file. | | +1 :green_heart: | shadedjars | 4m 59s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 17m 4s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | javadoc | 3m 0s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 187m 59s | root in the patch failed. | | +1 :green_heart: | asflicense | 0m 50s | The patch does not generate ASF License warnings. | | | | 253m 38s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.replication.TestAddToSerialReplicationPeer | | | hadoop.hbase.master.assignment.TestRegionMoveAndAbandon | | | hadoop.hbase.master.TestMasterNoCluster | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1056/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1056 | | Optional Tests | dupname asflicense checkstyle javac javadoc unit xml shadedjars hadoopcheck compile | | uname | Linux c5e406ce0ea9 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1056/out/precommit/personality/provided.sh | | git revision | master / 00fc46756a | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1056/1/artifact/out/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1056/1/testReport/ | | Max. process+thread count | 5076 (vs. ulimit of 1) | | modules | C: hbase-checkstyle . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1056/1/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-23702) `hbase.hstore.flusher.count` setting to 0 breaks HMaster
[ https://issues.apache.org/jira/browse/HBASE-23702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ctest updated HBASE-23702: -- Attachment: hbase-src-patch.txt Status: Patch Available (was: Open) > `hbase.hstore.flusher.count` setting to 0 breaks HMaster > > > Key: HBASE-23702 > URL: https://issues.apache.org/jira/browse/HBASE-23702 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 2.2.3 > Environment: HBase-2.2.3 > Java openjdk 1.8.0_222 > Ubuntu 18.04 >Reporter: Ctest >Priority: Major > Attachments: hbase-src-patch.txt > > > *Summary* > The configuration parameter `hbase.hstore.flusher.count` allows `0` (which > turns out to be a bad value after I understand the source code). > When we set `hbase.hstore.flusher.count` to 0, HMaster will fail in 200,000 > ms without any error message, but > ``` > java.lang.RuntimeException: Master not initialized after 20ms > ``` > > There’s no messages pinpointing `hbase.hstore.flusher.count` being the root > cause. > > 0 means `MemStoreFlusher` is not alive. During the initialization time of > HMaster, `isHealthy()` will be called and it will try to check if > `MemStoreFlusher` is alive or not. However, since we set > `hbase.hstore.flusher.count` to 0, there will be no flusher created at the > first place, which cause`isHealthy()` to return false. As a consequence, > HRegionServer does not enter its main loop. > > *How To Reproduce* > > The version of Hadoop: 2.2.3 > > # Set the value of configuration parameter `hbase.hstore.flusher.count` to > `0` in “conf/hbase-site.xml” > # Start hbase by running “bin/start-hbase.sh” > # Wait for 3-4 minutes > # Open the log file “logs/hbase--master-.log” -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-23702) `hbase.hstore.flusher.count` setting to 0 breaks HMaster
Ctest created HBASE-23702: - Summary: `hbase.hstore.flusher.count` setting to 0 breaks HMaster Key: HBASE-23702 URL: https://issues.apache.org/jira/browse/HBASE-23702 Project: HBase Issue Type: Bug Components: regionserver Affects Versions: 2.2.3 Environment: HBase-2.2.3 Java openjdk 1.8.0_222 Ubuntu 18.04 Reporter: Ctest *Summary* The configuration parameter `hbase.hstore.flusher.count` allows `0` (which turns out to be a bad value after I understand the source code). When we set `hbase.hstore.flusher.count` to 0, HMaster will fail in 200,000 ms without any error message, but ``` java.lang.RuntimeException: Master not initialized after 20ms ``` There’s no messages pinpointing `hbase.hstore.flusher.count` being the root cause. 0 means `MemStoreFlusher` is not alive. During the initialization time of HMaster, `isHealthy()` will be called and it will try to check if `MemStoreFlusher` is alive or not. However, since we set `hbase.hstore.flusher.count` to 0, there will be no flusher created at the first place, which cause`isHealthy()` to return false. As a consequence, HRegionServer does not enter its main loop. *How To Reproduce* The version of Hadoop: 2.2.3 # Set the value of configuration parameter `hbase.hstore.flusher.count` to `0` in “conf/hbase-site.xml” # Start hbase by running “bin/start-hbase.sh” # Wait for 3-4 minutes # Open the log file “logs/hbase--master-.log” -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] bharathv commented on a change in pull request #1057: HBASE-23701 Try to converge automated checks around Category
bharathv commented on a change in pull request #1057: HBASE-23701 Try to
converge automated checks around Category
URL: https://github.com/apache/hbase/pull/1057#discussion_r367665168
##
File path:
hbase-common/src/test/java/org/apache/hadoop/hbase/HBaseClassTestRule.java
##
@@ -59,13 +59,20 @@ private HBaseClassTestRule(Class clazz, Timeout
timeout) {
private static long getTimeoutInSeconds(Class clazz) {
Category[] categories = clazz.getAnnotationsByType(Category.class);
-for (Class c : categories[0].value()) {
- if (c == SmallTests.class || c == MediumTests.class || c ==
LargeTests.class) {
-// All tests have a 13 minutes timeout.
-return TimeUnit.MINUTES.toSeconds(13);
- }
- if (c == IntegrationTests.class) {
-return TimeUnit.MINUTES.toSeconds(Long.MAX_VALUE);
+// This should never happen
+if (categories.length > 1) {
+ throw new IllegalArgumentException("Code-bug: unsure how to handle more
than one Category");
Review comment:
It appears that Category is not a repeatable annotation [1]. There are
compile time checks for this. I think the whole block of code can be
simplified to something like.
```
Preconditions.checkArgument(categories.length == 1, "Invalid number of
categories found for class " + clazz + " Required 1: found: " +
categories.length. Include one of ...");
for (Class c : categories[0].value()) {
if (c == SmallTests.class || c == MediumTests.class || c ==
LargeTests.class) {
// All tests have a 13 minutes timeout.
return TimeUnit.MINUTES.toSeconds(13);
}
if (c == IntegrationTests.class) {
return TimeUnit.MINUTES.toSeconds(Long.MAX_VALUE);
}
}
}
```
[1] https://docs.oracle.com/javase/tutorial/java/annotations/repeating.html
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #1057: HBASE-23701 Try to converge automated checks around Category
bharathv commented on a change in pull request #1057: HBASE-23701 Try to
converge automated checks around Category
URL: https://github.com/apache/hbase/pull/1057#discussion_r367665777
##
File path:
hbase-common/src/test/java/org/apache/hadoop/hbase/HBaseClassTestRuleChecker.java
##
@@ -41,8 +41,12 @@
@Override
public void testStarted(Description description) throws Exception {
Category[] categories =
description.getTestClass().getAnnotationsByType(Category.class);
+// This should never happen
+if (categories.length > 1) {
+ throw new IllegalArgumentException("Code-bug: unsure how to handle more
than one Category");
Review comment:
same.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1057: HBASE-23701 Try to converge automated checks around Category
Apache-HBase commented on issue #1057: HBASE-23701 Try to converge automated checks around Category URL: https://github.com/apache/hbase/pull/1057#issuecomment-575367200 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 59s | master passed | | +1 :green_heart: | compile | 0m 24s | master passed | | +1 :green_heart: | checkstyle | 0m 27s | master passed | | +1 :green_heart: | shadedjars | 4m 36s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 24s | master passed | | +0 :ok: | spotbugs | 0m 51s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 0m 48s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 52s | the patch passed | | +1 :green_heart: | compile | 0m 24s | the patch passed | | +1 :green_heart: | javac | 0m 24s | the patch passed | | +1 :green_heart: | checkstyle | 0m 25s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 4m 34s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 15m 40s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | javadoc | 0m 23s | the patch passed | | +1 :green_heart: | findbugs | 0m 53s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 3m 18s | hbase-common in the patch passed. | | +1 :green_heart: | asflicense | 0m 14s | The patch does not generate ASF License warnings. | | | | 50m 20s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1057/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1057 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux f7dc3d12620c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1057/out/precommit/personality/provided.sh | | git revision | master / 00fc46756a | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1057/1/testReport/ | | Max. process+thread count | 284 (vs. ulimit of 1) | | modules | C: hbase-common U: hbase-common | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1057/1/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-18095) Provide an option for clients to find the server hosting META that does not involve the ZooKeeper client
[
https://issues.apache.org/jira/browse/HBASE-18095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17017516#comment-17017516
]
Hudson commented on HBASE-18095:
Results for branch HBASE-18095/client-locate-meta-no-zookeeper
[build #41 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-18095%252Fclient-locate-meta-no-zookeeper/41/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-18095%252Fclient-locate-meta-no-zookeeper/41//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-18095%252Fclient-locate-meta-no-zookeeper/41//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-18095%252Fclient-locate-meta-no-zookeeper/41//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Provide an option for clients to find the server hosting META that does not
> involve the ZooKeeper client
>
>
> Key: HBASE-18095
> URL: https://issues.apache.org/jira/browse/HBASE-18095
> Project: HBase
> Issue Type: New Feature
> Components: Client
>Reporter: Andrew Kyle Purtell
>Assignee: Bharath Vissapragada
>Priority: Major
> Attachments: HBASE-18095.master-v1.patch, HBASE-18095.master-v2.patch
>
>
> Clients are required to connect to ZooKeeper to find the location of the
> regionserver hosting the meta table region. Site configuration provides the
> client a list of ZK quorum peers and the client uses an embedded ZK client to
> query meta location. Timeouts and retry behavior of this embedded ZK client
> are managed orthogonally to HBase layer settings and in some cases the ZK
> cannot manage what in theory the HBase client can, i.e. fail fast upon outage
> or network partition.
> We should consider new configuration settings that provide a list of
> well-known master and backup master locations, and with this information the
> client can contact any of the master processes directly. Any master in either
> active or passive state will track meta location and respond to requests for
> it with its cached last known location. If this location is stale, the client
> can ask again with a flag set that requests the master refresh its location
> cache and return the up-to-date location. Every client interaction with the
> cluster thus uses only HBase RPC as transport, with appropriate settings
> applied to the connection. The configuration toggle that enables this
> alternative meta location lookup should be false by default.
> This removes the requirement that HBase clients embed the ZK client and
> contact the ZK service directly at the beginning of the connection lifecycle.
> This has several benefits. ZK service need not be exposed to clients, and
> their potential abuse, yet no benefit ZK provides the HBase server cluster is
> compromised. Normalizing HBase client and ZK client timeout settings and
> retry behavior - in some cases, impossible, i.e. for fail-fast - is no longer
> necessary.
> And, from [~ghelmling]: There is an additional complication here for
> token-based authentication. When a delegation token is used for SASL
> authentication, the client uses the cluster ID obtained from Zookeeper to
> select the token identifier to use. So there would also need to be some
> Zookeeper-less, unauthenticated way to obtain the cluster ID as well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] bharathv commented on issue #1051: HBASE-23665: Split unit tests from TestTableName into a separate test…
bharathv commented on issue #1051: HBASE-23665: Split unit tests from TestTableName into a separate test… URL: https://github.com/apache/hbase/pull/1051#issuecomment-575359963 Fixed the check style nit and removed some dead code. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] joshelser opened a new pull request #1057: HBASE-23701 Try to converge automated checks around Category
joshelser opened a new pull request #1057: HBASE-23701 Try to converge automated checks around Category URL: https://github.com/apache/hbase/pull/1057 Best as I can tell, we will either have an array of zero length or length one for Category annotations. Make sure we fail with a good exception if either of those are not met. cc/ @bharathv This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23701) Make sure HBaseClassTestRule doesn't suffer same issue as HBaseClassTestRuleChecker
[ https://issues.apache.org/jira/browse/HBASE-23701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17017467#comment-17017467 ] Josh Elser commented on HBASE-23701: [~busbey] also asked a great question [https://github.com/apache/hbase/pull/1052#discussion_r367200547] about why are we only checking the first element of the Category annotation. I believe compile-time checks enforce that we will only ever see a one-element array of Category's for a class (certainly, given how we use it, that will be the case). Let me also fix both the Test Rule and the Test Rule Checker to fail if we get more than one to confirm that this is true, and prevent any surprises down the road. > Make sure HBaseClassTestRule doesn't suffer same issue as > HBaseClassTestRuleChecker > --- > > Key: HBASE-23701 > URL: https://issues.apache.org/jira/browse/HBASE-23701 > Project: HBase > Issue Type: Bug >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Minor > > [~bharathv] pointed out on HBASE-23695 > ([https://github.com/apache/hbase/pull/1052]) that HBaseClassTestRule suffers > the same potential bug that I fixed in HBASE-23695 for > HBaseClassTestRuleChecker. Make sure the fix is in both places. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] joshelser commented on a change in pull request #1052: HBASE-23695 Fail gracefully if no category is present
joshelser commented on a change in pull request #1052: HBASE-23695 Fail
gracefully if no category is present
URL: https://github.com/apache/hbase/pull/1052#discussion_r367639392
##
File path:
hbase-common/src/test/java/org/apache/hadoop/hbase/HBaseClassTestRuleChecker.java
##
@@ -41,9 +41,12 @@
@Override
public void testStarted(Description description) throws Exception {
Category[] categories =
description.getTestClass().getAnnotationsByType(Category.class);
-for (Class c : categories[0].value()) {
- if (c == IntegrationTests.class) {
-return;
+// Don't fail if there is a missing category
+if (categories.length > 0) {
+ for (Class c : categories[0].value()) {
Review comment:
The `@Category` annotation is not `Repeatable` so we can only have a single
one. Its value is `Class[]`, so we can't provide anything else, e.g. an
array of class[] is disallowed. I think this is OK, but will add an explicit
check on this :)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Created] (HBASE-23701) Make sure HBaseClassTestRule doesn't suffer same issue as HBaseClassTestRuleChecker
Josh Elser created HBASE-23701: -- Summary: Make sure HBaseClassTestRule doesn't suffer same issue as HBaseClassTestRuleChecker Key: HBASE-23701 URL: https://issues.apache.org/jira/browse/HBASE-23701 Project: HBase Issue Type: Bug Reporter: Josh Elser Assignee: Josh Elser [~bharathv] pointed out on HBASE-23695 ([https://github.com/apache/hbase/pull/1052]) that HBaseClassTestRule suffers the same potential bug that I fixed in HBASE-23695 for HBaseClassTestRuleChecker. Make sure the fix is in both places. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1051: HBASE-23665: Split unit tests from TestTableName into a separate test…
Apache-HBase commented on issue #1051: HBASE-23665: Split unit tests from TestTableName into a separate test… URL: https://github.com/apache/hbase/pull/1051#issuecomment-575328062 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 10 new or modified test files. | ||| _ branch-1 Compile Tests _ | | +0 :ok: | mvndep | 1m 24s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 8m 10s | branch-1 passed | | +1 :green_heart: | compile | 0m 59s | branch-1 passed with JDK v1.8.0_232 | | +1 :green_heart: | compile | 1m 7s | branch-1 passed with JDK v1.7.0_242 | | +1 :green_heart: | checkstyle | 2m 4s | branch-1 passed | | +1 :green_heart: | shadedjars | 2m 58s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 55s | branch-1 passed with JDK v1.8.0_232 | | +1 :green_heart: | javadoc | 1m 5s | branch-1 passed with JDK v1.7.0_242 | | +0 :ok: | spotbugs | 2m 42s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 3m 51s | branch-1 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 1m 58s | the patch passed | | +1 :green_heart: | compile | 1m 0s | the patch passed with JDK v1.8.0_232 | | +1 :green_heart: | javac | 1m 0s | the patch passed | | +1 :green_heart: | compile | 1m 9s | the patch passed with JDK v1.7.0_242 | | +1 :green_heart: | javac | 1m 9s | the patch passed | | -1 :x: | checkstyle | 1m 30s | hbase-server: The patch generated 1 new + 12 unchanged - 23 fixed = 13 total (was 35) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 2m 49s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 5m 9s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. | | +1 :green_heart: | javadoc | 0m 49s | the patch passed with JDK v1.8.0_232 | | +1 :green_heart: | javadoc | 1m 4s | the patch passed with JDK v1.7.0_242 | | +1 :green_heart: | findbugs | 4m 5s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 39s | hbase-common in the patch passed. | | +1 :green_heart: | unit | 125m 45s | hbase-server in the patch passed. | | +1 :green_heart: | asflicense | 0m 58s | The patch does not generate ASF License warnings. | | | | 176m 58s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1051/4/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1051 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 38ad2e06d5be 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1051/out/precommit/personality/provided.sh | | git revision | branch-1 / 99a328f | | Default Java | 1.7.0_242 | | Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_232 /usr/lib/jvm/zulu-7-amd64:1.7.0_242 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1051/4/artifact/out/diff-checkstyle-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1051/4/testReport/ | | Max. process+thread count | 4382 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1051/4/console | | versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about t
[GitHub] [hbase] Apache-HBase commented on issue #1022: HBASE-23680 RegionProcedureStore missing cleaning of hfile archive
Apache-HBase commented on issue #1022: HBASE-23680 RegionProcedureStore missing cleaning of hfile archive URL: https://github.com/apache/hbase/pull/1022#issuecomment-575314621 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 2s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 7 new or modified test files. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 33s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 41s | master passed | | +1 :green_heart: | compile | 1m 37s | master passed | | +1 :green_heart: | checkstyle | 2m 9s | master passed | | +0 :ok: | refguide | 6m 26s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | shadedjars | 4m 59s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 12s | master passed | | +0 :ok: | spotbugs | 4m 49s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 6m 9s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 28s | the patch passed | | +1 :green_heart: | compile | 1m 38s | the patch passed | | +1 :green_heart: | javac | 1m 38s | the patch passed | | +1 :green_heart: | checkstyle | 2m 7s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +0 :ok: | refguide | 6m 19s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | shadedjars | 5m 2s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 17m 8s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | javadoc | 1m 11s | the patch passed | | +1 :green_heart: | findbugs | 6m 34s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 3m 8s | hbase-common in the patch passed. | | +1 :green_heart: | unit | 3m 35s | hbase-procedure in the patch passed. | | +1 :green_heart: | unit | 155m 19s | hbase-server in the patch passed. | | +1 :green_heart: | asflicense | 1m 9s | The patch does not generate ASF License warnings. | | | | 246m 4s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1022/6/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1022 | | Optional Tests | dupname asflicense javac javadoc unit refguide xml spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 608fe92c9c22 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1022/out/precommit/personality/provided.sh | | git revision | master / edc53683c4 | | Default Java | 1.8.0_181 | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1022/6/artifact/out/branch-site/book.html | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1022/6/artifact/out/patch-site/book.html | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1022/6/testReport/ | | Max. process+thread count | 4602 (vs. ulimit of 1) | | modules | C: hbase-common hbase-procedure hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1022/6/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please cont
[GitHub] [hbase] joshelser commented on issue #1052: HBASE-23695 Fail gracefully if no category is present
joshelser commented on issue #1052: HBASE-23695 Fail gracefully if no category is present URL: https://github.com/apache/hbase/pull/1052#issuecomment-575302082 Awesomes, @bharathv ! I'll spin out a new Jira issue and mention you all there :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] ndimiduk commented on issue #1056: HBASE-23700 Upgrade checkstyle and plugin versions
ndimiduk commented on issue #1056: HBASE-23700 Upgrade checkstyle and plugin versions URL: https://github.com/apache/hbase/pull/1056#issuecomment-575295762 Note for reviewers: you'll need to run `mvn -pl hbase-checkstyle install -DskipTests` with this patch applied in order to make the updated configuration available to a subsequent invocation of `man checkstyle:check`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] ndimiduk opened a new pull request #1056: HBASE-23700 Upgrade checkstyle and plugin versions
ndimiduk opened a new pull request #1056: HBASE-23700 Upgrade checkstyle and plugin versions URL: https://github.com/apache/hbase/pull/1056 Bump checkstyle version to 8.28, maven-checkstyle-plugin to 3.1.0. As per HBASE-23242 and the updated checkstyle docs[1], the LineLength check should be placed under an instance of Checker. [1] https://checkstyle.sourceforge.io/config_sizes.html#LineLength This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-23700) Upgrade checkstyle and plugin versions
[ https://issues.apache.org/jira/browse/HBASE-23700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-23700: - Description: Our checkstyle version is pretty antiquated. Update it, and pull in the latest version of the maven plugin as well. > Upgrade checkstyle and plugin versions > -- > > Key: HBASE-23700 > URL: https://issues.apache.org/jira/browse/HBASE-23700 > Project: HBase > Issue Type: Task > Components: build >Reporter: Nick Dimiduk >Priority: Minor > > Our checkstyle version is pretty antiquated. Update it, and pull in the > latest version of the maven plugin as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23700) Upgrade checkstyle and plugin versions
[ https://issues.apache.org/jira/browse/HBASE-23700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-23700: - Component/s: build > Upgrade checkstyle and plugin versions > -- > > Key: HBASE-23700 > URL: https://issues.apache.org/jira/browse/HBASE-23700 > Project: HBase > Issue Type: Task > Components: build >Reporter: Nick Dimiduk >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23700) Upgrade checkstyle and plugin versions
[ https://issues.apache.org/jira/browse/HBASE-23700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-23700: - Priority: Minor (was: Major) > Upgrade checkstyle and plugin versions > -- > > Key: HBASE-23700 > URL: https://issues.apache.org/jira/browse/HBASE-23700 > Project: HBase > Issue Type: Task >Reporter: Nick Dimiduk >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-23700) Upgrade checkstyle and plugin verions
Nick Dimiduk created HBASE-23700: Summary: Upgrade checkstyle and plugin verions Key: HBASE-23700 URL: https://issues.apache.org/jira/browse/HBASE-23700 Project: HBase Issue Type: Task Reporter: Nick Dimiduk -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23700) Upgrade checkstyle and plugin versions
[ https://issues.apache.org/jira/browse/HBASE-23700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-23700: - Summary: Upgrade checkstyle and plugin versions (was: Upgrade checkstyle and plugin verions) > Upgrade checkstyle and plugin versions > -- > > Key: HBASE-23700 > URL: https://issues.apache.org/jira/browse/HBASE-23700 > Project: HBase > Issue Type: Task >Reporter: Nick Dimiduk >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] bharathv commented on issue #1052: HBASE-23695 Fail gracefully if no category is present
bharathv commented on issue #1052: HBASE-23695 Fail gracefully if no category is present URL: https://github.com/apache/hbase/pull/1052#issuecomment-575278747 @ndimiduk / @joshelser Think there is another similar bug lurking around in HBaseClassTestRule. Tried it out of curiosity and here is the full stack trace. (see the underlying stack..) ``` java.lang.ExceptionInInitializerError at sun.misc.Unsafe.ensureClassInitialized(Native Method) at sun.reflect.UnsafeFieldAccessorFactory.newFieldAccessor(UnsafeFieldAccessorFactory.java:43) at sun.reflect.ReflectionFactory.newFieldAccessor(ReflectionFactory.java:156) at java.lang.reflect.Field.acquireFieldAccessor(Field.java:1088) at java.lang.reflect.Field.getFieldAccessor(Field.java:1069) at java.lang.reflect.Field.get(Field.java:393) at org.junit.runners.model.FrameworkField.get(FrameworkField.java:88) at org.junit.runners.model.TestClass.collectAnnotatedFieldValues(TestClass.java:249) at org.junit.runners.ParentRunner.classRules(ParentRunner.java:280) at org.junit.runners.ParentRunner.withClassRules(ParentRunner.java:268) at org.junit.runners.ParentRunner.classBlock(ParentRunner.java:217) at org.junit.runners.ParentRunner.run(ParentRunner.java:412) at org.junit.runner.JUnitCore.run(JUnitCore.java:137) at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68) at com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:47) at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:242) at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70) Caused by: java.lang.ArrayIndexOutOfBoundsException: 0 at org.apache.hadoop.hbase.HBaseClassTestRule.getTimeoutInSeconds(HBaseClassTestRule.java:62) at org.apache.hadoop.hbase.HBaseClassTestRule.forClass(HBaseClassTestRule.java:77) at org.apache.hadoop.hbase.TestTableName.(TestTableName.java:44) ... 17 more ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #1026: HBASE-23682 Fix NPE when disable DeadServerMetricRegionChore
bharathv commented on a change in pull request #1026: HBASE-23682 Fix NPE when
disable DeadServerMetricRegionChore
URL: https://github.com/apache/hbase/pull/1026#discussion_r367567662
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestDeadServerMetricRegionChore.java
##
@@ -0,0 +1,68 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.master.assignment;
+
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.HBaseTestingUtility;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.testclassification.MasterTests;
+import org.apache.hadoop.hbase.testclassification.MediumTests;
+import org.junit.After;
+import org.junit.Before;
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+
+/**
+ * Testcase for HBASE-23682.
+ */
+@Category({ MasterTests.class, MediumTests.class })
+public class TestDeadServerMetricRegionChore {
+
+ @ClassRule
+ public static final HBaseClassTestRule CLASS_RULE =
+HBaseClassTestRule.forClass(TestDeadServerMetricRegionChore.class);
+
+ protected HBaseTestingUtility util;
+
+ @Before
+ public void setUp() throws Exception {
+util = new HBaseTestingUtility();
+// Disable DeadServerMetricRegionChore
+util.getConfiguration()
+
.setInt(AssignmentManager.DEAD_REGION_METRIC_CHORE_INTERVAL_MSEC_CONF_KEY, -1);
+ }
+
+ @After
+ public void tearDown() throws Exception {
+ }
+
+ @Test
+ public void testDeadServerMetricRegionChore() throws Exception {
+try {
+ this.util.startMiniCluster();
Review comment:
So, I think the only pending question is ...why not move
shutdownMiniCluster() to tearDown()? I think @HorizonNet is also asking the
same thing.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1055: HBASE-23699 ByteBuff may not recycle correctly when NettyRpcServer enabled and client disconnect
Apache-HBase commented on issue #1055: HBASE-23699 ByteBuff may not recycle correctly when NettyRpcServer enabled and client disconnect URL: https://github.com/apache/hbase/pull/1055#issuecomment-575272005 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 35s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 11s | master passed | | +1 :green_heart: | compile | 1m 18s | master passed | | +1 :green_heart: | checkstyle | 1m 44s | master passed | | +1 :green_heart: | shadedjars | 4m 33s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 58s | master passed | | +0 :ok: | spotbugs | 4m 31s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 5m 18s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 52s | the patch passed | | +1 :green_heart: | compile | 1m 20s | the patch passed | | +1 :green_heart: | javac | 1m 20s | the patch passed | | +1 :green_heart: | checkstyle | 1m 43s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 4m 36s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 15m 32s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | javadoc | 0m 56s | the patch passed | | +1 :green_heart: | findbugs | 5m 23s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 3m 20s | hbase-common in the patch passed. | | -1 :x: | unit | 242m 6s | hbase-server in the patch failed. | | +1 :green_heart: | asflicense | 1m 8s | The patch does not generate ASF License warnings. | | | | 308m 21s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.util.TestMiniClusterLoadParallel | | | hadoop.hbase.replication.TestReplicationSmallTests | | | hadoop.hbase.client.TestAsyncTableGetMultiThreaded | | | hadoop.hbase.master.assignment.TestRegionMoveAndAbandon | | | hadoop.hbase.client.TestMultiParallel | | | hadoop.hbase.io.encoding.TestLoadAndSwitchEncodeOnDisk | | | hadoop.hbase.client.TestMultiRespectsLimits | | | hadoop.hbase.coprocessor.TestMetaTableMetrics | | | hadoop.hbase.client.TestMobRestoreSnapshotFromClientAfterSplittingRegions | | | hadoop.hbase.client.TestClientOperationInterrupt | | | hadoop.hbase.master.procedure.TestSCPWithMetaWithoutZKCoordinated | | | hadoop.hbase.master.assignment.TestMergeTableRegionsProcedure | | | hadoop.hbase.client.TestCloneSnapshotFromClientCloneLinksAfterDelete | | | hadoop.hbase.util.TestMiniClusterLoadEncoded | | | hadoop.hbase.master.procedure.TestRestoreSnapshotProcedure | | | hadoop.hbase.master.procedure.TestMasterFailoverWithProcedures | | | hadoop.hbase.client.TestAsyncNonMetaRegionLocator | | | hadoop.hbase.security.visibility.TestVisibilityLabelsWithACL | | | hadoop.hbase.util.TestMiniClusterLoadSequential | | | hadoop.hbase.quotas.TestQuotaObserverChoreWithMiniCluster | | | hadoop.hbase.quotas.TestSpaceQuotasWithRegionReplicas | | | hadoop.hbase.regionserver.TestJoinedScanners | | | hadoop.hbase.client.TestAsyncTable | | | hadoop.hbase.client.TestMobRestoreSnapshotFromClientAfterTruncate | | | hadoop.hbase.regionserver.TestHRegionServerBulkLoad | | | hadoop.hbase.snapshot.TestRestoreFlushSnapshotFromClient | | | hadoop.hbase.quotas.TestQuotaStatusRPCs | | | hadoop.hbase.TestMultiVersions | | | hadoop.hbase.client.TestRestoreSnapshotFromClientSimple | | | hadoop.hbase.client.TestFromClientSide3 | | | hadoop.hbase.master.procedure.TestTruncateTableProcedure | | | hadoop.hbase.quotas.TestSpaceQuotaBasicFunctioning | | | hadoop.hbase.quotas.TestSpaceQuotaSwitchPolicies | | | hadoop.hbase.quotas.TestSpaceQuotaRemoval | | | hadoop.hbase.master.TestMasterNoCluster | | | hadoop.hbase.util.TestFromClientSide3WoUnsafe |
[GitHub] [hbase] joshelser commented on issue #1052: HBASE-23695 Fail gracefully if no category is present
joshelser commented on issue #1052: HBASE-23695 Fail gracefully if no category is present URL: https://github.com/apache/hbase/pull/1052#issuecomment-575271739 ``` % mvn -X Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) Maven home: /usr/local/Cellar/maven/3.6.3/libexec Java version: 1.8.0_211, vendor: Oracle Corporation, runtime: /Library/Java/JavaVirtualMachines/jdk1.8.0_211.jdk/Contents/Home/jre Default locale: en_US, platform encoding: UTF-8 OS name: "mac os x", version: "10.14.5", arch: "x86_64", family: "mac" ``` maybe some difference in built tools, @ndimiduk ? That is goofy that you see something else. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23677) region.jsp returns 500/NPE when provided encoded region name is not online
[
https://issues.apache.org/jira/browse/HBASE-23677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17017352#comment-17017352
]
Hudson commented on HBASE-23677:
Results for branch master
[build #1599 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1599/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1599//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1599//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1599//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> region.jsp returns 500/NPE when provided encoded region name is not online
> --
>
> Key: HBASE-23677
> URL: https://issues.apache.org/jira/browse/HBASE-23677
> Project: HBase
> Issue Type: Bug
> Components: regionserver, UI
>Affects Versions: 2.2.3
>Reporter: Nick Dimiduk
>Assignee: wenfeiyi666
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.2.4
>
>
> Noticed while testing for HBASE-23653. A link off to a region that is closed
> or otherwise not in the region server's online region map results in a 500.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23694) After RegionProcedureStore completes migration of WALProcedureStore, still running WALProcedureStore.syncThread keeps trying to delete now inexistent log files.
[
https://issues.apache.org/jira/browse/HBASE-23694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17017354#comment-17017354
]
Hudson commented on HBASE-23694:
Results for branch master
[build #1599 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1599/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1599//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1599//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1599//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> After RegionProcedureStore completes migration of WALProcedureStore, still
> running WALProcedureStore.syncThread keeps trying to delete now inexistent
> log files.
> --
>
> Key: HBASE-23694
> URL: https://issues.apache.org/jira/browse/HBASE-23694
> Project: HBase
> Issue Type: Bug
> Components: proc-v2, RegionProcedureStore
>Affects Versions: 3.0.0
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> With the introduction of the new procedure store to save procs on a table,
> instead of proc WALs, we added some migration logic to enable a smooth
> upgrade of clusters under previous versions that used to have proc wal files
> as the underlying procedure store.
> While running a fresh install with latest master branch version, I had
> noticed that once the old _WALProcedureStore_ directory is detected, it
> creates and start a WPS instance
> [here|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/procedure2/store/region/RegionProcedureStore.java#L311],
> passing a built-in _ProcedureLoader_
> [here|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/procedure2/store/region/RegionProcedureStore.java#L315]
> to perform the conversion from proc wal files to table based.
> At the end of this conversion, the builtin loader deletes the proc wal dir
> [here|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/procedure2/store/region/RegionProcedureStore.java#L363].
> This may cause a race condition where a running _WALProcedureStore_ internal
> thread may be trying to delete the first proc wal file that may had already
> rolled, then failing with FNFE.
> Even worse is that _WALProcedureStore.syncLoop_ keeps trying indefinitely,
> flooding Master logs with messages such as below:
> {noformat}
> 2020-01-14 06:13:23,331 INFO [master/hbase01:16000:becomeActiveMaster]
> region.RegionProcedureStore: The old WALProcedureStore wal directory
> file:/root/hbase-3.0.0-SNAPSHOT/hbase-data/MasterProcWALs exists, migrating...
> 2020-01-14 06:13:23,361 DEBUG [master/hbase01:16000:becomeActiveMaster]
> wal.WALProcedureStore: Starting WAL Procedure Store lease recovery
> 2020-01-14 06:13:23,453 INFO [master/hbase01:16000:becomeActiveMaster]
> wal.WALProcedureStore: Rolled new Procedure Store WAL, id=1
> 2020-01-14 06:13:23,454 DEBUG [master/hbase01:16000:becomeActiveMaster]
> wal.WALProcedureStore: Lease acquired for flushLogId=1
> 2020-01-14 06:13:23,454 DEBUG [master/hbase01:16000:becomeActiveMaster]
> wal.WALProcedureStore: No state logs to replay.
> 2020-01-14 06:13:23,454 INFO [master/hbase01:16000:becomeActiveMaster]
> region.RegionProcedureStore: The WALProcedureStore max pid is 0, and the max
> pid of all loaded procedures is -1
> 2020-01-14 06:13:23,455 INFO [master/hbase01:16000:becomeActiveMaster]
> region.RegionProcedureStore: Migration of WALProcedureStore finished
> 2020-01-14 06:13:23,455 INFO [master/hbase01:16000:becomeActiveMaster]
> procedure2.ProcedureExecutor: Recovered RegionProcedureStore lease in 784 msec
> 2020-01-14 06:13:23,471 TRACE [WALProcedureStoreSyncThread]
> wal.WALProcedureStore: no active procedures
> 2020-01-14 06:13:23,516 INFO [master/hbase01:16000:becomeActiveMaster]
> procedure2.ProcedureExecutor: Loaded RegionProcedureStore in 61 msec
> 2020-01-14 06:13:23,516 INFO [master/hbase01:16000:becomeActiveMaster]
> procedure2.RemoteProcedureDispatcher: Instantiated,
[jira] [Commented] (HBASE-23683) Make HBaseInterClusterReplicationEndpoint more extensible
[
https://issues.apache.org/jira/browse/HBASE-23683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17017350#comment-17017350
]
Hudson commented on HBASE-23683:
Results for branch master
[build #1599 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1599/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1599//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1599//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1599//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Make HBaseInterClusterReplicationEndpoint more extensible
> -
>
> Key: HBASE-23683
> URL: https://issues.apache.org/jira/browse/HBASE-23683
> Project: HBase
> Issue Type: Improvement
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Major
> Fix For: 3.0.0
>
>
> *HBaseInterClusterReplicationEndpoint* currently creates the cluster
> connection and sink manager instances inside its _init_ method and assigns
> those to private class variables. Then any potential custom extension of
> *HBaseInterClusterReplicationEndpoint* that requires custom implementations
> of connection and/or sink manager would need to resort to _java reflection_
> for effectively replace those instances, such as below:
> {noformat}
> ...
> ClusterConnection conn = (ClusterConnection)ConnectionFactory.
> createConnection(context.getConfiguration(),
> User.create(replicationUgi));
> ReplicationSinkManager sinkManager = new ReplicationSinkManager(conn,
> ctx.getPeerId(),
> this, context.getConfiguration());
> try {
> Field field = this.getClass().getSuperclass().getDeclaredField("conn");
> field.setAccessible(true);
> field.set(this, conn);
> field =
> this.getClass().getSuperclass().getDeclaredField("replicationSinkMgr");
> field.setAccessible(true);
> field.set(this, sinkManager);
> } catch (Exception e) {
> throw new IOException(e);
> }
> ...
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23674) Too many rit page Numbers show confusion
[
https://issues.apache.org/jira/browse/HBASE-23674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17017353#comment-17017353
]
Hudson commented on HBASE-23674:
Results for branch master
[build #1599 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1599/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1599//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1599//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1599//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Too many rit page Numbers show confusion
>
>
> Key: HBASE-23674
> URL: https://issues.apache.org/jira/browse/HBASE-23674
> Project: HBase
> Issue Type: Improvement
> Components: master
>Affects Versions: 3.0.0
>Reporter: dingbaosheng
>Assignee: dingbaosheng
>Priority: Trivial
> Fix For: 3.0.0, 2.3.0, 2.2.4
>
> Attachments: HBASE-23674.master.0001.patch,
> HBASE-23674.master.0002.patch, HBASE-23674.master.0003.patch, Screen Shot
> 2020-01-14 at 11.01.34 AM.png, rit_2.png, rit_page.jpg, rit_too_many.jpg
>
>
> Too much rits can cause page rendering clutter, which can be resolved by
> adding pagers.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23665) Split unit tests from TestTableName into a separate test only class
[
https://issues.apache.org/jira/browse/HBASE-23665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17017351#comment-17017351
]
Hudson commented on HBASE-23665:
Results for branch master
[build #1599 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1599/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1599//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1599//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1599//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Split unit tests from TestTableName into a separate test only class
> ---
>
> Key: HBASE-23665
> URL: https://issues.apache.org/jira/browse/HBASE-23665
> Project: HBase
> Issue Type: Test
> Components: test
>Reporter: Nick Dimiduk
>Assignee: Bharath Vissapragada
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 1.6.0
>
>
> The class {{TestTableName}} in hbase-common is both a unit test for the
> {{TableName}} class, and a junit {{TestRule}}. This double-duty is strange;
> the Rule functionality is not discoverable at all. Split the Rule out into a
> separate class, maybe {{TableNameRule}} or some such.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23691) Add 2.2.3 to download page
[
https://issues.apache.org/jira/browse/HBASE-23691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17017349#comment-17017349
]
Hudson commented on HBASE-23691:
Results for branch master
[build #1599 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1599/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1599//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1599//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1599//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Add 2.2.3 to download page
> --
>
> Key: HBASE-23691
> URL: https://issues.apache.org/jira/browse/HBASE-23691
> Project: HBase
> Issue Type: Sub-task
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Fix For: 3.0.0
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] ndimiduk commented on issue #1051: HBASE-23665: Split unit tests from TestTableName into a separate test…
ndimiduk commented on issue #1051: HBASE-23665: Split unit tests from TestTableName into a separate test… URL: https://github.com/apache/hbase/pull/1051#issuecomment-575264768 Yep, I followed the other PR. Thanks for tracking it down. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] ndimiduk commented on issue #1052: HBASE-23695 Fail gracefully if no category is present
ndimiduk commented on issue #1052: HBASE-23695 Fail gracefully if no category is present URL: https://github.com/apache/hbase/pull/1052#issuecomment-575260771 Weird. With or without this patch I get a `java.lang.ExceptionInInitializerError` with the cause being the line number of the test's `HBaseClassTestRule` `@ClassRule`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #1047: HBASE-23683 Make HBaseInterClusterReplicationEndpoint more extensible…
bharathv commented on a change in pull request #1047: HBASE-23683 Make
HBaseInterClusterReplicationEndpoint more extensible…
URL: https://github.com/apache/hbase/pull/1047#discussion_r367551620
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/HBaseInterClusterReplicationEndpoint.java
##
@@ -133,12 +152,12 @@ public void init(Context context) throws IOException {
// TODO: This connection is replication specific or we should make it
particular to
// replication and make replication specific settings such as compression
or codec to use
// passing Cells.
-this.conn = (ClusterConnection)
ConnectionFactory.createConnection(this.conf);
+this.conn = (ClusterConnection) createConnection(this.conf);
Review comment:
Oh I see.. I _think_ I get the problem. Basically you are just relying on
ConnectionFactory and not worried about the type it is returning. Ya,
refactoring it will be a bigger patch.
nit: How about adding a preconditions check..
Preconditions.checkState(returnedConn instanceof ClusterConnection) and back it
up with a comment why it could fail?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Resolved] (HBASE-23653) Expose content of meta table in web ui
[
https://issues.apache.org/jira/browse/HBASE-23653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk resolved HBASE-23653.
--
Resolution: Fixed
> Expose content of meta table in web ui
> --
>
> Key: HBASE-23653
> URL: https://issues.apache.org/jira/browse/HBASE-23653
> Project: HBase
> Issue Type: New Feature
> Components: master, Operability, UI
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Minor
> Fix For: 3.0.0, 2.3.0
>
> Attachments: 23653.0.png, 23653.1.png
>
>
> While testing improvements to hbck2, breaking and fixing a cluster's region
> assignments, we've found that quite a few questions can only be answered by
> dropping into a shell and scanning meta. This is in contrast to the nice web
> view we have on procedures and their locks. It would be nice to have a
> similar view into the content of meta. I've put together and extension to the
> existing {{table.jsp}} that does this. It's had a couple rounds of operator
> feedback. Will post up some screenshots along with the PR.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-23653) Expose content of meta table in web ui
[
https://issues.apache.org/jira/browse/HBASE-23653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk updated HBASE-23653:
-
Fix Version/s: 2.3.0
3.0.0
> Expose content of meta table in web ui
> --
>
> Key: HBASE-23653
> URL: https://issues.apache.org/jira/browse/HBASE-23653
> Project: HBase
> Issue Type: New Feature
> Components: master, Operability, UI
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Minor
> Fix For: 3.0.0, 2.3.0
>
> Attachments: 23653.0.png, 23653.1.png
>
>
> While testing improvements to hbck2, breaking and fixing a cluster's region
> assignments, we've found that quite a few questions can only be answered by
> dropping into a shell and scanning meta. This is in contrast to the nice web
> view we have on procedures and their locks. It would be nice to have a
> similar view into the content of meta. I've put together and extension to the
> existing {{table.jsp}} that does this. It's had a couple rounds of operator
> feedback. Will post up some screenshots along with the PR.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] ndimiduk merged pull request #1020: HBASE-23653 Expose content of meta table in web ui
ndimiduk merged pull request #1020: HBASE-23653 Expose content of meta table in web ui URL: https://github.com/apache/hbase/pull/1020 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] ndimiduk merged pull request #1021: Backport HBASE-23653 Expose content of meta table in web ui
ndimiduk merged pull request #1021: Backport HBASE-23653 Expose content of meta table in web ui URL: https://github.com/apache/hbase/pull/1021 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] ndimiduk commented on a change in pull request #1018: HBASE-23652 Move the unsupported procedure type check before migratin…
ndimiduk commented on a change in pull request #1018: HBASE-23652 Move the
unsupported procedure type check before migratin…
URL: https://github.com/apache/hbase/pull/1018#discussion_r367527245
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/procedure2/store/region/RegionProcedureStore.java
##
@@ -298,6 +307,45 @@ private HRegion open(Configuration conf, FileSystem fs,
Path rootDir) throws IOE
null);
}
+ @SuppressWarnings("deprecation")
+ private static final ImmutableSet> UNSUPPORTED_PROCEDURES =
+ImmutableSet.of(RecoverMetaProcedure.class, AssignProcedure.class,
UnassignProcedure.class,
+ MoveRegionProcedure.class);
+
+ /**
+ * In HBASE-20811, we have introduced a new TRSP to assign/unassign/move
regions, and it is
+ * incompatible with the old
AssignProcedure/UnassignProcedure/MoveRegionProcedure. So we need to
+ * make sure that there are none these procedures when upgrading. If there
are, the master will
+ * quit, you need to go back to the old version to finish these procedures
first before upgrading.
+ */
+ private void checkUnsupportedProcedure(Map, List>>
procsByType)
+throws HBaseIOException {
+// Confirm that we do not have unfinished assign/unassign related
procedures. It is not easy to
+// support both the old assign/unassign procedures and the new
TransitRegionStateProcedure as
+// there will be conflict in the code for AM. We should finish all these
procedures before
+// upgrading.
+for (Class clazz : UNSUPPORTED_PROCEDURES) {
+ List> procs = procsByType.get(clazz);
+ if (procs != null) {
+LOG.error(
+ "Unsupported procedure type {} found, please rollback your master to
the old" +
+" version to finish them, and then try to upgrade again. The full
procedure list: {}",
+ clazz, procs);
+throw new HBaseIOException("Unsupported procedure type " + clazz + "
found");
+ }
+}
+// A special check for SCP, as we do not support RecoverMetaProcedure any
more so we need to
+// make sure that no one will try to schedule it but SCP does have a state
which will schedule
+// it.
+if (procsByType.getOrDefault(ServerCrashProcedure.class,
Collections.emptyList()).stream()
Review comment:
::nod::
I disagree with eclipse formatter. I don't think it's been updated since
java8.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (HBASE-23677) region.jsp returns 500/NPE when provided encoded region name is not online
[ https://issues.apache.org/jira/browse/HBASE-23677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17017286#comment-17017286 ] Nick Dimiduk commented on HBASE-23677: -- thank you sir! > region.jsp returns 500/NPE when provided encoded region name is not online > -- > > Key: HBASE-23677 > URL: https://issues.apache.org/jira/browse/HBASE-23677 > Project: HBase > Issue Type: Bug > Components: regionserver, UI >Affects Versions: 2.2.3 >Reporter: Nick Dimiduk >Assignee: wenfeiyi666 >Priority: Minor > Fix For: 3.0.0, 2.3.0, 2.2.4 > > > Noticed while testing for HBASE-23653. A link off to a region that is closed > or otherwise not in the region server's online region map results in a 500. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1026: HBASE-23682 Fix NPE when disable DeadServerMetricRegionChore
Apache-HBase commented on issue #1026: HBASE-23682 Fix NPE when disable DeadServerMetricRegionChore URL: https://github.com/apache/hbase/pull/1026#issuecomment-575236201 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 43s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 37s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 59s | master passed | | +1 :green_heart: | compile | 1m 32s | master passed | | +1 :green_heart: | checkstyle | 1m 49s | master passed | | +1 :green_heart: | shadedjars | 5m 20s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 7s | master passed | | +0 :ok: | spotbugs | 5m 32s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 6m 10s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 6m 8s | the patch passed | | +1 :green_heart: | compile | 1m 19s | the patch passed | | +1 :green_heart: | javac | 1m 19s | the patch passed | | +1 :green_heart: | checkstyle | 1m 45s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 5m 1s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 17m 22s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | javadoc | 0m 52s | the patch passed | | +1 :green_heart: | findbugs | 5m 36s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 3m 36s | hbase-procedure in the patch passed. | | -1 :x: | unit | 169m 24s | hbase-server in the patch failed. | | +1 :green_heart: | asflicense | 0m 54s | The patch does not generate ASF License warnings. | | | | 243m 34s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.TestHBaseTestingUtility | | | hadoop.hbase.master.assignment.TestRegionMoveAndAbandon | | | hadoop.hbase.master.TestMasterNoCluster | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/6/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1026 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 1261dfc1fa9a 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1026/out/precommit/personality/provided.sh | | git revision | master / 19d3bed1d4 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/6/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/6/testReport/ | | Max. process+thread count | 5047 (vs. ulimit of 1) | | modules | C: hbase-procedure hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/6/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23347) Pluggable RPC authentication
[ https://issues.apache.org/jira/browse/HBASE-23347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17017280#comment-17017280 ] Josh Elser commented on HBASE-23347: [~zhangduo], are you interested in this landing onto branch-2.2? While there should be no outward impact on users, it struck me as too "big" of a change for maintenance releases. Curious what you think. Thanks. > Pluggable RPC authentication > > > Key: HBASE-23347 > URL: https://issues.apache.org/jira/browse/HBASE-23347 > Project: HBase > Issue Type: Improvement > Components: rpc, security >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Major > Fix For: 3.0.0, 2.3.0 > > > Today in HBase, we rely on SASL to implement Kerberos and delegation token > authentication. The RPC client and server logic is very tightly coupled to > our three authentication mechanism (the previously two mentioned plus simple > auth'n) for no good reason (other than "that's how it was built", best as I > can tell). > SASL's function is to decouple the "application" from how a request is being > authenticated, which means that, to support a variety of other authentication > approaches, we just need to be a little more flexible in letting developers > create their own authentication mechanism for HBase. > This is less for the "average joe" user to write their own authentication > plugin (eek), but more to allow us HBase developers to start iterating, see > what is possible. > I'll attach a full write-up on what I have today as to how I think we can add > these abstractions, as well as an initial implementation of this idea, with a > unit test that shows an end-to-end authentication solution against HBase. > cc/ [~wchevreuil] as he's been working with me behind the scenes, giving lots > of great feedback and support. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-23347) Pluggable RPC authentication
[ https://issues.apache.org/jira/browse/HBASE-23347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser resolved HBASE-23347. Fix Version/s: 2.3.0 Hadoop Flags: Reviewed Release Note: This change introduces an internal abstraction layer which allows for new SASL-based authentication mechanisms to be used inside HBase services. All existing SASL-based authentication mechanism were ported to the new abstraction, making no external change in runtime semantics, client API, or RPC serialization format. Developers familiar with extending HBase can implement authentication mechanism beyond simple Kerberos and DelegationTokens which authenticate HBase users against some other user database. HBase service authentication (Master to/from RegionServer) continue to operate solely over Kerberos. Resolution: Fixed Pushed to branch-2 and master. Thanks to everyone who played a part in reviewing this. > Pluggable RPC authentication > > > Key: HBASE-23347 > URL: https://issues.apache.org/jira/browse/HBASE-23347 > Project: HBase > Issue Type: Improvement > Components: rpc, security >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Major > Fix For: 3.0.0, 2.3.0 > > > Today in HBase, we rely on SASL to implement Kerberos and delegation token > authentication. The RPC client and server logic is very tightly coupled to > our three authentication mechanism (the previously two mentioned plus simple > auth'n) for no good reason (other than "that's how it was built", best as I > can tell). > SASL's function is to decouple the "application" from how a request is being > authenticated, which means that, to support a variety of other authentication > approaches, we just need to be a little more flexible in letting developers > create their own authentication mechanism for HBase. > This is less for the "average joe" user to write their own authentication > plugin (eek), but more to allow us HBase developers to start iterating, see > what is possible. > I'll attach a full write-up on what I have today as to how I think we can add > these abstractions, as well as an initial implementation of this idea, with a > unit test that shows an end-to-end authentication solution against HBase. > cc/ [~wchevreuil] as he's been working with me behind the scenes, giving lots > of great feedback and support. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] asfgit closed pull request #884: HBASE-23347 Allowable custom authentication methods for RPCs
asfgit closed pull request #884: HBASE-23347 Allowable custom authentication methods for RPCs URL: https://github.com/apache/hbase/pull/884 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] joshelser commented on a change in pull request #1052: HBASE-23695 Fail gracefully if no category is present
joshelser commented on a change in pull request #1052: HBASE-23695 Fail
gracefully if no category is present
URL: https://github.com/apache/hbase/pull/1052#discussion_r367483211
##
File path:
hbase-common/src/test/java/org/apache/hadoop/hbase/HBaseClassTestRuleChecker.java
##
@@ -41,9 +41,12 @@
@Override
public void testStarted(Description description) throws Exception {
Category[] categories =
description.getTestClass().getAnnotationsByType(Category.class);
-for (Class c : categories[0].value()) {
- if (c == IntegrationTests.class) {
-return;
+// Don't fail if there is a missing category
+if (categories.length > 0) {
+ for (Class c : categories[0].value()) {
Review comment:
I'm not actually sure what all is allowed by `Category`. I would assume that
this for-loop handles both `@Category(OneInterface.class)` and
`@Category({InterfaceA.class,InterfaceB.class})`. I have to experiment to see
what else is actually allowable.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] joshelser commented on issue #1052: HBASE-23695 Fail gracefully if no category is present
joshelser commented on issue #1052: HBASE-23695 Fail gracefully if no category is present URL: https://github.com/apache/hbase/pull/1052#issuecomment-575203674 Thanks @busbey and @virajjasani for the reviews as well! I didn't notice your approvals until after pushing (was going to push last night, but someone beat me to it and then I needed to rebase). Apologies for not getting your `Signed-off-by` in the commit message. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (HBASE-23695) Fail more gracefully when test class is missing Category
[
https://issues.apache.org/jira/browse/HBASE-23695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josh Elser resolved HBASE-23695.
Fix Version/s: 2.1.9
2.2.3
2.3.0
3.0.0
Hadoop Flags: Reviewed
Resolution: Fixed
> Fail more gracefully when test class is missing Category
>
>
> Key: HBASE-23695
> URL: https://issues.apache.org/jira/browse/HBASE-23695
> Project: HBase
> Issue Type: Bug
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.2.3, 2.1.9
>
>
> When a test class is missing a category, you might see an error such as:
> {noformat}
> [ERROR] Test mechanism Time elapsed: 0.305 s <<< ERROR!
> java.lang.ArrayIndexOutOfBoundsException: 0[ERROR] Test mechanism Time
> elapsed: 0.102 s <<< ERROR!
> java.lang.ArrayIndexOutOfBoundsException: 0[ERROR] Test mechanism Time
> elapsed: 0.103 s <<< ERROR!
> java.lang.ArrayIndexOutOfBoundsException: 0[ERROR] Test mechanism Time
> elapsed: 0.102 s <<< ERROR!
> java.lang.ArrayIndexOutOfBoundsException: 0[ERROR] Test mechanism Time
> elapsed: 0.098 s <<< ERROR!
> java.lang.ArrayIndexOutOfBoundsException: 0[ERROR] Test mechanism :: 0
> {noformat}
> You have to dig into the dump file to find out the actual error was:
> {noformat}
> org.apache.maven.surefire.testset.TestSetFailedException: Test mechanism :: 0
> at
> org.apache.maven.surefire.common.junit4.JUnit4RunListener.rethrowAnyTestMechanismFailures(JUnit4RunListener.java:192)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:167)
> at
> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:377)
> at
> org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:138)
> at
> org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:465)
> at
> org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:451)
> Caused by: java.lang.ArrayIndexOutOfBoundsException: 0
> at
> org.apache.hadoop.hbase.HBaseClassTestRuleChecker.testStarted(HBaseClassTestRuleChecker.java:44)
> at
> org.junit.runner.notification.RunNotifier$5.notifyListener(RunNotifier.java:156)
> at
> org.junit.runner.notification.RunNotifier$SafeNotifier.run(RunNotifier.java:72)
> at
> org.junit.runner.notification.RunNotifier.fireTestStarted(RunNotifier.java:153)
> at
> org.apache.maven.surefire.common.junit4.Notifier.fireTestStarted(Notifier.java:100)
> at
> org.junit.internal.runners.model.EachTestNotifier.fireTestStarted(EachTestNotifier.java:42)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:364)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
> at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
> at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
> at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)
> ... 4 more {noformat}
> We can fix this up to get a proper exception thrown.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] asfgit closed pull request #1052: HBASE-23695 Fail gracefully if no category is present
asfgit closed pull request #1052: HBASE-23695 Fail gracefully if no category is present URL: https://github.com/apache/hbase/pull/1052 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (HBASE-23652) Move the unsupported procedure type check before migrating to RegionProcedureStore
[ https://issues.apache.org/jira/browse/HBASE-23652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-23652. --- Hadoop Flags: Reviewed Resolution: Fixed Pushed to master and branch-2. Thanks [~ndimiduk]. > Move the unsupported procedure type check before migrating to > RegionProcedureStore > -- > > Key: HBASE-23652 > URL: https://issues.apache.org/jira/browse/HBASE-23652 > Project: HBase > Issue Type: Task > Components: master >Affects Versions: 2.2.2 >Reporter: Nick Dimiduk >Assignee: Duo Zhang >Priority: Blocker > Fix For: 3.0.0, 2.3.0 > > > Per > [discussion|https://lists.apache.org/thread.html/c5f960e6cf3c89ffbf8f8302afb121462a08fd9a89d384c6795a7b81%40%3Cdev.hbase.apache.org%3E] > on the list, let's figure out how to make the upgrade from a v2.1 procedure > store less error-prone. Could be a simple as documenting runbook steps to > execute during the rolling upgrade, but it would be nice if the software > could roll over the data versions gracefully. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache9 merged pull request #1018: HBASE-23652 Move the unsupported procedure type check before migratin…
Apache9 merged pull request #1018: HBASE-23652 Move the unsupported procedure type check before migratin… URL: https://github.com/apache/hbase/pull/1018 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23677) region.jsp returns 500/NPE when provided encoded region name is not online
[ https://issues.apache.org/jira/browse/HBASE-23677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17016969#comment-17016969 ] Wellington Chevreuil commented on HBASE-23677: -- Done for the branch-2 and branch-2.2 as well. > region.jsp returns 500/NPE when provided encoded region name is not online > -- > > Key: HBASE-23677 > URL: https://issues.apache.org/jira/browse/HBASE-23677 > Project: HBase > Issue Type: Bug > Components: regionserver, UI >Affects Versions: 2.2.3 >Reporter: Nick Dimiduk >Assignee: wenfeiyi666 >Priority: Minor > Fix For: 3.0.0, 2.3.0, 2.2.4 > > > Noticed while testing for HBASE-23653. A link off to a region that is closed > or otherwise not in the region server's online region map results in a 500. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-23675) Move to Apache parent POM version 22
[ https://issues.apache.org/jira/browse/HBASE-23675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi resolved HBASE-23675. --- Resolution: Fixed Re-resolving. > Move to Apache parent POM version 22 > > > Key: HBASE-23675 > URL: https://issues.apache.org/jira/browse/HBASE-23675 > Project: HBase > Issue Type: Improvement > Components: dependencies >Affects Versions: 3.0.0, 2.3.0, 1.6.0 >Reporter: Peter Somogyi >Assignee: Peter Somogyi >Priority: Minor > Fix For: 3.0.0, 2.3.0, 1.6.0 > > > Apache parent POM version 22 was released on 2020/01/09. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1030: HBASE-23621 Reduced the number of Checkstyle violations in tests of hbase-common
Apache-HBase commented on issue #1030: HBASE-23621 Reduced the number of Checkstyle violations in tests of hbase-common URL: https://github.com/apache/hbase/pull/1030#issuecomment-575161963 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 40s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 11 new or modified test files. | ||| _ branch-1 Compile Tests _ | | +0 :ok: | mvndep | 1m 32s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 8m 1s | branch-1 passed | | +1 :green_heart: | compile | 1m 17s | branch-1 passed with JDK v1.8.0_242 | | +1 :green_heart: | compile | 1m 22s | branch-1 passed with JDK v1.7.0_252 | | +1 :green_heart: | checkstyle | 2m 36s | branch-1 passed | | +1 :green_heart: | shadedjars | 3m 49s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 3s | branch-1 passed with JDK v1.8.0_242 | | +1 :green_heart: | javadoc | 1m 21s | branch-1 passed with JDK v1.7.0_252 | | +0 :ok: | spotbugs | 3m 24s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 4m 43s | branch-1 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 39s | the patch passed | | +1 :green_heart: | compile | 1m 13s | the patch passed with JDK v1.8.0_242 | | +1 :green_heart: | javac | 1m 13s | the patch passed | | +1 :green_heart: | compile | 1m 31s | the patch passed with JDK v1.7.0_252 | | +1 :green_heart: | javac | 1m 31s | the patch passed | | +1 :green_heart: | checkstyle | 0m 34s | hbase-common: The patch generated 0 new + 20 unchanged - 32 fixed = 20 total (was 52) | | +1 :green_heart: | checkstyle | 1m 56s | hbase-server: The patch generated 0 new + 330 unchanged - 1 fixed = 330 total (was 331) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 3m 48s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 6m 1s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. | | +1 :green_heart: | javadoc | 1m 2s | the patch passed with JDK v1.8.0_242 | | +1 :green_heart: | javadoc | 1m 16s | the patch passed with JDK v1.7.0_252 | | +1 :green_heart: | findbugs | 4m 54s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 53s | hbase-common in the patch passed. | | -1 :x: | unit | 157m 50s | hbase-server in the patch failed. | | +1 :green_heart: | asflicense | 0m 44s | The patch does not generate ASF License warnings. | | | | 218m 32s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.mapreduce.TestLoadIncrementalHFilesUseSecurityEndPoint | | | hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFiles | | | hadoop.hbase.master.balancer.TestStochasticLoadBalancer2 | | | hadoop.hbase.mapreduce.TestLoadIncrementalHFiles | | | hadoop.hbase.master.TestMasterBalanceThrottling | | | hadoop.hbase.mapreduce.TestTableSnapshotInputFormat | | | hadoop.hbase.master.TestWarmupRegion | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/5/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1030 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux c3a6b5d7e2f4 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1030/out/precommit/personality/provided.sh | | git revision | branch-1 / 99a328f | | Default Java | 1.7.0_252 | | Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_242 /usr/lib/jvm/zulu-7-amd64:1.7.0_252 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/5/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/5/testRep
[jira] [Commented] (HBASE-18326) Fix and reenable TestMasterProcedureWalLease
[ https://issues.apache.org/jira/browse/HBASE-18326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17016955#comment-17016955 ] Szabolcs Bukros commented on HBASE-18326: - Test got deleted in HBASE-23326. Can we close this ticket or should we try to re-introduce the test? > Fix and reenable TestMasterProcedureWalLease > > > Key: HBASE-18326 > URL: https://issues.apache.org/jira/browse/HBASE-18326 > Project: HBase > Issue Type: Sub-task > Components: test >Reporter: Michael Stack >Priority: Blocker > Fix For: 3.0.0, 2.3.0 > > > Fix and reenable flakey important test. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1022: HBASE-23680 RegionProcedureStore missing cleaning of hfile archive
Apache-HBase commented on issue #1022: HBASE-23680 RegionProcedureStore missing cleaning of hfile archive URL: https://github.com/apache/hbase/pull/1022#issuecomment-575142947 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 7s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 7 new or modified test files. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 32s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 44s | master passed | | +1 :green_heart: | compile | 1m 39s | master passed | | +1 :green_heart: | checkstyle | 2m 9s | master passed | | +0 :ok: | refguide | 6m 26s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | shadedjars | 5m 0s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 11s | master passed | | +0 :ok: | spotbugs | 5m 2s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 6m 22s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 28s | the patch passed | | +1 :green_heart: | compile | 1m 38s | the patch passed | | +1 :green_heart: | javac | 1m 38s | the patch passed | | -1 :x: | checkstyle | 1m 30s | hbase-server: The patch generated 3 new + 103 unchanged - 0 fixed = 106 total (was 103) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. | | +0 :ok: | refguide | 6m 17s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | shadedjars | 5m 4s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 17m 14s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | javadoc | 1m 10s | the patch passed | | +1 :green_heart: | findbugs | 6m 40s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 3m 6s | hbase-common in the patch passed. | | +1 :green_heart: | unit | 3m 36s | hbase-procedure in the patch passed. | | +1 :green_heart: | unit | 155m 54s | hbase-server in the patch passed. | | +1 :green_heart: | asflicense | 1m 16s | The patch does not generate ASF License warnings. | | | | 247m 17s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1022/5/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1022 | | Optional Tests | dupname asflicense javac javadoc unit refguide xml spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux b929b09c26eb 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1022/out/precommit/personality/provided.sh | | git revision | master / 19d3bed1d4 | | Default Java | 1.8.0_181 | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1022/5/artifact/out/branch-site/book.html | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1022/5/artifact/out/diff-checkstyle-hbase-server.txt | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1022/5/artifact/out/patch-site/book.html | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1022/5/testReport/ | | Max. process+thread count | 5002 (vs. ulimit of 1) | | modules | C: hbase-common hbase-procedure hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1022/5/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is
[jira] [Commented] (HBASE-23698) Switch central repo to https on branch-1
[
https://issues.apache.org/jira/browse/HBASE-23698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17016875#comment-17016875
]
Hudson commented on HBASE-23698:
Results for branch branch-1
[build #1202 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1202/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1202//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1202//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1202//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Switch central repo to https on branch-1
>
>
> Key: HBASE-23698
> URL: https://issues.apache.org/jira/browse/HBASE-23698
> Project: HBase
> Issue Type: Bug
> Components: tooling
>Affects Versions: 1.6.0
>Reporter: Bharath Vissapragada
>Assignee: Bharath Vissapragada
>Priority: Blocker
> Labels: broken-build
> Fix For: 1.6.0
>
>
> Maven central started enforcing https [1] today and branch-1 builds are
> failing presumably due to an older maven version.
> Maven 3.2.3 [2] and later already switched the defaults, so not every one
> might run into this problem, depending on what mvn they are using. Jenkins
> jobs are hitting this, so they are likely using an older version.
> [1] https://blog.sonatype.com/central-repository-moving-to-https
> [2] https://issues.apache.org/jira/browse/MNG-5672
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] chenxu14 opened a new pull request #1055: HBASE-23699 ByteBuff may not recycle correctly when NettyRpcServer enabled and client disconnect
chenxu14 opened a new pull request #1055: HBASE-23699 ByteBuff may not recycle correctly when NettyRpcServer enabled and client disconnect URL: https://github.com/apache/hbase/pull/1055 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1026: HBASE-23682 Fix NPE when disable DeadServerMetricRegionChore
Apache-HBase commented on issue #1026: HBASE-23682 Fix NPE when disable DeadServerMetricRegionChore URL: https://github.com/apache/hbase/pull/1026#issuecomment-575130961 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 21s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 34s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 53s | master passed | | +1 :green_heart: | compile | 1m 18s | master passed | | +1 :green_heart: | checkstyle | 1m 43s | master passed | | +1 :green_heart: | shadedjars | 5m 10s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 57s | master passed | | +0 :ok: | spotbugs | 5m 28s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 6m 5s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 6m 30s | the patch passed | | +1 :green_heart: | compile | 1m 30s | the patch passed | | +1 :green_heart: | javac | 1m 30s | the patch passed | | +1 :green_heart: | checkstyle | 1m 52s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 5m 29s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 18m 50s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | javadoc | 0m 51s | the patch passed | | +1 :green_heart: | findbugs | 5m 37s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 3m 47s | hbase-procedure in the patch passed. | | -1 :x: | unit | 164m 52s | hbase-server in the patch failed. | | +1 :green_heart: | asflicense | 0m 48s | The patch does not generate ASF License warnings. | | | | 240m 47s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.assignment.TestRegionMoveAndAbandon | | | hadoop.hbase.master.TestMasterNoCluster | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/5/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1026 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 9e89df078a8f 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1026/out/precommit/personality/provided.sh | | git revision | master / 19d3bed1d4 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/5/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/5/testReport/ | | Max. process+thread count | 4742 (vs. ulimit of 1) | | modules | C: hbase-procedure hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/5/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] HorizonNet removed a comment on issue #1036: HBASE-23686 Revert binary incompatible change in ByteRangeUtils and removed reflections in CommonFSUtils
HorizonNet removed a comment on issue #1036: HBASE-23686 Revert binary incompatible change in ByteRangeUtils and removed reflections in CommonFSUtils URL: https://github.com/apache/hbase/pull/1036#issuecomment-575128468 Problem in the build seems to be related to [HBASE-22732](https://issues.apache.org/jira/browse/HBASE-22732]). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] HorizonNet commented on issue #1034: HBASE-23622 Reduced the number of Checkstyle violations in hbase-common
HorizonNet commented on issue #1034: HBASE-23622 Reduced the number of Checkstyle violations in hbase-common URL: https://github.com/apache/hbase/pull/1034#issuecomment-575128383 Problem in the build seems to be related to [HBASE-22732](https://issues.apache.org/jira/browse/HBASE-22732]). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] HorizonNet commented on issue #1036: HBASE-23686 Revert binary incompatible change in ByteRangeUtils and removed reflections in CommonFSUtils
HorizonNet commented on issue #1036: HBASE-23686 Revert binary incompatible change in ByteRangeUtils and removed reflections in CommonFSUtils URL: https://github.com/apache/hbase/pull/1036#issuecomment-575128468 Problem in the build seems to be related to [HBASE-22732](https://issues.apache.org/jira/browse/HBASE-22732]). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (HBASE-23699) ByteBuff may not recycle correctly when NettyRpcServer enabled and client disconnect
chenxu created HBASE-23699:
--
Summary: ByteBuff may not recycle correctly when NettyRpcServer
enabled and client disconnect
Key: HBASE-23699
URL: https://issues.apache.org/jira/browse/HBASE-23699
Project: HBase
Issue Type: Bug
Components: rpc
Reporter: chenxu
Assignee: chenxu
Code in NettyRpcServerResponseEncoder
{code:java}
@Override
public void write(ChannelHandlerContext ctx, Object msg, ChannelPromise
promise) throws Exception {
if (msg instanceof RpcResponse) {
RpcResponse resp = (RpcResponse) msg;
BufferChain buf = resp.getResponse();
ctx.write(Unpooled.wrappedBuffer(buf.getBuffers()), promise).addListener(f
-> {
resp.done();
if (f.isSuccess()) {
metrics.sentBytes(buf.size());
}
});
} else {
ctx.write(msg, promise);
}
}
{code}
If exception occurs during ChannelHandlerContext#write (such as Client
disconnected), ByteBuff may not be recycled correctly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1025: HBASE-23646 Resolved remaining Checkstyle violations in tests of hbase-rest
Apache-HBase commented on issue #1025: HBASE-23646 Resolved remaining Checkstyle violations in tests of hbase-rest URL: https://github.com/apache/hbase/pull/1025#issuecomment-575104887 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 5 new or modified test files. | ||| _ branch-1 Compile Tests _ | | +0 :ok: | mvndep | 1m 29s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 7m 31s | branch-1 passed | | +1 :green_heart: | compile | 0m 30s | branch-1 passed with JDK v1.8.0_242 | | +1 :green_heart: | compile | 0m 38s | branch-1 passed with JDK v1.7.0_252 | | +1 :green_heart: | checkstyle | 5m 5s | branch-1 passed | | +1 :green_heart: | shadedjars | 2m 57s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 37s | branch-1 passed with JDK v1.8.0_242 | | +1 :green_heart: | javadoc | 0m 38s | branch-1 passed with JDK v1.7.0_252 | | +0 :ok: | spotbugs | 1m 3s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +0 :ok: | findbugs | 0m 25s | branch/hbase-checkstyle no findbugs output file (findbugsXml.xml) | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 1m 52s | the patch passed | | +1 :green_heart: | compile | 0m 32s | the patch passed with JDK v1.8.0_242 | | +1 :green_heart: | javac | 0m 32s | the patch passed | | +1 :green_heart: | compile | 0m 38s | the patch passed with JDK v1.7.0_252 | | +1 :green_heart: | javac | 0m 38s | the patch passed | | +1 :green_heart: | checkstyle | 4m 54s | root: The patch generated 0 new + 4 unchanged - 188 fixed = 4 total (was 192) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | -1 :x: | xml | 0m 0s | The patch has 1 ill-formed XML file(s). | | +1 :green_heart: | shadedjars | 2m 51s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 4m 50s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. | | +1 :green_heart: | javadoc | 0m 29s | the patch passed with JDK v1.8.0_242 | | +1 :green_heart: | javadoc | 0m 37s | the patch passed with JDK v1.7.0_252 | | +0 :ok: | findbugs | 0m 13s | hbase-checkstyle has no data from findbugs | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 12s | hbase-checkstyle in the patch passed. | | +1 :green_heart: | unit | 14m 5s | hbase-rest in the patch passed. | | +1 :green_heart: | asflicense | 0m 24s | The patch does not generate ASF License warnings. | | | | 58m 24s | | | Reason | Tests | |---:|:--| | XML | Parsing Error(s): | | | hbase-checkstyle/src/main/resources/hbase/checkstyle-suppressions.xml | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1025/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1025 | | Optional Tests | dupname asflicense checkstyle javac javadoc unit xml spotbugs findbugs shadedjars hadoopcheck hbaseanti compile | | uname | Linux 52901538802f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1025/out/precommit/personality/provided.sh | | git revision | branch-1 / 99a328f | | Default Java | 1.7.0_252 | | Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_242 /usr/lib/jvm/zulu-7-amd64:1.7.0_252 | | xml | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1025/3/artifact/out/xml.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1025/3/testReport/ | | Max. process+thread count | 2033 (vs. ulimit of 1) | | modules | C: hbase-checkstyle hbase-rest U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1025/3/console | | versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was a
[GitHub] [hbase] Apache-HBase commented on issue #1018: HBASE-23652 Move the unsupported procedure type check before migratin…
Apache-HBase commented on issue #1018: HBASE-23652 Move the unsupported procedure type check before migratin… URL: https://github.com/apache/hbase/pull/1018#issuecomment-575095658 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m 4s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 59s | master passed | | +1 :green_heart: | compile | 0m 57s | master passed | | +1 :green_heart: | checkstyle | 1m 32s | master passed | | +1 :green_heart: | shadedjars | 5m 0s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 39s | master passed | | +0 :ok: | spotbugs | 4m 58s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 4m 56s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 28s | the patch passed | | +1 :green_heart: | compile | 0m 57s | the patch passed | | +1 :green_heart: | javac | 0m 57s | the patch passed | | +1 :green_heart: | checkstyle | 1m 30s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 5m 0s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 17m 24s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | javadoc | 0m 34s | the patch passed | | +1 :green_heart: | findbugs | 4m 56s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 164m 41s | hbase-server in the patch failed. | | +1 :green_heart: | asflicense | 0m 30s | The patch does not generate ASF License warnings. | | | | 231m 5s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestAsyncTableGetMultiThreaded | | | hadoop.hbase.master.assignment.TestRegionMoveAndAbandon | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1018/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1018 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 069513a48abf 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1018/out/precommit/personality/provided.sh | | git revision | master / 19d3bed1d4 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1018/3/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1018/3/testReport/ | | Max. process+thread count | 4825 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1018/3/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] wchevreuil commented on a change in pull request #1047: HBASE-23683 Make HBaseInterClusterReplicationEndpoint more extensible…
wchevreuil commented on a change in pull request #1047: HBASE-23683 Make
HBaseInterClusterReplicationEndpoint more extensible…
URL: https://github.com/apache/hbase/pull/1047#discussion_r367349645
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/HBaseInterClusterReplicationEndpoint.java
##
@@ -133,12 +152,12 @@ public void init(Context context) throws IOException {
// TODO: This connection is replication specific or we should make it
particular to
// replication and make replication specific settings such as compression
or codec to use
// passing Cells.
-this.conn = (ClusterConnection)
ConnectionFactory.createConnection(this.conf);
+this.conn = (ClusterConnection) createConnection(this.conf);
Review comment:
> what does your use case look like here where you have an override that
does a generic Connection rather than (some type of) ClusterConnection?
I have a _HBaseInterClusterReplicationEndpoint_ extension where I'm still
using _ConnectionFactory_ for creating connections, but I use different factory
method than what is used by _HBaseInterClusterReplicationEndpoint_. I don't
really care about which connection implementation the factory is returning, I
just rely on whatever is the default (in 2.x, it's _ClusterConnection_). I
noticed, though, that default connection type changed between 2.x and 3.0, from
_ClusterConnection_ to _AsycnClusterConnection_. So, if we keep _create_
methods referencing generic _Connection_ only, I won't need to change my
_HBaseInterClusterReplicationEndpoint_ extension if I upgrade to hbase 3.x
(provided, of course, that _HBaseInterClusterReplicationEndpoint.conn_ variable
also changes to same default returned by _ConnectionFactory_).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] binlijin commented on a change in pull request #1026: HBASE-23682 Fix NPE when disable DeadServerMetricRegionChore
binlijin commented on a change in pull request #1026: HBASE-23682 Fix NPE when
disable DeadServerMetricRegionChore
URL: https://github.com/apache/hbase/pull/1026#discussion_r367337726
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestDeadServerMetricRegionChore.java
##
@@ -0,0 +1,74 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.master.assignment;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.HBaseTestingUtility;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.testclassification.LargeTests;
+import org.apache.hadoop.hbase.testclassification.MasterTests;
+import org.apache.hadoop.hbase.util.FSUtils;
+import org.junit.After;
+import org.junit.Before;
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+
+/**
+ * Base class for AM test.
+ */
+@Category({ MasterTests.class, LargeTests.class })
+public class TestDeadServerMetricRegionChore {
+
+ @ClassRule
+ public static final HBaseClassTestRule CLASS_RULE =
+HBaseClassTestRule.forClass(TestDeadServerMetricRegionChore.class);
+
+ protected HBaseTestingUtility util;
+
+ protected void setupConfiguration(Configuration conf) throws Exception {
+FSUtils.setRootDir(conf, util.getDataTestDir());
+// Disable DeadServerMetricRegionChore
+
conf.setInt(AssignmentManager.DEAD_REGION_METRIC_CHORE_INTERVAL_MSEC_CONF_KEY,
-1);
+ }
+
+ @Before
+ public void setUp() throws Exception {
+util = new HBaseTestingUtility();
+setupConfiguration(util.getConfiguration());
+ }
+
+ @After
+ public void tearDown() throws Exception {
+ }
+
+ @Test
+ public void testDeadServerMetricRegionChore() throws Exception {
+try {
+ this.util.startMiniCluster();
+ // Master start up normal.
+ final TableName tableName =
TableName.valueOf("testDeadServerMetricRegionChore");
+ this.util.createTable(tableName, "f");
+ this.util.waitTableAvailable(tableName);
+} finally {
+ this.util.killMiniHBaseCluster();
Review comment:
The shutdown has no problem, i already change killMiniHBaseCluster
to shutdownMiniCluster.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1054: HBASE-23625 Reduced number of Checkstyle violations in hbase-common
Apache-HBase commented on issue #1054: HBASE-23625 Reduced number of Checkstyle violations in hbase-common URL: https://github.com/apache/hbase/pull/1054#issuecomment-575085215 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-1 Compile Tests _ | | +1 :green_heart: | mvninstall | 8m 44s | branch-1 passed | | +1 :green_heart: | compile | 0m 18s | branch-1 passed with JDK v1.8.0_232 | | +1 :green_heart: | compile | 0m 23s | branch-1 passed with JDK v1.7.0_242 | | +1 :green_heart: | checkstyle | 0m 36s | branch-1 passed | | +1 :green_heart: | shadedjars | 2m 56s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 27s | branch-1 passed with JDK v1.8.0_232 | | +1 :green_heart: | javadoc | 0m 23s | branch-1 passed with JDK v1.7.0_242 | | +0 :ok: | spotbugs | 1m 14s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 1m 10s | branch-1 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 1m 55s | the patch passed | | +1 :green_heart: | compile | 0m 18s | the patch passed with JDK v1.8.0_232 | | +1 :green_heart: | javac | 0m 18s | the patch passed | | +1 :green_heart: | compile | 0m 21s | the patch passed with JDK v1.7.0_242 | | +1 :green_heart: | javac | 0m 21s | the patch passed | | +1 :green_heart: | checkstyle | 0m 29s | hbase-common: The patch generated 0 new + 0 unchanged - 51 fixed = 0 total (was 51) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 2m 48s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 4m 52s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. | | +1 :green_heart: | javadoc | 0m 19s | the patch passed with JDK v1.8.0_232 | | +1 :green_heart: | javadoc | 0m 23s | the patch passed with JDK v1.7.0_242 | | +1 :green_heart: | findbugs | 1m 11s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 36s | hbase-common in the patch passed. | | +1 :green_heart: | asflicense | 0m 17s | The patch does not generate ASF License warnings. | | | | 34m 41s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1054/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1054 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux cec8e3e6e688 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1054/out/precommit/personality/provided.sh | | git revision | branch-1 / 99a328f | | Default Java | 1.7.0_242 | | Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_232 /usr/lib/jvm/zulu-7-amd64:1.7.0_242 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1054/2/testReport/ | | Max. process+thread count | 112 (vs. ulimit of 1) | | modules | C: hbase-common U: hbase-common | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1054/2/console | | versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] binlijin commented on a change in pull request #1026: HBASE-23682 Fix NPE when disable DeadServerMetricRegionChore
binlijin commented on a change in pull request #1026: HBASE-23682 Fix NPE when
disable DeadServerMetricRegionChore
URL: https://github.com/apache/hbase/pull/1026#discussion_r367337726
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestDeadServerMetricRegionChore.java
##
@@ -0,0 +1,74 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.master.assignment;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.HBaseTestingUtility;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.testclassification.LargeTests;
+import org.apache.hadoop.hbase.testclassification.MasterTests;
+import org.apache.hadoop.hbase.util.FSUtils;
+import org.junit.After;
+import org.junit.Before;
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+
+/**
+ * Base class for AM test.
+ */
+@Category({ MasterTests.class, LargeTests.class })
+public class TestDeadServerMetricRegionChore {
+
+ @ClassRule
+ public static final HBaseClassTestRule CLASS_RULE =
+HBaseClassTestRule.forClass(TestDeadServerMetricRegionChore.class);
+
+ protected HBaseTestingUtility util;
+
+ protected void setupConfiguration(Configuration conf) throws Exception {
+FSUtils.setRootDir(conf, util.getDataTestDir());
+// Disable DeadServerMetricRegionChore
+
conf.setInt(AssignmentManager.DEAD_REGION_METRIC_CHORE_INTERVAL_MSEC_CONF_KEY,
-1);
+ }
+
+ @Before
+ public void setUp() throws Exception {
+util = new HBaseTestingUtility();
+setupConfiguration(util.getConfiguration());
+ }
+
+ @After
+ public void tearDown() throws Exception {
+ }
+
+ @Test
+ public void testDeadServerMetricRegionChore() throws Exception {
+try {
+ this.util.startMiniCluster();
+ // Master start up normal.
+ final TableName tableName =
TableName.valueOf("testDeadServerMetricRegionChore");
+ this.util.createTable(tableName, "f");
+ this.util.waitTableAvailable(tableName);
+} finally {
+ this.util.killMiniHBaseCluster();
Review comment:
The shutdown has no problem.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1046: HBASE-23623 Reduced the number of Checkstyle violations in hbase-rest
Apache-HBase commented on issue #1046: HBASE-23623 Reduced the number of Checkstyle violations in hbase-rest URL: https://github.com/apache/hbase/pull/1046#issuecomment-575081750 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 7m 7s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 11 new or modified test files. | ||| _ branch-1 Compile Tests _ | | +1 :green_heart: | mvninstall | 9m 47s | branch-1 passed | | +1 :green_heart: | compile | 0m 19s | branch-1 passed with JDK v1.8.0_242 | | +1 :green_heart: | compile | 0m 26s | branch-1 passed with JDK v1.7.0_252 | | +1 :green_heart: | checkstyle | 0m 36s | branch-1 passed | | +1 :green_heart: | shadedjars | 2m 53s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 28s | branch-1 passed with JDK v1.8.0_242 | | +1 :green_heart: | javadoc | 0m 26s | branch-1 passed with JDK v1.7.0_252 | | +0 :ok: | spotbugs | 1m 15s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 1m 11s | branch-1 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 1m 55s | the patch passed | | +1 :green_heart: | compile | 0m 21s | the patch passed with JDK v1.8.0_242 | | +1 :green_heart: | javac | 0m 21s | the patch passed | | +1 :green_heart: | compile | 0m 26s | the patch passed with JDK v1.7.0_252 | | +1 :green_heart: | javac | 0m 26s | the patch passed | | +1 :green_heart: | checkstyle | 0m 30s | hbase-rest: The patch generated 0 new + 21 unchanged - 49 fixed = 21 total (was 70) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 2m 50s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 5m 3s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. | | +1 :green_heart: | javadoc | 0m 19s | the patch passed with JDK v1.8.0_242 | | +1 :green_heart: | javadoc | 0m 26s | the patch passed with JDK v1.7.0_252 | | +1 :green_heart: | findbugs | 1m 12s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 14m 5s | hbase-rest in the patch passed. | | +1 :green_heart: | asflicense | 0m 17s | The patch does not generate ASF License warnings. | | | | 54m 20s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1046 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 760cad888e64 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1046/out/precommit/personality/provided.sh | | git revision | branch-1 / 99a328f | | Default Java | 1.7.0_252 | | Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_242 /usr/lib/jvm/zulu-7-amd64:1.7.0_252 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/3/testReport/ | | Max. process+thread count | 2031 (vs. ulimit of 1) | | modules | C: hbase-rest U: hbase-rest | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/3/console | | versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1026: HBASE-23682 Fix NPE when disable DeadServerMetricRegionChore
HorizonNet commented on a change in pull request #1026: HBASE-23682 Fix NPE
when disable DeadServerMetricRegionChore
URL: https://github.com/apache/hbase/pull/1026#discussion_r367327702
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestDeadServerMetricRegionChore.java
##
@@ -0,0 +1,74 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.master.assignment;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.HBaseTestingUtility;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.testclassification.LargeTests;
+import org.apache.hadoop.hbase.testclassification.MasterTests;
+import org.apache.hadoop.hbase.util.FSUtils;
+import org.junit.After;
+import org.junit.Before;
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+
+/**
+ * Base class for AM test.
+ */
+@Category({ MasterTests.class, LargeTests.class })
+public class TestDeadServerMetricRegionChore {
+
+ @ClassRule
+ public static final HBaseClassTestRule CLASS_RULE =
+HBaseClassTestRule.forClass(TestDeadServerMetricRegionChore.class);
+
+ protected HBaseTestingUtility util;
+
+ protected void setupConfiguration(Configuration conf) throws Exception {
+FSUtils.setRootDir(conf, util.getDataTestDir());
+// Disable DeadServerMetricRegionChore
+
conf.setInt(AssignmentManager.DEAD_REGION_METRIC_CHORE_INTERVAL_MSEC_CONF_KEY,
-1);
+ }
+
+ @Before
+ public void setUp() throws Exception {
+util = new HBaseTestingUtility();
+setupConfiguration(util.getConfiguration());
+ }
+
+ @After
+ public void tearDown() throws Exception {
+ }
+
+ @Test
+ public void testDeadServerMetricRegionChore() throws Exception {
+try {
+ this.util.startMiniCluster();
+ // Master start up normal.
+ final TableName tableName =
TableName.valueOf("testDeadServerMetricRegionChore");
+ this.util.createTable(tableName, "f");
+ this.util.waitTableAvailable(tableName);
+} finally {
+ this.util.killMiniHBaseCluster();
Review comment:
Is the shutdown failing or because it is part of the `tearDown`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1046: HBASE-23623 Reduced the number of Checkstyle violations in hbase-rest
HorizonNet commented on a change in pull request #1046: HBASE-23623 Reduced the number of Checkstyle violations in hbase-rest URL: https://github.com/apache/hbase/pull/1046#discussion_r367307938 ## File path: hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/client/TestRemoteTable.java ## @@ -1,5 +1,4 @@ -/* - * +/** Review comment: Fixed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1046: HBASE-23623 Reduced the number of Checkstyle violations in hbase-rest
HorizonNet commented on a change in pull request #1046: HBASE-23623 Reduced the number of Checkstyle violations in hbase-rest URL: https://github.com/apache/hbase/pull/1046#discussion_r367307878 ## File path: hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestSchemaResource.java ## @@ -1,5 +1,4 @@ -/* - * +/** Review comment: Fixed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1046: HBASE-23623 Reduced the number of Checkstyle violations in hbase-rest
HorizonNet commented on a change in pull request #1046: HBASE-23623 Reduced the number of Checkstyle violations in hbase-rest URL: https://github.com/apache/hbase/pull/1046#discussion_r367307810 ## File path: hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestNamespacesResource.java ## @@ -1,5 +1,4 @@ -/* - * +/** Review comment: Fixed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1046: HBASE-23623 Reduced the number of Checkstyle violations in hbase-rest
HorizonNet commented on a change in pull request #1046: HBASE-23623 Reduced the number of Checkstyle violations in hbase-rest URL: https://github.com/apache/hbase/pull/1046#discussion_r367307844 ## File path: hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestScannersWithLabels.java ## @@ -1,4 +1,4 @@ -/* +/** Review comment: Fixed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
