[jira] [Commented] (HBASE-22514) Move rsgroup feature into core of HBase
[
https://issues.apache.org/jira/browse/HBASE-22514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17042379#comment-17042379
]
Hudson commented on HBASE-22514:
Results for branch HBASE-22514
[build #281 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/281/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/281//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/281//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/281//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Move rsgroup feature into core of HBase
> ---
>
> Key: HBASE-22514
> URL: https://issues.apache.org/jira/browse/HBASE-22514
> Project: HBase
> Issue Type: Umbrella
> Components: Admin, Client, rsgroup
>Reporter: Yechao Chen
>Assignee: Duo Zhang
>Priority: Major
> Attachments: HBASE-22514.master.001.patch,
> image-2019-05-31-18-25-38-217.png
>
>
> The class RSGroupAdminClient is not public
> we need to use java api RSGroupAdminClient to manager RSG
> so RSGroupAdminClient should be public
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1195: HBASE-23876 [WIP] Add JDK11 compilation and unit test support to nightly job
Apache-HBase commented on issue #1195: HBASE-23876 [WIP] Add JDK11 compilation and unit test support to nightly job URL: https://github.com/apache/hbase/pull/1195#issuecomment-589918372 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m 20s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 1s | Shelldocs was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 2s | master passed | | +1 :green_heart: | compile | 4m 1s | master passed with JDK v2020-01-14 | | +1 :green_heart: | compile | 3m 20s | master passed with JDK v1.8.0_232 | | +1 :green_heart: | shadedjars | 5m 11s | branch has no errors when building our shaded downstream artifacts. | | -1 :x: | javadoc | 0m 48s | root in master failed with JDK v2020-01-14. | | +1 :green_heart: | javadoc | 5m 37s | master passed with JDK v1.8.0_232 | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 20s | the patch passed | | +1 :green_heart: | compile | 6m 2s | the patch passed with JDK v2020-01-14 | | +1 :green_heart: | javac | 6m 2s | the patch passed | | +1 :green_heart: | compile | 3m 34s | the patch passed with JDK v1.8.0_232 | | +1 :green_heart: | javac | 3m 35s | the patch passed | | +1 :green_heart: | hadolint | 0m 1s | The patch generated 0 new + 0 unchanged - 4 fixed = 0 total (was 4) | | +1 :green_heart: | shellcheck | 0m 2s | There were no new shellcheck issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. | | +1 :green_heart: | shadedjars | 5m 6s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 17m 43s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | -1 :x: | javadoc | 0m 19s | root in the patch failed with JDK v2020-01-14. | | +1 :green_heart: | javadoc | 2m 50s | the patch passed with JDK v1.8.0_232 | ||| _ Other Tests _ | | -1 :x: | unit | 156m 38s | root in the patch failed with JDK v1.8.0_232. | | +1 :green_heart: | asflicense | 0m 32s | The patch does not generate ASF License warnings. | | | | 239m 25s | | | Reason | Tests | |---:|:--| | JDK v2020-01-14 Failed junit tests | hadoop.hbase.util.TestFutureUtils | | JDK v1.8.0_232 Failed junit tests | hadoop.hbase.rsgroup.TestRSGroupsKillRS | | | hadoop.hbase.rsgroup.TestRSGroupsBasics | | | hadoop.hbase.rsgroup.TestEnableRSGroups | | | hadoop.hbase.master.procedure.TestSCPWithReplicasWithRSGroup | | | hadoop.hbase.rsgroup.TestRSGroupsOfflineMode | | | hadoop.hbase.rsgroup.TestRSGroupsWithACL | | | hadoop.hbase.rsgroup.TestRSGroupsAdmin1 | | | hadoop.hbase.rsgroup.TestRSGroupMajorCompactionTTL | | | hadoop.hbase.rsgroup.TestRSGroupsBalance | | | hadoop.hbase.coprocessor.TestCoprocessorServiceBackwardCompatibility | | | hadoop.hbase.coprocessor.TestBatchCoprocessorEndpoint | | | hadoop.hbase.coprocessor.TestCoprocessorTableEndpoint | | | hadoop.hbase.coprocessor.TestRowProcessorEndpoint | | | hadoop.hbase.coprocessor.TestClassLoading | | | hadoop.hbase.regionserver.TestServerCustomProtocol | | | hadoop.hbase.coprocessor.TestImportExport | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1195/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1195 | | Optional Tests | dupname asflicense hadolint shellcheck shelldocs javac javadoc unit shadedjars hadoopcheck xml compile | | uname | Linux 857c24b655d9 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1195/out/precommit/personality/provided.sh | | git revision | master / 400b7ce954 | | Default Java | 1.8.0_232 | | Multi-JDK versions | /usr/lib/jvm/jdk-11.0.6+10:2020-01-14 /usr/lib/jvm/jdk8u232-b09:1.8.0_232 | | javadoc |
[jira] [Commented] (HBASE-23854) Documentation update of external_apis.adoc#example-scala-code
[
https://issues.apache.org/jira/browse/HBASE-23854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17042371#comment-17042371
]
Hudson commented on HBASE-23854:
Results for branch branch-2.1
[build #1812 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1812/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1812//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1812//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1812//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Documentation update of external_apis.adoc#example-scala-code
> -
>
> Key: HBASE-23854
> URL: https://issues.apache.org/jira/browse/HBASE-23854
> Project: HBase
> Issue Type: Task
> Components: documentation
>Reporter: Michael Heil
>Assignee: Michael Heil
>Priority: Trivial
> Labels: beginner
> Fix For: 3.0.0, 2.3.0, 2.2.4, 2.1.10
>
> Attachments: HBASE-23854.patch
>
>
> Update the Example Scala Code in the Reference Guide as it contains
> deprecated content such as
> * new HBaseConfiguration()
> * new HTable(conf, "mytable")
> * add(Bytes.toBytes("ids"),Bytes.toBytes("id1"),Bytes.toBytes("one"))
> Replace it with:
> * HBaseConfiguration.create()
> * TableName.valueOf({color:#6a8759}"mytable"{color})
> *
> addColumn(Bytes.toBytes({color:#6a8759}"ids"{color}){color:#cc7832},{color}Bytes.toBytes({color:#6a8759}"id1"{color}){color:#cc7832},{color}Bytes.toBytes({color:#6a8759}"one"{color}))
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-22040) Add mergeRegionsAsync with a List of region names method in AsyncAdmin
[ https://issues.apache.org/jira/browse/HBASE-22040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17042359#comment-17042359 ] Duo Zhang commented on HBASE-22040: --- I'm OK with backporting this if you want. Adding new methods Admin interface can theoretically break the compatibility if someone implements the interface but it is fine(we've mentioned this in our refguide as these interfaces are not supposed to be implement by users). Just go ahead. [~sakthi]. > Add mergeRegionsAsync with a List of region names method in AsyncAdmin > -- > > Key: HBASE-22040 > URL: https://issues.apache.org/jira/browse/HBASE-22040 > Project: HBase > Issue Type: Sub-task > Components: Admin, asyncclient, Client >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0, 2.2.0, 2.3.0 > > Attachments: HBASE-22040-branch-2.patch, HBASE-22040-v1.patch, > HBASE-22040-v2.patch, HBASE-22040-v3.patch, HBASE-22040.patch > > > Although we only support merging two regions until now, but the rpc protocol > does support passing more than two regions to master. > So I think we should provide the methods, but need to add comments to say > that for now we only support merging two regions so do not try to pass more > than two regions. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] busbey commented on issue #1196: HBASE-23755. [OpenTracing] Declare HTrace is unusable in the user doc
busbey commented on issue #1196: HBASE-23755. [OpenTracing] Declare HTrace is unusable in the user doc URL: https://github.com/apache/hbase/pull/1196#issuecomment-589910940 let's delete the section instead? and update the htrace note in the upgrade paths section to note that it's broken? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log
bharathv commented on a change in pull request #754: HBASE-22978 : Online slow
response log
URL: https://github.com/apache/hbase/pull/754#discussion_r382879831
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/slowlog/TestSlowLogRecorder.java
##
@@ -0,0 +1,522 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hbase.regionserver.slowlog;
+
+import java.io.IOException;
+import java.net.InetAddress;
+import java.security.PrivilegedAction;
+import java.security.PrivilegedExceptionAction;
+import java.util.List;
+import java.util.Optional;
+import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.TimeUnit;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.CellScanner;
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.HBaseTestingUtility;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.ipc.RpcCall;
+import org.apache.hadoop.hbase.ipc.RpcCallback;
+import org.apache.hadoop.hbase.security.User;
+import org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos;
+import org.apache.hadoop.hbase.shaded.protobuf.generated.HBaseProtos;
+import org.apache.hadoop.hbase.shaded.protobuf.generated.RPCProtos;
+import org.apache.hadoop.hbase.testclassification.MasterTests;
+import org.apache.hadoop.hbase.testclassification.MediumTests;
+import org.apache.hbase.thirdparty.com.google.protobuf.BlockingService;
+import org.apache.hbase.thirdparty.com.google.protobuf.ByteString;
+import org.apache.hbase.thirdparty.com.google.protobuf.Descriptors;
+import org.apache.hbase.thirdparty.com.google.protobuf.Message;
+import org.junit.Assert;
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import
org.apache.hbase.thirdparty.com.google.common.util.concurrent.Uninterruptibles;
+
+import org.apache.hadoop.hbase.shaded.protobuf.generated.AdminProtos;
+import
org.apache.hadoop.hbase.shaded.protobuf.generated.TooSlowLog.SlowLogPayload;
+
+/**
+ * Tests for Online SlowLog Provider Service
+ */
+@Category({MasterTests.class, MediumTests.class})
+public class TestSlowLogRecorder {
+
+ @ClassRule
+ public static final HBaseClassTestRule CLASS_RULE =
+HBaseClassTestRule.forClass(TestSlowLogRecorder.class);
+
+ private static final Logger LOG =
LoggerFactory.getLogger(TestSlowLogRecorder.class);
+
+ private static final HBaseTestingUtility HBASE_TESTING_UTILITY = new
HBaseTestingUtility();
+
+ private SlowLogRecorder slowLogRecorder;
+
+ private static Configuration applySlowLogRecorderConf(int eventSize) {
+Configuration conf = HBASE_TESTING_UTILITY.getConfiguration();
+conf.setBoolean(HConstants.SLOW_LOG_BUFFER_ENABLED_KEY, true);
+conf.setInt("hbase.regionserver.slowlog.ringbuffer.size", eventSize);
+return conf;
+ }
+
+ /**
+ * confirm that for a ringbuffer of slow logs, payload on given index of
buffer
+ * has expected elements
+ *
+ * @param i index of ringbuffer logs
+ * @param j data value that was put on index i
+ * @param slowLogPayloads list of payload retrieved from {@link
SlowLogRecorder}
+ */
+ private void confirmPayloadParams(int i, int j, List
slowLogPayloads) {
+Assert.assertEquals(slowLogPayloads.get(i).getClientAddress(), "client_" +
j);
+Assert.assertEquals(slowLogPayloads.get(i).getUserName(), "userName_" + j);
+Assert.assertEquals(slowLogPayloads.get(i).getServerClass(), "class_" + j);
+ }
+
+ @Test
+ public void testOnlieSlowLogConsumption() throws Exception {
+Configuration conf = applySlowLogRecorderConf(8);
+slowLogRecorder = new SlowLogRecorder(conf);
+AdminProtos.SlowLogResponseRequest request =
+ AdminProtos.SlowLogResponseRequest.newBuilder().setLimit(15).build();
+Assert.assertEquals(slowLogRecorder.getSlowLogPayloads(request).size(), 0);
+LOG.debug("Initially ringbuffer of Slow Log records is empty");
+
+int i = 0;
+
+// add 5 records initially
+for (; i < 5; i++) {
+ RpcLogDetails rpcLogDetails =
+
[GitHub] [hbase] bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log
bharathv commented on a change in pull request #754: HBASE-22978 : Online slow
response log
URL: https://github.com/apache/hbase/pull/754#discussion_r382872894
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/slowlog/SlowLogEventHandler.java
##
@@ -0,0 +1,205 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hbase.regionserver.slowlog;
+
+import com.lmax.disruptor.EventHandler;
+import com.lmax.disruptor.RingBuffer;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.List;
+import java.util.Queue;
+import java.util.stream.Collectors;
+
+import org.apache.commons.lang3.StringUtils;
+import org.apache.hadoop.hbase.client.SlowLogParams;
+import org.apache.hadoop.hbase.ipc.RpcCall;
+import org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos;
+import org.apache.hbase.thirdparty.com.google.protobuf.Descriptors;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import org.apache.hbase.thirdparty.com.google.common.collect.EvictingQueue;
+import org.apache.hbase.thirdparty.com.google.common.collect.Queues;
+import org.apache.hbase.thirdparty.com.google.protobuf.Message;
+
+import org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil;
+import org.apache.hadoop.hbase.shaded.protobuf.generated.AdminProtos;
+import
org.apache.hadoop.hbase.shaded.protobuf.generated.TooSlowLog.SlowLogPayload;
+
+/**
+ * Event Handler run by disruptor ringbuffer consumer
+ */
+@InterfaceAudience.Private
+class SlowLogEventHandler implements EventHandler {
+
+ private static final Logger LOG =
LoggerFactory.getLogger(SlowLogEventHandler.class);
+
+ private final Queue queue;
+
+ SlowLogEventHandler(int eventCount) {
+EvictingQueue evictingQueue =
EvictingQueue.create(eventCount);
+queue = Queues.synchronizedQueue(evictingQueue);
+ }
+
+ /**
+ * Called when a publisher has published an event to the {@link RingBuffer}
+ *
+ * @param event published to the {@link RingBuffer}
+ * @param sequence of the event being processed
+ * @param endOfBatch flag to indicate if this is the last event in a batch
from
+ * the {@link RingBuffer}
+ * @throws Exception if the EventHandler would like the exception handled
further up the chain
+ */
+ @Override
+ public void onEvent(RingBufferEnvelope event, long sequence, boolean
endOfBatch)
+ throws Exception {
+final RpcLogDetails rpcCallDetails = event.getPayload();
+final RpcCall rpcCall = rpcCallDetails.getRpcCall();
+final String clientAddress = rpcCallDetails.getClientAddress();
+final long responseSize = rpcCallDetails.getResponseSize();
+final String className = rpcCallDetails.getClassName();
+Descriptors.MethodDescriptor methodDescriptor = rpcCall.getMethod();
+Message param = rpcCall.getParam();
+long receiveTime = rpcCall.getReceiveTime();
+long startTime = rpcCall.getStartTime();
+long endTime = System.currentTimeMillis();
+int processingTime = (int) (endTime - startTime);
+int qTime = (int) (startTime - receiveTime);
+final SlowLogParams slowLogParams = ProtobufUtil.getSlowLogParams(param);
+int numGets = 0;
+int numMutations = 0;
+int numServiceCalls = 0;
+if (param instanceof ClientProtos.MultiRequest) {
+ ClientProtos.MultiRequest multi = (ClientProtos.MultiRequest) param;
+ for (ClientProtos.RegionAction regionAction :
multi.getRegionActionList()) {
+for (ClientProtos.Action action : regionAction.getActionList()) {
+ if (action.hasMutation()) {
+numMutations++;
+ }
+ if (action.hasGet()) {
+numGets++;
+ }
+ if (action.hasServiceCall()) {
+numServiceCalls++;
+ }
+}
+ }
+}
+final String userName =
rpcCall.getRequestUserName().orElse(StringUtils.EMPTY);
+final String methodDescriptorName =
+ methodDescriptor != null ? methodDescriptor.getName() :
StringUtils.EMPTY;
+SlowLogPayload slowLogPayload = SlowLogPayload.newBuilder()
+ .setCallDetails(methodDescriptorName +
[GitHub] [hbase] bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log
bharathv commented on a change in pull request #754: HBASE-22978 : Online slow
response log
URL: https://github.com/apache/hbase/pull/754#discussion_r382878329
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/slowlog/RingBufferEnvelope.java
##
@@ -0,0 +1,57 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hbase.regionserver.slowlog;
+
+import org.apache.hadoop.hbase.ipc.RpcCall;
+import org.apache.yetus.audience.InterfaceAudience;
+
+
+/**
+ * An envelope to carry payload in the slow log ring buffer that serves as
online buffer
+ * to provide latest TooSlowLog
+ */
+@InterfaceAudience.Private
+final class RingBufferEnvelope {
+
+ private RpcLogDetails rpcLogDetails;
+
+ /**
+ * Load the Truck with {@link RpcCall}
Review comment:
nit: whats a Truck.. don't think thats a disruptor terminilogy...
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log
bharathv commented on a change in pull request #754: HBASE-22978 : Online slow
response log
URL: https://github.com/apache/hbase/pull/754#discussion_r382874132
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/slowlog/SlowLogEventHandler.java
##
@@ -0,0 +1,205 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hbase.regionserver.slowlog;
+
+import com.lmax.disruptor.EventHandler;
+import com.lmax.disruptor.RingBuffer;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.List;
+import java.util.Queue;
+import java.util.stream.Collectors;
+
+import org.apache.commons.lang3.StringUtils;
+import org.apache.hadoop.hbase.client.SlowLogParams;
+import org.apache.hadoop.hbase.ipc.RpcCall;
+import org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos;
+import org.apache.hbase.thirdparty.com.google.protobuf.Descriptors;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import org.apache.hbase.thirdparty.com.google.common.collect.EvictingQueue;
+import org.apache.hbase.thirdparty.com.google.common.collect.Queues;
+import org.apache.hbase.thirdparty.com.google.protobuf.Message;
+
+import org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil;
+import org.apache.hadoop.hbase.shaded.protobuf.generated.AdminProtos;
+import
org.apache.hadoop.hbase.shaded.protobuf.generated.TooSlowLog.SlowLogPayload;
+
+/**
+ * Event Handler run by disruptor ringbuffer consumer
+ */
+@InterfaceAudience.Private
+class SlowLogEventHandler implements EventHandler {
+
+ private static final Logger LOG =
LoggerFactory.getLogger(SlowLogEventHandler.class);
+
+ private final Queue queue;
+
+ SlowLogEventHandler(int eventCount) {
+EvictingQueue evictingQueue =
EvictingQueue.create(eventCount);
+queue = Queues.synchronizedQueue(evictingQueue);
+ }
+
+ /**
+ * Called when a publisher has published an event to the {@link RingBuffer}
+ *
+ * @param event published to the {@link RingBuffer}
+ * @param sequence of the event being processed
+ * @param endOfBatch flag to indicate if this is the last event in a batch
from
+ * the {@link RingBuffer}
+ * @throws Exception if the EventHandler would like the exception handled
further up the chain
+ */
+ @Override
+ public void onEvent(RingBufferEnvelope event, long sequence, boolean
endOfBatch)
+ throws Exception {
+final RpcLogDetails rpcCallDetails = event.getPayload();
+final RpcCall rpcCall = rpcCallDetails.getRpcCall();
+final String clientAddress = rpcCallDetails.getClientAddress();
+final long responseSize = rpcCallDetails.getResponseSize();
+final String className = rpcCallDetails.getClassName();
+Descriptors.MethodDescriptor methodDescriptor = rpcCall.getMethod();
+Message param = rpcCall.getParam();
+long receiveTime = rpcCall.getReceiveTime();
+long startTime = rpcCall.getStartTime();
+long endTime = System.currentTimeMillis();
+int processingTime = (int) (endTime - startTime);
+int qTime = (int) (startTime - receiveTime);
+final SlowLogParams slowLogParams = ProtobufUtil.getSlowLogParams(param);
+int numGets = 0;
+int numMutations = 0;
+int numServiceCalls = 0;
+if (param instanceof ClientProtos.MultiRequest) {
+ ClientProtos.MultiRequest multi = (ClientProtos.MultiRequest) param;
+ for (ClientProtos.RegionAction regionAction :
multi.getRegionActionList()) {
+for (ClientProtos.Action action : regionAction.getActionList()) {
+ if (action.hasMutation()) {
+numMutations++;
+ }
+ if (action.hasGet()) {
+numGets++;
+ }
+ if (action.hasServiceCall()) {
+numServiceCalls++;
+ }
+}
+ }
+}
+final String userName =
rpcCall.getRequestUserName().orElse(StringUtils.EMPTY);
+final String methodDescriptorName =
+ methodDescriptor != null ? methodDescriptor.getName() :
StringUtils.EMPTY;
+SlowLogPayload slowLogPayload = SlowLogPayload.newBuilder()
+ .setCallDetails(methodDescriptorName +
[GitHub] [hbase] bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log
bharathv commented on a change in pull request #754: HBASE-22978 : Online slow
response log
URL: https://github.com/apache/hbase/pull/754#discussion_r382872128
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/slowlog/SlowLogEventHandler.java
##
@@ -0,0 +1,205 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hbase.regionserver.slowlog;
+
+import com.lmax.disruptor.EventHandler;
+import com.lmax.disruptor.RingBuffer;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.List;
+import java.util.Queue;
+import java.util.stream.Collectors;
+
+import org.apache.commons.lang3.StringUtils;
+import org.apache.hadoop.hbase.client.SlowLogParams;
+import org.apache.hadoop.hbase.ipc.RpcCall;
+import org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos;
+import org.apache.hbase.thirdparty.com.google.protobuf.Descriptors;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import org.apache.hbase.thirdparty.com.google.common.collect.EvictingQueue;
+import org.apache.hbase.thirdparty.com.google.common.collect.Queues;
+import org.apache.hbase.thirdparty.com.google.protobuf.Message;
+
+import org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil;
+import org.apache.hadoop.hbase.shaded.protobuf.generated.AdminProtos;
+import
org.apache.hadoop.hbase.shaded.protobuf.generated.TooSlowLog.SlowLogPayload;
+
+/**
+ * Event Handler run by disruptor ringbuffer consumer
+ */
+@InterfaceAudience.Private
+class SlowLogEventHandler implements EventHandler {
+
+ private static final Logger LOG =
LoggerFactory.getLogger(SlowLogEventHandler.class);
+
+ private final Queue queue;
+
+ SlowLogEventHandler(int eventCount) {
+EvictingQueue evictingQueue =
EvictingQueue.create(eventCount);
+queue = Queues.synchronizedQueue(evictingQueue);
+ }
+
+ /**
+ * Called when a publisher has published an event to the {@link RingBuffer}
+ *
+ * @param event published to the {@link RingBuffer}
+ * @param sequence of the event being processed
+ * @param endOfBatch flag to indicate if this is the last event in a batch
from
+ * the {@link RingBuffer}
+ * @throws Exception if the EventHandler would like the exception handled
further up the chain
+ */
+ @Override
+ public void onEvent(RingBufferEnvelope event, long sequence, boolean
endOfBatch)
+ throws Exception {
+final RpcLogDetails rpcCallDetails = event.getPayload();
+final RpcCall rpcCall = rpcCallDetails.getRpcCall();
+final String clientAddress = rpcCallDetails.getClientAddress();
+final long responseSize = rpcCallDetails.getResponseSize();
+final String className = rpcCallDetails.getClassName();
+Descriptors.MethodDescriptor methodDescriptor = rpcCall.getMethod();
+Message param = rpcCall.getParam();
+long receiveTime = rpcCall.getReceiveTime();
+long startTime = rpcCall.getStartTime();
+long endTime = System.currentTimeMillis();
+int processingTime = (int) (endTime - startTime);
+int qTime = (int) (startTime - receiveTime);
+final SlowLogParams slowLogParams = ProtobufUtil.getSlowLogParams(param);
+int numGets = 0;
+int numMutations = 0;
+int numServiceCalls = 0;
+if (param instanceof ClientProtos.MultiRequest) {
+ ClientProtos.MultiRequest multi = (ClientProtos.MultiRequest) param;
+ for (ClientProtos.RegionAction regionAction :
multi.getRegionActionList()) {
+for (ClientProtos.Action action : regionAction.getActionList()) {
+ if (action.hasMutation()) {
+numMutations++;
+ }
+ if (action.hasGet()) {
+numGets++;
+ }
+ if (action.hasServiceCall()) {
+numServiceCalls++;
+ }
+}
+ }
+}
+final String userName =
rpcCall.getRequestUserName().orElse(StringUtils.EMPTY);
+final String methodDescriptorName =
+ methodDescriptor != null ? methodDescriptor.getName() :
StringUtils.EMPTY;
+SlowLogPayload slowLogPayload = SlowLogPayload.newBuilder()
+ .setCallDetails(methodDescriptorName +
[GitHub] [hbase] bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log
bharathv commented on a change in pull request #754: HBASE-22978 : Online slow
response log
URL: https://github.com/apache/hbase/pull/754#discussion_r382879850
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/slowlog/TestSlowLogRecorder.java
##
@@ -0,0 +1,522 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hbase.regionserver.slowlog;
+
+import java.io.IOException;
+import java.net.InetAddress;
+import java.security.PrivilegedAction;
+import java.security.PrivilegedExceptionAction;
+import java.util.List;
+import java.util.Optional;
+import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.TimeUnit;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.CellScanner;
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.HBaseTestingUtility;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.ipc.RpcCall;
+import org.apache.hadoop.hbase.ipc.RpcCallback;
+import org.apache.hadoop.hbase.security.User;
+import org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos;
+import org.apache.hadoop.hbase.shaded.protobuf.generated.HBaseProtos;
+import org.apache.hadoop.hbase.shaded.protobuf.generated.RPCProtos;
+import org.apache.hadoop.hbase.testclassification.MasterTests;
+import org.apache.hadoop.hbase.testclassification.MediumTests;
+import org.apache.hbase.thirdparty.com.google.protobuf.BlockingService;
+import org.apache.hbase.thirdparty.com.google.protobuf.ByteString;
+import org.apache.hbase.thirdparty.com.google.protobuf.Descriptors;
+import org.apache.hbase.thirdparty.com.google.protobuf.Message;
+import org.junit.Assert;
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import
org.apache.hbase.thirdparty.com.google.common.util.concurrent.Uninterruptibles;
+
+import org.apache.hadoop.hbase.shaded.protobuf.generated.AdminProtos;
+import
org.apache.hadoop.hbase.shaded.protobuf.generated.TooSlowLog.SlowLogPayload;
+
+/**
+ * Tests for Online SlowLog Provider Service
+ */
+@Category({MasterTests.class, MediumTests.class})
+public class TestSlowLogRecorder {
+
+ @ClassRule
+ public static final HBaseClassTestRule CLASS_RULE =
+HBaseClassTestRule.forClass(TestSlowLogRecorder.class);
+
+ private static final Logger LOG =
LoggerFactory.getLogger(TestSlowLogRecorder.class);
+
+ private static final HBaseTestingUtility HBASE_TESTING_UTILITY = new
HBaseTestingUtility();
+
+ private SlowLogRecorder slowLogRecorder;
+
+ private static Configuration applySlowLogRecorderConf(int eventSize) {
+Configuration conf = HBASE_TESTING_UTILITY.getConfiguration();
+conf.setBoolean(HConstants.SLOW_LOG_BUFFER_ENABLED_KEY, true);
+conf.setInt("hbase.regionserver.slowlog.ringbuffer.size", eventSize);
+return conf;
+ }
+
+ /**
+ * confirm that for a ringbuffer of slow logs, payload on given index of
buffer
+ * has expected elements
+ *
+ * @param i index of ringbuffer logs
+ * @param j data value that was put on index i
+ * @param slowLogPayloads list of payload retrieved from {@link
SlowLogRecorder}
+ */
+ private void confirmPayloadParams(int i, int j, List
slowLogPayloads) {
+Assert.assertEquals(slowLogPayloads.get(i).getClientAddress(), "client_" +
j);
+Assert.assertEquals(slowLogPayloads.get(i).getUserName(), "userName_" + j);
+Assert.assertEquals(slowLogPayloads.get(i).getServerClass(), "class_" + j);
+ }
+
+ @Test
+ public void testOnlieSlowLogConsumption() throws Exception {
+Configuration conf = applySlowLogRecorderConf(8);
+slowLogRecorder = new SlowLogRecorder(conf);
+AdminProtos.SlowLogResponseRequest request =
+ AdminProtos.SlowLogResponseRequest.newBuilder().setLimit(15).build();
+Assert.assertEquals(slowLogRecorder.getSlowLogPayloads(request).size(), 0);
+LOG.debug("Initially ringbuffer of Slow Log records is empty");
+
+int i = 0;
+
+// add 5 records initially
+for (; i < 5; i++) {
+ RpcLogDetails rpcLogDetails =
+
[GitHub] [hbase] bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log
bharathv commented on a change in pull request #754: HBASE-22978 : Online slow
response log
URL: https://github.com/apache/hbase/pull/754#discussion_r382879845
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/slowlog/TestSlowLogRecorder.java
##
@@ -0,0 +1,522 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hbase.regionserver.slowlog;
+
+import java.io.IOException;
+import java.net.InetAddress;
+import java.security.PrivilegedAction;
+import java.security.PrivilegedExceptionAction;
+import java.util.List;
+import java.util.Optional;
+import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.TimeUnit;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.CellScanner;
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.HBaseTestingUtility;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.ipc.RpcCall;
+import org.apache.hadoop.hbase.ipc.RpcCallback;
+import org.apache.hadoop.hbase.security.User;
+import org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos;
+import org.apache.hadoop.hbase.shaded.protobuf.generated.HBaseProtos;
+import org.apache.hadoop.hbase.shaded.protobuf.generated.RPCProtos;
+import org.apache.hadoop.hbase.testclassification.MasterTests;
+import org.apache.hadoop.hbase.testclassification.MediumTests;
+import org.apache.hbase.thirdparty.com.google.protobuf.BlockingService;
+import org.apache.hbase.thirdparty.com.google.protobuf.ByteString;
+import org.apache.hbase.thirdparty.com.google.protobuf.Descriptors;
+import org.apache.hbase.thirdparty.com.google.protobuf.Message;
+import org.junit.Assert;
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import
org.apache.hbase.thirdparty.com.google.common.util.concurrent.Uninterruptibles;
+
+import org.apache.hadoop.hbase.shaded.protobuf.generated.AdminProtos;
+import
org.apache.hadoop.hbase.shaded.protobuf.generated.TooSlowLog.SlowLogPayload;
+
+/**
+ * Tests for Online SlowLog Provider Service
+ */
+@Category({MasterTests.class, MediumTests.class})
+public class TestSlowLogRecorder {
+
+ @ClassRule
+ public static final HBaseClassTestRule CLASS_RULE =
+HBaseClassTestRule.forClass(TestSlowLogRecorder.class);
+
+ private static final Logger LOG =
LoggerFactory.getLogger(TestSlowLogRecorder.class);
+
+ private static final HBaseTestingUtility HBASE_TESTING_UTILITY = new
HBaseTestingUtility();
+
+ private SlowLogRecorder slowLogRecorder;
+
+ private static Configuration applySlowLogRecorderConf(int eventSize) {
+Configuration conf = HBASE_TESTING_UTILITY.getConfiguration();
+conf.setBoolean(HConstants.SLOW_LOG_BUFFER_ENABLED_KEY, true);
+conf.setInt("hbase.regionserver.slowlog.ringbuffer.size", eventSize);
+return conf;
+ }
+
+ /**
+ * confirm that for a ringbuffer of slow logs, payload on given index of
buffer
+ * has expected elements
+ *
+ * @param i index of ringbuffer logs
+ * @param j data value that was put on index i
+ * @param slowLogPayloads list of payload retrieved from {@link
SlowLogRecorder}
+ */
+ private void confirmPayloadParams(int i, int j, List
slowLogPayloads) {
+Assert.assertEquals(slowLogPayloads.get(i).getClientAddress(), "client_" +
j);
+Assert.assertEquals(slowLogPayloads.get(i).getUserName(), "userName_" + j);
+Assert.assertEquals(slowLogPayloads.get(i).getServerClass(), "class_" + j);
+ }
+
+ @Test
+ public void testOnlieSlowLogConsumption() throws Exception {
+Configuration conf = applySlowLogRecorderConf(8);
+slowLogRecorder = new SlowLogRecorder(conf);
+AdminProtos.SlowLogResponseRequest request =
+ AdminProtos.SlowLogResponseRequest.newBuilder().setLimit(15).build();
+Assert.assertEquals(slowLogRecorder.getSlowLogPayloads(request).size(), 0);
+LOG.debug("Initially ringbuffer of Slow Log records is empty");
+
+int i = 0;
+
+// add 5 records initially
+for (; i < 5; i++) {
+ RpcLogDetails rpcLogDetails =
+
[GitHub] [hbase] bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log
bharathv commented on a change in pull request #754: HBASE-22978 : Online slow
response log
URL: https://github.com/apache/hbase/pull/754#discussion_r382878645
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/slowlog/SlowLogEventHandler.java
##
@@ -0,0 +1,205 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hbase.regionserver.slowlog;
+
+import com.lmax.disruptor.EventHandler;
+import com.lmax.disruptor.RingBuffer;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.List;
+import java.util.Queue;
+import java.util.stream.Collectors;
+
+import org.apache.commons.lang3.StringUtils;
+import org.apache.hadoop.hbase.client.SlowLogParams;
+import org.apache.hadoop.hbase.ipc.RpcCall;
+import org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos;
+import org.apache.hbase.thirdparty.com.google.protobuf.Descriptors;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import org.apache.hbase.thirdparty.com.google.common.collect.EvictingQueue;
+import org.apache.hbase.thirdparty.com.google.common.collect.Queues;
+import org.apache.hbase.thirdparty.com.google.protobuf.Message;
+
+import org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil;
+import org.apache.hadoop.hbase.shaded.protobuf.generated.AdminProtos;
+import
org.apache.hadoop.hbase.shaded.protobuf.generated.TooSlowLog.SlowLogPayload;
+
+/**
+ * Event Handler run by disruptor ringbuffer consumer
+ */
+@InterfaceAudience.Private
+class SlowLogEventHandler implements EventHandler {
+
+ private static final Logger LOG =
LoggerFactory.getLogger(SlowLogEventHandler.class);
+
+ private final Queue queue;
+
+ SlowLogEventHandler(int eventCount) {
+EvictingQueue evictingQueue =
EvictingQueue.create(eventCount);
+queue = Queues.synchronizedQueue(evictingQueue);
+ }
+
+ /**
+ * Called when a publisher has published an event to the {@link RingBuffer}
+ *
+ * @param event published to the {@link RingBuffer}
+ * @param sequence of the event being processed
+ * @param endOfBatch flag to indicate if this is the last event in a batch
from
+ * the {@link RingBuffer}
+ * @throws Exception if the EventHandler would like the exception handled
further up the chain
+ */
+ @Override
+ public void onEvent(RingBufferEnvelope event, long sequence, boolean
endOfBatch)
+ throws Exception {
+final RpcLogDetails rpcCallDetails = event.getPayload();
+final RpcCall rpcCall = rpcCallDetails.getRpcCall();
+final String clientAddress = rpcCallDetails.getClientAddress();
+final long responseSize = rpcCallDetails.getResponseSize();
+final String className = rpcCallDetails.getClassName();
+Descriptors.MethodDescriptor methodDescriptor = rpcCall.getMethod();
+Message param = rpcCall.getParam();
+long receiveTime = rpcCall.getReceiveTime();
+long startTime = rpcCall.getStartTime();
+long endTime = System.currentTimeMillis();
+int processingTime = (int) (endTime - startTime);
+int qTime = (int) (startTime - receiveTime);
+final SlowLogParams slowLogParams = ProtobufUtil.getSlowLogParams(param);
+int numGets = 0;
+int numMutations = 0;
+int numServiceCalls = 0;
+if (param instanceof ClientProtos.MultiRequest) {
+ ClientProtos.MultiRequest multi = (ClientProtos.MultiRequest) param;
+ for (ClientProtos.RegionAction regionAction :
multi.getRegionActionList()) {
+for (ClientProtos.Action action : regionAction.getActionList()) {
+ if (action.hasMutation()) {
+numMutations++;
+ }
+ if (action.hasGet()) {
+numGets++;
+ }
+ if (action.hasServiceCall()) {
+numServiceCalls++;
+ }
+}
+ }
+}
+final String userName =
rpcCall.getRequestUserName().orElse(StringUtils.EMPTY);
+final String methodDescriptorName =
+ methodDescriptor != null ? methodDescriptor.getName() :
StringUtils.EMPTY;
+SlowLogPayload slowLogPayload = SlowLogPayload.newBuilder()
+ .setCallDetails(methodDescriptorName +
[GitHub] [hbase] bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log
bharathv commented on a change in pull request #754: HBASE-22978 : Online slow
response log
URL: https://github.com/apache/hbase/pull/754#discussion_r382878529
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/slowlog/SlowLogEventHandler.java
##
@@ -0,0 +1,205 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hbase.regionserver.slowlog;
+
+import com.lmax.disruptor.EventHandler;
+import com.lmax.disruptor.RingBuffer;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.List;
+import java.util.Queue;
+import java.util.stream.Collectors;
+
+import org.apache.commons.lang3.StringUtils;
+import org.apache.hadoop.hbase.client.SlowLogParams;
+import org.apache.hadoop.hbase.ipc.RpcCall;
+import org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos;
+import org.apache.hbase.thirdparty.com.google.protobuf.Descriptors;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import org.apache.hbase.thirdparty.com.google.common.collect.EvictingQueue;
+import org.apache.hbase.thirdparty.com.google.common.collect.Queues;
+import org.apache.hbase.thirdparty.com.google.protobuf.Message;
+
+import org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil;
+import org.apache.hadoop.hbase.shaded.protobuf.generated.AdminProtos;
+import
org.apache.hadoop.hbase.shaded.protobuf.generated.TooSlowLog.SlowLogPayload;
+
+/**
+ * Event Handler run by disruptor ringbuffer consumer
+ */
+@InterfaceAudience.Private
+class SlowLogEventHandler implements EventHandler {
+
+ private static final Logger LOG =
LoggerFactory.getLogger(SlowLogEventHandler.class);
+
+ private final Queue queue;
+
+ SlowLogEventHandler(int eventCount) {
+EvictingQueue evictingQueue =
EvictingQueue.create(eventCount);
+queue = Queues.synchronizedQueue(evictingQueue);
+ }
+
+ /**
+ * Called when a publisher has published an event to the {@link RingBuffer}
+ *
+ * @param event published to the {@link RingBuffer}
+ * @param sequence of the event being processed
+ * @param endOfBatch flag to indicate if this is the last event in a batch
from
+ * the {@link RingBuffer}
+ * @throws Exception if the EventHandler would like the exception handled
further up the chain
+ */
+ @Override
+ public void onEvent(RingBufferEnvelope event, long sequence, boolean
endOfBatch)
+ throws Exception {
+final RpcLogDetails rpcCallDetails = event.getPayload();
+final RpcCall rpcCall = rpcCallDetails.getRpcCall();
+final String clientAddress = rpcCallDetails.getClientAddress();
+final long responseSize = rpcCallDetails.getResponseSize();
+final String className = rpcCallDetails.getClassName();
+Descriptors.MethodDescriptor methodDescriptor = rpcCall.getMethod();
+Message param = rpcCall.getParam();
+long receiveTime = rpcCall.getReceiveTime();
+long startTime = rpcCall.getStartTime();
+long endTime = System.currentTimeMillis();
+int processingTime = (int) (endTime - startTime);
+int qTime = (int) (startTime - receiveTime);
+final SlowLogParams slowLogParams = ProtobufUtil.getSlowLogParams(param);
+int numGets = 0;
+int numMutations = 0;
+int numServiceCalls = 0;
+if (param instanceof ClientProtos.MultiRequest) {
+ ClientProtos.MultiRequest multi = (ClientProtos.MultiRequest) param;
+ for (ClientProtos.RegionAction regionAction :
multi.getRegionActionList()) {
+for (ClientProtos.Action action : regionAction.getActionList()) {
+ if (action.hasMutation()) {
+numMutations++;
+ }
+ if (action.hasGet()) {
+numGets++;
+ }
+ if (action.hasServiceCall()) {
+numServiceCalls++;
+ }
+}
+ }
+}
+final String userName =
rpcCall.getRequestUserName().orElse(StringUtils.EMPTY);
+final String methodDescriptorName =
+ methodDescriptor != null ? methodDescriptor.getName() :
StringUtils.EMPTY;
+SlowLogPayload slowLogPayload = SlowLogPayload.newBuilder()
+ .setCallDetails(methodDescriptorName +
[GitHub] [hbase] bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log
bharathv commented on a change in pull request #754: HBASE-22978 : Online slow
response log
URL: https://github.com/apache/hbase/pull/754#discussion_r382878572
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/slowlog/SlowLogEventHandler.java
##
@@ -0,0 +1,205 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hbase.regionserver.slowlog;
+
+import com.lmax.disruptor.EventHandler;
+import com.lmax.disruptor.RingBuffer;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.List;
+import java.util.Queue;
+import java.util.stream.Collectors;
+
+import org.apache.commons.lang3.StringUtils;
+import org.apache.hadoop.hbase.client.SlowLogParams;
+import org.apache.hadoop.hbase.ipc.RpcCall;
+import org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos;
+import org.apache.hbase.thirdparty.com.google.protobuf.Descriptors;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import org.apache.hbase.thirdparty.com.google.common.collect.EvictingQueue;
+import org.apache.hbase.thirdparty.com.google.common.collect.Queues;
+import org.apache.hbase.thirdparty.com.google.protobuf.Message;
+
+import org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil;
+import org.apache.hadoop.hbase.shaded.protobuf.generated.AdminProtos;
+import
org.apache.hadoop.hbase.shaded.protobuf.generated.TooSlowLog.SlowLogPayload;
+
+/**
+ * Event Handler run by disruptor ringbuffer consumer
+ */
+@InterfaceAudience.Private
+class SlowLogEventHandler implements EventHandler {
+
+ private static final Logger LOG =
LoggerFactory.getLogger(SlowLogEventHandler.class);
+
+ private final Queue queue;
+
+ SlowLogEventHandler(int eventCount) {
+EvictingQueue evictingQueue =
EvictingQueue.create(eventCount);
+queue = Queues.synchronizedQueue(evictingQueue);
+ }
+
+ /**
+ * Called when a publisher has published an event to the {@link RingBuffer}
+ *
+ * @param event published to the {@link RingBuffer}
+ * @param sequence of the event being processed
+ * @param endOfBatch flag to indicate if this is the last event in a batch
from
+ * the {@link RingBuffer}
+ * @throws Exception if the EventHandler would like the exception handled
further up the chain
+ */
+ @Override
+ public void onEvent(RingBufferEnvelope event, long sequence, boolean
endOfBatch)
+ throws Exception {
+final RpcLogDetails rpcCallDetails = event.getPayload();
+final RpcCall rpcCall = rpcCallDetails.getRpcCall();
+final String clientAddress = rpcCallDetails.getClientAddress();
+final long responseSize = rpcCallDetails.getResponseSize();
+final String className = rpcCallDetails.getClassName();
+Descriptors.MethodDescriptor methodDescriptor = rpcCall.getMethod();
+Message param = rpcCall.getParam();
+long receiveTime = rpcCall.getReceiveTime();
+long startTime = rpcCall.getStartTime();
+long endTime = System.currentTimeMillis();
+int processingTime = (int) (endTime - startTime);
+int qTime = (int) (startTime - receiveTime);
+final SlowLogParams slowLogParams = ProtobufUtil.getSlowLogParams(param);
+int numGets = 0;
+int numMutations = 0;
+int numServiceCalls = 0;
+if (param instanceof ClientProtos.MultiRequest) {
+ ClientProtos.MultiRequest multi = (ClientProtos.MultiRequest) param;
+ for (ClientProtos.RegionAction regionAction :
multi.getRegionActionList()) {
+for (ClientProtos.Action action : regionAction.getActionList()) {
+ if (action.hasMutation()) {
+numMutations++;
+ }
+ if (action.hasGet()) {
+numGets++;
+ }
+ if (action.hasServiceCall()) {
+numServiceCalls++;
+ }
+}
+ }
+}
+final String userName =
rpcCall.getRequestUserName().orElse(StringUtils.EMPTY);
+final String methodDescriptorName =
+ methodDescriptor != null ? methodDescriptor.getName() :
StringUtils.EMPTY;
+SlowLogPayload slowLogPayload = SlowLogPayload.newBuilder()
+ .setCallDetails(methodDescriptorName +
[GitHub] [hbase] bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log
bharathv commented on a change in pull request #754: HBASE-22978 : Online slow
response log
URL: https://github.com/apache/hbase/pull/754#discussion_r382876386
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java
##
@@ -3410,4 +3471,56 @@ public static RegionStatesCount
toTableRegionStatesCount(
.build();
}
+ /**
+ * Convert Protobuf class
+ * {@link
org.apache.hadoop.hbase.shaded.protobuf.generated.TooSlowLog.SlowLogPayload}
+ * To client SlowLog Payload class {@link SlowLogRecord}
+ *
+ * @param slowLogPayload SlowLog Payload protobuf instance
+ * @return SlowLog Payload for client usecase
+ */
+ private static SlowLogRecord getSlowLogPayload(
Review comment:
nit: getSlowLogRecord()?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log
bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r382871376 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java ## @@ -3874,4 +3878,62 @@ private void getProcedureResult(long procId, CompletableFuture future, int .call(); } + @Override + public CompletableFuture> getSlowLogResponses( +@Nullable final Set serverNames, Review comment: nit: mind doing the annotations in multiple places? (not just here) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log
bharathv commented on a change in pull request #754: HBASE-22978 : Online slow
response log
URL: https://github.com/apache/hbase/pull/754#discussion_r382873543
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/slowlog/SlowLogEventHandler.java
##
@@ -0,0 +1,205 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hbase.regionserver.slowlog;
+
+import com.lmax.disruptor.EventHandler;
+import com.lmax.disruptor.RingBuffer;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.List;
+import java.util.Queue;
+import java.util.stream.Collectors;
+
+import org.apache.commons.lang3.StringUtils;
+import org.apache.hadoop.hbase.client.SlowLogParams;
+import org.apache.hadoop.hbase.ipc.RpcCall;
+import org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos;
+import org.apache.hbase.thirdparty.com.google.protobuf.Descriptors;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import org.apache.hbase.thirdparty.com.google.common.collect.EvictingQueue;
+import org.apache.hbase.thirdparty.com.google.common.collect.Queues;
+import org.apache.hbase.thirdparty.com.google.protobuf.Message;
+
+import org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil;
+import org.apache.hadoop.hbase.shaded.protobuf.generated.AdminProtos;
+import
org.apache.hadoop.hbase.shaded.protobuf.generated.TooSlowLog.SlowLogPayload;
+
+/**
+ * Event Handler run by disruptor ringbuffer consumer
+ */
+@InterfaceAudience.Private
+class SlowLogEventHandler implements EventHandler {
+
+ private static final Logger LOG =
LoggerFactory.getLogger(SlowLogEventHandler.class);
+
+ private final Queue queue;
+
+ SlowLogEventHandler(int eventCount) {
+EvictingQueue evictingQueue =
EvictingQueue.create(eventCount);
+queue = Queues.synchronizedQueue(evictingQueue);
+ }
+
+ /**
+ * Called when a publisher has published an event to the {@link RingBuffer}
+ *
+ * @param event published to the {@link RingBuffer}
+ * @param sequence of the event being processed
+ * @param endOfBatch flag to indicate if this is the last event in a batch
from
+ * the {@link RingBuffer}
+ * @throws Exception if the EventHandler would like the exception handled
further up the chain
+ */
+ @Override
+ public void onEvent(RingBufferEnvelope event, long sequence, boolean
endOfBatch)
+ throws Exception {
+final RpcLogDetails rpcCallDetails = event.getPayload();
+final RpcCall rpcCall = rpcCallDetails.getRpcCall();
+final String clientAddress = rpcCallDetails.getClientAddress();
+final long responseSize = rpcCallDetails.getResponseSize();
+final String className = rpcCallDetails.getClassName();
+Descriptors.MethodDescriptor methodDescriptor = rpcCall.getMethod();
+Message param = rpcCall.getParam();
+long receiveTime = rpcCall.getReceiveTime();
+long startTime = rpcCall.getStartTime();
+long endTime = System.currentTimeMillis();
+int processingTime = (int) (endTime - startTime);
+int qTime = (int) (startTime - receiveTime);
+final SlowLogParams slowLogParams = ProtobufUtil.getSlowLogParams(param);
+int numGets = 0;
+int numMutations = 0;
+int numServiceCalls = 0;
+if (param instanceof ClientProtos.MultiRequest) {
+ ClientProtos.MultiRequest multi = (ClientProtos.MultiRequest) param;
+ for (ClientProtos.RegionAction regionAction :
multi.getRegionActionList()) {
+for (ClientProtos.Action action : regionAction.getActionList()) {
+ if (action.hasMutation()) {
+numMutations++;
+ }
+ if (action.hasGet()) {
+numGets++;
+ }
+ if (action.hasServiceCall()) {
+numServiceCalls++;
+ }
+}
+ }
+}
+final String userName =
rpcCall.getRequestUserName().orElse(StringUtils.EMPTY);
+final String methodDescriptorName =
+ methodDescriptor != null ? methodDescriptor.getName() :
StringUtils.EMPTY;
+SlowLogPayload slowLogPayload = SlowLogPayload.newBuilder()
+ .setCallDetails(methodDescriptorName +
[GitHub] [hbase] bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log
bharathv commented on a change in pull request #754: HBASE-22978 : Online slow
response log
URL: https://github.com/apache/hbase/pull/754#discussion_r382879258
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/slowlog/SlowLogRecorder.java
##
@@ -0,0 +1,153 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hbase.regionserver.slowlog;
+
+import com.lmax.disruptor.BlockingWaitStrategy;
+import com.lmax.disruptor.RingBuffer;
+import com.lmax.disruptor.dsl.Disruptor;
+import com.lmax.disruptor.dsl.ProducerType;
+
+import java.util.Collections;
+import java.util.List;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.util.Threads;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.apache.yetus.audience.InterfaceStability;
+
+import org.apache.hbase.thirdparty.com.google.common.base.Preconditions;
+
+import org.apache.hadoop.hbase.shaded.protobuf.generated.AdminProtos;
+import
org.apache.hadoop.hbase.shaded.protobuf.generated.TooSlowLog.SlowLogPayload;
+
+/**
+ * Online SlowLog Provider Service that keeps slow RPC logs in the ring buffer.
+ * The service uses LMAX Disruptor to save slow records which are then
consumed by
+ * a queue and based on the ring buffer size, the available records are then
fetched
+ * from the queue in thread-safe manner.
+ */
+@InterfaceAudience.Private
+@InterfaceStability.Evolving
+public class SlowLogRecorder {
+
+ private final Disruptor disruptor;
+ private final SlowLogEventHandler slowLogEventHandler;
+ private final int eventCount;
+ private final boolean isOnlineSlowLogProviderEnabled;
+
+ private static final String SLOW_LOG_RING_BUFFER_SIZE =
+"hbase.regionserver.slowlog.ringbuffer.size";
+
+ /**
+ * Initialize disruptor with configurable ringbuffer size
+ */
+ public SlowLogRecorder(Configuration conf) {
+isOnlineSlowLogProviderEnabled =
conf.getBoolean(HConstants.SLOW_LOG_BUFFER_ENABLED_KEY,
+ HConstants.DEFAULT_ONLINE_LOG_PROVIDER_ENABLED);
+
+if (!isOnlineSlowLogProviderEnabled) {
+ this.disruptor = null;
Review comment:
nit: all these are defaults.. any reason specifically null initialize them?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log
bharathv commented on a change in pull request #754: HBASE-22978 : Online slow
response log
URL: https://github.com/apache/hbase/pull/754#discussion_r382878387
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/slowlog/SlowLogEventHandler.java
##
@@ -0,0 +1,205 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hbase.regionserver.slowlog;
+
+import com.lmax.disruptor.EventHandler;
+import com.lmax.disruptor.RingBuffer;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.List;
+import java.util.Queue;
+import java.util.stream.Collectors;
+
+import org.apache.commons.lang3.StringUtils;
+import org.apache.hadoop.hbase.client.SlowLogParams;
+import org.apache.hadoop.hbase.ipc.RpcCall;
+import org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos;
+import org.apache.hbase.thirdparty.com.google.protobuf.Descriptors;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import org.apache.hbase.thirdparty.com.google.common.collect.EvictingQueue;
+import org.apache.hbase.thirdparty.com.google.common.collect.Queues;
+import org.apache.hbase.thirdparty.com.google.protobuf.Message;
+
+import org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil;
+import org.apache.hadoop.hbase.shaded.protobuf.generated.AdminProtos;
+import
org.apache.hadoop.hbase.shaded.protobuf.generated.TooSlowLog.SlowLogPayload;
+
+/**
+ * Event Handler run by disruptor ringbuffer consumer
+ */
+@InterfaceAudience.Private
+class SlowLogEventHandler implements EventHandler {
+
+ private static final Logger LOG =
LoggerFactory.getLogger(SlowLogEventHandler.class);
+
+ private final Queue queue;
+
+ SlowLogEventHandler(int eventCount) {
+EvictingQueue evictingQueue =
EvictingQueue.create(eventCount);
+queue = Queues.synchronizedQueue(evictingQueue);
+ }
+
+ /**
+ * Called when a publisher has published an event to the {@link RingBuffer}
+ *
+ * @param event published to the {@link RingBuffer}
+ * @param sequence of the event being processed
+ * @param endOfBatch flag to indicate if this is the last event in a batch
from
+ * the {@link RingBuffer}
+ * @throws Exception if the EventHandler would like the exception handled
further up the chain
+ */
+ @Override
+ public void onEvent(RingBufferEnvelope event, long sequence, boolean
endOfBatch)
Review comment:
endOfBatch is unused.. is that okay?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1194: HBASE-23882: Experimenting with low config settings.
Apache-HBase commented on issue #1194: HBASE-23882: Experimenting with low config settings. URL: https://github.com/apache/hbase/pull/1194#issuecomment-589907430 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 42s | branch-2 passed | | +1 :green_heart: | compile | 1m 23s | branch-2 passed | | +1 :green_heart: | checkstyle | 1m 39s | branch-2 passed | | +1 :green_heart: | shadedjars | 4m 37s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 57s | branch-2 passed | | +0 :ok: | spotbugs | 3m 43s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 4m 29s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 17s | the patch passed | | +1 :green_heart: | compile | 1m 21s | the patch passed | | +1 :green_heart: | javac | 1m 21s | the patch passed | | +1 :green_heart: | checkstyle | 1m 39s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 4m 37s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 16m 45s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | javadoc | 0m 54s | the patch passed | | +1 :green_heart: | findbugs | 4m 53s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 11s | hbase-common in the patch passed. | | -1 :x: | unit | 87m 50s | hbase-server in the patch failed. | | +1 :green_heart: | asflicense | 0m 43s | The patch does not generate ASF License warnings. | | | | 151m 45s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestClientOperationInterrupt | | | hadoop.hbase.security.access.TestNamespaceCommands | | | hadoop.hbase.client.TestReplicasClient | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1194/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1194 | | JIRA Issue | HBASE-23882 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux b035aef41854 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1194/out/precommit/personality/provided.sh | | git revision | branch-2 / cb838bc301 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1194/1/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1194/1/testReport/ | | Max. process+thread count | 5668 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1194/1/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23882) Scale *MiniCluster config for the environment it runs in.
[
https://issues.apache.org/jira/browse/HBASE-23882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17042339#comment-17042339
]
HBase QA commented on HBASE-23882:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
32s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} branch-2 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
42s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
23s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
39s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
37s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
57s{color} | {color:green} branch-2 passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 3m
43s{color} | {color:blue} Used deprecated FindBugs config; considering
switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
29s{color} | {color:green} branch-2 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
16s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
37s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
16m 45s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
53s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
11s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 87m 50s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
43s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}151m 45s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.client.TestClientOperationInterrupt |
| | hadoop.hbase.security.access.TestNamespaceCommands |
| | hadoop.hbase.client.TestReplicasClient |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.4 Server=19.03.4 base:
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1194/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/1194 |
| JIRA Issue | HBASE-23882 |
| Optional
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit URL: https://github.com/apache/hbase/pull/1183#issuecomment-589906501 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m 2s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 42s | master passed | | +1 :green_heart: | compile | 3m 48s | master passed with JDK v2020-01-14 | | +1 :green_heart: | compile | 4m 53s | master passed with JDK v1.8.0_232 | | +1 :green_heart: | shadedjars | 5m 15s | branch has no errors when building our shaded downstream artifacts. | | -1 :x: | javadoc | 0m 22s | root in master failed with JDK v2020-01-14. | | +1 :green_heart: | javadoc | 3m 1s | master passed with JDK v1.8.0_232 | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 31s | the patch passed | | +1 :green_heart: | compile | 3m 42s | the patch passed with JDK v2020-01-14 | | +1 :green_heart: | javac | 3m 42s | the patch passed | | +1 :green_heart: | compile | 3m 3s | the patch passed with JDK v1.8.0_232 | | +1 :green_heart: | javac | 3m 3s | the patch passed | | +1 :green_heart: | hadolint | 0m 2s | The patch generated 0 new + 0 unchanged - 4 fixed = 0 total (was 4) | | +1 :green_heart: | shellcheck | 0m 2s | There were no new shellcheck issues. | | +1 :green_heart: | whitespace | 0m 1s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +1 :green_heart: | shadedjars | 4m 45s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 16m 8s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | -1 :x: | javadoc | 0m 20s | root in the patch failed with JDK v2020-01-14. | | +1 :green_heart: | javadoc | 2m 47s | the patch passed with JDK v1.8.0_232 | ||| _ Other Tests _ | | -1 :x: | unit | 70m 48s | root in the patch failed with JDK v1.8.0_232. | | +1 :green_heart: | asflicense | 0m 37s | The patch does not generate ASF License warnings. | | | | 142m 39s | | | Reason | Tests | |---:|:--| | JDK v2020-01-14 Failed junit tests | hadoop.hbase.util.TestFutureUtils | | JDK v1.8.0_232 Failed junit tests | hadoop.hbase.security.token.TestZKSecretWatcher | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/20/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1183 | | Optional Tests | dupname asflicense hadolint shellcheck shelldocs javac javadoc unit shadedjars hadoopcheck xml compile | | uname | Linux 313d2fa800b5 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1183/out/precommit/personality/provided.sh | | git revision | master / 400b7ce954 | | Default Java | 1.8.0_232 | | Multi-JDK versions | /usr/lib/jvm/jdk-11.0.6+10:2020-01-14 /usr/lib/jvm/jdk8u232-b09:1.8.0_232 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/20/artifact/out/branch-javadoc-root-jdk2020-01-14.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/20/artifact/out/patch-javadoc-root-jdk2020-01-14.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/20/artifact/out/patch-unit-root-jdk1.8.0_232.txt | | JDK v1.8.0_232 Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/20/testReport/ | | Max. process+thread count | 8777 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/20/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) shellcheck=0.4.6 hadolint=1.17.5-0-g443423c | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically
[GitHub] [hbase] Apache-HBase commented on issue #1186: HBASE-19146 Update Protobuf to 3.11.4
Apache-HBase commented on issue #1186: HBASE-19146 Update Protobuf to 3.11.4 URL: https://github.com/apache/hbase/pull/1186#issuecomment-589905767 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 47s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 29s | master passed | | +1 :green_heart: | compile | 3m 19s | master passed | | +1 :green_heart: | checkstyle | 2m 17s | master passed | | +1 :green_heart: | shadedjars | 4m 53s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 17s | master passed | | +0 :ok: | spotbugs | 15m 40s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 17m 2s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 41s | the patch passed | | +1 :green_heart: | compile | 4m 34s | the patch passed | | +1 :green_heart: | javac | 4m 34s | the patch passed | | +1 :green_heart: | checkstyle | 3m 29s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. | | +1 :green_heart: | shadedjars | 7m 20s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 25m 2s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | javadoc | 5m 6s | the patch passed | | +1 :green_heart: | findbugs | 22m 32s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 72m 26s | root in the patch failed. | | +1 :green_heart: | asflicense | 1m 13s | The patch does not generate ASF License warnings. | | | | 195m 20s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestAsyncTableAdminApi2 | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1186/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1186 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile xml | | uname | Linux 3d3b95f92a34 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1186/out/precommit/personality/provided.sh | | git revision | master / 400b7ce954 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1186/3/artifact/out/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1186/3/testReport/ | | Max. process+thread count | 8575 (vs. ulimit of 1) | | modules | C: hbase-protocol . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1186/3/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #754: HBASE-22978 : Online slow response log
Apache-HBase commented on issue #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#issuecomment-589904797 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 3s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | prototool | 0m 1s | prototool was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 6 new or modified test files. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 36s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 48s | master passed | | +1 :green_heart: | compile | 3m 25s | master passed | | +1 :green_heart: | checkstyle | 2m 40s | master passed | | +0 :ok: | refguide | 5m 29s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | shadedjars | 5m 7s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 5m 9s | master passed | | +0 :ok: | spotbugs | 1m 27s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 25m 42s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 33s | the patch passed | | +1 :green_heart: | compile | 3m 23s | the patch passed | | +1 :green_heart: | cc | 3m 23s | the patch passed | | +1 :green_heart: | javac | 3m 23s | the patch passed | | -1 :x: | checkstyle | 2m 38s | root: The patch generated 6 new + 433 unchanged - 1 fixed = 439 total (was 434) | | +1 :green_heart: | rubocop | 0m 10s | There were no new rubocop issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +0 :ok: | refguide | 5m 26s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | shadedjars | 5m 5s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 17m 45s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | hbaseprotoc | 9m 19s | the patch passed | | +1 :green_heart: | javadoc | 5m 33s | the patch passed | | +1 :green_heart: | findbugs | 29m 36s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 133m 18s | root in the patch failed. | | +1 :green_heart: | asflicense | 2m 39s | The patch does not generate ASF License warnings. | | | | 284m 20s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.snapshot.TestExportSnapshotV1NoCluster | | | hadoop.hbase.snapshot.TestExportSnapshotV2NoCluster | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/19/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/754 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile refguide xml cc hbaseprotoc prototool rubocop | | uname | Linux 25ad47dfb155 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-754/out/precommit/personality/provided.sh | | git revision | master / 400b7ce954 | | Default Java | 1.8.0_181 | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/19/artifact/out/branch-site/book.html | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/19/artifact/out/diff-checkstyle-root.txt | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/19/artifact/out/patch-site/book.html | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/19/artifact/out/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/19/testReport/ | | Max. process+thread count | 5984 (vs. ulimit of 1) | | modules | C:
[jira] [Commented] (HBASE-23881) TestShadeSaslAuthenticationProvider failures
[
https://issues.apache.org/jira/browse/HBASE-23881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17042336#comment-17042336
]
Bharath Vissapragada commented on HBASE-23881:
--
Can you confirm if the following test (which is a slight rewrite of your
original test) does not run into the fail()? (on commit hash 3168cf210)
{noformat}
@Test
public void testNegativeAuthentication() throws Exception {
// Validate that we can read that record back out as the user with our
custom auth'n
final Configuration clientConf = new Configuration(CONF);
clientConf.setInt(HConstants.HBASE_CLIENT_RETRIES_NUMBER, 3);
try (Connection conn = ConnectionFactory.createConnection(clientConf)) {
UserGroupInformation user1 = UserGroupInformation.createUserForTesting(
"user1", new String[0]);
user1.addToken(
ShadeClientTokenUtil.obtainToken(conn, "user1", "not a real
password".toCharArray()));
user1.doAs(new PrivilegedExceptionAction() {
@Override public Void run() throws Exception {
try (Connection conn =
ConnectionFactory.createConnection(clientConf)) {
conn.getAdmin().listTableDescriptors();
fail("Should not successfully authenticate with HBase");
return null;
}
}
});
}
}
{noformat}
> TestShadeSaslAuthenticationProvider failures
>
>
> Key: HBASE-23881
> URL: https://issues.apache.org/jira/browse/HBASE-23881
> Project: HBase
> Issue Type: Bug
> Components: test
>Affects Versions: 3.0.0
>Reporter: Bharath Vissapragada
>Assignee: Josh Elser
>Priority: Major
>
> TestShadeSaslAuthenticationProvider now fails deterministically with the
> following exception..
> {noformat}
> java.lang.Exception: Unexpected exception,
> expected but
> was
> at
> org.apache.hadoop.hbase.security.provider.example.TestShadeSaslAuthenticationProvider.testNegativeAuthentication(TestShadeSaslAuthenticationProvider.java:233)
> {noformat}
> The test now fails a different place than before merging HBASE-18095 because
> the RPCs are also a part of connection setup. We might need to rewrite the
> test..
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1196: HBASE-23755. [OpenTracing] Declare HTrace is unusable in the user doc
Apache-HBase commented on issue #1196: HBASE-23755. [OpenTracing] Declare HTrace is unusable in the user doc URL: https://github.com/apache/hbase/pull/1196#issuecomment-589904376 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 33s | master passed | | +0 :ok: | refguide | 4m 45s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 2s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +0 :ok: | refguide | 4m 48s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 20s | The patch does not generate ASF License warnings. | | | | 22m 8s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1196/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1196 | | Optional Tests | dupname asflicense refguide | | uname | Linux a5340aa3a75c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1196/out/precommit/personality/provided.sh | | git revision | master / 400b7ce954 | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1196/1/artifact/out/branch-site/book.html | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1196/1/artifact/out/patch-site/book.html | | Max. process+thread count | 96 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1196/1/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23881) TestShadeSaslAuthenticationProvider failures
[
https://issues.apache.org/jira/browse/HBASE-23881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17042333#comment-17042333
]
Josh Elser commented on HBASE-23881:
{quote}To further simplify it, please try it out at commit hash 3168cf210,
which is pre-HBASE-18095.
{quote}
That's the problem – the tests pass for me on that commit :)
{noformat}
[INFO] Running
org.apache.hadoop.hbase.security.provider.example.TestShadeSaslAuthenticationProvider
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 24.758 s
- in
org.apache.hadoop.hbase.security.provider.example.TestShadeSaslAuthenticationProvider
{noformat}
However, when I run it on the tip of master, I see:
{noformat}
2020-02-21 20:34:10,755 INFO [Time-limited test]
example.TestShadeSaslAuthenticationProvider$3(244): Caught exception in
negative test
java.io.IOException: Invalid result for request getClusterId(). Will be retried
at java.lang.Thread.getStackTrace(Thread.java:1559)
at
org.apache.hadoop.hbase.util.FutureUtils.setStackTrace(FutureUtils.java:130)
at
org.apache.hadoop.hbase.util.FutureUtils.rethrow(FutureUtils.java:145)
at org.apache.hadoop.hbase.util.FutureUtils.get(FutureUtils.java:168)
at
org.apache.hadoop.hbase.client.ConnectionFactory.createConnection(ConnectionFactory.java:230)
at
org.apache.hadoop.hbase.client.ConnectionFactory.createConnection(ConnectionFactory.java:129)
at
org.apache.hadoop.hbase.security.provider.example.TestShadeSaslAuthenticationProvider$3.run(TestShadeSaslAuthenticationProvider.java:238)
at
org.apache.hadoop.hbase.security.provider.example.TestShadeSaslAuthenticationProvider$3.run(TestShadeSaslAuthenticationProvider.java:236)
{noformat}
I'll check the nightlies, but if you can share:
* Maven version
* JDK Version
* {{$MAVEN_OPTS}}
* the test output file from surefire-reports, after modifying the root log
level to be DEBUG in hbase-examples/src/test/resources/log4j.properties, that
would be awesome :)
Hopefully I can pull some of this from a build machine, too.
> TestShadeSaslAuthenticationProvider failures
>
>
> Key: HBASE-23881
> URL: https://issues.apache.org/jira/browse/HBASE-23881
> Project: HBase
> Issue Type: Bug
> Components: test
>Affects Versions: 3.0.0
>Reporter: Bharath Vissapragada
>Assignee: Josh Elser
>Priority: Major
>
> TestShadeSaslAuthenticationProvider now fails deterministically with the
> following exception..
> {noformat}
> java.lang.Exception: Unexpected exception,
> expected but
> was
> at
> org.apache.hadoop.hbase.security.provider.example.TestShadeSaslAuthenticationProvider.testNegativeAuthentication(TestShadeSaslAuthenticationProvider.java:233)
> {noformat}
> The test now fails a different place than before merging HBASE-18095 because
> the RPCs are also a part of connection setup. We might need to rewrite the
> test..
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23881) TestShadeSaslAuthenticationProvider failures
[
https://issues.apache.org/jira/browse/HBASE-23881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17042326#comment-17042326
]
Bharath Vissapragada commented on HBASE-23881:
--
To further simplify it, please try it out at commit hash {{3168cf210}}, which
is pre-HBASE-18095.
> TestShadeSaslAuthenticationProvider failures
>
>
> Key: HBASE-23881
> URL: https://issues.apache.org/jira/browse/HBASE-23881
> Project: HBase
> Issue Type: Bug
> Components: test
>Affects Versions: 3.0.0
>Reporter: Bharath Vissapragada
>Assignee: Josh Elser
>Priority: Major
>
> TestShadeSaslAuthenticationProvider now fails deterministically with the
> following exception..
> {noformat}
> java.lang.Exception: Unexpected exception,
> expected but
> was
> at
> org.apache.hadoop.hbase.security.provider.example.TestShadeSaslAuthenticationProvider.testNegativeAuthentication(TestShadeSaslAuthenticationProvider.java:233)
> {noformat}
> The test now fails a different place than before merging HBASE-18095 because
> the RPCs are also a part of connection setup. We might need to rewrite the
> test..
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23881) TestShadeSaslAuthenticationProvider failures
[
https://issues.apache.org/jira/browse/HBASE-23881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17042325#comment-17042325
]
Bharath Vissapragada commented on HBASE-23881:
--
This is my local run, just ran a single stand alone test. I think my modified
test
[above|https://issues.apache.org/jira/browse/HBASE-23881?focusedCommentId=17042112=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17042112]
is an even simpler repro of this issue since it eliminates the noise of
whether table exists or not?
> TestShadeSaslAuthenticationProvider failures
>
>
> Key: HBASE-23881
> URL: https://issues.apache.org/jira/browse/HBASE-23881
> Project: HBase
> Issue Type: Bug
> Components: test
>Affects Versions: 3.0.0
>Reporter: Bharath Vissapragada
>Assignee: Josh Elser
>Priority: Major
>
> TestShadeSaslAuthenticationProvider now fails deterministically with the
> following exception..
> {noformat}
> java.lang.Exception: Unexpected exception,
> expected but
> was
> at
> org.apache.hadoop.hbase.security.provider.example.TestShadeSaslAuthenticationProvider.testNegativeAuthentication(TestShadeSaslAuthenticationProvider.java:233)
> {noformat}
> The test now fails a different place than before merging HBASE-18095 because
> the RPCs are also a part of connection setup. We might need to rewrite the
> test..
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23854) Documentation update of external_apis.adoc#example-scala-code
[
https://issues.apache.org/jira/browse/HBASE-23854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17042323#comment-17042323
]
Hudson commented on HBASE-23854:
Results for branch branch-2
[build #2497 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2497/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2497//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2497//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2497//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Documentation update of external_apis.adoc#example-scala-code
> -
>
> Key: HBASE-23854
> URL: https://issues.apache.org/jira/browse/HBASE-23854
> Project: HBase
> Issue Type: Task
> Components: documentation
>Reporter: Michael Heil
>Assignee: Michael Heil
>Priority: Trivial
> Labels: beginner
> Fix For: 3.0.0, 2.3.0, 2.2.4, 2.1.10
>
> Attachments: HBASE-23854.patch
>
>
> Update the Example Scala Code in the Reference Guide as it contains
> deprecated content such as
> * new HBaseConfiguration()
> * new HTable(conf, "mytable")
> * add(Bytes.toBytes("ids"),Bytes.toBytes("id1"),Bytes.toBytes("one"))
> Replace it with:
> * HBaseConfiguration.create()
> * TableName.valueOf({color:#6a8759}"mytable"{color})
> *
> addColumn(Bytes.toBytes({color:#6a8759}"ids"{color}){color:#cc7832},{color}Bytes.toBytes({color:#6a8759}"id1"{color}){color:#cc7832},{color}Bytes.toBytes({color:#6a8759}"one"{color}))
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-23755) [OpenTracing] Declare HTrace is unusable in the user doc
[ https://issues.apache.org/jira/browse/HBASE-23755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang updated HBASE-23755: Attachment: Screen Shot 2020-02-21 at 5.18.12 PM.png > [OpenTracing] Declare HTrace is unusable in the user doc > > > Key: HBASE-23755 > URL: https://issues.apache.org/jira/browse/HBASE-23755 > Project: HBase > Issue Type: Sub-task >Reporter: Wei-Chiu Chuang >Assignee: Wei-Chiu Chuang >Priority: Major > Fix For: 3.0.0 > > Attachments: Screen Shot 2020-02-21 at 5.18.12 PM.png > > > The trace doesn't work at all in HBase 2.0 and above after HBASE-18601 (the > trace doesn't get picked up at the server side). We should make a note in the > user doc stating it is > # unusable > # deprecated in HBase 2.x because HTrace is in Attic. > # removed from HBase 3.0 and above. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23755) [OpenTracing] Declare HTrace is unusable in the user doc
[ https://issues.apache.org/jira/browse/HBASE-23755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17042322#comment-17042322 ] Wei-Chiu Chuang commented on HBASE-23755: - This is how it's rendered: !Screen Shot 2020-02-21 at 5.18.12 PM.png! > [OpenTracing] Declare HTrace is unusable in the user doc > > > Key: HBASE-23755 > URL: https://issues.apache.org/jira/browse/HBASE-23755 > Project: HBase > Issue Type: Sub-task >Reporter: Wei-Chiu Chuang >Assignee: Wei-Chiu Chuang >Priority: Major > Fix For: 3.0.0 > > Attachments: Screen Shot 2020-02-21 at 5.18.12 PM.png > > > The trace doesn't work at all in HBase 2.0 and above after HBASE-18601 (the > trace doesn't get picked up at the server side). We should make a note in the > user doc stating it is > # unusable > # deprecated in HBase 2.x because HTrace is in Attic. > # removed from HBase 3.0 and above. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] jojochuang opened a new pull request #1196: HBASE-23755. [OpenTracing] Declare HTrace is unusable in the user doc
jojochuang opened a new pull request #1196: HBASE-23755. [OpenTracing] Declare HTrace is unusable in the user doc URL: https://github.com/apache/hbase/pull/1196 Add a NOTE in Appendix L warning that users are advised not to follow the instructions. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23881) TestShadeSaslAuthenticationProvider failures
[
https://issues.apache.org/jira/browse/HBASE-23881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17042321#comment-17042321
]
Josh Elser commented on HBASE-23881:
[~bharathv], are you running tests concurrently? That table should definitely
exist as it is created in a {{\@Before}} block. I assume you were looking at
nightlies?
> TestShadeSaslAuthenticationProvider failures
>
>
> Key: HBASE-23881
> URL: https://issues.apache.org/jira/browse/HBASE-23881
> Project: HBase
> Issue Type: Bug
> Components: test
>Affects Versions: 3.0.0
>Reporter: Bharath Vissapragada
>Assignee: Josh Elser
>Priority: Major
>
> TestShadeSaslAuthenticationProvider now fails deterministically with the
> following exception..
> {noformat}
> java.lang.Exception: Unexpected exception,
> expected but
> was
> at
> org.apache.hadoop.hbase.security.provider.example.TestShadeSaslAuthenticationProvider.testNegativeAuthentication(TestShadeSaslAuthenticationProvider.java:233)
> {noformat}
> The test now fails a different place than before merging HBASE-18095 because
> the RPCs are also a part of connection setup. We might need to rewrite the
> test..
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] ndimiduk commented on a change in pull request #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
ndimiduk commented on a change in pull request #1183: HBASE-23767 Add JDK11
compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#discussion_r382868840
##
File path: dev-support/Jenkinsfile_GitHub
##
@@ -144,8 +143,9 @@ pipeline {
YETUS_ARGS+=("--docker")
YETUS_ARGS+=("--dockerfile=${DOCKERFILE}")
YETUS_ARGS+=("--mvn-custom-repos")
-
YETUS_ARGS+=("--multijdkdirs=/usr/lib/jvm/java-8-openjdk-amd64")
-YETUS_ARGS+=("--findbugs-home=/usr")
+YETUS_ARGS+=("--java-home=/usr/lib/jvm/java-8")
+YETUS_ARGS+=("--multijdkdirs=/usr/lib/jvm/java-8")
Review comment:
Okay, this was a bit of learning out loud.
My longer-term goal is to converge the Jenkinsfiles/Dockerfiles across
branches. Thus the image will ship with multiple JDKs and the jobs will need to
manage `JAVA_HOME` the Jenkinsfile instead.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on issue #1195: HBASE-23876 [WIP] Add JDK11 compilation and unit test support to nightly job
ndimiduk commented on issue #1195: HBASE-23876 [WIP] Add JDK11 compilation and unit test support to nightly job URL: https://github.com/apache/hbase/pull/1195#issuecomment-589896310 I pushed a [feature branch](https://github.com/apache/hbase/tree/HBASE-23876/jdk11-nightly-master) that should be picked up by the nightlies job. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1195: HBASE-23876 [WIP] Add JDK11 compilation and unit test support to nightly job
Apache-HBase commented on issue #1195: HBASE-23876 [WIP] Add JDK11 compilation and unit test support to nightly job URL: https://github.com/apache/hbase/pull/1195#issuecomment-589896037 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1195/1/console in case of problems. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] ndimiduk commented on issue #1195: HBASE-23876 [WIP] Add JDK11 compilation and unit test support to nightly job
ndimiduk commented on issue #1195: HBASE-23876 [WIP] Add JDK11 compilation and unit test support to nightly job URL: https://github.com/apache/hbase/pull/1195#issuecomment-589895771 @busbey comments like https://github.com/apache/hbase/blob/b53e9a325cffee0a2dba53de5afd5e63084c334e/dev-support/Jenkinsfile#L198-L200 and this bit of logic https://github.com/apache/hbase/blob/b53e9a325cffee0a2dba53de5afd5e63084c334e/dev-support/Jenkinsfile#L281-L294 (notice the scm checkout is performed into the dir `component`, but the yetus_nightly script is invoked from `BASEDIR`) makes me think that nightlies are not so closely tied to their branch-local Jenkinsfiles as I originally understood. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] ndimiduk opened a new pull request #1195: HBASE-23876 [WIP] Add JDK11 compilation and unit test support to nightly job
ndimiduk opened a new pull request #1195: HBASE-23876 [WIP] Add JDK11 compilation and unit test support to nightly job URL: https://github.com/apache/hbase/pull/1195 This PR provides changes necessary to run JDK11 checks during nightlies. It depends on HBASE-23767/#1183. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23862) Fix flaky TestSnapshotFromMaster in 1.x versions
[ https://issues.apache.org/jira/browse/HBASE-23862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17042300#comment-17042300 ] Hudson commented on HBASE-23862: FAILURE: Integrated in Jenkins build HBase-1.3-IT #677 (See [https://builds.apache.org/job/HBase-1.3-IT/677/]) HBASE-23862 Fix flaky TestSnapshotFromMaster in 1.x versions (#1190) (sakthi: rev 25db826693c9edfd47f3c2a4d84f6c85e4873777) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/cleaner/TestSnapshotFromMaster.java > Fix flaky TestSnapshotFromMaster in 1.x versions > > > Key: HBASE-23862 > URL: https://issues.apache.org/jira/browse/HBASE-23862 > Project: HBase > Issue Type: Task >Reporter: Sakthi >Assignee: Sakthi >Priority: Major > Fix For: 1.3.7, 1.7.0, 1.4.13 > > Attachments: hbase-23862.branch-1.3.001.patch, > hbase-23862.branch-1.4.001.patch > > > HBASE-23658 was about fixing this flakey ut in branch-2+. I think it can be > backported to branch-1s as well. 18/30 times this test has failed in > branch-1, 10/30 in 1.4 and 3/30 in 1.3. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23881) TestShadeSaslAuthenticationProvider failures
[
https://issues.apache.org/jira/browse/HBASE-23881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17042292#comment-17042292
]
Bharath Vissapragada commented on HBASE-23881:
--
No worries, reassigning to you. If you don't have time, feel free to assign it
back to me, I can dig into it next week.
> TestShadeSaslAuthenticationProvider failures
>
>
> Key: HBASE-23881
> URL: https://issues.apache.org/jira/browse/HBASE-23881
> Project: HBase
> Issue Type: Bug
> Components: test
>Affects Versions: 3.0.0
>Reporter: Bharath Vissapragada
>Assignee: Bharath Vissapragada
>Priority: Major
>
> TestShadeSaslAuthenticationProvider now fails deterministically with the
> following exception..
> {noformat}
> java.lang.Exception: Unexpected exception,
> expected but
> was
> at
> org.apache.hadoop.hbase.security.provider.example.TestShadeSaslAuthenticationProvider.testNegativeAuthentication(TestShadeSaslAuthenticationProvider.java:233)
> {noformat}
> The test now fails a different place than before merging HBASE-18095 because
> the RPCs are also a part of connection setup. We might need to rewrite the
> test..
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (HBASE-23881) TestShadeSaslAuthenticationProvider failures
[
https://issues.apache.org/jira/browse/HBASE-23881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bharath Vissapragada reassigned HBASE-23881:
Assignee: Josh Elser (was: Bharath Vissapragada)
> TestShadeSaslAuthenticationProvider failures
>
>
> Key: HBASE-23881
> URL: https://issues.apache.org/jira/browse/HBASE-23881
> Project: HBase
> Issue Type: Bug
> Components: test
>Affects Versions: 3.0.0
>Reporter: Bharath Vissapragada
>Assignee: Josh Elser
>Priority: Major
>
> TestShadeSaslAuthenticationProvider now fails deterministically with the
> following exception..
> {noformat}
> java.lang.Exception: Unexpected exception,
> expected but
> was
> at
> org.apache.hadoop.hbase.security.provider.example.TestShadeSaslAuthenticationProvider.testNegativeAuthentication(TestShadeSaslAuthenticationProvider.java:233)
> {noformat}
> The test now fails a different place than before merging HBASE-18095 because
> the RPCs are also a part of connection setup. We might need to rewrite the
> test..
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23862) Fix flaky TestSnapshotFromMaster in 1.x versions
[ https://issues.apache.org/jira/browse/HBASE-23862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17042283#comment-17042283 ] Sakthi commented on HBASE-23862: branch-1 pom currently aims at 1.7.0-snapshot hence putting 1.7.0 as fix version. > Fix flaky TestSnapshotFromMaster in 1.x versions > > > Key: HBASE-23862 > URL: https://issues.apache.org/jira/browse/HBASE-23862 > Project: HBase > Issue Type: Task >Reporter: Sakthi >Assignee: Sakthi >Priority: Major > Fix For: 1.3.7, 1.7.0, 1.4.13 > > Attachments: hbase-23862.branch-1.3.001.patch, > hbase-23862.branch-1.4.001.patch > > > HBASE-23658 was about fixing this flakey ut in branch-2+. I think it can be > backported to branch-1s as well. 18/30 times this test has failed in > branch-1, 10/30 in 1.4 and 3/30 in 1.3. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23862) Fix flaky TestSnapshotFromMaster in 1.x versions
[ https://issues.apache.org/jira/browse/HBASE-23862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sakthi updated HBASE-23862: --- Fix Version/s: 1.4.13 1.7.0 1.3.7 > Fix flaky TestSnapshotFromMaster in 1.x versions > > > Key: HBASE-23862 > URL: https://issues.apache.org/jira/browse/HBASE-23862 > Project: HBase > Issue Type: Task >Reporter: Sakthi >Assignee: Sakthi >Priority: Major > Fix For: 1.3.7, 1.7.0, 1.4.13 > > Attachments: hbase-23862.branch-1.3.001.patch, > hbase-23862.branch-1.4.001.patch > > > HBASE-23658 was about fixing this flakey ut in branch-2+. I think it can be > backported to branch-1s as well. 18/30 times this test has failed in > branch-1, 10/30 in 1.4 and 3/30 in 1.3. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23862) Fix flaky TestSnapshotFromMaster in 1.x versions
[ https://issues.apache.org/jira/browse/HBASE-23862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17042281#comment-17042281 ] Sakthi commented on HBASE-23862: pushed to branch-1.4 and branch-1.3. Let me close out this jira. > Fix flaky TestSnapshotFromMaster in 1.x versions > > > Key: HBASE-23862 > URL: https://issues.apache.org/jira/browse/HBASE-23862 > Project: HBase > Issue Type: Task >Reporter: Sakthi >Assignee: Sakthi >Priority: Major > Attachments: hbase-23862.branch-1.3.001.patch, > hbase-23862.branch-1.4.001.patch > > > HBASE-23658 was about fixing this flakey ut in branch-2+. I think it can be > backported to branch-1s as well. 18/30 times this test has failed in > branch-1, 10/30 in 1.4 and 3/30 in 1.3. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-22827) Expose multi-region merge in shell and Admin API
[ https://issues.apache.org/jira/browse/HBASE-22827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17042279#comment-17042279 ] Sakthi commented on HBASE-22827: Sure [~busbey]. I think we can work on getting this feature in 2.2 as well like i mentioned in the previous comment. As far as branch-2.1 is concerned, the branch is missing HBASE-22040 hence it's okay to skip it there rather than backporting that and including this feature there. I'll go ahead and merge this feature in branch-2.2 in few days, unless any objections. > Expose multi-region merge in shell and Admin API > > > Key: HBASE-22827 > URL: https://issues.apache.org/jira/browse/HBASE-22827 > Project: HBase > Issue Type: Improvement > Components: Admin, shell >Reporter: Michael Stack >Assignee: Sakthi >Priority: Major > Fix For: 3.0.0, 2.3.0 > > Attachments: hbase-22827.branch-2.001.patch > > > HBASE-22777 adds being able to merge more than two regions at once. It is > only available internally currently for use by hbck2 doing fixup of overlaps > in hbase:meta. This issue is about exposing it via the Admin Interface and in > turn, via the shell. Probably best if old two region merge method is > deprecated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-22040) Add mergeRegionsAsync with a List of region names method in AsyncAdmin
[ https://issues.apache.org/jira/browse/HBASE-22040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17042277#comment-17042277 ] Sakthi commented on HBASE-22040: I think it's fine to not include this in 2.1 now. Never mind Duo. > Add mergeRegionsAsync with a List of region names method in AsyncAdmin > -- > > Key: HBASE-22040 > URL: https://issues.apache.org/jira/browse/HBASE-22040 > Project: HBase > Issue Type: Sub-task > Components: Admin, asyncclient, Client >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0, 2.2.0, 2.3.0 > > Attachments: HBASE-22040-branch-2.patch, HBASE-22040-v1.patch, > HBASE-22040-v2.patch, HBASE-22040-v3.patch, HBASE-22040.patch > > > Although we only support merging two regions until now, but the rpc protocol > does support passing more than two regions to master. > So I think we should provide the methods, but need to add comments to say > that for now we only support merging two regions so do not try to pass more > than two regions. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] jatsakthi merged pull request #1190: HBASE-23862 Fix flaky TestSnapshotFromMaster in 1.x versions
jatsakthi merged pull request #1190: HBASE-23862 Fix flaky TestSnapshotFromMaster in 1.x versions URL: https://github.com/apache/hbase/pull/1190 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] jatsakthi commented on issue #1190: HBASE-23862 Fix flaky TestSnapshotFromMaster in 1.x versions
jatsakthi commented on issue #1190: HBASE-23862 Fix flaky TestSnapshotFromMaster in 1.x versions URL: https://github.com/apache/hbase/pull/1190#issuecomment-589888620 Yes @virajjasani this is covered in branch-1 already. @busbey just create HBASE-23883 for tracking that. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (HBASE-23883) HBase Precommit builds are broken due to some docker/java issue.
Sakthi created HBASE-23883: -- Summary: HBase Precommit builds are broken due to some docker/java issue. Key: HBASE-23883 URL: https://issues.apache.org/jira/browse/HBASE-23883 Project: HBase Issue Type: Task Components: build Reporter: Sakthi For example see: https://builds.apache.org/view/H-L/view/HBase/job/PreCommit-HBASE-Build/1136/console -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23875) Add JDK11 compilation and unit test support to Jira attached patch precommit
[ https://issues.apache.org/jira/browse/HBASE-23875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-23875: - Attachment: (was: HBASE-23875.0.patch) > Add JDK11 compilation and unit test support to Jira attached patch precommit > > > Key: HBASE-23875 > URL: https://issues.apache.org/jira/browse/HBASE-23875 > Project: HBase > Issue Type: Sub-task > Components: build >Reporter: Nick Dimiduk >Assignee: Nick Dimiduk >Priority: Major > > We already test against multiple JDK versions in a handful of places. Let's > get JDK11 added to the mix. Applies to Jira attached-patch pre-commit. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23875) Add JDK11 compilation and unit test support to Jira attached patch precommit
[ https://issues.apache.org/jira/browse/HBASE-23875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-23875: - Status: Open (was: Patch Available) > Add JDK11 compilation and unit test support to Jira attached patch precommit > > > Key: HBASE-23875 > URL: https://issues.apache.org/jira/browse/HBASE-23875 > Project: HBase > Issue Type: Sub-task > Components: build >Reporter: Nick Dimiduk >Assignee: Nick Dimiduk >Priority: Major > > We already test against multiple JDK versions in a handful of places. Let's > get JDK11 added to the mix. Applies to Jira attached-patch pre-commit. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23881) TestShadeSaslAuthenticationProvider failures
[
https://issues.apache.org/jira/browse/HBASE-23881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17042271#comment-17042271
]
Josh Elser commented on HBASE-23881:
Thanks, Bharath. Let me look.
> TestShadeSaslAuthenticationProvider failures
>
>
> Key: HBASE-23881
> URL: https://issues.apache.org/jira/browse/HBASE-23881
> Project: HBase
> Issue Type: Bug
> Components: test
>Affects Versions: 3.0.0
>Reporter: Bharath Vissapragada
>Assignee: Bharath Vissapragada
>Priority: Major
>
> TestShadeSaslAuthenticationProvider now fails deterministically with the
> following exception..
> {noformat}
> java.lang.Exception: Unexpected exception,
> expected but
> was
> at
> org.apache.hadoop.hbase.security.provider.example.TestShadeSaslAuthenticationProvider.testNegativeAuthentication(TestShadeSaslAuthenticationProvider.java:233)
> {noformat}
> The test now fails a different place than before merging HBASE-18095 because
> the RPCs are also a part of connection setup. We might need to rewrite the
> test..
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23823) Run maven with more than default single thread (--threads=0.5C)
[
https://issues.apache.org/jira/browse/HBASE-23823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17042263#comment-17042263
]
Michael Stack commented on HBASE-23823:
---
[~busbey] Duh. Thanks.
It takes a while to trace but it looks like yetus is doing reasonable thing.
Copying out what it does...
{code}
$ maven_version=$(mvn --offline --version 2>/dev/null | head -n 1 2>/dev/null)
kalashnikov:yetus stack$ echo $maven_version
Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
{code}
We using whatever /usr/share/maven/bin/mvn is I could have it dump out its
version at start of test run...?
> Run maven with more than default single thread (--threads=0.5C)
> ---
>
> Key: HBASE-23823
> URL: https://issues.apache.org/jira/browse/HBASE-23823
> Project: HBase
> Issue Type: Sub-task
>Reporter: Michael Stack
>Priority: Major
> Attachments:
> 0001-HBASE-23823-Run-maven-with-more-than-default-single-.patch,
> 0001-HBASE-23823-Run-maven-with-more-than-default-single-.patch,
> 0001-HBASE-23823-Run-maven-with-more-than-default-single-.patch,
> 0001-HBASE-23823-Run-maven-with-more-than-default-single-.patch
>
>
> See tail of parent task where we made commits to hbase-personality trying to
> make maven run more furiously on nightly builds by upping the maven thread
> count (the --threads flag ... see
> https://cwiki.apache.org/confluence/display/MAVEN/Parallel+builds+in+Maven+3).
> The effort was abandoned because it unsettled the build. This issue
> separates messing with the maven threads flag from the broader topic the
> parent covers.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] jatsakthi commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
jatsakthi commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit URL: https://github.com/apache/hbase/pull/1183#issuecomment-589884570 Thanks for taking up this one @ndimiduk the results look great. Will review This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit URL: https://github.com/apache/hbase/pull/1183#issuecomment-589884666 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/20/console in case of problems. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] ndimiduk commented on issue #1183: HBASE-23767 WIP do not merge
ndimiduk commented on issue #1183: HBASE-23767 WIP do not merge URL: https://github.com/apache/hbase/pull/1183#issuecomment-589884011 Before this can be merged, the other jobs that depend on the Dockerfile will need to be updated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23882) Scale *MiniCluster config for the environment it runs in.
[ https://issues.apache.org/jira/browse/HBASE-23882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17042245#comment-17042245 ] Mark Robert Miller commented on HBASE-23882: Here is some initial experimentation with bringing mini cluster settings down to scale. To start, I've been shooting for pretty minimal. I've pulled this out of an experimental branch and so some work may still be in order to find any tests these settings are too low for. I will continue to update this as I fine tune. I also have some other changes I'd like to dig out around thread pool sizing if I can find them again. I'll likely update again early next week. > Scale *MiniCluster config for the environment it runs in. > - > > Key: HBASE-23882 > URL: https://issues.apache.org/jira/browse/HBASE-23882 > Project: HBase > Issue Type: Test >Reporter: Mark Robert Miller >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] ndimiduk commented on issue #1183: HBASE-23767 WIP do not merge
ndimiduk commented on issue #1183: HBASE-23767 WIP do not merge URL: https://github.com/apache/hbase/pull/1183#issuecomment-589883543 Okay, this patch looks ready. The bit where I tickle the pom.xml will be removed before final commit. For an example of the results, see https://github.com/apache/hbase/pull/1183#issuecomment-589501678 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] markrmiller opened a new pull request #1194: HBASE-23882: Experimenting with low config settings.
markrmiller opened a new pull request #1194: HBASE-23882: Experimenting with low config settings. URL: https://github.com/apache/hbase/pull/1194 Here is some initial experimentation with bringing mini cluster settings down to scale. To start, I've been shooting for pretty minimal. I've pulled this out of an experimental branch and so some work may still be in order to find any tests these settings are too low for. I will continue to update this as I fine tune. I also have some other changes I'd like to dig out around thread pool sizing if I can find them again. I'll likely update again early next week. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] ndimiduk commented on a change in pull request #1183: HBASE-23767 WIP do not merge
ndimiduk commented on a change in pull request #1183: HBASE-23767 WIP do not
merge
URL: https://github.com/apache/hbase/pull/1183#discussion_r382845753
##
File path: dev-support/docker/Dockerfile
##
@@ -14,47 +14,173 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-# Dockerfile for installing the necessary dependencies for building Hadoop.
-# See BUILDING.txt.
-
-FROM maven:3.5-jdk-8
-
-RUN apt-get -q update && apt-get -q install --no-install-recommends -y \
- git \
- bats \
- findbugs \
- libperl-critic-perl \
- pylint \
- python-dateutil \
- rsync \
- make \
- gcc \
- libc6-dev \
- ruby \
- ruby-dev \
- wget \
- && \
-gem install --no-document rake rubocop ruby-lint
-
-ENV FINDBUGS_HOME /usr
-
-
-# Install shellcheck
-###
-RUN mkdir -p /opt/shellcheck && \
-curl -L -s -S \
-
https://storage.googleapis.com/shellcheck/shellcheck-stable.linux.x86_64.tar.xz
\
--o /opt/shellcheck.tar.xz && \
-tar xJf /opt/shellcheck.tar.xz --strip-components 1 -C /opt/shellcheck && \
-ln -s /opt/shellcheck/shellcheck /usr/bin/shellcheck && \
-rm -f /opt/shellcheck.tar.xz
+#
+# Dockerfile used as the build and test environment for Yetus.
+#
+# Built in multiple stages so as to avoid re-downloading large binaries when
+# tweaking unrelated aspects of the image.
-###
-# Avoid out of memory errors in builds
-###
-ENV MAVEN_OPTS -Xmx3g
+# start with a minimal image into which we can download remote tarballs
+FROM ubuntu:18.04 AS BASE_IMAGE
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+
+# hadolint ignore=DL3009
+RUN DEBIAN_FRONTEND=noninteractive apt-get -qq update && \
+ DEBIAN_FRONTEND=noninteractive apt-get -qq install --no-install-recommends
-y \
+ca-certificates=20180409 \
+curl=7.58.0-2ubuntu3.8 \
+locales=2.27-3ubuntu1
+
+RUN locale-gen en_US.UTF-8
+ENV LANG=en_US.UTF-8 LANGUAGE=en_US:en LC_ALL=en_US.UTF-8
+
+##
+# download sundry dependencies
+#
+
+FROM BASE_IMAGE AS FINDBUGS_DOWNLOAD_IMAGE
+ENV FINDBUGS_VERSION '3.0.1'
+ENV FINDBUGS_URL
"https://downloads.sourceforge.net/project/findbugs/findbugs/${FINDBUGS_VERSION}/findbugs-${FINDBUGS_VERSION}.tar.gz;
+ENV FINDBUGS_SHA256
'e80e0da0c213a27504ef3188ef25f107651700ffc66433eac6a7454bbe336419'
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+RUN curl -LfsSo /tmp/findbugs.tar.gz "${FINDBUGS_URL}" && \
+ echo "${FINDBUGS_SHA256} */tmp/findbugs.tar.gz" | sha256sum -c -
+
+FROM BASE_IMAGE AS HADOLINT_DOWNLOAD_IMAGE
+ENV HADOLINT_VERSION '1.17.5'
+ENV HADOLINT_URL
"https://github.com/hadolint/hadolint/releases/download/v${HADOLINT_VERSION}/hadolint-Linux-x86_64;
+ENV HADOLINT_SHA256
'20dd38bc0602040f19268adc14c3d1aae11af27b463af43f3122076baf827a35'
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+RUN curl -LfsSo /tmp/hadolint "${HADOLINT_URL}" && \
+ echo "${HADOLINT_SHA256} */tmp/hadolint" | sha256sum -c -
+
+FROM BASE_IMAGE AS MAVEN_DOWNLOAD_IMAGE
+ENV MAVEN_VERSION='3.5.4'
+ENV MAVEN_URL
"https://archive.apache.org/dist/maven/maven-3/${MAVEN_VERSION}/binaries/apache-maven-${MAVEN_VERSION}-bin.tar.gz;
+ENV MAVEN_SHA256
'ce50b1c91364cb77efe3776f756a6d92b76d9038b0a0782f7d53acf1e997a14d'
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+RUN curl -LfsSo /tmp/maven.tar.gz "${MAVEN_URL}" && \
+ echo "${MAVEN_SHA256} */tmp/maven.tar.gz" | sha256sum -c -
+
+FROM BASE_IMAGE AS ZULU7_DOWNLOAD_IMAGE
+ENV ZULU7_URL
'https://cdn.azul.com/zulu/bin/zulu7.36.0.5-ca-jdk7.0.252-linux_x64.tar.gz'
+ENV ZULU7_SHA256
'e0f34c242e6d456dac3e2c8a9eaeacfa8ea75c4dfc3e8818190bf0326e839d82'
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+RUN curl -LfsSo /tmp/zulujdk7.tar.gz "${ZULU7_URL}" && \
+ echo "${ZULU7_SHA256} */tmp/zulujdk7.tar.gz" | sha256sum -c -
+
+FROM BASE_IMAGE AS OPENJDK8_DOWNLOAD_IMAGE
+ENV OPENJDK8_URL
'https://github.com/AdoptOpenJDK/openjdk8-binaries/releases/download/jdk8u232-b09/OpenJDK8U-jdk_x64_linux_hotspot_8u232b09.tar.gz'
+ENV OPENJDK8_SHA256
'7b7884f2eb2ba2d47f4c0bf3bb1a2a95b73a3a7734bd47ebf9798483a7bcc423'
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+RUN curl -LfsSo /tmp/adoptopenjdk8.tar.gz "${OPENJDK8_URL}" && \
+ echo "${OPENJDK8_SHA256} */tmp/adoptopenjdk8.tar.gz" | sha256sum -c -
+
+FROM BASE_IMAGE AS OPENJDK11_DOWNLOAD_IMAGE
+ENV OPENJDK11_URL
'https://github.com/AdoptOpenJDK/openjdk11-binaries/releases/download/jdk-11.0.6%2B10/OpenJDK11U-jdk_x64_linux_hotspot_11.0.6_10.tar.gz'
+ENV OPENJDK11_SHA256
'330d19a2eaa07ed02757d7a785a77bab49f5ee710ea03b4ee2fa220ddd0feffc'
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+RUN curl -LfsSo /tmp/adoptopenjdk11.tar.gz "${OPENJDK11_URL}" && \
+ echo "${OPENJDK11_SHA256} */tmp/adoptopenjdk11.tar.gz" | sha256sum -c -
+
+##
+# build the final image
+#
+
+FROM BASE_IMAGE
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+
+# install dependencies from system packages. the first set brings the Ubuntu
+# distro into
[GitHub] [hbase] martin-g commented on issue #1186: HBASE-19146 Update Protobuf to 3.11.4
martin-g commented on issue #1186: HBASE-19146 Update Protobuf to 3.11.4 URL: https://github.com/apache/hbase/pull/1186#issuecomment-589868417 BTW src/main/asciidoc/_chapters/troubleshooting.adoc has an item named `trouble.hbasezerocopybytestring`. I think it should be removed with this PR. Right ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase-thirdparty] martin-g opened a new pull request #14: HBASE-19146 Update Protobuf to 3.11.4
martin-g opened a new pull request #14: HBASE-19146 Update Protobuf to 3.11.4 URL: https://github.com/apache/hbase-thirdparty/pull/14 Remove duplicate entry of maven-source-plugin. It was causing a warning in Maven builds. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] martin-g commented on issue #1186: HBASE-19146 Update Protobuf to 3.11.4
martin-g commented on issue #1186: HBASE-19146 Update Protobuf to 3.11.4 URL: https://github.com/apache/hbase/pull/1186#issuecomment-589867787 > Also, IIRC, we actually patch our pb (see build over in hbase-thirdparty https://github.com/apache/hbase-thirdparty/pull/14 Do I need to do something more there ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23880) [Flakey Test] TestRegionReplicaFailover fails frequently
[
https://issues.apache.org/jira/browse/HBASE-23880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17042209#comment-17042209
]
Hudson commented on HBASE-23880:
Results for branch branch-2
[build #2496 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2496/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2496//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2496//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2496//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> [Flakey Test] TestRegionReplicaFailover fails frequently
>
>
> Key: HBASE-23880
> URL: https://issues.apache.org/jira/browse/HBASE-23880
> Project: HBase
> Issue Type: Bug
> Components: flakies
>Affects Versions: 3.0.0, 2.3.0
>Reporter: Michael Stack
>Priority: Trivial
> Attachments:
> 0001-HBASE-23880-Flakey-Test-TestRegionReplicaFailover-fa.patch, Screen Shot
> 2020-02-20 at 10.09.09 PM.png
>
>
> Fails > 50% of the time in the GCE runs since we upped their ferocity a few
> days ago.
> Looking, the complaints are weirdly often OOME, can't create thread. Looking,
> it at least does start of a RS at end of a test when it kills one EVEN THOUGH
> the @before starts a whole new cluster. This improves general resource usage
> going by the resource dumps before and after but still loads of leaking.
> Cut down on the amount of work it does too. Let me push small patch and see
> if helps.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23849) Harden small and medium tests for lots of parallel runs with re-used jvms.
[ https://issues.apache.org/jira/browse/HBASE-23849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17042204#comment-17042204 ] Mark Robert Miller commented on HBASE-23849: HBASE-23882 is will be useful here as well. > Harden small and medium tests for lots of parallel runs with re-used jvms. > -- > > Key: HBASE-23849 > URL: https://issues.apache.org/jira/browse/HBASE-23849 > Project: HBase > Issue Type: Test >Reporter: Mark Robert Miller >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-23882) Scale *MiniCluster config for the environment it runs in.
Mark Robert Miller created HBASE-23882: -- Summary: Scale *MiniCluster config for the environment it runs in. Key: HBASE-23882 URL: https://issues.apache.org/jira/browse/HBASE-23882 Project: HBase Issue Type: Test Reporter: Mark Robert Miller -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23639) Change InterfaceAudience for ClusterManager interface and HBaseClusterManager class public
[ https://issues.apache.org/jira/browse/HBASE-23639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17042177#comment-17042177 ] Andrew Kyle Purtell commented on HBASE-23639: - I made a comment on the doc. Strictly speaking it's not necessary to move the classes to a new maven module. They can be moved to src/ within hbase-it and marked as public. Not sure there is much benefit of making a new module, given the refactoring is going to "break" hbase-it anyway, but I have not strong opinion about it either. > Change InterfaceAudience for ClusterManager interface and HBaseClusterManager > class public > --- > > Key: HBASE-23639 > URL: https://issues.apache.org/jira/browse/HBASE-23639 > Project: HBase > Issue Type: Improvement > Components: API, integration tests, test >Reporter: Mihir Monani >Assignee: Lokesh Khurana >Priority: Minor > > In hbase-it package, Class like RESTApiClusterManager and HBaseClusterManager > which has some part of implementation code for Chaos Action. > > If any user wants to create private implementation which resembles > HBaseClusterManager, then it has to be merged with hbase-it package as > ClusterManager Interface and it's extended implementations are private. > > We should make them public so anyone can have their own implementation and > need to be merged with hbase-it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1184: HBASE-23848 Removed deprecated setStopRow from Scan
Apache-HBase commented on issue #1184: HBASE-23848 Removed deprecated setStopRow from Scan URL: https://github.com/apache/hbase/pull/1184#issuecomment-589839667 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 12 new or modified test files. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 39s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 21s | master passed | | +1 :green_heart: | compile | 3m 55s | master passed | | +1 :green_heart: | checkstyle | 3m 45s | master passed | | +1 :green_heart: | shadedjars | 4m 44s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 46s | master passed | | +0 :ok: | spotbugs | 1m 34s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 9m 22s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 2s | the patch passed | | +1 :green_heart: | compile | 3m 56s | the patch passed | | +1 :green_heart: | javac | 3m 56s | the patch passed | | +1 :green_heart: | checkstyle | 0m 31s | The patch passed checkstyle in hbase-client | | +1 :green_heart: | checkstyle | 1m 6s | hbase-server: The patch generated 0 new + 18 unchanged - 2 fixed = 18 total (was 20) | | +1 :green_heart: | checkstyle | 0m 22s | The patch passed checkstyle in hbase-mapreduce | | +1 :green_heart: | checkstyle | 0m 51s | The patch passed checkstyle in hbase-thrift | | +1 :green_heart: | checkstyle | 0m 15s | The patch passed checkstyle in hbase-backup | | +1 :green_heart: | checkstyle | 0m 19s | hbase-it: The patch generated 0 new + 34 unchanged - 1 fixed = 34 total (was 35) | | +1 :green_heart: | checkstyle | 0m 17s | The patch passed checkstyle in hbase-rest | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 4m 43s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 15m 58s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | javadoc | 2m 49s | the patch passed | | +1 :green_heart: | findbugs | 10m 16s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 55s | hbase-client in the patch passed. | | -1 :x: | unit | 66m 49s | hbase-server in the patch failed. | | -1 :x: | unit | 8m 25s | hbase-mapreduce in the patch failed. | | +1 :green_heart: | unit | 2m 28s | hbase-thrift in the patch passed. | | -1 :x: | unit | 16m 39s | hbase-backup in the patch failed. | | +1 :green_heart: | unit | 1m 14s | hbase-it in the patch passed. | | +1 :green_heart: | unit | 3m 16s | hbase-rest in the patch passed. | | +1 :green_heart: | asflicense | 4m 7s | The patch does not generate ASF License warnings. | | | | 189m 42s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.regionserver.TestHStoreFile | | | hadoop.hbase.regionserver.TestSeekOptimizations | | | hadoop.hbase.snapshot.TestExportSnapshotV2NoCluster | | | hadoop.hbase.snapshot.TestExportSnapshotV1NoCluster | | | hadoop.hbase.backup.TestBackupDelete | | | hadoop.hbase.backup.TestRepairAfterFailedDelete | | | hadoop.hbase.backup.TestFullBackupSetRestoreSet | | | hadoop.hbase.backup.TestBackupShowHistory | | | hadoop.hbase.backup.TestIncrementalBackupWithBulkLoad | | | hadoop.hbase.backup.TestBackupDescribe | | | hadoop.hbase.backup.TestRestoreBoundaryTests | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1184/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1184 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 7528141f79d9 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality |
[jira] [Commented] (HBASE-23823) Run maven with more than default single thread (--threads=0.5C)
[
https://issues.apache.org/jira/browse/HBASE-23823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17042168#comment-17042168
]
Sean Busbey commented on HBASE-23823:
-
It's in this set of versions in the footer:
{code}
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.7.0
{code}
Looks like we aren't parsing the maven version correctly. Maybe we've changed
it's output to include a timestamp somehow?
> Run maven with more than default single thread (--threads=0.5C)
> ---
>
> Key: HBASE-23823
> URL: https://issues.apache.org/jira/browse/HBASE-23823
> Project: HBase
> Issue Type: Sub-task
>Reporter: Michael Stack
>Priority: Major
> Attachments:
> 0001-HBASE-23823-Run-maven-with-more-than-default-single-.patch,
> 0001-HBASE-23823-Run-maven-with-more-than-default-single-.patch,
> 0001-HBASE-23823-Run-maven-with-more-than-default-single-.patch,
> 0001-HBASE-23823-Run-maven-with-more-than-default-single-.patch
>
>
> See tail of parent task where we made commits to hbase-personality trying to
> make maven run more furiously on nightly builds by upping the maven thread
> count (the --threads flag ... see
> https://cwiki.apache.org/confluence/display/MAVEN/Parallel+builds+in+Maven+3).
> The effort was abandoned because it unsettled the build. This issue
> separates messing with the maven threads flag from the broader topic the
> parent covers.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-23854) Documentation update of external_apis.adoc#example-scala-code
[
https://issues.apache.org/jira/browse/HBASE-23854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey updated HBASE-23854:
Fix Version/s: 2.1.10
2.2.4
2.3.0
3.0.0
Assignee: Michael Heil
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Documentation update of external_apis.adoc#example-scala-code
> -
>
> Key: HBASE-23854
> URL: https://issues.apache.org/jira/browse/HBASE-23854
> Project: HBase
> Issue Type: Task
> Components: documentation
>Reporter: Michael Heil
>Assignee: Michael Heil
>Priority: Trivial
> Labels: beginner
> Fix For: 3.0.0, 2.3.0, 2.2.4, 2.1.10
>
> Attachments: HBASE-23854.patch
>
>
> Update the Example Scala Code in the Reference Guide as it contains
> deprecated content such as
> * new HBaseConfiguration()
> * new HTable(conf, "mytable")
> * add(Bytes.toBytes("ids"),Bytes.toBytes("id1"),Bytes.toBytes("one"))
> Replace it with:
> * HBaseConfiguration.create()
> * TableName.valueOf({color:#6a8759}"mytable"{color})
> *
> addColumn(Bytes.toBytes({color:#6a8759}"ids"{color}){color:#cc7832},{color}Bytes.toBytes({color:#6a8759}"id1"{color}){color:#cc7832},{color}Bytes.toBytes({color:#6a8759}"one"{color}))
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23854) Documentation update of external_apis.adoc#example-scala-code
[
https://issues.apache.org/jira/browse/HBASE-23854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17042163#comment-17042163
]
Sean Busbey commented on HBASE-23854:
-
Hi [~michaelheil] and welcome to HBase!
I've added you to the set of contributors in our jira's permissions. You should
now be able to assign jiras to yourself.
Thanks for the doc update. For future contributions you'll get more reviewers
noticing things if you submit a github PR. So long as you reference the jira ID
in the commit message there should be a bot to link things up.
i.e. for this jira the commit subject would be "HBASE-23854 replaced deprecated
code in Example Scala Code section"
> Documentation update of external_apis.adoc#example-scala-code
> -
>
> Key: HBASE-23854
> URL: https://issues.apache.org/jira/browse/HBASE-23854
> Project: HBase
> Issue Type: Task
> Components: documentation
>Reporter: Michael Heil
>Priority: Trivial
> Labels: beginner
> Attachments: HBASE-23854.patch
>
>
> Update the Example Scala Code in the Reference Guide as it contains
> deprecated content such as
> * new HBaseConfiguration()
> * new HTable(conf, "mytable")
> * add(Bytes.toBytes("ids"),Bytes.toBytes("id1"),Bytes.toBytes("one"))
> Replace it with:
> * HBaseConfiguration.create()
> * TableName.valueOf({color:#6a8759}"mytable"{color})
> *
> addColumn(Bytes.toBytes({color:#6a8759}"ids"{color}){color:#cc7832},{color}Bytes.toBytes({color:#6a8759}"id1"{color}){color:#cc7832},{color}Bytes.toBytes({color:#6a8759}"one"{color}))
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1188: HBASE-23843 Removed deprecated Scan(byte[]) from Scan
Apache-HBase commented on issue #1188: HBASE-23843 Removed deprecated Scan(byte[]) from Scan URL: https://github.com/apache/hbase/pull/1188#issuecomment-589831578 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 10s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 16 new or modified test files. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 34s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 46s | master passed | | +1 :green_heart: | compile | 3m 51s | master passed | | +1 :green_heart: | checkstyle | 3m 36s | master passed | | +1 :green_heart: | shadedjars | 5m 7s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 42s | master passed | | +0 :ok: | spotbugs | 1m 38s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 9m 49s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 35s | the patch passed | | +1 :green_heart: | compile | 3m 47s | the patch passed | | +1 :green_heart: | javac | 3m 47s | the patch passed | | +1 :green_heart: | checkstyle | 3m 30s | the patch passed | | +1 :green_heart: | rubocop | 0m 4s | There were no new rubocop issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 5m 4s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 17m 36s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | javadoc | 2m 44s | the patch passed | | +1 :green_heart: | findbugs | 10m 45s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 59s | hbase-client in the patch passed. | | -1 :x: | unit | 95m 22s | hbase-server in the patch failed. | | +1 :green_heart: | unit | 9m 35s | hbase-mapreduce in the patch passed. | | +1 :green_heart: | unit | 2m 46s | hbase-thrift in the patch passed. | | +1 :green_heart: | unit | 7m 10s | hbase-shell in the patch passed. | | +1 :green_heart: | unit | 4m 27s | hbase-rest in the patch passed. | | -1 :x: | unit | 2m 42s | hbase-examples in the patch failed. | | +1 :green_heart: | asflicense | 2m 43s | The patch does not generate ASF License warnings. | | | | 216m 2s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.security.provider.example.TestShadeSaslAuthenticationProvider | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1188/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1188 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile rubocop | | uname | Linux df220f883e37 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1188/out/precommit/personality/provided.sh | | git revision | master / 3ab0135c0e | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1188/3/artifact/out/patch-unit-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1188/3/artifact/out/patch-unit-hbase-examples.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1188/3/testReport/ | | Max. process+thread count | 6567 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-shell hbase-rest hbase-examples U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1188/3/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 rubocop=0.80.0 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an
[GitHub] [hbase] Apache-HBase commented on issue #1146: HBASE-23781 Removed deprecated createTableDescriptor(String) from HBaseTestingUtility
Apache-HBase commented on issue #1146: HBASE-23781 Removed deprecated createTableDescriptor(String) from HBaseTestingUtility URL: https://github.com/apache/hbase/pull/1146#issuecomment-589825882 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 17 new or modified test files. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 41s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 25s | master passed | | +1 :green_heart: | compile | 1m 28s | master passed | | +1 :green_heart: | checkstyle | 1m 34s | master passed | | +1 :green_heart: | shadedjars | 4m 47s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 55s | master passed | | +0 :ok: | spotbugs | 4m 16s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 4m 13s | master passed | | -0 :warning: | patch | 4m 31s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 28s | the patch passed | | +1 :green_heart: | compile | 1m 32s | the patch passed | | +1 :green_heart: | javac | 1m 32s | the patch passed | | +1 :green_heart: | checkstyle | 1m 31s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 4m 50s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 15m 50s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | javadoc | 0m 51s | the patch passed | | +1 :green_heart: | findbugs | 4m 21s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 64m 59s | hbase-server in the patch failed. | | +1 :green_heart: | unit | 1m 14s | hbase-it in the patch passed. | | +1 :green_heart: | asflicense | 1m 6s | The patch does not generate ASF License warnings. | | | | 128m 18s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.replication.TestNamespaceReplicationWithBulkLoadedData | | | hadoop.hbase.replication.TestReplicationStatus | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1146/8/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1146 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux fd2a0ec51b66 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1146/out/precommit/personality/provided.sh | | git revision | master / 3ab0135c0e | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1146/8/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1146/8/testReport/ | | Max. process+thread count | 9799 (vs. ulimit of 1) | | modules | C: hbase-server hbase-it U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1146/8/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Comment Edited] (HBASE-23881) TestShadeSaslAuthenticationProvider failures
[
https://issues.apache.org/jira/browse/HBASE-23881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17042112#comment-17042112
]
Bharath Vissapragada edited comment on HBASE-23881 at 2/21/20 7:46 PM:
---
Ok.. I should've clarified it a bit better. The test passes now too but _I
think_ it passes for a wrong reason. The authentication goes through fine
(which shouldn't happen) but because the getTable() throws a different form of
DNRIOE (for whatever reason), the test passes.
To verify this, I slightly changed the test as follows. I do a
{{listTableDescriptors()}} on the connection that is not supposed to work.
{noformat}
@Test
public void testNegativeAuthentication() throws Exception {
// Validate that we can read that record back out as the user with our
custom auth'n
final Configuration clientConf = new Configuration(CONF);
clientConf.setInt(HConstants.HBASE_CLIENT_RETRIES_NUMBER, 3);
try (Connection conn = ConnectionFactory.createConnection(clientConf)) {
UserGroupInformation user1 = UserGroupInformation.createUserForTesting(
"user1", new String[0]);
user1.addToken(
ShadeClientTokenUtil.obtainToken(conn, "user1", "not a real
password".toCharArray()));
user1.doAs(new PrivilegedExceptionAction() {
@Override public Void run() throws Exception {
try (Connection conn =
ConnectionFactory.createConnection(clientConf)) {
conn.getAdmin().listTableDescriptors();
fail("Should not successfully authenticate with HBase");
return null;
}
}
});
}
}
{noformat}
and .. .it fails as follows...
{noformat}
java.lang.AssertionError: Should not successfully authenticate with HBase
at org.junit.Assert.fail(Assert.java:89)
at
org.apache.hadoop.hbase.security.provider.example.TestShadeSaslAuthenticationProvider$3.run(TestShadeSaslAuthenticationProvider.java:237)
at
org.apache.hadoop.hbase.security.provider.example.TestShadeSaslAuthenticationProvider$3.run(TestShadeSaslAuthenticationProvider.java:233)
at java.security.AccessController.doPrivileged(Native Method)
at javax.security.auth.Subject.doAs(Subject.java:422)
at
org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1844)
at
org.apache.hadoop.hbase.security.provider.example.TestShadeSaslAuthenticationProvider.testNegativeAuthentication(TestShadeSaslAuthenticationProvider.java:233)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:61)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at
org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
{noformat}
was (Author: bharathv):
Ok.. I should've clarified it a bit better. The test passes now too but I think
it passes for a wrong reason. The authentication goes through fine but because
the getTable() throws a different form of DNRIOE (for whatever reason), the
test passes.
To verify this, I slightly changed the test as follows. I do a
{{listTableDescriptors()}} on the connection that is supposed to not work.
{noformat}
@Test
public void testNegativeAuthentication() throws Exception {
// Validate that we can read that record back out as the user with our
custom auth'n
final Configuration clientConf = new Configuration(CONF);
clientConf.setInt(HConstants.HBASE_CLIENT_RETRIES_NUMBER, 3);
try (Connection conn = ConnectionFactory.createConnection(clientConf)) {
UserGroupInformation user1 = UserGroupInformation.createUserForTesting(
"user1", new String[0]);
user1.addToken(
ShadeClientTokenUtil.obtainToken(conn, "user1", "not a real
password".toCharArray()));
user1.doAs(new PrivilegedExceptionAction() {
@Override public Void run() throws Exception {
try (Connection conn =
[GitHub] [hbase] Apache-HBase commented on issue #1189: HBASE-23842 Removed deprecated Scan(byte[], byte[]) from Scan
Apache-HBase commented on issue #1189: HBASE-23842 Removed deprecated Scan(byte[], byte[]) from Scan URL: https://github.com/apache/hbase/pull/1189#issuecomment-589806116 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 18 new or modified test files. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 38s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 14s | master passed | | +1 :green_heart: | compile | 3m 46s | master passed | | +1 :green_heart: | checkstyle | 3m 33s | master passed | | +1 :green_heart: | shadedjars | 4m 42s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 45s | master passed | | +0 :ok: | spotbugs | 1m 31s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 9m 18s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 0s | the patch passed | | +1 :green_heart: | compile | 3m 46s | the patch passed | | +1 :green_heart: | javac | 3m 46s | the patch passed | | +1 :green_heart: | checkstyle | 0m 31s | The patch passed checkstyle in hbase-client | | +1 :green_heart: | checkstyle | 1m 17s | hbase-server: The patch generated 0 new + 374 unchanged - 83 fixed = 374 total (was 457) | | +1 :green_heart: | checkstyle | 0m 20s | The patch passed checkstyle in hbase-mapreduce | | +1 :green_heart: | checkstyle | 0m 39s | The patch passed checkstyle in hbase-thrift | | +1 :green_heart: | checkstyle | 0m 13s | The patch passed checkstyle in hbase-shell | | +1 :green_heart: | checkstyle | 0m 14s | The patch passed checkstyle in hbase-endpoint | | +1 :green_heart: | checkstyle | 0m 17s | The patch passed checkstyle in hbase-rest | | +1 :green_heart: | rubocop | 0m 3s | There were no new rubocop issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 4m 43s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 16m 38s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | javadoc | 2m 46s | the patch passed | | +1 :green_heart: | findbugs | 10m 50s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 53s | hbase-client in the patch passed. | | -1 :x: | unit | 77m 22s | hbase-server in the patch failed. | | -1 :x: | unit | 9m 50s | hbase-mapreduce in the patch failed. | | +1 :green_heart: | unit | 2m 35s | hbase-thrift in the patch passed. | | +1 :green_heart: | unit | 7m 21s | hbase-shell in the patch passed. | | +1 :green_heart: | unit | 3m 14s | hbase-endpoint in the patch passed. | | +1 :green_heart: | unit | 3m 18s | hbase-rest in the patch passed. | | +1 :green_heart: | asflicense | 3m 19s | The patch does not generate ASF License warnings. | | | | 193m 54s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.replication.TestReplicationKillSlaveRS | | | hadoop.hbase.regionserver.TestHStoreFile | | | hadoop.hbase.replication.TestReplicationSyncUpTool | | | hadoop.hbase.replication.multiwal.TestReplicationKillMasterRSCompressedWithMultipleAsyncWAL | | | hadoop.hbase.client.TestAsyncTableGetMultiThreaded | | | hadoop.hbase.replication.TestSerialReplicationFailover | | | hadoop.hbase.replication.TestReplicationEmptyWALRecovery | | | hadoop.hbase.replication.TestSyncReplicationMoreLogsInLocalCopyToRemote | | | hadoop.hbase.snapshot.TestExportSnapshotV2NoCluster | | | hadoop.hbase.snapshot.TestExportSnapshotV1NoCluster | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1189/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1189 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile rubocop | | uname |
[GitHub] [hbase] jojochuang commented on issue #1179: HBASE-23861. Reconcile Hadoop version.
jojochuang commented on issue #1179: HBASE-23861. Reconcile Hadoop version. URL: https://github.com/apache/hbase/pull/1179#issuecomment-589805344 I think the patch doesn't require additional change to support hadoop-2 profile... mvn clean install -Dhadoop-two.version=2.10.1-SNAPSHOT mvn -X test -Dtest=TestHelloHBase -Dhadoop-two.version=2.10.1-SNAPSHOT I see that it uses hadoop-*-2.10-1-SNAPSHOT jars in runtime. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] busbey commented on issue #1190: HBASE-23862 Fix flaky TestSnapshotFromMaster in 1.x versions
busbey commented on issue #1190: HBASE-23862 Fix flaky TestSnapshotFromMaster in 1.x versions URL: https://github.com/apache/hbase/pull/1190#issuecomment-589792789 > HBase nightly builds are broken due to some docker/java issue. Is there a jira for this already? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase-thirdparty] jojochuang commented on a change in pull request #13: HBASE-23811. [OpenTracing] Add shaded JaegerTracing tracer to hbase-thirdparty.
jojochuang commented on a change in pull request #13: HBASE-23811. [OpenTracing] Add shaded JaegerTracing tracer to hbase-thirdparty. URL: https://github.com/apache/hbase-thirdparty/pull/13#discussion_r382754747 ## File path: hbase-shaded-jaeger/pom.xml ## @@ -0,0 +1,176 @@ + +https://maven.apache.org/POM/4.0.0; + xmlns:xsi="https://www.w3.org/2001/XMLSchema-instance; + xsi:schemaLocation="https://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd;> + +4.0.0 + +hbase-thirdparty +org.apache.hbase.thirdparty +3.2.1-SNAPSHOT Review comment: Bumped the version to 3.3.0-SNAPSHOT. I believe I should do this for all shaded thirdparty libraries. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23881) TestShadeSaslAuthenticationProvider failures
[
https://issues.apache.org/jira/browse/HBASE-23881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17042112#comment-17042112
]
Bharath Vissapragada commented on HBASE-23881:
--
Ok.. I should've clarified it a bit better. The test passes now too but I think
it passes for a wrong reason. The authentication goes through fine but because
the getTable() throws a different form of DNRIOE (for whatever reason), the
test passes.
To verify this, I slightly changed the test as follows. I do a
{{listTableDescriptors()}} on the connection that is supposed to not work.
{noformat}
@Test
public void testNegativeAuthentication() throws Exception {
// Validate that we can read that record back out as the user with our
custom auth'n
final Configuration clientConf = new Configuration(CONF);
clientConf.setInt(HConstants.HBASE_CLIENT_RETRIES_NUMBER, 3);
try (Connection conn = ConnectionFactory.createConnection(clientConf)) {
UserGroupInformation user1 = UserGroupInformation.createUserForTesting(
"user1", new String[0]);
user1.addToken(
ShadeClientTokenUtil.obtainToken(conn, "user1", "not a real
password".toCharArray()));
user1.doAs(new PrivilegedExceptionAction() {
@Override public Void run() throws Exception {
try (Connection conn =
ConnectionFactory.createConnection(clientConf)) {
conn.getAdmin().listTableDescriptors();
fail("Should not successfully authenticate with HBase");
return null;
}
}
});
}
}
{noformat}
and .. .it fails as follows...
{noformat}
java.lang.AssertionError: Should not successfully authenticate with HBase
at org.junit.Assert.fail(Assert.java:89)
at
org.apache.hadoop.hbase.security.provider.example.TestShadeSaslAuthenticationProvider$3.run(TestShadeSaslAuthenticationProvider.java:237)
at
org.apache.hadoop.hbase.security.provider.example.TestShadeSaslAuthenticationProvider$3.run(TestShadeSaslAuthenticationProvider.java:233)
at java.security.AccessController.doPrivileged(Native Method)
at javax.security.auth.Subject.doAs(Subject.java:422)
at
org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1844)
at
org.apache.hadoop.hbase.security.provider.example.TestShadeSaslAuthenticationProvider.testNegativeAuthentication(TestShadeSaslAuthenticationProvider.java:233)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:61)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at
org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
{noformat}
> TestShadeSaslAuthenticationProvider failures
>
>
> Key: HBASE-23881
> URL: https://issues.apache.org/jira/browse/HBASE-23881
> Project: HBase
> Issue Type: Bug
> Components: test
>Affects Versions: 3.0.0
>Reporter: Bharath Vissapragada
>Assignee: Bharath Vissapragada
>Priority: Major
>
> TestShadeSaslAuthenticationProvider now fails deterministically with the
> following exception..
> {noformat}
> java.lang.Exception: Unexpected exception,
> expected but
> was
> at
> org.apache.hadoop.hbase.security.provider.example.TestShadeSaslAuthenticationProvider.testNegativeAuthentication(TestShadeSaslAuthenticationProvider.java:233)
> {noformat}
> The test now fails a different place than before merging HBASE-18095 because
> the RPCs are also a part of connection setup. We might need to rewrite the
> test..
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase-thirdparty] jojochuang commented on a change in pull request #13: HBASE-23811. [OpenTracing] Add shaded JaegerTracing tracer to hbase-thirdparty.
jojochuang commented on a change in pull request #13: HBASE-23811.
[OpenTracing] Add shaded JaegerTracing tracer to hbase-thirdparty.
URL: https://github.com/apache/hbase-thirdparty/pull/13#discussion_r382754826
##
File path: hbase-shaded-jaeger/pom.xml
##
@@ -0,0 +1,176 @@
+
+https://maven.apache.org/POM/4.0.0;
+ xmlns:xsi="https://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="https://maven.apache.org/POM/4.0.0
https://maven.apache.org/xsd/maven-4.0.0.xsd;>
+
+4.0.0
+
+hbase-thirdparty
+org.apache.hbase.thirdparty
+3.2.1-SNAPSHOT
+..
+
+hbase-shaded-jaeger
+Apache HBase Relocated (Shaded) JaegerTracing Libs
+The shaded uber jar of JaegerTracing library used by
HBase.
+
+
+
+io.jaegertracing
+jaeger-client
+${jaegertracing.version}
+
+
+
+
+
+
+
+
+maven-assembly-plugin
+
+true
+
+
+
+org.apache.maven.plugins
+maven-shade-plugin
+
+
+
aggregate-into-a-jar-with-relocated-third-parties
+package
+
+shade
+
+
+false
+
false
+false
+
+
+
+
org.apache.httpcomponents:httpclient
Review comment:
Done.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (HBASE-23881) TestShadeSaslAuthenticationProvider failures
[
https://issues.apache.org/jira/browse/HBASE-23881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17042096#comment-17042096
]
Josh Elser commented on HBASE-23881:
Expects a DNRIOE because the user provides an invalid password. So, we should
return back "hey, don't retry this (because your password will still be wrong)".
Is the TableNotFoundException coming because of some exception mangling in not
being allowed to read meta?
The test was passing reliably for me prior to commit. This is a much faster
bit-rot than normal..
> TestShadeSaslAuthenticationProvider failures
>
>
> Key: HBASE-23881
> URL: https://issues.apache.org/jira/browse/HBASE-23881
> Project: HBase
> Issue Type: Bug
> Components: test
>Affects Versions: 3.0.0
>Reporter: Bharath Vissapragada
>Assignee: Bharath Vissapragada
>Priority: Major
>
> TestShadeSaslAuthenticationProvider now fails deterministically with the
> following exception..
> {noformat}
> java.lang.Exception: Unexpected exception,
> expected but
> was
> at
> org.apache.hadoop.hbase.security.provider.example.TestShadeSaslAuthenticationProvider.testNegativeAuthentication(TestShadeSaslAuthenticationProvider.java:233)
> {noformat}
> The test now fails a different place than before merging HBASE-18095 because
> the RPCs are also a part of connection setup. We might need to rewrite the
> test..
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23881) TestShadeSaslAuthenticationProvider failures
[
https://issues.apache.org/jira/browse/HBASE-23881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17042095#comment-17042095
]
Bharath Vissapragada commented on HBASE-23881:
--
[~elserj] The ShadeSaslAuthProvider looks a little shady ;), thought you might
have an idea. I reverted all my patches for HBASE-18095 and the test actually
fails with a {{TableNotFoundException}}, which means the auth is going through?
The test passes because it expects {{DoNotRetryIOException}} and
{{TableNotFoundException}} extends that. I thought you might know this on top
of your head. Any smoking gun? (why does it expect a DoNotRetryIOException?)
{noformat}
org.apache.hadoop.hbase.TableNotFoundException: testNegativeAuthentication
at java.lang.Thread.getStackTrace(Thread.java:1559)
at
org.apache.hadoop.hbase.util.FutureUtils.setStackTrace(FutureUtils.java:130)
at
org.apache.hadoop.hbase.util.FutureUtils.rethrow(FutureUtils.java:145)
at org.apache.hadoop.hbase.util.FutureUtils.get(FutureUtils.java:168)
at
org.apache.hadoop.hbase.client.TableOverAsyncTable.get(TableOverAsyncTable.java:180)
at
org.apache.hadoop.hbase.security.provider.example.TestShadeSaslAuthenticationProvider$3.run(TestShadeSaslAuthenticationProvider.java:237)
at
org.apache.hadoop.hbase.security.provider.example.TestShadeSaslAuthenticationProvider$3.run(TestShadeSaslAuthenticationProvider.java:233)
at java.security.AccessController.doPrivileged(Native Method)
at javax.security.auth.Subject.doAs(Subject.java:422)
at
org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1844)
at
org.apache.hadoop.hbase.security.provider.example.TestShadeSaslAuthenticationProvider.testNegativeAuthentication(TestShadeSaslAuthenticationProvider.java:233)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:61)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at
org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
at
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at
org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:288)
at
org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:282)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.lang.Thread.run(Thread.java:748)
at Future.get(Unknown Source)
at
org.apache.hadoop.hbase.client.AsyncNonMetaRegionLocator$1.onComplete(AsyncNonMetaRegionLocator.java:453)
at
org.apache.hadoop.hbase.client.AsyncClientScanner.lambda$startScan$1(AsyncClientScanner.java:183)
{noformat}
> TestShadeSaslAuthenticationProvider failures
>
>
> Key: HBASE-23881
> URL: https://issues.apache.org/jira/browse/HBASE-23881
> Project: HBase
> Issue Type: Bug
> Components: test
>Affects Versions: 3.0.0
>Reporter: Bharath Vissapragada
>Assignee: Bharath Vissapragada
>Priority: Major
>
> TestShadeSaslAuthenticationProvider now fails deterministically with the
> following exception..
> {noformat}
> java.lang.Exception: Unexpected exception,
>
[jira] [Resolved] (HBASE-23863) [Flakey Test] TestReplicationEndpointWithMultipleWAL#testInterClusterReplication improvements
[ https://issues.apache.org/jira/browse/HBASE-23863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-23863. --- Assignee: Michael Stack Resolution: Fixed Resolving. Pushed on branch-2 only. Not on master because it has changed. Doesn't seem to have definitively fixed this issue so changed title to say 'improvement'. More to come. > [Flakey Test] > TestReplicationEndpointWithMultipleWAL#testInterClusterReplication > improvements > - > > Key: HBASE-23863 > URL: https://issues.apache.org/jira/browse/HBASE-23863 > Project: HBase > Issue Type: Bug > Components: flakies >Reporter: Michael Stack >Assignee: Michael Stack >Priority: Major > Fix For: 2.3.0 > > Attachments: > 0001-HBASE-23863-Flakey-Test-TestReplicationEndpointWithM.patch > > > This one fails in an odd way about 15% of the time where it replicates 2499 > edits of 2500 And seemingly always these numbers. Odd. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] HorizonNet commented on issue #1146: HBASE-23781 Removed deprecated createTableDescriptor(String) from HBaseTestingUtility
HorizonNet commented on issue #1146: HBASE-23781 Removed deprecated createTableDescriptor(String) from HBaseTestingUtility URL: https://github.com/apache/hbase/pull/1146#issuecomment-589776705 Fixed the remaining Checkstyle violation. The test failing in the last build passes locally. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (HBASE-23881) TestShadeSaslAuthenticationProvider failures
Bharath Vissapragada created HBASE-23881:
Summary: TestShadeSaslAuthenticationProvider failures
Key: HBASE-23881
URL: https://issues.apache.org/jira/browse/HBASE-23881
Project: HBase
Issue Type: Bug
Components: test
Affects Versions: 3.0.0
Reporter: Bharath Vissapragada
Assignee: Bharath Vissapragada
TestShadeSaslAuthenticationProvider now fails deterministically with the
following exception..
{noformat}
java.lang.Exception: Unexpected exception,
expected but
was
at
org.apache.hadoop.hbase.security.provider.example.TestShadeSaslAuthenticationProvider.testNegativeAuthentication(TestShadeSaslAuthenticationProvider.java:233)
{noformat}
The test now fails a different place than before merging HBASE-18095 because
the RPCs are also a part of connection setup. We might need to rewrite the
test..
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] HorizonNet commented on issue #1184: HBASE-23848 Removed deprecated setStopRow from Scan
HorizonNet commented on issue #1184: HBASE-23848 Removed deprecated setStopRow from Scan URL: https://github.com/apache/hbase/pull/1184#issuecomment-589767036 Fixed a failure in `TestScanWithBloomError`. All other tests are passing locally. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-23863) [Flakey Test] TestReplicationEndpointWithMultipleWAL#testInterClusterReplication
[ https://issues.apache.org/jira/browse/HBASE-23863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-23863: -- Fix Version/s: (was: 3.0.0) > [Flakey Test] > TestReplicationEndpointWithMultipleWAL#testInterClusterReplication > > > Key: HBASE-23863 > URL: https://issues.apache.org/jira/browse/HBASE-23863 > Project: HBase > Issue Type: Bug > Components: flakies >Reporter: Michael Stack >Priority: Major > Fix For: 2.3.0 > > Attachments: > 0001-HBASE-23863-Flakey-Test-TestReplicationEndpointWithM.patch > > > This one fails in an odd way about 15% of the time where it replicates 2499 > edits of 2500 And seemingly always these numbers. Odd. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23863) [Flakey Test] TestReplicationEndpointWithMultipleWAL#testInterClusterReplication improvements
[ https://issues.apache.org/jira/browse/HBASE-23863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-23863: -- Summary: [Flakey Test] TestReplicationEndpointWithMultipleWAL#testInterClusterReplication improvements (was: [Flakey Test] TestReplicationEndpointWithMultipleWAL#testInterClusterReplication) > [Flakey Test] > TestReplicationEndpointWithMultipleWAL#testInterClusterReplication > improvements > - > > Key: HBASE-23863 > URL: https://issues.apache.org/jira/browse/HBASE-23863 > Project: HBase > Issue Type: Bug > Components: flakies >Reporter: Michael Stack >Priority: Major > Fix For: 2.3.0 > > Attachments: > 0001-HBASE-23863-Flakey-Test-TestReplicationEndpointWithM.patch > > > This one fails in an odd way about 15% of the time where it replicates 2499 > edits of 2500 And seemingly always these numbers. Odd. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-23880) [Flakey Test] TestRegionReplicaFailover fails frequently
[ https://issues.apache.org/jira/browse/HBASE-23880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-23880. --- Resolution: Incomplete Resolving as 'incomplete' after reverting patch pushed yesterday. This is still an issue. Will be back w/ new JIRA after figuring it out. > [Flakey Test] TestRegionReplicaFailover fails frequently > > > Key: HBASE-23880 > URL: https://issues.apache.org/jira/browse/HBASE-23880 > Project: HBase > Issue Type: Bug > Components: flakies >Affects Versions: 3.0.0, 2.3.0 >Reporter: Michael Stack >Priority: Trivial > Attachments: > 0001-HBASE-23880-Flakey-Test-TestRegionReplicaFailover-fa.patch, Screen Shot > 2020-02-20 at 10.09.09 PM.png > > > Fails > 50% of the time in the GCE runs since we upped their ferocity a few > days ago. > Looking, the complaints are weirdly often OOME, can't create thread. Looking, > it at least does start of a RS at end of a test when it kills one EVEN THOUGH > the @before starts a whole new cluster. This improves general resource usage > going by the resource dumps before and after but still loads of leaking. > Cut down on the amount of work it does too. Let me push small patch and see > if helps. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23880) [Flakey Test] TestRegionReplicaFailover fails frequently
[ https://issues.apache.org/jira/browse/HBASE-23880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17042063#comment-17042063 ] Michael Stack commented on HBASE-23880: --- Build has gone a bit wonky. Let me revert this patch though since it does not 'fix' the issue seen. Will close and open a new JIRA after I figure whats up. > [Flakey Test] TestRegionReplicaFailover fails frequently > > > Key: HBASE-23880 > URL: https://issues.apache.org/jira/browse/HBASE-23880 > Project: HBase > Issue Type: Bug > Components: flakies >Affects Versions: 3.0.0, 2.3.0 >Reporter: Michael Stack >Priority: Trivial > Attachments: > 0001-HBASE-23880-Flakey-Test-TestRegionReplicaFailover-fa.patch, Screen Shot > 2020-02-20 at 10.09.09 PM.png > > > Fails > 50% of the time in the GCE runs since we upped their ferocity a few > days ago. > Looking, the complaints are weirdly often OOME, can't create thread. Looking, > it at least does start of a RS at end of a test when it kills one EVEN THOUGH > the @before starts a whole new cluster. This improves general resource usage > going by the resource dumps before and after but still loads of leaking. > Cut down on the amount of work it does too. Let me push small patch and see > if helps. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] HorizonNet commented on issue #1188: HBASE-23843 Removed deprecated Scan(byte[]) from Scan
HorizonNet commented on issue #1188: HBASE-23843 Removed deprecated Scan(byte[]) from Scan URL: https://github.com/apache/hbase/pull/1188#issuecomment-589746950 Test failures from latest build pass locally, except `TestShadeSaslAuthenticationProvider`, which seems to be unrelated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (HBASE-23561) Look up of Region in Master by encoded region name is O(n)
[
https://issues.apache.org/jira/browse/HBASE-23561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wellington Chevreuil resolved HBASE-23561.
--
Resolution: Fixed
Merged into master. Thanks for the contribution, [~minwoo.kang]!
> Look up of Region in Master by encoded region name is O(n)
> --
>
> Key: HBASE-23561
> URL: https://issues.apache.org/jira/browse/HBASE-23561
> Project: HBase
> Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Michael Stack
>Assignee: Minwoo Kang
>Priority: Trivial
> Fix For: 3.0.0
>
>
> {{ public RegionState getRegionState(final String encodedRegionName) {
> // TODO: Need a map but it is just dispatch merge...
> for (RegionStateNode node: regionsMap.values()) {
> if (node.getRegionInfo().getEncodedName().equals(encodedRegionName)) {
> return node.toRegionState();
> }
> }
> return null;
> }}}
> It is not used much so making it trivial.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-23561) Look up of Region in Master by encoded region name is O(n)
[
https://issues.apache.org/jira/browse/HBASE-23561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wellington Chevreuil updated HBASE-23561:
-
Affects Version/s: 3.0.0
> Look up of Region in Master by encoded region name is O(n)
> --
>
> Key: HBASE-23561
> URL: https://issues.apache.org/jira/browse/HBASE-23561
> Project: HBase
> Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Michael Stack
>Assignee: Minwoo Kang
>Priority: Trivial
>
> {{ public RegionState getRegionState(final String encodedRegionName) {
> // TODO: Need a map but it is just dispatch merge...
> for (RegionStateNode node: regionsMap.values()) {
> if (node.getRegionInfo().getEncodedName().equals(encodedRegionName)) {
> return node.toRegionState();
> }
> }
> return null;
> }}}
> It is not used much so making it trivial.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-23561) Look up of Region in Master by encoded region name is O(n)
[
https://issues.apache.org/jira/browse/HBASE-23561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wellington Chevreuil updated HBASE-23561:
-
Fix Version/s: 3.0.0
> Look up of Region in Master by encoded region name is O(n)
> --
>
> Key: HBASE-23561
> URL: https://issues.apache.org/jira/browse/HBASE-23561
> Project: HBase
> Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Michael Stack
>Assignee: Minwoo Kang
>Priority: Trivial
> Fix For: 3.0.0
>
>
> {{ public RegionState getRegionState(final String encodedRegionName) {
> // TODO: Need a map but it is just dispatch merge...
> for (RegionStateNode node: regionsMap.values()) {
> if (node.getRegionInfo().getEncodedName().equals(encodedRegionName)) {
> return node.toRegionState();
> }
> }
> return null;
> }}}
> It is not used much so making it trivial.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] wchevreuil merged pull request #1193: HBASE-23561 Look up of Region in Master by encoded region name is O(n)
wchevreuil merged pull request #1193: HBASE-23561 Look up of Region in Master by encoded region name is O(n) URL: https://github.com/apache/hbase/pull/1193 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] HorizonNet commented on issue #1189: HBASE-23842 Removed deprecated Scan(byte[], byte[]) from Scan
HorizonNet commented on issue #1189: HBASE-23842 Removed deprecated Scan(byte[], byte[]) from Scan URL: https://github.com/apache/hbase/pull/1189#issuecomment-589727451 Latest test failures were related. Updated the patch to include a fix. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] wchevreuil commented on issue #1193: HBASE-23561 Look up of Region in Master by encoded region name is O(n)
wchevreuil commented on issue #1193: HBASE-23561 Look up of Region in Master by encoded region name is O(n) URL: https://github.com/apache/hbase/pull/1193#issuecomment-589727097 Got a green, let me merge this PR. Thanks for the contribution, @mwkang ! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23880) [Flakey Test] TestRegionReplicaFailover fails frequently
[
https://issues.apache.org/jira/browse/HBASE-23880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17041995#comment-17041995
]
Michael Stack commented on HBASE-23880:
---
This doesn't seem to have helped. Build #5526 is the one that added the patch
but a test in it failed with the same old:
{code}
Error Message
unable to create new native thread
Stacktrace
java.lang.OutOfMemoryError: unable to create new native thread
at
org.apache.hadoop.hbase.regionserver.TestRegionReplicaFailover.verifyNumericRowsWithTimeout(TestRegionReplicaFailover.java:204)
at
org.apache.hadoop.hbase.regionserver.TestRegionReplicaFailover.testSecondaryRegionKill(TestRegionReplicaFailover.java:220)
{code}
Will be back
> [Flakey Test] TestRegionReplicaFailover fails frequently
>
>
> Key: HBASE-23880
> URL: https://issues.apache.org/jira/browse/HBASE-23880
> Project: HBase
> Issue Type: Bug
> Components: flakies
>Affects Versions: 3.0.0, 2.3.0
>Reporter: Michael Stack
>Priority: Trivial
> Attachments:
> 0001-HBASE-23880-Flakey-Test-TestRegionReplicaFailover-fa.patch, Screen Shot
> 2020-02-20 at 10.09.09 PM.png
>
>
> Fails > 50% of the time in the GCE runs since we upped their ferocity a few
> days ago.
> Looking, the complaints are weirdly often OOME, can't create thread. Looking,
> it at least does start of a RS at end of a test when it kills one EVEN THOUGH
> the @before starts a whole new cluster. This improves general resource usage
> going by the resource dumps before and after but still loads of leaking.
> Cut down on the amount of work it does too. Let me push small patch and see
> if helps.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
