[jira] [Commented] (HBASE-23895) STUCK Region-In-Transition when failed to insert procedure to procedure store
[
https://issues.apache.org/jira/browse/HBASE-23895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049978#comment-17049978
]
Guanghao Zhang commented on HBASE-23895:
Talked with [~zhangduo] offline. One easy fix is save the current rpc call to a
local variable. And set it back after mutate region.
> STUCK Region-In-Transition when failed to insert procedure to procedure store
> -
>
> Key: HBASE-23895
> URL: https://issues.apache.org/jira/browse/HBASE-23895
> Project: HBase
> Issue Type: Bug
> Components: proc-v2, RegionProcedureStore
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
> Attachments: suggestion.patch
>
>
> When move an region, it will generate a TRSP first and set the procedure to
> the region state node. But if the submit TRSP failed, the procedure cannot be
> unset now and the region will stuck in RIT.
> hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
> {code:java}
> public Future moveAsync(RegionPlan regionPlan) throws
> HBaseIOException {
> TransitRegionStateProcedure proc =
> createMoveRegionProcedure(regionPlan.getRegionInfo(),
> regionPlan.getDestination());
> return
> ProcedureSyncWait.submitProcedure(master.getMasterProcedureExecutor(), proc);
> }
> public TransitRegionStateProcedure createMoveRegionProcedure(RegionInfo
> regionInfo,
> ServerName targetServer) throws HBaseIOException {
> RegionStateNode regionNode =
> this.regionStates.getRegionStateNode(regionInfo);
> if (regionNode == null) {
> throw new UnknownRegionException("No RegionStateNode found for " +
> regionInfo.getEncodedName() + "(Closed/Deleted?)");
> }
> TransitRegionStateProcedure proc;
> regionNode.lock();
> try {
> preTransitCheck(regionNode, STATES_EXPECTED_ON_UNASSIGN_OR_MOVE);
> regionNode.checkOnline();
> proc = TransitRegionStateProcedure.move(getProcedureEnvironment(),
> regionInfo, targetServer);
> regionNode.setProcedure(proc);
> } finally {
> regionNode.unlock();
> }
> return proc;
> }
> {code}
> hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionStateNode.java
> {code:java}
> public void setProcedure(TransitRegionStateProcedure proc) {
> assert this.procedure == null;
> this.procedure = proc;
> ritMap.put(regionInfo, this);
> }
> public void unsetProcedure(TransitRegionStateProcedure proc) {
> assert this.procedure == proc;
> this.procedure = null;
> ritMap.remove(regionInfo, this);
> }
> {code}
> {code:java}
> 2020-02-26,13:45:21,344 ERROR
> [RpcServer.default.RWQ.Fifo.read.handler=437,queue=5,port=21500]
> org.apache.hadoop.hbase.ipc.RpcServer: Unexpected throwable object
> java.io.UncheckedIOException:
> org.apache.hadoop.hbase.exceptions.TimeoutIOException: Timed out waiting for
> lock for row: \x00\x00\x00\x00\x00\x0B\xAB\xD2 in region
> 9731aea823e7f83264b14713ae486fb7
> at
> org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore.update(RegionProcedureStore.java:588)
> at
> org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore.insert(RegionProcedureStore.java:545)
> at
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.submitProcedure(ProcedureExecutor.java:1042)
> at
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.submitProcedure(ProcedureExecutor.java:860)
> at
> org.apache.hadoop.hbase.master.procedure.ProcedureSyncWait.submitProcedure(ProcedureSyncWait.java:123)
> at
> org.apache.hadoop.hbase.master.assignment.AssignmentManager.moveAsync(AssignmentManager.java:657)
> at
> org.apache.hadoop.hbase.master.HMaster.executeRegionPlansWithThrottling(HMaster.java:1793)
> at org.apache.hadoop.hbase.master.HMaster.balance(HMaster.java:1761)
> at
> org.apache.hadoop.hbase.master.MasterRpcServices.balance(MasterRpcServices.java:654)
> at
> org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:374)
> at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:135)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:352)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:332)
> Caused by: org.apache.hadoop.hbase.exceptions.TimeoutIOException: Timed out
> waiting for lock for row: \x00\x00\x00\x00\x00\x0B\xAB\xD2 in region
> 9731aea823e7f83264b14713ae486fb7
> at
>
[jira] [Commented] (HBASE-23702) `hbase.hstore.flusher.count` setting to 0 breaks HMaster
[
https://issues.apache.org/jira/browse/HBASE-23702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049960#comment-17049960
]
Guanghao Zhang commented on HBASE-23702:
How about at least one handler? int handlerCount = Math.max(1,
conf.getInt("hbase.hstore.flusher.count", 2));
> `hbase.hstore.flusher.count` setting to 0 breaks HMaster
>
>
> Key: HBASE-23702
> URL: https://issues.apache.org/jira/browse/HBASE-23702
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Affects Versions: 2.2.3
> Environment: HBase-2.2.3
> Java openjdk 1.8.0_222
> Ubuntu 18.04
>Reporter: Ctest
>Priority: Major
> Attachments: HBASE-23702-000.patch, HBASE-23702-000.patch,
> HBASE-23702-000.patch, HBASE-23702-000.patch
>
>
> Summary
> The configuration parameter `hbase.hstore.flusher.count` allows `0` (which
> turns out to be a bad value after I understand the source code).
> When we set `hbase.hstore.flusher.count` to 0, HMaster will fail in 200,000
> ms without any error message, but
> ```
> java.lang.RuntimeException: Master not initialized after 20ms
> ```
>
> There’s no messages pinpointing `hbase.hstore.flusher.count` being the root
> cause.
>
> 0 means `MemStoreFlusher` is not alive. During the initialization time of
> HMaster, `isHealthy()` will be called and it will try to check if
> `MemStoreFlusher` is alive or not. However, since we set
> `hbase.hstore.flusher.count` to 0, there will be no flusher created at the
> first place, which cause`isHealthy()` to return false. As a consequence,
> HRegionServer does not enter its main loop.
>
> *How To Reproduce*
>
> The version of HBase: 2.2.3
>
> # Set the value of configuration parameter `hbase.hstore.flusher.count` to
> `0` in “conf/hbase-site.xml”
> # Start hbase by running “bin/start-hbase.sh”
> # Wait for 3-4 minutes
> # Open the log file “logs/hbase-- master -.log”
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] pankaj72981 commented on issue #1223: HBASE-23739 BoundedRecoveredHFilesOutputSink should read the table de…
pankaj72981 commented on issue #1223: HBASE-23739 BoundedRecoveredHFilesOutputSink should read the table de… URL: https://github.com/apache/hbase/pull/1223#issuecomment-593800761 I fixed this issue in my local branch, do you mind reviewing that? @infraio @Apache9 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (HBASE-23784) /hadoop-3.1.3/libexec/hadoop-functions.sh:行2360: HADOOP_ORG.APACHE.HADOOP.HBASE.UTIL.GETJAVAPROPERTY_USER: 错误的替换
[ https://issues.apache.org/jira/browse/HBASE-23784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang resolved HBASE-23784. Resolution: Invalid > /hadoop-3.1.3/libexec/hadoop-functions.sh:行2360: > HADOOP_ORG.APACHE.HADOOP.HBASE.UTIL.GETJAVAPROPERTY_USER: 错误的替换 > > > Key: HBASE-23784 > URL: https://issues.apache.org/jira/browse/HBASE-23784 > Project: HBase > Issue Type: Bug >Affects Versions: 2.2.3 >Reporter: ZHangTianLong >Priority: Major > > /hadoop-3.1.3/libexec/hadoop-functions.sh:行2360: > HADOOP_ORG.APACHE.HADOOP.HBASE.UTIL.GETJAVAPROPERTY_USER: 错误的替换 > /hadoop-3.1.3/libexec/hadoop-functions.sh:行2455: > HADOOP_ORG.APACHE.HADOOP.HBASE.UTIL.GETJAVAPROPERTY_OPTS: 错误的替换 > Hadoop版本3.1.3 > 分布式安装启动报错 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-22146) SpaceQuotaViolationPolicy Disable is not working in Namespace level
[ https://issues.apache.org/jira/browse/HBASE-22146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-22146: --- Fix Version/s: (was: 2.2.4) 2.2.5 > SpaceQuotaViolationPolicy Disable is not working in Namespace level > --- > > Key: HBASE-22146 > URL: https://issues.apache.org/jira/browse/HBASE-22146 > Project: HBase > Issue Type: Bug >Affects Versions: 3.0.0, 2.0.0 >Reporter: Uma Maheswari >Assignee: Shardul Singh >Priority: Major > Labels: Quota, space > Fix For: 3.0.0, 2.0.7, 2.1.10, 2.2.5 > > > SpaceQuotaViolationPolicy Disable is not working in Namespace level > PFB the steps: > * Create Namespace and set Quota violation policy as Disable > * Create tables under namespace and violate Quota > Expected result: Tables to get disabled > Actual Result: Tables are not getting disabled > Note: mutation operation is not allowed on the table -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] pankaj72981 opened a new pull request #1233: HBASE-23633 Find a way to handle the corrupt recovered hfiles
pankaj72981 opened a new pull request #1233: HBASE-23633 Find a way to handle the corrupt recovered hfiles URL: https://github.com/apache/hbase/pull/1233 Check and delete the incomplete/corrupted recovered hfiles whose length is zero. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] infraio commented on a change in pull request #1221: HBASE-23895 STUCK Region-In-Transition when failed to insert procedur…
infraio commented on a change in pull request #1221: HBASE-23895 STUCK
Region-In-Transition when failed to insert procedur…
URL: https://github.com/apache/hbase/pull/1221#discussion_r386824503
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/procedure2/store/region/RegionProcedureStore.java
##
@@ -552,11 +586,12 @@ public void insert(Procedure proc, Procedure[]
subProcs) {
for (Procedure subProc : subProcs) {
serializePut(subProc, mutations, rowsToLock);
}
- region.mutateRowsWithLocks(mutations, rowsToLock, NO_NONCE, NO_NONCE);
+ executeInsert(mutations, rowsToLock);
Review comment:
Let me write a ut to verify this.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (HBASE-23895) STUCK Region-In-Transition when failed to insert procedure to procedure store
[
https://issues.apache.org/jira/browse/HBASE-23895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049944#comment-17049944
]
Guanghao Zhang commented on HBASE-23895:
bq. Suggestion for #1 attached as suggestion.patch.
Then if one new developer need the rpc call. He need to know this history: use
RegionServerServices.getRpcCall instead of RpcServer.getRpcCall. How to avoid
misuse for the furture developer？
> STUCK Region-In-Transition when failed to insert procedure to procedure store
> -
>
> Key: HBASE-23895
> URL: https://issues.apache.org/jira/browse/HBASE-23895
> Project: HBase
> Issue Type: Bug
> Components: proc-v2, RegionProcedureStore
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
> Attachments: suggestion.patch
>
>
> When move an region, it will generate a TRSP first and set the procedure to
> the region state node. But if the submit TRSP failed, the procedure cannot be
> unset now and the region will stuck in RIT.
> hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
> {code:java}
> public Future moveAsync(RegionPlan regionPlan) throws
> HBaseIOException {
> TransitRegionStateProcedure proc =
> createMoveRegionProcedure(regionPlan.getRegionInfo(),
> regionPlan.getDestination());
> return
> ProcedureSyncWait.submitProcedure(master.getMasterProcedureExecutor(), proc);
> }
> public TransitRegionStateProcedure createMoveRegionProcedure(RegionInfo
> regionInfo,
> ServerName targetServer) throws HBaseIOException {
> RegionStateNode regionNode =
> this.regionStates.getRegionStateNode(regionInfo);
> if (regionNode == null) {
> throw new UnknownRegionException("No RegionStateNode found for " +
> regionInfo.getEncodedName() + "(Closed/Deleted?)");
> }
> TransitRegionStateProcedure proc;
> regionNode.lock();
> try {
> preTransitCheck(regionNode, STATES_EXPECTED_ON_UNASSIGN_OR_MOVE);
> regionNode.checkOnline();
> proc = TransitRegionStateProcedure.move(getProcedureEnvironment(),
> regionInfo, targetServer);
> regionNode.setProcedure(proc);
> } finally {
> regionNode.unlock();
> }
> return proc;
> }
> {code}
> hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionStateNode.java
> {code:java}
> public void setProcedure(TransitRegionStateProcedure proc) {
> assert this.procedure == null;
> this.procedure = proc;
> ritMap.put(regionInfo, this);
> }
> public void unsetProcedure(TransitRegionStateProcedure proc) {
> assert this.procedure == proc;
> this.procedure = null;
> ritMap.remove(regionInfo, this);
> }
> {code}
> {code:java}
> 2020-02-26,13:45:21,344 ERROR
> [RpcServer.default.RWQ.Fifo.read.handler=437,queue=5,port=21500]
> org.apache.hadoop.hbase.ipc.RpcServer: Unexpected throwable object
> java.io.UncheckedIOException:
> org.apache.hadoop.hbase.exceptions.TimeoutIOException: Timed out waiting for
> lock for row: \x00\x00\x00\x00\x00\x0B\xAB\xD2 in region
> 9731aea823e7f83264b14713ae486fb7
> at
> org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore.update(RegionProcedureStore.java:588)
> at
> org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore.insert(RegionProcedureStore.java:545)
> at
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.submitProcedure(ProcedureExecutor.java:1042)
> at
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.submitProcedure(ProcedureExecutor.java:860)
> at
> org.apache.hadoop.hbase.master.procedure.ProcedureSyncWait.submitProcedure(ProcedureSyncWait.java:123)
> at
> org.apache.hadoop.hbase.master.assignment.AssignmentManager.moveAsync(AssignmentManager.java:657)
> at
> org.apache.hadoop.hbase.master.HMaster.executeRegionPlansWithThrottling(HMaster.java:1793)
> at org.apache.hadoop.hbase.master.HMaster.balance(HMaster.java:1761)
> at
> org.apache.hadoop.hbase.master.MasterRpcServices.balance(MasterRpcServices.java:654)
> at
> org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:374)
> at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:135)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:352)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:332)
> Caused by: org.apache.hadoop.hbase.exceptions.TimeoutIOException: Timed out
> waiting for lock for row: \x00\x00\x00\x00\x00\x0B\xAB\xD2 in region
>
[jira] [Commented] (HBASE-23895) STUCK Region-In-Transition when failed to insert procedure to procedure store
[
https://issues.apache.org/jira/browse/HBASE-23895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049934#comment-17049934
]
Michael Stack commented on HBASE-23895:
---
Suggestion for #1 attached as suggestion.patch. Its too ugly having to
implement full RegionServerServices.
> STUCK Region-In-Transition when failed to insert procedure to procedure store
> -
>
> Key: HBASE-23895
> URL: https://issues.apache.org/jira/browse/HBASE-23895
> Project: HBase
> Issue Type: Bug
> Components: proc-v2, RegionProcedureStore
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
> Attachments: suggestion.patch
>
>
> When move an region, it will generate a TRSP first and set the procedure to
> the region state node. But if the submit TRSP failed, the procedure cannot be
> unset now and the region will stuck in RIT.
> hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
> {code:java}
> public Future moveAsync(RegionPlan regionPlan) throws
> HBaseIOException {
> TransitRegionStateProcedure proc =
> createMoveRegionProcedure(regionPlan.getRegionInfo(),
> regionPlan.getDestination());
> return
> ProcedureSyncWait.submitProcedure(master.getMasterProcedureExecutor(), proc);
> }
> public TransitRegionStateProcedure createMoveRegionProcedure(RegionInfo
> regionInfo,
> ServerName targetServer) throws HBaseIOException {
> RegionStateNode regionNode =
> this.regionStates.getRegionStateNode(regionInfo);
> if (regionNode == null) {
> throw new UnknownRegionException("No RegionStateNode found for " +
> regionInfo.getEncodedName() + "(Closed/Deleted?)");
> }
> TransitRegionStateProcedure proc;
> regionNode.lock();
> try {
> preTransitCheck(regionNode, STATES_EXPECTED_ON_UNASSIGN_OR_MOVE);
> regionNode.checkOnline();
> proc = TransitRegionStateProcedure.move(getProcedureEnvironment(),
> regionInfo, targetServer);
> regionNode.setProcedure(proc);
> } finally {
> regionNode.unlock();
> }
> return proc;
> }
> {code}
> hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionStateNode.java
> {code:java}
> public void setProcedure(TransitRegionStateProcedure proc) {
> assert this.procedure == null;
> this.procedure = proc;
> ritMap.put(regionInfo, this);
> }
> public void unsetProcedure(TransitRegionStateProcedure proc) {
> assert this.procedure == proc;
> this.procedure = null;
> ritMap.remove(regionInfo, this);
> }
> {code}
> {code:java}
> 2020-02-26,13:45:21,344 ERROR
> [RpcServer.default.RWQ.Fifo.read.handler=437,queue=5,port=21500]
> org.apache.hadoop.hbase.ipc.RpcServer: Unexpected throwable object
> java.io.UncheckedIOException:
> org.apache.hadoop.hbase.exceptions.TimeoutIOException: Timed out waiting for
> lock for row: \x00\x00\x00\x00\x00\x0B\xAB\xD2 in region
> 9731aea823e7f83264b14713ae486fb7
> at
> org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore.update(RegionProcedureStore.java:588)
> at
> org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore.insert(RegionProcedureStore.java:545)
> at
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.submitProcedure(ProcedureExecutor.java:1042)
> at
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.submitProcedure(ProcedureExecutor.java:860)
> at
> org.apache.hadoop.hbase.master.procedure.ProcedureSyncWait.submitProcedure(ProcedureSyncWait.java:123)
> at
> org.apache.hadoop.hbase.master.assignment.AssignmentManager.moveAsync(AssignmentManager.java:657)
> at
> org.apache.hadoop.hbase.master.HMaster.executeRegionPlansWithThrottling(HMaster.java:1793)
> at org.apache.hadoop.hbase.master.HMaster.balance(HMaster.java:1761)
> at
> org.apache.hadoop.hbase.master.MasterRpcServices.balance(MasterRpcServices.java:654)
> at
> org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:374)
> at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:135)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:352)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:332)
> Caused by: org.apache.hadoop.hbase.exceptions.TimeoutIOException: Timed out
> waiting for lock for row: \x00\x00\x00\x00\x00\x0B\xAB\xD2 in region
> 9731aea823e7f83264b14713ae486fb7
> at
> org.apache.hadoop.hbase.regionserver.HRegion.getRowLockInternal(HRegion.java:6158)
>
[jira] [Updated] (HBASE-23895) STUCK Region-In-Transition when failed to insert procedure to procedure store
[
https://issues.apache.org/jira/browse/HBASE-23895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Stack updated HBASE-23895:
--
Attachment: suggestion.patch
> STUCK Region-In-Transition when failed to insert procedure to procedure store
> -
>
> Key: HBASE-23895
> URL: https://issues.apache.org/jira/browse/HBASE-23895
> Project: HBase
> Issue Type: Bug
> Components: proc-v2, RegionProcedureStore
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
> Attachments: suggestion.patch
>
>
> When move an region, it will generate a TRSP first and set the procedure to
> the region state node. But if the submit TRSP failed, the procedure cannot be
> unset now and the region will stuck in RIT.
> hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
> {code:java}
> public Future moveAsync(RegionPlan regionPlan) throws
> HBaseIOException {
> TransitRegionStateProcedure proc =
> createMoveRegionProcedure(regionPlan.getRegionInfo(),
> regionPlan.getDestination());
> return
> ProcedureSyncWait.submitProcedure(master.getMasterProcedureExecutor(), proc);
> }
> public TransitRegionStateProcedure createMoveRegionProcedure(RegionInfo
> regionInfo,
> ServerName targetServer) throws HBaseIOException {
> RegionStateNode regionNode =
> this.regionStates.getRegionStateNode(regionInfo);
> if (regionNode == null) {
> throw new UnknownRegionException("No RegionStateNode found for " +
> regionInfo.getEncodedName() + "(Closed/Deleted?)");
> }
> TransitRegionStateProcedure proc;
> regionNode.lock();
> try {
> preTransitCheck(regionNode, STATES_EXPECTED_ON_UNASSIGN_OR_MOVE);
> regionNode.checkOnline();
> proc = TransitRegionStateProcedure.move(getProcedureEnvironment(),
> regionInfo, targetServer);
> regionNode.setProcedure(proc);
> } finally {
> regionNode.unlock();
> }
> return proc;
> }
> {code}
> hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionStateNode.java
> {code:java}
> public void setProcedure(TransitRegionStateProcedure proc) {
> assert this.procedure == null;
> this.procedure = proc;
> ritMap.put(regionInfo, this);
> }
> public void unsetProcedure(TransitRegionStateProcedure proc) {
> assert this.procedure == proc;
> this.procedure = null;
> ritMap.remove(regionInfo, this);
> }
> {code}
> {code:java}
> 2020-02-26,13:45:21,344 ERROR
> [RpcServer.default.RWQ.Fifo.read.handler=437,queue=5,port=21500]
> org.apache.hadoop.hbase.ipc.RpcServer: Unexpected throwable object
> java.io.UncheckedIOException:
> org.apache.hadoop.hbase.exceptions.TimeoutIOException: Timed out waiting for
> lock for row: \x00\x00\x00\x00\x00\x0B\xAB\xD2 in region
> 9731aea823e7f83264b14713ae486fb7
> at
> org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore.update(RegionProcedureStore.java:588)
> at
> org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore.insert(RegionProcedureStore.java:545)
> at
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.submitProcedure(ProcedureExecutor.java:1042)
> at
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.submitProcedure(ProcedureExecutor.java:860)
> at
> org.apache.hadoop.hbase.master.procedure.ProcedureSyncWait.submitProcedure(ProcedureSyncWait.java:123)
> at
> org.apache.hadoop.hbase.master.assignment.AssignmentManager.moveAsync(AssignmentManager.java:657)
> at
> org.apache.hadoop.hbase.master.HMaster.executeRegionPlansWithThrottling(HMaster.java:1793)
> at org.apache.hadoop.hbase.master.HMaster.balance(HMaster.java:1761)
> at
> org.apache.hadoop.hbase.master.MasterRpcServices.balance(MasterRpcServices.java:654)
> at
> org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:374)
> at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:135)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:352)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:332)
> Caused by: org.apache.hadoop.hbase.exceptions.TimeoutIOException: Timed out
> waiting for lock for row: \x00\x00\x00\x00\x00\x0B\xAB\xD2 in region
> 9731aea823e7f83264b14713ae486fb7
> at
> org.apache.hadoop.hbase.regionserver.HRegion.getRowLockInternal(HRegion.java:6158)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.lockRowsAndBuildMiniBatch(HRegion.java:3488)
>
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit URL: https://github.com/apache/hbase/pull/1183#issuecomment-593787225 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 22s | master passed | | +1 :green_heart: | compile | 3m 51s | master passed | | +1 :green_heart: | shadedjars | 5m 5s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 19s | root in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 11s | the patch passed | | +1 :green_heart: | compile | 3m 53s | the patch passed | | +1 :green_heart: | javac | 3m 53s | the patch passed | | +1 :green_heart: | shadedjars | 5m 3s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 19s | root in the patch failed. | ||| _ Other Tests _ | | -1 :x: | unit | 1m 58s | root in the patch failed. | | | | 35m 3s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/60/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1183 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 4113076af2e0 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / c0301e3fdf | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/60/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/60/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/60/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/60/testReport/ | | Max. process+thread count | 473 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/60/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit URL: https://github.com/apache/hbase/pull/1183#issuecomment-593784431 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 10s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | ||| _ Patch Compile Tests _ | | +1 :green_heart: | hadolint | 0m 1s | The patch generated 0 new + 0 unchanged - 4 fixed = 0 total (was 4) | | +1 :green_heart: | shellcheck | 0m 2s | There were no new shellcheck issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 16m 25s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 19s | The patch does not generate ASF License warnings. | | | | 24m 32s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/60/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1183 | | Optional Tests | dupname asflicense hadolint shellcheck shelldocs hadoopcheck xml | | uname | Linux 07b8571b7e20 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / c0301e3fdf | | Max. process+thread count | 76 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/60/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) shellcheck=0.4.6 hadolint=1.17.5-0-g443423c | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit URL: https://github.com/apache/hbase/pull/1183#issuecomment-593778441 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/60/console in case of problems. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit URL: https://github.com/apache/hbase/pull/1183#issuecomment-593778414 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/60/console in case of problems. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit URL: https://github.com/apache/hbase/pull/1183#issuecomment-593778440 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/60/console in case of problems. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22827) Expose multi-region merge in shell and Admin API
[
https://issues.apache.org/jira/browse/HBASE-22827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049919#comment-17049919
]
Hudson commented on HBASE-22827:
Results for branch branch-2.1
[build #1822 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1822/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1822//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1822//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1822//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Expose multi-region merge in shell and Admin API
>
>
> Key: HBASE-22827
> URL: https://issues.apache.org/jira/browse/HBASE-22827
> Project: HBase
> Issue Type: Improvement
> Components: Admin, shell
>Reporter: Michael Stack
>Assignee: Sakthi
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.4
>
> Attachments: hbase-22827.branch-2.001.patch
>
>
> HBASE-22777 adds being able to merge more than two regions at once. It is
> only available internally currently for use by hbck2 doing fixup of overlaps
> in hbase:meta. This issue is about exposing it via the Admin Interface and in
> turn, via the shell. Probably best if old two region merge method is
> deprecated.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit URL: https://github.com/apache/hbase/pull/1183#issuecomment-593773312 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/59/console in case of problems. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit URL: https://github.com/apache/hbase/pull/1183#issuecomment-593773323 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/59/console in case of problems. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit URL: https://github.com/apache/hbase/pull/1183#issuecomment-593773322 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/59/console in case of problems. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] infraio edited a comment on issue #1225: HBASE-23912 Resolve the TODO of FSTableDescriptor's construct method
infraio edited a comment on issue #1225: HBASE-23912 Resolve the TODO of FSTableDescriptor's construct method URL: https://github.com/apache/hbase/pull/1225#issuecomment-593772504 The failed ut not realted and passed locally. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] infraio commented on issue #1225: HBASE-23912 Resolve the TODO of FSTableDescriptor's construct method
infraio commented on issue #1225: HBASE-23912 Resolve the TODO of FSTableDescriptor's construct method URL: https://github.com/apache/hbase/pull/1225#issuecomment-593772504 The failed ut not realted. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1230: Backport HBASE-23553 to branch-2.1
Apache-HBase commented on issue #1230: Backport HBASE-23553 to branch-2.1 URL: https://github.com/apache/hbase/pull/1230#issuecomment-593767885 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 28s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. | ||| _ branch-2.1 Compile Tests _ | | +1 :green_heart: | mvninstall | 7m 30s | branch-2.1 passed | | +1 :green_heart: | compile | 1m 13s | branch-2.1 passed | | +1 :green_heart: | checkstyle | 1m 41s | branch-2.1 passed | | +1 :green_heart: | shadedjars | 5m 1s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 47s | branch-2.1 passed | | +0 :ok: | spotbugs | 3m 29s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 3m 27s | branch-2.1 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 20s | the patch passed | | +1 :green_heart: | compile | 1m 16s | the patch passed | | +1 :green_heart: | javac | 1m 16s | the patch passed | | +1 :green_heart: | checkstyle | 1m 42s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 5m 7s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 27m 4s | Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2. | | +1 :green_heart: | javadoc | 0m 43s | the patch passed | | +1 :green_heart: | findbugs | 3m 28s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 250m 37s | hbase-server in the patch failed. | | +1 :green_heart: | asflicense | 0m 28s | The patch does not generate ASF License warnings. | | | | 326m 55s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.replication.TestReplicationDisableInactivePeer | | | hadoop.hbase.replication.TestReplicationSmallTests | | | hadoop.hbase.replication.TestReplicationKillSlaveRS | | | hadoop.hbase.replication.TestReplicationKillSlaveRSWithSeparateOldWALs | | | hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint | | | hadoop.hbase.regionserver.TestSplitTransactionOnCluster | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1230/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1230 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 047a8be2e5b1 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1230/out/precommit/personality/provided.sh | | git revision | branch-2.1 / 5b3e59e234 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1230/2/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1230/2/testReport/ | | Max. process+thread count | 4805 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1230/2/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit URL: https://github.com/apache/hbase/pull/1183#issuecomment-593765344 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 37s | master passed | | +1 :green_heart: | compile | 3m 6s | master passed | | +1 :green_heart: | shadedjars | 4m 45s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 48s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 6s | the patch passed | | +1 :green_heart: | compile | 3m 2s | the patch passed | | +1 :green_heart: | javac | 3m 2s | the patch passed | | +1 :green_heart: | shadedjars | 4m 44s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 40s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 69m 42s | root in the patch failed. | | | | 104m 37s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/58/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1183 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux e47c775ee753 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / c0301e3fdf | | Default Java | 1.8.0_232 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/58/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/58/testReport/ | | Max. process+thread count | 8366 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/58/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-23639) Change InterfaceAudience for ClusterManager interface and HBaseClusterManager class public
[ https://issues.apache.org/jira/browse/HBASE-23639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lokesh Khurana updated HBASE-23639: --- Status: Open (was: Patch Available) > Change InterfaceAudience for ClusterManager interface and HBaseClusterManager > class public > --- > > Key: HBASE-23639 > URL: https://issues.apache.org/jira/browse/HBASE-23639 > Project: HBase > Issue Type: Improvement > Components: API, integration tests, test >Affects Versions: master >Reporter: Mihir Monani >Assignee: Lokesh Khurana >Priority: Minor > Attachments: HBASE-23639-master.patch > > > In hbase-it package, Class like RESTApiClusterManager and HBaseClusterManager > which has some part of implementation code for Chaos Action. > > If any user wants to create private implementation which resembles > HBaseClusterManager, then it has to be merged with hbase-it package as > ClusterManager Interface and it's extended implementations are private. > > We should make them public so anyone can have their own implementation and > need to be merged with hbase-it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit URL: https://github.com/apache/hbase/pull/1183#issuecomment-593752996 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m 23s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 7m 31s | master passed | | +1 :green_heart: | compile | 5m 1s | master passed | | +1 :green_heart: | shadedjars | 7m 4s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 26s | root in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 8m 5s | the patch passed | | +1 :green_heart: | compile | 4m 18s | the patch passed | | +1 :green_heart: | javac | 4m 18s | the patch passed | | +1 :green_heart: | shadedjars | 5m 37s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 19s | root in the patch failed. | ||| _ Other Tests _ | | -1 :x: | unit | 2m 0s | root in the patch failed. | | | | 47m 51s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/58/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1183 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux fbc3ef9d9426 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / c0301e3fdf | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/58/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/58/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/58/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/58/testReport/ | | Max. process+thread count | 418 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/58/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit URL: https://github.com/apache/hbase/pull/1183#issuecomment-593747752 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | ||| _ Patch Compile Tests _ | | +1 :green_heart: | hadolint | 0m 1s | The patch generated 0 new + 0 unchanged - 4 fixed = 0 total (was 4) | | +1 :green_heart: | shellcheck | 0m 2s | There were no new shellcheck issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 16m 27s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 18s | The patch does not generate ASF License warnings. | | | | 23m 58s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/58/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1183 | | Optional Tests | dupname asflicense hadolint shellcheck shelldocs hadoopcheck xml | | uname | Linux 9d3703753634 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / c0301e3fdf | | Max. process+thread count | 76 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/58/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) shellcheck=0.4.6 hadolint=1.17.5-0-g443423c | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit URL: https://github.com/apache/hbase/pull/1183#issuecomment-593742362 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/58/console in case of problems. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit URL: https://github.com/apache/hbase/pull/1183#issuecomment-593742257 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/58/console in case of problems. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit URL: https://github.com/apache/hbase/pull/1183#issuecomment-593742254 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/58/console in case of problems. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] chenxu14 commented on a change in pull request #1231: HBASE-23917 [SimpleRpcServer] Subsequent requests will have no response in case of request IO mess up
chenxu14 commented on a change in pull request #1231: HBASE-23917
[SimpleRpcServer] Subsequent requests will have no response in case of request
IO mess up
URL: https://github.com/apache/hbase/pull/1231#discussion_r386774260
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/RequestIOMessUpException.java
##
@@ -0,0 +1,37 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hbase;
+
+import java.io.IOException;
+import org.apache.yetus.audience.InterfaceAudience;
+
+/**
+ * Thrown by a region server if the request IO mess up.
+ */
+@SuppressWarnings("serial")
+@InterfaceAudience.Public
+public class RequestIOMessUpException extends IOException {
Review comment:
rename it to RequestIOCorruptionException
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit URL: https://github.com/apache/hbase/pull/1183#issuecomment-593734072 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 31s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 33s | master passed | | +1 :green_heart: | compile | 3m 7s | master passed | | +1 :green_heart: | shadedjars | 4m 52s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 45s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 7s | the patch passed | | +1 :green_heart: | compile | 3m 2s | the patch passed | | +1 :green_heart: | javac | 3m 2s | the patch passed | | +1 :green_heart: | shadedjars | 4m 51s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 47s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 110m 59s | root in the patch failed. | | | | 147m 36s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/57/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1183 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux f473beb94ada 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / c0301e3fdf | | Default Java | 1.8.0_232 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/57/artifact/out/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/57/testReport/ | | Max. process+thread count | 9906 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/57/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit URL: https://github.com/apache/hbase/pull/1183#issuecomment-593705711 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 30s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 57s | master passed | | +1 :green_heart: | compile | 4m 1s | master passed | | +1 :green_heart: | shadedjars | 5m 27s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 23s | root in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 23s | the patch passed | | +1 :green_heart: | compile | 4m 4s | the patch passed | | +1 :green_heart: | javac | 4m 4s | the patch passed | | +1 :green_heart: | shadedjars | 5m 17s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 19s | root in the patch failed. | ||| _ Other Tests _ | | -1 :x: | unit | 1m 59s | root in the patch failed. | | | | 37m 33s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/57/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1183 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 6a4fdc0799cd 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / c0301e3fdf | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/57/artifact/out/branch-javadoc-root.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/57/artifact/out/patch-javadoc-root.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/57/artifact/out/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/57/testReport/ | | Max. process+thread count | 460 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/57/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] jojochuang commented on a change in pull request #1210: HBASE-23757. [OpenTracing] Migrate from HTrace to OpenTracing (Java code)
jojochuang commented on a change in pull request #1210: HBASE-23757.
[OpenTracing] Migrate from HTrace to OpenTracing (Java code)
URL: https://github.com/apache/hbase/pull/1210#discussion_r386732569
##
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/trace/TraceUtil.java
##
@@ -17,103 +17,169 @@
*/
package org.apache.hadoop.hbase.trace;
+import io.opentracing.Scope;
+import io.opentracing.SpanContext;
+import io.opentracing.mock.MockTracer;
+import io.opentracing.propagation.Format;
+import io.opentracing.propagation.TextMapExtractAdapter;
+import io.opentracing.propagation.TextMapInjectAdapter;
+import io.opentracing.Span;
+import io.opentracing.SpanContext;
+import io.opentracing.Tracer;
+import io.opentracing.propagation.Format;
+import io.opentracing.propagation.TextMapExtractAdapter;
+import io.opentracing.propagation.TextMapInjectAdapter;
+import io.opentracing.util.GlobalTracer;
+import org.apache.commons.codec.binary.Hex;
import org.apache.hadoop.conf.Configuration;
import org.apache.htrace.core.HTraceConfiguration;
import org.apache.htrace.core.Sampler;
-import org.apache.htrace.core.Span;
import org.apache.htrace.core.SpanReceiver;
import org.apache.htrace.core.TraceScope;
-import org.apache.htrace.core.Tracer;
+import io.jaegertracing.Configuration.SamplerConfiguration;
+
+import org.apache.hadoop.tracing.TraceUtils;
+import
org.apache.hbase.thirdparty.com.google.common.annotations.VisibleForTesting;
import org.apache.yetus.audience.InterfaceAudience;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.ByteArrayInputStream;
+import java.io.ByteArrayOutputStream;
+import java.io.IOException;
+import java.io.ObjectInputStream;
+import java.io.ObjectOutputStream;
+import java.util.HashMap;
+import java.util.Map;
/**
* This wrapper class provides functions for accessing htrace 4+ functionality
in a simplified way.
*/
@InterfaceAudience.Private
public final class TraceUtil {
- private static HTraceConfiguration conf;
- private static Tracer tracer;
+ static final Logger LOG = LoggerFactory.getLogger(TraceUtils.class);
+
+ private static io.jaegertracing.Configuration conf;
+ private static io.opentracing.Tracer tracer;
+
+ public static final String HBASE_OPENTRACING_TRACER =
"hbase.opentracing.tracer";
+ public static final String HBASE_OPENTRACING_TRACER_DEFAULT = "jaeger";
+ public static final String HBASE_OPENTRACING_MOCKTRACER = "mock";
private TraceUtil() {
}
- public static void initTracer(Configuration c) {
-if (c != null) {
- conf = new HBaseHTraceConfiguration(c);
+ public static void initTracer(Configuration c, String serviceName) {
+if (GlobalTracer.isRegistered()) {
+ LOG.info("A tracer is already registered.");
+ return;
}
-if (tracer == null && conf != null) {
- tracer = new Tracer.Builder("Tracer").conf(conf).build();
+switch(c.get(HBASE_OPENTRACING_TRACER, HBASE_OPENTRACING_TRACER_DEFAULT)) {
+case HBASE_OPENTRACING_TRACER_DEFAULT:
+ io.jaegertracing.Configuration conf =
io.jaegertracing.Configuration.fromEnv(serviceName);
+ tracer = conf.getTracerBuilder().build();
+ break;
+case HBASE_OPENTRACING_MOCKTRACER:
+ tracer = new MockTracer();
+ break;
+default:
+ throw new RuntimeException("Unexpected tracer");
}
+
+
+GlobalTracer.register(tracer);
Review comment:
Yeah make sense to me. I wanted to use GlobalTracer originally because I
wanted to make coprocessors, like Phoenix to work. But maintaining a global
tracer reference inside HBase should also work (need to use reflection but
that's fine)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit URL: https://github.com/apache/hbase/pull/1183#issuecomment-593702187 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | ||| _ Patch Compile Tests _ | | +1 :green_heart: | hadolint | 0m 3s | The patch generated 0 new + 0 unchanged - 4 fixed = 0 total (was 4) | | +1 :green_heart: | shellcheck | 0m 1s | There were no new shellcheck issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 16m 42s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 17s | The patch does not generate ASF License warnings. | | | | 24m 4s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/57/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1183 | | Optional Tests | dupname asflicense hadolint shellcheck shelldocs hadoopcheck xml | | uname | Linux 1a23e1d91a57 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / c0301e3fdf | | Max. process+thread count | 76 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/57/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) shellcheck=0.4.6 hadolint=1.17.5-0-g443423c | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] joshelser commented on a change in pull request #1230: Backport HBASE-23553 to branch-2.1
joshelser commented on a change in pull request #1230: Backport HBASE-23553 to
branch-2.1
URL: https://github.com/apache/hbase/pull/1230#discussion_r386727193
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestTableSnapshotScanner.java
##
@@ -405,19 +404,23 @@ public void testMergeRegion() throws Exception {
}
});
// set file modify time and then run cleaner
- long time = System.currentTimeMillis() -
TimeToLiveHFileCleaner.DEFAULT_TTL * 1000;
+ long cleanerTtl = conf.getLong("hbase.master.hfilecleaner.ttl",
+ TimeToLiveHFileCleaner.DEFAULT_TTL);
+ long time = System.currentTimeMillis() - cleanerTtl * 1000;
traverseAndSetFileTime(HFileArchiveUtil.getArchivePath(conf), time);
UTIL.getMiniHBaseCluster().getMaster().getHFileCleaner().runCleaner();
// scan snapshot
try (TableSnapshotScanner scanner = new TableSnapshotScanner(conf,
UTIL.getDataTestDirOnTestFS(snapshotName), snapshotName, new
Scan(bbb, yyy))) {
verifyScanner(scanner, bbb, yyy);
+ } catch (IOException e) {
+Assert.assertTrue(e.getCause() != null);
Review comment:
I don't think you need to have this catch for `IOException` nor the outer
catch for `Exception`. If the exception propagates up, it will cause the test
case to fail :)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit URL: https://github.com/apache/hbase/pull/1183#issuecomment-593691238 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/57/console in case of problems. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit URL: https://github.com/apache/hbase/pull/1183#issuecomment-593691235 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/57/console in case of problems. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit URL: https://github.com/apache/hbase/pull/1183#issuecomment-593691239 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/57/console in case of problems. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23876) Add JDK11 compilation and unit test support to nightly job
[
https://issues.apache.org/jira/browse/HBASE-23876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049755#comment-17049755
]
Hudson commented on HBASE-23876:
Results for branch HBASE-23876/jdk11-nightly-master
[build #22 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-23876%252Fjdk11-nightly-master/22/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-23876%252Fjdk11-nightly-master/22//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-23876%252Fjdk11-nightly-master/22//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-23876%252Fjdk11-nightly-master/22//JDK8_Nightly_Build_Report_(Hadoop3)/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-23876%252Fjdk11-nightly-master/22//JDK11_Nightly_Build_Report/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Add JDK11 compilation and unit test support to nightly job
> --
>
> Key: HBASE-23876
> URL: https://issues.apache.org/jira/browse/HBASE-23876
> Project: HBase
> Issue Type: Sub-task
> Components: build
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
>
> We already test against multiple JDK versions in a handful of places. Let's
> get JDK11 added to the mix. Applies to nightly job.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] karthikhw edited a comment on issue #1230: Backport HBASE-23553 to branch-2.1
karthikhw edited a comment on issue #1230: Backport HBASE-23553 to branch-2.1 URL: https://github.com/apache/hbase/pull/1230#issuecomment-593675796 Sorry @joshelser. Its my bad! I simply back-ported theses changes, just only excluding compactionSwitch in the code. I should have done review before committing. Pls review the latest commit. ||Are you sure the test still has coverage for the issue in HBASE-23553? Yes @busbey This test covers HBASE-23553. Usually, we don't need compactionSwitch in this test case, as we know it never triggers compaction since it only loads less data with no manual compaction and only an individual test. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] karthikhw commented on issue #1230: Backport HBASE-23553 to branch-2.1
karthikhw commented on issue #1230: Backport HBASE-23553 to branch-2.1 URL: https://github.com/apache/hbase/pull/1230#issuecomment-593675796 Sorry @joshelser. Its my bad! I simply back-ported theses changes, just only excluding compactionSwitch in the code. I should have done review before committing. Pls review the latest commit. ||Are you sure the test still has coverage for the issue in HBASE-23553? Yes @busbey This test covers HBASE-23553. Usually, we don't need compactionSwitch in this test case, as we know it never triggers compaction since it only loads less data and an individual test. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23881) TestShadeSaslAuthenticationProvider failures
[
https://issues.apache.org/jira/browse/HBASE-23881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049676#comment-17049676
]
Josh Elser commented on HBASE-23881:
Ok, I think I see what the issue is. Seems like this is something unique to the
PLAIN mechanism.
[http://hg.openjdk.java.net/jdk8u/jdk8u/jdk/file/beb15266ba1a/src/share/classes/com/sun/security/sasl/PlainClient.java#l100]
The client creates the response to the challenge from the server, which encodes
the username/password into a challenge, to send it back to the RegionServer.
[https://github.com/apache/hbase/blob/04d789f1a7549f2ae3c25ad4d125601c6b99fdc6/hbase-client/src/main/java/org/apache/hadoop/hbase/security/NettyHBaseSaslRpcClientHandler.java#L114-L117]
Here, we are calling that method (to respond to the initial server challenge),
immediately checking to see if the SaslClient thinks the handshake is complete.
[http://hg.openjdk.java.net/jdk8u/jdk8u/jdk/file/beb15266ba1a/src/share/classes/com/sun/security/sasl/PlainClient.java#l138]
But the PlainClient (implements SaslClient) already thinks the handshake was
successful.
I believe the problem is that the client moves ahead, thinking that the sasl
handshake is done, but the server throws back an error saying "No, this has
failed". This _doesn't_ happen for gssapi/krb5 because there's an extra
challenge/response phase.
> TestShadeSaslAuthenticationProvider failures
>
>
> Key: HBASE-23881
> URL: https://issues.apache.org/jira/browse/HBASE-23881
> Project: HBase
> Issue Type: Bug
> Components: test
>Affects Versions: 3.0.0, 2.3.0
>Reporter: Bharath Vissapragada
>Assignee: Josh Elser
>Priority: Major
>
> TestShadeSaslAuthenticationProvider now fails deterministically with the
> following exception..
> {noformat}
> java.lang.Exception: Unexpected exception,
> expected but
> was
> at
> org.apache.hadoop.hbase.security.provider.example.TestShadeSaslAuthenticationProvider.testNegativeAuthentication(TestShadeSaslAuthenticationProvider.java:233)
> {noformat}
> The test now fails a different place than before merging HBASE-18095 because
> the RPCs are also a part of connection setup. We might need to rewrite the
> test..
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-23919) [Flakey Test] Standalone Zookeeper won't start (minizookeepercluster won't come up)
[
https://issues.apache.org/jira/browse/HBASE-23919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Stack updated HBASE-23919:
--
Component/s: flakies
Description:
I've seen this on occasion across different hardwares; the standalone zookeeper
won't come up and then random unit test fails in its junit startup phase as
part of launching mini cluster.
I've been trying to track this w/ a while now adding in logging, using more of
zk client instead of the copy/paste we've had a long while now, and adding in
logging (I've been running locally w/ zk logging set to INFO).
It looks like this currently where the last thing out of the server launch is
this
{code:java}
2020-03-02 07:57:46,129 INFO [Time-limited test]
server.ZooKeeperServer(854): maxSessionTimeout set to -1
2020-03-02 07:57:46,139 INFO [Time-limited test]
server.NIOServerCnxnFactory(89): binding to port 0.0.0.0/0.0.0.0:49316
2020-03-02 07:57:46,181 INFO [Time-limited test]
zookeeper.MiniZooKeeperCluster(256): Started connectionTimeout=3,
dir=/Users/stack/checkouts/hbase.git/hbase-server/target/test-data/89d57393-fe97-9200-630f-7843ee406bd2/
cluster_6b4d6f67-7978-dc67-a1a3-7b1b0c0e4268/zookeeper_0,
clientPort=49316,
dataDir=/Users/stack/checkouts/hbase.git/hbase-server/target/test-data/89d57393-fe97-9200-630f-7843ee406bd2/cluster_6b4d6f67-7978-dc67-a1a3-7b1b0c0e4268/
zookeeper_0/version-2,
dataLogDir=/Users/stack/checkouts/hbase.git/hbase-server/target/test-data/89d57393-fe97-9200-630f-7843ee406bd2/cluster_6b4d6f67-7978-dc67-a1a3-7b1b0c0e4268/zookeeper_0/version-2,
tickTime=2000, maxClientCnxns=300, minSessionTimeout=4000,
maxSessionTimeout=4, serverId=0{code}
... then the client just does this over and over:
{code:java}
2020-03-02 07:57:46,182 INFO [Time-limited test]
client.FourLetterWordMain(65): connecting to localhost 49316
2020-03-02 07:57:46,213 INFO [Time-limited test]
zookeeper.MiniZooKeeperCluster(453): localhost:49316 not up
java.net.SocketException: Connection reset
at java.net.SocketInputStream.read(SocketInputStream.java:209)
at java.net.SocketInputStream.read(SocketInputStream.java:141)
at
sun.nio.cs.StreamDecoder.readBytes(StreamDecoder.java:284)
at
sun.nio.cs.StreamDecoder.implRead(StreamDecoder.java:326)
at
sun.nio.cs.StreamDecoder.read(StreamDecoder.java:178)
at
java.io.InputStreamReader.read(InputStreamReader.java:184)
at
java.io.BufferedReader.fill(BufferedReader.java:161)
at
java.io.BufferedReader.readLine(BufferedReader.java:324)
at
java.io.BufferedReader.readLine(BufferedReader.java:389)
at
org.apache.zookeeper.client.FourLetterWordMain.send4LetterWord(FourLetterWordMain.java:84)
[jira] [Updated] (HBASE-23919) [Flakey Test] Standalone Zookeeper won't start (minizookeepercluster won't come up)
[ https://issues.apache.org/jira/browse/HBASE-23919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-23919: -- Summary: [Flakey Test] Standalone Zookeeper won't start (minizookeepercluster won't come up) (was: [fla) > [Flakey Test] Standalone Zookeeper won't start (minizookeepercluster won't > come up) > --- > > Key: HBASE-23919 > URL: https://issues.apache.org/jira/browse/HBASE-23919 > Project: HBase > Issue Type: Bug >Reporter: Michael Stack >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-23919) [fla
Michael Stack created HBASE-23919: - Summary: [fla Key: HBASE-23919 URL: https://issues.apache.org/jira/browse/HBASE-23919 Project: HBase Issue Type: Bug Reporter: Michael Stack -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1201: HBASE-23639 : Moving classes out of hbase-it /test for direct API use of chaos.
Apache-HBase commented on issue #1201: HBASE-23639 : Moving classes out of hbase-it /test for direct API use of chaos. URL: https://github.com/apache/hbase/pull/1201#issuecomment-593568714 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 3s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 79 new or modified test files. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 37s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 19s | master passed | | +1 :green_heart: | compile | 0m 53s | master passed | | +1 :green_heart: | checkstyle | 0m 49s | master passed | | +1 :green_heart: | shadedjars | 4m 50s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 38s | master passed | | +0 :ok: | spotbugs | 0m 51s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 0m 50s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 6s | the patch passed | | +1 :green_heart: | compile | 0m 52s | the patch passed | | +1 :green_heart: | javac | 0m 52s | the patch passed | | -1 :x: | checkstyle | 0m 22s | hbase-it: The patch generated 2 new + 129 unchanged - 1 fixed = 131 total (was 130) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. | | +1 :green_heart: | shadedjars | 4m 50s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 16m 35s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | -1 :x: | javadoc | 0m 18s | hbase-it generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 :green_heart: | findbugs | 0m 54s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 6s | hbase-common in the patch passed. | | +1 :green_heart: | unit | 0m 50s | hbase-it in the patch passed. | | +1 :green_heart: | asflicense | 0m 24s | The patch does not generate ASF License warnings. | | | | 53m 44s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1201/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1201 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile xml | | uname | Linux 13a256f2661b 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1201/out/precommit/personality/provided.sh | | git revision | master / c0301e3fdf | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1201/3/artifact/out/diff-checkstyle-hbase-it.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1201/3/artifact/out/diff-javadoc-javadoc-hbase-it.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1201/3/testReport/ | | Max. process+thread count | 609 (vs. ulimit of 1) | | modules | C: hbase-common hbase-it U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1201/3/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] mihir6692 commented on issue #1201: HBASE-23639 : Moving classes out of hbase-it /test for direct API use of chaos.
mihir6692 commented on issue #1201: HBASE-23639 : Moving classes out of hbase-it /test for direct API use of chaos. URL: https://github.com/apache/hbase/pull/1201#issuecomment-593565133 Should we add **HBaseInterfaceAudience.TOOLS** for ChaosMonkeyRunner class? I saw it being used at classes which can be invoked from command lines like PE, HbaseFsck, HFilePerformanceEvaluation etc. @busbey @apurtell This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1221: HBASE-23895 STUCK Region-In-Transition when failed to insert procedur…
saintstack commented on a change in pull request #1221: HBASE-23895 STUCK
Region-In-Transition when failed to insert procedur…
URL: https://github.com/apache/hbase/pull/1221#discussion_r386571087
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/procedure2/store/region/RegionProcedureStore.java
##
@@ -552,11 +586,12 @@ public void insert(Procedure proc, Procedure[]
subProcs) {
for (Procedure subProc : subProcs) {
serializePut(subProc, mutations, rowsToLock);
}
- region.mutateRowsWithLocks(mutations, rowsToLock, NO_NONCE, NO_NONCE);
+ executeInsert(mutations, rowsToLock);
Review comment:
Will this work?
We still might get another's rpc when the RpcServer is called because the
row key clashes?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Updated] (HBASE-23910) Revisit Callable converting all exceptions (including Runtimes) to IOE
[ https://issues.apache.org/jira/browse/HBASE-23910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-23910: -- Description: This came up in the review of HBASE-23904 where in one location, we swapped out the old Callable for a different idiom. The refactor happened to let out RuntimeExceptions rather than wrap them as we've done up to this. Discussion in the issue wondered if this not the proper behavior. This issue is about deciding if it is the case and if so, then the retrofit of the code base to not wrap REs in IOEs. Environment: (was: This came up in the review of HBASE-23904 where in one location, we swapped out the old Callable for a different idiom. The refactor happened to let out RuntimeExceptions rather than wrap them as we've done up to this. Discussion in the issue wondered if this not the proper behavior. This issue is about deciding if it is the case and if so, then the retrofit of the code base to not wrap REs in IOEs.) > Revisit Callable converting all exceptions (including Runtimes) to IOE > -- > > Key: HBASE-23910 > URL: https://issues.apache.org/jira/browse/HBASE-23910 > Project: HBase > Issue Type: Improvement >Reporter: Michael Stack >Priority: Major > > This came up in the review of HBASE-23904 where in one location, we swapped > out the old Callable for a different idiom. The refactor happened to let out > RuntimeExceptions rather than wrap them as we've done up to this. Discussion > in the issue wondered if this not the proper behavior. This issue is about > deciding if it is the case and if so, then the retrofit of the code base to > not wrap REs in IOEs. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23918) Track sensitive resources to ensure they are closed and assist devs in finding leaks.
[ https://issues.apache.org/jira/browse/HBASE-23918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049513#comment-17049513 ] Michael Stack commented on HBASE-23918: --- I like the word 'growy'. We have ResourceChecker. It tracks a few resource counts like threads and file descriptors. It'll thread dump if hangers-on. Does this effort relate? Can they be tied? Or is it strictly object tracking? > Track sensitive resources to ensure they are closed and assist devs in > finding leaks. > - > > Key: HBASE-23918 > URL: https://issues.apache.org/jira/browse/HBASE-23918 > Project: HBase > Issue Type: Improvement >Reporter: Mark Robert Miller >Priority: Major > > Closing some objects is quite critical. Issues with leaks can be quite > slippery and nasty and growy. Maintaining close integrity is an embarrassing > sport for humans. > In the past, those 3 thoughts led me to start tracking objects in tests to > alert of leaks. Even with an alert though, the job of tracking down all of > the leaks just based on what leaked was beyond my skill. If it's beyond even > one devs skill that is committing, that tends to end up trouble. So I added > the stack trace for the origin of the object. Things can still get a bit > tricky to track down in some cases, but now I had the start of a real > solution to all of the whack-a-mole games I spent too much time playing. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23639) Change InterfaceAudience for ClusterManager interface and HBaseClusterManager class public
[ https://issues.apache.org/jira/browse/HBASE-23639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049454#comment-17049454 ] Andrew Kyle Purtell commented on HBASE-23639: - bq. We can address our classes IA.LimitedPrivate and IS.Evolving with having a HIA.CHAOS for the project. bq. Also as specified in doc we were thinking of adding a new config property for MonkeyFactory Class, but that can be done with having an annotation of IA.LimitedPrivate. +1 from me. Also as I suggested on the design doc, seems fine to make a src/ directory in hbase-it and place the new LimitedPrivate annotated interfaces there. Not sure there is much utility in adding another maven module when these classes are going to be intimate with other aspects of hbase-it . > Change InterfaceAudience for ClusterManager interface and HBaseClusterManager > class public > --- > > Key: HBASE-23639 > URL: https://issues.apache.org/jira/browse/HBASE-23639 > Project: HBase > Issue Type: Improvement > Components: API, integration tests, test >Affects Versions: master >Reporter: Mihir Monani >Assignee: Lokesh Khurana >Priority: Minor > Attachments: HBASE-23639-master.patch > > > In hbase-it package, Class like RESTApiClusterManager and HBaseClusterManager > which has some part of implementation code for Chaos Action. > > If any user wants to create private implementation which resembles > HBaseClusterManager, then it has to be merged with hbase-it package as > ClusterManager Interface and it's extended implementations are private. > > We should make them public so anyone can have their own implementation and > need to be merged with hbase-it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] busbey commented on issue #1230: Backport HBASE-23553 to branch-2.1
busbey commented on issue #1230: Backport HBASE-23553 to branch-2.1 URL: https://github.com/apache/hbase/pull/1230#issuecomment-593499978 note for committers if I'm not the one who pushes this, the following commit message should be used: ``` HBASE-23553 Snapshot referenced data files are deleted in some case Backport to branch-2.1 via HBASE-23915 by Karthik P. Differs from original by skipping test-only need for the "turn compaction on/off" feature. Closes #1230 Co-authored-by: Karthik Palanisamy ``` Karthik I used the email address associated with your github account above. let us know if you'd prefer a different one. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] joshelser commented on a change in pull request #1230: Backport HBASE-23553 to branch-2.1
joshelser commented on a change in pull request #1230: Backport HBASE-23553 to
branch-2.1
URL: https://github.com/apache/hbase/pull/1230#discussion_r386504245
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestTableSnapshotScanner.java
##
@@ -303,4 +312,131 @@ private static void verifyRow(Result result) throws
IOException {
}
}
+ @Test
+ public void testMergeRegion() throws Exception {
+setupCluster();
+TableName tableName = TableName.valueOf("testMergeRegion");
+String snapshotName = tableName.getNameAsString() + "_snapshot";
+Configuration conf = UTIL.getConfiguration();
+Path rootDir =
UTIL.getHBaseCluster().getMaster().getMasterFileSystem().getRootDir();
+long timeout = 2; // 20s
+try (Admin admin = UTIL.getAdmin()) {
+ List serverList = admin.getRegionServers().stream().map(sn ->
sn.getServerName())
+ .collect(Collectors.toList());
+ // create table with 3 regions
+ Table table = UTIL.createTable(tableName, FAMILIES, 1, bbb, yyy, 3);
+ List regions = admin.getRegions(tableName);
+ Assert.assertEquals(3, regions.size());
+ RegionInfo region0 = regions.get(0);
+ RegionInfo region1 = regions.get(1);
+ RegionInfo region2 = regions.get(2);
+ // put some data in the table
+ UTIL.loadTable(table, FAMILIES);
+ admin.flush(tableName);
+ // wait flush is finished
+ UTIL.waitFor(timeout, () -> {
+try {
+ Path tableDir = FSUtils.getTableDir(rootDir, tableName);
+ for (RegionInfo region : regions) {
+Path regionDir = new Path(tableDir, region.getEncodedName());
+for (Path familyDir : FSUtils.getFamilyDirs(fs, regionDir)) {
+ if (fs.listStatus(familyDir).length != 1) {
+return false;
+ }
+}
+ }
+ return true;
+} catch (IOException e) {
+ LOG.warn("Failed check if flush is finished", e);
+ return false;
+}
+ });
+ // merge 2 regions
+ admin.mergeRegionsAsync(region0.getEncodedNameAsBytes(),
region1.getEncodedNameAsBytes(),
+true);
+ UTIL.waitFor(timeout, () -> admin.getRegions(tableName).size() == 2);
+ List mergedRegions = admin.getRegions(tableName);
+ RegionInfo mergedRegion =
+
mergedRegions.get(0).getEncodedName().equals(region2.getEncodedName())
+ ? mergedRegions.get(1)
+ : mergedRegions.get(0);
+ // snapshot
+ admin.snapshot(snapshotName, tableName);
+ Assert.assertEquals(1, admin.listSnapshots().size());
+ // major compact
+ admin.majorCompactRegion(mergedRegion.getRegionName());
+ // wait until merged region has no reference
+ UTIL.waitFor(timeout, () -> {
+try {
+ for (RegionServerThread regionServerThread :
UTIL.getMiniHBaseCluster()
+ .getRegionServerThreads()) {
+HRegionServer regionServer = regionServerThread.getRegionServer();
+for (HRegion subRegion : regionServer.getRegions(tableName)) {
+ if (subRegion.getRegionInfo().getEncodedName()
+ .equals(mergedRegion.getEncodedName())) {
+regionServer.getCompactedHFilesDischarger().chore();
+ }
+}
+ }
+ Path tableDir = FSUtils.getTableDir(rootDir, tableName);
+ HRegionFileSystem regionFs = HRegionFileSystem
+ .openRegionFromFileSystem(UTIL.getConfiguration(), fs, tableDir,
mergedRegion, true);
+ return !regionFs.hasReferences(admin.getDescriptor(tableName));
+} catch (IOException e) {
+ LOG.warn("Failed check merged region has no reference", e);
+ return false;
+}
+ });
+ // run catalog janitor to clean and wait for parent regions are archived
+
UTIL.getMiniHBaseCluster().getMaster().getCatalogJanitor().choreForTesting();
+ UTIL.waitFor(timeout, () -> {
+try {
+ Path tableDir = FSUtils.getTableDir(rootDir, tableName);
+ for (FileStatus fileStatus : fs.listStatus(tableDir)) {
+String name = fileStatus.getPath().getName();
+if (name.equals(region0.getEncodedName()) ||
name.equals(region1.getEncodedName())) {
+ return false;
+}
+ }
+ return true;
+} catch (IOException e) {
+ LOG.warn("Check if parent regions are archived error", e);
+ return false;
+}
+ });
+ // set file modify time and then run cleaner
+ long time = System.currentTimeMillis() -
TimeToLiveHFileCleaner.DEFAULT_TTL * 1000;
+ traverseAndSetFileTime(HFileArchiveUtil.getArchivePath(conf), time);
+ UTIL.getMiniHBaseCluster().getMaster().getHFileCleaner().runCleaner();
+ // scan snapshot
+ try (TableSnapshotScanner scanner = new TableSnapshotScanner(conf,
+
[GitHub] [hbase] joshelser commented on a change in pull request #1230: Backport HBASE-23553 to branch-2.1
joshelser commented on a change in pull request #1230: Backport HBASE-23553 to
branch-2.1
URL: https://github.com/apache/hbase/pull/1230#discussion_r386504683
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestTableSnapshotScanner.java
##
@@ -303,4 +312,131 @@ private static void verifyRow(Result result) throws
IOException {
}
}
+ @Test
+ public void testMergeRegion() throws Exception {
+setupCluster();
+TableName tableName = TableName.valueOf("testMergeRegion");
+String snapshotName = tableName.getNameAsString() + "_snapshot";
+Configuration conf = UTIL.getConfiguration();
+Path rootDir =
UTIL.getHBaseCluster().getMaster().getMasterFileSystem().getRootDir();
+long timeout = 2; // 20s
+try (Admin admin = UTIL.getAdmin()) {
+ List serverList = admin.getRegionServers().stream().map(sn ->
sn.getServerName())
+ .collect(Collectors.toList());
+ // create table with 3 regions
+ Table table = UTIL.createTable(tableName, FAMILIES, 1, bbb, yyy, 3);
+ List regions = admin.getRegions(tableName);
+ Assert.assertEquals(3, regions.size());
+ RegionInfo region0 = regions.get(0);
+ RegionInfo region1 = regions.get(1);
+ RegionInfo region2 = regions.get(2);
+ // put some data in the table
+ UTIL.loadTable(table, FAMILIES);
+ admin.flush(tableName);
+ // wait flush is finished
+ UTIL.waitFor(timeout, () -> {
+try {
+ Path tableDir = FSUtils.getTableDir(rootDir, tableName);
+ for (RegionInfo region : regions) {
+Path regionDir = new Path(tableDir, region.getEncodedName());
+for (Path familyDir : FSUtils.getFamilyDirs(fs, regionDir)) {
+ if (fs.listStatus(familyDir).length != 1) {
+return false;
+ }
+}
+ }
+ return true;
+} catch (IOException e) {
+ LOG.warn("Failed check if flush is finished", e);
+ return false;
+}
+ });
+ // merge 2 regions
+ admin.mergeRegionsAsync(region0.getEncodedNameAsBytes(),
region1.getEncodedNameAsBytes(),
+true);
+ UTIL.waitFor(timeout, () -> admin.getRegions(tableName).size() == 2);
+ List mergedRegions = admin.getRegions(tableName);
+ RegionInfo mergedRegion =
+
mergedRegions.get(0).getEncodedName().equals(region2.getEncodedName())
+ ? mergedRegions.get(1)
+ : mergedRegions.get(0);
+ // snapshot
+ admin.snapshot(snapshotName, tableName);
+ Assert.assertEquals(1, admin.listSnapshots().size());
+ // major compact
+ admin.majorCompactRegion(mergedRegion.getRegionName());
+ // wait until merged region has no reference
+ UTIL.waitFor(timeout, () -> {
+try {
+ for (RegionServerThread regionServerThread :
UTIL.getMiniHBaseCluster()
+ .getRegionServerThreads()) {
+HRegionServer regionServer = regionServerThread.getRegionServer();
+for (HRegion subRegion : regionServer.getRegions(tableName)) {
+ if (subRegion.getRegionInfo().getEncodedName()
+ .equals(mergedRegion.getEncodedName())) {
+regionServer.getCompactedHFilesDischarger().chore();
+ }
+}
+ }
+ Path tableDir = FSUtils.getTableDir(rootDir, tableName);
+ HRegionFileSystem regionFs = HRegionFileSystem
+ .openRegionFromFileSystem(UTIL.getConfiguration(), fs, tableDir,
mergedRegion, true);
+ return !regionFs.hasReferences(admin.getDescriptor(tableName));
+} catch (IOException e) {
+ LOG.warn("Failed check merged region has no reference", e);
+ return false;
+}
+ });
+ // run catalog janitor to clean and wait for parent regions are archived
+
UTIL.getMiniHBaseCluster().getMaster().getCatalogJanitor().choreForTesting();
+ UTIL.waitFor(timeout, () -> {
+try {
+ Path tableDir = FSUtils.getTableDir(rootDir, tableName);
+ for (FileStatus fileStatus : fs.listStatus(tableDir)) {
+String name = fileStatus.getPath().getName();
+if (name.equals(region0.getEncodedName()) ||
name.equals(region1.getEncodedName())) {
+ return false;
+}
+ }
+ return true;
+} catch (IOException e) {
+ LOG.warn("Check if parent regions are archived error", e);
+ return false;
+}
+ });
+ // set file modify time and then run cleaner
+ long time = System.currentTimeMillis() -
TimeToLiveHFileCleaner.DEFAULT_TTL * 1000;
+ traverseAndSetFileTime(HFileArchiveUtil.getArchivePath(conf), time);
+ UTIL.getMiniHBaseCluster().getMaster().getHFileCleaner().runCleaner();
+ // scan snapshot
+ try (TableSnapshotScanner scanner = new TableSnapshotScanner(conf,
+
[GitHub] [hbase] joshelser commented on a change in pull request #1230: Backport HBASE-23553 to branch-2.1
joshelser commented on a change in pull request #1230: Backport HBASE-23553 to
branch-2.1
URL: https://github.com/apache/hbase/pull/1230#discussion_r386503431
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestTableSnapshotScanner.java
##
@@ -303,4 +312,131 @@ private static void verifyRow(Result result) throws
IOException {
}
}
+ @Test
+ public void testMergeRegion() throws Exception {
+setupCluster();
+TableName tableName = TableName.valueOf("testMergeRegion");
+String snapshotName = tableName.getNameAsString() + "_snapshot";
+Configuration conf = UTIL.getConfiguration();
+Path rootDir =
UTIL.getHBaseCluster().getMaster().getMasterFileSystem().getRootDir();
+long timeout = 2; // 20s
+try (Admin admin = UTIL.getAdmin()) {
+ List serverList = admin.getRegionServers().stream().map(sn ->
sn.getServerName())
+ .collect(Collectors.toList());
+ // create table with 3 regions
+ Table table = UTIL.createTable(tableName, FAMILIES, 1, bbb, yyy, 3);
+ List regions = admin.getRegions(tableName);
+ Assert.assertEquals(3, regions.size());
+ RegionInfo region0 = regions.get(0);
+ RegionInfo region1 = regions.get(1);
+ RegionInfo region2 = regions.get(2);
+ // put some data in the table
+ UTIL.loadTable(table, FAMILIES);
+ admin.flush(tableName);
+ // wait flush is finished
+ UTIL.waitFor(timeout, () -> {
+try {
+ Path tableDir = FSUtils.getTableDir(rootDir, tableName);
+ for (RegionInfo region : regions) {
+Path regionDir = new Path(tableDir, region.getEncodedName());
+for (Path familyDir : FSUtils.getFamilyDirs(fs, regionDir)) {
+ if (fs.listStatus(familyDir).length != 1) {
+return false;
+ }
+}
+ }
+ return true;
+} catch (IOException e) {
+ LOG.warn("Failed check if flush is finished", e);
+ return false;
+}
+ });
+ // merge 2 regions
+ admin.mergeRegionsAsync(region0.getEncodedNameAsBytes(),
region1.getEncodedNameAsBytes(),
+true);
+ UTIL.waitFor(timeout, () -> admin.getRegions(tableName).size() == 2);
+ List mergedRegions = admin.getRegions(tableName);
+ RegionInfo mergedRegion =
+
mergedRegions.get(0).getEncodedName().equals(region2.getEncodedName())
+ ? mergedRegions.get(1)
+ : mergedRegions.get(0);
+ // snapshot
+ admin.snapshot(snapshotName, tableName);
+ Assert.assertEquals(1, admin.listSnapshots().size());
+ // major compact
+ admin.majorCompactRegion(mergedRegion.getRegionName());
+ // wait until merged region has no reference
+ UTIL.waitFor(timeout, () -> {
+try {
+ for (RegionServerThread regionServerThread :
UTIL.getMiniHBaseCluster()
+ .getRegionServerThreads()) {
+HRegionServer regionServer = regionServerThread.getRegionServer();
+for (HRegion subRegion : regionServer.getRegions(tableName)) {
+ if (subRegion.getRegionInfo().getEncodedName()
+ .equals(mergedRegion.getEncodedName())) {
+regionServer.getCompactedHFilesDischarger().chore();
+ }
+}
+ }
+ Path tableDir = FSUtils.getTableDir(rootDir, tableName);
+ HRegionFileSystem regionFs = HRegionFileSystem
+ .openRegionFromFileSystem(UTIL.getConfiguration(), fs, tableDir,
mergedRegion, true);
+ return !regionFs.hasReferences(admin.getDescriptor(tableName));
+} catch (IOException e) {
+ LOG.warn("Failed check merged region has no reference", e);
+ return false;
+}
+ });
+ // run catalog janitor to clean and wait for parent regions are archived
+
UTIL.getMiniHBaseCluster().getMaster().getCatalogJanitor().choreForTesting();
+ UTIL.waitFor(timeout, () -> {
+try {
+ Path tableDir = FSUtils.getTableDir(rootDir, tableName);
+ for (FileStatus fileStatus : fs.listStatus(tableDir)) {
+String name = fileStatus.getPath().getName();
+if (name.equals(region0.getEncodedName()) ||
name.equals(region1.getEncodedName())) {
+ return false;
+}
+ }
+ return true;
+} catch (IOException e) {
+ LOG.warn("Check if parent regions are archived error", e);
+ return false;
+}
+ });
+ // set file modify time and then run cleaner
+ long time = System.currentTimeMillis() -
TimeToLiveHFileCleaner.DEFAULT_TTL * 1000;
Review comment:
Can we pull the actual TTL out of the configuration instead of relying on
this default ttl variable?
This is an automated message from the Apache Git Service.
To respond to the message,
[GitHub] [hbase] joshelser commented on a change in pull request #1230: Backport HBASE-23553 to branch-2.1
joshelser commented on a change in pull request #1230: Backport HBASE-23553 to
branch-2.1
URL: https://github.com/apache/hbase/pull/1230#discussion_r386502643
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestTableSnapshotScanner.java
##
@@ -303,4 +312,131 @@ private static void verifyRow(Result result) throws
IOException {
}
}
+ @Test
+ public void testMergeRegion() throws Exception {
+setupCluster();
+TableName tableName = TableName.valueOf("testMergeRegion");
+String snapshotName = tableName.getNameAsString() + "_snapshot";
+Configuration conf = UTIL.getConfiguration();
+Path rootDir =
UTIL.getHBaseCluster().getMaster().getMasterFileSystem().getRootDir();
+long timeout = 2; // 20s
+try (Admin admin = UTIL.getAdmin()) {
+ List serverList = admin.getRegionServers().stream().map(sn ->
sn.getServerName())
+ .collect(Collectors.toList());
+ // create table with 3 regions
+ Table table = UTIL.createTable(tableName, FAMILIES, 1, bbb, yyy, 3);
+ List regions = admin.getRegions(tableName);
+ Assert.assertEquals(3, regions.size());
+ RegionInfo region0 = regions.get(0);
+ RegionInfo region1 = regions.get(1);
+ RegionInfo region2 = regions.get(2);
+ // put some data in the table
+ UTIL.loadTable(table, FAMILIES);
+ admin.flush(tableName);
+ // wait flush is finished
+ UTIL.waitFor(timeout, () -> {
+try {
+ Path tableDir = FSUtils.getTableDir(rootDir, tableName);
+ for (RegionInfo region : regions) {
+Path regionDir = new Path(tableDir, region.getEncodedName());
+for (Path familyDir : FSUtils.getFamilyDirs(fs, regionDir)) {
+ if (fs.listStatus(familyDir).length != 1) {
+return false;
+ }
+}
+ }
+ return true;
+} catch (IOException e) {
+ LOG.warn("Failed check if flush is finished", e);
+ return false;
+}
+ });
+ // merge 2 regions
+ admin.mergeRegionsAsync(region0.getEncodedNameAsBytes(),
region1.getEncodedNameAsBytes(),
+true);
+ UTIL.waitFor(timeout, () -> admin.getRegions(tableName).size() == 2);
+ List mergedRegions = admin.getRegions(tableName);
+ RegionInfo mergedRegion =
+
mergedRegions.get(0).getEncodedName().equals(region2.getEncodedName())
+ ? mergedRegions.get(1)
+ : mergedRegions.get(0);
+ // snapshot
+ admin.snapshot(snapshotName, tableName);
+ Assert.assertEquals(1, admin.listSnapshots().size());
+ // major compact
+ admin.majorCompactRegion(mergedRegion.getRegionName());
+ // wait until merged region has no reference
+ UTIL.waitFor(timeout, () -> {
+try {
+ for (RegionServerThread regionServerThread :
UTIL.getMiniHBaseCluster()
+ .getRegionServerThreads()) {
+HRegionServer regionServer = regionServerThread.getRegionServer();
+for (HRegion subRegion : regionServer.getRegions(tableName)) {
+ if (subRegion.getRegionInfo().getEncodedName()
+ .equals(mergedRegion.getEncodedName())) {
+regionServer.getCompactedHFilesDischarger().chore();
+ }
+}
+ }
+ Path tableDir = FSUtils.getTableDir(rootDir, tableName);
+ HRegionFileSystem regionFs = HRegionFileSystem
+ .openRegionFromFileSystem(UTIL.getConfiguration(), fs, tableDir,
mergedRegion, true);
+ return !regionFs.hasReferences(admin.getDescriptor(tableName));
+} catch (IOException e) {
+ LOG.warn("Failed check merged region has no reference", e);
+ return false;
+}
+ });
+ // run catalog janitor to clean and wait for parent regions are archived
Review comment:
Nit: IIRC, we call the input to a merge the "daughters" of a merge which
come together to make one "parent". It's like split (e.g one parent, two
daughters), but in reverse.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] joshelser commented on a change in pull request #1230: Backport HBASE-23553 to branch-2.1
joshelser commented on a change in pull request #1230: Backport HBASE-23553 to
branch-2.1
URL: https://github.com/apache/hbase/pull/1230#discussion_r386496544
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestTableSnapshotScanner.java
##
@@ -303,4 +312,131 @@ private static void verifyRow(Result result) throws
IOException {
}
}
+ @Test
+ public void testMergeRegion() throws Exception {
+setupCluster();
+TableName tableName = TableName.valueOf("testMergeRegion");
+String snapshotName = tableName.getNameAsString() + "_snapshot";
+Configuration conf = UTIL.getConfiguration();
+Path rootDir =
UTIL.getHBaseCluster().getMaster().getMasterFileSystem().getRootDir();
+long timeout = 2; // 20s
+try (Admin admin = UTIL.getAdmin()) {
+ List serverList = admin.getRegionServers().stream().map(sn ->
sn.getServerName())
Review comment:
Unused
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (HBASE-23639) Change InterfaceAudience for ClusterManager interface and HBaseClusterManager class public
[ https://issues.apache.org/jira/browse/HBASE-23639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049236#comment-17049236 ] Sean Busbey commented on HBASE-23639: - bq. We can address our classes IA.LimitedPrivate and IS.Evolving with having a HIA.CHAOS for the project. Updating things to be IA.LimitedPrivate sounds good to me. I personally don't find the InterfaceStability annotation helpful, but if you want the extra flexibility of marking things IS.Evolving then I'd be comfortable with that for a few releases. > Change InterfaceAudience for ClusterManager interface and HBaseClusterManager > class public > --- > > Key: HBASE-23639 > URL: https://issues.apache.org/jira/browse/HBASE-23639 > Project: HBase > Issue Type: Improvement > Components: API, integration tests, test >Affects Versions: master >Reporter: Mihir Monani >Assignee: Lokesh Khurana >Priority: Minor > Attachments: HBASE-23639-master.patch > > > In hbase-it package, Class like RESTApiClusterManager and HBaseClusterManager > which has some part of implementation code for Chaos Action. > > If any user wants to create private implementation which resembles > HBaseClusterManager, then it has to be merged with hbase-it package as > ClusterManager Interface and it's extended implementations are private. > > We should make them public so anyone can have their own implementation and > need to be merged with hbase-it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23639) Change InterfaceAudience for ClusterManager interface and HBaseClusterManager class public
[ https://issues.apache.org/jira/browse/HBASE-23639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049186#comment-17049186 ] Lokesh Khurana commented on HBASE-23639: [~apurtell] Can you please take a look and see if this can be a right way to move forward.? > Change InterfaceAudience for ClusterManager interface and HBaseClusterManager > class public > --- > > Key: HBASE-23639 > URL: https://issues.apache.org/jira/browse/HBASE-23639 > Project: HBase > Issue Type: Improvement > Components: API, integration tests, test >Affects Versions: master >Reporter: Mihir Monani >Assignee: Lokesh Khurana >Priority: Minor > Attachments: HBASE-23639-master.patch > > > In hbase-it package, Class like RESTApiClusterManager and HBaseClusterManager > which has some part of implementation code for Chaos Action. > > If any user wants to create private implementation which resembles > HBaseClusterManager, then it has to be merged with hbase-it package as > ClusterManager Interface and it's extended implementations are private. > > We should make them public so anyone can have their own implementation and > need to be merged with hbase-it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1219: HBASE-23788 ROW_INDEX_V1 encoder should consider the secondary index size with the encoded data size tracking
Apache-HBase commented on issue #1219: HBASE-23788 ROW_INDEX_V1 encoder should consider the secondary index size with the encoded data size tracking URL: https://github.com/apache/hbase/pull/1219#issuecomment-593378247 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 35s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 35s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 47s | master passed | | +1 :green_heart: | compile | 1m 21s | master passed | | +1 :green_heart: | checkstyle | 1m 38s | master passed | | +1 :green_heart: | shadedjars | 5m 9s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 57s | master passed | | +0 :ok: | spotbugs | 5m 37s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 6m 26s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 28s | the patch passed | | +1 :green_heart: | compile | 1m 22s | the patch passed | | +1 :green_heart: | javac | 1m 22s | the patch passed | | +1 :green_heart: | checkstyle | 0m 23s | The patch passed checkstyle in hbase-common | | +1 :green_heart: | checkstyle | 1m 14s | hbase-server: The patch generated 0 new + 15 unchanged - 1 fixed = 15 total (was 16) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 5m 9s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 17m 15s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | javadoc | 0m 56s | the patch passed | | +1 :green_heart: | findbugs | 6m 38s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 13s | hbase-common in the patch passed. | | -1 :x: | unit | 85m 16s | hbase-server in the patch failed. | | +1 :green_heart: | asflicense | 1m 7s | The patch does not generate ASF License warnings. | | | | 157m 51s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestAsyncTableAdminApi | | | hadoop.hbase.client.TestAvoidCellReferencesIntoShippedBlocks | | | hadoop.hbase.client.TestAsyncClusterAdminApi2 | | | hadoop.hbase.client.TestAsyncNonMetaRegionLocatorConcurrenyLimit | | | hadoop.hbase.client.TestScannersFromClientSide2 | | | hadoop.hbase.client.TestMobCloneSnapshotFromClientError | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1219/4/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1219 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux d607b781dab4 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1219/out/precommit/personality/provided.sh | | git revision | master / c21b28fc5c | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1219/4/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1219/4/testReport/ | | Max. process+thread count | 5840 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1219/4/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please
[jira] [Updated] (HBASE-23868) Replace usages of HColumnDescriptor(byte [] familyName) with builder pattern
[ https://issues.apache.org/jira/browse/HBASE-23868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-23868: - Fix Version/s: 3.0.0 Resolution: Fixed Status: Resolved (was: Patch Available) > Replace usages of HColumnDescriptor(byte [] familyName) with builder pattern > > > Key: HBASE-23868 > URL: https://issues.apache.org/jira/browse/HBASE-23868 > Project: HBase > Issue Type: Improvement >Affects Versions: 3.0.0 >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Major > Fix For: 3.0.0 > > > Replace HColumnDescriptor(byte [] familyName) with > ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor as we need to > remove HColumnDescriptor(byte [] familyName) from 3.0. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23253) Rewrite rsgroup related UTs with the new methods introduced in HBASE-22932
[
https://issues.apache.org/jira/browse/HBASE-23253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049142#comment-17049142
]
Hudson commented on HBASE-23253:
Results for branch master
[build #1649 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1649/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Rewrite rsgroup related UTs with the new methods introduced in HBASE-22932
> --
>
> Key: HBASE-23253
> URL: https://issues.apache.org/jira/browse/HBASE-23253
> Project: HBase
> Issue Type: Sub-task
> Components: test
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-22820) Do not need to persist default rs group now
[
https://issues.apache.org/jira/browse/HBASE-22820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049131#comment-17049131
]
Hudson commented on HBASE-22820:
Results for branch master
[build #1649 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1649/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Do not need to persist default rs group now
> ---
>
> Key: HBASE-22820
> URL: https://issues.apache.org/jira/browse/HBASE-22820
> Project: HBase
> Issue Type: Sub-task
>Reporter: Duo Zhang
>Assignee: Xiaolin Ha
>Priority: Major
> Fix For: 3.0.0
>
>
> As now the rs group info for a table is stored in the table metadata, we only
> need to store the servers of a rs group to the rs group table, so we do not
> need to store the default rs group anymore. The servers in default group will
> be refreshed automatically.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23807) Make rsgroup related shell command to use the new admin methods
[
https://issues.apache.org/jira/browse/HBASE-23807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049145#comment-17049145
]
Hudson commented on HBASE-23807:
Results for branch master
[build #1649 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1649/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Make rsgroup related shell command to use the new admin methods
> ---
>
> Key: HBASE-23807
> URL: https://issues.apache.org/jira/browse/HBASE-23807
> Project: HBase
> Issue Type: Sub-task
> Components: Admin, rsgroup, shell
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] virajjasani merged pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
virajjasani merged pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)… URL: https://github.com/apache/hbase/pull/1222 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22932) Add rs group management methods in Admin and AsyncAdmin
[
https://issues.apache.org/jira/browse/HBASE-22932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049140#comment-17049140
]
Hudson commented on HBASE-22932:
Results for branch master
[build #1649 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1649/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Add rs group management methods in Admin and AsyncAdmin
> ---
>
> Key: HBASE-22932
> URL: https://issues.apache.org/jira/browse/HBASE-22932
> Project: HBase
> Issue Type: Sub-task
> Components: Admin, asyncclient, Client
>Reporter: Duo Zhang
>Assignee: Xiaolin Ha
>Priority: Major
> Fix For: 3.0.0
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-22987) Calculate the region servers in default group in foreground
[
https://issues.apache.org/jira/browse/HBASE-22987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049134#comment-17049134
]
Hudson commented on HBASE-22987:
Results for branch master
[build #1649 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1649/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Calculate the region servers in default group in foreground
> ---
>
> Key: HBASE-22987
> URL: https://issues.apache.org/jira/browse/HBASE-22987
> Project: HBase
> Issue Type: Sub-task
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0
>
>
> As now we do not need to persist the default rs group, it is fine to calcuate
> in foreground as it is just some in memory computations. And maybe even we
> could calculate the server set when we want to use it?
> The advantage here is that there will be no lag.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23890) Update the rsgroup section in our ref guide
[
https://issues.apache.org/jira/browse/HBASE-23890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049147#comment-17049147
]
Hudson commented on HBASE-23890:
Results for branch master
[build #1649 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1649/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Update the rsgroup section in our ref guide
> ---
>
> Key: HBASE-23890
> URL: https://issues.apache.org/jira/browse/HBASE-23890
> Project: HBase
> Issue Type: Sub-task
> Components: documentation
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-22729) Start RSGroupInfoManager as default
[
https://issues.apache.org/jira/browse/HBASE-22729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049133#comment-17049133
]
Hudson commented on HBASE-22729:
Results for branch master
[build #1649 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1649/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Start RSGroupInfoManager as default
> ---
>
> Key: HBASE-22729
> URL: https://issues.apache.org/jira/browse/HBASE-22729
> Project: HBase
> Issue Type: Sub-task
> Components: master, rsgroup
>Reporter: Guanghao Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0
>
>
> Start RSGroupInfoManager as default. If no rsgroup information, all
> RegionServers belong to default group.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23050) Use RSGroupInfoManager to get rsgroups in master UI's rsgroup part
[
https://issues.apache.org/jira/browse/HBASE-23050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049138#comment-17049138
]
Hudson commented on HBASE-23050:
Results for branch master
[build #1649 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1649/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Use RSGroupInfoManager to get rsgroups in master UI's rsgroup part
> --
>
> Key: HBASE-23050
> URL: https://issues.apache.org/jira/browse/HBASE-23050
> Project: HBase
> Issue Type: Sub-task
>Reporter: Guanghao Zhang
>Assignee: Guangxu Cheng
>Priority: Major
> Fix For: 3.0.0
>
>
> Now it use RSGroupTableAccessor to get all rsgroups.
> {code:java}
> List groups =
> RSGroupTableAccessor.getAllRSGroupInfo(master.getConnection());
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23081) Add an option to enable/disable rs group feature
[
https://issues.apache.org/jira/browse/HBASE-23081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049136#comment-17049136
]
Hudson commented on HBASE-23081:
Results for branch master
[build #1649 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1649/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Add an option to enable/disable rs group feature
>
>
> Key: HBASE-23081
> URL: https://issues.apache.org/jira/browse/HBASE-23081
> Project: HBase
> Issue Type: Sub-task
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0
>
>
> I think we'd better follow the way of acl, although the balancer could always
> be RSGroupBasedLoadBalancer, but the RSGroupInfoManager can be different. If
> we disable rs group feature, we can introduced a DisabledRSGroupInfoManager.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23232) Remove rsgroup profile from pom.xml of hbase-assembly
[
https://issues.apache.org/jira/browse/HBASE-23232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049137#comment-17049137
]
Hudson commented on HBASE-23232:
Results for branch master
[build #1649 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1649/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Remove rsgroup profile from pom.xml of hbase-assembly
> -
>
> Key: HBASE-23232
> URL: https://issues.apache.org/jira/browse/HBASE-23232
> Project: HBase
> Issue Type: Sub-task
> Components: build, rsgroup
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
>Priority: Major
> Fix For: 3.0.0
>
>
> branch HBASE-22514 built failed
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-22695) Store the rsgroup of a table in table configuration
[
https://issues.apache.org/jira/browse/HBASE-22695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049129#comment-17049129
]
Hudson commented on HBASE-22695:
Results for branch master
[build #1649 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1649/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Store the rsgroup of a table in table configuration
> ---
>
> Key: HBASE-22695
> URL: https://issues.apache.org/jira/browse/HBASE-22695
> Project: HBase
> Issue Type: Sub-task
> Components: rsgroup
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-22809) Allow creating table in group when rs group contains no live servers
[
https://issues.apache.org/jira/browse/HBASE-22809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049130#comment-17049130
]
Hudson commented on HBASE-22809:
Results for branch master
[build #1649 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1649/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Allow creating table in group when rs group contains no live servers
>
>
> Key: HBASE-22809
> URL: https://issues.apache.org/jira/browse/HBASE-22809
> Project: HBase
> Issue Type: Sub-task
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0
>
>
> This is for API consistency. In general, a rs group could have no live
> servers if all the region servers are dead, and then the regions in side this
> group can not online.
> So it is a bit strange that we do not allow new regions here since they are
> just the same with the old regions...
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23911) Attach the new rsgroup implementation design doc to our code base
[
https://issues.apache.org/jira/browse/HBASE-23911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049148#comment-17049148
]
Hudson commented on HBASE-23911:
Results for branch master
[build #1649 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1649/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Attach the new rsgroup implementation design doc to our code base
> -
>
> Key: HBASE-23911
> URL: https://issues.apache.org/jira/browse/HBASE-23911
> Project: HBase
> Issue Type: Sub-task
> Components: documentation
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-22971) Deprecated RSGroupAdminEndpoint and make RSGroup feature always enabled
[
https://issues.apache.org/jira/browse/HBASE-22971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049135#comment-17049135
]
Hudson commented on HBASE-22971:
Results for branch master
[build #1649 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1649/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Deprecated RSGroupAdminEndpoint and make RSGroup feature always enabled
> ---
>
> Key: HBASE-22971
> URL: https://issues.apache.org/jira/browse/HBASE-22971
> Project: HBase
> Issue Type: Sub-task
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0
>
>
> As said in the design doc, rs group feature will always be enabled, but if
> you do not add any new rs groups, all the region servers and tables will be
> in the default group.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23818) Cleanup the remaining RSGroupInfo.getTables call in the code base
[
https://issues.apache.org/jira/browse/HBASE-23818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049146#comment-17049146
]
Hudson commented on HBASE-23818:
Results for branch master
[build #1649 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1649/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Cleanup the remaining RSGroupInfo.getTables call in the code base
> -
>
> Key: HBASE-23818
> URL: https://issues.apache.org/jira/browse/HBASE-23818
> Project: HBase
> Issue Type: Sub-task
> Components: rsgroup
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23276) Add admin methods to get tables within a group
[
https://issues.apache.org/jira/browse/HBASE-23276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049144#comment-17049144
]
Hudson commented on HBASE-23276:
Results for branch master
[build #1649 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1649/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Add admin methods to get tables within a group
> --
>
> Key: HBASE-23276
> URL: https://issues.apache.org/jira/browse/HBASE-23276
> Project: HBase
> Issue Type: Sub-task
> Components: Admin, Client, rsgroup
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0
>
>
> Now the RSGroupInfo will not contains table info, we should provide a method
> in Admin to do this, otherwise users need to scan all the table descriptors
> manually.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23743) Release 1.4.13
[
https://issues.apache.org/jira/browse/HBASE-23743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049149#comment-17049149
]
Hudson commented on HBASE-23743:
Results for branch master
[build #1649 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1649/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Release 1.4.13
> --
>
> Key: HBASE-23743
> URL: https://issues.apache.org/jira/browse/HBASE-23743
> Project: HBase
> Issue Type: Task
> Components: build, community
>Affects Versions: 1.4.13
>Reporter: Sean Busbey
>Assignee: Sakthi
>Priority: Major
> Fix For: 1.4.13
>
>
> over due for 1.4.13. I'll try to use the release manager scripts this time.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23235) Re-enable TestRSGroupsKillRS.testLowerMetaGroupVersion
[
https://issues.apache.org/jira/browse/HBASE-23235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049143#comment-17049143
]
Hudson commented on HBASE-23235:
Results for branch master
[build #1649 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1649/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Re-enable TestRSGroupsKillRS.testLowerMetaGroupVersion
> --
>
> Key: HBASE-23235
> URL: https://issues.apache.org/jira/browse/HBASE-23235
> Project: HBase
> Issue Type: Sub-task
> Components: rsgroup, test
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0
>
>
> It is not allowed to change the table descriptor for system tables,
> especially that the table descriptor for meta table is hard coded. We need to
> find a way to deal with this.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-22819) Automatically migrate the rs group config for table after HBASE-22695
[
https://issues.apache.org/jira/browse/HBASE-22819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049132#comment-17049132
]
Hudson commented on HBASE-22819:
Results for branch master
[build #1649 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1649/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Automatically migrate the rs group config for table after HBASE-22695
> -
>
> Key: HBASE-22819
> URL: https://issues.apache.org/jira/browse/HBASE-22819
> Project: HBase
> Issue Type: Sub-task
> Components: master, rsgroup
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0
>
>
> It used to be stored in the rsgroup table, so we need to migrate it to the
> new place.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-22676) Move all the code in hbase-rsgroup to hbase-server and remove hbase-rsgroup module
[
https://issues.apache.org/jira/browse/HBASE-22676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049128#comment-17049128
]
Hudson commented on HBASE-22676:
Results for branch master
[build #1649 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1649/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Move all the code in hbase-rsgroup to hbase-server and remove hbase-rsgroup
> module
> --
>
> Key: HBASE-22676
> URL: https://issues.apache.org/jira/browse/HBASE-22676
> Project: HBase
> Issue Type: Sub-task
> Components: build, pom, rsgroup
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0
>
>
> Let's do this first and then try to refactor it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-22664) Move protobuf stuff in hbase-rsgroup to hbase-protocol-shaded
[
https://issues.apache.org/jira/browse/HBASE-22664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049126#comment-17049126
]
Hudson commented on HBASE-22664:
Results for branch master
[build #1649 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1649/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Move protobuf stuff in hbase-rsgroup to hbase-protocol-shaded
> -
>
> Key: HBASE-22664
> URL: https://issues.apache.org/jira/browse/HBASE-22664
> Project: HBase
> Issue Type: Sub-task
> Components: Protobufs, Region Assignment, rsgroup
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-22662) Move RSGroupInfoManager to hbase-server
[
https://issues.apache.org/jira/browse/HBASE-22662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049127#comment-17049127
]
Hudson commented on HBASE-22662:
Results for branch master
[build #1649 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1649/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Move RSGroupInfoManager to hbase-server
> ---
>
> Key: HBASE-22662
> URL: https://issues.apache.org/jira/browse/HBASE-22662
> Project: HBase
> Issue Type: Sub-task
> Components: rsgroup
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-22662.v0.patch, HBASE-22662.v1.patch
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23914) TestThriftHBaseServiceHandler.testMetricsWithException failing
[
https://issues.apache.org/jira/browse/HBASE-23914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049125#comment-17049125
]
Hudson commented on HBASE-23914:
Results for branch master
[build #1649 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1649/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1649//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> TestThriftHBaseServiceHandler.testMetricsWithException failing
> --
>
> Key: HBASE-23914
> URL: https://issues.apache.org/jira/browse/HBASE-23914
> Project: HBase
> Issue Type: Test
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> TestThriftHBaseServiceHandler.testMetricsWithException() is failing as test
> due to timeout. We need to set hbase.client.retries.number
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] virajjasani commented on issue #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
virajjasani commented on issue #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)… URL: https://github.com/apache/hbase/pull/1222#issuecomment-593364692 Thanks for the review @HorizonNet This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Comment Edited] (HBASE-23887) BlockCache performance improve
[
https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049107#comment-17049107
]
Danil Lipovoy edited comment on HBASE-23887 at 3/2/20 11:13 AM:
Did long run load test for weekend. Changed blocksize, comperssion and run
major_compact - that's why lines changes sometimes. All is ok, cluster is
working:
!BC_LongRun.png!
When we could merge PR?
was (Author: pustota):
Did long run load test for weekend. Changed blocksize, comperssion and run
major_compact - that's why lines changes sometimes. All is ok cluster is
working:
!BC_LongRun.png!
When we could merge PR?
> BlockCache performance improve
> --
>
> Key: HBASE-23887
> URL: https://issues.apache.org/jira/browse/HBASE-23887
> Project: HBase
> Issue Type: Improvement
> Components: BlockCache, Performance
>Reporter: Danil Lipovoy
>Priority: Minor
> Attachments: 1582787018434_rs_metrics.jpg,
> 1582801838065_rs_metrics_new.png, BC_LongRun.png, cmp.png
>
>
> Hi!
> I first time here, correct me please if something wrong.
> I want propose how to improve performance when data in HFiles much more than
> BlockChache (usual story in BigData). The idea - caching only part of DATA
> blocks. It is good becouse LruBlockCache starts to work and save huge amount
> of GC. See the picture in attachment with test below. Requests per second is
> higher, GC is lower.
>
> The key point of the code:
> Added the parameter: *hbase.lru.cache.data.block.percent* which by default =
> 100
>
> But if we set it 0-99, then will work the next logic:
>
>
> {code:java}
> public void cacheBlock(BlockCacheKey cacheKey, Cacheable buf, boolean
> inMemory) {
> if (cacheDataBlockPercent != 100 && buf.getBlockType().isData())
> if (cacheKey.getOffset() % 100 >= cacheDataBlockPercent)
> return;
> ...
> // the same code as usual
> }
> {code}
>
>
> Descriptions of the test:
> 4 nodes E5-2698 v4 @ 2.20GHz, 700 Gb Mem.
> 4 RegionServers
> 4 tables by 64 regions by 1.88 Gb data in each = 600 Gb total (only FAST_DIFF)
> Total BlockCache Size = 48 Gb (8 % of data in HFiles)
> Random read in 20 threads
>
> I am going to make Pull Request, hope it is right way to make some
> contribution in this cool product.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23887) BlockCache performance improve
[
https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049107#comment-17049107
]
Danil Lipovoy commented on HBASE-23887:
---
Did long run load test for weekend. Changed blocksize, comperssion and run
major_compact - that's why lines changes sometimes. All is ok cluster is
working:
!BC_LongRun.png!
When we could merge PR?
> BlockCache performance improve
> --
>
> Key: HBASE-23887
> URL: https://issues.apache.org/jira/browse/HBASE-23887
> Project: HBase
> Issue Type: Improvement
> Components: BlockCache, Performance
>Reporter: Danil Lipovoy
>Priority: Minor
> Attachments: 1582787018434_rs_metrics.jpg,
> 1582801838065_rs_metrics_new.png, BC_LongRun.png, cmp.png
>
>
> Hi!
> I first time here, correct me please if something wrong.
> I want propose how to improve performance when data in HFiles much more than
> BlockChache (usual story in BigData). The idea - caching only part of DATA
> blocks. It is good becouse LruBlockCache starts to work and save huge amount
> of GC. See the picture in attachment with test below. Requests per second is
> higher, GC is lower.
>
> The key point of the code:
> Added the parameter: *hbase.lru.cache.data.block.percent* which by default =
> 100
>
> But if we set it 0-99, then will work the next logic:
>
>
> {code:java}
> public void cacheBlock(BlockCacheKey cacheKey, Cacheable buf, boolean
> inMemory) {
> if (cacheDataBlockPercent != 100 && buf.getBlockType().isData())
> if (cacheKey.getOffset() % 100 >= cacheDataBlockPercent)
> return;
> ...
> // the same code as usual
> }
> {code}
>
>
> Descriptions of the test:
> 4 nodes E5-2698 v4 @ 2.20GHz, 700 Gb Mem.
> 4 RegionServers
> 4 tables by 64 regions by 1.88 Gb data in each = 600 Gb total (only FAST_DIFF)
> Total BlockCache Size = 48 Gb (8 % of data in HFiles)
> Random read in 20 threads
>
> I am going to make Pull Request, hope it is right way to make some
> contribution in this cool product.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-23887) BlockCache performance improve
[
https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Danil Lipovoy updated HBASE-23887:
--
Attachment: BC_LongRun.png
> BlockCache performance improve
> --
>
> Key: HBASE-23887
> URL: https://issues.apache.org/jira/browse/HBASE-23887
> Project: HBase
> Issue Type: Improvement
> Components: BlockCache, Performance
>Reporter: Danil Lipovoy
>Priority: Minor
> Attachments: 1582787018434_rs_metrics.jpg,
> 1582801838065_rs_metrics_new.png, BC_LongRun.png, cmp.png
>
>
> Hi!
> I first time here, correct me please if something wrong.
> I want propose how to improve performance when data in HFiles much more than
> BlockChache (usual story in BigData). The idea - caching only part of DATA
> blocks. It is good becouse LruBlockCache starts to work and save huge amount
> of GC. See the picture in attachment with test below. Requests per second is
> higher, GC is lower.
>
> The key point of the code:
> Added the parameter: *hbase.lru.cache.data.block.percent* which by default =
> 100
>
> But if we set it 0-99, then will work the next logic:
>
>
> {code:java}
> public void cacheBlock(BlockCacheKey cacheKey, Cacheable buf, boolean
> inMemory) {
> if (cacheDataBlockPercent != 100 && buf.getBlockType().isData())
> if (cacheKey.getOffset() % 100 >= cacheDataBlockPercent)
> return;
> ...
> // the same code as usual
> }
> {code}
>
>
> Descriptions of the test:
> 4 nodes E5-2698 v4 @ 2.20GHz, 700 Gb Mem.
> 4 RegionServers
> 4 tables by 64 regions by 1.88 Gb data in each = 600 Gb total (only FAST_DIFF)
> Total BlockCache Size = 48 Gb (8 % of data in HFiles)
> Random read in 20 threads
>
> I am going to make Pull Request, hope it is right way to make some
> contribution in this cool product.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] wchevreuil commented on a change in pull request #1231: HBASE-23917 [SimpleRpcServer] Subsequent requests will have no response in case of request IO mess up
wchevreuil commented on a change in pull request #1231: HBASE-23917
[SimpleRpcServer] Subsequent requests will have no response in case of request
IO mess up
URL: https://github.com/apache/hbase/pull/1231#discussion_r386308348
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestBlockingIPC.java
##
@@ -106,4 +121,62 @@ protected RpcServer createTestFailingRpcServer(Server
server, String name,
Configuration conf, RpcScheduler scheduler) throws IOException {
return new TestFailingRpcServer(server, name, services, bindAddress, conf,
scheduler);
}
+
+ private static class TestIOMessUpRpcServer extends SimpleRpcServer {
+TestIOMessUpRpcServer(Server server, String name,
+List services,
InetSocketAddress bindAddress,
+Configuration conf, RpcScheduler scheduler) throws IOException {
+ super(server, name, services, bindAddress, conf, scheduler, true);
+}
+
+@Override
+protected SimpleServerRpcConnection getConnection(SocketChannel channel,
long time) {
+ return new SimpleServerRpcConnection(this, channel, time) {
+private boolean ioMessUp = true;
+@Override
+void initByteBuffToReadInto(int length) {
+ if (connectionHeaderRead && connectionPreambleRead && ioMessUp) {
+// mock that the request has mess up
+ioMessUp = false;
+super.initByteBuffToReadInto(length + 100);
+ } else {
+super.initByteBuffToReadInto(length);
+ }
+}
+ };
+}
+ }
+
+ private RpcServer createIOMessUpRpcServer(Server server, String name,
+ List services, InetSocketAddress
bindAddress,
+ Configuration conf, RpcScheduler scheduler) throws IOException {
+return new TestIOMessUpRpcServer(server, name, services, bindAddress,
conf, scheduler);
+ }
+
+ @Test
+ public void testRequestIOMessUp() throws IOException, ServiceException {
+String msg = "hello";
+Configuration conf = new Configuration(CONF);
+RpcServer rpcServer = createIOMessUpRpcServer(null, "testRpcServer",
+Lists.newArrayList(new RpcServer.BlockingServiceAndInterface(
+SERVICE, null)), new InetSocketAddress("localhost", 0), conf,
+new FifoRpcScheduler(conf, 1));
+
+try (AbstractRpcClient client = createRpcClient(conf)) {
+ rpcServer.start();
+ BlockingInterface stub = newBlockingStub(client,
rpcServer.getListenerAddress());
+ EchoRequestProto param =
EchoRequestProto.newBuilder().setMessage(msg).build();
+ try {
+stub.echo(null, param);
+fail("RPC should have failed because request IO mess up.");
+ } catch (ServiceException e) {
+assertTrue(e.toString(),
+
StringUtils.stringifyException(e).contains("RequestIOMessUpException"));
+// mess up IO don't blocking subsequent requests
+assertEquals(msg, stub.echo(null, param).getMessage());
Review comment:
nit: use _expected_ flag in _@Test_ annotation?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] wchevreuil commented on a change in pull request #1231: HBASE-23917 [SimpleRpcServer] Subsequent requests will have no response in case of request IO mess up
wchevreuil commented on a change in pull request #1231: HBASE-23917
[SimpleRpcServer] Subsequent requests will have no response in case of request
IO mess up
URL: https://github.com/apache/hbase/pull/1231#discussion_r386144505
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/RequestIOMessUpException.java
##
@@ -0,0 +1,37 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hbase;
+
+import java.io.IOException;
+import org.apache.yetus.audience.InterfaceAudience;
+
+/**
+ * Thrown by a region server if the request IO mess up.
+ */
+@SuppressWarnings("serial")
+@InterfaceAudience.Public
+public class RequestIOMessUpException extends IOException {
Review comment:
What is a request IO mess up? Some sort of corruption in the stream? A
socket time out? It would be nice to provide more details in the comments and
maybe rename it to something more intuitive, such as
"RequestIOCorruptionException" or "RpcCorruptionException"?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ramkrish86 commented on issue #1219: HBASE-23788 ROW_INDEX_V1 encoder should consider the secondary index size with the encoded data size tracking
ramkrish86 commented on issue #1219: HBASE-23788 ROW_INDEX_V1 encoder should consider the secondary index size with the encoded data size tracking URL: https://github.com/apache/hbase/pull/1219#issuecomment-593323647 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23909) list_regions fails if table is under split
[
https://issues.apache.org/jira/browse/HBASE-23909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17048984#comment-17048984
]
Peter Somogyi commented on HBASE-23909:
---
bq. As of now, we don't have an Admin API to determine if any region of a given
table is being split right now. Is that correct?
Yes, I'm not aware of such API.
Go for it! :)
> list_regions fails if table is under split
> --
>
> Key: HBASE-23909
> URL: https://issues.apache.org/jira/browse/HBASE-23909
> Project: HBase
> Issue Type: Bug
> Components: shell
>Affects Versions: 1.6.0
>Reporter: Peter Somogyi
>Priority: Minor
>
> Shortly after executing split 'table' command from the shell the list_regions
> 'table' fails with "ERROR: undefined method `toString' for nil:NilClass"
>
> {noformat}
> hbase(main):002:0> list_regions 'cluster_test'
> SERVER_NAME |
>REGION_NAME | START_KEY |END_KEY | SIZE | REQ |
> LOCALITY |
> --- |
> - |
> -- | -- | - | | -- |
> nokedli,34665,1582736360668 |
> cluster_test,,1582736408029.857a9b734a2f490e573ba20b1bbf99b3. ||
> | 3348 | 20408042 |0.0 |
> nokedli,34665,1582736360668 |
> cluster_test,,1582736408029.1749360028b3a5e76b5da1d1888e5b9d. |
> | | 3321 | 20242123 |0.0 |
> nokedli,34665,1582736360668 |
> cluster_test,,1582736408029.1f1366aa0ee621d496103ac5a50bca77. |
> | | 3316 | 20215774 |0.0 |
> nokedli,34665,1582736360668 |
> cluster_test,,1582736408029.ae95589c9498443a89aea4c42c199372. |
> | | 3327 | 20285312 |0.0 |
> nokedli,34665,1582736360668 |
> cluster_test,,1582736408029.239647c37e27cbd3154180ce5004a1ea. |
> || 3355 | 20451469 |0.0 |
> 5 rows
> hbase(main):003:0> split 'cluster_test'
> 0 row(s) in 0.2240 seconds
> hbase(main):004:0> list_regions 'cluster_test'
> ERROR: undefined method `toString' for nil:NilClass
> Here is some help for this command:
> List all regions for a particular table as an array and also filter
> them by server name (optional) as prefix
> and maximum locality (optional). By default, it will return all the
> regions for the table with any locality.
> The command displays server name, region name, start key, end key,
> size of the region in MB, number of requests
> and the locality. The information can be projected out via an array
> as third parameter. By default all these information
> is displayed. Possible array values are SERVER_NAME, REGION_NAME,
> START_KEY, END_KEY, SIZE, REQ and LOCALITY. Values
> are not case sensitive. If you don't want to filter by server name,
> pass an empty hash / string as shown below.
> Examples:
> hbase> list_regions 'table_name'
> hbase> list_regions 'table_name', 'server_name'
> hbase> list_regions 'table_name', {SERVER_NAME => 'server_name',
> LOCALITY_THRESHOLD => 0.8}
> hbase> list_regions 'table_name', {SERVER_NAME => 'server_name',
> LOCALITY_THRESHOLD => 0.8}, ['SERVER_NAME']
> hbase> list_regions 'table_name', {}, ['SERVER_NAME', 'start_key']
> hbase> list_regions 'table_name', '', ['SERVER_NAME', 'start_key']
> hbase(main):005:0> list_regions 'cluster_test'
> SERVER_NAME |
> REGION_NAME |
> START_KEY | END_KEY | SIZE |
> REQ | LOCALITY |
> --- |
>
> | --- |
> --- | - | | -- |
> nokedli,34665,1582736360668 |
> cluster_test,,1582878981608.614acededc61f55a10816bb871d0421b. |
> | 197f83f2390a2a0c4104f4630982c585-461828 | 3348 |
> 10204021 |0.0 |
> nokedli,34665,1582736360668 |
> cluster_test,197f83f2390a2a0c4104f4630982c585-461828,1582878981608.5987f972793bd422564a0758e545caa5.
> | 197f83f2390a2a0c4104f4630982c585-461828 |
> | 3348 | 10204021 |0.0 |
> nokedli,34665,1582736360668 |
> cluster_test,,1582878982425.a306381f3ee03161dc832eaca066131b. |
> |
[GitHub] [hbase-operator-tools] wchevreuil commented on issue #53: HBASE-23791 [operator tools] Remove reference to I.A. Private interfa…
wchevreuil commented on issue #53: HBASE-23791 [operator tools] Remove reference to I.A. Private interfa… URL: https://github.com/apache/hbase-operator-tools/pull/53#issuecomment-593314870 Ping @joshelser : Any further suggestions with this one or are we good to go here? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace
usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r386274757
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestAtomicOperation.java
##
@@ -301,15 +299,18 @@ private void initHRegion (byte [] tableName, String
callingMethod,
private void initHRegion (byte [] tableName, String callingMethod, int []
maxVersions,
byte[] ... families)
throws IOException {
-HTableDescriptor htd = new HTableDescriptor(TableName.valueOf(tableName));
+TableDescriptorBuilder.ModifyableTableDescriptor tableDescriptor =
+ new
TableDescriptorBuilder.ModifyableTableDescriptor(TableName.valueOf(tableName));
+
int i=0;
for(byte [] family : families) {
- HColumnDescriptor hcd = new HColumnDescriptor(family);
- hcd.setMaxVersions(maxVersions != null ? maxVersions[i++] : 1);
- htd.addFamily(hcd);
+ ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor
familyDescriptor =
+new
ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor(family);
+ familyDescriptor.setMaxVersions(maxVersions != null ? maxVersions[i++] :
1);
Review comment:
Use the builder.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace
usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r386274592
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/mob/TestMobStoreScanner.java
##
@@ -99,14 +99,14 @@ public static void tearDownAfterClass() throws Exception {
public void setUp(long threshold, TableName tn) throws Exception {
conf = TEST_UTIL.getConfiguration();
fs = FileSystem.get(conf);
-desc = new HTableDescriptor(tn);
-hcd = new HColumnDescriptor(family);
-hcd.setMobEnabled(true);
-hcd.setMobThreshold(threshold);
-hcd.setMaxVersions(4);
-desc.addFamily(hcd);
+tableDescriptor = new TableDescriptorBuilder.ModifyableTableDescriptor(tn);
+familyDescriptor = new
ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor(family);
+familyDescriptor.setMobEnabled(true);
Review comment:
Use the builder.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace
usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r386281197
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
##
@@ -2806,15 +2804,18 @@ public void testGetWithFilter() throws IOException,
InterruptedException {
byte[] value2 = Bytes.toBytes("value2");
final int maxVersions = 3;
-HColumnDescriptor hcd = new HColumnDescriptor(fam1);
-hcd.setMaxVersions(maxVersions);
-HTableDescriptor htd = new
HTableDescriptor(TableName.valueOf("testFilterAndColumnTracker"));
-htd.addFamily(hcd);
+ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor
familyDescriptor =
+ new ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor(fam1);
+familyDescriptor.setMaxVersions(maxVersions);
Review comment:
Use the builder.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace
usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r386282004
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestPerColumnFamilyFlush.java
##
@@ -629,12 +636,17 @@ public static void main(String[] args) throws Exception {
int numRegions = Integer.parseInt(args[0]);
long numRows = Long.parseLong(args[1]);
-HTableDescriptor htd = new HTableDescriptor(TABLENAME);
-htd.setMaxFileSize(10L * 1024 * 1024 * 1024);
-htd.setValue(HTableDescriptor.SPLIT_POLICY,
ConstantSizeRegionSplitPolicy.class.getName());
-htd.addFamily(new HColumnDescriptor(FAMILY1));
-htd.addFamily(new HColumnDescriptor(FAMILY2));
-htd.addFamily(new HColumnDescriptor(FAMILY3));
+TableDescriptorBuilder.ModifyableTableDescriptor tableDescriptor =
+ new TableDescriptorBuilder.ModifyableTableDescriptor(TABLENAME);
+tableDescriptor.setMaxFileSize(10L * 1024 * 1024 * 1024);
Review comment:
Use the builder.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace
usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r386274396
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/mob/TestMobFileCleanerChore.java
##
@@ -87,24 +87,23 @@
public TestMobFileCleanerChore() {
}
-
@Before
public void setUp() throws Exception {
HTU = new HBaseTestingUtility();
-hdt = HTU.createTableDescriptor(TableName.valueOf("testMobCompactTable"));
+tableDescriptor =
HTU.createModifyableTableDescriptor("testMobCompactTable");
conf = HTU.getConfiguration();
initConf();
HTU.startMiniCluster();
admin = HTU.getAdmin();
chore = new MobFileCleanerChore();
-hcd = new HColumnDescriptor(fam);
-hcd.setMobEnabled(true);
-hcd.setMobThreshold(mobLen);
-hcd.setMaxVersions(1);
-hdt.addFamily(hcd);
-table = HTU.createTable(hdt, null);
+familyDescriptor = new
ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor(fam);
+familyDescriptor.setMobEnabled(true);
Review comment:
Use the builder.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…
HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace
usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r386275633
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactSplitThread.java
##
@@ -111,10 +112,12 @@ public void testThreadPoolSizeTuning() throws Exception {
Configuration conf = TEST_UTIL.getConfiguration();
Connection conn = ConnectionFactory.createConnection(conf);
try {
- HTableDescriptor htd = new HTableDescriptor(tableName);
- htd.addFamily(new HColumnDescriptor(family));
- htd.setCompactionEnabled(false);
- TEST_UTIL.getAdmin().createTable(htd);
+ TableDescriptorBuilder.ModifyableTableDescriptor tableDescriptor =
+new TableDescriptorBuilder.ModifyableTableDescriptor(tableName);
+ tableDescriptor.setColumnFamily(
+new
ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor(family));
+ tableDescriptor.setCompactionEnabled(false);
Review comment:
Use the builder.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
