[GitHub] [hbase] Apache-HBase commented on pull request #1962: HBASE-24615 MutableRangeHistogram#updateSnapshotRangeMetrics doesn't calculate the distribution for last bucket.
Apache-HBase commented on pull request #1962: URL: https://github.com/apache/hbase/pull/1962#issuecomment-655937122 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 41s | master passed | | +1 :green_heart: | checkstyle | 0m 17s | master passed | | +1 :green_heart: | spotbugs | 0m 40s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 31s | the patch passed | | -0 :warning: | checkstyle | 0m 15s | hbase-hadoop-compat: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 14m 17s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 0m 47s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 13s | The patch does not generate ASF License warnings. | | | | 35m 29s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1962/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1962 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 1e399d1d4942 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 1db89773e6 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1962/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-hadoop-compat.txt | | Max. process+thread count | 95 (vs. ulimit of 12500) | | modules | C: hbase-hadoop-compat U: hbase-hadoop-compat | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1962/3/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1962: HBASE-24615 MutableRangeHistogram#updateSnapshotRangeMetrics doesn't calculate the distribution for last bucket.
Apache-HBase commented on pull request #1962: URL: https://github.com/apache/hbase/pull/1962#issuecomment-655935287 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 49s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 38s | master passed | | +1 :green_heart: | compile | 0m 22s | master passed | | +1 :green_heart: | shadedjars | 7m 35s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 22s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 30s | the patch passed | | +1 :green_heart: | compile | 0m 22s | the patch passed | | +1 :green_heart: | javac | 0m 22s | the patch passed | | +1 :green_heart: | shadedjars | 7m 8s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 18s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 40s | hbase-hadoop-compat in the patch passed. | | | | 28m 47s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1962/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1962 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux f9def8818fbe 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 1db89773e6 | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1962/3/testReport/ | | Max. process+thread count | 318 (vs. ulimit of 12500) | | modules | C: hbase-hadoop-compat U: hbase-hadoop-compat | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1962/3/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2035: HBASE-24663 Add procedure process time statistics UI
Apache-HBase commented on pull request #2035: URL: https://github.com/apache/hbase/pull/2035#issuecomment-655931078 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 11s | master passed | | +1 :green_heart: | compile | 1m 37s | master passed | | +1 :green_heart: | shadedjars | 5m 47s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 18s | hbase-metrics in master failed. | | -0 :warning: | javadoc | 0m 16s | hbase-metrics-api in master failed. | | -0 :warning: | javadoc | 0m 39s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 59s | the patch passed | | +1 :green_heart: | compile | 1m 39s | the patch passed | | +1 :green_heart: | javac | 1m 39s | the patch passed | | +1 :green_heart: | shadedjars | 5m 41s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 16s | hbase-metrics-api in the patch failed. | | -0 :warning: | javadoc | 0m 16s | hbase-metrics in the patch failed. | | -0 :warning: | javadoc | 0m 40s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 21s | hbase-metrics-api in the patch passed. | | +1 :green_heart: | unit | 0m 21s | hbase-metrics in the patch passed. | | +1 :green_heart: | unit | 130m 4s | hbase-server in the patch passed. | | | | 159m 48s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2035/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2035 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux d92dd5b83e1d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 1db89773e6 | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2035/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-metrics.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2035/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-metrics-api.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2035/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2035/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-metrics-api.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2035/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-metrics.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2035/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2035/2/testReport/ | | Max. process+thread count | 4526 (vs. ulimit of 12500) | | modules | C: hbase-metrics-api hbase-metrics hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2035/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bsglz commented on pull request #1926: HBASE-24586 Add table level locality in table.jsp
bsglz commented on pull request #1926: URL: https://github.com/apache/hbase/pull/1926#issuecomment-655930843 The ut failure seems related, let me check. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2039: HBASE-22738 Fallback to default group to choose RS when there are no …
Apache-HBase commented on pull request #2039: URL: https://github.com/apache/hbase/pull/2039#issuecomment-655930446 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 38s | branch-2 passed | | +1 :green_heart: | checkstyle | 0m 15s | branch-2 passed | | +1 :green_heart: | spotbugs | 0m 42s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 11s | the patch passed | | +1 :green_heart: | checkstyle | 0m 13s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 19s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 0m 49s | the patch passed | ||| _ Other Tests _ | | -1 :x: | asflicense | 0m 14s | The patch generated 1 ASF License warnings. | | | | 27m 58s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2039/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2039 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 90bdb6ccd1e7 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 5fcffae5db | | asflicense | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2039/1/artifact/yetus-general-check/output/patch-asflicense-problems.txt | | Max. process+thread count | 94 (vs. ulimit of 12500) | | modules | C: hbase-rsgroup U: hbase-rsgroup | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2039/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2039: HBASE-22738 Fallback to default group to choose RS when there are no …
Apache-HBase commented on pull request #2039: URL: https://github.com/apache/hbase/pull/2039#issuecomment-655930268 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s | Docker mode activated. | | -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 27s | branch-2 passed | | +1 :green_heart: | compile | 0m 28s | branch-2 passed | | +1 :green_heart: | shadedjars | 5m 55s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 26s | hbase-rsgroup in branch-2 failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 4s | the patch passed | | +1 :green_heart: | compile | 0m 27s | the patch passed | | +1 :green_heart: | javac | 0m 27s | the patch passed | | +1 :green_heart: | shadedjars | 6m 40s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 21s | hbase-rsgroup in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 54s | hbase-rsgroup in the patch passed. | | | | 27m 25s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2039/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2039 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 21c3baad9693 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 5fcffae5db | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2039/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rsgroup.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2039/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rsgroup.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2039/1/testReport/ | | Max. process+thread count | 3900 (vs. ulimit of 12500) | | modules | C: hbase-rsgroup U: hbase-rsgroup | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2039/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2039: HBASE-22738 Fallback to default group to choose RS when there are no …
Apache-HBase commented on pull request #2039: URL: https://github.com/apache/hbase/pull/2039#issuecomment-655928889 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s | Docker mode activated. | | -0 :warning: | yetus | 0m 8s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 44s | branch-2 passed | | +1 :green_heart: | compile | 0m 23s | branch-2 passed | | +1 :green_heart: | shadedjars | 5m 2s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 24s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 28s | the patch passed | | +1 :green_heart: | compile | 0m 23s | the patch passed | | +1 :green_heart: | javac | 0m 23s | the patch passed | | +1 :green_heart: | shadedjars | 5m 4s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 21s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 3m 1s | hbase-rsgroup in the patch passed. | | | | 23m 34s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2039/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2039 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 16b57d332afa 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 5fcffae5db | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2039/1/testReport/ | | Max. process+thread count | 3831 (vs. ulimit of 12500) | | modules | C: hbase-rsgroup U: hbase-rsgroup | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2039/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ddupg opened a new pull request #2039: HBASE-22738 Fallback to default group to choose RS when there are no …
ddupg opened a new pull request #2039: URL: https://github.com/apache/hbase/pull/2039 …RS in current group backport HBASE-22738 to branch2 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1926: HBASE-24586 Add table level locality in table.jsp
Apache-HBase commented on pull request #1926: URL: https://github.com/apache/hbase/pull/1926#issuecomment-655919756 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 35s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 3s | master passed | | +1 :green_heart: | compile | 2m 30s | master passed | | +1 :green_heart: | shadedjars | 5m 40s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 26s | hbase-client in master failed. | | -0 :warning: | javadoc | 0m 40s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 58s | the patch passed | | +1 :green_heart: | compile | 2m 30s | the patch passed | | +1 :green_heart: | javac | 2m 30s | the patch passed | | +1 :green_heart: | shadedjars | 5m 44s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 26s | hbase-client in the patch failed. | | -0 :warning: | javadoc | 0m 39s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 59s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 1m 6s | hbase-client in the patch passed. | | -1 :x: | unit | 142m 10s | hbase-server in the patch failed. | | | | 175m 2s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1926/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1926 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 97ab23609da9 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 1db89773e6 | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1926/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1926/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1926/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1926/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1926/5/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1926/5/testReport/ | | Max. process+thread count | 3979 (vs. ulimit of 12500) | | modules | C: hbase-protocol-shaded hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1926/5/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1926: HBASE-24586 Add table level locality in table.jsp
Apache-HBase commented on pull request #1926: URL: https://github.com/apache/hbase/pull/1926#issuecomment-655918331 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 32s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 32s | master passed | | +1 :green_heart: | compile | 2m 10s | master passed | | +1 :green_heart: | shadedjars | 5m 40s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 14s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 27s | the patch passed | | +1 :green_heart: | compile | 2m 4s | the patch passed | | +1 :green_heart: | javac | 2m 4s | the patch passed | | +1 :green_heart: | shadedjars | 5m 34s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 11s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 45s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 1m 8s | hbase-client in the patch passed. | | -1 :x: | unit | 140m 2s | hbase-server in the patch failed. | | | | 170m 48s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1926/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1926 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux baef9cf6e2f0 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 1db89773e6 | | Default Java | 1.8.0_232 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1926/5/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1926/5/testReport/ | | Max. process+thread count | 4319 (vs. ulimit of 12500) | | modules | C: hbase-protocol-shaded hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1926/5/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2006: HBASE-24632 Enable procedure-based log splitting as default in hbase3
Apache-HBase commented on pull request #2006: URL: https://github.com/apache/hbase/pull/2006#issuecomment-655907968 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 31s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 15s | branch-2 passed | | +1 :green_heart: | checkstyle | 1m 46s | branch-2 passed | | +1 :green_heart: | spotbugs | 3m 4s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 11s | the patch passed | | -0 :warning: | checkstyle | 1m 7s | hbase-server: The patch generated 1 new + 50 unchanged - 20 fixed = 51 total (was 70) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 32s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 3m 37s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 35s | The patch does not generate ASF License warnings. | | | | 37m 52s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2006/7/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2006 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 70b0b70a0db2 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 5fcffae5db | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2006/7/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 94 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-zookeeper hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2006/7/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2038: HBASE-24687 MobFileCleanerChore uses a new Connection for each table …
Apache-HBase commented on pull request #2038: URL: https://github.com/apache/hbase/pull/2038#issuecomment-655895497 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 27s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 11s | master passed | | +1 :green_heart: | checkstyle | 1m 13s | master passed | | +1 :green_heart: | spotbugs | 2m 10s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 46s | the patch passed | | -0 :warning: | checkstyle | 1m 11s | hbase-server: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 12m 26s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 2m 24s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 13s | The patch does not generate ASF License warnings. | | | | 36m 50s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2038/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2038 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux f78b36892f12 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 1db89773e6 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2038/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 84 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2038/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2035: HBASE-24663 Add procedure process time statistics UI
Apache-HBase commented on pull request #2035: URL: https://github.com/apache/hbase/pull/2035#issuecomment-655893053 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 24s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 28s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 50s | master passed | | +1 :green_heart: | checkstyle | 1m 31s | master passed | | +1 :green_heart: | spotbugs | 2m 50s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 43s | the patch passed | | +1 :green_heart: | checkstyle | 1m 30s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 12m 7s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 3m 17s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 30s | The patch does not generate ASF License warnings. | | | | 38m 23s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2035/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2035 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 72f02f675fbc 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 1db89773e6 | | Max. process+thread count | 84 (vs. ulimit of 12500) | | modules | C: hbase-metrics-api hbase-metrics hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2035/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1961: HBASE-24623 SIGSEGV v ~StubRoutines::jbyte_disjoint_arraycopy
Apache-HBase commented on pull request #1961: URL: https://github.com/apache/hbase/pull/1961#issuecomment-655886052 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 30s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 42s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 14s | branch-2 passed | | +1 :green_heart: | compile | 1m 29s | branch-2 passed | | +1 :green_heart: | shadedjars | 5m 42s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 4s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 21s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 51s | the patch passed | | +1 :green_heart: | compile | 1m 23s | the patch passed | | +1 :green_heart: | javac | 1m 23s | the patch passed | | +1 :green_heart: | shadedjars | 5m 31s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 56s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 26s | hbase-common in the patch passed. | | -1 :x: | unit | 232m 1s | hbase-server in the patch failed. | | | | 262m 25s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1961/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1961 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 315e754c0886 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 5fcffae5db | | Default Java | 1.8.0_232 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1961/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1961/2/testReport/ | | Max. process+thread count | 2489 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1961/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Joseph295 opened a new pull request #2038: HBASE-24687 MobFileCleanerChore uses a new Connection for each table …
Joseph295 opened a new pull request #2038: URL: https://github.com/apache/hbase/pull/2038 …each time it runs This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1961: HBASE-24623 SIGSEGV v ~StubRoutines::jbyte_disjoint_arraycopy
Apache-HBase commented on pull request #1961: URL: https://github.com/apache/hbase/pull/1961#issuecomment-655883727 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 29s | Docker mode activated. | | -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 3s | branch-2 passed | | +1 :green_heart: | compile | 1m 45s | branch-2 passed | | +1 :green_heart: | shadedjars | 6m 44s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 23s | hbase-common in branch-2 failed. | | -0 :warning: | javadoc | 0m 53s | hbase-server in branch-2 failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 26s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 42s | the patch passed | | +1 :green_heart: | compile | 1m 40s | the patch passed | | +1 :green_heart: | javac | 1m 40s | the patch passed | | +1 :green_heart: | shadedjars | 6m 50s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 20s | hbase-common in the patch failed. | | -0 :warning: | javadoc | 0m 49s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 14s | hbase-common in the patch passed. | | -1 :x: | unit | 215m 35s | hbase-server in the patch failed. | | | | 251m 22s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1961/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1961 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 7d7fbeab4001 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 5fcffae5db | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1961/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1961/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1961/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1961/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1961/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1961/2/testReport/ | | Max. process+thread count | 2669 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1961/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1926: HBASE-24586 Add table level locality in table.jsp
Apache-HBase commented on pull request #1926: URL: https://github.com/apache/hbase/pull/1926#issuecomment-655883771 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | prototool | 0m 0s | prototool was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 45s | master passed | | +1 :green_heart: | checkstyle | 1m 46s | master passed | | +1 :green_heart: | spotbugs | 6m 33s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 28s | the patch passed | | +1 :green_heart: | checkstyle | 1m 42s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 53s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | hbaseprotoc | 2m 21s | the patch passed | | +1 :green_heart: | spotbugs | 8m 26s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 39s | The patch does not generate ASF License warnings. | | | | 51m 34s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1926/5/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1926 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle cc hbaseprotoc prototool | | uname | Linux c76179ce0151 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 1db89773e6 | | Max. process+thread count | 94 (vs. ulimit of 12500) | | modules | C: hbase-protocol-shaded hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1926/5/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2034: Backport "HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length. (#1970)" to branch-2
Apache-HBase commented on pull request #2034: URL: https://github.com/apache/hbase/pull/2034#issuecomment-655882761 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 50s | branch-2 passed | | +1 :green_heart: | checkstyle | 1m 27s | branch-2 passed | | +1 :green_heart: | spotbugs | 2m 36s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 29s | the patch passed | | +1 :green_heart: | checkstyle | 0m 11s | The patch passed checkstyle in hbase-asyncfs | | +1 :green_heart: | checkstyle | 1m 13s | hbase-server: The patch generated 0 new + 46 unchanged - 3 fixed = 46 total (was 49) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 12m 23s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 2m 55s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 21s | The patch does not generate ASF License warnings. | | | | 37m 18s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2034/4/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2034 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 7c9485586489 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 5fcffae5db | | Max. process+thread count | 84 (vs. ulimit of 12500) | | modules | C: hbase-asyncfs hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2034/4/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24625) AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length.
[
https://issues.apache.org/jira/browse/HBASE-24625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17154159#comment-17154159
]
chenglei commented on HBASE-24625:
--
[~zhangduo], could you please help me review the
[PR#2034|https://github.com/apache/hbase/pull/2034] for branch-2 ? The
{{TestWALEntryStream}} is passed.
> AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced
> file length.
>
>
> Key: HBASE-24625
> URL: https://issues.apache.org/jira/browse/HBASE-24625
> Project: HBase
> Issue Type: Bug
> Components: Replication, wal
>Affects Versions: 2.1.0, 2.0.0, 2.2.0, 2.3.0
>Reporter: chenglei
>Assignee: chenglei
>Priority: Critical
> Fix For: 3.0.0-alpha-1, 2.3.1, 2.2.6
>
>
> By HBASE-14004, we introduce {{WALFileLengthProvider}} interface to keep the
> current writing wal file length by ourselves, {{WALEntryStream}} used by
> {{ReplicationSourceWALReader}} could only read WAL file byte size <=
> {{WALFileLengthProvider.getLogFileSizeIfBeingWritten}} if the WAL file is
> current been writing on the same RegionServer .
> {{AsyncFSWAL}} implements {{WALFileLengthProvider}} by
> {{AbstractFSWAL.getLogFileSizeIfBeingWritten}}, just as folllows :
> {code:java}
>public OptionalLong getLogFileSizeIfBeingWritten(Path path) {
> rollWriterLock.lock();
> try {
> Path currentPath = getOldPath();
> if (path.equals(currentPath)) {
> W writer = this.writer;
> return writer != null ? OptionalLong.of(writer.getLength()) :
> OptionalLong.empty();
> } else {
> return OptionalLong.empty();
> }
> } finally {
> rollWriterLock.unlock();
> }
> }
> {code}
> For {{AsyncFSWAL}}, above {{AsyncFSWAL.writer}} is
> {{AsyncProtobufLogWriter}} ，and {{AsyncProtobufLogWriter.getLength}} is as
> follows:
> {code:java}
> public long getLength() {
> return length.get();
> }
> {code}
> But for {{AsyncProtobufLogWriter}}, any append method may increase the above
> {{AsyncProtobufLogWriter.length}}, especially for following
> {{AsyncFSWAL.append}}
> method just appending the {{WALEntry}} to
> {{FanOutOneBlockAsyncDFSOutput.buf}}:
> {code:java}
> public void append(Entry entry) {
> int buffered = output.buffered();
> try {
> entry.getKey().
>
> getBuilder(compressor).setFollowingKvCount(entry.getEdit().size()).build()
> .writeDelimitedTo(asyncOutputWrapper);
> } catch (IOException e) {
> throw new AssertionError("should not happen", e);
> }
>
> try {
>for (Cell cell : entry.getEdit().getCells()) {
> cellEncoder.write(cell);
>}
> } catch (IOException e) {
>throw new AssertionError("should not happen", e);
> }
> length.addAndGet(output.buffered() - buffered);
> }
> {code}
> That is to say, {{AsyncFSWAL.getLogFileSizeIfBeingWritten}} could not reflect
> the file length which successfully synced to underlying HDFS, which is not
> as expected.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24698) Turn OFF Canary WebUI as default
[ https://issues.apache.org/jira/browse/HBASE-24698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17154156#comment-17154156 ] Duo Zhang commented on HBASE-24698: --- I could have a try to see if it is possible... Netty is a bit raw but we still uses jsp... > Turn OFF Canary WebUI as default > > > Key: HBASE-24698 > URL: https://issues.apache.org/jira/browse/HBASE-24698 > Project: HBase > Issue Type: Sub-task > Components: canary >Reporter: Michael Stack >Assignee: Michael Stack >Priority: Major > > See parent issue. There is a CLASSPATH issue when running against hadoop3 > that needs resolving. Meantime, the canary fails to run with a cryptic > message. This will surprise operators. Let me make it so you ask for the > canary webui; by default, it does not come up. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24698) Turn OFF Canary WebUI as default
[ https://issues.apache.org/jira/browse/HBASE-24698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17154154#comment-17154154 ] Michael Stack commented on HBASE-24698: --- [~zhangduo] it would make our life easier. Is there one? > Turn OFF Canary WebUI as default > > > Key: HBASE-24698 > URL: https://issues.apache.org/jira/browse/HBASE-24698 > Project: HBase > Issue Type: Sub-task > Components: canary >Reporter: Michael Stack >Assignee: Michael Stack >Priority: Major > > See parent issue. There is a CLASSPATH issue when running against hadoop3 > that needs resolving. Meantime, the canary fails to run with a cryptic > message. This will surprise operators. Let me make it so you ask for the > canary webui; by default, it does not come up. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] bsglz commented on a change in pull request #1926: HBASE-24586 Add table level locality in table.jsp
bsglz commented on a change in pull request #1926:
URL: https://github.com/apache/hbase/pull/1926#discussion_r451936485
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/HDFSBlocksDistribution.java
##
@@ -228,33 +228,49 @@ public long getUniqueBlocksTotalWeight() {
* Implementations 'visit' hostAndWeight.
*/
public interface Visitor {
-float visit(final HostAndWeight hostAndWeight);
+long visit(final HostAndWeight hostAndWeight);
}
/**
* @param host the host name
* @return the locality index of the given host
*/
public float getBlockLocalityIndex(String host) {
-return getBlockLocalityIndexInternal(host,
- e -> (float) e.weight / (float) uniqueBlocksTotalWeight);
+return (float) getBlocksLocalityWeightInternal(host, e -> e.weight)
Review comment:
Fixed.
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/HDFSBlocksDistribution.java
##
@@ -228,33 +228,49 @@ public long getUniqueBlocksTotalWeight() {
* Implementations 'visit' hostAndWeight.
*/
public interface Visitor {
-float visit(final HostAndWeight hostAndWeight);
+long visit(final HostAndWeight hostAndWeight);
}
/**
* @param host the host name
* @return the locality index of the given host
*/
public float getBlockLocalityIndex(String host) {
-return getBlockLocalityIndexInternal(host,
- e -> (float) e.weight / (float) uniqueBlocksTotalWeight);
+return (float) getBlocksLocalityWeightInternal(host, e -> e.weight)
+ / (float) uniqueBlocksTotalWeight;
}
/**
* @param host the host name
* @return the locality index with ssd of the given host
*/
public float getBlockLocalityIndexForSsd(String host) {
-return getBlockLocalityIndexInternal(host,
- e -> (float) e.weightForSsd / (float) uniqueBlocksTotalWeight);
+return (float) getBlocksLocalityWeightInternal(host, e -> e.weightForSsd)
Review comment:
Fixed.
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/HDFSBlocksDistribution.java
##
@@ -228,33 +228,49 @@ public long getUniqueBlocksTotalWeight() {
* Implementations 'visit' hostAndWeight.
*/
public interface Visitor {
-float visit(final HostAndWeight hostAndWeight);
+long visit(final HostAndWeight hostAndWeight);
}
/**
* @param host the host name
* @return the locality index of the given host
*/
public float getBlockLocalityIndex(String host) {
-return getBlockLocalityIndexInternal(host,
- e -> (float) e.weight / (float) uniqueBlocksTotalWeight);
+return (float) getBlocksLocalityWeightInternal(host, e -> e.weight)
+ / (float) uniqueBlocksTotalWeight;
}
/**
* @param host the host name
* @return the locality index with ssd of the given host
*/
public float getBlockLocalityIndexForSsd(String host) {
-return getBlockLocalityIndexInternal(host,
- e -> (float) e.weightForSsd / (float) uniqueBlocksTotalWeight);
+return (float) getBlocksLocalityWeightInternal(host, e -> e.weightForSsd)
+ / (float) uniqueBlocksTotalWeight;
+ }
+
+ /**
+ * @param host the host name
+ * @return the blocks local weight of the given host
+ */
+ public long getBlocksLocalWeight(String host) {
+return getBlocksLocalityWeightInternal(host, e -> e.weight);
Review comment:
Fixed.
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/HDFSBlocksDistribution.java
##
@@ -228,33 +228,49 @@ public long getUniqueBlocksTotalWeight() {
* Implementations 'visit' hostAndWeight.
*/
public interface Visitor {
-float visit(final HostAndWeight hostAndWeight);
+long visit(final HostAndWeight hostAndWeight);
}
/**
* @param host the host name
* @return the locality index of the given host
*/
public float getBlockLocalityIndex(String host) {
-return getBlockLocalityIndexInternal(host,
- e -> (float) e.weight / (float) uniqueBlocksTotalWeight);
+return (float) getBlocksLocalityWeightInternal(host, e -> e.weight)
+ / (float) uniqueBlocksTotalWeight;
}
/**
* @param host the host name
* @return the locality index with ssd of the given host
*/
public float getBlockLocalityIndexForSsd(String host) {
-return getBlockLocalityIndexInternal(host,
- e -> (float) e.weightForSsd / (float) uniqueBlocksTotalWeight);
+return (float) getBlocksLocalityWeightInternal(host, e -> e.weightForSsd)
+ / (float) uniqueBlocksTotalWeight;
+ }
+
+ /**
+ * @param host the host name
+ * @return the blocks local weight of the given host
+ */
+ public long getBlocksLocalWeight(String host) {
+return getBlocksLocalityWeightInternal(host, e -> e.weight);
+ }
+
+ /**
+ * @param host the host name
+ * @return the blocks local with ssd weight of the given host
+ */
+ public long getBlocksLocalWithSsdWeight(String host)
[GitHub] [hbase] Apache-HBase commented on pull request #2037: HBASE-24698 Turn OFF Canary WebUI as default
Apache-HBase commented on pull request #2037: URL: https://github.com/apache/hbase/pull/2037#issuecomment-655864619 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 24s | Docker mode activated. | | -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2.3 Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 45s | branch-2.3 passed | | +1 :green_heart: | compile | 1m 12s | branch-2.3 passed | | +1 :green_heart: | shadedjars | 6m 29s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 43s | hbase-server in branch-2.3 failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 22s | the patch passed | | +1 :green_heart: | compile | 1m 10s | the patch passed | | +1 :green_heart: | javac | 1m 10s | the patch passed | | +1 :green_heart: | shadedjars | 6m 23s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 40s | hbase-server in the patch failed. | ||| _ Other Tests _ | | -1 :x: | unit | 194m 45s | hbase-server in the patch failed. | | | | 223m 51s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2037/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2037 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 76c31cee0e06 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.3 / 53690d01e2 | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2037/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2037/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2037/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2037/1/testReport/ | | Max. process+thread count | 2380 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2037/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2037: HBASE-24698 Turn OFF Canary WebUI as default
Apache-HBase commented on pull request #2037: URL: https://github.com/apache/hbase/pull/2037#issuecomment-655864516 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 8s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2.3 Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 58s | branch-2.3 passed | | +1 :green_heart: | compile | 0m 58s | branch-2.3 passed | | +1 :green_heart: | shadedjars | 5m 31s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 37s | branch-2.3 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 33s | the patch passed | | +1 :green_heart: | compile | 0m 56s | the patch passed | | +1 :green_heart: | javac | 0m 56s | the patch passed | | +1 :green_heart: | shadedjars | 5m 26s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 36s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 198m 52s | hbase-server in the patch passed. | | | | 223m 29s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2037/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2037 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 65758d3898fd 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.3 / 53690d01e2 | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2037/1/testReport/ | | Max. process+thread count | 2521 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2037/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bsglz commented on a change in pull request #1926: HBASE-24586 Add table level locality in table.jsp
bsglz commented on a change in pull request #1926:
URL: https://github.com/apache/hbase/pull/1926#discussion_r451932811
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/HDFSBlocksDistribution.java
##
@@ -228,33 +228,49 @@ public long getUniqueBlocksTotalWeight() {
* Implementations 'visit' hostAndWeight.
Review comment:
Goop point.
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/HDFSBlocksDistribution.java
##
@@ -228,33 +228,49 @@ public long getUniqueBlocksTotalWeight() {
* Implementations 'visit' hostAndWeight.
Review comment:
Good point.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] bsglz commented on a change in pull request #1926: HBASE-24586 Add table level locality in table.jsp
bsglz commented on a change in pull request #1926:
URL: https://github.com/apache/hbase/pull/1926#discussion_r451932583
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/HDFSBlocksDistribution.java
##
@@ -228,33 +228,49 @@ public long getUniqueBlocksTotalWeight() {
* Implementations 'visit' hostAndWeight.
*/
public interface Visitor {
-float visit(final HostAndWeight hostAndWeight);
+long visit(final HostAndWeight hostAndWeight);
Review comment:
Just thought we need fetch original value now, change it to long will
more flexbility.
Thanks.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (HBASE-24698) Turn OFF Canary WebUI as default
[ https://issues.apache.org/jira/browse/HBASE-24698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17154146#comment-17154146 ] Duo Zhang commented on HBASE-24698: --- Was wondering whether we should just implement our own http server with netty, so we do not need to depend on jetty any more... > Turn OFF Canary WebUI as default > > > Key: HBASE-24698 > URL: https://issues.apache.org/jira/browse/HBASE-24698 > Project: HBase > Issue Type: Sub-task > Components: canary >Reporter: Michael Stack >Assignee: Michael Stack >Priority: Major > > See parent issue. There is a CLASSPATH issue when running against hadoop3 > that needs resolving. Meantime, the canary fails to run with a cryptic > message. This will surprise operators. Let me make it so you ask for the > canary webui; by default, it does not come up. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache9 commented on a change in pull request #2037: HBASE-24698 Turn OFF Canary WebUI as default
Apache9 commented on a change in pull request #2037:
URL: https://github.com/apache/hbase/pull/2037#discussion_r451927555
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/tool/CanaryTool.java
##
@@ -128,14 +124,8 @@
public class CanaryTool implements Tool, Canary {
public static final String HBASE_CANARY_INFO_PORT = "hbase.canary.info.port";
- public static final int DEFAULT_CANARY_INFOPORT = 16050;
-
- public static final String HBASE_CANARY_INFO_BINDADDRESS =
"hbase.canary.info.bindAddress";
Review comment:
Why removing the static final declaration and use the string literal
directly?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] bsglz edited a comment on pull request #2032: HBASE-24404 Support flush a single column family of region
bsglz edited a comment on pull request #2032: URL: https://github.com/apache/hbase/pull/2032#issuecomment-655856810 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bsglz commented on pull request #2032: HBASE-24404 Support flush a single column family of region
bsglz commented on pull request #2032: URL: https://github.com/apache/hbase/pull/2032#issuecomment-655856810 The javadoc issues also exist in master, is this a bug of jdk-11? See https://bugs.openjdk.java.net/browse/JDK-8212233. There is a workaround in project commons-pool, can we do as same way? https://github.com/apache/commons-pool/blob/master/pom.xml ``` java11+ [11,) true ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ddupg commented on pull request #2026: HBASE-22738 Fallback to default group to choose RS when there are no …
ddupg commented on pull request #2026: URL: https://github.com/apache/hbase/pull/2026#issuecomment-655855385 > The target branch should be branch-2, not branch-2.3? OK, close this PR and open new one to branch-2. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ddupg closed pull request #2026: HBASE-22738 Fallback to default group to choose RS when there are no …
ddupg closed pull request #2026: URL: https://github.com/apache/hbase/pull/2026 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Joseph295 commented on a change in pull request #2035: HBASE-24663 Add procedure process time statistics UI
Joseph295 commented on a change in pull request #2035: URL: https://github.com/apache/hbase/pull/2035#discussion_r451923319 ## File path: hbase-metrics-api/src/main/java/org/apache/hadoop/hbase/metrics/Histogram.java ## @@ -55,4 +55,10 @@ @InterfaceAudience.Private Snapshot snapshot(); + long[] getQuantiles(double[] quantiles); Review comment: snapshot() will be better, but the implementation will reset the data before, which makes no senses for histogram metrics. I haven't gotten the reason.Another thing is the interfaces in Histogram are not enough? There are getMin, getMax, usually we need quantiles? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-11288) Splittable Meta
[
https://issues.apache.org/jira/browse/HBASE-11288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17154128#comment-17154128
]
Duo Zhang commented on HBASE-11288:
---
{quote}
Given that “General Root Table” has proven itself in BigTable and other clones
(eg Accumulo AFAIK).
{quote}
Bigtable is designed way back in 2006, not everything in BigTable is correct.
And they do not give us their code so we do not know their framework on how to
deal with tablet assignment and tablet server crash. What we have for now is
procedure v2 in HBase, so our discussion should based on procedure v2. If you
have other better solution, please file another issue to replace procedure v2
and then we go back here.
And this is not only about adding another tier, how do you plan to distribute
the load of the general root table? Region replica is not stable enough, for
years.
{quote}
For validation, my understanding is we use ITBLL to test wether the current
1-tier assignment is working properly or not, why don’t we try and run ITBLL on
the “General Root Table” POC to investigate and validate the 2-tier assignment
concern? Thoughts?
{quote}
This suggestion is weak. I'm afraid after running ITBLL we will sit here again
to argue that, 'This is only a POC, do not focus on polishing'. But from my
understanding, ITBLL is for polishing. We should have a clear design, and a
clean code, and then we use ITBLL to find out the corner cases to polish our
code, make it more robust.
And I want to know you opinion on 'master local region'. I've explain that,
with caching servers, master will not be on the critical path of normal client
read/write. Client just go to the cache servers, which is similar to read
replicas feature, but much easier to implement and more stable. Are there any
other concerns about this solution?
Thanks.
> Splittable Meta
> ---
>
> Key: HBASE-11288
> URL: https://issues.apache.org/jira/browse/HBASE-11288
> Project: HBase
> Issue Type: Umbrella
> Components: meta
>Reporter: Francis Christopher Liu
>Assignee: Francis Christopher Liu
>Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-16212) Many connections to datanode are created when doing a large scan
[ https://issues.apache.org/jira/browse/HBASE-16212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17154114#comment-17154114 ] Liu Zheng commented on HBASE-16212: --- this issue seems to be reproduced in version hbase 1.5.0: 2020-07-09 09:13:24,744 ERROR org.apache.hadoop.hdfs.server.datanode.DataNode: BlockSender.sendChunks() exception: java.io.IOException: 连接被对方重设 at sun.nio.ch.FileChannelImpl.transferTo0(Native Method) at sun.nio.ch.FileChannelImpl.transferToDirectlyInternal(FileChannelImpl.java:428) at sun.nio.ch.FileChannelImpl.transferToDirectly(FileChannelImpl.java:493) at sun.nio.ch.FileChannelImpl.transferTo(FileChannelImpl.java:605) at org.apache.hadoop.net.SocketOutputStream.transferToFully(SocketOutputStream.java:223) at org.apache.hadoop.hdfs.server.datanode.BlockSender.sendPacket(BlockSender.java:647) at org.apache.hadoop.hdfs.server.datanode.BlockSender.doSendBlock(BlockSender.java:830) at org.apache.hadoop.hdfs.server.datanode.BlockSender.sendBlock(BlockSender.java:778) at org.apache.hadoop.hdfs.server.datanode.DataXceiver.readBlock(DataXceiver.java:594) at org.apache.hadoop.hdfs.protocol.datatransfer.Receiver.opReadBlock(Receiver.java:145) at org.apache.hadoop.hdfs.protocol.datatransfer.Receiver.processOp(Receiver.java:100) at org.apache.hadoop.hdfs.server.datanode.DataXceiver.run(DataXceiver.java:288) at java.lang.Thread.run(Thread.java:748) > Many connections to datanode are created when doing a large scan > - > > Key: HBASE-16212 > URL: https://issues.apache.org/jira/browse/HBASE-16212 > Project: HBase > Issue Type: Improvement >Affects Versions: 1.1.2 >Reporter: Zhihua Deng >Priority: Major > Attachments: HBASE-16212.patch, HBASE-16212.v2.patch > > > As described in https://issues.apache.org/jira/browse/HDFS-8659, the datanode > is suffering from logging the same repeatedly. Adding log to DFSInputStream, > it outputs as follows: > 2016-07-10 21:31:42,147 INFO > [B.defaultRpcServer.handler=22,queue=1,port=16020] hdfs.DFSClient: > DFSClient_NONMAPREDUCE_1984924661_1 seek > DatanodeInfoWithStorage[10.130.1.29:50010,DS-086bc494-d862-470c-86e8-9cb7929985c6,DISK] > for BP-360285305-10.130.1.11-1444619256876:blk_1109360829_35627143. pos: > 111506876, targetPos: 111506843 > ... > As the pos of this input stream is larger than targetPos(the pos trying to > seek), A new connection to the datanode will be created, the older one will > be closed as a consequence. When the wrong seeking ops are large, the > datanode's block scanner info message is spamming logs, as well as many > connections to the same datanode will be created. > hadoop version: 2.7.1 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-11288) Splittable Meta
[ https://issues.apache.org/jira/browse/HBASE-11288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17154103#comment-17154103 ] Francis Christopher Liu commented on HBASE-11288: - Thanks for you response Duo. So it sounds to me the main reason for going with the “Root table on master” implementation is because of the strong disagreement towards the “General Root Table” implementation in particular the fact that it adds another tier in assignment. Given that “General Root Table” has proven itself in BigTable and other clones (eg Accumulo AFAIK). The concern it seems is specific to HBase’s implementation, there is a strong concern that we might fail again at getting it to work. Correct me if I’m wrong here. Regardless of which implementation the addition of split meta will not only be a significant change to HBase but also something that we will likely be living with for quite a while. Because of that I am proposing that we apply some rigor on deciding which implementation we will go with. My current thinking is given that the main reason it seems for picking “Root table on master” is because we want to avoid failing at tiering again, why don’t we come up with a way to validate that assertion? IMHO the situation now and then are very different especially with the addition of ProcV2 and the revamped Assignment. For validation, my understanding is we use ITBLL to test wether the current 1-tier assignment is working properly or not, why don’t we try and run ITBLL on the “General Root Table” POC to investigate and validate the 2-tier assignment concern? Thoughts? > Splittable Meta > --- > > Key: HBASE-11288 > URL: https://issues.apache.org/jira/browse/HBASE-11288 > Project: HBase > Issue Type: Umbrella > Components: meta >Reporter: Francis Christopher Liu >Assignee: Francis Christopher Liu >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] infraio edited a comment on pull request #1935: HBASE-22146 SpaceQuotaViolationPolicy Disable is not working in Names…
infraio edited a comment on pull request #1935: URL: https://github.com/apache/hbase/pull/1935#issuecomment-655827442 > My change removes these QUOTA_FAMILY_USAGE column family for the tables when a namespace quota is deleted and allows the user to insert into the tables in the namespace when the violated space quota is removed. Got it. But I thought you should fix the problem not in QuotaUtil class, maybe in MasterQuotaManager? Keep QuotaUtil simple and fix this in upper layer. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] infraio commented on pull request #1935: HBASE-22146 SpaceQuotaViolationPolicy Disable is not working in Names…
infraio commented on pull request #1935: URL: https://github.com/apache/hbase/pull/1935#issuecomment-655827442 > My change removes these QUOTA_FAMILY_USAGE column family for the tables when a namespace quota is deleted and allows the user to insert into the tables in the namespace when the violated space quota is removed. Got it. But I thought you should fix the problem not in QuotaUtil class, maybe in MasterQuotaManager? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1961: HBASE-24623 SIGSEGV v ~StubRoutines::jbyte_disjoint_arraycopy
Apache-HBase commented on pull request #1961: URL: https://github.com/apache/hbase/pull/1961#issuecomment-655827239 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 0s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 53s | branch-2 passed | | +1 :green_heart: | checkstyle | 2m 2s | branch-2 passed | | +1 :green_heart: | spotbugs | 3m 13s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 25s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 0s | the patch passed | | -0 :warning: | checkstyle | 1m 27s | hbase-server: The patch generated 1 new + 45 unchanged - 20 fixed = 46 total (was 65) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 15m 16s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 3m 36s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 25s | The patch does not generate ASF License warnings. | | | | 47m 40s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1961/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1961 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 60fe75950f7d 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 5fcffae5db | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1961/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 84 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1961/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] infraio commented on a change in pull request #2035: HBASE-24663 Add procedure process time statistics UI
infraio commented on a change in pull request #2035: URL: https://github.com/apache/hbase/pull/2035#discussion_r451893191 ## File path: hbase-metrics-api/src/main/java/org/apache/hadoop/hbase/metrics/Histogram.java ## @@ -55,4 +55,10 @@ @InterfaceAudience.Private Snapshot snapshot(); + long[] getQuantiles(double[] quantiles); Review comment: Do we have to change this interface? This is IA.LimitedPrivate. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2037: HBASE-24698 Turn OFF Canary WebUI as default
Apache-HBase commented on pull request #2037: URL: https://github.com/apache/hbase/pull/2037#issuecomment-655813572 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2.3 Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 38s | branch-2.3 passed | | +1 :green_heart: | checkstyle | 1m 8s | branch-2.3 passed | | +1 :green_heart: | spotbugs | 1m 55s | branch-2.3 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 11s | the patch passed | | +1 :green_heart: | checkstyle | 1m 6s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 16m 53s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 2m 6s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 15s | The patch does not generate ASF License warnings. | | | | 37m 54s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2037/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2037 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 563d4171c434 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.3 / 53690d01e2 | | Max. process+thread count | 94 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2037/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] skochhar commented on a change in pull request #1935: HBASE-22146 SpaceQuotaViolationPolicy Disable is not working in Names…
skochhar commented on a change in pull request #1935:
URL: https://github.com/apache/hbase/pull/1935#discussion_r447974191
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/namespace/NamespaceAuditor.java
##
@@ -18,6 +18,7 @@
package org.apache.hadoop.hbase.namespace;
import java.io.IOException;
+import java.util.Set;
Review comment:
Good catch Sakthi, I will remove the import
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/QuotaUtil.java
##
@@ -264,17 +265,33 @@ private static void deleteQuotas(final Connection
connection, final byte[] rowKe
final byte[] qualifier) throws IOException {
Delete delete = new Delete(rowKey);
if (qualifier != null) {
- delete.addColumns(QUOTA_FAMILY_INFO, qualifier);
+ if (Arrays.equals(qualifier,QUOTA_QUALIFIER_POLICY)) {
+delete.addColumns(QUOTA_FAMILY_USAGE, qualifier);
+ } else
+delete.addColumns(QUOTA_FAMILY_INFO, qualifier);
}
-doDelete(connection, delete);
if (isNamespaceRowKey(rowKey)) {
- TableName[] tableArray =
connection.getAdmin().listTableNamesByNamespace(getNamespaceFromRowKey(rowKey));
- for (TableName tableName: tableArray) {
-if (QuotaUtil.getTableQuota(connection, tableName) == null) {
- deleteTableQuota(connection,tableName);
+ //Check namespace is not deleted before you get info about quota and
list of tables in namespace
+ NamespaceDescriptor[] descs =
connection.getAdmin().listNamespaceDescriptors();
+ String ns = getNamespaceFromRowKey(rowKey);
+ int index = 0;
+ while (index < descs.length) {
+if (ns.equals(descs[index].getName())) {
+ Quotas namespaceQuota = getNamespaceQuota(connection,ns);
+ if (namespaceQuota != null && namespaceQuota.hasSpace()) {
+TableName[] tableArray =
connection.getAdmin().listTableNamesByNamespace(ns);
+for (TableName tableName : tableArray) {
+ deleteQuotas(connection, getTableRowKey(tableName),
QUOTA_QUALIFIER_POLICY);
+}
+ }
+ //Exit the while loop by moving to last index
+ index = descs.length;
+} else {
+ index++;
}
}
}
+doDelete(connection, delete);
Review comment:
> What would happen if we get an exception trying to delete a quota? Would
it be necessary to retry the operation again?
Thanks for reviewing Esteban.
I am doing null checks everywhere to avoid NPEs. I tested this code with a
namespace quota on a namespace both without any tables, and with tables and the
code worked fine.
I see that in line 282 connection.getAdmin().listTableNamesByNamespace(ns)
can throw IOException. I can add try-catch around my new code to avoid the
final doDelete() for the namespace getting impacted from any exception in the
new code.
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/QuotaUtil.java
##
@@ -264,17 +265,33 @@ private static void deleteQuotas(final Connection
connection, final byte[] rowKe
final byte[] qualifier) throws IOException {
Delete delete = new Delete(rowKey);
if (qualifier != null) {
- delete.addColumns(QUOTA_FAMILY_INFO, qualifier);
+ if (Arrays.equals(qualifier,QUOTA_QUALIFIER_POLICY)) {
+delete.addColumns(QUOTA_FAMILY_USAGE, qualifier);
+ } else
+delete.addColumns(QUOTA_FAMILY_INFO, qualifier);
}
-doDelete(connection, delete);
if (isNamespaceRowKey(rowKey)) {
- TableName[] tableArray =
connection.getAdmin().listTableNamesByNamespace(getNamespaceFromRowKey(rowKey));
- for (TableName tableName: tableArray) {
-if (QuotaUtil.getTableQuota(connection, tableName) == null) {
- deleteTableQuota(connection,tableName);
+ //Check namespace is not deleted before you get info about quota and
list of tables in namespace
+ NamespaceDescriptor[] descs =
connection.getAdmin().listNamespaceDescriptors();
+ String ns = getNamespaceFromRowKey(rowKey);
+ int index = 0;
+ while (index < descs.length) {
+if (ns.equals(descs[index].getName())) {
+ Quotas namespaceQuota = getNamespaceQuota(connection,ns);
+ if (namespaceQuota != null && namespaceQuota.hasSpace()) {
+TableName[] tableArray =
connection.getAdmin().listTableNamesByNamespace(ns);
+for (TableName tableName : tableArray) {
+ deleteQuotas(connection, getTableRowKey(tableName),
QUOTA_QUALIFIER_POLICY);
+}
+ }
+ //Exit the while loop by moving to last index
+ index = descs.length;
+} else {
+ index++;
}
}
}
+doDelete(connection, delete);
Review comment:
I checked more usages of this method and other files where
getAdmin().listTableNamesByNamespace(ns) is used and in case of error they
[jira] [Commented] (HBASE-23994) Add WebUI to Canary
[
https://issues.apache.org/jira/browse/HBASE-23994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17154088#comment-17154088
]
Michael Stack commented on HBASE-23994:
---
Filed sub-issue HBASE-24698 to turn off this feature by default.
> Add WebUI to Canary
>
>
> Key: HBASE-23994
> URL: https://issues.apache.org/jira/browse/HBASE-23994
> Project: HBase
> Issue Type: Improvement
> Components: canary, UI, Usability
>Affects Versions: 3.0.0-alpha-1
>Reporter: Zhuoyue Huang
>Assignee: Zhuoyue Huang
>Priority: Trivial
> Fix For: 3.0.0-alpha-1, 2.3.0
>
> Attachments: image-2020-03-16-09-12-00-595.png
>
>
> During the running of Canary, the table sniff failure information will be
> printed through the Log.
> {code:java}
> LOG.error("Read from {} on {}", table, server);
> {code}
>
> I think we can use WebUI to display these failures to make it easier for us
> to view this information
>
> !image-2020-03-16-09-12-00-595.png!
> As shown in the figure above, we can directly see the Table and Regionserver
> where the error occurred
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] saintstack opened a new pull request #2037: HBASE-24698 Turn OFF Canary WebUI as default
saintstack opened a new pull request #2037: URL: https://github.com/apache/hbase/pull/2037 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (HBASE-24700) Turn OFF Canary WebUI as default
[ https://issues.apache.org/jira/browse/HBASE-24700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-24700. --- Resolution: Duplicate Duplicate of HBASE-24698 > Turn OFF Canary WebUI as default > > > Key: HBASE-24700 > URL: https://issues.apache.org/jira/browse/HBASE-24700 > Project: HBase > Issue Type: Sub-task > Components: canary >Reporter: Michael Stack >Assignee: Michael Stack >Priority: Major > > See parent issue. There is a CLASSPATH issue when running against hadoop3 > that needs resolving. Meantime, the canary fails to run with a cryptic > message. This will surprise operators. Let me make it so you ask for the > canary webui; by default, it does not come up. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-24703) Turn OFF Canary WebUI as default
[ https://issues.apache.org/jira/browse/HBASE-24703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-24703. --- Resolution: Duplicate Duplicate of HBASE-24698 > Turn OFF Canary WebUI as default > > > Key: HBASE-24703 > URL: https://issues.apache.org/jira/browse/HBASE-24703 > Project: HBase > Issue Type: Sub-task > Components: canary >Reporter: Michael Stack >Assignee: Michael Stack >Priority: Major > > See parent issue. There is a CLASSPATH issue when running against hadoop3 > that needs resolving. Meantime, the canary fails to run with a cryptic > message. This will surprise operators. Let me make it so you ask for the > canary webui; by default, it does not come up. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-24702) Turn OFF Canary WebUI as default
[ https://issues.apache.org/jira/browse/HBASE-24702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-24702. --- Resolution: Duplicate Duplicate of HBASE-24698 > Turn OFF Canary WebUI as default > > > Key: HBASE-24702 > URL: https://issues.apache.org/jira/browse/HBASE-24702 > Project: HBase > Issue Type: Sub-task > Components: canary >Reporter: Michael Stack >Assignee: Michael Stack >Priority: Major > > See parent issue. There is a CLASSPATH issue when running against hadoop3 > that needs resolving. Meantime, the canary fails to run with a cryptic > message. This will surprise operators. Let me make it so you ask for the > canary webui; by default, it does not come up. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-24701) Turn OFF Canary WebUI as default
[ https://issues.apache.org/jira/browse/HBASE-24701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-24701. --- Resolution: Duplicate Duplicate of HBASE-24698 > Turn OFF Canary WebUI as default > > > Key: HBASE-24701 > URL: https://issues.apache.org/jira/browse/HBASE-24701 > Project: HBase > Issue Type: Sub-task > Components: canary >Reporter: Michael Stack >Assignee: Michael Stack >Priority: Major > > See parent issue. There is a CLASSPATH issue when running against hadoop3 > that needs resolving. Meantime, the canary fails to run with a cryptic > message. This will surprise operators. Let me make it so you ask for the > canary webui; by default, it does not come up. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-24699) Turn OFF Canary WebUI as default
[ https://issues.apache.org/jira/browse/HBASE-24699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-24699. --- Resolution: Duplicate Duplicate of HBASE-24698 > Turn OFF Canary WebUI as default > > > Key: HBASE-24699 > URL: https://issues.apache.org/jira/browse/HBASE-24699 > Project: HBase > Issue Type: Sub-task > Components: canary >Reporter: Michael Stack >Assignee: Michael Stack >Priority: Major > > See parent issue. There is a CLASSPATH issue when running against hadoop3 > that needs resolving. Meantime, the canary fails to run with a cryptic > message. This will surprise operators. Let me make it so you ask for the > canary webui; by default, it does not come up. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-24703) Turn OFF Canary WebUI as default
Michael Stack created HBASE-24703: - Summary: Turn OFF Canary WebUI as default Key: HBASE-24703 URL: https://issues.apache.org/jira/browse/HBASE-24703 Project: HBase Issue Type: Sub-task Components: canary Reporter: Michael Stack Assignee: Michael Stack See parent issue. There is a CLASSPATH issue when running against hadoop3 that needs resolving. Meantime, the canary fails to run with a cryptic message. This will surprise operators. Let me make it so you ask for the canary webui; by default, it does not come up. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-24702) Turn OFF Canary WebUI as default
Michael Stack created HBASE-24702: - Summary: Turn OFF Canary WebUI as default Key: HBASE-24702 URL: https://issues.apache.org/jira/browse/HBASE-24702 Project: HBase Issue Type: Sub-task Components: canary Reporter: Michael Stack Assignee: Michael Stack See parent issue. There is a CLASSPATH issue when running against hadoop3 that needs resolving. Meantime, the canary fails to run with a cryptic message. This will surprise operators. Let me make it so you ask for the canary webui; by default, it does not come up. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-24701) Turn OFF Canary WebUI as default
Michael Stack created HBASE-24701: - Summary: Turn OFF Canary WebUI as default Key: HBASE-24701 URL: https://issues.apache.org/jira/browse/HBASE-24701 Project: HBase Issue Type: Sub-task Components: canary Reporter: Michael Stack Assignee: Michael Stack See parent issue. There is a CLASSPATH issue when running against hadoop3 that needs resolving. Meantime, the canary fails to run with a cryptic message. This will surprise operators. Let me make it so you ask for the canary webui; by default, it does not come up. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-24700) Turn OFF Canary WebUI as default
Michael Stack created HBASE-24700: - Summary: Turn OFF Canary WebUI as default Key: HBASE-24700 URL: https://issues.apache.org/jira/browse/HBASE-24700 Project: HBase Issue Type: Sub-task Components: canary Reporter: Michael Stack Assignee: Michael Stack See parent issue. There is a CLASSPATH issue when running against hadoop3 that needs resolving. Meantime, the canary fails to run with a cryptic message. This will surprise operators. Let me make it so you ask for the canary webui; by default, it does not come up. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-24699) Turn OFF Canary WebUI as default
Michael Stack created HBASE-24699: - Summary: Turn OFF Canary WebUI as default Key: HBASE-24699 URL: https://issues.apache.org/jira/browse/HBASE-24699 Project: HBase Issue Type: Sub-task Components: canary Reporter: Michael Stack Assignee: Michael Stack See parent issue. There is a CLASSPATH issue when running against hadoop3 that needs resolving. Meantime, the canary fails to run with a cryptic message. This will surprise operators. Let me make it so you ask for the canary webui; by default, it does not come up. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-24698) Turn OFF Canary WebUI as default
Michael Stack created HBASE-24698: - Summary: Turn OFF Canary WebUI as default Key: HBASE-24698 URL: https://issues.apache.org/jira/browse/HBASE-24698 Project: HBase Issue Type: Sub-task Components: canary Reporter: Michael Stack Assignee: Michael Stack See parent issue. There is a CLASSPATH issue when running against hadoop3 that needs resolving. Meantime, the canary fails to run with a cryptic message. This will surprise operators. Let me make it so you ask for the canary webui; by default, it does not come up. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24650) Change the return types of the new checkAndMutate methods introduced in HBASE-8458
[
https://issues.apache.org/jira/browse/HBASE-24650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17154038#comment-17154038
]
Hudson commented on HBASE-24650:
Results for branch branch-2
[build #2740 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2740/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2740/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2740/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2740/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2740/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Change the return types of the new checkAndMutate methods introduced in
> HBASE-8458
> --
>
> Key: HBASE-24650
> URL: https://issues.apache.org/jira/browse/HBASE-24650
> Project: HBase
> Issue Type: Sub-task
> Components: Client
>Reporter: Toshihiro Suzuki
>Assignee: Toshihiro Suzuki
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.4.0
>
>
> To support CheckAndMutate with Increment/Append, the new checkAndMutate
> methods introduced in HBASE-8458 need to return the result of the specified
> Increment/Append operation in addition to a boolean value represents whether
> it's successful or not. Currently, the methods return only boolean value(s),
> so we need to change the return types of the methods. The methods are
> unreleased yet currently, so I think it's no problem to change the return
> types of the methods.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24431) RSGroupInfo add configuration map to store something extra
[
https://issues.apache.org/jira/browse/HBASE-24431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17154039#comment-17154039
]
Hudson commented on HBASE-24431:
Results for branch branch-2
[build #2740 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2740/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2740/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2740/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2740/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2740/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> RSGroupInfo add configuration map to store something extra
> --
>
> Key: HBASE-24431
> URL: https://issues.apache.org/jira/browse/HBASE-24431
> Project: HBase
> Issue Type: Improvement
> Components: rsgroup
>Affects Versions: 3.0.0-alpha-1
>Reporter: Sun Xin
>Assignee: Sun Xin
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.4.0
>
>
> Maybe we should add a _Map configuration_ into RSGroupInfo to
> store extra infomation.
> For example, we can store the minimum number of machines the group needs, in
> order to move machine into this group automatically.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2008: HBASE-24665 all wal of RegionGroupingProvider together roll
Apache-HBase commented on pull request #2008: URL: https://github.com/apache/hbase/pull/2008#issuecomment-655738875 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. | ||| _ branch-2.2 Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 29s | branch-2.2 passed | | +1 :green_heart: | compile | 0m 58s | branch-2.2 passed | | +1 :green_heart: | checkstyle | 1m 17s | branch-2.2 passed | | +1 :green_heart: | shadedjars | 4m 44s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 38s | branch-2.2 passed | | +0 :ok: | spotbugs | 3m 27s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 3m 26s | branch-2.2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 56s | the patch passed | | +1 :green_heart: | compile | 1m 0s | the patch passed | | +1 :green_heart: | javac | 1m 0s | the patch passed | | -1 :x: | checkstyle | 1m 18s | hbase-server: The patch generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 4m 15s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 26m 4s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 2.10.0 or 3.1.2 3.2.1. | | +1 :green_heart: | javadoc | 0m 36s | the patch passed | | +1 :green_heart: | findbugs | 3m 28s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 148m 44s | hbase-server in the patch passed. | | +1 :green_heart: | asflicense | 0m 37s | The patch does not generate ASF License warnings. | | | | 214m 27s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2008/4/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2008 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 9925d2079c1e 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-2008/out/precommit/personality/provided.sh | | git revision | branch-2.2 / 160c2290bf | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2008/4/artifact/out/diff-checkstyle-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2008/4/testReport/ | | Max. process+thread count | 4341 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2008/4/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (HBASE-24697) Source checksum is missing from web ui
Nick Dimiduk created HBASE-24697: Summary: Source checksum is missing from web ui Key: HBASE-24697 URL: https://issues.apache.org/jira/browse/HBASE-24697 Project: HBase Issue Type: Bug Components: UI Affects Versions: 2.3.0 Reporter: Nick Dimiduk The web ui has a "Software Attribute" section with a table entry called "HBase Source Checksum", supposed to be a sha512 checksum according to the description. Instead, the value is just "(stdin)=". -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-24696) Include JVM information on Web UI under "Software Attributes"
Nick Dimiduk created HBASE-24696: Summary: Include JVM information on Web UI under "Software Attributes" Key: HBASE-24696 URL: https://issues.apache.org/jira/browse/HBASE-24696 Project: HBase Issue Type: Improvement Components: UI Reporter: Nick Dimiduk It's a small thing, but seems like an omission. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23600) Improve chances of edits landing into hbase:meta even when high load
[ https://issues.apache.org/jira/browse/HBASE-23600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17153849#comment-17153849 ] Michael Stack commented on HBASE-23600: --- Follow-up. I didn't get far w/ this patch; was unable to see much difference. Needs more work. Perhaps better route would be putting up a port for metadata only so Master writes to hbase:meta always land? > Improve chances of edits landing into hbase:meta even when high load > > > Key: HBASE-23600 > URL: https://issues.apache.org/jira/browse/HBASE-23600 > Project: HBase > Issue Type: Improvement > Components: rpc >Reporter: Michael Stack >Priority: Major > Attachments: priority.rpc.patch > > > Of late I've been testing clusters under high load to study failures and to > figure how to effect recovery if cluster is unable to recover on its own. > One interesting case is a RS that is struggling mostly because writes to HDFS > are backed up and sync calls are running very slow taking a long time to > complete. The RPC backs up with waiting requests, and eventually goes over > one or more bounds. The RS then starts throwing CallQueueTooBigExceptions. > This struggling state can last a good while. We throw CQTBEs whatever the > priority of the incoming request. > We throw CQTBE in two places; on original parse of the request before we > dispatch it on a handler -- here we check size of all queues and if over the > threshold (default 1G), throw the exception -- and then later when we > dispatch the request to internal queues, we'll count items in queue and if > over default in any one queue (default is 10 * handler count), we'll fail > dispatch and again throw CQTBE. > We shouldn't be running w/ big queues. We should be rejecting Requests we > know we'll never process in time before client loses interest (See the CoDel > thesis and the implementations added a good while back. See splitting meta > project so all requests don't end up on one server). TODO. > Meantime I was looking to see if having read a high-priority request, if > rather than dropping it on the floor, instead, what would happen if I let it > through even if above thresholds? My main concern is edits to hbase:meta. > When sustained, saturated load on the RS carrying hbase:meta, edits may not > land. The result is incomplete Procedures and a disorientated Master. I was > playing w/ trying to put off the corruption as long as possible, > experimenting (CoDel doesn't do priority at first blush; we probably want to > add this). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2036: HBASE-21596 Delete for a specific cell version can bring back version…
Apache-HBase commented on pull request #2036: URL: https://github.com/apache/hbase/pull/2036#issuecomment-655679576 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 48s | branch-2 passed | | +1 :green_heart: | compile | 0m 54s | branch-2 passed | | +1 :green_heart: | shadedjars | 5m 4s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 38s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 23s | the patch passed | | +1 :green_heart: | compile | 0m 54s | the patch passed | | +1 :green_heart: | javac | 0m 54s | the patch passed | | +1 :green_heart: | shadedjars | 5m 6s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 37s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 151m 25s | hbase-server in the patch passed. | | | | 174m 41s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2036/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2036 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux da9ba2d3c764 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 5fcffae5db | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2036/1/testReport/ | | Max. process+thread count | 3501 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2036/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2036: HBASE-21596 Delete for a specific cell version can bring back version…
Apache-HBase commented on pull request #2036: URL: https://github.com/apache/hbase/pull/2036#issuecomment-655676553 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docker mode activated. | | -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 28s | branch-2 passed | | +1 :green_heart: | compile | 1m 5s | branch-2 passed | | +1 :green_heart: | shadedjars | 6m 1s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 44s | hbase-server in branch-2 failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 0s | the patch passed | | +1 :green_heart: | compile | 1m 5s | the patch passed | | +1 :green_heart: | javac | 1m 5s | the patch passed | | +1 :green_heart: | shadedjars | 6m 40s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 49s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 140m 51s | hbase-server in the patch passed. | | | | 168m 24s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2036/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2036 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux dfdd04e16907 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 5fcffae5db | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2036/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2036/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2036/1/testReport/ | | Max. process+thread count | 3643 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2036/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2008: HBASE-24665 all wal of RegionGroupingProvider together roll
Apache-HBase commented on pull request #2008: URL: https://github.com/apache/hbase/pull/2008#issuecomment-655636094 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. | ||| _ branch-2.2 Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 13s | branch-2.2 passed | | +1 :green_heart: | compile | 0m 54s | branch-2.2 passed | | +1 :green_heart: | checkstyle | 1m 18s | branch-2.2 passed | | +1 :green_heart: | shadedjars | 4m 2s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 37s | branch-2.2 passed | | +0 :ok: | spotbugs | 3m 21s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 3m 20s | branch-2.2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 41s | the patch passed | | +1 :green_heart: | compile | 0m 59s | the patch passed | | +1 :green_heart: | javac | 0m 59s | the patch passed | | -1 :x: | checkstyle | 1m 18s | hbase-server: The patch generated 6 new + 0 unchanged - 0 fixed = 6 total (was 0) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 4m 4s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 25m 16s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 2.10.0 or 3.1.2 3.2.1. | | +1 :green_heart: | javadoc | 0m 35s | the patch passed | | +1 :green_heart: | findbugs | 3m 11s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 147m 2s | hbase-server in the patch passed. | | +1 :green_heart: | asflicense | 0m 34s | The patch does not generate ASF License warnings. | | | | 209m 57s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2008/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2008 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 982e66f0de53 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-2008/out/precommit/personality/provided.sh | | git revision | branch-2.2 / 160c2290bf | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2008/3/artifact/out/diff-checkstyle-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2008/3/testReport/ | | Max. process+thread count | 4353 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2008/3/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] anoopsjohn commented on a change in pull request #2021: HBASE-24665 all wal of RegionGroupingProvider together roll
anoopsjohn commented on a change in pull request #2021:
URL: https://github.com/apache/hbase/pull/2021#discussion_r451688123
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/AbstractWALRoller.java
##
@@ -148,10 +148,9 @@ private void abort(String reason, Throwable cause) {
@Override
public void run() {
while (running) {
- boolean periodic = false;
long now = System.currentTimeMillis();
checkLowReplication(now);
- periodic = (now - this.lastRollTime) > this.rollPeriod;
+ boolean periodic = (now - this.lastRollTime) > this.rollPeriod;
Review comment:
Not on this patch directly.
We have the periodic WAL roll.. Every WAL should get rolled as per this
period. When one WAL gets rolled, we will change the lastRollTime and so it
can happen that some WALs will ever get rolled!
This issue will be visible now as we will selectively roll WAL files after
this patch. Actually we need to track the lastRollTime per WAL instance.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] anoopsjohn commented on a change in pull request #2021: HBASE-24665 all wal of RegionGroupingProvider together roll
anoopsjohn commented on a change in pull request #2021:
URL: https://github.com/apache/hbase/pull/2021#discussion_r451686449
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/AbstractWALRoller.java
##
@@ -178,14 +177,17 @@ public void run() {
for (Iterator> iter =
walNeedsRoll.entrySet().iterator(); iter
.hasNext();) {
Entry entry = iter.next();
+ if (!periodic && !entry.getValue()) {
Review comment:
The actual fix is this alone right?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (HBASE-24603) Zookeeper sync() call is async
[
https://issues.apache.org/jira/browse/HBASE-24603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17153748#comment-17153748
]
Bharath Vissapragada commented on HBASE-24603:
--
[~anoop.hbase] Right, this bug applies for almost all the active branches. Let
me back port to other active maintenance branches.
> Zookeeper sync() call is async
> --
>
> Key: HBASE-24603
> URL: https://issues.apache.org/jira/browse/HBASE-24603
> Project: HBase
> Issue Type: Improvement
> Components: master, regionserver
>Affects Versions: 3.0.0-alpha-1, 2.3.0, 1.7.0
>Reporter: Bharath Vissapragada
>Assignee: Bharath Vissapragada
>Priority: Critical
> Fix For: 3.0.0-alpha-1, 2.3.0, 1.7.0
>
>
> Here is the method that does a sync() of lagging followers with leader in the
> quorum. We rely on this to see a consistent snapshot of ZK data from multiple
> clients. However the problem is that the underlying sync() call is actually
> asynchronous since we are passing a 'null' call back. See the ZK API
> [doc|https://zookeeper.apache.org/doc/r3.5.7/apidocs/zookeeper-server/index.html]
> for details. The end-result is that sync() doesn't guarantee that it has
> happened by the time it returns.
> {noformat}
> /**
>* Forces a synchronization of this ZooKeeper client connection.
>*
>* Executing this method before running other methods will ensure that the
>* subsequent operations are up-to-date and consistent as of the time that
>* the sync is complete.
>*
>* This is used for compareAndSwap type operations where we need to read the
>* data of an existing node and delete or transition that node, utilizing
> the
>* previously read version and data. We want to ensure that the version
> read
>* is up-to-date from when we begin the operation.
>*/
> public void sync(String path) throws KeeperException {
> this.recoverableZooKeeper.sync(path, null, null);
> }
> {noformat}
> We rely on this heavily (at least in the older branches that do ZK based
> region assignment). In branch-1 we saw weird "BadVersionException" exceptions
> in RITs because of the inconsistent view of the ZK snapshot. It could
> manifest differently in other branches. Either way, this is something we need
> to fix.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2036: HBASE-21596 Delete for a specific cell version can bring back version…
Apache-HBase commented on pull request #2036: URL: https://github.com/apache/hbase/pull/2036#issuecomment-655610445 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 14s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 1s | branch-2 passed | | +1 :green_heart: | checkstyle | 1m 22s | branch-2 passed | | +1 :green_heart: | spotbugs | 2m 12s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 34s | the patch passed | | +1 :green_heart: | checkstyle | 1m 15s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 14m 0s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 2m 14s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 13s | The patch does not generate ASF License warnings. | | | | 37m 44s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2036/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2036 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux d2924a1bc9cd 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 5fcffae5db | | Max. process+thread count | 84 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2036/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] wchevreuil opened a new pull request #2036: HBASE-21596 Delete for a specific cell version can bring back version…
wchevreuil opened a new pull request #2036: URL: https://github.com/apache/hbase/pull/2036 …… (#2009) Had to resolve some conflicts while cherry picking into branch-2. Created branch-2 PR to run pre commit tests. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-21596) Delete for a specific cell version can bring back versions above VERSIONS limit
[ https://issues.apache.org/jira/browse/HBASE-21596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-21596: - Fix Version/s: 3.0.0-alpha-1 > Delete for a specific cell version can bring back versions above VERSIONS > limit > --- > > Key: HBASE-21596 > URL: https://issues.apache.org/jira/browse/HBASE-21596 > Project: HBase > Issue Type: Bug >Affects Versions: 3.0.0-alpha-1 >Reporter: Wellington Chevreuil >Assignee: Wellington Chevreuil >Priority: Minor > Fix For: 3.0.0-alpha-1 > > Attachments: HBASE-21596-master.001.patch, > HBASE-21596-master.002.patch, HBASE-21596-master.003.patch, initial-patch.txt > > > Originally tested with HBase Shell delete command, but it's also reproducible > with Client API Delete operation. > The problem is that the memstore scan filter logic for versions only counts > the amount of cells it has read so far, then once the VERSIONS limit has been > reached, it just skips the remaining cells. If a delete marker is inserted on > a given cell version, that cell will not be accounted, then oldest versions > that should had disappeared will now pop up on the scan results. > Example, for a cell from a CF with max versions of 3, that has 4 versions T1, > T2, T3 and T4, scan correctly shows T4, T3 and T2. If a delete is triggered > for any for these 3 versions, say T3, scan now will show: T4, T2 and T1, but > T1 was supposed to be gone by the time T4 was added. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-21596) Delete for a specific cell version can bring back versions above VERSIONS limit
[ https://issues.apache.org/jira/browse/HBASE-21596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-21596: - Affects Version/s: 3.0.0-alpha-1 > Delete for a specific cell version can bring back versions above VERSIONS > limit > --- > > Key: HBASE-21596 > URL: https://issues.apache.org/jira/browse/HBASE-21596 > Project: HBase > Issue Type: Bug >Affects Versions: 3.0.0-alpha-1 >Reporter: Wellington Chevreuil >Assignee: Wellington Chevreuil >Priority: Minor > Attachments: HBASE-21596-master.001.patch, > HBASE-21596-master.002.patch, HBASE-21596-master.003.patch, initial-patch.txt > > > Originally tested with HBase Shell delete command, but it's also reproducible > with Client API Delete operation. > The problem is that the memstore scan filter logic for versions only counts > the amount of cells it has read so far, then once the VERSIONS limit has been > reached, it just skips the remaining cells. If a delete marker is inserted on > a given cell version, that cell will not be accounted, then oldest versions > that should had disappeared will now pop up on the scan results. > Example, for a cell from a CF with max versions of 3, that has 4 versions T1, > T2, T3 and T4, scan correctly shows T4, T3 and T2. If a delete is triggered > for any for these 3 versions, say T3, scan now will show: T4, T2 and T1, but > T1 was supposed to be gone by the time T4 was added. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] virajjasani commented on a change in pull request #1926: HBASE-24586 Add table level locality in table.jsp
virajjasani commented on a change in pull request #1926:
URL: https://github.com/apache/hbase/pull/1926#discussion_r451599800
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/HDFSBlocksDistribution.java
##
@@ -228,33 +228,49 @@ public long getUniqueBlocksTotalWeight() {
* Implementations 'visit' hostAndWeight.
*/
public interface Visitor {
-float visit(final HostAndWeight hostAndWeight);
+long visit(final HostAndWeight hostAndWeight);
}
/**
* @param host the host name
* @return the locality index of the given host
*/
public float getBlockLocalityIndex(String host) {
-return getBlockLocalityIndexInternal(host,
- e -> (float) e.weight / (float) uniqueBlocksTotalWeight);
+return (float) getBlocksLocalityWeightInternal(host, e -> e.weight)
+ / (float) uniqueBlocksTotalWeight;
}
/**
* @param host the host name
* @return the locality index with ssd of the given host
*/
public float getBlockLocalityIndexForSsd(String host) {
-return getBlockLocalityIndexInternal(host,
- e -> (float) e.weightForSsd / (float) uniqueBlocksTotalWeight);
+return (float) getBlocksLocalityWeightInternal(host, e -> e.weightForSsd)
+ / (float) uniqueBlocksTotalWeight;
+ }
+
+ /**
+ * @param host the host name
+ * @return the blocks local weight of the given host
+ */
+ public long getBlocksLocalWeight(String host) {
+return getBlocksLocalityWeightInternal(host, e -> e.weight);
Review comment:
same here
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/HDFSBlocksDistribution.java
##
@@ -228,33 +228,49 @@ public long getUniqueBlocksTotalWeight() {
* Implementations 'visit' hostAndWeight.
*/
public interface Visitor {
-float visit(final HostAndWeight hostAndWeight);
+long visit(final HostAndWeight hostAndWeight);
}
/**
* @param host the host name
* @return the locality index of the given host
*/
public float getBlockLocalityIndex(String host) {
-return getBlockLocalityIndexInternal(host,
- e -> (float) e.weight / (float) uniqueBlocksTotalWeight);
+return (float) getBlocksLocalityWeightInternal(host, e -> e.weight)
+ / (float) uniqueBlocksTotalWeight;
}
/**
* @param host the host name
* @return the locality index with ssd of the given host
*/
public float getBlockLocalityIndexForSsd(String host) {
-return getBlockLocalityIndexInternal(host,
- e -> (float) e.weightForSsd / (float) uniqueBlocksTotalWeight);
+return (float) getBlocksLocalityWeightInternal(host, e -> e.weightForSsd)
Review comment:
same here: `getBlocksLocalityWeightInternal(host,
HostAndWeight::getWeightForSsd)`
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/HDFSBlocksDistribution.java
##
@@ -228,33 +228,49 @@ public long getUniqueBlocksTotalWeight() {
* Implementations 'visit' hostAndWeight.
*/
public interface Visitor {
-float visit(final HostAndWeight hostAndWeight);
+long visit(final HostAndWeight hostAndWeight);
}
/**
* @param host the host name
* @return the locality index of the given host
*/
public float getBlockLocalityIndex(String host) {
-return getBlockLocalityIndexInternal(host,
- e -> (float) e.weight / (float) uniqueBlocksTotalWeight);
+return (float) getBlocksLocalityWeightInternal(host, e -> e.weight)
Review comment:
Can we use method reference here: `getBlocksLocalityWeightInternal(host,
HostAndWeight::getWeight)` ?
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/HDFSBlocksDistribution.java
##
@@ -228,33 +228,49 @@ public long getUniqueBlocksTotalWeight() {
* Implementations 'visit' hostAndWeight.
*/
public interface Visitor {
-float visit(final HostAndWeight hostAndWeight);
+long visit(final HostAndWeight hostAndWeight);
}
/**
* @param host the host name
* @return the locality index of the given host
*/
public float getBlockLocalityIndex(String host) {
-return getBlockLocalityIndexInternal(host,
- e -> (float) e.weight / (float) uniqueBlocksTotalWeight);
+return (float) getBlocksLocalityWeightInternal(host, e -> e.weight)
+ / (float) uniqueBlocksTotalWeight;
}
/**
* @param host the host name
* @return the locality index with ssd of the given host
*/
public float getBlockLocalityIndexForSsd(String host) {
-return getBlockLocalityIndexInternal(host,
- e -> (float) e.weightForSsd / (float) uniqueBlocksTotalWeight);
+return (float) getBlocksLocalityWeightInternal(host, e -> e.weightForSsd)
+ / (float) uniqueBlocksTotalWeight;
+ }
+
+ /**
+ * @param host the host name
+ * @return the blocks local weight of the given host
+ */
+ public long getBlocksLocalWeight(String host) {
+return getBlocksLocalityWeightInternal(host, e -> e.w
[jira] [Commented] (HBASE-24688) AssignRegionHandler uses EventType.M_RS_CLOSE_META instead of EventType.M_RS_OPEN_META for meta region
[
https://issues.apache.org/jira/browse/HBASE-24688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17153642#comment-17153642
]
Hudson commented on HBASE-24688:
Results for branch master
[build #1780 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1780/]: (/)
*{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1780/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1663//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1780/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1780/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> AssignRegionHandler uses EventType.M_RS_CLOSE_META instead of
> EventType.M_RS_OPEN_META for meta region
> --
>
> Key: HBASE-24688
> URL: https://issues.apache.org/jira/browse/HBASE-24688
> Project: HBase
> Issue Type: Bug
>Reporter: Huaxiang Sun
>Assignee: Huaxiang Sun
>Priority: Major
>
> This results in openMetaRegion always be executed in closeMetaExecutor.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] wchevreuil merged pull request #2009: HBASE-21596 Delete for a specific cell version can bring back version…
wchevreuil merged pull request #2009: URL: https://github.com/apache/hbase/pull/2009 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] wchevreuil commented on pull request #2032: HBASE-24404 Support flush a single column family of region
wchevreuil commented on pull request #2032: URL: https://github.com/apache/hbase/pull/2032#issuecomment-655544655 > > Looks a great additional function. How about also allow for flushing a specific column family among all regions within a table? It could be another jira/PR if you feel better to keep separate work. > > Flush table was implemented by a different way that through execProcedure(use pv1), i prefer to do it in a separate jira. > BTW, compact table was implemented in client side by iterate all its regions, should flush table go same way? Indeed, it's more complex then I originally thought. Let's keep discussing it on the other jira. I think this one is good to go, after fixing the latest javadoc issues. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] wchevreuil edited a comment on pull request #2032: HBASE-24404 Support flush a single column family of region
wchevreuil edited a comment on pull request #2032: URL: https://github.com/apache/hbase/pull/2032#issuecomment-655544655 > > Looks a great additional function. How about also allow for flushing a specific column family among all regions within a table? It could be another jira/PR if you feel better to keep separate work. > > Flush table was implemented by a different way that through execProcedure(use pv1), i prefer to do it in a separate jira. > BTW, compact table was implemented in client side by iterate all its regions, should flush table go same way? Indeed, it's more complex than I originally thought. Let's keep discussing it on the other jira. I think this one is good to go, after fixing the latest javadoc issues. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (HBASE-24695) FSHLog - close the current WAL file in a background thread
Anoop Sam John created HBASE-24695:
--
Summary: FSHLog - close the current WAL file in a background thread
Key: HBASE-24695
URL: https://issues.apache.org/jira/browse/HBASE-24695
Project: HBase
Issue Type: Improvement
Reporter: Anoop Sam John
Assignee: Anoop Sam John
We have this as a TODO in code already
{code}
// It is at the safe point. Swap out writer from under the blocked writer
thread.
// TODO: This is close is inline with critical section. Should happen in
background?
if (this.writer != null) {
oldFileLen = this.writer.getLength();
try {
TraceUtil.addTimelineAnnotation("closing writer");
this.writer.close();
TraceUtil.addTimelineAnnotation("writer closed");
this.closeErrorCount.set(0);
}
{code}
This close call in critical section and writes are blocked. Lets move this
close call into another WALCloser thread.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2008: HBASE-24665 all wal of RegionGroupingProvider together roll
Apache-HBase commented on pull request #2008: URL: https://github.com/apache/hbase/pull/2008#issuecomment-655515592 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 4s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. | ||| _ branch-2.2 Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 14s | branch-2.2 passed | | +1 :green_heart: | compile | 0m 58s | branch-2.2 passed | | +1 :green_heart: | checkstyle | 1m 19s | branch-2.2 passed | | +1 :green_heart: | shadedjars | 4m 5s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 37s | branch-2.2 passed | | +0 :ok: | spotbugs | 3m 18s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 3m 16s | branch-2.2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 45s | the patch passed | | +1 :green_heart: | compile | 0m 55s | the patch passed | | +1 :green_heart: | javac | 0m 55s | the patch passed | | -1 :x: | checkstyle | 1m 19s | hbase-server: The patch generated 6 new + 0 unchanged - 0 fixed = 6 total (was 0) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 4m 4s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 25m 16s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 2.10.0 or 3.1.2 3.2.1. | | +1 :green_heart: | javadoc | 0m 38s | the patch passed | | +1 :green_heart: | findbugs | 3m 25s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 150m 46s | hbase-server in the patch passed. | | +1 :green_heart: | asflicense | 0m 36s | The patch does not generate ASF License warnings. | | | | 215m 31s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2008/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2008 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux f1af7cefb9be 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-2008/out/precommit/personality/provided.sh | | git revision | branch-2.2 / 160c2290bf | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2008/2/artifact/out/diff-checkstyle-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2008/2/testReport/ | | Max. process+thread count | 4344 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2008/2/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24687) MobFileCleanerChore uses a new Connection for each table each time it runs
[ https://issues.apache.org/jira/browse/HBASE-24687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17153518#comment-17153518 ] Junhong Xu commented on HBASE-24687: bq. there's a less severe version of this problem in branch-2 based releases where we make a new connection per chore invocation. Ping [~busbey] Do you think it's not a problem for branch-2 only or for branches including master? Do we need cache the connection and more threads? > MobFileCleanerChore uses a new Connection for each table each time it runs > -- > > Key: HBASE-24687 > URL: https://issues.apache.org/jira/browse/HBASE-24687 > Project: HBase > Issue Type: Bug > Components: mob >Affects Versions: 3.0.0-alpha-1 >Reporter: Manas >Assignee: Junhong Xu >Priority: Minor > Attachments: Screen Shot 2020-07-06 at 6.06.43 PM.png > > > Currently creating a new connection for every table under > MobFileCleanerChore.java where we should theoretically just using the > connection from HBase masterservices. > > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] WenFeiYi commented on pull request #2008: HBASE-24665 all wal of RegionGroupingProvider together roll
WenFeiYi commented on pull request #2008: URL: https://github.com/apache/hbase/pull/2008#issuecomment-655444997 > Can you add more comments to explain "why the fix worked"? And add a UT for this? I update, please review, if ok, I update other branch. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2035: HBASE-24663 Add procedure process time statistics UI
Apache-HBase commented on pull request #2035: URL: https://github.com/apache/hbase/pull/2035#issuecomment-655441924 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 38s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 10s | master passed | | +1 :green_heart: | compile | 1m 31s | master passed | | +1 :green_heart: | shadedjars | 6m 22s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 8s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 6s | the patch passed | | +1 :green_heart: | compile | 1m 30s | the patch passed | | +1 :green_heart: | javac | 1m 30s | the patch passed | | +1 :green_heart: | shadedjars | 6m 8s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 2s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 18s | hbase-metrics-api in the patch passed. | | +1 :green_heart: | unit | 0m 19s | hbase-metrics in the patch passed. | | +1 :green_heart: | unit | 202m 2s | hbase-server in the patch passed. | | | | 232m 56s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2035/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2035 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux bf2aabab3ce2 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 90f4ff7d7c | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2035/1/testReport/ | | Max. process+thread count | 3360 (vs. ulimit of 12500) | | modules | C: hbase-metrics-api hbase-metrics hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2035/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24686) [LOG] Log improvement in Connection#close
[ https://issues.apache.org/jira/browse/HBASE-24686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17153484#comment-17153484 ] Peter Somogyi commented on HBASE-24686: --- Hi [~mokai87], I added you as a contributor and assigned the issue to you. > [LOG] Log improvement in Connection#close > - > > Key: HBASE-24686 > URL: https://issues.apache.org/jira/browse/HBASE-24686 > Project: HBase > Issue Type: Improvement > Components: Client, logging >Affects Versions: 2.2.3 >Reporter: mokai >Assignee: mokai >Priority: Major > > We met some customers used hbase connection improperly, some threads call > failed since the shared connection closed by one of the threads. > It's better to print the details when connection closing. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (HBASE-24686) [LOG] Log improvement in Connection#close
[ https://issues.apache.org/jira/browse/HBASE-24686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi reassigned HBASE-24686: - Assignee: mokai > [LOG] Log improvement in Connection#close > - > > Key: HBASE-24686 > URL: https://issues.apache.org/jira/browse/HBASE-24686 > Project: HBase > Issue Type: Improvement > Components: Client, logging >Affects Versions: 2.2.3 >Reporter: mokai >Assignee: mokai >Priority: Major > > We met some customers used hbase connection improperly, some threads call > failed since the shared connection closed by one of the threads. > It's better to print the details when connection closing. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2035: HBASE-24663 Add procedure process time statistics UI
Apache-HBase commented on pull request #2035: URL: https://github.com/apache/hbase/pull/2035#issuecomment-655435541 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 24s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 37s | master passed | | +1 :green_heart: | compile | 1m 38s | master passed | | +1 :green_heart: | shadedjars | 6m 21s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 15s | hbase-metrics in master failed. | | -0 :warning: | javadoc | 0m 14s | hbase-metrics-api in master failed. | | -0 :warning: | javadoc | 0m 41s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 27s | the patch passed | | +1 :green_heart: | compile | 1m 39s | the patch passed | | +1 :green_heart: | javac | 1m 39s | the patch passed | | +1 :green_heart: | shadedjars | 6m 21s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 14s | hbase-metrics-api in the patch failed. | | -0 :warning: | javadoc | 0m 14s | hbase-metrics in the patch failed. | | -0 :warning: | javadoc | 0m 40s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 19s | hbase-metrics-api in the patch passed. | | +1 :green_heart: | unit | 0m 20s | hbase-metrics in the patch passed. | | +1 :green_heart: | unit | 186m 22s | hbase-server in the patch passed. | | | | 217m 27s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2035/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2035 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux e9b622dd543e 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 90f4ff7d7c | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2035/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-metrics.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2035/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-metrics-api.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2035/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2035/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-metrics-api.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2035/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-metrics.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2035/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2035/1/testReport/ | | Max. process+thread count | 3356 (vs. ulimit of 12500) | | modules | C: hbase-metrics-api hbase-metrics hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2035/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2019: HBASE-24681 Remove the cache walsById/walsByIdRecoveredQueues from Re…
Apache-HBase commented on pull request #2019: URL: https://github.com/apache/hbase/pull/2019#issuecomment-655413313 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 47s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ HBASE-24666 Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 15s | HBASE-24666 passed | | +1 :green_heart: | compile | 1m 15s | HBASE-24666 passed | | +1 :green_heart: | shadedjars | 6m 47s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 46s | hbase-server in HBASE-24666 failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 55s | the patch passed | | +1 :green_heart: | compile | 1m 28s | the patch passed | | +1 :green_heart: | javac | 1m 28s | the patch passed | | +1 :green_heart: | shadedjars | 6m 58s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 45s | hbase-server in the patch failed. | ||| _ Other Tests _ | | -1 :x: | unit | 149m 42s | hbase-server in the patch failed. | | | | 180m 36s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2019 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 39aeeeb16c39 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-24666 / c2949719c5 | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/2/testReport/ | | Max. process+thread count | 4455 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2019: HBASE-24681 Remove the cache walsById/walsByIdRecoveredQueues from Re…
Apache-HBase commented on pull request #2019: URL: https://github.com/apache/hbase/pull/2019#issuecomment-655405877 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ HBASE-24666 Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 48s | HBASE-24666 passed | | +1 :green_heart: | compile | 0m 55s | HBASE-24666 passed | | +1 :green_heart: | shadedjars | 5m 41s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 40s | HBASE-24666 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 24s | the patch passed | | +1 :green_heart: | compile | 0m 56s | the patch passed | | +1 :green_heart: | javac | 0m 56s | the patch passed | | +1 :green_heart: | shadedjars | 5m 33s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 36s | hbase-server generated 7 new + 28 unchanged - 0 fixed = 35 total (was 28) | ||| _ Other Tests _ | | +1 :green_heart: | unit | 141m 35s | hbase-server in the patch passed. | | | | 165m 57s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2019 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux d9d40903c967 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-24666 / c2949719c5 | | Default Java | 1.8.0_232 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/2/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/2/testReport/ | | Max. process+thread count | 4710 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24663) Add procedure process time statistics UI
[ https://issues.apache.org/jira/browse/HBASE-24663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17153414#comment-17153414 ] Junhong Xu commented on HBASE-24663: Yeah, in the internal branch, all regions on the server have been moved before stopped, and cleanups have been done completely. It's not a 'kill -9' crash. > Add procedure process time statistics UI > > > Key: HBASE-24663 > URL: https://issues.apache.org/jira/browse/HBASE-24663 > Project: HBase > Issue Type: Improvement >Reporter: Guanghao Zhang >Assignee: Junhong Xu >Priority: Major > Attachments: screenshot-1.png > > > Added in "Procedures & Locks" jsp. > For the first version UI, we care about the process time of > ServerCrashProcedure, TRSP, OpenRegionProcedure and CloseRegionProcedure. > Plan to show the avg/P50/P90/min/max process time of these procedures. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24694) Support flush a single column family of table
[ https://issues.apache.org/jira/browse/HBASE-24694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zheng Wang updated HBASE-24694: --- Description: This is follow-on work of HBASE-24404, do it as a seprate issue could make it easier to reveiw. (was: This is follow-on task of HBASE-24404, do it as a seprate issue could make it easier to reveiw.) > Support flush a single column family of table > - > > Key: HBASE-24694 > URL: https://issues.apache.org/jira/browse/HBASE-24694 > Project: HBase > Issue Type: New Feature >Reporter: Zheng Wang >Assignee: Zheng Wang >Priority: Major > > This is follow-on work of HBASE-24404, do it as a seprate issue could make it > easier to reveiw. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-24694) Support flush a single column family of table
Zheng Wang created HBASE-24694: -- Summary: Support flush a single column family of table Key: HBASE-24694 URL: https://issues.apache.org/jira/browse/HBASE-24694 Project: HBase Issue Type: New Feature Reporter: Zheng Wang Assignee: Zheng Wang This is follow-on task of HBASE-24404, do it as a seprate issue could make it easier to reveiw. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24653) Show snapshot owner on Master WebUI
[ https://issues.apache.org/jira/browse/HBASE-24653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17153406#comment-17153406 ] niuyulin commented on HBASE-24653: -- home page: !snapshot1.png! snapshot detail page: !snapshot2.png! > Show snapshot owner on Master WebUI > --- > > Key: HBASE-24653 > URL: https://issues.apache.org/jira/browse/HBASE-24653 > Project: HBase > Issue Type: Improvement >Reporter: Yi Mei >Assignee: niuyulin >Priority: Major > Attachments: snapshot1.png, snapshot2.png > > > Now Master UI shows lots of snapshot informations, and owner is also useful > to find out who create this snapshot. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24653) Show snapshot owner on Master WebUI
[ https://issues.apache.org/jira/browse/HBASE-24653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] niuyulin updated HBASE-24653: - Attachment: snapshot2.png > Show snapshot owner on Master WebUI > --- > > Key: HBASE-24653 > URL: https://issues.apache.org/jira/browse/HBASE-24653 > Project: HBase > Issue Type: Improvement >Reporter: Yi Mei >Assignee: niuyulin >Priority: Major > Attachments: snapshot1.png, snapshot2.png > > > Now Master UI shows lots of snapshot informations, and owner is also useful > to find out who create this snapshot. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24653) Show snapshot owner on Master WebUI
[ https://issues.apache.org/jira/browse/HBASE-24653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] niuyulin updated HBASE-24653: - Attachment: snapshot1.png > Show snapshot owner on Master WebUI > --- > > Key: HBASE-24653 > URL: https://issues.apache.org/jira/browse/HBASE-24653 > Project: HBase > Issue Type: Improvement >Reporter: Yi Mei >Assignee: niuyulin >Priority: Major > Attachments: snapshot1.png > > > Now Master UI shows lots of snapshot informations, and owner is also useful > to find out who create this snapshot. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] bsglz commented on pull request #2011: HBASE-24664 Some changing of split region by overall region size rath…
bsglz commented on pull request #2011: URL: https://github.com/apache/hbase/pull/2011#issuecomment-655385037 Seems the ut failure unrelated to this pr. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24632) Enable procedure-based log splitting as default in hbase3
[
https://issues.apache.org/jira/browse/HBASE-24632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17153366#comment-17153366
]
Pankaj Kumar commented on HBASE-24632:
--
{quote}You in favor of enabling this for 2.4.0/3.0.0 by default sir?
{quote}
Yeah, we can make procedure-based log splitting as default in master branch.
> Enable procedure-based log splitting as default in hbase3
> -
>
> Key: HBASE-24632
> URL: https://issues.apache.org/jira/browse/HBASE-24632
> Project: HBase
> Issue Type: Sub-task
> Components: wal
>Reporter: Michael Stack
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.4.0
>
>
> Means changing this value in HConstants to false:
>public static final boolean DEFAULT_HBASE_SPLIT_COORDINATED_BY_ZK = true;
> Should probably also deprecate the current zk distributed split too so we can
> clear out those classes to.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2011: HBASE-24664 Some changing of split region by overall region size rath…
Apache-HBase commented on pull request #2011: URL: https://github.com/apache/hbase/pull/2011#issuecomment-655374098 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 45s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 25s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 12s | master passed | | +1 :green_heart: | compile | 2m 46s | master passed | | +1 :green_heart: | shadedjars | 7m 17s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 31s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 28s | the patch passed | | +1 :green_heart: | compile | 3m 1s | the patch passed | | +1 :green_heart: | javac | 3m 1s | the patch passed | | +1 :green_heart: | shadedjars | 7m 10s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 45s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 335m 56s | root in the patch failed. | | | | 376m 5s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2011/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2011 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 09db1bb67116 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 90f4ff7d7c | | Default Java | 1.8.0_232 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2011/5/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2011/5/testReport/ | | Max. process+thread count | 5223 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-server . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2011/5/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] nyl3532016 commented on pull request #2016: HBASE-24653 Show snapshot owner on Master WebUI
nyl3532016 commented on pull request #2016: URL: https://github.com/apache/hbase/pull/2016#issuecomment-655365645 ok, now show ttl in human readable way   This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] infraio commented on pull request #2026: HBASE-22738 Fallback to default group to choose RS when there are no …
infraio commented on pull request #2026: URL: https://github.com/apache/hbase/pull/2026#issuecomment-655355755 The target branch should be branch-2, not branch-2.3? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (HBASE-24687) MobFileCleanerChore uses a new Connection for each table each time it runs
[ https://issues.apache.org/jira/browse/HBASE-24687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junhong Xu reassigned HBASE-24687: -- Assignee: Junhong Xu > MobFileCleanerChore uses a new Connection for each table each time it runs > -- > > Key: HBASE-24687 > URL: https://issues.apache.org/jira/browse/HBASE-24687 > Project: HBase > Issue Type: Bug > Components: mob >Affects Versions: 3.0.0-alpha-1 >Reporter: Manas >Assignee: Junhong Xu >Priority: Minor > Attachments: Screen Shot 2020-07-06 at 6.06.43 PM.png > > > Currently creating a new connection for every table under > MobFileCleanerChore.java where we should theoretically just using the > connection from HBase masterservices. > > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24687) MobFileCleanerChore uses a new Connection for each table each time it runs
[ https://issues.apache.org/jira/browse/HBASE-24687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17153319#comment-17153319 ] Junhong Xu commented on HBASE-24687: Another thing is there is only one thread to check and cleanup the files in the whole cluster. Let me fix them both. > MobFileCleanerChore uses a new Connection for each table each time it runs > -- > > Key: HBASE-24687 > URL: https://issues.apache.org/jira/browse/HBASE-24687 > Project: HBase > Issue Type: Bug > Components: mob >Affects Versions: 3.0.0-alpha-1 >Reporter: Manas >Priority: Minor > Attachments: Screen Shot 2020-07-06 at 6.06.43 PM.png > > > Currently creating a new connection for every table under > MobFileCleanerChore.java where we should theoretically just using the > connection from HBase masterservices. > > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2035: HBASE-24663 Add procedure process time statistics UI
Apache-HBase commented on pull request #2035: URL: https://github.com/apache/hbase/pull/2035#issuecomment-655346374 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 35s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 21s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 11s | master passed | | +1 :green_heart: | checkstyle | 1m 38s | master passed | | +1 :green_heart: | spotbugs | 3m 3s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 58s | the patch passed | | +1 :green_heart: | checkstyle | 1m 39s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 12m 42s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 4m 4s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 38s | The patch does not generate ASF License warnings. | | | | 43m 20s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2035/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2035 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 3da88e50eedd 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 90f4ff7d7c | | Max. process+thread count | 84 (vs. ulimit of 12500) | | modules | C: hbase-metrics-api hbase-metrics hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2035/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
