[GitHub] [hbase] Apache-HBase commented on pull request #2582: HBASE-25187 Improve SizeCachedKV variants initialization
Apache-HBase commented on pull request #2582: URL: https://github.com/apache/hbase/pull/2582#issuecomment-725265363 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 26s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 53s | master passed | | +1 :green_heart: | checkstyle | 1m 34s | master passed | | +1 :green_heart: | spotbugs | 2m 42s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 26s | the patch passed | | +1 :green_heart: | checkstyle | 1m 25s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 17m 18s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. | | +1 :green_heart: | spotbugs | 2m 59s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 26s | The patch does not generate ASF License warnings. | | | | 42m 14s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2582/7/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2582 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 019f499d6313 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f0c430aed2 | | Max. process+thread count | 94 (vs. ulimit of 3) | | modules | C: hbase-common hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2582/7/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=3.1.12 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2646: HBASE-25273 fix typo in StripeStoreFileManager java doc
Apache-HBase commented on pull request #2646: URL: https://github.com/apache/hbase/pull/2646#issuecomment-725224863 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 49s | master passed | | +1 :green_heart: | checkstyle | 1m 7s | master passed | | +1 :green_heart: | spotbugs | 2m 1s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 24s | the patch passed | | +1 :green_heart: | checkstyle | 1m 3s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 17m 16s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. | | +1 :green_heart: | spotbugs | 2m 7s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 15s | The patch does not generate ASF License warnings. | | | | 38m 43s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2646/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2646 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux a92a26abe162 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f0c430aed2 | | Max. process+thread count | 94 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2646/1/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=3.1.12 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] clarax commented on a change in pull request #2644: HBASE-25127 Enhance PerformanceEvaluation to profile meta replica performance.
clarax commented on a change in pull request #2644:
URL: https://github.com/apache/hbase/pull/2644#discussion_r521129644
##
File path:
hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java
##
@@ -1998,6 +2006,41 @@ protected void testTakedown() throws IOException {
super.testTakedown();
}
}
+ static class MetaRandomReadTest extends TableTest {
+private Random rd = new Random();
+private RegionLocator regionLocator;
+
+MetaRandomReadTest(Connection con, TestOptions options, Status status) {
+ super(con, options, status);
+ LOG.info("call getRegionLocation");
+}
+
+@Override
+void onStartup() throws IOException {
+ this.table = connection.getTable(TableName.valueOf("hbase:meta"));
+ this.regionLocator =
connection.getRegionLocator(TableName.valueOf("hbase:meta"));
+}
+
+@Override
+boolean testRow(final int i, final long startTime) throws IOException,
InterruptedException {
+ if (opts.randomSleep > 0) {
+Thread.sleep(rd.nextInt(opts.randomSleep));
+ }
+ HRegionLocation hRegionLocation =
regionLocator.getRegionLocation(Bytes.toBytes(Integer.toString(rd.nextInt(100)
+ 1)), true);
Review comment:
Right. I was thinking to add trace in the case of troubleshooting but
not sure.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] clarax commented on a change in pull request #2644: HBASE-25127 Enhance PerformanceEvaluation to profile meta replica performance.
clarax commented on a change in pull request #2644:
URL: https://github.com/apache/hbase/pull/2644#discussion_r521129808
##
File path:
hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java
##
@@ -1998,6 +2006,41 @@ protected void testTakedown() throws IOException {
super.testTakedown();
}
}
+ static class MetaRandomReadTest extends TableTest {
+private Random rd = new Random();
+private RegionLocator regionLocator;
+
+MetaRandomReadTest(Connection con, TestOptions options, Status status) {
+ super(con, options, status);
+ LOG.info("call getRegionLocation");
+}
+
+@Override
+void onStartup() throws IOException {
+ this.table = connection.getTable(TableName.valueOf("hbase:meta"));
+ this.regionLocator =
connection.getRegionLocator(TableName.valueOf("hbase:meta"));
+}
+
+@Override
+boolean testRow(final int i, final long startTime) throws IOException,
InterruptedException {
+ if (opts.randomSleep > 0) {
+Thread.sleep(rd.nextInt(opts.randomSleep));
+ }
+ HRegionLocation hRegionLocation =
regionLocator.getRegionLocation(Bytes.toBytes(Integer.toString(rd.nextInt(100)
+ 1)), true);
Review comment:
MetaWriteTest should be executed before MetaReadTest to populate the
table.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] clarax commented on a change in pull request #2644: HBASE-25127 Enhance PerformanceEvaluation to profile meta replica performance.
clarax commented on a change in pull request #2644:
URL: https://github.com/apache/hbase/pull/2644#discussion_r521129644
##
File path:
hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java
##
@@ -1998,6 +2006,41 @@ protected void testTakedown() throws IOException {
super.testTakedown();
}
}
+ static class MetaRandomReadTest extends TableTest {
+private Random rd = new Random();
+private RegionLocator regionLocator;
+
+MetaRandomReadTest(Connection con, TestOptions options, Status status) {
+ super(con, options, status);
+ LOG.info("call getRegionLocation");
+}
+
+@Override
+void onStartup() throws IOException {
+ this.table = connection.getTable(TableName.valueOf("hbase:meta"));
+ this.regionLocator =
connection.getRegionLocator(TableName.valueOf("hbase:meta"));
+}
+
+@Override
+boolean testRow(final int i, final long startTime) throws IOException,
InterruptedException {
+ if (opts.randomSleep > 0) {
+Thread.sleep(rd.nextInt(opts.randomSleep));
+ }
+ HRegionLocation hRegionLocation =
regionLocator.getRegionLocation(Bytes.toBytes(Integer.toString(rd.nextInt(100)
+ 1)), true);
Review comment:
Right.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (HBASE-25273) fix typo in StripeStoreFileManager java doc
[ https://issues.apache.org/jira/browse/HBASE-25273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hossein Zolfi updated HBASE-25273: -- External issue URL: https://github.com/apache/hbase/pull/2646 > fix typo in StripeStoreFileManager java doc > --- > > Key: HBASE-25273 > URL: https://issues.apache.org/jira/browse/HBASE-25273 > Project: HBase > Issue Type: Improvement >Reporter: Hossein Zolfi >Priority: Major > > See StripeCompactionPolicy on how the stripes are determined; this class > doesn't care. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] empire opened a new pull request #2646: HBASE-25273 fix typo in StripeStoreFileManager java doc
empire opened a new pull request #2646: URL: https://github.com/apache/hbase/pull/2646 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (HBASE-25273) fix typo in StripeStoreFileManager java doc
Hossein Zolfi created HBASE-25273: - Summary: fix typo in StripeStoreFileManager java doc Key: HBASE-25273 URL: https://issues.apache.org/jira/browse/HBASE-25273 Project: HBase Issue Type: Improvement Reporter: Hossein Zolfi See StripeCompactionPolicy on how the stripes are determined; this class doesn't care. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2640: Backport: HBASE-25126 Add load balance logic in hbase-client to distribute read…
Apache-HBase commented on pull request #2640: URL: https://github.com/apache/hbase/pull/2640#issuecomment-725196555 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 24s | Docker mode activated. | | -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ HBASE-18070.branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 58s | HBASE-18070.branch-2 passed | | +1 :green_heart: | compile | 1m 49s | HBASE-18070.branch-2 passed | | +1 :green_heart: | shadedjars | 7m 36s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 19s | HBASE-18070.branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 39s | the patch passed | | +1 :green_heart: | compile | 1m 47s | the patch passed | | +1 :green_heart: | javac | 1m 47s | the patch passed | | +1 :green_heart: | shadedjars | 7m 26s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 11s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 49s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 221m 21s | hbase-server in the patch passed. | | | | 260m 3s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2640/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2640 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 32b59bd0428a 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-18070.branch-2 / e4e7386b39 | | Default Java | AdoptOpenJDK-11.0.6+10 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2640/2/testReport/ | | Max. process+thread count | 2635 (vs. ulimit of 12500) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2640/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2645: HBASE-25272 Support scan on a specific replica
Apache-HBase commented on pull request #2645: URL: https://github.com/apache/hbase/pull/2645#issuecomment-725193546 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 41s | Docker mode activated. | | -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 50s | branch-2 passed | | +1 :green_heart: | compile | 0m 32s | branch-2 passed | | +1 :green_heart: | shadedjars | 7m 27s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 29s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 29s | the patch passed | | +1 :green_heart: | compile | 0m 32s | the patch passed | | +1 :green_heart: | javac | 0m 32s | the patch passed | | +1 :green_heart: | shadedjars | 7m 24s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 28s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 48s | hbase-client in the patch passed. | | | | 32m 57s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2645/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2645 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 8f8827ec6ed5 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / ec3f843b23 | | Default Java | AdoptOpenJDK-11.0.6+10 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2645/1/testReport/ | | Max. process+thread count | 214 (vs. ulimit of 12500) | | modules | C: hbase-client U: hbase-client | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2645/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2645: HBASE-25272 Support scan on a specific replica
Apache-HBase commented on pull request #2645: URL: https://github.com/apache/hbase/pull/2645#issuecomment-725192767 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 39s | branch-2 passed | | +1 :green_heart: | checkstyle | 0m 34s | branch-2 passed | | +1 :green_heart: | spotbugs | 1m 9s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 11s | the patch passed | | -0 :warning: | checkstyle | 0m 32s | hbase-client: The patch generated 2 new + 10 unchanged - 23 fixed = 12 total (was 33) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 34s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 1m 17s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 15s | The patch does not generate ASF License warnings. | | | | 30m 8s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2645/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2645 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux ab1e4af51b05 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / ec3f843b23 | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2645/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt | | Max. process+thread count | 94 (vs. ulimit of 12500) | | modules | C: hbase-client U: hbase-client | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2645/1/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=3.1.12 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2645: HBASE-25272 Support scan on a specific replica
Apache-HBase commented on pull request #2645: URL: https://github.com/apache/hbase/pull/2645#issuecomment-725191362 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 42s | branch-2 passed | | +1 :green_heart: | compile | 0m 27s | branch-2 passed | | +1 :green_heart: | shadedjars | 6m 4s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 27s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 17s | the patch passed | | +1 :green_heart: | compile | 0m 26s | the patch passed | | +1 :green_heart: | javac | 0m 26s | the patch passed | | +1 :green_heart: | shadedjars | 5m 57s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 25s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 17s | hbase-client in the patch passed. | | | | 25m 1s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2645/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2645 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 7041a2dc93bb 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / ec3f843b23 | | Default Java | AdoptOpenJDK-1.8.0_232-b09 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2645/1/testReport/ | | Max. process+thread count | 342 (vs. ulimit of 12500) | | modules | C: hbase-client U: hbase-client | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2645/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] sguggilam commented on a change in pull request #2627: HBASE-25251 Enable configuration based enable/disable of Unsafe packa…
sguggilam commented on a change in pull request #2627: URL: https://github.com/apache/hbase/pull/2627#discussion_r521105633 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/util/UnsafeAvailChecker.java ## @@ -33,12 +35,16 @@ private static final Logger LOG = LoggerFactory.getLogger(UnsafeAvailChecker.class); private static boolean avail = false; private static boolean unaligned = false; + // Flag that can be set by clients to enable/disable Unsafe package usage + private static boolean useUnsafe; Review comment: @Apache9 Yes that is definitely a good idea and in fact we have started the change with having a configuration parameter that can be set to false for disabling the Unsafe usage which would be read in the static block ( of UnsafeAvailChecker) for not having the clients to explicitly call a method to disable the Unsafe availability @apurtell But one thing that we observed is that not all clients have the hbase-site or hbase-default xml in the classpaths where they can set this flag . Hence we thought of having a util method (in addition to the configuration way of disabling it) for helping those clients to disable the Unsafe usage . Please provide your thoughts on any other way that we can help achieve this. ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/util/UnsafeAvailChecker.java ## @@ -33,12 +35,16 @@ private static final Logger LOG = LoggerFactory.getLogger(UnsafeAvailChecker.class); private static boolean avail = false; private static boolean unaligned = false; + // Flag that can be set by clients to enable/disable Unsafe package usage + private static boolean useUnsafe; Review comment: @Apache9 Yes that is definitely a good idea and in fact we have started the change with having a configuration parameter that can be set to false for disabling the Unsafe usage which would be read in the static block ( of UnsafeAvailChecker) for not having the clients to explicitly call a method to disable the Unsafe availability But one thing that we observed is that not all clients have the hbase-site or hbase-default xml in the classpaths where they can set this flag . Hence we thought of having a util method (in addition to the configuration way of disabling it) for helping those clients to disable the Unsafe usage . Please provide your thoughts on any other way that we can help achieve this. @apurtell This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #2645: HBASE-25272 Support scan on a specific replica
Apache9 commented on pull request #2645: URL: https://github.com/apache/hbase/pull/2645#issuecomment-725175775 Check whether we could pass all the existing UTs. Need to add a test to verify the function. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 opened a new pull request #2645: HBASE-25272 Support scan on a specific replica
Apache9 opened a new pull request #2645: URL: https://github.com/apache/hbase/pull/2645 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2643: HBASE-18070
Apache-HBase commented on pull request #2643: URL: https://github.com/apache/hbase/pull/2643#issuecomment-725123952 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 6s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 53s | master passed | | +1 :green_heart: | compile | 1m 50s | master passed | | +1 :green_heart: | shadedjars | 7m 29s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 9s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 40s | the patch passed | | +1 :green_heart: | compile | 1m 53s | the patch passed | | +1 :green_heart: | javac | 1m 53s | the patch passed | | +1 :green_heart: | shadedjars | 7m 32s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 42s | hbase-server generated 1 new + 83 unchanged - 0 fixed = 84 total (was 83) | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 25s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 195m 10s | hbase-server in the patch passed. | | | | 231m 1s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2643/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2643 | | JIRA Issue | HBASE-18070 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux a25e5e7dcd69 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f0c430aed2 | | Default Java | AdoptOpenJDK-11.0.6+10 | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2643/1/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2643/1/testReport/ | | Max. process+thread count | 2957 (vs. ulimit of 3) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2643/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-25269) [hbase-thirdparty] Set version as 3.4.1 in prep for first RC
[ https://issues.apache.org/jira/browse/HBASE-25269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25269: -- Fix Version/s: (was: thirdpart-3.4.1) thirdparty-3.4.1 > [hbase-thirdparty] Set version as 3.4.1 in prep for first RC > > > Key: HBASE-25269 > URL: https://issues.apache.org/jira/browse/HBASE-25269 > Project: HBase > Issue Type: Sub-task > Components: thirdparty >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: thirdparty-3.4.1 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-25264) [hbase-thirdparty] Update jersey version in hbase-thirdparty
[ https://issues.apache.org/jira/browse/HBASE-25264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25264: -- Fix Version/s: (was: thirdpart-3.4.1) thirdparty-3.4.1 > [hbase-thirdparty] Update jersey version in hbase-thirdparty > > > Key: HBASE-25264 > URL: https://issues.apache.org/jira/browse/HBASE-25264 > Project: HBase > Issue Type: Task > Components: dependencies, hbase-thirdparty >Reporter: Duo Zhang >Assignee: Zhuoyue Huang >Priority: Major > Fix For: thirdparty-3.4.1 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-25265) [hbase-thirdparty] Bump dependencis in hbase-thirdparty
[ https://issues.apache.org/jira/browse/HBASE-25265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25265: -- Fix Version/s: (was: thirdpart-3.4.1) thirdparty-3.4.1 > [hbase-thirdparty] Bump dependencis in hbase-thirdparty > --- > > Key: HBASE-25265 > URL: https://issues.apache.org/jira/browse/HBASE-25265 > Project: HBase > Issue Type: Task > Components: dependencies, hbase-thirdparty >Reporter: Duo Zhang >Assignee: Zhuoyue Huang >Priority: Major > Fix For: thirdparty-3.4.1 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-25262) [hbase-thirdparty] Update jetty version in hbase-thirdparty
[ https://issues.apache.org/jira/browse/HBASE-25262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25262: -- Fix Version/s: (was: thirdpart-3.4.1) thirdparty-3.4.1 > [hbase-thirdparty] Update jetty version in hbase-thirdparty > --- > > Key: HBASE-25262 > URL: https://issues.apache.org/jira/browse/HBASE-25262 > Project: HBase > Issue Type: Improvement > Components: dependencies, hbase-thirdparty >Reporter: Wei-Chiu Chuang >Assignee: Wei-Chiu Chuang >Priority: Major > Fix For: thirdparty-3.4.1 > > > The master branch of hbase-thirdparty is on Jetty 9.4.31. The latest 9.4.x is > Jetty 9.4.34. We should update to the latest. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-25269) [hbase-thirdparty] Set version as 3.4.1 in prep for first RC
[ https://issues.apache.org/jira/browse/HBASE-25269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-25269. --- Fix Version/s: thirdpart-3.4.1 Hadoop Flags: Reviewed Assignee: Duo Zhang Resolution: Fixed Merged to master. Thanks [~zghao] for reviewing. > [hbase-thirdparty] Set version as 3.4.1 in prep for first RC > > > Key: HBASE-25269 > URL: https://issues.apache.org/jira/browse/HBASE-25269 > Project: HBase > Issue Type: Sub-task > Components: thirdparty >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: thirdpart-3.4.1 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase-thirdparty] Apache9 merged pull request #41: HBASE-25269 [hbase-thirdparty] Set version as 3.4.1 in prep for first RC
Apache9 merged pull request #41: URL: https://github.com/apache/hbase-thirdparty/pull/41 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24632) Enable procedure-based log splitting as default in hbase3
[
https://issues.apache.org/jira/browse/HBASE-24632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17229682#comment-17229682
]
Michael Stack commented on HBASE-24632:
---
{quote}[~stack] [~anoop.hbase] The zk based log splitting is only a internal
implenation. Can we purge them out in master branch and no need wait to 4.0.0?
{quote}
It is on by default in 2.4.0. I was thinking it should stay in place for a
while in case we find a problem in procedure-based log splitting. Perhaps we
figure out if procedure-based log splitting is stable in 2.4 + 2.5 So,
purging from trunk/branch-3 would be ok?
> Enable procedure-based log splitting as default in hbase3
> -
>
> Key: HBASE-24632
> URL: https://issues.apache.org/jira/browse/HBASE-24632
> Project: HBase
> Issue Type: Sub-task
> Components: wal
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.4.0
>
>
> Means changing this value in HConstants to false:
>public static final boolean DEFAULT_HBASE_SPLIT_COORDINATED_BY_ZK = true;
> Should probably also deprecate the current zk distributed split too so we can
> clear out those classes to.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (HBASE-25255) Master fails to initialize when creating rs group table
[
https://issues.apache.org/jira/browse/HBASE-25255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang reassigned HBASE-25255:
-
Assignee: Duo Zhang
> Master fails to initialize when creating rs group table
> ---
>
> Key: HBASE-25255
> URL: https://issues.apache.org/jira/browse/HBASE-25255
> Project: HBase
> Issue Type: Bug
> Components: master, rsgroup
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Critical
> Attachments:
> TEST-org.apache.hadoop.hbase.rsgroup.TestRSGroupsKillRS.xml
>
>
> Saw this when setup TestRSGroupsKillRS
> {noformat}
> 2020-11-07 16:29:54,565 ERROR [master/e476f4f509a7:0:becomeActiveMaster]
> helpers.MarkerIgnoringBase(159): Failed to become active master
> java.lang.AssertionError
> at
> org.apache.hadoop.hbase.master.assignment.RegionStateNode.setProcedure(RegionStateNode.java:198)
> at
> org.apache.hadoop.hbase.master.assignment.AssignmentManager.createAssignProcedure(AssignmentManager.java:647)
> at
> org.apache.hadoop.hbase.master.assignment.AssignmentManager.lambda$null$6(AssignmentManager.java:878)
> at
> java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193)
> at
> java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193)
> at
> java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1382)
> at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:482)
> at
> java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472)
> at
> java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
> at
> java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
> at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
> at
> java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:485)
> at
> java.util.stream.ReferencePipeline$7$1.accept(ReferencePipeline.java:272)
> at
> java.util.HashMap$EntrySpliterator.forEachRemaining(HashMap.java:1699)
> at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:482)
> at
> java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472)
> at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:546)
> at
> java.util.stream.AbstractPipeline.evaluateToArrayNode(AbstractPipeline.java:260)
> at
> java.util.stream.ReferencePipeline.toArray(ReferencePipeline.java:505)
> at
> org.apache.hadoop.hbase.master.assignment.AssignmentManager.createAssignProcedures(AssignmentManager.java:879)
> at
> org.apache.hadoop.hbase.master.assignment.AssignmentManager.createRoundRobinAssignProcedures(AssignmentManager.java:759)
> at
> org.apache.hadoop.hbase.master.assignment.AssignmentManager.createRoundRobinAssignProcedures(AssignmentManager.java:775)
> at
> org.apache.hadoop.hbase.master.assignment.AssignmentManager.processOfflineRegions(AssignmentManager.java:1513)
> at
> org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:1012)
> at
> org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2116)
> at org.apache.hadoop.hbase.master.HMaster.lambda$run$0(HMaster.java:515)
> at java.lang.Thread.run(Thread.java:748)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2640: Backport: HBASE-25126 Add load balance logic in hbase-client to distribute read…
Apache-HBase commented on pull request #2640: URL: https://github.com/apache/hbase/pull/2640#issuecomment-725108199 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker mode activated. | | -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ HBASE-18070.branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 37s | HBASE-18070.branch-2 passed | | +1 :green_heart: | compile | 1m 24s | HBASE-18070.branch-2 passed | | +1 :green_heart: | shadedjars | 6m 1s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 4s | HBASE-18070.branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 21s | the patch passed | | +1 :green_heart: | compile | 1m 23s | the patch passed | | +1 :green_heart: | javac | 1m 23s | the patch passed | | +1 :green_heart: | shadedjars | 5m 59s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 24s | hbase-client generated 1 new + 3 unchanged - 0 fixed = 4 total (was 3) | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 17s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 138m 45s | hbase-server in the patch passed. | | | | 168m 36s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2640/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2640 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux a4b35d12dbbd 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-18070.branch-2 / e4e7386b39 | | Default Java | AdoptOpenJDK-1.8.0_232-b09 | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2640/2/artifact/yetus-jdk8-hadoop2-check/output/diff-javadoc-javadoc-hbase-client.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2640/2/testReport/ | | Max. process+thread count | 4396 (vs. ulimit of 12500) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2640/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work started] (HBASE-25272) Support scan on a specific replica
[ https://issues.apache.org/jira/browse/HBASE-25272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-25272 started by Duo Zhang. - > Support scan on a specific replica > -- > > Key: HBASE-25272 > URL: https://issues.apache.org/jira/browse/HBASE-25272 > Project: HBase > Issue Type: Improvement > Components: Client, scan >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Critical > Fix For: 2.4.0 > > > This is a missing part of the client library for sync client on branch-2, and > it is necessary when implementing meta replicas read. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25272) Support scan on a specific replica
[ https://issues.apache.org/jira/browse/HBASE-25272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17229679#comment-17229679 ] Duo Zhang commented on HBASE-25272: --- [~huaxiangsun] [~stack] FYI. > Support scan on a specific replica > -- > > Key: HBASE-25272 > URL: https://issues.apache.org/jira/browse/HBASE-25272 > Project: HBase > Issue Type: Improvement > Components: Client, scan >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Critical > Fix For: 2.4.0 > > > This is a missing part of the client library for sync client on branch-2, and > it is necessary when implementing meta replicas read. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-25272) Support scan on a specific replica
Duo Zhang created HBASE-25272: - Summary: Support scan on a specific replica Key: HBASE-25272 URL: https://issues.apache.org/jira/browse/HBASE-25272 Project: HBase Issue Type: Improvement Components: Client, scan Reporter: Duo Zhang Assignee: Duo Zhang Fix For: 2.4.0 This is a missing part of the client library for sync client on branch-2, and it is necessary when implementing meta replicas read. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work started] (HBASE-25272) Support scan on a specific replica
[ https://issues.apache.org/jira/browse/HBASE-25272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-25272 started by Duo Zhang. - > Support scan on a specific replica > -- > > Key: HBASE-25272 > URL: https://issues.apache.org/jira/browse/HBASE-25272 > Project: HBase > Issue Type: Improvement > Components: Client, scan >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Critical > Fix For: 2.4.0 > > > This is a missing part of the client library for sync client on branch-2, and > it is necessary when implementing meta replicas read. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work stopped] (HBASE-25272) Support scan on a specific replica
[ https://issues.apache.org/jira/browse/HBASE-25272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-25272 stopped by Duo Zhang. - > Support scan on a specific replica > -- > > Key: HBASE-25272 > URL: https://issues.apache.org/jira/browse/HBASE-25272 > Project: HBase > Issue Type: Improvement > Components: Client, scan >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Critical > Fix For: 2.4.0 > > > This is a missing part of the client library for sync client on branch-2, and > it is necessary when implementing meta replicas read. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache9 commented on pull request #2640: Backport: HBASE-25126 Add load balance logic in hbase-client to distribute read…
Apache9 commented on pull request #2640: URL: https://github.com/apache/hbase/pull/2640#issuecomment-725100501 Checked the code, we do not support scan on a specific replica... I think this should be a bug... Let me open an issue to address it, should not be very hard but the code is a bit mess so... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase-thirdparty] Apache-HBase commented on pull request #41: HBASE-25269 [hbase-thirdparty] Set version as 3.4.1 in prep for first RC
Apache-HBase commented on pull request #41: URL: https://github.com/apache/hbase-thirdparty/pull/41#issuecomment-725098602 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 4s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 0m 39s | master passed | | +1 :green_heart: | compile | 0m 49s | master passed | | +1 :green_heart: | javadoc | 0m 36s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 0m 25s | master passed | | +0 :ok: | mvndep | 0m 30s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 1m 29s | the patch passed | | +1 :green_heart: | compile | 0m 50s | the patch passed | | +1 :green_heart: | javac | 0m 50s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 5s | The patch has no ill-formed XML file. | | +1 :green_heart: | javadoc | 0m 35s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 12s | hbase-shaded-protobuf in the patch passed. | | +1 :green_heart: | unit | 0m 5s | hbase-shaded-netty in the patch passed. | | +1 :green_heart: | unit | 0m 5s | hbase-shaded-gson in the patch passed. | | +1 :green_heart: | unit | 0m 4s | hbase-shaded-miscellaneous in the patch passed. | | +1 :green_heart: | unit | 0m 5s | hbase-shaded-jetty in the patch passed. | | +1 :green_heart: | unit | 0m 6s | hbase-shaded-jersey in the patch passed. | | +1 :green_heart: | unit | 0m 12s | root in the patch passed. | | +1 :green_heart: | asflicense | 0m 32s | The patch does not generate ASF License warnings. | | | | 8m 43s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-Thirdparty-PreCommit/job/PR-41/1/artifact/yetus-precommit-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/41 | | Optional Tests | dupname asflicense javac javadoc unit xml compile | | uname | Linux 403aedf39112 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 GNU/Linux | | Build tool | maven | | git revision | master / 2a5b19f | | Default Java | Oracle Corporation-1.8.0_272-b10 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-Thirdparty-PreCommit/job/PR-41/1/testReport/ | | Max. process+thread count | 38 (vs. ulimit of 1000) | | modules | C: hbase-shaded-protobuf hbase-shaded-netty hbase-shaded-gson hbase-shaded-miscellaneous hbase-shaded-jetty hbase-shaded-jersey . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-Thirdparty-PreCommit/job/PR-41/1/console | | versions | git=2.20.1 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase-thirdparty] Apache9 opened a new pull request #41: HBASE-25269 [hbase-thirdparty] Set version as 3.4.1 in prep for first RC
Apache9 opened a new pull request #41: URL: https://github.com/apache/hbase-thirdparty/pull/41 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (HBASE-25269) [hbase-thirdparty] Set version as 3.4.1 in prep for first RC
Duo Zhang created HBASE-25269: - Summary: [hbase-thirdparty] Set version as 3.4.1 in prep for first RC Key: HBASE-25269 URL: https://issues.apache.org/jira/browse/HBASE-25269 Project: HBase Issue Type: Sub-task Components: thirdparty Reporter: Duo Zhang -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-25271) [hbase-thirdarty] Put up 3.4.0RC1
Duo Zhang created HBASE-25271: - Summary: [hbase-thirdarty] Put up 3.4.0RC1 Key: HBASE-25271 URL: https://issues.apache.org/jira/browse/HBASE-25271 Project: HBase Issue Type: Sub-task Reporter: Duo Zhang -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-25270) [hbase-thirdparty] Generate CHANGES.md and RELEASENOTES.md for 3.4.1
Duo Zhang created HBASE-25270: - Summary: [hbase-thirdparty] Generate CHANGES.md and RELEASENOTES.md for 3.4.1 Key: HBASE-25270 URL: https://issues.apache.org/jira/browse/HBASE-25270 Project: HBase Issue Type: Sub-task Components: thirdparty Reporter: Duo Zhang -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-25268) [hbase-thirdparty] Release 3.4.1
Duo Zhang created HBASE-25268: - Summary: [hbase-thirdparty] Release 3.4.1 Key: HBASE-25268 URL: https://issues.apache.org/jira/browse/HBASE-25268 Project: HBase Issue Type: Umbrella Reporter: Duo Zhang -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache9 commented on pull request #2640: Backport: HBASE-25126 Add load balance logic in hbase-client to distribute read…
Apache9 commented on pull request #2640: URL: https://github.com/apache/hbase/pull/2640#issuecomment-725090936 > > > > We do not support scan on a specific replica on branch-2? I think this should be a bug? We can set replica id on a Scan object? > > > > > > > > > Actually, it is not mentioned before that scan over a specific replica region is supported. Right now, Reverse scan is supported, I need to create a followup jira to support this over normal scan. > > > > > > For async client this is implemented. And for sync client on branch-2, we have timeline consistent read support for scan. IIRC, it is very complicated and spent me a lot of time to support the feature in async client. > > Let me read the code again. I could open a separated issue to support it on branch-2 to address the problem so you could rebase your patch later. > > Yeah, you are right. Both Async and Sync support timeline scan. There is no interface exposed to support meta scan over a replica region, maybe it is ok for now? No interface needed, just set the replicaId in the Scan object is enough? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2643: HBASE-18070
Apache-HBase commented on pull request #2643: URL: https://github.com/apache/hbase/pull/2643#issuecomment-725089746 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 39s | master passed | | +1 :green_heart: | compile | 1m 25s | master passed | | +1 :green_heart: | shadedjars | 6m 36s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 2s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 26s | the patch passed | | +1 :green_heart: | compile | 1m 21s | the patch passed | | +1 :green_heart: | javac | 1m 21s | the patch passed | | +1 :green_heart: | shadedjars | 6m 33s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 40s | hbase-server generated 1 new + 15 unchanged - 0 fixed = 16 total (was 15) | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 3s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 142m 58s | hbase-server in the patch passed. | | | | 172m 53s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2643/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2643 | | JIRA Issue | HBASE-18070 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 19fcf14af68b 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f0c430aed2 | | Default Java | AdoptOpenJDK-1.8.0_232-b09 | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2643/1/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2643/1/testReport/ | | Max. process+thread count | 3926 (vs. ulimit of 3) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2643/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ankitsinghal commented on a change in pull request #2546: HBASE-24813 ReplicationSource should clear buffer usage on Replicatio…
ankitsinghal commented on a change in pull request #2546:
URL: https://github.com/apache/hbase/pull/2546#discussion_r520999059
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
##
@@ -684,17 +684,17 @@ public void terminate(String reason, Exception cause,
boolean clearMetrics,
Threads.shutdown(initThread, this.sleepForRetries);
}
Collection workers = workerThreads.values();
-for (ReplicationSourceShipper worker : workers) {
- worker.stopWorker();
- if(worker.entryReader != null) {
-worker.entryReader.setReaderRunning(false);
- }
-}
+
if (this.replicationEndpoint != null) {
this.replicationEndpoint.stop();
}
+
for (ReplicationSourceShipper worker : workers) {
+ worker.stopWorker();
+ if (worker.entryReader != null) {
+worker.entryReader.setReaderRunning(false);
Review comment:
sure, let me try to explain again.
I was referring to restore this loop.
```
for (ReplicationSourceShipper worker : workers) {
worker.stopWorker();
if(worker.entryReader != null) {
worker.entryReader.setReaderRunning(false);
}
}
```
As your current flow is stopping the worker in a linear manner:-
* Stop a worker
* wait for the worker thread to complete.
* stop another worker
* wait for it finishes
* continue for others..
So in the worst case, you would have to wait for the number of workers *
min(time taken by the worker to finish, timeout)
though by restoring the old loop, you are parallelizing the stopping of the
workers.
* ask all worker threads to finish their work by setting their state.
* then in the second loop, wait for each worker to finish, while you are
waiting for 1 worker, others are also completing their work in parallel.
* so when you are done with one worker it is possible that all other workers
are also done.
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceShipper.java
##
@@ -325,4 +327,53 @@ void stopWorker() {
public boolean isFinished() {
return state == WorkerState.FINISHED;
}
+
+ /**
+ * Attempts to properly update
ReplicationSourceManager.totalBufferUser,
+ * in case there were unprocessed entries batched by the reader to the
shipper,
+ * but the shipper didn't manage to ship those because the replication
source is being terminated.
+ * In that case, it iterates through the batched entries and decrease the
pending
+ * entries size from ReplicationSourceManager.totalBufferUser
+ *
+ * NOTES
+ * 1) This method should only be called upon replication source termination.
+ * It blocks waiting for both shipper and reader threads termination,
+ * to make sure no race conditions
+ * when updating ReplicationSourceManager.totalBufferUser.
+ *
+ * 2) It does not attempt to terminate reader and shipper threads.
Those must
+ * have been triggered interruption/termination prior to calling this method.
+ */
+ void clearWALEntryBatch() {
+long timeout = System.currentTimeMillis() + this.shipEditsTimeout;
+while(this.isAlive() || this.entryReader.isAlive()){
+ try {
+if (System.currentTimeMillis() >= timeout) {
+ LOG.warn("Interrupting source thread for peer {} without cleaning
buffer usage "
++ "because clearWALEntryBatch method timed out whilst waiting
reader/shipper "
++ "thread to stop.", this.source.getPeerId());
+ Thread.currentThread().interrupt();
Review comment:
> * 1) This method should only be called upon replication source
termination.
so what this interrupt will do, how is it handled in the source?
```
LOG.warn("Interrupting source thread for peer {} without cleaning buffer
usage "
+ "because clearWALEntryBatch method timed out whilst waiting
reader/shipper "
+ "thread to stop.", this.source.getPeerId());
```
don't we need to return here as we timed out and not clearing the batch?
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceShipper.java
##
@@ -325,4 +327,53 @@ void stopWorker() {
public boolean isFinished() {
return state == WorkerState.FINISHED;
}
+
+ /**
+ * Attempts to properly update
ReplicationSourceManager.totalBufferUser,
+ * in case there were unprocessed entries batched by the reader to the
shipper,
+ * but the shipper didn't manage to ship those because the replication
source is being terminated.
+ * In that case, it iterates through the batched entries and decrease the
pending
+ * entries size from ReplicationSourceManager.totalBufferUser
+ *
+ * NOTES
+ * 1) This method should only be called upon replication source terminat
[GitHub] [hbase] huaxiangsun commented on pull request #2640: Backport: HBASE-25126 Add load balance logic in hbase-client to distribute read…
huaxiangsun commented on pull request #2640: URL: https://github.com/apache/hbase/pull/2640#issuecomment-725087113 > > > We do not support scan on a specific replica on branch-2? I think this should be a bug? We can set replica id on a Scan object? > > > > > > Actually, it is not mentioned before that scan over a specific replica region is supported. Right now, Reverse scan is supported, I need to create a followup jira to support this over normal scan. > > For async client this is implemented. And for sync client on branch-2, we have timeline consistent read support for scan. IIRC, it is very complicated and spent me a lot of time to support the feature in async client. > > Let me read the code again. I could open a separated issue to support it on branch-2 to address the problem so you could rebase your patch later. Yeah, you are right. Both Async and Sync support timeline scan. There is no interface exposed to support meta scan over a replica region, maybe it is ok for now? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (HBASE-25265) [hbase-thirdparty] Bump dependencis in hbase-thirdparty
[ https://issues.apache.org/jira/browse/HBASE-25265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-25265. --- Hadoop Flags: Reviewed Resolution: Fixed Merged to master. Thanks [~GeorryHuang] for contributing. > [hbase-thirdparty] Bump dependencis in hbase-thirdparty > --- > > Key: HBASE-25265 > URL: https://issues.apache.org/jira/browse/HBASE-25265 > Project: HBase > Issue Type: Task > Components: dependencies, hbase-thirdparty >Reporter: Duo Zhang >Assignee: Zhuoyue Huang >Priority: Major > Fix For: thirdpart-3.4.1 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-25264) [hbase-thirdparty] Update jersey version in hbase-thirdparty
[ https://issues.apache.org/jira/browse/HBASE-25264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-25264. --- Hadoop Flags: Reviewed Resolution: Fixed Merged to master. Thanks [~GeorryHuang] for contributing. > [hbase-thirdparty] Update jersey version in hbase-thirdparty > > > Key: HBASE-25264 > URL: https://issues.apache.org/jira/browse/HBASE-25264 > Project: HBase > Issue Type: Task > Components: dependencies, hbase-thirdparty >Reporter: Duo Zhang >Assignee: Zhuoyue Huang >Priority: Major > Fix For: thirdpart-3.4.1 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase-thirdparty] Apache9 merged pull request #40: HBASE-25265 [hbase-thirdparty] Bump dependencis in hbase-thirdparty
Apache9 merged pull request #40: URL: https://github.com/apache/hbase-thirdparty/pull/40 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase-thirdparty] Apache9 merged pull request #39: HBASE-25264 [hbase-thirdparty] Update jersey version in hbase-thirdparty
Apache9 merged pull request #39: URL: https://github.com/apache/hbase-thirdparty/pull/39 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on a change in pull request #2627: HBASE-25251 Enable configuration based enable/disable of Unsafe packa…
Apache9 commented on a change in pull request #2627: URL: https://github.com/apache/hbase/pull/2627#discussion_r521012570 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/util/UnsafeAvailChecker.java ## @@ -33,12 +35,16 @@ private static final Logger LOG = LoggerFactory.getLogger(UnsafeAvailChecker.class); private static boolean avail = false; private static boolean unaligned = false; + // Flag that can be set by clients to enable/disable Unsafe package usage + private static boolean useUnsafe; Review comment: Could we make use of a environment variable to enable or disable the unsafe usage? I do not expect we should support switching the unsafe usage on the fly This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on a change in pull request #2644: HBASE-25127 Enhance PerformanceEvaluation to profile meta replica performance.
Apache9 commented on a change in pull request #2644:
URL: https://github.com/apache/hbase/pull/2644#discussion_r521010199
##
File path:
hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java
##
@@ -1998,6 +2006,41 @@ protected void testTakedown() throws IOException {
super.testTakedown();
}
}
+ static class MetaRandomReadTest extends TableTest {
+private Random rd = new Random();
+private RegionLocator regionLocator;
+
+MetaRandomReadTest(Connection con, TestOptions options, Status status) {
+ super(con, options, status);
+ LOG.info("call getRegionLocation");
+}
+
+@Override
+void onStartup() throws IOException {
+ this.table = connection.getTable(TableName.valueOf("hbase:meta"));
+ this.regionLocator =
connection.getRegionLocator(TableName.valueOf("hbase:meta"));
+}
+
+@Override
+boolean testRow(final int i, final long startTime) throws IOException,
InterruptedException {
+ if (opts.randomSleep > 0) {
+Thread.sleep(rd.nextInt(opts.randomSleep));
+ }
+ HRegionLocation hRegionLocation =
regionLocator.getRegionLocation(Bytes.toBytes(Integer.toString(rd.nextInt(100)
+ 1)), true);
Review comment:
the return value is not used?
##
File path:
hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java
##
@@ -2276,7 +2319,38 @@ boolean testRow(final int i, final long startTime)
throws IOException {
return true;
}
}
+ static class MetaWriteTest extends Test {
+
+MetaWriteTest(Connection con, TestOptions options, Status status) {
+ super(con, options, status);
+}
+
+@Override
+void onStartup() throws IOException {
+}
+@Override
+void onTakedown() throws IOException {
+}
+@Override
+boolean testRow(final int i, final long startTime) throws IOException {
+ List regionInfos = new ArrayList();
+
+ for (int index = 0; index < i; index++) {
+
regionInfos.add(RegionInfoBuilder.newBuilder(TableName.valueOf("hbase:meta"))
Review comment:
This will be a bit confusing that we add "hbase:meta" to hbase:meta?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #2640: Backport: HBASE-25126 Add load balance logic in hbase-client to distribute read…
Apache9 commented on pull request #2640: URL: https://github.com/apache/hbase/pull/2640#issuecomment-725074601 > > We do not support scan on a specific replica on branch-2? I think this should be a bug? We can set replica id on a Scan object? > > Actually, it is not mentioned before that scan over a specific replica region is supported. Right now, Reverse scan is supported, I need to create a followup jira to support this over normal scan. For async client this is implemented. And for sync client on branch-2, we have timeline consistent read support for scan. IIRC, it is very complicated and spent me a lot of time to support the feature in async client. Let me read the code again. I could open a separated issue to support it on branch-2 to address the problem so you could rebase your patch later. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on a change in pull request #2640: Backport: HBASE-25126 Add load balance logic in hbase-client to distribute read…
Apache9 commented on a change in pull request #2640: URL: https://github.com/apache/hbase/pull/2640#discussion_r521003149 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java ## @@ -161,7 +165,11 @@ private final boolean hostnamesCanChange; private final long pause; private final long pauseForCQTBE;// pause for CallQueueTooBigException, if specified - private boolean useMetaReplicas; Review comment: OK, I got your point. Here the' useMetaReplicas' flag is only for locating region, so it is fine to remove it. The "hbase.meta.replicas.use" config will still be honored here, and at other places, we will still check the "hbase.meta.replicas.use" config separately. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2483: HBASE-25026 - Create a metric to track scans that have no start row and/or stop row
Apache-HBase commented on pull request #2483: URL: https://github.com/apache/hbase/pull/2483#issuecomment-725069912 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 7s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 29s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 53s | master passed | | +1 :green_heart: | compile | 1m 15s | master passed | | +1 :green_heart: | shadedjars | 7m 7s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 51s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 51s | the patch passed | | +1 :green_heart: | compile | 1m 15s | the patch passed | | +1 :green_heart: | javac | 1m 15s | the patch passed | | +1 :green_heart: | shadedjars | 7m 7s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 51s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 36s | hbase-hadoop-compat in the patch passed. | | +1 :green_heart: | unit | 205m 10s | hbase-server in the patch passed. | | | | 235m 47s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2483/20/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2483 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux bdbad3d4c6bb 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f0c430aed2 | | Default Java | AdoptOpenJDK-1.8.0_232-b09 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2483/20/testReport/ | | Max. process+thread count | 3365 (vs. ulimit of 3) | | modules | C: hbase-hadoop-compat hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2483/20/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2644: HBASE-25127 Enhance PerformanceEvaluation to profile meta replica performance.
Apache-HBase commented on pull request #2644: URL: https://github.com/apache/hbase/pull/2644#issuecomment-725068660 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 35s | master passed | | +1 :green_heart: | compile | 0m 31s | master passed | | +1 :green_heart: | shadedjars | 8m 58s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 27s | master passed | | -0 :warning: | patch | 9m 37s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 25s | the patch passed | | +1 :green_heart: | compile | 0m 32s | the patch passed | | +1 :green_heart: | javac | 0m 32s | the patch passed | | +1 :green_heart: | shadedjars | 9m 12s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 27s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 12m 16s | hbase-mapreduce in the patch passed. | | | | 45m 18s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2644/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2644 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 036ea5db24f7 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f0c430aed2 | | Default Java | AdoptOpenJDK-11.0.6+10 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2644/1/testReport/ | | Max. process+thread count | 3911 (vs. ulimit of 3) | | modules | C: hbase-mapreduce U: hbase-mapreduce | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2644/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24632) Enable procedure-based log splitting as default in hbase3
[ https://issues.apache.org/jira/browse/HBASE-24632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17229625#comment-17229625 ] Guanghao Zhang commented on HBASE-24632: [~stack] [~anoop.hbase] The zk based log splitting is only a internal implenation. Can we purge them out in master branch and no need wait to 4.0.0? > Enable procedure-based log splitting as default in hbase3 > - > > Key: HBASE-24632 > URL: https://issues.apache.org/jira/browse/HBASE-24632 > Project: HBase > Issue Type: Sub-task > Components: wal >Reporter: Michael Stack >Assignee: Michael Stack >Priority: Major > Fix For: 3.0.0-alpha-1, 2.4.0 > > > Means changing this value in HConstants to false: >public static final boolean DEFAULT_HBASE_SPLIT_COORDINATED_BY_ZK = true; > Should probably also deprecate the current zk distributed split too so we can > clear out those classes to. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2644: HBASE-25127 Enhance PerformanceEvaluation to profile meta replica performance.
Apache-HBase commented on pull request #2644: URL: https://github.com/apache/hbase/pull/2644#issuecomment-725065685 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 44s | master passed | | +1 :green_heart: | checkstyle | 0m 21s | master passed | | +1 :green_heart: | spotbugs | 0m 44s | master passed | | -0 :warning: | patch | 0m 53s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 29s | the patch passed | | -0 :warning: | checkstyle | 0m 19s | hbase-mapreduce: The patch generated 1 new + 42 unchanged - 0 fixed = 43 total (was 42) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 17m 15s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. | | +1 :green_heart: | spotbugs | 1m 50s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 12s | The patch does not generate ASF License warnings. | | | | 36m 21s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2644/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2644 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux f27bcee38a80 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f0c430aed2 | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2644/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-mapreduce.txt | | Max. process+thread count | 94 (vs. ulimit of 3) | | modules | C: hbase-mapreduce U: hbase-mapreduce | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2644/1/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=3.1.12 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2640: Backport: HBASE-25126 Add load balance logic in hbase-client to distribute read…
Apache-HBase commented on pull request #2640: URL: https://github.com/apache/hbase/pull/2640#issuecomment-725064999 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 7m 28s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ HBASE-18070.branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 35s | HBASE-18070.branch-2 passed | | +1 :green_heart: | checkstyle | 1m 39s | HBASE-18070.branch-2 passed | | +1 :green_heart: | spotbugs | 3m 3s | HBASE-18070.branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 16s | the patch passed | | -0 :warning: | checkstyle | 0m 33s | hbase-client: The patch generated 1 new + 40 unchanged - 0 fixed = 41 total (was 40) | | -0 :warning: | checkstyle | 1m 7s | hbase-server: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 40s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 3m 20s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 26s | The patch does not generate ASF License warnings. | | | | 44m 18s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2640/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2640 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 5c10e0d15ca2 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-18070.branch-2 / e4e7386b39 | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2640/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2640/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 94 (vs. ulimit of 12500) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2640/2/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=3.1.12 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2644: HBASE-25127 Enhance PerformanceEvaluation to profile meta replica performance.
Apache-HBase commented on pull request #2644: URL: https://github.com/apache/hbase/pull/2644#issuecomment-725064859 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 47s | master passed | | +1 :green_heart: | compile | 0m 24s | master passed | | +1 :green_heart: | shadedjars | 6m 43s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 20s | master passed | | -0 :warning: | patch | 7m 14s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 34s | the patch passed | | +1 :green_heart: | compile | 0m 24s | the patch passed | | +1 :green_heart: | javac | 0m 24s | the patch passed | | +1 :green_heart: | shadedjars | 6m 33s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 17s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 10m 12s | hbase-mapreduce in the patch passed. | | | | 33m 56s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2644/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2644 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 27a8efc86023 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f0c430aed2 | | Default Java | AdoptOpenJDK-1.8.0_232-b09 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2644/1/testReport/ | | Max. process+thread count | 4470 (vs. ulimit of 3) | | modules | C: hbase-mapreduce U: hbase-mapreduce | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2644/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] clarax opened a new pull request #2644: HBASE-25127 Enhance PerformanceEvaluation to profile meta replica performance.
clarax opened a new pull request #2644: URL: https://github.com/apache/hbase/pull/2644 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2627: HBASE-25251 Enable configuration based enable/disable of Unsafe packa…
Apache-HBase commented on pull request #2627: URL: https://github.com/apache/hbase/pull/2627#issuecomment-725052001 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 39s | master passed | | +1 :green_heart: | checkstyle | 0m 28s | master passed | | +1 :green_heart: | spotbugs | 0m 42s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 31s | the patch passed | | -0 :warning: | checkstyle | 0m 26s | hbase-common: The patch generated 1 new + 84 unchanged - 0 fixed = 85 total (was 84) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 18m 55s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. | | +1 :green_heart: | spotbugs | 0m 52s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 13s | The patch does not generate ASF License warnings. | | | | 37m 35s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2627/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2627 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle xml | | uname | Linux 7fb142318c45 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f0c430aed2 | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2627/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-common.txt | | Max. process+thread count | 94 (vs. ulimit of 3) | | modules | C: hbase-common U: hbase-common | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2627/3/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=3.1.12 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (HBASE-25127) Enhance PerformanceEvaluation to profile meta replica performance.
[ https://issues.apache.org/jira/browse/HBASE-25127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clara Xiong reassigned HBASE-25127: --- Assignee: Clara Xiong (was: Huaxiang Sun) > Enhance PerformanceEvaluation to profile meta replica performance. > -- > > Key: HBASE-25127 > URL: https://issues.apache.org/jira/browse/HBASE-25127 > Project: HBase > Issue Type: Sub-task >Reporter: Huaxiang Sun >Assignee: Clara Xiong >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] huaxiangsun commented on a change in pull request #2640: Backport: HBASE-25126 Add load balance logic in hbase-client to distribute read…
huaxiangsun commented on a change in pull request #2640:
URL: https://github.com/apache/hbase/pull/2640#discussion_r520961582
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
##
@@ -332,19 +338,59 @@ public void newDead(ServerName sn) {
close();
throw e;
}
+
+// Get the region locator's meta replica mode.
+this.metaReplicaMode =
CatalogReplicaMode.fromString(conf.get(LOCATOR_META_REPLICAS_MODE,
+ CatalogReplicaMode.NONE.toString()));
+
+switch (this.metaReplicaMode) {
+ case LOAD_BALANCE:
+String replicaSelectorClass = conf.get(
+ RegionLocator.LOCATOR_META_REPLICAS_MODE_LOADBALANCE_SELECTOR,
+ CatalogReplicaLoadBalanceSimpleSelector.class.getName());
+
+this.metaReplicaSelector =
CatalogReplicaLoadBalanceSelectorFactory.createSelector(
+ replicaSelectorClass, META_TABLE_NAME, getChoreService(), () -> {
+int numOfReplicas = 1;
+try {
+ RegionLocations metaLocations =
registry.getMetaRegionLocations().get(
+connectionConfig.getReadRpcTimeout(), TimeUnit.MILLISECONDS);
+ numOfReplicas = metaLocations.size();
+} catch (Exception e) {
+ LOG.error("Failed to get table {}'s region replication, ",
META_TABLE_NAME, e);
+}
+return numOfReplicas;
+ });
+break;
+ case NONE:
+// If user does not configure LOCATOR_META_REPLICAS_MODE, let's check
the legacy config.
+
+boolean useMetaReplicas = conf.getBoolean(USE_META_REPLICAS,
+ DEFAULT_USE_META_REPLICAS);
+if (useMetaReplicas) {
+ this.metaReplicaMode = CatalogReplicaMode.HEDGED_READ;
+}
+break;
+ default:
+// Doing nothing
+}
}
private void spawnRenewalChore(final UserGroupInformation user) {
-authService = new ChoreService("Relogin service");
-authService.scheduleChore(AuthUtil.getAuthRenewalChore(user));
+ChoreService service = getChoreService();
+service.scheduleChore(AuthUtil.getAuthRenewalChore(user));
}
/**
* @param useMetaReplicas
*/
@VisibleForTesting
void setUseMetaReplicas(final boolean useMetaReplicas) {
-this.useMetaReplicas = useMetaReplicas;
Review comment:
will work on this later tonight.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2483: HBASE-25026 - Create a metric to track scans that have no start row and/or stop row
Apache-HBase commented on pull request #2483: URL: https://github.com/apache/hbase/pull/2483#issuecomment-725050788 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 5m 35s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 21s | master passed | | +1 :green_heart: | compile | 1m 31s | master passed | | +1 :green_heart: | shadedjars | 6m 44s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 0s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 12s | the patch passed | | +1 :green_heart: | compile | 1m 31s | the patch passed | | +1 :green_heart: | javac | 1m 31s | the patch passed | | +1 :green_heart: | shadedjars | 6m 59s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 58s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 36s | hbase-hadoop-compat in the patch passed. | | +1 :green_heart: | unit | 140m 33s | hbase-server in the patch passed. | | | | 177m 4s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2483/20/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2483 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux f7cc290a85d1 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f0c430aed2 | | Default Java | AdoptOpenJDK-11.0.6+10 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2483/20/testReport/ | | Max. process+thread count | 3818 (vs. ulimit of 3) | | modules | C: hbase-hadoop-compat hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2483/20/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] huaxiangsun commented on pull request #2640: Backport: HBASE-25126 Add load balance logic in hbase-client to distribute read…
huaxiangsun commented on pull request #2640: URL: https://github.com/apache/hbase/pull/2640#issuecomment-725050749 Uploaded a new patch which fixes unitest errors. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2642: HBASE-25267 Add SSL keystore type and truststore related configs for HBase RESTServer
Apache-HBase commented on pull request #2642: URL: https://github.com/apache/hbase/pull/2642#issuecomment-725049827 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 11s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 21s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 8s | master passed | | +1 :green_heart: | checkstyle | 0m 29s | master passed | | +1 :green_heart: | spotbugs | 1m 10s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 49s | the patch passed | | -0 :warning: | checkstyle | 0m 16s | hbase-rest: The patch generated 1 new + 33 unchanged - 0 fixed = 34 total (was 33) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 19m 33s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. | | -1 :x: | spotbugs | 0m 52s | hbase-rest generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 21s | The patch does not generate ASF License warnings. | | | | 41m 24s | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-rest | | | Should org.apache.hadoop.hbase.rest.client.Client$ClientTrustStoreInitializationException be a _static_ inner class? At Client.java:inner class? At Client.java:[lines 787-789] | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2642/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2642 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 48b7141fdb1e 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f0c430aed2 | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2642/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-rest.txt | | spotbugs | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2642/2/artifact/yetus-general-check/output/new-spotbugs-hbase-rest.html | | Max. process+thread count | 84 (vs. ulimit of 3) | | modules | C: hbase-http hbase-rest U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2642/2/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=3.1.12 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2627: HBASE-25251 Enable configuration based enable/disable of Unsafe packa…
Apache-HBase commented on pull request #2627: URL: https://github.com/apache/hbase/pull/2627#issuecomment-725049347 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 25s | master passed | | +1 :green_heart: | compile | 0m 27s | master passed | | +1 :green_heart: | shadedjars | 7m 1s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 26s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 17s | the patch passed | | +1 :green_heart: | compile | 0m 27s | the patch passed | | +1 :green_heart: | javac | 0m 27s | the patch passed | | +1 :green_heart: | shadedjars | 6m 59s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 25s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 37s | hbase-common in the patch passed. | | | | 28m 41s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2627/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2627 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 8662a283c653 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f0c430aed2 | | Default Java | AdoptOpenJDK-11.0.6+10 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2627/3/testReport/ | | Max. process+thread count | 274 (vs. ulimit of 3) | | modules | C: hbase-common U: hbase-common | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2627/3/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2627: HBASE-25251 Enable configuration based enable/disable of Unsafe packa…
Apache-HBase commented on pull request #2627: URL: https://github.com/apache/hbase/pull/2627#issuecomment-725048716 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 54s | master passed | | +1 :green_heart: | compile | 0m 26s | master passed | | +1 :green_heart: | shadedjars | 6m 34s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 24s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 11s | the patch passed | | +1 :green_heart: | compile | 0m 25s | the patch passed | | +1 :green_heart: | javac | 0m 25s | the patch passed | | +1 :green_heart: | shadedjars | 6m 40s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 21s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 19s | hbase-common in the patch passed. | | | | 26m 56s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2627/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2627 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 37126e7d9064 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f0c430aed2 | | Default Java | AdoptOpenJDK-1.8.0_232-b09 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2627/3/testReport/ | | Max. process+thread count | 339 (vs. ulimit of 3) | | modules | C: hbase-common U: hbase-common | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2627/3/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2643: HBASE-18070
Apache-HBase commented on pull request #2643: URL: https://github.com/apache/hbase/pull/2643#issuecomment-725048503 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 41s | master passed | | +1 :green_heart: | checkstyle | 1m 41s | master passed | | +1 :green_heart: | spotbugs | 2m 55s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 27s | the patch passed | | -0 :warning: | checkstyle | 1m 11s | hbase-server: The patch generated 3 new + 265 unchanged - 11 fixed = 268 total (was 276) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 17m 14s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. | | +1 :green_heart: | spotbugs | 3m 14s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 26s | The patch does not generate ASF License warnings. | | | | 43m 6s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2643/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2643 | | JIRA Issue | HBASE-18070 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux f4967955e3f9 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f0c430aed2 | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2643/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 94 (vs. ulimit of 3) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2643/1/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=3.1.12 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2642: HBASE-25267 Add SSL keystore type and truststore related configs for HBase RESTServer
Apache-HBase commented on pull request #2642: URL: https://github.com/apache/hbase/pull/2642#issuecomment-725047891 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 49s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 52s | master passed | | +1 :green_heart: | compile | 0m 53s | master passed | | +1 :green_heart: | shadedjars | 8m 21s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 47s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 6s | the patch passed | | +1 :green_heart: | compile | 0m 48s | the patch passed | | +1 :green_heart: | javac | 0m 48s | the patch passed | | +1 :green_heart: | shadedjars | 7m 14s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 39s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 43s | hbase-http in the patch passed. | | -1 :x: | unit | 3m 9s | hbase-rest in the patch failed. | | | | 35m 27s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2642/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2642 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 4c7311926bef 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f0c430aed2 | | Default Java | AdoptOpenJDK-11.0.6+10 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2642/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-rest.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2642/2/testReport/ | | Max. process+thread count | 2432 (vs. ulimit of 3) | | modules | C: hbase-http hbase-rest U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2642/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2642: HBASE-25267 Add SSL keystore type and truststore related configs for HBase RESTServer
Apache-HBase commented on pull request #2642: URL: https://github.com/apache/hbase/pull/2642#issuecomment-725045709 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 23s | master passed | | +1 :green_heart: | compile | 0m 45s | master passed | | +1 :green_heart: | shadedjars | 6m 38s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 35s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 33s | the patch passed | | +1 :green_heart: | compile | 0m 47s | the patch passed | | +1 :green_heart: | javac | 0m 47s | the patch passed | | +1 :green_heart: | shadedjars | 6m 26s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 33s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 42s | hbase-http in the patch passed. | | -1 :x: | unit | 3m 28s | hbase-rest in the patch failed. | | | | 29m 12s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2642/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2642 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 4239d1b54d5a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f0c430aed2 | | Default Java | AdoptOpenJDK-1.8.0_232-b09 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2642/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-rest.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2642/2/testReport/ | | Max. process+thread count | 2693 (vs. ulimit of 3) | | modules | C: hbase-http hbase-rest U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2642/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-25267) Add SSL keystore type and truststore related configs for HBase RESTServer
[
https://issues.apache.org/jira/browse/HBASE-25267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mate Szalay-Beko updated HBASE-25267:
-
Description:
The RESTServer currently relies on the following parameters to configure SSL on
the REST API:
* {{hbase.rest.ssl.enabled}}
* {{hbase.rest.ssl.keystore.store}}
* {{hbase.rest.ssl.keystore.password}}
* {{hbase.rest.ssl.keystore.keypassword}}
* {{hbase.rest.ssl.exclude.cipher.suites}}
* {{hbase.rest.ssl.include.cipher.suites}}
* {{hbase.rest.ssl.exclude.protocols}}
* {{hbase.rest.ssl.include.protocols}}
In this patch I want to introduce the following new parameters:
* {{hbase.rest.ssl.keystore.type}}
* {{hbase.rest.ssl.truststore.store}}
* {{hbase.rest.ssl.truststore.password}}
* {{hbase.rest.ssl.truststore.type}}
If any of the new the parameter is not provided, then we should fall-back to
the current behaviour (e.g. assuming JKS keystore/truststore types, or no
passwords, or no custom trust store file).
was:
The keystore configuration of the RESTServer currently relies on the following
parameters to configure SSL:
* hbase.rest.ssl.enabled
* hbase.rest.ssl.keystore.store
* hbase.rest.ssl.keystore.password
* hbase.rest.ssl.keystore.keypassword
* hbase.rest.ssl.exclude.cipher.suites
* hbase.rest.ssl.include.cipher.suites
* hbase.rest.ssl.exclude.protocols
* hbase.rest.ssl.include.protocols
In this patch I want to introduce the following new parameters:
* {{hbase.rest.ssl.keystore.type}}
* {{hbase.rest.ssl.truststore.store}}
* {{hbase.rest.ssl.}}{{truststore}}{{.password}}
* {{hbase.rest.ssl.}}{{truststore}}{{.type}}
If any of the new the parameter is not provided, then we should fall-back to
the current behaviour (e.g. assuming JKS keystore/truststore types, or no
passwords, or no custom trust store file).
> Add SSL keystore type and truststore related configs for HBase RESTServer
> -
>
> Key: HBASE-25267
> URL: https://issues.apache.org/jira/browse/HBASE-25267
> Project: HBase
> Issue Type: Improvement
> Components: REST
>Reporter: Mate Szalay-Beko
>Assignee: Mate Szalay-Beko
>Priority: Major
>
> The RESTServer currently relies on the following parameters to configure SSL
> on the REST API:
> * {{hbase.rest.ssl.enabled}}
> * {{hbase.rest.ssl.keystore.store}}
> * {{hbase.rest.ssl.keystore.password}}
> * {{hbase.rest.ssl.keystore.keypassword}}
> * {{hbase.rest.ssl.exclude.cipher.suites}}
> * {{hbase.rest.ssl.include.cipher.suites}}
> * {{hbase.rest.ssl.exclude.protocols}}
> * {{hbase.rest.ssl.include.protocols}}
> In this patch I want to introduce the following new parameters:
> * {{hbase.rest.ssl.keystore.type}}
> * {{hbase.rest.ssl.truststore.store}}
> * {{hbase.rest.ssl.truststore.password}}
> * {{hbase.rest.ssl.truststore.type}}
> If any of the new the parameter is not provided, then we should fall-back to
> the current behaviour (e.g. assuming JKS keystore/truststore types, or no
> passwords, or no custom trust store file).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-25267) Add SSL keystore type and truststore related configs for HBase RESTServer
[
https://issues.apache.org/jira/browse/HBASE-25267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mate Szalay-Beko updated HBASE-25267:
-
Summary: Add SSL keystore type and truststore related configs for HBase
RESTServer (was: Make SSL truststore and keystore type configurable in HBase
RESTServer)
> Add SSL keystore type and truststore related configs for HBase RESTServer
> -
>
> Key: HBASE-25267
> URL: https://issues.apache.org/jira/browse/HBASE-25267
> Project: HBase
> Issue Type: Improvement
> Components: REST
>Reporter: Mate Szalay-Beko
>Assignee: Mate Szalay-Beko
>Priority: Major
>
> The keystore configuration of the RESTServer currently relies on the
> following parameters to configure SSL:
> * hbase.rest.ssl.enabled
> * hbase.rest.ssl.keystore.store
> * hbase.rest.ssl.keystore.password
> * hbase.rest.ssl.keystore.keypassword
> * hbase.rest.ssl.exclude.cipher.suites
> * hbase.rest.ssl.include.cipher.suites
> * hbase.rest.ssl.exclude.protocols
> * hbase.rest.ssl.include.protocols
> In this patch I want to introduce the following new parameters:
> * {{hbase.rest.ssl.keystore.type}}
> * {{hbase.rest.ssl.truststore.store}}
> * {{hbase.rest.ssl.}}{{truststore}}{{.password}}
> * {{hbase.rest.ssl.}}{{truststore}}{{.type}}
> If any of the new the parameter is not provided, then we should fall-back to
> the current behaviour (e.g. assuming JKS keystore/truststore types, or no
> passwords, or no custom trust store file).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] saintstack opened a new pull request #2643: HBASE-18070
saintstack opened a new pull request #2643: URL: https://github.com/apache/hbase/pull/2643 Check unit tests before merge attempt This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] huaxiangsun commented on a change in pull request #2640: Backport: HBASE-25126 Add load balance logic in hbase-client to distribute read…
huaxiangsun commented on a change in pull request #2640:
URL: https://github.com/apache/hbase/pull/2640#discussion_r520937824
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ReversedClientScanner.java
##
@@ -64,7 +64,9 @@ protected boolean setNewStartKey() {
@Override
protected ReversedScannerCallable createScannerCallable() {
+// In case of meta, we want to support scan over a replica region.
+int replicaId = (scan.getConsistency() == Consistency.TIMELINE) ?
scan.getReplicaId() : 0;
Review comment:
For testing failures, it is my misunderstanding of the default
targetReplicaId is 0 (actually it is -1). Introduce a utility method to
differentiate the case for scan over a specific replica region in TIMELINE mode.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] huaxiangsun commented on pull request #2640: Backport: HBASE-25126 Add load balance logic in hbase-client to distribute read…
huaxiangsun commented on pull request #2640: URL: https://github.com/apache/hbase/pull/2640#issuecomment-725027005 > We do not support scan on a specific replica on branch-2? I think this should be a bug? We can set replica id on a Scan object? Actually, it is not mentioned before that scan over a specific replica region is supported. Right now, Reverse scan is supported, I need to create a followup jira to support this over normal scan. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] huaxiangsun commented on a change in pull request #2640: Backport: HBASE-25126 Add load balance logic in hbase-client to distribute read…
huaxiangsun commented on a change in pull request #2640:
URL: https://github.com/apache/hbase/pull/2640#discussion_r520936401
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
##
@@ -841,8 +898,23 @@ private RegionLocations locateRegionInMeta(TableName
tableName, byte[] row, bool
Scan s = new Scan().withStartRow(metaStartKey).withStopRow(metaStopKey,
true)
.addFamily(HConstants.CATALOG_FAMILY).setReversed(true).setCaching(5)
.setReadType(ReadType.PREAD);
-if (this.useMetaReplicas) {
- s.setConsistency(Consistency.TIMELINE);
+
+switch (this.metaReplicaMode) {
+ case LOAD_BALANCE:
+int metaReplicaId = this.metaReplicaSelector.select(tableName, row,
+ RegionLocateType.CURRENT);
+if (metaReplicaId != RegionInfo.DEFAULT_REPLICA_ID) {
+ // If the selector gives a non-primary meta replica region, then go
with it.
+ // Otherwise, just go to primary in non-hedgedRead mode.
+ s.setConsistency(Consistency.TIMELINE);
+ s.setReplicaId(metaReplicaId);
+}
+break;
+ case HEDGED_READ:
+s.setConsistency(Consistency.TIMELINE);
+break;
+ default:
+// do nothing
Review comment:
As explained above.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2546: HBASE-24813 ReplicationSource should clear buffer usage on Replicatio…
Apache-HBase commented on pull request #2546: URL: https://github.com/apache/hbase/pull/2546#issuecomment-725022052 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 10m 25s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 20s | master passed | | +1 :green_heart: | compile | 1m 25s | master passed | | +1 :green_heart: | shadedjars | 8m 17s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 45s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 50s | the patch passed | | +1 :green_heart: | compile | 1m 20s | the patch passed | | +1 :green_heart: | javac | 1m 20s | the patch passed | | +1 :green_heart: | shadedjars | 7m 34s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 45s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 196m 32s | hbase-server in the patch failed. | | | | 239m 8s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2546/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2546 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 347e0454744b 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f0c430aed2 | | Default Java | AdoptOpenJDK-11.0.6+10 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2546/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2546/3/testReport/ | | Max. process+thread count | 3643 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2546/3/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-25267) Make SSL truststore and keystore type configurable in HBase RESTServer
[
https://issues.apache.org/jira/browse/HBASE-25267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mate Szalay-Beko updated HBASE-25267:
-
Description:
The keystore configuration of the RESTServer currently relies on the following
parameters to configure SSL:
* hbase.rest.ssl.enabled
* hbase.rest.ssl.keystore.store
* hbase.rest.ssl.keystore.password
* hbase.rest.ssl.keystore.keypassword
* hbase.rest.ssl.exclude.cipher.suites
* hbase.rest.ssl.include.cipher.suites
* hbase.rest.ssl.exclude.protocols
* hbase.rest.ssl.include.protocols
In this patch I want to introduce the following new parameters:
* {{hbase.rest.ssl.keystore.type}}
* {{hbase.rest.ssl.truststore.store}}
* {{hbase.rest.ssl.}}{{truststore}}{{.password}}
* {{hbase.rest.ssl.}}{{truststore}}{{.type}}
If any of the new the parameter is not provided, then we should fall-back to
the current behaviour (e.g. assuming JKS keystore/truststore types, or no
passwords, or no custom trust store file).
was:
The keystore configuration of the RESTServer currently relies on the following
parameters to configure SSL:
* hbase.rest.ssl.enabled
* hbase.rest.ssl.keystore.store
* hbase.rest.ssl.keystore.password
* hbase.rest.ssl.keystore.keypassword
* hbase.rest.ssl.exclude.cipher.suites
* hbase.rest.ssl.include.cipher.suites
* hbase.rest.ssl.exclude.protocols
* hbase.rest.ssl.include.protocols
In this patch I want to introduce the {{hbase.rest.ssl.keystore.type}}
parameter, enabling us to customize the keystore type for the REST server. If
the parameter is not provided, then we should fall-back to the current
behaviour (which assumes keystore type JKS).
(this is similar how we already do in the InfoServer with the
\{{ssl.server.keystore.type}} parameter)
> Make SSL truststore and keystore type configurable in HBase RESTServer
> --
>
> Key: HBASE-25267
> URL: https://issues.apache.org/jira/browse/HBASE-25267
> Project: HBase
> Issue Type: Improvement
> Components: REST
>Reporter: Mate Szalay-Beko
>Assignee: Mate Szalay-Beko
>Priority: Major
>
> The keystore configuration of the RESTServer currently relies on the
> following parameters to configure SSL:
> * hbase.rest.ssl.enabled
> * hbase.rest.ssl.keystore.store
> * hbase.rest.ssl.keystore.password
> * hbase.rest.ssl.keystore.keypassword
> * hbase.rest.ssl.exclude.cipher.suites
> * hbase.rest.ssl.include.cipher.suites
> * hbase.rest.ssl.exclude.protocols
> * hbase.rest.ssl.include.protocols
> In this patch I want to introduce the following new parameters:
> * {{hbase.rest.ssl.keystore.type}}
> * {{hbase.rest.ssl.truststore.store}}
> * {{hbase.rest.ssl.}}{{truststore}}{{.password}}
> * {{hbase.rest.ssl.}}{{truststore}}{{.type}}
> If any of the new the parameter is not provided, then we should fall-back to
> the current behaviour (e.g. assuming JKS keystore/truststore types, or no
> passwords, or no custom trust store file).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-25267) Make SSL truststore and keystore type configurable in HBase RESTServer
[
https://issues.apache.org/jira/browse/HBASE-25267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mate Szalay-Beko updated HBASE-25267:
-
Summary: Make SSL truststore and keystore type configurable in HBase
RESTServer (was: Make SSL keystore type configurable in HBase RESTServer)
> Make SSL truststore and keystore type configurable in HBase RESTServer
> --
>
> Key: HBASE-25267
> URL: https://issues.apache.org/jira/browse/HBASE-25267
> Project: HBase
> Issue Type: Improvement
> Components: REST
>Reporter: Mate Szalay-Beko
>Assignee: Mate Szalay-Beko
>Priority: Major
>
> The keystore configuration of the RESTServer currently relies on the
> following parameters to configure SSL:
> * hbase.rest.ssl.enabled
> * hbase.rest.ssl.keystore.store
> * hbase.rest.ssl.keystore.password
> * hbase.rest.ssl.keystore.keypassword
> * hbase.rest.ssl.exclude.cipher.suites
> * hbase.rest.ssl.include.cipher.suites
> * hbase.rest.ssl.exclude.protocols
> * hbase.rest.ssl.include.protocols
> In this patch I want to introduce the {{hbase.rest.ssl.keystore.type}}
> parameter, enabling us to customize the keystore type for the REST server. If
> the parameter is not provided, then we should fall-back to the current
> behaviour (which assumes keystore type JKS).
> (this is similar how we already do in the InfoServer with the
> \{{ssl.server.keystore.type}} parameter)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2483: HBASE-25026 - Create a metric to track scans that have no start row and/or stop row
Apache-HBase commented on pull request #2483: URL: https://github.com/apache/hbase/pull/2483#issuecomment-725004306 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 7m 5s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 31s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 55s | master passed | | +1 :green_heart: | checkstyle | 1m 28s | master passed | | +1 :green_heart: | spotbugs | 2m 38s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 47s | the patch passed | | -0 :warning: | checkstyle | 0m 13s | hbase-hadoop-compat: The patch generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1) | | -0 :warning: | checkstyle | 1m 15s | hbase-server: The patch generated 7 new + 280 unchanged - 0 fixed = 287 total (was 280) | | -0 :warning: | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply | | +1 :green_heart: | hadoopcheck | 18m 55s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. | | +1 :green_heart: | spotbugs | 2m 55s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 21s | The patch does not generate ASF License warnings. | | | | 51m 21s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2483/20/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2483 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 4b1615a75307 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f0c430aed2 | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2483/20/artifact/yetus-general-check/output/diff-checkstyle-hbase-hadoop-compat.txt | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2483/20/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | whitespace | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2483/20/artifact/yetus-general-check/output/whitespace-eol.txt | | Max. process+thread count | 84 (vs. ulimit of 3) | | modules | C: hbase-hadoop-compat hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2483/20/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=3.1.12 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2546: HBASE-24813 ReplicationSource should clear buffer usage on Replicatio…
Apache-HBase commented on pull request #2546: URL: https://github.com/apache/hbase/pull/2546#issuecomment-724993712 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 4s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 36s | master passed | | +1 :green_heart: | compile | 0m 55s | master passed | | +1 :green_heart: | shadedjars | 6m 33s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 39s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 30s | the patch passed | | +1 :green_heart: | compile | 0m 56s | the patch passed | | +1 :green_heart: | javac | 0m 56s | the patch passed | | +1 :green_heart: | shadedjars | 6m 34s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 37s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 146m 15s | hbase-server in the patch failed. | | | | 172m 54s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2546/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2546 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 6ee290d5b71b 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f0c430aed2 | | Default Java | AdoptOpenJDK-1.8.0_232-b09 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2546/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2546/3/testReport/ | | Max. process+thread count | 4596 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2546/3/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2483: HBASE-25026 - Create a metric to track scans that have no start row and/or stop row
Apache-HBase commented on pull request #2483: URL: https://github.com/apache/hbase/pull/2483#issuecomment-724978822 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 36s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 35s | master passed | | +1 :green_heart: | compile | 1m 15s | master passed | | +1 :green_heart: | shadedjars | 6m 35s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 51s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 26s | the patch passed | | +1 :green_heart: | compile | 1m 15s | the patch passed | | +1 :green_heart: | javac | 1m 15s | the patch passed | | +1 :green_heart: | shadedjars | 6m 34s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 54s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 33s | hbase-hadoop-compat in the patch passed. | | -1 :x: | unit | 140m 2s | hbase-server in the patch failed. | | | | 168m 51s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2483/19/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2483 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 03795e491980 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f0c430aed2 | | Default Java | AdoptOpenJDK-1.8.0_232-b09 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2483/19/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2483/19/testReport/ | | Max. process+thread count | 3842 (vs. ulimit of 3) | | modules | C: hbase-hadoop-compat hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2483/19/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2483: HBASE-25026 - Create a metric to track scans that have no start row and/or stop row
Apache-HBase commented on pull request #2483: URL: https://github.com/apache/hbase/pull/2483#issuecomment-724976528 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 35s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 2s | master passed | | +1 :green_heart: | compile | 1m 25s | master passed | | +1 :green_heart: | shadedjars | 6m 40s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 59s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 0s | the patch passed | | +1 :green_heart: | compile | 1m 28s | the patch passed | | +1 :green_heart: | javac | 1m 28s | the patch passed | | +1 :green_heart: | shadedjars | 6m 42s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 1s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 36s | hbase-hadoop-compat in the patch passed. | | -1 :x: | unit | 133m 28s | hbase-server in the patch failed. | | | | 164m 2s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2483/19/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2483 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 57fc4b724153 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f0c430aed2 | | Default Java | AdoptOpenJDK-11.0.6+10 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2483/19/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2483/19/testReport/ | | Max. process+thread count | 4518 (vs. ulimit of 3) | | modules | C: hbase-hadoop-compat hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2483/19/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] huaxiangsun commented on a change in pull request #2640: Backport: HBASE-25126 Add load balance logic in hbase-client to distribute read…
huaxiangsun commented on a change in pull request #2640:
URL: https://github.com/apache/hbase/pull/2640#discussion_r520883525
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ReversedClientScanner.java
##
@@ -64,7 +64,9 @@ protected boolean setNewStartKey() {
@Override
protected ReversedScannerCallable createScannerCallable() {
+// In case of meta, we want to support scan over a replica region.
+int replicaId = (scan.getConsistency() == Consistency.TIMELINE) ?
scan.getReplicaId() : 0;
Review comment:
However, I introduced a bug here. For Consistency.TIMELINE, if scan is
targeted to a specific replica region, replicaId is -1, which is incorrect. For
this case, it also needs to pass in 0.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] apurtell edited a comment on pull request #2627: HBASE-25251 Enable configuration based enable/disable of Unsafe packa…
apurtell edited a comment on pull request #2627: URL: https://github.com/apache/hbase/pull/2627#issuecomment-724972518 Test failure is weird. TestByteRangeWithKVSerialization. Might be related. Does it reproduce locally for you @sguggilam ? I wonder if the static initialization order changes (deliberate) are causing a deadlock. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] apurtell commented on pull request #2627: HBASE-25251 Enable configuration based enable/disable of Unsafe packa…
apurtell commented on pull request #2627: URL: https://github.com/apache/hbase/pull/2627#issuecomment-724972518 Test failure is weird. TestByteRangeWithKVSerialization. Might be related. Does it reproduce locally for you @sguggilam ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] huaxiangsun commented on a change in pull request #2640: Backport: HBASE-25126 Add load balance logic in hbase-client to distribute read…
huaxiangsun commented on a change in pull request #2640:
URL: https://github.com/apache/hbase/pull/2640#discussion_r520872063
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ReversedClientScanner.java
##
@@ -64,7 +64,9 @@ protected boolean setNewStartKey() {
@Override
protected ReversedScannerCallable createScannerCallable() {
+// In case of meta, we want to support scan over a replica region.
+int replicaId = (scan.getConsistency() == Consistency.TIMELINE) ?
scan.getReplicaId() : 0;
Review comment:
Just found out that what you said is correct.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] huaxiangsun commented on a change in pull request #2640: Backport: HBASE-25126 Add load balance logic in hbase-client to distribute read…
huaxiangsun commented on a change in pull request #2640:
URL: https://github.com/apache/hbase/pull/2640#discussion_r520869597
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ReversedClientScanner.java
##
@@ -64,7 +64,9 @@ protected boolean setNewStartKey() {
@Override
protected ReversedScannerCallable createScannerCallable() {
+// In case of meta, we want to support scan over a replica region.
+int replicaId = (scan.getConsistency() == Consistency.TIMELINE) ?
scan.getReplicaId() : 0;
Review comment:
My previous comment is incorrect(removed it). let me visit it again.
Just found out the targetReplicaId is initialized to -1. Testing also fails,
let me debug first.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] huaxiangsun commented on a change in pull request #2640: Backport: HBASE-25126 Add load balance logic in hbase-client to distribute read…
huaxiangsun commented on a change in pull request #2640:
URL: https://github.com/apache/hbase/pull/2640#discussion_r520869597
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ReversedClientScanner.java
##
@@ -64,7 +64,9 @@ protected boolean setNewStartKey() {
@Override
protected ReversedScannerCallable createScannerCallable() {
+// In case of meta, we want to support scan over a replica region.
+int replicaId = (scan.getConsistency() == Consistency.TIMELINE) ?
scan.getReplicaId() : 0;
Review comment:
The previous comment is incorrect, let me visit it again. Just found out
the targetReplicaId is initialized to -1. Testing also fails, let me debug
first.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] huaxiangsun commented on a change in pull request #2640: Backport: HBASE-25126 Add load balance logic in hbase-client to distribute read…
huaxiangsun commented on a change in pull request #2640:
URL: https://github.com/apache/hbase/pull/2640#discussion_r520782327
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ReversedClientScanner.java
##
@@ -64,7 +64,9 @@ protected boolean setNewStartKey() {
@Override
protected ReversedScannerCallable createScannerCallable() {
+// In case of meta, we want to support scan over a replica region.
+int replicaId = (scan.getConsistency() == Consistency.TIMELINE) ?
scan.getReplicaId() : 0;
Review comment:
There is no -1 involved. The flow is like that:
1. If it is Consistency.STRONG, no replica involved.
2. If it is Consistency.TIMELINE, and targetReplicaId is 0, it is the hedged
read behavior (primary first, then go to replicas if no response within
configured interval).
3. If it is Consistency.TIMELINE, and targetReplicaId is a valid replica
id, go to the target replica region within the specified replica id.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2627: HBASE-25251 Enable configuration based enable/disable of Unsafe packa…
Apache-HBase commented on pull request #2627: URL: https://github.com/apache/hbase/pull/2627#issuecomment-724948595 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 11s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 43s | master passed | | +1 :green_heart: | compile | 0m 26s | master passed | | +1 :green_heart: | shadedjars | 7m 50s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 26s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 11s | the patch passed | | +1 :green_heart: | compile | 0m 27s | the patch passed | | +1 :green_heart: | javac | 0m 27s | the patch passed | | +1 :green_heart: | shadedjars | 7m 37s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 23s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 13m 39s | hbase-common in the patch failed. | | | | 43m 3s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2627/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2627 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux c0432fb5a78d 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f0c430aed2 | | Default Java | AdoptOpenJDK-1.8.0_232-b09 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2627/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-common.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2627/2/testReport/ | | Max. process+thread count | 343 (vs. ulimit of 3) | | modules | C: hbase-common U: hbase-common | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2627/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2627: HBASE-25251 Enable configuration based enable/disable of Unsafe packa…
Apache-HBase commented on pull request #2627: URL: https://github.com/apache/hbase/pull/2627#issuecomment-724948012 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 15s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 42s | master passed | | +1 :green_heart: | compile | 0m 26s | master passed | | +1 :green_heart: | shadedjars | 7m 23s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 22s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 35s | the patch passed | | +1 :green_heart: | compile | 0m 25s | the patch passed | | +1 :green_heart: | javac | 0m 25s | the patch passed | | +1 :green_heart: | shadedjars | 7m 24s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 22s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 13m 51s | hbase-common in the patch failed. | | | | 42m 1s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2627/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2627 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 0097c3c8ea9c 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f0c430aed2 | | Default Java | AdoptOpenJDK-11.0.6+10 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2627/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-common.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2627/2/testReport/ | | Max. process+thread count | 198 (vs. ulimit of 3) | | modules | C: hbase-common U: hbase-common | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2627/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2627: HBASE-25251 Enable configuration based enable/disable of Unsafe packa…
Apache-HBase commented on pull request #2627: URL: https://github.com/apache/hbase/pull/2627#issuecomment-724944259 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 45s | master passed | | +1 :green_heart: | checkstyle | 0m 27s | master passed | | +1 :green_heart: | spotbugs | 0m 43s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 29s | the patch passed | | +1 :green_heart: | checkstyle | 0m 25s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 17m 1s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. | | +1 :green_heart: | spotbugs | 0m 53s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 14s | The patch does not generate ASF License warnings. | | | | 34m 41s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2627/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2627 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle xml | | uname | Linux 1d6bfb0d195a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f0c430aed2 | | Max. process+thread count | 94 (vs. ulimit of 3) | | modules | C: hbase-common U: hbase-common | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2627/2/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=3.1.12 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase-operator-tools] Apache-HBase commented on pull request #78: HBASE-25266 [hbase-operator-tools] Add a repair tool for moving stale…
Apache-HBase commented on pull request #78: URL: https://github.com/apache/hbase-operator-tools/pull/78#issuecomment-724934003 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | spotbugs | 0m 0s | spotbugs executables are not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 25s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 0m 27s | master passed | | +1 :green_heart: | compile | 0m 16s | master passed | | +1 :green_heart: | checkstyle | 0m 10s | master passed | | +1 :green_heart: | javadoc | 0m 11s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 3s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 0m 18s | the patch passed | | +1 :green_heart: | compile | 0m 17s | the patch passed | | -1 :x: | javac | 0m 8s | hbase-tools generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 :green_heart: | checkstyle | 0m 7s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +1 :green_heart: | javadoc | 0m 10s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 5m 44s | hbase-hbck2 in the patch passed. | | -1 :x: | unit | 2m 1s | hbase-tools in the patch failed. | | +1 :green_heart: | asflicense | 0m 9s | The patch does not generate ASF License warnings. | | | | 11m 14s | | | Reason | Tests | |---:|:--| | Failed junit tests | hbase.TestRegionsMerger | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-Operator-Tools-PreCommit/job/PR-78/2/artifact/yetus-precommit-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase-operator-tools/pull/78 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile xml | | uname | Linux 777b3951a706 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 GNU/Linux | | Build tool | maven | | git revision | master / 5cdc0e2 | | Default Java | Oracle Corporation-1.8.0_272-b10 | | javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-Operator-Tools-PreCommit/job/PR-78/2/artifact/yetus-precommit-check/output/diff-compile-javac-hbase-tools.txt | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-Operator-Tools-PreCommit/job/PR-78/2/artifact/yetus-precommit-check/output/patch-unit-hbase-tools.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-Operator-Tools-PreCommit/job/PR-78/2/testReport/ | | Max. process+thread count | 942 (vs. ulimit of 1000) | | modules | C: hbase-hbck2 hbase-tools U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-Operator-Tools-PreCommit/job/PR-78/2/console | | versions | git=2.20.1 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-25266) [hbase-operator-tools] Add a repair tool for moving stale regions dir not present in meta away from table dir
[ https://issues.apache.org/jira/browse/HBASE-25266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17229485#comment-17229485 ] Wellington Chevreuil commented on HBASE-25266: -- Thanks for pointing that out, [~stack]. Have you started some work there already? If not, I can move this PR to that, and add the extra check for recovered.edits as well. > [hbase-operator-tools] Add a repair tool for moving stale regions dir not > present in meta away from table dir > - > > Key: HBASE-25266 > URL: https://issues.apache.org/jira/browse/HBASE-25266 > Project: HBase > Issue Type: New Feature >Reporter: Wellington Chevreuil >Assignee: Wellington Chevreuil >Priority: Major > > This adds a new tool under *hbase-tools* module, that allows for moving aways > regions dirs existing under table's hdfs dir, but not in meta. This is useful > in cases where the region is not present in meta, but still has data on hdfs, > yet no holes in the table region chain is detected. > On such cases, the existing *HBCK2 addFsRegionsMissingInMeta* command isn't > ideal, as it would bring the region back in meta and cause overlaps. > This tool performs the following actions: > 1) Identifies regions in hdfs but not in meta using > *HBCK2.reportTablesWithMissingRegionsInMeta*; > 2) For each of these regions, sidelines the related dir to a temp folder; > 3) Bulkload hfiles from each sidelined region to the related table; > Sidelined regions are never removed from temp folder. Operators should remove > those manually, after they certified on data integrity. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2546: HBASE-24813 ReplicationSource should clear buffer usage on Replicatio…
Apache-HBase commented on pull request #2546: URL: https://github.com/apache/hbase/pull/2546#issuecomment-724928908 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 36s | master passed | | +1 :green_heart: | checkstyle | 1m 5s | master passed | | +1 :green_heart: | spotbugs | 1m 59s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 31s | the patch passed | | -0 :warning: | checkstyle | 1m 3s | hbase-server: The patch generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 19m 28s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. | | +1 :green_heart: | spotbugs | 2m 19s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 12s | The patch does not generate ASF License warnings. | | | | 41m 44s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2546/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2546 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux a35191384864 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f0c430aed2 | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2546/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 94 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2546/3/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=3.1.12 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase-operator-tools] wchevreuil commented on pull request #78: HBASE-25266 [hbase-operator-tools] Add a repair tool for moving stale…
wchevreuil commented on pull request #78: URL: https://github.com/apache/hbase-operator-tools/pull/78#issuecomment-724928915 > please update the README to explain this tool, when one should use it, how to use it, how to tell that it was successful or that it had a problem. Thansk, @busbey , will do it on a next commit tomorrow. Had pushed new commit today addressing checkstyles and some other comments. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] sguggilam commented on a change in pull request #2627: HBASE-25251 Enable configuration based enable/disable of Unsafe packa…
sguggilam commented on a change in pull request #2627:
URL: https://github.com/apache/hbase/pull/2627#discussion_r520832308
##
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/util/UnsafeAvailChecker.java
##
@@ -33,12 +35,16 @@
private static final Logger LOG =
LoggerFactory.getLogger(UnsafeAvailChecker.class);
private static boolean avail = false;
private static boolean unaligned = false;
+ // Flag that can be set by clients to enable/disable Unsafe package usage
+ private static boolean useUnsafe;
static {
avail = AccessController.doPrivileged(new PrivilegedAction() {
@Override
public Boolean run() {
try {
+ final Configuration conf = HBaseConfiguration.create();
+ useUnsafe = conf.getBoolean("hbase.unsafe.usage.enabled", true);
Review comment:
Done @apurtell
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] sguggilam commented on a change in pull request #2627: HBASE-25251 Enable configuration based enable/disable of Unsafe packa…
sguggilam commented on a change in pull request #2627:
URL: https://github.com/apache/hbase/pull/2627#discussion_r520831984
##
File path:
hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestBytes.java
##
@@ -58,7 +59,7 @@ private static void setUnsafe(boolean value) throws Exception
{
} finally {
modifiersField.setInt(field, oldModifiers);
}
-assertEquals(Bytes.UNSAFE_UNALIGNED, value);
+assertEquals(UnsafeAvailChecker.unaligned(), value);
}
Review comment:
@apurtell Added a test in the new commit. Added a resource in the
classpath for the class to consume the flag during class loading in the static
block. Please review and let me know your thoughts
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] sguggilam commented on a change in pull request #2627: HBASE-25251 Enable configuration based enable/disable of Unsafe packa…
sguggilam commented on a change in pull request #2627: URL: https://github.com/apache/hbase/pull/2627#discussion_r520831194 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/util/UnsafeAvailChecker.java ## @@ -33,12 +35,16 @@ private static final Logger LOG = LoggerFactory.getLogger(UnsafeAvailChecker.class); private static boolean avail = false; private static boolean unaligned = false; + // Flag that can be set by clients to enable/disable Unsafe package usage + private static boolean useUnsafe; Review comment: @Apache9 We might override the useUnsafe flag to enable/disable the Unsafe package usage on the client side using overrideUnsafeAvail method This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase-operator-tools] wchevreuil commented on a change in pull request #78: HBASE-25266 [hbase-operator-tools] Add a repair tool for moving stale…
wchevreuil commented on a change in pull request #78:
URL:
https://github.com/apache/hbase-operator-tools/pull/78#discussion_r520823960
##
File path:
hbase-tools/src/main/java/org/apache/hbase/MissingRegionDirsRepairTool.java
##
@@ -0,0 +1,126 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hbase;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.conf.Configured;
+import org.apache.hadoop.fs.FileStatus;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.hbase.HBaseConfiguration;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.Admin;
+import org.apache.hadoop.hbase.client.Connection;
+import org.apache.hadoop.hbase.client.ConnectionFactory;
+import org.apache.hadoop.hbase.tool.LoadIncrementalHFiles;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.hadoop.util.ToolRunner;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.util.List;
+import java.util.Map;
+
+public class MissingRegionDirsRepairTool extends Configured implements
org.apache.hadoop.util.Tool {
+
+ private static final Logger LOG =
+LoggerFactory.getLogger(MissingRegionDirsRepairTool.class.getName());
+
+ private static final String TEMP_DIR_PREFIX = "missing_dirs_repair_";
+
+ private Configuration conf;
+ private HBCK2 hbck;
+ private LoadIncrementalHFiles bulkLoad;
+
+ public MissingRegionDirsRepairTool(Configuration conf) {
+this.conf=conf;
+this.hbck = new HBCK2(conf);
+this.bulkLoad = new LoadIncrementalHFiles(conf);
+ }
+
+ @Override
+ public int run(String[] strings) throws Exception {
+Map> result = hbck
+ .reportTablesWithMissingRegionsInMeta(null);
+Path runPath = new Path(HBCKFsUtils.getRootDir(conf),
+ TEMP_DIR_PREFIX + System.currentTimeMillis());
+FileSystem fs = runPath.getFileSystem(conf);
+LOG.info("creating temp dir at: " + runPath.getName());
+fs.mkdirs(runPath);
+try(Connection conn = ConnectionFactory.createConnection(conf)) {
+ Admin admin = conn.getAdmin();
+ result.forEach((t, p) -> {
+if(!p.isEmpty()) {
+ Path tblPath =
+new Path(runPath, new Path(t.getNameWithNamespaceInclAsString()
+ .replaceAll(":", "_")));
+ try {
+fs.mkdirs(tblPath);
+Path sidelined = new Path(tblPath, "sidelined");
+fs.mkdirs(sidelined);
+Path bulkload = new Path(tblPath, "bulkload");
+fs.mkdirs(bulkload);
+p.stream().forEach(region -> {
+ try {
+Path sidelinedRegionDir = new Path(sidelined,
region.getName());
+fs.mkdirs(sidelinedRegionDir);
+HBCKFsUtils.copyFilesParallel(fs, region, fs,
sidelinedRegionDir, conf, 3);
Review comment:
For this copyFilesParallel method call, there wouldn't be any problems,
as the sidelinedRegionDir is under the individual "missing_dirs_repair_TS" dir.
But if each run gets here at different times, later runs would not find already
sidelined regions. There's still possibility that same region gets sidelined by
different runs, which would also bulkload the regions files again. Not ideal in
terms of resources usage, but still fine for data consistency sake. I guess we
can implement some sort of lock file in a given hdfs location to avoid multiple
runs?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] huaxiangsun commented on pull request #2640: Backport: HBASE-25126 Add load balance logic in hbase-client to distribute read…
huaxiangsun commented on pull request #2640: URL: https://github.com/apache/hbase/pull/2640#issuecomment-724914478 Seems that the patch has some issue, because related tests are failing, let me look into those failures. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2483: HBASE-25026 - Create a metric to track scans that have no start row and/or stop row
Apache-HBase commented on pull request #2483: URL: https://github.com/apache/hbase/pull/2483#issuecomment-724914556 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 35s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 29s | master passed | | +1 :green_heart: | checkstyle | 1m 25s | master passed | | +1 :green_heart: | spotbugs | 2m 28s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 25s | the patch passed | | -0 :warning: | checkstyle | 0m 14s | hbase-hadoop-compat: The patch generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1) | | -0 :warning: | checkstyle | 1m 10s | hbase-server: The patch generated 7 new + 280 unchanged - 0 fixed = 287 total (was 280) | | -0 :warning: | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply | | +1 :green_heart: | hadoopcheck | 17m 4s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. | | +1 :green_heart: | spotbugs | 2m 48s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 25s | The patch does not generate ASF License warnings. | | | | 41m 22s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2483/19/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2483 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 1c7a96a7a3d8 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f0c430aed2 | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2483/19/artifact/yetus-general-check/output/diff-checkstyle-hbase-hadoop-compat.txt | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2483/19/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | whitespace | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2483/19/artifact/yetus-general-check/output/whitespace-eol.txt | | Max. process+thread count | 94 (vs. ulimit of 3) | | modules | C: hbase-hadoop-compat hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2483/19/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=3.1.12 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
