[GitHub] [hbase] pankaj72981 commented on a change in pull request #3544: HBASE-26154: Provide exception metric for quota exceeded and throttling
pankaj72981 commented on a change in pull request #3544:
URL: https://github.com/apache/hbase/pull/3544#discussion_r679642255
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServer.java
##
@@ -116,6 +122,12 @@ public void exception(Throwable throwable) {
source.multiActionTooLargeException();
} else if (throwable instanceof CallQueueTooBigException) {
source.callQueueTooBigException();
+ } else if (throwable instanceof QuotaExceededException) {
+source.quotaExceededException();
+ } else if (throwable instanceof RpcThrottlingException) {
+source.rpcThrottlingException();
+ } else if (LOG.isDebugEnabled()) {
+LOG.debug("Unknown exception type: " +
throwable.getClass().getSimpleName());
Review comment:
Log the exception instead of class name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3544: HBASE-26154: Provide exception metric for quota exceeded and throttling
Apache-HBase commented on pull request #3544: URL: https://github.com/apache/hbase/pull/3544#issuecomment-889616909 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docker mode activated. | | -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 35s | branch-2 passed | | +1 :green_heart: | compile | 2m 5s | branch-2 passed | | +1 :green_heart: | shadedjars | 6m 23s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 41s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 21s | the patch passed | | +1 :green_heart: | compile | 2m 5s | the patch passed | | +1 :green_heart: | javac | 2m 5s | the patch passed | | +1 :green_heart: | shadedjars | 6m 27s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 39s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 26s | hbase-hadoop-compat in the patch passed. | | +1 :green_heart: | unit | 0m 27s | hbase-hadoop2-compat in the patch passed. | | +1 :green_heart: | unit | 145m 7s | hbase-server in the patch passed. | | +1 :green_heart: | unit | 7m 34s | hbase-thrift in the patch passed. | | | | 184m 44s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3544/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3544 | | JIRA Issue | HBASE-26154 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 1e5d19cbad5a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / f049301606 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3544/2/testReport/ | | Max. process+thread count | 3916 (vs. ulimit of 12500) | | modules | C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server hbase-thrift U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3544/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3544: HBASE-26154: Provide exception metric for quota exceeded and throttling
Apache-HBase commented on pull request #3544: URL: https://github.com/apache/hbase/pull/3544#issuecomment-889613875 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker mode activated. | | -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 19s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 57s | branch-2 passed | | +1 :green_heart: | compile | 2m 21s | branch-2 passed | | +1 :green_heart: | shadedjars | 7m 5s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 5s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 59s | the patch passed | | +1 :green_heart: | compile | 2m 22s | the patch passed | | +1 :green_heart: | javac | 2m 22s | the patch passed | | +1 :green_heart: | shadedjars | 7m 13s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 7s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 27s | hbase-hadoop-compat in the patch passed. | | +1 :green_heart: | unit | 0m 31s | hbase-hadoop2-compat in the patch passed. | | +1 :green_heart: | unit | 132m 29s | hbase-server in the patch passed. | | +1 :green_heart: | unit | 6m 7s | hbase-thrift in the patch passed. | | | | 174m 54s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3544/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3544 | | JIRA Issue | HBASE-26154 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux ade57f0c3beb 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / f049301606 | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3544/2/testReport/ | | Max. process+thread count | 3713 (vs. ulimit of 12500) | | modules | C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server hbase-thrift U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3544/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-25714) Offload the compaction job to independent Compaction Server
[ https://issues.apache.org/jira/browse/HBASE-25714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yulin Niu updated HBASE-25714: -- Attachment: CoprocessorSupport1.png > Offload the compaction job to independent Compaction Server > --- > > Key: HBASE-25714 > URL: https://issues.apache.org/jira/browse/HBASE-25714 > Project: HBase > Issue Type: Umbrella >Reporter: Yulin Niu >Assignee: Yulin Niu >Priority: Major > Attachments: CoprocessorSupport1.png > > > The basic idea is add a role "CompactionServer" to take the Compaction job. > HMaster is responsible for scheduling the compaction job to different > CompactionServer. > [design > doc|https://docs.google.com/document/d/1exmhQpQArAgnryLaV78K3260rKm64BHBNzZE4VdTz0c/edit?usp=sharing] > Suggestions are welcomed. Thanks. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #3544: HBASE-26154: Provide exception metric for quota exceeded and throttling
Apache-HBase commented on pull request #3544: URL: https://github.com/apache/hbase/pull/3544#issuecomment-889577783 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 26s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 34s | branch-2 passed | | +1 :green_heart: | compile | 5m 10s | branch-2 passed | | +1 :green_heart: | checkstyle | 2m 16s | branch-2 passed | | +1 :green_heart: | spotbugs | 4m 53s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 53s | the patch passed | | +1 :green_heart: | compile | 5m 51s | the patch passed | | +1 :green_heart: | javac | 5m 51s | the patch passed | | +1 :green_heart: | checkstyle | 2m 21s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 13m 36s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 5m 36s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 48s | The patch does not generate ASF License warnings. | | | | 58m 31s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3544/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3544 | | JIRA Issue | HBASE-26154 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux a4cc0021f03a 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / f049301606 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Max. process+thread count | 96 (vs. ulimit of 12500) | | modules | C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server hbase-thrift U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3544/2/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #3529: HBASE-26124 Backport HBASE-25373 "Remove HTrace completely in code base and try to make use of OpenTelemetry" to branch-2
Apache9 commented on pull request #3529: URL: https://github.com/apache/hbase/pull/3529#issuecomment-889571251 Be lated +1. Thanks @taklwu for taking this work. This PR seems OK to merge to branch-2 directly, but I'm not sure if is better to backport to a branch-2 based feature branch first for the other issues? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3543: HBASE-26125 Backport HBASE-25401 "Add trace support for async call in…
Apache-HBase commented on pull request #3543: URL: https://github.com/apache/hbase/pull/3543#issuecomment-889565952 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s | Docker mode activated. | | -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 30s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 16s | branch-2 passed | | +1 :green_heart: | compile | 4m 2s | branch-2 passed | | +1 :green_heart: | shadedjars | 11m 38s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 7m 9s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 29s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 6m 40s | the patch passed | | +1 :green_heart: | compile | 4m 2s | the patch passed | | +1 :green_heart: | javac | 4m 2s | the patch passed | | +1 :green_heart: | shadedjars | 11m 19s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 6m 15s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 206m 10s | root in the patch passed. | | | | 268m 37s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3543/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3543 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 2d0f1a3d1173 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / f049301606 | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3543/1/testReport/ | | Max. process+thread count | 6109 (vs. ulimit of 12500) | | modules | C: hbase-protocol-shaded hbase-common hbase-client hbase-server . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3543/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3544: HBASE-26154: Provide exception metric for quota exceeded and throttling
Apache-HBase commented on pull request #3544: URL: https://github.com/apache/hbase/pull/3544#issuecomment-889558756 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docker mode activated. | | -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 43s | branch-2 passed | | +1 :green_heart: | compile | 2m 5s | branch-2 passed | | +1 :green_heart: | shadedjars | 6m 31s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 43s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 22s | the patch passed | | +1 :green_heart: | compile | 2m 6s | the patch passed | | +1 :green_heart: | javac | 2m 6s | the patch passed | | +1 :green_heart: | shadedjars | 6m 19s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 40s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 27s | hbase-hadoop-compat in the patch passed. | | +1 :green_heart: | unit | 0m 27s | hbase-hadoop2-compat in the patch passed. | | +1 :green_heart: | unit | 143m 21s | hbase-server in the patch passed. | | +1 :green_heart: | unit | 7m 42s | hbase-thrift in the patch passed. | | | | 183m 38s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3544/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3544 | | JIRA Issue | HBASE-26154 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 4f1e49bd38b9 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / f049301606 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3544/1/testReport/ | | Max. process+thread count | 4029 (vs. ulimit of 12500) | | modules | C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server hbase-thrift U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3544/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3544: HBASE-26154: Provide exception metric for quota exceeded and throttling
Apache-HBase commented on pull request #3544: URL: https://github.com/apache/hbase/pull/3544#issuecomment-889556164 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docker mode activated. | | -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 16s | branch-2 passed | | +1 :green_heart: | compile | 2m 25s | branch-2 passed | | +1 :green_heart: | shadedjars | 7m 16s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 9s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 21s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 2s | the patch passed | | +1 :green_heart: | compile | 2m 27s | the patch passed | | +1 :green_heart: | javac | 2m 27s | the patch passed | | +1 :green_heart: | shadedjars | 7m 12s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 3s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 28s | hbase-hadoop-compat in the patch passed. | | +1 :green_heart: | unit | 0m 31s | hbase-hadoop2-compat in the patch passed. | | +1 :green_heart: | unit | 133m 0s | hbase-server in the patch passed. | | +1 :green_heart: | unit | 6m 16s | hbase-thrift in the patch passed. | | | | 176m 25s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3544/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3544 | | JIRA Issue | HBASE-26154 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 88257a4bce35 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / f049301606 | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3544/1/testReport/ | | Max. process+thread count | 3846 (vs. ulimit of 12500) | | modules | C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server hbase-thrift U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3544/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3532: HBASE-26122: Implement an optional maximum size for Gets, after which a partial result is returned
Apache-HBase commented on pull request #3532: URL: https://github.com/apache/hbase/pull/3532#issuecomment-889539674 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s | Docker mode activated. | | -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 19s | branch-2 passed | | +1 :green_heart: | compile | 2m 56s | branch-2 passed | | +1 :green_heart: | shadedjars | 7m 11s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 37s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 57s | the patch passed | | +1 :green_heart: | compile | 3m 2s | the patch passed | | +1 :green_heart: | javac | 3m 2s | the patch passed | | +1 :green_heart: | shadedjars | 7m 25s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 43s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 52s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 0m 31s | hbase-protocol in the patch passed. | | +1 :green_heart: | unit | 2m 49s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 178m 39s | hbase-server in the patch passed. | | | | 219m 18s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3532/6/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3532 | | JIRA Issue | HBASE-26122 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux fe90a061873e 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / f049301606 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3532/6/testReport/ | | Max. process+thread count | 4217 (vs. ulimit of 12500) | | modules | C: hbase-protocol-shaded hbase-protocol hbase-client hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3532/6/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3532: HBASE-26122: Implement an optional maximum size for Gets, after which a partial result is returned
Apache-HBase commented on pull request #3532: URL: https://github.com/apache/hbase/pull/3532#issuecomment-889527402 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 45s | Docker mode activated. | | -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 35s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 42s | branch-2 passed | | +1 :green_heart: | compile | 3m 49s | branch-2 passed | | +1 :green_heart: | shadedjars | 9m 51s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 57s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 35s | the patch passed | | +1 :green_heart: | compile | 3m 44s | the patch passed | | +1 :green_heart: | javac | 3m 44s | the patch passed | | +1 :green_heart: | shadedjars | 7m 15s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 35s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 52s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 0m 31s | hbase-protocol in the patch passed. | | +1 :green_heart: | unit | 2m 42s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 133m 9s | hbase-server in the patch passed. | | | | 180m 43s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3532/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3532 | | JIRA Issue | HBASE-26122 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 010a9486285c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / f049301606 | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3532/6/testReport/ | | Max. process+thread count | 4138 (vs. ulimit of 12500) | | modules | C: hbase-protocol-shaded hbase-protocol hbase-client hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3532/6/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3544: HBASE-26154: Provide exception metric for quota exceeded and throttling
Apache-HBase commented on pull request #3544: URL: https://github.com/apache/hbase/pull/3544#issuecomment-889515305 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 38s | branch-2 passed | | +1 :green_heart: | compile | 5m 4s | branch-2 passed | | +1 :green_heart: | checkstyle | 2m 11s | branch-2 passed | | +1 :green_heart: | spotbugs | 4m 21s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 19s | the patch passed | | +1 :green_heart: | compile | 5m 5s | the patch passed | | +1 :green_heart: | javac | 5m 5s | the patch passed | | +1 :green_heart: | checkstyle | 2m 14s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 12m 0s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 5m 2s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 53s | The patch does not generate ASF License warnings. | | | | 53m 38s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3544/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3544 | | JIRA Issue | HBASE-26154 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux f1a95297a123 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / f049301606 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Max. process+thread count | 96 (vs. ulimit of 12500) | | modules | C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server hbase-thrift U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3544/1/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work started] (HBASE-26125) Backport HBASE-25401 "Add trace support for async call in rpc client" to branch-2
[ https://issues.apache.org/jira/browse/HBASE-26125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-26125 started by Tak-Lon (Stephen) Wu. > Backport HBASE-25401 "Add trace support for async call in rpc client" to > branch-2 > - > > Key: HBASE-26125 > URL: https://issues.apache.org/jira/browse/HBASE-26125 > Project: HBase > Issue Type: Sub-task > Components: tracing >Affects Versions: 2.5.0 >Reporter: Tak-Lon (Stephen) Wu >Assignee: Tak-Lon (Stephen) Wu >Priority: Major > > [2/17 commits of > HBASE-22120|https://github.com/apache/hbase/pull/2901/commits], original > commit of HBASE-25401 was > [https://github.com/apache/hbase/commit/242028671535dfed67ec13d9ed0d6067f3ccfd04] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #3543: HBASE-26125 Backport HBASE-25401 "Add trace support for async call in…
Apache-HBase commented on pull request #3543: URL: https://github.com/apache/hbase/pull/3543#issuecomment-889504373 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 10s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | prototool | 0m 0s | prototool was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 0s | branch-2 passed | | +1 :green_heart: | compile | 9m 18s | branch-2 passed | | +1 :green_heart: | checkstyle | 2m 28s | branch-2 passed | | +1 :green_heart: | spotbugs | 16m 34s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 19s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 40s | the patch passed | | +1 :green_heart: | compile | 9m 19s | the patch passed | | +1 :green_heart: | cc | 9m 19s | the patch passed | | +1 :green_heart: | javac | 9m 19s | the patch passed | | +1 :green_heart: | checkstyle | 2m 26s | root: The patch generated 0 new + 22 unchanged - 4 fixed = 22 total (was 26) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 13m 6s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | hbaseprotoc | 6m 22s | the patch passed | | +1 :green_heart: | spotbugs | 17m 26s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 57s | The patch does not generate ASF License warnings. | | | | 97m 2s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3543/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3543 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool xml | | uname | Linux aa49cd5524a0 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / f049301606 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Max. process+thread count | 127 (vs. ulimit of 12500) | | modules | C: hbase-protocol-shaded hbase-common hbase-client hbase-server . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3543/1/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bbeaudreault opened a new pull request #3544: HBASE-26154: Provide exception metric for quota exceeded and throttling
bbeaudreault opened a new pull request #3544: URL: https://github.com/apache/hbase/pull/3544 See https://issues.apache.org/jira/browse/HBASE-26154 Also adds a debug log for unknown exceptions, which we've also found helpful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bbeaudreault commented on a change in pull request #3536: HBASE-26147: Add dry_run_balancer and related Admin interfaces for running the balancer without executing any region moves
bbeaudreault commented on a change in pull request #3536:
URL: https://github.com/apache/hbase/pull/3536#discussion_r679509915
##
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java
##
@@ -1253,6 +1253,15 @@ default boolean balancer() throws IOException {
*/
boolean balance() throws IOException;
+ /**
+ * Invoke the balancer in dry run mode. Will show plan but not actually move
any regions.
+ * Can NOT run for various reasons. Check logs.
+ *
+ * @return true if dry run ran, false otherwise.
+ * @throws IOException if a remote or network exception occurs
+ */
+ boolean dryRunBalance() throws IOException;
Review comment:
Thinking about it more and reading the aspirational semver doc, it seems
like the "lesser of all evils" is the change that a) doesn't break
compatibility (all of them), and b) will have the most longevity. We don't want
to add a method today if we plan to replace it in the "near future".
Given that, if you don't like `dryRunBalancer`, I would vote for
BalancerConfig. We know that we want to add support for config overrides, and
it'd be awkward to add that aside an enum or boolean.
I personally actually prefer `dryRunBalancer` because unlike `boolean
force`, it feels like a distinct mode from the normal balancer and we might
iterate on it over time separately from the normal balancer. For instance we
might add return values that differ from what the normal balancer will ever
return, arguments that don't make sense for the normal balancer, etc.
That said, I'm not a committer so my vote may not be worth that much :) I'd
be open to doing which ever will get it merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3532: HBASE-26122: Implement an optional maximum size for Gets, after which a partial result is returned
Apache-HBase commented on pull request #3532: URL: https://github.com/apache/hbase/pull/3532#issuecomment-889485592 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 8s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | prototool | 0m 0s | prototool was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 58s | branch-2 passed | | +1 :green_heart: | compile | 7m 47s | branch-2 passed | | +1 :green_heart: | checkstyle | 2m 38s | branch-2 passed | | +1 :green_heart: | spotbugs | 9m 19s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 17s | the patch passed | | +1 :green_heart: | compile | 7m 52s | the patch passed | | +1 :green_heart: | cc | 7m 52s | the patch passed | | +1 :green_heart: | javac | 7m 52s | the patch passed | | -0 :warning: | checkstyle | 1m 25s | hbase-server: The patch generated 5 new + 272 unchanged - 0 fixed = 277 total (was 272) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 15m 44s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | hbaseprotoc | 2m 44s | the patch passed | | +1 :green_heart: | spotbugs | 8m 7s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 51s | The patch does not generate ASF License warnings. | | | | 79m 47s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3532/6/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3532 | | JIRA Issue | HBASE-26122 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool | | uname | Linux 03f1d03c6ff1 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / f049301606 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3532/6/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 96 (vs. ulimit of 12500) | | modules | C: hbase-protocol-shaded hbase-protocol hbase-client hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3532/6/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bbeaudreault commented on a change in pull request #3536: HBASE-26147: Add dry_run_balancer and related Admin interfaces for running the balancer without executing any region moves
bbeaudreault commented on a change in pull request #3536:
URL: https://github.com/apache/hbase/pull/3536#discussion_r679509915
##
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java
##
@@ -1253,6 +1253,15 @@ default boolean balancer() throws IOException {
*/
boolean balance() throws IOException;
+ /**
+ * Invoke the balancer in dry run mode. Will show plan but not actually move
any regions.
+ * Can NOT run for various reasons. Check logs.
+ *
+ * @return true if dry run ran, false otherwise.
+ * @throws IOException if a remote or network exception occurs
+ */
+ boolean dryRunBalance() throws IOException;
Review comment:
Thinking about it more and reading the aspirational semver doc, it seems
like the "lesser of all evils" is the change that a) doesn't break
compatibility (all of them), and b) will have the most longevity. We don't want
to add dryRunBalancer today if we plan to replace it in the "near future".
Given that, if you don't like `dryRunBalancer`, I would vote for
BalancerConfig. We know that we want to add support for config overrides, and
it'd be awkward to add that aside an enum or boolean.
I personally actually prefer `dryRunBalancer` because unlike `boolean
force`, it feels like a distinct mode from the normal balancer and we might
iterate on it over time separately from the normal balancer. For instance we
might add return values that differ from what the normal balancer will ever
return, arguments that don't make sense for the normal balancer, etc.
That said, I'm not a committer so my vote may not be worth that much :) I'd
be open to doing which ever will get it merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] bbeaudreault commented on a change in pull request #3536: HBASE-26147: Add dry_run_balancer and related Admin interfaces for running the balancer without executing any region moves
bbeaudreault commented on a change in pull request #3536:
URL: https://github.com/apache/hbase/pull/3536#discussion_r679500129
##
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java
##
@@ -1253,6 +1253,15 @@ default boolean balancer() throws IOException {
*/
boolean balance() throws IOException;
+ /**
+ * Invoke the balancer in dry run mode. Will show plan but not actually move
any regions.
+ * Can NOT run for various reasons. Check logs.
+ *
+ * @return true if dry run ran, false otherwise.
+ * @throws IOException if a remote or network exception occurs
+ */
+ boolean dryRunBalance() throws IOException;
Review comment:
Ok, so it's more acceptable to modify the public API in this case? Here
are some possibilities I can come up with:
- Modify the existing `balance(boolean force)` to add a new `boolean dryRun`
argument. So `balance(boolean force, boolean dryRun)`. I don't love putting 2
booleans back to back like this, especially since force + boolean doesn't quite
make sense.
- In this case I think I'd actually have to add a new method to preserve
backwards compatibility, and the the existing `balance(boolean force)` would
delegate to `return balance(force, false)`.
- Change the going forward signature to a RunMode enum (or other name), with
`REQUEST`, `FORCE`, `DRY_RUN`.
- In this case I would need a new `balance(RunMode runMode)`, and then the
existing balance would delegate to `return balance(force ? RunMode.FORCE :
RunMode.REQUEST)`
- Change the going forward signature to a BalancerConfig object. We have a
lot of options for how the BalancerConfig is constructed, either as a builder
or factory methods.
- Similar to above, I'd add a new `balance(BalancerConfig)`, and delegate
based on the value of the force boolean.
I honestly think the last option is the best for long term as it sets us up
for future expansion, but it's also the most complicated. I'd be fine to add
that, but all of these options change the public API. I'm not sure which is the
lesser of all evils from that perspective.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] joshelser commented on a change in pull request #3536: HBASE-26147: Add dry_run_balancer and related Admin interfaces for running the balancer without executing any region moves
joshelser commented on a change in pull request #3536:
URL: https://github.com/apache/hbase/pull/3536#discussion_r679486521
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##
@@ -1809,6 +1809,10 @@ public boolean balance(boolean force) throws IOException
{
List plans = this.balancer.balanceCluster(assignments);
+ if (runMode.isDryRun()) {
+return true;
Review comment:
Heh, yeah, I saw the chatter on Jira after I posted the review 蘿
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] joshelser commented on a change in pull request #3536: HBASE-26147: Add dry_run_balancer and related Admin interfaces for running the balancer without executing any region moves
joshelser commented on a change in pull request #3536:
URL: https://github.com/apache/hbase/pull/3536#discussion_r679486302
##
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java
##
@@ -1253,6 +1253,15 @@ default boolean balancer() throws IOException {
*/
boolean balance() throws IOException;
+ /**
+ * Invoke the balancer in dry run mode. Will show plan but not actually move
any regions.
+ * Can NOT run for various reasons. Check logs.
+ *
+ * @return true if dry run ran, false otherwise.
+ * @throws IOException if a remote or network exception occurs
+ */
+ boolean dryRunBalance() throws IOException;
Review comment:
> I'm not sure how the hbase devs weigh interface change questions like
this.
Yeah, that's exactly the problem ;). As you have added it now, you've added
a new method to the public API which we would not be able to remove before
HBase 4.0.0 at this point. Meaning, we want to be very cautious when adding new
methods on public API.
I believe our specification technically allow us to define a single method
on the interface to be at a lesser visibility (not Public), but it's not
something we typically do, especially on one of the most user-facing interfaces.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] bbeaudreault commented on a change in pull request #3536: HBASE-26147: Add dry_run_balancer and related Admin interfaces for running the balancer without executing any region moves
bbeaudreault commented on a change in pull request #3536:
URL: https://github.com/apache/hbase/pull/3536#discussion_r679475586
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##
@@ -1809,6 +1809,10 @@ public boolean balance(boolean force) throws IOException
{
List plans = this.balancer.balanceCluster(assignments);
+ if (runMode.isDryRun()) {
+return true;
Review comment:
Yea, that's a great idea. We were discussing something similar in the
jira, though I'd prefer to do that in a separate jira/PR since it'd be another
involved change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] bbeaudreault commented on a change in pull request #3536: HBASE-26147: Add dry_run_balancer and related Admin interfaces for running the balancer without executing any region moves
bbeaudreault commented on a change in pull request #3536:
URL: https://github.com/apache/hbase/pull/3536#discussion_r679474668
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##
@@ -1809,6 +1809,10 @@ public boolean balance(boolean force) throws IOException
{
List plans = this.balancer.balanceCluster(assignments);
+ if (runMode.isDryRun()) {
+return true;
+ }
+
Review comment:
I followed the same logic in the rsgroup implementation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] bbeaudreault commented on a change in pull request #3536: HBASE-26147: Add dry_run_balancer and related Admin interfaces for running the balancer without executing any region moves
bbeaudreault commented on a change in pull request #3536:
URL: https://github.com/apache/hbase/pull/3536#discussion_r679474465
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##
@@ -1809,6 +1809,10 @@ public boolean balance(boolean force) throws IOException
{
List plans = this.balancer.balanceCluster(assignments);
+ if (runMode.isDryRun()) {
+return true;
+ }
+
Review comment:
@joshelser thanks for the review! I wanted to point out that a few lines
below this diff (line 1825) is the `postBalance` coprocessor call. We skip that
for dry run mode, but a few lines above this diff (line 1790) is the
`preBalance` coprocessor call, which we _do_ call.
I chose to call pre and not post because it seems like maybe someone might
use `preBalance` to check or set extra state that might be necessary for the
balancer, while I was concerned that `postBalance` might make decisions based
on balance plans that are passed in but were not actually executed.
I've been thinking maybe we should just skip both or call both, and
wondering if you have any thoughts. We could also pass in the RunMode into the
coprocessor, but then we get into coprocessor interface changes. Not sure
that's worth it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] bbeaudreault commented on a change in pull request #3536: HBASE-26147: Add dry_run_balancer and related Admin interfaces for running the balancer without executing any region moves
bbeaudreault commented on a change in pull request #3536:
URL: https://github.com/apache/hbase/pull/3536#discussion_r679472058
##
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java
##
@@ -1253,6 +1253,15 @@ default boolean balancer() throws IOException {
*/
boolean balance() throws IOException;
+ /**
+ * Invoke the balancer in dry run mode. Will show plan but not actually move
any regions.
+ * Can NOT run for various reasons. Check logs.
+ *
+ * @return true if dry run ran, false otherwise.
+ * @throws IOException if a remote or network exception occurs
+ */
+ boolean dryRunBalance() throws IOException;
Review comment:
I could do that. I didn't initially do that for a few reasons:
- There are already a lot of overloads of `balance()`, between the
deprecated `balancer()` and the `boolean force`.
- I didn't want to add another boolean argument. IMO an interface
`balance(boolean, boolean)` can be easily messed up. I could expose a
client-side version of RunMode enum though, but in order to preserve backwards
compatibility we'd have to add a whole set of new overloads.
- In the comments of HBASE-26147 we discussed enhancing dry run mode to
accept config overrides for cost functions. This would make it much more
intuitive to iterate on cost functions without doing a bunch of gymnastics. If
we wanted to do that, we'd need to add another argument that would be specific
to dry run mode which would further complicate the interface of `balance()`.
To the last reason, I could plan ahead for that and have `balance()` take a
BalancerConfig object instead of an enum. That'd give us the future flexibility
to add config overrides to just dry run mode, but it's a more complex interface
and not _that_ much better than having 2 separate methods.
Do you have any opinions on the above? I'm not sure how the hbase devs weigh
interface change questions like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] joshelser commented on a change in pull request #3536: HBASE-26147: Add dry_run_balancer and related Admin interfaces for running the balancer without executing any region moves
joshelser commented on a change in pull request #3536:
URL: https://github.com/apache/hbase/pull/3536#discussion_r679453610
##
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java
##
@@ -1253,6 +1253,15 @@ default boolean balancer() throws IOException {
*/
boolean balance() throws IOException;
+ /**
+ * Invoke the balancer in dry run mode. Will show plan but not actually move
any regions.
+ * Can NOT run for various reasons. Check logs.
+ *
+ * @return true if dry run ran, false otherwise.
+ * @throws IOException if a remote or network exception occurs
+ */
+ boolean dryRunBalance() throws IOException;
Review comment:
I'm not a big fan of adding a brand new API just for the `dry-run` mode.
What about overloading the existing `balance()` method?
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/LoadBalancer.java
##
@@ -86,6 +86,18 @@
// We deliberately use 'localhost' so the operation will fail fast
ServerName BOGUS_SERVER_NAME = ServerName.valueOf("localhost,1,1");
+ enum RunMode {
+CHORE, REQUEST, FORCE, DRY_RUN;
+
+boolean isForced() {
+ return this == FORCE;
+}
+
+boolean isDryRun() {
+ return this == DRY_RUN;
+}
Review comment:
IMO, these aren't adding much over `runMode == RunMode.DRY_RUN` and
`runMode == RunMode.FORCE`.
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterDryRunBalancer.java
##
@@ -0,0 +1,114 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.master;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
+import java.io.IOException;
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.HBaseTestingUtility;
+import org.apache.hadoop.hbase.ServerName;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.RegionInfo;
+import org.apache.hadoop.hbase.regionserver.HRegionServer;
+import org.apache.hadoop.hbase.testclassification.MasterTests;
+import org.apache.hadoop.hbase.testclassification.MediumTests;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.junit.After;
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.mockito.Mockito;
+
+@Category({ MasterTests.class, MediumTests.class})
+public class TestMasterDryRunBalancer {
+ @ClassRule
+ public static final HBaseClassTestRule CLASS_RULE =
+HBaseClassTestRule.forClass(TestMasterDryRunBalancer.class);
+
+ private static final HBaseTestingUtility TEST_UTIL = new
HBaseTestingUtility();
+ private static final byte[] FAMILYNAME = Bytes.toBytes("fam");
+
+ @After
+ public void shutdown() throws Exception {
+TEST_UTIL.shutdownMiniCluster();
+ }
+
+ @Test
+ public void testDryRunBalancer() throws Exception {
+TEST_UTIL.startMiniCluster(2);
+
+TableName tableName = createTable("testDryRunBalancer");
+HMaster master = Mockito.spy(TEST_UTIL.getHBaseCluster().getMaster());
+
+// dry run should be possible with balancer disabled
+// disabling it will ensure the chore does not mess with our forced
unbalance below
+master.balanceSwitch(false);
+assertFalse(master.isBalancerOn());
+
+HRegionServer biasedServer = unbalance(master, tableName);
+
+assertTrue(master.balance(LoadBalancer.RunMode.DRY_RUN));
+
+// sanity check that we truly don't try to execute any plans
+Mockito.verify(master,
Mockito.never()).executeRegionPlansWithThrottling(Mockito.anyList());
+
+// should still be unbalanced post dry run
+assertServerContainsAllRegions(biasedServer.getServerName(), tableName);
+
+TEST_UTIL.deleteTable(tableName);
+ }
+
+ private TableName createTable(String table) throws IOException {
+TableName tableName = TableName.valueOf(table);
+byte[] startKey = new byte[] { 0x00 };
+byte[] stopKey = new byte[] { 0x7f };
+TEST_UTIL.createTable(tableName, new byte[][] { FAMILYNAME }, 1, startKey,
stopKey,
+ 100);
+return tableName;
+ }
+
+
+ private
[jira] [Updated] (HBASE-26125) Backport HBASE-25401 "Add trace support for async call in rpc client" to branch-2
[ https://issues.apache.org/jira/browse/HBASE-26125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu updated HBASE-26125: - Description: [2/17 commits of HBASE-22120|https://github.com/apache/hbase/pull/2901/commits], original commit of HBASE-25401 was [https://github.com/apache/hbase/commit/242028671535dfed67ec13d9ed0d6067f3ccfd04] (was: [2/17 commits of HBASE-22120|https://github.com/apache/hbase/pull/2901/commits], original commit was https://github.com/apache/hbase/commit/242028671535dfed67ec13d9ed0d6067f3ccfd04) > Backport HBASE-25401 "Add trace support for async call in rpc client" to > branch-2 > - > > Key: HBASE-26125 > URL: https://issues.apache.org/jira/browse/HBASE-26125 > Project: HBase > Issue Type: Sub-task > Components: tracing >Affects Versions: 2.5.0 >Reporter: Tak-Lon (Stephen) Wu >Assignee: Tak-Lon (Stephen) Wu >Priority: Major > > [2/17 commits of > HBASE-22120|https://github.com/apache/hbase/pull/2901/commits], original > commit of HBASE-25401 was > [https://github.com/apache/hbase/commit/242028671535dfed67ec13d9ed0d6067f3ccfd04] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-26125) Backport HBASE-25401 "Add trace support for async call in rpc client" to branch-2
[ https://issues.apache.org/jira/browse/HBASE-26125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu updated HBASE-26125: - Description: [2/17 commits of HBASE-22120|https://github.com/apache/hbase/pull/2901/commits], original commit was https://github.com/apache/hbase/commit/242028671535dfed67ec13d9ed0d6067f3ccfd04 (was: [2/17 commits of HBASE-22120|https://github.com/apache/hbase/pull/2901/commits],) > Backport HBASE-25401 "Add trace support for async call in rpc client" to > branch-2 > - > > Key: HBASE-26125 > URL: https://issues.apache.org/jira/browse/HBASE-26125 > Project: HBase > Issue Type: Sub-task > Components: tracing >Affects Versions: 2.5.0 >Reporter: Tak-Lon (Stephen) Wu >Assignee: Tak-Lon (Stephen) Wu >Priority: Major > > [2/17 commits of > HBASE-22120|https://github.com/apache/hbase/pull/2901/commits], original > commit was > https://github.com/apache/hbase/commit/242028671535dfed67ec13d9ed0d6067f3ccfd04 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] taklwu opened a new pull request #3543: HBASE-26125 Backport HBASE-25401 "Add trace support for async call in…
taklwu opened a new pull request #3543: URL: https://github.com/apache/hbase/pull/3543 … rpc client" to branch-2 2/17 commits of HBASE-22120 original commit is 242028671535dfed67ec13d9ed0d6067f3ccfd04 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-26125) Backport HBASE-25401 "Add trace support for async call in rpc client" to branch-2
[ https://issues.apache.org/jira/browse/HBASE-26125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu updated HBASE-26125: - Summary: Backport HBASE-25401 "Add trace support for async call in rpc client" to branch-2 (was: Backport HBASE-25401 to branch-2) > Backport HBASE-25401 "Add trace support for async call in rpc client" to > branch-2 > - > > Key: HBASE-26125 > URL: https://issues.apache.org/jira/browse/HBASE-26125 > Project: HBase > Issue Type: Sub-task > Components: tracing >Affects Versions: 2.5.0 >Reporter: Tak-Lon (Stephen) Wu >Priority: Major > > [2/17 commits of > HBASE-22120|https://github.com/apache/hbase/pull/2901/commits], -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (HBASE-26125) Backport HBASE-25401 "Add trace support for async call in rpc client" to branch-2
[ https://issues.apache.org/jira/browse/HBASE-26125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu reassigned HBASE-26125: Assignee: Tak-Lon (Stephen) Wu > Backport HBASE-25401 "Add trace support for async call in rpc client" to > branch-2 > - > > Key: HBASE-26125 > URL: https://issues.apache.org/jira/browse/HBASE-26125 > Project: HBase > Issue Type: Sub-task > Components: tracing >Affects Versions: 2.5.0 >Reporter: Tak-Lon (Stephen) Wu >Assignee: Tak-Lon (Stephen) Wu >Priority: Major > > [2/17 commits of > HBASE-22120|https://github.com/apache/hbase/pull/2901/commits], -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-26124) Backport HBASE-25373 "Remove HTrace completely in code base and try to make use of OpenTelemetry" to branch-2
[ https://issues.apache.org/jira/browse/HBASE-26124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu resolved HBASE-26124. -- Hadoop Flags: Reviewed Release Note: https://github.com/apache/hbase/commit/f0493016062267fc37e14659d9183673d42a8f1d Resolution: Fixed > Backport HBASE-25373 "Remove HTrace completely in code base and try to make > use of OpenTelemetry" to branch-2 > - > > Key: HBASE-26124 > URL: https://issues.apache.org/jira/browse/HBASE-26124 > Project: HBase > Issue Type: Sub-task > Components: tracing >Affects Versions: 2.5.0, 2.3.5, 2.4.5 >Reporter: Tak-Lon (Stephen) Wu >Assignee: Tak-Lon (Stephen) Wu >Priority: Major > Fix For: 2.5.0 > > > [1/17 commits of > HBASE-22120|https://github.com/apache/hbase/pull/2901/commits], backporting > HBASE-25373 Remove HTrace completely in code base and try to make use of > OpenTelemetry > We will need to remove some unimplemented tracing in > AsyncRequestFutureImpl#getNewMultiActionRunnable that master branch does not > have it and also upstream in master does not implement TraceRunnable with > OpenTelemetry plugin > the original commit on master is > https://github.com/apache/hbase/commit/302d9ea8b888762a5a20a5ba5c2be7bc239afaef > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-26125) Backport HBASE-25401 to branch-2
[ https://issues.apache.org/jira/browse/HBASE-26125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu updated HBASE-26125: - Description: [2/17 commits of HBASE-22120|https://github.com/apache/hbase/pull/2901/commits], > Backport HBASE-25401 to branch-2 > > > Key: HBASE-26125 > URL: https://issues.apache.org/jira/browse/HBASE-26125 > Project: HBase > Issue Type: Sub-task > Components: tracing >Affects Versions: 2.5.0 >Reporter: Tak-Lon (Stephen) Wu >Priority: Major > > [2/17 commits of > HBASE-22120|https://github.com/apache/hbase/pull/2901/commits], -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-26124) Backport HBASE-25373 "Remove HTrace completely in code base and try to make use of OpenTelemetry" to branch-2
[ https://issues.apache.org/jira/browse/HBASE-26124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu updated HBASE-26124: - Fix Version/s: 2.5.0 Affects Version/s: 2.3.5 2.4.5 code committed to branch-2 https://github.com/apache/hbase/commit/f0493016062267fc37e14659d9183673d42a8f1d > Backport HBASE-25373 "Remove HTrace completely in code base and try to make > use of OpenTelemetry" to branch-2 > - > > Key: HBASE-26124 > URL: https://issues.apache.org/jira/browse/HBASE-26124 > Project: HBase > Issue Type: Sub-task > Components: tracing >Affects Versions: 2.5.0, 2.3.5, 2.4.5 >Reporter: Tak-Lon (Stephen) Wu >Assignee: Tak-Lon (Stephen) Wu >Priority: Major > Fix For: 2.5.0 > > > [1/17 commits of > HBASE-22120|https://github.com/apache/hbase/pull/2901/commits], backporting > HBASE-25373 Remove HTrace completely in code base and try to make use of > OpenTelemetry > We will need to remove some unimplemented tracing in > AsyncRequestFutureImpl#getNewMultiActionRunnable that master branch does not > have it and also upstream in master does not implement TraceRunnable with > OpenTelemetry plugin > the original commit on master is > https://github.com/apache/hbase/commit/302d9ea8b888762a5a20a5ba5c2be7bc239afaef > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-26154) Provide exception metric for quota exceeded and throttling
Bryan Beaudreault created HBASE-26154: - Summary: Provide exception metric for quota exceeded and throttling Key: HBASE-26154 URL: https://issues.apache.org/jira/browse/HBASE-26154 Project: HBase Issue Type: Improvement Reporter: Bryan Beaudreault Assignee: Bryan Beaudreault We should add metrics for QuotaExceededException and RpcThrottlingException. This is something we've found very useful to track as it helps us identify bad access patterns in clients. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (HBASE-26152) TestShadedHBaseTestingUtility failing with NoSuchMethodError
[
https://issues.apache.org/jira/browse/HBASE-26152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17390070#comment-17390070
]
Andrew Kyle Purtell edited comment on HBASE-26152 at 7/29/21, 6:32 PM:
---
Affects all 2.4.x.
The fix is going to be untangling the issues with transitive shaded
dependencies post 2.3.
was (Author: apurtell):
Affects all 2.4.x.
> TestShadedHBaseTestingUtility failing with NoSuchMethodError
>
>
> Key: HBASE-26152
> URL: https://issues.apache.org/jira/browse/HBASE-26152
> Project: HBase
> Issue Type: Task
>Affects Versions: 2.4.0, 2.4.1, 2.4.2, 2.4.3, 2.4.4, 2.4.5
>Reporter: Andrew Kyle Purtell
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-2, 2.4.6
>
>
> {noformat}
> [INFO] ---
> [INFO] T E S T S
> [INFO] ---
> [INFO] Running org.apache.hbase.shaded.TestShadedHBaseTestingUtility
> [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
> 19.515 s <<< FAILURE! - in
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility
> [ERROR] org.apache.hbase.shaded.TestShadedHBaseTestingUtility Time elapsed:
> 19.513 s <<< ERROR!
> java.io.IOException: Shutting down
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> Caused by: java.lang.RuntimeException: Failed construction of Master: class
> org.apache.hadoop.hbase.master.HMasterMultiple exceptions
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> Caused by: java.io.IOException: Problem starting http server
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> Caused by: org.apache.hbase.thirdparty.org.eclipse.jetty.util.MultiException:
> Multiple exceptions
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> Caused by: java.lang.NoSuchMethodError:
> javax.servlet.ServletContext.createFilter(Ljava/lang/Class;)Ljavax/servlet/Filter;
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> [INFO]
> [INFO] Results:
> [INFO]
> [ERROR] Errors:
> [ERROR] TestShadedHBaseTestingUtility.setUp:47 » IO Shutting down
> [INFO]
> [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-26152) TestShadedHBaseTestingUtility failing with NoSuchMethodError
[
https://issues.apache.org/jira/browse/HBASE-26152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17390070#comment-17390070
]
Andrew Kyle Purtell commented on HBASE-26152:
-
Affects all 2.4.x.
> TestShadedHBaseTestingUtility failing with NoSuchMethodError
>
>
> Key: HBASE-26152
> URL: https://issues.apache.org/jira/browse/HBASE-26152
> Project: HBase
> Issue Type: Task
>Affects Versions: 2.4.0, 2.4.1, 2.4.2, 2.4.3, 2.4.4, 2.4.5
>Reporter: Andrew Kyle Purtell
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-2, 2.4.6
>
>
> {noformat}
> [INFO] ---
> [INFO] T E S T S
> [INFO] ---
> [INFO] Running org.apache.hbase.shaded.TestShadedHBaseTestingUtility
> [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
> 19.515 s <<< FAILURE! - in
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility
> [ERROR] org.apache.hbase.shaded.TestShadedHBaseTestingUtility Time elapsed:
> 19.513 s <<< ERROR!
> java.io.IOException: Shutting down
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> Caused by: java.lang.RuntimeException: Failed construction of Master: class
> org.apache.hadoop.hbase.master.HMasterMultiple exceptions
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> Caused by: java.io.IOException: Problem starting http server
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> Caused by: org.apache.hbase.thirdparty.org.eclipse.jetty.util.MultiException:
> Multiple exceptions
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> Caused by: java.lang.NoSuchMethodError:
> javax.servlet.ServletContext.createFilter(Ljava/lang/Class;)Ljavax/servlet/Filter;
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> [INFO]
> [INFO] Results:
> [INFO]
> [ERROR] Errors:
> [ERROR] TestShadedHBaseTestingUtility.setUp:47 » IO Shutting down
> [INFO]
> [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-26152) TestShadedHBaseTestingUtility failing with NoSuchMethodError
[
https://issues.apache.org/jira/browse/HBASE-26152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Kyle Purtell updated HBASE-26152:
Affects Version/s: 2.4.0
> TestShadedHBaseTestingUtility failing with NoSuchMethodError
>
>
> Key: HBASE-26152
> URL: https://issues.apache.org/jira/browse/HBASE-26152
> Project: HBase
> Issue Type: Task
>Affects Versions: 2.4.0, 2.4.1, 2.4.2, 2.4.3, 2.4.4, 2.4.5
>Reporter: Andrew Kyle Purtell
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-2, 2.4.6
>
>
> {noformat}
> [INFO] ---
> [INFO] T E S T S
> [INFO] ---
> [INFO] Running org.apache.hbase.shaded.TestShadedHBaseTestingUtility
> [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
> 19.515 s <<< FAILURE! - in
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility
> [ERROR] org.apache.hbase.shaded.TestShadedHBaseTestingUtility Time elapsed:
> 19.513 s <<< ERROR!
> java.io.IOException: Shutting down
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> Caused by: java.lang.RuntimeException: Failed construction of Master: class
> org.apache.hadoop.hbase.master.HMasterMultiple exceptions
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> Caused by: java.io.IOException: Problem starting http server
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> Caused by: org.apache.hbase.thirdparty.org.eclipse.jetty.util.MultiException:
> Multiple exceptions
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> Caused by: java.lang.NoSuchMethodError:
> javax.servlet.ServletContext.createFilter(Ljava/lang/Class;)Ljavax/servlet/Filter;
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> [INFO]
> [INFO] Results:
> [INFO]
> [ERROR] Errors:
> [ERROR] TestShadedHBaseTestingUtility.setUp:47 » IO Shutting down
> [INFO]
> [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] saintstack opened a new pull request #3542: HBASE-26153 [create-release] Use cmd-line defined env vars
saintstack opened a new pull request #3542: URL: https://github.com/apache/hbase/pull/3542 Allow defining the below on the command-line (previously you could not): RC_COUNT RELEASE_TAG GPG_KEY Adds an edit of the usage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-26152) TestShadedHBaseTestingUtility failing with NoSuchMethodError
[
https://issues.apache.org/jira/browse/HBASE-26152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Kyle Purtell updated HBASE-26152:
Affects Version/s: 2.4.1
> TestShadedHBaseTestingUtility failing with NoSuchMethodError
>
>
> Key: HBASE-26152
> URL: https://issues.apache.org/jira/browse/HBASE-26152
> Project: HBase
> Issue Type: Task
>Affects Versions: 2.4.1, 2.4.2, 2.4.3, 2.4.4, 2.4.5
>Reporter: Andrew Kyle Purtell
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-2, 2.4.6
>
>
> {noformat}
> [INFO] ---
> [INFO] T E S T S
> [INFO] ---
> [INFO] Running org.apache.hbase.shaded.TestShadedHBaseTestingUtility
> [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
> 19.515 s <<< FAILURE! - in
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility
> [ERROR] org.apache.hbase.shaded.TestShadedHBaseTestingUtility Time elapsed:
> 19.513 s <<< ERROR!
> java.io.IOException: Shutting down
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> Caused by: java.lang.RuntimeException: Failed construction of Master: class
> org.apache.hadoop.hbase.master.HMasterMultiple exceptions
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> Caused by: java.io.IOException: Problem starting http server
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> Caused by: org.apache.hbase.thirdparty.org.eclipse.jetty.util.MultiException:
> Multiple exceptions
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> Caused by: java.lang.NoSuchMethodError:
> javax.servlet.ServletContext.createFilter(Ljava/lang/Class;)Ljavax/servlet/Filter;
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> [INFO]
> [INFO] Results:
> [INFO]
> [ERROR] Errors:
> [ERROR] TestShadedHBaseTestingUtility.setUp:47 » IO Shutting down
> [INFO]
> [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (HBASE-26153) [create-release] Use cmd-line defined env vars
Michael Stack created HBASE-26153: - Summary: [create-release] Use cmd-line defined env vars Key: HBASE-26153 URL: https://issues.apache.org/jira/browse/HBASE-26153 Project: HBase Issue Type: Improvement Components: RC Reporter: Michael Stack Minor item. The create-release scripts allows defining some of the variables used on the command line but not all. Fix. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (HBASE-26152) TestShadedHBaseTestingUtility failing with NoSuchMethodError
[
https://issues.apache.org/jira/browse/HBASE-26152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17390046#comment-17390046
]
Andrew Kyle Purtell edited comment on HBASE-26152 at 7/29/21, 5:40 PM:
---
Bisecting. So far it's reproducible at rel/2.4.2, rel/2.4.3, and rel/2.4.4, so
it's been with us for a while. Java 8. MacOS X x86_64. Not sure why it didn't
turn up in release voting. I'll report back if I find a clear culprit, although
I'm guessing it will be whenever we set what is the current hbase-thirdparty
version in the POMs.
was (Author: apurtell):
Bisecting. So far it's reproducible at rel/2.4.3 and rel/2.4.4, so it's been
with us for a while. Java 8. MacOS X x86_64. Not sure why it didn't turn up in
release voting. I'll report back if I find a clear culprit, although I'm
guessing it will be whenever we set what is the current hbase-thirdparty
version in the POMs.
> TestShadedHBaseTestingUtility failing with NoSuchMethodError
>
>
> Key: HBASE-26152
> URL: https://issues.apache.org/jira/browse/HBASE-26152
> Project: HBase
> Issue Type: Task
>Affects Versions: 2.4.3, 2.4.4, 2.4.5
>Reporter: Andrew Kyle Purtell
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-2, 2.4.6
>
>
> {noformat}
> [INFO] ---
> [INFO] T E S T S
> [INFO] ---
> [INFO] Running org.apache.hbase.shaded.TestShadedHBaseTestingUtility
> [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
> 19.515 s <<< FAILURE! - in
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility
> [ERROR] org.apache.hbase.shaded.TestShadedHBaseTestingUtility Time elapsed:
> 19.513 s <<< ERROR!
> java.io.IOException: Shutting down
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> Caused by: java.lang.RuntimeException: Failed construction of Master: class
> org.apache.hadoop.hbase.master.HMasterMultiple exceptions
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> Caused by: java.io.IOException: Problem starting http server
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> Caused by: org.apache.hbase.thirdparty.org.eclipse.jetty.util.MultiException:
> Multiple exceptions
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> Caused by: java.lang.NoSuchMethodError:
> javax.servlet.ServletContext.createFilter(Ljava/lang/Class;)Ljavax/servlet/Filter;
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> [INFO]
> [INFO] Results:
> [INFO]
> [ERROR] Errors:
> [ERROR] TestShadedHBaseTestingUtility.setUp:47 » IO Shutting down
> [INFO]
> [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-26152) TestShadedHBaseTestingUtility failing with NoSuchMethodError
[
https://issues.apache.org/jira/browse/HBASE-26152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Kyle Purtell updated HBASE-26152:
Affects Version/s: 2.4.2
> TestShadedHBaseTestingUtility failing with NoSuchMethodError
>
>
> Key: HBASE-26152
> URL: https://issues.apache.org/jira/browse/HBASE-26152
> Project: HBase
> Issue Type: Task
>Affects Versions: 2.4.2, 2.4.3, 2.4.4, 2.4.5
>Reporter: Andrew Kyle Purtell
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-2, 2.4.6
>
>
> {noformat}
> [INFO] ---
> [INFO] T E S T S
> [INFO] ---
> [INFO] Running org.apache.hbase.shaded.TestShadedHBaseTestingUtility
> [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
> 19.515 s <<< FAILURE! - in
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility
> [ERROR] org.apache.hbase.shaded.TestShadedHBaseTestingUtility Time elapsed:
> 19.513 s <<< ERROR!
> java.io.IOException: Shutting down
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> Caused by: java.lang.RuntimeException: Failed construction of Master: class
> org.apache.hadoop.hbase.master.HMasterMultiple exceptions
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> Caused by: java.io.IOException: Problem starting http server
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> Caused by: org.apache.hbase.thirdparty.org.eclipse.jetty.util.MultiException:
> Multiple exceptions
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> Caused by: java.lang.NoSuchMethodError:
> javax.servlet.ServletContext.createFilter(Ljava/lang/Class;)Ljavax/servlet/Filter;
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> [INFO]
> [INFO] Results:
> [INFO]
> [ERROR] Errors:
> [ERROR] TestShadedHBaseTestingUtility.setUp:47 » IO Shutting down
> [INFO]
> [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (HBASE-26152) TestShadedHBaseTestingUtility failing with NoSuchMethodError
[
https://issues.apache.org/jira/browse/HBASE-26152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17390046#comment-17390046
]
Andrew Kyle Purtell edited comment on HBASE-26152 at 7/29/21, 5:39 PM:
---
Bisecting. So far it's reproducible at rel/2.4.3 and rel/2.4.4, so it's been
with us for a while. Java 8. MacOS X x86_64. Not sure why it didn't turn up in
release voting. I'll report back if I find a clear culprit, although I'm
guessing it will be whenever we set what is the current hbase-thirdparty
version in the POMs.
was (Author: apurtell):
Bisecting. So far it's reproducible at rel/2.4.3 and rel/2.4.4, so it's been
with us for a while. Java 8. MacOS X x86_64. Not sure why it didn't turn up in
release voting. I'll report back if I find a clear culprit, although I'm
guessing it will be whenever we adjusted for the current hbase-thirdparty
version.
> TestShadedHBaseTestingUtility failing with NoSuchMethodError
>
>
> Key: HBASE-26152
> URL: https://issues.apache.org/jira/browse/HBASE-26152
> Project: HBase
> Issue Type: Task
>Affects Versions: 2.4.3, 2.4.4, 2.4.5
>Reporter: Andrew Kyle Purtell
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-2, 2.4.6
>
>
> {noformat}
> [INFO] ---
> [INFO] T E S T S
> [INFO] ---
> [INFO] Running org.apache.hbase.shaded.TestShadedHBaseTestingUtility
> [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
> 19.515 s <<< FAILURE! - in
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility
> [ERROR] org.apache.hbase.shaded.TestShadedHBaseTestingUtility Time elapsed:
> 19.513 s <<< ERROR!
> java.io.IOException: Shutting down
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> Caused by: java.lang.RuntimeException: Failed construction of Master: class
> org.apache.hadoop.hbase.master.HMasterMultiple exceptions
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> Caused by: java.io.IOException: Problem starting http server
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> Caused by: org.apache.hbase.thirdparty.org.eclipse.jetty.util.MultiException:
> Multiple exceptions
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> Caused by: java.lang.NoSuchMethodError:
> javax.servlet.ServletContext.createFilter(Ljava/lang/Class;)Ljavax/servlet/Filter;
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> [INFO]
> [INFO] Results:
> [INFO]
> [ERROR] Errors:
> [ERROR] TestShadedHBaseTestingUtility.setUp:47 » IO Shutting down
> [INFO]
> [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-26152) TestShadedHBaseTestingUtility failing with NoSuchMethodError
[
https://issues.apache.org/jira/browse/HBASE-26152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17390046#comment-17390046
]
Andrew Kyle Purtell commented on HBASE-26152:
-
Bisecting. So far it's reproducible at rel/2.4.3 and rel/2.4.4, so it's been
with us for a while. Java 8. MacOS X x86_64. Not sure why it didn't turn up in
release voting. I'll report back if I find a clear culprit, although I'm
guessing it will be whenever we adjusted for the current hbase-thirdparty
version.
> TestShadedHBaseTestingUtility failing with NoSuchMethodError
>
>
> Key: HBASE-26152
> URL: https://issues.apache.org/jira/browse/HBASE-26152
> Project: HBase
> Issue Type: Task
>Affects Versions: 2.4.3, 2.4.4, 2.4.5
>Reporter: Andrew Kyle Purtell
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-2, 2.4.6
>
>
> {noformat}
> [INFO] ---
> [INFO] T E S T S
> [INFO] ---
> [INFO] Running org.apache.hbase.shaded.TestShadedHBaseTestingUtility
> [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
> 19.515 s <<< FAILURE! - in
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility
> [ERROR] org.apache.hbase.shaded.TestShadedHBaseTestingUtility Time elapsed:
> 19.513 s <<< ERROR!
> java.io.IOException: Shutting down
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> Caused by: java.lang.RuntimeException: Failed construction of Master: class
> org.apache.hadoop.hbase.master.HMasterMultiple exceptions
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> Caused by: java.io.IOException: Problem starting http server
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> Caused by: org.apache.hbase.thirdparty.org.eclipse.jetty.util.MultiException:
> Multiple exceptions
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> Caused by: java.lang.NoSuchMethodError:
> javax.servlet.ServletContext.createFilter(Ljava/lang/Class;)Ljavax/servlet/Filter;
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> [INFO]
> [INFO] Results:
> [INFO]
> [ERROR] Errors:
> [ERROR] TestShadedHBaseTestingUtility.setUp:47 » IO Shutting down
> [INFO]
> [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-26152) TestShadedHBaseTestingUtility failing with NoSuchMethodError
[
https://issues.apache.org/jira/browse/HBASE-26152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Kyle Purtell updated HBASE-26152:
Affects Version/s: 2.4.3
> TestShadedHBaseTestingUtility failing with NoSuchMethodError
>
>
> Key: HBASE-26152
> URL: https://issues.apache.org/jira/browse/HBASE-26152
> Project: HBase
> Issue Type: Task
>Affects Versions: 2.4.3, 2.4.4, 2.4.5
>Reporter: Andrew Kyle Purtell
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-2, 2.4.6
>
>
> {noformat}
> [INFO] ---
> [INFO] T E S T S
> [INFO] ---
> [INFO] Running org.apache.hbase.shaded.TestShadedHBaseTestingUtility
> [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
> 19.515 s <<< FAILURE! - in
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility
> [ERROR] org.apache.hbase.shaded.TestShadedHBaseTestingUtility Time elapsed:
> 19.513 s <<< ERROR!
> java.io.IOException: Shutting down
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> Caused by: java.lang.RuntimeException: Failed construction of Master: class
> org.apache.hadoop.hbase.master.HMasterMultiple exceptions
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> Caused by: java.io.IOException: Problem starting http server
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> Caused by: org.apache.hbase.thirdparty.org.eclipse.jetty.util.MultiException:
> Multiple exceptions
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> Caused by: java.lang.NoSuchMethodError:
> javax.servlet.ServletContext.createFilter(Ljava/lang/Class;)Ljavax/servlet/Filter;
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> [INFO]
> [INFO] Results:
> [INFO]
> [ERROR] Errors:
> [ERROR] TestShadedHBaseTestingUtility.setUp:47 » IO Shutting down
> [INFO]
> [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (HBASE-26152) TestShadedHBaseTestingUtility failing with NoSuchMethodError
Andrew Kyle Purtell created HBASE-26152:
---
Summary: TestShadedHBaseTestingUtility failing with
NoSuchMethodError
Key: HBASE-26152
URL: https://issues.apache.org/jira/browse/HBASE-26152
Project: HBase
Issue Type: Task
Affects Versions: 2.4.5, 2.4.4
Reporter: Andrew Kyle Purtell
Fix For: 2.5.0, 3.0.0-alpha-2, 2.4.6
{noformat}
[INFO] ---
[INFO] T E S T S
[INFO] ---
[INFO] Running org.apache.hbase.shaded.TestShadedHBaseTestingUtility
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 19.515
s <<< FAILURE! - in org.apache.hbase.shaded.TestShadedHBaseTestingUtility
[ERROR] org.apache.hbase.shaded.TestShadedHBaseTestingUtility Time elapsed:
19.513 s <<< ERROR!
java.io.IOException: Shutting down
at
org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
Caused by: java.lang.RuntimeException: Failed construction of Master: class
org.apache.hadoop.hbase.master.HMasterMultiple exceptions
at
org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
Caused by: java.io.IOException: Problem starting http server
at
org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
Caused by: org.apache.hbase.thirdparty.org.eclipse.jetty.util.MultiException:
Multiple exceptions
at
org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
Caused by: java.lang.NoSuchMethodError:
javax.servlet.ServletContext.createFilter(Ljava/lang/Class;)Ljavax/servlet/Filter;
at
org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
[INFO]
[INFO] Results:
[INFO]
[ERROR] Errors:
[ERROR] TestShadedHBaseTestingUtility.setUp:47 » IO Shutting down
[INFO]
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0
{noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-26147) Add dry run mode to hbase balancer
[ https://issues.apache.org/jira/browse/HBASE-26147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17390039#comment-17390039 ] Bryan Beaudreault commented on HBASE-26147: --- I've added the dry_run_balance_rsgroup command and related RSGroupAdmin, etc in my latest commit on the PR. One piece to point out: For both the normal balancer and the rsgroup balancer, I'm currently running preBalance coprocessors but _not_ postBalance. The thought here is that preBalance is likely to be setup stuff, while postBalance expects to be called after regions have moved so might not be safe to call. I can see how this might be a little confusing or error prone though, so I'd also be open to skipping coprocessors altogether for dry run. I thought about adding a dry run argument to the coprocessor call, but that would mean an interface change. I could also add dryrun-specific coprocessor methods, but not sure how valuable that is. Thoughts? > Add dry run mode to hbase balancer > -- > > Key: HBASE-26147 > URL: https://issues.apache.org/jira/browse/HBASE-26147 > Project: HBase > Issue Type: Improvement > Components: Balancer, master >Reporter: Bryan Beaudreault >Assignee: Bryan Beaudreault >Priority: Major > > It's often rather hard to know how the cost function changes you're making > will affect the balance of the cluster, and currently the only way to know is > to run it. If the cost decisions are not good, you may have just moved many > regions towards a non-ideal balance. Region moves themselves are not free for > clients, and the resulting balance may cause a regression. > We should add a mode to the balancer so that it can be invoked without > actually executing any plans. This will allow an administrator to iterate on > their cost functions and used the balancer's logging to see how their changes > would affect the cluster. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] taklwu merged pull request #3529: HBASE-26124 Backport HBASE-25373 "Remove HTrace completely in code base and try to make use of OpenTelemetry" to branch-2
taklwu merged pull request #3529: URL: https://github.com/apache/hbase/pull/3529 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] taklwu commented on pull request #3529: HBASE-26124 Backport HBASE-25373 "Remove HTrace completely in code base and try to make use of OpenTelemetry" to branch-2
taklwu commented on pull request #3529: URL: https://github.com/apache/hbase/pull/3529#issuecomment-889278230 javac, checkstyle and rubocop have all been fixed, merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-26151) Reimplement MasterAddressTracker to also cache backup master addresses
[ https://issues.apache.org/jira/browse/HBASE-26151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26151: -- Component/s: Zookeeper Client > Reimplement MasterAddressTracker to also cache backup master addresses > -- > > Key: HBASE-26151 > URL: https://issues.apache.org/jira/browse/HBASE-26151 > Project: HBase > Issue Type: Sub-task > Components: Client, Zookeeper >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > > Now it will fetch backup master addresses every time, which is not a very > good idea if we want to expose the data to client. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-26151) Reimplement MasterAddressTracker to also cache backup master addresses
Duo Zhang created HBASE-26151: - Summary: Reimplement MasterAddressTracker to also cache backup master addresses Key: HBASE-26151 URL: https://issues.apache.org/jira/browse/HBASE-26151 Project: HBase Issue Type: Sub-task Reporter: Duo Zhang Now it will fetch backup master addresses every time, which is not a very good idea if we want to expose the data to client. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (HBASE-26151) Reimplement MasterAddressTracker to also cache backup master addresses
[ https://issues.apache.org/jira/browse/HBASE-26151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-26151: - Assignee: Duo Zhang > Reimplement MasterAddressTracker to also cache backup master addresses > -- > > Key: HBASE-26151 > URL: https://issues.apache.org/jira/browse/HBASE-26151 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > > Now it will fetch backup master addresses every time, which is not a very > good idea if we want to expose the data to client. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #3532: HBASE-26122: Implement an optional maximum size for Gets, after which a partial result is returned
Apache-HBase commented on pull request #3532: URL: https://github.com/apache/hbase/pull/3532#issuecomment-889227429 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 17s | Docker mode activated. | | -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 44s | branch-2 passed | | +1 :green_heart: | compile | 2m 42s | branch-2 passed | | +1 :green_heart: | shadedjars | 6m 31s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 35s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 20s | the patch passed | | +1 :green_heart: | compile | 2m 31s | the patch passed | | +1 :green_heart: | javac | 2m 31s | the patch passed | | +1 :green_heart: | shadedjars | 5m 56s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 32s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 44s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 0m 27s | hbase-protocol in the patch passed. | | +1 :green_heart: | unit | 2m 49s | hbase-client in the patch passed. | | -1 :x: | unit | 168m 36s | hbase-server in the patch failed. | | | | 204m 53s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3532/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3532 | | JIRA Issue | HBASE-26122 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 0bc23eec7e1d 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / d470b25e05 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3532/4/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3532/4/testReport/ | | Max. process+thread count | 3414 (vs. ulimit of 12500) | | modules | C: hbase-protocol-shaded hbase-protocol hbase-client hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3532/4/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work started] (HBASE-26150) Let region server also carry ClientMetaService
[ https://issues.apache.org/jira/browse/HBASE-26150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-26150 started by Duo Zhang. - > Let region server also carry ClientMetaService > -- > > Key: HBASE-26150 > URL: https://issues.apache.org/jira/browse/HBASE-26150 > Project: HBase > Issue Type: Sub-task > Components: Client, meta >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > > Usually region server will be deployed on machines which are more powerful > than masters, so it will be good to let region servers carries more load. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-26150) Let region server also carry ClientMetaService
Duo Zhang created HBASE-26150: - Summary: Let region server also carry ClientMetaService Key: HBASE-26150 URL: https://issues.apache.org/jira/browse/HBASE-26150 Project: HBase Issue Type: Sub-task Components: Client, meta Reporter: Duo Zhang Assignee: Duo Zhang Usually region server will be deployed on machines which are more powerful than masters, so it will be good to let region servers carries more load. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-25051) DIGEST based auth broken for MasterRegistry
[ https://issues.apache.org/jira/browse/HBASE-25051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25051: -- Parent Issue: HBASE-26149 (was: HBASE-18095) > DIGEST based auth broken for MasterRegistry > --- > > Key: HBASE-25051 > URL: https://issues.apache.org/jira/browse/HBASE-25051 > Project: HBase > Issue Type: Sub-task > Components: Client, security >Affects Versions: 3.0.0-alpha-1, 2.3.0, 1.7.0 >Reporter: Bharath Vissapragada >Assignee: Bharath Vissapragada >Priority: Minor > > DIGEST-MD5 based sasl auth depends on cluster-ID to obtain tokens. With > master registry, we have a circular dependency here because master registry > needs an rpcClient to talk to masters (and to get cluster ID) and rpc-Client > needs a clusterId if DIGEST based auth is configured. Earlier, there was a ZK > client that has its own authentication mechanism to fetch the cluster ID. > HBASE-23330, I think doesn't fully fix the problem. It depends on an active > connection to fetch delegation tokens for the MR job and that inherently > assumes that the active connection does not use a DIGEST auth. > It is not clear to me how common it is to use DIGEST based auth in > connections. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23324) Deprecate clients that connect to Zookeeper
[ https://issues.apache.org/jira/browse/HBASE-23324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-23324: -- Parent Issue: HBASE-26149 (was: HBASE-18095) > Deprecate clients that connect to Zookeeper > --- > > Key: HBASE-23324 > URL: https://issues.apache.org/jira/browse/HBASE-23324 > Project: HBase > Issue Type: Sub-task >Reporter: Nick Dimiduk >Priority: Major > > Sort out on what schedule we'll deprecated and then delete the old > client-to-zookeeper path. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-26149) Further improvements on ConnectionRegistry implementations
Duo Zhang created HBASE-26149: - Summary: Further improvements on ConnectionRegistry implementations Key: HBASE-26149 URL: https://issues.apache.org/jira/browse/HBASE-26149 Project: HBase Issue Type: Umbrella Components: Client Reporter: Duo Zhang -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #3532: HBASE-26122: Implement an optional maximum size for Gets, after which a partial result is returned
Apache-HBase commented on pull request #3532: URL: https://github.com/apache/hbase/pull/3532#issuecomment-889205967 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s | Docker mode activated. | | -0 :warning: | yetus | 0m 8s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 16s | branch-2 passed | | +1 :green_heart: | compile | 3m 2s | branch-2 passed | | +1 :green_heart: | shadedjars | 6m 52s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 40s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 58s | the patch passed | | +1 :green_heart: | compile | 3m 2s | the patch passed | | +1 :green_heart: | javac | 3m 2s | the patch passed | | +1 :green_heart: | shadedjars | 6m 44s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 39s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 53s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 0m 31s | hbase-protocol in the patch passed. | | +1 :green_heart: | unit | 2m 43s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 133m 50s | hbase-server in the patch passed. | | | | 173m 17s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3532/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3532 | | JIRA Issue | HBASE-26122 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 94222698b409 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / d470b25e05 | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3532/4/testReport/ | | Max. process+thread count | 4107 (vs. ulimit of 12500) | | modules | C: hbase-protocol-shaded hbase-protocol hbase-client hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3532/4/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3460: HBASE-26064 Introduce a StoreFileTracker to abstract the stor…
Apache-HBase commented on pull request #3460: URL: https://github.com/apache/hbase/pull/3460#issuecomment-889198188 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 38s | master passed | | +1 :green_heart: | compile | 1m 14s | master passed | | +1 :green_heart: | shadedjars | 10m 36s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 52s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 49s | the patch passed | | +1 :green_heart: | compile | 1m 37s | the patch passed | | +1 :green_heart: | javac | 1m 37s | the patch passed | | +1 :green_heart: | shadedjars | 11m 27s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 49s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 153m 2s | hbase-server in the patch passed. | | | | 192m 58s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3460/13/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3460 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 62e43b54c11b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 5f0950558f | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3460/13/testReport/ | | Max. process+thread count | 3650 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3460/13/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3460: HBASE-26064 Introduce a StoreFileTracker to abstract the stor…
Apache-HBase commented on pull request #3460: URL: https://github.com/apache/hbase/pull/3460#issuecomment-889179367 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 20s | master passed | | +1 :green_heart: | compile | 1m 11s | master passed | | +1 :green_heart: | shadedjars | 9m 13s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 42s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 57s | the patch passed | | +1 :green_heart: | compile | 1m 5s | the patch passed | | +1 :green_heart: | javac | 1m 5s | the patch passed | | +1 :green_heart: | shadedjars | 8m 16s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 35s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 160m 50s | hbase-server in the patch passed. | | | | 192m 56s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3460/13/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3460 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 14cc1a886f65 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 5f0950558f | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3460/13/testReport/ | | Max. process+thread count | 3733 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3460/13/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-26096) Cleanup the deprecated methods in HBTU related classes and format code
[
https://issues.apache.org/jira/browse/HBASE-26096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17389922#comment-17389922
]
Hudson commented on HBASE-26096:
Results for branch master
[build #355 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/355/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/355/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/355/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/355/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Cleanup the deprecated methods in HBTU related classes and format code
> --
>
> Key: HBASE-26096
> URL: https://issues.apache.org/jira/browse/HBASE-26096
> Project: HBase
> Issue Type: Sub-task
> Components: test
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0-alpha-2
>
>
> As it is now IA.LimitedPrivate, we should clean it up before the final 3.0.0
> release, to make the interface cleaner.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-26147) Add dry run mode to hbase balancer
[ https://issues.apache.org/jira/browse/HBASE-26147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17389878#comment-17389878 ] Bryan Beaudreault commented on HBASE-26147: --- [~rda3mon] For 1, I thought about building upon the existing balancer command. I decided against it for a couple reasons, which I'm happy to hear other opinions on: * I wasn't sure if we wanted to try to mirror Admin interface a bit, where the command is called dryRunBalance() * I personally prefer the more explicit syntax of having a separate command, as it's more discoverable and intuitive as an operator than string args * Above we've discussed ways in which we could build upon dry run mode, for example allow passing cost function overrides. I think that'd be easier with a separate command. In terms of Admin#dryRunBalance() vs Admin#balance(...) I felt like there were already lots of overloads of balance/balancer/etc, between deprecations and the force boolean. I think an ideal interface might include a RunMode enum, like I added internal to the HMaster. I didn't want to add another overload for that. Additionally, for the same reason as above if we decided to add on-demand config overrides for dry run mode that'd be a lot more straightforward with a separate command. Let me know if you still think it makes sense to have a single command. For 2, I'll take a look at rsgroup later today. I didn't realize there was a different implementation for it. > Add dry run mode to hbase balancer > -- > > Key: HBASE-26147 > URL: https://issues.apache.org/jira/browse/HBASE-26147 > Project: HBase > Issue Type: Improvement > Components: Balancer, master >Reporter: Bryan Beaudreault >Assignee: Bryan Beaudreault >Priority: Major > > It's often rather hard to know how the cost function changes you're making > will affect the balance of the cluster, and currently the only way to know is > to run it. If the cost decisions are not good, you may have just moved many > regions towards a non-ideal balance. Region moves themselves are not free for > clients, and the resulting balance may cause a regression. > We should add a mode to the balancer so that it can be invoked without > actually executing any plans. This will allow an administrator to iterate on > their cost functions and used the balancer's logging to see how their changes > would affect the cluster. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #3532: HBASE-26122: Implement an optional maximum size for Gets, after which a partial result is returned
Apache-HBase commented on pull request #3532: URL: https://github.com/apache/hbase/pull/3532#issuecomment-889087340 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +0 :ok: | prototool | 0m 0s | prototool was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 42s | branch-2 passed | | +1 :green_heart: | compile | 6m 12s | branch-2 passed | | +1 :green_heart: | checkstyle | 2m 16s | branch-2 passed | | +1 :green_heart: | spotbugs | 7m 7s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 17s | the patch passed | | +1 :green_heart: | compile | 6m 9s | the patch passed | | +1 :green_heart: | cc | 6m 9s | the patch passed | | +1 :green_heart: | javac | 6m 9s | the patch passed | | -0 :warning: | checkstyle | 1m 15s | hbase-server: The patch generated 5 new + 272 unchanged - 0 fixed = 277 total (was 272) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 41s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | hbaseprotoc | 2m 27s | the patch passed | | +1 :green_heart: | spotbugs | 7m 54s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 51s | The patch does not generate ASF License warnings. | | | | 63m 19s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3532/4/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3532 | | JIRA Issue | HBASE-26122 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool | | uname | Linux eddcc42bdce3 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / d470b25e05 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3532/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 96 (vs. ulimit of 12500) | | modules | C: hbase-protocol-shaded hbase-protocol hbase-client hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3532/4/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3541: HBASE-26114 when “hbase.mob.compaction.threads.max” is set to a negat…
Apache-HBase commented on pull request #3541: URL: https://github.com/apache/hbase/pull/3541#issuecomment-889062909 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 36s | Docker mode activated. | | -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | -1 :x: | mvninstall | 5m 23s | root in branch-2 failed. | | +1 :green_heart: | compile | 1m 39s | branch-2 passed | | +1 :green_heart: | shadedjars | 9m 38s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 7s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 44s | the patch passed | | +1 :green_heart: | compile | 1m 47s | the patch passed | | +1 :green_heart: | javac | 1m 47s | the patch passed | | +1 :green_heart: | shadedjars | 10m 29s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 4s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 232m 38s | hbase-server in the patch passed. | | | | 275m 49s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3541/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3541 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 15dc58fbc7ce 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / d470b25e05 | | Default Java | AdoptOpenJDK-11.0.10+9 | | mvninstall | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3541/1/artifact/yetus-jdk11-hadoop3-check/output/branch-mvninstall-root.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3541/1/testReport/ | | Max. process+thread count | 2822 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3541/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3460: HBASE-26064 Introduce a StoreFileTracker to abstract the stor…
Apache-HBase commented on pull request #3460: URL: https://github.com/apache/hbase/pull/3460#issuecomment-889057370 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 14s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 57s | master passed | | +1 :green_heart: | compile | 4m 2s | master passed | | +1 :green_heart: | checkstyle | 1m 21s | master passed | | +1 :green_heart: | spotbugs | 2m 44s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 50s | the patch passed | | +1 :green_heart: | compile | 3m 55s | the patch passed | | +1 :green_heart: | javac | 3m 55s | the patch passed | | +1 :green_heart: | checkstyle | 1m 17s | hbase-server: The patch generated 0 new + 146 unchanged - 15 fixed = 146 total (was 161) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 24m 43s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. | | +1 :green_heart: | spotbugs | 3m 3s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 18s | The patch does not generate ASF License warnings. | | | | 62m 22s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3460/13/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3460 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux 6a0a25031afb 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 5f0950558f | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Max. process+thread count | 86 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3460/13/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3460: HBASE-26064 Introduce a StoreFileTracker to abstract the stor…
Apache-HBase commented on pull request #3460: URL: https://github.com/apache/hbase/pull/3460#issuecomment-888987720 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 35s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 57s | master passed | | +1 :green_heart: | compile | 1m 35s | master passed | | +1 :green_heart: | shadedjars | 9m 51s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 50s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 55s | the patch passed | | +1 :green_heart: | compile | 1m 39s | the patch passed | | +1 :green_heart: | javac | 1m 39s | the patch passed | | +1 :green_heart: | shadedjars | 10m 56s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 57s | hbase-server generated 1 new + 86 unchanged - 0 fixed = 87 total (was 86) | ||| _ Other Tests _ | | -1 :x: | unit | 271m 7s | hbase-server in the patch failed. | | | | 315m 23s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3460/12/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3460 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 9e84eec9b1b4 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 5f0950558f | | Default Java | AdoptOpenJDK-11.0.10+9 | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3460/12/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3460/12/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3460/12/testReport/ | | Max. process+thread count | 2731 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3460/12/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3529: HBASE-26124 Backport HBASE-25373 "Remove HTrace completely in code base and try to make use of OpenTelemetry" to branch-2
Apache-HBase commented on pull request #3529: URL: https://github.com/apache/hbase/pull/3529#issuecomment-888963355 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 48s | Docker mode activated. | | -0 :warning: | yetus | 0m 8s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 43s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 6m 19s | branch-2 passed | | +1 :green_heart: | compile | 4m 0s | branch-2 passed | | +1 :green_heart: | shadedjars | 11m 16s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 8m 9s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 19s | the patch passed | | +1 :green_heart: | compile | 3m 32s | the patch passed | | +1 :green_heart: | javac | 3m 32s | the patch passed | | +1 :green_heart: | shadedjars | 7m 47s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 7m 33s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 186m 4s | root in the patch passed. | | | | 246m 19s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/7/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3529 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux fb6428c06c41 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / d470b25e05 | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/7/testReport/ | | Max. process+thread count | 6756 (vs. ulimit of 12500) | | modules | C: hbase-protocol-shaded hbase-common hbase-client hbase-zookeeper hbase-asyncfs hbase-server hbase-mapreduce hbase-shell hbase-it hbase-shaded hbase-shaded/hbase-shaded-client hbase-external-blockcache hbase-shaded/hbase-shaded-testing-util . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/7/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3541: HBASE-26114 when “hbase.mob.compaction.threads.max” is set to a negat…
Apache-HBase commented on pull request #3541: URL: https://github.com/apache/hbase/pull/3541#issuecomment-888906320 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 38s | branch-2 passed | | +1 :green_heart: | compile | 3m 43s | branch-2 passed | | +1 :green_heart: | checkstyle | 1m 10s | branch-2 passed | | +1 :green_heart: | spotbugs | 2m 28s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 39s | the patch passed | | +1 :green_heart: | compile | 3m 37s | the patch passed | | +1 :green_heart: | javac | 3m 37s | the patch passed | | +1 :green_heart: | checkstyle | 1m 14s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 13m 39s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 2m 25s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 16s | The patch does not generate ASF License warnings. | | | | 46m 6s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3541/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3541 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux 502657d5a664 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / d470b25e05 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Max. process+thread count | 96 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3541/1/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-26096) Cleanup the deprecated methods in HBTU related classes and format code
[ https://issues.apache.org/jira/browse/HBASE-26096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17389737#comment-17389737 ] Yose Simamora commented on HBASE-26096: --- Excuse me sir, can i ask you please sir about how to run the hbase from hbase gihub? > Cleanup the deprecated methods in HBTU related classes and format code > -- > > Key: HBASE-26096 > URL: https://issues.apache.org/jira/browse/HBASE-26096 > Project: HBase > Issue Type: Sub-task > Components: test >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0-alpha-2 > > > As it is now IA.LimitedPrivate, we should clean it up before the final 3.0.0 > release, to make the interface cleaner. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #3460: HBASE-26064 Introduce a StoreFileTracker to abstract the stor…
Apache-HBase commented on pull request #3460: URL: https://github.com/apache/hbase/pull/3460#issuecomment-81922 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 5s | master passed | | +1 :green_heart: | compile | 1m 0s | master passed | | +1 :green_heart: | shadedjars | 8m 12s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 39s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 41s | the patch passed | | +1 :green_heart: | compile | 1m 0s | the patch passed | | +1 :green_heart: | javac | 1m 0s | the patch passed | | +1 :green_heart: | shadedjars | 8m 18s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 36s | hbase-server generated 1 new + 21 unchanged - 0 fixed = 22 total (was 21) | ||| _ Other Tests _ | | -1 :x: | unit | 143m 20s | hbase-server in the patch failed. | | | | 173m 37s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3460/12/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3460 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 9f79f585a750 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 5f0950558f | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3460/12/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3460/12/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3460/12/testReport/ | | Max. process+thread count | 4354 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3460/12/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] liever18 opened a new pull request #3541: HBASE-26114 when “hbase.mob.compaction.threads.max” is set to a negat…
liever18 opened a new pull request #3541:
URL: https://github.com/apache/hbase/pull/3541
[https://issues.apache.org/jira/projects/HBASE/issues/HBASE-26114]
Description of PR
fix bug HBASE-26114
When the value is set to a negative number, such as -1, Hmaster cannot start
normally. When MOB_COMPACTION_THREADS_MAX is set to 0, mobUtil will set it to
1. But the program does not take into account that it is set to a negative
number.
changge
modified
if (maxThreads == 0) {
to
if (maxThreads <= 0) {
to improve the handling mechanism for the user to set
hbase.mob.compaction.threads.max as an abnormal value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] liever18 closed pull request #3539: [HBASE-26114][master]when “hbase.mob.compaction.threads.max” is set t…
liever18 closed pull request #3539: URL: https://github.com/apache/hbase/pull/3539 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-26114) when “hbase.mob.compaction.threads.max” is set to a negative number, HMaster cannot start normally
[
https://issues.apache.org/jira/browse/HBASE-26114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17389305#comment-17389305
]
Anoop Sam John commented on HBASE-26114:
I see. Keep the change in branch-2 only then
> when “hbase.mob.compaction.threads.max” is set to a negative number, HMaster
> cannot start normally
> ---
>
> Key: HBASE-26114
> URL: https://issues.apache.org/jira/browse/HBASE-26114
> Project: HBase
> Issue Type: Bug
> Components: master
>Affects Versions: 2.2.0, 2.4.4
> Environment: HBase 2.2.2
> os.name=Linux
> os.arch=amd64
> os.version=5.4.0-72-generic
> java.version=1.8.0_191
> java.vendor=Oracle Corporation
>Reporter: Jingxuan Fu
>Priority: Minor
> Labels: patch
> Fix For: 2.5.0, 3.0.0-alpha-2
>
> Attachments: HBASE-26114.000.patch
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> In hbase-default.xml：
>
> {code:java}
>
> hbase.mob.compaction.threads.max
> 1
>
> The max number of threads used in MobCompactor.
>
> {code}
>
> When the value is set to a negative number, such as -1, Hmaster cannot start
> normally.
> The log file will output:
>
> {code:cpp}
> 2021-07-22 18:54:13,758 ERROR [master/JavaFuzz:16000:becomeActiveMaster]
> master.HMaster: Failed to become active master
> java.lang.IllegalArgumentException
> at
> java.util.concurrent.ThreadPoolExecutor.(ThreadPoolExecutor.java:1314)
> at
> org.apache.hadoop.hbase.mob.MobUtils.createMobCompactorThreadPool(MobUtils.java:880)
> at org.apache.hadoop.hbase.master.MobCompactionChore.
> (MobCompactionChore.java:51) at
> org.apache.hadoop.hbase.master.HMaster.initMobCleaner(HMaster.java:1278)
> at
> org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:1161)
>
> at
> org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2112)
> at org.apache.hadoop.hbase.master.HMaster.lambda$run$0(HMaster.java:580)
> at java.lang.Thread.run(Thread.java:748)
> 2021-07-22 18:54:13,760 ERROR [master/JavaFuzz:16000:becomeActiveMaster]
> master.HMaster: Master server abort: loaded coprocessors are:
> [org.apache.hadoop.hbase.coprocessor.MultiRowMutationEndpoint]
> 2021-07-22 18:54:13,760 ERROR [master/JavaFuzz:16000:becomeActiveMaster]
> master.HMaster: * ABORTING master javafuzz,16000,1626951243154: Unhandled
> exception. Starting shutdown. * java.lang.IllegalArgumentException
> at
> java.util.concurrent.ThreadPoolExecutor.(ThreadPoolExecutor.java:1314)
> at
> org.apache.hadoop.hbase.mob.MobUtils.createMobCompactorThreadPool(MobUtils.java:880)
>
> at
> org.apache.hadoop.hbase.master.MobCompactionChore.(MobCompactionChore.java:51)
>
> at org.apache.hadoop.hbase.master.HMaster.initMobCleaner(HMaster.java:1278)
> at
> org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:1161)
>
> at
> org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2112)
>
> at org.apache.hadoop.hbase.master.HMaster.lambda$run$0(HMaster.java:580)
> at java.lang.Thread.run(Thread.java:748)
> 2021-07-
> 22 18:54:13,760 INFO [master/JavaFuzz:16000:becomeActiveMaster]
> regionserver.HRegionServer: * STOPPING region server
> 'javafuzz,16000,1626951243154' *{code}
>
> In MobUtils.java(package org.apache.hadoop.hbase.mob)
> This method from version 2.2.0 to version 2.4.4 is the same
> {code:java}
> public static ExecutorService createMobCompactorThreadPool(Configuration
> conf) { int maxThreads =
> conf.getInt(MobConstants.MOB_COMPACTION_THREADS_MAX,
> MobConstants.DEFAULT_MOB_COMPACTION_THREADS_MAX);
> if (maxThreads == 0) {
>maxThreads = 1;
> }
> final SynchronousQueue queue = new SynchronousQueue<>();
> ThreadPoolExecutor pool = new ThreadPoolExecutor(1, maxThreads, 60,
> TimeUnit.SECONDS, queue,
> Threads.newDaemonThreadFactory("MobCompactor"), new
> RejectedExecutionHandler() {
> @Override
> public void rejectedExecution(Runnable r, ThreadPoolExecutor
> executor) {
> try {
> // waiting for a thread to pick up instead of throwing
> exceptions.
> queue.put(r);
> } catch (InterruptedException e) {
> throw new RejectedExecutionException(e);
> }
> }
> });
> ((ThreadPoolExecutor) pool).allowCoreThreadTimeOut(true);
> return pool;
>}{code}
> When
[GitHub] [hbase] Apache-HBase commented on pull request #3539: [HBASE-26114][master]when “hbase.mob.compaction.threads.max” is set t…
Apache-HBase commented on pull request #3539: URL: https://github.com/apache/hbase/pull/3539#issuecomment-52736 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 47s | Docker mode activated. | | -0 :warning: | yetus | 0m 8s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2.3 Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 40s | branch-2.3 passed | | +1 :green_heart: | compile | 1m 13s | branch-2.3 passed | | +1 :green_heart: | shadedjars | 6m 30s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 47s | branch-2.3 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 25s | the patch passed | | +1 :green_heart: | compile | 1m 11s | the patch passed | | +1 :green_heart: | javac | 1m 11s | the patch passed | | +1 :green_heart: | shadedjars | 6m 48s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 46s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 229m 11s | hbase-server in the patch passed. | | | | 259m 31s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3539/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3539 | | JIRA Issue | HBASE-26114 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 63e960f31986 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.3 / fd1a3fcf7b | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3539/1/testReport/ | | Max. process+thread count | 2428 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3539/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-26114) when “hbase.mob.compaction.threads.max” is set to a negative number, HMaster cannot start normally
[
https://issues.apache.org/jira/browse/HBASE-26114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17389293#comment-17389293
]
Jingxuan Fu commented on HBASE-26114:
-
[~anoop.hbase] thanks for your advice.
I see "'hbase.mob.compaction.threads.max' is obsolete and not used anymore." in
master branch. It seems that version 3.0.0 has made major changes to this part.
What should I do next?
> when “hbase.mob.compaction.threads.max” is set to a negative number, HMaster
> cannot start normally
> ---
>
> Key: HBASE-26114
> URL: https://issues.apache.org/jira/browse/HBASE-26114
> Project: HBase
> Issue Type: Bug
> Components: master
>Affects Versions: 2.2.0, 2.4.4
> Environment: HBase 2.2.2
> os.name=Linux
> os.arch=amd64
> os.version=5.4.0-72-generic
> java.version=1.8.0_191
> java.vendor=Oracle Corporation
>Reporter: Jingxuan Fu
>Priority: Minor
> Labels: patch
> Fix For: 2.5.0, 3.0.0-alpha-2
>
> Attachments: HBASE-26114.000.patch
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> In hbase-default.xml：
>
> {code:java}
>
> hbase.mob.compaction.threads.max
> 1
>
> The max number of threads used in MobCompactor.
>
> {code}
>
> When the value is set to a negative number, such as -1, Hmaster cannot start
> normally.
> The log file will output:
>
> {code:cpp}
> 2021-07-22 18:54:13,758 ERROR [master/JavaFuzz:16000:becomeActiveMaster]
> master.HMaster: Failed to become active master
> java.lang.IllegalArgumentException
> at
> java.util.concurrent.ThreadPoolExecutor.(ThreadPoolExecutor.java:1314)
> at
> org.apache.hadoop.hbase.mob.MobUtils.createMobCompactorThreadPool(MobUtils.java:880)
> at org.apache.hadoop.hbase.master.MobCompactionChore.
> (MobCompactionChore.java:51) at
> org.apache.hadoop.hbase.master.HMaster.initMobCleaner(HMaster.java:1278)
> at
> org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:1161)
>
> at
> org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2112)
> at org.apache.hadoop.hbase.master.HMaster.lambda$run$0(HMaster.java:580)
> at java.lang.Thread.run(Thread.java:748)
> 2021-07-22 18:54:13,760 ERROR [master/JavaFuzz:16000:becomeActiveMaster]
> master.HMaster: Master server abort: loaded coprocessors are:
> [org.apache.hadoop.hbase.coprocessor.MultiRowMutationEndpoint]
> 2021-07-22 18:54:13,760 ERROR [master/JavaFuzz:16000:becomeActiveMaster]
> master.HMaster: * ABORTING master javafuzz,16000,1626951243154: Unhandled
> exception. Starting shutdown. * java.lang.IllegalArgumentException
> at
> java.util.concurrent.ThreadPoolExecutor.(ThreadPoolExecutor.java:1314)
> at
> org.apache.hadoop.hbase.mob.MobUtils.createMobCompactorThreadPool(MobUtils.java:880)
>
> at
> org.apache.hadoop.hbase.master.MobCompactionChore.(MobCompactionChore.java:51)
>
> at org.apache.hadoop.hbase.master.HMaster.initMobCleaner(HMaster.java:1278)
> at
> org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:1161)
>
> at
> org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2112)
>
> at org.apache.hadoop.hbase.master.HMaster.lambda$run$0(HMaster.java:580)
> at java.lang.Thread.run(Thread.java:748)
> 2021-07-
> 22 18:54:13,760 INFO [master/JavaFuzz:16000:becomeActiveMaster]
> regionserver.HRegionServer: * STOPPING region server
> 'javafuzz,16000,1626951243154' *{code}
>
> In MobUtils.java(package org.apache.hadoop.hbase.mob)
> This method from version 2.2.0 to version 2.4.4 is the same
> {code:java}
> public static ExecutorService createMobCompactorThreadPool(Configuration
> conf) { int maxThreads =
> conf.getInt(MobConstants.MOB_COMPACTION_THREADS_MAX,
> MobConstants.DEFAULT_MOB_COMPACTION_THREADS_MAX);
> if (maxThreads == 0) {
>maxThreads = 1;
> }
> final SynchronousQueue queue = new SynchronousQueue<>();
> ThreadPoolExecutor pool = new ThreadPoolExecutor(1, maxThreads, 60,
> TimeUnit.SECONDS, queue,
> Threads.newDaemonThreadFactory("MobCompactor"), new
> RejectedExecutionHandler() {
> @Override
> public void rejectedExecution(Runnable r, ThreadPoolExecutor
> executor) {
> try {
> // waiting for a thread to pick up instead of throwing
> exceptions.
> queue.put(r);
> } catch (InterruptedException e) {
> throw new RejectedExecutionException(e);
> }
[GitHub] [hbase] Apache-HBase commented on pull request #3533: HBASE-26144 The HStore.snapshot method is never called in main code
Apache-HBase commented on pull request #3533: URL: https://github.com/apache/hbase/pull/3533#issuecomment-50250 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 39s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 3s | master passed | | +1 :green_heart: | compile | 1m 22s | master passed | | +1 :green_heart: | shadedjars | 10m 11s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 43s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 22s | the patch passed | | +1 :green_heart: | compile | 1m 10s | the patch passed | | +1 :green_heart: | javac | 1m 10s | the patch passed | | +1 :green_heart: | shadedjars | 9m 30s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 41s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 234m 40s | hbase-server in the patch passed. | | | | 272m 29s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3533/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3533 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 478ceb3b3b0f 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 5f0950558f | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3533/3/testReport/ | | Max. process+thread count | 3136 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3533/3/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3529: HBASE-26124 Backport HBASE-25373 "Remove HTrace completely in code base and try to make use of OpenTelemetry" to branch-2
Apache-HBase commented on pull request #3529: URL: https://github.com/apache/hbase/pull/3529#issuecomment-49034 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 34s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 32s | branch-2 passed | | +1 :green_heart: | compile | 8m 50s | branch-2 passed | | +1 :green_heart: | checkstyle | 2m 17s | branch-2 passed | | +1 :green_heart: | spotbugs | 18m 20s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 21s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 27s | the patch passed | | +1 :green_heart: | compile | 9m 3s | the patch passed | | +1 :green_heart: | javac | 9m 3s | the patch passed | | +1 :green_heart: | checkstyle | 2m 22s | root: The patch generated 0 new + 736 unchanged - 27 fixed = 736 total (was 763) | | +1 :green_heart: | rubocop | 0m 3s | The patch generated 0 new + 3 unchanged - 8 fixed = 3 total (was 11) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 16s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 12m 30s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 21m 25s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 2m 46s | The patch does not generate ASF License warnings. | | | | 97m 40s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/7/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3529 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml rubocop | | uname | Linux 6c965c001b97 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / d470b25e05 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Max. process+thread count | 141 (vs. ulimit of 12500) | | modules | C: hbase-protocol-shaded hbase-common hbase-client hbase-zookeeper hbase-asyncfs hbase-server hbase-mapreduce hbase-shell hbase-it hbase-shaded hbase-shaded/hbase-shaded-client hbase-external-blockcache hbase-shaded/hbase-shaded-testing-util . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/7/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
