[jira] [Comment Edited] (HBASE-26712) Balancer encounters NPE in rare case
[
https://issues.apache.org/jira/browse/HBASE-26712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17494335#comment-17494335
]
chenglei edited comment on HBASE-26712 at 2/18/22, 3:03 AM:
It is a bug which found on branch-2.4，so also backport and push it to
branch-2.4.
was (Author: comnetwork):
It is bug which originates from 2.4，so also backport and push it to branch-2.4.
> Balancer encounters NPE in rare case
>
>
> Key: HBASE-26712
> URL: https://issues.apache.org/jira/browse/HBASE-26712
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.4.9
>Reporter: Viraj Jasani
>Assignee: chenglei
>Priority: Major
> Fix For: 2.5.0, 2.6.0, 3.0.0-alpha-3, 2.4.10
>
>
>
> {code:java}
> ERROR [ster-1:6.Chore.1] hbase.ScheduledChore - Caught error
> java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.master.assignment.AssignmentManager.balance(AssignmentManager.java:758)
> at
> org.apache.hadoop.hbase.master.HMaster.executeRegionPlansWithThrottling(HMaster.java:1834)
> at org.apache.hadoop.hbase.master.HMaster.balance(HMaster.java:1797)
> at org.apache.hadoop.hbase.master.HMaster.balance(HMaster.java:1707)
> at
> org.apache.hadoop.hbase.master.balancer.BalancerChore.chore(BalancerChore.java:49)
> at org.apache.hadoop.hbase.ScheduledChore.run(ScheduledChore.java:153)
> at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
> at
> org.apache.hadoop.hbase.JitterScheduledThreadPoolExecutorImpl$JitteredRunnableScheduledFuture.run(JitterScheduledThreadPoolExecutorImpl.java:111)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> {code}
> Let's fix this.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (HBASE-26712) Balancer encounters NPE in rare case
[
https://issues.apache.org/jira/browse/HBASE-26712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
chenglei updated HBASE-26712:
-
Fix Version/s: 2.4.10
> Balancer encounters NPE in rare case
>
>
> Key: HBASE-26712
> URL: https://issues.apache.org/jira/browse/HBASE-26712
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.4.9
>Reporter: Viraj Jasani
>Assignee: chenglei
>Priority: Major
> Fix For: 2.5.0, 2.6.0, 3.0.0-alpha-3, 2.4.10
>
>
>
> {code:java}
> ERROR [ster-1:6.Chore.1] hbase.ScheduledChore - Caught error
> java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.master.assignment.AssignmentManager.balance(AssignmentManager.java:758)
> at
> org.apache.hadoop.hbase.master.HMaster.executeRegionPlansWithThrottling(HMaster.java:1834)
> at org.apache.hadoop.hbase.master.HMaster.balance(HMaster.java:1797)
> at org.apache.hadoop.hbase.master.HMaster.balance(HMaster.java:1707)
> at
> org.apache.hadoop.hbase.master.balancer.BalancerChore.chore(BalancerChore.java:49)
> at org.apache.hadoop.hbase.ScheduledChore.run(ScheduledChore.java:153)
> at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
> at
> org.apache.hadoop.hbase.JitterScheduledThreadPoolExecutorImpl$JitteredRunnableScheduledFuture.run(JitterScheduledThreadPoolExecutorImpl.java:111)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> {code}
> Let's fix this.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (HBASE-26712) Balancer encounters NPE in rare case
[
https://issues.apache.org/jira/browse/HBASE-26712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17494335#comment-17494335
]
chenglei commented on HBASE-26712:
--
It is bug which originates from 2.4，so also backport and push it to branch-2.4.
> Balancer encounters NPE in rare case
>
>
> Key: HBASE-26712
> URL: https://issues.apache.org/jira/browse/HBASE-26712
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.4.9
>Reporter: Viraj Jasani
>Assignee: chenglei
>Priority: Major
> Fix For: 2.5.0, 2.6.0, 3.0.0-alpha-3
>
>
>
> {code:java}
> ERROR [ster-1:6.Chore.1] hbase.ScheduledChore - Caught error
> java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.master.assignment.AssignmentManager.balance(AssignmentManager.java:758)
> at
> org.apache.hadoop.hbase.master.HMaster.executeRegionPlansWithThrottling(HMaster.java:1834)
> at org.apache.hadoop.hbase.master.HMaster.balance(HMaster.java:1797)
> at org.apache.hadoop.hbase.master.HMaster.balance(HMaster.java:1707)
> at
> org.apache.hadoop.hbase.master.balancer.BalancerChore.chore(BalancerChore.java:49)
> at org.apache.hadoop.hbase.ScheduledChore.run(ScheduledChore.java:153)
> at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
> at
> org.apache.hadoop.hbase.JitterScheduledThreadPoolExecutorImpl$JitteredRunnableScheduledFuture.run(JitterScheduledThreadPoolExecutorImpl.java:111)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> {code}
> Let's fix this.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [hbase] comnetwork merged pull request #4117: HBASE-26712 Balancer encounters NPE in rare case
comnetwork merged pull request #4117: URL: https://github.com/apache/hbase/pull/4117 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] wchevreuil commented on a change in pull request #4111: HBASE-26640 Reimplement master local region initialization to better …
wchevreuil commented on a change in pull request #4111:
URL: https://github.com/apache/hbase/pull/4111#discussion_r809487400
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/region/MasterRegion.java
##
@@ -287,6 +303,39 @@ private static void replayWALs(Configuration conf,
FileSystem walFs, Path walRoo
}
}
+ private static void tryMigrate(Configuration conf, FileSystem fs, Path
tableDir,
+RegionInfo regionInfo, TableDescriptor oldTd, TableDescriptor newTd)
throws IOException {
+Class oldSft =
+
StoreFileTrackerFactory.getTrackerClass(oldTd.getValue(StoreFileTrackerFactory.TRACKER_IMPL));
+Class newSft =
+
StoreFileTrackerFactory.getTrackerClass(newTd.getValue(StoreFileTrackerFactory.TRACKER_IMPL));
+if (oldSft.equals(newSft)) {
+ LOG.debug("old store file tracker {} is the same with new store file
tracker, skip migration",
+StoreFileTrackerFactory.getStoreFileTrackerName(oldSft));
+ if (!oldSft.equals(newSft)) {
+// we may change other things such as adding a new family, so here we
still need to persist
+// the new table descriptor
+LOG.info("Update table descriptor from {} to {}", oldTd, newTd);
+FSTableDescriptors.createTableDescriptorForTableDirectory(fs,
tableDir, newTd, true);
+ }
Review comment:
I believe this block is never reached.
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/region/MasterRegionFactory.java
##
@@ -89,10 +94,23 @@
.setDataBlockEncoding(DataBlockEncoding.ROW_INDEX_V1).build())
.setColumnFamily(ColumnFamilyDescriptorBuilder.of(PROC_FAMILY)).build();
+ private static TableDescriptor withTrackerConfigs(Configuration conf) {
+String trackerImpl = conf.get(TRACKER_IMPL,
conf.get(StoreFileTrackerFactory.TRACKER_IMPL,
+ StoreFileTrackerFactory.Trackers.DEFAULT.name()));
+Class trackerClass =
+ StoreFileTrackerFactory.getTrackerClass(trackerImpl);
+if (StoreFileTrackerFactory.isMigration(trackerClass)) {
+ throw new IllegalArgumentException("Should not set store file tracker to
" +
+StoreFileTrackerFactory.Trackers.MIGRATION.name() + " for master local
region");
+}
+StoreFileTracker tracker = ReflectionUtils.newInstance(trackerClass, conf,
true, null);
+return
tracker.updateWithTrackerConfigs(TableDescriptorBuilder.newBuilder(TABLE_DESC)).build();
+ }
Review comment:
Could maybe go to one of the SFT related classes, like the SFT Factory
or the SFT validations util? I think we had already done some similar
validation elsewhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase-connectors] taklwu commented on a change in pull request #93: HBASE-22338 LICENSE file only contains Apache 2.0
taklwu commented on a change in pull request #93:
URL: https://github.com/apache/hbase-connectors/pull/93#discussion_r808616239
##
File path: pom.xml
##
@@ -128,6 +128,15 @@
${maven.build.timestamp}
1.8
${compileSource}
+
+2022
Review comment:
I can't the reason -.- although I tried to use `-Dbuild.year=2022` and
it worked I will revert the change for this build.year first. let me know
if you find any thing. my goal is to have the dependency included in the
`NOTICE` file correctly.
In addition, I'm wondered if we need to add a generated NOTICE for modules
of `spark` e.g. `hbase-spark`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (HBASE-26707) Reduce number of renames during bulkload
[ https://issues.apache.org/jira/browse/HBASE-26707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17494197#comment-17494197 ] Wellington Chevreuil commented on HBASE-26707: -- Thanks for the PR, [~bszabolcs]! Had merged into master branch, but trying to cherry-pick it into branch-2 had some conflicts. Would you mind push a branch-2 compatible PR? > Reduce number of renames during bulkload > > > Key: HBASE-26707 > URL: https://issues.apache.org/jira/browse/HBASE-26707 > Project: HBase > Issue Type: Sub-task >Reporter: Szabolcs Bukros >Assignee: Szabolcs Bukros >Priority: Major > > Make sure we only do a single rename operation during bulkload when > StoreEngine does not require the the use of tmp directories. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [hbase] BukrosSzabolcs commented on pull request #4066: HBASE-26707: Reduce number of renames during bulkload
BukrosSzabolcs commented on pull request #4066: URL: https://github.com/apache/hbase/pull/4066#issuecomment-1043347250 Thanks a lot @wchevreuil for your feedback and merging this! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] wchevreuil merged pull request #4066: HBASE-26707: Reduce number of renames during bulkload
wchevreuil merged pull request #4066: URL: https://github.com/apache/hbase/pull/4066 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] busbey commented on pull request #3926: HBASE-26546: hbase-shaded-client missing required thirdparty classes under hadoop 3.3.1
busbey commented on pull request #3926: URL: https://github.com/apache/hbase/pull/3926#issuecomment-1043337254 I agree that we should not be excluding these classes. there are already checks that allow for hadoop classes to show up in just those artifacts where we allow hadoop, and AFAICT the hadoop third party stuff is properly located. the failure that HBASE-25792 was in the `hbase-shaded-mapreduce` artifact, which isn't allowed to have any hadoop classes in the first place. So if there's no complaint after this change it likely just means that whatever was causing a leak of hadoop stuff into that module has since been fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-26760) LICENSE handling should not allow non-aggregated "apache-2.0"
[
https://issues.apache.org/jira/browse/HBASE-26760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey updated HBASE-26760:
Affects Version/s: 2.4.9
2.4.8
2.4.7
2.4.6
2.4.5
2.4.4
> LICENSE handling should not allow non-aggregated "apache-2.0"
> -
>
> Key: HBASE-26760
> URL: https://issues.apache.org/jira/browse/HBASE-26760
> Project: HBase
> Issue Type: Task
> Components: community
>Affects Versions: 2.4.3, 2.4.4, 2.4.5, 2.4.6, 2.4.7, 2.4.8, 2.4.9
>Reporter: Sean Busbey
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-3, 2.4.10
>
>
> our non-aggregated license check currently allows the malformed name
> "apache-2.0". All ALv2 licenses should be aggregated.
> - remove "apache-2.0" from the {{non_aggregate_fine}} list
> - figure out what dependencies are referring to this license and correct them
> in {{supplemental-models.xml}}
> nice to have: maybe add a precommit check that complains if the
> {{non_aggregate_fine}} set is changed?
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (HBASE-26760) LICENSE handling should not allow non-aggregated "apache-2.0"
[
https://issues.apache.org/jira/browse/HBASE-26760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey updated HBASE-26760:
Fix Version/s: 2.4.10
> LICENSE handling should not allow non-aggregated "apache-2.0"
> -
>
> Key: HBASE-26760
> URL: https://issues.apache.org/jira/browse/HBASE-26760
> Project: HBase
> Issue Type: Task
> Components: community
>Affects Versions: 2.4.3
>Reporter: Sean Busbey
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-3, 2.4.10
>
>
> our non-aggregated license check currently allows the malformed name
> "apache-2.0". All ALv2 licenses should be aggregated.
> - remove "apache-2.0" from the {{non_aggregate_fine}} list
> - figure out what dependencies are referring to this license and correct them
> in {{supplemental-models.xml}}
> nice to have: maybe add a precommit check that complains if the
> {{non_aggregate_fine}} set is changed?
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (HBASE-26760) LICENSE handling should not allow non-aggregated "apache-2.0"
[
https://issues.apache.org/jira/browse/HBASE-26760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey updated HBASE-26760:
Affects Version/s: (was: 2.4.10)
> LICENSE handling should not allow non-aggregated "apache-2.0"
> -
>
> Key: HBASE-26760
> URL: https://issues.apache.org/jira/browse/HBASE-26760
> Project: HBase
> Issue Type: Task
> Components: community
>Affects Versions: 2.4.3
>Reporter: Sean Busbey
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-3
>
>
> our non-aggregated license check currently allows the malformed name
> "apache-2.0". All ALv2 licenses should be aggregated.
> - remove "apache-2.0" from the {{non_aggregate_fine}} list
> - figure out what dependencies are referring to this license and correct them
> in {{supplemental-models.xml}}
> nice to have: maybe add a precommit check that complains if the
> {{non_aggregate_fine}} set is changed?
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (HBASE-26760) LICENSE handling should not allow non-aggregated "apache-2.0"
[
https://issues.apache.org/jira/browse/HBASE-26760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey updated HBASE-26760:
Fix Version/s: 3.0.0-alpha-3
> LICENSE handling should not allow non-aggregated "apache-2.0"
> -
>
> Key: HBASE-26760
> URL: https://issues.apache.org/jira/browse/HBASE-26760
> Project: HBase
> Issue Type: Task
> Components: community
>Affects Versions: 2.4.3, 2.4.10
>Reporter: Sean Busbey
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-3
>
>
> our non-aggregated license check currently allows the malformed name
> "apache-2.0". All ALv2 licenses should be aggregated.
> - remove "apache-2.0" from the {{non_aggregate_fine}} list
> - figure out what dependencies are referring to this license and correct them
> in {{supplemental-models.xml}}
> nice to have: maybe add a precommit check that complains if the
> {{non_aggregate_fine}} set is changed?
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (HBASE-26760) LICENSE handling should not allow non-aggregated "apache-2.0"
[
https://issues.apache.org/jira/browse/HBASE-26760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17494164#comment-17494164
]
Sean Busbey commented on HBASE-26760:
-
looks like the transitive dependencies should be found while building against
Hadoop 3.3 specifically.
> LICENSE handling should not allow non-aggregated "apache-2.0"
> -
>
> Key: HBASE-26760
> URL: https://issues.apache.org/jira/browse/HBASE-26760
> Project: HBase
> Issue Type: Task
> Components: community
>Affects Versions: 2.4.3, 2.4.10
>Reporter: Sean Busbey
>Priority: Major
> Fix For: 2.5.0
>
>
> our non-aggregated license check currently allows the malformed name
> "apache-2.0". All ALv2 licenses should be aggregated.
> - remove "apache-2.0" from the {{non_aggregate_fine}} list
> - figure out what dependencies are referring to this license and correct them
> in {{supplemental-models.xml}}
> nice to have: maybe add a precommit check that complains if the
> {{non_aggregate_fine}} set is changed?
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Created] (HBASE-26760) LICENSE handling should not allow non-aggregated "apache-2.0"
Sean Busbey created HBASE-26760:
---
Summary: LICENSE handling should not allow non-aggregated
"apache-2.0"
Key: HBASE-26760
URL: https://issues.apache.org/jira/browse/HBASE-26760
Project: HBase
Issue Type: Task
Components: community
Affects Versions: 2.4.3, 2.4.10
Reporter: Sean Busbey
Fix For: 2.5.0
our non-aggregated license check currently allows the malformed name
"apache-2.0". All ALv2 licenses should be aggregated.
- remove "apache-2.0" from the {{non_aggregate_fine}} list
- figure out what dependencies are referring to this license and correct them
in {{supplemental-models.xml}}
nice to have: maybe add a precommit check that complains if the
{{non_aggregate_fine}} set is changed?
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [hbase] Apache-HBase commented on pull request #4066: HBASE-26707: Reduce number of renames during bulkload
Apache-HBase commented on pull request #4066: URL: https://github.com/apache/hbase/pull/4066#issuecomment-1043310518 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 17s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 57s | master passed | | +1 :green_heart: | compile | 1m 0s | master passed | | +1 :green_heart: | shadedjars | 5m 19s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 36s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 47s | the patch passed | | +1 :green_heart: | compile | 1m 2s | the patch passed | | +1 :green_heart: | javac | 1m 2s | the patch passed | | +1 :green_heart: | shadedjars | 5m 6s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 39s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 354m 23s | hbase-server in the patch passed. | | +1 :green_heart: | unit | 0m 50s | hbase-it in the patch passed. | | | | 377m 46s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4066/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4066 | | JIRA Issue | HBASE-26707 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux a7e13d486ed2 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8dec499181 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4066/1/testReport/ | | Max. process+thread count | 1667 (vs. ulimit of 3) | | modules | C: hbase-server hbase-it U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4066/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4066: HBASE-26707: Reduce number of renames during bulkload
Apache-HBase commented on pull request #4066: URL: https://github.com/apache/hbase/pull/4066#issuecomment-1043265828 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 57s | master passed | | +1 :green_heart: | compile | 0m 57s | master passed | | +1 :green_heart: | shadedjars | 4m 57s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 34s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 42s | the patch passed | | +1 :green_heart: | compile | 0m 57s | the patch passed | | +1 :green_heart: | javac | 0m 57s | the patch passed | | +1 :green_heart: | shadedjars | 4m 56s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 32s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 309m 39s | hbase-server in the patch passed. | | +1 :green_heart: | unit | 0m 48s | hbase-it in the patch passed. | | | | 331m 8s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4066/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4066 | | JIRA Issue | HBASE-26707 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 386f4b022b74 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8dec499181 | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4066/1/testReport/ | | Max. process+thread count | 1717 (vs. ulimit of 3) | | modules | C: hbase-server hbase-it U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4066/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (HBASE-26696) Migrate our jenkins jobs from ci-hadoop to ci-hbase
[ https://issues.apache.org/jira/browse/HBASE-26696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey resolved HBASE-26696. - Resolution: Fixed this is all wrapped up now. > Migrate our jenkins jobs from ci-hadoop to ci-hbase > --- > > Key: HBASE-26696 > URL: https://issues.apache.org/jira/browse/HBASE-26696 > Project: HBase > Issue Type: Task > Components: jenkins >Reporter: Duo Zhang >Priority: Major > > We have our own jenkins controller now. > Let's do the migration. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (HBASE-26756) remove disabled hbase jobs from ci-hadoop
[ https://issues.apache.org/jira/browse/HBASE-26756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey resolved HBASE-26756. - Resolution: Fixed went ahead and cleared things out. > remove disabled hbase jobs from ci-hadoop > - > > Key: HBASE-26756 > URL: https://issues.apache.org/jira/browse/HBASE-26756 > Project: HBase > Issue Type: Sub-task >Reporter: Sean Busbey >Assignee: Sean Busbey >Priority: Major > > There are a bunch of disabled jobs on ci-hadoop from us cautiously moving to > ci-hbase. Delete them all once we're confident that things are moved over to > ci-hbase enough that we are going to handle future problems by fixing them > in-place on ci-hbase rather than rolling back to running on ci-hadoop. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Work started] (HBASE-26756) remove disabled hbase jobs from ci-hadoop
[ https://issues.apache.org/jira/browse/HBASE-26756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-26756 started by Sean Busbey. --- > remove disabled hbase jobs from ci-hadoop > - > > Key: HBASE-26756 > URL: https://issues.apache.org/jira/browse/HBASE-26756 > Project: HBase > Issue Type: Sub-task >Reporter: Sean Busbey >Assignee: Sean Busbey >Priority: Major > > There are a bunch of disabled jobs on ci-hadoop from us cautiously moving to > ci-hbase. Delete them all once we're confident that things are moved over to > ci-hbase enough that we are going to handle future problems by fixing them > in-place on ci-hbase rather than rolling back to running on ci-hadoop. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Comment Edited] (HBASE-22338) LICENSE file only contains Apache 2.0
[ https://issues.apache.org/jira/browse/HBASE-22338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17494072#comment-17494072 ] Tak-Lon (Stephen) Wu edited comment on HBASE-22338 at 2/17/22, 4:52 PM: resend a new PR https://github.com/apache/hbase-connectors/pull/93 and continue this JIRA, and hopefully we can close the PR#41 as it's not necessary when the auto generation for LICENSE and NOTICE files are working fine. was (Author: taklwu): resend a new PR https://github.com/apache/hbase-connectors/pull/93 and continue this JIRA, and hopefully we can close the PR#41 as it's not necessary when the auto generation is working fine. > LICENSE file only contains Apache 2.0 > - > > Key: HBASE-22338 > URL: https://issues.apache.org/jira/browse/HBASE-22338 > Project: HBase > Issue Type: Bug > Components: hbase-connectors >Affects Versions: connector-1.0.0 >Reporter: Peter Somogyi >Assignee: Tak-Lon (Stephen) Wu >Priority: Critical > Fix For: hbase-connectors-1.0.1 > > Attachments: NOTICE.aggregate-no-build-year, > hbase-connectors-dependency.html > > > LICENSE.md file has only Apache 2.0 licenses but we package dependencies that > use different ones. For example jcodings uses MIT. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (HBASE-22338) LICENSE file only contains Apache 2.0
[ https://issues.apache.org/jira/browse/HBASE-22338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17494072#comment-17494072 ] Tak-Lon (Stephen) Wu commented on HBASE-22338: -- resend a new PR https://github.com/apache/hbase-connectors/pull/93 and continue this JIRA, and hopefully we can close the PR#41 as it's not necessary when the auto generation is working fine. > LICENSE file only contains Apache 2.0 > - > > Key: HBASE-22338 > URL: https://issues.apache.org/jira/browse/HBASE-22338 > Project: HBase > Issue Type: Bug > Components: hbase-connectors >Affects Versions: connector-1.0.0 >Reporter: Peter Somogyi >Assignee: Tak-Lon (Stephen) Wu >Priority: Critical > Fix For: hbase-connectors-1.0.1 > > Attachments: NOTICE.aggregate-no-build-year, > hbase-connectors-dependency.html > > > LICENSE.md file has only Apache 2.0 licenses but we package dependencies that > use different ones. For example jcodings uses MIT. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [hbase] Apache-HBase commented on pull request #4115: Introduce a Snapshot Procedure
Apache-HBase commented on pull request #4115: URL: https://github.com/apache/hbase/pull/4115#issuecomment-1043140577 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 22s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 59s | master passed | | +1 :green_heart: | compile | 1m 35s | master passed | | +1 :green_heart: | shadedjars | 5m 38s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 53s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 51s | the patch passed | | +1 :green_heart: | compile | 1m 44s | the patch passed | | +1 :green_heart: | javac | 1m 44s | the patch passed | | +1 :green_heart: | shadedjars | 6m 7s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 53s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 33s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 1m 48s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 353m 12s | hbase-server in the patch passed. | | | | 381m 45s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4115/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4115 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 290212966ceb 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8dec499181 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4115/4/testReport/ | | Max. process+thread count | 1629 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4115/4/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4115: Introduce a Snapshot Procedure
Apache-HBase commented on pull request #4115: URL: https://github.com/apache/hbase/pull/4115#issuecomment-1043079208 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 45s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 55s | master passed | | +1 :green_heart: | compile | 1m 27s | master passed | | +1 :green_heart: | shadedjars | 5m 2s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 46s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 45s | the patch passed | | +1 :green_heart: | compile | 1m 31s | the patch passed | | +1 :green_heart: | javac | 1m 31s | the patch passed | | +1 :green_heart: | shadedjars | 4m 59s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 45s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 32s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 1m 46s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 315m 45s | hbase-server in the patch passed. | | | | 340m 48s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4115/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4115 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux e8da03a02f8b 5.4.0-1054-aws #57~18.04.1-Ubuntu SMP Thu Jul 15 03:21:36 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8dec499181 | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4115/4/testReport/ | | Max. process+thread count | 1612 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4115/4/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4117: HBASE-26712 Balancer encounters NPE in rare case
Apache-HBase commented on pull request #4117: URL: https://github.com/apache/hbase/pull/4117#issuecomment-1043075574 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 22s | Docker mode activated. | | -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2.4 Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 38s | branch-2.4 passed | | +1 :green_heart: | compile | 0m 38s | branch-2.4 passed | | +1 :green_heart: | shadedjars | 4m 5s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 28s | branch-2.4 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 37s | the patch passed | | +1 :green_heart: | compile | 0m 32s | the patch passed | | +1 :green_heart: | javac | 0m 32s | the patch passed | | +1 :green_heart: | shadedjars | 3m 58s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 26s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 333m 25s | hbase-server in the patch passed. | | | | 352m 2s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4117/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4117 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 27437802f9b9 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.4 / 0020da472d | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4117/2/testReport/ | | Max. process+thread count | 2000 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4117/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4106: HBASE-26545 Implement tracing of scan
Apache-HBase commented on pull request #4106: URL: https://github.com/apache/hbase/pull/4106#issuecomment-1043070218 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 12s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 27s | master passed | | +1 :green_heart: | compile | 5m 46s | master passed | | +1 :green_heart: | checkstyle | 1m 9s | master passed | | +1 :green_heart: | spotbugs | 8m 57s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 25s | the patch passed | | +1 :green_heart: | compile | 5m 47s | the patch passed | | -0 :warning: | javac | 5m 47s | root generated 1 new + 1625 unchanged - 0 fixed = 1626 total (was 1625) | | -0 :warning: | checkstyle | 1m 9s | root: The patch generated 2 new + 7 unchanged - 1 fixed = 9 total (was 8) | | +1 :green_heart: | whitespace | 0m 1s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 0s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 11m 39s | Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1. | | +1 :green_heart: | spotbugs | 9m 44s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 30s | The patch does not generate ASF License warnings. | | | | 56m 52s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4106/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4106 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml | | uname | Linux d9b385ae1481 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8dec499181 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4106/2/artifact/yetus-general-check/output/diff-compile-javac-root.txt | | checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4106/2/artifact/yetus-general-check/output/diff-checkstyle-root.txt | | Max. process+thread count | 87 (vs. ulimit of 3) | | modules | C: hbase-client hbase-server . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4106/2/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4117: HBASE-26712 Balancer encounters NPE in rare case
Apache-HBase commented on pull request #4117: URL: https://github.com/apache/hbase/pull/4117#issuecomment-1043061973 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 3s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2.4 Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 26s | branch-2.4 passed | | +1 :green_heart: | compile | 0m 41s | branch-2.4 passed | | +1 :green_heart: | shadedjars | 3m 50s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 25s | branch-2.4 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 30s | the patch passed | | +1 :green_heart: | compile | 0m 40s | the patch passed | | +1 :green_heart: | javac | 0m 40s | the patch passed | | +1 :green_heart: | shadedjars | 4m 5s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 34s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 321m 35s | hbase-server in the patch passed. | | | | 339m 14s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4117/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4117 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 90e40cbfdcfc 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.4 / 0020da472d | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4117/2/testReport/ | | Max. process+thread count | 1986 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4117/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4106: HBASE-26545 Implement tracing of scan
Apache-HBase commented on pull request #4106: URL: https://github.com/apache/hbase/pull/4106#issuecomment-1043048767 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 15s | master passed | | +1 :green_heart: | compile | 2m 11s | master passed | | +1 :green_heart: | shadedjars | 5m 18s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 3s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 10s | the patch passed | | +1 :green_heart: | compile | 2m 25s | the patch passed | | +1 :green_heart: | javac | 2m 25s | the patch passed | | +1 :green_heart: | shadedjars | 5m 11s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 7s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 7m 9s | root in the patch failed. | | | | 37m 4s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4106/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4106 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 7ea0e4d24d11 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8dec499181 | | Default Java | AdoptOpenJDK-11.0.10+9 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4106/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4106/2/testReport/ | | Max. process+thread count | 387 (vs. ulimit of 3) | | modules | C: hbase-client hbase-server . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4106/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4106: HBASE-26545 Implement tracing of scan
Apache-HBase commented on pull request #4106: URL: https://github.com/apache/hbase/pull/4106#issuecomment-1043044252 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 37s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 32s | master passed | | +1 :green_heart: | compile | 1m 37s | master passed | | +1 :green_heart: | shadedjars | 5m 7s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 57s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 24s | the patch passed | | +1 :green_heart: | compile | 1m 37s | the patch passed | | +1 :green_heart: | javac | 1m 37s | the patch passed | | +1 :green_heart: | shadedjars | 5m 11s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 58s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 6m 2s | root in the patch failed. | | | | 31m 28s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4106/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4106 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux c2921780a452 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8dec499181 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4106/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4106/2/testReport/ | | Max. process+thread count | 335 (vs. ulimit of 3) | | modules | C: hbase-client hbase-server . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4106/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bbeaudreault commented on pull request #3944: HBASE-26576
bbeaudreault commented on pull request #3944: URL: https://github.com/apache/hbase/pull/3944#issuecomment-1043036708 @apurtell I see you doing some admin work the last couple days. I appreciate the looks on my PRs. If you have time any chance you can take a look at this one from my colleague as well? It's a small and simple one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ndimiduk commented on a change in pull request #4106: HBASE-26545 Implement tracing of scan
ndimiduk commented on a change in pull request #4106:
URL: https://github.com/apache/hbase/pull/4106#discussion_r809115423
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncTableImpl.java
##
@@ -44,12 +45,11 @@
@InterfaceAudience.Private
class AsyncTableImpl implements AsyncTable {
- private final AsyncTable rawTable;
+ private final RawAsyncTableImpl rawTable;
Review comment:
I think that changing this member variable to the concrete type makes
following the relationship between these two classes more clear -- should I
break this cleanup out into a separate PR?
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncClientScanner.java
##
@@ -140,26 +152,35 @@ public OpenScannerResponse(HRegionLocation loc, boolean
isRegionServerRemote, In
private CompletableFuture
callOpenScanner(HBaseRpcController controller,
HRegionLocation loc, ClientService.Interface stub) {
-boolean isRegionServerRemote = isRemote(loc.getHostname());
-incRPCCallsMetrics(scanMetrics, isRegionServerRemote);
-if (openScannerTries.getAndIncrement() > 1) {
- incRPCRetriesMetrics(scanMetrics, isRegionServerRemote);
-}
-CompletableFuture future = new CompletableFuture<>();
-try {
- ScanRequest request =
RequestConverter.buildScanRequest(loc.getRegion().getRegionName(), scan,
-scan.getCaching(), false);
- stub.scan(controller, request, resp -> {
-if (controller.failed()) {
- future.completeExceptionally(controller.getFailed());
- return;
-}
-future.complete(new OpenScannerResponse(loc, isRegionServerRemote,
stub, controller, resp));
- });
-} catch (IOException e) {
- future.completeExceptionally(e);
+final Span localSpan = span;
+try (Scope ignored = localSpan.makeCurrent()) {
+ boolean isRegionServerRemote = isRemote(loc.getHostname());
+ incRPCCallsMetrics(scanMetrics, isRegionServerRemote);
+ if (openScannerTries.getAndIncrement() > 1) {
+incRPCRetriesMetrics(scanMetrics, isRegionServerRemote);
+ }
+ CompletableFuture future = new
CompletableFuture<>();
+ try {
+ScanRequest request = RequestConverter.buildScanRequest(
+ loc.getRegion().getRegionName(), scan, scan.getCaching(), false);
+stub.scan(controller, request, resp -> {
+ try (Scope ignored1 = localSpan.makeCurrent()) {
+if (controller.failed()) {
+ final IOException e = controller.getFailed();
+ future.completeExceptionally(e);
+ TraceUtil.setError(localSpan, e);
+ localSpan.end();
+ return;
+}
+future.complete(new OpenScannerResponse(
+ loc, isRegionServerRemote, stub, controller, resp));
+ }
+});
+ } catch (IOException e) {
+future.completeExceptionally(e);
Review comment:
Do we need to `setError` and `span.end()` here as well?
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncConnectionImpl.java
##
@@ -362,7 +362,7 @@ ClientBackoffPolicy getBackoffPolicy() {
public AsyncTable build() {
RawAsyncTableImpl rawTable =
new RawAsyncTableImpl(AsyncConnectionImpl.this, RETRY_TIMER, this);
-return new AsyncTableImpl(AsyncConnectionImpl.this, rawTable, pool);
+return new AsyncTableImpl(rawTable, pool);
Review comment:
the `conn` instance is never used in `AsyncTableImpl` constructor --
should I break this cleanup out into a separate PR?
##
File path:
hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncTableTracing.java
##
@@ -452,6 +459,53 @@ public void testScanAll() {
assertTrace("SCAN");
}
+ @Test
+ public void testScan() throws Throwable {
Review comment:
These two test methods are awfully inadequate. Let me replace this with
test classes that more closely resemble the children of
`AbstractTestAsyncTableScan`.
##
File path:
hbase-client/src/test/java/org/apache/hadoop/hbase/client/trace/StringTraceRenderer.java
##
@@ -0,0 +1,139 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific
[GitHub] [hbase] ndimiduk commented on pull request #4106: HBASE-26545 Implement tracing of scan
ndimiduk commented on pull request #4106: URL: https://github.com/apache/hbase/pull/4106#issuecomment-1043008065 I've pushed an update. Rebased onto master. Reworked how the span is threaded through `AsyncClientScanner` based on @Apache9 's comments. Likewise, thread the `span` through the `AsyncTableResultScanner` for the same purpose. I also enabled span lifetime auditing for unit tests. Marked the PR as a draft because I think there's more work to do -- at the very least, I plan to introduce test coverage via new, dedicated test class(es) instead of piggy-backing on the existing scan tests. Duo -- I look forward to your further thoughts/observations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4066: HBASE-26707: Reduce number of renames during bulkload
Apache-HBase commented on pull request #4066: URL: https://github.com/apache/hbase/pull/4066#issuecomment-1042944215 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 58s | master passed | | +1 :green_heart: | compile | 2m 39s | master passed | | +1 :green_heart: | checkstyle | 0m 52s | master passed | | +1 :green_heart: | spotbugs | 1m 49s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 47s | the patch passed | | +1 :green_heart: | compile | 2m 49s | the patch passed | | +1 :green_heart: | javac | 2m 49s | the patch passed | | -0 :warning: | checkstyle | 0m 48s | hbase-server: The patch generated 24 new + 180 unchanged - 0 fixed = 204 total (was 180) | | -0 :warning: | checkstyle | 0m 13s | hbase-it: The patch generated 62 new + 0 unchanged - 0 fixed = 62 total (was 0) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 12m 54s | Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1. | | +1 :green_heart: | spotbugs | 2m 22s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 16s | The patch does not generate ASF License warnings. | | | | 37m 2s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4066/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4066 | | JIRA Issue | HBASE-26707 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux db24d3d70c45 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8dec499181 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4066/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4066/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-it.txt | | Max. process+thread count | 60 (vs. ulimit of 3) | | modules | C: hbase-server hbase-it U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4066/1/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4038: HBASE-26552 Introduce retry to logroller to avoid abort
Apache-HBase commented on pull request #4038: URL: https://github.com/apache/hbase/pull/4038#issuecomment-1042901042 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m 14s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 6s | master passed | | +1 :green_heart: | compile | 0m 46s | master passed | | +1 :green_heart: | shadedjars | 4m 51s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 29s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 51s | the patch passed | | +1 :green_heart: | compile | 0m 45s | the patch passed | | +1 :green_heart: | javac | 0m 45s | the patch passed | | +1 :green_heart: | shadedjars | 4m 45s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 27s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 354m 31s | hbase-server in the patch failed. | | | | 380m 4s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4038/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4038 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 0907739e4d1b 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8dec499181 | | Default Java | AdoptOpenJDK-11.0.10+9 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4038/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4038/1/testReport/ | | Max. process+thread count | 1815 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4038/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4038: HBASE-26552 Introduce retry to logroller to avoid abort
Apache-HBase commented on pull request #4038: URL: https://github.com/apache/hbase/pull/4038#issuecomment-1042894151 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m 0s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 38s | master passed | | +1 :green_heart: | compile | 0m 38s | master passed | | +1 :green_heart: | shadedjars | 4m 39s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 25s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 24s | the patch passed | | +1 :green_heart: | compile | 0m 38s | the patch passed | | +1 :green_heart: | javac | 0m 38s | the patch passed | | +1 :green_heart: | shadedjars | 4m 39s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 24s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 347m 40s | hbase-server in the patch passed. | | | | 371m 35s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4038/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4038 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 9015201a7d17 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8dec499181 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4038/1/testReport/ | | Max. process+thread count | 1670 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4038/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3117: HBASE-25709 Close region may stuck when region is compacting and skip…
Apache-HBase commented on pull request #3117: URL: https://github.com/apache/hbase/pull/3117#issuecomment-1042814943 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 22s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 35s | master passed | | +1 :green_heart: | compile | 0m 38s | master passed | | +1 :green_heart: | shadedjars | 4m 44s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 25s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 22s | the patch passed | | +1 :green_heart: | compile | 0m 38s | the patch passed | | +1 :green_heart: | javac | 0m 38s | the patch passed | | +1 :green_heart: | shadedjars | 4m 37s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 24s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 333m 44s | hbase-server in the patch passed. | | | | 351m 40s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-3117/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3117 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 0696c3eb827d 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8dec499181 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-3117/2/testReport/ | | Max. process+thread count | 1679 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-3117/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4115: Introduce a Snapshot Procedure
Apache-HBase commented on pull request #4115: URL: https://github.com/apache/hbase/pull/4115#issuecomment-1042813088 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 6s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +0 :ok: | prototool | 0m 0s | prototool was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 4s | master passed | | +1 :green_heart: | compile | 4m 25s | master passed | | +1 :green_heart: | checkstyle | 1m 12s | master passed | | +1 :green_heart: | spotbugs | 6m 16s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 1s | the patch passed | | +1 :green_heart: | compile | 4m 7s | the patch passed | | +1 :green_heart: | cc | 4m 7s | the patch passed | | +1 :green_heart: | javac | 4m 7s | the patch passed | | -0 :warning: | checkstyle | 0m 40s | hbase-server: The patch generated 1 new + 105 unchanged - 3 fixed = 106 total (was 108) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 12m 55s | Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1. | | +1 :green_heart: | hbaseprotoc | 1m 24s | the patch passed | | +1 :green_heart: | spotbugs | 5m 50s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 24s | The patch does not generate ASF License warnings. | | | | 51m 10s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4115/4/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4115 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool | | uname | Linux 606f16d522a0 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8dec499181 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4115/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 60 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4115/4/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3117: HBASE-25709 Close region may stuck when region is compacting and skip…
Apache-HBase commented on pull request #3117: URL: https://github.com/apache/hbase/pull/3117#issuecomment-1042795658 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 37s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 2s | master passed | | +1 :green_heart: | compile | 0m 39s | master passed | | +1 :green_heart: | shadedjars | 4m 53s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 23s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 39s | the patch passed | | +1 :green_heart: | compile | 0m 41s | the patch passed | | +1 :green_heart: | javac | 0m 41s | the patch passed | | +1 :green_heart: | shadedjars | 4m 52s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 21s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 308m 50s | hbase-server in the patch passed. | | | | 329m 54s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-3117/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3117 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux b24a2dbdd40a 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8dec499181 | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-3117/2/testReport/ | | Max. process+thread count | 1586 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-3117/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4117: HBASE-26712 Balancer encounters NPE in rare case
Apache-HBase commented on pull request #4117: URL: https://github.com/apache/hbase/pull/4117#issuecomment-1042777827 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 22s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2.4 Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 25s | branch-2.4 passed | | +1 :green_heart: | compile | 1m 49s | branch-2.4 passed | | +1 :green_heart: | checkstyle | 0m 40s | branch-2.4 passed | | +1 :green_heart: | spotbugs | 1m 18s | branch-2.4 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 7s | the patch passed | | +1 :green_heart: | compile | 1m 50s | the patch passed | | +1 :green_heart: | javac | 1m 50s | the patch passed | | +1 :green_heart: | checkstyle | 0m 39s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 9m 58s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 1m 20s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 10s | The patch does not generate ASF License warnings. | | | | 27m 15s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4117/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4117 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux 2b9bf5df265f 5.4.0-96-generic #109-Ubuntu SMP Wed Jan 12 16:49:16 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.4 / 0020da472d | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Max. process+thread count | 60 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4117/2/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-26747) Use python2 instead of python in our python scripts
[
https://issues.apache.org/jira/browse/HBASE-26747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493816#comment-17493816
]
Hudson commented on HBASE-26747:
Results for branch HBASE-26747
[build #7 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-26747/7/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-26747/7/General_20Nightly_20Build_20Report/]
> Use python2 instead of python in our python scripts
> ---
>
> Key: HBASE-26747
> URL: https://issues.apache.org/jira/browse/HBASE-26747
> Project: HBase
> Issue Type: Sub-task
> Components: jenkins
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.5.0, 1.7.2, 3.0.0-alpha-3, 2.4.10
>
>
> According to the suggestion from INFRA team, let's specify python2 directly.
> Later we could see if we can migrate to python3.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [hbase] Apache-HBase commented on pull request #4117: HBASE-26712 Balancer encounters NPE in rare case
Apache-HBase commented on pull request #4117: URL: https://github.com/apache/hbase/pull/4117#issuecomment-1042745553 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 2s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2.4 Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 50s | branch-2.4 passed | | +1 :green_heart: | compile | 0m 41s | branch-2.4 passed | | +1 :green_heart: | shadedjars | 3m 55s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 26s | branch-2.4 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 34s | the patch passed | | +1 :green_heart: | compile | 0m 43s | the patch passed | | +1 :green_heart: | javac | 0m 43s | the patch passed | | +1 :green_heart: | shadedjars | 3m 51s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 25s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 319m 30s | hbase-server in the patch passed. | | | | 337m 7s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4117/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4117 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux dd48b30eee3b 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.4 / 0020da472d | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4117/1/testReport/ | | Max. process+thread count | 1914 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4117/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4117: HBASE-26712 Balancer encounters NPE in rare case
Apache-HBase commented on pull request #4117: URL: https://github.com/apache/hbase/pull/4117#issuecomment-104275 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 52s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2.4 Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 32s | branch-2.4 passed | | +1 :green_heart: | compile | 0m 31s | branch-2.4 passed | | +1 :green_heart: | shadedjars | 3m 34s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 23s | branch-2.4 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 5s | the patch passed | | +1 :green_heart: | compile | 0m 30s | the patch passed | | +1 :green_heart: | javac | 0m 30s | the patch passed | | +1 :green_heart: | shadedjars | 3m 32s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 20s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 319m 19s | hbase-server in the patch passed. | | | | 335m 48s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4117/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4117 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 84b6abae619b 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.4 / 0020da472d | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4117/1/testReport/ | | Max. process+thread count | 2299 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4117/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
