taklwu commented on a change in pull request #93:
URL: https://github.com/apache/hbase-connectors/pull/93#discussion_r808616239
##########
File path: pom.xml
##########
@@ -128,6 +128,15 @@
<buildDate>${maven.build.timestamp}</buildDate>
<compileSource>1.8</compileSource>
<java.min.version>${compileSource}</java.min.version>
+ <!-- override on command line to have generated LICENSE files include
+ diagnostic info for verifying notice requirements -->
+ <build.year>2022</build.year>
Review comment:
I can't the reason -.- although I tried to use `-Dbuild.year=2022` and
it worked.... I will revert the change for this build.year first. let me know
if you find any thing. my goal is to have the dependency included in the
`NOTICE` file correctly.
In addition, I'm wondered if we need to add a generated NOTICE for modules
of `spark` e.g. `hbase-spark`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
