[jira] [Commented] (HBASE-25922) Disabled sanity checks ignored on snapshot restore

2022-08-26 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17585673#comment-17585673
 ] 

Hudson commented on HBASE-25922:


Results for branch branch-2
[build #628 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/628/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/628/General_20Nightly_20Build_20Report/]


(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/628/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/628/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/628/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Disabled sanity checks ignored on snapshot restore
> --
>
> Key: HBASE-25922
> URL: https://issues.apache.org/jira/browse/HBASE-25922
> Project: HBase
>  Issue Type: Bug
>  Components: conf, snapshots
>Affects Versions: 2.2.6, 2.4.2
> Environment: This has been tested in
>  * Google Dataproc running HBase 2.2.6
>  * Local HBase 2.4.2
>Reporter: Julian Nodorp
>Assignee: Ujjawal Kumar
>Priority: Minor
> Fix For: 2.5.1, 3.0.0-alpha-4
>
>
> Disabling sanity checks on a table is ignored when restoring snapshots. If 
> this is expected behavior at least the error message is misleading.
> h3. Steps *to Reproduce*
>  # Create a new table
> {{create 't', 'cf'}}
>  # Add a coprocessor to the newly created table
> {{alter 't', METHOD => 'table_att', 'coprocessor' => 
> 'coprocessor.jar|com.example.MyCoprocessor|0'}}
>  # Create a snapshot
> {{snapshot 't', 'snapshot-t'}}
>  # Disable the table to prevent region servers from crashing in the next step
> {{disable 't'}}
>  # Delete the coprocessor JAR and restart HBase.
>  # Attempt to restore the snapshot leads to failing sanity check as expected
> {{restore_snapshot 'snapshot-t'}}
> {{ERROR: org.apache.hadoop.hbase.DoNotRetryIOException: coprocessor.jar Set 
> hbase.table.sanity.checks to false at conf or table descriptor if you want to 
> bypass sanity checks [...]}}
>  # Disable sanity checks (as described in the error message) and retry
> {{alter 't', CONFIGURATION => \{'hbase.table.sanity.checks' => 'false'}}}
> {{restore_snapshot 'snapshot-t'}}
> h3. Expected Behavior
> The snapshot is restored.
> h3. Actual Behavior
> The same error message as in step 6. is shown.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (HBASE-27338) brotli compression lib tests fail on arm64

2022-08-26 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-27338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell reassigned HBASE-27338:
---

Assignee: Michael Stack

> brotli compression lib tests fail on arm64
> --
>
> Key: HBASE-27338
> URL: https://issues.apache.org/jira/browse/HBASE-27338
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 2.5.0
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Minor
>
> The brotli tests fail on M1 macs
>  
> {{[INFO] Running org.apache.hadoop.hbase.io.compress.brotli.TestBrotliCodec}}
> {{[INFO] Running 
> org.apache.hadoop.hbase.io.compress.brotli.TestHFileCompressionBrotli}}
> {{[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 
> 0.33 s <<< FAILURE! - in 
> org.apache.hadoop.hbase.io.compress.brotli.TestHFileCompressionBrotli}}
> {{[ERROR] 
> org.apache.hadoop.hbase.io.compress.brotli.TestHFileCompressionBrotli.test  
> Time elapsed: 0.225 s  <<< ERROR!}}
> {{java.lang.UnsatisfiedLinkError: Failed to load Brotli native library}}
> {{...}}
>  
> The lib is installed on this machine. A new release of 
> *[Brotli4j|https://github.com/hyperxpro/Brotli4j]* lib, 1.8.0, done a few 
> days ago fixes the issue... (See 
> [https://github.com/hyperxpro/Brotli4j/pull/34).] I tried it .
> {{[INFO] ---}}
> {{[INFO]  T E S T S}}
> {{[INFO] ---}}
> {{[INFO] Running org.apache.hadoop.hbase.io.compress.brotli.TestBrotliCodec}}
> {{[INFO] Running 
> org.apache.hadoop.hbase.io.compress.brotli.TestHFileCompressionBrotli}}
> {{[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
> 1.036 s - in 
> org.apache.hadoop.hbase.io.compress.brotli.TestHFileCompressionBrotli}}
> {{[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 8.42 
> s - in org.apache.hadoop.hbase.io.compress.brotli.TestBrotliCodec}}
> {{[INFO]}}
> {{[INFO] Results:}}
> {{[INFO]}}
> {{[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0}}
> {{[INFO]}}
> {{[INFO]}}
> {{[INFO] --- maven-surefire-plugin:3.0.0-M6:test (secondPartTestsExecution) @ 
> hbase-compression-brotli ---}}
> {{[INFO] Tests are skipped.}}
> {{[INFO]}}
> {{[INFO] --- maven-jar-plugin:3.2.0:test-jar (default) @ 
> hbase-compression-brotli ---}}
> {{[INFO] Building jar: 
> /Users/stack/checkouts/hbase/2.5.0RC1/hbase-2.5.0/hbase-compression/hbase-compression-brotli/target/hbase-compression-brotli-2.5.0-tests.jar}}
> {{[INFO]}}
> {{[INFO] --- maven-jar-plugin:3.2.0:jar (default-jar) @ 
> hbase-compression-brotli ---}}
> {{[INFO] Building jar: 
> /Users/stack/checkouts/hbase/2.5.0RC1/hbase-2.5.0/hbase-compression/hbase-compression-brotli/target/hbase-compression-brotli-2.5.0.jar}}
> {{[INFO]}}
> {{[INFO] --- maven-site-plugin:3.12.0:attach-descriptor (attach-descriptor) @ 
> hbase-compression-brotli ---}}
> {{[INFO] Skipping because packaging 'jar' is not pom.}}
> {{[INFO]}}
> {{[INFO] --- maven-install-plugin:2.5.2:install (default-install) @ 
> hbase-compression-brotli ---}}
> {{[INFO] Installing 
> /Users/stack/checkouts/hbase/2.5.0RC1/hbase-2.5.0/hbase-compression/hbase-compression-brotli/target/hbase-compression-brotli-2.5.0.jar
>  to 
> /Users/stack/.m2/repository/org/apache/hbase/hbase-compression-brotli/2.5.0/hbase-compression-brotli-2.5.0.jar}}
> {{[INFO] Installing 
> /Users/stack/checkouts/hbase/2.5.0RC1/hbase-2.5.0/hbase-compression/hbase-compression-brotli/pom.xml
>  to 
> /Users/stack/.m2/repository/org/apache/hbase/hbase-compression-brotli/2.5.0/hbase-compression-brotli-2.5.0.pom}}
> {{[INFO] Installing 
> /Users/stack/checkouts/hbase/2.5.0RC1/hbase-2.5.0/hbase-compression/hbase-compression-brotli/target/hbase-compression-brotli-2.5.0-tests.jar
>  to 
> /Users/stack/.m2/repository/org/apache/hbase/hbase-compression-brotli/2.5.0/hbase-compression-brotli-2.5.0-tests.jar}}
> {{[INFO] 
> }}
> {{[INFO] BUILD SUCCESS}}
> {{[INFO] 
> }}
> {{[INFO] Total time:  16.805 s}}
> {{[INFO] Finished at: 2022-08-26T11:30:13-07:00}}
> {{[INFO] 
> }}
>  
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (HBASE-27338) brotli compression lib tests fail on arm64

2022-08-26 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-27338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell updated HBASE-27338:

Status: Patch Available  (was: Open)

> brotli compression lib tests fail on arm64
> --
>
> Key: HBASE-27338
> URL: https://issues.apache.org/jira/browse/HBASE-27338
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 2.5.0
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Minor
> Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4
>
>
> The brotli tests fail on M1 macs
>  
> {{[INFO] Running org.apache.hadoop.hbase.io.compress.brotli.TestBrotliCodec}}
> {{[INFO] Running 
> org.apache.hadoop.hbase.io.compress.brotli.TestHFileCompressionBrotli}}
> {{[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 
> 0.33 s <<< FAILURE! - in 
> org.apache.hadoop.hbase.io.compress.brotli.TestHFileCompressionBrotli}}
> {{[ERROR] 
> org.apache.hadoop.hbase.io.compress.brotli.TestHFileCompressionBrotli.test  
> Time elapsed: 0.225 s  <<< ERROR!}}
> {{java.lang.UnsatisfiedLinkError: Failed to load Brotli native library}}
> {{...}}
>  
> The lib is installed on this machine. A new release of 
> *[Brotli4j|https://github.com/hyperxpro/Brotli4j]* lib, 1.8.0, done a few 
> days ago fixes the issue... (See 
> [https://github.com/hyperxpro/Brotli4j/pull/34).] I tried it .
> {{[INFO] ---}}
> {{[INFO]  T E S T S}}
> {{[INFO] ---}}
> {{[INFO] Running org.apache.hadoop.hbase.io.compress.brotli.TestBrotliCodec}}
> {{[INFO] Running 
> org.apache.hadoop.hbase.io.compress.brotli.TestHFileCompressionBrotli}}
> {{[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
> 1.036 s - in 
> org.apache.hadoop.hbase.io.compress.brotli.TestHFileCompressionBrotli}}
> {{[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 8.42 
> s - in org.apache.hadoop.hbase.io.compress.brotli.TestBrotliCodec}}
> {{[INFO]}}
> {{[INFO] Results:}}
> {{[INFO]}}
> {{[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0}}
> {{[INFO]}}
> {{[INFO]}}
> {{[INFO] --- maven-surefire-plugin:3.0.0-M6:test (secondPartTestsExecution) @ 
> hbase-compression-brotli ---}}
> {{[INFO] Tests are skipped.}}
> {{[INFO]}}
> {{[INFO] --- maven-jar-plugin:3.2.0:test-jar (default) @ 
> hbase-compression-brotli ---}}
> {{[INFO] Building jar: 
> /Users/stack/checkouts/hbase/2.5.0RC1/hbase-2.5.0/hbase-compression/hbase-compression-brotli/target/hbase-compression-brotli-2.5.0-tests.jar}}
> {{[INFO]}}
> {{[INFO] --- maven-jar-plugin:3.2.0:jar (default-jar) @ 
> hbase-compression-brotli ---}}
> {{[INFO] Building jar: 
> /Users/stack/checkouts/hbase/2.5.0RC1/hbase-2.5.0/hbase-compression/hbase-compression-brotli/target/hbase-compression-brotli-2.5.0.jar}}
> {{[INFO]}}
> {{[INFO] --- maven-site-plugin:3.12.0:attach-descriptor (attach-descriptor) @ 
> hbase-compression-brotli ---}}
> {{[INFO] Skipping because packaging 'jar' is not pom.}}
> {{[INFO]}}
> {{[INFO] --- maven-install-plugin:2.5.2:install (default-install) @ 
> hbase-compression-brotli ---}}
> {{[INFO] Installing 
> /Users/stack/checkouts/hbase/2.5.0RC1/hbase-2.5.0/hbase-compression/hbase-compression-brotli/target/hbase-compression-brotli-2.5.0.jar
>  to 
> /Users/stack/.m2/repository/org/apache/hbase/hbase-compression-brotli/2.5.0/hbase-compression-brotli-2.5.0.jar}}
> {{[INFO] Installing 
> /Users/stack/checkouts/hbase/2.5.0RC1/hbase-2.5.0/hbase-compression/hbase-compression-brotli/pom.xml
>  to 
> /Users/stack/.m2/repository/org/apache/hbase/hbase-compression-brotli/2.5.0/hbase-compression-brotli-2.5.0.pom}}
> {{[INFO] Installing 
> /Users/stack/checkouts/hbase/2.5.0RC1/hbase-2.5.0/hbase-compression/hbase-compression-brotli/target/hbase-compression-brotli-2.5.0-tests.jar
>  to 
> /Users/stack/.m2/repository/org/apache/hbase/hbase-compression-brotli/2.5.0/hbase-compression-brotli-2.5.0-tests.jar}}
> {{[INFO] 
> }}
> {{[INFO] BUILD SUCCESS}}
> {{[INFO] 
> }}
> {{[INFO] Total time:  16.805 s}}
> {{[INFO] Finished at: 2022-08-26T11:30:13-07:00}}
> {{[INFO] 
> }}
>  
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (HBASE-27338) brotli compression lib tests fail on arm64

2022-08-26 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-27338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell updated HBASE-27338:

Fix Version/s: 2.6.0
   2.5.1
   3.0.0-alpha-4

> brotli compression lib tests fail on arm64
> --
>
> Key: HBASE-27338
> URL: https://issues.apache.org/jira/browse/HBASE-27338
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 2.5.0
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Minor
> Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4
>
>
> The brotli tests fail on M1 macs
>  
> {{[INFO] Running org.apache.hadoop.hbase.io.compress.brotli.TestBrotliCodec}}
> {{[INFO] Running 
> org.apache.hadoop.hbase.io.compress.brotli.TestHFileCompressionBrotli}}
> {{[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 
> 0.33 s <<< FAILURE! - in 
> org.apache.hadoop.hbase.io.compress.brotli.TestHFileCompressionBrotli}}
> {{[ERROR] 
> org.apache.hadoop.hbase.io.compress.brotli.TestHFileCompressionBrotli.test  
> Time elapsed: 0.225 s  <<< ERROR!}}
> {{java.lang.UnsatisfiedLinkError: Failed to load Brotli native library}}
> {{...}}
>  
> The lib is installed on this machine. A new release of 
> *[Brotli4j|https://github.com/hyperxpro/Brotli4j]* lib, 1.8.0, done a few 
> days ago fixes the issue... (See 
> [https://github.com/hyperxpro/Brotli4j/pull/34).] I tried it .
> {{[INFO] ---}}
> {{[INFO]  T E S T S}}
> {{[INFO] ---}}
> {{[INFO] Running org.apache.hadoop.hbase.io.compress.brotli.TestBrotliCodec}}
> {{[INFO] Running 
> org.apache.hadoop.hbase.io.compress.brotli.TestHFileCompressionBrotli}}
> {{[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
> 1.036 s - in 
> org.apache.hadoop.hbase.io.compress.brotli.TestHFileCompressionBrotli}}
> {{[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 8.42 
> s - in org.apache.hadoop.hbase.io.compress.brotli.TestBrotliCodec}}
> {{[INFO]}}
> {{[INFO] Results:}}
> {{[INFO]}}
> {{[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0}}
> {{[INFO]}}
> {{[INFO]}}
> {{[INFO] --- maven-surefire-plugin:3.0.0-M6:test (secondPartTestsExecution) @ 
> hbase-compression-brotli ---}}
> {{[INFO] Tests are skipped.}}
> {{[INFO]}}
> {{[INFO] --- maven-jar-plugin:3.2.0:test-jar (default) @ 
> hbase-compression-brotli ---}}
> {{[INFO] Building jar: 
> /Users/stack/checkouts/hbase/2.5.0RC1/hbase-2.5.0/hbase-compression/hbase-compression-brotli/target/hbase-compression-brotli-2.5.0-tests.jar}}
> {{[INFO]}}
> {{[INFO] --- maven-jar-plugin:3.2.0:jar (default-jar) @ 
> hbase-compression-brotli ---}}
> {{[INFO] Building jar: 
> /Users/stack/checkouts/hbase/2.5.0RC1/hbase-2.5.0/hbase-compression/hbase-compression-brotli/target/hbase-compression-brotli-2.5.0.jar}}
> {{[INFO]}}
> {{[INFO] --- maven-site-plugin:3.12.0:attach-descriptor (attach-descriptor) @ 
> hbase-compression-brotli ---}}
> {{[INFO] Skipping because packaging 'jar' is not pom.}}
> {{[INFO]}}
> {{[INFO] --- maven-install-plugin:2.5.2:install (default-install) @ 
> hbase-compression-brotli ---}}
> {{[INFO] Installing 
> /Users/stack/checkouts/hbase/2.5.0RC1/hbase-2.5.0/hbase-compression/hbase-compression-brotli/target/hbase-compression-brotli-2.5.0.jar
>  to 
> /Users/stack/.m2/repository/org/apache/hbase/hbase-compression-brotli/2.5.0/hbase-compression-brotli-2.5.0.jar}}
> {{[INFO] Installing 
> /Users/stack/checkouts/hbase/2.5.0RC1/hbase-2.5.0/hbase-compression/hbase-compression-brotli/pom.xml
>  to 
> /Users/stack/.m2/repository/org/apache/hbase/hbase-compression-brotli/2.5.0/hbase-compression-brotli-2.5.0.pom}}
> {{[INFO] Installing 
> /Users/stack/checkouts/hbase/2.5.0RC1/hbase-2.5.0/hbase-compression/hbase-compression-brotli/target/hbase-compression-brotli-2.5.0-tests.jar
>  to 
> /Users/stack/.m2/repository/org/apache/hbase/hbase-compression-brotli/2.5.0/hbase-compression-brotli-2.5.0-tests.jar}}
> {{[INFO] 
> }}
> {{[INFO] BUILD SUCCESS}}
> {{[INFO] 
> }}
> {{[INFO] Total time:  16.805 s}}
> {{[INFO] Finished at: 2022-08-26T11:30:13-07:00}}
> {{[INFO] 
> }}
>  
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (HBASE-27338) brotli compression lib tests fail on arm64

2022-08-26 Thread Andrew Kyle Purtell (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17585647#comment-17585647
 ] 

Andrew Kyle Purtell edited comment on HBASE-27338 at 8/27/22 3:03 AM:
--

This one is a bit surprising because I developed it on arm64/m1. Seems the 
difference was it was a Linux VM. Guess OSX dylib support was missing in the 
1.7.1 release. Glad the update to 1.8.0 resolved it. 


was (Author: apurtell):
This one is odd because I developed it on arm64/m1. Difference was it was a 
Linux VM. Guess OSX dylib support was missing in the 1.7.1 release. Glad the 
update to 1.8.0 resolved it. 

> brotli compression lib tests fail on arm64
> --
>
> Key: HBASE-27338
> URL: https://issues.apache.org/jira/browse/HBASE-27338
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 2.5.0
>Reporter: Michael Stack
>Priority: Minor
>
> The brotli tests fail on M1 macs
>  
> {{[INFO] Running org.apache.hadoop.hbase.io.compress.brotli.TestBrotliCodec}}
> {{[INFO] Running 
> org.apache.hadoop.hbase.io.compress.brotli.TestHFileCompressionBrotli}}
> {{[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 
> 0.33 s <<< FAILURE! - in 
> org.apache.hadoop.hbase.io.compress.brotli.TestHFileCompressionBrotli}}
> {{[ERROR] 
> org.apache.hadoop.hbase.io.compress.brotli.TestHFileCompressionBrotli.test  
> Time elapsed: 0.225 s  <<< ERROR!}}
> {{java.lang.UnsatisfiedLinkError: Failed to load Brotli native library}}
> {{...}}
>  
> The lib is installed on this machine. A new release of 
> *[Brotli4j|https://github.com/hyperxpro/Brotli4j]* lib, 1.8.0, done a few 
> days ago fixes the issue... (See 
> [https://github.com/hyperxpro/Brotli4j/pull/34).] I tried it .
> {{[INFO] ---}}
> {{[INFO]  T E S T S}}
> {{[INFO] ---}}
> {{[INFO] Running org.apache.hadoop.hbase.io.compress.brotli.TestBrotliCodec}}
> {{[INFO] Running 
> org.apache.hadoop.hbase.io.compress.brotli.TestHFileCompressionBrotli}}
> {{[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
> 1.036 s - in 
> org.apache.hadoop.hbase.io.compress.brotli.TestHFileCompressionBrotli}}
> {{[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 8.42 
> s - in org.apache.hadoop.hbase.io.compress.brotli.TestBrotliCodec}}
> {{[INFO]}}
> {{[INFO] Results:}}
> {{[INFO]}}
> {{[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0}}
> {{[INFO]}}
> {{[INFO]}}
> {{[INFO] --- maven-surefire-plugin:3.0.0-M6:test (secondPartTestsExecution) @ 
> hbase-compression-brotli ---}}
> {{[INFO] Tests are skipped.}}
> {{[INFO]}}
> {{[INFO] --- maven-jar-plugin:3.2.0:test-jar (default) @ 
> hbase-compression-brotli ---}}
> {{[INFO] Building jar: 
> /Users/stack/checkouts/hbase/2.5.0RC1/hbase-2.5.0/hbase-compression/hbase-compression-brotli/target/hbase-compression-brotli-2.5.0-tests.jar}}
> {{[INFO]}}
> {{[INFO] --- maven-jar-plugin:3.2.0:jar (default-jar) @ 
> hbase-compression-brotli ---}}
> {{[INFO] Building jar: 
> /Users/stack/checkouts/hbase/2.5.0RC1/hbase-2.5.0/hbase-compression/hbase-compression-brotli/target/hbase-compression-brotli-2.5.0.jar}}
> {{[INFO]}}
> {{[INFO] --- maven-site-plugin:3.12.0:attach-descriptor (attach-descriptor) @ 
> hbase-compression-brotli ---}}
> {{[INFO] Skipping because packaging 'jar' is not pom.}}
> {{[INFO]}}
> {{[INFO] --- maven-install-plugin:2.5.2:install (default-install) @ 
> hbase-compression-brotli ---}}
> {{[INFO] Installing 
> /Users/stack/checkouts/hbase/2.5.0RC1/hbase-2.5.0/hbase-compression/hbase-compression-brotli/target/hbase-compression-brotli-2.5.0.jar
>  to 
> /Users/stack/.m2/repository/org/apache/hbase/hbase-compression-brotli/2.5.0/hbase-compression-brotli-2.5.0.jar}}
> {{[INFO] Installing 
> /Users/stack/checkouts/hbase/2.5.0RC1/hbase-2.5.0/hbase-compression/hbase-compression-brotli/pom.xml
>  to 
> /Users/stack/.m2/repository/org/apache/hbase/hbase-compression-brotli/2.5.0/hbase-compression-brotli-2.5.0.pom}}
> {{[INFO] Installing 
> /Users/stack/checkouts/hbase/2.5.0RC1/hbase-2.5.0/hbase-compression/hbase-compression-brotli/target/hbase-compression-brotli-2.5.0-tests.jar
>  to 
> /Users/stack/.m2/repository/org/apache/hbase/hbase-compression-brotli/2.5.0/hbase-compression-brotli-2.5.0-tests.jar}}
> {{[INFO] 
> }}
> {{[INFO] BUILD SUCCESS}}
> {{[INFO] 
> }}
> {{[INFO] Total time:  16.805 s}}
> {{[INFO] Finished at: 2022-08-26T11:30:13-07:00}}
> {{[INFO] 
> }}
>  
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Comment Edited] (HBASE-27338) brotli compression lib tests fail on arm64

2022-08-26 Thread Andrew Kyle Purtell (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17585647#comment-17585647
 ] 

Andrew Kyle Purtell edited comment on HBASE-27338 at 8/27/22 3:03 AM:
--

This one is odd because I developed it on arm64/m1. Difference was it was a 
Linux VM. Guess OSX dylib support was missing in the 1.7.1 release. Glad the 
update to 1.8.0 resolved it. 


was (Author: apurtell):
This one is odd because I developed it on arm64. Linux. But there could be 
additional platform differences like libc version. Glad the update to newer 
release resolved it. 

> brotli compression lib tests fail on arm64
> --
>
> Key: HBASE-27338
> URL: https://issues.apache.org/jira/browse/HBASE-27338
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 2.5.0
>Reporter: Michael Stack
>Priority: Minor
>
> The brotli tests fail on M1 macs
>  
> {{[INFO] Running org.apache.hadoop.hbase.io.compress.brotli.TestBrotliCodec}}
> {{[INFO] Running 
> org.apache.hadoop.hbase.io.compress.brotli.TestHFileCompressionBrotli}}
> {{[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 
> 0.33 s <<< FAILURE! - in 
> org.apache.hadoop.hbase.io.compress.brotli.TestHFileCompressionBrotli}}
> {{[ERROR] 
> org.apache.hadoop.hbase.io.compress.brotli.TestHFileCompressionBrotli.test  
> Time elapsed: 0.225 s  <<< ERROR!}}
> {{java.lang.UnsatisfiedLinkError: Failed to load Brotli native library}}
> {{...}}
>  
> The lib is installed on this machine. A new release of 
> *[Brotli4j|https://github.com/hyperxpro/Brotli4j]* lib, 1.8.0, done a few 
> days ago fixes the issue... (See 
> [https://github.com/hyperxpro/Brotli4j/pull/34).] I tried it .
> {{[INFO] ---}}
> {{[INFO]  T E S T S}}
> {{[INFO] ---}}
> {{[INFO] Running org.apache.hadoop.hbase.io.compress.brotli.TestBrotliCodec}}
> {{[INFO] Running 
> org.apache.hadoop.hbase.io.compress.brotli.TestHFileCompressionBrotli}}
> {{[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
> 1.036 s - in 
> org.apache.hadoop.hbase.io.compress.brotli.TestHFileCompressionBrotli}}
> {{[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 8.42 
> s - in org.apache.hadoop.hbase.io.compress.brotli.TestBrotliCodec}}
> {{[INFO]}}
> {{[INFO] Results:}}
> {{[INFO]}}
> {{[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0}}
> {{[INFO]}}
> {{[INFO]}}
> {{[INFO] --- maven-surefire-plugin:3.0.0-M6:test (secondPartTestsExecution) @ 
> hbase-compression-brotli ---}}
> {{[INFO] Tests are skipped.}}
> {{[INFO]}}
> {{[INFO] --- maven-jar-plugin:3.2.0:test-jar (default) @ 
> hbase-compression-brotli ---}}
> {{[INFO] Building jar: 
> /Users/stack/checkouts/hbase/2.5.0RC1/hbase-2.5.0/hbase-compression/hbase-compression-brotli/target/hbase-compression-brotli-2.5.0-tests.jar}}
> {{[INFO]}}
> {{[INFO] --- maven-jar-plugin:3.2.0:jar (default-jar) @ 
> hbase-compression-brotli ---}}
> {{[INFO] Building jar: 
> /Users/stack/checkouts/hbase/2.5.0RC1/hbase-2.5.0/hbase-compression/hbase-compression-brotli/target/hbase-compression-brotli-2.5.0.jar}}
> {{[INFO]}}
> {{[INFO] --- maven-site-plugin:3.12.0:attach-descriptor (attach-descriptor) @ 
> hbase-compression-brotli ---}}
> {{[INFO] Skipping because packaging 'jar' is not pom.}}
> {{[INFO]}}
> {{[INFO] --- maven-install-plugin:2.5.2:install (default-install) @ 
> hbase-compression-brotli ---}}
> {{[INFO] Installing 
> /Users/stack/checkouts/hbase/2.5.0RC1/hbase-2.5.0/hbase-compression/hbase-compression-brotli/target/hbase-compression-brotli-2.5.0.jar
>  to 
> /Users/stack/.m2/repository/org/apache/hbase/hbase-compression-brotli/2.5.0/hbase-compression-brotli-2.5.0.jar}}
> {{[INFO] Installing 
> /Users/stack/checkouts/hbase/2.5.0RC1/hbase-2.5.0/hbase-compression/hbase-compression-brotli/pom.xml
>  to 
> /Users/stack/.m2/repository/org/apache/hbase/hbase-compression-brotli/2.5.0/hbase-compression-brotli-2.5.0.pom}}
> {{[INFO] Installing 
> /Users/stack/checkouts/hbase/2.5.0RC1/hbase-2.5.0/hbase-compression/hbase-compression-brotli/target/hbase-compression-brotli-2.5.0-tests.jar
>  to 
> /Users/stack/.m2/repository/org/apache/hbase/hbase-compression-brotli/2.5.0/hbase-compression-brotli-2.5.0-tests.jar}}
> {{[INFO] 
> }}
> {{[INFO] BUILD SUCCESS}}
> {{[INFO] 
> }}
> {{[INFO] Total time:  16.805 s}}
> {{[INFO] Finished at: 2022-08-26T11:30:13-07:00}}
> {{[INFO] 
> }}
>  
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-27338) brotli compression lib tests fail on arm64

2022-08-26 Thread Andrew Kyle Purtell (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17585647#comment-17585647
 ] 

Andrew Kyle Purtell commented on HBASE-27338:
-

This one is odd because I developed it on arm64. Linux. But there could be 
additional platform differences like libc version. Glad the update to newer 
release resolved it. 

> brotli compression lib tests fail on arm64
> --
>
> Key: HBASE-27338
> URL: https://issues.apache.org/jira/browse/HBASE-27338
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 2.5.0
>Reporter: Michael Stack
>Priority: Minor
>
> The brotli tests fail on M1 macs
>  
> {{[INFO] Running org.apache.hadoop.hbase.io.compress.brotli.TestBrotliCodec}}
> {{[INFO] Running 
> org.apache.hadoop.hbase.io.compress.brotli.TestHFileCompressionBrotli}}
> {{[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 
> 0.33 s <<< FAILURE! - in 
> org.apache.hadoop.hbase.io.compress.brotli.TestHFileCompressionBrotli}}
> {{[ERROR] 
> org.apache.hadoop.hbase.io.compress.brotli.TestHFileCompressionBrotli.test  
> Time elapsed: 0.225 s  <<< ERROR!}}
> {{java.lang.UnsatisfiedLinkError: Failed to load Brotli native library}}
> {{...}}
>  
> The lib is installed on this machine. A new release of 
> *[Brotli4j|https://github.com/hyperxpro/Brotli4j]* lib, 1.8.0, done a few 
> days ago fixes the issue... (See 
> [https://github.com/hyperxpro/Brotli4j/pull/34).] I tried it .
> {{[INFO] ---}}
> {{[INFO]  T E S T S}}
> {{[INFO] ---}}
> {{[INFO] Running org.apache.hadoop.hbase.io.compress.brotli.TestBrotliCodec}}
> {{[INFO] Running 
> org.apache.hadoop.hbase.io.compress.brotli.TestHFileCompressionBrotli}}
> {{[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
> 1.036 s - in 
> org.apache.hadoop.hbase.io.compress.brotli.TestHFileCompressionBrotli}}
> {{[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 8.42 
> s - in org.apache.hadoop.hbase.io.compress.brotli.TestBrotliCodec}}
> {{[INFO]}}
> {{[INFO] Results:}}
> {{[INFO]}}
> {{[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0}}
> {{[INFO]}}
> {{[INFO]}}
> {{[INFO] --- maven-surefire-plugin:3.0.0-M6:test (secondPartTestsExecution) @ 
> hbase-compression-brotli ---}}
> {{[INFO] Tests are skipped.}}
> {{[INFO]}}
> {{[INFO] --- maven-jar-plugin:3.2.0:test-jar (default) @ 
> hbase-compression-brotli ---}}
> {{[INFO] Building jar: 
> /Users/stack/checkouts/hbase/2.5.0RC1/hbase-2.5.0/hbase-compression/hbase-compression-brotli/target/hbase-compression-brotli-2.5.0-tests.jar}}
> {{[INFO]}}
> {{[INFO] --- maven-jar-plugin:3.2.0:jar (default-jar) @ 
> hbase-compression-brotli ---}}
> {{[INFO] Building jar: 
> /Users/stack/checkouts/hbase/2.5.0RC1/hbase-2.5.0/hbase-compression/hbase-compression-brotli/target/hbase-compression-brotli-2.5.0.jar}}
> {{[INFO]}}
> {{[INFO] --- maven-site-plugin:3.12.0:attach-descriptor (attach-descriptor) @ 
> hbase-compression-brotli ---}}
> {{[INFO] Skipping because packaging 'jar' is not pom.}}
> {{[INFO]}}
> {{[INFO] --- maven-install-plugin:2.5.2:install (default-install) @ 
> hbase-compression-brotli ---}}
> {{[INFO] Installing 
> /Users/stack/checkouts/hbase/2.5.0RC1/hbase-2.5.0/hbase-compression/hbase-compression-brotli/target/hbase-compression-brotli-2.5.0.jar
>  to 
> /Users/stack/.m2/repository/org/apache/hbase/hbase-compression-brotli/2.5.0/hbase-compression-brotli-2.5.0.jar}}
> {{[INFO] Installing 
> /Users/stack/checkouts/hbase/2.5.0RC1/hbase-2.5.0/hbase-compression/hbase-compression-brotli/pom.xml
>  to 
> /Users/stack/.m2/repository/org/apache/hbase/hbase-compression-brotli/2.5.0/hbase-compression-brotli-2.5.0.pom}}
> {{[INFO] Installing 
> /Users/stack/checkouts/hbase/2.5.0RC1/hbase-2.5.0/hbase-compression/hbase-compression-brotli/target/hbase-compression-brotli-2.5.0-tests.jar
>  to 
> /Users/stack/.m2/repository/org/apache/hbase/hbase-compression-brotli/2.5.0/hbase-compression-brotli-2.5.0-tests.jar}}
> {{[INFO] 
> }}
> {{[INFO] BUILD SUCCESS}}
> {{[INFO] 
> }}
> {{[INFO] Total time:  16.805 s}}
> {{[INFO] Finished at: 2022-08-26T11:30:13-07:00}}
> {{[INFO] 
> }}
>  
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [hbase] Apache-HBase commented on pull request #4735: HBASE-27338 brotli compression lib tests fail on arm64

2022-08-26 Thread GitBox


Apache-HBase commented on PR #4735:
URL: https://github.com/apache/hbase/pull/4735#issuecomment-1229083079

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m  4s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 12s |  master passed  |
   | +1 :green_heart: |  compile  |   6m  6s |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 38s |  branch has no errors when 
running spotless:check.  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 17s |  the patch passed  |
   | +1 :green_heart: |  compile  |   6m 18s |  the patch passed  |
   | +1 :green_heart: |  javac  |   6m 18s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  xml  |   0m  0s |  The patch has no ill-formed XML 
file.  |
   | +1 :green_heart: |  hadoopcheck  |   7m 56s |  Patch does not cause any 
errors with Hadoop 3.2.4 3.3.4.  |
   | +1 :green_heart: |  spotless  |   0m 40s |  patch has no errors when 
running spotless:check.  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 12s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  32m 29s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4735/2/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4735 |
   | Optional Tests | dupname asflicense javac hadoopcheck spotless xml compile 
|
   | uname | Linux aa2824f29092 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 
02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 06728e554c |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   | Max. process+thread count | 138 (vs. ulimit of 3) |
   | modules | C: . U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4735/2/console 
|
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #4735: HBASE-27338 brotli compression lib tests fail on arm64

2022-08-26 Thread GitBox


Apache-HBase commented on PR #4735:
URL: https://github.com/apache/hbase/pull/4735#issuecomment-1229060479

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m 11s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  4s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 34s |  master passed  |
   | +1 :green_heart: |  compile  |   2m 11s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   4m 59s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   2m  0s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m  8s |  the patch passed  |
   | +1 :green_heart: |  compile  |   2m 15s |  the patch passed  |
   | +1 :green_heart: |  javac  |   2m 15s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   5m 40s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   2m  8s |  the patch passed  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  | 315m 23s |  root in the patch failed.  |
   |  |   | 344m 25s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4735/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4735 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux beb12bcc67be 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 
02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 06728e554c |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   | unit | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4735/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4735/1/testReport/
 |
   | Max. process+thread count | 2472 (vs. ulimit of 3) |
   | modules | C: . U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4735/1/console 
|
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #4735: HBASE-27338 brotli compression lib tests fail on arm64

2022-08-26 Thread GitBox


Apache-HBase commented on PR #4735:
URL: https://github.com/apache/hbase/pull/4735#issuecomment-1229016883

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 59s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  2s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 45s |  master passed  |
   | +1 :green_heart: |  compile  |   1m 44s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   3m 55s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 47s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 25s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 42s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m 42s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   3m 53s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 45s |  the patch passed  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  | 213m 32s |  root in the patch failed.  |
   |  |   | 236m 40s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4735/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4735 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 3d165fdf219e 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 
28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 06728e554c |
   | Default Java | AdoptOpenJDK-11.0.10+9 |
   | unit | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4735/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4735/1/testReport/
 |
   | Max. process+thread count | 2833 (vs. ulimit of 3) |
   | modules | C: . U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4735/1/console 
|
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #4733: HBASE-26553 OAuth Bearer authentication mech plugin for SASL

2022-08-26 Thread GitBox


Apache-HBase commented on PR #4733:
URL: https://github.com/apache/hbase/pull/4733#issuecomment-1229015131

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m 56s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 26s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m  7s |  master passed  |
   | +1 :green_heart: |  compile  |   2m  2s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   5m 38s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   3m 24s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 15s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 59s |  the patch passed  |
   | +1 :green_heart: |  compile  |   2m 12s |  the patch passed  |
   | +1 :green_heart: |  javac  |   2m 12s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   5m 38s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   3m 42s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  | 408m 38s |  root in the patch passed.  |
   |  |   | 442m 55s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4733/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4733 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 7c2a7e7144fd 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 
23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 06728e554c |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4733/1/testReport/
 |
   | Max. process+thread count | 4855 (vs. ulimit of 3) |
   | modules | C: hbase-common hbase-client hbase-resource-bundle hbase-server 
hbase-examples . U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4733/1/console 
|
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (HBASE-27336) The region visualizer shows 'undefined' region server

2022-08-26 Thread Huaxiang Sun (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-27336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Huaxiang Sun updated HBASE-27336:
-
Attachment: Screen Shot 2022-08-26 at 3.31.27 PM.png

> The region visualizer shows 'undefined' region server
> -
>
> Key: HBASE-27336
> URL: https://issues.apache.org/jira/browse/HBASE-27336
> Project: HBase
>  Issue Type: Bug
>  Components: master, UI
>Reporter: Duo Zhang
>Assignee: LiangJun He
>Priority: Major
> Attachments: Screen Shot 2022-08-26 at 3.31.27 PM.png
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (HBASE-27339) Improve sasl connection failure log message to include server

2022-08-26 Thread Viraj Jasani (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-27339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Viraj Jasani updated HBASE-27339:
-
Fix Version/s: 2.5.1
   2.4.15
   (was: 2.5.0)

> Improve sasl connection failure log message to include server
> -
>
> Key: HBASE-27339
> URL: https://issues.apache.org/jira/browse/HBASE-27339
> Project: HBase
>  Issue Type: Improvement
>  Components: Client
>Affects Versions: 1.7.2
>Reporter: Daniel Wong
>Priority: Minor
> Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4, 2.4.15
>
>
> We were seeing timeout issues in our deployment in the saslConnect path in 
> the blockingRPC client.  Knowing which server we failed to connect to would 
> help isolate and understand the issue.
>  
>  
> {code:java}
> ipc.BlockingRpcConnection - Exception encountered while connecting to the 
> server : 
> java.io.IOException: Connection reset by peer {code}
>  
>  
> Change the log message to something like
>  
> {code:java}
> ipc.BlockingRpcConnection - Exception encountered while connecting to the 
> server myhost.realm.net: 
> java.io.IOException: Connection reset by peer {code}
>  
> See relevant code 
> [here|https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/BlockingRpcConnection.java#L398]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (HBASE-27339) Improve sasl connection failure log message to include server

2022-08-26 Thread Viraj Jasani (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-27339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Viraj Jasani updated HBASE-27339:
-
Affects Version/s: (was: 2.4.13)

> Improve sasl connection failure log message to include server
> -
>
> Key: HBASE-27339
> URL: https://issues.apache.org/jira/browse/HBASE-27339
> Project: HBase
>  Issue Type: Improvement
>  Components: Client
>Affects Versions: 1.7.2
>Reporter: Daniel Wong
>Priority: Minor
> Fix For: 2.5.0
>
>
> We were seeing timeout issues in our deployment in the saslConnect path in 
> the blockingRPC client.  Knowing which server we failed to connect to would 
> help isolate and understand the issue.
>  
>  
> {code:java}
> ipc.BlockingRpcConnection - Exception encountered while connecting to the 
> server : 
> java.io.IOException: Connection reset by peer {code}
>  
>  
> Change the log message to something like
>  
> {code:java}
> ipc.BlockingRpcConnection - Exception encountered while connecting to the 
> server myhost.realm.net: 
> java.io.IOException: Connection reset by peer {code}
>  
> See relevant code 
> [here|https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/BlockingRpcConnection.java#L398]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (HBASE-27339) Improve sasl connection failure log message to include server

2022-08-26 Thread Viraj Jasani (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-27339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Viraj Jasani updated HBASE-27339:
-
Fix Version/s: 2.6.0
   3.0.0-alpha-4

> Improve sasl connection failure log message to include server
> -
>
> Key: HBASE-27339
> URL: https://issues.apache.org/jira/browse/HBASE-27339
> Project: HBase
>  Issue Type: Improvement
>  Components: Client
>Affects Versions: 1.7.2
>Reporter: Daniel Wong
>Priority: Minor
> Fix For: 2.5.0, 2.6.0, 3.0.0-alpha-4
>
>
> We were seeing timeout issues in our deployment in the saslConnect path in 
> the blockingRPC client.  Knowing which server we failed to connect to would 
> help isolate and understand the issue.
>  
>  
> {code:java}
> ipc.BlockingRpcConnection - Exception encountered while connecting to the 
> server : 
> java.io.IOException: Connection reset by peer {code}
>  
>  
> Change the log message to something like
>  
> {code:java}
> ipc.BlockingRpcConnection - Exception encountered while connecting to the 
> server myhost.realm.net: 
> java.io.IOException: Connection reset by peer {code}
>  
> See relevant code 
> [here|https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/BlockingRpcConnection.java#L398]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (HBASE-27339) Improve sasl connection failure log message to include server

2022-08-26 Thread Daniel Wong (Jira)
Daniel Wong created HBASE-27339:
---

 Summary: Improve sasl connection failure log message to include 
server
 Key: HBASE-27339
 URL: https://issues.apache.org/jira/browse/HBASE-27339
 Project: HBase
  Issue Type: Improvement
  Components: Client
Affects Versions: 2.4.13, 1.7.2
Reporter: Daniel Wong
 Fix For: 2.5.0


We were seeing timeout issues in our deployment in the saslConnect path in the 
blockingRPC client.  Knowing which server we failed to connect to would help 
isolate and understand the issue.

 

 
{code:java}
ipc.BlockingRpcConnection - Exception encountered while connecting to the 
server : 
java.io.IOException: Connection reset by peer {code}
 

 

Change the log message to something like

 
{code:java}
ipc.BlockingRpcConnection - Exception encountered while connecting to the 
server myhost.realm.net: 
java.io.IOException: Connection reset by peer {code}
 

See relevant code 
[here|https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/BlockingRpcConnection.java#L398]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [hbase] Apache-HBase commented on pull request #4734: HBASE-25922 - Disabled sanity checks ignored on snapshot restore (#4533)

2022-08-26 Thread GitBox


Apache-HBase commented on PR #4734:
URL: https://github.com/apache/hbase/pull/4734#issuecomment-1228898535

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   2m  7s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  8s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ branch-2.4 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 46s |  branch-2.4 passed  |
   | +1 :green_heart: |  compile  |   0m 55s |  branch-2.4 passed  |
   | +1 :green_heart: |  shadedjars  |   6m  6s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 33s |  branch-2.4 passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 13s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 59s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 59s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   5m 54s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 31s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  | 191m 16s |  hbase-server in the patch passed.  
|
   |  |   | 217m 31s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4734/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4734 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 76edb30c9c64 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 
23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2.4 / c8969e1859 |
   | Default Java | AdoptOpenJDK-11.0.10+9 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4734/1/testReport/
 |
   | Max. process+thread count | 2728 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4734/1/console 
|
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (HBASE-27330) Improvements of HMaster web ui

2022-08-26 Thread Viraj Jasani (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17585607#comment-17585607
 ] 

Viraj Jasani commented on HBASE-27330:
--

Curious, how many total regions you have on the cluster [~chaijunjie] 
[~fanyunbojerry] ?

> Improvements of HMaster web ui
> --
>
> Key: HBASE-27330
> URL: https://issues.apache.org/jira/browse/HBASE-27330
> Project: HBase
>  Issue Type: Improvement
>  Components: master, UI
>Affects Versions: 2.4.13
>Reporter: chaijunjie
>Priority: Major
>
> The HMaster web ui open very slowly when there are many regions in the 
> cluster, it may takes above 3min to load region and table messages, The RIT 
> and table on home page is very slow, because we load all info on one time...
> we need improve page loading speed of HMaster home page...



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [hbase] Apache-HBase commented on pull request #4734: HBASE-25922 - Disabled sanity checks ignored on snapshot restore (#4533)

2022-08-26 Thread GitBox


Apache-HBase commented on PR #4734:
URL: https://github.com/apache/hbase/pull/4734#issuecomment-1228890208

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m  5s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  4s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ branch-2.4 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 15s |  branch-2.4 passed  |
   | +1 :green_heart: |  compile  |   0m 37s |  branch-2.4 passed  |
   | +1 :green_heart: |  shadedjars  |   3m 56s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 26s |  branch-2.4 passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m  2s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 36s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 36s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   3m 55s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 23s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  | 195m 45s |  hbase-server in the patch passed.  
|
   |  |   | 213m 15s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4734/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4734 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 17cb4b22e459 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 
02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2.4 / c8969e1859 |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4734/1/testReport/
 |
   | Max. process+thread count | 2444 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4734/1/console 
|
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] bbeaudreault commented on pull request #4734: HBASE-25922 - Disabled sanity checks ignored on snapshot restore (#4533)

2022-08-26 Thread GitBox


bbeaudreault commented on PR #4734:
URL: https://github.com/apache/hbase/pull/4734#issuecomment-122229

   This is probably safe, but i'll merge once CI finishes since it's already 
running.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #4735: HBASE-27338 brotli compression lib tests fail on arm64

2022-08-26 Thread GitBox


Apache-HBase commented on PR #4735:
URL: https://github.com/apache/hbase/pull/4735#issuecomment-1228829635

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m  2s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  @author  |   0m  1s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 34s |  master passed  |
   | +1 :green_heart: |  compile  |   6m 12s |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 41s |  branch has no errors when 
running spotless:check.  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 12s |  the patch passed  |
   | +1 :green_heart: |  compile  |   6m 16s |  the patch passed  |
   | +1 :green_heart: |  javac  |   6m 16s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  xml  |   0m  1s |  The patch has no ill-formed XML 
file.  |
   | +1 :green_heart: |  hadoopcheck  |   7m 58s |  Patch does not cause any 
errors with Hadoop 3.2.4 3.3.4.  |
   | +1 :green_heart: |  spotless  |   0m 38s |  patch has no errors when 
running spotless:check.  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 13s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  32m 53s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4735/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4735 |
   | Optional Tests | dupname asflicense javac hadoopcheck spotless xml compile 
|
   | uname | Linux b4f7880df7f4 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 
02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 06728e554c |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   | Max. process+thread count | 139 (vs. ulimit of 3) |
   | modules | C: . U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4735/1/console 
|
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #4733: HBASE-26553 OAuth Bearer authentication mech plugin for SASL

2022-08-26 Thread GitBox


Apache-HBase commented on PR #4733:
URL: https://github.com/apache/hbase/pull/4733#issuecomment-1228827413

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 53s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 21s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   2m 41s |  master passed  |
   | +1 :green_heart: |  compile  |   1m 43s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   3m 58s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   2m 54s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 14s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 31s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 43s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m 43s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   3m 54s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   2m 55s |  the patch passed  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  | 213m 42s |  root in the patch failed.  |
   |  |   | 239m 30s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4733/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4733 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 5c8a411d2553 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 
23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 06728e554c |
   | Default Java | AdoptOpenJDK-11.0.10+9 |
   | unit | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4733/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4733/1/testReport/
 |
   | Max. process+thread count | 2599 (vs. ulimit of 3) |
   | modules | C: hbase-common hbase-client hbase-resource-bundle hbase-server 
hbase-examples . U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4733/1/console 
|
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #4727: HBASE-27317 : Storefiletracking : Rectifying the option for columnfamily as mandatory

2022-08-26 Thread GitBox


Apache-HBase commented on PR #4727:
URL: https://github.com/apache/hbase/pull/4727#issuecomment-1228825826

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 54s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  2s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 18s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 34s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   4m  0s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 22s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m  8s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 35s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 35s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   4m  1s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 23s |  the patch passed  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  | 242m 18s |  hbase-server in the patch failed.  |
   |  |   | 260m 33s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4727/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4727 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 9053d4c7792f 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 
23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 06728e554c |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   | unit | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4727/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4727/3/testReport/
 |
   | Max. process+thread count | 2462 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4727/3/console 
|
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #4727: HBASE-27317 : Storefiletracking : Rectifying the option for columnfamily as mandatory

2022-08-26 Thread GitBox


Apache-HBase commented on PR #4727:
URL: https://github.com/apache/hbase/pull/4727#issuecomment-1228799744

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m  6s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 29s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 46s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   3m 51s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 26s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 40s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 47s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 47s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   3m 47s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 26s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  | 207m 15s |  hbase-server in the patch passed.  
|
   |  |   | 225m 17s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4727/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4727 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 73220b24fe0c 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 
02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 06728e554c |
   | Default Java | AdoptOpenJDK-11.0.10+9 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4727/3/testReport/
 |
   | Max. process+thread count | 2564 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4727/3/console 
|
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (HBASE-27338) brotli compression lib tests fail on arm64

2022-08-26 Thread Michael Stack (Jira)
Michael Stack created HBASE-27338:
-

 Summary: brotli compression lib tests fail on arm64
 Key: HBASE-27338
 URL: https://issues.apache.org/jira/browse/HBASE-27338
 Project: HBase
  Issue Type: Improvement
Affects Versions: 2.5.0
Reporter: Michael Stack


The brotli tests fail on M1 macs

 

{{[INFO] Running org.apache.hadoop.hbase.io.compress.brotli.TestBrotliCodec}}
{{[INFO] Running 
org.apache.hadoop.hbase.io.compress.brotli.TestHFileCompressionBrotli}}
{{[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.33 
s <<< FAILURE! - in 
org.apache.hadoop.hbase.io.compress.brotli.TestHFileCompressionBrotli}}
{{[ERROR] 
org.apache.hadoop.hbase.io.compress.brotli.TestHFileCompressionBrotli.test  
Time elapsed: 0.225 s  <<< ERROR!}}
{{java.lang.UnsatisfiedLinkError: Failed to load Brotli native library}}

{{...}}

 

The lib is installed on this machine. A new release of 
*[Brotli4j|https://github.com/hyperxpro/Brotli4j]* lib, 1.8.0, done a few days 
ago fixes the issue... (See [https://github.com/hyperxpro/Brotli4j/pull/34).] I 
tried it .

{{[INFO] ---}}
{{[INFO]  T E S T S}}
{{[INFO] ---}}
{{[INFO] Running org.apache.hadoop.hbase.io.compress.brotli.TestBrotliCodec}}
{{[INFO] Running 
org.apache.hadoop.hbase.io.compress.brotli.TestHFileCompressionBrotli}}
{{[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.036 
s - in org.apache.hadoop.hbase.io.compress.brotli.TestHFileCompressionBrotli}}

{{[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 8.42 s 
- in org.apache.hadoop.hbase.io.compress.brotli.TestBrotliCodec}}
{{[INFO]}}
{{[INFO] Results:}}
{{[INFO]}}
{{[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0}}
{{[INFO]}}
{{[INFO]}}
{{[INFO] --- maven-surefire-plugin:3.0.0-M6:test (secondPartTestsExecution) @ 
hbase-compression-brotli ---}}
{{[INFO] Tests are skipped.}}
{{[INFO]}}
{{[INFO] --- maven-jar-plugin:3.2.0:test-jar (default) @ 
hbase-compression-brotli ---}}
{{[INFO] Building jar: 
/Users/stack/checkouts/hbase/2.5.0RC1/hbase-2.5.0/hbase-compression/hbase-compression-brotli/target/hbase-compression-brotli-2.5.0-tests.jar}}
{{[INFO]}}
{{[INFO] --- maven-jar-plugin:3.2.0:jar (default-jar) @ 
hbase-compression-brotli ---}}
{{[INFO] Building jar: 
/Users/stack/checkouts/hbase/2.5.0RC1/hbase-2.5.0/hbase-compression/hbase-compression-brotli/target/hbase-compression-brotli-2.5.0.jar}}
{{[INFO]}}
{{[INFO] --- maven-site-plugin:3.12.0:attach-descriptor (attach-descriptor) @ 
hbase-compression-brotli ---}}
{{[INFO] Skipping because packaging 'jar' is not pom.}}
{{[INFO]}}
{{[INFO] --- maven-install-plugin:2.5.2:install (default-install) @ 
hbase-compression-brotli ---}}
{{[INFO] Installing 
/Users/stack/checkouts/hbase/2.5.0RC1/hbase-2.5.0/hbase-compression/hbase-compression-brotli/target/hbase-compression-brotli-2.5.0.jar
 to 
/Users/stack/.m2/repository/org/apache/hbase/hbase-compression-brotli/2.5.0/hbase-compression-brotli-2.5.0.jar}}
{{[INFO] Installing 
/Users/stack/checkouts/hbase/2.5.0RC1/hbase-2.5.0/hbase-compression/hbase-compression-brotli/pom.xml
 to 
/Users/stack/.m2/repository/org/apache/hbase/hbase-compression-brotli/2.5.0/hbase-compression-brotli-2.5.0.pom}}
{{[INFO] Installing 
/Users/stack/checkouts/hbase/2.5.0RC1/hbase-2.5.0/hbase-compression/hbase-compression-brotli/target/hbase-compression-brotli-2.5.0-tests.jar
 to 
/Users/stack/.m2/repository/org/apache/hbase/hbase-compression-brotli/2.5.0/hbase-compression-brotli-2.5.0-tests.jar}}
{{[INFO] 
}}
{{[INFO] BUILD SUCCESS}}
{{[INFO] 
}}
{{[INFO] Total time:  16.805 s}}
{{[INFO] Finished at: 2022-08-26T11:30:13-07:00}}
{{[INFO] 
}}

 

 

 

 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [hbase] virajjasani commented on pull request #4536: HBASE-25709 Close region may stuck when region is compacting and skip…

2022-08-26 Thread GitBox


virajjasani commented on PR #4536:
URL: https://github.com/apache/hbase/pull/4536#issuecomment-1228753917

   Sorry @sunhelly, could not get to it for long time. Let me try to get back 
to this.
   Btw is the change in `setToNewRow()` something that we previously missing? 
Just trying to understand it better. Thank you @sunhelly 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #4734: HBASE-25922 - Disabled sanity checks ignored on snapshot restore (#4533)

2022-08-26 Thread GitBox


Apache-HBase commented on PR #4734:
URL: https://github.com/apache/hbase/pull/4734#issuecomment-1228735532

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 49s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ branch-2.4 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m  9s |  branch-2.4 passed  |
   | +1 :green_heart: |  compile  |   2m 14s |  branch-2.4 passed  |
   | +1 :green_heart: |  checkstyle  |   0m 28s |  branch-2.4 passed  |
   | +1 :green_heart: |  spotless  |   0m 38s |  branch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   1m 13s |  branch-2.4 passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   1m 54s |  the patch passed  |
   | +1 :green_heart: |  compile  |   2m  5s |  the patch passed  |
   | +1 :green_heart: |  javac  |   2m  5s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   0m 27s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  hadoopcheck  |  14m 32s |  Patch does not cause any 
errors with Hadoop 2.10.2 or 3.1.4 3.2.4 3.3.4.  |
   | +1 :green_heart: |  spotless  |   0m 35s |  patch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   1m 16s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m  9s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  33m 27s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4734/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4734 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
spotless checkstyle compile |
   | uname | Linux 0a5702186c2e 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 
23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2.4 / c8969e1859 |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   | Max. process+thread count | 65 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4734/1/console 
|
   | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (HBASE-25922) Disabled sanity checks ignored on snapshot restore

2022-08-26 Thread Ujjawal Kumar (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17585529#comment-17585529
 ] 

Ujjawal Kumar commented on HBASE-25922:
---

We also want this in branch-2.4, have created the cherrypick here 
https://github.com/apache/hbase/pull/4734

> Disabled sanity checks ignored on snapshot restore
> --
>
> Key: HBASE-25922
> URL: https://issues.apache.org/jira/browse/HBASE-25922
> Project: HBase
>  Issue Type: Bug
>  Components: conf, snapshots
>Affects Versions: 2.2.6, 2.4.2
> Environment: This has been tested in
>  * Google Dataproc running HBase 2.2.6
>  * Local HBase 2.4.2
>Reporter: Julian Nodorp
>Assignee: Ujjawal Kumar
>Priority: Minor
> Fix For: 2.5.1, 3.0.0-alpha-4
>
>
> Disabling sanity checks on a table is ignored when restoring snapshots. If 
> this is expected behavior at least the error message is misleading.
> h3. Steps *to Reproduce*
>  # Create a new table
> {{create 't', 'cf'}}
>  # Add a coprocessor to the newly created table
> {{alter 't', METHOD => 'table_att', 'coprocessor' => 
> 'coprocessor.jar|com.example.MyCoprocessor|0'}}
>  # Create a snapshot
> {{snapshot 't', 'snapshot-t'}}
>  # Disable the table to prevent region servers from crashing in the next step
> {{disable 't'}}
>  # Delete the coprocessor JAR and restart HBase.
>  # Attempt to restore the snapshot leads to failing sanity check as expected
> {{restore_snapshot 'snapshot-t'}}
> {{ERROR: org.apache.hadoop.hbase.DoNotRetryIOException: coprocessor.jar Set 
> hbase.table.sanity.checks to false at conf or table descriptor if you want to 
> bypass sanity checks [...]}}
>  # Disable sanity checks (as described in the error message) and retry
> {{alter 't', CONFIGURATION => \{'hbase.table.sanity.checks' => 'false'}}}
> {{restore_snapshot 'snapshot-t'}}
> h3. Expected Behavior
> The snapshot is restored.
> h3. Actual Behavior
> The same error message as in step 6. is shown.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [hbase] ujjawal4046 opened a new pull request, #4734: HBASE-25922 - Disabled sanity checks ignored on snapshot restore (#4533)

2022-08-26 Thread GitBox


ujjawal4046 opened a new pull request, #4734:
URL: https://github.com/apache/hbase/pull/4734

   Signed-off-by: Duo Zhang 
   Signed-off-by: Bryan Beaudreault 
   
   Conflicts:

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Kota-SH commented on a diff in pull request #4726: HBASE-27313: Persist list of Hfiles names for which prefetch is done

2022-08-26 Thread GitBox


Kota-SH commented on code in PR #4726:
URL: https://github.com/apache/hbase/pull/4726#discussion_r956201256


##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/PrefetchExecutor.java:
##
@@ -44,12 +50,15 @@ public final class PrefetchExecutor {
 
   /** Futures for tracking block prefetch activity */
   private static final Map> prefetchFutures = new 
ConcurrentSkipListMap<>();
+  /** Set of files for which prefetch is completed */
+  public static HashMap prefetchCompleted = new HashMap<>();

Review Comment:
   Thanks for the review Wellington :) 
   Yes, my initial approach was to use a set. But I could find a protobuf 
support for HashSet.
   
   Also, I wanted to maintain a unique set of filenames so I could avoid doing 
a duplicate check. So I chose a map implementation. 
   
   
https://developers.google.com/protocol-buffers/docs/reference/java-generated#map-fields
 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #4721: HBASE-27231 FSHLog should retry writing WAL entries when syncs to HDF…

2022-08-26 Thread GitBox


Apache-HBase commented on PR #4721:
URL: https://github.com/apache/hbase/pull/4721#issuecomment-1228683822

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 48s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  2s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 25s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 35s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   4m  2s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 23s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m  7s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 35s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 35s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   4m  4s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | -0 :warning: |  javadoc  |   0m 23s |  hbase-server generated 6 new + 23 
unchanged - 0 fixed = 29 total (was 23)  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  | 220m 43s |  hbase-server in the patch passed.  
|
   |  |   | 238m 26s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4721/8/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4721 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 32f3a4db6d34 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 
23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 92cf962fee |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   | javadoc | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4721/8/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt
 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4721/8/testReport/
 |
   | Max. process+thread count | 2833 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4721/8/console 
|
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #4733: HBASE-26553 OAuth Bearer authentication mech plugin for SASL

2022-08-26 Thread GitBox


Apache-HBase commented on PR #4733:
URL: https://github.com/apache/hbase/pull/4733#issuecomment-1228678645

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m  2s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 18s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   2m 24s |  master passed  |
   | +1 :green_heart: |  compile  |   6m 12s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   1m  1s |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 41s |  branch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |  10m 25s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 16s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 13s |  the patch passed  |
   | +1 :green_heart: |  compile  |   6m 11s |  the patch passed  |
   | -0 :warning: |  javac  |   6m 11s |  root generated 3 new + 707 unchanged 
- 0 fixed = 710 total (was 707)  |
   | -0 :warning: |  checkstyle  |   1m  0s |  root: The patch generated 6 new 
+ 0 unchanged - 0 fixed = 6 total (was 0)  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  xml  |   0m  1s |  The patch has no ill-formed XML 
file.  |
   | +1 :green_heart: |  hadoopcheck  |   8m  0s |  Patch does not cause any 
errors with Hadoop 3.2.4 3.3.4.  |
   | -1 :x: |  spotless  |   0m 12s |  patch has 71 errors when running 
spotless:check, run spotless:apply to fix.  |
   | +1 :green_heart: |  spotbugs  |  10m 51s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 58s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  58m  2s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4733/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4733 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
spotless checkstyle compile xml |
   | uname | Linux 6546613b29b7 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 
02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 06728e554c |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   | javac | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4733/1/artifact/yetus-general-check/output/diff-compile-javac-root.txt
 |
   | checkstyle | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4733/1/artifact/yetus-general-check/output/diff-checkstyle-root.txt
 |
   | spotless | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4733/1/artifact/yetus-general-check/output/patch-spotless.txt
 |
   | Max. process+thread count | 138 (vs. ulimit of 3) |
   | modules | C: hbase-common hbase-client hbase-resource-bundle hbase-server 
hbase-examples . U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4733/1/console 
|
   | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #4721: HBASE-27231 FSHLog should retry writing WAL entries when syncs to HDF…

2022-08-26 Thread GitBox


Apache-HBase commented on PR #4721:
URL: https://github.com/apache/hbase/pull/4721#issuecomment-1228668163

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 20s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  4s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 30s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 48s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   3m 45s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 26s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 39s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 46s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 46s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   3m 44s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | -0 :warning: |  javadoc  |   0m 27s |  hbase-server generated 6 new + 91 
unchanged - 5 fixed = 97 total (was 96)  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  | 205m 16s |  hbase-server in the patch passed.  
|
   |  |   | 222m  7s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4721/8/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4721 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux f498399a7302 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 
02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 92cf962fee |
   | Default Java | AdoptOpenJDK-11.0.10+9 |
   | javadoc | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4721/8/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt
 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4721/8/testReport/
 |
   | Max. process+thread count | 2604 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4721/8/console 
|
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Assigned] (HBASE-27336) The region visualizer shows 'undefined' region server

2022-08-26 Thread LiangJun He (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-27336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

LiangJun He reassigned HBASE-27336:
---

Assignee: LiangJun He

> The region visualizer shows 'undefined' region server
> -
>
> Key: HBASE-27336
> URL: https://issues.apache.org/jira/browse/HBASE-27336
> Project: HBase
>  Issue Type: Bug
>  Components: master, UI
>Reporter: Duo Zhang
>Assignee: LiangJun He
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (HBASE-27337) [hbase-thirdparty] Add nimbus-jose-jwt library to hbase-shaded-miscellaneous

2022-08-26 Thread Andor Molnar (Jira)
Andor Molnar created HBASE-27337:


 Summary: [hbase-thirdparty] Add nimbus-jose-jwt library to 
hbase-shaded-miscellaneous
 Key: HBASE-27337
 URL: https://issues.apache.org/jira/browse/HBASE-27337
 Project: HBase
  Issue Type: Task
  Components: thirdparty
Reporter: Andor Molnar
Assignee: Andor Molnar


Required for OAuthBearer SASL auth plugin to work properly.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-27336) The region visualizer shows 'undefined' region server

2022-08-26 Thread Duo Zhang (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17585448#comment-17585448
 ] 

Duo Zhang commented on HBASE-27336:
---

Please see the attached image.

[~ndimiduk] FYI.

> The region visualizer shows 'undefined' region server
> -
>
> Key: HBASE-27336
> URL: https://issues.apache.org/jira/browse/HBASE-27336
> Project: HBase
>  Issue Type: Bug
>  Components: master, UI
>Reporter: Duo Zhang
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (HBASE-27335) HBase shell hang for a minute when quiting

2022-08-26 Thread Duo Zhang (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-27335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang updated HBASE-27335:
--
Summary: HBase shell hang for a minute when quiting  (was: HBase shell hang 
fora minute when quiting)

> HBase shell hang for a minute when quiting
> --
>
> Key: HBASE-27335
> URL: https://issues.apache.org/jira/browse/HBASE-27335
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Reporter: Duo Zhang
>Priority: Major
> Attachments: jstack.log
>
>
> Found this when trying the 2.5.0 RC. The way to reproduce
> Use './bin/hbase shell' to connect to a cluster, and then run these two 
> commands
> {code}
> count "hbase:meta"
> quit
> {code}
> We will hang about 1 minute before the final exit of the shell process.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (HBASE-27336) The region visualizer shows 'undefined' region server

2022-08-26 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-27336:
-

 Summary: The region visualizer shows 'undefined' region server
 Key: HBASE-27336
 URL: https://issues.apache.org/jira/browse/HBASE-27336
 Project: HBase
  Issue Type: Bug
  Components: master, UI
Reporter: Duo Zhang






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [hbase] Apache-HBase commented on pull request #4727: HBASE-27317 : Storefiletracking : Rectifying the option for columnfamily as mandatory

2022-08-26 Thread GitBox


Apache-HBase commented on PR #4727:
URL: https://github.com/apache/hbase/pull/4727#issuecomment-1228623029

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m  2s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 13s |  master passed  |
   | +1 :green_heart: |  compile  |   2m 14s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   0m 30s |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 39s |  branch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   1m 22s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 13s |  the patch passed  |
   | +1 :green_heart: |  compile  |   2m 17s |  the patch passed  |
   | +1 :green_heart: |  javac  |   2m 17s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   0m 30s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  hadoopcheck  |   7m 55s |  Patch does not cause any 
errors with Hadoop 3.2.4 3.3.4.  |
   | +1 :green_heart: |  spotless  |   0m 39s |  patch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   1m 24s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 10s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  28m 24s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4727/3/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4727 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
spotless checkstyle compile |
   | uname | Linux cea7c64d2b77 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 
02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 06728e554c |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   | Max. process+thread count | 64 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4727/3/console 
|
   | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] anmolnar opened a new pull request, #4733: HBASE-26553 OAuth Bearer authentication mech plugin for SASL

2022-08-26 Thread GitBox


anmolnar opened a new pull request, #4733:
URL: https://github.com/apache/hbase/pull/4733

   Adds a new SASL mech plugin for OAuthBearer (JWT) authentication. 
   - In order to keep the size of this initial patch manageable, the supported 
workflow is limited: client reads a single JWT token with expiry information 
from environment variable and authenticates with the server. 
   - It works similarly to Hadoop delegation tokens, JWT token takes 
precedence, but if it's missing, the auth provider will fall back to Kerberos.
   - Kerberos must be enabled on the cluster, otherwise HBase security is not 
enabled.
   
   Minimum configuration to enable JWT auth:
   ```
 
   hbase.client.sasl.provider.extras
   
org.apache.hadoop.hbase.security.provider.OAuthBearerSaslClientAuthenticationProvider
 
 
   hbase.server.sasl.provider.extras
   
org.apache.hadoop.hbase.security.provider.OAuthBearerSaslServerAuthenticationProvider
 
 
   hbase.client.sasl.provider.class
   
org.apache.hadoop.hbase.security.provider.OAuthBearerSaslProviderSelector
 
 
   hbase.security.oauth.jwt.jwks.url
   JWKS download url
 
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (HBASE-27335) HBase shell hang fora minute when quiting

2022-08-26 Thread Duo Zhang (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17585427#comment-17585427
 ] 

Duo Zhang commented on HBASE-27335:
---

[~ndimiduk] FYI.

> HBase shell hang fora minute when quiting
> -
>
> Key: HBASE-27335
> URL: https://issues.apache.org/jira/browse/HBASE-27335
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Reporter: Duo Zhang
>Priority: Major
> Attachments: jstack.log
>
>
> Found this when trying the 2.5.0 RC. The way to reproduce
> Use './bin/hbase shell' to connect to a cluster, and then run these two 
> commands
> {code}
> count "hbase:meta"
> quit
> {code}
> We will hang about 1 minute before the final exit of the shell process.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-27335) HBase shell hang fora minute when quiting

2022-08-26 Thread Duo Zhang (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17585426#comment-17585426
 ] 

Duo Zhang commented on HBASE-27335:
---

Attached the jstack when hanging.

Seems the only non daemon thread besides the JVM's is

{noformat}
"hconnection-0x656672fb-shared-pool-0" #27 prio=5 os_prio=0 cpu=179.83ms 
elapsed=29.72s tid=0x7fbe2a4a1800 nid=0x1b3b waiting on condition  
[0x7fbdf1dfe000]
   java.lang.Thread.State: TIMED_WAITING (parking)
at jdk.internal.misc.Unsafe.park(java.base@11.0.15/Native Method)
- parking to wait for  <0x0006a2a50e08> (a 
java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
at 
java.util.concurrent.locks.LockSupport.parkNanos(java.base@11.0.15/LockSupport.java:234)
at 
java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(java.base@11.0.15/AbstractQueuedSynchronizer.java:2123)
at 
java.util.concurrent.LinkedBlockingQueue.poll(java.base@11.0.15/LinkedBlockingQueue.java:458)
at 
java.util.concurrent.ThreadPoolExecutor.getTask(java.base@11.0.15/ThreadPoolExecutor.java:1053)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(java.base@11.0.15/ThreadPoolExecutor.java:1114)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(java.base@11.0.15/ThreadPoolExecutor.java:628)
at java.lang.Thread.run(java.base@11.0.15/Thread.java:829)
{noformat}

And another thing is that, if you leave the shell without any action for 1 
minute, then you can quit it immediately.

> HBase shell hang fora minute when quiting
> -
>
> Key: HBASE-27335
> URL: https://issues.apache.org/jira/browse/HBASE-27335
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Reporter: Duo Zhang
>Priority: Major
> Attachments: jstack.log
>
>
> Found this when trying the 2.5.0 RC. The way to reproduce
> Use './bin/hbase shell' to connect to a cluster, and then run these two 
> commands
> {code}
> count "hbase:meta"
> quit
> {code}
> We will hang about 1 minute before the final exit of the shell process.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (HBASE-27335) HBase shell hang fora minute when quiting

2022-08-26 Thread Duo Zhang (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-27335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang updated HBASE-27335:
--
Attachment: jstack.log

> HBase shell hang fora minute when quiting
> -
>
> Key: HBASE-27335
> URL: https://issues.apache.org/jira/browse/HBASE-27335
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Reporter: Duo Zhang
>Priority: Major
> Attachments: jstack.log
>
>
> Found this when trying the 2.5.0 RC. The way to reproduce
> Use './bin/hbase shell' to connect to a cluster, and then run these two 
> commands
> {code}
> count "hbase:meta"
> quit
> {code}
> We will hang about 1 minute before the final exit of the shell process.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (HBASE-27335) HBase shell hang fora minute when quiting

2022-08-26 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-27335:
-

 Summary: HBase shell hang fora minute when quiting
 Key: HBASE-27335
 URL: https://issues.apache.org/jira/browse/HBASE-27335
 Project: HBase
  Issue Type: Bug
  Components: shell
Reporter: Duo Zhang


Found this when trying the 2.5.0 RC. The way to reproduce

Use './bin/hbase shell' to connect to a cluster, and then run these two commands

{code}
count "hbase:meta"
quit
{code}

We will hang about 1 minute before the final exit of the shell process.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [hbase] Apache-HBase commented on pull request #4732: HBASE-27333 The condition for using the local hostname is the opposite

2022-08-26 Thread GitBox


Apache-HBase commented on PR #4732:
URL: https://github.com/apache/hbase/pull/4732#issuecomment-1228578006

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 23s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 25s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 40s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   3m 46s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 26s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 14s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 36s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 36s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   3m 46s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 24s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  | 204m 20s |  hbase-server in the patch passed.  
|
   |  |   | 220m 48s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4732/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4732 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 3283fac55ad6 5.4.0-109-generic #123-Ubuntu SMP Fri Apr 8 
09:10:54 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 92cf962fee |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4732/1/testReport/
 |
   | Max. process+thread count | 2370 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4732/1/console 
|
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #4732: HBASE-27333 The condition for using the local hostname is the opposite

2022-08-26 Thread GitBox


Apache-HBase commented on PR #4732:
URL: https://github.com/apache/hbase/pull/4732#issuecomment-1228569595

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 40s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  2s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 47s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 42s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   3m 59s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 25s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 29s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 42s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 42s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   3m 54s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 23s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  | 196m 44s |  hbase-server in the patch passed.  
|
   |  |   | 214m  9s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4732/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4732 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux f312be069696 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 
28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 92cf962fee |
   | Default Java | AdoptOpenJDK-11.0.10+9 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4732/1/testReport/
 |
   | Max. process+thread count | 2435 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4732/1/console 
|
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (HBASE-25922) Disabled sanity checks ignored on snapshot restore

2022-08-26 Thread Bryan Beaudreault (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-25922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Beaudreault updated HBASE-25922:
--
Fix Version/s: (was: 2.6.0)

> Disabled sanity checks ignored on snapshot restore
> --
>
> Key: HBASE-25922
> URL: https://issues.apache.org/jira/browse/HBASE-25922
> Project: HBase
>  Issue Type: Bug
>  Components: conf, snapshots
>Affects Versions: 2.2.6, 2.4.2
> Environment: This has been tested in
>  * Google Dataproc running HBase 2.2.6
>  * Local HBase 2.4.2
>Reporter: Julian Nodorp
>Assignee: Ujjawal Kumar
>Priority: Minor
> Fix For: 2.5.1, 3.0.0-alpha-4
>
>
> Disabling sanity checks on a table is ignored when restoring snapshots. If 
> this is expected behavior at least the error message is misleading.
> h3. Steps *to Reproduce*
>  # Create a new table
> {{create 't', 'cf'}}
>  # Add a coprocessor to the newly created table
> {{alter 't', METHOD => 'table_att', 'coprocessor' => 
> 'coprocessor.jar|com.example.MyCoprocessor|0'}}
>  # Create a snapshot
> {{snapshot 't', 'snapshot-t'}}
>  # Disable the table to prevent region servers from crashing in the next step
> {{disable 't'}}
>  # Delete the coprocessor JAR and restart HBase.
>  # Attempt to restore the snapshot leads to failing sanity check as expected
> {{restore_snapshot 'snapshot-t'}}
> {{ERROR: org.apache.hadoop.hbase.DoNotRetryIOException: coprocessor.jar Set 
> hbase.table.sanity.checks to false at conf or table descriptor if you want to 
> bypass sanity checks [...]}}
>  # Disable sanity checks (as described in the error message) and retry
> {{alter 't', CONFIGURATION => \{'hbase.table.sanity.checks' => 'false'}}}
> {{restore_snapshot 'snapshot-t'}}
> h3. Expected Behavior
> The snapshot is restored.
> h3. Actual Behavior
> The same error message as in step 6. is shown.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (HBASE-25922) Disabled sanity checks ignored on snapshot restore

2022-08-26 Thread Bryan Beaudreault (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-25922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Beaudreault resolved HBASE-25922.
---
Fix Version/s: 2.6.0
   2.5.1
   3.0.0-alpha-4
   Resolution: Fixed

Pushed to master, branch-2, branch-2.5. Thanks for the contribution [~ukumar] 
and review [~zhangduo]! 

> Disabled sanity checks ignored on snapshot restore
> --
>
> Key: HBASE-25922
> URL: https://issues.apache.org/jira/browse/HBASE-25922
> Project: HBase
>  Issue Type: Bug
>  Components: conf, snapshots
>Affects Versions: 2.2.6, 2.4.2
> Environment: This has been tested in
>  * Google Dataproc running HBase 2.2.6
>  * Local HBase 2.4.2
>Reporter: Julian Nodorp
>Assignee: Ujjawal Kumar
>Priority: Minor
> Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4
>
>
> Disabling sanity checks on a table is ignored when restoring snapshots. If 
> this is expected behavior at least the error message is misleading.
> h3. Steps *to Reproduce*
>  # Create a new table
> {{create 't', 'cf'}}
>  # Add a coprocessor to the newly created table
> {{alter 't', METHOD => 'table_att', 'coprocessor' => 
> 'coprocessor.jar|com.example.MyCoprocessor|0'}}
>  # Create a snapshot
> {{snapshot 't', 'snapshot-t'}}
>  # Disable the table to prevent region servers from crashing in the next step
> {{disable 't'}}
>  # Delete the coprocessor JAR and restart HBase.
>  # Attempt to restore the snapshot leads to failing sanity check as expected
> {{restore_snapshot 'snapshot-t'}}
> {{ERROR: org.apache.hadoop.hbase.DoNotRetryIOException: coprocessor.jar Set 
> hbase.table.sanity.checks to false at conf or table descriptor if you want to 
> bypass sanity checks [...]}}
>  # Disable sanity checks (as described in the error message) and retry
> {{alter 't', CONFIGURATION => \{'hbase.table.sanity.checks' => 'false'}}}
> {{restore_snapshot 'snapshot-t'}}
> h3. Expected Behavior
> The snapshot is restored.
> h3. Actual Behavior
> The same error message as in step 6. is shown.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [hbase] petersomogyi commented on pull request #4531: [HBASE-27116]fix the ruby issue which cause disable all table failure

2022-08-26 Thread GitBox


petersomogyi commented on PR #4531:
URL: https://github.com/apache/hbase/pull/4531#issuecomment-1228498484

   It is also failing with clean exit.
   ```
   echo "list\nexit" > clean_exit.rb
   
   /bin/hbase shell -n < clean_exit.rb ; echo $?
   TABLE
   peter
   1 row(s)
   Took 0.4534 seconds
   peter
   ERROR NoMethodError: undefined method `irb' for nil:NilClass
   1
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] petersomogyi commented on pull request #4531: [HBASE-27116]fix the ruby issue which cause disable all table failure

2022-08-26 Thread GitBox


petersomogyi commented on PR #4531:
URL: https://github.com/apache/hbase/pull/4531#issuecomment-1228479859

   Hi @alexdongli0829, I've tested your patch on the master branch, and in this 
combination it throws NoSuchMetrod error. Can you check?
   
   ```
   echo "list\nexit 1" > error_exit.rb
   
   ./bin/hbase shell -n < error_exit.rb ; echo $?
   TABLE
   peter
   1 row(s)
   Took 0.4349 seconds
   peter
   ERROR NoMethodError: undefined method `irb' for nil:NilClass
   1
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #4721: HBASE-27231 FSHLog should retry writing WAL entries when syncs to HDF…

2022-08-26 Thread GitBox


Apache-HBase commented on PR #4721:
URL: https://github.com/apache/hbase/pull/4721#issuecomment-1228441840

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m  4s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 12s |  master passed  |
   | +1 :green_heart: |  compile  |   2m 13s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   0m 31s |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 39s |  branch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   1m 17s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 15s |  the patch passed  |
   | +1 :green_heart: |  compile  |   2m 12s |  the patch passed  |
   | +1 :green_heart: |  javac  |   2m 12s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   0m 30s |  hbase-server: The patch 
generated 0 new + 21 unchanged - 2 fixed = 21 total (was 23)  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  hadoopcheck  |   7m 53s |  Patch does not cause any 
errors with Hadoop 3.2.4 3.3.4.  |
   | +1 :green_heart: |  spotless  |   0m 38s |  patch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   1m 23s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m  9s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  27m 51s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4721/8/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4721 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
spotless checkstyle compile |
   | uname | Linux ad2884e31371 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 
02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 92cf962fee |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   | Max. process+thread count | 60 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4721/8/console 
|
   | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] bbeaudreault merged pull request #4533: HBASE-25922 - Disabled sanity checks ignored on snapshot restore

2022-08-26 Thread GitBox


bbeaudreault merged PR #4533:
URL: https://github.com/apache/hbase/pull/4533


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (HBASE-27334) Add support for unsigned varint to Bytes util class

2022-08-26 Thread Bryan Beaudreault (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-27334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Beaudreault updated HBASE-27334:
--
Description: 
Our current Bytes.vintToBytes accepts a signed long, and the resulting encoded 
size is larger than it needs to be for small values. For example, 
Bytes.vintToBytes requires 3 bytes for values over 255, whereas an unsigned 
implementation can use 2 bytes for up to 16383. This continues across the 
spectrum, with the current requiring 4 bytes for values over 65535 and an 
unsigned impl can use 3 bytes up to 2097151, etc.

We can pull the implementation from protobuf's CodedInputStream and 
CodedOutputStream

  was:
Our current Bytes.vintToBytes accepts a signed long, and the resulting encoded 
size is larger than it needs to be for small values. For example, 
Bytes.vintToBytes requires 3 bytes for values over 255, whereas an unsigned 
implementation can use 2 bytes for up to 16383. This continues across the 
spectrum, with the current requiring 4 bytes for values over 65535 and an 
unsigned impl can use 3 bytes up to 2097151, etc.

We can pull the implementation from CodedInputStream and CodedOutputStream


> Add support for unsigned varint to Bytes util class
> ---
>
> Key: HBASE-27334
> URL: https://issues.apache.org/jira/browse/HBASE-27334
> Project: HBase
>  Issue Type: New Feature
>Reporter: Bryan Beaudreault
>Priority: Minor
>  Labels: beginner-friendly
>
> Our current Bytes.vintToBytes accepts a signed long, and the resulting 
> encoded size is larger than it needs to be for small values. For example, 
> Bytes.vintToBytes requires 3 bytes for values over 255, whereas an unsigned 
> implementation can use 2 bytes for up to 16383. This continues across the 
> spectrum, with the current requiring 4 bytes for values over 65535 and an 
> unsigned impl can use 3 bytes up to 2097151, etc.
> We can pull the implementation from protobuf's CodedInputStream and 
> CodedOutputStream



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (HBASE-24457) release scripts on mac os are too slow

2022-08-26 Thread Bryan Beaudreault (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-24457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Beaudreault updated HBASE-24457:
--
Labels: beginner-friendly  (was: )

> release scripts on mac os are too slow
> --
>
> Key: HBASE-24457
> URL: https://issues.apache.org/jira/browse/HBASE-24457
> Project: HBase
>  Issue Type: Umbrella
>  Components: community
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Blocker
>  Labels: beginner-friendly
> Fix For: 3.0.0-alpha-4
>
>
> related changes  to try to bring the time down to something I can use



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (HBASE-24457) release scripts on mac os are too slow

2022-08-26 Thread Bryan Beaudreault (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-24457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Beaudreault updated HBASE-24457:
--
Labels:   (was: beginner-friendly)

> release scripts on mac os are too slow
> --
>
> Key: HBASE-24457
> URL: https://issues.apache.org/jira/browse/HBASE-24457
> Project: HBase
>  Issue Type: Umbrella
>  Components: community
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Blocker
> Fix For: 3.0.0-alpha-4
>
>
> related changes  to try to bring the time down to something I can use



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (HBASE-27334) Add support for unsigned varint to Bytes util class

2022-08-26 Thread Bryan Beaudreault (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-27334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Beaudreault updated HBASE-27334:
--
Labels: beginner-friendly  (was: )

> Add support for unsigned varint to Bytes util class
> ---
>
> Key: HBASE-27334
> URL: https://issues.apache.org/jira/browse/HBASE-27334
> Project: HBase
>  Issue Type: New Feature
>Reporter: Bryan Beaudreault
>Priority: Minor
>  Labels: beginner-friendly
>
> Our current Bytes.vintToBytes accepts a signed long, and the resulting 
> encoded size is larger than it needs to be for small values. For example, 
> Bytes.vintToBytes requires 3 bytes for values over 255, whereas an unsigned 
> implementation can use 2 bytes for up to 16383. This continues across the 
> spectrum, with the current requiring 4 bytes for values over 65535 and an 
> unsigned impl can use 3 bytes up to 2097151, etc.
> We can pull the implementation from CodedInputStream and CodedOutputStream



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (HBASE-27334) Add support for unsigned varint to Bytes util class

2022-08-26 Thread Bryan Beaudreault (Jira)
Bryan Beaudreault created HBASE-27334:
-

 Summary: Add support for unsigned varint to Bytes util class
 Key: HBASE-27334
 URL: https://issues.apache.org/jira/browse/HBASE-27334
 Project: HBase
  Issue Type: New Feature
Reporter: Bryan Beaudreault


Our current Bytes.vintToBytes accepts a signed long, and the resulting encoded 
size is larger than it needs to be for small values. For example, 
Bytes.vintToBytes requires 3 bytes for values over 255, whereas an unsigned 
implementation can use 2 bytes for up to 16383. This continues across the 
spectrum, with the current requiring 4 bytes for values over 65535 and an 
unsigned impl can use 3 bytes up to 2097151, etc.

We can pull the implementation from CodedInputStream and CodedOutputStream



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [hbase] comnetwork commented on pull request #4721: HBASE-27231 FSHLog should retry writing WAL entries when syncs to HDF…

2022-08-26 Thread GitBox


comnetwork commented on PR #4721:
URL: https://github.com/apache/hbase/pull/4721#issuecomment-1228380175

   After I read the `FSHLog` code in current master,2.x, 1.x and 0.98, I find 
there are always existing a single-thread consumer to call blocking 
`ProtobufLog.append`(eg. in master `FSHLog.RingBufferEventHandler` 
corresponding to `AsyncFSWAL.consumeExecutor` calls `ProtobufLog.append` in its 
single-thread `onEvent` method), the problem you describe already exists in 
`FSHLog`. 
   One possible solution I can think of is to wrap `FSDataOutputStream` with a 
new `BufProtobufLogWriter` in a similar way to `AsyncProtobufLogWriter`, we 
just write to the internal `ByteBuffer` of `BufProtobufLogWriter` in 
`consumeExecutor`. When `BufProtobufLogWriter.sync` is called, we use a 
single-thread `FSWriter` to invoke `FSOutputStream.write`and this single-thread 
`FSWriter` use multiple SyncRunners to invoke `FSDataOutputstream.hflush`. 
`FSDataOutputstream.write` may also block this single single-thread 
`FSWriter`,so the queue between `consumeExecutor`  and `FSWriter`  is also 
likely to be full, once the queue is full, we could fail the sync requests and 
then execute syncFailed logic to retry.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #4732: HBASE-27333 The condition for using the local hostname is the opposite

2022-08-26 Thread GitBox


Apache-HBase commented on PR #4732:
URL: https://github.com/apache/hbase/pull/4732#issuecomment-1228379510

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 59s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 29s |  master passed  |
   | +1 :green_heart: |  compile  |   2m 16s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   0m 32s |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 41s |  branch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   1m 18s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 13s |  the patch passed  |
   | +1 :green_heart: |  compile  |   2m 16s |  the patch passed  |
   | +1 :green_heart: |  javac  |   2m 16s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   0m 31s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  hadoopcheck  |   8m  5s |  Patch does not cause any 
errors with Hadoop 3.2.4 3.3.4.  |
   | +1 :green_heart: |  spotless  |   0m 39s |  patch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   1m 25s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 12s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  28m 55s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4732/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4732 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
spotless checkstyle compile |
   | uname | Linux 413d05ddfe43 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 
02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 92cf962fee |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   | Max. process+thread count | 72 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4732/1/console 
|
   | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] comnetwork commented on pull request #4721: HBASE-27231 FSHLog should retry writing WAL entries when syncs to HDF…

2022-08-26 Thread GitBox


comnetwork commented on PR #4721:
URL: https://github.com/apache/hbase/pull/4721#issuecomment-1228364454

   After I read the FSHLog code in current master,2.x, 1.x and 0.98, I find 
they always has a single-thread consumer  to call blocking 
`ProtobufLog.append`(eg. in master `FSHLog.RingBufferEventHandler`  
corresponding to `AsyncFSWAL.consumeExecutor` calls `ProtobufLog.append` in its 
single-thread onEvent method),  the problem you describe always exists in 
`FSHLog`. One possible solution I can think of is to wrap FSOutputStream with a 
BufProtobufLogWriter in a similar way to AsyncProtobufLogWriter. In 
consumeExecutor just written to the internal BufProtobufLogWriter ByteBuffer, 
BufProtobufLogWriter when needed. The sync, The FSoutputStream.write will be 
synched by SyncRunner. Fsoutputstream.write may also block a single thread. So 
between the FSWriter and consumeExecutor queue is likely to be full, once the 
queue is full, can let call BufProtobufLogWriter. Sync request fails, then 
execute syncFailed logic


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (HBASE-27332) Remove RejectedExecutionHandler for long/short compaction thread pools

2022-08-26 Thread Bryan Beaudreault (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17585306#comment-17585306
 ] 

Bryan Beaudreault commented on HBASE-27332:
---

I feel like an OOME is a pretty bad failure mode for compaction queue buildup. 
Should we bound the queue? Maybe not a blocker for this issue, but might also 
change the approach if we decided to do that instead. 

> Remove RejectedExecutionHandler for long/short compaction thread pools
> --
>
> Key: HBASE-27332
> URL: https://issues.apache.org/jira/browse/HBASE-27332
> Project: HBase
>  Issue Type: Improvement
>  Components: Compaction
>Affects Versions: 3.0.0-alpha-3, 2.4.13
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Minor
> Fix For: 2.6.0, 3.0.0-alpha-4
>
>
> As disscussed in https://github.com/apache/hbase/pull/4725
> actually the max size of StealJobQueue is bouded by the VM limit of an array, 
> and the OOM exception occurs before the rejection handler. So StealJobQueue 
> is equivalent to be unbounded. I think the RejectionHandler may bring some 
> confusions and make the codes a little puzzle.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (HBASE-25382) Super Split Meta

2022-08-26 Thread Xiaolin Ha (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-25382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Xiaolin Ha reassigned HBASE-25382:
--

Assignee: (was: Xiaolin Ha)

> Super Split Meta
> 
>
> Key: HBASE-25382
> URL: https://issues.apache.org/jira/browse/HBASE-25382
> Project: HBase
>  Issue Type: Umbrella
>  Components: meta
>Reporter: Michael Stack
>Priority: Major
>
> Currently, the hbase:meta Table is made of one Region only. It is not 
> splittable. We would like to make it so the hbase:meta table can be split 
> just as we for user-space tables as they grow in size.
> Why split the hbase:meta table?
> {quote}A single Region _hbase:meta_ Table hotspots as cluster size grows. At 
> extreme, hotspotting brings on special-casing with deploys dedicating nodes 
> solely to the hosting of the single _hbase:meta_ Region to better carry the 
> higher load (but also to isolate _hbase:meta_ if heavily trafficked neighbor 
> Regions). Splitting, currently disallowed, will enable distributing the 
> _hbase:meta_ Table Regions, and thereby load, across the cluster. A 
> splittable _hbase:meta_ table will also alleviate concerns enlarging the 
> _hbase:meta_ table whether by adding more meta data per Region entry -- e.g. 
> keeping the list of Region HFiles in the _hbase:meta_ table -- or running 
> with more, smaller Regions rather than a few large Regions.
> {quote}
> This is not the first issue to concern itself with meta splitting 
> (HBASE-11288, HBASE-24950). By aggreement. -- see the base of HBASE-11288 -- 
> this issue supplants all previous JIRAs and design efforts. It is a reset. We 
> start by listing requirements in the attached Super Split Meta Design.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (HBASE-27333) The condition for using the local hostname is the opposite

2022-08-26 Thread Xiaolin Ha (Jira)
Xiaolin Ha created HBASE-27333:
--

 Summary: The condition for using the local hostname is the opposite
 Key: HBASE-27333
 URL: https://issues.apache.org/jira/browse/HBASE-27333
 Project: HBase
  Issue Type: Bug
  Components: regionserver
Affects Versions: 2.4.13, 3.0.0-alpha-3
Reporter: Xiaolin Ha
Assignee: Xiaolin Ha
 Fix For: 2.5.1, 3.0.0-alpha-4


For HRegionServer#handleReportForDutyResponse, when the hostname is different 
from the regionserver and master side, the condition to use the local hostname 
configed on regionserver is opposite.
{code:java}
if (
  !StringUtils.isBlank(useThisHostnameInstead)
&& !hostnameFromMasterPOV.equals(useThisHostnameInstead)
) {
  String msg = "Master passed us a different hostname to use; was="
+ this.useThisHostnameInstead + ", but now=" + hostnameFromMasterPOV;
  LOG.error(msg);
  throw new IOException(msg);
}
if (
  StringUtils.isBlank(useThisHostnameInstead)
&& 
!hostnameFromMasterPOV.equals(rpcServices.getSocketAddress().getHostName())
) {
  String msg = "Master passed us a different hostname to use; was="
+ rpcServices.getSocketAddress().getHostName() + ", but now=" + 
hostnameFromMasterPOV;
  LOG.error(msg);
} {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (HBASE-25382) Super Split Meta

2022-08-26 Thread Xiaolin Ha (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-25382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Xiaolin Ha reassigned HBASE-25382:
--

Assignee: Xiaolin Ha

> Super Split Meta
> 
>
> Key: HBASE-25382
> URL: https://issues.apache.org/jira/browse/HBASE-25382
> Project: HBase
>  Issue Type: Umbrella
>  Components: meta
>Reporter: Michael Stack
>Assignee: Xiaolin Ha
>Priority: Major
>
> Currently, the hbase:meta Table is made of one Region only. It is not 
> splittable. We would like to make it so the hbase:meta table can be split 
> just as we for user-space tables as they grow in size.
> Why split the hbase:meta table?
> {quote}A single Region _hbase:meta_ Table hotspots as cluster size grows. At 
> extreme, hotspotting brings on special-casing with deploys dedicating nodes 
> solely to the hosting of the single _hbase:meta_ Region to better carry the 
> higher load (but also to isolate _hbase:meta_ if heavily trafficked neighbor 
> Regions). Splitting, currently disallowed, will enable distributing the 
> _hbase:meta_ Table Regions, and thereby load, across the cluster. A 
> splittable _hbase:meta_ table will also alleviate concerns enlarging the 
> _hbase:meta_ table whether by adding more meta data per Region entry -- e.g. 
> keeping the list of Region HFiles in the _hbase:meta_ table -- or running 
> with more, smaller Regions rather than a few large Regions.
> {quote}
> This is not the first issue to concern itself with meta splitting 
> (HBASE-11288, HBASE-24950). By aggreement. -- see the base of HBASE-11288 -- 
> this issue supplants all previous JIRAs and design efforts. It is a reset. We 
> start by listing requirements in the attached Super Split Meta Design.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [hbase] Apache-HBase commented on pull request #4730: HBASE-27321 The ReplicationLogCleaner is not thread safe but can be c…

2022-08-26 Thread GitBox


Apache-HBase commented on PR #4730:
URL: https://github.com/apache/hbase/pull/4730#issuecomment-1228235440

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m 12s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 46s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   2m 44s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 51s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   4m 39s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 40s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 11s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 56s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 13s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m 13s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   5m  0s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 44s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m 45s |  hbase-common in the patch passed.  
|
   | +1 :green_heart: |  unit  | 221m  5s |  hbase-server in the patch passed.  
|
   |  |   | 245m 26s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4730/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4730 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 7c23709f1b83 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 
23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 92cf962fee |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4730/4/testReport/
 |
   | Max. process+thread count | 2601 (vs. ulimit of 3) |
   | modules | C: hbase-common hbase-server U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4730/4/console 
|
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #4730: HBASE-27321 The ReplicationLogCleaner is not thread safe but can be c…

2022-08-26 Thread GitBox


Apache-HBase commented on PR #4730:
URL: https://github.com/apache/hbase/pull/4730#issuecomment-1228228288

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m  4s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 13s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   2m 38s |  master passed  |
   | +1 :green_heart: |  compile  |   1m  5s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   3m 48s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 44s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 14s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 34s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m  6s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m  6s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   3m 50s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 43s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   2m  7s |  hbase-common in the patch passed.  
|
   | +1 :green_heart: |  unit  | 217m  7s |  hbase-server in the patch passed.  
|
   |  |   | 239m 11s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4730/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4730 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux e8dab7eaaa97 5.4.0-122-generic #138-Ubuntu SMP Wed Jun 22 
15:00:31 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 92cf962fee |
   | Default Java | AdoptOpenJDK-11.0.10+9 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4730/4/testReport/
 |
   | Max. process+thread count | 2724 (vs. ulimit of 3) |
   | modules | C: hbase-common hbase-server U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4730/4/console 
|
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #4731: HBASE-27332 Remove RejectedExecutionHandler for long/short compaction…

2022-08-26 Thread GitBox


Apache-HBase commented on PR #4731:
URL: https://github.com/apache/hbase/pull/4731#issuecomment-1228180943

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m 49s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 38s |  master passed  |
   | +1 :green_heart: |  compile  |   3m 54s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   0m 49s |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 58s |  branch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   2m 16s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 27s |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m 26s |  the patch passed  |
   | +1 :green_heart: |  javac  |   3m 26s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   0m 38s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  hadoopcheck  |  12m 50s |  Patch does not cause any 
errors with Hadoop 3.2.4 3.3.4.  |
   | +1 :green_heart: |  spotless  |   0m 51s |  patch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   2m  9s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 14s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  44m 27s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4731/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4731 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
spotless checkstyle compile |
   | uname | Linux 6accef09dd8d 5.4.0-122-generic #138-Ubuntu SMP Wed Jun 22 
15:00:31 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 92cf962fee |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   | Max. process+thread count | 62 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4731/1/console 
|
   | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #4727: HBASE-27317 : Storefiletracking : Rectifying the option for columnfamily as mandatory

2022-08-26 Thread GitBox


Apache-HBase commented on PR #4727:
URL: https://github.com/apache/hbase/pull/4727#issuecomment-1228170047

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m  2s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 48s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 47s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   3m 49s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 28s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 41s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 48s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 48s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   3m 47s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 26s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  | 210m 18s |  hbase-server in the patch passed.  
|
   |  |   | 228m 28s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4727/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4727 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 7fc4b7e4a593 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 
02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 92cf962fee |
   | Default Java | AdoptOpenJDK-11.0.10+9 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4727/2/testReport/
 |
   | Max. process+thread count | 2586 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4727/2/console 
|
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #4727: HBASE-27317 : Storefiletracking : Rectifying the option for columnfamily as mandatory

2022-08-26 Thread GitBox


Apache-HBase commented on PR #4727:
URL: https://github.com/apache/hbase/pull/4727#issuecomment-1228165822

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 39s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 21s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 37s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   4m  0s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 22s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m  6s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 34s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 34s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   4m  1s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 22s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  | 207m 26s |  hbase-server in the patch passed.  
|
   |  |   | 224m 16s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4727/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4727 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 5e0aed24bc7f 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 
23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 92cf962fee |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4727/2/testReport/
 |
   | Max. process+thread count | 2563 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4727/2/console 
|
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #4725: HBASE-27152 Under compaction mark may leak

2022-08-26 Thread GitBox


Apache-HBase commented on PR #4725:
URL: https://github.com/apache/hbase/pull/4725#issuecomment-1228151216

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 23s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 26s |  master passed  |
   | +1 :green_heart: |  compile  |   2m 15s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   0m 32s |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 40s |  branch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   1m 19s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 15s |  the patch passed  |
   | +1 :green_heart: |  compile  |   2m 12s |  the patch passed  |
   | +1 :green_heart: |  javac  |   2m 12s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   0m 30s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  hadoopcheck  |   7m 59s |  Patch does not cause any 
errors with Hadoop 3.2.4 3.3.4.  |
   | +1 :green_heart: |  spotless  |   0m 39s |  patch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   1m 23s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 10s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  27m 39s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4725/2/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4725 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
spotless checkstyle compile |
   | uname | Linux 3abf9db45550 5.4.0-109-generic #123-Ubuntu SMP Fri Apr 8 
09:10:54 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 92cf962fee |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   | Max. process+thread count | 64 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4725/2/console 
|
   | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] sunhelly opened a new pull request, #4731: HBASE-27332 Remove RejectedExecutionHandler for long/short compaction…

2022-08-26 Thread GitBox


sunhelly opened a new pull request, #4731:
URL: https://github.com/apache/hbase/pull/4731

   … thread pools


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Assigned] (HBASE-27332) Remove RejectedExecutionHandler for long/short compaction thread pools

2022-08-26 Thread Xiaolin Ha (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-27332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Xiaolin Ha reassigned HBASE-27332:
--

Assignee: Xiaolin Ha

> Remove RejectedExecutionHandler for long/short compaction thread pools
> --
>
> Key: HBASE-27332
> URL: https://issues.apache.org/jira/browse/HBASE-27332
> Project: HBase
>  Issue Type: Improvement
>  Components: Compaction
>Affects Versions: 3.0.0-alpha-3, 2.4.13
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Minor
> Fix For: 2.6.0, 3.0.0-alpha-4
>
>
> As disscussed in https://github.com/apache/hbase/pull/4725
> actually the max size of StealJobQueue is bouded by the VM limit of an array, 
> and the OOM exception occurs before the rejection handler. So StealJobQueue 
> is equivalent to be unbounded. I think the RejectionHandler may bring some 
> confusions and make the codes a little puzzle.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (HBASE-27332) Remove RejectedExecutionHandler for long/short compaction thread pools

2022-08-26 Thread Xiaolin Ha (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-27332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Xiaolin Ha updated HBASE-27332:
---
Summary: Remove RejectedExecutionHandler for long/short compaction thread 
pools  (was: Remove RejectedExecutionHandler for long/short compaction thread 
pool)

> Remove RejectedExecutionHandler for long/short compaction thread pools
> --
>
> Key: HBASE-27332
> URL: https://issues.apache.org/jira/browse/HBASE-27332
> Project: HBase
>  Issue Type: Improvement
>  Components: Compaction
>Affects Versions: 3.0.0-alpha-3, 2.4.13
>Reporter: Xiaolin Ha
>Priority: Minor
> Fix For: 2.6.0, 3.0.0-alpha-4
>
>
> As disscussed in https://github.com/apache/hbase/pull/4725
> actually the max size of StealJobQueue is bouded by the VM limit of an array, 
> and the OOM exception occurs before the rejection handler. So StealJobQueue 
> is equivalent to be unbounded. I think the RejectionHandler may bring some 
> confusions and make the codes a little puzzle.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (HBASE-27332) Remove RejectedExecutionHandler for long/short compaction thread pool

2022-08-26 Thread Xiaolin Ha (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-27332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Xiaolin Ha updated HBASE-27332:
---
Description: 
As disscussed in https://github.com/apache/hbase/pull/4725

actually the max size of StealJobQueue is bouded by the VM limit of an array, 
and the OOM exception occurs before the rejection handler. So StealJobQueue is 
equivalent to be unbounded. I think the RejectionHandler may bring some 
confusions and make the codes a little puzzle.

  was:
As disscussed in 
[https://github.com/apache/hbase/pull/4725|https://github.com/apache/hbase/pull/4725,],

actually the max size of StealJobQueue is bouded by the VM limit of an array, 
and the OOM exception occurs before the rejection handler. So StealJobQueue is 
equivalent to be unbounded. I think the RejectionHandler may bring some 
confusions and make the codes a little puzzle.


> Remove RejectedExecutionHandler for long/short compaction thread pool
> -
>
> Key: HBASE-27332
> URL: https://issues.apache.org/jira/browse/HBASE-27332
> Project: HBase
>  Issue Type: Improvement
>  Components: Compaction
>Affects Versions: 3.0.0-alpha-3, 2.4.13
>Reporter: Xiaolin Ha
>Priority: Minor
> Fix For: 2.6.0, 3.0.0-alpha-4
>
>
> As disscussed in https://github.com/apache/hbase/pull/4725
> actually the max size of StealJobQueue is bouded by the VM limit of an array, 
> and the OOM exception occurs before the rejection handler. So StealJobQueue 
> is equivalent to be unbounded. I think the RejectionHandler may bring some 
> confusions and make the codes a little puzzle.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (HBASE-27332) Remove RejectedExecutionHandler for long/short compaction thread pool

2022-08-26 Thread Xiaolin Ha (Jira)
Xiaolin Ha created HBASE-27332:
--

 Summary: Remove RejectedExecutionHandler for long/short compaction 
thread pool
 Key: HBASE-27332
 URL: https://issues.apache.org/jira/browse/HBASE-27332
 Project: HBase
  Issue Type: Improvement
  Components: Compaction
Affects Versions: 2.4.13, 3.0.0-alpha-3
Reporter: Xiaolin Ha
 Fix For: 2.6.0, 3.0.0-alpha-4


As disscussed in 
[https://github.com/apache/hbase/pull/4725|https://github.com/apache/hbase/pull/4725,],

actually the max size of StealJobQueue is bouded by the VM limit of an array, 
and the OOM exception occurs before the rejection handler. So StealJobQueue is 
equivalent to be unbounded. I think the RejectionHandler may bring some 
confusions and make the codes a little puzzle.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (HBASE-27331) fix typo: docs of StealJobQueue

2022-08-26 Thread Xiaolin Ha (Jira)
Xiaolin Ha created HBASE-27331:
--

 Summary: fix typo: docs of StealJobQueue
 Key: HBASE-27331
 URL: https://issues.apache.org/jira/browse/HBASE-27331
 Project: HBase
  Issue Type: Improvement
  Components: documentation
Affects Versions: 2.4.13, 3.0.0-alpha-3
Reporter: Xiaolin Ha
 Fix For: 2.6.0


{code:java}
* steal-from queue if this q ueue is empty. {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [hbase] sunhelly commented on a diff in pull request #4725: HBASE-27152 Under compaction mark may leak

2022-08-26 Thread GitBox


sunhelly commented on code in PR #4725:
URL: https://github.com/apache/hbase/pull/4725#discussion_r955709921


##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplit.java:
##
@@ -382,15 +381,20 @@ protected void requestCompactionInternal(HRegion region, 
HStore store, String wh
   // pool; we will do selection there, and move to large pool if necessary.
   pool = shortCompactions;
 }
-pool.execute(
-  new CompactionRunner(store, region, compaction, tracker, 
completeTracker, pool, user));
+
+// A simple implementation for under compaction marks.
+// Since this method is always called in the synchronized methods, we do 
not need to use the
+// boolean result to make sure that exactly the one that added here will 
be removed
+// in the next steps.
+underCompactionStores.add(getStoreNameForUnderCompaction(store));

Review Comment:
   Yes, the compaction mark adding and removing operations are in different 
threads, we can't avoid the latter removing thread excuting faster than the 
former adding thread. Let the marks be added before the compaction runner tasks 
be added to the thread pool can keep the correct order.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (HBASE-27325) the bulkload max call queue size can be update to a wrong value

2022-08-26 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17585179#comment-17585179
 ] 

Hudson commented on HBASE-27325:


Results for branch branch-2
[build #627 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/627/]: 
(/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/627/General_20Nightly_20Build_20Report/]


(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/627/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/627/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/627/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> the bulkload max call queue size can be update to a wrong value
> ---
>
> Key: HBASE-27325
> URL: https://issues.apache.org/jira/browse/HBASE-27325
> Project: HBase
>  Issue Type: Bug
>  Components: IPC/RPC
>Affects Versions: 3.0.0-alpha-3
>Reporter: ruanhui
>Assignee: ruanhui
>Priority: Minor
> Fix For: 2.6.0, 3.0.0-alpha-4
>
>
> The configKey can be wrong, because 
> name.toLowerCase(Locale.ROOT).contains("bulkLoad") is always false.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [hbase] sunhelly commented on a diff in pull request #4725: HBASE-27152 Under compaction mark may leak

2022-08-26 Thread GitBox


sunhelly commented on code in PR #4725:
URL: https://github.com/apache/hbase/pull/4725#discussion_r955705347


##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplit.java:
##
@@ -145,15 +144,15 @@ private void createCompactionExecutors() {
 final String n = Thread.currentThread().getName();
 
 StealJobQueue stealJobQueue = new 
StealJobQueue(COMPARATOR);
+// Since the StealJobQueue is unbounded, we need not to set the 
RejectedExecutionHandler for

Review Comment:
   Actually the max size of StealJobQueue is bouded by the VM limit of an 
array, and the OOM exception occurs before the rejection handler. So 
StealJobQueue is equivalent to be unbounded. I think the RejectionHandler may 
bring some confusions and make the codes a little puzzle. 
   I will seperate the removing the rejection handler here in another issue. 
Thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org