[jira] [Commented] (HBASE-27758) Inconsistent synchronization in MetricsUserSourceImpl
[
https://issues.apache.org/jira/browse/HBASE-27758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707504#comment-17707504
]
Hudson commented on HBASE-27758:
Results for branch branch-2
[build #783 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/783/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/783/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/783/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/783/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/783/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Inconsistent synchronization in MetricsUserSourceImpl
> -
>
> Key: HBASE-27758
> URL: https://issues.apache.org/jira/browse/HBASE-27758
> Project: HBase
> Issue Type: Improvement
>Reporter: Bryan Beaudreault
>Assignee: Bryan Beaudreault
>Priority: Major
> Labels: patch-available
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.4.17, 2.5.4
>
>
> Picked up by spotbugs:
>
> ||Code||Warning||
> |IS|Inconsistent synchronization of
> org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl.appendHisto;
> locked 50% of time|
> | |[Bug type IS2_INCONSISTENT_SYNC (click for
> details)|https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/7/artifact/yetus-general-check/output/new-spotbugs-hbase-hadoop-compat.html#IS2_INCONSISTENT_SYNC]
> In class org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl
> Field org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl.appendHisto
> Synchronized 50% of the time
> Unsynchronized access at MetricsUserSourceImpl.java:[line 253]
> Synchronized access at MetricsUserSourceImpl.java:[line 146]|
> |IS|Inconsistent synchronization of
> org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl.getHisto; locked
> 50% of time|
> | |[Bug type IS2_INCONSISTENT_SYNC (click for
> details)|https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/7/artifact/yetus-general-check/output/new-spotbugs-hbase-hadoop-compat.html#IS2_INCONSISTENT_SYNC]
> In class org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl
> Field org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl.getHisto
> Synchronized 50% of the time
> Unsynchronized access at MetricsUserSourceImpl.java:[line 241]
> Synchronized access at MetricsUserSourceImpl.java:[line 141]|
> |IS|Inconsistent synchronization of
> org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl.incrementHisto;
> locked 50% of time|
> | |[Bug type IS2_INCONSISTENT_SYNC (click for
> details)|https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/7/artifact/yetus-general-check/output/new-spotbugs-hbase-hadoop-compat.html#IS2_INCONSISTENT_SYNC]
> In class org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl
> Field
> org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl.incrementHisto
> Synchronized 50% of the time
> Unsynchronized access at MetricsUserSourceImpl.java:[line 247]
> Synchronized access at MetricsUserSourceImpl.java:[line 145]|
> |IS|Inconsistent synchronization of
> org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl.scanTimeHisto;
> locked 50% of time|
> | |[Bug type IS2_INCONSISTENT_SYNC (click for
> details)|https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/7/artifact/yetus-general-check/output/new-spotbugs-hbase-hadoop-compat.html#IS2_INCONSISTENT_SYNC]
> In class org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl
> Field org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl.scanTimeHisto
> Synchronized 50% of the time
> Unsynchronized access at MetricsUserSourceImpl.java:[line 264]
> Synchronized access at MetricsUserSourceImpl.java:[line 142]|
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27769) Use hasPathCapability to support recoverLease, setSafeMode, isFileClosed for non-HDFS file system
[ https://issues.apache.org/jira/browse/HBASE-27769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707489#comment-17707489 ] Duo Zhang commented on HBASE-27769: --- Will HADOOP-18671 be applied to all branches? > Use hasPathCapability to support recoverLease, setSafeMode, isFileClosed for > non-HDFS file system > - > > Key: HBASE-27769 > URL: https://issues.apache.org/jira/browse/HBASE-27769 > Project: HBase > Issue Type: Improvement >Affects Versions: 3.0.0-alpha-3, 2.4.16, 2.5.3 >Reporter: Tak-Lon (Stephen) Wu >Assignee: Tak-Lon (Stephen) Wu >Priority: Major > > after HADOOP-18671 , we will change the hbase-asyncfs to use use > hasPathCapability to support recoverLease, setSafeMode, isFileClosed for > non-HDFS file system instead of directly casting only HDFS in > RecoverLeaseFSUtils -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-27759) Release 2.4.17
[ https://issues.apache.org/jira/browse/HBASE-27759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707470#comment-17707470 ] Tak-Lon (Stephen) Wu commented on HBASE-27759: -- sent vote for 2.4.17RC0 > Release 2.4.17 > -- > > Key: HBASE-27759 > URL: https://issues.apache.org/jira/browse/HBASE-27759 > Project: HBase > Issue Type: Umbrella > Components: community >Reporter: Duo Zhang >Assignee: Tak-Lon (Stephen) Wu >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (HBASE-27772) Add 2.4.17 to download page
Tak-Lon (Stephen) Wu created HBASE-27772: Summary: Add 2.4.17 to download page Key: HBASE-27772 URL: https://issues.apache.org/jira/browse/HBASE-27772 Project: HBase Issue Type: Sub-task Components: website Reporter: Tak-Lon (Stephen) Wu Assignee: Tak-Lon (Stephen) Wu need a PR to add rel/2.4.17 to download page. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (HBASE-27771) Put up 2.4.17RC0
Tak-Lon (Stephen) Wu created HBASE-27771: Summary: Put up 2.4.17RC0 Key: HBASE-27771 URL: https://issues.apache.org/jira/browse/HBASE-27771 Project: HBase Issue Type: Sub-task Reporter: Tak-Lon (Stephen) Wu Assignee: Tak-Lon (Stephen) Wu send out vote for 2.4.17RC0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (HBASE-27770) Complete Release 2.4.17
Tak-Lon (Stephen) Wu created HBASE-27770: Summary: Complete Release 2.4.17 Key: HBASE-27770 URL: https://issues.apache.org/jira/browse/HBASE-27770 Project: HBase Issue Type: Sub-task Reporter: Tak-Lon (Stephen) Wu Assignee: Tak-Lon (Stephen) Wu # Release the artifacts on repository.apache.org # Move the binaries from dist-dev to dist-release # Add xml to download page # Push tag 2.4.17RC0 as tag rel/2.4.17 # Release 2.4.17 on JIRA https://issues.apache.org/jira/projects/HBASE/versions/12352760 # Add release data on [https://reporter.apache.org/addrelease.html?hbase] # Send announcement email -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work started] (HBASE-27759) Release 2.4.17
[ https://issues.apache.org/jira/browse/HBASE-27759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-27759 started by Tak-Lon (Stephen) Wu. > Release 2.4.17 > -- > > Key: HBASE-27759 > URL: https://issues.apache.org/jira/browse/HBASE-27759 > Project: HBase > Issue Type: Umbrella > Components: community >Reporter: Duo Zhang >Assignee: Tak-Lon (Stephen) Wu >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (HBASE-27604) Release 2.4.16
[ https://issues.apache.org/jira/browse/HBASE-27604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu resolved HBASE-27604. -- Resolution: Fixed > Release 2.4.16 > -- > > Key: HBASE-27604 > URL: https://issues.apache.org/jira/browse/HBASE-27604 > Project: HBase > Issue Type: Umbrella > Components: community >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (HBASE-27612) Push 2.4.16 release out
[ https://issues.apache.org/jira/browse/HBASE-27612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu resolved HBASE-27612. -- Resolution: Fixed > Push 2.4.16 release out > --- > > Key: HBASE-27612 > URL: https://issues.apache.org/jira/browse/HBASE-27612 > Project: HBase > Issue Type: Sub-task > Components: community >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > > # Release the artifacts on repository.apache.org > # Move the binaries from dist-dev to dist-release > # Add to download page, which is tracked by HBASE-27610 as it requires code > change > # Push tag 2.4.16RC1 as tag rel/2.4.16 > # Release 2.4.16 on jira > # Add release data on https://reporter.apache.org/addrelease.html?hbase > # Send announcement email -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-27604) Release 2.4.16
[ https://issues.apache.org/jira/browse/HBASE-27604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707469#comment-17707469 ] Tak-Lon (Stephen) Wu commented on HBASE-27604: -- closing it as 2.4.16 has released. > Release 2.4.16 > -- > > Key: HBASE-27604 > URL: https://issues.apache.org/jira/browse/HBASE-27604 > Project: HBase > Issue Type: Umbrella > Components: community >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (HBASE-27751) [hbase-operator-tools] TestMissingTableDescriptorGenerator fails with HBase 2.5.3
[
https://issues.apache.org/jira/browse/HBASE-27751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707441#comment-17707441
]
Rajeshbabu Chintaguntla edited comment on HBASE-27751 at 3/31/23 11:14 PM:
---
Committed to master. Thanks for the patch [~nihaljain.cs]. Thanks for review
[~wchevreuil].
was (Author: rajeshbabu):
Committed to master. Thanks for the patch [~nihaljain.cs].
> [hbase-operator-tools] TestMissingTableDescriptorGenerator fails with HBase
> 2.5.3
> -
>
> Key: HBASE-27751
> URL: https://issues.apache.org/jira/browse/HBASE-27751
> Project: HBase
> Issue Type: Bug
> Components: hbase-operator-tools
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Minor
> Fix For: hbase-operator-tools-1.3.0
>
>
> hbase-operator-tools fails to compile against hbase 2.5.3 with following test
> failures.
> {code:java}
> [INFO] Running org.apache.hbase.TestMissingTableDescriptorGenerator
> [ERROR] Tests run: 3, Failures: 0, Errors: 3, Skipped: 0, Time elapsed:
> 30.149 s <<< FAILURE! - in
> org.apache.hbase.TestMissingTableDescriptorGenerator
> [ERROR]
> testTableinfoGeneratedWhenNoTableSpecified(org.apache.hbase.TestMissingTableDescriptorGenerator)
> Time elapsed: 16.734 s <<< ERROR!
> java.lang.IllegalArgumentException:
> hdfs://localhost:51882/user/nihaljain/test-data/de8af727-6c02-7a95-9beb-027d18fc6603/data/default/test-1/.tabledesc/.tableinfo.01.639
> at
> org.apache.hbase.TestMissingTableDescriptorGenerator.testTableinfoGeneratedWhenNoTableSpecified(TestMissingTableDescriptorGenerator.java:145)
> [ERROR]
> shouldGenerateTableInfoBasedOnFileSystem(org.apache.hbase.TestMissingTableDescriptorGenerator)
> Time elapsed: 6.794 s <<< ERROR!
> java.lang.IllegalArgumentException:
> hdfs://localhost:51961/user/nihaljain/test-data/5ade0aa1-cb9a-a1da-b700-fe808eeda3b9/data/default/test-1/.tabledesc/.tableinfo.01.666
> at
> org.apache.hbase.TestMissingTableDescriptorGenerator.shouldGenerateTableInfoBasedOnFileSystem(TestMissingTableDescriptorGenerator.java:120)
> [ERROR]
> shouldGenerateTableInfoBasedOnCachedTableDescriptor(org.apache.hbase.TestMissingTableDescriptorGenerator)
> Time elapsed: 6.621 s <<< ERROR!
> java.lang.IllegalArgumentException:
> hdfs://localhost:52022/user/nihaljain/test-data/d858258b-6ba1-8e4f-c118-4e30d8a5136f/data/default/test-1/.tabledesc/.tableinfo.01.666
> at
> org.apache.hbase.TestMissingTableDescriptorGenerator.shouldGenerateTableInfoBasedOnCachedTableDescriptor(TestMissingTableDescriptorGenerator.java:107)
> {code}
> Steps to reproduce, run following against hbase-operator-tools master:
> {code:java}
> mvn clean install -Dhbase.version=2.5.3 -Dhbase-thirdparty.version=4.1.4
> {code}
> The goal is to allow hbase-operator-tools to compile with hbase 2.5.3 without
> any failures
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (HBASE-27751) [hbase-operator-tools] TestMissingTableDescriptorGenerator fails with HBase 2.5.3
[
https://issues.apache.org/jira/browse/HBASE-27751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rajeshbabu Chintaguntla resolved HBASE-27751.
-
Fix Version/s: hbase-operator-tools-1.3.0
Resolution: Fixed
Committed to master. Thanks for the patch [~nihaljain.cs].
> [hbase-operator-tools] TestMissingTableDescriptorGenerator fails with HBase
> 2.5.3
> -
>
> Key: HBASE-27751
> URL: https://issues.apache.org/jira/browse/HBASE-27751
> Project: HBase
> Issue Type: Bug
> Components: hbase-operator-tools
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Minor
> Fix For: hbase-operator-tools-1.3.0
>
>
> hbase-operator-tools fails to compile against hbase 2.5.3 with following test
> failures.
> {code:java}
> [INFO] Running org.apache.hbase.TestMissingTableDescriptorGenerator
> [ERROR] Tests run: 3, Failures: 0, Errors: 3, Skipped: 0, Time elapsed:
> 30.149 s <<< FAILURE! - in
> org.apache.hbase.TestMissingTableDescriptorGenerator
> [ERROR]
> testTableinfoGeneratedWhenNoTableSpecified(org.apache.hbase.TestMissingTableDescriptorGenerator)
> Time elapsed: 16.734 s <<< ERROR!
> java.lang.IllegalArgumentException:
> hdfs://localhost:51882/user/nihaljain/test-data/de8af727-6c02-7a95-9beb-027d18fc6603/data/default/test-1/.tabledesc/.tableinfo.01.639
> at
> org.apache.hbase.TestMissingTableDescriptorGenerator.testTableinfoGeneratedWhenNoTableSpecified(TestMissingTableDescriptorGenerator.java:145)
> [ERROR]
> shouldGenerateTableInfoBasedOnFileSystem(org.apache.hbase.TestMissingTableDescriptorGenerator)
> Time elapsed: 6.794 s <<< ERROR!
> java.lang.IllegalArgumentException:
> hdfs://localhost:51961/user/nihaljain/test-data/5ade0aa1-cb9a-a1da-b700-fe808eeda3b9/data/default/test-1/.tabledesc/.tableinfo.01.666
> at
> org.apache.hbase.TestMissingTableDescriptorGenerator.shouldGenerateTableInfoBasedOnFileSystem(TestMissingTableDescriptorGenerator.java:120)
> [ERROR]
> shouldGenerateTableInfoBasedOnCachedTableDescriptor(org.apache.hbase.TestMissingTableDescriptorGenerator)
> Time elapsed: 6.621 s <<< ERROR!
> java.lang.IllegalArgumentException:
> hdfs://localhost:52022/user/nihaljain/test-data/d858258b-6ba1-8e4f-c118-4e30d8a5136f/data/default/test-1/.tabledesc/.tableinfo.01.666
> at
> org.apache.hbase.TestMissingTableDescriptorGenerator.shouldGenerateTableInfoBasedOnCachedTableDescriptor(TestMissingTableDescriptorGenerator.java:107)
> {code}
> Steps to reproduce, run following against hbase-operator-tools master:
> {code:java}
> mvn clean install -Dhbase.version=2.5.3 -Dhbase-thirdparty.version=4.1.4
> {code}
> The goal is to allow hbase-operator-tools to compile with hbase 2.5.3 without
> any failures
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [hbase-operator-tools] chrajeshbabu merged pull request #113: HBASE-27751 TestMissingTableDescriptorGenerator fails with HBase 2.5.3
chrajeshbabu merged PR #113: URL: https://github.com/apache/hbase-operator-tools/pull/113 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-27769) Use hasPathCapability to support recoverLease, setSafeMode, isFileClosed for non-HDFS file system
[ https://issues.apache.org/jira/browse/HBASE-27769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu updated HBASE-27769: - Description: after HADOOP-18671 , we will change the hbase-asyncfs to use use hasPathCapability to support recoverLease, setSafeMode, isFileClosed for non-HDFS file system instead of directly casting only HDFS in RecoverLeaseFSUtils > Use hasPathCapability to support recoverLease, setSafeMode, isFileClosed for > non-HDFS file system > - > > Key: HBASE-27769 > URL: https://issues.apache.org/jira/browse/HBASE-27769 > Project: HBase > Issue Type: Improvement >Affects Versions: 3.0.0-alpha-3, 2.4.16, 2.5.3 >Reporter: Tak-Lon (Stephen) Wu >Assignee: Tak-Lon (Stephen) Wu >Priority: Major > > after HADOOP-18671 , we will change the hbase-asyncfs to use use > hasPathCapability to support recoverLease, setSafeMode, isFileClosed for > non-HDFS file system instead of directly casting only HDFS in > RecoverLeaseFSUtils -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27769) Use hasPathCapability to support recoverLease, setSafeMode, isFileClosed for non-HDFS file system
[ https://issues.apache.org/jira/browse/HBASE-27769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu updated HBASE-27769: - Affects Version/s: 2.5.3 2.4.16 3.0.0-alpha-3 > Use hasPathCapability to support recoverLease, setSafeMode, isFileClosed for > non-HDFS file system > - > > Key: HBASE-27769 > URL: https://issues.apache.org/jira/browse/HBASE-27769 > Project: HBase > Issue Type: Improvement >Affects Versions: 3.0.0-alpha-3, 2.4.16, 2.5.3 >Reporter: Tak-Lon (Stephen) Wu >Assignee: Tak-Lon (Stephen) Wu >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (HBASE-27769) Use hasPathCapability to support recoverLease, setSafeMode, isFileClosed for non-HDFS file system
Tak-Lon (Stephen) Wu created HBASE-27769: Summary: Use hasPathCapability to support recoverLease, setSafeMode, isFileClosed for non-HDFS file system Key: HBASE-27769 URL: https://issues.apache.org/jira/browse/HBASE-27769 Project: HBase Issue Type: Improvement Reporter: Tak-Lon (Stephen) Wu Assignee: Tak-Lon (Stephen) Wu -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (HBASE-27740) Support Ozone as a WAL backing storage
[ https://issues.apache.org/jira/browse/HBASE-27740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu reassigned HBASE-27740: Assignee: Tak-Lon (Stephen) Wu > Support Ozone as a WAL backing storage > -- > > Key: HBASE-27740 > URL: https://issues.apache.org/jira/browse/HBASE-27740 > Project: HBase > Issue Type: New Feature >Reporter: Wei-Chiu Chuang >Assignee: Tak-Lon (Stephen) Wu >Priority: Major > > As discussed in the > [thread|https://lists.apache.org/thread/tcrp8vxxs3z12y36mpzx35txhpp7tvxv], > we'd like to make HBase workloads possible on Ozone. > This feature is to be built on top of > # HDDS-7593 (support hsync and lease recovery in Ozone), and > # HADOOP-18671 (Add recoverLease(), setSafeMode(), isFileClosed() APIs to > FileSystem). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] Apache-HBase commented on pull request #5144: HBASE-27693 Support for Hadoop's LDAP Authentication mechanism
Apache-HBase commented on PR #5144: URL: https://github.com/apache/hbase/pull/5144#issuecomment-1492674418 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 5m 2s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 49s | master passed | | +1 :green_heart: | compile | 1m 36s | master passed | | +1 :green_heart: | shadedjars | 4m 17s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 34s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 50s | the patch passed | | +1 :green_heart: | compile | 1m 35s | the patch passed | | +1 :green_heart: | javac | 1m 35s | the patch passed | | +1 :green_heart: | shadedjars | 4m 24s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 35s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 356m 38s | root in the patch passed. | | | | 389m 12s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5144 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 135f2c31c0f5 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 143e9b4ff6 | | Default Java | Temurin-1.8.0_352-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/4/testReport/ | | Max. process+thread count | 4434 (vs. ulimit of 3) | | modules | C: hbase-http . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/4/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5144: HBASE-27693 Support for Hadoop's LDAP Authentication mechanism
Apache-HBase commented on PR #5144: URL: https://github.com/apache/hbase/pull/5144#issuecomment-1492615997 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 14s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 2s | master passed | | +1 :green_heart: | compile | 2m 19s | master passed | | +1 :green_heart: | shadedjars | 5m 40s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 42s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 56s | the patch passed | | +1 :green_heart: | compile | 2m 33s | the patch passed | | +1 :green_heart: | javac | 2m 33s | the patch passed | | +1 :green_heart: | shadedjars | 5m 53s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 55s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 283m 48s | root in the patch passed. | | | | 324m 11s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5144 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux badbf42f615c 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 143e9b4ff6 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/4/testReport/ | | Max. process+thread count | 4566 (vs. ulimit of 3) | | modules | C: hbase-http . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/4/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5155: HBASE-27536: add Scan to slow log payload
Apache-HBase commented on PR #5155: URL: https://github.com/apache/hbase/pull/5155#issuecomment-1492611561 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 11s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 6m 12s | master passed | | +1 :green_heart: | compile | 3m 8s | master passed | | +1 :green_heart: | shadedjars | 6m 7s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 26s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 25s | Maven dependency ordering for patch | | -1 :x: | mvninstall | 2m 12s | root in the patch failed. | | -1 :x: | compile | 0m 27s | hbase-client in the patch failed. | | -1 :x: | compile | 1m 1s | hbase-server in the patch failed. | | -0 :warning: | javac | 0m 27s | hbase-client in the patch failed. | | -0 :warning: | javac | 1m 1s | hbase-server in the patch failed. | | -1 :x: | shadedjars | 3m 27s | patch has 32 errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 21s | hbase-client generated 7 new + 44 unchanged - 0 fixed = 51 total (was 44) | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 56s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 3m 12s | hbase-common in the patch passed. | | -1 :x: | unit | 0m 17s | hbase-client in the patch failed. | | -1 :x: | unit | 0m 38s | hbase-server in the patch failed. | | | | 40m 15s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5155/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5155 | | JIRA Issue | HBASE-27536 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux cc96fc22c549 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 143e9b4ff6 | | Default Java | Eclipse Adoptium-11.0.17+8 | | mvninstall | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5155/1/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt | | compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5155/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-client.txt | | compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5155/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5155/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-client.txt | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5155/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt | | shadedjars | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5155/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt | | javadoc | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5155/1/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-client.txt | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5155/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-client.txt | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5155/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5155/1/testReport/ | | Max. process+thread count | 195 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-common hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5155/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries
[GitHub] [hbase] Apache-HBase commented on pull request #5155: HBASE-27536: add Scan to slow log payload
Apache-HBase commented on PR #5155: URL: https://github.com/apache/hbase/pull/5155#issuecomment-1492599377 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | prototool | 0m 0s | prototool was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 28s | master passed | | +1 :green_heart: | compile | 4m 4s | master passed | | +1 :green_heart: | checkstyle | 1m 3s | master passed | | +1 :green_heart: | spotless | 0m 41s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 4m 30s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch | | -1 :x: | mvninstall | 0m 51s | root in the patch failed. | | -1 :x: | compile | 0m 14s | hbase-client in the patch failed. | | -1 :x: | compile | 0m 24s | hbase-server in the patch failed. | | -0 :warning: | cc | 0m 14s | hbase-client in the patch failed. | | -0 :warning: | cc | 0m 24s | hbase-server in the patch failed. | | -0 :warning: | javac | 0m 14s | hbase-client in the patch failed. | | -0 :warning: | javac | 0m 24s | hbase-server in the patch failed. | | +1 :green_heart: | checkstyle | 0m 58s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | -1 :x: | hadoopcheck | 0m 59s | The patch causes 32 errors with Hadoop v3.2.4. | | -1 :x: | hadoopcheck | 2m 1s | The patch causes 32 errors with Hadoop v3.3.4. | | -1 :x: | hbaseprotoc | 0m 13s | hbase-client in the patch failed. | | -1 :x: | hbaseprotoc | 0m 25s | hbase-server in the patch failed. | | +1 :green_heart: | spotless | 0m 36s | patch has no errors when running spotless:check. | | -1 :x: | spotbugs | 0m 14s | hbase-client in the patch failed. | | -1 :x: | spotbugs | 0m 19s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 26s | The patch does not generate ASF License warnings. | | | | 28m 16s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5155/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5155 | | JIRA Issue | HBASE-27536 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool | | uname | Linux 5311b9756798 5.4.0-1093-aws #102~18.04.2-Ubuntu SMP Wed Dec 7 00:31:59 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 143e9b4ff6 | | Default Java | Eclipse Adoptium-11.0.17+8 | | mvninstall | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5155/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt | | compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5155/1/artifact/yetus-general-check/output/patch-compile-hbase-client.txt | | compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5155/1/artifact/yetus-general-check/output/patch-compile-hbase-server.txt | | cc | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5155/1/artifact/yetus-general-check/output/patch-compile-hbase-client.txt | | cc | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5155/1/artifact/yetus-general-check/output/patch-compile-hbase-server.txt | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5155/1/artifact/yetus-general-check/output/patch-compile-hbase-client.txt | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5155/1/artifact/yetus-general-check/output/patch-compile-hbase-server.txt | | hadoopcheck | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5155/1/artifact/yetus-general-check/output/patch-javac-3.2.4.txt | | hadoopcheck | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5155/1/artifact/yetus-general-check/output/patch-javac-3.3.4.txt | | hbaseprotoc |
[GitHub] [hbase] Apache-HBase commented on pull request #5155: HBASE-27536: add Scan to slow log payload
Apache-HBase commented on PR #5155: URL: https://github.com/apache/hbase/pull/5155#issuecomment-1492595954 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 19s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 16s | master passed | | +1 :green_heart: | compile | 1m 53s | master passed | | +1 :green_heart: | shadedjars | 5m 34s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 5s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | -1 :x: | mvninstall | 0m 53s | root in the patch failed. | | -1 :x: | compile | 0m 19s | hbase-client in the patch failed. | | -1 :x: | compile | 0m 34s | hbase-server in the patch failed. | | -0 :warning: | javac | 0m 19s | hbase-client in the patch failed. | | -0 :warning: | javac | 0m 34s | hbase-server in the patch failed. | | -1 :x: | shadedjars | 2m 30s | patch has 32 errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 20s | hbase-client generated 7 new + 30 unchanged - 0 fixed = 37 total (was 30) | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 26s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 1m 55s | hbase-common in the patch passed. | | -1 :x: | unit | 0m 20s | hbase-client in the patch failed. | | -1 :x: | unit | 0m 31s | hbase-server in the patch failed. | | | | 24m 27s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5155/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5155 | | JIRA Issue | HBASE-27536 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux fc0c29524f96 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 143e9b4ff6 | | Default Java | Temurin-1.8.0_352-b08 | | mvninstall | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5155/1/artifact/yetus-jdk8-hadoop3-check/output/patch-mvninstall-root.txt | | compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5155/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-client.txt | | compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5155/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5155/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-client.txt | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5155/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt | | shadedjars | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5155/1/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt | | javadoc | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5155/1/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-client.txt | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5155/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-client.txt | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5155/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5155/1/testReport/ | | Max. process+thread count | 162 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-common hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5155/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this
[GitHub] [hbase] rmdmattingly opened a new pull request, #5155: HBASE-27536: add Scan to slow log payload
rmdmattingly opened a new pull request, #5155: URL: https://github.com/apache/hbase/pull/5155 [HBASE-27536](https://issues.apache.org/jira/browse/HBASE-27536) Currently slow logs only includes a barebones text format of the underlying protobuf Message fields. Gets and Puts are relatively straightforward from a query cost perspective, but the configuration of Scans can have very significant performance implications. With that in mind, we think it would be valuable to include the JSON representation of a given Scan to the slow log that it may produce. cc @bbeaudreault @virajjasani -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4799: HBASE-27389 Add cost function in balancer to consider the cost of bui…
Apache-HBase commented on PR #4799: URL: https://github.com/apache/hbase/pull/4799#issuecomment-1492402531 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 24s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 9s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 49s | master passed | | +1 :green_heart: | compile | 2m 38s | master passed | | +1 :green_heart: | shadedjars | 4m 39s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 6s | master passed | | -0 :warning: | patch | 6m 16s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 14s | the patch passed | | +1 :green_heart: | compile | 1m 55s | the patch passed | | +1 :green_heart: | javac | 1m 55s | the patch passed | | +1 :green_heart: | shadedjars | 4m 29s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 6s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 32s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 2m 0s | hbase-common in the patch passed. | | +1 :green_heart: | unit | 1m 23s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 12m 5s | hbase-balancer in the patch passed. | | +1 :green_heart: | unit | 201m 40s | hbase-server in the patch passed. | | | | 247m 13s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4799/15/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4799 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 72ff7edd3c45 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 143e9b4ff6 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4799/15/testReport/ | | Max. process+thread count | 2703 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-common hbase-client hbase-balancer hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4799/15/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4799: HBASE-27389 Add cost function in balancer to consider the cost of bui…
Apache-HBase commented on PR #4799: URL: https://github.com/apache/hbase/pull/4799#issuecomment-1492398138 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 2s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 39s | master passed | | +1 :green_heart: | compile | 1m 38s | master passed | | +1 :green_heart: | shadedjars | 4m 34s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 0s | master passed | | -0 :warning: | patch | 6m 4s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 40s | the patch passed | | +1 :green_heart: | compile | 1m 37s | the patch passed | | +1 :green_heart: | javac | 1m 37s | the patch passed | | +1 :green_heart: | shadedjars | 4m 32s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 1s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 24s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 1m 41s | hbase-common in the patch passed. | | +1 :green_heart: | unit | 1m 7s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 9m 53s | hbase-balancer in the patch passed. | | +1 :green_heart: | unit | 204m 14s | hbase-server in the patch passed. | | | | 242m 39s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4799/15/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4799 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 23280f0d1d2a 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 143e9b4ff6 | | Default Java | Temurin-1.8.0_352-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4799/15/testReport/ | | Max. process+thread count | 2514 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-common hbase-client hbase-balancer hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4799/15/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5110: HBASE-27720 TestClusterRestartFailover is flakey due to metrics assertion
Apache-HBase commented on PR #5110: URL: https://github.com/apache/hbase/pull/5110#issuecomment-1492343859 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 59s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 35s | master passed | | +1 :green_heart: | compile | 0m 47s | master passed | | +1 :green_heart: | shadedjars | 4m 26s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 27s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 24s | the patch passed | | +1 :green_heart: | compile | 0m 45s | the patch passed | | +1 :green_heart: | javac | 0m 45s | the patch passed | | +1 :green_heart: | shadedjars | 4m 24s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 26s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 216m 1s | hbase-server in the patch passed. | | | | 240m 36s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5110/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5110 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 2511f107aa50 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 143e9b4ff6 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5110/2/testReport/ | | Max. process+thread count | 2457 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5110/2/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5110: HBASE-27720 TestClusterRestartFailover is flakey due to metrics assertion
Apache-HBase commented on PR #5110: URL: https://github.com/apache/hbase/pull/5110#issuecomment-1492334939 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 2s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 1s | master passed | | +1 :green_heart: | compile | 0m 39s | master passed | | +1 :green_heart: | shadedjars | 4m 15s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 24s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 49s | the patch passed | | +1 :green_heart: | compile | 0m 39s | the patch passed | | +1 :green_heart: | javac | 0m 39s | the patch passed | | +1 :green_heart: | shadedjars | 4m 18s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 23s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 214m 16s | hbase-server in the patch failed. | | | | 236m 3s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5110/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5110 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux c0ba7bb23dec 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 143e9b4ff6 | | Default Java | Temurin-1.8.0_352-b08 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5110/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5110/2/testReport/ | | Max. process+thread count | 2402 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5110/2/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5144: HBASE-27693 Support for Hadoop's LDAP Authentication mechanism
Apache-HBase commented on PR #5144: URL: https://github.com/apache/hbase/pull/5144#issuecomment-1492259945 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 54s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 19s | master passed | | +1 :green_heart: | compile | 4m 42s | master passed | | +1 :green_heart: | checkstyle | 1m 1s | master passed | | +0 :ok: | refguide | 2m 13s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | spotless | 0m 40s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 7m 26s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 13s | the patch passed | | +1 :green_heart: | compile | 4m 45s | the patch passed | | -0 :warning: | javac | 4m 45s | root generated 2 new + 908 unchanged - 0 fixed = 910 total (was 908) | | -0 :warning: | checkstyle | 1m 6s | root: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +0 :ok: | refguide | 2m 10s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | hadoopcheck | 11m 55s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | spotless | 0m 41s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 7m 45s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 18s | The patch does not generate ASF License warnings. | | | | 60m 2s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/4/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5144 | | Optional Tests | dupname asflicense javac hadoopcheck spotless xml compile spotbugs hbaseanti checkstyle refguide | | uname | Linux 8b115e85e78a 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 143e9b4ff6 | | Default Java | Eclipse Adoptium-11.0.17+8 | | refguide | https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5144/4/yetus-general-check/output/branch-site/book.html | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/4/artifact/yetus-general-check/output/diff-compile-javac-root.txt | | checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/4/artifact/yetus-general-check/output/diff-checkstyle-root.txt | | refguide | https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5144/4/yetus-general-check/output/patch-site/book.html | | Max. process+thread count | 177 (vs. ulimit of 3) | | modules | C: hbase-http . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/4/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5144: HBASE-27693 Support for Hadoop's LDAP Authentication mechanism
Apache-HBase commented on PR #5144: URL: https://github.com/apache/hbase/pull/5144#issuecomment-1492178478 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 5s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 6s | master passed | | +1 :green_heart: | compile | 2m 37s | master passed | | +1 :green_heart: | shadedjars | 5m 21s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 56s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 19s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 5s | the patch passed | | +1 :green_heart: | compile | 2m 29s | the patch passed | | +1 :green_heart: | javac | 2m 29s | the patch passed | | +1 :green_heart: | shadedjars | 5m 34s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 26s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 310m 36s | root in the patch failed. | | | | 350m 11s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5144 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 6950b50f468e 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / e5620e26a2 | | Default Java | Eclipse Adoptium-11.0.17+8 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/3/testReport/ | | Max. process+thread count | 2605 (vs. ulimit of 3) | | modules | C: hbase-http . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/3/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-27744) Update compression dependencies
[ https://issues.apache.org/jira/browse/HBASE-27744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707312#comment-17707312 ] Andrew Kyle Purtell commented on HBASE-27744: - The fix version for 2.4 is incorrect, sorry about that. Fixed it. The compression work only went as far back as 2.5. > Update compression dependencies > --- > > Key: HBASE-27744 > URL: https://issues.apache.org/jira/browse/HBASE-27744 > Project: HBase > Issue Type: Improvement > Components: io >Reporter: Andrew Kyle Purtell >Assignee: Andrew Kyle Purtell >Priority: Minor > Fix For: 2.6.0, 3.0.0-alpha-4, 2.5.4 > > > Update compression codec dependencies: > - aircompressor 0.21 -> 0.24 > - brotli4j 1.8.0 -> 1.11.0 > - snappy 1.1.8.4 -> 1.1.9.1 > - zstd-jni 1.5.0-4 -> 1.5.4-2 > and add a new supplemental model for new brotli4j dependency. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27744) Update compression dependencies
[ https://issues.apache.org/jira/browse/HBASE-27744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-27744: Fix Version/s: (was: 2.4.17) > Update compression dependencies > --- > > Key: HBASE-27744 > URL: https://issues.apache.org/jira/browse/HBASE-27744 > Project: HBase > Issue Type: Improvement > Components: io >Reporter: Andrew Kyle Purtell >Assignee: Andrew Kyle Purtell >Priority: Minor > Fix For: 2.6.0, 3.0.0-alpha-4, 2.5.4 > > > Update compression codec dependencies: > - aircompressor 0.21 -> 0.24 > - brotli4j 1.8.0 -> 1.11.0 > - snappy 1.1.8.4 -> 1.1.9.1 > - zstd-jni 1.5.0-4 -> 1.5.4-2 > and add a new supplemental model for new brotli4j dependency. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] Apache-HBase commented on pull request #4799: HBASE-27389 Add cost function in balancer to consider the cost of bui…
Apache-HBase commented on PR #4799: URL: https://github.com/apache/hbase/pull/4799#issuecomment-1492071971 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | prototool | 0m 0s | prototool was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 19s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 29s | master passed | | +1 :green_heart: | compile | 4m 23s | master passed | | +1 :green_heart: | checkstyle | 1m 10s | master passed | | +1 :green_heart: | spotless | 0m 40s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 5m 2s | master passed | | -0 :warning: | patch | 1m 49s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 9s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 28s | the patch passed | | +1 :green_heart: | compile | 4m 22s | the patch passed | | +1 :green_heart: | cc | 4m 22s | the patch passed | | +1 :green_heart: | javac | 4m 22s | the patch passed | | +1 :green_heart: | checkstyle | 1m 11s | the patch passed | | +1 :green_heart: | whitespace | 0m 1s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 13m 38s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | hbaseprotoc | 1m 55s | the patch passed | | +1 :green_heart: | spotless | 0m 40s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 5m 42s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 36s | The patch does not generate ASF License warnings. | | | | 56m 5s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4799/15/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4799 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool | | uname | Linux d8e008c1e858 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 143e9b4ff6 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Max. process+thread count | 83 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-common hbase-client hbase-balancer hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4799/15/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5110: HBASE-27720 TestClusterRestartFailover is flakey due to metrics assertion
Apache-HBase commented on PR #5110: URL: https://github.com/apache/hbase/pull/5110#issuecomment-1491992698 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 33s | master passed | | +1 :green_heart: | compile | 2m 22s | master passed | | +1 :green_heart: | checkstyle | 0m 34s | master passed | | +1 :green_heart: | spotless | 0m 41s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 24s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 13s | the patch passed | | +1 :green_heart: | compile | 2m 21s | the patch passed | | +1 :green_heart: | javac | 2m 21s | the patch passed | | +1 :green_heart: | checkstyle | 0m 31s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 12m 38s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | spotless | 0m 52s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 2m 1s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 12s | The patch does not generate ASF License warnings. | | | | 39m 35s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5110/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5110 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 0de3642b6d1c 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 143e9b4ff6 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Max. process+thread count | 86 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5110/2/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-27758) Inconsistent synchronization in MetricsUserSourceImpl
[ https://issues.apache.org/jira/browse/HBASE-27758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Beaudreault updated HBASE-27758: -- Fix Version/s: 2.6.0 3.0.0-alpha-4 2.4.17 2.5.4 Resolution: Fixed Status: Resolved (was: Patch Available) > Inconsistent synchronization in MetricsUserSourceImpl > - > > Key: HBASE-27758 > URL: https://issues.apache.org/jira/browse/HBASE-27758 > Project: HBase > Issue Type: Improvement >Reporter: Bryan Beaudreault >Assignee: Bryan Beaudreault >Priority: Major > Labels: patch-available > Fix For: 2.6.0, 3.0.0-alpha-4, 2.4.17, 2.5.4 > > > Picked up by spotbugs: > > ||Code||Warning|| > |IS|Inconsistent synchronization of > org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl.appendHisto; > locked 50% of time| > | |[Bug type IS2_INCONSISTENT_SYNC (click for > details)|https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/7/artifact/yetus-general-check/output/new-spotbugs-hbase-hadoop-compat.html#IS2_INCONSISTENT_SYNC] > In class org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl > Field org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl.appendHisto > Synchronized 50% of the time > Unsynchronized access at MetricsUserSourceImpl.java:[line 253] > Synchronized access at MetricsUserSourceImpl.java:[line 146]| > |IS|Inconsistent synchronization of > org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl.getHisto; locked > 50% of time| > | |[Bug type IS2_INCONSISTENT_SYNC (click for > details)|https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/7/artifact/yetus-general-check/output/new-spotbugs-hbase-hadoop-compat.html#IS2_INCONSISTENT_SYNC] > In class org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl > Field org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl.getHisto > Synchronized 50% of the time > Unsynchronized access at MetricsUserSourceImpl.java:[line 241] > Synchronized access at MetricsUserSourceImpl.java:[line 141]| > |IS|Inconsistent synchronization of > org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl.incrementHisto; > locked 50% of time| > | |[Bug type IS2_INCONSISTENT_SYNC (click for > details)|https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/7/artifact/yetus-general-check/output/new-spotbugs-hbase-hadoop-compat.html#IS2_INCONSISTENT_SYNC] > In class org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl > Field > org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl.incrementHisto > Synchronized 50% of the time > Unsynchronized access at MetricsUserSourceImpl.java:[line 247] > Synchronized access at MetricsUserSourceImpl.java:[line 145]| > |IS|Inconsistent synchronization of > org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl.scanTimeHisto; > locked 50% of time| > | |[Bug type IS2_INCONSISTENT_SYNC (click for > details)|https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/7/artifact/yetus-general-check/output/new-spotbugs-hbase-hadoop-compat.html#IS2_INCONSISTENT_SYNC] > In class org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl > Field org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl.scanTimeHisto > Synchronized 50% of the time > Unsynchronized access at MetricsUserSourceImpl.java:[line 264] > Synchronized access at MetricsUserSourceImpl.java:[line 142]| -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] Apache-HBase commented on pull request #4720: HBASE-27315 Add timeout to JavaRegexEngine
Apache-HBase commented on PR #4720: URL: https://github.com/apache/hbase/pull/4720#issuecomment-1491954815 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 58s | master passed | | +1 :green_heart: | compile | 0m 49s | master passed | | +1 :green_heart: | shadedjars | 4m 28s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 33s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 41s | the patch passed | | +1 :green_heart: | compile | 0m 49s | the patch passed | | +1 :green_heart: | javac | 0m 49s | the patch passed | | +1 :green_heart: | shadedjars | 4m 30s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 33s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 59s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 204m 27s | hbase-server in the patch passed. | | | | 227m 56s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4720/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4720 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux f412e5605a87 5.4.0-1097-aws #105~18.04.1-Ubuntu SMP Mon Feb 13 17:50:57 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / e5620e26a2 | | Default Java | Temurin-1.8.0_352-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4720/3/testReport/ | | Max. process+thread count | 2486 (vs. ulimit of 3) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4720/3/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] NihalJain commented on a diff in pull request #5144: HBASE-27693 Support for Hadoop's LDAP Authentication mechanism
NihalJain commented on code in PR #5144: URL: https://github.com/apache/hbase/pull/5144#discussion_r1154470258 ## hbase-http/src/main/java/org/apache/hadoop/hbase/http/lib/AuthenticationFilterInitializer.java: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hbase.http.lib; + +import java.io.IOException; +import java.util.HashMap; +import java.util.Map; +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.hbase.HBaseInterfaceAudience; +import org.apache.hadoop.hbase.http.FilterContainer; +import org.apache.hadoop.hbase.http.FilterInitializer; +import org.apache.hadoop.hbase.http.HttpServer; +import org.apache.hadoop.security.SecurityUtil; +import org.apache.hadoop.security.authentication.server.AuthenticationFilter; +import org.apache.hadoop.security.authentication.server.KerberosAuthenticationHandler; +import org.apache.yetus.audience.InterfaceAudience; + +/** Review Comment: Not sure whether we need to mention a note saying this class is copied from hadoop. Others can comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ndimiduk commented on a diff in pull request #5110: HBASE-27720 TestClusterRestartFailover is flakey due to metrics assertion
ndimiduk commented on code in PR #5110:
URL: https://github.com/apache/hbase/pull/5110#discussion_r1154477215
##
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestClusterRestartFailover.java:
##
@@ -131,10 +132,17 @@ public void test() throws Exception {
.getServerNode(SERVER_FOR_TEST);
assertNull("serverNode should be deleted after SCP finished", serverNode);
+// this test has been flakey. When it is rerun by surefire, the underlying
minicluster isn't
Review Comment:
Posted a new patch that (I think) will reset the master metrics each time
the mini cluster is started.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] NihalJain commented on a diff in pull request #5144: HBASE-27693 Support for Hadoop's LDAP Authentication mechanism
NihalJain commented on code in PR #5144:
URL: https://github.com/apache/hbase/pull/5144#discussion_r1154472009
##
hbase-http/src/test/java/org/apache/hadoop/hbase/http/TestLdapHttpServer.java:
##
@@ -0,0 +1,157 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.http;
+
+import static org.junit.Assert.assertEquals;
+
+import java.io.IOException;
+import java.net.HttpURLConnection;
+import java.net.URL;
+import org.apache.commons.codec.binary.Base64;
+import org.apache.directory.server.annotations.CreateLdapServer;
+import org.apache.directory.server.annotations.CreateTransport;
+import org.apache.directory.server.core.annotations.ApplyLdifs;
+import org.apache.directory.server.core.annotations.ContextEntry;
+import org.apache.directory.server.core.annotations.CreateDS;
+import org.apache.directory.server.core.annotations.CreatePartition;
+import org.apache.directory.server.core.integ.CreateLdapServerRule;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.http.resource.JerseyResource;
+import org.apache.hadoop.hbase.testclassification.MiscTests;
+import org.apache.hadoop.hbase.testclassification.SmallTests;
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * This class defines the constants used by the LDAP integration tests.
+ */
+final class LdapConstants {
+
+ /**
+ * This class defines constants to be used for LDAP integration testing.
Hence this class is not
+ * expected to be instantiated.
+ */
+ private LdapConstants() {
+ }
+
+ public static final String LDAP_BASE_DN = "dc=example,dc=com";
Review Comment:
Can we please either keep these variables inside TestLdapHttpServer or
extract the constants class outside?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] NihalJain commented on a diff in pull request #5144: HBASE-27693 Support for Hadoop's LDAP Authentication mechanism
NihalJain commented on code in PR #5144: URL: https://github.com/apache/hbase/pull/5144#discussion_r1154470258 ## hbase-http/src/main/java/org/apache/hadoop/hbase/http/lib/AuthenticationFilterInitializer.java: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hbase.http.lib; + +import java.io.IOException; +import java.util.HashMap; +import java.util.Map; +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.hbase.HBaseInterfaceAudience; +import org.apache.hadoop.hbase.http.FilterContainer; +import org.apache.hadoop.hbase.http.FilterInitializer; +import org.apache.hadoop.hbase.http.HttpServer; +import org.apache.hadoop.security.SecurityUtil; +import org.apache.hadoop.security.authentication.server.AuthenticationFilter; +import org.apache.hadoop.security.authentication.server.KerberosAuthenticationHandler; +import org.apache.yetus.audience.InterfaceAudience; + +/** Review Comment: Not sure whether we need to mention a note saying this class is copied from hadoop though. Others can comment. ## hbase-http/src/main/java/org/apache/hadoop/hbase/http/lib/AuthenticationFilterInitializer.java: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hbase.http.lib; + +import java.io.IOException; +import java.util.HashMap; +import java.util.Map; +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.hbase.HBaseInterfaceAudience; +import org.apache.hadoop.hbase.http.FilterContainer; +import org.apache.hadoop.hbase.http.FilterInitializer; +import org.apache.hadoop.hbase.http.HttpServer; +import org.apache.hadoop.security.SecurityUtil; +import org.apache.hadoop.security.authentication.server.AuthenticationFilter; +import org.apache.hadoop.security.authentication.server.KerberosAuthenticationHandler; +import org.apache.yetus.audience.InterfaceAudience; + +/** + * Initializes hadoop-auth AuthenticationFilter which provides support for Kerberos HTTP SPNEGO + * authentication. + * + * It enables anonymous access, simple/pseudo and Kerberos HTTP SPNEGO authentication for Hadoop Review Comment: The java doc looks out of place here, since a copy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] NihalJain commented on a diff in pull request #5144: HBASE-27693 Support for Hadoop's LDAP Authentication mechanism
NihalJain commented on code in PR #5144: URL: https://github.com/apache/hbase/pull/5144#discussion_r1154468259 ## hbase-http/pom.xml: ## @@ -29,6 +29,11 @@ hbase-http Apache HBase - HTTP HTTP functionality for HBase Servers + + +2.0.0.AM26 Review Comment: Could we please move this to main pom? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ndimiduk commented on pull request #5145: HBASE-27762 Include EventType and ProcedureV2 pid in logging via MDC
ndimiduk commented on PR #5145: URL: https://github.com/apache/hbase/pull/5145#issuecomment-1491870114 Test failure is https://issues.apache.org/jira/browse/HBASE-27720 . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase-operator-tools] NihalJain commented on pull request #113: HBASE-27751 TestMissingTableDescriptorGenerator fails with HBase 2.5.3
NihalJain commented on PR #113: URL: https://github.com/apache/hbase-operator-tools/pull/113#issuecomment-1491858608 > @NihalJain @chrajeshbabu does this change break compatibility with versions < 2.5.3? If so, we should make it compatible with 2.4, at least. You can check HBCK2.checkHBCKSupport logic for an example on how to verify cluster version, so that depending on the version, we should use one regex or another. Hi @wchevreuil Thanks for having at look at this. As shown in the sample tests for regex below: - old regex: https://regex101.com/r/iJrOxD/1 - new regex: https://regex101.com/r/IKmASB/1 The new regex is an extension of old one, i.e. strings matching old regex, also match new regex. See samples in above links. So it would not break compatibility. Do you still want to to handle the based on versions? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bbeaudreault merged pull request #5149: HBASE-27758 Inconsistent synchronization in MetricsUserSourceImpl
bbeaudreault merged PR #5149: URL: https://github.com/apache/hbase/pull/5149 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5144: HBASE-27693 Support for Hadoop's LDAP Authentication mechanism
Apache-HBase commented on PR #5144: URL: https://github.com/apache/hbase/pull/5144#issuecomment-1491749093 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m 51s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 29s | master passed | | +1 :green_heart: | compile | 4m 41s | master passed | | +1 :green_heart: | checkstyle | 1m 1s | master passed | | +0 :ok: | refguide | 2m 42s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | spotless | 0m 41s | branch has no errors when running spotless:check. | | -1 :x: | spotbugs | 7m 13s | root in master has 4 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 18s | the patch passed | | +1 :green_heart: | compile | 4m 40s | the patch passed | | -0 :warning: | javac | 4m 40s | root generated 2 new + 908 unchanged - 0 fixed = 910 total (was 908) | | -0 :warning: | checkstyle | 1m 3s | root: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +0 :ok: | refguide | 2m 17s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | hadoopcheck | 12m 4s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | -1 :x: | spotless | 0m 8s | patch has 15 errors when running spotless:check, run spotless:apply to fix. | | +1 :green_heart: | spotbugs | 7m 43s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 22s | The patch does not generate ASF License warnings. | | | | 64m 20s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5144 | | Optional Tests | dupname asflicense javac hadoopcheck spotless xml compile spotbugs hbaseanti checkstyle refguide | | uname | Linux 2e665f9bb57d 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / e5620e26a2 | | Default Java | Eclipse Adoptium-11.0.17+8 | | refguide | https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5144/3/yetus-general-check/output/branch-site/book.html | | spotbugs | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/3/artifact/yetus-general-check/output/branch-spotbugs-root-warnings.html | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/3/artifact/yetus-general-check/output/diff-compile-javac-root.txt | | checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/3/artifact/yetus-general-check/output/diff-checkstyle-root.txt | | refguide | https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5144/3/yetus-general-check/output/patch-site/book.html | | spotless | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/3/artifact/yetus-general-check/output/patch-spotless.txt | | Max. process+thread count | 177 (vs. ulimit of 3) | | modules | C: hbase-http . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/3/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4720: HBASE-27315 Add timeout to JavaRegexEngine
Apache-HBase commented on PR #4720: URL: https://github.com/apache/hbase/pull/4720#issuecomment-1491718512 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 59s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 29s | master passed | | +1 :green_heart: | compile | 3m 0s | master passed | | +1 :green_heart: | checkstyle | 0m 52s | master passed | | +1 :green_heart: | spotless | 0m 43s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 2m 10s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 22s | the patch passed | | +1 :green_heart: | compile | 3m 2s | the patch passed | | +1 :green_heart: | javac | 3m 2s | the patch passed | | -0 :warning: | checkstyle | 0m 16s | hbase-client: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 12m 19s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | -1 :x: | spotless | 0m 18s | patch has 47 errors when running spotless:check, run spotless:apply to fix. | | +1 :green_heart: | spotbugs | 2m 27s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 20s | The patch does not generate ASF License warnings. | | | | 42m 7s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4720/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4720 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 426cddad618f 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / e5620e26a2 | | Default Java | Eclipse Adoptium-11.0.17+8 | | checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4720/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt | | spotless | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4720/3/artifact/yetus-general-check/output/patch-spotless.txt | | Max. process+thread count | 86 (vs. ulimit of 3) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4720/3/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (HBASE-27693) Support for Hadoop's LDAP Authentication mechanism
[ https://issues.apache.org/jira/browse/HBASE-27693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17705182#comment-17705182 ] Yash Dodeja edited comment on HBASE-27693 at 3/31/23 10:00 AM: --- In this patch, tried to bring in Hadoop's authentication filter initializer to HBase. This helps initialize AuthenticationFilter and use LdapAuthenticationHandler in the HBase ecosystem. Tried testing on a cluster after setting the following configurations in hbase-site: *hbase.security.authentication.ui = ldap* *hbase.http.filter.initializers* = *org.apache.hadoop.hbase.http.lib.AuthenticationFilterInitializer* Also, had to set the following hadoop related/inherited configurations in hbase-site: *hadoop.http.authentication.type = ldap* *hadoop.http.authentication.ldap.binddomain = EXAMPLE.COM* *hadoop.http.authentication.ldap.providerurl = ldap://ldap-server-host:8920* *hadoop.http.authentication.ldap.enablestarttls = false* Added the same in the Web Security documentation in the patch. On testing the above setup, observed that HBase Web UI shows a popup asking for LDAP login in order to access the UI. Also added unit test case to check working of AuthenticationFilter and added functionality test TestLdapHttpServer to check authentication scenarios. A screenshot for the same shown in Safari browser is attached: !Screenshot 2023-03-27 at 10.53.26 AM.png! was (Author: JIRAUSER299009): In this patch, tried to bring in Hadoop's authentication filter initializer to HBase. This helps initialize AuthenticationFilter and use LdapAuthenticationHandler in the HBase ecosystem. Tried testing on a cluster after setting the following configurations in hbase-site: *hbase.security.authentication.ui = ldap* *hbase.http.filter.initializers* = *org.apache.hadoop.hbase.http.AuthenticationFilterInitializer* Also, had to set the following hadoop related/inherited configurations in hbase-site: *hadoop.http.authentication.type = ldap* *hadoop.http.authentication.ldap.binddomain = EXAMPLE.COM* *hadoop.http.authentication.ldap.providerurl = ldap://ldap-server-host:8920* *hadoop.http.authentication.ldap.enablestarttls = false* Added the same in the Web Security documentation in the patch. On testing the above setup, observed that HBase Web UI shows a popup asking for LDAP login in order to access the UI. A screenshot for the same shown in Safari browser is attached: !Screenshot 2023-03-27 at 10.53.26 AM.png! > Support for Hadoop's LDAP Authentication mechanism > -- > > Key: HBASE-27693 > URL: https://issues.apache.org/jira/browse/HBASE-27693 > Project: HBase > Issue Type: New Feature >Reporter: Yash Dodeja >Assignee: Yash Dodeja >Priority: Major > Attachments: Screenshot 2023-03-27 at 10.53.26 AM.png > > > Hadoop's AuthenticationFilter has changed and now has support for ldap > mechanism too. HBase still uses an older version tightly coupled with > kerberos and spnego as the only auth mechanisms. HADOOP-12082 has added > support for multiple auth handlers including LDAP. On trying to use Hadoop's > AuthenticationFilterInitializer in hbase.http.filter.initializers, there is a > casting exception as HBase requires it to extend > org.apache.hadoop.hbase.http.FilterInitializer. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] mwkang commented on a diff in pull request #4720: HBASE-27315 Add timeout to JavaRegexEngine
mwkang commented on code in PR #4720:
URL: https://github.com/apache/hbase/pull/4720#discussion_r1154275598
##
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/TimeoutCharSequence.java:
##
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.filter;
+
+import org.apache.hadoop.hbase.DoNotRetryUncheckedIOException;
+import org.apache.hadoop.hbase.util.EnvironmentEdgeManager;
+import org.apache.hadoop.util.StringUtils;
+
+/**
+ * It checks whether the timeout has been exceeded whenever the charAt method
is called.
+ */
+class TimeoutCharSequence implements CharSequence {
+ private final CharSequence value;
+ private final long startMillis;
+ private final long timeoutMillis;
+
+ /**
+ * Initialize a TimeoutCharSequence.
+ * @param value the original data
+ * @param startMillis time the operation started (ms)
+ * @param timeoutMillis the timeout (ms)
+ */
+ TimeoutCharSequence(CharSequence value, long startMillis, long
timeoutMillis) {
+this.value = value;
+this.startMillis = startMillis;
+this.timeoutMillis = timeoutMillis;
+ }
+
+ @Override
+ public int length() {
+return value.length();
+ }
+
+ @Override
+ public char charAt(int index) {
+final long diff = EnvironmentEdgeManager.currentTime() - startMillis;
Review Comment:
@Apache9
I changed to not call System.currentTimeMillis every time.
Could you please check this PR again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4799: HBASE-27389 Add cost function in balancer to consider the cost of bui…
Apache-HBase commented on PR #4799: URL: https://github.com/apache/hbase/pull/4799#issuecomment-1491649853 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 24s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 5s | master passed | | +1 :green_heart: | compile | 1m 43s | master passed | | +1 :green_heart: | shadedjars | 4m 42s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 2s | master passed | | -0 :warning: | patch | 6m 15s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 46s | the patch passed | | +1 :green_heart: | compile | 1m 39s | the patch passed | | +1 :green_heart: | javac | 1m 39s | the patch passed | | +1 :green_heart: | shadedjars | 4m 37s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 1s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 23s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 1m 41s | hbase-common in the patch passed. | | +1 :green_heart: | unit | 1m 8s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 9m 50s | hbase-balancer in the patch passed. | | +1 :green_heart: | unit | 204m 16s | hbase-server in the patch passed. | | | | 243m 16s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4799/14/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4799 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 75f73591994c 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / e5620e26a2 | | Default Java | Temurin-1.8.0_352-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4799/14/testReport/ | | Max. process+thread count | 2683 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-common hbase-client hbase-balancer hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4799/14/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4799: HBASE-27389 Add cost function in balancer to consider the cost of bui…
Apache-HBase commented on PR #4799: URL: https://github.com/apache/hbase/pull/4799#issuecomment-1491644165 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 27s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 56s | master passed | | +1 :green_heart: | compile | 1m 56s | master passed | | +1 :green_heart: | shadedjars | 4m 33s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 5s | master passed | | -0 :warning: | patch | 6m 9s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 16s | the patch passed | | +1 :green_heart: | compile | 1m 57s | the patch passed | | +1 :green_heart: | javac | 1m 57s | the patch passed | | +1 :green_heart: | shadedjars | 4m 29s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 3s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 30s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 1m 56s | hbase-common in the patch passed. | | +1 :green_heart: | unit | 1m 18s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 9m 43s | hbase-balancer in the patch passed. | | +1 :green_heart: | unit | 196m 44s | hbase-server in the patch passed. | | | | 238m 30s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4799/14/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4799 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 0006a10edb96 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / e5620e26a2 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4799/14/testReport/ | | Max. process+thread count | 2616 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-common hbase-client hbase-balancer hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4799/14/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-27751) [hbase-operator-tools] TestMissingTableDescriptorGenerator fails with HBase 2.5.3
[
https://issues.apache.org/jira/browse/HBASE-27751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707219#comment-17707219
]
Rajeshbabu Chintaguntla commented on HBASE-27751:
-
[~wchevreuil] [~zhangduo]
The TABLEINFO_FILE_REGEX change done in the PR seems fine after HBASE-26690.
Just would like to hear from you before committing.
> [hbase-operator-tools] TestMissingTableDescriptorGenerator fails with HBase
> 2.5.3
> -
>
> Key: HBASE-27751
> URL: https://issues.apache.org/jira/browse/HBASE-27751
> Project: HBase
> Issue Type: Bug
> Components: hbase-operator-tools
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Minor
>
> hbase-operator-tools fails to compile against hbase 2.5.3 with following test
> failures.
> {code:java}
> [INFO] Running org.apache.hbase.TestMissingTableDescriptorGenerator
> [ERROR] Tests run: 3, Failures: 0, Errors: 3, Skipped: 0, Time elapsed:
> 30.149 s <<< FAILURE! - in
> org.apache.hbase.TestMissingTableDescriptorGenerator
> [ERROR]
> testTableinfoGeneratedWhenNoTableSpecified(org.apache.hbase.TestMissingTableDescriptorGenerator)
> Time elapsed: 16.734 s <<< ERROR!
> java.lang.IllegalArgumentException:
> hdfs://localhost:51882/user/nihaljain/test-data/de8af727-6c02-7a95-9beb-027d18fc6603/data/default/test-1/.tabledesc/.tableinfo.01.639
> at
> org.apache.hbase.TestMissingTableDescriptorGenerator.testTableinfoGeneratedWhenNoTableSpecified(TestMissingTableDescriptorGenerator.java:145)
> [ERROR]
> shouldGenerateTableInfoBasedOnFileSystem(org.apache.hbase.TestMissingTableDescriptorGenerator)
> Time elapsed: 6.794 s <<< ERROR!
> java.lang.IllegalArgumentException:
> hdfs://localhost:51961/user/nihaljain/test-data/5ade0aa1-cb9a-a1da-b700-fe808eeda3b9/data/default/test-1/.tabledesc/.tableinfo.01.666
> at
> org.apache.hbase.TestMissingTableDescriptorGenerator.shouldGenerateTableInfoBasedOnFileSystem(TestMissingTableDescriptorGenerator.java:120)
> [ERROR]
> shouldGenerateTableInfoBasedOnCachedTableDescriptor(org.apache.hbase.TestMissingTableDescriptorGenerator)
> Time elapsed: 6.621 s <<< ERROR!
> java.lang.IllegalArgumentException:
> hdfs://localhost:52022/user/nihaljain/test-data/d858258b-6ba1-8e4f-c118-4e30d8a5136f/data/default/test-1/.tabledesc/.tableinfo.01.666
> at
> org.apache.hbase.TestMissingTableDescriptorGenerator.shouldGenerateTableInfoBasedOnCachedTableDescriptor(TestMissingTableDescriptorGenerator.java:107)
> {code}
> Steps to reproduce, run following against hbase-operator-tools master:
> {code:java}
> mvn clean install -Dhbase.version=2.5.3 -Dhbase-thirdparty.version=4.1.4
> {code}
> The goal is to allow hbase-operator-tools to compile with hbase 2.5.3 without
> any failures
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [hbase] Apache-HBase commented on pull request #4799: HBASE-27389 Add cost function in balancer to consider the cost of bui…
Apache-HBase commented on PR #4799: URL: https://github.com/apache/hbase/pull/4799#issuecomment-1491393729 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | prototool | 0m 0s | prototool was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 30s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 51s | master passed | | +1 :green_heart: | compile | 4m 28s | master passed | | +1 :green_heart: | checkstyle | 1m 9s | master passed | | +1 :green_heart: | spotless | 0m 40s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 5m 3s | master passed | | -0 :warning: | patch | 1m 49s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 40s | the patch passed | | +1 :green_heart: | compile | 4m 23s | the patch passed | | +1 :green_heart: | cc | 4m 23s | the patch passed | | +1 :green_heart: | javac | 4m 23s | the patch passed | | +1 :green_heart: | checkstyle | 1m 8s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 13m 33s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | hbaseprotoc | 1m 55s | the patch passed | | +1 :green_heart: | spotless | 0m 40s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 5m 49s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 36s | The patch does not generate ASF License warnings. | | | | 56m 39s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4799/14/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4799 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool | | uname | Linux 59e793620f8d 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / e5620e26a2 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Max. process+thread count | 86 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-common hbase-client hbase-balancer hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4799/14/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
