Re: [PR] HBASE-28534 Fix Kerberos authentication failure in local mode [hbase-connectors]
Apache-HBase commented on PR #128: URL: https://github.com/apache/hbase-connectors/pull/128#issuecomment-2063018499 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 1m 28s | master passed | | +1 :green_heart: | compile | 0m 41s | master passed | | +1 :green_heart: | spotless | 0m 14s | branch has no errors when running spotless:check. | | +1 :green_heart: | scaladoc | 0m 49s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 0m 49s | the patch passed | | +1 :green_heart: | compile | 0m 40s | the patch passed | | +1 :green_heart: | scalac | 0m 40s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | spotless | 0m 12s | patch has no errors when running spotless:check. | | +1 :green_heart: | scaladoc | 0m 49s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 7m 57s | hbase-spark in the patch passed. | | | | 15m 3s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-128/1/artifact/yetus-precommit-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase-connectors/pull/128 | | Optional Tests | dupname scalac scaladoc unit spotless compile | | uname | Linux 9da0468d0d9e 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 GNU/Linux | | Build tool | hb_maven | | Personality | dev-support/jenkins/hbase-personality.sh | | git revision | master / 307607c | | Test Results | https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-128/1/testReport/ | | Max. process+thread count | 945 (vs. ulimit of 12500) | | modules | C: spark/hbase-spark U: spark/hbase-spark | | Console output | https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-128/1/console | | versions | git=2.20.1 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-28500) Rest Java client library assumes stateless servers
[
https://issues.apache.org/jira/browse/HBASE-28500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838457#comment-17838457
]
Hudson commented on HBASE-28500:
Results for branch branch-2.6
[build #96 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/96/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/96/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/96/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/96/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/96/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Rest Java client library assumes stateless servers
> --
>
> Key: HBASE-28500
> URL: https://issues.apache.org/jira/browse/HBASE-28500
> Project: HBase
> Issue Type: Bug
> Components: REST
>Reporter: Istvan Toth
>Assignee: Istvan Toth
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.6.0, 2.4.18, 4.0.0-alpha-1, 2.7.0, 3.0.0-beta-2, 2.5.9
>
>
> The Rest Java client library accepts a list of rest servers, and does random
> load balancing between them for each request.
> This does not work for scans, which do have state on the rest server instance.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (HBASE-28534) Authentication failure when running hbase-spark in local mode
[
https://issues.apache.org/jira/browse/HBASE-28534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Junegunn Choi updated HBASE-28534:
--
Description:
h2. Problem
When running Spark in local mode, hbase-spark fails to authenticate to a
Kerberos secured HBase cluster. The error message is:
{quote}No matching SASL authentication provider and supporting token found from
providers for user: x...@xxx.xxx (auth:PROXY)
{quote}
That is because {{applyCreds}} changes the authentication method of the current
user to {{{}PROXY{}}}, when it should still be {{KERBEROS}} for local mode to
run correctly.
h2. Suggested solution
To fix this, I propose removing {{{}applyCreds{}}}. The function is no longer
needed and should be removed:
1. Because we should not change the authentication mode of the current user in
local mode
2. And because the purpose of the function is no longer valid. It is not doing
anything meaningful since the broadcasting of the user credentials was removed
in this commit:
[https://github.com/apache/hbase-connectors/commit/75e41365207408f5b47d5925469a49fd60078b5e]
A pull request is on the way.
h2. Testing
The fix was manually tested against Kerberos secured HBase 2.4.17 + Hadoop
3.3.5 cluster using Spark 3.5.1, both in local mode and with Yarn master,
running the following Python code.
{code:java}
df = (spark.read.format("org.apache.hadoop.hbase.spark")
.option("hbase.columns.mapping", "key STRING :key, state STRING
info:state")
.option("hbase.table", "hbase:meta").load())
df.first()
{code}
was:
h2. Problem
When running Spark in local mode, hbase-spark fails to authenticate to a
Kerberos secured HBase cluster. The error message is:
{quote}No matching SASL authentication provider and supporting token found from
providers for user: x...@xxx.xxx (auth:PROXY)
{quote}
That is because {{applyCreds}} changes the authentication method of the current
user to {{{}PROXY{}}}, when it should still be {{KERBEROS}} for local mode to
run correctly.
h2. Suggested solution
To fix this, I propose removing {{{}applyCreds{}}}. The function is no longer
needed and should be removed:
1. Because we should not change the authentication mode of the current user in
local mode
2. And because the purpose of the function is no longer valid. It is not doing
anything meaningful since the broadcasting of the user credentials was removed
in this commit:
[https://github.com/apache/hbase-connectors/commit/75e41365207408f5b47d5925469a49fd60078b5e]
A pull request is on the way.
h2. Testing
The fix was manually tested against Kerberos secured HBase 2.4.17 + Hadoop
3.3.5 cluster and with Spark 3.5.1, both in local mode and with Yarn master,
running the following Python code.
{code:java}
df = (spark.read.format("org.apache.hadoop.hbase.spark")
.option("hbase.columns.mapping", "key STRING :key, state STRING
info:state")
.option("hbase.table", "hbase:meta").load())
df.first()
{code}
> Authentication failure when running hbase-spark in local mode
> -
>
> Key: HBASE-28534
> URL: https://issues.apache.org/jira/browse/HBASE-28534
> Project: HBase
> Issue Type: Bug
> Components: spark
>Affects Versions: connector-1.0.0
>Reporter: Junegunn Choi
>Assignee: Junegunn Choi
>Priority: Major
>
> h2. Problem
> When running Spark in local mode, hbase-spark fails to authenticate to a
> Kerberos secured HBase cluster. The error message is:
> {quote}No matching SASL authentication provider and supporting token found
> from providers for user: x...@xxx.xxx (auth:PROXY)
> {quote}
> That is because {{applyCreds}} changes the authentication method of the
> current user to {{{}PROXY{}}}, when it should still be {{KERBEROS}} for local
> mode to run correctly.
> h2. Suggested solution
> To fix this, I propose removing {{{}applyCreds{}}}. The function is no longer
> needed and should be removed:
> 1. Because we should not change the authentication mode of the current user
> in local mode
> 2. And because the purpose of the function is no longer valid. It is not
> doing anything meaningful since the broadcasting of the user credentials was
> removed in this commit:
> [https://github.com/apache/hbase-connectors/commit/75e41365207408f5b47d5925469a49fd60078b5e]
> A pull request is on the way.
> h2. Testing
> The fix was manually tested against Kerberos secured HBase 2.4.17 + Hadoop
> 3.3.5 cluster using Spark 3.5.1, both in local mode and with Yarn master,
> running the following Python code.
> {code:java}
> df = (spark.read.format("org.apache.hadoop.hbase.spark")
> .option("hbase.columns.mapping", "key STRING :key, state
> STRING info:state")
> .option("hbase.table", "hbase:meta").load())
> df.first()
>
[PR] HBASE-28534 Fix Kerberos authentication failure in local mode [hbase-connectors]
junegunn opened a new pull request, #128: URL: https://github.com/apache/hbase-connectors/pull/128 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work started] (HBASE-28534) Authentication failure when running hbase-spark in local mode
[
https://issues.apache.org/jira/browse/HBASE-28534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HBASE-28534 started by Junegunn Choi.
-
> Authentication failure when running hbase-spark in local mode
> -
>
> Key: HBASE-28534
> URL: https://issues.apache.org/jira/browse/HBASE-28534
> Project: HBase
> Issue Type: Bug
> Components: spark
>Affects Versions: connector-1.0.0
>Reporter: Junegunn Choi
>Assignee: Junegunn Choi
>Priority: Major
>
> h2. Problem
> When running Spark in local mode, hbase-spark fails to authenticate to a
> Kerberos secured HBase cluster. The error message is:
> {quote}No matching SASL authentication provider and supporting token found
> from providers for user: x...@xxx.xxx (auth:PROXY)
> {quote}
> That is because {{applyCreds}} changes the authentication method of the
> current user to {{{}PROXY{}}}, when it should still be {{KERBEROS}} for local
> mode to run correctly.
> h2. Suggested solution
> To fix this, I propose removing {{{}applyCreds{}}}. The function is no longer
> needed and should be removed:
> 1. Because we should not change the authentication mode of the current user
> in local mode
> 2. And because the purpose of the function is no longer valid. It is not
> doing anything meaningful since the broadcasting of the user credentials was
> removed in this commit:
> [https://github.com/apache/hbase-connectors/commit/75e41365207408f5b47d5925469a49fd60078b5e]
> A pull request is on the way.
> h2. Testing
> The fix was manually tested against Kerberos secured HBase 2.4.17 + Hadoop
> 3.3.5 cluster and with Spark 3.5.1, both in local mode and with Yarn master,
> running the following Python code.
> {code:java}
> df = (spark.read.format("org.apache.hadoop.hbase.spark")
> .option("hbase.columns.mapping", "key STRING :key, state
> STRING info:state")
> .option("hbase.table", "hbase:meta").load())
> df.first()
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (HBASE-28534) Authentication failure when running hbase-spark in local mode
Junegunn Choi created HBASE-28534:
-
Summary: Authentication failure when running hbase-spark in local
mode
Key: HBASE-28534
URL: https://issues.apache.org/jira/browse/HBASE-28534
Project: HBase
Issue Type: Bug
Components: spark
Affects Versions: connector-1.0.0
Reporter: Junegunn Choi
h2. Problem
When running Spark in local mode, hbase-spark fails to authenticate to a
Kerberos secured HBase cluster. The error message is:
{quote}No matching SASL authentication provider and supporting token found from
providers for user: x...@xxx.xxx (auth:PROXY)
{quote}
That is because {{applyCreds}} changes the authentication method of the current
user to {{{}PROXY{}}}, when it should still be {{KERBEROS}} for local mode to
run correctly.
h2. Suggested solution
To fix this, I propose removing {{{}applyCreds{}}}. The function is no longer
needed and should be removed:
1. Because we should not change the authentication mode of the current user in
local mode
2. And because the purpose of the function is no longer valid. It is not doing
anything meaningful since the broadcasting of the user credentials was removed
in this commit:
[https://github.com/apache/hbase-connectors/commit/75e41365207408f5b47d5925469a49fd60078b5e]
A pull request is on the way.
h2. Testing
The fix was manually tested against Kerberos secured HBase 2.4.17 + Hadoop
3.3.5 cluster and with Spark 3.5.1, both in local mode and with Yarn master,
running the following Python code.
{code:java}
df = (spark.read.format("org.apache.hadoop.hbase.spark")
.option("hbase.columns.mapping", "key STRING :key, state STRING
info:state")
.option("hbase.table", "hbase:meta").load())
df.first()
{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (HBASE-28534) Authentication failure when running hbase-spark in local mode
[
https://issues.apache.org/jira/browse/HBASE-28534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Junegunn Choi reassigned HBASE-28534:
-
Assignee: Junegunn Choi
> Authentication failure when running hbase-spark in local mode
> -
>
> Key: HBASE-28534
> URL: https://issues.apache.org/jira/browse/HBASE-28534
> Project: HBase
> Issue Type: Bug
> Components: spark
>Affects Versions: connector-1.0.0
>Reporter: Junegunn Choi
>Assignee: Junegunn Choi
>Priority: Major
>
> h2. Problem
> When running Spark in local mode, hbase-spark fails to authenticate to a
> Kerberos secured HBase cluster. The error message is:
> {quote}No matching SASL authentication provider and supporting token found
> from providers for user: x...@xxx.xxx (auth:PROXY)
> {quote}
> That is because {{applyCreds}} changes the authentication method of the
> current user to {{{}PROXY{}}}, when it should still be {{KERBEROS}} for local
> mode to run correctly.
> h2. Suggested solution
> To fix this, I propose removing {{{}applyCreds{}}}. The function is no longer
> needed and should be removed:
> 1. Because we should not change the authentication mode of the current user
> in local mode
> 2. And because the purpose of the function is no longer valid. It is not
> doing anything meaningful since the broadcasting of the user credentials was
> removed in this commit:
> [https://github.com/apache/hbase-connectors/commit/75e41365207408f5b47d5925469a49fd60078b5e]
> A pull request is on the way.
> h2. Testing
> The fix was manually tested against Kerberos secured HBase 2.4.17 + Hadoop
> 3.3.5 cluster and with Spark 3.5.1, both in local mode and with Yarn master,
> running the following Python code.
> {code:java}
> df = (spark.read.format("org.apache.hadoop.hbase.spark")
> .option("hbase.columns.mapping", "key STRING :key, state
> STRING info:state")
> .option("hbase.table", "hbase:meta").load())
> df.first()
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-28500) Rest Java client library assumes stateless servers
[
https://issues.apache.org/jira/browse/HBASE-28500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838454#comment-17838454
]
Hudson commented on HBASE-28500:
Results for branch branch-2.4
[build #720 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/720/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/720/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/720/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/720/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/720/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Rest Java client library assumes stateless servers
> --
>
> Key: HBASE-28500
> URL: https://issues.apache.org/jira/browse/HBASE-28500
> Project: HBase
> Issue Type: Bug
> Components: REST
>Reporter: Istvan Toth
>Assignee: Istvan Toth
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.6.0, 2.4.18, 4.0.0-alpha-1, 2.7.0, 3.0.0-beta-2, 2.5.9
>
>
> The Rest Java client library accepts a list of rest servers, and does random
> load balancing between them for each request.
> This does not work for scans, which do have state on the rest server instance.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] HBASE-28529 Use ZKClientConfig instead of system properties when sett… [hbase]
Apache-HBase commented on PR #5835: URL: https://github.com/apache/hbase/pull/5835#issuecomment-2062966692 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 22s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 59s | master passed | | +1 :green_heart: | compile | 1m 7s | master passed | | +1 :green_heart: | shadedjars | 7m 1s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 1s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 32s | the patch passed | | +1 :green_heart: | compile | 1m 20s | the patch passed | | +1 :green_heart: | javac | 1m 20s | the patch passed | | +1 :green_heart: | shadedjars | 7m 24s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 21s | hbase-zookeeper generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0) | ||| _ Other Tests _ | | +1 :green_heart: | unit | 3m 36s | hbase-common in the patch passed. | | +1 :green_heart: | unit | 1m 53s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 0m 49s | hbase-zookeeper in the patch passed. | | | | 37m 51s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5835/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5835 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 7d9884ccc817 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d7f9ba6548 | | Default Java | Eclipse Adoptium-17.0.10+7 | | javadoc | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5835/1/artifact/yetus-jdk17-hadoop3-check/output/diff-javadoc-javadoc-hbase-zookeeper.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5835/1/testReport/ | | Max. process+thread count | 389 (vs. ulimit of 3) | | modules | C: hbase-common hbase-client hbase-zookeeper U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5835/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28529 Use ZKClientConfig instead of system properties when sett… [hbase]
Apache-HBase commented on PR #5835: URL: https://github.com/apache/hbase/pull/5835#issuecomment-2062959719 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 19s | master passed | | +1 :green_heart: | compile | 0m 47s | master passed | | +1 :green_heart: | shadedjars | 5m 53s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 41s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 55s | the patch passed | | +1 :green_heart: | compile | 0m 47s | the patch passed | | +1 :green_heart: | javac | 0m 47s | the patch passed | | +1 :green_heart: | shadedjars | 5m 51s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 10s | hbase-zookeeper generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0) | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 45s | hbase-common in the patch passed. | | +1 :green_heart: | unit | 1m 28s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 0m 41s | hbase-zookeeper in the patch passed. | | | | 28m 13s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5835/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5835 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux b7227e2d5fe8 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d7f9ba6548 | | Default Java | Eclipse Adoptium-11.0.17+8 | | javadoc | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5835/1/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-zookeeper.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5835/1/testReport/ | | Max. process+thread count | 383 (vs. ulimit of 3) | | modules | C: hbase-common hbase-client hbase-zookeeper U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5835/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28529 Use ZKClientConfig instead of system properties when sett… [hbase]
Apache-HBase commented on PR #5835: URL: https://github.com/apache/hbase/pull/5835#issuecomment-2062959426 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 17s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 59s | master passed | | +1 :green_heart: | compile | 1m 31s | master passed | | +1 :green_heart: | checkstyle | 0m 42s | master passed | | +1 :green_heart: | spotless | 0m 45s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 42s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 46s | the patch passed | | +1 :green_heart: | compile | 1m 31s | the patch passed | | +1 :green_heart: | javac | 0m 33s | hbase-common generated 0 new + 36 unchanged - 1 fixed = 36 total (was 37) | | +1 :green_heart: | javac | 0m 40s | hbase-client in the patch passed. | | -0 :warning: | javac | 0m 18s | hbase-zookeeper generated 1 new + 46 unchanged - 0 fixed = 47 total (was 46) | | +1 :green_heart: | checkstyle | 0m 41s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 4m 51s | Patch does not cause any errors with Hadoop 3.3.6. | | +1 :green_heart: | spotless | 0m 43s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 2m 4s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 30s | The patch does not generate ASF License warnings. | | | | 27m 57s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5835/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5835 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 06fbff701735 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d7f9ba6548 | | Default Java | Eclipse Adoptium-11.0.17+8 | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5835/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-zookeeper.txt | | Max. process+thread count | 80 (vs. ulimit of 3) | | modules | C: hbase-common hbase-client hbase-zookeeper U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5835/1/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28529 Use ZKClientConfig instead of system properties when sett… [hbase]
Apache-HBase commented on PR #5835: URL: https://github.com/apache/hbase/pull/5835#issuecomment-2062958817 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 44s | master passed | | +1 :green_heart: | compile | 0m 43s | master passed | | +1 :green_heart: | shadedjars | 5m 43s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 37s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 26s | the patch passed | | +1 :green_heart: | compile | 0m 43s | the patch passed | | +1 :green_heart: | javac | 0m 43s | the patch passed | | +1 :green_heart: | shadedjars | 5m 49s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 11s | hbase-zookeeper generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 16s | hbase-common in the patch passed. | | +1 :green_heart: | unit | 1m 37s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 0m 41s | hbase-zookeeper in the patch passed. | | | | 26m 50s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5835/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5835 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 1c704d6c00cd 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d7f9ba6548 | | Default Java | Temurin-1.8.0_352-b08 | | javadoc | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5835/1/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-zookeeper.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5835/1/testReport/ | | Max. process+thread count | 371 (vs. ulimit of 3) | | modules | C: hbase-common hbase-client hbase-zookeeper U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5835/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-27826 Refactor code to move creation of Ref files to SFT interface apis [hbase]
Apache9 commented on code in PR #5834:
URL: https://github.com/apache/hbase/pull/5834#discussion_r1569899833
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/SplitTableRegionProcedure.java:
##
@@ -666,8 +666,9 @@ private Pair, List> splitStoreFiles(final
MasterProcedureEnv en
// table dir. In case of failure, the proc would go through this again,
already existing
// region dirs and split files would just be ignored, new split files
should get created.
int nbFiles = 0;
-final Map> files =
- new HashMap>(htd.getColumnFamilyCount());
+final Map, StoreFileTracker>> files
=
Review Comment:
We need a separate StoreFileTracker for every StoreFile? Seems strange...
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileInfo.java:
##
@@ -119,12 +120,13 @@ public class StoreFileInfo implements Configurable {
* @param primaryReplica true if this is a store file for primary replica,
otherwise false.
*/
public StoreFileInfo(final Configuration conf, final FileSystem fs, final
Path initialPath,
-final boolean primaryReplica) throws IOException {
-this(conf, fs, null, initialPath, primaryReplica);
+final boolean primaryReplica, final StoreFileTracker sft) throws
IOException {
Review Comment:
I guess a better choice is to move these logics into StoreFileTracker, and
make the constructor of StoreFileInfo simpler, so we do not need to pass so
many parameters in...
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/storefiletracker/DefaultStoreFileTracker.java:
##
@@ -55,12 +65,49 @@ protected void
doAddCompactionResults(Collection compactedFiles,
@Override
protected List doLoadStoreFiles(boolean readOnly) throws
IOException {
-List files =
-
ctx.getRegionFileSystem().getStoreFiles(ctx.getFamily().getNameAsString());
+List files =
getStoreFiles(ctx.getFamily().getNameAsString(), true);
return files != null ? files : Collections.emptyList();
}
@Override
protected void doSetStoreFiles(Collection files) throws
IOException {
}
+
+ /**
+ * Returns the store files available for the family. This methods performs
the filtering based on
+ * the valid store files.
+ * @param familyName Column Family Name
+ * @return a set of {@link StoreFileInfo} for the specified family.
+ */
+ public List getStoreFiles(final String familyName, final
boolean validate)
Review Comment:
Why putting this method here and there is no `@Override` annotation? It is
for DefaultStoreFileTracker only? Who will call it?
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/SplitTableRegionProcedure.java:
##
@@ -822,22 +825,25 @@ private class StoreFileSplitter implements
Callable> {
private final HRegionFileSystem regionFs;
private final byte[] family;
private final HStoreFile sf;
+private final StoreFileTracker tracker;
/**
* Constructor that takes what it needs to split
* @param regionFs the file system
* @param family Family that contains the store file
* @param sf which file
*/
-public StoreFileSplitter(HRegionFileSystem regionFs, byte[] family,
HStoreFile sf) {
+public StoreFileSplitter(HRegionFileSystem regionFs, StoreFileTracker
tracker, byte[] family,
+ HStoreFile sf) {
this.regionFs = regionFs;
this.sf = sf;
this.family = family;
+ this.tracker = tracker;
}
@Override
public Pair call() throws IOException {
- return splitStoreFile(regionFs, family, sf);
+ return splitStoreFile(regionFs, tracker, family, sf);
Review Comment:
I think here we need to abstract at a higer level. As if we use file based
store file tracker, we do not need multi threading. So we'd better abstract a
method for splitting multiple store files in the store file tracker interface,
and in the implementation, we are free to choose whether to use multi threading.
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/storefiletracker/StoreFileTrackerBase.java:
##
@@ -189,6 +202,107 @@ public final StoreFileWriter
createWriter(CreateStoreFileWriterParams params) th
return builder.build();
}
+ @Override
+ public String createHFileLink(CreateHFileLinkParams params) throws
IOException {
+String name = HFileLink.createHFileLinkName(params.getLinkedTable(),
params.getLinkedRegion(),
+ params.getHfileName());
+String refName =
+ HFileLink.createBackReferenceName(params.getDstTableName(),
params.getDstRegionName());
+
+// Make sure the destination directory exists
+params.getFs().mkdirs(params.getDstFamilyPath());
+
+// Make sure the FileLink reference directory exists
+Path archiveStoreDir = HFileArchiveUtil.getStoreArchivePath(conf,
params.getLinkedTable(),
+ params.getLinkedRegion(),
[jira] [Updated] (HBASE-28529) Use ZKClientConfig instead of system properties when setting zookeeper configurations
[ https://issues.apache.org/jira/browse/HBASE-28529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HBASE-28529: --- Labels: pull-request-available (was: ) > Use ZKClientConfig instead of system properties when setting zookeeper > configurations > - > > Key: HBASE-28529 > URL: https://issues.apache.org/jira/browse/HBASE-28529 > Project: HBase > Issue Type: Improvement > Components: Zookeeper >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Labels: pull-request-available > > In HBASE-28340, we allow loading zookeeper configurations from hbase > configurations, but then we use system properties to pass these parameters > when creating zookeeper client. > For replication, we may want to use different zookeeper configurations > comparing to the ones we use for starting this hbase cluster, so using system > properties to pass these parameters is not suitable then. > We should make use of ZKClientConfig to pass these flags. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] HBASE-28464: Make replication ZKWatcher config customizable in extens… [hbase]
Apache9 commented on PR #5785: URL: https://github.com/apache/hbase/pull/5785#issuecomment-2062935447 Please see #5835 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] HBASE-28529 Use ZKClientConfig instead of system properties when sett… [hbase]
Apache9 opened a new pull request, #5835: URL: https://github.com/apache/hbase/pull/5835 …ing zookeeper configurations -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28527: Adjust BlockCacheKey to use the file path instead of file name. [hbase]
jhungund commented on code in PR #5832:
URL: https://github.com/apache/hbase/pull/5832#discussion_r1569869418
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketProtoUtils.java:
##
@@ -130,10 +136,30 @@ static Pair, NavigableSet result = new
ConcurrentHashMap<>();
NavigableSet resultSet = new
ConcurrentSkipListSet<>(Comparator
.comparing(BlockCacheKey::getHfileName).thenComparingLong(BlockCacheKey::getOffset));
+
+Map allFilePaths = null;
+DataTieringManager dataTieringManager;
+try {
+ dataTieringManager = DataTieringManager.getInstance();
+ allFilePaths = dataTieringManager.getAllFilesList();
+} catch (IllegalStateException e) {
+ // Data-Tiering manager has not been set up.
+ // Ignore the error and proceed with the normal flow.
+ LOG.warn("Error while getting DataTieringManager instance: {}",
e.getMessage());
+}
+
for (BucketCacheProtos.BackingMapEntry entry : backingMap.getEntryList()) {
BucketCacheProtos.BlockCacheKey protoKey = entry.getKey();
- BlockCacheKey key = new BlockCacheKey(protoKey.getHfilename(),
protoKey.getOffset(),
-protoKey.getPrimaryReplicaBlock(), fromPb(protoKey.getBlockType()));
+
+ BlockCacheKey key = null;
+ if (allFilePaths != null) {
+key = new BlockCacheKey(allFilePaths.get(protoKey.getHfilename()),
protoKey.getOffset(),
+ protoKey.getPrimaryReplicaBlock(), fromPb(protoKey.getBlockType()));
+ } else {
+key = new BlockCacheKey(new Path(protoKey.getHfilename()),
protoKey.getOffset(),
Review Comment:
One way I can think of avoiding incorrect path to be set is by adding the
following check in the constructor of BlockCacheKey:
`if (hfilePath.getParent() != null) {
this.filePath = hfilePath;
}
`
But with this, path will remain null and during evictions (freespace()),
either we should skip the data tiering logic for such blocks or take an
expensive route of going over each file of the region server to determine the
metadata. If the later case happens even for a single key, then, we are better
off without the path and use the file names itself. Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] HBASE-28527: Adjust BlockCacheKey to use the file path instead of file name. [hbase]
jhungund commented on code in PR #5832:
URL: https://github.com/apache/hbase/pull/5832#discussion_r1569869418
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketProtoUtils.java:
##
@@ -130,10 +136,30 @@ static Pair, NavigableSet result = new
ConcurrentHashMap<>();
NavigableSet resultSet = new
ConcurrentSkipListSet<>(Comparator
.comparing(BlockCacheKey::getHfileName).thenComparingLong(BlockCacheKey::getOffset));
+
+Map allFilePaths = null;
+DataTieringManager dataTieringManager;
+try {
+ dataTieringManager = DataTieringManager.getInstance();
+ allFilePaths = dataTieringManager.getAllFilesList();
+} catch (IllegalStateException e) {
+ // Data-Tiering manager has not been set up.
+ // Ignore the error and proceed with the normal flow.
+ LOG.warn("Error while getting DataTieringManager instance: {}",
e.getMessage());
+}
+
for (BucketCacheProtos.BackingMapEntry entry : backingMap.getEntryList()) {
BucketCacheProtos.BlockCacheKey protoKey = entry.getKey();
- BlockCacheKey key = new BlockCacheKey(protoKey.getHfilename(),
protoKey.getOffset(),
-protoKey.getPrimaryReplicaBlock(), fromPb(protoKey.getBlockType()));
+
+ BlockCacheKey key = null;
+ if (allFilePaths != null) {
+key = new BlockCacheKey(allFilePaths.get(protoKey.getHfilename()),
protoKey.getOffset(),
+ protoKey.getPrimaryReplicaBlock(), fromPb(protoKey.getBlockType()));
+ } else {
+key = new BlockCacheKey(new Path(protoKey.getHfilename()),
protoKey.getOffset(),
Review Comment:
One way I can think of avoiding incorrect path to be set is by adding the
following check in the constructor of BlockCacheKey:
`if (hfilePath.getParent() != null) {
this.filePath = hfilePath;
}
`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] HBASE-27126 Support multi-threads cleaner for MOB files [hbase]
Apache-HBase commented on PR #5833: URL: https://github.com/apache/hbase/pull/5833#issuecomment-2062459106 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 15s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 16s | master passed | | +1 :green_heart: | compile | 0m 48s | master passed | | +1 :green_heart: | shadedjars | 6m 50s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 46s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 13s | the patch passed | | +1 :green_heart: | compile | 1m 15s | the patch passed | | +1 :green_heart: | javac | 1m 15s | the patch passed | | +1 :green_heart: | shadedjars | 8m 35s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 43s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 337m 32s | hbase-server in the patch failed. | | | | 369m 13s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5833/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5833 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux e505286be8e2 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d7f9ba6548 | | Default Java | Temurin-1.8.0_352-b08 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5833/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5833/1/testReport/ | | Max. process+thread count | 4745 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5833/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-27826 Refactor code to move creation of Ref files to SFT interface apis [hbase]
Apache-HBase commented on PR #5834: URL: https://github.com/apache/hbase/pull/5834#issuecomment-2062421730 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 38s | master passed | | +1 :green_heart: | compile | 0m 56s | master passed | | +1 :green_heart: | shadedjars | 6m 43s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 29s | master passed | ||| _ Patch Compile Tests _ | | -1 :x: | mvninstall | 1m 54s | root in the patch failed. | | -1 :x: | compile | 0m 51s | hbase-server in the patch failed. | | -0 :warning: | javac | 0m 51s | hbase-server in the patch failed. | | -1 :x: | shadedjars | 5m 1s | patch has 612 errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 30s | hbase-server generated 4 new + 93 unchanged - 3 fixed = 97 total (was 96) | ||| _ Other Tests _ | | -1 :x: | unit | 1m 2s | hbase-server in the patch failed. | | | | 22m 43s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5834 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 993919b8a98e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d7f9ba6548 | | Default Java | Eclipse Adoptium-11.0.17+8 | | mvninstall | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt | | compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt | | shadedjars | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt | | javadoc | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/testReport/ | | Max. process+thread count | 79 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-27826 Refactor code to move creation of Ref files to SFT interface apis [hbase]
Apache-HBase commented on PR #5834: URL: https://github.com/apache/hbase/pull/5834#issuecomment-2062411590 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 39s | master passed | | +1 :green_heart: | compile | 3m 9s | master passed | | +1 :green_heart: | checkstyle | 0m 55s | master passed | | +1 :green_heart: | spotless | 0m 54s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 59s | master passed | ||| _ Patch Compile Tests _ | | -1 :x: | mvninstall | 2m 3s | root in the patch failed. | | -1 :x: | compile | 1m 11s | hbase-server in the patch failed. | | -0 :warning: | javac | 1m 11s | hbase-server in the patch failed. | | -0 :warning: | checkstyle | 0m 40s | hbase-server: The patch generated 2 new + 55 unchanged - 2 fixed = 57 total (was 57) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | -1 :x: | hadoopcheck | 2m 16s | The patch causes 612 errors with Hadoop v3.3.6. | | +1 :green_heart: | spotless | 0m 47s | patch has no errors when running spotless:check. | | -1 :x: | spotbugs | 0m 50s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 10s | The patch does not generate ASF License warnings. | | | | 20m 40s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5834 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 468a939842f1 5.4.0-176-generic #196-Ubuntu SMP Fri Mar 22 16:46:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d7f9ba6548 | | Default Java | Eclipse Adoptium-11.0.17+8 | | mvninstall | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/artifact/yetus-general-check/output/patch-mvninstall-root.txt | | compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/artifact/yetus-general-check/output/patch-compile-hbase-server.txt | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/artifact/yetus-general-check/output/patch-compile-hbase-server.txt | | checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | hadoopcheck | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/artifact/yetus-general-check/output/patch-javac-3.3.6.txt | | spotbugs | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/artifact/yetus-general-check/output/patch-spotbugs-hbase-server.txt | | Max. process+thread count | 78 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-27826 Refactor code to move creation of Ref files to SFT interface apis [hbase]
Apache-HBase commented on PR #5834: URL: https://github.com/apache/hbase/pull/5834#issuecomment-2062405932 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 11s | master passed | | +1 :green_heart: | compile | 0m 52s | master passed | | +1 :green_heart: | shadedjars | 5m 37s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 27s | master passed | ||| _ Patch Compile Tests _ | | -1 :x: | mvninstall | 1m 35s | root in the patch failed. | | -1 :x: | compile | 0m 50s | hbase-server in the patch failed. | | -0 :warning: | javac | 0m 50s | hbase-server in the patch failed. | | -1 :x: | shadedjars | 4m 14s | patch has 612 errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 25s | hbase-server generated 5 new + 48 unchanged - 0 fixed = 53 total (was 48) | ||| _ Other Tests _ | | -1 :x: | unit | 0m 51s | hbase-server in the patch failed. | | | | 19m 26s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5834 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux baf4aa312f52 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d7f9ba6548 | | Default Java | Eclipse Adoptium-17.0.10+7 | | mvninstall | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/artifact/yetus-jdk17-hadoop3-check/output/patch-mvninstall-root.txt | | compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/artifact/yetus-jdk17-hadoop3-check/output/patch-compile-hbase-server.txt | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/artifact/yetus-jdk17-hadoop3-check/output/patch-compile-hbase-server.txt | | shadedjars | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/artifact/yetus-jdk17-hadoop3-check/output/patch-shadedjars.txt | | javadoc | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/artifact/yetus-jdk17-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/testReport/ | | Max. process+thread count | 82 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-27826 Refactor code to move creation of Ref files to SFT interface apis [hbase]
Apache-HBase commented on PR #5834: URL: https://github.com/apache/hbase/pull/5834#issuecomment-2062398860 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 44s | master passed | | +1 :green_heart: | compile | 0m 40s | master passed | | +1 :green_heart: | shadedjars | 5m 41s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 25s | master passed | ||| _ Patch Compile Tests _ | | -1 :x: | mvninstall | 1m 13s | root in the patch failed. | | -1 :x: | compile | 0m 36s | hbase-server in the patch failed. | | -0 :warning: | javac | 0m 36s | hbase-server in the patch failed. | | -1 :x: | shadedjars | 4m 8s | patch has 616 errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 22s | hbase-server generated 3 new + 22 unchanged - 0 fixed = 25 total (was 22) | ||| _ Other Tests _ | | -1 :x: | unit | 0m 36s | hbase-server in the patch failed. | | | | 17m 48s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5834 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux da1b2ecb9d00 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d7f9ba6548 | | Default Java | Temurin-1.8.0_352-b08 | | mvninstall | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/artifact/yetus-jdk8-hadoop3-check/output/patch-mvninstall-root.txt | | compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt | | shadedjars | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt | | javadoc | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/testReport/ | | Max. process+thread count | 64 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28464: Make replication ZKWatcher config customizable in extens… [hbase]
Apache-HBase commented on PR #5785: URL: https://github.com/apache/hbase/pull/5785#issuecomment-2062362250 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 11s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 48s | master passed | | +1 :green_heart: | compile | 1m 5s | master passed | | +1 :green_heart: | shadedjars | 5m 14s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 39s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 49s | the patch passed | | +1 :green_heart: | compile | 1m 8s | the patch passed | | +1 :green_heart: | javac | 1m 8s | the patch passed | | +1 :green_heart: | shadedjars | 6m 33s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 39s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 40s | hbase-zookeeper in the patch passed. | | +1 :green_heart: | unit | 326m 45s | hbase-server in the patch passed. | | | | 353m 56s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5785/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5785 | | JIRA Issue | HBASE-28464 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 24c8c02f2b43 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d7f9ba6548 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5785/4/testReport/ | | Max. process+thread count | 4708 (vs. ulimit of 3) | | modules | C: hbase-zookeeper hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5785/4/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-27826 Refactor code to move creation of Ref files to SFT interface apis [hbase]
Apache-HBase commented on PR #5834: URL: https://github.com/apache/hbase/pull/5834#issuecomment-2062321856 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 46s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 12s | master passed | | +1 :green_heart: | compile | 1m 0s | master passed | | +1 :green_heart: | shadedjars | 6m 44s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 32s | master passed | ||| _ Patch Compile Tests _ | | -1 :x: | mvninstall | 2m 6s | root in the patch failed. | | -1 :x: | compile | 0m 58s | hbase-server in the patch failed. | | -0 :warning: | javac | 0m 58s | hbase-server in the patch failed. | | -1 :x: | shadedjars | 5m 2s | patch has 612 errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 30s | hbase-server generated 4 new + 93 unchanged - 3 fixed = 97 total (was 96) | ||| _ Other Tests _ | | -1 :x: | unit | 1m 1s | hbase-server in the patch failed. | | | | 24m 0s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5834 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 3a024ff851a8 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d7f9ba6548 | | Default Java | Eclipse Adoptium-11.0.17+8 | | mvninstall | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt | | compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt | | shadedjars | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt | | javadoc | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/testReport/ | | Max. process+thread count | 78 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-27826 Refactor code to move creation of Ref files to SFT interface apis [hbase]
Apache-HBase commented on PR #5834: URL: https://github.com/apache/hbase/pull/5834#issuecomment-2062319814 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 21s | master passed | | +1 :green_heart: | compile | 1m 7s | master passed | | +1 :green_heart: | shadedjars | 6m 9s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 27s | master passed | ||| _ Patch Compile Tests _ | | -1 :x: | mvninstall | 1m 48s | root in the patch failed. | | -1 :x: | compile | 0m 58s | hbase-server in the patch failed. | | -0 :warning: | javac | 0m 58s | hbase-server in the patch failed. | | -1 :x: | shadedjars | 4m 37s | patch has 612 errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 31s | hbase-server generated 5 new + 48 unchanged - 0 fixed = 53 total (was 48) | ||| _ Other Tests _ | | -1 :x: | unit | 0m 59s | hbase-server in the patch failed. | | | | 22m 37s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5834 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 419a9e836c0c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d7f9ba6548 | | Default Java | Eclipse Adoptium-17.0.10+7 | | mvninstall | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/artifact/yetus-jdk17-hadoop3-check/output/patch-mvninstall-root.txt | | compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/artifact/yetus-jdk17-hadoop3-check/output/patch-compile-hbase-server.txt | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/artifact/yetus-jdk17-hadoop3-check/output/patch-compile-hbase-server.txt | | shadedjars | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/artifact/yetus-jdk17-hadoop3-check/output/patch-shadedjars.txt | | javadoc | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/artifact/yetus-jdk17-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/testReport/ | | Max. process+thread count | 82 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-27826 Refactor code to move creation of Ref files to SFT interface apis [hbase]
Apache-HBase commented on PR #5834: URL: https://github.com/apache/hbase/pull/5834#issuecomment-2062313555 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 30s | master passed | | +1 :green_heart: | compile | 3m 18s | master passed | | +1 :green_heart: | checkstyle | 0m 57s | master passed | | +1 :green_heart: | spotless | 1m 6s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 53s | master passed | ||| _ Patch Compile Tests _ | | -1 :x: | mvninstall | 2m 7s | root in the patch failed. | | -1 :x: | compile | 1m 19s | hbase-server in the patch failed. | | -0 :warning: | javac | 1m 19s | hbase-server in the patch failed. | | -0 :warning: | checkstyle | 0m 42s | hbase-server: The patch generated 2 new + 55 unchanged - 2 fixed = 57 total (was 57) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | -1 :x: | hadoopcheck | 2m 26s | The patch causes 612 errors with Hadoop v3.3.6. | | +1 :green_heart: | spotless | 0m 50s | patch has no errors when running spotless:check. | | -1 :x: | spotbugs | 0m 48s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 10s | The patch does not generate ASF License warnings. | | | | 21m 6s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5834 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 6fd68976b686 5.4.0-176-generic #196-Ubuntu SMP Fri Mar 22 16:46:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d7f9ba6548 | | Default Java | Eclipse Adoptium-11.0.17+8 | | mvninstall | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt | | compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/artifact/yetus-general-check/output/patch-compile-hbase-server.txt | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/artifact/yetus-general-check/output/patch-compile-hbase-server.txt | | checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | hadoopcheck | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/artifact/yetus-general-check/output/patch-javac-3.3.6.txt | | spotbugs | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/artifact/yetus-general-check/output/patch-spotbugs-hbase-server.txt | | Max. process+thread count | 79 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-27826 Refactor code to move creation of Ref files to SFT interface apis [hbase]
Apache-HBase commented on PR #5834: URL: https://github.com/apache/hbase/pull/5834#issuecomment-2062297695 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 47s | master passed | | +1 :green_heart: | compile | 0m 39s | master passed | | +1 :green_heart: | shadedjars | 5m 32s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 24s | master passed | ||| _ Patch Compile Tests _ | | -1 :x: | mvninstall | 1m 14s | root in the patch failed. | | -1 :x: | compile | 0m 36s | hbase-server in the patch failed. | | -0 :warning: | javac | 0m 36s | hbase-server in the patch failed. | | -1 :x: | shadedjars | 4m 7s | patch has 616 errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 22s | hbase-server generated 3 new + 22 unchanged - 0 fixed = 25 total (was 22) | ||| _ Other Tests _ | | -1 :x: | unit | 0m 36s | hbase-server in the patch failed. | | | | 17m 39s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5834 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux cbb4cdc31d98 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d7f9ba6548 | | Default Java | Temurin-1.8.0_352-b08 | | mvninstall | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/artifact/yetus-jdk8-hadoop3-check/output/patch-mvninstall-root.txt | | compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt | | shadedjars | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt | | javadoc | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/testReport/ | | Max. process+thread count | 67 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-27126 Support multi-threads cleaner for MOB files [hbase]
Apache-HBase commented on PR #5833: URL: https://github.com/apache/hbase/pull/5833#issuecomment-2062225381 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 47s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 48s | master passed | | +1 :green_heart: | compile | 1m 11s | master passed | | +1 :green_heart: | shadedjars | 7m 37s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 36s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 27s | the patch passed | | +1 :green_heart: | compile | 1m 2s | the patch passed | | +1 :green_heart: | javac | 1m 2s | the patch passed | | +1 :green_heart: | shadedjars | 6m 26s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 32s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 272m 11s | hbase-server in the patch passed. | | | | 302m 27s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5833/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5833 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux cfd0c49ddf45 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d7f9ba6548 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5833/1/testReport/ | | Max. process+thread count | 5120 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5833/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-28292) Make Delay prefetch property to be dynamically configured
[
https://issues.apache.org/jira/browse/HBASE-28292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838374#comment-17838374
]
Hudson commented on HBASE-28292:
Results for branch branch-3
[build #186 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/186/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/186/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/186/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/186/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Make Delay prefetch property to be dynamically configured
> -
>
> Key: HBASE-28292
> URL: https://issues.apache.org/jira/browse/HBASE-28292
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 2.6.0, 2.4.17, 3.0.0-beta-1, 4.0.0-alpha-1, 2.7.0, 2.5.8
>Reporter: Abhishek Kothalikar
>Assignee: Abhishek Kothalikar
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.6.0, 2.4.18, 3.0.0, 4.0.0-alpha-1, 2.7.0, 2.5.9
>
> Attachments: HBASE-28292.docx
>
>
> Make the prefetch delay configurable. The prefetch delay is associated to
> hbase.hfile.prefetch.delay configuration. There are some cases where
> configuring hbase.hfile.prefetch.delay would help in achieving better
> throughput.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] HBASE-27826 Refactor code to move creation of Ref files to SFT interface apis [hbase]
gvprathyusha6 commented on PR #5834: URL: https://github.com/apache/hbase/pull/5834#issuecomment-2062158504 > Modifies HStoreFile/StoreFileInfo constructors to take SFT interface as a parameter. Refactors direct interactions of Reference/HFileLink creations to SFT interface. Also moves getStoreFiles/hasReferences from HRegionFS to SFT impls. Use the SFT interface to list files of store everywhere instead of using FS objects directly This POC PR is primarily to get a high level overview of the list of changes and is intended to be broken once the initial review is done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-27826) Region split and merge time while offline is O(n) with respect to number of store files
[
https://issues.apache.org/jira/browse/HBASE-27826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HBASE-27826:
---
Labels: pull-request-available (was: )
> Region split and merge time while offline is O(n) with respect to number of
> store files
> ---
>
> Key: HBASE-27826
> URL: https://issues.apache.org/jira/browse/HBASE-27826
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.5.4
>Reporter: Andrew Kyle Purtell
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.7.0, 3.0.0-beta-2
>
>
> This is a significant availability issue when HFiles are on S3. =
> HBASE-26079 ({_}Use StoreFileTracker when splitting and merging{_}) changed
> the split and merge table procedure implementations to indirect through the
> StoreFileTracker implementation when selecting HFiles to be merged or split,
> rather than directly listing those using file system APIs. It also changed
> the commit logic in HRegionFileSystem to add the link/ref files on resulting
> split or merged regions to the StoreFileTracker. However, the creation of a
> link file is still a filesystem operation and creating a “file” on S3 can
> take well over a second. If, for example there are 20 store files in a
> region, which is not uncommon, after the region is taken offline for a split
> (or merge) it may require more than 20 seconds to create the link files
> before the results can be brought back online, creating a severe availability
> problem. Splits and merges are supposed to be fast, completing in less than a
> second, certainly less than a few seconds. This has been true when HFiles are
> stored on HDFS only because file creation operations there are nearly
> instantaneous.
> There are two issues but both can be handled with modifications to the store
> file tracker interface and the file based store file tracker implementation.
> When the file based store file file tracker is enabled the HFile links should
> be virtual entities that only exist in the file manifest. We do not require
> physical files in the filesystem to serve as links now. That is the magic of
> the this file tracker, the manifest file replaces requirements to list the
> filesystem.
> Then, when splitting or merging, the HFile links should be collected into a
> list and committed in one batch using a new FILE file tracker interface,
> requiring only one update of the manifest file in S3, bringing the time
> requirement for this operation to O(1) down from O[n].
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-28292) Make Delay prefetch property to be dynamically configured
[
https://issues.apache.org/jira/browse/HBASE-28292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838370#comment-17838370
]
Hudson commented on HBASE-28292:
Results for branch branch-2.5
[build #512 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/512/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/512/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/512/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/512/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/512/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Make Delay prefetch property to be dynamically configured
> -
>
> Key: HBASE-28292
> URL: https://issues.apache.org/jira/browse/HBASE-28292
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 2.6.0, 2.4.17, 3.0.0-beta-1, 4.0.0-alpha-1, 2.7.0, 2.5.8
>Reporter: Abhishek Kothalikar
>Assignee: Abhishek Kothalikar
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.6.0, 2.4.18, 3.0.0, 4.0.0-alpha-1, 2.7.0, 2.5.9
>
> Attachments: HBASE-28292.docx
>
>
> Make the prefetch delay configurable. The prefetch delay is associated to
> hbase.hfile.prefetch.delay configuration. There are some cases where
> configuring hbase.hfile.prefetch.delay would help in achieving better
> throughput.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] HBASE-28464: Make replication ZKWatcher config customizable in extens… [hbase]
Apache-HBase commented on PR #5785: URL: https://github.com/apache/hbase/pull/5785#issuecomment-2062106424 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 48s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 17s | master passed | | +1 :green_heart: | compile | 1m 28s | master passed | | +1 :green_heart: | shadedjars | 6m 22s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 51s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 52s | the patch passed | | +1 :green_heart: | compile | 1m 26s | the patch passed | | +1 :green_heart: | javac | 1m 26s | the patch passed | | +1 :green_heart: | shadedjars | 5m 56s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 41s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 40s | hbase-zookeeper in the patch passed. | | -1 :x: | unit | 242m 47s | hbase-server in the patch failed. | | | | 274m 35s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5785/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5785 | | JIRA Issue | HBASE-28464 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 71f2a3c2b603 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d7f9ba6548 | | Default Java | Eclipse Adoptium-17.0.10+7 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5785/4/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5785/4/testReport/ | | Max. process+thread count | 4496 (vs. ulimit of 3) | | modules | C: hbase-zookeeper hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5785/4/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-27126 Support multi-threads cleaner for MOB files [hbase]
Apache-HBase commented on PR #5833: URL: https://github.com/apache/hbase/pull/5833#issuecomment-2062091341 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 54s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 0s | master passed | | +1 :green_heart: | compile | 0m 56s | master passed | | +1 :green_heart: | shadedjars | 5m 17s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 30s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 45s | the patch passed | | +1 :green_heart: | compile | 0m 55s | the patch passed | | +1 :green_heart: | javac | 0m 55s | the patch passed | | +1 :green_heart: | shadedjars | 5m 13s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 28s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 224m 37s | hbase-server in the patch passed. | | | | 249m 24s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5833/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5833 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 79e3110bc3f6 5.4.0-176-generic #196-Ubuntu SMP Fri Mar 22 16:46:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d7f9ba6548 | | Default Java | Eclipse Adoptium-17.0.10+7 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5833/1/testReport/ | | Max. process+thread count | 5600 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5833/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28464: Make replication ZKWatcher config customizable in extens… [hbase]
Apache-HBase commented on PR #5785: URL: https://github.com/apache/hbase/pull/5785#issuecomment-2062083661 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 15s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 47s | master passed | | +1 :green_heart: | compile | 1m 5s | master passed | | +1 :green_heart: | shadedjars | 5m 57s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 39s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 45s | the patch passed | | +1 :green_heart: | compile | 0m 56s | the patch passed | | +1 :green_heart: | javac | 0m 56s | the patch passed | | +1 :green_heart: | shadedjars | 5m 36s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 38s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 40s | hbase-zookeeper in the patch passed. | | +1 :green_heart: | unit | 231m 51s | hbase-server in the patch passed. | | | | 258m 25s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5785/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5785 | | JIRA Issue | HBASE-28464 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux af10032a9ec2 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d7f9ba6548 | | Default Java | Temurin-1.8.0_352-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5785/4/testReport/ | | Max. process+thread count | 4782 (vs. ulimit of 3) | | modules | C: hbase-zookeeper hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5785/4/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28527: Adjust BlockCacheKey to use the file path instead of file name. [hbase]
Apache-HBase commented on PR #5832: URL: https://github.com/apache/hbase/pull/5832#issuecomment-2061782838 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 57s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ HBASE-28463 Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 38s | HBASE-28463 passed | | +1 :green_heart: | compile | 0m 42s | HBASE-28463 passed | | +1 :green_heart: | shadedjars | 5m 10s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 26s | HBASE-28463 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 25s | the patch passed | | +1 :green_heart: | compile | 0m 42s | the patch passed | | +1 :green_heart: | javac | 0m 42s | the patch passed | | +1 :green_heart: | shadedjars | 5m 10s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 25s | hbase-server generated 1 new + 22 unchanged - 0 fixed = 23 total (was 22) | ||| _ Other Tests _ | | +1 :green_heart: | unit | 245m 20s | hbase-server in the patch passed. | | | | 268m 44s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5832/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5832 | | JIRA Issue | HBASE-28527 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 8b82e32a7389 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-28463 / b7bb8b9d27 | | Default Java | Temurin-1.8.0_352-b08 | | javadoc | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5832/1/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5832/1/testReport/ | | Max. process+thread count | 5281 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5832/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28527: Adjust BlockCacheKey to use the file path instead of file name. [hbase]
Apache-HBase commented on PR #5832: URL: https://github.com/apache/hbase/pull/5832#issuecomment-2061777146 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ HBASE-28463 Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 54s | HBASE-28463 passed | | +1 :green_heart: | compile | 1m 9s | HBASE-28463 passed | | +1 :green_heart: | shadedjars | 6m 55s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 44s | HBASE-28463 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 54s | the patch passed | | +1 :green_heart: | compile | 0m 57s | the patch passed | | +1 :green_heart: | javac | 0m 57s | the patch passed | | +1 :green_heart: | shadedjars | 6m 33s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 27s | hbase-server generated 1 new + 96 unchanged - 0 fixed = 97 total (was 96) | ||| _ Other Tests _ | | +1 :green_heart: | unit | 234m 25s | hbase-server in the patch passed. | | | | 265m 3s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5832/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5832 | | JIRA Issue | HBASE-28527 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 33900618b5c9 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-28463 / b7bb8b9d27 | | Default Java | Eclipse Adoptium-11.0.17+8 | | javadoc | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5832/1/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5832/1/testReport/ | | Max. process+thread count | 5198 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5832/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-27126 Support multi-threads cleaner for MOB files [hbase]
Apache-HBase commented on PR #5833: URL: https://github.com/apache/hbase/pull/5833#issuecomment-2061676341 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 52s | master passed | | +1 :green_heart: | compile | 3m 16s | master passed | | +1 :green_heart: | checkstyle | 0m 43s | master passed | | +1 :green_heart: | spotless | 0m 57s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 2m 3s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 47s | the patch passed | | +1 :green_heart: | compile | 3m 7s | the patch passed | | +1 :green_heart: | javac | 3m 7s | the patch passed | | +1 :green_heart: | checkstyle | 0m 43s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 5m 19s | Patch does not cause any errors with Hadoop 3.3.6. | | +1 :green_heart: | spotless | 1m 6s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 2m 7s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 13s | The patch does not generate ASF License warnings. | | | | 35m 46s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5833/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5833 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 4c5de78c569c 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d7f9ba6548 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Max. process+thread count | 77 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5833/1/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28464: Make replication ZKWatcher config customizable in extens… [hbase]
Apache-HBase commented on PR #5785: URL: https://github.com/apache/hbase/pull/5785#issuecomment-2061654053 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 49s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 20s | master passed | | +1 :green_heart: | compile | 3m 40s | master passed | | +1 :green_heart: | checkstyle | 0m 44s | master passed | | +1 :green_heart: | spotless | 0m 49s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 2m 13s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 59s | the patch passed | | +1 :green_heart: | compile | 3m 28s | the patch passed | | +1 :green_heart: | javac | 3m 28s | the patch passed | | +1 :green_heart: | checkstyle | 0m 51s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 5m 45s | Patch does not cause any errors with Hadoop 3.3.6. | | +1 :green_heart: | spotless | 1m 18s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 3m 56s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 30s | The patch does not generate ASF License warnings. | | | | 42m 42s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5785/4/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5785 | | JIRA Issue | HBASE-28464 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux f1fe78340dd4 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d7f9ba6548 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Max. process+thread count | 78 (vs. ulimit of 3) | | modules | C: hbase-zookeeper hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5785/4/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (HBASE-28533) Region split failure due to region quota limit leaves Hmaster's in memory state for the region in SPLITTING after procedure rollback
Daniel Roudnitsky created HBASE-28533:
-
Summary: Region split failure due to region quota limit leaves
Hmaster's in memory state for the region in SPLITTING after procedure rollback
Key: HBASE-28533
URL: https://issues.apache.org/jira/browse/HBASE-28533
Project: HBase
Issue Type: Bug
Components: Region Assignment
Affects Versions: 2.5.8
Environment: HBase Version 2.5.8,
r37444de6531b1bdabf2e445c83d0268ab1a6f919, Thu Feb 29 15:37:32 PST 2024
Reporter: Daniel Roudnitsky
When a SplitTableRegionProcedure is run for a region whose namespace is at its
maximum region quota limit, the split procedure will fail and rollback, and
Hmaster's in memory RegionStateNode for the region is left in a SPLITTING
state. Hmaster will then refuse to start any subsequent merge/split/move
procedures for that region because it believes the region is not OPEN, until it
is restarted and the in memory record of region states is reset.
In the first step of the split procedure SPLIT_TABLE_REGION_PREPARE the parent
region's RegionStateNode state is set to SPLITTING, and the transition is not
written to the meta table. In the next step SPLIT_TABLE_REGION_PRE_OPERATION
the region quota check is done, QuotaExceededException is thrown and the
procedure ends in ROLLEDBACK state without reverting the RegionStateNode back
to OPEN state. Hmaster is left believing the region is in a SPLITTING state
according to its in memory RegionStates, while the region is still online on
the assigned region server and according to meta.
To reproduce in HBase shell:
{code:java}
> create_namespace 'test_ns', {'hbase.namespace.quota.maxregions'=> 2}
> create 'test_ns:test_table', 'f1', {NUMREGIONS => 2, SPLITALGO =>
> 'UniformSplit'}
> region_a =
> region_b =
> split region_a, 'x'
# HMaster will report:
pid=405, state=ROLLEDBACK,
exception=org.apache.hadoop.hbase.quotas.QuotaExceededException via
master-split-regions:org.apache.hadoop.hbase.quotas.QuotaExceededException:
Region split not possible for : as quota limits are exceeded ;
SplitTableRegionProcedure table=test_ns:test_table, parent=...
> merge_region region_a, region_b
ERROR: org.apache.hadoop.hbase.exceptions.MergeRegionException:
org.apache.hadoop.hbase.client.DoNotRetryRegionException: is not
OPEN; state=SPLITTING
> stop_master # trigger hmaster failover
> merge_region region_a, region_b # merge now succeeds {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (HBASE-27126) Support multi-threads cleaner for MOB files
[ https://issues.apache.org/jira/browse/HBASE-27126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HBASE-27126: --- Labels: pull-request-available (was: ) > Support multi-threads cleaner for MOB files > --- > > Key: HBASE-27126 > URL: https://issues.apache.org/jira/browse/HBASE-27126 > Project: HBase > Issue Type: Improvement > Components: mob >Affects Versions: 2.4.12 >Reporter: Xiaolin Ha >Assignee: Chandra Sekhar K >Priority: Major > Labels: pull-request-available > Fix For: 3.0.0-beta-2 > > > Just like the muti-threads in hfile cleaner. > When there are many tables has MOB files, only one thread for cleaning them > is not enough. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] HBASE-28532 remove vulnerable slf4j-log4j12 dependency [hbase-operator-tools]
Apache-HBase commented on PR #142: URL: https://github.com/apache/hbase-operator-tools/pull/142#issuecomment-2061562917 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 25s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 32s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 0m 33s | master passed | | +1 :green_heart: | compile | 0m 19s | master passed | | +1 :green_heart: | spotless | 0m 8s | branch has no errors when running spotless:check. | | +1 :green_heart: | javadoc | 0m 13s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 7s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 0m 38s | the patch passed | | +1 :green_heart: | compile | 0m 21s | the patch passed | | +1 :green_heart: | javac | 0m 21s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. | | +1 :green_heart: | spotless | 0m 6s | patch has no errors when running spotless:check. | | +1 :green_heart: | javadoc | 0m 12s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 8s | hbase-table-reporter in the patch passed. | | +1 :green_heart: | unit | 6m 48s | root in the patch passed. | | +1 :green_heart: | asflicense | 0m 11s | The patch does not generate ASF License warnings. | | | | 12m 0s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-142/1/artifact/yetus-precommit-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase-operator-tools/pull/142 | | Optional Tests | dupname asflicense javac javadoc unit spotless xml compile | | uname | Linux 863c0a17ac48 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/jenkins/hbase-personality.sh | | git revision | master / 4286235 | | Default Java | Oracle Corporation-1.8.0_342-b07 | | Test Results | https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-142/1/testReport/ | | Max. process+thread count | 1256 (vs. ulimit of 5000) | | modules | C: hbase-table-reporter . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-142/1/console | | versions | git=2.30.2 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] HBASE-28532 remove vulnerable slf4j-log4j12 dependency [hbase-operator-tools]
nikita15p opened a new pull request, #142: URL: https://github.com/apache/hbase-operator-tools/pull/142 Build and tests are passing ``` [INFO] [INFO] Reactor Summary for Apache HBase Operator Tools 1.3.0-SNAPSHOT: [INFO] [INFO] Apache HBase Operator Tools SUCCESS [ 2.605 s] [INFO] Apache HBase - Table Reporter .. SUCCESS [ 10.532 s] [INFO] Apache HBase - HBCK2 ... SUCCESS [03:51 min] [INFO] Apache HBase - HBase Tools . SUCCESS [01:32 min] [INFO] Apache HBase Operator Tools - Assembly . SUCCESS [ 0.213 s] [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 05:37 min [INFO] Finished at: 2024-04-17T14:58:57Z [INFO] ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-28532) remove vulnerable slf4j-log4j12 dependency
[ https://issues.apache.org/jira/browse/HBASE-28532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838230#comment-17838230 ] guluo commented on HBASE-28532: --- I rechecked this code and found that HBASE-28531 and this issue are not the same issue. HBASE-28531 is raised regarding this hbase-hbck2 module, which has already used log4j-slf4j-impl. It's just that HBASE-28531 occurred because the version of log4j-slf4j-impl lower than 2.17.2. > remove vulnerable slf4j-log4j12 dependency > -- > > Key: HBASE-28532 > URL: https://issues.apache.org/jira/browse/HBASE-28532 > Project: HBase > Issue Type: Improvement > Components: hbase-operator-tools >Reporter: Nikita Pande >Priority: Major > > slf4j-log4j12 is a bridge from SLF4J to Log4j 1.x. > Since log4j 1.x is vulnerable , so this needs to be removed. > > It is to be replaced with the log4j-slf4j-impl dependency, which is a bridge > from SLF4J to Log4j 2.x. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (HBASE-28532) remove vulnerable slf4j-log4j12 dependency
[ https://issues.apache.org/jira/browse/HBASE-28532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838212#comment-17838212 ] guluo edited comment on HBASE-28532 at 4/17/24 2:39 PM: -HBASE-28531 can be part of this issue.- was (Author: guluo): HBASE-28531 can be part of this issue. > remove vulnerable slf4j-log4j12 dependency > -- > > Key: HBASE-28532 > URL: https://issues.apache.org/jira/browse/HBASE-28532 > Project: HBase > Issue Type: Improvement > Components: hbase-operator-tools >Reporter: Nikita Pande >Priority: Major > > slf4j-log4j12 is a bridge from SLF4J to Log4j 1.x. > Since log4j 1.x is vulnerable , so this needs to be removed. > > It is to be replaced with the log4j-slf4j-impl dependency, which is a bridge > from SLF4J to Log4j 2.x. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] HBASE-28527: Adjust BlockCacheKey to use the file path instead of file name. [hbase]
vinayakphegde commented on code in PR #5832:
URL: https://github.com/apache/hbase/pull/5832#discussion_r1568930833
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketProtoUtils.java:
##
@@ -130,10 +136,30 @@ static Pair, NavigableSet result = new
ConcurrentHashMap<>();
NavigableSet resultSet = new
ConcurrentSkipListSet<>(Comparator
.comparing(BlockCacheKey::getHfileName).thenComparingLong(BlockCacheKey::getOffset));
+
+Map allFilePaths = null;
+DataTieringManager dataTieringManager;
+try {
+ dataTieringManager = DataTieringManager.getInstance();
+ allFilePaths = dataTieringManager.getAllFilesList();
+} catch (IllegalStateException e) {
+ // Data-Tiering manager has not been set up.
+ // Ignore the error and proceed with the normal flow.
+ LOG.warn("Error while getting DataTieringManager instance: {}",
e.getMessage());
+}
+
for (BucketCacheProtos.BackingMapEntry entry : backingMap.getEntryList()) {
BucketCacheProtos.BlockCacheKey protoKey = entry.getKey();
- BlockCacheKey key = new BlockCacheKey(protoKey.getHfilename(),
protoKey.getOffset(),
-protoKey.getPrimaryReplicaBlock(), fromPb(protoKey.getBlockType()));
+
+ BlockCacheKey key = null;
+ if (allFilePaths != null) {
+key = new BlockCacheKey(allFilePaths.get(protoKey.getHfilename()),
protoKey.getOffset(),
+ protoKey.getPrimaryReplicaBlock(), fromPb(protoKey.getBlockType()));
+ } else {
+key = new BlockCacheKey(new Path(protoKey.getHfilename()),
protoKey.getOffset(),
Review Comment:
The path will be incorrect, right? Anyone who accesses it will find the
incorrect path.
However, I couldn't think of any solution for that. @wchevreuil, do you have
any thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (HBASE-28532) remove vulnerable slf4j-log4j12 dependency
[ https://issues.apache.org/jira/browse/HBASE-28532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838212#comment-17838212 ] guluo commented on HBASE-28532: --- HBASE-28531 can be part of this issue. > remove vulnerable slf4j-log4j12 dependency > -- > > Key: HBASE-28532 > URL: https://issues.apache.org/jira/browse/HBASE-28532 > Project: HBase > Issue Type: Improvement > Components: hbase-operator-tools >Reporter: Nikita Pande >Priority: Major > > slf4j-log4j12 is a bridge from SLF4J to Log4j 1.x. > Since log4j 1.x is vulnerable , so this needs to be removed. > > It is to be replaced with the log4j-slf4j-impl dependency, which is a bridge > from SLF4J to Log4j 2.x. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-28532) remove vulnerable slf4j-log4j12 dependency
[ https://issues.apache.org/jira/browse/HBASE-28532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikita Pande updated HBASE-28532: - Component/s: hbase-operator-tools > remove vulnerable slf4j-log4j12 dependency > -- > > Key: HBASE-28532 > URL: https://issues.apache.org/jira/browse/HBASE-28532 > Project: HBase > Issue Type: Improvement > Components: hbase-operator-tools >Reporter: Nikita Pande >Priority: Major > > slf4j-log4j12 is a bridge from SLF4J to Log4j 1.x. > Since log4j 1.x is vulnerable , so this needs to be removed. > > It is to be replaced with the log4j-slf4j-impl dependency, which is a bridge > from SLF4J to Log4j 2.x. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] HBASE-28527: Adjust BlockCacheKey to use the file path instead of file name. [hbase]
Apache-HBase commented on PR #5832: URL: https://github.com/apache/hbase/pull/5832#issuecomment-2061239559 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ HBASE-28463 Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 55s | HBASE-28463 passed | | +1 :green_heart: | compile | 3m 20s | HBASE-28463 passed | | +1 :green_heart: | checkstyle | 0m 41s | HBASE-28463 passed | | +1 :green_heart: | spotless | 0m 52s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 53s | HBASE-28463 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 58s | the patch passed | | +1 :green_heart: | compile | 3m 15s | the patch passed | | +1 :green_heart: | javac | 3m 15s | the patch passed | | -0 :warning: | checkstyle | 0m 46s | hbase-server: The patch generated 10 new + 85 unchanged - 0 fixed = 95 total (was 85) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 6m 14s | Patch does not cause any errors with Hadoop 3.3.6. | | -1 :x: | spotless | 1m 8s | patch has 69 errors when running spotless:check, run spotless:apply to fix. | | +1 :green_heart: | spotbugs | 2m 45s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 16s | The patch does not generate ASF License warnings. | | | | 40m 38s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5832/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5832 | | JIRA Issue | HBASE-28527 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 14b3ea56ed94 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-28463 / b7bb8b9d27 | | Default Java | Eclipse Adoptium-11.0.17+8 | | checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5832/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | spotless | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5832/1/artifact/yetus-general-check/output/patch-spotless.txt | | Max. process+thread count | 77 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5832/1/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (HBASE-28532) remove vulnerable slf4j-log4j12 dependency
Nikita Pande created HBASE-28532: Summary: remove vulnerable slf4j-log4j12 dependency Key: HBASE-28532 URL: https://issues.apache.org/jira/browse/HBASE-28532 Project: HBase Issue Type: Improvement Reporter: Nikita Pande slf4j-log4j12 is a bridge from SLF4J to Log4j 1.x. Since log4j 1.x is vulnerable , so this needs to be removed. It is to be replaced with the log4j-slf4j-impl dependency, which is a bridge from SLF4J to Log4j 2.x. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (HBASE-28500) Rest Java client library assumes stateless servers
[ https://issues.apache.org/jira/browse/HBASE-28500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Istvan Toth resolved HBASE-28500. - Resolution: Fixed > Rest Java client library assumes stateless servers > -- > > Key: HBASE-28500 > URL: https://issues.apache.org/jira/browse/HBASE-28500 > Project: HBase > Issue Type: Bug > Components: REST >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > Labels: pull-request-available > Fix For: 2.6.0, 2.4.18, 4.0.0-alpha-1, 2.7.0, 3.0.0-beta-2, 2.5.9 > > > The Rest Java client library accepts a list of rest servers, and does random > load balancing between them for each request. > This does not work for scans, which do have state on the rest server instance. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-28500) Rest Java client library assumes stateless servers
[ https://issues.apache.org/jira/browse/HBASE-28500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838175#comment-17838175 ] Istvan Toth commented on HBASE-28500: - Pushed the addendum to all active branches. > Rest Java client library assumes stateless servers > -- > > Key: HBASE-28500 > URL: https://issues.apache.org/jira/browse/HBASE-28500 > Project: HBase > Issue Type: Bug > Components: REST >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > Labels: pull-request-available > Fix For: 2.6.0, 2.4.18, 4.0.0-alpha-1, 2.7.0, 3.0.0-beta-2, 2.5.9 > > > The Rest Java client library accepts a list of rest servers, and does random > load balancing between them for each request. > This does not work for scans, which do have state on the rest server instance. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-28531) IndexOutOfBoundsException when executing HBCK2
[
https://issues.apache.org/jira/browse/HBASE-28531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838172#comment-17838172
]
Nikita Pande commented on HBASE-28531:
--
[~guluo] I was just in a process of bumping up log4j for hbase-operator tools
from log4j1.x which is being used in hbase-table-reporter. I can take this up
as part of the same or as part of this Jira as well.
> IndexOutOfBoundsException when executing HBCK2
> ---
>
> Key: HBASE-28531
> URL: https://issues.apache.org/jira/browse/HBASE-28531
> Project: HBase
> Issue Type: Bug
> Components: hbck2
> Environment: hbck master
> hbase master
>Reporter: guluo
>Priority: Major
>
> Reproduction
>
> Execute the following command:
> {code:java}
> //代码占位符
> ${HBASE_HOME}/bin/hbase --config /etc/hbase-conf hbck -j
> ~/hbase-operator-tools/hbase-hbck2/target/hbase-hbck2-1.0.0-SNAPSHOT.jar
> {code}
> we would get IndexOutOfBoundsException, as following.
> {code:java}
> //代码占位符
> Caused by: java.lang.StringIndexOutOfBoundsException: String index out of
> range: -1 at java.lang.String.substring(String.java:1967) at
> org.apache.logging.log4j.util.PropertiesUtil.partitionOnCommonPrefixes(PropertiesUtil.java:555)
> at
> org.apache.logging.log4j.core.config.properties.PropertiesConfigurationBuilder.build(PropertiesConfigurationBuilder.java:174)
> at
> org.apache.logging.log4j.core.config.properties.PropertiesConfigurationFactory.getConfiguration(PropertiesConfigurationFactory.java:56)
> at
> org.apache.logging.log4j.core.config.properties.PropertiesConfigurationFactory.getConfiguration(PropertiesConfigurationFactory.java:35)
> at
> org.apache.logging.log4j.core.config.ConfigurationFactory$Factory.getConfiguration(ConfigurationFactory.java:557)
> at
> org.apache.logging.log4j.core.config.ConfigurationFactory$Factory.getConfiguration(ConfigurationFactory.java:481)
> at
> org.apache.logging.log4j.core.config.ConfigurationFactory.getConfiguration(ConfigurationFactory.java:323)
> at
> org.apache.logging.log4j.core.LoggerContext.reconfigure(LoggerContext.java:695)
> at
> org.apache.logging.log4j.core.LoggerContext.reconfigure(LoggerContext.java:716)
> at
> org.apache.logging.log4j.core.LoggerContext.start(LoggerContext.java:270)
> at
> org.apache.logging.log4j.core.impl.Log4jContextFactory.getContext(Log4jContextFactory.java:155)
> at
> org.apache.logging.log4j.core.impl.Log4jContextFactory.getContext(Log4jContextFactory.java:47)
> at org.apache.logging.log4j.LogManager.getContext(LogManager.java:196)
> at
> org.apache.logging.log4j.spi.AbstractLoggerAdapter.getContext(AbstractLoggerAdapter.java:137)
> at
> org.apache.logging.slf4j.Log4jLoggerFactory.getContext(Log4jLoggerFactory.java:55)
> at
> org.apache.logging.log4j.spi.AbstractLoggerAdapter.getLogger(AbstractLoggerAdapter.java:47)
> at
> org.apache.logging.slf4j.Log4jLoggerFactory.getLogger(Log4jLoggerFactory.java:33)
> at org.slf4j.LoggerFactory.getLogger(LoggerFactory.java:358) at
> org.slf4j.LoggerFactory.getLogger(LoggerFactory.java:383) at
> org.apache.hbase.HBCK2.(HBCK2.java:92) {code}
> The Reason.
> The current version of HBase uses version 2.17.2 of log4j2, which supports
> shorthand syntax for properties configuration ( LOG4J2-3341 :
> https://issues.apache.org/jira/browse/LOG4J2-3341).
>
> However, The current version of HBCK2 uses version 2.17.1 of log4j2, which
> does not support the feature.
> So, we would get IndexOutOfBoundsException when HBCK2 uses as following
> log4j2 properties, and this is the default log configuration format for HBase
> logger.http = INFO,NullAppender
> In order to avoid this problem, I think we need bump log4j2 from 2.17.1 to
> 2.17.2 against HBCK2.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] HBASE-28500 Rest Java client library assumes stateless servers (Adden… [hbase]
stoty merged PR #5831: URL: https://github.com/apache/hbase/pull/5831 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-28527) Adjust BlockCacheKey to use the file path instead of file name.
[ https://issues.apache.org/jira/browse/HBASE-28527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HBASE-28527: --- Labels: pull-request-available (was: ) > Adjust BlockCacheKey to use the file path instead of file name. > --- > > Key: HBASE-28527 > URL: https://issues.apache.org/jira/browse/HBASE-28527 > Project: HBase > Issue Type: Task > Components: BucketCache >Reporter: Janardhan Hungund >Assignee: Janardhan Hungund >Priority: Major > Labels: pull-request-available > > The time-based priority eviction policy relies on the presence of path in the > BlockCacheKey to fetch the required metadata to check data hotness and decide > whether or not to retain the block in the bucket cache. > Hence, the constructor of BlockCacheKey is adjusted to take the file path as > the input parameter. The code paths that create the blockCacheKey and also > the unit tests need to be adjusted to pass the path instead of file name. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (HBASE-28531) IndexOutOfBoundsException when executing HBCK2
guluo created HBASE-28531:
-
Summary: IndexOutOfBoundsException when executing HBCK2
Key: HBASE-28531
URL: https://issues.apache.org/jira/browse/HBASE-28531
Project: HBase
Issue Type: Bug
Components: hbck2
Environment: hbck master
hbase master
Reporter: guluo
Reproduction
Execute the following command:
{code:java}
//代码占位符
${HBASE_HOME}/bin/hbase --config /etc/hbase-conf hbck -j
~/hbase-operator-tools/hbase-hbck2/target/hbase-hbck2-1.0.0-SNAPSHOT.jar {code}
we would get IndexOutOfBoundsException, as following.
{code:java}
//代码占位符
Caused by: java.lang.StringIndexOutOfBoundsException: String index out of
range: -1 at java.lang.String.substring(String.java:1967) at
org.apache.logging.log4j.util.PropertiesUtil.partitionOnCommonPrefixes(PropertiesUtil.java:555)
at
org.apache.logging.log4j.core.config.properties.PropertiesConfigurationBuilder.build(PropertiesConfigurationBuilder.java:174)
at
org.apache.logging.log4j.core.config.properties.PropertiesConfigurationFactory.getConfiguration(PropertiesConfigurationFactory.java:56)
at
org.apache.logging.log4j.core.config.properties.PropertiesConfigurationFactory.getConfiguration(PropertiesConfigurationFactory.java:35)
at
org.apache.logging.log4j.core.config.ConfigurationFactory$Factory.getConfiguration(ConfigurationFactory.java:557)
at
org.apache.logging.log4j.core.config.ConfigurationFactory$Factory.getConfiguration(ConfigurationFactory.java:481)
at
org.apache.logging.log4j.core.config.ConfigurationFactory.getConfiguration(ConfigurationFactory.java:323)
at
org.apache.logging.log4j.core.LoggerContext.reconfigure(LoggerContext.java:695)
at
org.apache.logging.log4j.core.LoggerContext.reconfigure(LoggerContext.java:716)
at org.apache.logging.log4j.core.LoggerContext.start(LoggerContext.java:270)
at
org.apache.logging.log4j.core.impl.Log4jContextFactory.getContext(Log4jContextFactory.java:155)
at
org.apache.logging.log4j.core.impl.Log4jContextFactory.getContext(Log4jContextFactory.java:47)
at org.apache.logging.log4j.LogManager.getContext(LogManager.java:196)
at
org.apache.logging.log4j.spi.AbstractLoggerAdapter.getContext(AbstractLoggerAdapter.java:137)
at
org.apache.logging.slf4j.Log4jLoggerFactory.getContext(Log4jLoggerFactory.java:55)
at
org.apache.logging.log4j.spi.AbstractLoggerAdapter.getLogger(AbstractLoggerAdapter.java:47)
at
org.apache.logging.slf4j.Log4jLoggerFactory.getLogger(Log4jLoggerFactory.java:33)
at org.slf4j.LoggerFactory.getLogger(LoggerFactory.java:358) at
org.slf4j.LoggerFactory.getLogger(LoggerFactory.java:383) at
org.apache.hbase.HBCK2.(HBCK2.java:92) {code}
The Reason.
The current version of HBase uses version 2.17.2 of log4j2, which supports
shorthand syntax for properties configuration ( LOG4J2-3341 :
https://issues.apache.org/jira/browse/LOG4J2-3341).
However, The current version of HBCK2 uses version 2.17.1 of log4j2, which does
not support the feature.
So, we would get IndexOutOfBoundsException when HBCK2 uses as following log4j2
properties, and this is the default log configuration format for HBase
logger.http = INFO,NullAppender
In order to avoid this problem, I think we need bump log4j2 from 2.17.1 to
2.17.2 against HBCK2.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] HBASE-28527: Adjust BlockCacheKey to use the file path instead of file name. [hbase]
jhungund commented on code in PR #5832:
URL: https://github.com/apache/hbase/pull/5832#discussion_r1568762667
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java:
##
@@ -530,8 +530,8 @@ public HRegionServer(final Configuration conf) throws
IOException {
regionServerAccounting = new RegionServerAccounting(conf);
- blockCache = BlockCacheFactory.createBlockCache(conf);
DataTieringManager.instantiate(onlineRegions);
+ blockCache = BlockCacheFactory.createBlockCache(conf);
Review Comment:
Instantiation of Data tiering manager is required to read the cache from
persistence. Hence, change the order here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] HBASE-28527: Adjust BlockCacheKey to use the file path instead of file name. [hbase]
jhungund commented on code in PR #5832:
URL: https://github.com/apache/hbase/pull/5832#discussion_r1568760594
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketProtoUtils.java:
##
@@ -130,10 +136,30 @@ static Pair, NavigableSet result = new
ConcurrentHashMap<>();
NavigableSet resultSet = new
ConcurrentSkipListSet<>(Comparator
.comparing(BlockCacheKey::getHfileName).thenComparingLong(BlockCacheKey::getOffset));
+
+Map allFilePaths = null;
+DataTieringManager dataTieringManager;
+try {
+ dataTieringManager = DataTieringManager.getInstance();
+ allFilePaths = dataTieringManager.getAllFilesList();
+} catch (IllegalStateException e) {
+ // Data-Tiering manager has not been set up.
+ // Ignore the error and proceed with the normal flow.
+ LOG.warn("Error while getting DataTieringManager instance: {}",
e.getMessage());
+}
+
for (BucketCacheProtos.BackingMapEntry entry : backingMap.getEntryList()) {
BucketCacheProtos.BlockCacheKey protoKey = entry.getKey();
- BlockCacheKey key = new BlockCacheKey(protoKey.getHfilename(),
protoKey.getOffset(),
-protoKey.getPrimaryReplicaBlock(), fromPb(protoKey.getBlockType()));
+
+ BlockCacheKey key = null;
+ if (allFilePaths != null) {
+key = new BlockCacheKey(allFilePaths.get(protoKey.getHfilename()),
protoKey.getOffset(),
+ protoKey.getPrimaryReplicaBlock(), fromPb(protoKey.getBlockType()));
+ } else {
+key = new BlockCacheKey(new Path(protoKey.getHfilename()),
protoKey.getOffset(),
Review Comment:
This call will set the file name appropriately to protoKey.getHfilename().
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] HBASE-28527: Adjust BlockCacheKey to use the file path instead of file name. [hbase]
jhungund opened a new pull request, #5832: URL: https://github.com/apache/hbase/pull/5832 The time-based priority eviction policy relies on the presence of path in the BlockCacheKey to fetch the required metadata to check data hotness and decide whether or not to retain the block in the bucket cache. Hence, the constructor of BlockCacheKey is adjusted to take the file path as the input parameter. The code paths that create the blockCacheKey and also the unit tests need to be adjusted to pass the path instead of file name. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28521 Use standard ConnectionRegistry and Client API to get reg… [hbase]
Apache-HBase commented on PR #5825: URL: https://github.com/apache/hbase/pull/5825#issuecomment-2061063197 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 20s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 28s | master passed | | +1 :green_heart: | compile | 0m 42s | master passed | | +1 :green_heart: | shadedjars | 5m 9s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 26s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 26s | the patch passed | | +1 :green_heart: | compile | 0m 41s | the patch passed | | +1 :green_heart: | javac | 0m 41s | the patch passed | | +1 :green_heart: | shadedjars | 5m 14s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 25s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 252m 58s | hbase-server in the patch failed. | | | | 275m 28s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5825/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5825 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux f466adda45c4 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 16e9affca3 | | Default Java | Temurin-1.8.0_352-b08 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5825/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5825/2/testReport/ | | Max. process+thread count | 5386 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5825/2/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28521 Use standard ConnectionRegistry and Client API to get reg… [hbase]
Apache-HBase commented on PR #5825: URL: https://github.com/apache/hbase/pull/5825#issuecomment-2061029976 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 57s | master passed | | +1 :green_heart: | compile | 0m 54s | master passed | | +1 :green_heart: | shadedjars | 6m 24s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 26s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 17s | the patch passed | | +1 :green_heart: | compile | 0m 47s | the patch passed | | +1 :green_heart: | javac | 0m 47s | the patch passed | | +1 :green_heart: | shadedjars | 6m 4s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 23s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 228m 28s | hbase-server in the patch failed. | | | | 255m 19s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5825/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5825 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 50a40cecd39c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 16e9affca3 | | Default Java | Eclipse Adoptium-11.0.17+8 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5825/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5825/2/testReport/ | | Max. process+thread count | 6021 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5825/2/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28521 Use standard ConnectionRegistry and Client API to get reg… [hbase]
Apache-HBase commented on PR #5825: URL: https://github.com/apache/hbase/pull/5825#issuecomment-2061019666 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 1s | master passed | | +1 :green_heart: | compile | 0m 52s | master passed | | +1 :green_heart: | shadedjars | 5m 11s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 30s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 47s | the patch passed | | +1 :green_heart: | compile | 0m 58s | the patch passed | | +1 :green_heart: | javac | 0m 58s | the patch passed | | +1 :green_heart: | shadedjars | 5m 5s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 29s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 225m 17s | hbase-server in the patch failed. | | | | 249m 27s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5825/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5825 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux a9153312126a 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 16e9affca3 | | Default Java | Eclipse Adoptium-17.0.10+7 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5825/2/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5825/2/testReport/ | | Max. process+thread count | 4705 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5825/2/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28500 Rest Java client library assumes stateless servers (Adden… [hbase]
petersomogyi commented on PR #5831: URL: https://github.com/apache/hbase/pull/5831#issuecomment-2060956025 The reported spotbugs failure is before applying the patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (HBASE-28530) Better not use threads when parallel seek enabled and only one storescanner to seek
Rajeshbabu Chintaguntla created HBASE-28530:
---
Summary: Better not use threads when parallel seek enabled and
only one storescanner to seek
Key: HBASE-28530
URL: https://issues.apache.org/jira/browse/HBASE-28530
Project: HBase
Issue Type: Improvement
Reporter: Rajeshbabu Chintaguntla
Assignee: Rajeshbabu Chintaguntla
When parallel seek enabled, seeking through the scanners using multiple threads
and waiting on the countdown lock to complete the seek on all the scanners. It
would be better not to use threads when there is only one scanners to seek.
Might not be significant improvement but will be useful when a region has one
store file post major compaction.
{code:java}
private void parallelSeek(final List scanners,
final Cell kv)
throws IOException {
if (scanners.isEmpty()) return;
int storeFileScannerCount = scanners.size();
CountDownLatch latch = new CountDownLatch(storeFileScannerCount);
List handlers = new ArrayList<>(storeFileScannerCount);
for (KeyValueScanner scanner : scanners) {
if (scanner instanceof StoreFileScanner) {
ParallelSeekHandler seekHandler = new ParallelSeekHandler(scanner, kv,
this.readPt, latch);
executor.submit(seekHandler);
handlers.add(seekHandler);
} else {
scanner.seek(kv);
latch.countDown();
}
}
try {
latch.await();
} catch (InterruptedException ie) {
throw (InterruptedIOException) new InterruptedIOException().initCause(ie);
}
{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-28520) CVE-2024-29131 resolution
[ https://issues.apache.org/jira/browse/HBASE-28520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838060#comment-17838060 ] Ashwini Soni commented on HBASE-28520: -- Which hadoop dependency? Is it hadoop-common? Can you name the jar file or the maven dependency? > CVE-2024-29131 resolution > - > > Key: HBASE-28520 > URL: https://issues.apache.org/jira/browse/HBASE-28520 > Project: HBase > Issue Type: Bug >Reporter: Ashwini Soni >Priority: Major > > The CVE-2024-29131 is related to the package > org.apache.commons:commons-configuration2. The current version used is 2.1.1. > This needs to be upgraded to 2.10.1. > I tried upgrading it. When commons-configuration2 is upgraded to 2.10.1 then > the below error occurs in hbase-master: > > > > Exception in thread "main" java.lang.NoSuchMethodError: > org.apache.commons.text.lookup.StringLookupFactory.base64DecoderStringLookup()Lorg/apache/commons/text/lookup/StringLookup; > at > org.apache.commons.configuration2.interpol.DefaultLookups.(DefaultLookups.java:68) > at > org.apache.commons.configuration2.interpol.ConfigurationInterpolator$DefaultPrefixLookupsHolder.createDefaultLookups(ConfigurationInterpolator.java:647) > at > org.apache.commons.configuration2.interpol.ConfigurationInterpolator$DefaultPrefixLookupsHolder.(ConfigurationInterpolator.java:627) > at > org.apache.commons.configuration2.interpol.ConfigurationInterpolator$DefaultPrefixLookupsHolder.(ConfigurationInterpolator.java:614) > at > org.apache.commons.configuration2.interpol.ConfigurationInterpolator.getDefaultPrefixLookups(ConfigurationInterpolator.java:290) > at > org.apache.commons.configuration2.AbstractConfiguration.installDefaultInterpolator(AbstractConfiguration.java:378) > at > org.apache.commons.configuration2.AbstractConfiguration.(AbstractConfiguration.java:125) > at > org.apache.commons.configuration2.BaseConfiguration.(BaseConfiguration.java:36) > at > org.apache.commons.configuration2.PropertiesConfiguration.(PropertiesConfiguration.java:1060) > at > org.apache.hadoop.metrics2.impl.MetricsConfig.loadFirst(MetricsConfig.java:114) > at > org.apache.hadoop.metrics2.impl.MetricsConfig.create(MetricsConfig.java:97) > at > org.apache.hadoop.metrics2.impl.MetricsSystemImpl.configure(MetricsSystemImpl.java:482) > at > org.apache.hadoop.metrics2.impl.MetricsSystemImpl.start(MetricsSystemImpl.java:188) > at > org.apache.hadoop.metrics2.impl.MetricsSystemImpl.init(MetricsSystemImpl.java:163) > at > org.apache.hadoop.metrics2.lib.DefaultMetricsSystem.init(DefaultMetricsSystem.java:62) > at > org.apache.hadoop.metrics2.lib.DefaultMetricsSystem.initialize(DefaultMetricsSystem.java:58) > at > org.apache.hadoop.hbase.metrics.BaseSourceImpl$DefaultMetricsSystemInitializer.init(BaseSourceImpl.java:54) > at > org.apache.hadoop.hbase.metrics.BaseSourceImpl.(BaseSourceImpl.java:112) > at > org.apache.hadoop.hbase.metrics.ExceptionTrackingSourceImpl.(ExceptionTrackingSourceImpl.java:47) > at > org.apache.hadoop.hbase.thrift.MetricsThriftServerSourceImpl.(MetricsThriftServerSourceImpl.java:54) > at > org.apache.hadoop.hbase.thrift.MetricsThriftServerSourceFactoryImpl.createThriftOneSource(MetricsThriftServerSourceFactoryImpl.java:43) > at > org.apache.hadoop.hbase.thrift.ThriftMetrics.(ThriftMetrics.java:75) > at > org.apache.hadoop.hbase.thrift.ThriftServer.createThriftMetrics(ThriftServer.java:200) > at > org.apache.hadoop.hbase.thrift.ThriftServer.setupParamters(ThriftServer.java:228) > at > org.apache.hadoop.hbase.thrift.ThriftServer.run(ThriftServer.java:830) > at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76) > at > org.apache.hadoop.hbase.thrift.ThriftServer.main(ThriftServer.java:861) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-28528) Improvements in HFile prefetch
[
https://issues.apache.org/jira/browse/HBASE-28528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838051#comment-17838051
]
Wellington Chevreuil commented on HBASE-28528:
--
Thanks for the follow up, [~rajeshbabu]. I have some thoughts:
{quote}
Currently hfile prefetch on open is configurable cluster wise. Would be better
to make it table wise configurable.
{quote}
Yeah, I think that should be helpful. Right now, the closest we have to this
would be to disable BLOCKCACHE entirely in the CF config (see HBASE-28217).
{quote}
Also would be better to have region filters which can allow to specify which
regions data can be prefetched.
{quote}
That's interesting indeed, however it would be a bit more sophisticated, as
regions are a dynamic structure. I guess this would require an additional
qualifier in the meta table and then additional API/shell commands to set this.
> Improvements in HFile prefetch
> --
>
> Key: HBASE-28528
> URL: https://issues.apache.org/jira/browse/HBASE-28528
> Project: HBase
> Issue Type: Improvement
>Reporter: Rajeshbabu Chintaguntla
>Assignee: Rajeshbabu Chintaguntla
>Priority: Major
>
> Currently hfile prefetch on open is configurable cluster wise. Would be
> better to make it table wise configurable. Also would be better to have
> region filters which can allow to specify which regions data can be
> prefetched. This will be useful when there are hot regions whose data
> prefetching can help for low latency requirements.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] HBASE-28509 ScanResumer.resume would perform unnecessary scan when cl… [hbase]
comnetwork commented on code in PR #5817:
URL: https://github.com/apache/hbase/pull/5817#discussion_r1565142498
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncTableResultScanner.java:
##
@@ -143,6 +144,18 @@ private void resumePrefetch() {
resumer = null;
}
+ private void termianteResumerIfPossible() {
+if (resumer == null) {
+ return;
+}
+if (resumer instanceof ScanResumerImpl) {
+ ((ScanResumerImpl) resumer).terminate();
Review Comment:
@Apache9, Thank you for suggestion, I have added more comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] HBASE-28500 Rest Java client library assumes stateless servers (Adden… [hbase]
Apache-HBase commented on PR #5831: URL: https://github.com/apache/hbase/pull/5831#issuecomment-2060654946 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 53s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 36s | master passed | | +1 :green_heart: | compile | 0m 23s | master passed | | +1 :green_heart: | shadedjars | 6m 40s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 22s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 2s | the patch passed | | +1 :green_heart: | compile | 0m 21s | the patch passed | | +1 :green_heart: | javac | 0m 21s | the patch passed | | +1 :green_heart: | shadedjars | 6m 52s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 22s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 4m 45s | hbase-rest in the patch passed. | | | | 30m 21s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5831/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5831 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 67b1b7f55fde 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 16e9affca3 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5831/1/testReport/ | | Max. process+thread count | 1589 (vs. ulimit of 3) | | modules | C: hbase-rest U: hbase-rest | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5831/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28500 Rest Java client library assumes stateless servers (Adden… [hbase]
Apache-HBase commented on PR #5831: URL: https://github.com/apache/hbase/pull/5831#issuecomment-2060651655 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 52s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 59s | master passed | | +1 :green_heart: | compile | 0m 20s | master passed | | +1 :green_heart: | shadedjars | 6m 20s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 14s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 29s | the patch passed | | +1 :green_heart: | compile | 0m 25s | the patch passed | | +1 :green_heart: | javac | 0m 25s | the patch passed | | +1 :green_heart: | shadedjars | 6m 22s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 12s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 5m 7s | hbase-rest in the patch passed. | | | | 28m 28s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5831/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5831 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 8260d6736341 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 16e9affca3 | | Default Java | Temurin-1.8.0_352-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5831/1/testReport/ | | Max. process+thread count | 1649 (vs. ulimit of 3) | | modules | C: hbase-rest U: hbase-rest | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5831/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28500 Rest Java client library assumes stateless servers (Adden… [hbase]
Apache-HBase commented on PR #5831: URL: https://github.com/apache/hbase/pull/5831#issuecomment-2060640724 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 2s | master passed | | +1 :green_heart: | compile | 0m 19s | master passed | | +1 :green_heart: | shadedjars | 5m 15s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 16s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 50s | the patch passed | | +1 :green_heart: | compile | 0m 19s | the patch passed | | +1 :green_heart: | javac | 0m 19s | the patch passed | | +1 :green_heart: | shadedjars | 5m 14s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 15s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 3m 27s | hbase-rest in the patch passed. | | | | 22m 33s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5831/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5831 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux b6bb8e58005f 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 16e9affca3 | | Default Java | Eclipse Adoptium-17.0.10+7 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5831/1/testReport/ | | Max. process+thread count | 1756 (vs. ulimit of 3) | | modules | C: hbase-rest U: hbase-rest | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5831/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28500 Rest Java client library assumes stateless servers (Adden… [hbase]
Apache-HBase commented on PR #5831: URL: https://github.com/apache/hbase/pull/5831#issuecomment-2060640496 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 15s | master passed | | +1 :green_heart: | compile | 0m 26s | master passed | | +1 :green_heart: | checkstyle | 0m 9s | master passed | | +1 :green_heart: | spotless | 0m 44s | branch has no errors when running spotless:check. | | -1 :x: | spotbugs | 0m 30s | hbase-rest in master has 1 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 49s | the patch passed | | +1 :green_heart: | compile | 0m 24s | the patch passed | | +1 :green_heart: | javac | 0m 24s | the patch passed | | +1 :green_heart: | checkstyle | 0m 8s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 5m 21s | Patch does not cause any errors with Hadoop 3.3.6. | | +1 :green_heart: | spotless | 0m 41s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 0m 33s | hbase-rest generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 9s | The patch does not generate ASF License warnings. | | | | 22m 23s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5831/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5831 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 433792a048cb 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 16e9affca3 | | Default Java | Eclipse Adoptium-11.0.17+8 | | spotbugs | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5831/1/artifact/yetus-general-check/output/branch-spotbugs-hbase-rest-warnings.html | | Max. process+thread count | 84 (vs. ulimit of 3) | | modules | C: hbase-rest U: hbase-rest | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5831/1/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28521 Use standard ConnectionRegistry and Client API to get reg… [hbase]
Apache-HBase commented on PR #5825: URL: https://github.com/apache/hbase/pull/5825#issuecomment-2060588267 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 46s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 52s | master passed | | +1 :green_heart: | compile | 3m 19s | master passed | | +1 :green_heart: | checkstyle | 0m 45s | master passed | | +1 :green_heart: | spotless | 1m 8s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 2m 9s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 19s | the patch passed | | +1 :green_heart: | compile | 2m 36s | the patch passed | | +1 :green_heart: | javac | 2m 36s | the patch passed | | +1 :green_heart: | checkstyle | 0m 33s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 5m 42s | Patch does not cause any errors with Hadoop 3.3.6. | | +1 :green_heart: | spotless | 0m 43s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 42s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 11s | The patch does not generate ASF License warnings. | | | | 33m 50s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5825/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5825 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux d5e69ca95191 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 16e9affca3 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Max. process+thread count | 82 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5825/2/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-26974 Introduce a LogRollProcedure [hbase]
frostruan commented on PR #5408: URL: https://github.com/apache/hbase/pull/5408#issuecomment-2060558485 Will push the newest code as soon as possible. Thanks Duo ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] HBASE-28500 Rest Java client library assumes stateless servers (Adden… [hbase]
stoty opened a new pull request, #5831: URL: https://github.com/apache/hbase/pull/5831 …dum:fix spotbugs warning) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-28529) Use ZKClientConfig instead of system properties when setting zookeeper configurations
[ https://issues.apache.org/jira/browse/HBASE-28529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-28529: -- Component/s: Zookeeper > Use ZKClientConfig instead of system properties when setting zookeeper > configurations > - > > Key: HBASE-28529 > URL: https://issues.apache.org/jira/browse/HBASE-28529 > Project: HBase > Issue Type: Improvement > Components: Zookeeper >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > > In HBASE-28340, we allow loading zookeeper configurations from hbase > configurations, but then we use system properties to pass these parameters > when creating zookeeper client. > For replication, we may want to use different zookeeper configurations > comparing to the ones we use for starting this hbase cluster, so using system > properties to pass these parameters is not suitable then. > We should make use of ZKClientConfig to pass these flags. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-28529) Use ZKClientConfig instead of system properties when setting zookeeper configurations
[ https://issues.apache.org/jira/browse/HBASE-28529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838003#comment-17838003 ] Duo Zhang commented on HBASE-28529: --- [~andor] FYI. [~bszabolcs] [~wchevreuil] I will provide a PR soon. You guys could see if this is enough for addressing HBASE-28464, by setting configurations in replication peer config, instead of implementing a special replication endpoint. Thanks. > Use ZKClientConfig instead of system properties when setting zookeeper > configurations > - > > Key: HBASE-28529 > URL: https://issues.apache.org/jira/browse/HBASE-28529 > Project: HBase > Issue Type: Improvement > Components: Zookeeper >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > > In HBASE-28340, we allow loading zookeeper configurations from hbase > configurations, but then we use system properties to pass these parameters > when creating zookeeper client. > For replication, we may want to use different zookeeper configurations > comparing to the ones we use for starting this hbase cluster, so using system > properties to pass these parameters is not suitable then. > We should make use of ZKClientConfig to pass these flags. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (HBASE-28529) Use ZKClientConfig instead of system properties when setting zookeeper configurations
Duo Zhang created HBASE-28529: - Summary: Use ZKClientConfig instead of system properties when setting zookeeper configurations Key: HBASE-28529 URL: https://issues.apache.org/jira/browse/HBASE-28529 Project: HBase Issue Type: Improvement Reporter: Duo Zhang In HBASE-28340, we allow loading zookeeper configurations from hbase configurations, but then we use system properties to pass these parameters when creating zookeeper client. For replication, we may want to use different zookeeper configurations comparing to the ones we use for starting this hbase cluster, so using system properties to pass these parameters is not suitable then. We should make use of ZKClientConfig to pass these flags. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work started] (HBASE-28529) Use ZKClientConfig instead of system properties when setting zookeeper configurations
[ https://issues.apache.org/jira/browse/HBASE-28529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-28529 started by Duo Zhang. - > Use ZKClientConfig instead of system properties when setting zookeeper > configurations > - > > Key: HBASE-28529 > URL: https://issues.apache.org/jira/browse/HBASE-28529 > Project: HBase > Issue Type: Improvement >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > > In HBASE-28340, we allow loading zookeeper configurations from hbase > configurations, but then we use system properties to pass these parameters > when creating zookeeper client. > For replication, we may want to use different zookeeper configurations > comparing to the ones we use for starting this hbase cluster, so using system > properties to pass these parameters is not suitable then. > We should make use of ZKClientConfig to pass these flags. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (HBASE-28529) Use ZKClientConfig instead of system properties when setting zookeeper configurations
[ https://issues.apache.org/jira/browse/HBASE-28529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-28529: - Assignee: Duo Zhang > Use ZKClientConfig instead of system properties when setting zookeeper > configurations > - > > Key: HBASE-28529 > URL: https://issues.apache.org/jira/browse/HBASE-28529 > Project: HBase > Issue Type: Improvement >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > > In HBASE-28340, we allow loading zookeeper configurations from hbase > configurations, but then we use system properties to pass these parameters > when creating zookeeper client. > For replication, we may want to use different zookeeper configurations > comparing to the ones we use for starting this hbase cluster, so using system > properties to pass these parameters is not suitable then. > We should make use of ZKClientConfig to pass these flags. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-26974) Introduce a LogRollProcedure
[ https://issues.apache.org/jira/browse/HBASE-26974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HBASE-26974: --- Labels: pull-request-available (was: ) > Introduce a LogRollProcedure > > > Key: HBASE-26974 > URL: https://issues.apache.org/jira/browse/HBASE-26974 > Project: HBase > Issue Type: Improvement > Components: backuprestore, proc-v2 >Reporter: ruanhui >Assignee: ruanhui >Priority: Minor > Labels: pull-request-available > Fix For: 3.0.0-beta-2 > > > The current log-rolling for all regionservers is based in ZK. Here is an > attempt to reimplement it with procedure v2. > Here are some requirements about the implementation. > The procedure can be introduced as a new feature. It should remain fully > compatible with previous implementations. Also, this feature can be disabled > by the configuration. Currently we only use the logroll procedure when taking > a backup job, so I think all code logic should be implemented in the > hbase-backup module as much as possible(I'm not sure if this is the right way > to do it. If you have any suggestions, please let me know). > Here are some details about the implementation. > *LogRollProcedure* > The LogRollProcedure is used to roll WAL for all the regionservers in the > cluster. It acquires the shared lock of the backup system table. > *RSLogRollProcedure* > The RSLogRollProcedure is used to schedule a RSLogRollRemoteProcedure for > each regionserver. When the subprocedure returns, the RSLogRollProcedure will > check the logrolling result in the backup system table. If failed, The > RSLogRollProcedure will schedule a new RSLogRollRemoteProcedure to retry. > *RSLogRollRemoteProcedure* > The RSLogRollRemoteProcedure is used to send the log roll request to the > remote server. > This is only the first version implementation, any suggestions and feedbacks > are appreciated. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] HBASE-26974 Introduce a LogRollProcedure [hbase]
Apache9 commented on PR #5408: URL: https://github.com/apache/hbase/pull/5408#issuecomment-2060519013 Any updates here? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28150 CreateTableProcedure and DeleteTableProcedure should slee… [hbase]
Apache9 commented on code in PR #5502:
URL: https://github.com/apache/hbase/pull/5502#discussion_r1568321401
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/DeleteTableProcedure.java:
##
@@ -133,12 +139,25 @@ protected Flow executeFromState(final MasterProcedureEnv
env, DeleteTableState s
if (isRollbackSupported(state)) {
setFailure("master-delete-table", e);
} else {
-LOG.warn("Retriable error trying to delete table=" + getTableName() +
" state=" + state, e);
+if (retryCounter == null) {
+ retryCounter =
ProcedureUtil.createRetryCounter(env.getMasterConfiguration());
+}
+long backoff = retryCounter.getBackoffTimeAndIncrementAttempts();
+LOG.warn("Retriable error trying to delete table={},state={},suspend
{}secs.",
+ getTableName(), state, backoff / 1000, e);
+throw suspend(Math.toIntExact(backoff), true);
}
}
return Flow.HAS_MORE_STATE;
Review Comment:
Ditto.
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/CreateTableProcedure.java:
##
@@ -137,12 +143,25 @@ protected Flow executeFromState(final MasterProcedureEnv
env, final CreateTableS
if (isRollbackSupported(state)) {
setFailure("master-create-table", e);
} else {
-LOG.warn("Retriable error trying to create table=" + getTableName() +
" state=" + state, e);
+if (retryCounter == null) {
+ retryCounter =
ProcedureUtil.createRetryCounter(env.getMasterConfiguration());
+}
+long backoff = retryCounter.getBackoffTimeAndIncrementAttempts();
+LOG.warn("Retriable error trying to create table={},state={},suspend
{}secs.",
+ getTableName(), state, backoff / 1000, e);
+throw suspend(Math.toIntExact(backoff), true);
}
}
return Flow.HAS_MORE_STATE;
Review Comment:
You need to reset the retryCounter to null here. The reason for resetting is
that, if we have successfully finished one step, we should reset the
retryCounter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (HBASE-28150) CreateTableProcedure and DeleteTableProcedure should sleep a while before retrying
[
https://issues.apache.org/jira/browse/HBASE-28150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HBASE-28150:
---
Labels: pull-request-available (was: )
> CreateTableProcedure and DeleteTableProcedure should sleep a while before
> retrying
> --
>
> Key: HBASE-28150
> URL: https://issues.apache.org/jira/browse/HBASE-28150
> Project: HBase
> Issue Type: Improvement
> Components: master, proc-v2
>Affects Versions: 2.4.14
>Reporter: chaijunjie
>Assignee: chaijunjie
>Priority: Major
> Labels: pull-request-available
> Attachments: HBASE-28150.patch
>
>
> create a table, but it failed when execute CREATE_TABLE_WRITE_FS_LAYOUT, then
> will try again and again, will write too many proc record to master:store, we
> find num of the master WAL in oldWALs more than 13000..
>
> Q: should add a suspend time logic for create table proc retry? i see
> TransitRegionStateProcedure has the logic..
>
> ---
> sorry, i upload screenshot failed, just copy to here
> {code:java}
> // 2023-10-12 12:34:35,360 | INFO | RegionOpenAndInit-themis:a-pool-0 |
> Closing region themis:a,,1697025107991.513d3d5b4d3ad5c8f13bacea4a888d69. |
> org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1688)
> 2023-10-12 12:34:35,360 | INFO | RegionOpenAndInit-themis:a-pool-0 | Closed
> themis:a,,1697025107991.513d3d5b4d3ad5c8f13bacea4a888d69. |
> org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1900)
> 2023-10-12 12:34:35,360 | INFO | PEWorker-1 | Region directories are created
> at hdfs://hacluster/hbase/.tmp for table themis:a |
> org.apache.hadoop.hbase.master.procedure.CreateTableProcedure.createFsLayout(CreateTableProcedure.java:346)
> 2023-10-12 12:34:35,362 | WARN | PEWorker-1 | Retriable error trying to
> create table=themis:a state=CREATE_TABLE_WRITE_FS_LAYOUT |
> org.apache.hadoop.hbase.master.procedure.CreateTableProcedure.executeFromState(CreateTableProcedure.java:159)
> java.io.IOException: Unable to move table from
> temp=hdfs://hacluster/hbase/.tmp/data/themis/a to hbase
> root=hdfs://hacluster/hbase/data/themis/a
> at
> org.apache.hadoop.hbase.master.procedure.CreateTableProcedure.moveTempDirectoryToHBaseRoot(CreateTableProcedure.java:391)
> at
> org.apache.hadoop.hbase.master.procedure.CreateTableProcedure.createFsLayout(CreateTableProcedure.java:350)
> at
> org.apache.hadoop.hbase.master.procedure.CreateTableProcedure.createFsLayout(CreateTableProcedure.java:318)
> at
> org.apache.hadoop.hbase.master.procedure.CreateTableProcedure.executeFromState(CreateTableProcedure.java:121)
> at
> org.apache.hadoop.hbase.master.procedure.CreateTableProcedure.executeFromState(CreateTableProcedure.java:75)
> at
> org.apache.hadoop.hbase.procedure2.StateMachineProcedure.execute(StateMachineProcedure.java:188)
> at
> org.apache.hadoop.hbase.procedure2.Procedure.doExecute(Procedure.java:922)
> at
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execProcedure(ProcedureExecutor.java:1650)
> at
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeProcedure(ProcedureExecutor.java:1396)
> at
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$1000(ProcedureExecutor.java:75)
> at
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.runProcedure(ProcedureExecutor.java:1962)
> at org.apache.hadoop.hbase.trace.TraceUtil.trace(TraceUtil.java:221)
> at
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.run(ProcedureExecutor.java:1988)
> 2023-10-12 12:34:35,387 | INFO | PEWorker-1 | pid=917,
> state=RUNNABLE:CREATE_TABLE_WRITE_FS_LAYOUT, locked=true;
> CreateTableProcedure table=themis:a execute
> state=CREATE_TABLE_WRITE_FS_LAYOUT |
> org.apache.hadoop.hbase.master.procedure.CreateTableProcedure.executeFromState(CreateTableProcedure.java:102)
> 2023-10-12 12:34:35,414 | INFO | RegionOpenAndInit-themis:a-pool-0 |
> creating {ENCODED => 513d3d5b4d3ad5c8f13bacea4a888d69, NAME =>
> 'themis:a,,1697025107991.513d3d5b4d3ad5c8f13bacea4a888d69.', STARTKEY => '',
> ENDKEY => ''}, tableDescriptor='themis:a', {NAME => 'f1', BLOOMFILTER =>
> 'ROW', IN_MEMORY => 'false', VERSIONS => '1', KEEP_DELETED_CELLS => 'FALSE',
> DATA_BLOCK_ENCODING => 'NONE', COMPRESSION => 'NONE', TTL => 'FOREVER',
> MIN_VERSIONS => '0', BLOCKCACHE => 'true', BLOCKSIZE => '65536',
> REPLICATION_SCOPE => '0'}, regionDir=hdfs://hacluster/hbase/.tmp |
> org.apache.hadoop.hbase.regionserver.HRegion.createHRegion(HRegion.java:7906)
> 2023-10-12 12:34:35,432 | INFO | RegionOpenAndInit-themis:a-pool-0 | Waiting
> for
[jira] [Commented] (HBASE-28500) Rest Java client library assumes stateless servers
[
https://issues.apache.org/jira/browse/HBASE-28500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837990#comment-17837990
]
Hudson commented on HBASE-28500:
Results for branch branch-2
[build #1032 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1032/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1032/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1032/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1032/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1032/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Rest Java client library assumes stateless servers
> --
>
> Key: HBASE-28500
> URL: https://issues.apache.org/jira/browse/HBASE-28500
> Project: HBase
> Issue Type: Bug
> Components: REST
>Reporter: Istvan Toth
>Assignee: Istvan Toth
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.6.0, 2.4.18, 4.0.0-alpha-1, 2.7.0, 3.0.0-beta-2, 2.5.9
>
>
> The Rest Java client library accepts a list of rest servers, and does random
> load balancing between them for each request.
> This does not work for scans, which do have state on the rest server instance.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-28292) Make Delay prefetch property to be dynamically configured
[
https://issues.apache.org/jira/browse/HBASE-28292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837991#comment-17837991
]
Hudson commented on HBASE-28292:
Results for branch branch-2
[build #1032 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1032/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1032/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1032/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1032/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1032/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Make Delay prefetch property to be dynamically configured
> -
>
> Key: HBASE-28292
> URL: https://issues.apache.org/jira/browse/HBASE-28292
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 2.6.0, 2.4.17, 3.0.0-beta-1, 4.0.0-alpha-1, 2.7.0, 2.5.8
>Reporter: Abhishek Kothalikar
>Assignee: Abhishek Kothalikar
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.6.0, 2.4.18, 3.0.0, 4.0.0-alpha-1, 2.7.0, 2.5.9
>
> Attachments: HBASE-28292.docx
>
>
> Make the prefetch delay configurable. The prefetch delay is associated to
> hbase.hfile.prefetch.delay configuration. There are some cases where
> configuring hbase.hfile.prefetch.delay would help in achieving better
> throughput.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-28518) Allow specifying a filter for the REST multiget endpoint
[
https://issues.apache.org/jira/browse/HBASE-28518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837989#comment-17837989
]
Hudson commented on HBASE-28518:
Results for branch branch-2
[build #1032 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1032/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1032/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1032/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1032/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1032/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Allow specifying a filter for the REST multiget endpoint
>
>
> Key: HBASE-28518
> URL: https://issues.apache.org/jira/browse/HBASE-28518
> Project: HBase
> Issue Type: Improvement
> Components: REST
>Reporter: Istvan Toth
>Assignee: Istvan Toth
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.6.0, 2.4.18, 4.0.0-alpha-1, 2.7.0, 3.0.0-beta-2, 2.5.9
>
>
> The native HBase API allows specifying Filters for get operations.
> The REST interface does not currently expose this functionality.
> Add a parameter to the multiget enpoint to allow specifying filters.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (HBASE-28528) Improvements in HFile prefetch
Rajeshbabu Chintaguntla created HBASE-28528: --- Summary: Improvements in HFile prefetch Key: HBASE-28528 URL: https://issues.apache.org/jira/browse/HBASE-28528 Project: HBase Issue Type: Improvement Reporter: Rajeshbabu Chintaguntla Assignee: Rajeshbabu Chintaguntla Currently hfile prefetch on open is configurable cluster wise. Would be better to make it table wise configurable. Also would be better to have region filters which can allow to specify which regions data can be prefetched. This will be useful when there are hot regions whose data prefetching can help for low latency requirements. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (HBASE-28527) Adjust BlockCacheKey to use the file path instead of file name.
[ https://issues.apache.org/jira/browse/HBASE-28527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Janardhan Hungund reassigned HBASE-28527: - Assignee: Janardhan Hungund > Adjust BlockCacheKey to use the file path instead of file name. > --- > > Key: HBASE-28527 > URL: https://issues.apache.org/jira/browse/HBASE-28527 > Project: HBase > Issue Type: Task > Components: BucketCache >Reporter: Janardhan Hungund >Assignee: Janardhan Hungund >Priority: Major > > The time-based priority eviction policy relies on the presence of path in the > BlockCacheKey to fetch the required metadata to check data hotness and decide > whether or not to retain the block in the bucket cache. > Hence, the constructor of BlockCacheKey is adjusted to take the file path as > the input parameter. The code paths that create the blockCacheKey and also > the unit tests need to be adjusted to pass the path instead of file name. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work started] (HBASE-28527) Adjust BlockCacheKey to use the file path instead of file name.
[ https://issues.apache.org/jira/browse/HBASE-28527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-28527 started by Janardhan Hungund. - > Adjust BlockCacheKey to use the file path instead of file name. > --- > > Key: HBASE-28527 > URL: https://issues.apache.org/jira/browse/HBASE-28527 > Project: HBase > Issue Type: Task > Components: BucketCache >Reporter: Janardhan Hungund >Assignee: Janardhan Hungund >Priority: Major > > The time-based priority eviction policy relies on the presence of path in the > BlockCacheKey to fetch the required metadata to check data hotness and decide > whether or not to retain the block in the bucket cache. > Hence, the constructor of BlockCacheKey is adjusted to take the file path as > the input parameter. The code paths that create the blockCacheKey and also > the unit tests need to be adjusted to pass the path instead of file name. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (HBASE-28527) Adjust BlockCacheKey to use the file path instead of file name.
Janardhan Hungund created HBASE-28527: - Summary: Adjust BlockCacheKey to use the file path instead of file name. Key: HBASE-28527 URL: https://issues.apache.org/jira/browse/HBASE-28527 Project: HBase Issue Type: Task Components: BucketCache Reporter: Janardhan Hungund The time-based priority eviction policy relies on the presence of path in the BlockCacheKey to fetch the required metadata to check data hotness and decide whether or not to retain the block in the bucket cache. Hence, the constructor of BlockCacheKey is adjusted to take the file path as the input parameter. The code paths that create the blockCacheKey and also the unit tests need to be adjusted to pass the path instead of file name. -- This message was sent by Atlassian Jira (v8.20.10#820010)
