[jira] [Updated] (HBASE-18809) [C++] Templatize AsyncBatchRpcRetryingCaller Class

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-18809:
--
Attachment: HBASE-18809.HBASE-14850.v2.patch

Thanks for the review Enis,

Here is the updated patch with the changes.

Thanks

> [C++] Templatize AsyncBatchRpcRetryingCaller Class
> --
>
> Key: HBASE-18809
> URL: https://issues.apache.org/jira/browse/HBASE-18809
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-18809.HBASE-14850.v1.patch, 
> HBASE-18809.HBASE-14850.v2.patch
>
>
> Objective is to templatize AsyncBatchRpcRetryingCaller class to support Get, 
> Put, Delete etc request types and Result, Void response types.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18809) [C++] Templatize AsyncBatchRpcRetryingCaller Class

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-18809:
--
Attachment: HBASE-18809.HBASE-14850.v1.patch

This patch templatizes the response for Multi calls to handle hbase::Result and 
folly::Unit types. Subsequent patches will templatize the request types.

Thanks

> [C++] Templatize AsyncBatchRpcRetryingCaller Class
> --
>
> Key: HBASE-18809
> URL: https://issues.apache.org/jira/browse/HBASE-18809
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-18809.HBASE-14850.v1.patch
>
>
> Objective is to templatize AsyncBatchRpcRetryingCaller class to support Get, 
> Put, Delete etc request types and Result, Void response types.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18809) [C++] Templatize AsyncBatchRpcRetryingCaller Class

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-18809:
--
Summary: [C++] Templatize AsyncBatchRpcRetryingCaller Class  (was: 
[C++]Templatize AsyncBatchRpcRetryingCaller Class)

> [C++] Templatize AsyncBatchRpcRetryingCaller Class
> --
>
> Key: HBASE-18809
> URL: https://issues.apache.org/jira/browse/HBASE-18809
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
>
> Objective is to templatize AsyncBatchRpcRetryingCaller class to support Get, 
> Put, Delete etc request types and Result, Void response types.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (HBASE-18809) [C++]Templatize AsyncBatchRpcRetryingCaller Class

[Sudeep Sunthankar (JIRA)]

Sudeep Sunthankar created HBASE-18809:
-

 Summary: [C++]Templatize AsyncBatchRpcRetryingCaller Class
 Key: HBASE-18809
 URL: https://issues.apache.org/jira/browse/HBASE-18809
 Project: HBase
  Issue Type: Sub-task
Reporter: Sudeep Sunthankar


Objective is to templatize AsyncBatchRpcRetryingCaller class to support Get, 
Put, Delete etc request types and Result, Void response types.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (HBASE-18809) [C++]Templatize AsyncBatchRpcRetryingCaller Class

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar reassigned HBASE-18809:
-

Assignee: Sudeep Sunthankar

> [C++]Templatize AsyncBatchRpcRetryingCaller Class
> -
>
> Key: HBASE-18809
> URL: https://issues.apache.org/jira/browse/HBASE-18809
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
>
> Objective is to templatize AsyncBatchRpcRetryingCaller class to support Get, 
> Put, Delete etc request types and Result, Void response types.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18727) [C++] Don't link JNI/JVM stuff into libHbaseClient

[Sudeep Sunthankar (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159466#comment-16159466
 ] 

Sudeep Sunthankar commented on HBASE-18727:
---

Hi [~enis], 
The changes look good. Couple of points:-
# test-util directory consists code related to standalone and mini cluster. 
Instead of excluding the sources in EXCLUDE_SRC we can remove the test-util 
folder from the MODULES variable itself as follows:
{code}
MODULES := connection core exceptions security serde utils
{code}
# Also I have noticed that we have a unit-test by the name of 
connection/rpc-test-server-handler.cc. We should either change the below 
variable as follows to exclude it from the library or rename the file.
{code}
EXCLUDE_SRC := $(foreach sdir,$(SRC_DIR),$(wildcard $(sdir)/*-test*.cc))
{code}

Thanks.

> [C++] Don't link JNI/JVM stuff into libHbaseClient
> --
>
> Key: HBASE-18727
> URL: https://issues.apache.org/jira/browse/HBASE-18727
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Scott Hunt
>Priority: Minor
> Fix For: HBASE-14850
>
> Attachments: hbase-18727-v2.patch, Makefile_HBASE_18727.patch
>
>
> It doesn't seem like we should be linking the objects from the test-util 
> directory into the library, as those [I believe] are just for testing.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18507) [C++] Support for MultiPuts in AsyncBatchRpcRetryingCaller class

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-18507:
--
Attachment: HBASE-18507.HBASE-14850.v4.patch

Thanks for the review [~enis]. The attached patch has changes based on the same.

Thanks.
 

> [C++] Support for MultiPuts in AsyncBatchRpcRetryingCaller class
> 
>
> Key: HBASE-18507
> URL: https://issues.apache.org/jira/browse/HBASE-18507
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-18507.HBASE-14850.v1.patch, 
> HBASE-18507.HBASE-14850.v2.patch, HBASE-18507.HBASE-14850.v3.patch, 
> HBASE-18507.HBASE-14850.v4.patch
>
>
> We will be addressing Multi Puts changes to AsyncBatchRpcRetryingCaller class 
> here



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18507) [C++] Support for MultiPuts in AsyncBatchRpcRetryingCaller class

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-18507:
--
Attachment: HBASE-18507.HBASE-14850.v3.patch

Hi, This patch addresses points raised in the last feedback except the last one.
I'm working on multi-retry tests similar to multi gets and will upload in the 
next patch.

Thanks

> [C++] Support for MultiPuts in AsyncBatchRpcRetryingCaller class
> 
>
> Key: HBASE-18507
> URL: https://issues.apache.org/jira/browse/HBASE-18507
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-18507.HBASE-14850.v1.patch, 
> HBASE-18507.HBASE-14850.v2.patch, HBASE-18507.HBASE-14850.v3.patch
>
>
> We will be addressing Multi Puts changes to AsyncBatchRpcRetryingCaller class 
> here



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18507) [C++] Support for MultiPuts in AsyncBatchRpcRetryingCaller class

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-18507:
--
Attachment: HBASE-18507.HBASE-14850.v2.patch

- Addressed feedback from the last patch. 
- Templatized request in AsyncBatchRpc. As of now we are persisting with 
hbase::Row, which can be made more cleaner by passing the actual derived 
classes like hbase::Get and hbase::Put.

Thanks.

> [C++] Support for MultiPuts in AsyncBatchRpcRetryingCaller class
> 
>
> Key: HBASE-18507
> URL: https://issues.apache.org/jira/browse/HBASE-18507
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-18507.HBASE-14850.v1.patch, 
> HBASE-18507.HBASE-14850.v2.patch
>
>
> We will be addressing Multi Puts changes to AsyncBatchRpcRetryingCaller class 
> here



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18507) [C++] Support for MultiPuts in AsyncBatchRpcRetryingCaller class

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-18507:
--
Attachment: HBASE-18507.HBASE-14850.v1.patch

Addressed below changes:-
# Templatized AsyncBatchRpcRetryingCaller
# Added mutation PB formation in request-converter
# raw-async-table.cc will now pass vector of hbase::Row for MultiGets and 
MultiPuts

Thanks

> [C++] Support for MultiPuts in AsyncBatchRpcRetryingCaller class
> 
>
> Key: HBASE-18507
> URL: https://issues.apache.org/jira/browse/HBASE-18507
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-18507.HBASE-14850.v1.patch
>
>
> We will be addressing Multi Puts changes to AsyncBatchRpcRetryingCaller class 
> here



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (HBASE-18507) [C++] Support for MultiPuts in AsyncBatchRpcRetryingCaller class

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar reassigned HBASE-18507:
-

Assignee: Sudeep Sunthankar

> [C++] Support for MultiPuts in AsyncBatchRpcRetryingCaller class
> 
>
> Key: HBASE-18507
> URL: https://issues.apache.org/jira/browse/HBASE-18507
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
>
> We will be addressing Multi Puts changes to AsyncBatchRpcRetryingCaller class 
> here



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (HBASE-18507) [C++] Support for MultiPuts in AsyncBatchRpcRetryingCaller class

[Sudeep Sunthankar (JIRA)]

Sudeep Sunthankar created HBASE-18507:
-

 Summary: [C++] Support for MultiPuts in 
AsyncBatchRpcRetryingCaller class
 Key: HBASE-18507
 URL: https://issues.apache.org/jira/browse/HBASE-18507
 Project: HBase
  Issue Type: Sub-task
Reporter: Sudeep Sunthankar


We will be addressing Multi Puts changes to AsyncBatchRpcRetryingCaller class 
here



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18061) [C++] Fix retry logic in multi-get calls

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-18061:
--
Attachment: HBASE-18061.HBASE-14850.v9.patch

This patch consists of below changes
* Removed comments and Code cleanup done
* Replaced OnError() for exceptions in Send
* Added multi-region test in mocks
* removeErrors missing:- At the Java side, removeErrors is used to fetch last 
List for an action and then adds a new one to this 
returned list before calling completeExceptionally. I have added similar 
functionality in Add2Errors method where the vector is added with a new element 
to action2errors_ map and then the value at particular index i.e. the vector is 
passed to setException()
* replaced std::unique_lock with std::lock_guard with a recursive mutex. Tested 
with 50k and mocks with 10K records without any issues.
Thanks

> [C++] Fix retry logic in multi-get calls
> 
>
> Key: HBASE-18061
> URL: https://issues.apache.org/jira/browse/HBASE-18061
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: Sudeep Sunthankar
> Fix For: HBASE-14850
>
> Attachments: HBASE-18061.HBASE-14850.v1.patch, 
> HBASE-18061.HBASE-14850.v3.patch, HBASE-18061.HBASE-14850.v5.patch, 
> HBASE-18061.HBASE-14850.v6.patch, HBASE-18061.HBASE-14850.v7.patch, 
> HBASE-18061.HBASE-14850.v9.patch, hbase-18061-v8.patch
>
>
> HBASE-17576 adds multi-gets. There are a couple of todos to fix in the retry 
> logic, and some unit testing to be done for the multi-gets. We'll do these in 
> this issue. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18061) [C++] Fix retry logic in multi-get calls

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-18061:
--
Status: Open  (was: Patch Available)

> [C++] Fix retry logic in multi-get calls
> 
>
> Key: HBASE-18061
> URL: https://issues.apache.org/jira/browse/HBASE-18061
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: Sudeep Sunthankar
> Fix For: HBASE-14850
>
> Attachments: HBASE-18061.HBASE-14850.v1.patch, 
> HBASE-18061.HBASE-14850.v3.patch, HBASE-18061.HBASE-14850.v5.patch, 
> HBASE-18061.HBASE-14850.v6.patch, HBASE-18061.HBASE-14850.v7.patch, 
> hbase-18061-v8.patch
>
>
> HBASE-17576 adds multi-gets. There are a couple of todos to fix in the retry 
> logic, and some unit testing to be done for the multi-gets. We'll do these in 
> this issue. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18061) [C++] Fix retry logic in multi-get calls

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-18061:
--
Attachment: hbase-18061-v8.patch

Updated patch with resolution of rebaisng and compilation issues.

Thanks

> [C++] Fix retry logic in multi-get calls
> 
>
> Key: HBASE-18061
> URL: https://issues.apache.org/jira/browse/HBASE-18061
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: Sudeep Sunthankar
> Fix For: HBASE-14850
>
> Attachments: HBASE-18061.HBASE-14850.v1.patch, 
> HBASE-18061.HBASE-14850.v3.patch, HBASE-18061.HBASE-14850.v5.patch, 
> HBASE-18061.HBASE-14850.v6.patch, HBASE-18061.HBASE-14850.v7.patch, 
> hbase-18061-v8.patch
>
>
> HBASE-17576 adds multi-gets. There are a couple of todos to fix in the retry 
> logic, and some unit testing to be done for the multi-gets. We'll do these in 
> this issue. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18061) [C++] Fix retry logic in multi-get calls

[Sudeep Sunthankar (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16084716#comment-16084716
 ] 

Sudeep Sunthankar commented on HBASE-18061:
---

Thanks [~tedyu], yes I can see there are some issues. I have rectified the same 
and testing the patch. 

> [C++] Fix retry logic in multi-get calls
> 
>
> Key: HBASE-18061
> URL: https://issues.apache.org/jira/browse/HBASE-18061
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: Sudeep Sunthankar
> Fix For: HBASE-14850
>
> Attachments: HBASE-18061.HBASE-14850.v1.patch, 
> HBASE-18061.HBASE-14850.v3.patch, HBASE-18061.HBASE-14850.v5.patch, 
> HBASE-18061.HBASE-14850.v6.patch, HBASE-18061.HBASE-14850.v7.patch
>
>
> HBASE-17576 adds multi-gets. There are a couple of todos to fix in the retry 
> logic, and some unit testing to be done for the multi-gets. We'll do these in 
> this issue. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18061) [C++] Fix retry logic in multi-get calls

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-18061:
--
Attachment: HBASE-18061.HBASE-14850.v7.patch

Rebased and Updated V7 patch with the missing unit-test

Thanks.

> [C++] Fix retry logic in multi-get calls
> 
>
> Key: HBASE-18061
> URL: https://issues.apache.org/jira/browse/HBASE-18061
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: Sudeep Sunthankar
> Fix For: HBASE-14850
>
> Attachments: HBASE-18061.HBASE-14850.v1.patch, 
> HBASE-18061.HBASE-14850.v3.patch, HBASE-18061.HBASE-14850.v5.patch, 
> HBASE-18061.HBASE-14850.v6.patch, HBASE-18061.HBASE-14850.v7.patch
>
>
> HBASE-17576 adds multi-gets. There are a couple of todos to fix in the retry 
> logic, and some unit testing to be done for the multi-gets. We'll do these in 
> this issue. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18061) [C++] Fix retry logic in multi-get calls

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-18061:
--
Status: Patch Available  (was: Open)

> [C++] Fix retry logic in multi-get calls
> 
>
> Key: HBASE-18061
> URL: https://issues.apache.org/jira/browse/HBASE-18061
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: Sudeep Sunthankar
> Fix For: HBASE-14850
>
> Attachments: HBASE-18061.HBASE-14850.v1.patch, 
> HBASE-18061.HBASE-14850.v3.patch, HBASE-18061.HBASE-14850.v5.patch, 
> HBASE-18061.HBASE-14850.v6.patch, HBASE-18061.HBASE-14850.v7.patch
>
>
> HBASE-17576 adds multi-gets. There are a couple of todos to fix in the retry 
> logic, and some unit testing to be done for the multi-gets. We'll do these in 
> this issue. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18061) [C++] Fix retry logic in multi-get calls

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-18061:
--
Attachment: HBASE-18061.HBASE-14850.v6.patch

Thanks for the review [~enis]. I have uploaded a new patch with the below 
changes:-
* Cleaned up unnecessary comments and logging.
* Streamlined the mocks with Success and Failure cases.
* Formatted and lint checked.
* Moved common code in MultiGets and MultiGetsWithRegionSplits to a function.

Thanks

> [C++] Fix retry logic in multi-get calls
> 
>
> Key: HBASE-18061
> URL: https://issues.apache.org/jira/browse/HBASE-18061
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: Sudeep Sunthankar
> Fix For: HBASE-14850
>
> Attachments: HBASE-18061.HBASE-14850.v1.patch, 
> HBASE-18061.HBASE-14850.v3.patch, HBASE-18061.HBASE-14850.v5.patch, 
> HBASE-18061.HBASE-14850.v6.patch
>
>
> HBASE-17576 adds multi-gets. There are a couple of todos to fix in the retry 
> logic, and some unit testing to be done for the multi-gets. We'll do these in 
> this issue. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18061) [C++] Fix retry logic in multi-get calls

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-18061:
--
Attachment: HBASE-18061.HBASE-14850.v5.patch

V5 patch addresses the below points:-
# Mocks for AsyncRpcBatchRetryingCaller class. Have run the tests for 20 reps 
without any issues.
# Fixed a bug where we were getting deadlock issued in 
AsyncRpcBatchRetryingCaller.
#  Changed number of region servers for mini-cluster in core/client-test.cc to 
2 and Gets size increased to 20K. It was increased because of incorrect 
behavior with requests >= 10K. the mini-cluster was freezing intermittently 
because of the issue mentioned above.
# Fixed bug with incorrect handling of ActionsByServer map in 
AsyncRpcBatchRetryingCaller for tables with split regions. Added unit-tests as 
well for the same in core/client-test.cc

Thanks.

> [C++] Fix retry logic in multi-get calls
> 
>
> Key: HBASE-18061
> URL: https://issues.apache.org/jira/browse/HBASE-18061
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: Sudeep Sunthankar
> Fix For: HBASE-14850
>
> Attachments: HBASE-18061.HBASE-14850.v1.patch, 
> HBASE-18061.HBASE-14850.v3.patch, HBASE-18061.HBASE-14850.v5.patch
>
>
> HBASE-17576 adds multi-gets. There are a couple of todos to fix in the retry 
> logic, and some unit testing to be done for the multi-gets. We'll do these in 
> this issue. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18061) [C++] Fix retry logic in multi-get calls

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-18061:
--
Attachment: HBASE-18061.HBASE-14850.v3.patch

Foll changes included in the patch:-

# Added linking of krb5, ssl, crypto and pthread libraries in Makefile.
# Added exception_class_name in ResponseConverter while storing 
RemoteExceptions.
# Passing list of actions, so that we can fetch original index of the action 
when storing Result/Exception in ResponseConverter.
# Fixed a bug how we store the fetched responses in Result vector as it wasn't 
proper, (Pt. 2 above) + this change fixes the same.
# Added a unit test for for multi-gets with pre region splits and changed the 
number of requests to 10K.
# Changed the number of region servers in clien-test to 10 in mini cluster 
startup

Thanks

> [C++] Fix retry logic in multi-get calls
> 
>
> Key: HBASE-18061
> URL: https://issues.apache.org/jira/browse/HBASE-18061
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: Sudeep Sunthankar
> Fix For: HBASE-14850
>
> Attachments: HBASE-18061.HBASE-14850.v1.patch, 
> HBASE-18061.HBASE-14850.v3.patch
>
>
> HBASE-17576 adds multi-gets. There are a couple of todos to fix in the retry 
> logic, and some unit testing to be done for the multi-gets. We'll do these in 
> this issue. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Comment Edited] (HBASE-18061) [C++] Fix retry logic in multi-get calls

[Sudeep Sunthankar (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16054992#comment-16054992
 ] 

Sudeep Sunthankar edited comment on HBASE-18061 at 6/20/17 12:49 AM:
-

Deleted last patch because of some issues in Makefile in the patch



was (Author: sudeeps):
This patch consists of the foll changes:-
# Added exception_class_name in ResponseConverter while storing 
RemoteExceptions.
# Passing list of actions, so that we can fetch original index of the action 
when storing Result/Exception in ResponseConverter.
# Fixed a bug how we store the fetched responses in Result vector as it wasn't 
proper, (Pt. 2 above) + this change fixes the same.
# Added a unit test for for multi-gets with pre region splits and changed the 
number of requests to 10K.
# Changed the number of region servers in clien-test to 10 in mini cluster 
startup
# Added reviews from the last patch

Thanks.

> [C++] Fix retry logic in multi-get calls
> 
>
> Key: HBASE-18061
> URL: https://issues.apache.org/jira/browse/HBASE-18061
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: Sudeep Sunthankar
> Fix For: HBASE-14850
>
> Attachments: HBASE-18061.HBASE-14850.v1.patch
>
>
> HBASE-17576 adds multi-gets. There are a couple of todos to fix in the retry 
> logic, and some unit testing to be done for the multi-gets. We'll do these in 
> this issue. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18061) [C++] Fix retry logic in multi-get calls

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-18061:
--
Attachment: (was: HBASE-18061.HBASE-14850.v3.patch)

> [C++] Fix retry logic in multi-get calls
> 
>
> Key: HBASE-18061
> URL: https://issues.apache.org/jira/browse/HBASE-18061
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: Sudeep Sunthankar
> Fix For: HBASE-14850
>
> Attachments: HBASE-18061.HBASE-14850.v1.patch
>
>
> HBASE-17576 adds multi-gets. There are a couple of todos to fix in the retry 
> logic, and some unit testing to be done for the multi-gets. We'll do these in 
> this issue. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18061) [C++] Fix retry logic in multi-get calls

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-18061:
--
Status: Open  (was: Patch Available)

> [C++] Fix retry logic in multi-get calls
> 
>
> Key: HBASE-18061
> URL: https://issues.apache.org/jira/browse/HBASE-18061
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: Sudeep Sunthankar
> Fix For: HBASE-14850
>
> Attachments: HBASE-18061.HBASE-14850.v1.patch
>
>
> HBASE-17576 adds multi-gets. There are a couple of todos to fix in the retry 
> logic, and some unit testing to be done for the multi-gets. We'll do these in 
> this issue. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18061) [C++] Fix retry logic in multi-get calls

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-18061:
--
Status: Patch Available  (was: In Progress)

> [C++] Fix retry logic in multi-get calls
> 
>
> Key: HBASE-18061
> URL: https://issues.apache.org/jira/browse/HBASE-18061
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: Sudeep Sunthankar
> Fix For: HBASE-14850
>
> Attachments: HBASE-18061.HBASE-14850.v1.patch, 
> HBASE-18061.HBASE-14850.v3.patch
>
>
> HBASE-17576 adds multi-gets. There are a couple of todos to fix in the retry 
> logic, and some unit testing to be done for the multi-gets. We'll do these in 
> this issue. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18061) [C++] Fix retry logic in multi-get calls

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-18061:
--
Attachment: HBASE-18061.HBASE-14850.v3.patch

This patch consists of the foll changes:-
# Added exception_class_name in ResponseConverter while storing 
RemoteExceptions.
# Passing list of actions, so that we can fetch original index of the action 
when storing Result/Exception in ResponseConverter.
# Fixed a bug how we store the fetched responses in Result vector as it wasn't 
proper, (Pt. 2 above) + this change fixes the same.
# Added a unit test for for multi-gets with pre region splits and changed the 
number of requests to 10K.
# Changed the number of region servers in clien-test to 10 in mini cluster 
startup
# Added reviews from the last patch

Thanks.

> [C++] Fix retry logic in multi-get calls
> 
>
> Key: HBASE-18061
> URL: https://issues.apache.org/jira/browse/HBASE-18061
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: Sudeep Sunthankar
> Fix For: HBASE-14850
>
> Attachments: HBASE-18061.HBASE-14850.v1.patch, 
> HBASE-18061.HBASE-14850.v3.patch
>
>
> HBASE-17576 adds multi-gets. There are a couple of todos to fix in the retry 
> logic, and some unit testing to be done for the multi-gets. We'll do these in 
> this issue. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Work started] (HBASE-18061) [C++] Fix retry logic in multi-get calls

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on HBASE-18061 started by Sudeep Sunthankar.
-
> [C++] Fix retry logic in multi-get calls
> 
>
> Key: HBASE-18061
> URL: https://issues.apache.org/jira/browse/HBASE-18061
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: Sudeep Sunthankar
> Fix For: HBASE-14850
>
> Attachments: HBASE-18061.HBASE-14850.v1.patch, 
> HBASE-18061.HBASE-14850.v3.patch
>
>
> HBASE-17576 adds multi-gets. There are a couple of todos to fix in the retry 
> logic, and some unit testing to be done for the multi-gets. We'll do these in 
> this issue. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18061) [C++] Fix retry logic in multi-get calls

[Sudeep Sunthankar (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-18061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16039869#comment-16039869
 ] 

Sudeep Sunthankar commented on HBASE-18061:
---

Thanks for the review [~enis]. I will have a look at HBASE-17907. Till I get 
the mocks working, I have changed some part of the code to send requests to a 
dummy region. This results in generation of exceptions as well as retries. 

> [C++] Fix retry logic in multi-get calls
> 
>
> Key: HBASE-18061
> URL: https://issues.apache.org/jira/browse/HBASE-18061
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: Sudeep Sunthankar
> Fix For: HBASE-14850
>
> Attachments: HBASE-18061.HBASE-14850.v1.patch
>
>
> HBASE-17576 adds multi-gets. There are a couple of todos to fix in the retry 
> logic, and some unit testing to be done for the multi-gets. We'll do these in 
> this issue. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (HBASE-18061) [C++] Fix retry logic in multi-get calls

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-18061:
--
Attachment: HBASE-18061.HBASE-14850.v1.patch

This patch consists of:
# Added exception-utils for ShouldRetry() method
# Added checks for std::out_of_range and std::runtime_error in ShouldRetry()
# Standardized std::exception to folly::exception_wrapper in 
AsyncBatchRpcRetryingCaller and helper classes.
# Replaced ShouldRetry() in AsyncRpcRetryingCaller() with 
ExceptionUtils::ShouldRetry()
# Changed Makefile to link krb5, ssl, crypto and pthread libraries

Thanks.

> [C++] Fix retry logic in multi-get calls
> 
>
> Key: HBASE-18061
> URL: https://issues.apache.org/jira/browse/HBASE-18061
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: Sudeep Sunthankar
> Fix For: HBASE-14850
>
> Attachments: HBASE-18061.HBASE-14850.v1.patch
>
>
> HBASE-17576 adds multi-gets. There are a couple of todos to fix in the retry 
> logic, and some unit testing to be done for the multi-gets. We'll do these in 
> this issue. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (HBASE-18061) [C++] Fix retry logic in multi-get calls

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-18061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-18061:
--
Summary: [C++] Fix retry logic in multi-get calls  (was: Fix retry logic in 
multi-get calls)

> [C++] Fix retry logic in multi-get calls
> 
>
> Key: HBASE-18061
> URL: https://issues.apache.org/jira/browse/HBASE-18061
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: Sudeep Sunthankar
> Fix For: HBASE-14850
>
>
> HBASE-17576 adds multi-gets. There are a couple of todos to fix in the retry 
> logic, and some unit testing to be done for the multi-gets. We'll do these in 
> this issue. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (HBASE-17576) [C++] Implement request retry mechanism over RPC for Multi calls.

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-17576:
--
Attachment: HBASE-17576.HBASE-14850.v12.patch

Resubmitting the patch as BUCK was missing for compilation of 
AsyncBatchRpcRetryingCaller

Thanks

> [C++] Implement request retry mechanism over RPC for Multi calls.
> -
>
> Key: HBASE-17576
> URL: https://issues.apache.org/jira/browse/HBASE-17576
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17576.HBASE-14850.v10.patch, 
> HBASE-17576.HBASE-14850.v11.patch, HBASE-17576.HBASE-14850.v12.patch, 
> HBASE-17576.HBASE-14850.v1.patch, HBASE-17576.HBASE-14850.v2.patch, 
> HBASE-17576.HBASE-14850.v3.patch, HBASE-17576.HBASE-14850.v4.patch, 
> HBASE-17576.HBASE-14850.v5.patch, HBASE-17576.HBASE-14850.v6.patch, 
> HBASE-17576.HBASE-14850.v7.patch, HBASE-17576.HBASE-14850.v8.patch, 
> HBASE-17576.HBASE-14850.v9.patch
>
>
> This work is based on top of HBASE-17465. Multi Calls will be based on this.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (HBASE-17576) [C++] Implement request retry mechanism over RPC for Multi calls.

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-17576:
--
Attachment: (was: HBASE-17576.HBASE-14850.v12.patch)

> [C++] Implement request retry mechanism over RPC for Multi calls.
> -
>
> Key: HBASE-17576
> URL: https://issues.apache.org/jira/browse/HBASE-17576
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17576.HBASE-14850.v10.patch, 
> HBASE-17576.HBASE-14850.v11.patch, HBASE-17576.HBASE-14850.v1.patch, 
> HBASE-17576.HBASE-14850.v2.patch, HBASE-17576.HBASE-14850.v3.patch, 
> HBASE-17576.HBASE-14850.v4.patch, HBASE-17576.HBASE-14850.v5.patch, 
> HBASE-17576.HBASE-14850.v6.patch, HBASE-17576.HBASE-14850.v7.patch, 
> HBASE-17576.HBASE-14850.v8.patch, HBASE-17576.HBASE-14850.v9.patch
>
>
> This work is based on top of HBASE-17465. Multi Calls will be based on this.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (HBASE-17576) [C++] Implement request retry mechanism over RPC for Multi calls.

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-17576:
--
Attachment: HBASE-17576.HBASE-14850.v12.patch

This patch consists of:-
# AsyncBatchRpcRetryingCaller/Action classes have been changed to work with Get 
class @present.
# wait()/get() have been removed from AsyncBatchRpcRetryingCaller. table->Get() 
handles the wait.
# Tested Multigets on mini-cluster.
# Removed unnecessary logging lines from simple-client.
Thanks

> [C++] Implement request retry mechanism over RPC for Multi calls.
> -
>
> Key: HBASE-17576
> URL: https://issues.apache.org/jira/browse/HBASE-17576
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17576.HBASE-14850.v10.patch, 
> HBASE-17576.HBASE-14850.v11.patch, HBASE-17576.HBASE-14850.v12.patch, 
> HBASE-17576.HBASE-14850.v1.patch, HBASE-17576.HBASE-14850.v2.patch, 
> HBASE-17576.HBASE-14850.v3.patch, HBASE-17576.HBASE-14850.v4.patch, 
> HBASE-17576.HBASE-14850.v5.patch, HBASE-17576.HBASE-14850.v6.patch, 
> HBASE-17576.HBASE-14850.v7.patch, HBASE-17576.HBASE-14850.v8.patch, 
> HBASE-17576.HBASE-14850.v9.patch
>
>
> This work is based on top of HBASE-17465. Multi Calls will be based on this.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Comment Edited] (HBASE-17576) [C++] Implement request retry mechanism over RPC for Multi calls.

[Sudeep Sunthankar (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15997884#comment-15997884
 ] 

Sudeep Sunthankar edited comment on HBASE-17576 at 5/5/17 7:54 AM:
---

Hi [~enis], Thanks for your feedback. The attached patch consists of the foll 
changes

* As suggested, I removed the get() while getting region location and making an 
async call as it was not asynchronous. But, on dong this the functions were 
returning instantly and the lambdas were not satisfied. I suspect, the duration 
in operation_timeout() in table.cc is not large enough and the call to get() 
doesn't wait long enough.. To test this, I turned on the glog logging, and due 
to the time taken for file i/o, the lambdas had some time to execute, but it 
was still not big enough. So before inserting the lambdas, I'm calling 
folly::Future::wait() and this ensures that the lambdas are executed (Without 
the wait() call, I'm getting an exception for BrokenPromise). But, I'm still 
skeptical whether this is the correct thing to do as we are waiting for some 
'x' amount of time in ms before the callbacks are executed. Need your further 
guidance on that part.
* RawAsyncTable::Get() for multi requests now returns a 
Future>.
* action2promises_ in async-batch-rpc-retrying-caller.cc creates promises 
during construction and when AsyncBatchRpcRetryingCaller::Call() returns, we 
return those promises as a vector of futures.
* There was a regression in last couple of patches where ActionsByServer was 
changed to std::map from std::unordered_map. Have fixed that as well in this 
patch.

Thanks


was (Author: sudeeps):
Hi [~enis], Thanks for your feedback. The attached patch consists of the foll 
changes

* As suggested, I removed the get() while getting region location and making an 
async call as it was not asynchronous. But, on dong this the functions were 
returning instantly and the lambdas were not satisfied. I suspect, the duration 
in operation_timeout() in table.cc is not large enough and the call to get() 
doesn't wait long enough.. To test this, I turned on the glog logging, and due 
to the time taken for file i/o, the lambdas had some time to execute, but it 
was still not big enough. So before inserting the lambdas, I'm calling 
folly::Future::wait() and this ensures that the lambdas are executed. But, I'm 
still skeptical whether this is the correct thing to do as we are waiting for 
some 'x' amount of time in ms before the callbacks are executed. Need your 
further guidance on that part.
* RawAsyncTable::Get() for multi requests now returns a 
Future>.
* action2promises_ in async-batch-rpc-retrying-caller.cc creates promises 
during construction and when AsyncBatchRpcRetryingCaller::Call() returns, we 
return those promises as a vector of futures.
* There was a regression in last couple of patches where ActionsByServer was 
changed to std::map from std::unordered_map. Have fixed that as well in this 
patch.

Thanks

> [C++] Implement request retry mechanism over RPC for Multi calls.
> -
>
> Key: HBASE-17576
> URL: https://issues.apache.org/jira/browse/HBASE-17576
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17576.HBASE-14850.v10.patch, 
> HBASE-17576.HBASE-14850.v11.patch, HBASE-17576.HBASE-14850.v1.patch, 
> HBASE-17576.HBASE-14850.v2.patch, HBASE-17576.HBASE-14850.v3.patch, 
> HBASE-17576.HBASE-14850.v4.patch, HBASE-17576.HBASE-14850.v5.patch, 
> HBASE-17576.HBASE-14850.v6.patch, HBASE-17576.HBASE-14850.v7.patch, 
> HBASE-17576.HBASE-14850.v8.patch, HBASE-17576.HBASE-14850.v9.patch
>
>
> This work is based on top of HBASE-17465. Multi Calls will be based on this.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (HBASE-17576) [C++] Implement request retry mechanism over RPC for Multi calls.

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-17576:
--
Attachment: HBASE-17576.HBASE-14850.v11.patch

Hi [~enis], Thanks for your feedback. The attached patch consists of the foll 
changes

* As suggested, I removed the get() while getting region location and making an 
async call as it was not asynchronous. But, on dong this the functions were 
returning instantly and the lambdas were not satisfied. I suspect, the duration 
in operation_timeout() in table.cc is not large enough and the call to get() 
doesn't wait long enough.. To test this, I turned on the glog logging, and due 
to the time taken for file i/o, the lambdas had some time to execute, but it 
was still not big enough. So before inserting the lambdas, I'm calling 
folly::Future::wait() and this ensures that the lambdas are executed. But, I'm 
still skeptical whether this is the correct thing to do as we are waiting for 
some 'x' amount of time in ms before the callbacks are executed. Need your 
further guidance on that part.
* RawAsyncTable::Get() for multi requests now returns a 
Future>.
* action2promises_ in async-batch-rpc-retrying-caller.cc creates promises 
during construction and when AsyncBatchRpcRetryingCaller::Call() returns, we 
return those promises as a vector of futures.
* There was a regression in last couple of patches where ActionsByServer was 
changed to std::map from std::unordered_map. Have fixed that as well in this 
patch.

Thanks

> [C++] Implement request retry mechanism over RPC for Multi calls.
> -
>
> Key: HBASE-17576
> URL: https://issues.apache.org/jira/browse/HBASE-17576
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17576.HBASE-14850.v10.patch, 
> HBASE-17576.HBASE-14850.v11.patch, HBASE-17576.HBASE-14850.v1.patch, 
> HBASE-17576.HBASE-14850.v2.patch, HBASE-17576.HBASE-14850.v3.patch, 
> HBASE-17576.HBASE-14850.v4.patch, HBASE-17576.HBASE-14850.v5.patch, 
> HBASE-17576.HBASE-14850.v6.patch, HBASE-17576.HBASE-14850.v7.patch, 
> HBASE-17576.HBASE-14850.v8.patch, HBASE-17576.HBASE-14850.v9.patch
>
>
> This work is based on top of HBASE-17465. Multi Calls will be based on this.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Comment Edited] (HBASE-17576) [C++] Implement request retry mechanism over RPC for Multi calls.

[Sudeep Sunthankar (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15994540#comment-15994540
 ] 

Sudeep Sunthankar edited comment on HBASE-17576 at 5/3/17 9:41 AM:
---

V10 patch for Multi Requests.
Hi [~enis], Addressed below points

# {quote}You should use CHECK macros from glog like this: {quote}
# {quote}Remove these commented out code{quote}
# {quote}Simple client does not write test2 and testextra columns, why are you 
adding them to the list of gets: {quote}
-- I added them as I couldn't run the unit tests on mini cluster. Have removed 
for now.
# {quote}Result->DebugString() already prints out the Cell information, no? Why 
are you doing extra logging inside this if{quote}
-- Same as above
# {quote}No need for checking the exception type in table.cc: {quote}
-- Removed, throwing std::runtime_error.
# {quote}std::vector is already an instance of 
std::vector, no? You should not need to copy the 
vector.{quote}
-- We can't directly pass a vector of Gets, to a function accepting vector of 
Row, as it results in a build error. I have changed it to pass the begin() and 
end() iterators instead of copying the Gets to a new Row vector.

There are some TODO's which will be addressed in the next patch as they have to 
be based on HBASE-17800 in them, while some require a review. Please let me 
know your feedback on the latter ones.

--
Thanks


was (Author: sudeeps):
V10 patch for Multi Requests.
Hi [~enis], Addressed below points

# {quote}You should use CHECK macros from glog like this: {quote}
# {quote}Remove these commented out code{quote}
# {quote}Simple client does not write test2 and testextra columns, why are you 
adding them to the list of gets: {quote}
-- I added them as I couldn't run the unit tests on mini cluster. Have removed 
for now.
# {quote}Result->DebugString() already prints out the Cell information, no? Why 
are you doing extra logging inside this if{quote}
-- Same as above
# {quote}No need for checking the exception type in table.cc: {quote}
-- Removed, throwing std::runtime_error.
# {quote}std::vector is already an instance of 
std::vector, no? You should not need to copy the 
vector.{quote}
-- We can't directly pass a vector of Gets, to a function accepting vector of 
Row, as it results in a build error. I have changed it to pass the begin() and 
end() iterators instead of copying the Gets to a new Row vector.

--
Thanks

> [C++] Implement request retry mechanism over RPC for Multi calls.
> -
>
> Key: HBASE-17576
> URL: https://issues.apache.org/jira/browse/HBASE-17576
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17576.HBASE-14850.v10.patch, 
> HBASE-17576.HBASE-14850.v1.patch, HBASE-17576.HBASE-14850.v2.patch, 
> HBASE-17576.HBASE-14850.v3.patch, HBASE-17576.HBASE-14850.v4.patch, 
> HBASE-17576.HBASE-14850.v5.patch, HBASE-17576.HBASE-14850.v6.patch, 
> HBASE-17576.HBASE-14850.v7.patch, HBASE-17576.HBASE-14850.v8.patch, 
> HBASE-17576.HBASE-14850.v9.patch
>
>
> This work is based on top of HBASE-17465. Multi Calls will be based on this.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Comment Edited] (HBASE-17576) [C++] Implement request retry mechanism over RPC for Multi calls.

[Sudeep Sunthankar (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15994540#comment-15994540
 ] 

Sudeep Sunthankar edited comment on HBASE-17576 at 5/3/17 9:36 AM:
---

V10 patch for Multi Requests.
Hi [~enis], Addressed below points

# {quote}You should use CHECK macros from glog like this: {quote}
# {quote}Remove these commented out code{quote}
# {quote}Simple client does not write test2 and testextra columns, why are you 
adding them to the list of gets: {quote}
-- I added them as I couldn't run the unit tests on mini cluster. Have removed 
for now.
# {quote}Result->DebugString() already prints out the Cell information, no? Why 
are you doing extra logging inside this if{quote}
-- Same as above
# {quote}No need for checking the exception type in table.cc: {quote}
-- Removed, throwing std::runtime_error.
# {quote}std::vector is already an instance of 
std::vector, no? You should not need to copy the 
vector.{quote}
-- We can't directly pass a vector of Gets, to a function accepting vector of 
Row, as it results in a build error. I have changed it to pass the begin() and 
end() iterators instead of copying the Gets to a new Row vector.

--
Thanks


was (Author: sudeeps):
V10 patch for Multi Requests

> [C++] Implement request retry mechanism over RPC for Multi calls.
> -
>
> Key: HBASE-17576
> URL: https://issues.apache.org/jira/browse/HBASE-17576
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17576.HBASE-14850.v10.patch, 
> HBASE-17576.HBASE-14850.v1.patch, HBASE-17576.HBASE-14850.v2.patch, 
> HBASE-17576.HBASE-14850.v3.patch, HBASE-17576.HBASE-14850.v4.patch, 
> HBASE-17576.HBASE-14850.v5.patch, HBASE-17576.HBASE-14850.v6.patch, 
> HBASE-17576.HBASE-14850.v7.patch, HBASE-17576.HBASE-14850.v8.patch, 
> HBASE-17576.HBASE-14850.v9.patch
>
>
> This work is based on top of HBASE-17465. Multi Calls will be based on this.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (HBASE-17576) [C++] Implement request retry mechanism over RPC for Multi calls.

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-17576:
--
Attachment: HBASE-17576.HBASE-14850.v10.patch

V10 patch for Multi Requests

> [C++] Implement request retry mechanism over RPC for Multi calls.
> -
>
> Key: HBASE-17576
> URL: https://issues.apache.org/jira/browse/HBASE-17576
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17576.HBASE-14850.v10.patch, 
> HBASE-17576.HBASE-14850.v1.patch, HBASE-17576.HBASE-14850.v2.patch, 
> HBASE-17576.HBASE-14850.v3.patch, HBASE-17576.HBASE-14850.v4.patch, 
> HBASE-17576.HBASE-14850.v5.patch, HBASE-17576.HBASE-14850.v6.patch, 
> HBASE-17576.HBASE-14850.v7.patch, HBASE-17576.HBASE-14850.v8.patch, 
> HBASE-17576.HBASE-14850.v9.patch
>
>
> This work is based on top of HBASE-17465. Multi Calls will be based on this.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HBASE-17576) [C++] Implement request retry mechanism over RPC for Multi calls.

[Sudeep Sunthankar (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15986736#comment-15986736
 ] 

Sudeep Sunthankar commented on HBASE-17576:
---

Hi [~enis],
Based on the feedback I have uploaded a V9 patch. It doesn't have the changes 
for read/write locks, and copying of the gets vector, I'm working on it and 
will address it in an upcoming patch. Also could you please verify if the 
unit-tests are running fine, because the mini-cluster gives me an error and 
doesn't start in my docker env.

Thanks

> [C++] Implement request retry mechanism over RPC for Multi calls.
> -
>
> Key: HBASE-17576
> URL: https://issues.apache.org/jira/browse/HBASE-17576
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17576.HBASE-14850.v1.patch, 
> HBASE-17576.HBASE-14850.v2.patch, HBASE-17576.HBASE-14850.v3.patch, 
> HBASE-17576.HBASE-14850.v4.patch, HBASE-17576.HBASE-14850.v5.patch, 
> HBASE-17576.HBASE-14850.v6.patch, HBASE-17576.HBASE-14850.v7.patch, 
> HBASE-17576.HBASE-14850.v8.patch, HBASE-17576.HBASE-14850.v9.patch
>
>
> This work is based on top of HBASE-17465. Multi Calls will be based on this.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (HBASE-17576) [C++] Implement request retry mechanism over RPC for Multi calls.

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-17576:
--
Attachment: HBASE-17576.HBASE-14850.v9.patch

V9 patch addresses the below:-
# Added statndalone HBase Gets() call to simple-client.cc
# Methods for Gets() in raw-async-table.* return a Future
# Added Gets() unit-tests for mini-cluster in client-test.cc
# Sources hooked in core/BUCK

Thanks

> [C++] Implement request retry mechanism over RPC for Multi calls.
> -
>
> Key: HBASE-17576
> URL: https://issues.apache.org/jira/browse/HBASE-17576
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17576.HBASE-14850.v1.patch, 
> HBASE-17576.HBASE-14850.v2.patch, HBASE-17576.HBASE-14850.v3.patch, 
> HBASE-17576.HBASE-14850.v4.patch, HBASE-17576.HBASE-14850.v5.patch, 
> HBASE-17576.HBASE-14850.v6.patch, HBASE-17576.HBASE-14850.v7.patch, 
> HBASE-17576.HBASE-14850.v8.patch, HBASE-17576.HBASE-14850.v9.patch
>
>
> This work is based on top of HBASE-17465. Multi Calls will be based on this.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HBASE-17576) [C++] Implement request retry mechanism over RPC for Multi calls.

[Sudeep Sunthankar (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15962530#comment-15962530
 ] 

Sudeep Sunthankar commented on HBASE-17576:
---

Hi [~enis]

We require {code} std::mutex action2errors_lock_;{code} for synchornizing the 
action2erros_ DS. This is similar to the handling done at Java API.

{quote}
you can change the all rpc end-to-end be based on shared_ptr rather 
than unique_ptr
{quote}
I believe we should take this approach instead of adding it to Response object.

Thanks

> [C++] Implement request retry mechanism over RPC for Multi calls.
> -
>
> Key: HBASE-17576
> URL: https://issues.apache.org/jira/browse/HBASE-17576
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17576.HBASE-14850.v1.patch, 
> HBASE-17576.HBASE-14850.v2.patch, HBASE-17576.HBASE-14850.v3.patch, 
> HBASE-17576.HBASE-14850.v4.patch, HBASE-17576.HBASE-14850.v5.patch, 
> HBASE-17576.HBASE-14850.v6.patch, HBASE-17576.HBASE-14850.v7.patch, 
> HBASE-17576.HBASE-14850.v8.patch
>
>
> This work is based on top of HBASE-17465. Multi Calls will be based on this.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (HBASE-17576) [C++] Implement request retry mechanism over RPC for Multi calls.

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-17576:
--
Attachment: HBASE-17576.HBASE-14850.v8.patch

This patch addresses the below points:-
1) Changed ActionsByServer to unirdered_map with hash and equals implementation
2) Changed raw-async-table Batch() call to the way Get() and Put() is being 
called
3) Added read/write locks

Thanks

> [C++] Implement request retry mechanism over RPC for Multi calls.
> -
>
> Key: HBASE-17576
> URL: https://issues.apache.org/jira/browse/HBASE-17576
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17576.HBASE-14850.v1.patch, 
> HBASE-17576.HBASE-14850.v2.patch, HBASE-17576.HBASE-14850.v3.patch, 
> HBASE-17576.HBASE-14850.v4.patch, HBASE-17576.HBASE-14850.v5.patch, 
> HBASE-17576.HBASE-14850.v6.patch, HBASE-17576.HBASE-14850.v7.patch, 
> HBASE-17576.HBASE-14850.v8.patch
>
>
> This work is based on top of HBASE-17465. Multi Calls will be based on this.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (HBASE-17771) [C++] Classes required for implementation of BatchCallerBuilder

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-17771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-17771:
--
Status: Patch Available  (was: Reopened)

> [C++] Classes required for implementation of BatchCallerBuilder
> ---
>
> Key: HBASE-17771
> URL: https://issues.apache.org/jira/browse/HBASE-17771
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Fix For: HBASE-14850
>
> Attachments: HBASE-17771.HBASE-14850.v1.patch, 
> HBASE-17771.HBASE-14850.v2.patch, HBASE-17771.HBASE-14850.v3.patch, 
> HBASE-17771.HBASE-14850.v4.patch, HBASE-17771.HBASE-14850.v5.patch, 
> HBASE-17771.HBASE-14850.v6.patch
>
>
> Separating depedencies of BatchCallerBuilder.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (HBASE-17771) [C++] Classes required for implementation of BatchCallerBuilder

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-17771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-17771:
--
Attachment: HBASE-17771.HBASE-14850.v6.patch

Rebased patch

> [C++] Classes required for implementation of BatchCallerBuilder
> ---
>
> Key: HBASE-17771
> URL: https://issues.apache.org/jira/browse/HBASE-17771
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Fix For: HBASE-14850
>
> Attachments: HBASE-17771.HBASE-14850.v1.patch, 
> HBASE-17771.HBASE-14850.v2.patch, HBASE-17771.HBASE-14850.v3.patch, 
> HBASE-17771.HBASE-14850.v4.patch, HBASE-17771.HBASE-14850.v5.patch, 
> HBASE-17771.HBASE-14850.v6.patch
>
>
> Separating depedencies of BatchCallerBuilder.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HBASE-17771) [C++] Classes required for implementation of BatchCallerBuilder

[Sudeep Sunthankar (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-17771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15946314#comment-15946314
 ] 

Sudeep Sunthankar commented on HBASE-17771:
---

Hi Enis,

Lets commit this. Let me implement read and write locks at the 
AsyncBatchRpcRetryingCaller level. Also we would have the Row class in the repo 
which is required by HBASE-15894

Thanks.

> [C++] Classes required for implementation of BatchCallerBuilder
> ---
>
> Key: HBASE-17771
> URL: https://issues.apache.org/jira/browse/HBASE-17771
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Fix For: HBASE-14850
>
> Attachments: HBASE-17771.HBASE-14850.v1.patch, 
> HBASE-17771.HBASE-14850.v2.patch, HBASE-17771.HBASE-14850.v3.patch, 
> HBASE-17771.HBASE-14850.v4.patch, HBASE-17771.HBASE-14850.v5.patch
>
>
> Separating depedencies of BatchCallerBuilder.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (HBASE-17771) [C++] Classes required for implementation of BatchCallerBuilder

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-17771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-17771:
--
Attachment: HBASE-17771.HBASE-14850.v5.patch

V5 patch with the foll changes:-
# removed the mutexes. Will be implemented at AsyncRpcBatchRetryingCaller level.
# Changed the INFO log to VLOG(3)
# Sources and headers hooked up in BUCK.

Thanks

> [C++] Classes required for implementation of BatchCallerBuilder
> ---
>
> Key: HBASE-17771
> URL: https://issues.apache.org/jira/browse/HBASE-17771
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Fix For: HBASE-14850
>
> Attachments: HBASE-17771.HBASE-14850.v1.patch, 
> HBASE-17771.HBASE-14850.v2.patch, HBASE-17771.HBASE-14850.v3.patch, 
> HBASE-17771.HBASE-14850.v4.patch, HBASE-17771.HBASE-14850.v5.patch
>
>
> Separating depedencies of BatchCallerBuilder.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (HBASE-17576) [C++] Implement request retry mechanism over RPC for Multi calls.

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-17576:
--
Attachment: HBASE-17576.HBASE-14850.v7.patch

This patch does the foll:-
# Hooks the BatchCaller to RawAsyncTable. 
# Templatization removed and moved to AsyncConnection
# Moved AsyncBatchRpcRetryingCaller src and header
# Removed unnecessary looping in Send() method
# Added unit-test. which runs on a standalone HBase instance and depends on 
HBASE-17830

Thanks

> [C++] Implement request retry mechanism over RPC for Multi calls.
> -
>
> Key: HBASE-17576
> URL: https://issues.apache.org/jira/browse/HBASE-17576
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17576.HBASE-14850.v1.patch, 
> HBASE-17576.HBASE-14850.v2.patch, HBASE-17576.HBASE-14850.v3.patch, 
> HBASE-17576.HBASE-14850.v4.patch, HBASE-17576.HBASE-14850.v5.patch, 
> HBASE-17576.HBASE-14850.v6.patch, HBASE-17576.HBASE-14850.v7.patch
>
>
> This work is based on top of HBASE-17465. Multi Calls will be based on this.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (HBASE-17771) [C++] Classes required for implementation of BatchCallerBuilder

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-17771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-17771:
--
Attachment: HBASE-17771.HBASE-14850.v4.patch

This patch consists of the foll:-
# Removes unnecessary test and debugging conditions, logging statements and 
comments. 
# Consistency in method naming
# Added mutexes in case of writes. For reads, we are not using mutexes as of 
now as all the methods are called by const objects. Further we are returning a 
const reference so no changes will happen this way.

Thanks.

> [C++] Classes required for implementation of BatchCallerBuilder
> ---
>
> Key: HBASE-17771
> URL: https://issues.apache.org/jira/browse/HBASE-17771
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Fix For: HBASE-14850
>
> Attachments: HBASE-17771.HBASE-14850.v1.patch, 
> HBASE-17771.HBASE-14850.v2.patch, HBASE-17771.HBASE-14850.v3.patch, 
> HBASE-17771.HBASE-14850.v4.patch
>
>
> Separating depedencies of BatchCallerBuilder.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (HBASE-17829) [C++] Update for simple_client

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-17829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-17829:
--
Attachment: HBASE-17829.HBASE-14850.v1.patch

Adding AsyncCall() to make RPC calls as simple-client binary was failing.

Thanks

> [C++] Update for simple_client
> --
>
> Key: HBASE-17829
> URL: https://issues.apache.org/jira/browse/HBASE-17829
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17829.HBASE-14850.v1.patch
>
>
> simple_client binary is failing. This patch has a fix for this.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (HBASE-17830) [C++] Test Util support for standlone HBase instance

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-17830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-17830:
--
Attachment: HBASE-17830.HBASE-14850.v1.patch

This patch adds methods to run a standalone HBase instance.
Thanks.

> [C++] Test Util support for standlone HBase instance
> 
>
> Key: HBASE-17830
> URL: https://issues.apache.org/jira/browse/HBASE-17830
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17830.HBASE-14850.v1.patch
>
>
> Running standalone instance was removed from TestUtil after introduction of 
> mini cluster. We are re-introducing methods to run a standalone instance if 
> reqd.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (HBASE-17829) [C++] Update for simple_client

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-17829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar reassigned HBASE-17829:
-

Assignee: Sudeep Sunthankar

> [C++] Update for simple_client
> --
>
> Key: HBASE-17829
> URL: https://issues.apache.org/jira/browse/HBASE-17829
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
>
> simple_client binary is failing. This patch has a fix for this.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (HBASE-17830) [C++] Test Util support for standlone HBase instance

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-17830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar reassigned HBASE-17830:
-

Assignee: Sudeep Sunthankar

> [C++] Test Util support for standlone HBase instance
> 
>
> Key: HBASE-17830
> URL: https://issues.apache.org/jira/browse/HBASE-17830
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
>
> Running standalone instance was removed from TestUtil after introduction of 
> mini cluster. We are re-introducing methods to run a standalone instance if 
> reqd.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (HBASE-17830) [C++] Test Util support for standlone HBase instance

[Sudeep Sunthankar (JIRA)]

Sudeep Sunthankar created HBASE-17830:
-

 Summary: [C++] Test Util support for standlone HBase instance
 Key: HBASE-17830
 URL: https://issues.apache.org/jira/browse/HBASE-17830
 Project: HBase
  Issue Type: Sub-task
Reporter: Sudeep Sunthankar


Running standalone instance was removed from TestUtil after introduction of 
mini cluster. We are re-introducing methods to run a standalone instance if 
reqd.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (HBASE-17829) [C++] Update for simple_client

[Sudeep Sunthankar (JIRA)]

Sudeep Sunthankar created HBASE-17829:
-

 Summary: [C++] Update for simple_client
 Key: HBASE-17829
 URL: https://issues.apache.org/jira/browse/HBASE-17829
 Project: HBase
  Issue Type: Sub-task
Reporter: Sudeep Sunthankar


simple_client binary is failing. This patch has a fix for this.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (HBASE-17771) [C++] Classes required for implementation of BatchCallerBuilder

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-17771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-17771:
--
Attachment: HBASE-17771.HBASE-14850.v2.patch

Have addressed the feedback in the last patch

Thanks

> [C++] Classes required for implementation of BatchCallerBuilder
> ---
>
> Key: HBASE-17771
> URL: https://issues.apache.org/jira/browse/HBASE-17771
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Fix For: HBASE-14850
>
> Attachments: HBASE-17771.HBASE-14850.v1.patch, 
> HBASE-17771.HBASE-14850.v2.patch
>
>
> Separating depedencies of BatchCallerBuilder.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (HBASE-17576) [C++] Implement request retry mechanism over RPC for Multi calls.

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-17576:
--
Attachment: HBASE-17576.HBASE-14850.v6.patch

v6 patch consisting of only AsyncBatchRpcRetryingCaller class 

> [C++] Implement request retry mechanism over RPC for Multi calls.
> -
>
> Key: HBASE-17576
> URL: https://issues.apache.org/jira/browse/HBASE-17576
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17576.HBASE-14850.v1.patch, 
> HBASE-17576.HBASE-14850.v2.patch, HBASE-17576.HBASE-14850.v3.patch, 
> HBASE-17576.HBASE-14850.v4.patch, HBASE-17576.HBASE-14850.v5.patch, 
> HBASE-17576.HBASE-14850.v6.patch
>
>
> This work is based on top of HBASE-17465. Multi Calls will be based on this.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (HBASE-17768) [C++] Makefile should recompile only the changed sources

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-17768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-17768:
--
Attachment: HBASE-17768.HBASE-14850.v2.patch

# Removing the script dependency to create PB srcs
# Updated help in Makefile and Makefile.protos

Thanks

> [C++] Makefile should recompile only the changed sources
> 
>
> Key: HBASE-17768
> URL: https://issues.apache.org/jira/browse/HBASE-17768
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17768.HBASE-14850.v1.patch, 
> HBASE-17768.HBASE-14850.v2.patch
>
>
> Current Makefile builds everything including PB sources  everytime. This 
> patch addresses the issue



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (HBASE-17771) [C++] Classes required for implementation of BatchCallerBuilder

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-17771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-17771:
--
Attachment: HBASE-17771.HBASE-14850.v1.patch

This patch consists of classes required for BatchCallerBuilder. 

Thanks

> [C++] Classes required for implementation of BatchCallerBuilder
> ---
>
> Key: HBASE-17771
> URL: https://issues.apache.org/jira/browse/HBASE-17771
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17771.HBASE-14850.v1.patch
>
>
> Separating depedencies of BatchCallerBuilder.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Issue Comment Deleted] (HBASE-17576) [C++] Implement request retry mechanism over RPC for Multi calls.

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-17576:
--
Comment: was deleted

(was: This patch consists of classes required for BatchCallerBuilder)

> [C++] Implement request retry mechanism over RPC for Multi calls.
> -
>
> Key: HBASE-17576
> URL: https://issues.apache.org/jira/browse/HBASE-17576
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17576.HBASE-14850.v1.patch, 
> HBASE-17576.HBASE-14850.v2.patch, HBASE-17576.HBASE-14850.v3.patch, 
> HBASE-17576.HBASE-14850.v4.patch, HBASE-17576.HBASE-14850.v5.patch
>
>
> This work is based on top of HBASE-17465. Multi Calls will be based on this.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (HBASE-17771) [C++] Classes required for implementation of BatchCallerBuilder

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-17771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar reassigned HBASE-17771:
-

Assignee: Sudeep Sunthankar

> [C++] Classes required for implementation of BatchCallerBuilder
> ---
>
> Key: HBASE-17771
> URL: https://issues.apache.org/jira/browse/HBASE-17771
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
>
> Separating depedencies of BatchCallerBuilder.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (HBASE-17576) [C++] Implement request retry mechanism over RPC for Multi calls.

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-17576:
--
Attachment: (was: HBASE-17576.HBASE-14850.v6.patch)

> [C++] Implement request retry mechanism over RPC for Multi calls.
> -
>
> Key: HBASE-17576
> URL: https://issues.apache.org/jira/browse/HBASE-17576
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17576.HBASE-14850.v1.patch, 
> HBASE-17576.HBASE-14850.v2.patch, HBASE-17576.HBASE-14850.v3.patch, 
> HBASE-17576.HBASE-14850.v4.patch, HBASE-17576.HBASE-14850.v5.patch
>
>
> This work is based on top of HBASE-17465. Multi Calls will be based on this.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (HBASE-17771) [C++] Classes required for implementation of BatchCallerBuilder

[Sudeep Sunthankar (JIRA)]

Sudeep Sunthankar created HBASE-17771:
-

 Summary: [C++] Classes required for implementation of 
BatchCallerBuilder
 Key: HBASE-17771
 URL: https://issues.apache.org/jira/browse/HBASE-17771
 Project: HBase
  Issue Type: Sub-task
Reporter: Sudeep Sunthankar


Separating depedencies of BatchCallerBuilder.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (HBASE-17768) [C++] Makefile should recompile only the changed sources

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-17768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-17768:
--
Summary: [C++] Makefile should recompile only the changed sources  (was: 
Makefile should recompile only the changed sources)

> [C++] Makefile should recompile only the changed sources
> 
>
> Key: HBASE-17768
> URL: https://issues.apache.org/jira/browse/HBASE-17768
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17768.HBASE-14850.v1.patch
>
>
> Current Makefile builds everything including PB sources  everytime. This 
> patch addresses the issue



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (HBASE-17576) [C++] Implement request retry mechanism over RPC for Multi calls.

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-17576:
--
Attachment: HBASE-17576.HBASE-14850.v6.patch

This patch consists of classes required for BatchCallerBuilder

> [C++] Implement request retry mechanism over RPC for Multi calls.
> -
>
> Key: HBASE-17576
> URL: https://issues.apache.org/jira/browse/HBASE-17576
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17576.HBASE-14850.v1.patch, 
> HBASE-17576.HBASE-14850.v2.patch, HBASE-17576.HBASE-14850.v3.patch, 
> HBASE-17576.HBASE-14850.v4.patch, HBASE-17576.HBASE-14850.v5.patch, 
> HBASE-17576.HBASE-14850.v6.patch
>
>
> This work is based on top of HBASE-17465. Multi Calls will be based on this.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (HBASE-17768) Makefile should recompile only the changed sources

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-17768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-17768:
--
Attachment: HBASE-17768.HBASE-14850.v1.patch

This patch fixes the problem with Makefile and Makefile.protos and 
recompilation takes place only for changed files

> Makefile should recompile only the changed sources
> --
>
> Key: HBASE-17768
> URL: https://issues.apache.org/jira/browse/HBASE-17768
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17768.HBASE-14850.v1.patch
>
>
> Current Makefile builds everything including PB sources  everytime. This 
> patch addresses the issue



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (HBASE-17768) Makefile should recompile only the changed sources

[Sudeep Sunthankar (JIRA)]

Sudeep Sunthankar created HBASE-17768:
-

 Summary: Makefile should recompile only the changed sources
 Key: HBASE-17768
 URL: https://issues.apache.org/jira/browse/HBASE-17768
 Project: HBase
  Issue Type: Sub-task
Reporter: Sudeep Sunthankar
Assignee: Sudeep Sunthankar


Current Makefile builds everything including PB sources  everytime. This patch 
addresses the issue



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (HBASE-17576) [C++] Implement request retry mechanism over RPC for Multi calls.

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-17576:
--
Attachment: HBASE-17576.HBASE-14850.v5.patch

# v5 patch. which has callbacks added in GroupAndSend, Send.
# Population of Results in vector of Futures.

> [C++] Implement request retry mechanism over RPC for Multi calls.
> -
>
> Key: HBASE-17576
> URL: https://issues.apache.org/jira/browse/HBASE-17576
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17576.HBASE-14850.v1.patch, 
> HBASE-17576.HBASE-14850.v2.patch, HBASE-17576.HBASE-14850.v3.patch, 
> HBASE-17576.HBASE-14850.v4.patch, HBASE-17576.HBASE-14850.v5.patch
>
>
> This work is based on top of HBASE-17465. Multi Calls will be based on this.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Comment Edited] (HBASE-17576) [C++] Implement request retry mechanism over RPC for Multi calls.

[Sudeep Sunthankar (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878707#comment-15878707
 ] 

Sudeep Sunthankar edited comment on HBASE-17576 at 2/22/17 4:54 PM:


This patch consists of the foll changes:-
1) Row interface has a method to return the row; Get class inherits Row 
2) HRegionLocation changed to RegionLocation
3) Removed AbstractResponse and moved ResponseType enum to MultiResponse class
4) ActionsByRegion map changed from Map(hash_code(region_name))=Action to 
Map(region_nam)=Action
5) GroupAndSend() logic updated


was (Author: sudeeps):
This patch consists of the foll changes:-
1) Row interface has a method to return the row; Get class inherits Row 
2) HRegionLocation changed to RegionLocation
3) Removed AbstractResponse and moved ResponseType enum to MultiResponse class
4) ActionsByRegion map changed from hash_code(region_name)->Action to 
region_name->Action
5) GroupAndSend() logic updated

> [C++] Implement request retry mechanism over RPC for Multi calls.
> -
>
> Key: HBASE-17576
> URL: https://issues.apache.org/jira/browse/HBASE-17576
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17576.HBASE-14850.v1.patch, 
> HBASE-17576.HBASE-14850.v2.patch, HBASE-17576.HBASE-14850.v3.patch, 
> HBASE-17576.HBASE-14850.v4.patch
>
>
> This work is based on top of HBASE-17465. Multi Calls will be based on this.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (HBASE-17576) [C++] Implement request retry mechanism over RPC for Multi calls.

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-17576:
--
Attachment: HBASE-17576.HBASE-14850.v4.patch

This patch consists of the foll changes:-
1) Row interface has a method to return the row; Get class inherits Row 
2) HRegionLocation changed to RegionLocation
3) Removed AbstractResponse and moved ResponseType enum to MultiResponse class
4) ActionsByRegion map changed from hash_code(region_name)->Action to 
region_name->Action
5) GroupAndSend() logic updated

> [C++] Implement request retry mechanism over RPC for Multi calls.
> -
>
> Key: HBASE-17576
> URL: https://issues.apache.org/jira/browse/HBASE-17576
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17576.HBASE-14850.v1.patch, 
> HBASE-17576.HBASE-14850.v2.patch, HBASE-17576.HBASE-14850.v3.patch, 
> HBASE-17576.HBASE-14850.v4.patch
>
>
> This work is based on top of HBASE-17465. Multi Calls will be based on this.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (HBASE-17576) [C++] Implement request retry mechanism over RPC for Multi calls.

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-17576:
--
Attachment: HBASE-17576.HBASE-14850.v3.patch

V3 patch which adds more functionality. Subsequent patches will focus more on 
error handling and getting the response from Future.

> [C++] Implement request retry mechanism over RPC for Multi calls.
> -
>
> Key: HBASE-17576
> URL: https://issues.apache.org/jira/browse/HBASE-17576
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17576.HBASE-14850.v1.patch, 
> HBASE-17576.HBASE-14850.v2.patch, HBASE-17576.HBASE-14850.v3.patch
>
>
> This work is based on top of HBASE-17465. Multi Calls will be based on this.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (HBASE-17576) [C++] Implement request retry mechanism over RPC for Multi calls.

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-17576:
--
Attachment: HBASE-17576.HBASE-14850.v2.patch

V2 patch, which is taking shape on similar lines as Java API. Please comment if 
anything looks wrong.

Thanks

> [C++] Implement request retry mechanism over RPC for Multi calls.
> -
>
> Key: HBASE-17576
> URL: https://issues.apache.org/jira/browse/HBASE-17576
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17576.HBASE-14850.v1.patch, 
> HBASE-17576.HBASE-14850.v2.patch
>
>
> This work is based on top of HBASE-17465. Multi Calls will be based on this.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HBASE-17278) [C++] Cell Scanner Implementation to be used by ResultScanner

[Sudeep Sunthankar (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-17278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15851615#comment-15851615
 ] 

Sudeep Sunthankar commented on HBASE-17278:
---

Hi [~enis], I tested the patch. The patch looks fine except for the below 
changes which were resulting in compilation and linking errors. 
# {code}
KeyValueCodec() changed to public from private in keyvalue-codec.h
{code}
# Changed below declarations to pure virtual in codec.h
{code}
  virtual std::unique_ptr CreateEncoder(std::shared_ptr 
cell_block);
  virtual std::unique_ptr CreateDecoder(std::shared_ptr 
cell_block,
 uint32_t 
cell_block_start_offset,
 uint32_t cell_block_length);
{code}

Thanks

> [C++] Cell Scanner Implementation to be used by ResultScanner
> -
>
> Key: HBASE-17278
> URL: https://issues.apache.org/jira/browse/HBASE-17278
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17278.HBASE-14850.v1.patch, 
> HBASE-17278.HBASE-14850.v2.patch, HBASE-17278.HBASE-14850.v3.patch, 
> HBASE-17278.HBASE-14850.v4.patch, hbase-17278_v5.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (HBASE-17576) [C++] Implement request retry mechanism over RPC for Multi calls.

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-17576:
--
Attachment: HBASE-17576.HBASE-14850.v1.patch

V1 patch for Multi Calls. We will be adding retries and error handling in 
coming patches.

> [C++] Implement request retry mechanism over RPC for Multi calls.
> -
>
> Key: HBASE-17576
> URL: https://issues.apache.org/jira/browse/HBASE-17576
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17576.HBASE-14850.v1.patch
>
>
> This work is based on top of HBASE-17465. Multi Calls will be based on this.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (HBASE-17576) [C++] Implement request retry mechanism over RPC for Multi calls.

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-17576:
--
Summary: [C++] Implement request retry mechanism over RPC for Multi calls.  
(was: Implement request retry mechanism over RPC for Multi calls.)

> [C++] Implement request retry mechanism over RPC for Multi calls.
> -
>
> Key: HBASE-17576
> URL: https://issues.apache.org/jira/browse/HBASE-17576
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
>
> This work is based on top of HBASE-17465. Multi Calls will be based on this.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (HBASE-17576) Implement request retry mechanism over RPC for Multi calls.

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar reassigned HBASE-17576:
-

Assignee: Sudeep Sunthankar

> Implement request retry mechanism over RPC for Multi calls.
> ---
>
> Key: HBASE-17576
> URL: https://issues.apache.org/jira/browse/HBASE-17576
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
>
> This work is based on top of HBASE-17465. Multi Calls will be based on this.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (HBASE-17576) Implement request retry mechanism over RPC for Multi calls.

[Sudeep Sunthankar (JIRA)]

Sudeep Sunthankar created HBASE-17576:
-

 Summary: Implement request retry mechanism over RPC for Multi 
calls.
 Key: HBASE-17576
 URL: https://issues.apache.org/jira/browse/HBASE-17576
 Project: HBase
  Issue Type: Sub-task
Reporter: Sudeep Sunthankar


This work is based on top of HBASE-17465. Multi Calls will be based on this.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (HBASE-17278) [C++] Cell Scanner Implementation to be used by ResultScanner

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-17278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-17278:
--
Attachment: HBASE-17278.HBASE-14850.v4.patch

Re-submitting the patch after removing unnecessary source for CellScanner 
interface.

Thanks

> [C++] Cell Scanner Implementation to be used by ResultScanner
> -
>
> Key: HBASE-17278
> URL: https://issues.apache.org/jira/browse/HBASE-17278
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17278.HBASE-14850.v1.patch, 
> HBASE-17278.HBASE-14850.v2.patch, HBASE-17278.HBASE-14850.v3.patch, 
> HBASE-17278.HBASE-14850.v4.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-17278) [C++] Cell Scanner Implementation to be used by ResultScanner

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-17278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-17278:
--
Attachment: (was: HBASE-17278.HBASE-14850.v4.patch)

> [C++] Cell Scanner Implementation to be used by ResultScanner
> -
>
> Key: HBASE-17278
> URL: https://issues.apache.org/jira/browse/HBASE-17278
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17278.HBASE-14850.v1.patch, 
> HBASE-17278.HBASE-14850.v2.patch, HBASE-17278.HBASE-14850.v3.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-17278) [C++] Cell Scanner Implementation to be used by ResultScanner

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-17278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-17278:
--
Attachment: HBASE-17278.HBASE-14850.v4.patch

This patch addresses the points based on the last feedback.
1) Unnecessary methods removed from CellScanner.
2) Added Decoder() method to KeyValueCodec() which will enable decoding of cell 
block through base class methods of Advance() and Current()

Thanks

> [C++] Cell Scanner Implementation to be used by ResultScanner
> -
>
> Key: HBASE-17278
> URL: https://issues.apache.org/jira/browse/HBASE-17278
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17278.HBASE-14850.v1.patch, 
> HBASE-17278.HBASE-14850.v2.patch, HBASE-17278.HBASE-14850.v3.patch, 
> HBASE-17278.HBASE-14850.v4.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-17278) [C++] Cell Scanner Implementation to be used by ResultScanner

[Sudeep Sunthankar (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-17278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15831173#comment-15831173
 ] 

Sudeep Sunthankar commented on HBASE-17278:
---

Thanks for the feedback [~enis]. I referred to IOBUF tests in folly and read 
some documentation as well as tested by parsing cell_meta_block in response 
which as per your suggestion I obtained by setting the codec class to 
KeyValueCodec. 
Would also like to know your thoughts on methods such as Current(), 
CellBlockMetaLength() which are not overridden in the derived class. Should 
these also be defined as per the implementation ? 

> [C++] Cell Scanner Implementation to be used by ResultScanner
> -
>
> Key: HBASE-17278
> URL: https://issues.apache.org/jira/browse/HBASE-17278
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17278.HBASE-14850.v1.patch, 
> HBASE-17278.HBASE-14850.v2.patch, HBASE-17278.HBASE-14850.v3.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-17278) [C++] Cell Scanner Implementation to be used by ResultScanner

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-17278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-17278:
--
Attachment: HBASE-17278.HBASE-14850.v3.patch

Hi,
I have addressed the below points as per the feedback which were missing in the 
last patch.
# CellScanner is an Abstract class now.
# KeyValueCodec class implements the methods defined in CellScanner
# We are passing IOBUF instead of passing the extracted data from IOBUF
# Added documentation

Thanks.

> [C++] Cell Scanner Implementation to be used by ResultScanner
> -
>
> Key: HBASE-17278
> URL: https://issues.apache.org/jira/browse/HBASE-17278
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17278.HBASE-14850.v1.patch, 
> HBASE-17278.HBASE-14850.v2.patch, HBASE-17278.HBASE-14850.v3.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-17485) [C++] Zookeeper quorum and znode lookup made configurable

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-17485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-17485:
--
Attachment: HBASE-17485.HBASE-14850.v1.patch

This patch has changes consisting of passing Configuration instance to 
LocationCache. Using Configuration object we have made zookeeper quorum and 
zookeeper znode property configurable. 

> [C++] Zookeeper quorum and znode lookup made configurable
> -
>
> Key: HBASE-17485
> URL: https://issues.apache.org/jira/browse/HBASE-17485
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17485.HBASE-14850.v1.patch
>
>
> Lookup for Zookeeper Quorum and Zookeeper Znode should be done using 
> Configuration instance.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-17485) [C++] Zookeeper quorum and znode lookup made configurable

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-17485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-17485:
--
Status: Patch Available  (was: Open)

> [C++] Zookeeper quorum and znode lookup made configurable
> -
>
> Key: HBASE-17485
> URL: https://issues.apache.org/jira/browse/HBASE-17485
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17485.HBASE-14850.v1.patch
>
>
> Lookup for Zookeeper Quorum and Zookeeper Znode should be done using 
> Configuration instance.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (HBASE-17485) [C++] Zookeeper quorum and znode lookup made configurable

[Sudeep Sunthankar (JIRA)]

Sudeep Sunthankar created HBASE-17485:
-

 Summary: [C++] Zookeeper quorum and znode lookup made configurable
 Key: HBASE-17485
 URL: https://issues.apache.org/jira/browse/HBASE-17485
 Project: HBase
  Issue Type: Sub-task
Reporter: Sudeep Sunthankar


Lookup for Zookeeper Quorum and Zookeeper Znode should be done using 
Configuration instance.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (HBASE-17485) [C++] Zookeeper quorum and znode lookup made configurable

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-17485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar reassigned HBASE-17485:
-

Assignee: Sudeep Sunthankar

> [C++] Zookeeper quorum and znode lookup made configurable
> -
>
> Key: HBASE-17485
> URL: https://issues.apache.org/jira/browse/HBASE-17485
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
>
> Lookup for Zookeeper Quorum and Zookeeper Znode should be done using 
> Configuration instance.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-17481) [C++] Changing cpplint to ignore line wrapping warnings

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-17481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-17481:
--
Status: Patch Available  (was: Open)

> [C++] Changing cpplint to ignore line wrapping warnings
> ---
>
> Key: HBASE-17481
> URL: https://issues.apache.org/jira/browse/HBASE-17481
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17481.HBASE-14850.v1.patch
>
>
> We have changed the line wrapping to 100. cpplint should reflect the same to 
> avoid unnecessary warnings.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-17481) [C++] Changing cpplint to ignore line wrapping warnings

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-17481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-17481:
--
Attachment: HBASE-17481.HBASE-14850.v1.patch

Added option --linelength=100

> [C++] Changing cpplint to ignore line wrapping warnings
> ---
>
> Key: HBASE-17481
> URL: https://issues.apache.org/jira/browse/HBASE-17481
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17481.HBASE-14850.v1.patch
>
>
> We have changed the line wrapping to 100. cpplint should reflect the same to 
> avoid unnecessary warnings.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (HBASE-17481) [C++] Changing cpplint to ignore line wrapping warnings

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-17481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar reassigned HBASE-17481:
-

Assignee: Sudeep Sunthankar

> [C++] Changing cpplint to ignore line wrapping warnings
> ---
>
> Key: HBASE-17481
> URL: https://issues.apache.org/jira/browse/HBASE-17481
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
>
> We have changed the line wrapping to 100. cpplint should reflect the same to 
> avoid unnecessary warnings.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (HBASE-17481) [C++] Changing cpplint to ignore line wrapping warnings

[Sudeep Sunthankar (JIRA)]

Sudeep Sunthankar created HBASE-17481:
-

 Summary: [C++] Changing cpplint to ignore line wrapping warnings
 Key: HBASE-17481
 URL: https://issues.apache.org/jira/browse/HBASE-17481
 Project: HBase
  Issue Type: Sub-task
Reporter: Sudeep Sunthankar


We have changed the line wrapping to 100. cpplint should reflect the same to 
avoid unnecessary warnings.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-17278) [C++] Cell Scanner Implementation to be used by ResultScanner

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-17278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-17278:
--
Status: Patch Available  (was: In Progress)

> [C++] Cell Scanner Implementation to be used by ResultScanner
> -
>
> Key: HBASE-17278
> URL: https://issues.apache.org/jira/browse/HBASE-17278
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17278.HBASE-14850.v1.patch, 
> HBASE-17278.HBASE-14850.v2.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-17278) [C++] Cell Scanner Implementation to be used by ResultScanner

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-17278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-17278:
--
Attachment: HBASE-17278.HBASE-14850.v2.patch

In this patch we have the foll:-
1) Cell Scanner class which will iterate through sequence of cells obtained 
from cell_meta block
2) KeyValueCodec class where the actual logic of parsing is present

Thanks. 

> [C++] Cell Scanner Implementation to be used by ResultScanner
> -
>
> Key: HBASE-17278
> URL: https://issues.apache.org/jira/browse/HBASE-17278
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17278.HBASE-14850.v1.patch, 
> HBASE-17278.HBASE-14850.v2.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-17315) [C++] HBase Client and Table Implementation

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-17315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-17315:
--
Attachment: HBASE-17315.HBASE-14850.v6.patch

This patch is to be applied on HBASE-17451 as it is dependent on Request and 
Response converter classes.

Thanks

> [C++] HBase Client and Table Implementation
> ---
>
> Key: HBASE-17315
> URL: https://issues.apache.org/jira/browse/HBASE-17315
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17315.HBASE-14850.v1.patch, 
> HBASE-17315.HBASE-14850.v2.patch, HBASE-17315.HBASE-14850.v3.patch, 
> HBASE-17315.HBASE-14850.v4.patch, HBASE-17315.HBASE-14850.v5.patch, 
> HBASE-17315.HBASE-14850.v6.patch
>
>
> Consists of Client and Table implementation which will be used to call the 
> corresponding client methods i.e Get, Gets, Scan etc. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-17451) [C++] HBase Request and Response Converter

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-17451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-17451:
--
Attachment: HBASE-17451.HBASE-14850.v1.patch

First cut of RequestConverter and ResponseConverter class. 

> [C++] HBase Request and Response Converter
> --
>
> Key: HBASE-17451
> URL: https://issues.apache.org/jira/browse/HBASE-17451
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17451.HBASE-14850.v1.patch
>
>
> Conversion of HBase client side data structures to Protobuf messages and 
> vice-versa.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-17451) [C++] HBase Request and Response Converter

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-17451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-17451:
--
Status: Patch Available  (was: Open)

> [C++] HBase Request and Response Converter
> --
>
> Key: HBASE-17451
> URL: https://issues.apache.org/jira/browse/HBASE-17451
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17451.HBASE-14850.v1.patch
>
>
> Conversion of HBase client side data structures to Protobuf messages and 
> vice-versa.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (HBASE-17451) [C++] HBase Request and Response Converter

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-17451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar reassigned HBASE-17451:
-

Assignee: Sudeep Sunthankar

> [C++] HBase Request and Response Converter
> --
>
> Key: HBASE-17451
> URL: https://issues.apache.org/jira/browse/HBASE-17451
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
>
> Conversion of HBase client side data structures to Protobuf messages and 
> vice-versa.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (HBASE-17451) [C++] HBase Request and Response Converter

[Sudeep Sunthankar (JIRA)]

Sudeep Sunthankar created HBASE-17451:
-

 Summary: [C++] HBase Request and Response Converter
 Key: HBASE-17451
 URL: https://issues.apache.org/jira/browse/HBASE-17451
 Project: HBase
  Issue Type: Sub-task
Reporter: Sudeep Sunthankar


Conversion of HBase client side data structures to Protobuf messages and 
vice-versa.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-17315) [C++] HBase Client and Table Implementation

[Sudeep Sunthankar (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-17315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15813759#comment-15813759
 ] 

Sudeep Sunthankar commented on HBASE-17315:
---

Thanks [~enis]

{quote}
{code}
hbase::TestUtil *test_util = new hbase::TestUtil();
..
+  delete test_util;
{code}
{quote}
There was a feedback in one of the earlier issues, not to include smart 
pointers in test cases, hence I refrained from it.

{quote}
{code}
 // ASSERT_TRUE(table != nullptr) << "Unable to get connection to Table.";
{code}
{quote}
Since we moved, it from unique_ptr to return by value, I had commented out the 
part. 
I will be uncomment it in the next patch and also include changes for 
RequestConverter and ResponseConverter classes.

> [C++] HBase Client and Table Implementation
> ---
>
> Key: HBASE-17315
> URL: https://issues.apache.org/jira/browse/HBASE-17315
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17315.HBASE-14850.v1.patch, 
> HBASE-17315.HBASE-14850.v2.patch, HBASE-17315.HBASE-14850.v3.patch, 
> HBASE-17315.HBASE-14850.v4.patch, HBASE-17315.HBASE-14850.v5.patch
>
>
> Consists of Client and Table implementation which will be used to call the 
> corresponding client methods i.e Get, Gets, Scan etc. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-17315) [C++] HBase Client and Table Implementation

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-17315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-17315:
--
Status: Patch Available  (was: Open)

> [C++] HBase Client and Table Implementation
> ---
>
> Key: HBASE-17315
> URL: https://issues.apache.org/jira/browse/HBASE-17315
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17315.HBASE-14850.v1.patch, 
> HBASE-17315.HBASE-14850.v2.patch, HBASE-17315.HBASE-14850.v3.patch, 
> HBASE-17315.HBASE-14850.v4.patch, HBASE-17315.HBASE-14850.v5.patch
>
>
> Consists of Client and Table implementation which will be used to call the 
> corresponding client methods i.e Get, Gets, Scan etc. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-17315) [C++] HBase Client and Table Implementation

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-17315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-17315:
--
Attachment: HBASE-17315.HBASE-14850.v5.patch

This patch consists of below changes:-
# Removed extra parameter for zookeeper quorum and unneceesary commented code.
# Addressed issue to return Table and Result as values instead of pointers. 
# Fixed TimeRange allocattion in ProtobufRequestBuilder class.

Thanks

> [C++] HBase Client and Table Implementation
> ---
>
> Key: HBASE-17315
> URL: https://issues.apache.org/jira/browse/HBASE-17315
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17315.HBASE-14850.v1.patch, 
> HBASE-17315.HBASE-14850.v2.patch, HBASE-17315.HBASE-14850.v3.patch, 
> HBASE-17315.HBASE-14850.v4.patch, HBASE-17315.HBASE-14850.v5.patch
>
>
> Consists of Client and Table implementation which will be used to call the 
> corresponding client methods i.e Get, Gets, Scan etc. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-17315) [C++] HBase Client and Table Implementation

[Sudeep Sunthankar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-17315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sudeep Sunthankar updated HBASE-17315:
--
Status: Open  (was: Patch Available)

> [C++] HBase Client and Table Implementation
> ---
>
> Key: HBASE-17315
> URL: https://issues.apache.org/jira/browse/HBASE-17315
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17315.HBASE-14850.v1.patch, 
> HBASE-17315.HBASE-14850.v2.patch, HBASE-17315.HBASE-14850.v3.patch, 
> HBASE-17315.HBASE-14850.v4.patch
>
>
> Consists of Client and Table implementation which will be used to call the 
> corresponding client methods i.e Get, Gets, Scan etc. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)