[GitHub] [hbase] Apache9 commented on a diff in pull request #4305: HBASE-26907 Update Hadoop3 versions for JEP 223 compliance

2022-04-21 Thread GitBox 


Apache9 commented on code in PR #4305:
URL: https://github.com/apache/hbase/pull/4305#discussion_r855257735


##
pom.xml:
##
@@ -3032,7 +3033,8 @@
 
 --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED 
${hbase-surefire.argLine}
 
-3.2.0
+
+3.2.3

Review Comment:
   From my understanding in the past, the minimum version here is the minimum 
supported hadoop version. And for the quick hadoop check, it is usually the 
latest patch release for a minor release line.
   
   But seems what we have in pom is usually the minimum minor release line but 
the latest patch release of this minor release line... So there 3.2.3 should be 
OK.
   
   On the CVE problem, it is another story, it usually means we need to drop 
the support for some patch releases.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] Apache9 commented on a diff in pull request #4305: HBASE-26907 Update Hadoop3 versions for JEP 223 compliance

2022-04-16 Thread GitBox 


Apache9 commented on code in PR #4305:
URL: https://github.com/apache/hbase/pull/4305#discussion_r851623093


##
pom.xml:
##
@@ -3032,7 +3033,8 @@
 
 --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED 
${hbase-surefire.argLine}
 
-3.2.0
+
+3.2.3

Review Comment:
   Should be 3.2.2 instead of 3.2.3.



##
dev-support/hbase-personality.sh:
##
@@ -660,9 +660,9 @@ function hadoopcheck_rebuild
   else
 yetus_info "Setting Hadoop 3 versions to test based on 
branch-2.4+/master/feature branch rules"
 if [[ "${QUICK_HADOOPCHECK}" == "true" ]]; then
-  hbase_hadoop3_versions="3.1.2 3.2.2 3.3.1"
+  hbase_hadoop3_versions="3.1.4 3.2.3 3.3.1"

Review Comment:
   3.3.1 should be 3.3.2



##
dev-support/hbase-personality.sh:
##
@@ -660,9 +660,9 @@ function hadoopcheck_rebuild
   else
 yetus_info "Setting Hadoop 3 versions to test based on 
branch-2.4+/master/feature branch rules"
 if [[ "${QUICK_HADOOPCHECK}" == "true" ]]; then
-  hbase_hadoop3_versions="3.1.2 3.2.2 3.3.1"
+  hbase_hadoop3_versions="3.1.4 3.2.3 3.3.1"
 else
-  hbase_hadoop3_versions="3.1.1 3.1.2 3.2.0 3.2.1 3.2.2 3.3.0 3.3.1"
+  hbase_hadoop3_versions="3.1.4 3.2.2 3.2.3 3.3.0 3.3.1"

Review Comment:
   Should also add 3.3.2



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] Apache9 commented on a diff in pull request #4305: HBASE-26907 Update Hadoop3 versions for JEP 223 compliance

2022-04-04 Thread GitBox 


Apache9 commented on code in PR #4305:
URL: https://github.com/apache/hbase/pull/4305#discussion_r841687236


##
dev-support/hbase-personality.sh:
##
@@ -660,9 +660,9 @@ function hadoopcheck_rebuild
   else
 yetus_info "Setting Hadoop 3 versions to test based on 
branch-2.4+/master/feature branch rules"
 if [[ "${QUICK_HADOOPCHECK}" == "true" ]]; then
-  hbase_hadoop3_versions="3.1.2 3.2.2 3.3.1"
+  hbase_hadoop3_versions="3.1.4 3.2.2 3.3.2"

Review Comment:
   Should also change 3.2.2 to 3.2.3?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org